Config
Log for #openttd on 14th November 2017:
Times are UTC Toggle Colours
00:24:50  *** orudge` has quit IRC
00:25:11  *** orudge` has joined #openttd
00:25:11  *** ChanServ sets mode: +o orudge`
01:02:09  *** Gustavo6046 has quit IRC
01:03:09  *** bryjen has joined #openttd
01:35:08  *** sim-al2 has joined #openttd
02:14:35  *** bryjen has quit IRC
02:18:54  *** bryjen has joined #openttd
02:46:41  *** Thedarkb1 has joined #openttd
02:52:41  *** Thedarkb has quit IRC
03:13:42  *** Boggerm has joined #openttd
03:14:09  <Boggerm> Hello There.
03:22:40  *** sim-al2 is now known as Guest496
03:22:41  *** sim-al2 has joined #openttd
03:26:10  *** Guest496 has quit IRC
03:32:44  *** orudge` has quit IRC
03:32:53  *** glx has quit IRC
03:33:21  *** orudge` has joined #openttd
03:33:22  *** ChanServ sets mode: +o orudge`
03:45:12  *** Boggerm has quit IRC
03:45:36  *** orudge` has quit IRC
03:45:52  *** orudge` has joined #openttd
03:45:52  *** ChanServ sets mode: +o orudge`
03:54:07  *** samgunner has quit IRC
05:06:00  *** Cubey has quit IRC
05:56:42  *** sim-al2 has quit IRC
06:00:22  *** bryjen has quit IRC
06:05:28  *** sla_ro|master has joined #openttd
06:56:58  *** tokai|noir has joined #openttd
06:56:58  *** ChanServ sets mode: +v tokai|noir
07:03:56  *** tokai has quit IRC
07:12:59  *** sla_ro|master has quit IRC
07:23:29  *** Thanark has quit IRC
07:33:43  *** Laedek has joined #openttd
07:35:52  *** Breckett has joined #openttd
07:36:40  *** Laedek_ has quit IRC
07:39:03  *** Laedek_ has joined #openttd
07:42:15  *** Laedek has quit IRC
07:45:19  *** Breckett has quit IRC
08:29:54  *** Breckett has joined #openttd
09:18:40  *** Samu has joined #openttd
09:18:46  <Samu> hello
09:21:22  <Samu> "go to the nearest hangar" orders are causing "dest too far" problems for aircraft with range
09:21:33  <Samu> 1.7.1
09:23:55  *** Gja has joined #openttd
09:28:36  *** Samu has quit IRC
10:15:17  *** Samu has joined #openttd
10:21:08  *** DDR has quit IRC
10:43:50  <Samu> when insering a "service at near depot", it puts destination 0 :(
10:46:39  <Samu> why 0?
10:47:49  <Samu> gonna try INVALID_STATION
11:04:04  <Samu> seriously, aircraft range is one of those poorly thought features
11:05:12  <Samu> aircraft is out of range, skip to a reachable dest, then skip back to the same out of range dest -> now it's not out of range and flies to it
11:13:46  *** Gja has quit IRC
11:23:50  *** Gja has joined #openttd
11:27:37  *** sim-al2 has joined #openttd
11:29:19  *** ToffeeYogurtPots has joined #openttd
11:37:10  *** ToffeeYogurtPots has quit IRC
11:52:04  <Samu> sorry for criticizing
11:54:02  *** stefino has joined #openttd
12:10:23  *** Breckett_ has joined #openttd
12:11:43  *** Breckett has quit IRC
12:30:33  *** ToffeeYogurtPots has joined #openttd
12:45:39  *** DD has joined #openttd
12:52:40  *** Breckett_ has quit IRC
13:01:38  *** DD has quit IRC
13:03:01  *** Breckett has joined #openttd
13:27:43  *** FLHerne has quit IRC
13:32:17  *** FLHerne has joined #openttd
13:37:44  *** Thedarkb1 has quit IRC
13:46:07  *** Samu has quit IRC
13:47:47  *** Samu has joined #openttd
13:51:44  *** Thedarkb1 has joined #openttd
13:54:23  *** Samu has quit IRC
13:59:51  *** Samu has joined #openttd
14:02:31  *** Samu has quit IRC
14:04:40  *** sim-al2 has quit IRC
14:05:32  *** sla_ro|master has joined #openttd
14:09:35  *** Flygon has quit IRC
14:11:14  *** Samu has joined #openttd
14:11:15  <Samu> a
14:20:02  *** Gustavo6046 has joined #openttd
14:51:54  <peter1138> o
15:01:52  *** Alberth has joined #openttd
15:01:52  *** ChanServ sets mode: +o Alberth
15:02:00  <Alberth> o/
15:02:10  <crem> \o
15:26:45  *** Thedarkb1 has quit IRC
15:32:51  *** samgunner has joined #openttd
15:52:15  <Samu> i have a problem related to aircraft range
15:52:45  <Alberth> use an aircraft with unlimited range, and gone is your problem
16:04:14  *** ToffeeYogurtPots has quit IRC
16:06:19  *** synchris has joined #openttd
16:06:28  <Samu> FindNearestHangar has a problem with range, and i'm unsure what can be done about
16:06:34  <Samu> it
16:07:06  <Samu> Check if our current destination can be reached from the depot airport.
16:07:28  <Samu> current destination is ambiguous
16:07:46  <Samu> sometimes it's the airport the plane is at, sometimes it's the airport at the next destination
16:08:17  <Alberth> why would the current destination need to be reachable?
16:08:28  <Samu> because aircraft has range
16:08:54  <Samu> if the depot is reachable, but then it can't reach next destination... it won't get out after being serviced
16:09:01  <Alberth> you can obviously always fly back to where you are coming from and then go to the destination
16:10:19  <Alberth> if that is too complicated then indeed, check before accepting a hangar as destination
16:11:10  <Samu> the problem is: next destination isn't always the next airport, but the one he's at
16:11:41  <Samu> in this situation, it will be prone to be stuck inside depot with dest too far
16:12:34  <Samu> next destination isn't updated the way it should be
16:14:16  <Alberth> so first compute the true next destination?
16:14:48  <Samu> i'm trying to figure out how
16:15:52  <Samu> needs to know where he's at, the current station  and the next one
16:16:35  <Alberth> I would go for where it is, and the next destination
16:16:48  <Samu> vtile tells me where the aircraft is atm
16:16:53  <Alberth> if both are the same, you must get the next next destination
16:16:59  <Samu> TileIndex vtile = TileVirtXY(v->x_pos, v->y_pos);
16:17:31  <Samu> yeah, unsure how am I detecting that
16:17:34  <Alberth> airport has no collection of tiles in some way?
16:17:46  <Samu> it has st->airport.tile
16:18:16  <Alberth> ok, maybe some form of size then?
16:19:06  <Alberth> could be tricky if the aircraft is flying over an airport :p
16:20:44  <Samu> let me think
16:20:50  <Samu> there's airport 0, 1 and 2
16:20:54  <Samu> only airport 0 has depot
16:21:00  <Alberth> /me lets samu think
16:21:12  <Samu> aircraft has just landed on airport 2
16:21:17  <Samu> now it checks for servicing
16:21:44  <Samu> airport 2 has no hangar, so it calls findsnearesthangar
16:22:56  <Samu> oh, right, forgot, aircraft is going from airport 1 to airport 2, important
16:23:21  <Samu> GetTargetAirportIfValid(v) is called for *cur_dest
16:23:32  <Samu> and the airport it comes up with is airport 2
16:23:44  <Samu> it should have been airport 1, which is the next in the orders
16:24:03  <Alberth> probably not until it has loaded/unloaded cargo
16:24:23  <Alberth> at which point the journey it is doing has been completed
16:24:25  <Samu> it is already doing the checkservcing
16:24:29  <Samu> so it's past that
16:24:53  <Alberth> but it just landed
16:25:34  <Alberth> but sure, trains check for depots quite arbitrarily too
16:25:37  <Samu> i'm gonna try this with clean trunk
16:25:40  <Samu> brb
16:25:56  <Alberth> why is an aircraft a problem?
16:27:23  <Samu> the targetairport is only updated when the aircraft finishes helitakeoff
16:28:40  <Samu> when helicopter is raising up, and the check for servicing is called, and it needs to find a nearest hangar... it gets the wrong airport
16:30:42  <Alberth> aircraft and helitakeoff, that's confusing
16:31:15  *** Cubey has joined #openttd
16:31:32  <Samu> crap, i forgot an important order, the 3rd order was "service at nearest hangar"
16:32:32  <Samu> "service at nearest hangar" for some reason, uses StationID 0
16:33:19  <Alberth> and 0 triggers a search?
16:34:01  <Samu> 0 is the targetairport
16:34:04  <Samu> :(
16:34:15  <Alberth> ah
16:34:40  <Samu> order.MakeGoToDepot(0, ODTFB_PART_OF_ORDERS, 				_settings_client.gui.new_nonstop && this->vehicle->IsGroundVehicle() ? ONSF_NO_STOP_AT_INTERMEDIATE_STATIONS : ONSF_STOP_EVERYWHERE);
16:34:40  <Alberth> makes sense, as it's the only airport with a depot :p
16:35:07  <Samu> ...GoToDepot(0, ... this 0
16:35:15  <Alberth> yeah
16:35:45  <Samu> coincidence, 0 has hangar indeed
16:37:47  <Alberth> actually, it's a DepotID and not an airport id
16:38:02  <Alberth> unless these are linked
16:38:29  <Alberth> probably not, as that would break trains
16:38:48  <Samu> they are somewhat linked, airport hangars are belong to station tiles
16:40:08  <Alberth>  /* Aircraft have StationIDs for depot orders and never use DepotIDs   <-- ah, indeed
16:40:29  <Samu> okay, so the current order is "service at nearest hangar", right after landing, findnearest calls const Station *cur_dest = GetTargetAirportIfValid(v);
16:40:52  <Samu> it does Station *st = Station::GetIfValid(v->targetairport);
16:41:21  <Samu> v->targetairport is 0, per "service at nearest hangar", let's see
16:41:50  <Samu> nop, it was 2
16:41:59  <Samu> damn, what the heck am i reporting then?
16:42:06  <Samu> ah, right
16:42:11  <Samu> it should have been 1
16:42:21  <Samu> because that's the next destination
16:42:29  <Alberth> no
16:42:43  <Alberth> if a train goes from station A to B
16:42:47  *** Progman has joined #openttd
16:42:56  <Alberth> and from B to C
16:43:15  <Alberth> and on the way to B  it looks for depot, and finds depot X
16:43:32  <Alberth> it should still go to B after service right?
16:43:40  <Alberth> same with aircraft
16:44:13  <Samu> this aircraft is doing a "service at nearest hangar"
16:44:20  <Alberth> it is heading for the passenger terminal at 2, it should continue to go there after service
16:44:48  <Alberth> why does it land on 2 then?
16:45:18  <Alberth> I mean, there is no hangar there
16:45:21  <Samu> from the orders
16:45:29  <Samu> order 1: go to airport 1
16:45:33  <Samu> order 2: go to airport 2
16:45:37  <Samu> they're heliports, btw
16:45:39  <Samu> no hangars
16:45:45  <Samu> order 3: service at nearesh hangar
16:45:52  <Samu> that hangar is at airport 0
16:46:11  <Samu> it's now executing order 3
16:46:28  <Alberth> it has loaded and unloaded already?
16:46:31  <Samu> yes
16:46:40  <Alberth> but it just landed
16:46:53  <Samu> it landed, unloaded and loaded, and now is executing order 3
16:47:00  <Alberth> ok
16:47:16  <Samu> target airport brrings up airport 2, it should be 1, should it not?
16:47:28  <Samu> that's the next destination in the order
16:47:32  <Samu> after the service
16:48:34  *** TheMask96 has quit IRC
16:48:36  *** TheMask96 has joined #openttd
16:49:27  <Samu> about distances between airports, airport 1 and airport 2 are within aircraft range
16:49:42  <Samu> airport 1 and airport 0 are also within aircraft range
16:49:48  <Samu> airport 2 and airport 0 are not
16:50:41  <Samu> basically, airport 1 is in the middle of airport 0 and 2
16:52:54  <Samu> distance from aircraft to the iterated hangar (airport 0) is outside aircraft range
16:54:17  <Samu> DistanceSquare(st->airport.tile, cur_dest->airport.tile)
16:54:44  <Samu> distance from airport 0 to airport 2 > aircraft range, true
16:55:19  <Samu> returns nothing
16:55:30  <Samu> INVALID_STATION
16:55:55  <Alberth> that would seem fair
16:56:05  <Samu> v->IncrementRealOrderIndex();
16:56:17  <Samu> skips order 3, goes back to order 1
16:56:47  <Samu> so, it looks right
16:56:54  <Alberth> yeah
16:56:58  <Samu> then what was wrong, why did i ever bring this up :(
16:57:22  <Alberth> wrong scenario perhaps?
16:57:45  <Samu> gonna try service at nearest hangar before order 2
16:57:48  <Samu> brb
16:58:06  <Samu> order 1: go to airport 1
16:58:17  <Samu> order 2: service at nearest hangar
16:58:21  <Samu> order 3: go to airport 2
16:58:41  <Alberth> would probably skip order 3?
16:59:56  <Samu> helicopter landed at airport 1, loaded, unloaded, and now is starting order 2
17:00:11  <Samu> targetairport is 1
17:00:20  <Samu> distance from airport 0 to airport 1 > aircraft range, false
17:00:46  <Samu> it flying to service at hangar 1
17:01:05  <Samu> ops airport 0
17:01:23  <Samu> ah, this is it
17:01:31  <Samu> too far to next destination, can't exit hangar
17:02:01  <Samu> doesn't exit hangar
17:02:09  <Samu> is trying to execute order 3
17:03:16  <Samu> it should have checked distance from airport 0 to airport 2 > aircraft range
17:04:08  <Samu> r27930, with no M, clean trunk
17:04:18  <Samu> this was what I wanted to report
17:07:40  <Samu> must think how to solve this
17:08:33  <Samu> the problem is only for orders of type go to nearest hangar/service at nearest hangar
17:09:01  <Samu> i wonder how conditional orders work
17:10:15  <Samu> strange, i can't skip order
17:10:33  <Samu> still too far even when trying to go to airport 1, from airport 0
17:11:06  *** Thedarkb1 has joined #openttd
17:11:48  <Samu> now this is a real bug, aircraft is unresponsive
17:12:04  <Samu> stuck with "too far to near destination" without any orders atm
17:13:02  *** DDR has joined #openttd
17:19:18  <Samu> bah game was paused, i'm stupid, sorry
17:19:44  <Alberth> working as intended thus :)
17:20:40  <Samu> sorry :(
17:21:40  <Alberth> nah, I make such stupid mistakes all the time :)
17:22:01  <Alberth> as long as you realize what's happening afterwards :)
17:22:12  <Alberth> gtg now, bye
17:22:23  *** Alberth has left #openttd
17:22:29  <Samu> tc
17:48:06  *** Thedarkb1 has quit IRC
17:52:42  *** Thedarkb1 has joined #openttd
17:54:32  *** stefino has quit IRC
17:59:23  *** HerzogDeXtEr has joined #openttd
17:59:38  *** Gja has quit IRC
18:02:26  *** frosch123 has joined #openttd
18:03:23  *** glx has joined #openttd
18:03:23  *** ChanServ sets mode: +v glx
18:06:30  *** Breckett has quit IRC
18:07:21  *** chomwitt has joined #openttd
18:09:49  *** Wormnest has joined #openttd
18:11:35  *** Gja has joined #openttd
18:13:55  *** Wolf01 has joined #openttd
18:15:52  <Wolf01> o/
18:24:36  *** loeky has joined #openttd
18:27:28  *** Breckett has joined #openttd
18:40:35  *** Stimrol has joined #openttd
18:51:01  *** Progman has quit IRC
18:53:10  *** ToffeeYogurtPots has joined #openttd
19:19:31  *** andythenorth has joined #openttd
19:30:49  <andythenorth> o/
19:30:49  *** samgunner has quit IRC
19:31:16  <crem> \o
19:36:32  *** glx_ has joined #openttd
19:36:33  *** glx is now known as Guest537
19:36:33  *** glx_ is now known as glx
19:42:56  *** Guest537 has quit IRC
19:43:47  *** Stimrol has quit IRC
19:50:33  *** Stimrol has joined #openttd
20:08:17  <Samu> const Station *next_station = v->current_order.IsType(OT_GOTO_STATION) || v->current_order.IsType(OT_GOTO_DEPOT) && v->current_order.GetDepotActionType() != ODATFB_NEAREST_DEPOT? Station::GetIfValid(v->current_order.GetDestination()) == cur_dest ? Station::GetIfValid(v->GetLastOrder()->GetDestination()) : Station::GetIfValid(v->current_order.GetDestination()) : Station::GetIfValid(v->GetNextStoppingStation().value);
20:24:37  *** ToffeeYogurtPots has quit IRC
20:35:05  *** ToffeeYogurtPots has joined #openttd
20:49:11  <Wolf01> Why don't you concatenate the entire source in one line?
20:53:12  *** ToffeeYogurtPots has quit IRC
20:56:43  <frosch123> [21:49] <Wolf01> Why don't you concatenate the entire source in one line? <- i found all fs bugs, they are caused by line 1
20:57:06  <Wolf01> :D
20:57:26  <Eddi|zuHause> what am i gonna do with this late medieval earth that has non-sentient birds on it?
20:58:01  <Wolf01> Wat?!
20:58:28  <frosch123> he had too many senile birds
20:58:34  <frosch123> *has
20:59:11  *** sla_ro|master has quit IRC
20:59:59  <Eddi|zuHause> not earth... Sol III
21:00:57  <frosch123> doesn't sound like moo2, so probably stellaris
21:01:30  <Eddi|zuHause> in my last game i had a Sol III that was a dead world, inhabited by non-sentient cockroaches
21:01:32  *** Arveen2 has joined #openttd
21:02:22  <frosch123> are they better than sentient cockroaches?
21:04:04  <Eddi|zuHause> well, you can uplift them and find out :p
21:06:24  *** Arveen has quit IRC
21:11:53  <Wolf01> You are teasing me to play spore again
21:12:57  <V453000> omg that thing?
21:13:17  <V453000> haven't heard about that since all the hype when it came out and disappointed the shit out of me
21:16:01  <Wolf01> XD
21:16:48  <Wolf01> TBH, I liked it
21:18:02  <Wolf01> I liked a bit less the last part when you had to gather the spice and bring it to the other side of the galaxy with a really limited cargo bay
21:21:17  <Wolf01> Some kind of automated commercial routes which give you a cut of the profits would have been a lot better
21:23:35  <supermop_> did anyone play ascendancy?
21:25:28  <Wolf01> That one like master of orion?
21:30:05  <supermop_> maybe? it was from the early 90s
21:30:14  <supermop_> sort of turn-ish based
21:30:22  <supermop_> it incremented in 'days'
21:30:24  <Wolf01> Yeah, that one
21:31:12  <supermop_> when nothing was happening you'd fly through 10s of thousands of days
21:31:30  <supermop_> until the next breakthrough, or arrival in another star system
21:37:26  <Wolf01> Just like civilization
21:38:53  *** loeky has quit IRC
21:41:23  *** Thedarkb1 has quit IRC
21:41:49  *** Thedarkb1 has joined #openttd
22:10:06  <Wolf01> 'night
22:10:10  *** Wolf01 has quit IRC
22:16:45  *** Thedarkb1 has quit IRC
22:26:35  *** synchris has quit IRC
22:26:46  *** frosch123 has quit IRC
22:30:57  *** samgunner has joined #openttd
22:32:16  *** samgunner has joined #openttd
22:32:47  *** samgunner has joined #openttd
22:39:05  *** Breckett has quit IRC
22:40:25  *** HerzogDeXtEr has quit IRC
22:40:30  *** Gja has quit IRC
22:45:06  *** Gustavo6046 has quit IRC
22:55:42  *** Gustavo6046 has joined #openttd
22:55:45  *** Wormnest has quit IRC
22:56:03  *** Stimrol has quit IRC
22:57:24  *** Thedarkb1 has joined #openttd
22:58:08  *** andythenorth has quit IRC
23:52:52  *** Flygon has joined #openttd

Powered by YARRSTE version: svn-trunk