Config
Log for #openttd on 26th October 2018:
Times are UTC Toggle Colours
00:12:37  *** glavinics has quit IRC
00:28:19  *** Thedarkb has quit IRC
00:38:19  *** bigjazzsound has joined #openttd
00:43:12  *** Flygon has joined #openttd
01:36:33  *** Samu has quit IRC
01:49:04  *** DNS0 has joined #openttd
01:55:49  *** glx has quit IRC
02:04:01  *** zuzabrik has joined #openttd
02:16:51  *** triolus00 has joined #openttd
02:17:25  *** triolus has quit IRC
03:00:02  *** sh4rm4^Q has joined #openttd
03:20:09  *** yellyFish has quit IRC
03:20:37  *** HerzogDeXtEr has joined #openttd
03:27:02  *** HerzogDeXtEr1 has quit IRC
03:42:58  *** HerzogDeXtEr has quit IRC
03:56:56  *** cHawk has quit IRC
03:59:00  *** bytesighs has joined #openttd
04:02:41  *** cHawk has joined #openttd
04:25:23  *** d-fence_ has joined #openttd
04:27:07  *** sim-al2 has joined #openttd
04:39:37  *** sim-al2 has quit IRC
05:08:10  *** FrostFeline7 has joined #openttd
05:08:44  *** FrostFeline7 has quit IRC
05:09:05  *** ramindia has joined #openttd
06:36:29  *** serialoverflow19 has joined #openttd
06:51:53  *** rocky11384497 has quit IRC
07:12:04  *** puddingpimp has joined #openttd
07:12:47  *** puddingpimp has quit IRC
07:31:05  *** fryguybo1 has joined #openttd
07:36:29  *** urdh has quit IRC
07:37:57  *** nedbat has joined #openttd
07:37:59  *** urdh has joined #openttd
07:38:24  *** nedbat has quit IRC
08:09:17  *** matt21347 has joined #openttd
08:24:08  *** ExEs47 has joined #openttd
08:24:45  *** ExEs47 has quit IRC
08:32:17  *** d1str0 has joined #openttd
08:32:50  *** d1str0 has quit IRC
08:39:12  *** glavinics has joined #openttd
08:42:16  *** edef11 has joined #openttd
08:50:50  *** edef11 has quit IRC
08:54:09  *** emcepe has joined #openttd
09:34:37  *** Thinkofname has joined #openttd
09:34:52  *** Thinkofname has quit IRC
09:37:02  *** ianychoi has joined #openttd
09:47:03  *** Wacko1976 has joined #openttd
10:21:43  *** APTX_ has quit IRC
10:22:26  <glavinics> Hi, question regarding the "cleanup+moving to git" in general as I am totally new: Is there any plan to introduce cmake instead of simple make and with this support the cross platform compilation, it would support to generate visual studio  and xcode project as well?
10:29:32  *** gnu_jj has quit IRC
10:31:10  *** cypher6 has joined #openttd
10:36:00  <Xaroth> glavinics: You can always send in a PR
10:38:03  *** cypher6 has quit IRC
10:41:46  *** HerzogDeXtEr has joined #openttd
10:50:40  <FLHerne> glavinics: FWIW, the current buildsystem already generates MSVC projects
10:50:50  <FLHerne> glavinics: See projects/generate.vbs etc.
10:51:06  <FLHerne> (using CMake probably would save a lot of awkward custom code there)
11:04:15  *** tanuki has joined #openttd
11:11:44  *** dcraig8 has joined #openttd
11:23:02  <LordAro> glavinics: there is a mild plan to convert the build system to cmake - i think my branch is the most up to date: https://github.com/LordAro/OpenTTD/tree/cmake
11:23:08  <LordAro> it's not a high priority
11:28:59  *** Wacko1976 has quit IRC
11:49:33  *** darach has joined #openttd
11:54:45  *** atomizer has joined #openttd
12:37:05  *** automatical has joined #openttd
12:37:21  *** automatical has quit IRC
12:41:41  *** mirav has joined #openttd
13:08:29  <glavinics> thanks, I'm going to check this branch
13:12:35  <LordAro> it's very very incomplete
13:12:59  <LordAro> i did get it into a compiled state, can't remember whether i ever finished adding any video libraries
13:13:11  <LordAro> which makes it a bit fun for usability :)
13:13:15  <LordAro> glavinics: ^
13:14:38  <glavinics> I'm new so everything is good for practice and get familiar with the environment, no worries :)
13:17:05  *** nielsm has joined #openttd
13:20:33  *** Stimrol has joined #openttd
13:39:03  <ST2> oh, we're almost on the time for scary things :D
13:39:04  <ST2> https://img-9gag-fun.9cache.com/photo/aLgQ3bv_700b.jpg
14:16:57  *** Samu_ has joined #openttd
14:29:47  <nielsm> not quite transport tycoon, but fine video on "video game industry and logistics is so wrong" :) https://www.youtube.com/watch?v=8LysiXf-DJU
14:57:05  *** Gja has joined #openttd
15:12:25  *** Wormnest has joined #openttd
15:16:46  *** rocky11384497 has joined #openttd
15:19:18  *** gUcu_ has joined #openttd
15:29:41  *** Wormnest has quit IRC
15:31:39  *** Flygon has quit IRC
15:37:12  *** wodencafe has quit IRC
15:45:39  <Eddi|zuHause> i'm not sure i should have watched that
15:46:25  <nielsm> disillusioned? :)
15:54:23  *** Stimrol has quit IRC
15:56:42  *** wodencafe has joined #openttd
16:00:34  *** Stimrol has joined #openttd
16:16:23  *** yellyFish has joined #openttd
16:16:59  <yellyFish> hello :)
16:23:34  *** Thedarkb has joined #openttd
16:27:24  *** TheMask96 has quit IRC
16:27:45  *** TheMask96 has joined #openttd
16:32:53  *** Thedarkb has quit IRC
16:36:20  <planetmaker> o/
16:42:58  <yellyFish> I have been trying to measure some functions with the in-game framerate thing but can't seem to make it work. i added a new row for it in framerate_gui.cpp and in framerate_type.h but still nothing. I just get a 'Game loop' row in blue in the frame rate window
16:43:08  <yellyFish> It compiles fine and all
16:43:49  *** Thedarkb has joined #openttd
16:44:41  <nielsm> you need to add a bunch of things in different places, in the right order
16:45:45  <nielsm> and most or none of it is sanity checked at compile time
16:46:01  <nielsm> can you make a diff of your changes and put it on a pastebin?
16:46:18  <nielsm> (or a branch on github)
16:46:45  <yellyFish> yeah. the thing is i am doing this with JGRPP
16:46:57  <yellyFish> but i don't think it changes that much
16:47:03  *** Gustavo6046 has quit IRC
16:47:04  <yellyFish> i'll do a diff
16:54:14  <nielsm> https://github.com/OpenTTD/OpenTTD/commit/e00908f5e900ac5314930b2775eb38f91a6c4abe#diff-0feed7269f2b37a39d2b49632a02cdfeR397
16:54:15  <nielsm> wtf
16:54:34  * nielsm blames orudge
16:55:27  *** Thedarkb has quit IRC
16:56:56  <yellyFish> https://pastebin.com/wAEj9wYp
16:59:19  <nielsm> you also need to add the string to english.txt
16:59:23  <nielsm> for the GUI window
16:59:25  <Eddi|zuHause> usually people make "unified diff"s, because they are a lot more readable
16:59:30  <nielsm> and yes that
16:59:40  <Eddi|zuHause> also, versioning tools like git make those by default
16:59:46  <nielsm> if you're using git, use the 'git diff' command
17:01:08  <yellyFish> i have been learning git with my own little toy projects, but i don't know if it's possible to use it with not the newest version to test on the same version of the server
17:01:44  <Eddi|zuHause> yes, that's easy
17:02:00  <nielsm> git diff  <- makes a diff of unstaged, uncommitted changes
17:02:04  <Eddi|zuHause> just "git checkout <hash>"
17:02:11  <nielsm> git diff --cached  <-- makes a diff of stages, uncommitted changes
17:02:37  <nielsm> git diff <revisionorbranchname>  <-- makes a diff from current committed version to that commit
17:02:54  <Eddi|zuHause> the hash is in the server version "OpenTTD g<hash>"
17:03:46  <LordAro> nielsm: i found https://stackoverflow.com/questions/33271273/msvc-fails-on-static-assert-on-struct-member
17:03:49  <Eddi|zuHause> instead of a hash you can also use a tag
17:03:52  <LordAro> no mention of if it's been fixed in 2017
17:04:02  <yellyFish> uhhh, let me try this english.txt thing first
17:06:27  <Samu_> 2015 update 3 is what I use I think
17:08:43  *** Wolf01 has joined #openttd
17:09:20  <Wolf01> o/
17:09:37  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh approved pull request #6911: Codechange: Improve (un)zoom performance https://git.io/fx9ff
17:09:38  <yellyFish> \o
17:14:13  <yellyFish> welp. at least it shows the name. but it shows 0.00 ms but that's not possible because i know this function is used a lot
17:14:26  <nielsm> LordAro, would you prefer solving that compile error via removing the static assert, moving it inside the constructor,m or moving it inside the event function near the point of variables' use?
17:14:36  <yellyFish> i'll do the git thing first tho
17:15:29  <LordAro> nielsm: i would probably say the constructor
17:15:32  <nielsm> yellyFish ah yeah, when using PerformanceAccumulator you need to also add a "reset" of the accumulator somewhere
17:15:33  <LordAro> with a comment
17:17:01  *** Thedarkb has joined #openttd
17:18:40  <nielsm> yellyFish, probably add PerformanceAccumulator::Reset(PFE_SPRITEGROUP); on openttd.cpp line 1360
17:18:45  <nielsm> just below the other reset
17:19:23  <nielsm> it's not entirely obvious from that function name, but it's actually in the Reset function the measurement gets recorded
17:19:38  <nielsm> the constructor only accumulates timing into the current measurement
17:19:41  *** wodencafe has quit IRC
17:20:13  <yellyFish> am i too picky or this should be made into a object so we can insert more easily new measurements?
17:20:36  <yellyFish> or something like that to automate this process at least
17:20:40  <nielsm> I tried making it as simple to add new things as possible :)
17:21:09  <yellyFish> or document it
17:21:21  <yellyFish> or is it already somewhere?
17:21:35  <nielsm> any easier to plug in than this and you'd need to either sacrifice runtime performance, or use some preprocessor step on the code
17:21:36  <nielsm> I think
17:21:48  <nielsm> nah, more documentation would be in place, you're right
17:22:07  <yellyFish> i am not trying to be rude btw ;)
17:22:10  <Eddi|zuHause> we used to have a "Cookbook" in the wiki to record that kind of "howto", but that typically is outdated by the time it is written...
17:22:34  <nielsm> yeah, it's better to add it to the doc comment on the class
17:23:20  <nielsm> bbl, food
17:25:33  <yellyFish> so i clone, then checkout to the version i want and branch?
17:25:52  <Eddi|zuHause> yes
17:30:02  *** APTX_ has joined #openttd
17:43:12  *** _1horimiya1 has joined #openttd
17:43:14  *** _1horimiya1 has left #openttd
17:43:55  *** _1horimiya1 has joined #openttd
17:46:07  *** _1horimiya1 has quit IRC
17:47:56  *** andythenorth has joined #openttd
17:49:02  <andythenorth> yo
17:49:08  <Wolf01> o/
17:53:35  *** gelignite has joined #openttd
18:00:39  *** Thedarkb has quit IRC
18:08:05  *** frosch123 has joined #openttd
18:13:06  *** wodencafe has joined #openttd
18:16:24  <andythenorth> quak
18:18:34  *** gelignite has quit IRC
18:18:57  *** gelignite has joined #openttd
18:19:58  *** Thedarkb has joined #openttd
18:20:35  *** gelignite2nd has joined #openttd
18:20:48  <andythenorth> 	also stuff
18:20:50  <andythenorth> and things
18:22:42  <DorpsGek_II> [OpenTTD/OpenTTD] michicc merged pull request #6911: Codechange: Improve (un)zoom performance https://git.io/fxoMe
18:23:36  <LordAro> stuff AND things?
18:23:39  <LordAro> wow
18:26:05  <andythenorth> wondering if I can get forums fixed
18:26:14  <andythenorth> kind of used to like htem
18:27:14  *** gelignite has quit IRC
18:30:30  *** glavinics has quit IRC
18:30:49  <frosch123> moo
18:31:03  <andythenorth> enough tanks
18:31:06  <andythenorth> more horse or something
18:31:14  <andythenorth> can we get any more PRs through?
18:31:27  *** MC_saban has joined #openttd
18:32:01  <andythenorth> here are the ones not 'waiting on author' https://github.com/OpenTTD/OpenTTD/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+-label%3A%22waiting-on-author%22+
18:32:24  <andythenorth> and here are the ones that aren't Samu https://github.com/OpenTTD/OpenTTD/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+-label%3A%22waiting-on-author%22+-author%3A%22SamuXarick%22+
18:37:20  <Eddi|zuHause> i don't think i have useful input for any of those
18:43:02  *** yellyFish has quit IRC
18:43:30  *** yellyFish has joined #openttd
18:45:08  *** Thedarkb1-X40 has joined #openttd
18:45:22  *** Thedarkb1 has joined #openttd
18:51:28  *** fdegir has joined #openttd
18:51:34  *** Thedarkb has quit IRC
18:51:49  *** Thedarkb-X40 has quit IRC
19:05:24  *** glx has joined #openttd
19:05:24  *** ChanServ sets mode: +v glx
19:15:46  *** Wacko1976 has joined #openttd
19:16:10  *** yellyFish has left #openttd
19:16:53  *** yellyFish has joined #openttd
19:19:11  *** yellyFish has quit IRC
19:31:59  <Wolf01> I should burn my credit card
19:36:31  *** yellyFish has joined #openttd
19:44:09  <andythenorth> y?
19:44:18  <Wolf01> Lego
19:44:58  <andythenorth> any new technic?
19:45:35  <Wolf01> The forest machine
19:45:37  *** Thedarkb1 has quit IRC
19:45:54  <Wolf01> I'm curious about the new pneumatic valves
19:46:43  <Wolf01> You might say "buy the valves alone", no, MOAR PIECES!
19:46:48  <Eddi|zuHause> i don't trust people who don't articulate the "p" in "pneumatic"
19:47:15  *** happpy has joined #openttd
19:47:26  *** happpy has left #openttd
19:48:00  <andythenorth> I ordered new valves on BL
19:48:02  <andythenorth> from belgium
19:48:05  <andythenorth> no arrive :(
19:49:56  <Eddi|zuHause> that's because of brexit
19:53:29  *** yellyFish has quit IRC
19:54:29  *** yellyFish has joined #openttd
19:54:46  <andythenorth> or post
19:55:07  *** yellyFish has joined #openttd
19:55:40  <Wolf01> Or scammed
19:59:20  <andythenorth> that
20:04:00  <yellyFish> is it possible to make the same change to two branches? i want to change where i measure the timing for both the base case and the one with changes
20:05:12  <nielsm> cherry-pick the revision from one branch to the other
20:05:37  <nielsm> or, make the change on a separate branch and merge than branch into both
20:05:44  <nielsm> actually do the latter
20:07:11  <yellyFish> but shouldn't it work to change the base case branch only if i made the branch with changes from it ?
20:08:10  <yellyFish> or am i misunderstanding how branching works
20:09:47  <nielsm> you probably are, but I'd need a drawing board to explain things well so I'll just tell you to read up on it somewhere else that already has pre-made illustrations
20:10:11  <yellyFish> yeah. i am also reading
20:11:25  <andythenorth> it's just a tree
20:11:32  <andythenorth> 'just'
20:11:40  <nielsm> nah it's a directed acyclic graph
20:12:30  <andythenorth> you just quoted a line from https://en.wikipedia.org/wiki/Anathem
20:12:31  <nielsm> if you know what a DAG is git becomes a lot easier to understand
20:12:46  <andythenorth> the problem with DAGs
20:12:51  <andythenorth> is you start seeing them everywhere :P
20:12:51  <yellyFish> i know what a DAG is
20:14:09  <yellyFish> DAGs are trees but not all tress are DAGs
20:14:22  <nielsm> other way around
20:14:22  <Eddi|zuHause> <yellyFish> but shouldn't it work to change the base case branch only if i made the branch with changes from it ? <-- you'd want to have a script that duplicates the commit you make on one branch automatically on the other one
20:15:40  <Eddi|zuHause> or, you have a branch and rebase it onto whatever checkout you want
20:16:29  <nielsm> also maybe worth reading, as this series of blog posts concerns the case of maintaining one change in multiple branches in git: https://blogs.msdn.microsoft.com/oldnewthing/20180312-00/?p=98215
20:16:30  <Eddi|zuHause> so your branch can be on top of anything you want, but you have only one copy of the branch at any given time
20:17:57  *** Progman has joined #openttd
20:21:41  *** leerg319 has joined #openttd
20:25:13  *** glavinics has joined #openttd
20:25:14  *** gelignite2nd has quit IRC
20:27:16  <yellyFish> mmm. so if i rebase the common node for both branches then they will also have those changes?
20:27:59  *** nielsm has quit IRC
20:28:37  *** magog has joined #openttd
20:29:20  *** magog has quit IRC
20:30:10  *** leerg319 has quit IRC
20:30:31  <andythenorth> should do
20:46:19  <Eddi|zuHause> yellyFish: by rebasing your branch, you take it off one node, and reattach it to another node on the graph
20:46:38  <Eddi|zuHause> so it will disappear at one place, and reappear at another
20:52:24  <andythenorth> oof bed
20:52:24  *** andythenorth has left #openttd
21:03:58  *** Levex has joined #openttd
21:26:14  *** Gja has quit IRC
21:42:50  *** lulzy has joined #openttd
21:45:01  *** Gustavo6046 has joined #openttd
21:51:27  *** frosch123 has quit IRC
22:01:46  *** pstef has joined #openttd
22:07:51  *** Mo0O has joined #openttd
22:08:59  *** Mo0O has quit IRC
22:27:29  *** Eddi|zuHause2 has joined #openttd
22:32:14  *** Eddi|zuHause has quit IRC
22:39:25  *** matt21347 has quit IRC
22:53:35  *** Gustavo6056 has joined #openttd
23:00:39  *** Gustavo6046 has quit IRC
23:00:39  *** Gustavo6056 is now known as Gustavo6046
23:09:01  *** Eddi|zuHause2 is now known as Eddi|zuHause
23:27:31  *** mindlesstux has quit IRC
23:35:57  *** Gustavo6056 has joined #openttd
23:41:20  *** Wolf01 has quit IRC
23:43:09  *** Gustavo6046 has quit IRC
23:43:09  *** Gustavo6056 is now known as Gustavo6046
23:49:17  *** Wacko1976 has quit IRC
23:55:01  *** Samu_ has quit IRC
23:57:00  *** Gustavo6056 has joined #openttd

Powered by YARRSTE version: svn-trunk