Log for #openttd on 14th February 2019:
Times are UTC Toggle Colours
00:02:02  *** tokai has joined #openttd
00:02:02  *** ChanServ sets mode: +v tokai
00:09:00  *** tokai|noir has quit IRC
01:05:54  <DorpsGek_II> [OpenTTD/OpenTTD] JGRennison opened issue #7226: NPF: Ship: Assertion failure when ship encounters shore
01:09:21  *** Gustavo6046 has quit IRC
01:18:44  *** supermop_Home has joined #openttd
01:43:33  *** Pikka has joined #openttd
01:48:24  *** snail_UES_ has joined #openttd
02:06:44  *** Thedarkb-X40 has joined #openttd
02:13:44  *** Thedarkb1-T60 has quit IRC
02:22:28  <supermop_Home> yo Pikka
02:38:17  <Pikka> yo yo
02:43:25  *** samu has quit IRC
03:14:55  *** Wormnest has quit IRC
03:22:42  *** glx has quit IRC
03:30:17  *** debdog has joined #openttd
03:33:39  *** D-HUND has quit IRC
04:31:04  *** Pokka has joined #openttd
04:37:52  *** Pikka has quit IRC
04:46:10  *** snail_UES_ has quit IRC
04:48:14  *** Thedarkb-X40 has quit IRC
06:08:57  *** Smedles has quit IRC
06:10:28  *** Smedles has joined #openttd
06:34:03  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN opened pull request #7227: Replace Window::scrolling_scrollbar with Window::active_widget
06:37:20  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7209: Fix: volume slider behavior in music gui
07:05:41  *** andythenorth has joined #openttd
07:10:33  <Pokka> well
07:10:36  *** Pokka is now known as Pikka
07:24:36  <andythenorth> indeed?
07:42:21  <peter1138> Is it?
07:42:30  *** Eddi|zuHause2 has joined #openttd
07:46:56  <Pikka> mostly
07:47:29  *** Eddi|zuHause has quit IRC
07:49:50  <andythenorth> 93%
07:51:07  <peter1138> < I might need help eating this...
07:58:40  <andythenorth> is it some kind of special day?
08:12:17  <peter1138> Not sure.
08:27:43  *** andythenorth has quit IRC
08:57:32  *** andythenorth has joined #openttd
09:00:05  <LordAro> peter1138: doesn't matter; got cake?
09:12:52  *** samu has joined #openttd
09:15:27  <samu> hi
09:18:42  <peter1138> I have got cake :D
09:29:08  <debdog> certainly better than cmake
09:35:48  <samu> oh, npf crashed
09:36:10  <samu> I failed to trigger that crash
09:43:17  <samu> got it
09:43:25  <samu> requires 90 degrees forbidden
09:44:06  <samu> if it happens for ships, i suppose it should also happen for trains, let me test
09:50:02  <samu> hmm nop, doesnt happen for trains
10:02:58  <samu> interesting though
10:03:07  <samu> NPF is dumber
10:03:31  <samu> doesn't consider reversing for trains
10:22:27  *** andythenorth has left #openttd
10:31:25  *** Eddi|zuHause2 is now known as Eddi|zuHause
10:32:26  <Eddi|zuHause> aren't these the kinf of things that hang on the wall for years and then nobody dares to touch it because they forgot how long it was?
10:32:32  <Eddi|zuHause> *kind
10:41:32  <samu> it was touched recently
10:51:42  <peter1138> Well it looks easy to partially revert that.
10:55:06  *** andythenorth has joined #openttd
10:55:34  <andythenorth> Pikka: HSTs, mail or no mail?
10:56:33  <peter1138> I'd go for no mail.
10:59:38  <andythenorth> design innit
10:59:47  <andythenorth> trains + sandwiches
11:01:20  <andythenorth> no mail is simplest
11:01:32  <andythenorth> kind of wastes some tile space though :P
11:02:46  <andythenorth> bbl
11:02:47  *** andythenorth has left #openttd
11:12:01  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on issue #7226: NPF: Ship: Assertion failure when ship encounters shore
11:22:31  *** Pikka has quit IRC
11:56:55  <samu> no need to revert too much
11:57:28  <samu> seems to be a case of 90 degrees
11:58:16  <samu> need to see how this was before the change
11:58:24  <samu> I think the assert doesn't need to be there
12:00:29  <samu> result.best_trackdir  = INVALID_TRACKDIR;
12:00:57  <samu> there is indeed no track, that a reverse should be happening
12:01:34  <peter1138> That's why I said partially revert. Literally junk that hunk.
12:01:52  <samu> just for the ship
12:01:56  <peter1138> Yes.
12:02:07  <peter1138> I can do a PR when I have my lunchbreak.
12:02:08  <samu> for train it doesn't happen, because PBS reserved stuff
12:02:33  <samu> not really sure why
12:02:40  <samu> but it's pbs related
12:03:07  <peter1138> Yeah, but white chocolate lion bars are incredibly sweet.
12:03:54  <samu> for road vehicle, the code makes a reverse track special bit
12:05:24  <samu> if (type != TRANSPORT_ROAD || HasBit(subtype, ROADTYPE_TRAM)) return;
12:05:31  <samu> but if it is a tram
12:05:44  <samu> it apparently can asser
12:05:45  <samu> t
12:06:07  <samu> how do i test trams... need newgrfs
12:07:38  <peter1138> Yeah, get a tram set.
12:14:36  <samu> hmm nop, doesn't assert, or i dont know how to
12:18:46  *** Flygon has quit IRC
12:21:05  <samu> well, it's just the ship
12:21:28  <samu> maybe don't ask the pathfinder for a track if 90 degrees
12:21:35  <samu> if none ahead
12:22:17  <samu> reverse before asking pathfinder
12:22:23  <samu> and keep the assert
12:22:25  <samu> what u think?
12:22:42  <peter1138> Pathfinder should say no path if there's no path.
12:22:45  <peter1138> Not crash.
12:23:10  <samu> but it's a single tile, the tile just next
12:28:35  <samu> u got this at line 478 ship_cmp.cpp /* Can't continue in same direction so pick first available track. */
12:29:03  <samu> maybe should be repeated just before line 500
12:29:13  <samu> erm 501
12:29:43  <samu> if (tracks == TRACK_BIT_NONE)
12:32:26  <samu> hmm opf doesnt have 90 degrees :|
12:33:23  <samu> it really has to ask the pathfinder because of opf
12:33:27  <samu> t.t
12:44:24  <peter1138> Doesn't have 90 degrees?
12:53:20  *** samu has quit IRC
13:09:16  *** sla_ro|master has joined #openttd
13:25:10  *** Extrems has quit IRC
13:26:17  *** Extrems has joined #openttd
13:26:37  *** Markk has joined #openttd
13:27:27  <DorpsGek_II> [OpenTTD/OpenTTD] glx22 commented on pull request #7227: Replace Window::scrolling_scrollbar with Window::active_widget
13:31:01  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7227: Replace Window::scrolling_scrollbar with Window::active_widget
13:33:45  *** snail_UES_ has joined #openttd
13:35:07  *** andythenorth has joined #openttd
13:39:55  <andythenorth> maybe I go on a train ride
13:40:09  <andythenorth> the power->weight on those is insane
13:43:48  <andythenorth> 4500hp / 260t
13:44:10  <peter1138> Heh
13:44:36  <andythenorth> I should go to exeter
13:46:15  <Eddi|zuHause> how does that compare to
13:46:53  <Eddi|zuHause> i remember someone mentioning instances where one of those engines went with a single passenger car
13:47:36  <andythenorth> is that a Ludmilla?
13:48:30  <Eddi|zuHause> yes
13:50:46  <DorpsGek_II> [OpenTTD/OpenTTD] MrMamen opened pull request #7228: Update changelog.txt
13:51:18  <Eddi|zuHause> the only way you could make that worse is having two of these, because you lack a steering car for push-pull-service
13:53:47  *** Gustavo6046 has joined #openttd
13:56:09  *** snail_UES_ has quit IRC
14:04:51  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN opened pull request #7229: Fix #7114: Partial revert of 7d06fec799 for ship pathfinding.
14:05:09  <peter1138> Oh, samu left.
14:12:32  *** samu has joined #openttd
14:18:03  <samu> when will this be
14:18:07  <samu> 1.9.0'ed
14:20:14  <peter1138> When 1.9.0 is released.
14:21:30  <peter1138> You can build your own docs though, of course.
14:23:27  <andythenorth> hmm
14:23:30  <andythenorth> 93%
14:23:34  <andythenorth> maybe I should add some more trains
14:23:39  <andythenorth> then it will be 85% again
14:25:27  <Eddi|zuHause> andythenorth: think of it this way: "everybody has to die" is not true, if you count up the number of people who ever have died against the ones that have ever been born, you get a number something along the lines of 95%. if that ever reaches 100% it means mankind is extinct
14:25:42  <andythenorth> yes
14:25:44  <andythenorth> that
14:26:04  <andythenorth> it's the exact analogy
14:26:23  <Eddi|zuHause> if your project ever reaches 100% completion it is dead
14:26:51  <andythenorth> OTOH, I do have to release 2.0.0 sometime :P
14:26:54  <andythenorth> 2.0.0 doesn't mean dead
14:27:55  <peter1138> If only you had engine variations...
14:31:16  <andythenorth> I didn't want to mention :P
14:31:22  <andythenorth> so how are we doing that again?
14:31:59  <Eddi|zuHause> so, i haven't solved any of my performance problems, but i haven't had any system freezes when i manually echo high/low to /sys/class/drm/card0/device/power_dpm_force_performance_level instead of keeping it at auto
14:32:43  <peter1138> Have you considered it might be faulty hardware?
14:32:47  *** kapamat has joined #openttd
14:33:19  <Eddi|zuHause> yes, but the alternative hardware is worse/older/less supported/not dx11
14:39:17  <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on issue #7226: NPF: Ship: Assertion failure when ship encounters shore
14:51:02  *** nielsm has joined #openttd
15:00:40  <samu> add  90 degrees for opf?
15:04:59  <DorpsGek_II> [OpenTTD/OpenTTD] nikolas closed pull request #7209: Fix: volume slider behavior in music gui
15:05:00  <DorpsGek_II> [OpenTTD/OpenTTD] nikolas commented on pull request #7209: Fix: volume slider behavior in music gui
15:10:41  <samu> Should I use autoreplace or should I not
15:10:45  <samu> for my AI
15:13:25  <samu> I'm 50%/50%
15:13:27  <samu> unsure
15:15:30  <andythenorth> is opf deleeted yet?
15:15:37  <andythenorth> or even deleted?
15:19:30  <peter1138> Sadly not.
15:20:04  <peter1138> samu, "90 degrees for opf" ... what does that mean?
15:20:15  <peter1138> With OPF, ships do turn 90 degrees.
15:21:31  <samu> forbid 90 degrees
15:21:56  <samu> i had a patch request about it, but got rejected
15:23:54  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7227: Replace Window::scrolling_scrollbar with Window::active_widget
15:24:16  <peter1138> Yeah we're more likely to remove that option, at least for ships.
15:24:22  <peter1138> And more likely to remove OPF.
15:25:12  <LordAro> ^ pls
15:26:25  <andythenorth> pls, it's healthy to delete stuff
15:26:33  <andythenorth> ok maybe not as much as I want to delete :P
15:26:34  <andythenorth> but some
15:30:20  <andythenorth> samu: maybe you could do a PR removing OPF? o_O
15:30:25  <andythenorth> you've probably seen a lot of that code?
15:30:40  <andythenorth> and you could find all the regressions
15:34:41  *** Wormnest has joined #openttd
15:36:48  <andythenorth> dunno if anyone would approve it though :x
15:40:56  *** samu has quit IRC
15:43:09  <DorpsGek_II> [OpenTTD/OpenTTD] nikolas commented on pull request #7228: Update changelog.txt
15:48:56  *** Samu has joined #openttd
15:49:00  <Samu> hi
15:53:34  <Samu> so i installed HexChat
15:53:40  <Samu> text is blurry
15:53:45  <Samu> how to fix?
15:55:20  <Samu> gonna try dpi aware stuff, brb
15:55:23  *** Samu has left #openttd
15:59:34  *** Samu has joined #openttd
15:59:45  <Samu> solved!
15:59:53  <Samu> it was high dpi aware stuff
16:04:01  <Samu> m
16:12:51  <DorpsGek_II> [OpenTTD/OpenTTD] glx22 commented on pull request #7228: Update changelog.txt
16:25:34  *** Progman has joined #openttd
16:28:27  *** Gja has joined #openttd
16:38:39  *** HerzogDeXtEr has joined #openttd
16:42:56  *** synchris has joined #openttd
16:59:56  <DorpsGek_II> [OpenTTD/OpenTTD] MrMamen updated pull request #7228: Update changelog.txt
17:00:55  <DorpsGek_II> [OpenTTD/OpenTTD] MrMamen commented on pull request #7228: Update changelog.txt
17:01:42  *** acklen_ has quit IRC
17:02:08  *** APTX has quit IRC
17:03:22  *** APTX has joined #openttd
17:33:09  <Samu> arf, my AI doesn't work well with groups
17:33:16  <Samu> wasn't built with it in mind :|
17:35:41  <andythenorth> so eh
17:35:48  <andythenorth> what does Article 13 mean for Bananas?
17:37:37  <nielsm> well I suppose technically it'd mean everything had to be manually reviewed before becoming available
17:38:36  *** acklen has joined #openttd
17:38:53  <andythenorth> but how do we know what infringes copyright?
17:39:04  <andythenorth> does this mean Bananas is over?
17:40:19  <nielsm> well isn't part of the uploader agreement that you give bananas a non-exclusive, non-retractable license to distribute the uploaded work forever?
17:41:04  <nielsm> of course you can only grant that if you actually have the rights to grant those rights
17:41:06  <nielsm> (ugh)
17:42:49  <andythenorth> there's no case law obviously
17:42:56  <andythenorth> and limited legal opinons, it's too new
17:43:20  <andythenorth> but there seems to be a requirement to deploy content recognition technology on uploads to prevent infringement
17:43:39  <andythenorth>
17:43:45  <nielsm> add a feature to bananas to allow people to upload material they do _not_ want available on bananas
17:44:02  <andythenorth> interesting idea
17:44:19  <andythenorth> but we'd need them to delegate us the rights to hold that copyrighted material
17:44:32  <andythenorth> I can think of at least one contributor who won't do that
17:45:17  <nielsm> well, if they won't let the service provider do automatic screening against their material they don't have a good case if someone else uploads their material and it can't be recognized, imo
17:46:34  <nielsm> specifically for GRFs could allow registering just GRFid's of course
17:46:35  <peter1138> Personally I'd just ignore it all.
17:46:45  <nielsm> as long as nobody sues there's no problem
17:47:01  <peter1138> It's clearly an ill-thought out law that's designed to only apply to the likes of Facebook, Instagram and Twitter...
17:47:35  <peter1138> I better go and get some dog food.
17:49:07  <andythenorth> just move Bananas to the UK
17:49:13  <andythenorth> article 13 probably won't apply eh
17:49:16  <andythenorth> we opted out of this stuff :P
17:50:03  <nielsm> the article 11 link tax is the most ridiculous though
17:50:12  <nielsm> why must I pay you to refer people to you?
17:50:22  *** andythenorth has quit IRC
17:50:34  <nielsm> did I ever pay for the right to suggest someone go to the store and buy a newspaper?
17:53:31  *** frosch123 has joined #openttd
17:56:11  *** Wormnest has quit IRC
18:11:31  *** Wolf01 has joined #openttd
18:13:01  <Wolf01> o/
18:14:40  *** glx has joined #openttd
18:14:41  *** ChanServ sets mode: +v glx
18:18:05  <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep opened pull request #7230: Fix #7226: No ship track due to "forbid 90 deg turns"-> Do not call pathfinders.
18:21:10  <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7230: Fix #7226: No ship track due to "forbid 90 deg turns"-> Do not call pathfinders.
18:22:24  *** andythenorth has joined #openttd
18:24:42  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh approved pull request #7228: Update changelog.txt
18:25:01  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh merged pull request #7228: Update changelog.txt
18:29:11  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #7178: Add AI and GS to framerate window
18:35:42  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh approved pull request #7217: Fix #6599: Disable build and rename button in build vehicle window when no vehicle is selected.
18:35:51  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh merged pull request #7217: Fix #6599: Disable build and rename button in build vehicle window when no vehicle is selected.
18:35:57  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh closed issue #6599: Can still click on buy button in vehicle selection window even if no vehicle is selected
18:39:04  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh requested changes for pull request #7169: Fix: Spectator color
18:43:23  <Samu> 90 degrees for opf soon!
18:45:44  <LordAro> Samu: it's like you totally ignored what everyone said
18:45:58  <Eddi|zuHause> that sounds like my experience
18:48:32  <Eddi|zuHause> <nielsm> the article 11 link tax is the most ridiculous though <-- the worst part about that is that they passed the exact same law in germany, and it turned out to be completely useless
18:50:23  <Eddi|zuHause> half of the news publishers went "what? that's crazy even for our standards, google can just link our news for free"
18:50:27  <Eddi|zuHause> and for the other half google went "what? that's crazy, so we shorten our links to not contain any content, see how many people click on that"
18:50:49  <Eddi|zuHause> then they tried to force google to show the full details (and get paid), which didn't work
18:51:08  <Eddi|zuHause> and after like 2 years they finally gave in and said "fine, you can also show it for free"
18:52:39  <Eddi|zuHause> so in the end, google (which is 99% of all links) pays nothing, and smaller news aggregators can't compete with google anymore. nobody gets paid.
18:53:11  <Eddi|zuHause> well, except for the lawyers
18:56:58  <nielsm> huh
18:59:57  <andythenorth> kinda wonder how it's supposed to work
19:00:11  <andythenorth> these EU-wide laws
19:00:14  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh approved pull request #7224: Change: Use selected group as parent when creating a new group.
19:00:17  <andythenorth> that seem to benefit nobody
19:02:35  <nielsm> laws that think to protect people who don't understand technology against technology, enacted by people who don't understand technology
19:04:06  <andythenorth> that benefit technology giants
19:06:28  <andythenorth> like GDPR
19:06:39  <andythenorth> which means we've all opted in to data collection, through all those popups
19:10:23  <peter1138> Hi, I have dog food now.
19:10:26  <peter1138> And I have raw milk.
19:10:38  <peter1138> And the missus is cooking a giant dinner.
19:11:18  <peter1138> nielsm, is the AI/GS framerate stuff near ready?
19:11:59  <nielsm> well, it works as-is, question is mostly about presentation I suppose
19:12:28  <nielsm> (UX)
19:12:34  <peter1138> *nod*
19:12:44  <peter1138> Scrollbar :-)
19:14:25  <andythenorth> peter1138: are those the ingredients? :o
19:14:34  <peter1138> I hope not.
19:18:58  <peter1138> Hmm.
19:19:06  <peter1138> I should start removing old branches, yes.
19:23:31  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #6811: Feature: Add NotRoadTypes (NRT)
19:25:27  *** Thedarkb1-T60 has joined #openttd
19:26:37  <peter1138> ^ Just a rebase, nothing new since... the other day, I guess.
19:32:54  *** Gja has quit IRC
19:40:04  *** Thedarkb1-T60 has quit IRC
19:44:48  <andythenorth> eh
19:44:58  <andythenorth> bananas, multiple people can upload the same grf right?
19:45:09  <andythenorth> I have uploaded my grfs from both coop and my account
19:45:11  <andythenorth> planetmaker: ^
19:45:30  <peter1138> Does it not at least check the GrfID?
19:45:49  *** gelignite has joined #openttd
19:47:18  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN opened pull request #7231: Add: Add flag and railtype sprite type to draw pre-combined ground sprites.
19:47:43  <peter1138> I just discovered the Draft feature... nice.
19:48:42  <peter1138> Ah but the list doesn't show Draft status.
19:50:13  <andythenorth> list?
19:50:17  *** Thedarkb-T60 has joined #openttd
19:50:39  <peter1138> PR list.
19:52:49  <andythenorth> eh I have FIRS uploaded from 2 accounts on bananas
19:53:01  <andythenorth> but I can't upload FIRS 3 from my account, only coop
19:53:06  <andythenorth> don't really understand that
19:54:44  <peter1138> Just turn it into a free-for-all.
19:54:53  <peter1138> Problem is, that person expects it to be curated.
19:56:56  <andythenorth> person is not native english speaker
19:57:01  <andythenorth> so I'm not just dismissing as a fuckwit
19:57:04  <andythenorth> but eh
19:57:32  <peter1138> Well, it's not a stupid request, it's just not what Bananas is.
19:57:53  <andythenorth> it's a confusing and inconsistent request
19:58:16  <andythenorth> I should probably stay out of it, I don't really have any use for bananas
20:05:32  *** Gja has joined #openttd
20:06:39  <peter1138> You don't?
20:08:03  <nielsm> bananas are useful for making desserts
20:08:17  <andythenorth> I just upload stuff
20:08:25  <andythenorth> I downloaded some pikka grfs years ago
20:08:46  <andythenorth> sometimes I have to test some savegame from GH or something
20:08:51  <andythenorth> then find all the missing content
20:09:00  <andythenorth> I don't really use grfs tbh
20:09:51  <peter1138> I used to always use them.
20:09:59  <peter1138> Now I just can't be bothered to set them up.
20:10:05  <peter1138> Even though it's easier than it ever was.
20:10:16  <peter1138> A GUI! Even for parameters! It's magic.
20:11:42  *** Gja has quit IRC
20:12:53  <andythenorth> I have 10
20:12:56  <andythenorth> I made 6 of them :P
20:22:41  <andythenorth> so station tiles with weird catchments peter1138? o_O
20:24:02  <peter1138> Non-rectangular?
20:24:04  <peter1138> Is it useful?
20:24:32  <Eddi|zuHause> make catchment area work the intuitive way that everyone thinks it does?
20:24:42  <peter1138> Yes
20:24:55  <Eddi|zuHause> also, make the game more euclidean
20:25:30  <peter1138> When do oil rigs appear?
20:25:42  <Eddi|zuHause> 1960? 70?
20:25:59  <Eddi|zuHause> somewhere in that range
20:26:12  <Eddi|zuHause> never at mapgen, though
20:26:12  <peter1138> Do they appear on new game during that date?
20:26:16  <peter1138> Hah!
20:26:31  <peter1138> Well, at least FFWD is... fast :)
20:27:01  <Eddi|zuHause> scenario editor? fund?
20:28:00  <andythenorth> I was just thinking bigger / smaller :P
20:28:52  <Eddi|zuHause> andythenorth: that is pretty meaningless as long as just the largest radius counts
20:29:07  <andythenorth> +1
20:29:33  <andythenorth> dunno how it would work anyway
20:29:39  <Eddi|zuHause> and if you want beautification tiles that don't increase area you got newobjects
20:29:52  <andythenorth> I was thinking something like, rail tiles are radius 1
20:30:03  <andythenorth> eye candy tiles get radius 20 or something
20:31:03  <andythenorth> need to figure out *something* so I can make use of industry > more cargos out
20:31:12  *** synchris has quit IRC
20:31:29  <andythenorth> stations are quite limiting there
20:33:40  <nielsm> random thought: would be cool if different railtypes (and roadtypes) could add their own icons to station signs
20:33:55  <peter1138> Hmm
20:33:55  <nielsm> so e.g. traditional rail and monorail could have different icons
20:34:02  <peter1138> That could be doable.
20:34:12  <nielsm> and the same for NRT
20:34:13  <andythenorth> no steam train icon? :o
20:34:31  <andythenorth> hmm, dump truck icon for HAUL
20:35:36  <peter1138> Hmm, yeah, it's doable, but these are text glyphs rather than sprites.
20:35:37  <nielsm> also, again I'm going to suggest having some kind of compressed map block storage that could be used anywhere
20:35:45  <peter1138> Just a little bit fiddly.
20:35:45  <nielsm> (which could move some map data out of map arrays even)
20:36:13  <nielsm> e.g. a compressed bitmap (either by eliding blank blocks or using RLE) of a station's catchment area
20:36:39  <nielsm> so you do a rough check for stations possibly in catchment, then check the bitmaps for each of those stations for accurate result
20:37:44  *** Thedarkb-T60 has quit IRC
20:38:00  <nielsm> or well, complex catchment areas with per-tile catchment could actually be calculated and cached on demand
20:38:29  <peter1138> I... I'm about to do that last thing anyway.
20:38:32  <Eddi|zuHause> each station gets a hashmap of which tiles it covers
20:38:38  <peter1138> Stations have tons of off-map storage anyway
20:40:00  <Eddi|zuHause> on industry production, you loop through each station and find a non-empty intersection between station area tiles and industry tiles
20:40:15  <Eddi|zuHause> on vehicle delivery you loop through all catchment area tiles
20:40:22  <Eddi|zuHause> or something along those lines
20:40:45  <Eddi|zuHause> it's neither crazy memory nor crazy runtime heavy
20:41:39  <peter1138> Yeah, I'm... about to do that ;)
20:41:46  *** Thedarkb-T60 has joined #openttd
20:41:59  <peter1138> Although I admit I was going to do an x,y array unless you wrote hashmap... D'oh.
20:42:12  <Eddi|zuHause> std::set?
20:42:49  <nielsm> nah std::set is probably not good
20:42:50  <Eddi|zuHause> i did 3 days worth of coding with STL containers, i'm now an expert
20:43:23  <peter1138> nielsm, I'll start off with whatever works, and then consider performance later.
20:43:33  <nielsm> for caching I think an RLE bitmap is the most efficient
20:43:49  <peter1138> Uhm.
20:44:01  <nielsm> in terms of cpu/memory balance
20:44:08  <Eddi|zuHause> what are we sending faxes or something? :p
20:44:15  <peter1138> Forget about space. Dedicated servers don't come with 1KB RAM...
20:44:15  <nielsm> a straight bitmap would be the fastest in straight cpu
20:44:41  <nielsm> yeah but if you have 4000 stations with large catchment areas now you're suddenly using rather much regardless
20:44:46  <Eddi|zuHause> i think CPU time is the more important one to optimize
20:45:00  <nielsm> also be wary of data structures that cause memory fragmentation
20:46:39  <peter1138> 4000 stations can't all cover the same area.
20:47:30  *** supermop_Home has quit IRC
20:50:10  <Eddi|zuHause> i don't see memory fragmentation becoming an issue. if the station area is modified, you can easly scrap the cache and rebuild it from scratch
20:50:42  <Eddi|zuHause> it only happens on user interaction, so can be a more expensive operation
20:52:37  *** HerzogDeXtEr1 has joined #openttd
20:53:20  <_dp_> hi! does anyone know why msvc here gives error C2061: syntax error: identifier 'Polyline'  ?
20:53:23  <_dp_> static bool FindPolyline(const Point &pt, const LineSnapPoint &start, Polyline *ret)
20:53:46  <_dp_> it's defined as a struct earlier in the same file and it compiles fine with g++
20:54:17  <nielsm> well I don't know if you suggested std::set as a joke, but it would get you a ton of tiny heap allocations (it's a balanced tree) so likely have poor cpu cache locality and cause potential trouble for the heap allocator if some of the elements are freed or moved around during building
20:54:35  <nielsm> _dp_ file and line?
20:55:14  <Eddi|zuHause> _dp_: is that the complete message?
20:55:46  <Eddi|zuHause> _dp_: almost always "syntax error"-style messages mean something went wrong BEFORE that point
20:56:07  <Eddi|zuHause> it's just at that point the compiler got confused enough to give up
20:56:39  <_dp_>
20:58:39  *** HerzogDeXtEr has quit IRC
20:58:51  <Eddi|zuHause> _dp_: could be somthing interfering from a MSVC-specific header
20:59:22  <_dp_> full compiler output:
20:59:43  <nielsm> you have an #include at line 968 well past the usual include block, try moving that
20:59:45  <_dp_> Eddi|zuHause, yeah, I though of that but couldn't find anything
21:00:00  <nielsm> and another later too
21:00:16  <_dp_> also I compiled 1.8 version with studio before
21:00:35  <Eddi|zuHause> _dp_: have you tried just the polyline patch individually?
21:01:12  <nielsm> viewport.cpp(2920): warning C4551: function call missing argument list
21:01:21  <nielsm> 2920: Polyline polyline;
21:01:31  <nielsm> it absolutely thinks Polyline is the name of a function, not your struct
21:01:39  <ST2> _dp_: I've also had issues with msvc project files, but sidework made me postpone this :|
21:02:32  <_dp_> Eddi|zuHause, no but it's a bit modified patch already, don't have it separate
21:02:58  <nielsm>
21:03:00  <nielsm> likely that one
21:03:04  <_dp_> also experimenting with azure so it's not quite easy to try random guesses :(
21:03:42  <_dp_> since it don't have studio myself and can only run pipelines
21:04:15  <_dp_> nielsm, hm, interesting
21:04:32  <_dp_> nielsm, I'll try renaming it than, thanks!
21:04:36  <Eddi|zuHause> definitely move those stray #includes
21:04:49  <Eddi|zuHause> so your struct definition will happen later
21:05:58  <Eddi|zuHause> (and people wonder why we didn't include some patches in master)
21:06:22  <Eddi|zuHause> (after all, they were "well tested" for years)
21:06:33  <_dp_> Eddi|zuHause, stray includes come from vanilla openttd btw
21:07:17  <_dp_> well, it's is tested... as long as it compiles :p
21:07:52  <peter1138> Okay, so with #7230
21:07:53  <nielsm> hmm true yes, those includes are in master
21:08:04  <peter1138> The question is... *should* the 90 degree checks be moved outside of the pathfinder?
21:08:31  <peter1138> forbidding 90 degree turns is basically a feature OF the pathfinder, so...
21:09:05  <nielsm> it looks like that's the only call site of that function
21:09:15  <nielsm> and where it's used is pretty much already pathfinding code
21:09:19  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7230: Fix #7226: No ship track due to "forbid 90 deg turns"-> Do not call pathfinders.
21:09:32  <peter1138> Hm.
21:09:53  <Eddi|zuHause> peter1138: really, ships shouldn't forbit 90° turns
21:10:03  <Eddi|zuHause> there is no sane reason for doing it
21:10:03  <peter1138> Eddi|zuHause, that isn't the point
21:11:43  * peter1138 rebases his patch which removes it for ships.
21:11:44  <Eddi|zuHause> the diff looks sane though
21:13:07  <Eddi|zuHause> but why do we need both a DiagDir and a TrackDir? that seems redundant
21:14:47  <peter1138> TrackDir identifies upper/left or lower/right track bits.
21:15:12  <peter1138> DiagDir is just the 4 directions.
21:15:21  <peter1138> So they are not equivalent.
21:16:17  <Eddi|zuHause> i mean, you could infer the diagdir from the trackdir
21:16:37  <nielsm> gnight
21:17:27  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN opened pull request #7232: Change: Don't apply forbid 90 deg turn settings to ships.
21:17:33  <peter1138> ^^
21:17:44  <Eddi|zuHause> :)
21:19:20  <peter1138> Better comment.
21:19:50  <peter1138> Looks like OPF and NPF didn't forbid 90 deg turns anyway?
21:19:59  <peter1138> Anything in NPF mentions trains.
21:20:03  <peter1138> And OPF just doesn't.
21:20:09  <Eddi|zuHause> no idea
21:21:02  <peter1138> Hmm, actually forbidding 90 deg turns now makes ships faster, as on-the-spot rotation makes it stop.
21:21:35  <peter1138> Hmm, I guess increase penalty for 90 degree turns?
21:24:39  *** nielsm has quit IRC
21:29:50  <peter1138> Ok, where's the function to get Direction from Trackdir, anyway? :/
21:33:14  *** andythenorth has quit IRC
21:34:19  *** gelignite has quit IRC
21:34:21  <Samu> removing opf?
21:34:27  <peter1138> No.
21:34:48  <Samu> removing 90 degrees?
21:35:36  <Samu> npf forbids 90 deg
21:35:41  <peter1138> remove forbid 90 degrees.
21:35:43  <peter1138> Where?
21:35:48  <Samu> it was only opf that didn't
21:35:52  <peter1138> Onlly removing it for ships, not trains.
21:36:12  <Samu> it's ... hmm somewhere in npf, driveable trackbits i think
21:39:57  <peter1138> Oh, of course. I already patched that out!
21:40:11  <peter1138> Only checks for TRANSPORT_RAIL :)
21:42:21  <Samu> then that was it
21:42:45  <peter1138> Yeah, sorry. Forgot I'd taken care of it.
21:44:56  <Eddi|zuHause> peter1138: something about "trackdir to exitdir" pops into my head
21:45:52  <peter1138> Nah, that's a DiagDir
21:51:46  <Eddi|zuHause> that's what we wanted, i thought?
21:54:59  <peter1138> No, I wanted a Direction.
21:56:34  *** HerzogDeXtEr1 has quit IRC
21:57:14  <peter1138> Hmm, well, adding a penalty doesn't seem to work :/
21:59:49  *** frosch123 has quit IRC
22:06:18  *** Wolf01 has quit IRC
22:19:30  *** Flygon has joined #openttd
22:26:17  *** Pikka has joined #openttd
22:34:09  <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7230: Fix #7226: No ship track due to "forbid 90 deg turns"-> Do not call pathfinders.
22:41:22  *** sla_ro|master has quit IRC
22:43:08  <DorpsGek_II> [OpenTTD/website] andreszs commented on issue #48:
22:48:38  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7230: Fix #7226: No ship track due to "forbid 90 deg turns"-> Do not call pathfinders.
22:49:08  <peter1138> Hmm, so the penalty *is* working...
22:49:12  <peter1138> Just not on the last segment.
22:50:32  <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7232: Change: Don't apply forbid 90 deg turn settings to ships.
22:53:06  <Samu> oh no... rip 90 deg
22:54:29  *** Supercheese has joined #openttd
23:00:09  <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7224: Change: Use selected group as parent when creating a new group.
23:17:46  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7224: Change: Use selected group as parent when creating a new group.
23:21:24  <peter1138> So remind me under what circumstances is forbid 90 degree turns for ships harmful?
23:32:07  <Samu> it's ok,
23:32:21  <Samu> makes my friendly rivers complete
23:33:19  <peter1138> What?
23:33:55  <Samu> lock friendly rivers
23:34:15  <peter1138> Does forbidding 90 degree turns help that someho?
23:34:17  <peter1138> +w
23:36:30  <peter1138> I'd think permitting 90 degree turns would help it.
23:55:37  <Samu> permiting helps
23:58:06  *** supermop_Home has joined #openttd
23:58:22  <peter1138> Well then.
23:58:34  <peter1138> Removing the option for ships means it would always be permitted.
23:59:10  <glx> forbit 90° was a train thing anyway
23:59:17  <peter1138> Originally, yes.
23:59:17  <glx> *forbid
23:59:45  <glx> and it's really the only transport type where it makes sense

Powered by YARRSTE version: svn-trunk