Config
Log for #openttd on 3rd March 2019:
Times are UTC Toggle Colours
00:00:17  <TrueBrain> and feel free to move your MT/MD thing into the branch if you picked up those comments of mine (or even feel free to ignore some :P)
00:00:24  <TrueBrain> don't forget to close the PR after ;)
00:00:27  <TrueBrain> for now, bedtime for me
00:00:33  <glx> ok, I just converted source.list to test anyway
00:00:43  <TrueBrain> I saw :) It is a good step forward :)
00:06:22  *** Samu has joined #openttd
00:06:49  <Samu> can I talk?
00:07:40  *** Flygon has joined #openttd
00:07:42  <nnyby> Samu: lol yes
00:08:10  <DorpsGek_II> [OpenTTD/OpenTTD] Berbe commented on pull request #7286: Add #2155: newheightmapgame command https://git.io/fhAd5
00:09:32  <DorpsGek_II> [OpenTTD/OpenTTD] Berbe commented on pull request #7286: Add #2155: newheightmapgame command https://git.io/fhAdF
00:11:35  <Samu> im testing https://github.com/OpenTTD/OpenTTD/pull/7298
00:12:01  <Samu> TrueBrain, requested it
00:13:12  <glx> but you should explain on the PR, not here
00:14:01  <glx> even if people are present when you say it, they may forget
00:18:59  <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #7190: Fix #7188: AI instance crash when reloading AI in a server, and an AI… https://git.io/fhAFe
00:19:27  <DorpsGek_II> [OpenTTD/OpenTTD] glx22 updated pull request #7270: Introduce CMake (and removing all other project-related code) https://git.io/fhbqc
00:49:53  *** snail_UES_ has joined #openttd
00:54:11  <DorpsGek_II> [OpenTTD/OpenTTD] glx22 commented on pull request #7270: Introduce CMake (and removing all other project-related code) https://git.io/fhAFs
01:11:05  <DorpsGek_II> [OpenTTD/OpenTTD] glx22 approved pull request #7225: Add: Various AI/GS functions that may be useful. https://git.io/fhAFl
01:15:29  *** Gustavo6056 has joined #openttd
01:19:14  <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick opened pull request #7312: Feature: Increased aircraft breakdown rate based on travelled tiles. https://git.io/fhAFR
01:20:02  *** Gustavo6046 has quit IRC
01:20:02  *** Gustavo6056 is now known as Gustavo6046
01:24:55  *** Gustavo6046 has quit IRC
01:26:10  <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #7312: Feature: Increased aircraft breakdown rate based on travelled tiles. https://git.io/fhAFR
01:26:37  *** Gustavo6046 has joined #openttd
01:27:15  <Samu> the evil commit checker
01:27:25  *** Gustavo6046 has quit IRC
01:29:17  <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #7312: Feature: Increased aircraft breakdown rate based on travelled tiles. https://git.io/fhAFR
01:31:53  <Samu> why is it failing now? :(
01:32:53  *** Gustavo6046 has joined #openttd
01:40:24  <glx> it was not the commit checker ;)
01:41:56  <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick opened pull request #7313: Change: Pause running costs on standard road stops. https://git.io/fhAFw
01:46:09  *** Progman has quit IRC
01:59:16  *** Beerbelott1 has joined #openttd
02:04:57  <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z commented on pull request #7313: Change: Pause running costs on standard road stops. https://git.io/fhAFD
02:06:41  *** Beerbelott has quit IRC
02:19:54  *** keoz has quit IRC
02:23:51  <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick opened pull request #7314: Change: Separate forbid 90 deg for trains and ships https://git.io/fhAFd
02:26:34  *** HerzogDeXtEr has quit IRC
02:26:34  <Samu> faster server autosaves ... i don't think you want this
02:27:09  <Samu> considering save empty script was rejected
02:29:17  <Samu> (dis)allow large aeroplane on short runway
02:29:23  <Samu> hmm...
02:31:17  <Samu> https://www.tt-forums.net/viewtopic.php?p=1193905#p1193905
02:31:30  <Samu> it was controversial
02:34:37  <Samu> I call it the electric rails for aircraft
02:34:54  <Samu> similar in purpose
03:11:33  *** debdog has joined #openttd
03:11:52  <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick opened pull request #7315: Feature: Move players to company accepting take-over offer. https://git.io/fhAbG
03:14:59  *** D-HUND has quit IRC
03:16:16  <Samu> https://www.tt-forums.net/viewtopic.php?p=1183448#p1183448 also controversial :|
03:37:52  *** Supercheese has quit IRC
03:38:13  *** Supercheese has joined #openttd
03:44:51  *** Beerbelott1 is now known as beerbelott
03:45:14  *** beerbelott is now known as Beerbelott
03:52:20  *** tokai has joined #openttd
03:52:20  *** ChanServ sets mode: +v tokai
03:59:04  *** tokai|noir has quit IRC
04:04:03  *** Wormnest has quit IRC
04:30:45  *** glx has quit IRC
04:33:35  *** Samu has quit IRC
04:46:17  <DorpsGek_II> [OpenTTD/OpenTTD] Berbe updated pull request #7286: Add #2155: newheightmapgame command https://git.io/fhNZl
04:57:29  <DorpsGek_II> [OpenTTD/OpenTTD] Berbe updated pull request #7286: Add #2155: newheightmapgame command https://git.io/fhNZl
05:04:26  *** Thedarkb-X40 has quit IRC
05:05:34  <DorpsGek_II> [OpenTTD/OpenTTD] Berbe updated pull request #7286: Add #2155: newheightmapgame command https://git.io/fhNZl
05:06:26  *** Thedarkb-X40 has joined #openttd
05:08:52  <Beerbelott> https://dev.azure.com/openttd/OpenTTD/_build/results?buildId=1728&view=results
05:09:03  <Beerbelott> Fail: /azure-pipelines-ci.yml:  Unable to find file /azure-pipelines/templates/windows-build.yml in  repository self using ref refs/pull/7286/merge and commit  b90b99b5c3bfb3c4ee1e9e90e47537f77c56f698: Not Found
05:09:21  *** Beerbelott has left #openttd
05:35:23  *** supermop_Home has quit IRC
06:10:25  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN closed pull request #7313: Change: Pause running costs on standard road stops. https://git.io/fhAFw
06:10:26  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7313: Change: Pause running costs on standard road stops. https://git.io/fhANd
06:13:40  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #7261: Add: Road vehicle path cache. https://git.io/fhAR7
06:21:56  *** snail_UES_ has quit IRC
06:29:24  *** Alberth has joined #openttd
06:29:24  *** ChanServ sets mode: +o Alberth
06:29:51  <Alberth> morninks
06:45:51  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7261: Add: Road vehicle path cache. https://git.io/fhFw4
06:46:00  <peter1138> morning
06:46:17  <peter1138> Let's see if the CI bothers to build it this time :p
06:46:23  <peter1138> Ah, looks better.
06:52:40  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7312: Feature: Increased aircraft breakdown rate based on travelled tiles. https://git.io/fhAAf
06:54:10  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7314: Change: Separate forbid 90 deg for trains and ships https://git.io/fhAAk
06:56:58  *** Wormnest has joined #openttd
06:57:43  *** blelch has joined #openttd
06:57:47  <blelch> Hi!
06:58:03  <blelch> How do I 'quit'? I can't seem to find a button/option for that
06:58:40  <blelch> oh; nevermind
06:58:44  <blelch> it was under Save
06:59:06  *** Thedarkb-X40 has quit IRC
07:00:40  *** blelch has quit IRC
07:00:58  *** blelch has joined #openttd
07:05:02  *** Wormnest has quit IRC
07:09:52  *** Supercheese has quit IRC
07:14:32  <blelch> When I 'exit' the game, my desktop freezes for a while with everything displaced
07:14:46  <blelch> it doesn't exit cleanly
07:18:00  <peter1138> Running fullscreen at a different resolution?
07:38:21  *** nielsm has joined #openttd
07:43:52  *** sla_ro|master has joined #openttd
07:48:54  *** keoz has joined #openttd
08:06:38  *** agentw4b has joined #openttd
08:08:43  <peter1138> Hi
08:09:50  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN opened pull request #7316: Change: Always report error when ordering a road vehicle to wrong type of road stop. https://git.io/fhAxC
08:10:41  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7272: Change: [NPF] Add path cache for ships. https://git.io/fhAxl
08:11:05  <peter1138> Off for the day, bye.
08:15:42  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh merged pull request #7225: Add: Various AI/GS functions that may be useful. https://git.io/fh7Gz
08:24:39  *** gelignite has joined #openttd
08:36:32  *** andythenorth has joined #openttd
08:37:03  <Alberth> o/
08:37:05  <andythenorth> moin
08:41:17  <blelch> peter1138: yes..
08:46:22  <Alberth> switching screen size means the OS needs to rebuild the screen, changing memory layout of the screen, and querying all applications to redraw themselves. That takes time, especially if they have to be retrieved from the disk
08:47:21  <Alberth> in the mean time, it shows the re-organized memory of the screen, but the applications haven't painted their part yet, so you get a nice colourful mess for a while
08:49:42  <nielsm> okay, maybe derail yet some more valleys
08:49:47  <nielsm> and get the steam train going this time
08:50:30  <Alberth> derail valleys?  :)
08:50:33  <andythenorth> so I need this, but for regular shell https://github.com/JamesRandall/Vsts-GitHub-Pages-Publish/blob/master/buildAndReleaseTask/publish.ps1
08:50:49  <andythenorth> and somehow it has to get the github creds safely from an Azure Service Connection
08:50:58  * andythenorth has no suitable emoji
08:52:14  <andythenorth> planetmaker: do we want to keep bundles?
08:52:27  <andythenorth> (as a concept)
09:00:46  <nielsm> hmm should I maybe stream this valley thing? I probably won't be commentating on it and may just tab out at random times though
09:13:14  *** andythenorth has quit IRC
09:17:27  *** Progman has joined #openttd
09:42:46  <blelch> Alberth: okay! I set it to the right res... lemme see if it still happens
09:49:25  *** Thedarkb-T60 has quit IRC
09:55:48  <nielsm> lol RIGHT on time! https://0x0.st/zoZI.jpg
10:02:45  <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7314: Change: Separate forbid 90 deg for trains and ships https://git.io/fhApM
10:03:33  <TrueBrain> you go girl! :P
10:05:18  <TrueBrain> peter1138: what are the odds of making https://github.com/OpenTTD/OpenTTD/pull/7232 a non-draft?
10:05:46  <Alberth> wont be back today (for his value of day)
10:07:19  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7314: Change: Separate forbid 90 deg for trains and ships https://git.io/fhApy
10:07:37  <TrueBrain> ghehe :) Well, I hope he has a backlog :P
10:08:36  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7232: Change: Don't apply forbid 90 deg turn settings to ships. https://git.io/fhApH
10:08:58  <nielsm> pro shunting technique: stand on the roof of the shunter when backing up
10:11:48  <TrueBrain> haha
10:11:58  <TrueBrain> hmm .. can you take over companies in MP that are controlled by other players?
10:12:02  <TrueBrain> thought that was never possible :P
10:12:22  <nielsm> only if they bankrupt
10:12:23  <Eddi|zuHause> TrueBrain: on bankupcy
10:12:27  <TrueBrain> goofy
10:12:49  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7316: Change: Always report error when ordering a road vehicle to wrong type of road stop. https://git.io/fhApF
10:13:19  <TrueBrain> https://github.com/OpenTTD/OpenTTD/pull/7315 <- this sounds like the wrong fix .. and I am not a big fan of yet-another-setting
10:13:37  <TrueBrain> the way I see this more useful, is if in the bankrupt dialog you can say: yes, yes + players, no
10:14:04  <TrueBrain> how that PR is done, feels like an anti-feature with a lot of unexpected side-results :P
10:14:30  <TrueBrain> guess the real life scenario of: if you take over the company, depending on the company, you might or might not want to take over the personal too :P
10:14:42  <TrueBrain> anyone agree/disagree on that statement?
10:15:51  <Eddi|zuHause> i thought we discussed that feature in a forum thread a few years ago, with the outcome: "if someone bought the company, they would obviously oust the manager that made it bankrupt"
10:16:40  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain closed pull request #7312: Feature: Increased aircraft breakdown rate based on travelled tiles. https://git.io/fhAFR
10:16:41  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7312: Feature: Increased aircraft breakdown rate based on travelled tiles. https://git.io/fhApx
10:17:03  <TrueBrain> Eddi|zuHause: yeah ... I guess in MP you can be "the nice guy"
10:17:40  <Eddi|zuHause> TrueBrain: well, you could have a feature to invite spectators into your company
10:18:16  <Eddi|zuHause> don't even have to give them your password that way
10:18:42  <TrueBrain> I like that
10:19:16  <Eddi|zuHause> (we might want to revisit how passwords work in that step)
10:19:57  *** blelch has left #openttd
10:20:39  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7315: Feature: Move players to company accepting take-over offer. https://git.io/fhAhe
10:20:40  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain closed pull request #7315: Feature: Move players to company accepting take-over offer. https://git.io/fhAbG
10:21:06  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain requested changes for pull request #7306: Add: Chrono based TIC() and TOC() in debug https://git.io/fhAhJ
10:21:51  <TrueBrain> it is annoying how many PRs he makes in a day, without contributing to PRs of other people .. this is unbalanced ..
10:21:59  *** HerzogDeXtEr has joined #openttd
10:25:35  <nielsm> it's a lot of work mentoring someone who can write functioning code, but not great code, and does not have the experience/education to reason about code and recognize good/bad code and program structure
10:25:46  <TrueBrain> Eddi|zuHause: https://github.com/OpenTTD/OpenTTD/pull/7302 <- so this makes it that planes still crash when they are big and the airport is not, even if they have the crash-setting off? And only with a cheat-on it is prevented? As that is exactly what I expect already would happen :D
10:25:57  <TrueBrain> nielsm: yup
10:26:25  <Eddi|zuHause> TrueBrain: yes, that is what that does, and also what i expected.
10:26:47  <Eddi|zuHause> TrueBrain: we might want to explain that better in the settings dialog
10:27:39  <TrueBrain> that is a change in a translation string, right?
10:27:58  <TrueBrain> 3276 <- feels random; I dont like magic values ..
10:28:01  <TrueBrain> 0xCCC .. not much better
10:28:03  <TrueBrain> hmm
10:28:31  <TrueBrain> 0x4000 / 20, I guess
10:28:36  <TrueBrain> but that is not much better :D
10:28:37  <nielsm> 3276 = 32768/10
10:28:47  <Eddi|zuHause> TrueBrain: it's the value that has been there for years. original was 0x10000/20
10:28:51  *** andythenorth_ has joined #openttd
10:29:02  <TrueBrain> Eddi|zuHause: I understand; is no reason to leave it there now :D
10:29:07  <TrueBrain> @calc 1<<22
10:29:07  <DorpsGek> TrueBrain: Error: Something in there wasn't a valid number.
10:29:09  <TrueBrain> grr
10:29:18  <Eddi|zuHause> @calc 2**22
10:29:18  <DorpsGek> Eddi|zuHause: 4194304
10:29:24  <TrueBrain> ty :)
10:29:33  <TrueBrain> @calc 3276 / (2**22)
10:29:33  <DorpsGek> TrueBrain: 0.000781059265137
10:29:47  <TrueBrain> that is a small odd?
10:29:58  <Eddi|zuHause> it seems low, but it is rerun multiple ticks in a row
10:30:05  <TrueBrain> ah :)
10:30:05  <TrueBrain> k
10:30:28  <Eddi|zuHause> multiple aircraft ticks, so might depend on plane speed setting
10:30:42  <TrueBrain> what an odd function :)
10:30:49  <andythenorth_> i guess I have some puzzles
10:31:00  <Eddi|zuHause> yeah, but i didn't feel like completely rewriting it :p
10:31:22  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7302: Change: make crash chance at short runway independent of plane crash … https://git.io/fhAhc
10:31:59  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7293: Add: No plane crashes unless runway is too short option https://git.io/fhAhC
10:32:00  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain closed pull request #7293: Add: No plane crashes unless runway is too short option https://git.io/fhNy3
10:32:03  <andythenorth_> TL:DR; what’s the purpose/future of coop devzone?
10:32:22  <andythenorth_> it has ~100 projects
10:32:51  <andythenorth_> but it’s a maintenance burdeb
10:33:04  <TrueBrain> it exists out of a necessity in times things like GH did not exist (yet)
10:33:14  <Eddi|zuHause> andythenorth_: it seems like fragil undermaintained infrastructure
10:33:20  <andythenorth_> should we just sack it?
10:33:23  <Eddi|zuHause> no
10:33:33  <andythenorth_> because...?
10:33:38  <Eddi|zuHause> you should teach people how to migrate away from it
10:33:45  <nielsm> how many projects are active on it?
10:33:52  <andythenorth_> unknown
10:33:54  <nielsm> (e.g. received commits within the last 1 year)
10:34:18  <andythenorth_> but there are programatic ways to detect that
10:34:21  <TrueBrain> Eddi|zuHause: I milestoned your patch for 1.10, as I think it is unwise to put it in 1.9 at this stage :)
10:34:31  <Eddi|zuHause> that is fine
10:34:38  <andythenorth_> there was a script for devzone activity
10:34:47  <TrueBrain> andythenorth_: indeed, migrate people away till the activity is too low :)
10:35:01  <Eddi|zuHause> nielsm: in NewGRF land, that might be a bad way to measure "active"
10:35:10  <TrueBrain> the thing with these things: once started, you can never go back :)
10:35:14  <andythenorth_> well I am not the maintainer, but otherwise yes
10:35:42  <Eddi|zuHause> and even if they're not "active", it's way too valuable as an archive
10:35:45  <andythenorth_> so the offering of coop was simplicity
10:35:59  <Eddi|zuHause> to just go "so long, and thanks for all the fish"
10:36:04  <andythenorth_> but the alternatives are much less simple
10:36:07  <andythenorth_> so far
10:36:22  <TrueBrain> nielsm: any chance you can fix up https://github.com/OpenTTD/OpenTTD/pull/7298 for the few things requested? Would be nice to have it in 1.9 I guess :)
10:37:02  <andythenorth_> so are we abandoning the offer of simple service for grfs?
10:37:03  <Eddi|zuHause> andythenorth_: the benefits, at least for my perspective, were always: "i want to play with trains, leave all that technical stuff to more experienced specialists"
10:37:09  <nielsm> a maybe acceptable roadmap would be something like offer a feature to mark a project "closed"/"moved", inform everyone they should be moving out, after a while put everyone on read-only, and later after that pack everything into archive files and only offer big-pack downloads
10:37:12  <andythenorth_> or rolling a new one?
10:37:39  <TrueBrain> andythenorth_: template it on GitHub
10:37:49  * nielsm has not yet derailed
10:38:04  <Eddi|zuHause> nielsm: so false advertising?
10:38:25  <TrueBrain> https://github.com/OpenTTD/OpenTTD/pull/7294 <- is it me, or is this something more for a patchpack?
10:38:31  <TrueBrain> I don't see the use of having 100000 settings in OpenTTD
10:39:10  <nielsm> TrueBrain, so how far towards https://dhh.dk/2012/rails-is-omakase.html do you lean? :P
10:39:20  <andythenorth_> I am -1 to 7294
10:39:34  <andythenorth_> more combinatorial shit
10:40:00  <Eddi|zuHause> if you don't want level crossings over your rails, use a railtype that forbids it?
10:40:15  <TrueBrain> nielsm: lol :) What a text :P
10:40:40  <TrueBrain> the one thing I never liked in OpenTTD, that for everything we added a setting
10:40:44  <nielsm> Eddi|zuHause sounds like the most reasonable yes
10:40:45  <TrueBrain> new PF? Lets make a new settings
10:40:48  <TrueBrain> New idea? MORE SETTINGS
10:40:53  <TrueBrain> people are drowning in settings
10:40:56  <TrueBrain> same to the UI btw
10:41:03  <TrueBrain> when I open OpenTTD now, I am lost in the complexity of the UI
10:41:06  <TrueBrain> so many buttons I can click
10:41:09  <TrueBrain> andi for what ...
10:41:32  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh closed pull request #7294: Add: Allow or disallow company level crossings as a game setting https://git.io/fhNy2
10:41:33  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7294: Add: Allow or disallow company level crossings as a game setting https://git.io/fhAhu
10:41:40  <TrueBrain> awh, nielsm beat me to it :(
10:41:58  <TrueBrain> I was closing stuff, ffs :P :D <3 :)
10:43:32  <andythenorth_> objectives on wiki say we prefer content to settings
10:43:40  <TrueBrain> https://github.com/OpenTTD/OpenTTD/pull/7287 <- I am always so-so with these things ..
10:45:00  <TrueBrain> 1.9 or 1.10 for #7287?
10:45:27  <nielsm> seems pretty low-risk to me
10:46:01  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain approved pull request #7287: Change: Allow vehicle group names to be non-unique. https://git.io/fhAhV
10:46:22  <Eddi|zuHause> i'm usually on the "don't rush it" side..
10:46:39  <Eddi|zuHause> but i also never get anything done... :p
10:46:51  <nielsm> so RC is next weekend?
10:47:16  <TrueBrain> nielsm: LordAro wanted today .. I dont care :P
10:47:59  <TrueBrain> this bridge stuff ....
10:48:05  <TrueBrain> too many work in there ..
10:48:08  <TrueBrain> what do we do about that ..
10:48:33  <TrueBrain> storing the townid in map of course solves a lot of things .. but .. do we want that?
10:49:39  <TrueBrain> https://github.com/OpenTTD/OpenTTD/pull/7284 is small and elegant, but still not the real solution, I guess
10:50:24  <Eddi|zuHause> wasn't there a "don't build bridges before the first house" patch?
10:51:32  <TrueBrain> there is?
10:51:45  <TrueBrain> even with that, I like #7284, as it is a bit more clever than to look for the nearest town :)
10:51:55  <TrueBrain> not perfect, but a nice bridge (pun intended) between the solutions, I guess
10:52:13  <nielsm> I like the "no bridges before first house" idea too
10:52:23  <TrueBrain> where is it?
10:52:32  <nielsm> I mean, if the town is not viable _without_ a bridge, that was a pretty bad town location
10:52:54  <TrueBrain> but even with such patch, #7284 fixes a huge performance issue
10:52:57  <TrueBrain> so is that worth it?
10:53:13  <TrueBrain> than we have https://github.com/OpenTTD/OpenTTD/pull/7282, which seems something for the long-term more ..
10:54:36  <nielsm> this might make you derail: https://0x0.st/zoNN.jpg
10:54:51  <TrueBrain> lol
10:55:15  <Eddi|zuHause> well, if the short-term solution doesn't block the long-term one it should be fine?
10:55:16  <TrueBrain> I cannot find a PR that does "no bridge before first house"
10:55:58  <nielsm> I think that was an alt solution on samu's pr for a while
10:56:14  <Eddi|zuHause> [Dienstag, 26. Februar 2019] [15:54:58 CET] <peter1138> I added "if (t->population == 0) return false;" ... first line of the function.
10:56:29  <TrueBrain> Eddi|zuHause: lol .. so yeah, that is not a PR
10:56:34  <TrueBrain> okay, you know what, lets delay all this to 1.10
10:57:22  *** andythenorth_ has quit IRC
10:57:29  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7284: Fix #7043, Fix #7274: Delete town owned bridge based on adjacent tile ownership, not nearest town. https://git.io/fhAh1
10:57:37  *** andythenorth_ has joined #openttd
10:57:46  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #7298: Fix multiplayer emergency save https://git.io/fhAJ2
10:58:09  <TrueBrain> awh, I liked the ALT+9
10:58:12  <TrueBrain> owh well, this works too :)
10:58:21  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain approved pull request #7298: Fix multiplayer emergency save https://git.io/fhAhM
10:59:05  <andythenorth_> newgrf editing directly in openttd?
10:59:20  <andythenorth_> then just pickle the memory state?
10:59:29  <Eddi|zuHause> can't see that working out...
10:59:39  <TrueBrain> hmm, I cannot filter the draft PRs in the overview? Odd
10:59:41  <nielsm> could also make force desync a console command instead
10:59:48  <andythenorth_> stop pissing around with abstractions?
10:59:48  <nielsm> much less accidentally hittable
11:00:19  <Eddi|zuHause> nielsm: but then that should also apply to crash
11:00:26  <andythenorth_> funny story: we just removed the ‘crash the app’ view at work this week
11:00:27  <TrueBrain> ALT+0 or ALT+9 .. they both make you cry .. so I didnt mind
11:00:29  <TrueBrain> but meh ..
11:00:32  <TrueBrain> it is what it is :)
11:01:04  <TrueBrain> an oldie: https://github.com/OpenTTD/OpenTTD/pull/6931 <- yea or nay?
11:01:30  <nielsm> I'm not at all sure what the state of it is
11:01:32  <TrueBrain> I understand what they try to fix, but is it a fixable thing ..
11:01:50  <nielsm> but in general I still think the idea is bad
11:01:58  <Eddi|zuHause> it's a "it's-fixable-but-you're-trying-too-hard"
11:01:58  <andythenorth_> it’s a real issue
11:02:14  <andythenorth_> the problem is likely the author
11:02:27  <andythenorth_> the issue is stupid and annoying
11:02:52  <TrueBrain> so the problem is real but the solution is wrong?
11:02:55  <TrueBrain> or what are we saying here?
11:03:01  <Eddi|zuHause> yes
11:03:18  <andythenorth_> there will be a low trust in the results of that PR
11:03:30  <andythenorth_> the problem is minor, but real
11:03:36  <Eddi|zuHause> as in "use these 5 lines that are close enough instead of these 30 lines that are fiddling with individual straws"
11:03:54  <andythenorth_> and the kind of thing we should be capable of solving
11:04:31  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh merged pull request #7287: Change: Allow vehicle group names to be non-unique. https://git.io/fhNZo
11:04:44  <andythenorth_> circ tile search when placing a house or something
11:04:55  <andythenorth_> or fix it in newgrf
11:05:22  <andythenorth_> if I had more andythenorths I would make a house set that fixes it
11:06:07  <andythenorth_> I already fixed industries doing similar things
11:06:18  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #6931: Change: Prevent town growth from blocking ships https://git.io/fhAhH
11:06:19  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain closed pull request #6931: Change: Prevent town growth from blocking ships https://git.io/fhsRY
11:06:47  <TrueBrain> so how is https://github.com/OpenTTD/OpenTTD/pull/6965 going?
11:07:17  <TrueBrain> feels done? Not sure what it is waiting/blocking on
11:07:54  <andythenorth_> it’s frigging onerous to test
11:08:14  <andythenorth_> needs playing for multiple years on multiple maps
11:08:37  <andythenorth_> but
11:08:38  <Eddi|zuHause> that's why it should have been in a beta so people can give feedback (which they never do)
11:08:52  <andythenorth_> fixing the broken part is valid, no?
11:09:01  <TrueBrain> so lets ship it in 1.10 ;)
11:09:07  <andythenorth_> it will just cause some downstream noise
11:09:25  <andythenorth_> 1.10
11:09:26  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7029: #6315 Rail fences in snow or desert https://git.io/fhAh5
11:10:22  <TrueBrain> https://github.com/OpenTTD/OpenTTD/pull/7084 <- I am not sure this will ever make it in .. near impossible to review .. but it might be good
11:10:25  <TrueBrain> we need someone that dig into that .. meh
11:11:11  <Eddi|zuHause> yeah, seems way too big
11:11:18  <andythenorth_> leave it open, and don’t look at it
11:11:20  <Eddi|zuHause> also not my area
11:11:47  <andythenorth_> UI design does not go well when done by inexperienced designers
11:11:53  <andythenorth_> who lack empathy
11:12:07  <andythenorth_> and are solving a very specific niche personal goal
11:12:13  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7184: Change: Distribute cargo to multiple stations or industries https://git.io/fhAhb
11:12:35  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh merged pull request #7298: Fix multiplayer emergency save https://git.io/fhAJ2
11:12:36  <andythenorth_> the UI is already high friction
11:12:42  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh closed issue #7280: Emergency netsave on desync saves title game https://git.io/fhbFQ
11:12:44  <TrueBrain> andythenorth_: the "leave it open" means it will be there for ever .. as it keeps on getting rebased ;)
11:13:15  <andythenorth_> well...there’s a lot of effort in that WIP
11:13:18  <andythenorth_> dunno
11:13:32  <andythenorth_> how many parades do we want to piss on?
11:13:46  <TrueBrain> I want a healthy list of PRs
11:13:50  <andythenorth_> ok
11:13:54  <TrueBrain> not a list of "we are too scared to touch tme so we don't"
11:14:02  <Eddi|zuHause> TrueBrain: can we adjust the default filter options when viewing the "PR" tab to exclude WIP?
11:14:07  <TrueBrain> breaking some eggs from time to time is not the worst
11:14:09  * andythenorth_ has had a week of ripping plasters off one way or the other
11:14:22  <TrueBrain> Eddi|zuHause: I want to filte rout the draft PRs, but I havent found out how yet :(
11:14:26  <andythenorth_> broken eggs Mon-Fri
11:14:52  <andythenorth_> all out of egg breaking energy :p
11:15:02  <TrueBrain> that is why I was doing it :)
11:15:06  <TrueBrain> I had some left over from this week :P
11:15:12  <andythenorth_> it’s a kw in search no?
11:15:14  <TrueBrain> okay, 3 entries for 1.9 left
11:15:42  <nielsm> taking a look at https://github.com/OpenTTD/OpenTTD/pull/7288 now
11:16:13  <andythenorth_> peterer is such a spammer pf PRs :)
11:16:29  <Eddi|zuHause> TrueBrain: apparently there's a "no:something" filter, not sure how it works
11:16:48  <andythenorth_> the filters are good, once you learn them
11:17:00  <andythenorth_> takes a bit of effort
11:17:20  <andythenorth_> filtering out specific author is what I do most
11:17:30  <Eddi|zuHause> doesn't seem like the right one
11:17:48  <Eddi|zuHause> andythenorth_: what string do you use for that?
11:17:58  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on issue #7062: Ship pathfinders ignore the max order distance https://git.io/fhAhx
11:18:13  <andythenorth_> something like -author:name
11:18:16  <andythenorth_> iirc
11:18:25  <Eddi|zuHause> oh, -
11:18:28  <andythenorth_> on phone, cba to try
11:18:36  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on issue #6922: Replace ICU ParagraphLayout with something else? https://git.io/fhAhp
11:18:55  *** andythenorth_ has quit IRC
11:19:10  <Eddi|zuHause> TrueBrain: so "-is:draft"?
11:19:10  *** andythenorth_ has joined #openttd
11:19:46  <TrueBrain> doesn't work for me?
11:20:06  <Eddi|zuHause> result seems strange
11:20:14  <peter1138> sorry for spamming prs
11:20:19  <peter1138> i will stop
11:20:24  *** andythenorth_ has quit IRC
11:20:27  <TrueBrain> peter1138: why? :)
11:20:38  *** andythenorth_ has joined #openttd
11:20:56  <andythenorth_> i think it’s probably ok peter1138
11:21:08  <andythenorth_> on balance :p
11:21:18  <TrueBrain> your PRs at least have reasoning and can be understood .. and are expected to be the least amount of lines needed to fix the issue :D
11:21:31  <andythenorth_> if only they weren’t getting lost amongst the others
11:22:04  <TrueBrain> Eddi|zuHause: it is either "is:open", "is:closed" or "is:draft"
11:22:09  <TrueBrain> they seem to overload eachother
11:22:12  <TrueBrain> (including the -)
11:22:20  <TrueBrain> so "-is:draft" shows both open and closed :D
11:22:30  <Eddi|zuHause> weird?
11:23:30  <andythenorth_> what’s the PR count now?
11:23:38  <TrueBrain> 49
11:23:51  <andythenorth_> can we have a bot that whines if they exceed 2 pages on GH
11:23:53  <andythenorth_> ??
11:24:56  <TrueBrain> sure; no clue what good it does
11:25:01  <TrueBrain> I did consider a rate limit per user :P
11:25:06  <TrueBrain> reject if you have more than N PRs in N hous
11:25:15  <TrueBrain> but than I remember what I really wanted
11:25:26  <TrueBrain> is if name is N, reject if more than N PRs are open
11:25:29  <TrueBrain> so that is not fair :P
11:26:14  <TrueBrain> Eddi|zuHause: ah, the - doesn't seem to work
11:26:27  <TrueBrain> documentation also suggest you can only search on things, not on not things
11:26:40  <Eddi|zuHause> yeah, i was looking for it
11:26:44  <Eddi|zuHause> but can't find anything
11:27:12  <peter1138> that town bridge 0 pop thing, it was samu's pr but he totally changed it
11:27:28  <TrueBrain> so it is guess for a new PR ? :D
11:27:31  <peter1138> i'm a bit sliw, reading on mobile
11:27:49  <Eddi|zuHause> https://help.github.com/en/articles/understanding-the-search-syntax <-- seems to say "not" or "-" should work
11:27:55  <andythenorth_> my phone client crashes hard every 5mins
11:28:01  <andythenorth_> mega lolz
11:28:09  <nielsm> 09:11:10 - <@peter1138> Off for the day, bye.  12:20:20 - <@peter1138> sorry for spamming prs
11:28:10  <nielsm> short day
11:28:11  <nielsm> :)
11:28:24  <TrueBrain> Eddi|zuHause: possibly that is for the genereic search? I don't know ..
11:28:59  <peter1138> im still out, i cant code
11:29:10  <TrueBrain> Eddi|zuHause: yeah, NOT and - are not working there
11:29:10  <Eddi|zuHause> i think it says "not" works for words, and "-" for qualifiers
11:29:11  <TrueBrain> owh well
11:29:59  <TrueBrain> it does work for labels
11:30:20  <andythenorth_> label more stuff :p
11:30:22  <TrueBrain> so there are 49 open PRs
11:30:24  <TrueBrain> 4 with label WIP
11:30:29  <TrueBrain> when I search for -label:wip
11:30:31  <TrueBrain> I have 46 PRs
11:30:35  <TrueBrain> someone .. is not good at math
11:30:52  <andythenorth_> includes closed?
11:30:59  <andythenorth_> dunno
11:31:00  <TrueBrain> nope
11:31:16  <Eddi|zuHause> maybe "draft" is the wrong word?
11:31:32  <TrueBrain> Eddi|zuHause: is:draft
11:31:32  <TrueBrain> works fine
11:31:44  <Eddi|zuHause> yeah, but...
11:31:50  <TrueBrain> okay, 1.9 milestone has just 1 entry left, on which nielsm said he was working .. so .. we are almost there :D
11:31:53  <TrueBrain> anything we are missing?
11:31:58  <TrueBrain> now is the best time, I guess
11:32:14  <peter1138> i can tag all mybstuff 19 if yiu like
11:32:17  <peter1138> :p
11:32:21  <Eddi|zuHause> if i add " -is:draft " i suddenly get "won't implement" in the results
11:32:30  <TrueBrain> if you enjoy doing that :D But not sure that is helping ;) :D
11:32:41  <TrueBrain> Eddi|zuHause: "-is:draft" returns EVERYTHING
11:32:46  <TrueBrain> I noticed :P
11:33:15  <TrueBrain> peter1138: and remember, the sooner we branch 1.9, the sooner you can merge all your shiny toys :)
11:33:26  <peter1138> woo!
11:35:26  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7288: Fix 23960d0f2c: Company livery window shows incorrect groups when opened from group window in multiplayer. https://git.io/fhAjI
11:36:36  *** Eddi|zuHause2 has joined #openttd
11:36:40  <nielsm> woah LOOK at this! https://0x0.st/zoNj.png
11:36:50  <nielsm> two new 1.9 features in one shot
11:36:55  <Eddi|zuHause2> a bot that attaches WIP label to all draft PRs?
11:36:56  <Eddi|zuHause2> then filter on "-label:WIP"?
11:36:57  <nielsm> adjacent stations built without ctrl
11:37:03  <nielsm> and town building bridge over rail
11:37:14  <TrueBrain> nielsm: :D
11:37:18  <TrueBrain> Eddi|zuHause2: yeah .. possible
11:37:26  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7288: Fix 23960d0f2c: Company livery window shows incorrect groups when opened from group window in multiplayer. https://git.io/fhAjt
11:37:31  <TrueBrain> I guess probot could help there, as they give a framework for bots with these easy jobs
11:37:51  <Eddi|zuHause2> or ask some github support how to filter on draft-pr?
11:38:06  <TrueBrain> I btw cannot change the default search query
11:38:06  <andythenorth_> towns that prefer bridges to crossings? o_O
11:38:13  <TrueBrain> so it would be manual work anyway, every time you open that page
11:38:25  <Eddi|zuHause2> hm, sad
11:38:50  <TrueBrain> nielsm: most I like about that screenshot the huge difference between the resolution of the station etc, and the labels :D
11:38:54  <TrueBrain> that looks so weird :P
11:39:19  <peter1138> andy not sure its meant to prefer bridges, just build if possible
11:39:31  <TrueBrain> right, time for lunch. After that hopefully LordAro can make a 1.9 branch :P (or anyone else, ofc)
11:39:32  <peter1138> if its never building crossi gs, then tgats a regression
11:40:24  <peter1138> before the change it wasnt possible
11:40:40  <Eddi|zuHause2> i would have thought it's limited to cases where it can't build a crossing (disabled, signal, diagonal rail, whatever)
11:40:44  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7288: Fix 23960d0f2c: Company livery window shows incorrect groups when opened from group window in multiplayer. https://git.io/fhAjm
11:40:55  *** Eddi|zuHause has quit IRC
11:41:31  *** Eddi|zuHause2 is now known as Eddi|zuHause
11:42:13  <andythenorth_> I was making a feature request :)
11:42:20  <nielsm> I think I'd prefer if small towns tended to build level crossings over rail, while large cities would tend to build bridges
11:42:40  <andythenorth_> popn?
11:42:45  <nielsm> more or less yes
11:42:47  <peter1138> nielsm, make a pr for that then :)
11:43:02  <peter1138> sounds reasonable to me
11:43:10  <Eddi|zuHause> base it on town zone?
11:43:29  <peter1138> pop makes more sense
11:43:45  <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep updated pull request #7272: Change: [NPF] Add path cache for ships. https://git.io/fhb8v
11:43:49  <nielsm> a rich town has more money to spend on bridges :P
11:44:00  <peter1138> yes, this
11:44:07  <Eddi|zuHause> doesn't mean they will :p
11:44:41  <peter1138> no but
11:44:44  <nielsm> what I'd like even more was if the town could "back off" with a road that was about to cross a railroad
11:44:51  <nielsm> and build a bridge instead
11:44:52  <Eddi|zuHause> however, if one or both of the ends are sloped, it should lean towards bridge
11:45:41  <Eddi|zuHause> nielsm: i'd like that approach more, if a house could be built next to a bridge ramp, so you'd not leave houses which normally couldn't be built
11:45:45  <nielsm> e.g. had built this: https://0x0.st/zoN9.png   and then changed to this: https://0x0.st/zoNp.png
11:46:01  <peter1138> cool, do it ;)
11:46:10  <nielsm> Eddi|zuHause we got towns building on diagonals early in this dev cycle :)
11:46:18  <nielsm> so that hole left in should be buildable here
11:46:36  <Eddi|zuHause> ok
11:46:40  <peter1138> could be 1.10 chsnge, heuristics deciding how to expand
11:47:08  *** andythenorth_ has quit IRC
11:48:24  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7288: Fix 23960d0f2c: Company livery window shows incorrect groups when opened from group window in multiplayer. https://git.io/fhAjW
11:49:40  <nielsm> release RC without 7288 in, ask players to try to reproduce it?
11:57:58  <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7272: Change: [NPF] Add path cache for ships. https://git.io/fhAjg
12:01:11  <TrueBrain> nielsm: I can see if I can reproduce it, I guess
12:02:58  <TrueBrain> no clue what allthose words are in that ticket, but I am sure I will find out :)
12:03:19  <michi_cc> nielsm: One problem would be line 710 in company_gui, the call uses the window number but it is only set lateron.
12:03:32  <peter1138> yes
12:03:46  <peter1138> wibdow number is reset during the initialization calls
12:05:35  <TrueBrain> what is Group Livery, and where is the button? :D
12:06:18  <TrueBrain> ah, colours I guess?
12:06:45  <nielsm> https://0x0.st/zoNG.png
12:06:47  <TrueBrain> hmm . .are we still missing some gfx?
12:06:50  <TrueBrain> was that fixed already?
12:07:03  <nielsm> guess it depends on opengfx vs original?
12:07:04  <nielsm> :(
12:07:09  <TrueBrain> tnx nielsm :) Still a questiomark here :P
12:07:17  <TrueBrain> we have an openttd.grf for that, not?
12:08:33  <DorpsGek_II> [OpenTTD/OpenTTD] michicc commented on pull request #7306: Add: Chrono based TIC() and TOC() in debug https://git.io/fhAjD
12:08:52  <TrueBrain> also weird, that the group names are cross-server, not per player :P
12:08:58  <TrueBrain> so as company 2, my group was prenamed Group 3
12:09:01  <TrueBrain> while I had no groups yet
12:09:36  <TrueBrain> okay, I can reproduce the issue
12:09:39  <TrueBrain> lets see if the PR fixes it .. :D
12:12:20  <TrueBrain> at least I cannot reproduce it with that fix applied :P
12:13:05  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain approved pull request #7288: Fix 23960d0f2c: Company livery window shows incorrect groups when opened from group window in multiplayer. https://git.io/fhAj9
12:13:39  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain merged pull request #7288: Fix 23960d0f2c: Company livery window shows incorrect groups when opened from group window in multiplayer. https://git.io/fhNcY
12:13:59  <TrueBrain> so how about that missing grf stuff ..
12:16:04  <TrueBrain> there is no newer OpenGFX too
12:16:10  <TrueBrain> so how is it that it is fixed in your screenshot nielsm?
12:16:19  <nielsm> I'm not using opengfx
12:16:21  <nielsm> but original
12:16:29  <nielsm> opengfx does not use openttd.grf afaik
12:16:42  <TrueBrain> ah
12:16:47  <TrueBrain> so it is fixed in openttd.grf ?
12:17:05  <nielsm> the new sprite is in openttd.grf which is an addon to the original graphics
12:17:09  <TrueBrain> k k
12:17:19  <TrueBrain> so .. we need to fix OpenGFX before the 1st of April?
12:17:41  <nielsm> so basically either make a new opengfx release, or implement a baseset missing sprites fallback mechanism
12:18:03  <nielsm> that does not depend on the baseset definition file
12:18:42  <nielsm> aBase and zBase etc. would probably also miss the new icon
12:18:51  <TrueBrain> I see no changes in OpenGFX, so I assume it is not in there yet at all?
12:19:17  <TrueBrain> yeah, and they should update too .. but as OpenGFX is auto-installed for most users on first play, it is a bit more important to already have that fixed on release :D
12:19:35  <TrueBrain> we also need to bump NSIS for it
12:20:03  <TrueBrain> so .. who to poke for making that happen?
12:20:05  <nielsm> what if you upgrade your existing install, it won't know you need a new opengfx release will it?
12:20:29  <TrueBrain> I guess you need to update via the Content Service
12:20:32  <Eddi|zuHause> alledgedly, OpenGFX falls back to the openttd.grf sprites now, so a fix is not strictly necessary
12:20:42  <TrueBrain> Eddi|zuHause: 0.5.2 does not, I promise you
12:20:42  <Eddi|zuHause> it just will complain loudly to all users
12:21:24  <Eddi|zuHause> well, i don't use opengfx
12:21:27  <TrueBrain> but, who can fix/help with this? planetmaker? andy?
12:21:59  <Eddi|zuHause> presumably, the fix is trivial? just needs someone with access to the repo?
12:22:19  <TrueBrain> hence my question, who can fix/help with this
12:22:26  <nielsm> it's just drawing one new sprite
12:22:32  <nielsm> and adding it
12:22:38  <TrueBrain> I had 5 ? icons btw
12:22:41  <michi_cc> TrueBrain: pm said he would update OGFX
12:22:46  <TrueBrain> 1 for the Livery, 4 in the Livery window
12:22:49  <Eddi|zuHause> i would've just copied over the openttd.grf sprites?
12:22:59  <Eddi|zuHause> instead of drawing new ones?
12:23:33  <TrueBrain> michi_cc: any idea what the timeline was? Did he happen to mention?
12:23:55  <nielsm> oh it does say so https://0x0.st/zoqz.png
12:23:58  <michi_cc> Check logs of last weekend :)
12:23:58  <Eddi|zuHause> i wouldn't wait for this until release
12:24:03  <nielsm> and for me it does fall back
12:25:07  *** andythenorth has joined #openttd
12:25:21  <TrueBrain> Eddi|zuHause: we need this fixed before release (the OpenGFX bump)
12:25:27  <TrueBrain> as it requires a change in the NSIS
12:25:35  <TrueBrain> so OpenGFX has to be fixed before we can release :)
12:26:00  <TrueBrain> nielsm: weird, it is not showing me that message ..
12:26:04  <andythenorth> real irc
12:26:09  * andythenorth off the phone
12:26:33  <Eddi|zuHause> TrueBrain: maybe it picks an outdated openttd.grf?
12:27:08  <TrueBrain> the one in master?
12:27:36  <TrueBrain> the nightly does do it ... so .. lol
12:27:56  <TrueBrain> that on its own is interesting ..
12:28:13  <TrueBrain> but okay, that is not really relevant :)
12:28:21  <TrueBrain> andythenorth: can you help to fix OpenGFX? Or is pm the only one?
12:28:27  <TrueBrain> (it is missing a few sprites)
12:28:43  <andythenorth> I can but not now
12:28:50  <TrueBrain> soon? :)
12:28:54  <andythenorth> probably today
12:28:58  <TrueBrain> \o/
12:29:07  <andythenorth> I've never used it, but it's just copy-paste to a png?
12:29:11  <TrueBrain> would be nice if we have an RC that already has them ;)
12:29:23  <TrueBrain> no clue, don't ask me about NewGRF stuff :)
12:29:30  * andythenorth assumes it's just open photoshop, paste, commit
12:30:13  <michi_cc> TrueBrain: Not necessarily for NSIS, as far as I can see an old OpenTTD would ignore extra GUI sprites at the end of the Action 5. Replacing the current download should be fine.
12:30:28  <Eddi|zuHause> andythenorth: might be easier for the future if it was just copying the openttd.grf file over, instead of editing it
12:30:31  <TrueBrain> michi_cc: not sure if I follow you
12:30:37  <TrueBrain> michi_cc: NSIS downloads a specific OpenGFX
12:30:38  <nielsm> the sprites for this are not visually quite compatible between original and opengfx: https://0x0.st/zoqX.png
12:30:42  <TrueBrain> it would be nice if that already contains the correct sprites
12:30:45  <nielsm> so new sprites would need to be drawn
12:30:48  <TrueBrain> otherwise on first launch it complains it ismising sprites
12:30:52  <TrueBrain> michi_cc: what do you mean?
12:31:17  <michi_cc> TrueBrain: Yes, but updating the file under the current URL shouldn't harm e.g. 1.8.0.
12:31:29  <TrueBrain> michi_cc: but that is kinda hackish
12:31:39  <TrueBrain> and besides, the file is downloaded under the OpenGFX version
12:31:45  <TrueBrain> so we have to recreate 0.5.2
12:31:49  <TrueBrain> that sounds really wrong :)
12:31:49  <michi_cc> It's not.
12:32:12  <michi_cc> http://binaries.openttd.org/installer/opengfx-${OPENGFX_BASE_VERSION}.7z" with !define OPENGFX_BASE_VERSION "1.2.0"
12:32:23  <michi_cc> You told me exactly that last weekend :p
12:32:33  <TrueBrain> last weekend? That was a few weekends earlier, not? :)
12:32:39  <TrueBrain> and yes, it uses the version to fetch the file
12:32:44  <TrueBrain> but it should download it under its real name
12:32:49  <TrueBrain> (as in, store on disk)
12:33:00  <TrueBrain> well, I guess that still works, true
12:33:04  <michi_cc> That there is no need to bump the 1.2.0 version unless older OpenTTDs can't load it anymore.
12:33:04  <TrueBrain> but it still feels rather dirty
12:33:24  <TrueBrain> but okay, I guess you are right, we can fix it "later"
12:33:37  <TrueBrain> but my main point was, that I rather have RC1 already not tell on startup it is missing sprites
12:33:40  <TrueBrain> which it currently is :)
12:34:10  <michi_cc> Yes, definitely. It just doesn't depend on NSIS :)
12:34:28  <TrueBrain> I still think we should also fix it in NSIS, but .. I agree it is not required ;)
12:34:42  <TrueBrain> as far as I know, we always did it like that .. not sure if anything breaks if we do it another way :)
12:35:06  <TrueBrain> but .. that is not based on facts ;)
12:35:07  <michi_cc> I'm quite sure we had OGFX changes after releasing OTTD 1.2.0.
12:35:17  <TrueBrain> hmm, I can check that
12:35:45  <TrueBrain> 0.5.0 -> 0.5.2
12:35:47  <TrueBrain> you are right
12:35:55  <TrueBrain> so if it is strict backwards compatible, it should be fine
12:36:18  <TrueBrain> 0.4 -> 0.5 did need a NSIS bump
12:36:22  <TrueBrain> okay, fair enough michi_cc :)
12:36:51  <TrueBrain> another puzzle: when I build OpenTTD via CMake, it is not telling me it is missing sprites
12:36:57  <TrueBrain> same codebase
12:38:38  <TrueBrain> so we still configure something differently ... oh-oh
12:43:26  <Eddi|zuHause> i still suspect it's picking a wrong openttd.grf
12:43:37  <TrueBrain> it is commited in master, not?
12:43:56  <TrueBrain> hmm .. possibly it is not using the right folder?
12:44:05  <TrueBrain> I run it from bin/
12:44:14  <TrueBrain> but ... I know sometimes the searchpaths are off :P
12:44:28  <Eddi|zuHause> i think so, but maybe it's not copied correctly?
12:44:37  <andythenorth> I am not maintaining the ogfx sprite style :)
12:44:47  <TrueBrain> it is not copied at all, openttd.grf
12:44:49  <TrueBrain> it is just there :P
12:45:09  <andythenorth> hmm
12:45:11  <andythenorth> ouch
12:45:53  <TrueBrain> hmm, found another cmake related issue .. it is rebuilding my project every time .. wtf is that ..
12:46:03  <TrueBrain> possibly glx knows that
12:46:08  <Eddi|zuHause> TrueBrain: i suspect you have an openttd.grf elsewhere, and it gets confused
12:48:59  <TrueBrain> okay, if I copy the file in Documents/OpenTTD/baseset, it does work as expected
12:49:06  <TrueBrain> so it is really not seeing the version in bin/
12:49:16  <TrueBrain> there are no other locations it could hide, as far as I can tell
12:49:45  <TrueBrain> it does find the opntitle.dat ..
12:49:45  <TrueBrain> weird
12:51:11  <TrueBrain> also the obms and obses
12:51:17  <TrueBrain> it is only the openttd.grf it is not finding there :P
12:51:25  <TrueBrain> the wonderful world of OpenTTD search paths :)
12:52:10  <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep closed pull request #7238: Codechange: Remove assert when trying to intersect two tile areas and… https://git.io/fh5RL
12:52:11  <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7238: Codechange: Remove assert when trying to intersect two tile areas and… https://git.io/fhxez
12:52:12  <TrueBrain> owh well, can't be bothered. Tnx Eddi|zuHause, for the breadcrumbs :)
12:53:36  <andythenorth> I read a thing this weekend about someone who quit developing software :)
12:55:28  <TrueBrain> you sound like Samu now :)
12:55:43  <TrueBrain> this random out-of-context line of text :P
12:55:51  <Eddi|zuHause> the desease is certainly spreading
12:56:45  <TrueBrain> the main difference is, that in this case I am curious what he is talking about
12:57:34  <Eddi|zuHause> that is the nature of clickbait
12:57:46  <TrueBrain> so he is making money out of these quotes? :o
12:58:11  <Eddi|zuHause> step 1: clickbait
12:58:14  <Eddi|zuHause> step 2: ???
12:58:17  <Eddi|zuHause> step 3: profit!
12:59:40  <andythenorth> I've always posted out of context
12:59:48  <andythenorth> and random 6-line streams of consciousness
12:59:56  <andythenorth> the difference is I ship stuff, and don't clutter up PRs
13:00:11  <andythenorth> nor highlight people with 'help'
13:00:49  <TrueBrain> but yet you keep us in suspense!
13:00:50  <TrueBrain> :D
13:01:20  <andythenorth> https://io9.gizmodo.com/legendary-programmer-why-the-lucky-stiffs-strange-fas-476461205
13:01:36  <andythenorth> a Ruby guy who suddenly quit, because software is awful
13:01:48  <andythenorth> I skim read the novel, there's a PDF of it
13:02:01  <andythenorth> reminds me of stuff I wrote 15 years ago, but never finished
13:02:20  * andythenorth is having a 'sofware is awful' weekend :P
13:03:08  <TrueBrain> as longt as it is contained in a weekend :P
13:04:39  <andythenorth> oof
13:05:00  <andythenorth> mostly I think it's the slow collapse of coop, and who that leaves maintaining all the coop stuff
13:05:04  <andythenorth> seems to be me
13:06:03  <TrueBrain> so be like me, and move it to places others can maintain it :)
13:06:07  <andythenorth> I only joined coop because I was asked to put my code somewhere it would be preserved for the community if I left
13:06:17  <andythenorth> I was never a maintainer, just a user
13:07:16  <Eddi|zuHause> andythenorth: there's several layers to that
13:07:16  <andythenorth> now, instead of doing what I want, which is working on newgrfs
13:07:28  <andythenorth> I'm rebuilding a system so other people can work on newgrfs, but not me
13:07:35  <andythenorth> because I'm now the maintainer
13:07:40  <andythenorth> seems like an own goal
13:07:57  <andythenorth> oops
13:10:13  <TrueBrain> http://www.derailvalley.com/roadmap/ <- what a nice format :)
13:13:28  *** J0anJosep has joined #openttd
13:13:54  <nielsm> I hope "bug fixes and improvements" covers vegetation not covering the track and trees growing through bridges
13:14:03  <nielsm> because that's my biggest annoyance with it atm
13:14:24  <nielsm> I'd play with vegetation off but that just makes it look sad
13:14:24  <andythenorth> sounds like realisms :)
13:14:57  <J0anJosep> Hi
13:15:16  <nielsm> also would be nice with some longer straight sections where you can actually get up in speed and not have to brake right away :P
13:18:35  *** Beerbelott has joined #openttd
13:22:28  <andythenorth> hi J0anJosep :)
13:23:31  <TrueBrain> nielsm: Derail Valley crashes here :( That is justi sad
13:23:53  <TrueBrain> by the looks it runs out of memory on the GPU
13:23:56  <nielsm> you can't even crash your trains
13:25:27  <nielsm> I have a geforce gtx 1050 with probably 2 or 3 GB
13:25:44  <nielsm> 2 GB
13:26:08  <TrueBrain> I have a 1080 .. and now a black screen .. lol
13:26:14  *** Flygon has left #openttd
13:26:46  <nielsm> you're starting it in non-vr mode right? (assuming you are planning on playing with keyboard/mouse)
13:26:53  <TrueBrain> no
13:26:56  <TrueBrain> I plan on playing it in VR :P
13:27:36  <TrueBrain> I had the same issue with Apex .. it assumes it is the only one using GPU memory
13:27:37  <TrueBrain> it is not
13:28:00  *** drac_boy has joined #openttd
13:28:08  <drac_boy> hi there this not-sunny cloudy day :-s
13:30:37  <peter1138> it has a non vr mode? oh...
13:31:25  <nielsm> it's already better than railworks ever was
13:31:59  <drac_boy> hm which train simulator are we talking about? (or did I misguess the topic)
13:32:05  <nielsm> okay well, there's no signals to follow, but it shouldn't be hard to beat dovetail on that point either
13:32:14  <nielsm> derail valley
13:32:51  <peter1138> heh dovetail smells
13:33:42  <milek7> that derail valley seems more gameplay/vr oriented than realistic simulation compared to other sims
13:34:47  <drac_boy> nielsm hmm going from the Steam description it does rather sound interesting .. a little like msts mixed with "you actually do need to deliver the loaded wagon to there" realism
13:35:12  <drac_boy> not sure about the gpu need but mm I'll keep it bookmarked for a while just in case
13:37:41  <peter1138> Yeah, it's game that involves trains.
13:37:59  <peter1138> Got a spare moment on the laptop. Anything I need to look at? :p
13:40:31  * drac_boy still has msts and a large downloads-copy cd as well somewhere around here
13:41:31  <peter1138> TrueBrain, https://github.com/OpenTTD/OpenTTD/commit/d0184dfc846b3fc46a55d87b8fce890b23ef3960
13:41:55  <milek7> msts is too old
13:41:57  <milek7> and 2d cabins
13:42:01  <peter1138> TrueBrain, that was the original version of Samu's PR which just needed the additional line I suggested. I could make a new PR with just that if you like.
13:42:25  <peter1138> Although It's unnecessary if you consider #7284.
13:43:04  <TrueBrain> bah, game crashed again
13:43:05  <TrueBrain> annoying
13:43:46  <drac_boy> milek7 actually the downloads have extensions .. can even have real brake riggings provisions too
13:43:51  <TrueBrain> I think 7284 is the better choice here; but that is me :)
13:44:01  <peter1138> Yes, it is.
13:44:07  <drac_boy> but if you only want use the default non-download graphics then yes it would look like a flat box indeed
13:45:02  <peter1138> So is it 1.9 or 1.10? It's a nice performance benefit for generating large maps.
13:45:12  <TrueBrain> I would say 1.10
13:45:25  <TrueBrain> just to close down 1.9
13:45:27  <peter1138> And unlike the other version which adds towns to the map, it doesn't really change much.
13:45:29  <TrueBrain> so LordAro can in fact branch :)
13:45:30  <peter1138> Hmm.
13:45:36  <peter1138> Oh well.
13:45:50  <TrueBrain> from my perspective: it has been like this for years
13:45:57  <TrueBrain> :P
13:46:19  <peter1138> As I said, oh well.
13:46:50  <peter1138> If we go the path of storing town index for bridges for 1.10, then it's unnecessary and can be closed.
13:47:30  <peter1138> Personally I think that's overkill and nothing really needs to know about town index for bridges, other than this edge case which is only apparently on world generation.
13:47:34  *** frosch123 has joined #openttd
13:48:58  <TrueBrain> why is this game crashing on me ... annoying
13:51:00  <peter1138> -ly
13:52:37  <DorpsGek_II> [OpenTTD/OpenTTD] Berbe updated pull request #7286: Add #2155: newheightmapgame command https://git.io/fhNZl
13:52:50  <milek7> drac_boy: for reasonable physics and real procedures maszyna eu07.pl is pretty good (though environment graphics is.. ugly) (disclaimer: i'm associated with it)
13:52:57  <milek7> and community is likely too much polish-centric to compete with msts/openrails
13:53:42  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7284: Fix #7043, Fix #7274: Delete town owned bridge based on adjacent tile ownership, not nearest town. https://git.io/fhxvO
13:54:06  <Eddi|zuHause> maybe bridges could use an off-map pool, which should be designed with a flexible-bridges-rewrite in mind, which then as a side effect could also store town ownership?
13:54:49  <peter1138> Eddi|zuHause, JGR's PP uses off-map storage, but 16 bits isn't enough to index them.
13:55:27  <peter1138> I think he uses m2 up to a point and then other bridges are in a hash.
13:55:27  <drac_boy> milek7 interesting game .. tbh I've actually played with the pkp grf from time to time so seeing these locomotives again is .. :-)
13:56:11  <Eddi|zuHause> well, the bridge head tile needs to lose all the road/rail trackbit stuff, which need to go into the off-map, which would be a linear list of tiles (for vehicle movement) instead of the current wormhole behaviour
13:56:23  <Eddi|zuHause> then there's enough storage left to index bridges
13:56:32  <peter1138> Though if I did it, I would just make the index larger and either store it in more bits, or make m2 reference multiple bridges which would be quicker to look up.
13:57:00  <peter1138> Don't need to lose all of it. But ok.
13:57:08  <peter1138> Could make space indeed.
13:58:04  <peter1138> Come up with a proposal ;)
13:58:14  <Eddi|zuHause> problem with that approach might be that all functions getting a TileIndex need to be prepared to get a non-map tile
13:59:39  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7279: Fix #7062: Remove ship max order distance. https://git.io/fhxvZ
13:59:55  <peter1138> All?
14:00:52  <peter1138> I think we already have a map bit for "has bridge above". Harder to make work with non-straight bridges.
14:01:08  <Eddi|zuHause> well, you could replace TileIndex with a struct that behaves like an int for all non-bridge usages
14:01:44  <peter1138> Just make the map fully 3D :p
14:01:52  <peter1138> x,y,z
14:01:59  <peter1138> Screw storage space :D
14:02:05  <Eddi|zuHause> that wastes a looooooot of space :p
14:02:25  <Eddi|zuHause> and makes it difficult to follow the terrain surface
14:02:39  <peter1138> MineOpenTTDCraft
14:02:40  <TrueBrain> nielsm: you playing it with or without VR?
14:02:45  *** Samu has joined #openttd
14:02:59  <peter1138> Wait for it.
14:03:09  <drac_boy> :)
14:03:24  <DorpsGek_II> [OpenTTD/OpenTTD] GabdaZM commented on pull request #7306: Add: Chrono based TIC() and TOC() in debug https://git.io/fhxvc
14:03:42  <Eddi|zuHause> peter1138: too little simcity in that :p
14:03:45  <TrueBrain> for some reason rendering 2x 2k screens + VR makes the GPU say: BYEZzzz
14:03:47  <frosch123> TrueBrain: do we already have a solution for https://paste.openttdcoop.org/p8xz3wdqc?/p8xz3wdqc
14:03:54  <Samu> hi
14:04:20  <TrueBrain> frosch123: what is the problem exactly?
14:05:09  <frosch123> releases are built with assertions disabled, and rev.cpp has a flag for "stable tag"
14:05:27  <nielsm> TrueBrain: I don't have VR
14:05:36  <peter1138> Can the build system handle it without needing a specific commit, I guess?
14:05:38  <frosch123> i guess we can add the latter with findversion.sh testing for tags with only numbers, without rC or beta
14:05:40  <peter1138> Or I'm misreading.
14:05:41  <TrueBrain> nielsm: you are missing out :P
14:05:42  <frosch123> no idea about the compile options
14:05:55  <milek7> drac_boy: we're preparing for release on steam, to get rid of these nsis with torrent installers
14:06:02  <Eddi|zuHause> <TrueBrain> for some reason rendering 2x 2k screens + VR makes the GPU say: BYEZzzz <-- dunno, my GPU says that way earlier :p
14:06:30  <TrueBrain> frosch123: we can just apply that patch on branches, not?
14:06:40  <TrueBrain> not really sure what solution you are looking for
14:06:57  <frosch123> the flag is only supposed to be set for stable releases, not for RC or beta
14:07:07  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7306: Add: Chrono based TIC() and TOC() in debug https://git.io/fhxv8
14:07:09  <TrueBrain> so we apply it before we release?
14:07:17  <frosch123> and revert afterwards?
14:07:29  <TrueBrain> I guess? No clue
14:07:39  <TrueBrain> I just point to LordAro :P
14:07:49  <drac_boy> milek7 mm well keep having from with that project ok? :)
14:08:33  <milek7> what do you mean?
14:08:34  <TrueBrain> sorry frosch123, I was unaware that being a problem. But I also try to stay out how releases are done from a git point of view :)
14:08:42  <TrueBrain> I am hoping other people are tackling those issues
14:08:49  <TrueBrain> I try to focus on getting the CI etc to behave :D
14:09:11  <drac_boy> milek7 sorry I thought you said you were part of the project team on it? or did I misread some earlier lines now
14:09:27  <frosch123> that's ok, i just wanted to know the status, since I have no idea what happens anymore :)
14:09:35  <milek7> yes, i'm on team :)
14:10:03  <milek7> sorry, i just cannot parse that sentence
14:10:33  *** synchris has joined #openttd
14:10:35  <TrueBrain> frosch123: I hope LordAro knows more about this :)
14:10:38  <drac_boy> np
14:11:06  <Eddi|zuHause> milek7: don't you love people who chain random words and expect other people to understand their gibberish?
14:11:20  <DorpsGek_II> [OpenTTD/OpenTTD] Berbe commented on pull request #7286: Add #2155: newheightmapgame command https://git.io/fhxvz
14:11:50  <peter1138> Would be nice if the build system could know from the tag that it is building a release, and automatically disable asserts, etc.
14:12:22  * drac_boy bonks za eddi with a funny coding fork for talking like weird? :P
14:12:23  <drac_boy> heheh
14:13:06  <drac_boy> truebrain not to be silly but did you just said your big brain had no idea? :)
14:16:21  <drac_boy> milek7 just curious but do the team just prefer modern locomotives alone or is it due to the extra work that would be needed to add a steam locomotive to the gameengine?
14:16:51  <Eddi|zuHause> i'm assuming steam engines have crazy number of moving parts
14:17:04  <peter1138> TrueBrain, oh yeah the group default name thing, the number is of course the pool index, so dependent on groups other people made. Maybe that can be changed.
14:17:32  <drac_boy> usually yes but there are always steam trams which look almost like diesel/electric but just with more smoke coming from the roof :)
14:17:42  <drac_boy> although hmm I don't know if poland ever had them
14:18:20  <Eddi|zuHause> what would be the point of a steam engine where you can't see the moving parts?!
14:19:07  <drac_boy> dunno, I'll leave you with this nevertheless ;-) http://4.bp.blogspot.com/-am0CKqXG8go/USdahrkYjjI/AAAAAAAAsg0/35READrH8zA/s1600/PAYS+BAS---DOESBURG+BERGSTRAAT--TRAIN+596.6+GTW--1956.jpg
14:20:29  <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #7302: Change: make crash chance at short runway independent of plane crash … https://git.io/fhxva
14:20:49  <Samu> :(
14:20:52  <milek7> no special reason, we just don't have physics code for steam engines
14:20:59  <drac_boy> anyway going let you people do your codings etc .. I'm off to sort more sketch papers
14:21:12  <milek7> and there is less resources about it (locomotives to photograph, measure, etc.)
14:21:27  <drac_boy> milek7 np nothing too special about pkp steam although I do like how they have these 'simple' and oversized headlights that sorta make them a little unique to me for some reason
14:21:46  <drac_boy> anyway .. I'm going off tho so :)
14:21:57  *** drac_boy has left #openttd
14:22:27  <Eddi|zuHause> i'm imagining most of the PKP steam engines are actually repainted prussian engines
14:22:28  <peter1138> milek7, what game/project is that?
14:22:37  <milek7> https://eu07.pl/
14:24:03  <peter1138> The download page is in foreign ;)
14:24:33  <DorpsGek_II> [OpenTTD/OpenTTD] GabdaZM updated pull request #7306: Add: Chrono based TIC() and TOC() in debug https://git.io/fhA6p
14:24:35  *** glx has joined #openttd
14:24:35  *** ChanServ sets mode: +v glx
14:24:36  <nielsm> https://0x0.st/zobr.jpg  whoops
14:26:07  <peter1138> Heh
14:26:12  <peter1138> I... need to find £15
14:26:25  <peter1138> Hmm, does it have multiplayer yet?
14:27:14  <milek7> eh, nobody updated languages for 19.01 release. i must throw out this silly cms and replace with hugo or something
14:27:47  <peter1138> Hmm, laptop is so slow, still compiling :p
14:27:48  <nielsm> https://0x0.st/zobz.jpg
14:27:57  <nielsm> https://0x0.st/zobi.jpg
14:28:17  <nielsm> I got above 100 km/h !!
14:28:23  <TrueBrain> I finally was on my wy to make some money .... game crash
14:28:25  <TrueBrain> ugh
14:28:33  <peter1138> Oh
14:28:51  <Eddi|zuHause> nielsm: looks like it was worth it :p
14:29:17  <milek7> some companies in poland use it for train driver training
14:29:19  <TrueBrain> it really has issues staying in bounds of the GPU memory ..
14:30:04  <Eddi|zuHause> TrueBrain: is GPUswap memory a thing? :p
14:30:08  <TrueBrain> :D
14:30:27  <Samu> why is NewGRF the answer for everything ...
14:30:28  <TrueBrain> I don't know what it is with games lately, but they seem to wrongly estimate how much memory they can store in the GPU
14:30:31  <TrueBrain> not the first game ..
14:31:40  <TrueBrain> doesn't help that many things use GPU memory these days .. like Chrome .. etc
14:32:09  <Eddi|zuHause> "A GPU with an MMU can virtualize GPU and host memory, so that it can appear as a single address space, with the physical host memory accesses handled by DMA transfer."
14:32:35  <milek7> don't gpu drivers swap vram into system ram (and from there to swap)?
14:32:45  <milek7> at least opengl did that, don't know about directx
14:32:58  <TrueBrain> this is mostly textures
14:33:03  <TrueBrain> not sure what happens with them honestly
14:33:07  <TrueBrain> I also have swap disabled :P
14:33:28  <TrueBrain> (if 8GB GPU RAM and 16GB CPU RAM is not sufficient, I don't want to know)
14:33:52  <Eddi|zuHause> TrueBrain: i recently enabled zswap
14:33:53  <peter1138> o_O
14:34:09  <milek7> would it work on wine?
14:34:17  <glx> maybe they develop on high end machines and don't care about optimistation ;)
14:34:21  <peter1138> Samu, 10:43 < andythenorth_> objectives on wiki say we prefer content to settings
14:34:36  <TrueBrain> glx: when I generate a MSVC project from CMake, it keeps rebuilding it every time .. no clue what is going on there :( I was hoping you had any
14:34:40  <TrueBrain> possibly it is a local issue :D
14:35:29  <Samu> NewGRFs feel too random
14:35:37  <Samu> there's too many of them
14:35:46  <peter1138> They're content.
14:35:46  <TrueBrain> s/NewGRF/settings/
14:36:11  <peter1138> And, especially in the case of a feature that NewGRF can already control, we should not add settings that will conflict.
14:36:34  <glx> rebuilding what ?
14:36:40  <TrueBrain> glx: everything
14:37:05  <glx> checking
14:37:09  <TrueBrain> so if I press Build twice
14:37:14  <TrueBrain> it is like I pressed Rebuild twice
14:37:45  <TrueBrain> could absolutely by my project, as I kinda did a lot of shit with it .. but I was hoping to get a second opinion on the matter :)
14:39:14  <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #7314: Change: Separate forbid 90 deg for trains and ships https://git.io/fhAFd
14:40:26  <andythenorth> are we still talking about that?
14:40:30  <andythenorth> no it's a waste of time
14:40:57  <glx> for me 90° should be for trains only
14:41:06  <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on pull request #7314: Change: Separate forbid 90 deg for trains and ships https://git.io/fhxvD
14:41:07  <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed pull request #7314: Change: Separate forbid 90 deg for trains and ships https://git.io/fhAFd
14:41:10  <andythenorth> it's been debated to death
14:41:29  <andythenorth> stuff like this makes me want to quit OpenTTD tbh
14:41:31  <andythenorth> it's a drag
14:41:35  *** andythenorth has left #openttd
14:42:09  <Samu> eh :O
14:44:48  <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth reopened pull request #7314: Change: Separate forbid 90 deg for trains and ships https://git.io/fhAFd
14:46:26  <Samu> why is 7302 favoured and 7293 rejected... I can't understand your reasonings
14:47:25  <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on pull request #7314: Change: Separate forbid 90 deg for trains and ships https://git.io/fhxv5
14:47:33  <Samu> 7302 changes a setting that was taken for granted
14:47:35  <nielsm> Samu: this is not _your_ game, it's _our_ game, and your contributions very often bear a showing of you not having a good view of the big picture, and of having very little experience with developing large software products
14:47:54  <nielsm> your lack of experience results in your misjudging what is a good change and what will remain maintainable over time
14:48:09  <Samu> better not change anything then
14:48:30  <glx> hmm mingw detects ICU, and as things are ordered in gfx_layout.cpp I think it uses it by default instead of uniscribe
14:48:53  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7314: Change: Separate forbid 90 deg for trains and ships https://git.io/fhxvd
14:48:54  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain closed pull request #7314: Change: Separate forbid 90 deg for trains and ships https://git.io/fhAFd
14:49:03  <TrueBrain> ping pong; now it is final :)
14:49:30  <nielsm> change is not inherently bad, but kneejerk-reaction change is often bad because you only respond to one isolated incident and don't look at what the greater result will be
14:49:44  <nielsm> good change requires planning and overview
14:50:20  <Samu> you're letting plane crashes when setting it to none. I can't understand why this is a valid reason
14:51:44  *** supermop_Home_ has joined #openttd
14:51:48  <supermop_Home_> yo
14:53:05  <TrueBrain> Samu: there is a huge difference between a disaster, which the setting controls, and something like having too big planes take off from too small airports
14:53:14  <TrueBrain> the first you control with a disaster-like settings, the second with a cheat
14:53:19  <TrueBrain> those are 2 different worlds
14:54:13  <glx> TrueBrain: just tried project from command line (so using cmake --build . --config Release) twice, first time it rebuild everything, second time everything was up-to-date so no rebuild
14:54:17  <TrueBrain> for the same reason if you run two trains in each other, no matter what your settings are, they will crash
14:54:34  <TrueBrain> glx: sorry, I was a bit unclear: I meant I generated a MSVC project from CMake
14:54:39  <TrueBrain> and I did Build Solution from there
14:54:41  <TrueBrain> so OpenTTD.sln
14:54:45  <TrueBrain> that keeps rebuilding for me
14:54:50  <glx> I also opened the openttd.sln in VS and pressed build many times, no rebuild
14:54:57  <TrueBrain> okay, so it is me :)
14:54:59  <TrueBrain> well, tnx :P
14:55:01  <TrueBrain> ghehe
14:55:03  <TrueBrain> no, seriously, tnx :)
14:55:19  <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z updated pull request #7302: Change: make crash chance at short runway independent of plane crash … https://git.io/fhALz
14:55:52  <TrueBrain> perfect Eddi|zuHause, tnx a bunch :)
14:56:05  <TrueBrain> guess it also needs a commit to remove all translations, or is that fixed another way already?
14:56:10  <glx> https://paste.openttdcoop.org/pwadxkiqg
14:56:19  <glx> that's the output
14:56:34  <TrueBrain> k; always nice to know it is me, not the rest of the world :P
14:56:40  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7302: Change: make crash chance at short runway independent of plane crash … https://git.io/fhxvp
14:56:49  <Eddi|zuHause> TrueBrain: i haven't followed that, but there was a problem recently where eints just put the removed translations back in
14:57:09  <TrueBrain> that is fixed
14:57:10  <TrueBrain> I know
14:57:11  <glx> Eddi|zuHause: only for changed english srting
14:57:12  <TrueBrain> :)
14:57:39  <glx> for totally removed string there were no issues :)
14:57:48  <Eddi|zuHause> however, i don't think removing the translations is necessary here. the translators can just update the strings whenever...
14:58:03  <TrueBrain> I think they are not going to notice it is changed
14:58:07  <TrueBrain> I remember there was something with that ..
14:58:11  <glx> if format change we get a bunch of warnings
14:58:12  <TrueBrain> frosch123: you happen to know? :)
14:58:35  <glx> and they are markes as outdated in eints
14:58:41  <glx> *marked
14:59:19  <frosch123> TrueBrain: when the english string changes, eints marks the translations as "outdated"
14:59:35  <TrueBrain> cool
14:59:35  <TrueBrain> okay
14:59:37  <TrueBrain> so nothing to do
14:59:38  <TrueBrain> :)
14:59:38  <TrueBrain> tnx!
14:59:40  <glx> but the main reason we remove changed strings (when format change) is the warnings
14:59:57  <Eddi|zuHause> glx: that is not necessary here
15:00:30  <frosch123> http://translator.openttd.org/project/openttd-trunk <- outdated: english text changed; invalid: english text changed, parameters incompatible now
15:00:45  <glx> ah that's new :)
15:01:10  <frosch123> the recent change about "invalid" was that now eints does not output invalid string anymore, but only keeps them in its internal storage
15:01:35  <glx> oh I have translations to fix
15:01:45  <frosch123> as a result, if you delete the eints projects and resetup it, you will loose all invalid strings in addition to information about outdatedness and history
15:04:54  <TrueBrain> k, cool :)
15:05:05  <TrueBrain> so Eddi|zuHause, we will merge it once we branched 1.9 I suggest :)
15:05:20  <Eddi|zuHause> i have no problem with that
15:05:28  <frosch123> wrt. committing translations: if you change translations via push, eints will take the new translations; touching invalid strings has no effect. eints will remove them now even if you did not
15:06:07  <Beerbelott> Is there a way to get credentials to have access to the Web translator?
15:06:21  <glx> would be nice if "copy base" button could convert string commands to {STRING} :)
15:06:30  <Eddi|zuHause> yes, you write an email to the translations manager
15:06:43  <TrueBrain> Beerbelott: https://www.openttd.org/contact.html <- contact the Translations Manager
15:07:02  <Eddi|zuHause> pro tip: don't ask who the translations manager is
15:07:03  <Beerbelott> thx
15:07:10  <Eddi|zuHause> especially if you are finnish :p
15:07:25  <TrueBrain> you can ask; just the answer is always the same :)
15:07:49  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7279: Fix #7062: Remove ship max order distance. https://git.io/fhxfU
15:08:04  <Beerbelott> TrueBrain: OK thx, better not to lose my time on that then
15:08:21  <Beerbelott> I appreciate you don't send me in a wall ;)
15:09:57  <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #7302: Change: make crash chance at short runway independent of plane crash … https://git.io/fhxfq
15:10:44  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7302: Change: make crash chance at short runway independent of plane crash … https://git.io/fhxfY
15:11:26  <Samu> oh well, I better go, I need to calm down
15:11:28  <Samu> afk
15:12:09  <TrueBrain> yes, you do
15:13:45  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7302: Change: make crash chance at short runway independent of plane crash … https://git.io/fhxfO
15:14:09  <LordAro> afternoon
15:14:14  <TrueBrain> howdie LordAro
15:15:09  <DorpsGek_II> [OpenTTD/OpenTTD] Berbe commented on pull request #7302: Change: make crash chance at short runway independent of plane crash … https://git.io/fhxf3
15:15:47  <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on pull request #7302: Change: make crash chance at short runway independent of plane crash … https://git.io/fhxfs
15:16:16  <TrueBrain> lol @ LordAro :) You are not wrong there :D
15:16:18  <Beerbelott> andy got angry, now Samu
15:16:32  <Beerbelott> WTH is happening today? New moon? :p
15:16:41  <LordAro> oh, have i missed some drama?
15:17:40  <Eddi|zuHause> just the usual, andy getting oversaturated by an overeager wannabe-contributor with low-quality contributions
15:17:47  <Eddi|zuHause> nothing that hasn't happened before
15:17:55  <DorpsGek_II> [OpenTTD/OpenTTD] Berbe commented on pull request #7302: Change: make crash chance at short runway independent of plane crash … https://git.io/fhxfn
15:18:04  <TrueBrain> and I went through the list of PRs and just closed everything that needed closing :)
15:19:08  <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on pull request #7302: Change: make crash chance at short runway independent of plane crash … https://git.io/fhxfc
15:19:49  * LordAro notes the 1.9 milestone is complete
15:19:51  <Beerbelott> Talking about low-quality contributions, I added feature commit to thePR #7286... which kinda overhauls how file are loaded with the -g switch. Is this acceptable?
15:19:52  <LordAro> branch time?
15:20:15  <TrueBrain> LordAro: I did my best to do the hard work; now it is your job :P
15:20:43  <TrueBrain> we postponed a few from 1.9 to 1.10, like ICU
15:20:47  <TrueBrain> thought it was the right thing to do
15:20:49  <LordAro> mm
15:20:49  <Eddi|zuHause> Beerbelott: feels like a separate PR?
15:21:19  <LordAro> i personally have no issues with "separate but related" things being in the same PR
15:21:27  *** gelignite has quit IRC
15:21:30  <LordAro> as long as they're in separate commits
15:21:36  <TrueBrain> as long as it remains in a state of "being able to review" :D
15:21:48  <TrueBrain> and you have to understand it can mean that because of the unrelated change, the whole PR can block
15:21:53  <LordAro> TrueBrain: there was a red cross on the last commit of master due to azure/github failure, i'll branch if that gets a tick :)
15:22:04  <Eddi|zuHause> well, it can stay there, as long as the consensus doesn't result in "we want one, but not the other"
15:22:19  <Eddi|zuHause> or the discussion gets too cross-talk-y
15:23:26  <LordAro> ^
15:23:40  <Eddi|zuHause> it's probably bettter in the same PR if it is prone to merge conflicts due to changing related areas
15:24:05  <LordAro> i have a suspicion the answer may well be "we want one, but not the other", but we'll see
15:24:07  <TrueBrain> balancing act :D
15:24:52  <TrueBrain> LordAro: did you retrigger it?
15:24:54  <Beerbelott> Eddi|zuHause: Well mb splitting up? Adding the FiosGetScenarioListCallback & FiosGetHeightmapListCallback calls are merely extending functionality to encompass being able to load heightmap from CLI. I would agree that the rest (allowing to load by name w/o path when in scannedfolders + ability to load by title) could be split off
15:24:57  <TrueBrain> I never seen that work :D
15:25:23  <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry updated pull request #7165: [core] Implement SmallVector using std::vector https://git.io/fhSz0
15:25:46  <Beerbelott> LordAro: Yes I signalled that error yday night, but I pushed again this morning and the compilatio nworked, this time
15:25:49  *** m3henry has joined #openttd
15:25:54  <Beerbelott> seems a bit random :D
15:26:17  <Beerbelott> TrueBrain: No I pushed again earlier
15:26:27  <TrueBrain> LordAro: you saw the question frosch123 had about stable releases?
15:26:31  <Eddi|zuHause> probably wrong moon phase/ascendant
15:26:37  <TrueBrain> Beerbelott: I am not sure what you are answering on? (sorry)
15:26:58  <Beerbelott> the Azure error, when u asked LordAro if he triggered it again
15:27:16  <TrueBrain> yes; LordAro and me were talking about master failing to build :)
15:27:17  <Eddi|zuHause> Beerbelott: he's talking about a different occurance of that error
15:27:27  <Beerbelott> Oh sry. I shut up now :p
15:27:29  <TrueBrain> :D
15:27:35  <TrueBrain> cross-talk ;)
15:27:56  <DorpsGek_II> [OpenTTD/OpenTTD] frosch123 opened pull request #7317: Add: Detect stable tags automatically, and set the 'stable' flag in '… https://git.io/fhxfu
15:28:22  <frosch123> ^^ can someone please test that on windows :)
15:28:42  <TrueBrain> frosch123: how about doing the whole newgrf version based on findversion?
15:28:54  <Eddi|zuHause> how does stable detection work from src bundles without git?
15:29:04  <TrueBrain> Eddi|zuHause: source bundles have a .ottdrev file in them
15:29:06  <glx> .ottdrev
15:29:08  <TrueBrain> which stores the content of findversion.sh
15:29:10  <Beerbelott> Eddi|zuHause: Well I'll leave my PR as it is, because it feels strange to split that up... I'll let experience reviewer decide on which path of action to follow
15:29:23  <Beerbelott> reviewerS* :D
15:29:44  <TrueBrain> frosch123: I guess based on the findversion information, we could set the whole value automagic? We can also keep those things for the CMake rewrite, as there it might be a bit easier to do these things
15:29:58  <glx> hmm in cmake branch how will we create .ottdrev ?
15:30:12  <TrueBrain> glx: FindVersion.cmake can be executed
15:30:18  <TrueBrain> (that is exactly what happens)
15:30:25  <frosch123> TrueBrain: "master" has no idea that it is 1.9
15:30:29  <TrueBrain> glx: that will be fine :)
15:30:42  <TrueBrain> frosch123: true
15:30:48  <glx> but it doesn't generate the string to put in .ottdrev I think
15:31:03  <TrueBrain> frosch123: well, in CMake we can at least automatically do the ASSERT stuff based on this new tag :)
15:31:13  <TrueBrain> glx: we fix that when we get there :)
15:31:18  <TrueBrain> just a matter of doing, honestly
15:31:23  <glx> true
15:31:34  <TrueBrain> I mean .. -DGENERATE_OTTDREV
15:31:37  <glx> at least it can read the file already
15:31:43  <TrueBrain> just to blab out a random solution :)
15:32:26  <nielsm> and now I have music playing through a non-General MIDI sound module :D
15:32:29  <nielsm> from 1988
15:32:32  <TrueBrain> I like how you are automating this a bit more frosch123 :) I think that is a good goal .. that things just "work" :)
15:32:55  <TrueBrain> nielsm: right, I almost forget to ask: can we drop timidity and extmidi support from OpenTTD? Is fluidsynth enough? :D
15:33:12  <Beerbelott> How come https://github.com/OpenTTD/OpenTTD/pull/7286/checks?sha=d895e83291abac766f9d4591a904b19e9dd2df4b is empty? Aren't all commits individually checked?
15:33:37  <TrueBrain> Beerbelott: only the HEAD of a PR is checked
15:33:54  <nielsm> TrueBrain: libtimidity only works/worked with the PSP port for some reason
15:33:59  <nielsm> extmidi is a silly thing
15:34:07  <TrueBrain> k; I will remove it :)
15:34:14  <TrueBrain> I couldn't find libtimidity, which annoyed me
15:34:17  <TrueBrain> and extmidi is .. very odd :P
15:34:29  <Beerbelott> OK thx. But yesterday on HEAD fail, the second commit was checked... Would not it be more logical to just discard that and consider the PR faield anyway?
15:34:35  <nielsm> otoh support for alsa or jack midi ports might be a good idea
15:34:50  <Beerbelott> (and that would remove load from check farm)
15:34:52  <TrueBrain> nielsm: but that requires changes, not?
15:35:03  <nielsm> yea
15:35:09  <TrueBrain> Beerbelott: I cannot parse what you said there, sorry :(
15:35:20  <TrueBrain> nielsm: k :) Tnx for the info!
15:35:31  <LordAro> frosch123: doesn't seem to be working on mingw, findversion.sh is returning 1 for stable_tag, but rev.cpp is still 0...
15:36:11  <Eddi|zuHause> TrueBrain: i think he means "if commit-checker fails, cancel the compilation checks"?
15:36:17  <TrueBrain> frosch123: "If stable_regexp.Test(filename) Then" <- filename?
15:36:21  <TrueBrain> shouldnt that be "tag"?
15:36:29  <frosch123> yep, c&p
15:37:10  <TrueBrain> Eddi|zuHause: ah; that keeps popping up. but yeah, that is both impracticable to implement, and doesn't really help/fix anything :)
15:37:54  <TrueBrain> it is this: delay everything with 5 minutes for the odd case someone fails the commit-checker .. or assume the failing of the commit-checker is the rare situation, and save 5 minutes in 90% of the cases :)
15:38:04  <LordAro> frosch123: oh wait, rev.cpp only gets updated when you actually build, carry on :)
15:38:16  <TrueBrain> ghehe :)
15:38:55  <frosch123> hmm, different issue: when i make two tags "1.9.0-RC1" and "1.9.0" referring to the same hash, findversion reports always the same one
15:39:25  <TrueBrain> we can never have those two tags on the same commit currently :)
15:39:26  <frosch123> hmm. nevermind, we always update the changelog with "(no changes)"
15:39:39  <frosch123> so rc will never equal the release
15:39:52  <TrueBrain> and we have to bump os/debian
15:39:54  <TrueBrain> NSIS ...
15:39:55  <TrueBrain> ;)
15:39:56  <TrueBrain> :D
15:40:05  <LordAro> https://dev.azure.com/openttd/OpenTTD/_build/results?buildId=1742&view=logs&jobId=a5e52b91-c83f-5429-4a68-c246fc63a4f7&taskId=bde16fc7-7659-5b1c-12aa-0110866d993c&lineStart=575&lineEnd=576&colStart=1&colEnd=1 hmm, why isn't the OSX build picking up static_assert...
15:40:26  <Eddi|zuHause> we might need an "1.10-alpha" tag for git-describe to be meaningful?
15:41:00  <DorpsGek_II> [OpenTTD/OpenTTD] frosch123 updated pull request #7317: Add: Detect stable tags automatically, and set the 'stable' flag in '… https://git.io/fhxfu
15:41:01  <TrueBrain> Eddi|zuHause: otherwise the master remains '1.9', which is odd indeed
15:41:45  <Eddi|zuHause> in SVN we always had a "trunk is heading for 1.(x+1) now" commit which updated some numbers
15:42:06  <Eddi|zuHause> which could get this tag
15:42:16  <LordAro> i think that'll still be necessary regardless
15:42:17  <TrueBrain> I would also like it if os/debian wasgenerated from such tag
15:42:22  <TrueBrain> so we dont need to bump it constantly
15:42:35  <TrueBrain> but .. we can figure that out in 1.10
15:42:36  <nielsm> could make a tag 1.10-begin right after the branch?
15:43:57  <LordAro> oh hang on, mingw failed to build
15:44:18  <TrueBrain> nielsm: 1.10-prealpha? :D
15:44:28  <Eddi|zuHause> nielsm: well, "alpha" sounds better than "begin"
15:44:49  <Eddi|zuHause> TrueBrain: we don't have anything else that is called "alpha", so why "pre"?
15:44:59  <LordAro> TrueBrain: we/you forgot to update config.lib for #7308 ^^
15:45:40  <LordAro> PR incoming...
15:45:58  <TrueBrain> Eddi|zuHause: BECAUSE! :D
15:46:06  <Eddi|zuHause> best reason.
15:47:15  <LordAro> alpha is also before beta
15:47:34  <TrueBrain> Eddi|zuHause: I was not being serious btw :)
15:47:52  <Eddi|zuHause> that is the default assumption, remember? :p
15:51:18  <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z commented on pull request #7302: Change: make crash chance at short runway independent of plane crash … https://git.io/fhxfd
15:51:23  <glx> hmm annoying steam popups ;)
15:52:49  <Eddi|zuHause> settings->interface->annoy me about updates->uncheck
15:53:16  <glx> it's usually ok, unless some one restart continuously a game :)
15:54:45  <Eddi|zuHause> the worst part i have seen so far is if you "follow" a game, you get not only update posts, but also "event notifications" which you cannot separately disable
15:56:32  <DorpsGek_II> [OpenTTD/OpenTTD] LordAro opened pull request #7318: Fix #7308: MinGW build with SDL https://git.io/fhxfj
15:56:43  <Beerbelott> TrueBrain: Yesterday, I got a fail on my PR HEAD commit due to some fail to get some Azure container or sth like that. When that happened, checks were triggered on the 2nd commit. Isn't that a waste of resources?
15:57:45  <milek7> macincloud pricing is weird: "Managed Server Plan": /month, "Pay-as-You-Go": /hour = 0/month
15:58:00  <LordAro> Beerbelott: not our resources to waste :)
15:58:20  <milek7> and "Pay-as-You-Go" anyway requires to buy minimum 30 hours
15:58:58  <glx> silly pricing
15:59:13  <glx> the less you may need it, the more you have to pay
15:59:31  <LordAro> makes sense from a server provisioning point of view
16:00:28  *** supermop_Home_ has quit IRC
16:00:34  <glx> but 750 vs 20
16:00:56  <LordAro> that does seem quite high
16:01:26  <glx> or 720 is the full month, with minimum of 30
16:02:07  <Eddi|zuHause> i read that as "minimum 30$, max 720$"
16:02:29  <glx> yes makes more sense, and seems reasonnable
16:02:31  <peter1138> jack-midi is not really useful for a game.
16:02:46  <peter1138> I had a patch YEARS ago to output audio through jack too, but it's not for gaming :p
16:03:00  <glx> music with belugas ?
16:03:02  <peter1138> Just another complicated codepath we didn't need.
16:03:05  <peter1138> Hehe :D
16:03:08  <milek7> ah, there is hidden print
16:03:09  *** Wormnest has joined #openttd
16:03:33  <Eddi|zuHause> milek7: i'd assume the 20$ plan has some limits
16:03:43  <milek7> 3-Hour Daily Limit - .00 USD per month per server
16:03:49  <milek7> No Daily Limit - .00 USD per month per server
16:04:15  <milek7> so it's  vs 720$, still weird
16:05:43  <glx> depends on your needs
16:06:15  <peter1138> extmidi is a bit nasty but does let you use pmidi if you want to use an external synth.
16:06:40  <peter1138> libtimidity can probably go?
16:07:05  <LordAro> probably
16:07:50  <peter1138> It was only ever enabled for PSP support, IIRC.
16:07:57  <peter1138> And who even builds that?
16:08:04  <peter1138> Maybe it's built on Linux these days.
16:08:13  <glx> we droped it some time ago IIRC
16:08:17  <Beerbelott> milek7: They want to ensure minimum monthly income, making flexibility of per hour pricing a feature to pay extra for
16:08:46  <peter1138> Do I need a 'working' Lego wind turbine?
16:08:54  <peter1138> It has a motor, so it's not really working, heh.
16:09:26  <milek7> i need to get sse4.1 cpu and install macos on vm
16:09:43  <peter1138> Hmm
16:09:49  <LordAro> libtimidity basically doesn't exist any more, as best as i can tell
16:10:25  <peter1138> *nod*
16:10:28  <peter1138> Drop it! :D
16:10:36  <peter1138> libfluidsynth works very well.
16:11:55  <Eddi|zuHause> peter1138: every motor is also a generator :)
16:12:53  <nnyby> libtimidity can go.. it's not even available in standard distros anymore. but it has been worked on recently: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=921597
16:14:00  <LordAro> Eddi|zuHause: i suspect peter1138 cannot generate the wind speeds required to make a lego motor into a generator :p
16:14:43  <peter1138> Depends how many brussels I ate.
16:15:54  <Eddi|zuHause> *würg*
16:16:03  <DorpsGek_II> [OpenTTD/OpenTTD] Berbe updated pull request #7286: Add #2155: newheightmapgame command https://git.io/fhNZl
16:16:49  *** supermop_Home_ has joined #openttd
16:21:55  *** Wormnest has quit IRC
16:23:00  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7317: Add: Detect stable tags automatically, and set the 'stable' flag in '… https://git.io/fhxJw
16:27:48  <Eddi|zuHause> the "independent" font size is weird, because it doesn't affect some symbol buttons like the "x" or dropdown menus
16:29:22  <nielsm> never had this disaster in sc2k before https://0x0.st/zobD.jpg
16:30:25  <glx> Eddi|zuHause: yes those are sprites
16:31:10  <Eddi|zuHause> nielsm: it's been so long ago, i honestly can't remember
16:31:41  *** Wormnest has joined #openttd
16:32:15  <supermop_Home_> is there so reason the terrain generator wont make mountains taller than 16 when I have max height set to 100?
16:32:38  <Eddi|zuHause> default or tgp?
16:33:27  <Eddi|zuHause> the original one uses heightmap sprites, which don't contiain larger ones
16:34:48  <supermop_Home_> nielsm: apparently your city is using Fahrenheit and miles per hour, but millimeters for precipitation huh?
16:36:05  <supermop_Home_> Eddi|zuHause terragenesis
16:36:58  <supermop_Home_> it will let me raise the land after the fact but they generate with flat-tops at level 16
16:38:01  <supermop_Home_> per the guy in the firs thread, I can build a dredging site at height 16, but not fishing grounds. Fishing grounds can be built at level 1 though
16:39:56  <Eddi|zuHause> where do you even set the heightlevel?
16:42:17  <Eddi|zuHause> ok, so my max height is 32, and terrain set to "alpine", and the highest i can find on a 1024^2 map is 23
16:42:48  <Eddi|zuHause> oh, there's a 26
16:43:01  <Eddi|zuHause> and a 28
16:43:40  <Eddi|zuHause> oooh... found a 31
16:44:00  <glx> depending on map size it may be hard to reach the highest level
16:45:09  <Eddi|zuHause> still generating a weird flat mountaintop
16:45:41  <Eddi|zuHause> and these weird rugged coast lines
16:46:26  <Eddi|zuHause> i'm considering reading up on how perlin noise is actually meant to work...
16:46:28  <glx> I think a max height of 100 need at least 100 tiles, 200 without freeform edge probably
16:46:33  <nielsm> apropos plane crashes https://0x0.st/zobC.jpg
16:47:44  <Eddi|zuHause> so you didn't even name the mayor?
16:48:03  <nielsm> nope :(
16:48:12  <Beerbelott> :D
16:48:23  <nielsm> my original diskettes are dead so I've had to pirate a copy
16:49:02  <Beerbelott> THe 'bum' town name shows high levels of creativity too :p
16:50:26  <TrueBrain> LordAro: you are sneaking in a lot of changes in a single commit :D
16:51:11  <Eddi|zuHause> nielsm: i'm not 100% sure, but i think i still have my originally pirated copy, copied around over various computers :p
16:51:12  <LordAro> TrueBrain: 3 commits seemed excessive
16:51:54  <TrueBrain> yeah, not for this stuff, I am afraid .. as I had to look real long to see what the fix was, and what your OCD was :D
16:52:21  <LordAro> bleh, fine
16:52:23  <LordAro> :p
16:52:49  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain requested changes for pull request #7318: Fix #7308: MinGW build with SDL https://git.io/fhxJp
16:53:18  <nielsm> https://0x0.st/zoco.png
16:53:22  <nielsm> yay
16:53:29  *** snail_UES_ has joined #openttd
16:54:02  <DorpsGek_II> [OpenTTD/OpenTTD] glx22 commented on pull request #7317: Add: Detect stable tags automatically, and set the 'stable' flag in '… https://git.io/fhxJh
16:54:12  <TrueBrain> okay, too much VR makes me a bit .. I need to puke :P
16:55:07  <TrueBrain> ah, okay, zlib worked because it is doing ${zlib}-config
16:55:09  <TrueBrain> which is never empty
16:55:10  <TrueBrain> silly
16:56:21  <TrueBrain> and --static-libs doesn't exist for my pkg-config
16:56:30  <TrueBrain> but does for sdl-config
16:56:31  <TrueBrain> weird :P
16:56:42  <TrueBrain> --libs --static does not work
16:56:44  <supermop_Home_> i set it to 256x256, mountanous
16:56:46  <supermop_Home_> https://imgur.com/a/bJH1WZV
16:56:53  <Eddi|zuHause> <TrueBrain> okay, too much VR makes me a bit .. I need to puke :P <-- try one of those travel pills? :p
16:56:54  <TrueBrain> so LordAro, did you test your 'static' change?
16:57:22  <supermop_Home_> the tallest mountains have large flattened tops, where it seems they should continue upwards
16:57:27  <LordAro> TrueBrain: yeah
16:57:41  <Eddi|zuHause> supermop_Home_: yeah, TGP is a bit weird about that
16:57:47  <LordAro> $sdl_config has been pkg-config since 2015
16:57:54  <TrueBrain> LordAro: so the static part never worked
16:57:57  <TrueBrain> lol
16:57:59  <supermop_Home_> i don't expect an actual 100  tall mountain at 256x256, but at least something like 30
16:57:59  <LordAro> yup
16:58:10  <LordAro> TrueBrain: you can add static builds to the list of things that still need to be CI'd :p
16:58:11  <TrueBrain> so yeah, 3 commits, and I am fine with it :)
16:58:31  <TrueBrain> it still is an open ticket ;) Feel free to contribute :)
16:58:45  <Eddi|zuHause> supermop_Home_: tried different smoothness/hilliness settings?
16:59:59  <DorpsGek_II> [OpenTTD/OpenTTD] LordAro updated pull request #7318: Fix #7308: MinGW build with SDL https://git.io/fhxfj
17:00:26  <supermop_Home_> nielsm, from 2047 to 2057 the cost of the paper went from a quarter to a dollar?
17:00:26  <LordAro> oh, i meant to use 8 chars for the commit reference, oh well
17:00:52  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain approved pull request #7318: Fix #7308: MinGW build with SDL https://git.io/fhxU3
17:00:55  <TrueBrain> tnx LordAro
17:01:20  <supermop_Home_> Eddi|zuHause i have 'mountainous' and 'rough' and 'medium' for variety distribution
17:02:14  <Eddi|zuHause> supermop_Home_: on 1024^2 with 64 levels and mountaineus/smooth i get about 40 as highest (with medium variety)
17:02:41  <supermop_Home_> with alpinist, rough, medium i get 19 but it is still kind of flat on top
17:03:57  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7302: Change: make crash chance at short runway independent of plane crash … https://git.io/fhxU8
17:04:11  <supermop_Home_> alpinist, very rough, very high i get 17
17:04:53  <Eddi|zuHause> which version?
17:08:04  <supermop_Home_> 1.9.0b3
17:08:33  <supermop_Home_> but its not flat any more on those settings at least
17:11:12  <supermop_Home_> i guess the answer is 'terra genesis generates unsatisfying terrain a lot of the time' which isn't really news
17:11:37  <Eddi|zuHause> supermop_Home_: try the different variety distributions
17:14:21  <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z updated pull request #7302: Change: make crash chance at short runway independent of plane crash … https://git.io/fhALz
17:14:27  <DorpsGek_II> [OpenTTD/OpenTTD] glx22 commented on pull request #7286: Add #2155: newheightmapgame command https://git.io/fhxUu
17:15:36  <TrueBrain> I wish you could approve a PR, but that the milestone kept it from being mergable
17:15:38  <TrueBrain> that would be nice ..
17:15:40  <TrueBrain> owh well
17:16:27  <LordAro> heh
17:17:18  <Eddi|zuHause> TrueBrain: probably not a thing the inventor of the milestone feature had in mind :)
17:18:06  <Eddi|zuHause> he probably meant "no later than milestone N", not "no earlier than milestone N-1"
17:18:36  <Samu> what do you think of this? https://github.com/SamuXarick/OpenTTD/compare/large-plane-on-short-runway?expand=1
17:23:26  <LordAro> Samu: i don't believe any such setting is ever going to get merged, for the all the previously mentioned reasons - it's too exploitable
17:24:00  <LordAro> though thank you for checking before opening a pull request
17:24:16  <Samu> :)
17:30:25  <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry updated pull request #7165: [core] Implement SmallVector using std::vector https://git.io/fhSz0
17:30:33  <m3henry> Done.
17:33:17  <LordAro> :o
17:33:27  <LordAro> now rebase it!
17:37:03  <glx> m3henry: you can remove S from all templates that were using SmallVector I think
17:42:43  *** keoz has quit IRC
17:45:07  <DorpsGek_II> [OpenTTD/OpenTTD] michicc commented on pull request #7306: Add: Chrono based TIC() and TOC() in debug https://git.io/fhxTv
17:55:34  <Beerbelott> glx: Thx for your pointer... those conditiions on  PR #7286 are abit messy
17:56:41  <Beerbelott> I am in the process of attempting to validate a lot of different cases... I wonder: is there a possibility to check game mode w/ scripts to make automated tests fro mthem? Could be nice to automate that, making sure CLI is not broken and behaves as intended...
17:57:54  <Eddi|zuHause> i don't think you can run scripts in scenario editor
17:58:38  <glx> yes scripts usually run in GM_NORMAL mode
17:59:12  <glx> and have no access to switch mode
17:59:52  <Beerbelott> OK
18:00:09  <Beerbelott> I suppose using the DEBUG facility and parsing the output might be feasible?
18:00:15  <Beerbelott> facilities*
18:00:38  <glx> but I think your current error should be spotable with "-e -g"
18:00:58  <Beerbelott> errors*
18:01:08  <glx> as you probably won't be in scenario editor
18:01:14  <Beerbelott> the switchs for the 'advanced' mode using name & title are also wrong
18:01:22  <Beerbelott> yes I was
18:01:39  <Beerbelott> .. I think?
18:01:49  <Beerbelott> well too much commits/branching around ^^
18:04:39  <DorpsGek_II> [OpenTTD/OpenTTD] LordAro merged pull request #7318: Fix #7308: MinGW build with SDL https://git.io/fhxfj
18:05:41  <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on pull request #7317: Add: Detect stable tags automatically, and set the 'stable' flag in '… https://git.io/fhxTW
18:10:16  <DorpsGek_II> [OpenTTD/OpenTTD] frosch123 commented on pull request #7317: Add: Detect stable tags automatically, and set the 'stable' flag in '… https://git.io/fhxTB
18:16:28  <Beerbelott> If you put a savegame into a tar archive along w/ .id & . title files, is that supported?
18:19:01  <Eddi|zuHause> why did i just watch a video called "why does appendicitis decrease" when the video explains how it increased in the first place and ends with "why does it drop? we basically don't know"
18:19:49  *** keoz has joined #openttd
18:20:46  *** J0anJosep has quit IRC
18:21:00  <LordAro> Eddi|zuHause: i feel only you can answer that question
18:21:28  <Eddi|zuHause> well... i basically don't know :p
18:23:53  *** Wormnest has quit IRC
18:24:38  *** gelignite has joined #openttd
18:25:22  <DorpsGek_II> [OpenTTD/OpenTTD] Berbe updated pull request #7286: Add #2155: newheightmapgame command https://git.io/fhNZl
18:44:26  <peter1138> Hi.
18:45:45  <peter1138> Oh, whoops, I left OpenTTD connected to openttdcoop this morning...
18:46:44  <LordAro> what year is it?
18:47:22  <DorpsGek_II> [OpenTTD/OpenTTD] GabdaZM updated pull request #7306: Add: Chrono based TIC() and TOC() in debug https://git.io/fhA6p
18:47:37  <Eddi|zuHause> something around 2009?
18:47:55  <peter1138> 21something
18:50:15  <peter1138> I have we branched yet?
18:50:19  <DorpsGek_II> [OpenTTD/OpenTTD] GabdaZM commented on pull request #7306: Add: Chrono based TIC() and TOC() in debug https://git.io/fhxkc
18:51:08  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7317: Add: Detect stable tags automatically, and set the 'stable' flag in '… https://git.io/fhxkW
18:51:19  <LordAro> peter1138: i'm not sure what's happening with #7317, or i would've done
18:52:02  * peter1138 tests 7317
18:52:05  <peter1138> Hmm>
18:52:09  <peter1138> What do you mean?
18:52:15  <peter1138> Oh, branched.
18:52:19  <peter1138> Sorry, forgot I asked :D
18:52:24  <peter1138> Yeah, we should get that in first.
18:52:46  <peter1138> OpenTTD 2.0
18:52:47  <peter1138> Hahah
18:53:38  <LordAro> :p
18:53:41  <peter1138> Newgrf version is 1.9.0.1
18:53:44  <peter1138> o_O
18:53:54  <peter1138> I guess the rest of that is still manual, heh.
18:54:25  <peter1138> Ok, so 7317 is purely about Newgrf version.
18:54:30  <peter1138> I guess it's hardly critical lol
18:54:34  <DorpsGek_II> [OpenTTD/OpenTTD] frosch123 opened pull request #7319: Change: Heading for 1.10 now https://git.io/fhxk2
18:54:34  <peter1138> But it work son Linux
18:54:42  <frosch123> LordAro: ^^ first PR after branch :p
18:54:57  <frosch123> though it will conflict with the other PR
18:55:02  <peter1138> Do I need to test on Windows as well or is that done?
18:55:06  <LordAro> frosch123: lol
18:55:13  <frosch123> peter1138: MSVC is untested
18:55:47  <peter1138> Ok
18:56:40  <peter1138> I'll let you know in a sec :D
18:57:52  <LordAro> huzzah
18:57:53  <peter1138> Weird how I'm running on Windows, I have MVSC 2017, but I also have a Linux VM... and I use vim under Linux to do all my devving.
18:58:00  <peter1138> Cos, well, MSVC smells.
18:59:08  <peter1138> Nope, still 1.9.0.0
18:59:24  <peter1138> It did regenerate rev.cpp
19:00:14  <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry updated pull request #7165: [core] Implement SmallVector using std::vector https://git.io/fhSz0
19:01:43  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7317: Add: Detect stable tags automatically, and set the 'stable' flag in '… https://git.io/fhxkX
19:02:42  <peter1138> Um.
19:03:06  <peter1138> I got confused :p
19:03:35  <peter1138> 7317 is not 7137.
19:04:41  <TrueBrain> levenshtein distance .... what can you do about it
19:05:28  <frosch123> TrueBrain: is it possible to disable assertions via the compilefarm when building stable tags?
19:05:38  <TrueBrain> frosch123: not with the current MSVC project files, no
19:05:43  <TrueBrain> with CMake, it will
19:05:44  <Eddi|zuHause> that's why things like ISBN have a checksum that spots flipped digits :)
19:05:45  <TrueBrain> so for 1.10 we can fix this
19:05:51  <TrueBrain> for 1.9, I don't see a way to do so
19:06:11  <frosch123> ok, then i suggest we disable assertions in the 1.9 branch after the last rc
19:06:23  <TrueBrain> that sounds like a fine solution
19:06:34  <peter1138> Yeah, we probably need them for the RCs :-)
19:07:09  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7317: Add: Detect stable tags automatically, and set the 'stable' flag in '… https://git.io/fhxkH
19:07:17  <peter1138> There we go. It does work.
19:07:28  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN approved pull request #7317: Add: Detect stable tags automatically, and set the 'stable' flag in '… https://git.io/fhxk7
19:07:55  <TrueBrain> frosch123: I added it to the CMake PR, so we don't forget to add that :)
19:08:30  <DorpsGek_II> [OpenTTD/OpenTTD] frosch123 merged pull request #7317: Add: Detect stable tags automatically, and set the 'stable' flag in '… https://git.io/fhxfu
19:08:39  <peter1138> Can't we provide environment variables to ./configure on the build farm?
19:08:47  <TrueBrain> not to MSVC project files
19:08:53  <peter1138> Oh :(
19:08:57  <peter1138> Fair enoguh.
19:09:04  <TrueBrain> that is one of the things CMake fixes :)
19:09:12  <peter1138> And not worth expending much effort when we are going to switch to CMake anyway.
19:09:31  <TrueBrain> well, the effort is switching :D But not worth the effort for 1.9 in my opinion
19:09:34  <peter1138> Who's got me as a friend on Steam?
19:09:37  <TrueBrain> one last time doing it to old way ...
19:09:47  <TrueBrain> friends? That concept is rather unknown to me :P
19:10:09  <Xaroth> He means "People you generally cuss at less frequently than others" .
19:10:10  <peter1138> I've got VR, but I'm too lazy to fire that up, so...
19:10:24  <peter1138> Derail Valley in pancake mode it is.
19:10:44  <TrueBrain> pancake mode :D
19:11:16  <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry updated pull request #7165: [core] Implement SmallVector using std::vector https://git.io/fhSz0
19:11:18  <TrueBrain> LordAro: after branching you immediately want to do an RC? (well, after a PR in the branch, ofc)
19:11:33  <Eddi|zuHause> is that like pancake earth?
19:11:51  <LordAro> TrueBrain: no reason why not, imo
19:13:05  <peter1138> This is so cool, way more fleshed out than the demo.
19:13:09  <peter1138> And it loads faster, heh.
19:13:58  <LordAro> Xaroth: :D
19:14:00  <DorpsGek_II> [OpenTTD/OpenTTD] frosch123 updated pull request #7319: Change: Heading for 1.10 now https://git.io/fhxk2
19:14:31  <TrueBrain> owh, I have one more thing to fix btw
19:15:30  <peter1138> I like the fact that kept teleporting even for pancake.
19:15:52  <snail_UES_> hi guys, question about railtype introduction date
19:16:09  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain opened pull request #7320: Fix: [AzurePipelines] also trigger CI on release branches https://git.io/fhxkA
19:16:13  <snail_UES_> I’m setting my high-speed railtype to be introduced in 1970, but in the game, it is actually introduced much earlier
19:16:14  <TrueBrain> that might also be useful ^^ :)
19:16:22  <LordAro> TrueBrain: pfft
19:16:35  <peter1138> snail_UES_, it is introduced when a vehicle of that type is introduced.
19:16:36  <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #7320: Fix: [AzurePipelines] also trigger CI on release branches https://git.io/fhxkx
19:16:48  *** supermop_Home_ has quit IRC
19:16:57  <TrueBrain> I am just happy I remembered before branching :D
19:16:57  <snail_UES_> peter1138: thing is, there are no vehicles of that railtype in the set whatsoever
19:17:24  <snail_UES_> all of my vehicles are coded as “normal speed”; some vehicles are crippled outside of the high-speed tracks
19:17:31  <TrueBrain> btw, LordAro, you can create branches via the GitHub Website, as a FYI :)
19:17:43  <snail_UES_> because the concept behind my “normal speed” tracks includes “low maximum axle weight"
19:17:46  <LordAro> TrueBrain: i know :p
19:18:00  <TrueBrain> we will have to see how we are going to backport things btw .. currently it has to be done via PRs, but that might not be ideal
19:18:07  <TrueBrain> but .. that is for RC2 :P
19:18:20  <LordAro> TrueBrain: mm...
19:19:26  <snail_UES_> so how can I get introduction date enforced, even if the set includes no vehicles of that specific railtype (but that railtype is compatible with others)?
19:19:53  <peter1138> Hmm
19:20:14  <peter1138> I... think that needs changes.
19:20:39  <peter1138> And we're just about branching for 1.9 so maybe a little late :(
19:20:56  <snail_UES_> bummer…
19:21:45  <snail_UES_> will a posting on the forum help expedite this? it would be useful not just for my set
19:22:12  <LordAro> filing an issue on GH would be more worthwhile
19:23:20  <LordAro> but even so, probably still not in 1.9
19:23:43  <LordAro> (1.10 is expected to break the preexisting yearly release cycle, if that helps)
19:24:49  <snail_UES_> ok, so I’ll open a new issue here —> https://github.com/OpenTTD/OpenTTD/issues
19:25:04  <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry updated pull request #7165: [core] Implement SmallVector using std::vector https://git.io/fhSz0
19:25:51  <TrueBrain> will we tag frosch123's PR as 1.10-alpha (once merged, ofc)
19:25:52  <TrueBrain> ?
19:26:06  <LordAro> TrueBrain: go over why that's necessary?
19:26:18  <TrueBrain> 'git describe', is one that comes to mind
19:26:42  <LordAro> how did it work before any 1.9 betas were tagged?
19:26:43  <TrueBrain> not sure it is necessary btw, but there was talk about it
19:26:48  <TrueBrain> and I mostly remembered that would generate a binary :P
19:27:01  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain merged pull request #7320: Fix: [AzurePipelines] also trigger CI on release branches https://git.io/fhxkA
19:27:05  <LordAro> do it if it appears necessary, imo
19:27:09  <LordAro> not before :p
19:27:20  <TrueBrain> well, if we want to do that, we have to change the CI/CD a bit
19:27:25  <TrueBrain> otherwise .. weird things happen :)
19:27:43  <LordAro> right then
19:27:45  <LordAro> branch time?
19:27:48  <frosch123> that PR is also meant to show that you cannot put "increment for next version" into a script
19:27:50  <TrueBrain> fine by me LordAro
19:27:51  <LordAro> last chance to object
19:28:03  <frosch123> LordAro: go ahead
19:28:42  <LordAro> \o/
19:29:18  <TrueBrain> now, quick, a PR for both branches!
19:29:28  <peter1138> snail_UES_, yes github issues are very much more likely to be seen than forum threads.
19:29:50  <snail_UES_> thanks
19:29:51  <peter1138> I suspect it will need a new flag to disable introduction with vehicle type.
19:29:59  <LordAro> TrueBrain: i didn't have a changelog ready :<
19:30:12  <peter1138> Hopefully it will be something easily backportable :-)
19:30:32  <peter1138> Also, I just cut up a ginormous sweet potato to make wedges, they're now sitting in the oven :D
19:30:40  <TrueBrain> LordAro: bad preparation, I see ...
19:31:26  <TrueBrain> good, CI/CD did not pick up the branch (it shouldn't :P)
19:31:51  <TrueBrain> LordAro: if you take care of the changelog, I will take care of the rest in a PR ;)
19:32:30  <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry updated pull request #7165: [core] Implement SmallVector using std::vector https://git.io/fhSz0
19:32:55  <peter1138> Ok, I bought Derail Valley. Played it for 5 minutes, now I'm thinking it's too much like hard work :(
19:32:59  <peter1138> I might refund it :p
19:33:06  <DorpsGek_II> [OpenTTD/OpenTTD] jcoletto77 opened issue #7321: RailTypes: Introduction date not enforced https://git.io/fhxIY
19:34:31  <TrueBrain> lol @ peter1138 :)
19:34:41  <TrueBrain> owh .. we still need a new OpenGFX .. and someone scared andy away :(
19:34:52  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on issue #7321: RailTypes: Introduction date not enforced https://git.io/fhxIs
19:35:21  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain opened pull request #7322: Update: Changelog for 1.9.0-RC1 and prepare for release. https://git.io/fhxIG
19:35:27  <TrueBrain> LordAro: ^^ only needs a changelog :)
19:35:35  <nielsm> peter1138 yeah it's absolutely a work simulator pretty much ETS2 on rails
19:35:48  <nielsm> but with more freedom
19:35:52  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7322: Update: Changelog for 1.9.0-RC1 and prepare for release. https://git.io/fhxIG
19:35:58  <nielsm> (you can't leave your truck in truck sim)
19:36:24  <peter1138> I wish you could.
19:36:32  <peter1138> Of course, ETS2's VR mode is half baked anyway.
19:36:42  <DorpsGek_II> [OpenTTD/OpenTTD] jcoletto77 commented on issue #7321: RailTypes: Introduction date not enforced https://git.io/fhxIZ
19:37:41  *** supermop_Home_ has joined #openttd
19:40:06  <michi_cc> TrueBrain: In theory something like https://gist.github.com/michicc/6e9e8701e0a6a6bafaa72cce09bd3e0e might work with Azure. Global variables are passed in as environment variables, at least for script elements. Couldn't find anything exact for vsbuild stuff though.
19:40:58  <TrueBrain> michi_cc: lol .. it always surprises how much magic people can do with MSVC :)
19:41:04  <LordAro> TrueBrain: https://gist.github.com/LordAro/68064a56f56e5f4a813d857c9fd06d75
19:41:27  <Eddi|zuHause> ok... dear astroneer physics... when i pick up my winch with an object attached, why does it flow who-knows-where when i pick it up, the object disconnects, and the object is nowhere to be seen anymore?
19:41:33  <michi_cc> MSBuild is a lot more powerful than what the VS IDE generates on its own.
19:41:38  <frosch123> LordAro: TrueBrain: s/vehciles/vehicles/
19:41:54  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7322: Update: Changelog for 1.9.0-RC1 and prepare for release https://git.io/fhxIG
19:42:11  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7322: Update: Changelog for 1.9.0-RC1 and prepare for release https://git.io/fhxIG
19:42:17  <LordAro> :)
19:42:36  <TrueBrain> michi_cc: still, I guess it is better to do it manually for one last time. Gives us more time to test things through etc :)
19:43:12  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on issue #7321: RailTypes: Introduction date not enforced https://git.io/fhxIE
19:43:23  <m3henry> LordAro: rebase and CI complete
19:43:45  <LordAro> m3henry: huzzah
19:43:55  <LordAro> thanks so much for doing all of that, it's a huge amount of work
19:44:30  <TrueBrain> so we can approve frosch123's patch too?
19:44:33  <nielsm> TrueBrain: "Allow towns to build brights"
19:44:36  <nielsm> brights = bridges
19:44:37  <TrueBrain> or does anyone really want to look if he didn't forget any? :P
19:45:05  <nielsm> and "Goto hanger orders" hanger = hangar
19:45:11  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7322: Update: Changelog for 1.9.0-RC1 and prepare for release https://git.io/fhxIG
19:45:25  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7322: Update: Changelog for 1.9.0-RC1 and prepare for release https://git.io/fhxIG
19:45:26  <TrueBrain> keep them coming
19:46:08  <m3henry> It was quite the marathon, especially Begin and End
19:47:12  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on issue #7321: RailTypes: Introduction date not enforced https://git.io/fhxI2
19:48:13  *** Alberth has left #openttd
19:50:06  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain approved pull request #7319: Change: Heading for 1.10 now https://git.io/fhxIX
19:51:28  <m3henry> On to the next crusade
19:51:43  <nielsm> can we merge all the pending PRs now? :D
19:51:59  <DorpsGek_II> [OpenTTD/OpenTTD] frosch123 merged pull request #7319: Change: Heading for 1.10 now https://git.io/fhxk2
19:52:09  <TrueBrain> nielsm: seems so
19:52:15  <TrueBrain> and if someone can approve RC1 ;)
19:52:32  <nielsm> so, NRT now? :3
19:53:08  <TrueBrain> fine by me, tbfh
19:53:33  <DorpsGek_II> [OpenTTD/OpenTTD] frosch123 approved pull request #7322: Update: Changelog for 1.9.0-RC1 and prepare for release https://git.io/fhxI7
19:53:42  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain merged pull request #7322: Update: Changelog for 1.9.0-RC1 and prepare for release https://git.io/fhxIG
19:54:07  <TrueBrain> tag created
19:54:24  <peter1138> NRT might need squashing :p
19:54:32  <peter1138> Or at least merging fixups.
19:54:49  <TrueBrain> but yeah, all the 1.10 can hit master now
19:57:13  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain approved pull request #7232: Change: Don't apply forbid 90 deg turn settings to ships. https://git.io/fhxIA
19:57:25  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain approved pull request #7302: Change: make crash chance at short runway independent of plane crash … https://git.io/fhxIx
19:57:33  <TrueBrain> lets approve the two most talked about PRs :P
19:58:33  <TrueBrain> before I hit merge, any real objections to me merging those 2?
19:58:50  <nielsm> good with me
19:59:01  <frosch123> https://wiki.openttd.org/To_do_for_releases <- updated that as far as i know
19:59:19  <TrueBrain> frosch123: <3
19:59:46  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain merged pull request #7232: Change: Don't apply forbid 90 deg turn settings to ships. https://git.io/fh7DC
19:59:53  <TrueBrain> merge conflict
19:59:54  <TrueBrain> darn it
20:00:02  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain merged pull request #7302: Change: make crash chance at short runway independent of plane crash … https://git.io/fhALz
20:00:05  <TrueBrain> there we go
20:01:15  <TrueBrain> @topic set 1 1.9.0-RC1, 1.8.0
20:01:15  *** DorpsGek changes topic to "1.9.0-RC1, 1.8.0 | Website: *.openttd.org (source: github, translator: translator, server list: servers, wiki: wiki) | Don't ask to ask, just ask | 'Latest' is not a valid version, 'Most recent' neither | English only"
20:03:09  <DorpsGek_II> [OpenTTD/OpenTTD] frosch123 commented on pull request #7301: Feature: When filtering purchase list by cargo type, make buy button perform a refit if required. https://git.io/fhxLL
20:04:11  <frosch123> has anyone ever used TIC/TOC?
20:04:26  <DorpsGek_II> [OpenTTD/OpenTTD] Berbe commented on pull request #7286: Add #2155: newheightmapgame command https://git.io/fhxLq
20:04:27  <frosch123> i only ever used callgrind
20:04:50  <Beerbelott> glx: Changes done, although functionality does not seem to be 100% :(
20:05:03  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #7306: Add: Chrono based TIC() and TOC() in debug https://git.io/fhAhJ
20:05:22  <TrueBrain> frosch123: I know of people who have used it :P
20:05:48  <TrueBrain> I always wonder if adding TIC/TOC in the codebase is useful, and if TICC/TOCC is ... but I guess it makes using it easier for when-ever ..
20:06:28  <frosch123> yeah, it just appeared samuesque to me to change them :p
20:06:43  <Beerbelott> Pun! I spot a pun!
20:07:04  <TrueBrain> I wish there was a voting system on GitHub
20:07:16  <TrueBrain> typical PR I want to give a -/+0 for
20:07:24  <peter1138> I use TIC/TOC
20:07:25  <michi_cc> TrueBrain: Just for the record (and without having verified the YML syntax), this would probably work: https://gist.github.com/michicc/6e9e8701e0a6a6bafaa72cce09bd3e0e
20:07:34  <peter1138> At least, in the past.
20:07:39  <peter1138> Mostly I just use the framerate window now ;)
20:07:52  <TrueBrain> michi_cc: except that that "stable" in azure pipelines is not the stable we need for this :D
20:07:55  <TrueBrain> it needs a new variable
20:08:37  <TrueBrain> beta/RC vs 'stable' .. both are in the set "stable" :D
20:09:04  <TrueBrain> anyway, what is currently missing in the CI, is to detect if it is a 'stable' (and not a beta or RC)
20:09:08  <TrueBrain> as the CI is triggered from a tag
20:09:51  <TrueBrain> here too, I know how to do that in CMake without issue .. but .. in the current setup .. not really sure :D
20:10:00  <Beerbelott> michi_cc: DisableAsserts is a char for '0' and an integer for 1
20:10:01  <TrueBrain> guess we can piggy back on the findversion output
20:10:22  <TrueBrain> but that variable needs to feed in the msbuildargument somehow ..
20:10:45  <TrueBrain> meh .. michi_cc: the more I think about this, the more difficult it gets :P
20:12:25  <michi_cc> Yeah, it's just a rough concept in case we ever need that. For 1.9 a single manual commit is a lot simpler :)
20:12:58  <TrueBrain> I am sure it is possible, but MSVC is too difficult for me :P
20:13:04  <TrueBrain> that is why I like CMake .. I understand that :D
20:13:10  <TrueBrain> (and it can produce MSVC project files pretty well :D)
20:13:49  <TrueBrain> but I will remember to knock on your door when we are fixing this michi_cc :D >:D
20:15:12  <TrueBrain> okay, RC1 seems to be compiled correctly \o/ :D
20:15:18  <TrueBrain> I am so happy with this new integration, you have no idea :)
20:15:33  <TrueBrain> no more annoying and complex things to configure Bamboo for every release ..
20:15:45  <TrueBrain> just 'tag' and done
20:17:12  <peter1138> :-)
20:17:52  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #6965: Add: Option for population-linear town cargo generation https://git.io/fpkqa
20:18:08  <LordAro> huzzah
20:21:12  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on issue #7321: RailTypes: Introduction date not enforced https://git.io/fhxLz
20:35:29  <TrueBrain> bah. Derail Valley keeps on crashing in VR
20:35:34  <TrueBrain> well, my computer crashes :P
20:35:53  <TrueBrain> well, my video memory runs out, and weird shit starts to happen :D
20:36:31  <TrueBrain> "Latest release in testing is 1.9.0-RC1, released on 2019-03-03 20:00 UTC." .. how ... that ... okay, cool :)
20:36:45  <TrueBrain> that was not planned, that exact time :P
20:37:10  <LordAro> :D
20:39:02  *** synchris has quit IRC
20:41:51  <peter1138> News article? ;)
20:44:01  <TrueBrain> yes please, if you can create one, would be lovely
20:45:47  <glx> again nightly=tag ?
20:46:28  <DorpsGek_II> [OpenTTD/OpenTTD] jcoletto77 commented on issue #7321: RailTypes: Introduction date not enforced https://git.io/fhxLH
20:51:41  <TrueBrain> glx: yeah ... no, I have no clue what you said there :)
20:53:53  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on issue #7321: RailTypes: Introduction date not enforced https://git.io/fhxLA
20:54:18  <peter1138> TrueBrain, nightly is the same version as RC1
20:54:43  <peter1138> But no. it's not.
20:54:44  *** gelignite has quit IRC
20:54:53  <peter1138> Nightly was at 7pm, not 8pm.
20:55:59  <glx> yeah was a misreading from me
21:00:14  <peter1138> :)
21:01:24  *** sla_ro|master has quit IRC
21:06:12  <peter1138> snail_UES_, where can I find your sets to test with?
21:06:31  <snail_UES_> on my thread in the forums… hold on
21:06:48  <peter1138> I have no idea what thread that would be.
21:06:57  <snail_UES_> https://www.tt-forums.net/viewtopic.php?f=67&t=84269
21:07:23  <snail_UES_> the 3rd zipfile includes the trainset and the trackset
21:07:49  <snail_UES_> the trackset includes a “high-speed” NG track type that should be introduced in 1970. However if you start a game in, say, 1900 it’s already there
21:09:53  <peter1138> Ok.
21:14:44  <TrueBrain> awh, I derailed ..
21:14:49  <TrueBrain> you cant make that turn with 50 km/hw
21:14:51  <TrueBrain> -w
21:14:53  <TrueBrain> weird
21:19:22  <peter1138> :D
21:24:05  <TrueBrain> and again! lol .. this is more difficult than I expected :P
21:24:11  <TrueBrain> you cannot turn around at most stations ... that is annoying :P
21:27:06  *** Gumle2 has joined #openttd
21:28:51  *** frosch123 has quit IRC
21:29:35  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on issue #7321: RailTypes: Introduction date not enforced https://git.io/fhxta
21:30:37  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on issue #7321: RailTypes: Introduction date not enforced https://git.io/fhxtV
21:34:47  <peter1138> snail_UES_, well... that was awkward ;(
21:37:20  <snail_UES_> peter1138: what do you mean?
21:37:30  <peter1138> Read the ticket :)
21:39:51  <peter1138> The NABZ introduction date is wrong as well.
21:41:48  <snail_UES_> hmm, my NFO code for that railtype introduction reads “ 17 1f 09 00 00 “
21:42:02  <peter1138> Yes. What is 91F meant to be?
21:44:08  <snail_UES_> I think I see what you mean… that’s decimal 2335
21:44:14  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7261: Add: Road vehicle path cache. https://git.io/fhFw4
21:44:25  <snail_UES_> so it’s treated as the number of days since jan 1st, year 0?
21:44:32  <peter1138> Yes, it's a long-format date.
21:44:51  <peter1138> But even if it was from 1920, that value would still be in 1926.
21:45:26  <peter1138> And if it was just year, well, that'd be year 2335. (or 4255.)
21:45:41  <peter1138> So those two numbers you have make no sense.
21:46:11  <snail_UES_> so it should be around 719,542 days for 1/1/1970
21:46:22  <snail_UES_> which is hex AFAB6
21:47:22  <peter1138> Yeah.
21:47:32  <peter1138> I wonder where you got 91F from, that's all.
21:48:09  <snail_UES_> so the correct NFO should be 17 B6 FA A0 00 for 1/1/1970?
21:48:20  <peter1138> No.
21:48:36  <peter1138> B6 FA 0A 00
21:49:15  <snail_UES_> oh right, 0A instead of A0
21:49:27  <peter1138> If you were using NML... ;)
21:49:31  <snail_UES_> :p
21:50:22  <peter1138> Btw, did pre-combined track sprites ever feel useful?
21:50:41  <snail_UES_> haven’t tried them yet...
21:50:53  <peter1138> Where you would draw all combinations of junctions instead of letting the game combine multiple parts.
21:51:02  <peter1138> It's not in the game yet, but there's a PR for it.
21:51:17  <snail_UES_> that sounds cool…
21:51:23  <peter1138> It was something that was vaguely requested about 5-6 years ago, but never got anywhere.
21:51:36  <peter1138> Means you get to control how each switch looks.
21:51:37  <LordAro> there is? which PR?
21:51:43  <snail_UES_> it sounds quite useful. It could be a way to make 3rd rail look even better
21:51:45  <peter1138> Does require a bit more effort :)
21:51:51  <peter1138> https://github.com/OpenTTD/OpenTTD/pull/7231
21:51:53  <snail_UES_> and maybe draw really curved switches...
21:52:14  <peter1138> I dunno about curved, it doesn't allow referening neighbour tiles.
21:52:25  <peter1138> But maybe.
21:52:47  <peter1138> LordAro, check the commit date. It's genuine.
21:53:06  <snail_UES_> I’ve only got a minor issue with tunnel portals
21:53:23  <peter1138> Tunnel portals will always be awkward.
21:53:52  <snail_UES_> I use custom ones, whose shape goes slightly beyond its normal bounding box (the tunnel portals are a bit higher, having two massive pillars at the sides of the entrance)
21:54:09  <Beerbelott> Editor load seems to behave very differently w/ heightmap than w/ savegame/scenario...
21:54:13  <snail_UES_> those pillars look nice if a tunnel portal stands by itself (meaning they get drawn even beyonf their box)
21:54:35  <snail_UES_> but for 2 parallel tracks, the pillar gets cut for the track that’s “closer to the viewer” if you know what I mean
21:54:52  <LordAro> peter1138: nice
21:55:20  <peter1138> It was when pikka was still doing stuff, heh.
21:55:25  <peter1138> But, heh.
21:55:48  <peter1138> snail_UES_, I'm not sure how you would solve that seeing as it is out-of-spec.
21:55:52  *** Gumle2 has quit IRC
21:56:04  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7234: Feature: Game setting to define how industries with neutral stations accept and supply cargo from/to surrounding stations. https://git.io/fhxtQ
21:57:31  <snail_UES_> I guess you can’t draw portals that are beyond their box?
21:57:44  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7248: Change: Group processing of vehicle ticks by type of vehicle. This allows use of PerformanceCounter instead of PerformanceAccumulator. https://git.io/fhxt7
21:57:45  <peter1138> You can, but you end up with glitches. That's the point of the box.
21:58:05  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7234: Feature: Game setting to define how industries with neutral stations accept and supply cargo from/to surrounding stations. https://git.io/fh5qg
21:59:38  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7234: Feature: Game setting to define how industries with neutral stations accept and supply cargo from/to surrounding stations. https://git.io/fhxtN
22:00:17  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7250: K-d tree data structure for spatial lookups https://git.io/fhxtx
22:00:34  <DorpsGek_II> [OpenTTD/OpenTTD] nikolas updated pull request #7086: Change #6173: Update SDL driver to use SDL 2.0 https://git.io/fhamZ
22:02:07  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7248: Change: Group processing of vehicle ticks by type of vehicle. This allows use of PerformanceCounter instead of PerformanceAccumulator. https://git.io/fhxth
22:02:14  <snail_UES_> hmm, weird… I’ve changed that property from “ 17 1f 09 00 00 “ to “ 17 B6 FA 0A 00 “ in my code
22:02:22  <snail_UES_> now that railtype never shows up… even in year 2200
22:02:40  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh approved pull request #7284: Fix #7043, Fix #7274: Delete town owned bridge based on adjacent tile ownership, not nearest town. https://git.io/fhxtj
22:04:23  <snail_UES_> peter1138: any ideas as to why it disappeared?
22:06:53  <peter1138> Yeah. Just checking...
22:07:00  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh dismissed a review for pull request #7235: Change: Non-rectangular sparse station catchment area https://git.io/fhbLE
22:07:02  <peter1138> Although, no, hmm.
22:08:18  <snail_UES_> I’ll be back in about 10mins
22:11:00  <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick opened pull request #7323: Fix #7274, Fix #7043: Town bridges store town indexes in map array. https://git.io/fhxqk
22:11:35  <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick closed pull request #7282: Fix #7274, Fix #7043: Town bridges store town indexes in map array. https://git.io/fhbpT
22:11:55  <peter1138> Samu, what?
22:12:33  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7235: Change: Non-rectangular sparse station catchment area https://git.io/fh5s1
22:12:49  <Samu> i renamed branch and it could no longer push, so I solved that by copying into a new branch
22:13:03  <peter1138> You can rename it back...
22:13:13  <peter1138> Don't open and close new PRs, it loses the history.
22:13:32  <Samu> it didn't work
22:13:34  <peter1138> And fills our PRs up with junk.
22:14:00  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7323: Fix #7274, Fix #7043: Town bridges store town indexes in map array. https://git.io/fhxqm
22:14:36  <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #7323: Fix #7274, Fix #7043: Town bridges store town indexes in map array. https://git.io/fhxqY
22:15:55  <LordAro> Samu: that literally tells you what to run
22:17:14  <Samu> Sorry about that :(
22:17:28  <Samu> I will no longer rename branches
22:17:48  <LordAro> also yes, it's rarely worth bothering to do that
22:18:06  <LordAro> branch name is immaterial
22:19:09  <LordAro> Samu: and always always fill out the pull request description
22:19:17  <LordAro> just as you would for an issue
22:19:25  <LordAro> otherwise they're just going to get closed immediately
22:19:32  <LordAro> and you're going to end up getting blocked
22:21:34  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7323: Fix #7274, Fix #7043: Town bridges store town indexes in map array. https://git.io/fhxqZ
22:24:34  <snail_UES_> back
22:26:03  <DorpsGek_II> [OpenTTD/OpenTTD] jcoletto77 commented on issue #7321: RailTypes: Introduction date not enforced https://git.io/fhxqC
22:27:29  *** qwebirc82905 has joined #openttd
22:27:57  <DorpsGek_II> [OpenTTD/OpenTTD] LordAro closed pull request #7323: Fix #7274, Fix #7043: Town bridges store town indexes in map array. https://git.io/fhxqk
22:28:06  <LordAro> no description for PR -> no description for closing it
22:28:10  <LordAro> i think that's fair
22:28:58  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN merged pull request #7284: Fix #7043, Fix #7274: Delete town owned bridge based on adjacent tile ownership, not nearest town. https://git.io/fhNsa
22:29:05  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN closed issue #7043: Disconnected towns during world generation https://git.io/fhnCg
22:29:06  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN closed issue #7274: Very long stalls during town generation https://git.io/fhb4F
22:29:23  <LordAro> peter1138: nicely done
22:31:16  <peter1138> That hot cross bun I ate was nice. Tesco finest of some sort.
22:31:28  <peter1138> Probably not the best thing to be eating at 22:30, though.
22:31:34  *** Progman has quit IRC
22:32:38  <supermop_Home_> I've been eating a tub of sun-dried tomatoes from whole foods
22:32:57  <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry opened pull request #7324: Codechange: [C++11] Use override specifer for overriding member declarations https://git.io/fhxq0
22:33:09  <peter1138> ^^ I started a patch to do that :)
22:33:37  <peter1138> I didn't remove the /* virtual */ part though.
22:33:47  <m3henry> Is a bit redundant
22:33:50  <peter1138> Yes.
22:33:55  <peter1138> Did you script it?
22:34:14  <m3henry> No, I used grep, xargs and nano
22:34:42  <peter1138> Using grep & xargs sounds like scripting, not nano though.
22:35:18  <m3henry> And listened to https://www.youtube.com/watch?v=B36BXid7iQ0 while I did it using Find, delete and paste
22:36:48  <peter1138> Hahah
22:37:10  <peter1138> Yeah, I stopped when I realised that once you have put override on one method, you've got to do it for all in that class.
22:38:11  <peter1138> I've got some warnings.
22:38:42  <m3henry> Which compiler?
22:38:46  <peter1138> clang
22:38:46  <Eddi|zuHause> uhm, i would've used sed -i for that
22:38:51  <Eddi|zuHause> seems doable
22:38:56  <Beerbelott> OMG this editor needs some fixing to work w/ heightmaps........
22:39:03  <peter1138> widget_type.h:411:7: error: 'SetupSmallestSize' overrides a member function but is not marked 'override'
22:39:08  *** agentw4b has quit IRC
22:39:28  <Beerbelott> I don't even know if what I'm doing is right, but that... kinda... works? :\
22:39:46  <peter1138> I guess it was missing the /* virtual */
22:40:03  <peter1138> What editor?
22:40:10  <Beerbelott> Game editor
22:40:15  <m3henry> Any other editors?
22:40:21  <m3henry> warnings*
22:40:28  <LordAro> a common typo
22:40:32  <m3henry> xD
22:40:37  <peter1138> Same file :504
22:40:51  <peter1138> :504, :533, :553, :554
22:40:52  <LordAro> peter1138: does the CI not emit the same warnings?
22:41:04  <Beerbelott> Don't slap me too hard, but another PR is coming w/ *maybe* loads of crap in there
22:41:17  <Eddi|zuHause> there seem to be 3 cases: function head before "{", function head ending with ";" and function head ending with "newline {"
22:41:27  <Eddi|zuHause> that should be 3 simple regexes ;)
22:41:52  <peter1138> LordAro, yes, at least the clang compiler.
22:42:16  <peter1138> There's some in station_base.h as well
22:42:17  <Eddi|zuHause> at least for me, that would probably have been faster than find/replace in loads of files :p
22:42:47  <peter1138> Eddi|zuHause, I'm not sure what you are talking about.
22:43:01  <peter1138> 3 cases of what?
22:43:01  <Eddi|zuHause> the virtual->override change
22:43:23  <Beerbelott> How come heightmap got such a bad treatment? Are those a relatively recent addition to the game?
22:43:39  <peter1138> Beerbelott, I don't know what is wrong with it.
22:43:56  <peter1138> Loading a heightmap into the editor is (or should be) the same as loading it into game to play.
22:44:05  <peter1138> It just... loads it.
22:45:24  <Beerbelott> 'case SM_LOAD_HEIGHTMAP:' of SwitchToMode in openttd.cpp does not work.
22:45:25  <Beerbelott> By replicating there what was made to fire up an empty editor, I made it load the heightmap as intended
22:45:42  <Beerbelott> peter1138: Yeah, if you go through an empty editor 1st, yes
22:45:52  <Eddi|zuHause> like: s/\/\* virtual \*\([^\{]*)\{/override \{/
22:45:57  <Beerbelott> if you come directly w/ SM_LOAD_HEIGHTMAP, it does not
22:46:12  <LordAro> https://wiki.openttd.org/Terkhen/Scenario_format#Extended_heightmap_format in a galaxy, far far away...
22:46:18  <Eddi|zuHause> or something like that
22:46:45  <Beerbelott> Also: if (_network_server && (new_mode == SM_LOAD_GAME || new_mode == SM_NEWGAME || new_mode == SM_RESTARTGAME)) { is not well-suited for heightmap integration
22:47:06  <peter1138> Beerbelott, how do you come directly with SM_LOAD_HEIGHTMAP?
22:47:32  <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry updated pull request #7324: Codechange: [C++11] Use override specifer for overriding member declarations https://git.io/fhxq0
22:47:37  <Beerbelott> When trating them as other file format, thus making changes for load on start :)
22:47:40  <peter1138> I think you're describing a condition that doesn't exist in master currently.
22:47:48  <Beerbelott> By trating*
22:47:53  <Beerbelott> treating* come on
22:47:54  <peter1138> Therefore, yes, you will probably have to make that condition work.
22:48:15  <Beerbelott> peter1138: Yes, but I wonder why it even exists... if it does not work
22:48:29  <peter1138> Why what exists?
22:48:51  <Beerbelott> case SM_LOAD_HEIGHTMAP: of SwitchToMode
22:49:04  <peter1138> It's used when loading a heightmap into the scenario editor.
22:49:24  <peter1138> Which certainly does work.
22:49:41  <Beerbelott> Well in its current state, its counting on goign through an empty editor to fill some gaps
22:49:52  <Eddi|zuHause> Beerbelott: the existing code works for all cases that can occur (hopefully). if you add a new case and it doesn't work, you might have missed a precondition somewhere
22:50:00  <peter1138> Yes, because that's the only way it can occur.
22:50:25  <peter1138> If you are changing it so it can occur otherwise, then yes, it is not really the existing code's fault, you will need to handle it.
22:50:54  <peter1138> m3henry, widget_type.h:412 and :503
22:51:18  <Beerbelott> Getting the inspiration from case SM_EDITOR:, I made a couple changes which end up loading the heightmap in the editor...
22:51:34  <nielsm> I've probably written some GUI stuff overriding functions without adding /* virtual */
22:51:34  <peter1138> I'm sure.
22:51:35  <Beerbelott> Although I dunno if what I do is completely berserk
22:51:41  <peter1138> nielsm, me too.
22:51:58  <Beerbelott> hence a new PR coming in ;)
22:52:07  * Beerbelott went hiding
22:52:14  <peter1138> Beerbelott, it's fine to do these changes, but you can't expect the existing code, which never needed to handle this new case, to not need changes.
22:52:48  <m3henry> peter1138: ty
22:52:58  <peter1138> "How come heightmap got such a bad treatment?" is not a useful question.
22:53:02  <Beerbelott> I thought this file format was already kind of dealt with in an approximately similar way to savegames/scenarios... The more I discover, the more I worry :D
22:53:11  <LordAro> Beerbelott: if it's something that depends on your changes, it should go in the same PR
22:53:15  <LordAro> imo
22:53:32  <Beerbelott> Actually reverse
22:54:07  <Beerbelott> As my current PR stands, if you try to load a heightmap directly in editor mode (-e -g), you come back to the main menu
22:54:46  <Beerbelott> Is it a big deal if the improvement to make editor + heightmap work out of the shelf in another PR?
22:54:53  <peter1138> I actually can't think of a reason why you'd ever want to do that, but...
22:55:39  <Beerbelott> Well the initial idea was just to load a heightmap as a file w/ -g... but -g needs to be compatible with -e, there is no reason to make an exception
22:55:55  <Beerbelott> I do not really care about the editor actually, my changes were aimed at dedicated servers :)
22:56:12  <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry updated pull request #7324: Codechange: [C++11] Use override specifer for overriding member declarations https://git.io/fhxq0
22:56:16  <Beerbelott> so to be feature-complete, it'd require to fix that
22:56:22  <Beerbelott> am I wrong?
22:56:41  <peter1138> Nope.
22:57:02  <Beerbelott> and there are modes already existing for that precise case of loading a heightmap in the editor thing
22:57:18  <Beerbelott> so it's like it's all there to work, but it's not... directly
22:57:23  <peter1138> By all means, fix it. Just accept that if you are making a new code path, that code path won't have been tested in the way you have expected.
22:57:42  <peter1138> It's just not a problem with the existing code as it stands.
22:58:21  <peter1138> m3henry, network/network_gui.cpp:121 and :147
22:58:21  <Beerbelott> that's where I am a bit afraid, as I have little-to-know global knowledge of the program... I merely try to mimic what happens in other places, crossing fingers :\
22:58:37  <peter1138> Beerbelott, don't worry, as long as you carry on it'll come to you.
22:58:44  <Beerbelott> LordAro: so same PR or new one?
22:58:53  <peter1138> I don't any of us knows all the details these days.
22:59:19  <LordAro> Beerbelott: it can always be split out, but they can't be merged
22:59:20  <Beerbelott> well CTD are to be expected then? :D
22:59:22  <peter1138> Same PR, separate commits. If it's deemed it should be a separate PR, they can be split.
22:59:58  <Beerbelott> OK I'll do that... Might need a rename at some point if it continues sliding down the path of complexity... :\
23:00:27  <Beerbelott> and I'm no developer, that's the funny part :D
23:00:42  <peter1138> Renaming a PR is easy. Just don't bother renaming branches, that just leads to pain.
23:01:29  <Beerbelott> peter1138: I already made a mistake or deleting a branch a few days ago, remember? ;)
23:01:38  <peter1138> :)
23:01:42  <peter1138> And someone else did it today...
23:01:45  <peter1138> " If you wish, you can delete your fork of OpenTTD/OpenTTD. "
23:01:54  <peter1138> Cheers GitHub, yeah, I'd really want to do that...
23:01:55  <Beerbelott> my branch is called 'heightmap' anyway. can't think of a better name :D
23:02:12  <LordAro> peter1138: i guess if you've forked just to fix one particular issue...
23:02:13  <Beerbelott> I'm branching as hell on my part...
23:02:15  <LordAro> but yeah, bit odd
23:02:32  <peter1138> Yeah but it's so prominent on something I perceive as rare.
23:02:35  <peter1138> Maybe it's not rare for them.
23:02:52  <Eddi|zuHause> <peter1138> " If you wish, you can delete your fork of OpenTTD/OpenTTD. " <-- i also saw this button today, and was wondering "that looks awfully easy to press accidentally" :p
23:02:56  <peter1138> They probably have more metrics on us that I have ;)
23:03:38  <peter1138> m3henry, table/newgrf_debug_data.h has a load as well.
23:04:03  <peter1138> I really wish this was a default-on check :/
23:04:19  <peter1138> If you have nothing marked as override then it doesn't care.
23:04:43  <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry updated pull request #7324: Codechange: [C++11] Use override specifer for overriding member declarations https://git.io/fhxq0
23:06:33  *** HerzogDeXtEr has quit IRC
23:08:45  *** Lejving has quit IRC
23:08:54  <Beerbelott> I suppose GitHub hates all those fork sitting there idle ;) Less forks = more gc
23:09:01  <peter1138> :)
23:10:00  *** Lejving has joined #openttd
23:10:08  <DorpsGek_II> [OpenTTD/website] LordAro opened pull request #67: Add: OpenTTD 1.9.0-RC1 news post https://git.io/fhxmY
23:11:02  <peter1138> \o/
23:11:13  <TrueBrain> LordAro: sentences end with a dot
23:11:25  <LordAro> TrueBrain: sorry about the local branch, i couldn't (trivially) figure out a way to create the branch on my fork via the web interface
23:11:37  <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry updated pull request #7324: Codechange: [C++11] Use override specifer for overriding member declarations https://git.io/fhxq0
23:11:38  <TrueBrain> you are them all :p
23:11:58  <TrueBrain> the same way you did on the main branch :)
23:12:11  <TrueBrain> but it doesn't auto sync.. so yeah
23:12:14  <TrueBrain> it is fine
23:12:26  <TrueBrain> just delete it afterwards ;)
23:12:28  <LordAro> it'll be gone in a few moments, anyway :p
23:12:53  <TrueBrain> after you found the dot key on your keyboard :p
23:13:37  <DorpsGek_II> [OpenTTD/website] Eddi-z updated pull request #67: Add: OpenTTD 1.9.0-RC1 news post https://git.io/fhxmY
23:13:40  <Eddi|zuHause> (sorry)
23:13:54  <peter1138> m3henry, just 4 left in newgrf_debug_data from what I can see.
23:14:00  <peter1138> m3henry, :363 365 529 and 537
23:14:03  <Eddi|zuHause> (i had to try whether that works)
23:14:09  <TrueBrain> still more missing dots :p
23:14:14  <peter1138> I dunno about other non-Linux builds though.
23:14:22  <TrueBrain> I like this collaborated way of news writing tbh
23:14:34  <TrueBrain> possibly we should always do it like this
23:14:58  <DorpsGek_II> [OpenTTD/website] Eddi-z updated pull request #67: Add: OpenTTD 1.9.0-RC1 news post https://git.io/fhxmY
23:15:05  <peter1138> 1 major thing
23:15:08  <peter1138> Well, fairly.
23:15:13  <peter1138> OS X FreeType :p
23:15:28  <TrueBrain> tnx Eddi
23:15:38  <TrueBrain> can't approve on mobile :(
23:15:59  *** nielsm has quit IRC
23:16:12  <DorpsGek_II> [OpenTTD/website] Eddi-z approved pull request #67: Add: OpenTTD 1.9.0-RC1 news post https://git.io/fhxm3
23:16:37  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on issue #7321: RailTypes: Introduction date not enforced https://git.io/fhxmG
23:17:04  <TrueBrain> time to get some sleep; night all
23:17:38  <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry updated pull request #7324: Codechange: [C++11] Use override specifer for overriding member declarations https://git.io/fhxq0
23:18:21  <m3henry> o/
23:18:43  <peter1138> I wonder if there are any classes which are missing.
23:19:29  <LordAro> some static analyser should be able to tell you
23:19:38  <LordAro> cppcheck has something, i think
23:21:21  <peter1138> "Failed to load std.cfg. Your Cppcheck installation is broken"
23:21:22  <peter1138> Hmm :/
23:22:12  <Eddi|zuHause> so who can merge the news post? it says i can't.
23:28:13  <snail_UES_> peter1138: saw your comment
23:28:25  <snail_UES_> I’m using a version of OTTD from July 2018, has the code changed since?
23:31:22  <peter1138> Nope.
23:32:20  <snail_UES_> then there must be something weird with my NFO
23:35:50  *** keoz has quit IRC
23:36:29  <peter1138> Did you accidentally go with A0 instead of 0A? :p
23:37:05  <Samu> why was it closed? I told you what happened :|
23:37:49  <Samu> just downloaded RC-1, gonna test some AIs
23:40:44  *** qwebirc82905 has quit IRC
23:46:31  <DorpsGek_II> [OpenTTD/website] michicc merged pull request #67: Add: OpenTTD 1.9.0-RC1 news post https://git.io/fhxmY
23:46:43  <snail_UES_> I wrote: “ 17 B6 FA 0A 00 "
23:50:08  <supermop_Home_> safe to assume nrt isn't going to move forward any time soon?
23:50:20  <peter1138> supermop_Home_, nope
23:50:31  <peter1138> supermop_Home_, it will
23:50:34  <supermop_Home_> so i don't need to start working on my RV set again yet
23:50:35  <peter1138> supermop_Home_, 1.9 was branched.
23:50:51  <peter1138> m3henry, I still see some /* virtual */ in cpp files.
23:51:07  <supermop_Home_> hmm. i miss a good generic station set
23:51:14  <peter1138> newstats :)
23:51:21  <peter1138> Actually
23:51:29  <peter1138> You're right, there are none. You should make one ;)
23:51:32  <supermop_Home_> i just use chips all the time lately.
23:51:40  <Eddi|zuHause> newstats is a passenger station set
23:51:42  <supermop_Home_> i am waiting for NML
23:52:05  <Eddi|zuHause> i wouldn't hold my breath on that :p
23:52:28  <supermop_Home_> chips is ok for cargo but a little bland - all those paved flat lots stacked 10m high with crates
23:53:16  <supermop_Home_> the default stations with just a tad more richness would be 90% of what I desire
23:53:17  <Beerbelott> What are the valid prefixes for commit messages again? I got a list from a fail from commit-checker the other day but did not make a printscreen
23:53:23  <Eddi|zuHause> i was thinking of a distribution of which cargo type is displayed on each tile, so not only the highest one gets shown, but it gets somewhat mixed
23:53:47  <supermop_Home_> i can't even understand the code i wrote for MLSS ~9 years ago at this point
23:53:54  <LordAro> Beerbelott: https://github.com/OpenTTD/OpenTTD-git-hooks/blob/master/hooks/check-message.py
23:54:31  <Beerbelott> LordAro: Many thx!
23:54:39  <Eddi|zuHause> http://wiki.openttd.org/Commit_style#Commit_message
23:54:44  <Eddi|zuHause> not sure how up to date that is
23:54:54  <supermop_Home_> hmm i did try some rendered station sprites about 4 years ago
23:55:32  <supermop_Home_> but I've sort of wandered away from rendering things that are not for work these days
23:55:46  <Eddi|zuHause> it seems updated, but with wiki you can never be sure :p
23:56:18  <supermop_Home_> Eddi|zuHause a 60-40 mix of cargo for chips would be nice
23:56:53  <supermop_Home_> as is, my station with 1000T of coal looks like it has none if it has 1001T of Iron Ore
23:56:58  <Eddi|zuHause> supermop_Home_: https://en.wikipedia.org/wiki/Largest_remainder_method
23:57:26  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #6811: Feature: Add NotRoadTypes (NRT)  https://git.io/vhlfg
23:57:38  <Eddi|zuHause> (not 100% serious)
23:59:24  <supermop_Home_> of course if you build a Victorian passenger terminal hall for your coal mine, should it still show coal piled up on the platforms?

Powered by YARRSTE version: svn-trunk