Config
Log for #openttd on 7th March 2019:
Times are UTC Toggle Colours
00:02:33  <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry updated pull request #7165: [core] Implement SmallVector using std::vector https://git.io/fhSz0
00:08:49  <m3henry> I guess that means it's nearly over, if you're reached the penultimate commit
00:35:24  <drac_boy> mm quiet night for coding .. anyway I'm going off for today still :)
00:35:27  *** drac_boy has left #openttd
00:37:51  *** Thedarkb-T60 has joined #openttd
00:44:24  <DorpsGek_II> [OpenTTD/OpenTTD] nikolas updated pull request #7086: Change #6173: Update SDL driver to use SDL 2.0 https://git.io/fhamZ
01:28:22  <Eddi|zuHause> oh man this last portal chamber was hidden :/
01:31:52  *** Supercheese has quit IRC
01:58:48  <Samu> I see gamescripts can create subsidies, that's interesting
01:59:08  <Samu> but it could have a bit more control
02:00:18  <Samu> oh well
02:03:37  <DorpsGek_II> [OpenTTD/OpenTTD] nikolas opened issue #7337: Audio driver crash on quit - fluidsynth/SDL https://git.io/fhpg0
02:05:03  <peter1138> Give it more control then.
02:11:14  <Samu> how many months it lasts
02:11:37  <Samu> and... how many months it lasts when completed
02:12:07  <Samu> but still, it's a game script slot occupied just for this :(
02:15:58  *** Samu has quit IRC
02:18:03  <DorpsGek_II> [OpenTTD/OpenTTD] nikolas commented on issue #7333: Libtimidity could be trivially enabled to play music through mixer.cpp https://git.io/fhpgX
02:38:13  *** m3henry has quit IRC
02:45:01  *** Smedles has quit IRC
02:46:13  *** Smedles has joined #openttd
02:55:19  *** Thedarkb-T60 has quit IRC
03:07:13  *** debdog has joined #openttd
03:10:34  *** D-HUND has quit IRC
03:29:58  *** Beerbelott has left #openttd
03:52:31  <DorpsGek_II> [OpenTTD/OpenTTD] nikolas opened pull request #7338: Fix: spelling for a few real town names https://git.io/fhpaU
03:52:45  *** tokai has joined #openttd
03:52:45  *** ChanServ sets mode: +v tokai
03:59:39  *** tokai|noir has quit IRC
04:32:34  *** Wormnest has quit IRC
05:05:20  *** Heiki has quit IRC
05:12:36  *** glx has quit IRC
05:21:03  *** keoz has joined #openttd
06:05:04  *** Pikka has joined #openttd
07:03:38  *** andythenorth has joined #openttd
07:13:47  <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on pull request #6811: Feature: Add NotRoadTypes (NRT)  https://git.io/fhpVA
07:17:01  *** APTX has quit IRC
07:23:30  <andythenorth> moin
07:26:02  <peter1138>  At least 1 approving review is required by reviewers with write access.
08:48:50  *** m3henry has joined #openttd
08:50:42  <m3henry> o/
09:07:22  *** Beerbelott has joined #openttd
09:11:29  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on issue #7337: Audio driver crash on quit - fluidsynth/SDL https://git.io/fhprR
10:15:23  *** Heiki has joined #openttd
10:27:04  <Eddi|zuHause> is that just me or is there a spam attack on the forum?
10:34:13  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7338: Fix: spelling for a few real town names https://git.io/fhpKm
10:34:44  <peter1138> And gone :p
10:38:22  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7336: Add: AI API for vehicle group colours https://git.io/fhp00
10:49:02  *** Thedarkb-T60 has joined #openttd
10:52:59  *** Thedarkb-T60 has quit IRC
10:52:59  *** Eddi|zuHause has quit IRC
10:53:06  *** Thedarkb-T60 has joined #openttd
10:53:25  *** Eddi|zuHause has joined #openttd
11:07:52  <LordAro> peter1138: there was a reason for the double quotes, something to do with the escape codes
11:08:01  <LordAro> let me see if i can find it...
11:10:21  <LordAro> oh wait, your comment has disappeared
11:10:32  <LordAro> guess you found out about "warning: hex escape sequence out of range" :)
11:12:25  <peter1138> I realised as I posted, didn't actually try it :)
11:16:03  <LordAro> :)
11:17:58  <peter1138> Okay, here's one...
11:18:38  <peter1138> Why is road vehicles "Drive on left" / "Drive on right" so prominent in the Game Options window?
11:19:01  <peter1138> Town Names should also be a world-gen option.
11:21:47  <LordAro> because TTD, i imagine
11:26:07  <peter1138> Yeah
11:26:42  <peter1138> watching trees grow and die on ffwd is mesmerising :p
11:27:46  <DorpsGek_II> [OpenTTD/OpenTTD] Gymnasiast commented on issue #7332: Performance in DOS is terrible https://git.io/fhp6M
11:33:00  <andythenorth> game options is so weird :D
11:33:07  <andythenorth> also can I switch drive side during game?
11:33:10  <andythenorth> :P
11:33:12  <andythenorth> make it possible
11:33:30  <peter1138> Yes, if there are no road vehicles.
11:36:39  <andythenorth> send em all to depot
11:54:44  *** Thedarkb-T60 has quit IRC
12:29:02  <peter1138> Make road-side NewGRF configurable in NRT ;p
12:29:17  <andythenorth> good feature
12:29:47  <Eddi|zuHause> anyone ever study the halflife of a "good feature"?
12:35:55  <peter1138> Is it ready yet?
12:36:22  <andythenorth> is it ever?
12:57:55  <peter1138> Mmm, reheated pizza
13:00:20  *** Pikka has quit IRC
13:01:26  *** agentw4b has quit IRC
13:05:38  <DorpsGek_II> [OpenTTD/OpenTTD] GabdaZM commented on pull request #7250: K-d tree data structure for spatial lookups https://git.io/fhpPQ
13:17:40  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7250: K-d tree data structure for spatial lookups https://git.io/fhpXv
13:21:06  *** Flygon has quit IRC
13:21:25  <Eddi|zuHause> this time not from the bin?
13:31:19  <peter1138> No this one was handed to me yesterday in its box, still hot.
13:36:03  <DorpsGek_II> [OpenTTD/OpenTTD] Berbe commented on issue #7311: Wrong determination of personal directory https://git.io/fhpXr
13:41:38  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on issue #7311: Wrong determination of personal directory https://git.io/fhpXQ
14:04:40  *** octernion has joined #openttd
14:14:45  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7272: Change: [NPF] Add path cache for ships. https://git.io/fhp1b
14:42:31  <DorpsGek_II> [OpenTTD/OpenTTD] Berbe commented on issue #7311: Wrong determination of personal directory https://git.io/fhpM7
14:44:06  *** nielsm has joined #openttd
14:45:03  <Beerbelott> peter1138: Updated my comment
14:46:36  <peter1138> Oh.. Yes, I misread it.
14:46:48  <peter1138> Your baseset is in ~/.openttd/content_download/baseset.
14:47:07  <peter1138> Afaik, changing the config path means it doesn't use ~/.openttd, that's by design.
14:47:37  <peter1138> (Not necessarily a good design!)
14:57:56  *** supermop_work has joined #openttd
14:59:08  *** supermop_work_ has joined #openttd
15:01:06  *** supermop_work__ has joined #openttd
15:03:52  *** supermop_work___ has joined #openttd
15:05:58  *** supermop_work has quit IRC
15:08:13  *** supermop_work_ has quit IRC
15:11:09  *** supermop_work__ has quit IRC
15:20:14  <Eddi|zuHause> i think there's room for improvement :p
15:20:38  *** Thedarkb-T60 has joined #openttd
15:24:15  <Beerbelott> It might be seen as logical to scan the dir (maybe the arborescence of known dirs) from where the config file is started, but that should not replace, in any way, the 'standard' dirs from locations the game files are said to be looking into
15:25:35  <Beerbelott> I guess the proper thing to do would be to add the dir of the config file (not the arborescence)
15:25:41  <Beerbelott> to the list of scanned files
15:26:14  <Beerbelott> But... well... that'd suppose it's logical we put other files there too
15:26:22  <Beerbelott> I dunno, quite a big design question actually
15:27:01  <Beerbelott> To keep things simple, I wouldn't add dirs to scan
15:27:25  <Beerbelott> I'd keep the standard dirs, merely allowing to temporarily overload the config file by another one
15:27:58  <Beerbelott> That would ensure consistency in what is loaded. The config file is then there to make sure what is configurable can be changed
15:28:47  <Beerbelott> This ensured consisency would save us from this kind of nightmare
15:30:01  <Thedarkb-T60> I've gotten an idea.
15:30:15  <Thedarkb-T60> Why not statically link libicu52.
15:30:47  <Thedarkb-T60> It would make OpenTTD a lot easier to install on Ubuntu and Debian.
15:31:22  <Beerbelott> openttd package manager compiled openttd against libicu57, starting in testing
15:31:27  *** andythenorth has left #openttd
15:31:36  <Thedarkb-T60> :D
15:31:44  <peter1138> Thedarkb-T60, https://www.openttd.org/downloads/openttd-releases/testing.html
15:31:54  <peter1138> ^ are any of those packages hard to install?
15:31:58  <Beerbelott> and it seems tests were done against libicu60
15:32:04  <Thedarkb-T60> That's great.
15:32:24  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7250: K-d tree data structure for spatial lookups https://git.io/fhpy2
15:32:24  <Thedarkb-T60> I'm trying that testing release right now.
15:32:30  <Beerbelott> Moreover, you can compile on stretch w/o trouble
15:32:40  <Beerbelott> picking up libicu-dev
15:33:02  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7250: K-d tree data structure for spatial lookups https://git.io/fhpyw
15:33:11  <Thedarkb-T60> That's good to know.
15:34:12  <Thedarkb-T60> It installed painlessly!
15:34:37  <Beerbelott> You can easily compile and even make .deb files in a container, whetever version: https://wiki.openttd.org/Category:Compiling_OpenTTD
15:35:28  <Beerbelott> I'd recommend using official packages on the website though :)
15:35:43  <Beerbelott> a simple script would do the trick
15:35:57  <Thedarkb-T60> I used to make packages for TinyCore Linux.
15:36:06  <Thedarkb-T60> I might well package up OpenTTD when I get around to it.
15:36:07  <peter1138> I made an Android build.
15:36:46  <peter1138> But only as a dedicated server build... Need to sort out libsdl :)
15:36:47  <Beerbelott> Thedarkb-T60: The compiling instructions might be a lil bit off-sync w/ reality coming up to requirements list, but the spirit is there
15:37:19  <Beerbelott> https://wiki.openttd.org/Compiling_on_(GNU/)Linux_and_*BSD#Debian_package
15:37:30  <Beerbelott> Can't think of anything easier
15:38:53  <Beerbelott> To build on stretch, I used that list: zlib1g-dev liblzo2-dev liblzma-dev libfontconfig-dev libicu-dev libsdl-dev libpng-dev li    bfreetype6-dev libfontconfig-dev
15:39:16  <Beerbelott> sry: zlib1g-dev liblzo2-dev liblzma-dev libfontconfig-dev libicu-dev libsdl-dev libpng-dev libfreetype6-dev libfontconfig-dev
15:39:29  <Beerbelott> (on top of wget xz-utils build-essential pkg-config debhelper)
15:39:56  <Beerbelott> then u got all the tools to make it roll
15:40:30  <Beerbelott> ofc pulling code from a git repo, scratch wget for git
15:40:39  <peter1138> apt-get build-dep openttd :)
15:41:21  <Beerbelott> Well, that too, but I'm a bit afraid to rely on the dependencies of a package not manage by your team :p
15:41:29  <Beerbelott> +d
15:41:52  <DorpsGek_II> [OpenTTD/OpenTTD] GabdaZM commented on pull request #7250: K-d tree data structure for spatial lookups https://git.io/fhpSL
15:42:09  <peter1138> Beerbelott, check the maintainer ;)
15:42:45  *** Wormnest has joined #openttd
15:42:49  <Beerbelott> peter1138: I'll make a tiny PR for issue #7311 where the fix will be replacing that odd line with using the dirs array. At least, a proposal will be on the table to be debated :)
15:43:16  <peter1138> It is maintained by one of us, however obviously it follows the normal Debian package rules, hence why it's kinda old.
15:43:17  <Beerbelott> Matthijs Kooijman <matthijs@stdin.nl>
15:43:28  <Beerbelott> Who's that?
15:43:48  <Eddi|zuHause> haven't heard that name in ages
15:44:25  <peter1138> Long time dev.
15:44:43  <Beerbelott> https://packages.debian.org/stretch/openttd
15:44:43  <Beerbelott> THere's a Jordi too
15:45:12  <Beerbelott> Well then Thedarkb-T60 I guess those debian packages might be to be trusted after all ;)
15:45:49  <peter1138> 7   grfcodec: flagged for removal in 26.9 days
15:45:49  <peter1138>    openttd-opengfx: buggy deps grfcodec, flagged for removal in 26.9 days
15:45:49  <peter1138>    openttd: buggy deps grfcodec, flagged for removal in 26.9 days
15:45:52  <peter1138> Interesting...
15:46:17  <peter1138> Ah, website changes
15:49:40  *** supermop_work has joined #openttd
15:49:52  <peter1138> Or not.
15:50:19  <peter1138> Hmm, it's not in github.,
15:50:38  *** supermop_work___ has quit IRC
15:50:48  <LordAro> someone should fix that
15:52:12  <peter1138> Someone™
15:52:33  *** supermop_work_ has joined #openttd
15:54:06  <peter1138>  Detecting your project’s version control system…
15:54:09  <peter1138> Wait for it...
15:54:17  <DorpsGek_II> [OpenTTD/OpenTTD] Berbe opened pull request #7339: Fix #7311: External configuration file does not change arborescence https://git.io/fhpS1
15:54:29  <peter1138> arborescence?
15:55:08  <Beerbelott> https://www.merriam-webster.com/dictionary/arborescence
15:55:09  <peter1138> I'm not sure that word is ever used there...
15:55:20  <Beerbelott> Well file-tree?
15:55:22  <peter1138> "directories" would make sense.
15:55:37  <Beerbelott> Here goes the 1st force-push
15:55:48  <Beerbelott> Breaking a record on how fast after 1st push :D
15:56:10  *** sla_ro|master has joined #openttd
15:56:40  <DorpsGek_II> [OpenTTD/OpenTTD] Berbe updated pull request #7339: Fix #7311: External configuration file does not change arborescence https://git.io/fhpS1
15:59:49  *** supermop_work has quit IRC
15:59:50  <Beerbelott> It seems this IRC notification was made w/ the old title
15:59:53  <Beerbelott> not the new one
16:00:08  <milek7> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=922625
16:00:09  <Beerbelott> Isn't this a bug? cc TrueBrain
16:00:14  <milek7> i don't see that attached bad.patch
16:03:56  <DorpsGek_II> [OpenTTD/OpenTTD] Berbe commented on pull request #7339: Fix #7311: External configuration file does not change directories https://git.io/fhpSj
16:11:37  *** Samu has joined #openttd
16:11:41  <Samu> hi
16:14:55  <greeter> greetings
16:21:20  <Eddi|zuHause> <Beerbelott> Breaking a record on how fast after 1st push :D <-- i don't think you quite made that record :p
16:21:40  *** Gumle2 has joined #openttd
16:22:19  <Beerbelott> I feel I pushed waaaay too much on my 1st PR, but that's another record I guess
16:22:31  <Beerbelott> There got to be a medal to earn! :D
16:23:56  *** Progman has joined #openttd
16:25:34  <LordAro> i'm still not a fan of "external" files being picked up during a regression test run
16:25:53  <LordAro> i'm of the opinion that if you specify -c for a config file, it should only use that file (and files relative to it)
16:27:00  <Eddi|zuHause> LordAro: but then, the regression should come with a regression baseset.
16:28:34  <planetmaker> regression baseset... sounds somewhat like overkill
16:29:20  <Eddi|zuHause> Beerbelott: what you should test now: 1) files relative to the config dir are still preferred over personal dir if they exist, 2) savegames etc. are stored relative to the config dir and not the personal dir
16:29:43  <peter1138> LordAro, is your bike back yet?
16:30:15  <planetmaker> though I recall that I could create a NoGFX baseset with OpenGFX source... iirc. The minimal baseset for a server
16:30:16  <Eddi|zuHause> planetmaker: but since the regression is run without UI, it doesn't need to contain actual sprites, just silence the "missing baseset" check
16:30:37  <planetmaker> 1px black pixels for all sprites except terragen
16:31:02  <peter1138> Random pixels where it's not transparent.
16:31:16  <planetmaker> too complicated to make
16:31:19  <peter1138> Call it OpenOzTransGFX
16:31:26  <planetmaker> it's easy to replace all ... :D :D
16:34:34  <Beerbelott> Eddi|zuHause: Well... that I did not know of. The current proposal breaks that for sure
16:35:46  <Beerbelott> I'm more kin to LordAro stance
16:36:04  *** supermop_work_ has quit IRC
16:36:34  <Beerbelott> It's the usual behaviour you encounter for stuff allowing to specify external resources
16:37:02  <Beerbelott> They are specifie explicitly, no implicit derivation from any of them is usually made, sticking to known conf dirs
16:37:22  <Beerbelott> (as that could lead to impredictible situations)
16:38:26  <Beerbelott> But well... that means this little change has deep imapct on how OpenTTD is behaving, break backwards-compatibility
16:38:43  <Beerbelott> Oh dear, what have I put myself into again... :p
16:39:16  <LordAro> peter1138: it is!
16:39:25  <Eddi|zuHause> Beerbelott: it always starts with "this should be an easy one-line patch" :p
16:39:53  *** HerzogDeXtEr has joined #openttd
16:40:56  <Eddi|zuHause> now... in all my travels i found 2 pieces of processed scrap, yet i need 3 to get started with making a shredder to make more pieces of scrap...
16:42:34  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #7250: K-d tree data structure for spatial lookups https://git.io/fhd4b
16:42:37  <Beerbelott> I did not expect it to be that easy... but not unleashing that kind of hell either :D
16:50:00  <peter1138> LordAro, \o/
16:50:15  *** supermop_work has joined #openttd
16:51:04  *** supermop_work_ has joined #openttd
16:52:24  <DorpsGek_II> [OpenTTD/OpenTTD] glx22 commented on pull request #7339: Fix #7311: External configuration file does not change directories https://git.io/fhpH6
16:53:44  *** glx has joined #openttd
16:53:44  *** ChanServ sets mode: +v glx
16:58:19  *** supermop_work has quit IRC
16:58:45  <Beerbelott> OMG when loading an external configuration file, the game creates all sorts of fiels there...
16:58:53  <Beerbelott> That's terrible behaviour IMHO
16:59:35  <Beerbelott> You might be willing to overload the default conf file w/o making a working dir where it's loaded from :\
17:00:03  <glx> it's a nice thing when you host many dedicated servers :)
17:00:06  <Beerbelott> Again, the implicit file locations if not explicitely set otherwise would be a better approach to this...
17:00:32  <Beerbelott> glx: Isolation badly done
17:01:21  <Beerbelott> I see that more as a threat than a feature
17:01:46  <glx> only one exe needed, and then 1 config per server
17:01:51  <Beerbelott> properly isolated instances could never load different configuration files fro mthe same binary ;)
17:02:01  <Beerbelott> exactly what's the worst
17:06:50  <Beerbelott> However, what you could be doing is mounting custom resources (conf file, savegames, scenarios, heightmaps, whatever) on a RO volume, share it between instances and have Server #1/#2 etc be able to be inter-changeable
17:07:31  <Beerbelott> each instance being properly isolated
17:10:21  *** m3henry has quit IRC
17:12:04  <Beerbelott> Well I guess the codebase on that has been inherited for quite a while, so it's only fair to assume design choices were made according to (bad) habits of the 90s (80s?) when virtualization/containers were a concept at best, if anything at all
17:12:30  <Beerbelott> The q° is: Does OpenTTD wanna change?
17:15:08  *** Gumle2 has quit IRC
17:15:50  <Eddi|zuHause>  <Beerbelott> OMG when loading an external configuration file, the game creates all sorts of fiels there... <-- one of the main uses behind that is you can have both openttd and all data files on an USB stick and carry that around, without spoiling the OS of the computer
17:16:26  <Eddi|zuHause> Beerbelott: you can't tell these people "use containers/virtualization"
17:18:52  <Beerbelott> Then the switch shall not be about loading a configuration file and implying a directory structure around
17:19:10  <Beerbelott> It shall be about changing the working directory and searching for a configuration file inside
17:19:36  <Beerbelott> I totally get your use case, but the code is prepped the wrong way around
17:20:38  <Beerbelott> the scope of the '-c' switch is implicitely widened, which might not be expected
17:21:09  <glx> it's indicated in the readme
17:22:20  <Beerbelott> glx: the '-h' message does not even mention '-c' :D
17:23:14  <Eddi|zuHause> Beerbelott: but even if it's not "expected", you can't simply break existing setups for no reason
17:23:34  <Beerbelott> Well I suppose '-c' definition might be changed to 'change working directory', supporting configuration file loading (and implying working directory from it) as a backwards-compitable fallback?
17:23:50  <Beerbelott> How about that?
17:23:57  <Beerbelott> compatible*
17:24:02  <glx>         "  -c config_file      = Use 'config_file' instead of 'openttd.cfg'\n"
17:24:11  <glx> it does mention -c
17:24:57  <Beerbelott> mmmh
17:25:01  <Beerbelott> Am I blind?
17:25:12  <glx> line 180
17:25:17  <Beerbelott> Yes I am... Sry about that
17:25:39  <Beerbelott> What do you think about the aforementioned way of dealing with that?
17:26:00  <Beerbelott> I don't wanna swim against current :)
17:26:08  <Beerbelott> flow
17:27:08  <glx> hmm yes, using -c could be equivalent to an implicit working directory change
17:28:36  <glx> but definitely setting specified config_dir as personal_dir feels wrong :)
17:28:56  <Beerbelott> I agree on both
17:29:40  <Beerbelott> So here we go for transforming configuration file locading in config_dir change...
17:29:56  <Beerbelott> (I dunno what I'm doing :D )
17:34:08  *** Gumle2 has joined #openttd
17:35:26  <DorpsGek_II> [OpenTTD/OpenTTD] Berbe commented on pull request #7339: Fix #7311: External configuration file does not change directories https://git.io/fhpQQ
17:41:55  <peter1138> hi
17:47:13  *** frosch123 has joined #openttd
17:52:31  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN approved pull request #7338: Fix: spelling for a few real town names https://git.io/fhp74
17:53:01  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN merged pull request #7338: Fix: spelling for a few real town names https://git.io/fhpaU
17:53:29  <nielsm> that one should be backported too, shouldn't it?
17:59:02  *** Gabda has joined #openttd
17:59:24  <peter1138> Can be, not particularly important.
17:59:37  <Gabda> hi
18:00:09  <nielsm> could be used as a test for backporting via PRs? :)
18:00:34  <peter1138> #7334 is more important
18:00:39  <Gabda> nielsm: I think the max in ForAllStationsRadius can go up to MapSizeX
18:01:22  <peter1138> Er, #7335 I mean :)
18:01:26  <nielsm> Gabda I'll look at it a bit later, busy moving virtual logs on virtual rails atm :)
18:01:42  <Gabda> ok
18:02:27  <Gabda> and with this I am finished reading, won't bother you with new comments :)
18:03:26  <nielsm> https://0x0.st/zokw.jpg
18:10:37  *** Gabda has quit IRC
18:12:39  *** Wormnest has quit IRC
18:16:47  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN approved pull request #7327: Cleanup: Remove repeated network error message on connection timeout. https://git.io/fhp7y
18:16:55  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN merged pull request #7327: Cleanup: Remove repeated network error message on connection timeout. https://git.io/fhxwc
18:23:02  *** Gustavo6046 has joined #openttd
18:31:45  *** Wolf01 has joined #openttd
18:32:57  <Wolf01> o/
18:41:14  <peter1138> \o
18:44:12  *** gelignite has joined #openttd
18:48:28  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #7250: K-d tree data structure for spatial lookups https://git.io/fhd4b
18:50:02  *** synchris has joined #openttd
18:54:21  <nielsm> hmm, how are translation changes backported? there might need to be some janitoring in those when strings change in master
18:55:05  <glx> there used to be a script somewhere
19:12:59  <frosch123> yes, there is a script
19:13:58  <frosch123> it's not versioned anywhere though
19:16:34  <Samu> what does backport mean?
19:17:02  <Wolf01> Mmmh, friend's wife wants to gift the lego millennium falcon to friend, he already purchased it with a good discound and buried it under the old lego boxes in the basement so she wouldn't know...
19:21:43  <peter1138> Oops
19:21:48  <nielsm> Samu: take changes made against the master version and copy them to the 1.9 release branch, without getting any unrelated changes along
19:21:50  <Eddi|zuHause> there's some he/she mismatch in that sentence
19:22:07  <peter1138> Eddi|zuHause, nope...
19:23:01  *** supermop_work_ has quit IRC
19:24:32  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7000: Some NewGRF variables concerning railtypes https://git.io/fhp5F
19:26:13  <peter1138> All these cool things we can get in once 1.9 is branched.
19:28:35  <Wolf01> :D
19:29:08  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7279: Fix #7062: Remove ship max order distance. https://git.io/fhpdf
19:30:31  <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z commented on pull request #7000: Some NewGRF variables concerning railtypes https://git.io/fhpdk
19:31:25  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7000: Some NewGRF variables concerning railtypes https://git.io/fhpdI
19:37:31  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7086: Change #6173: Update SDL driver to use SDL 2.0 https://git.io/fhpd3
19:38:03  *** Gumle2 has quit IRC
19:38:31  <Eddi|zuHause> we really need some proper test cases for #7000, but i'm not quite ready for that
19:40:54  <peter1138> Just needs a test to confirm working as expected.
19:41:00  <peter1138> I'm not after full on unit tests.
19:41:01  *** Pikka has joined #openttd
19:46:24  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7086: Change #6173: Update SDL driver to use SDL 2.0 https://git.io/fhpdl
19:46:58  *** supermop_work has joined #openttd
19:48:43  *** supermop_work_ has joined #openttd
19:49:19  <supermop_work_> yo
19:49:52  <Wolf01> o/
19:55:59  *** supermop_work has quit IRC
20:05:21  <DorpsGek_II> [OpenTTD/OpenTTD] nikolas updated pull request #7086: Change #6173: Update SDL driver to use SDL 2.0 https://git.io/fhamZ
20:07:14  <DorpsGek_II> [OpenTTD/OpenTTD] nikolas commented on pull request #7086: Change #6173: Update SDL driver to use SDL 2.0 https://git.io/fhpd1
20:13:22  *** frosch123 has quit IRC
20:36:09  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7086: Change #6173: Update SDL driver to use SDL 2.0 https://git.io/fhpFI
20:36:10  *** gelignite has quit IRC
20:36:58  *** synchris has quit IRC
20:47:05  <DorpsGek_II> [OpenTTD/OpenTTD] nikolas commented on pull request #7086: Change #6173: Update SDL driver to use SDL 2.0 https://git.io/fhpFR
20:49:50  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7086: Change #6173: Update SDL driver to use SDL 2.0 https://git.io/fhpFu
20:51:40  <peter1138> Bah @ micro-usb cables that stop working.
20:54:06  <DorpsGek_II> [OpenTTD/OpenTTD] nikolas updated pull request #7086: Change #6173: Update SDL driver to use SDL 2.0 https://git.io/fhamZ
20:56:26  <Beerbelott> Where is _config_dir declared?
20:56:49  <Beerbelott> Both references in openttd.cpp & fileio.cpp are tagged 'extern'
20:57:02  <Beerbelott> declared*
20:57:27  <peter1138> There is not _config_dir ?
20:57:33  *** Gumle2 has joined #openttd
20:57:49  <Beerbelott> I don't get it
20:57:51  <peter1138> Do you mean _config_file?
20:57:58  <Beerbelott> I rename all the occurrences to sth else
20:58:13  <Beerbelott> now the linker complains about undefined reference
20:58:14  <peter1138> _config_file is in settings.cpp
20:58:27  <peter1138> Oh!
20:58:29  <Beerbelott> but the definition for the new name did not change place :\
20:58:33  <peter1138> It's config_dir, not _config_dir.
20:58:45  <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7272: Change: [NPF] Add path cache for ships. https://git.io/fhpFX
20:58:59  <peter1138> config_dir isn't a global variable.
20:59:15  <peter1138> It only appears in src/fileio.cpp
20:59:43  <Beerbelott> sry I meant _config_file
20:59:45  <Beerbelott> I see https://github.com/OpenTTD/OpenTTD/blob/master/src/openttd.cpp#L565
20:59:59  <Beerbelott> but then I renamed all the occurrences and now... i's a mess
21:00:23  <TrueBrain> solution: don't! :D
21:00:23  <Beerbelott> What could have done wrong (many things, I know :p )
21:00:26  <TrueBrain> I am so good in these things :D
21:00:29  <Beerbelott> haha
21:00:33  <Beerbelott> #troll
21:00:36  <Beerbelott> -> []
21:00:54  <TrueBrain> moi?! CEST NON!
21:02:17  *** sla_ro|master has quit IRC
21:04:14  <peter1138> Right, SDL 2.0. Any objections?
21:04:19  <peter1138> I'm going with no :)
21:04:29  <peter1138> I'm also going for a pee.
21:05:21  <TrueBrain> we prepared everything to accept SDL 2.0
21:05:24  <TrueBrain> so no going back now :D
21:06:27  <peter1138> Cool.
21:06:44  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN approved pull request #7086: Change #6173: Update SDL driver to use SDL 2.0 https://git.io/fhpFx
21:06:50  <nnyby> cool ^_^ this user was seeing some weird behavior on the sdl 2 branch... im hoping this is just some sort of fluke.. https://github.com/OpenTTD/OpenTTD/issues/7296#issuecomment-468442689
21:07:12  <peter1138> Hmmm
21:07:51  <TrueBrain> we can pick either looking into that after merge, or before ;)
21:07:57  <TrueBrain> up to you peter1138 :)
21:08:12  <DorpsGek_II> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #7086: Change #6173: Update SDL driver to use SDL 2.0 https://git.io/fhpFx
21:08:21  <peter1138> Worth a quick look
21:08:46  <nnyby> looks like a case where all the video was initialized correctly, but somehow the updates just weren't triggered. really not sure how it's possible on the current branch.. dirty rectangles just working as usual. anyways, i haven't been able to reproduce this problem
21:09:05  <LordAro> peter1138: "FS#7296"
21:09:33  <peter1138> lol
21:09:39  <peter1138> Old habits.
21:09:49  <peter1138> Also why the heck did my pi kick off my ssh connection :(
21:10:18  <TrueBrain> you cannot even edit those comments
21:10:20  <TrueBrain> you can edit all, but not those
21:10:21  <TrueBrain> lol
21:10:51  <peter1138> Well, just tried with a totally fresh config, OpenGFX was bootstrapped and it works fine.
21:12:02  <nnyby> anyways, once we push sdl2 to master and everyone is forced to use it, i'm sure any problems like this will be uncovered very quickly :P so that's one debugging strategy
21:12:08  <peter1138> Hahah
21:12:31  <TrueBrain> it is the one I was hinting at ;)
21:14:38  *** Gumle2 has quit IRC
21:15:40  <peter1138> Hmm, seeing some issues
21:17:26  <peter1138> Ah, that's something else.
21:17:45  <peter1138> Switching from window to fullscreen with alt-enter fails if the mouse is not in the window.
21:18:40  <peter1138> It flicks over and then back again.
21:19:36  <nnyby> hmm, i didnt know about that shortcut. i'm not seeing that behavior right now.. it seems to work for me, using xfce, even when cursor is out of the window
21:19:49  <peter1138> Hmm, and now it's not. What.
21:19:54  <nnyby> what window manager are you using?
21:20:35  <nnyby> i was only able to uncover some problems like this with a "normal" window manager.. i use a tiling wm - xmonad - on my laptop and so i guess i gotta be testing in both
21:21:51  <peter1138> Seems to be intermittent.
21:28:17  <peter1138> Found it.
21:28:34  <peter1138> My issue, not #7296.
21:35:15  <Beerbelott> Om my
21:35:20  <Beerbelott> I'm fucking STUPID
21:35:27  <Beerbelott> I need some sleep
21:36:05  <Beerbelott> I am amending my last commit every way possible, splitting it as hell, only to realize I am compiling another damn branch.......
21:36:14  <Beerbelott> Kill me now
21:39:07  <peter1138> :D
21:45:34  *** Progman has quit IRC
21:45:52  <peter1138> Hmm, managed to make it crash.
21:46:17  <peter1138> Ah......
22:00:18  *** nielsm has quit IRC
22:00:28  <peter1138> So close and yet so far ;(
22:26:00  <Beerbelott> Has anyone anaged to load OpenGFX when calling trunk version w/ -c ?
22:34:44  *** octernion has quit IRC
22:35:01  *** Flygon has joined #openttd
22:38:10  <Beerbelott> These directories precedence are...
22:41:08  *** Wolf01 has quit IRC
22:47:45  <peter1138> Hmm, trying with Mate desktop instead of Gnome.
22:57:28  <nnyby> hmmm. link to crashlog / steps to reproduce? i'll see if i can crash this thing... i have played significant amounts of time on this branch, but very likely there's some weird edge cases to be uncovered
22:57:54  <peter1138> No, it's a bug introduced by my changed. I've got it sorted.
22:58:07  <Samu> nobody joined my game
22:58:08  <Samu> :p
23:01:12  *** HerzogDeXtEr has quit IRC
23:04:42  <nnyby> Samu: what game:P
23:04:56  <nnyby> wanna play??>_<
23:05:24  *** octernion has joined #openttd
23:22:14  <Samu> it's an ai only server :p
23:23:00  <Samu> road vehicle cache soon?
23:23:28  <acklen> Samu: what's the server?  I've got a few AIs I could test
23:23:54  *** octernion has quit IRC
23:24:07  <peter1138> Samu, probably not soon.
23:26:04  <peter1138> Everyone is busy I think :)
23:45:00  <Samu> https://servers.openttd.org/en/server/114360
23:45:08  <Samu> i'm not paying much attention honestly
23:46:45  <Beerbelott> Eddi|zuHause: I do not think what you told me was true about directory precedence was right: Directory where external configuration file sits has no precedence at all
23:47:40  <Eddi|zuHause> Beerbelott: maybe it's due for a clear redesign and redocumentation ;)
23:47:49  <Beerbelott> dbg: [console] /home/berbe/source/src/openttd.cpp:1074 SwitchToMode _file_to_saveload: name = Europe.sav, title = , fop = 1, AbstractFileType = 1, DetailedFileType: 1
23:47:49  <Beerbelott> dbg: [console] /home/berbe/source/src/fileio.cpp:421 FioFOpenFileSp Trying to load Europe.sav
23:47:49  <Beerbelott> dbg: [console] /home/berbe/source/src/fileio.cpp:421 FioFOpenFileSp Trying to load /home/berbe/source/save/Europe.sav
23:47:49  <Beerbelott> dbg: [console] /home/berbe/source/src/fileio.cpp:421 FioFOpenFileSp Trying to load /home/berbe/.openttd/save/Europe.sav
23:48:02  <Beerbelott> (mb I should have used a paste :p )
23:48:22  <Beerbelott> it just goes through a list of predefined dirs
23:48:56  <Eddi|zuHause> Beerbelott: what about the save location?
23:49:23  <Beerbelott> https://github.com/OpenTTD/OpenTTD/blob/master/src/saveload/saveload.cpp#L2771
23:49:47  <Beerbelott> See the 3 fallbacks?
23:50:08  <Beerbelott> 1st it tries to use the provided -g 'as is'
23:52:57  <Beerbelott> then goes throughhttps://github.com/OpenTTD/OpenTTD/blob/master/src/fileio_type.h#L110
23:53:31  <Beerbelott> I have a little bit of headache trying to remember who's who...
23:54:11  *** supermop_work_ has quit IRC
23:54:21  <Beerbelott> because ofc they are build on top of a searchpath... which might not be the same everytime, as I noted in my issue ;)
23:55:17  <Beerbelott> I should start a dedicated debug branch merely tracing directories path build flow
23:55:27  <Beerbelott> It wears me off
23:55:50  <Beerbelott> TL; DR I do not thing my PR breaks anything
23:57:11  <peter1138> I'm missing a resize event after toggling fullscreen off :/
23:57:21  <peter1138> Seems to depend on the WM.
23:59:09  <Eddi|zuHause> Beerbelott: still, what about the save location?

Powered by YARRSTE version: svn-trunk