Config
Log for #openttd on 28th October 2019:
Times are UTC Toggle Colours
00:47:00  *** Flygon has joined #openttd
01:36:15  *** Thedarkb1-X40 has joined #openttd
01:41:50  *** beno__ has quit IRC
02:26:27  *** Pikka has joined #openttd
02:57:13  <supermop_Home> os/2 warp?
02:57:28  <supermop_Home> was there a non-warp version of os/2?
02:57:38  <supermop_Home> hi Pikka
02:57:45  <Pikka> hello
04:20:42  *** glx has quit IRC
06:26:36  *** sla_ro|master has joined #openttd
06:46:44  *** sla_ro|master has quit IRC
07:03:30  *** Pikka has quit IRC
07:42:23  *** andythenorth has joined #openttd
07:53:04  *** stefino has joined #openttd
07:54:28  <stefino> andythenorth: ho andy, what does this "& 255" mean in case of tile check? "extra_callback_info2 & 255"
08:00:55  <andythenorth> probably a a bitmask
08:01:04  <andythenorth> where is it used?
08:02:04  <stefino> I tried to code petrol station and Im looking into your nml of FIRS
08:02:45  <stefino> trying to solve code of "road nearby"
08:04:46  <stefino> in the next switch is also  extra_callback_info2 but now with  "& 0xFF00) >> 8" so I only want to know what these numbers behind & mean :)
08:05:31  <DorpsGek_III> [OpenTTD/OpenTTD] RoqueDeicide commented on pull request #7730: Change: Use vehicle model age for station rating calculation https://git.io/Jeum0
08:19:16  * andythenorth looking
08:21:37  <andythenorth> I can't find & 255 in FIRS
08:21:42  <andythenorth> but it's probably this https://github.com/andythenorth/firs/blob/master/src/templates/location_check_macros_tile.pynml#L108
08:21:55  <andythenorth> it's tile_check https://newgrf-specs.tt-wiki.net/wiki/NML:IndustryTiles#Industry_tile_variables
08:22:27  <andythenorth> extra_callback_info2 returns multiple values in one set of bits
08:22:49  <andythenorth> the masks and shifts are used to select the correct bits
08:23:11  <andythenorth> this method is easier to understand if you have done nfo :)
08:26:09  *** HerzogDeXtEr has quit IRC
08:28:48  <stefino> okay :D I think that the best way is to set tha same nuber for now
08:43:39  *** seatsea041921 has joined #openttd
08:44:02  *** seatsea04192 has quit IRC
08:57:02  *** stefino has quit IRC
09:17:24  *** andythenorth has quit IRC
09:29:19  *** cHawk has joined #openttd
11:10:18  *** andythenorth has joined #openttd
11:10:47  *** Pikka has joined #openttd
11:14:57  <andythenorth> lo bob
11:20:08  <andythenorth> bye bob :)
11:20:09  *** andythenorth has quit IRC
12:11:38  <Pikka> oops
12:43:19  <Eddi|zuHause> <andythenorth> I can't find & 255 in FIRS <-- why would you use 255 there and not 0xFF?
12:44:00  *** andythenorth has joined #openttd
12:57:44  *** Pikka has quit IRC
13:11:14  <peter1138> Lunch time?
13:26:11  <andythenorth> I think s
13:26:12  <andythenorth> so
13:26:28  <supermop_work> ii had a bacon and rosemary fougasse?
13:26:34  <supermop_work> idkk how to spell it
13:26:40  <supermop_work> bread with holes in it
13:27:20  <andythenorth> I had cheese toastie
13:27:29  <andythenorth> but for some reason all the cheese escaped
13:27:32  <andythenorth> weird cheese
13:40:14  <peter1138> I had... a salad.
13:40:21  <peter1138> With turkey slices.
13:40:37  <peter1138> Now I have a persimmon but it's massive.
13:51:01  *** Flygon has quit IRC
13:52:44  <peter1138> Had a pear. Should I have crisps/chocolate?
13:53:10  <andythenorth> save it for later?
13:54:14  <peter1138> Nah.
13:54:26  <peter1138> I can't eat this persimmon. It's 250 kcal. In a single fruit. How!?
13:56:15  <andythenorth> sugar innit
13:56:44  <andythenorth> that is a lot of calories tho
13:59:22  <peter1138> Wait, seems to be a difference between american and japanese varieties.
13:59:27  <peter1138> 127 vs 70 per 100g
16:29:48  <DorpsGek_III> [OpenTTD/OpenTTD] sdcloudt opened pull request #7808: Removal of SVN ID line as it is not needed. https://git.io/Jeu89
16:34:09  <DorpsGek_III> [OpenTTD/OpenTTD] sdcloudt commented on pull request #7796: Unittests https://git.io/Jeu8b
16:35:31  *** cHawk has quit IRC
17:14:54  *** sla_ro|master has joined #openttd
17:16:29  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on pull request #7808: Removal of SVN ID line as it is not needed. https://git.io/JeuBe
17:17:29  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #7808: Removal of SVN ID line as it is not needed. https://git.io/JeuBk
17:18:55  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on pull request #7808: Removal of SVN ID line as it is not needed. https://git.io/JeuBm
17:19:48  *** glx has joined #openttd
17:19:48  *** ChanServ sets mode: +v glx
17:21:31  *** HerzogDeXtEr has joined #openttd
17:47:39  *** andythenorth has quit IRC
18:12:51  *** Progman has joined #openttd
18:13:50  *** andythenorth has joined #openttd
18:17:32  <milek7> supermop_work: os/2 warp 4.52
18:18:13  <milek7> now how to install gcc..
18:20:12  <andythenorth> yo
18:21:47  *** tokai has joined #openttd
18:21:47  *** ChanServ sets mode: +v tokai
18:28:38  *** tokai|noir has quit IRC
18:39:44  <andythenorth> LordAro: is it 1.10.x? :D
18:39:56  <andythenorth> or is it TV and food?
18:40:12  <LordAro> ¯\_(ツ)_/¯
18:40:23  <andythenorth> is it approving PRs?
18:40:32  <LordAro> did you find a list of changes from the last 3 weeks, or do i have to do it myself?
18:40:40  <andythenorth> doesn't git do it?
18:41:01  <LordAro> well yes, but looking at the list of merged PRs is easier
18:41:06  <andythenorth> oh yes
18:41:11  <andythenorth> no I didn't do that :P
18:41:45  <andythenorth> no dates on the github view :P
18:41:48  <andythenorth> https://github.com/OpenTTD/OpenTTD/pulls?q=is%3Apr+is%3Aclosed+sort%3Aupdated-desc
18:42:02  <andythenorth> I guess 21 days ago is enough
18:42:14  <LordAro> more or less, yeah
18:42:25  <andythenorth> oh, it's not a reliable sort
18:42:26  <andythenorth> hmm
18:42:52  <andythenorth> sort is updated, but updated date  != merged date
18:42:59  <andythenorth> at least not for all cases
18:43:07  <LordAro> it's generally quite close
18:44:11  <andythenorth> is there a 1.10 branch? Or how do I see what's already merged?
18:44:17  <andythenorth> or is nothing merged yet?
18:44:31  <andythenorth> I have https://github.com/OpenTTD/OpenTTD/pull/7726
18:44:41  <LordAro> 1.10 branch doesn't exist until the release candidates
18:44:48  <LordAro> it's just master/trunk until then
18:45:28  <LordAro> there are some things i'd like to be fixed before branching
18:45:41  <LordAro> like the road vehicle station sharing
18:45:45  <andythenorth> +1
18:45:54  <LordAro> but beta1 is perfectly doable
18:47:52  <andythenorth> I do think we should get that station fix out ASAP
18:47:57  <andythenorth> it keeps recurring
18:48:04  <andythenorth> (the sign move bug)
18:51:42  <glx> this one is fixed in master
18:54:10  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro updated pull request #7726: Prepare for 1.10.0-beta1 release https://git.io/fjjht
18:54:15  <LordAro> think that's everything
18:54:57  *** gelignite has joined #openttd
18:56:35  *** Wolf01 has joined #openttd
18:59:30  <andythenorth> hurrah
19:02:52  <Wolf01> Should I continue to watch "restoration of old engines" on youtube?
19:50:59  <andythenorth> maybe
19:51:03  *** tycoondemon has quit IRC
20:18:19  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #7806: Doc: update COPYING to restore a missing line and use markdown formatting https://git.io/JeuES
20:18:32  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro merged pull request #7806: Doc: update COPYING to restore a missing line and use markdown formatting https://git.io/JeE5o
20:26:23  <andythenorth> thx
20:26:51  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth updated pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeEde
20:27:32  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth updated pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeEde
20:27:48  <andythenorth> updated link to the copying.md
20:27:49  <andythenorth> :P
20:28:05  * andythenorth wonders how long README will stay in nitpick mode :)
20:28:09  <andythenorth> place bets?
20:28:13  <andythenorth> done by Christmas?
20:28:34  <LordAro> 1.10.0 on Christmas?
20:28:44  <LordAro> i think there's still enough time..
20:42:11  * andythenorth might have completed The Great Docs Revival by then :P
20:42:26  <andythenorth> actually, when README is done, I can probably stop?
20:42:38  <andythenorth> I daren't look in the gameplay or newgrf sections of the wiki :)
20:59:48  *** gelignite has quit IRC
21:03:39  <orudge> andythenorth: are you planning on killing off Allegro?
21:04:03  <orudge> [18:18:15] <milek7> now how to install gcc.. <-- I'm assuming you've seen https://os2ports.smedley.id.au/index.php
21:04:24  *** sla_ro|master has quit IRC
21:04:35  <orudge> milek7: although these days there's also an RPM repository with various bits and bobs. I did have OpenTTD updated and more or less building on OS/2 with the cmake branch, but the cmake branch hasn't quite made it to master yet
21:12:09  <andythenorth> orudge: no idea :)  It remains mentioned in the recent COMPILING.md doc https://github.com/OpenTTD/OpenTTD/blob/master/COMPILING.md
21:13:49  <orudge> andythenorth: was just wondering. Without a DOS target it's not really necessary any more, and I doubt anyone uses it in preference to SDL/Win32. Maybe one day we'll resurrect DJGPP support though :D
21:14:25  <milek7> https://i.imgur.com/7A66xt2.png
21:14:40  <milek7> i was curious about it as i have never seen os/2 before, but it is actually horrible
21:14:51  <orudge> milek7: it is "interesting", yes
21:15:15  <milek7> hm, maybe netscape 'save link as' is somehow broken
21:15:27  <orudge> There's an OpenSSH port available for OS/2, I was trying to get it to work so I could SSH to OS/2 to do my OpenTTD stuff, but never managed to get it to function properly :(
21:16:00  <orudge> milek7: you should be able to get a port of Firefox which may be a bit more reliable these days
21:19:13  <andythenorth> dunno who decides about compiler support :)
21:19:37  <milek7> even installing os was 'fun', i did it 4 times before it booted successfully ;d
21:20:07  <milek7> enough software archeology for today
21:28:26  <andythenorth> orudge: do a PR killing allegro? :)
21:28:56  <orudge> andythenorth: I don't particularly want to kill it, but I also expect it's not being maintained. Should maybe try to build with it and see if it works!
21:29:21  <milek7> allegro build works, at least on linux
21:29:44  <glx> it should still work, no real changes in the video area for a long time
21:30:13  <glx> except the limit on number of screen resolutions
21:30:24  <glx> (macOS is still limited though)
21:33:16  <LordAro> someone should approve #7726
21:33:20  <LordAro> go on, you know you want to
21:37:28  * andythenorth reading it
21:38:47  <andythenorth> do I have to double-check the entire changelog?
21:39:25  <LordAro> i don't think so, no :p
21:39:27  <LordAro> just the new bit
21:40:40  <andythenorth> I meant the diff :)
21:40:50  <LordAro> oh right, i see
21:40:53  <LordAro> eh, up to you
21:41:08  <LordAro> go through the non-backported PRs from the last year or so
21:41:14  <LordAro> see if there's anything i've missed
21:41:15  <andythenorth> wow so much new stuff
21:41:26  <andythenorth> ok this is not a 2 minute read, approve
21:41:27  <LordAro> or if there's some stuff that should be reclassified or cut out
21:41:41  <LordAro> andythenorth: nono, OTTD is dying
21:41:55  <andythenorth> as long as it's dying not dead
21:44:03  <andythenorth> do we mention doc / typo PRs?
21:44:14  <LordAro> usually not
21:44:33  <LordAro> really minor stuff and stuff that wasn't in a released version gets left out
21:44:43  <andythenorth> this in? https://github.com/OpenTTD/OpenTTD/pull/7699
21:45:20  <LordAro> not a user visible change (in nearly all use cases)
21:45:34  <andythenorth> https://github.com/OpenTTD/OpenTTD/pull/7802 ?
21:45:43  <LordAro> you're only going to see it in strace or gdb output
21:46:09  <LordAro> andythenorth: multi-tile dock related crash, not a released version
21:46:13  <andythenorth> ok
21:47:16  <andythenorth> https://github.com/OpenTTD/OpenTTD/pull/7752 ?
21:48:12  <LordAro> yeah, that's a good one
21:48:23  <andythenorth> potential source of newgrf bug reports
21:49:01  <LordAro> "- Change: Inactive industries do not make sound effects (#7752)" ?
21:49:29  <andythenorth> seems fine
21:50:04  <andythenorth> user reported crash fixed? https://github.com/OpenTTD/OpenTTD/pull/7652
21:50:44  <LordAro> pretty sure that was post-1.9 as well...
21:50:47  <LordAro> should check though
21:50:51  <andythenorth> k
21:51:03  <andythenorth> I'm ignoring all compile stuff
21:51:07  <andythenorth> and bundling
21:51:37  <LordAro> ah yes, that was for station coverage display
21:51:41  <LordAro> post 1.9
21:52:55  <andythenorth> oh the backported tag is quite useful
21:53:05  <andythenorth> let's me know to stop
21:53:16  <LordAro> :p
21:54:14  <andythenorth> I'm done, did you push the 7752 change?
21:54:22  <andythenorth> can approve when that's done
21:55:12  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro updated pull request #7726: Prepare for 1.10.0-beta1 release https://git.io/fjjht
21:56:08  <LordAro> there you go
21:56:51  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth approved pull request #7726: Prepare for 1.10.0-beta1 release https://git.io/JeuzA
21:57:02  <andythenorth> winner winner
21:58:10  <andythenorth> website release too?
21:58:11  <andythenorth> :P
22:01:01  <LordAro> will want a website post, indeed
22:01:01  *** Progman has quit IRC
22:01:19  <LordAro> wait, did we ever approve the dev blog?
22:01:24  <LordAro> or merge
22:05:45  <andythenorth> no comment :(
22:06:08  <LordAro> 2 posts at once it is then
22:08:26  <LordAro> still, i'd like more than 1 approval before i tag
22:08:41  <LordAro> glx: ? :)
22:09:33  <glx> on #7726 ?
22:09:38  <LordAro> yeah
22:10:03  <DorpsGek_III> [OpenTTD/website] LordAro approved pull request #106: Create 2019-10-19-monthly-dev-post.md https://git.io/Jeugn
22:10:46  <DorpsGek_III> [OpenTTD/website] LordAro merged pull request #106: Create 2019-10-19-monthly-dev-post.md https://git.io/JeBzW
22:11:12  <glx> hmm need to check if some recent file renames don't kill bundling
22:12:03  <LordAro> that'd be good
22:12:10  <glx>     $(Q)unix2dos "$(ROOT_DIR)/docs/"* "$(ROOT_DIR)/README.md" "$(ROOT_DIR)/COPYING" "$(ROOT_DIR)/changelog.txt" "$(ROOT_DIR)/known-bugs.txt"
22:12:23  <LordAro> COPYING needs an update
22:12:28  <glx> COPYING.md now I think
22:12:33  <LordAro> everything else is fine
22:14:12  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 approved pull request #7726: Prepare for 1.10.0-beta1 release https://git.io/Jeug0
22:14:27  <LordAro> glx: i can add that change to #7726 if you like
22:15:52  <glx> I think there's 3 locations to touch
22:16:49  <glx> 2 in Makefile.bundle.in and 1 in install.nsi, but I launched a global search
22:18:56  *** supermop_elsewhere has joined #openttd
22:21:08  <DorpsGek_III> [OpenTTD/website] LordAro opened pull request #108: Create 2019-10-29-monthly-dev-post.md https://git.io/JeugK
22:21:26  <LordAro> wait, crap, i didn't change the file title
22:21:36  <LordAro> andythenorth: ^ go nuts, needs some improvement yet
22:23:45  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro dismissed a review for pull request #7726: Prepare for 1.10.0-beta1 release https://git.io/Jeug0
22:23:45  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro dismissed a review for pull request #7726: Prepare for 1.10.0-beta1 release https://git.io/JeuzA
22:23:48  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro updated pull request #7726: Prepare for 1.10.0-beta1 release https://git.io/fjjht
22:23:54  <LordAro> noo, my approvals
22:23:56  <LordAro> glx: ^
22:25:46  <DorpsGek_III> [OpenTTD/website] LordAro updated pull request #108: Create 2019-10-29-monthly-dev-post.md https://git.io/JeugK
22:26:44  <glx> LordAro: rebase the branch, multiplayer.txt is still wrong
22:26:57  <glx> and I'm sur I fixed it :)
22:27:03  <glx> *sure
22:28:58  <glx> oh broken link in CONTRIBUTING.md too
22:29:56  <LordAro> honestly, who approved that PR
22:30:16  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro updated pull request #7726: Prepare for 1.10.0-beta1 release https://git.io/fjjht
22:30:45  <LordAro> oh, bad merge
22:31:36  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro updated pull request #7726: Prepare for 1.10.0-beta1 release https://git.io/fjjht
22:32:12  *** Wolf01 has quit IRC
22:32:16  <LordAro> done
22:32:34  <andythenorth> is NRT no longer notroadtypes? :)
22:32:41  <andythenorth> I am +/-0 to the name
22:32:58  <LordAro> andythenorth: i feel NewGRF RoadTypes might be more descriptive to the average reader :p
22:33:02  <andythenorth> yes
22:33:06  <LordAro> but i give you free reign over the news post
22:33:06  <andythenorth> wfm
22:33:09  <LordAro> do whatever you want
22:35:58  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 approved pull request #7726: Prepare for 1.10.0-beta1 release https://git.io/JeugH
22:36:29  <glx> so I need to try to remember to check everywhere when a file is renamed :)
22:37:05  <glx> rebasing cmake branch will be fun
22:37:25  <LordAro> found a couple more
22:37:55  <glx> yeah there's one in readme, one in rpm spec, another in OS2 installer
22:38:12  <glx> but I think they're not build breaker
22:39:02  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro dismissed a review for pull request #7726: Prepare for 1.10.0-beta1 release https://git.io/JeugH
22:39:02  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro updated pull request #7726: Prepare for 1.10.0-beta1 release https://git.io/fjjht
22:42:07  <glx> hmm line 74 of OS2, the readme is not renamed
22:42:29  <andythenorth> good reason to drop the port :D
22:42:33  <andythenorth> oof
22:43:38  <LordAro> i'm not sure this particular file has been touched since 1.0
22:43:49  <LordAro> judging by the versions at the top
22:44:38  <LordAro> but whatever
22:44:47  <glx> I don't even know if this installer is still valid
22:44:49  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro updated pull request #7726: Prepare for 1.10.0-beta1 release https://git.io/fjjht
22:48:56  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 approved pull request #7726: Prepare for 1.10.0-beta1 release https://git.io/Jeu2f
22:50:14  <LordAro> glx: i'm happy to make the tag, you want to merge?
22:50:55  <glx> waiting for the CI result
22:51:12  <LordAro> pfft.
22:51:19  <glx> squash or rebase ?
22:51:31  <LordAro> rebase would seem more proper to me
22:51:34  <glx> better keep all the commits I guess yes
22:51:44  <LordAro> there's a few not-quite-related changes in there
22:52:24  <glx> I like the Add: Me one :)
22:52:57  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 merged pull request #7726: Prepare for 1.10.0-beta1 release https://git.io/fjjht
22:53:18  <LordAro> right, last chance to prevent the tag
22:53:42  <LordAro> could wait until the master CI completes, i guess
22:56:48  <andythenorth> :o did 16 cargo industry not ship in 1.9.0?
22:56:55  * andythenorth checking changelog
22:57:04  <glx> no it's after
22:57:07  <andythenorth> oh yeah they did, all is well :)
22:57:20  <andythenorth> 1.9.0-beta1 - Feature: [NewGRF] Ability for industries & houses to produce and/or accept up to 16 different cargoes
22:57:45  <LordAro> it's in the changelog for 1.10...
22:57:50  <glx> hmm makes me think the industry window is still broken
22:57:59  <LordAro> yeah, it is
22:58:27  <LordAro> but we're pretty sure there's no newgrf out there (except test FIRS) that triggers it
22:58:28  <glx> with a crashing bug
22:58:33  <andythenorth> yeah
22:58:44  <andythenorth> but there are quite a lot of FIRS forks now
22:59:01  <andythenorth> and there is a weird habit of combining all industries and cargos to one single grf
22:59:08  <LordAro> there's an open issue, it's not a terrible thing
22:59:33  <LordAro> #7631
22:59:35  <andythenorth> the 1.10 post needs a tweak to drop the 16 cargo industry
22:59:40  <andythenorth> but I really should be asleep :P
22:59:55  <LordAro> so does the changelog, but perhaps we can just tweak it for beta2? :)
23:00:04  <glx> I have a dirty fix for it
23:01:52  * andythenorth back tomorrow, much zzzzzzzzz
23:01:54  *** andythenorth has left #openttd
23:02:55  <LordAro> glx: go on...
23:07:01  <glx> https://github.com/OpenTTD/OpenTTD/compare/master...glx22:fix_7631_alt?expand=1 <-- that's the dirty fix
23:07:27  <LordAro> oh right, yes
23:07:31  <glx> https://github.com/OpenTTD/OpenTTD/compare/master...glx22:industry_directory?expand=1 <-- less dirty I think
23:07:36  <LordAro> i thought you were referring to the changelog :p
23:07:39  <LordAro> tag time!
23:08:12  <glx> I'll take a screenshot of the less dirty fix
23:08:33  <LordAro> on brief glance, less dirty fix looks better for sure
23:10:22  <LordAro> hmm, no irc notification
23:10:27  <LordAro> i think we found this last time
23:10:29  <LordAro> ah well
23:10:31  <LordAro> done \o/
23:16:24  <LordAro> hrm, release CI hasn't triggered?
23:17:20  <glx> it's running
23:17:39  <glx> https://dev.azure.com/openttd/OpenTTD/_build/results?buildId=4471
23:18:07  <LordAro> aah, build failures
23:18:55  <glx> old gcc I guess
23:19:22  <LordAro> i fear so
23:19:37  <LordAro> looks like the std::move's i removed a while back
23:19:53  <LordAro> perhaps we don't have to care about the missing jessie builds?
23:19:59  <LordAro> it is oldstable now
23:20:04  <glx> but jessie is quite old yes
23:20:13  <LordAro> actually no, it's oldoldstable
23:20:29  <glx> stretch is oldstable I think
23:20:45  <LordAro> yeah, buster is stable now
23:21:31  <glx> win32 installer done
23:24:53  <LordAro> of course, it probably won't update the manifest/website/things if there's a build failure
23:25:26  <LordAro> or maybe it will
23:26:01  <glx> I don't know how it's handled
23:31:49  <LordAro> poke TB tomorrow morning if it's not appeared
23:32:16  * LordAro sleep
23:32:37  *** supermop_elsewhere has quit IRC
23:39:20  *** Pikka has joined #openttd
23:43:38  <LordAro> might need to just exclude the jessie builds and remake the tag
23:45:10  <Eddi|zuHause> what's the point of a CI if you just disable it whenever you please?
23:45:18  *** HerzogDeXtEr has quit IRC
23:45:32  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 opened pull request #7809: Fix #7631: replace produced&transported with cargo sprites in industry directory https://git.io/JeuaI
23:45:45  <glx> opened a draft with the screenshot
23:46:18  <glx> Eddi|zuHause: CI doesn't test everything
23:47:38  <glx> hmm disabling stuff means changing the yml in the repo
23:48:45  <Eddi|zuHause> no, it probably doesn't test everything (which is itself a problem), but if a test fails for some reason, you fix it, properly, and not just disalbe the test
23:48:58  <LordAro> depends why the test is failing
23:49:15  <LordAro> if the reason is "we don't support that compiler any more", i don't think that's unreasonable
23:49:42  <LordAro> i'll have a look tomorrow morning, shouldn't be too difficult to add a buster docker build in its place
23:49:54  <LordAro> would be useful to have, for sure
23:49:55  <Eddi|zuHause> in any case, it shouldn't be time critical enough to not wait till tomorrow
23:50:12  <LordAro> it would've been nice to have advance warning of the failure, yes
23:50:34  * LordAro actually slep
23:50:51  <glx> manifests are done anyway
23:51:01  <glx>   condition: succeededOrFailed()

Powered by YARRSTE version: svn-trunk