Config
Log for #openttd on 10th November 2019:
Times are UTC Toggle Colours
00:15:08  <DorpsGek_III> [OpenTTD/nml] matthijskooijman commented on pull request #54: Fix #39: Add compatibility with >=pillow-7.0.0 https://git.io/JeV92
00:45:15  *** arikover has quit IRC
01:33:36  *** WormnestAndroid has quit IRC
01:35:53  *** WormnestAndroid has joined #openttd
01:55:47  *** WormnestAndroid has quit IRC
01:56:50  *** WormnestAndroid has joined #openttd
02:02:41  *** gelignite2nd has joined #openttd
02:07:18  *** Progman has quit IRC
02:10:01  *** gelignite has quit IRC
02:47:35  *** gelignite2nd has quit IRC
03:31:50  *** glx has quit IRC
03:44:19  *** D-HUND has joined #openttd
03:46:31  *** supermop_Home_ has joined #openttd
03:47:47  *** debdog has quit IRC
06:41:17  *** sla_ro|master has joined #openttd
07:37:21  *** andythenorth has joined #openttd
07:46:02  *** andythenorth has quit IRC
08:02:18  *** HerzogDeXtEr has joined #openttd
08:06:03  *** andythenorth has joined #openttd
08:45:42  *** Progman has joined #openttd
10:01:02  *** nielsm has joined #openttd
10:08:12  <TrueBrain> that moment that your application has more lines of comments than code ..
10:08:17  <nielsm> hello
10:08:23  <TrueBrain> hi nielsm
10:08:38  <nielsm> back from vacation
10:08:52  *** andythenorth has quit IRC
10:09:37  <TrueBrain> and, how was your vacation? :D All refreshed and all?
10:29:48  *** Arveen has quit IRC
10:41:40  <TrueBrain> Server 127.0.0.1:3979 online
10:41:40  <TrueBrain> Server 127.0.0.1:3979 offline
10:41:41  <TrueBrain> w00p
10:41:49  <TrueBrain> dammit, I now leaked my IP :(
10:58:44  <TrueBrain> https://github.com/TrueBrain/OpenTTD-MasterServer/pull/1 <- it is far from done, but I could use an initial look if this is going the right direction :D (possibly something LordAro can help me out with)
11:01:19  *** Samu has joined #openttd
11:07:57  *** trainzz has joined #openttd
11:18:16  <Eddi|zuHause> haha, n00b, i'm gonna hack your IP now!
11:22:17  <nielsm> when's ottd getting support for this? https://0x0.st/zEeT.webm
11:22:36  <TrueBrain> pretty sure peter1138 has a patch for that :D
11:24:20  *** trainzz has quit IRC
11:37:15  *** Arveen has joined #openttd
11:42:48  *** frosch123 has joined #openttd
11:54:46  *** D-HUND is now known as debdog
12:50:30  *** Progman has quit IRC
13:07:46  <TrueBrain> lol ... there is a bug in OpenTTD's server code .. :D
13:08:07  <TrueBrain> the first time you advertise, and if you are running dualstack, you will get 2 server entries, instead of 1
13:08:29  <TrueBrain> Server 1649820221571175 with ::1:3979 online
13:08:29  <TrueBrain> Server 1649820221571081 with 127.0.0.1:3979 online
13:08:38  <TrueBrain> those server keys should be identical; they are not :)
13:08:48  <TrueBrain> second time they announce, they are
13:08:52  <TrueBrain> :D
13:13:17  *** andythenorth has joined #openttd
13:18:41  <DorpsGek_III> [OpenTTD/OpenTTD] TrueBrain opened issue #7828: First time server registration ends up in multiple online servers instead of one https://git.io/JeVNi
13:19:21  <TrueBrain> I wonder how common this is
13:31:54  *** Progman has joined #openttd
13:41:13  *** gelignite has joined #openttd
13:44:02  <frosch123> i think i saw some fs bug like that, but noone triaged it
13:44:22  <TrueBrain> funny, how rebuilding the masterserver shows this problem :D
13:44:37  <TrueBrain> I have no server-side mitigation to this; it really needs to be fixed in OpenTTD
13:45:34  <TrueBrain> well, not completely true; when the session_key is zero, I can send a new session_key to the server, and just don't ack his request. In result a few seconds later the server will rebroadcast his advertisement request, having the correct session_keys
13:45:40  <TrueBrain> bit dirty, but that does work :P
13:56:36  <TrueBrain> yeah, that works, but is a bit .. nasty
13:57:57  <TrueBrain> hmm .. unregister is also weird
13:58:02  <TrueBrain> it unregisters on every IP it has
13:58:06  <TrueBrain> instead of only the session_key
14:01:22  <TrueBrain> ugh, and ... I now realise that this protocol has a bigger issue :P
14:01:37  <TrueBrain> and the code is so horrible to fix ..
14:02:23  <DorpsGek_III> [OpenTTD/OpenTTD] TrueBrain opened issue #7829: Unregister of MasterServer happens per IP, instead of per session_key https://git.io/JeVAz
14:10:25  <DorpsGek_III> [OpenTTD/OpenTTD] TrueBrain commented on issue #7828: First time server registration ends up in multiple online servers instead of one https://git.io/JeVNi
14:31:45  *** Flygon has quit IRC
14:42:23  <andythenorth> yo
14:56:12  <LordAro> good morn
15:05:42  *** WormnestAndroid has quit IRC
15:30:39  *** WormnestAndroid has joined #openttd
15:40:58  *** Wormnest has joined #openttd
15:43:04  <andythenorth> is it PRs
15:43:07  <andythenorth> ?
16:05:53  *** WormnestAndroid has quit IRC
16:23:34  *** arikover has joined #openttd
16:26:05  *** WormnestAndroid has joined #openttd
16:39:14  <DorpsGek_III> [OpenTTD/OpenTTD] James103 commented on issue #7828: First time server registration ends up in multiple online servers instead of one https://git.io/JeVNi
16:41:06  <TrueBrain> what a weird question .. it doesn't add something to know this .. hmm .. *shrug*
16:45:00  <DorpsGek_III> [OpenTTD/OpenTTD] TrueBrain commented on issue #7828: First time server registration ends up in multiple online servers instead of one https://git.io/JeVNi
16:46:04  <Eddi|zuHause> there's like 3 years between those?
16:46:29  <TrueBrain> sounds about right
16:48:24  <andythenorth> he just wants to test it
16:48:28  <andythenorth> he likes testing
16:49:19  <TrueBrain> I already mitigated the issue, so testing is not really possible :D
16:53:20  <Eddi|zuHause> test what, anyway? it's not like he can try different versions of the masterserver
16:53:33  <andythenorth> there will be something
16:53:52  <andythenorth> it will be a reason to file another one of those very critical issues
17:50:01  <andythenorth> LordAro: README? :D
17:51:42  <LordAro> oh yeah
17:51:48  <LordAro> reading through TrueBrain's master server right now
17:57:41  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro requested changes for pull request #7827: Update: [AzurePipeline] manifest.sh for OpenTTD/website#111 https://git.io/JeVji
17:58:05  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro merged pull request #7824: Fix #7697: Add a Missing AddProducedCargo proc for HQ https://git.io/Je2I2
17:58:07  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro closed issue #7697: GetCargoProduction on Company HQ returns 0 for PASS/MAIL, but on TileLoop it does produce cargo https://git.io/fjda0
17:58:33  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #7825: Fix #7783, #7816: SDL2: Fix various issues with keyboard input https://git.io/JeVjM
17:58:45  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro merged pull request #7825: Fix #7783, #7816: SDL2: Fix various issues with keyboard input https://git.io/Je2wr
17:58:46  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro closed issue #7783: SDL2: Not possible to type shift-T into a edit context in multiplayer https://git.io/JeByK
17:58:48  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro closed issue #7816: SDL2: in console, typing _ or + zooms in and out the map https://git.io/JegWa
17:59:23  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro merged pull request #7808: Removal of SVN ID line as it is not needed. https://git.io/Jeu89
18:00:00  <andythenorth> do a release :P
18:00:05  <andythenorth> monthly releases? o_O
18:00:10  <LordAro> could do!
18:00:18  <LordAro> calm down
18:03:02  <andythenorth> ship early ship often :P
18:09:33  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro requested changes for pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeVjA
18:09:37  <LordAro> andythenorth: mwhaha.
18:29:30  *** tokai has joined #openttd
18:29:30  *** ChanServ sets mode: +v tokai
18:31:20  *** glx has joined #openttd
18:31:20  *** ChanServ sets mode: +v glx
18:36:27  *** tokai|noir has quit IRC
18:45:49  <DorpsGek_III> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/Jewvv
18:45:49  <DorpsGek_III>   - Update: Translations from eints (by translators)
18:46:27  <TrueBrain> tnx LordAro
18:46:57  <TrueBrain> pytest is already running; showing the coverage is a good idea :D
18:48:33  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 updated pull request #7827: Update: [AzurePipeline] manifest.sh for OpenTTD/website#111 https://git.io/Jea88
18:50:04  <DorpsGek_III> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7827: Update: [AzurePipeline] manifest.sh for OpenTTD/website#111 https://git.io/Jewvs
18:50:14  <TrueBrain> silly commit message is silly glx :)
18:50:32  <glx> I miss your comment before amending
18:51:40  <TrueBrain> and it is common practice to move  to a variable first
18:51:42  <TrueBrain> instead of using it
18:51:49  <TrueBrain> as  reads terrible, but it also not descriptive :D
18:52:17  <TrueBrain> (especially as  has 2 meanings in this function :D)
18:53:01  <TrueBrain> should we move source tarballs to dev-files too?
18:53:07  <TrueBrain> (open question)
18:55:42  <LordAro> i'd say so
19:04:48  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #7809: Fix #7631:  16 out cargo support for industry directory https://git.io/Jewv6
19:05:28  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro dismissed a review for pull request #7827: Update: [AzurePipeline] manifest.sh for OpenTTD/website#111 https://git.io/JeVji
19:12:03  <andythenorth> 3 company colours! https://www.railpictures.net/photo/715851/
19:40:00  <andythenorth> so README :P
19:40:06  <andythenorth> such revisions to make
20:03:52  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 updated pull request #7827: Update: [AzurePipeline] manifest.sh for OpenTTD/website#111 https://git.io/Jea88
20:14:05  <TrueBrain> glx: much better :)
20:14:15  <TrueBrain> 1 nitpicking thing, putting {} around variables is much advised
20:14:22  <TrueBrain> makes reading easier, but also avoids mistakes
20:14:32  <TrueBrain> $(cat ${FOLDER}/$filename.md5sum | cut -d\  -f1)" <- so ${filename} instead
20:14:51  <TrueBrain> the only common exception it $i, which is a silly variable name to use to start with :D
20:15:54  <glx> $i was here before, but I can change it
20:16:02  <TrueBrain> yeah, $i was me, that is stupid :)
20:16:23  <TrueBrain> but if only you fix ${key} and ${filename}, I am a happy man :)
20:19:25  <glx> done locally
20:19:30  <TrueBrain> <3
20:22:30  <glx> so now which files to move :)
20:23:19  <glx> source docs for sure
20:23:31  <glx> AI and GS I don't know
20:24:51  <glx> hmm but they are not required to play, only for script devs
20:31:36  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 updated pull request #7827: Codechange: [AzurePipeline] add developer files section in manifest https://git.io/Jea88
20:31:44  <glx> it's so easy to add filters now :)
20:32:40  <andythenorth> LordAro: so move the CONTRIBUTING.md license to that file?
20:33:07  <TrueBrain> docs for sure should be dev-files, yes :)
20:34:26  <glx> probably source archives too
20:35:05  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth dismissed a review for pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeV6D
20:35:05  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth updated pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeEde
20:36:24  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth updated pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeEde
20:40:10  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth commented on pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JewJG
20:40:49  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth updated pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeEde
20:40:55  <andythenorth> this is annoying, I can see the GH rendered md without pushing :P
20:41:11  <andythenorth> and if I close the PR to avoid dorpsgek spam, I'll lose the reviews
20:41:50  <glx> you need a markdown viewer
20:42:19  <andythenorth> I've got one
20:42:45  <glx> or a second branch just to check on your own github
20:43:00  <glx> then you cherrypick
20:44:17  <glx> btw if you close the PR then force push you can't reopen it
20:44:29  <glx> IIRC
20:50:10  <andythenorth> meh, faff, I'll just keep spamming
20:52:45  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth commented on pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JewJV
20:54:18  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth updated pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeEde
20:55:41  <andythenorth> hmm
20:56:00  <andythenorth> I find it weird that we have official forums
20:56:13  <andythenorth> but ok, I'll revise the README back again
20:57:01  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth updated pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeEde
20:58:57  <Eddi|zuHause> why would the forums not be official?
20:59:09  <Eddi|zuHause> forum.openttd.org should exist
20:59:21  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth updated pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeEde
21:00:02  <andythenorth> it's weird having official forums that are so readily ignored and dismissed
21:00:04  <TrueBrain> it does, and it is
21:00:10  <andythenorth> and from which many core contributors have been driven out
21:00:14  <andythenorth> but anyway
21:00:26  <andythenorth> I have called it 'the forum' again, instead of TT-Forums
21:02:09  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth updated pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeEde
21:04:46  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth updated pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JeEde
21:05:02  <andythenorth> fixed some more lines and punctuation :P
21:05:23  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth commented on pull request #7807: Doc: revised README to be more helpful to casual GitHub visitors https://git.io/JewJx
21:05:50  <andythenorth> LordAro: I've fixed most of those, there's a couple where remaining creative juice is zero :P
21:07:38  *** arikover has quit IRC
21:07:53  *** arikover has joined #openttd
21:31:26  *** arikover has quit IRC
21:31:38  *** arikover has joined #openttd
21:46:45  *** arikover has quit IRC
22:19:11  *** andythenorth has left #openttd
22:22:53  *** Wormnest_ has joined #openttd
22:26:44  *** sla_ro|master has quit IRC
22:28:48  *** Wormnest has quit IRC
22:35:58  *** WormnestAndroid has quit IRC
22:36:28  *** WormnestAndroid has joined #openttd
23:06:53  *** frosch123 has quit IRC
23:07:37  *** Flygon has joined #openttd
23:08:12  *** HerzogDeXtEr has quit IRC
23:14:29  *** Samu has quit IRC
23:38:15  *** Progman has quit IRC

Powered by YARRSTE version: svn-trunk