Config
Log for #openttd on 7th February 2020:
Times are UTC Toggle Colours
00:07:36  *** Heisi has quit IRC
00:24:58  *** snail_UES_ has joined #openttd
00:38:36  *** snail_UES_ has quit IRC
00:42:49  *** WormnestAndroid has quit IRC
00:44:14  *** WormnestAndroid has joined #openttd
00:44:33  *** WormnestAndroid has quit IRC
00:48:24  *** WormnestAndroid has joined #openttd
00:55:59  *** WormnestAndroid has quit IRC
01:01:14  *** WormnestAndroid has joined #openttd
01:33:08  *** Flygon has joined #openttd
02:42:39  *** heffer has quit IRC
02:53:54  *** heffer has joined #openttd
03:36:15  *** debdog has joined #openttd
03:38:02  *** Wormnest has quit IRC
03:38:07  *** glx has quit IRC
03:39:38  *** D-HUND has quit IRC
03:46:56  *** Pikka has joined #openttd
03:47:39  *** heffer_ has joined #openttd
03:49:25  *** heffer has quit IRC
04:29:47  *** Pikka has quit IRC
05:42:01  *** sla_ro|master has joined #openttd
06:04:08  *** adikt has joined #openttd
06:12:49  *** gnu_jj has quit IRC
06:34:56  *** andythenorth has joined #openttd
06:42:48  *** adikt has quit IRC
06:51:23  *** gnu_jj has joined #openttd
07:52:09  *** mrtmol[m] has left #openttd
08:10:41  *** andythenorth has quit IRC
08:13:57  *** andythenorth has joined #openttd
08:21:48  *** andythenorth has quit IRC
08:24:16  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh requested changes for pull request #7981: Close #7735: Implement protocol handling https://git.io/JvnJR
08:26:20  *** andythenorth has joined #openttd
08:27:40  *** andythenorth has quit IRC
08:51:37  *** andythenorth has joined #openttd
08:54:37  <andythenorth> yo
08:55:58  <LordAro> yoyo
08:57:25  *** el3ktr4 has joined #openttd
08:58:15  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #7981: Close #7735: Implement protocol handling https://git.io/JvnUm
09:13:37  *** el3ktr4 has quit IRC
09:16:31  *** el3ktr4 has joined #openttd
09:39:10  *** Eddi|zuHause2 has joined #openttd
09:44:01  *** Eddi|zuHause has quit IRC
10:05:17  *** Eddi|zuHause2 is now known as Eddi|zuHause
10:06:07  <Eddi|zuHause> i don't understand cities:skylines... i had 2 types of each school, and now one type is just gone, all the buildings i had of it disappeared and i can't build it anymore
10:21:00  <SpComb> mods?
10:27:08  <Eddi|zuHause> i'm pretty sure they were original vanilla and later updated vanilla versions
10:28:01  <Eddi|zuHause> i've no clue when they were changed
10:28:18  <Eddi|zuHause> they might have been of some building sets?
10:36:50  <Eddi|zuHause> hm weird, now i seem to be able to build them again...
10:48:37  *** Sheogorath has quit IRC
10:48:45  *** Sheogorath has joined #openttd
11:05:45  <Eddi|zuHause> also all of my police stations and some fire stations seem to have disappeared
11:18:52  <SpComb> cultural revolution
11:31:17  *** jjavaholic has joined #openttd
11:46:51  *** jjavaholic has quit IRC
11:47:08  *** jjavaholic has joined #openttd
12:30:44  *** spnda has joined #openttd
12:51:43  *** WormnestAndroid has quit IRC
12:51:57  *** WormnestAndroid has joined #openttd
13:05:03  *** gelignite has joined #openttd
13:36:20  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on pull request #7981: Close #7735: Implement protocol handling https://git.io/Jvntx
14:11:47  *** Tirili has joined #openttd
14:16:45  *** epoll has quit IRC
14:22:34  *** nielsm has joined #openttd
14:37:54  *** bjarni has joined #openttd
14:38:33  *** debdog has quit IRC
14:38:33  *** johanna[m] has quit IRC
14:38:33  *** Corns[m] has quit IRC
14:38:33  *** menelaos[m] has quit IRC
14:38:33  *** natalie[m] has quit IRC
14:38:33  *** karoline[m] has quit IRC
14:38:33  *** blim[m] has quit IRC
14:38:33  *** yoltid[m] has quit IRC
14:38:33  *** paulus[m] has quit IRC
14:38:33  *** ircer[m] has quit IRC
14:38:33  *** dag[m] has quit IRC
14:38:33  *** khavik[m] has quit IRC
14:38:33  *** grag[m] has quit IRC
14:38:33  *** karl[m] has quit IRC
14:38:33  *** DecapitatedO has quit IRC
14:38:33  *** avdg has quit IRC
14:38:33  *** XeryusTC has quit IRC
14:38:33  *** Hirundo has quit IRC
14:38:33  *** ericnoan has quit IRC
14:38:33  *** DorpsGek_III has quit IRC
14:38:33  *** SmatZ has quit IRC
14:39:03  *** debdog has joined #openttd
14:39:05  *** adikt has joined #openttd
14:40:22  *** DorpsGek_III has joined #openttd
14:42:31  <planetmaker> the protocol handling sounds like a very nice idea :)
14:42:43  *** Hirundo has joined #openttd
14:45:13  *** SmatZ has joined #openttd
14:45:30  <SpComb> as long as you're careful with untrusted / potentially malicious URLs
14:45:53  <SpComb> like, a URL handler that leads to local code execution is a bad idea
14:46:13  *** XeryusTC has joined #openttd
14:46:36  *** ericnoan has joined #openttd
14:47:13  *** avdg has joined #openttd
14:47:31  *** Flygon has quit IRC
14:48:23  <SpComb> heh yeah, there was a format string vuln on unknown query params
14:49:02  <SpComb> usually you use those to leak stuff, but some printf implementations also allow you to write stuff
14:50:20  <DorpsGek_III> [OpenTTD/OpenTTD] SpComb commented on pull request #7981: Close #7735: Implement protocol handling https://git.io/JvnmV
15:01:05  <spnda> When are the there going to be any precompiled binaries on bundles.openttdcoop.org for NML? They haven't been there since the NRT update, just wondering
15:01:24  <nielsm> when someone gets bundle making for windows working again, I think
15:01:53  <nielsm> also they'd be released on openttd website going forward afaiu
15:02:51  <nielsm> time to park a laptop in front of my desktop keyboard again, to work on that fluidsynth thing...
15:03:37  <andythenorth> spnda: not a direct answer but https://github.com/OpenTTD/nml/issues/42
15:09:25  <planetmaker> glx implemented some github action for building it... dunno which OS. But where do they end up?
15:10:11  <planetmaker> or does my memory mix up something?
15:10:33  <andythenorth> glx tested the build on GH
15:10:43  <spnda> andythenorth: Well, kinda want to build it myself then
15:10:43  <andythenorth> I'm not sure if that generates artefacts we can distribute yet
15:11:02  <spnda> Just I have no idea about python, especially pip
15:11:04  <planetmaker> spnda, not difficult. It's python after all... so in principle it does not even need building
15:11:20  <planetmaker> spnda, did you look at my latest posting in the NML thread at tt-f?
15:11:27  <planetmaker> did you try that approach?
15:11:46  <andythenorth> we probably should do this also https://github.com/OpenTTD/nml/issues/42
15:11:51  <planetmaker> the czech guy has been asking me the same... trying to teach him how to get python running
15:12:10  <planetmaker> same issue @ andythenorth ?
15:12:19  <andythenorth> oops paste fail sorry
15:12:24  <andythenorth> https://github.com/OpenTTD/nml/issues/43
15:12:36  <planetmaker> yeah
15:13:38  <spnda> well, pip doesn't really like my python installation for some reason. Also it's trying to use Python3 instead of Python2...
15:13:53  <planetmaker> so it should!
15:14:04  <planetmaker> python2 won't get you anything with nml
15:14:30  <planetmaker> you need python 3.5+
15:14:44  <planetmaker> and ply and pillow modules installed
15:14:54  <spnda> ok whatever, thought it was one of those stupid python2 only softwares
15:14:55  <andythenorth> 3.8 is substantially faster in my experience, although pypy is fastest
15:14:55  <spnda> I have those
15:15:09  <andythenorth> (3.8 faster than 3.5-3.7)
15:16:35  <spnda> I've got 3.7 I'm fine with that
15:19:44  <spnda> god bless https://github.com/pypa/pip/issues/5223
15:20:27  <spnda> makes me use a very old version of pip, but I can install pyinstaller so something good atleast
15:54:57  *** el3ktr4 has quit IRC
15:56:12  *** Etua has joined #openttd
15:58:17  <nielsm> wtf, I don't understand why my linux build fails to load graphics all of a sudden
15:58:50  <nielsm> grf debug says it does load the baseset without errors, but then it tried to use fallback sprites and complains about the terrain generator sprites and all kinds of stuff
16:00:48  *** Wormnest has joined #openttd
16:01:26  <nielsm> happens with both original graphics and opengfx
16:02:13  *** Tirili has quit IRC
16:04:11  <LordAro> spnda: i find `python -m pip` works more reliably than `pip` anyway
16:04:19  <LordAro> nielsm: suspicious
16:07:28  *** el3ktr4 has joined #openttd
16:10:13  <nielsm> uh yeah something weird is going on here
16:10:21  <nielsm> # time (make clean && make -j4)
16:10:34  <nielsm> real: 0m7.831s
16:11:56  <nielsm> looks like I have ccache installed and don't remember installing it, and it's probably making mistakes
16:28:40  <nielsm> okay this might be pretty serious
16:28:46  <nielsm> the error changes between runs of the same binary
16:28:57  <nielsm> uninstalling ccache did not affect it
17:03:18  <LordAro> uh
17:04:02  <nielsm> I started a memtest half an hour ago, hasn't found anything yet tho
17:07:06  <andythenorth> oh dear I've angered AWS billing monitor
17:07:09  <andythenorth> might have to pay :P
17:11:59  <spnda> Where is station tile rendering being handled? (Not for GUI purposes, but a placed station)
17:12:19  <nielsm> station_cmd.cpp
17:41:11  <DorpsGek_III> [OpenTTD/OpenTTD] mackensen commented on issue #7644: Mysteriously poor performance on macOS https://git.io/fjii3
17:54:07  <nielsm> yeah memtest passed...
18:00:13  <nielsm> built again after reboot, still behaves strangely
18:00:41  <nielsm> now it occasionally loads the game then crashes during something else, and gives errors about other things
18:01:06  <nielsm> time to wipe the machine?
18:04:16  <nielsm> it's like file i/o randomly fails/gives garbage
18:04:53  <nielsm> regression tests pass
18:04:58  <DorpsGek_III> [OpenTTD/OpenTTD] SoothedTau commented on issue #7644: Mysteriously poor performance on macOS https://git.io/fjii3
18:07:23  *** Wolf01 has joined #openttd
18:07:35  *** Samu has joined #openttd
18:09:34  <nielsm> okay it seems to have to do with my code so ignore everything I said
18:13:14  *** andythenorth has left #openttd
18:13:16  <LordAro> ha
18:13:19  *** andythenorth has joined #openttd
18:24:05  *** Progman has joined #openttd
18:28:54  <andythenorth> can you tell these are 2 different trains? https://dev.openttdcoop.org/attachments/download/9626/lemon-pegasus.png`
18:33:19  <andythenorth> or do they look identical?
18:35:07  <spnda> Close to identical, would still say they're different though
18:37:17  *** glx has joined #openttd
18:37:17  *** ChanServ sets mode: +v glx
18:38:54  *** Wormnest has quit IRC
18:40:03  <andythenorth> is frigging hard drawing steam engines
18:40:11  <andythenorth> they all look identical 100% all of them
18:44:47  *** WormnestAndroid has quit IRC
18:44:52  *** WormnestAndroid has joined #openttd
18:45:19  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh opened pull request #7983: Fix #7884: [Fluidsynth] Use recommended method of setting sample rate https://git.io/Jvncz
18:45:32  *** frosch123 has joined #openttd
18:45:37  <nielsm> lol
18:45:50  <nielsm> wrong ticket number in commit name
18:46:28  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh updated pull request #7983: Fix #7884: [Fluidsynth] Use recommended method of setting sample rate https://git.io/Jvncz
18:47:59  <LordAro> very nice
18:50:05  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #7983: Fix #7885: [Fluidsynth] Use recommended method of setting sample rate https://git.io/JvncP
18:50:07  <nielsm> and to explain the crashes I was getting: I didn't read the console output well enough and didn't see the message about trying to lock the same mutex twice in the same thread
18:50:18  <LordAro> ha
18:50:20  <nielsm> that error caused an abort
18:50:34  <nielsm> which caused other threads to fail at random spots
18:50:55  <nielsm> causing spurious error messages
18:52:41  <nielsm> there's also a thing where the call to set synth gain returns failure often or maybe every time, causing console spam
18:52:51  <nielsm> I'm not sure if that's related to the fluidsynth version I'm linking against
18:53:05  <nielsm> I don't remember which version it is ;)
18:54:28  *** tokai|noir has joined #openttd
18:54:28  *** ChanServ sets mode: +v tokai|noir
18:55:11  <nielsm> hmm, on second thought, I'm not sure if this is the right way to do the render routine, if it should just do a regular blocking mutex lock
18:56:21  <nielsm> on one hand it's a soft realtime routine, on the other hand you risk music playback popping because you were setting volume or querying IsSongPlaying exactly the wrong time
18:57:04  <nielsm> maybe those should not lock the mutex?
19:01:17  *** tokai has quit IRC
19:20:24  <Wolf01> Hmmm star trek time
19:23:41  <andythenorth> Tanks!
19:59:39  *** spnda has quit IRC
20:00:51  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on pull request #7983: Fix #7885: [Fluidsynth] Use recommended method of setting sample rate https://git.io/JvnWw
20:01:14  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh merged pull request #7983: Fix #7885: [Fluidsynth] Use recommended method of setting sample rate https://git.io/Jvncz
20:01:16  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh closed issue #7885: Use of deprecated fluid_synth_set_sample_rate https://git.io/JeADP
20:31:59  *** Etua has quit IRC
20:32:02  *** Wolf01 is now known as Guest15821
20:32:04  *** Wolf01 has joined #openttd
20:36:31  *** Guest15821 has quit IRC
20:36:54  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh opened pull request #7984: Fix #7525: Move autorenew setting to Basic category https://git.io/JvnlT
21:00:48  *** Smedles has quit IRC
21:02:38  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #7984: Fix #7525: Move autorenew setting to Basic category https://git.io/JvnlR
21:05:37  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh merged pull request #7984: Fix #7525: Move autorenew setting to Basic category https://git.io/JvnlT
21:05:38  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh closed issue #7525: Autorenew vehicle option to Basic settings https://git.io/fjOmN
21:06:45  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh updated pull request #7729: Add #7525: Allow autoreplace with same model vehicle https://git.io/JeeIF
21:17:25  *** spnda has joined #openttd
21:22:57  *** Smedles has joined #openttd
21:24:11  *** Smedles has quit IRC
21:26:29  <nielsm> 1.10.0 RC1 on sunday?
21:26:33  *** Smedles has joined #openttd
21:30:26  <LordAro> :+1:
21:30:36  *** Xaroth has joined #openttd
21:36:51  <Wolf01> peter1138: humble choice
21:39:40  <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 commented on pull request #7729: Add: Allow autoreplace with same model vehicle https://git.io/Jvn8K
21:40:09  *** Smedles has quit IRC
21:40:24  *** Smedles has joined #openttd
21:42:40  <frosch123> LordAro: nielsm: you may want to branch a few days before RC1
21:42:54  <frosch123> branches involves updating various things
21:43:04  <frosch123> mostly in master
21:43:13  <frosch123> (after the branch)
21:44:05  <LordAro> branch saturday evening/sunday morning, release sunday evening? :p
21:45:23  <LordAro> bumping the "major" version is just like doing a release, but without the release, right?
21:46:01  <frosch123> https://wiki.openttd.org/To_do_for_releases#After_creating_a_branch_for_a_new_version <- see PR#7319
21:46:08  <LordAro> :D
21:47:13  <peter1138> Wolf01, can't choose until payment, so...
21:47:16  <glx> oh nice we'll finally be able to merge #7270
21:47:45  <LordAro> glx: :D
21:47:53  <LordAro> i should probably review that...
21:48:07  <glx> oh it "works"
21:48:25  <LordAro> exactly :p
21:50:41  <Wolf01> peter1138, payment should be today
21:54:19  *** peter1138 has quit IRC
21:57:14  *** peter1138 has joined #openttd
21:57:14  *** ChanServ sets mode: +o peter1138
21:58:30  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #7979: Fix #7592: Limit road vehicle caching near destination https://git.io/Jvn4f
21:59:20  <glx> hmm there's the remote kick to fix too
21:59:53  <nielsm> yeah any kick or ban that would affect the host should be rejected in some way
22:00:43  <LordAro> kicks that affect the host are already ignored, might as well make the behaviour the same for rcon
22:00:53  <LordAro> because for whatever reason, rcon != host
22:01:48  <glx> by id is checked, by ip is not
22:02:14  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh merged pull request #7979: Fix #7592: Limit road vehicle caching near destination https://git.io/JvZSH
22:02:15  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh closed issue #7592: Road vehicles don't balance between multiple loading bays https://git.io/fjlL0
22:03:29  <LordAro> and also consider/work out if a CVE is worth filing
22:04:46  <frosch123> no, it only affects the user triggering it, not others
22:05:11  <frosch123> right?
22:05:18  <LordAro> that's what i said, but TB & milek7 disagreed
22:05:24  <LordAro> given the crash is a use-after-free
22:05:36  <milek7> it requires rcon password anyway
22:05:59  <LordAro> which 99% of the time is the server owner, but i guess not necessarily always
22:06:29  <nielsm> is there any protection against bruteforcing rcon passwords?
22:06:41  <milek7> no
22:07:49  <_dp_> what's the status of #7912? would be nice to have in 1.10
22:07:53  <frosch123> oh, the server crashes... i thought the rcon client crashes
22:08:21  <frosch123> _dp_: it would be nice if someone finished nrt
22:09:48  <nielsm> I suppose it's good enough to merge as-is, question is mostly if it should have more features or not before leaving draft
22:10:27  <_dp_> nielsm, it's useful enough as it is imo
22:11:09  <_dp_> nielsm, there is also sharing thing I want to build on top of it but that probably not happening for 1.10
22:11:40  <nielsm> I'll just rebase and do a test build, then mark as ready
22:12:23  <nielsm> I guess the storybook buttons aren't happening for 1.10
22:12:35  <glx> hmm server is protected from kick by IP it seems
22:13:51  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh updated pull request #7912: Feature: Disallow industry production changes from GS https://git.io/Jej1Z
22:13:59  <milek7> the issue is in kicking the client issuing rcon command
22:14:24  <glx> I think I have a fix
22:15:02  <milek7> it frees NetworkGameSocketHandler and it crashes later in ReceivePackets()
22:15:42  <nielsm> _dp_, maybe a flag that allows decreasing but not closing?
22:15:50  <nielsm> or is that getting too specific?
22:15:54  <frosch123> gread, gh is broken, i can't comment on diffs
22:16:20  <_dp_> nielsm, idk, have no use for that
22:16:36  <_dp_> nielsm, all I want is to stop all production changes rly
22:16:37  <nielsm> yeah I can't imagine why that would be useful either
22:17:12  <_dp_> as I'm sick tired fixing my rebuild-after closing thing that constantly bugs out xD
22:17:15  <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 commented on pull request #7912: Feature: Disallow industry production changes from GS https://git.io/Jvn4u
22:19:43  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on pull request #7912: Feature: Disallow industry production changes from GS https://git.io/Jvn4w
22:21:06  <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 commented on pull request #7912: Feature: Disallow industry production changes from GS https://git.io/Jvn45
22:21:17  *** el3ktr4 has quit IRC
22:23:06  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on pull request #7912: Feature: Disallow industry production changes from GS https://git.io/Jvn4j
22:23:11  <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 commented on pull request #7912: Feature: Disallow industry production changes from GS https://git.io/JvnBe
22:31:16  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 opened pull request #7985: Fix #7976: Don't kick the client doing the rcon https://git.io/JvnBt
22:31:20  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh updated pull request #7912: Feature: Disallow industry production changes from GS https://git.io/Jej1Z
22:36:41  *** Samu has quit IRC
22:39:08  <_dp_> actually the way it is not it won't rly stop stuff from closing
22:39:14  <_dp_> not all stuff at least
22:40:06  <_dp_> mb add no close flag?
22:40:56  <nielsm> hmm yeah actually, I'm not sure this protects secondary industries from the closure if no deliveries within 5 years check
22:41:22  <_dp_> nielsm, I don't even think it protects primaries :p
22:41:30  <_dp_> if they're already on lowest production
22:42:05  <_dp_> new_prod == old_prod == 0
22:42:45  <_dp_> ah, INDCTL_NO_PRODUCTION_CHANGE protects from closing
22:43:43  <_dp_> it has newgrf issue though
22:43:59  <_dp_> so replacing it with no close flag seems like a good solution to me
22:45:34  <nielsm> should newgrf be able to query these flags? (not set them)
22:45:41  <nielsm> to at least know if it's under the effect
22:45:48  *** spnda has quit IRC
22:46:00  <nielsm> so nobody has to be surprised when the request to change production or close was ignored
22:46:36  *** sla_ro|master has quit IRC
22:46:59  <frosch123> all newgrf that are still in development (i.e. firs) don't use either of those results
22:47:36  <frosch123> hmm, or was "no closure" a setting in firs?
22:47:50  <nielsm> firs does have some settings for closure rules
22:48:05  *** gelignite has quit IRC
22:50:10  <andythenorth> it's a parameter for secondary industry
22:50:26  <andythenorth> other industries don't close
22:50:30  <nielsm> then how about changing the first flag to a full-on stasis flag, when set the industry never does anything
22:50:36  <_dp_> I can't even imagine why would grf want to know this stuff
22:50:45  <nielsm> no cargo acceptance, no production, no callbacks, no sounds or animations
22:50:54  <frosch123> _dp_: ever played with ecs?
22:51:35  <_dp_> but I mostly want it for nogrf servers so don't rly think much about grf interaction
22:51:44  <_dp_> frosch123, yeah
22:52:10  <frosch123> do you remember the drama about daylength and ecs?
22:52:41  <_dp_> I'm not paying any attention to daylength so no xD
22:53:29  <frosch123> ecs replicates the ottd mechanics internally and then submits differential updates to ottd via the callbacks. so any little behaviour change in ottd makes ecs essentially desync with ottd
22:53:44  <frosch123> so it broke badly when industries produced more than 8 or 9 times a month
22:54:01  <_dp_> lol
22:54:02  <frosch123> and ecs even cared whether there are 8 or 9 in which month
22:54:28  <_dp_> well, I don't think anyone is going to update ecs over this anyway xD
22:54:39  <frosch123> anyway, the "more modern" industry sets do not use the production change callbacks for changing production
22:54:53  <frosch123> they just use the monthly callback for cyclic updates
22:56:37  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh updated pull request #7912: Feature: Disallow industry production changes from GS https://git.io/Jej1Z
22:56:59  <andythenorth> bed
22:57:01  *** andythenorth has left #openttd
22:58:57  *** adikt has quit IRC
23:00:41  <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 commented on pull request #7912: Feature: Disallow industry production changes from GS https://git.io/JvnBd
23:04:05  <_dp_> it there a good way to expand the entire hidden section in diff on github?
23:04:14  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on pull request #7912: Feature: Disallow industry production changes from GS https://git.io/JvnBh
23:04:20  <_dp_> instead of miliking the damn arrows
23:05:49  <frosch123> at least there are two arrows now, i think there was a time where you could only expand in one direction
23:06:21  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh updated pull request #7912: Feature: Disallow industry production changes from GS https://git.io/Jej1Z
23:06:38  <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 commented on pull request #7912: Feature: Disallow industry production changes from GS https://git.io/JvnRv
23:07:37  <frosch123> nielsm: 80+x variables map to the original ttd data
23:07:43  <_dp_> yeah, but it would be much better if it didn't jump randomly after clicking them
23:07:56  <nielsm> frosch123: where is that documented? :)
23:09:03  <frosch123> no idea, i gave up after nrt
23:09:35  <frosch123> .unused1:	resb 1	// 2dh:unused by TTD <- funnily 0xAD is free :p
23:10:16  <_dp_> I give up, you're changing it faster than I can expand the diff xD
23:10:59  <michi_cc> nielsm: 80+x are "documented" at http://marcin.ttdpatch.net/sv1codec/TTD-locations.html
23:11:07  <nielsm> is the "variable occupies slots corresponding to its size in bytes" thing also required for the 40+x ones?
23:11:12  <nielsm> or just a compatiblity-ish thing?
23:11:47  <nielsm> i.e. 0x46 is type Date i.e. int32, should the next then be 4A or is 47 fine?
23:12:13  <frosch123> 47
23:12:34  <frosch123> all non-8x vars are 32bit
23:12:57  <frosch123> they are all procedure calls
23:13:07  <frosch123> or switch-entries or whatever
23:13:11  <frosch123> no pointers involved
23:14:01  <michi_cc> Vars 0-7F are named variables, 80+x is just a fancy name for "read memory".
23:15:07  <nielsm> and is the 60+x are the only ones to take a parameter/"array index" just a convention or is it enforced anywhere?
23:15:13  <nielsm> I couldn't find anywhere that enforces it at least
23:16:02  <frosch123> it's enforced
23:16:09  <frosch123> they use two bytes in the .grf
23:16:21  <frosch123> 60+x variable is followed by another byte for the parameter
23:16:48  <nielsm> and it's 60-7F right?
23:16:50  <nielsm> the range
23:16:56  <frosch123> newgrf.cpp:5035
23:19:23  <frosch123> 0x00-0x3F are global variables (not item/feature specific), 40-5F are item-specific, 60-7F have parameters, 80-FF are memory dumps
23:20:14  <frosch123> though sometimes ttdp implementation details put variables in an unexpected category :)
23:21:22  *** Wolf01 has quit IRC
23:22:46  <frosch123> while ttdp may be dead, it still helps to give the variables some structure
23:25:09  <nielsm> grfv9 with 4cc variables please
23:25:26  <LordAro> andy? is that you?
23:26:03  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh updated pull request #7912: Feature: Disallow industry production changes from GS https://git.io/Jej1Z
23:26:05  <nielsm> lol
23:26:40  <frosch123> nielsm: http://devs.openttd.org/~frosch/texts/vartranstable.txt <- jgr implemented something similar for jgrpp's extra variables
23:27:48  *** Flygon has joined #openttd
23:28:28  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on pull request #7912: Feature: Disallow industry production changes from GS https://git.io/JvnRW
23:32:45  <nielsm> right, birds are making annoyed noises at my keyboarding and mousing, from behind their cover
23:32:48  <nielsm> I shoudl go to sleep
23:32:49  <nielsm> gn
23:37:27  <DorpsGek_III> [OpenTTD/OpenTTD] ldpl commented on pull request #7912: Feature: Disallow industry production changes from GS https://git.io/JvnRz
23:37:58  *** Flygon_ has joined #openttd
23:38:24  <_dp_> though now that I think of it those may not be flags at all
23:39:22  *** WormnestAndroid has quit IRC
23:39:37  <_dp_> so I don't even need to wait for this PR first xD
23:39:49  *** WormnestAndroid has joined #openttd
23:40:52  *** nielsm has quit IRC
23:42:00  <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 commented on pull request #7912: Feature: Disallow industry production changes from GS https://git.io/JvnRg
23:42:49  *** Progman has quit IRC
23:44:58  <_dp_> also I just nodiced... town exclusive rights a bound to company id so do they get transferred if new company reuses id?
23:45:14  <_dp_> can't find anything resetting it
23:45:19  *** Flygon has quit IRC
23:48:25  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #7985: Fix #7976: Don't kick the client doing the rcon https://git.io/JvnRo
23:48:49  <frosch123> _dp_: that means it also gets lost if you buy a company?
23:49:44  <frosch123> _dp_: economy.cpp:377
23:52:22  <_dp_> frosch123, yeah, if you buy it gets transferred
23:52:45  <frosch123> it also resets two lines down
23:54:06  <_dp_> oh, that thing is called with invalid owner on deletion
23:54:09  <_dp_> nvm then
23:54:11  <frosch123> bankcrupt and buyout is the same code
23:54:58  <_dp_> yeah, wasn't quite expecting that xD
23:59:38  <milek7> does it transfer vehicle exclusive rights too? ;p

Powered by YARRSTE version: svn-trunk