Config
Log for #openttd on 23rd February 2020:
Times are UTC Toggle Colours
00:03:26  *** nielsm has quit IRC
00:08:44  *** Wolf01 has quit IRC
00:22:31  *** WormnestAndroid has quit IRC
00:22:55  *** WormnestAndroid has joined #openttd
00:27:01  *** Progman has quit IRC
01:14:41  *** spnda has quit IRC
01:15:41  *** Flygon has joined #openttd
01:19:32  *** Smedles has quit IRC
01:20:53  *** Smedles has joined #openttd
01:23:26  *** arikover has quit IRC
01:29:48  *** Wormnest has joined #openttd
02:03:34  <DorpsGek_III> [OpenTTD/OpenGFX] Andrew350 commented on pull request #5: Change: Improved road tunnel construction gui icons https://git.io/Jv0g7
02:22:26  *** Wormnest has quit IRC
02:44:51  *** gelignite_ has joined #openttd
02:52:11  *** gelignite has quit IRC
03:18:01  *** debdog has joined #openttd
03:21:21  *** D-HUND has quit IRC
03:22:07  *** Wormnest has joined #openttd
03:24:46  *** snail_UES_ has quit IRC
03:57:17  *** glx has quit IRC
03:59:25  *** snail_UES_ has joined #openttd
04:12:20  *** Smedles has quit IRC
04:14:59  *** Smedles has joined #openttd
04:49:05  *** gelignite_ has quit IRC
05:54:26  *** Smedles has quit IRC
05:56:42  *** Smedles has joined #openttd
06:45:51  *** Wormnest has quit IRC
07:08:59  *** andythenorth has joined #openttd
07:29:11  <andythenorth> o/
07:35:39  *** Smedles has quit IRC
07:36:11  <TrueBrain> andythenorth : OpenGFX compiles. Your turn :p
07:36:22  <andythenorth> I just pulled
07:36:34  <andythenorth> been reading the github notifications
07:37:25  <andythenorth> hmm, I'd better fork it, my clone of official repo is no good eh
07:37:43  <TrueBrain> Smart :)
07:37:53  *** Smedles has joined #openttd
07:38:03  <andythenorth> would be smarter if I did it right first time, instead of wrong :P
07:41:30  * andythenorth looks for a makefile target that doesn't require gimp
07:43:31  <andythenorth> shall I just install GIMP and edit README to specify GIMP as required, not optional?
07:47:23  *** Progman has joined #openttd
07:51:45  <TrueBrain> It is optional
07:52:13  <TrueBrain> So that would be a weird thing to do :)
07:52:45  <TrueBrain> 'make nml' should work btw
07:58:11  <TrueBrain> ah, I see what they did ..
07:58:15  <TrueBrain> andythenorth: GIMP= make
07:58:15  <TrueBrain> works
07:58:43  <andythenorth> make nml works, I just missed it in the docs
07:58:56  <TrueBrain> the above also produces a tarball
07:59:08  <andythenorth> I should read the docs harder
07:59:18  <andythenorth> although make nml isn't mentioned so eh :)
07:59:19  <TrueBrain> no, this really is not you
07:59:32  <TrueBrain> building OpenGFX requires additional courses :P
08:01:30  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #23: Fix: [Makefile] autodetect if GIMP is installed https://git.io/Jv0Kq
08:01:34  <dwfreed> make GIMP= also works :)
08:01:37  <TrueBrain> there, that should help too :)
08:02:47  <dwfreed> the difference is that make GIMP= sets the make variable, GIMP= make sets an env variable; the latter of which will be inherited by programs run by make, the former won't
08:07:24  <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth commented on pull request #23: Fix: [Makefile] autodetect if GIMP is installed https://git.io/Jv0KY
08:09:30  <andythenorth> I appear to be able to build ogfx tar bundle
08:11:05  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #24: Fix: [Makefile] make sure that filenames in the tarball are as OpenTTD expects https://git.io/Jv0KO
08:14:47  <TrueBrain> and that even works :o
08:14:51  <TrueBrain> shocked
08:17:02  <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #24: Fix: [Makefile] make sure that filenames in the tarball are as OpenTTD expects https://git.io/Jv0KE
08:18:16  <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #23: Fix: [Makefile] autodetect if GIMP is installed https://git.io/Jv0Ku
08:19:20  <LordAro> reviewing PRs over breakfast is fun
08:19:28  <TrueBrain> especially these small ones :P
08:19:37  <TrueBrain> what is odd about the gimp detection thingy?
08:20:00  <LordAro> dunno, just haven't really seen that method of autodetection used before
08:20:08  <TrueBrain> ah .. it is all over this Makefile
08:20:16  <LordAro> fair enough
08:20:16  <TrueBrain> it is an old dirty cheap way of "autodetecting" :P
08:20:33  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #23: Fix: [Makefile] autodetect if GIMP is installed https://git.io/Jv0Kq
08:20:47  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain closed issue #22: OpenTTD (ingame) can only show readme.txt, which no longer exists https://git.io/Jv0ED
08:20:47  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #24: Fix: [Makefile] make sure that filenames in the tarball are as OpenTTD expects https://git.io/Jv0KO
08:23:05  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on issue #6: Make readme/changelog/license button clickable. https://git.io/Jv0Kr
08:23:06  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain closed issue #6: Make readme/changelog/license button clickable. https://git.io/Jv0Kr
08:24:17  * andythenorth wonders if the sprite warnings should be fixed
08:24:25  <andythenorth> I don't like that many errors just being normal
08:24:56  <TrueBrain> they really should
08:29:05  <LordAro> andythenorth: you should fix them!
08:29:21  <andythenorth> I'll look in a bit
08:33:46  <TrueBrain> from what glx said yesterday, mostly it is missing ANIM tags
08:37:03  <andythenorth> that makes sense
08:37:24  *** Progman has quit IRC
08:45:49  *** sla_ro|master has joined #openttd
08:51:05  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #25: Change: [Makefile] replace custom git-detection with 'findversion.sh' https://git.io/Jv0Kx
08:51:14  <TrueBrain> there, that should normalize OpenGFX in terms of OpenTTD versioning schema
08:51:24  <TrueBrain> makes releasing a lot easier :) (more of the same == easier)
08:51:48  * andythenorth should eat breakfast
08:51:56  <TrueBrain> I agree
08:56:14  *** nielsm has joined #openttd
08:58:57  <andythenorth> moin nielsm
09:00:44  <nielsm> morn
09:12:20  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #25: Change: [Makefile] replace custom git-detection with 'findversion.sh' https://git.io/Jv0Kx
09:13:52  *** Smedles_ has joined #openttd
09:14:23  *** Smedles has quit IRC
09:16:21  *** gelignite has joined #openttd
09:22:48  *** Smedles_ has quit IRC
09:24:03  *** Smedles has joined #openttd
09:28:42  *** snail_UES_ has quit IRC
09:29:25  *** tokai|noir has joined #openttd
09:29:25  *** ChanServ sets mode: +v tokai|noir
09:36:11  *** tokai has quit IRC
09:36:52  *** Samu has joined #openttd
09:41:19  <Samu> hi
09:41:35  *** Wolf01 has joined #openttd
09:41:46  <andythenorth> hi
09:43:09  <Wolf01> o/
09:48:44  *** andythenorth is now known as Guest17190
09:48:54  *** andythenorth has joined #openttd
09:53:26  *** Guest17190 has quit IRC
10:29:13  <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick updated pull request #7937: Build on competitor canal https://git.io/JvUIQ
10:32:00  <Samu> who can look at https://github.com/OpenTTD/OpenTTD/pull/7947
10:49:31  *** Speedy` has joined #openttd
11:04:11  <milek7> TrueBrain: http://webster.openttdcoop.org/index.php?channel=openttd&date=1582329600#1582414499
11:15:31  *** frosch123 has joined #openttd
11:21:20  <Samu> i cant run regression, failed to find a graphic set message popup :(
11:29:14  <Samu> i used to be able to run regression test, now it errors :(
11:31:45  <andythenorth> hmm
11:31:53  <DorpsGek_III> [OpenTTD/OpenGFX] frosch123 commented on pull request #25: Change: [Makefile] replace custom git-detection with 'findversion.sh' https://git.io/Jv0X6
11:32:11  <andythenorth> I'm not checking if every single one of these water sprites needs the animated flag set (or not)
11:32:22  * andythenorth blanket sets the flag for certain cases
11:32:46  <frosch123> if the name says "water" it's plausible :) if the name says "house", I would check
11:33:27  <frosch123> [ad] are you using ttdviewer?
11:33:54  <Samu> aha, regression fails to find a graphic set because the installer put it in the wrong folder
11:34:04  <andythenorth> I am not using ttdviewer
11:34:17  <andythenorth> but yes, I'm setting anim falg for all of waterfeatures.png etc
11:34:21  <andythenorth> and not other things
11:34:26  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #25: Change: [Makefile] replace custom git-detection with 'findversion.sh' https://git.io/Jv0XD
11:34:38  <andythenorth> if we eliminate the junk warnings, then we can attend to the actual warnings :P
11:39:24  <andythenorth> hmm
11:40:42  * andythenorth wonders if opengfx realsprites can't have the flags set
11:41:00  <TrueBrain> frosch123: suggestions to make it more clear are always welcome ofc :) The fact I have to explain tells me the code is not obvious, so any suggestions really are welcome :)
11:41:56  <TrueBrain> although it might be the diff that is confusing .. I change the use of Makefile.vcs .. possibly another name would make it more clear .. dunno
11:43:17  <andythenorth> nmlc ERROR: "./sprites/extra/extra-plus-rivers.pnml", line 158: Unrecognized identifier 'ANIM' encountered
11:43:25  <andythenorth> dunno what I'm missing :)
11:43:33  <TrueBrain> using the latest nmlc? :)
11:43:37  <TrueBrain> (as in, "master")
11:43:42  <andythenorth> I don't really write nml, I'm going by the docs
11:43:55  <andythenorth> yes I have absolute latest nml
11:44:10  <andythenorth> docs suggest this should be ok
11:44:11  <andythenorth> [ 338,  904,  19,   9,  14,  11, "sprites/png/terrain/waterfeatures.png", ANIM]
11:44:13  <frosch123> TrueBrain: is Makefile.vcs used at all?
11:44:14  <TrueBrain> just checking :) I also know nothing about how to write NML :)
11:44:22  <TrueBrain> frosch123: yes ... as dependency to know when to rebuild targets
11:44:26  <frosch123> i see that it is created, but i do not see where it is read
11:44:28  <TrueBrain> (as the comment mentions :P)
11:44:41  <frosch123> i see that .ottdrev is created, and used
11:44:45  <TrueBrain> "custom_tags.txt: Makefile.vcs"
11:44:46  <TrueBrain> for example
11:44:59  <TrueBrain> and
11:45:00  <TrueBrain> "%.obg: $(GFX_FILES) $(GRF_FILES) $(LNG_FILES) Makefile.vcs"
11:45:08  <TrueBrain> I see your grep-foo is failing on you :D <3
11:45:50  <frosch123> that's because i have not figured out how to view the whole file on gh, i only get a diff
11:46:08  <frosch123> i found the "..."
11:46:12  <TrueBrain> iles changed -> go to file -> click dots -> View file
11:46:34  <andythenorth> flags before filename maybe
11:46:37  * andythenorth tries
11:46:37  <TrueBrain> and really this is not you; this Makefile is just a bit oddly written. But I don't want to rebuild it completely :)
11:46:59  <TrueBrain> Makefile.vcs was always used to retrigger builds ... and help out for source-tarballs
11:47:11  * andythenorth is now an nml genius
11:47:18  <andythenorth> simply by reading docs, I was able to fix my error
11:47:27  <TrueBrain> .makefile_cache might be a better name?
11:47:34  <TrueBrain> andythenorth: gratz :)
11:48:08  <Samu> the installer installs the graphics set in the wrong folder
11:48:13  <frosch123> does the "Makefile.vcs not modified" work? I would expect make to rebuild everything everytime
11:48:33  <TrueBrain> read the Makefile.vcs: part careful:
11:48:34  <TrueBrain> 	$(_V) cmp -s $@.new $@ || cp $@.new $@
11:48:34  <TrueBrain> 	$(_V) -rm -f $@.new
11:48:36  <TrueBrain> took me a while :P
11:48:38  <frosch123> since everything depends via "Makjefile.vcs" on "FORCE"
11:48:56  <TrueBrain> so it really does work :)
11:49:09  <frosch123> make is magical sometimes
11:49:20  <TrueBrain> yes; and this type of make is even a special category of magic :)
11:49:35  <TrueBrain> so tempted to rewrite to CMake :P
11:49:37  <TrueBrain> but .. I am not
11:49:40  <frosch123> ok, next question: you remove .version from .gitignore, do you want to add .ottdrev?
11:49:51  <TrueBrain> .ottdrev is only created in a folder that is already ignored
11:49:55  <TrueBrain> so no :)
11:50:05  <milek7> so.. i should make that xcf2png PR?
11:50:09  <TrueBrain> but good question, as I wondered about that too :)
11:50:12  <TrueBrain> milek7: yes
11:50:53  <DorpsGek_III> [OpenTTD/OpenGFX] frosch123 approved pull request #25: Change: [Makefile] replace custom git-detection with 'findversion.sh' https://git.io/Jv0Xj
11:50:59  <frosch123> out of questions to ask
11:51:11  <TrueBrain> not sure that is a good thing or not, but tnx for looking into this :)
11:51:17  <TrueBrain> I did my best to test it every way I could
11:51:40  <frosch123> well, the makefile looked like it uses directories as dependencies
11:51:50  <frosch123> many coop makefiles use that, and it is completely broken :)
11:52:09  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #25: Change: [Makefile] replace custom git-detection with 'findversion.sh' https://git.io/Jv0Kx
11:52:10  <TrueBrain> it really is, yes
11:52:19  <TrueBrain> when CMake hits OpenTTD, we should revisit this
11:52:26  <TrueBrain> as it can share CMake files at that point, making this all a bit easier
11:53:26  <TrueBrain> but now first, lets make opengfx nightlies and releases :)
11:54:33  <TrueBrain> milek7: don't forget to change "xcf2png" into $(XCF2PNG) btw :)
11:56:27  <TrueBrain> milek7: with https://pastebin.com/raw/sE9J7UfK "ogfxe_extra.grf" still generates a different result btw
11:56:44  <milek7> hm
11:57:48  <TrueBrain> and I cannot start GIMP UI here, so I cannot test the thing you asked
11:59:21  <TrueBrain> if you want me to test anything, let me know :)
11:59:22  <Samu> it tries to load TRG1R.GRF, says it can't find it, then it crashes openttd on exit
11:59:38  <TrueBrain> (other than the UI thing .. :P)
11:59:41  <Samu> what the hell happened?
11:59:48  <Samu> i wasn't having problems building openttd
11:59:59  <Samu> suddenly, I am
12:01:50  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #5: Change: Improved road tunnel construction gui icons https://git.io/Jv013
12:04:56  <Samu> okay, i think i got it
12:05:11  <Samu> it's a problem related to where you install these files
12:05:39  <Samu> you are installing in C:\Program Files\OpenTTD\baseset
12:05:50  <Samu> but the config is somewhere else
12:06:04  <Samu> C:\Users\dj_sa\Documents\OpenTTD
12:06:51  <andythenorth> ok so opengfx compile doesn't support the nml realsprite flags
12:07:09  *** andythenorth has quit IRC
12:07:27  *** andythenorth has joined #openttd
12:07:27  <Samu> why is my username dj_sa?
12:07:30  <Samu> stupid windows
12:07:36  <TrueBrain> I have no idea what that means andythenorth  :)
12:07:41  <Samu> ruining my good name
12:07:54  <andythenorth> TrueBrain: this is why we have docs :)
12:08:10  <andythenorth> TL;DR there are warnings in nml about bad things
12:08:18  <andythenorth> but sometimes the bad things are desirable
12:08:24  <andythenorth> so we have flags to suppress the warnings
12:08:38  <andythenorth> but opengfx compile is incompatible with the flags
12:08:52  <TrueBrain> how are they incompatible? :)
12:08:54  <andythenorth> for extra fun, this isn't discoverable if only using make
12:08:55  <frosch123> so you have an ancient nml in your path? how do you compile firs?
12:09:22  <andythenorth> but the problem occurs when make is run after make clean
12:09:25  *** HerzogDeXtEr has quit IRC
12:09:40  <andythenorth> there's a parser somewhere to generate png deps for make
12:09:46  *** HerzogDeXtEr has joined #openttd
12:09:56  <andythenorth> and it's position based, adding the flags makes it choke
12:10:11  * andythenorth hasn't looked more, running out of laptop battery :(
12:10:15  <frosch123> ah, more broken makefiles :)
12:10:28  <andythenorth> I'd complain, but have you seen mine? :P
12:10:44  <TrueBrain> so where should this ANIM be added normally?
12:11:03  <andythenorth> flags https://newgrf-specs.tt-wiki.net/wiki/NML:Realsprites
12:11:11  <TrueBrain> I am not asking about the specs
12:11:16  <TrueBrain> where were you trying to add ANIM that fails :)
12:11:24  <TrueBrain> I want to help you; not learn NML :)
12:11:37  <andythenorth> oh you want an example that fails?
12:11:47  <TrueBrain> that would help, yes
12:12:00  <andythenorth> I deleted all my changes trying to diagnose the issue
12:12:06  <andythenorth> I shall make redo and make a diff
12:13:27  <andythenorth> https://gist.github.com/andythenorth/4e15b007084838dd378ffee145a17b0d
12:13:31  <andythenorth> TrueBrain: ^
12:13:55  <andythenorth> make clean, then make
12:14:02  <andythenorth> will fail with
12:14:02  <andythenorth> make: *** No rule to make target `ANIM,', needed by `ogfxe_extra.grf'.  Stop.
12:14:46  <andythenorth> oops, I am supposed to be doing something else, BRB
12:15:01  <milek7> TrueBrain: no, result is the same
12:15:27  <milek7> except that building on clean repo gives '1 * 6454	 14 "CINFOTNAME\" OpenGFX 0.5.5-17-g2c58f17" 00'
12:15:35  <milek7> and with patch '1 * 6460	 14 "CINFOTNAME\" OpenGFX 0.5.5-17-g2c58f17-dirty" 00'
12:15:42  <TrueBrain> milek7: not sure where you are referencing too, sorry :(
12:15:48  <frosch123> haha, the rule for Makefile.gfx is funny
12:16:05  <frosch123> it scans for pcx or png, drops the fileextension, and readds png
12:16:09  <milek7> that new ogfxe_extra.grf is different
12:16:26  <TrueBrain> milek7: ah .. so it is expected to be different
12:16:31  <TrueBrain> fair enough
12:16:35  <TrueBrain> any way for me to validate that easily?
12:17:10  <TrueBrain> andythenorth: your patch works for me :o
12:17:14  <milek7> though this is weird it only comes up in extra grf
12:17:40  <TrueBrain> milek7: no, that is correct .. I remember only one NML file needing the NEWGRF_VERSION
12:17:45  <TrueBrain> so that is expected, now I come to think of it
12:18:51  <andythenorth> hmm
12:18:56  <andythenorth> mac specific make failures?
12:19:06  <TrueBrain> I also don't see how that error could happen
12:19:12  <TrueBrain> you sure you don't have any other pending changes?
12:19:30  <andythenorth> the diff is all of 'git diff' locallly
12:19:39  <TrueBrain> and git status doesn't show untracked files?
12:19:48  <andythenorth> nope
12:20:27  <andythenorth> it didn't manifest until I ran 'make clean'
12:20:59  <TrueBrain> can you upgrade to latest master, and try again?
12:21:18  <TrueBrain> owh, and remove your Makefile.gfx
12:22:00  <TrueBrain> given you run with GIMP=, there is a bug in Makefile that can cause shit like this :)
12:22:10  * andythenorth crosses fingers
12:22:18  <andythenorth> oof no same shit
12:22:39  <TrueBrain> make clean && rm -f Makefile.gfx && GIMP= make
12:23:13  * andythenorth crosses toes
12:23:22  <andythenorth> meh
12:23:29  <andythenorth> same shit
12:24:00  <andythenorth> it was pm and ammler who taught me that 'no errors may happen in compile'
12:24:12  <andythenorth> but this is probably why they never fixed the warnings
12:24:19  <TrueBrain> does Makefile.gfx have any content?
12:26:44  <TrueBrain> milek7: confirmed, with NEWGRF_VERSION set to 0, both GIMP and xcf2png result in the same grf with your patch
12:26:47  <TrueBrain> so PR it, and lets go :)
12:28:03  <TrueBrain> andythenorth: with your patch, I cannot find a path that results in that error. Not sure if anyone else can reproduce it?
12:28:13  <TrueBrain> the only reason I can think of, is if Makefile.gfx is not empty
12:28:45  <TrueBrain> and even than, you need to have more changes for this to happen .. not sure ..
12:29:34  <andythenorth> TrueBrain: re. Makefile.gfx, using the command you pasted above, it isn't generated locally
12:29:54  <TrueBrain> hmm, nothing is cleaning up .dep files
12:29:56  <TrueBrain> so that might be a reason too
12:30:06  <TrueBrain> rm -f *.dep
12:30:08  <TrueBrain> and try again
12:30:29  <TrueBrain> if at any point nml produced invalid dep files, it will remain broken, basically
12:30:50  <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick opened issue #8018: Visual Studio/OpenTTD Baseset installation folder vs Regression build https://git.io/Jv017
12:30:54  <andythenorth> TrueBrain: sorted
12:30:59  <TrueBrain> that fixed it?
12:31:02  <Samu> i think this was not worth reporting, but...
12:31:06  <andythenorth> removing .deps fixed it
12:31:17  <TrueBrain> k; so it was because of your earlier attempts :)
12:31:24  <TrueBrain> lets see why 'clean' doesnt remove those files ..
12:31:32  * andythenorth GTG
12:31:34  <andythenorth> but thx
12:31:36  <TrueBrain> np
12:31:44  <andythenorth> I'll come back later and fix more warnings
12:31:47  *** andythenorth has quit IRC
12:35:47  <DorpsGek_III> [OpenTTD/OpenGFX] Milek7 opened pull request #26: Change: Use xcf2png instead of GIMP https://git.io/Jv0MU
12:37:37  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #27: Fix: [Makefile] make sure 'make clean' cleans all generated files https://git.io/Jv0Mk
12:37:45  <TrueBrain> and that should fix andy's issue for good
12:39:25  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #26: Change: Use xcf2png instead of GIMP https://git.io/Jv0MY
12:39:42  <TrueBrain> I guess we really should fix up that Makefile.gfx :P
12:40:18  <TrueBrain> it is so silly and unneededly slow
12:40:29  <TrueBrain> but that is something for another PR :)
12:40:44  <TrueBrain> do I dare to merge that PR ... do I know enough about this stuff ... it "looks okay" :P
12:42:43  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #28: Remove: [Makefile] documentation is now supplied, no longer generated https://git.io/Jv0Mn
12:44:09  <DorpsGek_III> [OpenTTD/OpenGFX] Milek7 updated pull request #26: Change: Use xcf2png instead of GIMP https://git.io/Jv0MU
12:44:44  <DorpsGek_III> [OpenTTD/OpenGFX] Milek7 updated pull request #26: Change: Use xcf2png instead of GIMP https://git.io/Jv0MU
12:44:58  <TrueBrain> was about to ask about the README :)
12:45:06  <TrueBrain> nice :)
12:45:33  <milek7> uh.. does xcf2png exists on windows?
12:45:45  <TrueBrain> oh-oh .....
12:46:54  <TrueBrain> fucking windows :P
12:47:08  <TrueBrain> mingw?
12:47:31  <TrueBrain> its in cygwin
12:48:33  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain commented on pull request #26: Change: Use xcf2png instead of GIMP https://git.io/Jv0M0
12:48:34  <milek7> xcftools sources contains "# FIXME: the MSVC++ port hasn't been tested in a loooong time"
12:48:51  <TrueBrain> yeah, but cygwin has it in its package list, so that should be fine I guess
12:50:19  <TrueBrain> you should ask glx when he comes online to check it out :)
12:51:52  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #28: Remove: [Makefile] documentation is now supplied, no longer generated https://git.io/Jv0Mn
12:53:57  <milek7> also when saving these .xcf in gimp 2.10 it is necessary to uncheck "Save this XCF file with better compresson"
12:54:03  <milek7> it probably should go into readme too
12:54:13  <TrueBrain> please do :)
12:56:08  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #28: Remove: [Makefile] documentation is now supplied, no longer generated https://git.io/Jv0Mn
13:00:59  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #29: Fix: [Makefile] tell the user he needs to install grfcodec if grfid is not found https://git.io/Jv0Mx
13:01:09  <TrueBrain> okay, these PRs should fix the andy-factor :)
13:01:46  <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #29: Fix: [Makefile] tell the user he needs to install grfcodec if grfid is not found https://git.io/Jv0Mp
13:02:02  <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #28: Remove: [Makefile] documentation is now supplied, no longer generated https://git.io/Jv0Mh
13:02:05  <TrueBrain> LordAro: stop tempting me to rewrite this shit in CMake :P
13:02:09  <LordAro> ^^
13:02:51  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #28: Remove: [Makefile] documentation is now supplied, no longer generated https://git.io/Jv0Mn
13:03:10  <DorpsGek_III> [OpenTTD/OpenGFX] LordAro approved pull request #27: Fix: [Makefile] make sure 'make clean' cleans all generated files https://git.io/Jv0De
13:03:23  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #27: Fix: [Makefile] make sure 'make clean' cleans all generated files https://git.io/Jv0Mk
13:07:26  <TrueBrain> milek7: https://github.com/j-jorge/xcftools/ seems to be the new source for xcftools
13:07:29  <TrueBrain> at least Debian switched to there
13:08:25  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain merged pull request #29: Fix: [Makefile] tell the user he needs to install grfcodec if grfid is not found https://git.io/Jv0Mx
13:21:02  <milek7> xcftools is neither in homebrew or macports
13:32:57  *** APTX_ has quit IRC
13:41:39  * _dp_ played with firs and cargodist yesterday, remembered why I don't like either of them
13:42:21  *** blathijs has joined #openttd
13:42:51  <TrueBrain> milek7: that might be a bit of a problem :(
13:43:12  <blathijs> TrueBrain: LordAro: milek7: Are you guys coding as crazy on OpenGFX today, or are all those PRs migrated from somewhere?
13:43:42  <TrueBrain> blathijs: you sound surprised :P
13:43:51  <TrueBrain> but yeah, I wrote all of those in the last 24 hours :)
13:44:01  <TrueBrain> there was a bit of dust on top of it :P
13:44:17  <TrueBrain> now the real work can start ...
13:44:19  <blathijs> Nice :-)
13:44:49  <TrueBrain> copyright still reads 2016 .. think that says it all :D
13:45:11  <blathijs> It just seems like a lot more than I can usually get done in 24h, so kudos :-p
13:45:26  <TrueBrain> it really is not that much tbh .. just Makefile shit
13:46:17  <TrueBrain> but tnx :)
13:46:26  <TrueBrain> hopefully I didn't break any of your debian magic :D
13:51:57  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on issue #8018: Visual Studio/OpenTTD Baseset installation folder vs Regression build https://git.io/Jv017
13:54:04  *** APTX has joined #openttd
13:56:14  *** sla_ro|master has quit IRC
13:57:16  *** glx has joined #openttd
13:57:16  *** ChanServ sets mode: +v glx
13:58:33  *** sla_ro|master has joined #openttd
14:17:39  <Samu> _dp_ https://www.tt-forums.net/viewtopic.php?f=33&t=73469&start=2620 have you figured the problem?
14:18:13  <_dp_> Samu, nope
14:18:37  <_dp_> I can imagine few ways it could go wrong in jgr's patchpack but not in vanilla
14:18:37  <Samu> if only that savegame was useful
14:18:46  <Samu> oh
14:20:14  <_dp_> either amount > 256 or owner > OWNER_NONE can break it
14:20:31  <_dp_> but doesn't seem to be the case in vanilla
14:21:04  <_dp_> though adding those  as asserts is probably not a bad idea
14:23:08  <Samu> more than 256, hmm some big industry?
14:23:34  <_dp_> afaict it's capped at 255 everywhere
14:24:01  <Samu> gonna test
14:24:09  <Samu> with the cheat menu
14:25:04  <Samu> what about those industries that transform cargo
14:25:29  <Samu> if i deliver 9000 at once how it's transforming it? 256 capped? I doubt it
14:26:25  <_dp_> it's probably capped even more on unload
14:27:27  <_dp_> typical cargo packet is like 5 units only
14:28:32  <Samu> hmmm let me set up a scenario
14:47:19  *** Flygon has quit IRC
14:54:23  <Samu> im so bad at setting up train networks :p
15:12:49  <Samu> trying my best to make that assert trigger, seems like it won't
15:14:15  <Samu> jgr says he was able to look at the savegame
15:14:19  <Samu> hmm :(
15:15:53  <Samu> but i couldn't
15:24:10  <Samu> okay, scenario is set up
15:24:30  <Samu> i could get some forest to produce 255 units
15:24:48  <Samu> i wanted to get the lumber mill instead
15:28:06  <Samu> ok 430
15:28:17  <Samu> but it splits to a min of 255
15:28:22  <Samu> so, you're right
15:36:44  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain opened pull request #30: Add: [Actions] publish on new tag (release) and every night (nightly) https://git.io/Jv09m
15:37:06  <TrueBrain> I think this is it ^^ .. but it currently is being tested on a schedule of every 5 minutes ... this is going to take a while to verify :D
15:39:49  <TrueBrain> cache is not supported with schedule .. wtf .. lol
15:41:16  *** APTX_ has joined #openttd
15:43:40  <glx> as xcf2png doesn't seem to be available on windows I tried to use imagemagick, but it seems imagemagick doesn't support indexed gimp files
15:45:16  *** APTX has quit IRC
15:47:24  <TrueBrain> glx: seems cygwin does have a version available; but I believe milek7 said OSX also doesn't have it
15:47:28  <TrueBrain> so it might not be a good fit after all :(
15:48:04  <TrueBrain> right, so caching only works for 'push' and 'pull_request'... so how do I know if we already build an OpenGFX version .. hmmmmmmmm
15:49:47  <Samu> what's the maximum value of uint
15:50:30  <glx> 2^16-1
15:50:31  *** gelignite_ has joined #openttd
15:51:05  <Samu> @calc 255*256*255*255
15:51:05  <DorpsGek> Samu: 4244832000
15:51:15  <glx> silly me uint is 32 bits
15:51:24  <glx> so 2^32-1 :)
15:51:27  <Samu> @calc 2 ** 32 -1
15:51:27  <DorpsGek> Samu: Error: Something in there wasn't a valid number.
15:51:33  <Samu> @calc 2 ** 32 - 1
15:51:33  <DorpsGek> Samu: 4294967295
15:52:10  <Samu> so it fits
15:52:16  <Samu> barelly, but still fits
15:52:54  <TrueBrain> facepalm
15:53:17  <LordAro> funnily enough, just less than 2**16 * 4 is less than 2**32
15:53:19  <TrueBrain> lets pretend we did not see someone calculate that 255256255*255 fits in a 32bit unsigned integer ..
15:53:40  <TrueBrain> without the typos, ofc
15:54:11  *** gelignite has quit IRC
15:54:26  <Samu> I'm checking for overflow
15:54:32  <Samu> it doesn't overflow
15:54:52  <Samu> @calc 256*256*255*255
15:54:52  <DorpsGek> Samu: 4261478400
15:55:01  <Samu> @calc 257*256*255*255
15:55:01  <DorpsGek> Samu: 4278124800
15:55:15  <DorpsGek_III> [OpenTTD/OpenGFX] TrueBrain updated pull request #30: Add: [Actions] publish on new tag (release) and every night (nightly) https://git.io/Jv09m
15:55:33  <TrueBrain> you are seriously surprised that 255**3 * 256 doesn't overflow 256 ** 4 ? Really? :)
15:55:52  <dwfreed> Samu: 255 is an 8 bit unsigned integer; 4 8 bit unsigned integers multiplied together will always fit within a 32 bit unsigned integer
15:55:52  <LordAro> TrueBrain: ah, but this is 255*2 * 256 * 257
15:55:55  <LordAro> totally different
15:56:01  <dwfreed> not really
15:56:02  <LordAro> ** *
15:56:55  <Samu> @calc 258*256*255*255
15:56:55  <DorpsGek> Samu: 4294771200
15:57:04  <Eddi|zuHause> (256+1)*(256-1) = (256)^2 - 1 (binomial rule)
15:57:07  <TrueBrain> please take this in a private message with DorpsGek
15:57:11  <TrueBrain> I have no interest in you cracking math
15:58:01  <Samu> 258 is the maximum amount before it overflows
15:58:05  <Samu> _dp_
15:58:19  <Samu> if you want to add an assert there
15:59:15  <TrueBrain> okay, this GitHub Actions PR is tested as good as I could .... now it is up to real-world testing :P
15:59:20  <TrueBrain> testing Actions in forks remains difficult
15:59:39  <TrueBrain> upload to S3 works, files are what I expect, all triggers work
15:59:57  <TrueBrain> fingers crossed
16:02:22  <Samu> i could get an industry produce 430 cargo, but it then goes over a min(430, 255), so the amount is 255
16:02:43  <Samu> maybe the problem can come from houses producing passengers?
16:06:26  <TrueBrain> if this PR is merged, OpenGFX is very similar to website in the way GitHub works. And very similar to OpenTTD binaries in the way it rebuilds the website etc. The only thing that is not fixed, is the NSIS installer. That still needs manual love and care
16:06:42  <TrueBrain> hopefully I didn't miss anything :D
16:06:51  *** snail_UES_ has joined #openttd
16:07:03  *** APTX_ has quit IRC
16:07:41  <Samu> town_houses have this: uint amt = GB(callback, 0, 8);
16:07:50  <Samu> that's a max of 255 too
16:08:03  <glx> yes it's 8 bits :)
16:09:20  <TrueBrain> owh, hmm ... a new tagged OpenGFX won't also be uploaded to BaNaNaS automagically
16:09:38  <TrueBrain> things for later additions, I am sure :P
16:09:52  <TrueBrain> ugh .. I really have to move BaNaNaS before 1st of April ... hmmmmmmmm
16:09:53  *** APTX has joined #openttd
16:10:05  <glx> yeah shoul be doable to use musa in this case
16:10:30  <Samu> headquarters code: uint amt = GB(r, 0, 8) / 8 / 4 + 1;
16:10:40  <TrueBrain> I should have used deployments, I now realise .. would make things a bit easier ..
16:10:49  <glx> Samu: clearly < 255
16:11:43  <TrueBrain> owh well, that too, for later updates :)
16:12:11  <TrueBrain> can't fix it all at once
16:13:52  <Samu> that's 8
16:14:03  <DorpsGek_III> [OpenTTD/OpenGFX] glx22 commented on pull request #26: Change: Use xcf2png instead of GIMP https://git.io/Jv09P
16:14:05  <Samu> well, then, it's jgr's fault :p
16:18:12  *** andythenorth has joined #openttd
16:20:09  <andythenorth> o/
16:22:43  <Samu> who can decipher this code, line 581 town_cmd.cpp, can u check whether amt is always 258 or less?
16:23:16  <Samu> before MoveGoodsToStation is called
16:23:27  *** Wormnest has joined #openttd
16:23:48  *** Wormnest has quit IRC
16:26:10  *** Wormnest has joined #openttd
16:29:38  <milek7> TrueBrain: it seems it was rejected in homebrew because it was unmaintained
16:29:40  <milek7> https://github.com/Homebrew/homebrew-core/pull/1216
16:29:52  <milek7> maybe we could retry with j-jorge fork
16:47:04  <andythenorth> hmm opengfx has me puzzled
16:47:18  <andythenorth> nvm
16:47:57  *** snail_UES_ has quit IRC
16:57:57  <frosch123> hmm, this graphql query is an escaping hell
16:58:04  <frosch123> i should just ban users with " in their name
16:59:22  <frosch123> hmm, graphql seems to have its own variable stuff
17:05:25  <Samu> okay, 32 is max value
17:05:48  <Samu> with linear passenger
17:06:12  <Eddi|zuHause> frosch123: just base64-encode all names?
17:08:49  <Samu> it's also 32 with quadratic
17:09:46  <Samu> only newgrf houses can set this value all the way to 255
17:11:17  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 updated pull request #7270: Introduce CMake (and removing all other project-related code) https://git.io/fhbqc
17:14:08  <_dp_> Samu, do you realize you just wasted two screens of chat just to repeat what I said in a single sentence? ;)
17:14:11  <_dp_> <_dp_> afaict it's capped at 255 everywhere
17:14:38  <Samu> oh, I realise now
17:27:03  <andythenorth> how do I mark a PR as draft?
17:27:24  <nielsm> click the arrow next to the create button
17:27:42  <andythenorth> thx
17:29:46  <DorpsGek_III> [OpenTTD/OpenGFX] andythenorth opened pull request #31: Fix: realsprites animated flag for various features, suppressing spurious warnings https://git.io/Jv0Qm
17:30:52  <Samu> i just got a case where amount == moving, perfect round numbers
17:31:54  <Samu> @calc 1564*91*91/91/161
17:31:54  <DorpsGek> Samu: 884
17:32:25  <Samu> @calc 1564*91*70/91/161
17:32:25  <DorpsGek> Samu: 680
17:33:32  <Samu> @calc 884+680
17:33:32  <DorpsGek> Samu: 1564
17:35:27  <Samu> I wonder if a*b*c/d/e is different than a*b*c/(d*e)
17:35:28  <TrueBrain> Last time Samu, take this in a PM with DorpsGek
17:35:31  <Samu> in integer
17:37:01  *** Wolf01 has quit IRC