Config
Log for #openttd on 31st March 2020:
Times are UTC Toggle Colours
00:11:24  *** gelignite has quit IRC
00:30:06  <Eddi|zuHause> i wanted to complain in the german forum about summer time setting not working, and found a thread from 8 years ago, complaining about the same thing – by me
00:33:27  <FLHerne> 'summer time setting' ?
00:35:17  <Eddi|zuHause> you know, the opposite of winter time
00:37:04  <FLHerne> Ok, but since when has OTTD cared about that at all? (or why should it?)
00:37:29  <Eddi|zuHause> openttd doesn't, but the forum does (post times and stuff)
00:46:57  <dwfreed> Eddi|zuHause: the forum probably hasn't been updated in 8+ years
00:47:53  <Eddi|zuHause> dwfreed: i think the opposite is true, some update reset the changes that were made after the last complaint
02:08:43  *** tuvok has joined #openttd
02:14:59  *** glx has quit IRC
02:15:59  *** tuvok-_ has quit IRC
02:57:05  *** D-HUND has joined #openttd
03:00:31  *** debdog has quit IRC
04:59:42  *** tokai has joined #openttd
04:59:42  *** ChanServ sets mode: +v tokai
05:06:43  *** tokai|noir has quit IRC
05:30:29  *** D-HUND has quit IRC
05:30:29  *** KenjiE20 has quit IRC
05:30:29  *** Sacro has quit IRC
05:30:29  *** ZirconiumX has quit IRC
05:30:29  *** moll has quit IRC
05:30:29  *** lastmikoi has quit IRC
05:30:30  *** gooodger has quit IRC
05:30:30  *** Artea has quit IRC
05:30:30  *** natalie[m] has quit IRC
05:30:30  *** joey[m] has quit IRC
05:30:30  *** osvaldo[m] has quit IRC
05:30:30  *** elliot[m] has quit IRC
05:30:30  *** natmac[m] has quit IRC
05:30:30  *** grag[m] has quit IRC
05:30:30  *** yur3shmukcik[m] has quit IRC
05:30:30  *** freu[m] has quit IRC
05:30:30  *** pina[m] has quit IRC
05:30:30  *** NGC3982 has quit IRC
05:30:30  *** skrzyp has quit IRC
05:30:30  *** Decapita1 has quit IRC
05:30:30  *** Alkel_U3 has quit IRC
05:30:30  *** milek7 has quit IRC
05:30:30  *** tyteen4a03 has quit IRC
05:30:30  *** michi_cc has quit IRC
05:30:30  *** guru3 has quit IRC
05:30:30  *** luaduck has quit IRC
05:30:30  *** orudge has quit IRC
05:30:30  *** dihedral has quit IRC
05:30:46  *** D-HUND has joined #openttd
05:30:46  *** KenjiE20 has joined #openttd
05:30:46  *** Sacro has joined #openttd
05:30:46  *** ZirconiumX has joined #openttd
05:30:46  *** moll has joined #openttd
05:30:46  *** lastmikoi has joined #openttd
05:30:46  *** gooodger has joined #openttd
05:30:46  *** Artea has joined #openttd
05:30:46  *** natalie[m] has joined #openttd
05:30:46  *** joey[m] has joined #openttd
05:30:46  *** osvaldo[m] has joined #openttd
05:30:46  *** elliot[m] has joined #openttd
05:30:46  *** natmac[m] has joined #openttd
05:30:46  *** grag[m] has joined #openttd
05:30:46  *** yur3shmukcik[m] has joined #openttd
05:30:46  *** freu[m] has joined #openttd
05:30:46  *** pina[m] has joined #openttd
05:30:46  *** NGC3982 has joined #openttd
05:30:46  *** skrzyp has joined #openttd
05:30:46  *** Decapita1 has joined #openttd
05:30:46  *** dihedral has joined #openttd
05:30:46  *** orudge has joined #openttd
05:30:46  *** milek7 has joined #openttd
05:30:46  *** tyteen4a03 has joined #openttd
05:30:46  *** luaduck has joined #openttd
05:30:46  *** Alkel_U3 has joined #openttd
05:30:46  *** guru3 has joined #openttd
05:30:46  *** michi_cc has joined #openttd
05:30:46  *** liquid.oftc.net sets mode: +v michi_cc
05:31:45  *** ChanServ sets mode: +o orudge
05:58:43  *** sla_ro|master has joined #openttd
06:15:50  *** tuvok has quit IRC
06:16:11  *** tuvok has joined #openttd
06:16:13  *** andythenorth has joined #openttd
06:28:54  *** Wolf01 has joined #openttd
06:34:53  *** k-man has quit IRC
06:38:01  *** k-man has joined #openttd
07:04:11  *** D-HUND is now known as debdog
07:46:04  *** Samu has joined #openttd
07:46:09  <Samu> hello
07:46:44  *** arikover has joined #openttd
07:53:48  <Samu> oh, i'm gonna test #8051
07:54:07  <DorpsGek_III_> [OpenTTD/website] Leffe108 commented on issue #48: finger.openttd.org https://git.io/fhi9K
07:59:18  <Samu> I have a feeling it's gonna break start_date
08:12:58  <tuvok> hm i have big problems with traffic lights and trains
08:13:53  <tuvok> gives a manual with that?
08:16:44  <andythenorth> https://wiki.openttd.org/Signals ?
08:24:36  <DorpsGek_III_> [OpenTTD/OpenTTD] SamuXarick commented on pull request #8051: Fix: Don't rerandomise a script's settings when loading from a save https://git.io/Jv5Cf
08:28:17  <DorpsGek_III_> [OpenTTD/OpenTTD] LordAro commented on pull request #8051: Fix: Don't rerandomise a script's settings when loading from a save https://git.io/Jv5CT
08:31:55  <Samu> I mean, random deviation for start_date, has to happen on constructor
08:32:16  <Samu> on new game
08:32:52  <Samu> you set a random deviation for 182 days in main menu, then you start a new game, and the deviation didn't occur
08:33:08  <Samu> it will occur when the script is starting, which is pointless by then, it has already waited 182 days
08:34:00  <LordAro> ah, i see
08:34:04  <LordAro> put that in the issue please
08:34:06  <LordAro> you started so well
08:45:53  <DorpsGek_III_> [OpenTTD/OpenTTD] SamuXarick commented on pull request #8051: Fix: Don't rerandomise a script's settings when loading from a save https://git.io/Jv5CV
08:51:26  <Samu> my bad, you don't really set a random deviation for 182 days
08:51:36  <Samu> you set a start_date of 182 days, what I meant to say
09:00:43  *** supermop_Home has quit IRC
09:17:04  <tuvok> hm i think iam to stupid for traffic signals and trains
09:26:32  <LordAro> tuvok: you can ignore all the presignal stuff, just use PBS signals
09:26:44  <LordAro> presignals are for advanced users only
09:44:04  <Eddi|zuHause> we should just remove presignals
10:02:00  *** gelignite has joined #openttd
10:24:14  <tuvok> hm ok
10:47:41  *** andythenorth has left #openttd
11:08:48  *** arikover has quit IRC
11:27:07  <DorpsGek_III_> [OpenTTD/OpenTTD] SamuXarick commented on pull request #8051: Fix: Don't rerandomise a script's settings when loading from a save https://git.io/Jv5Rb
11:27:17  <Samu> i made a big table :)
11:28:52  *** msmarquim has joined #openttd
11:29:32  <Samu> oops, table is wrong :|
11:29:37  <Samu> dumb me
11:30:51  <Samu> this is so confusing, even i get confused
11:31:48  *** msmarquim has quit IRC
11:50:16  *** arikover has joined #openttd
11:57:16  *** andythenorth has joined #openttd
12:22:58  <Samu> this just in! I think i found a bug with random deviation itself, the interval
12:23:38  <Samu> if value is 30, and random deviation is 10, the resulting value is inside [20, 39]
12:23:44  *** andythenorth has left #openttd
12:24:05  <Samu> shouldn't it be [20, 40]?
12:24:22  <Samu> 30 +/- 10 = [20, 40]
12:28:27  <DorpsGek_III_> [OpenTTD/OpenTTD] LordAro commented on pull request #8051: Fix: Don't rerandomise a script's settings when loading from a save https://git.io/Jv5ur
12:29:50  <LordAro> Samu: it's not uncommon for ranges to have an exclusive upper bound
12:30:15  <LordAro> i'd probably say that it should be documented, but probably not worth changing
12:31:06  <Samu> random range had a similar bug
12:31:15  <Samu> which was fixed
12:31:23  <LordAro> hmm, ok
12:31:28  <LordAro> should probably be consistent
12:32:14  <Samu> btw, have you seen #7661 - it reworks start_date to be more sane
12:33:34  <Samu> start_date is usually the problem in all this
12:40:51  <Samu> https://wiki.openttd.org/AI:AIInfo#Settings there's a table here
12:41:06  <Samu> "When the game is started, the value for the setting will be randomized between user_specified_value - random_deviation and user_specified_value + random_deviation."
12:41:45  <Samu> gonna fix
12:47:21  <Eddi|zuHause> if ranges have an open and a closed boundary, you can join and split them without fancy +1 maths
12:47:31  <Eddi|zuHause> but random deviation should probably be symmetrical
12:50:02  <DorpsGek_III_> [OpenTTD/OpenTTD] nielsmh commented on pull request #8051: Fix: Don't rerandomise a script's settings when loading from a save https://git.io/Jv5zb
12:51:58  <Samu> https://docs.openttd.org/ai-api/classAIInfo.html says "random_deviation If this property has a nonzero value, then the actual value of the setting in game will be user_configured_value + random(-random_deviation, random_deviation)."
12:58:04  <Samu> commit message looks good? Fix: [Script] Random deviation upper bound range is inclusive
12:58:30  <LordAro> s/is/should be/
12:58:48  <Samu> should be, ok
13:03:50  <DorpsGek_III_> [OpenTTD/OpenTTD] SamuXarick opened pull request #8052: Fix: [Script] Random deviation upper bound range should be inclusive https://git.io/Jv5gD
13:09:10  *** gelignite has quit IRC
13:36:54  *** nielsm has joined #openttd
13:39:35  *** supermop_Home has joined #openttd
13:39:42  <supermop_Home> good morning
13:45:00  <Samu> hi
13:56:05  *** Flygon has quit IRC
14:07:00  <Eddi|zuHause> <Samu> https://docs.openttd.org/ai-api/classAIInfo.html says "random_deviation If this property has a nonzero value, then the actual value of the setting in game will be user_configured_value + random(-random_deviation, random_deviation)." <- that is not a good description as random() usully has an open upper bound
14:08:45  <Eddi|zuHause> so it technically describes the old behaviour, but since we determined to change the behaviour, this description must also change
14:10:38  <LordAro> depends if random() is referring to anything specific
14:10:45  <LordAro> but should probably be clearer anyway
14:13:13  <Samu> ok, english is not my forte
14:14:17  <LordAro> that's a pretty funny sentence really
14:16:00  <Eddi|zuHause> it's a really bad description, because it uses technical language which it never specified
14:16:51  <Samu> I read it as 30 +/- 10
14:16:58  <Samu> so between 20 and 40, inclusive
14:18:03  <Samu> how can I make the descriptionit clearer
14:18:23  <Eddi|zuHause> probably something like "... will be randomized in the range [user_configured_value - random_deviation, user_configured_value + random_deviation] (inclusive)"
14:18:56  <Samu> ok, let me copy that
14:28:24  *** gelignite has joined #openttd
14:33:26  <Samu> while we're at it, this document is a bit outdated
14:33:42  <Samu> GetAPIVersion only has 1.3 as max
14:36:03  <Samu> custom difficulty no longer exists
14:44:22  <Samu> I have no means to test doxygen, but I think it's going to show ok
14:47:39  <DorpsGek_III_> [OpenTTD/OpenTTD] SamuXarick updated pull request #8052: Fix: [Script] Random deviation upper bound range should be inclusive https://git.io/Jv5gD
14:49:19  <Samu> oops, terrible typo :p
14:52:21  <DorpsGek_III_> [OpenTTD/OpenTTD] SamuXarick updated pull request #8052: Fix: [Script] Random deviation upper bound range should be inclusive https://git.io/Jv5gD
14:52:52  <Samu> fixedone
14:53:29  <Samu> how do i check doxygen ? wanted to see how it's displayed
14:54:18  <LordAro> build it yourself
14:54:19  <nielsm> you install doxygen on your own machine and run it
14:54:46  <Samu> oh really? :( no website to look for?
14:54:57  <LordAro> not for PRs
14:55:07  <Samu> too bad
15:03:37  <Samu> here's the CONFIG_RANDOM commit https://github.com/OpenTTD/OpenTTD/commit/41fb7cb15e79e3abd3bfddec14048f026a2d62e5, already in, 2 years ago
15:05:24  <DorpsGek_III_> [OpenTTD/OpenTTD] LordAro approved pull request #8052: Fix: [Script] Random deviation upper bound range should be inclusive https://git.io/Jv5oz
15:14:54  <Samu> hi nielsm how's ending_year going?
15:15:16  <nielsm> not done anything more on it
15:15:38  <nielsm> it's not a critical bug by any means
15:16:15  <Samu> there is a possibility of an overflow, if you wait 800k+ years
15:16:22  <Samu> but yeah, unlikely
15:17:31  <Samu> the _date doesn't get capped to year 5 million, it goes over
15:18:57  <nielsm> oh... if the player is insane and sets the end year to the same as MAX_YEAR
15:19:04  <Samu> yes
15:19:36  <nielsm> can we just call that an easter egg
15:19:52  <Samu> i tested what happened when it overflows
15:19:59  <nielsm> or otherwise promote it to a feature
15:20:07  <Samu> it's gonna end crashing openttd with weird errors
15:20:47  <Samu> i have a save, if you want to
15:20:55  <nielsm> I don't need a save
15:20:59  <nielsm> it's clear it will misbehave
15:21:44  <nielsm> I just think you've already caused me to waste more time (and wasted more of your own time) on a bug nobody will ever experience in practice
15:22:20  <Samu> Unnamed, 5879610-07-11.sav the last day before the overflow :p
15:22:27  <Samu> i like to test this stuff hehe
15:51:39  *** tuvok-_ has joined #openttd
15:58:53  *** tuvok has quit IRC
16:01:13  *** Zuu has joined #openttd
16:23:28  <Zuu> Hello
16:24:43  <LordAro> itsa Zuu
16:25:16  <Zuu> I know this may be controversial, but do you know any other open source game than OpenTTD that is perhaps a bit more general that can be played online multiplayer?
16:26:00  <LordAro> define "a bit more general"
16:26:58  <Zuu> These days I've ended up being in the board of a local game club which mostly meet and play games mostly as an excuse to be social and meet and due to c* we need to try to host something online.
16:27:56  <Zuu> It can be yazzy or some well known board game or some variant of that. That plays for 20-40 minutes or so.
16:28:54  <LordAro> https://en.wikipedia.org/wiki/List_of_open-source_video_games would probably be a good place to start
16:29:00  <LordAro> does OpenRCT2 have multiplayer yet?
16:29:19  <LordAro> apparently yes
16:29:28  <Zuu> Thanks for the suggestion/link.
16:31:00  <Zuu> Oh I've completely left out of OpenRCT/FreeRCT.
16:31:25  <LordAro> FreeRCT died several years ago
16:31:41  <Zuu> Yeah. At least I've implemented fences for it :D
16:31:47  <LordAro> :D
16:33:12  <arikover> Zuu: there is Pioneers, a computer-based version of "the Settlers of Catan": http://pio.sourceforge.net/
16:34:33  <arikover> Zuu: it is available on the Ubuntu Software Center, and I think a multilpayer game can be set online... not sure.
16:35:02  <Zuu> arikover: thanks for the suggestion. (fun fact: I've wored on a computer implementation of settlers of catan in Visual Basic which had hot seat multiplayer)
16:41:04  <arikover> Zuu: hot seat multiplayer reminds me of HM&M2... fun times.
16:45:47  <Zuu> Also talking of catan. I made a fairly catan-inspired mini-game in a Ludum dare. The backstory is that you inherit an island and have to build a settlement to support a moon program. https://junctioneer.net/navennni/www-latest/#/app/rules
16:48:03  <arikover> Zuu: so in the meantime I installed Pioneers from Ubuntu bananas, and there is a Pioneers Server thing. Of course the game is turn-based, so there is a lot of waiting, but it works.
16:48:45  <Zuu> That might be alright as that allows for the others to talk while waiting for the person deciding what to do.
16:49:36  <arikover> Zuu: ... the main problem being the maximum number of players: 8.
16:50:47  <Zuu> I know all comes down to that we should play OpenTTD :-p
16:54:25  <Samu> hi zuu
16:56:22  <Zuu> Hi Samu
16:58:11  <LordAro> Zuu: well, 1.10.0 release tomorrow :)
16:58:23  <Zuu> :)
16:58:51  <Wolf01> They said no april fools, so release now :>
16:59:23  <LordAro> i'm expecting it to be tagged tonight, tbf
16:59:50  <Samu> make cluelessplus build air
16:59:53  <Samu> https://www.tt-forums.net/viewtopic.php?f=65&t=86810
17:00:47  <Zuu> Great that the tradition is kept. Swedish road administration used to release model updates on or around 1 april but this year the schedule has been changed.
17:02:36  <Zuu> Clueless Plus can build air if you toggle a swich. The switch is there because it is not as good to not go bankrupt if you enable it. :-p
17:03:19  <Samu> I remember I had a question for you, but can't remember which
17:03:36  <Samu> now that you're here, I don't remember, of course
17:04:23  <Zuu> That happens.
17:08:08  <Samu> i think it was about the road pathfinder? let me see
17:13:39  <TrueBrain> run while you can Zuu , run! :P
17:13:41  <TrueBrain> and hi :)
17:13:52  <Zuu> TrueBrain: Great advice :-)
17:13:56  <Zuu> And hi
17:14:25  <Samu> ah, about this line
17:14:27  <Samu> https://dev.openttdcoop.org/projects/lib-pathfinderroad/repository/entry/main.nut#L257
17:14:40  <Zuu> TrueBrain: too late :-p
17:14:53  <TrueBrain> now you only have yourself to blame :)
17:15:11  <Samu> AIRoad.CanBuildConnectedRoadPartsHere can return -1
17:15:37  <Samu> line needs to be changed to AIRoad.CanBuildConnectedRoadPartsHere(cur_node, path.GetParent().GetTile(), next_tile) > 1
17:15:46  <Samu> can you change it? it says you're project manager
17:16:07  <Samu> i mean > 0
17:16:37  <Samu> then i guess superlib would also needs fixed
17:16:50  *** andythenorth has joined #openttd
17:16:52  <andythenorth> Hello!
17:17:03  <TrueBrain> owh no, an andythenorth
17:17:24  <andythenorth> oh dear, where?
17:17:28  <TrueBrain> I dunno
17:17:30  <TrueBrain> look behind you?
17:17:51  <TrueBrain> right, lets add some more regression tests ..
17:18:44  <andythenorth> oof I am accidentally going to work the rest of the day :P
17:18:47  <andythenorth> I can forsee it
17:18:58  <Samu> CanBuildConnectedRoadParts can in fact return -1, 0, 1 and 2
17:19:03  <andythenorth> New Zealand call at 20.30 UK time, and some website I am building also
17:19:10  <andythenorth> are we releasing anything? D
17:19:24  <TrueBrain> is it the end of the month?
17:20:27  <Zuu> Samu: I think I inherited the common road path finders after probably TrueBrain at some point. But I've not been active coding anything OpenTTD related for years.
17:20:41  <andythenorth> TrueBrain nearly!
17:20:50  *** tokai|noir has joined #openttd
17:20:50  *** ChanServ sets mode: +v tokai|noir
17:21:05  <DorpsGek_III_> [OpenTTD/OpenTTD] msikma commented on issue #7644: Mysteriously poor performance on macOS https://git.io/fjii3
17:21:10  <TrueBrain> yes, blame the author, such an easy escape :P :P :P :P :P
17:21:21  <Zuu> I probably still have the credentials so I can push an update if it is needed.
17:21:27  <TrueBrain> while I am looking at hacks to get around BaNaNaS doing uniqueid detection :P
17:21:37  <Zuu> TrueBrain: Think this time you took the blame on you.
17:21:42  <TrueBrain> :D
17:22:16  <Zuu> Ah that uniqueid and script name soup :-)
17:22:19  <TrueBrain> :D
17:23:46  *** Progman has joined #openttd
17:23:54  <Samu> there has been a recent fix regarding that function on OpenTTD side, so it's kind of relevant if it was also fixed in the library
17:24:29  <Samu> it still works, doesn't appear to be breaking AIs, but, it's accepting -1 as true
17:26:19  <Zuu> Hmm pushing to bananas is probably the easy part. Figuring out how to auth with devzone and how to use hg is probably more complicated.
17:26:45  *** adikt has quit IRC
17:27:21  *** gelignite has quit IRC
17:27:22  <Zuu> TrueBrain: according to devzone, Yexo is the original author and not you.
17:27:33  *** tokai has quit IRC
17:27:34  <TrueBrain> pretty sure that is sort-of a lie :P
17:27:37  <TrueBrain> but I am fine with it :D
17:27:49  <DorpsGek_III_> [OpenTTD/OpenTTD] andythenorth commented on issue #7644: Mysteriously poor performance on macOS https://git.io/fjii3
17:28:07  <Zuu> Hm.. although the first commit says "import verison 2" so there is still a verison 1 not in the repo that could be yours. :-p
17:30:11  <TrueBrain> that is how things went in these days :)
17:31:03  <Zuu> Yep
17:31:48  <Samu> due to a bug in openttd side, -1 was all that it was returning when loading a game with a different map size than the current
17:31:59  <Zuu> Is devzone still the source of thruth and I should figure out how to auth with it or are things moving over to github these days?
17:32:29  <TrueBrain> I do not think anyone currently is actively planning to migrate projects like that to GitHub
17:32:37  <TrueBrain> but if you like, I would welcome if you do :)
17:32:59  <Zuu> Or if you Samu have a ssh-key setup I can give you write access to the repo so you can patch the code and then I can figure out how to deploy to bananas.
17:33:17  <Samu> i dont have an account on openttdcoop
17:33:38  <Samu> not sure of ssh-key
17:33:41  <Samu> what's that
17:34:36  <Zuu> You have a private and a public key. The public key needs to be authorized on opentttdcoop. Today such things usually is done by adding it to your user account, but this is an older system where I think an admin needs to authorize your public key.
17:35:05  *** glx has joined #openttd
17:35:05  *** ChanServ sets mode: +v glx
17:35:27  <Zuu> But it could also be that I'm authorized and I just have used a specific ssh key for openttd-devzone and have broken my .ssh/config.
17:36:39  <TrueBrain> I said it before, and I say it again: tusd is implemented poorly ... the "post-create" call can be done before the "pre-create" call is
17:36:40  <TrueBrain> yes
17:36:41  <TrueBrain> you read that right
17:36:59  <TrueBrain> euh .. sorry: "post-finish" can be called before "post-create"
17:37:04  <TrueBrain> it is shitty :(
17:37:34  <glx> that doesn't seem safe
17:38:49  <TrueBrain> it isn't
17:39:17  <TrueBrain> also, something that is shitty: if you open 2 Excel files in 2 windows, make changes in one, make changes in the other, go back to the first and hit undo .... it undos the change of the other window!!!
17:39:20  <glx> any way to mark when a step is done ?
17:39:22  <TrueBrain> that fucked me over real good today
17:42:14  <TrueBrain> hmm .. a "main.nut" is required, not?
17:42:24  <Samu> yes
17:42:34  <glx> only classes are required I think
17:42:48  <Samu> it looks for a file with that name
17:42:54  <glx> but I need to check the source
17:43:15  <Zuu> TrueBrain: main.nut is requried for OpenTTD but not for Excel :-p
17:43:20  <TrueBrain> :D
17:43:24  <TrueBrain> sorry, I switched subject :P
17:44:12  <Zuu> Yeah it is strange how undo works in Excel. It has bugged me too. Or that when you have multiple windows of the same file it is a bit quirky.
17:44:28  <glx> ah yes scanner search for main.nut
17:47:37  *** spnda has joined #openttd
17:48:18  <glx> hmm unless a name is already given it seems https://github.com/OpenTTD/OpenTTD/blob/bd3a5876b0a730d4a5fc9e29a8446b7810c1697a/src/script/script_scanner.cpp#L26-L61
17:49:17  <spnda> Can I somehow obtain OpenTTD 1.8 or maybe even older?
17:49:27  <glx> yes you can :)
17:49:40  <spnda> from where?
17:49:48  <TrueBrain> glx: isn't that simply replacing "info.nut" with "main.nut", and loading that?
17:49:58  <TrueBrain> spnda: https://cdn.openttd.org/openttd-releases/
17:50:01  <TrueBrain> knock yourself out :)
17:50:08  <spnda> ayy thanks a lot
17:50:14  <glx> TrueBrain: yeah seems so
17:50:23  <Samu> https://www.ssh.com/ssh/public-key-authentication - I don't have anything resembling this
17:54:12  <DorpsGek_III_> [OpenTTD/OpenTTD] glx22 commented on pull request #8051: Fix: Don't rerandomise a script's settings when loading from a save https://git.io/Jv5MM
17:58:53  <DorpsGek_III_> [OpenTTD/OpenTTD] SamuXarick commented on pull request #8051: Fix: Don't rerandomise a script's settings when loading from a save https://git.io/Jv5Mx
18:00:03  <TrueBrain> b'/* A train: \xf0\x9f\x9a\x86 */\n'.decode("latin-1") gives no error
18:00:06  <TrueBrain> that is now what I want
18:00:39  <TrueBrain> decode("ascii") fixes my problem
18:00:53  <TrueBrain> but I guess that means some people cannot upload anymore :P
18:01:12  <TrueBrain> we made it a bit difficult in OpenTTD .. requiring a BOM to use utf8
18:01:53  <TrueBrain> I want to actively refuse those uploads, so people can fix it before it hits BaNaNaS
18:06:19  <TrueBrain> "File contains UTF-8 characters but doesn't contain UTF-8 BOM. OpenTTD won't load this file correctly. Please save the file with 'UTF-8 BOM' encoding."
18:06:23  <TrueBrain> are people going to understand this?
18:06:58  *** rotterdxm has joined #openttd
18:07:34  <LordAro> might want to consider linking to some wikipedia page about file encodings?
18:07:38  <LordAro> but other than that, reads fine
18:07:47  <Zuu> Samu: Is it ok that I log your report as an issue on devzone?
18:07:53  <TrueBrain> tnx LordAro
18:08:04  <Zuu> regarding the road path finder.
18:09:59  <Zuu> Samu: You won't get further than me without the help of a devzone admin to authorize your public key. If you're on windows you can enable the optional feature "openssh client" and you'll get ssh-keygen.
18:11:39  <Zuu> TrueBrain: It is probably enough for people who are aware of UTF-8 (BOM) or use an editor like notepad++ which have line-encoding options for BOM character. But most people would not be aware of it without an online search.
18:12:03  <TrueBrain> as long as they can find it with a search, I am fine, tbh
18:12:18  <Zuu> But that probably strengthens the case for actively checking for it and rejecting files encoded wrongly.
18:13:01  *** Zuu has quit IRC
18:13:13  <DorpsGek_III_> [OpenTTD/OpenTTD] LordAro closed pull request #8051: Fix: Don't rerandomise a script's settings when loading from a save https://git.io/Jv5eU
18:13:14  <DorpsGek_III_> [OpenTTD/OpenTTD] LordAro commented on pull request #8051: Fix: Don't rerandomise a script's settings when loading from a save https://git.io/Jv5D4
18:13:16  <DorpsGek_III_> [OpenTTD/OpenTTD] LordAro commented on pull request #7486: Fix: AI/GS settings with the flag SCRIPTCONFIG_RANDOM could be altered after loading from a savegame. https://git.io/Jv5DB
18:13:18  <DorpsGek_III_> [OpenTTD/OpenTTD] LordAro closed pull request #7486: Fix: AI/GS settings with the flag SCRIPTCONFIG_RANDOM could be altered after loading from a savegame. https://git.io/fjtsp
18:13:22  *** Zuu has joined #openttd
18:13:52  <LordAro> TrueBrain: i'd also be in favour of "fixing" OTTD's behaviour :p
18:14:02  * Zuu accidently killed their chat client when trying to make a thumbs up emoji :-p
18:14:36  <TrueBrain> LordAro: well, fixing OpenTTD is not as easy as you would think
18:14:42  <LordAro> naturally
18:14:43  <TrueBrain> currently we have some people who used latin-1
18:15:04  <TrueBrain> so how I for example now detect what was meant:
18:15:10  <TrueBrain> I check for BOM, if so: decode as utf-8
18:15:18  <TrueBrain> if not, decode as latin-1, and try to decode as utf-8
18:15:27  <TrueBrain> succeed with utf-8? Check if it gives the same result as latin-1
18:15:32  <TrueBrain> no? Someone forgot the BOM
18:15:48  <LordAro> sounds very complicated :p
18:15:51  <TrueBrain> it is
18:15:57  <TrueBrain> but okay, detection works :)
18:16:14  <LordAro> personally i'd just do utf8 decode -> if fail, fallback to latin-1
18:16:16  <LordAro> (on the OTTD side)
18:16:55  <TrueBrain> as long as you do that for the whole file, I guess
18:17:23  <LordAro> that is the -ve side to it
18:17:30  <LordAro> but... how big are the scripts really?
18:17:30  <Zuu> Hm.. are there files with mixed utf-8 and latin that we need to support? Oo
18:17:58  <LordAro> Zuu: that would be a case of "this is not valid utf8, so must be latin-1"
18:17:58  <TrueBrain> well, on a positive note, I only found a few uploads where people used latin-1
18:17:59  * Zuu hides (on script size)
18:18:04  <TrueBrain> and almost always with the pound-sign :P
18:18:15  <LordAro> if there are invalid characters, that's the author's fault
18:18:31  *** syr has quit IRC
18:18:38  <LordAro> s/invalid characters/incorrect characters after latin-1 decode/
18:18:55  *** syr has joined #openttd
18:20:49  <TrueBrain> but okay, at least at upload we are now somewhat prtected from this :)
18:22:37  <LordAro> aye
18:24:20  <TrueBrain> 	// function GetShortName()   { return "WRON"; }
18:24:20  <TrueBrain> 	function GetShortName()   { return "REGR"; }
18:24:22  <TrueBrain> it picks up WRON
18:24:25  *** WormnestAndroid has quit IRC
18:24:25  <Zuu> Regarding script size: SuperLib *.nut is about 9000 lines.
18:24:31  <TrueBrain> oops
18:24:54  <LordAro> TrueBrain: ahaha
18:25:18  <LordAro> Zuu: how much in kB?
18:25:51  <TrueBrain> these are all anti-Zuu lines of code btw :P
18:25:56  <TrueBrain> his tricks no longer work on us!
18:25:59  <TrueBrain> (well, Rb wrote that for musa :P)
18:26:01  *** WormnestAndroid has joined #openttd
18:26:35  <Zuu> LordAro: 324 k chars  (using cat *.nut | wc -m)
18:27:12  <LordAro> yeah, nothing too significant really
18:27:38  <Zuu> TrueBrain: So no blame on me? :-)
18:30:52  <andythenorth> BEER
18:34:17  <TrueBrain> okay, that are a few more regression cases \o/ Still a few more to go, but at least this is growing nicely now :)
18:34:17  <rotterdxm> I´ll drink to that
18:34:24  <rotterdxm> grats TrueBrain
18:34:37  <TrueBrain> 28 already, w00p
18:37:18  <TrueBrain> hmm .. readme.txt and license.txt .. what encoding do they have in OpenTTD ?
18:37:30  <TrueBrain> latin-1?
18:39:08  *** rotterdxm has quit IRC
18:39:17  *** gelignite has joined #openttd
18:39:36  <TrueBrain> it supports other languages, so I guess that is not possible
18:39:39  *** rotterdxm has joined #openttd
18:41:35  <TrueBrain> yeah, had to be valid UTF-8
18:41:36  <TrueBrain> cool
18:56:27  *** frosch123 has joined #openttd
19:00:01  <rotterdxm> is it weird if i set the IRC client colorscheme to match my NML language syntax file that i use in notepad++
19:00:24  <rotterdxm> because i don´t want to be right in that case
19:02:02  <TrueBrain> 70% coverage .. getting there ..
19:02:54  <rotterdxm> is this the new BaNaNas API you´re working on?
19:03:18  <TrueBrain> yes sir
19:03:42  <rotterdxm> you´re trying to make it backwards compatible with existing uploads?
19:03:52  <rotterdxm> with all their own flavors of weirdness
19:04:00  <TrueBrain> no, I am building the validator
19:04:04  <TrueBrain> to only allow that what is valid
19:04:07  <TrueBrain> so people don't upload crap :)
19:04:15  <rotterdxm> *whistles innocently*
19:04:31  <Samu> Zuu, sorry, I was having dinner. I'm new to SSH stuff
19:04:33  <rotterdxm> so what does coverage mean in this context?
19:04:37  <TrueBrain> okay ... I need a heightmap and a scenario (savegame) that is as tiny as possible .. hmmmmmm
19:04:38  <Samu> actually, i've never used it before
19:05:02  <TrueBrain> rotterdxm: I wrote an API for BaNaNaS, and I am now writing test-cases to validate I did everything as expected. coverage in this case means the amount of lines executed by my test-set
19:05:18  <TrueBrain> that means I have 30% code that is not triggered by the test-case, most likely indicating I need to add more tests :)
19:05:22  <Zuu> Samu: It is no problem. The point is that even if you sort it out you will be at no further point than I am.
19:05:26  <TrueBrain> for example, I don't test all API endpoints yet
19:05:42  <Samu> I see
19:05:47  <supermop_Home> andythenorthi want beer
19:06:01  <TrueBrain> I keep reading these things in the voice of homer
19:06:04  <TrueBrain> can't help it
19:06:46  <supermop_Home> new goal: deliver 800,000 liters of beer to Supermop by April 1 2020
19:08:20  *** arikover has quit IRC
19:08:23  <rotterdxm> ah i see, i just googled that term. interesting, Truebrain
19:08:37  <rotterdxm> so ideally 100% of the code is triggered
19:08:38  *** arikover has joined #openttd
19:08:52  <TrueBrain> 100% is not realistic
19:09:01  <TrueBrain> but at least till the point I don't see any lines I could trigger
19:09:10  <TrueBrain> the benefit is, if some upload ever breaks anything, we can fix it
19:09:18  <TrueBrain> and still know that nothing else is now broken (even more)
19:09:29  <rotterdxm> that is a huge upside
19:09:55  <rotterdxm> how long have you been working on this?
19:09:59  <rotterdxm> new API
19:10:13  <TrueBrain> the API? First commit was 5th of March, I believe
19:10:37  <TrueBrain> https://gist.github.com/TrueBrain/22ad7babbc474a57fa8618a681d704b6 <- 25th of Feb was the first thing written down
19:10:58  <TrueBrain> and we have 30 days left to get it in production :D
19:10:59  <TrueBrain> no preasure :P
19:12:10  <rotterdxm> ain´t no pressure without pleasure
19:12:24  <rotterdxm> how come there is a 30 day deadline?
19:14:16  <TrueBrain> the VPSes hosting the current BaNaNaS CDN expire at that point
19:14:20  <TrueBrain> as in, they are EoL
19:14:42  *** arikover has quit IRC
19:14:55  *** arikover has joined #openttd
19:18:36  <rotterdxm> oh whoa. okay so you´re replacing that whole... ecosystem(?) entirely?
19:18:55  <TrueBrain> just the backend
19:19:39  <rotterdxm> what happens if you do not make the deadline ?
19:20:10  <rotterdxm> should i start panic downloading newGRFs x)
19:20:52  <Zuu> Samu: I've logged the problem you brought up in the issue tracker https://dev.openttdcoop.org/issues/8701
19:21:15  <TrueBrain> rotterdxm: nah; I just blame Xaroth65 and we can move on
19:21:24  <rotterdxm> LOL
19:21:36  <Samu> thanks Zuu
19:21:56  <rotterdxm> it´s good to have a solid cascading blame schema prepared well in advance
19:22:16  <Samu> btw, you may add this link https://github.com/OpenTTD/OpenTTD/pull/8036
19:22:24  <TrueBrain> always rotterdxm , always :)
19:22:26  <Samu> makes it easier to understand what's solved
19:25:10  <Zuu> Interesting bug :-)
19:27:13  <Samu> turns out it affects *all* AIs :p
19:27:19  <andythenorth> I have a thick skin usually
19:27:21  <Samu> but not to the point of breaking them
19:27:25  <andythenorth> I could offer blame-as-a-service
19:27:36  <andythenorth> I might need 'service suspended' days sometimes though
19:28:06  <Samu> they just build sub-optimal paths
19:29:07  <Zuu> Samu: I don't rememeber how does squirrel threat numbers when casted to boolean?
19:29:18  <Samu> -1 is true
19:29:22  <Samu> 0 is false
19:29:25  <Samu> 1 is true, 2 is true
19:29:30  *** arikover has quit IRC
19:29:42  *** arikover has joined #openttd
19:29:55  <Zuu> So pre conditions failed is regarded as true. But why does it call it with wrong input data?
19:30:38  <TrueBrain> haha, I now did the stupiest thing ever ... I am generating regression-tests from existing BaNaNaS uploads, and feed that to the new BaNaNaS API, to see if they validate ... slow as fuck :P Because it is restarting the server every time :)
19:30:39  <TrueBrain> lol
19:30:43  <Samu> the input data was correct, but the bus caused it to be returning -1 all the time after loading a different map size
19:30:47  <Samu> the bug*
19:31:47  <Zuu> So when the bug in OpenTTD is fixed the script works fine?
19:32:01  <Zuu> But in older non-fixed OpenTTD versions the AI get in trouble?
19:32:32  <Samu> they don't get in trouble, because most of the time the library was also incorrectly using -1 as true
19:33:13  <Samu> it's confusing
19:33:32  <Samu> in short, it doesn't break AIs
19:33:37  <Samu> they still build their roads
19:33:54  <Samu> maybe sub-optimally
19:33:55  <Zuu> But if we fix the library to take -1 as false, then it will break AIs? :-p
19:34:56  <Samu> "yes"
19:34:58  <Zuu> (on old OpenTTd)
19:35:15  <Samu> ah, of that i'm not sure, didn't test
19:36:00  <Samu> wait a minute... I did test that!
19:36:29  <Samu> it doesn't break them, it builds with a different path
19:37:29  <Zuu> Is this fix (backported) in 1.10 branch?
19:37:36  <Samu> yes
19:39:48  <Zuu> So then the problem will solve by itself soon. And the script code could maybe use "> 0" for more correctness. Although it can be argued both ways if production code should check for erors like pre-condition failed.
19:41:48  <Samu> i tested the > 0 on my AI library
19:41:55  <TrueBrain> okay, seems we have some AIs which have UTF-8 but don't have the BOM .. let me see ...
19:41:59  <Samu> tends to build "smarter" roads
19:42:21  <TrueBrain> cool, an AI from LordAro  :)
19:42:23  <Samu> not saying the old method was wrong, it was also fine
19:42:37  * Zuu hopes not to be found guilty by TrueBrain
19:42:47  <LordAro> TrueBrain: well of course, i did it correctly :p
19:42:51  <Samu> fine in the sensse of "the path was complete and built correctly"
19:43:12  <TrueBrain> LordAro: pound-signs! :P
19:43:15  <LordAro> i'm fairly certain the squirrel code reads all encodings correctly anyway, doesn't it?
19:43:23  <Zuu> But given the many AIs/scripts I've uploaded it is not unlikely that I've done wrong. :-p
19:43:31  <TrueBrain> LordAro: now you tell me? Really? :P
19:43:41  <LordAro> i don't know what you're doing :p
19:44:00  <LordAro> i fixed something in that area some months ago...
19:44:04  <TrueBrain> LordAro: https://github.com/OpenTTD/OpenTTD/blob/13cc8a0ceec90def39cbcb84135a0bf039793a6f/src/script/squirrel.cpp#L636
19:44:11  <TrueBrain> if there is no BOM, it is read as ASCII
19:44:23  <LordAro> ah yeah
19:44:24  <TrueBrain> and with ASCII they mean latin-1, but who is counting
19:44:37  <TrueBrain> so I am guessing your info-lines look off
19:44:47  <LordAro> i feel like i would've noticed my info lines looking incorrect
19:44:49  <TrueBrain> "The company now has more than £"
19:45:01  <TrueBrain> would you mind double-checking this?
19:45:30  <LordAro> if it's just read as a sequence of bytes, i'm reasonably certain ICU/whatever just handles whatever it's given
19:45:51  <TrueBrain> so it is even more screwed than we thought?
19:46:37  <Samu> TrueBrain, didn't we check that with company value gs?
19:46:42  <TrueBrain> if you think that LordAro , I could really use confirmation of that claim :) As it kinda depend what we let through on BaNaNaS :)
19:46:48  <Samu> it also makes use of the £
19:46:59  <rotterdxm> so this is sort of like a brexit
19:47:01  <TrueBrain> no, yours was in latin-1
19:47:12  <Samu> oh :o
19:47:19  <TrueBrain> LordAro: as if your claim is correct, we don't need any encoding validation tbh
19:48:13  <TrueBrain> would also mean I don't get why we do all this BOM stuff in the code :D
19:48:39  <LordAro> TrueBrain: you win https://i.imgur.com/fCKygao.png
19:48:46  <LordAro> (on Windows/MinGW, at least)
19:48:52  <TrueBrain> I was not out to win anything, to be clear :)
19:49:00  <TrueBrain> I just like to have the validation to be correct ;)
19:49:06  <LordAro> :p
19:49:13  <TrueBrain> okay, so I am rejecting your AIs in that case :D
19:49:28  <Zuu> Also this is not the right win as it means more work. But at least not wasted work.
19:50:09  <TrueBrain> (to be clear, I am taking all BaNaNaS content as-is, that is already uploaded. Not rejecting anything already there :P)
19:50:42  <Samu> LordAro, look at the bright side, you had a crash report to fix!
19:50:44  <glx> yeah the idea is to reject new invalid stuff
19:51:01  <rotterdxm> that is excellent news
19:51:31  <rotterdxm> well, news to me
19:51:41  <LordAro> TrueBrain: i'm not entirely sure things should be rejected purely based on a possibly incorrect encoding
19:51:50  <glx> anyway wrong encoding only means weird displayed strings
19:51:50  <LordAro> it works fine, after all
19:51:58  <TrueBrain> LordAro: we just established it is not "possible" incorrect, it is incorrect
19:52:09  <TrueBrain> and "works fine" can lead to other issues
19:52:09  <LordAro> the string might not actually be used :p
19:52:12  <LordAro> could be in a comment
19:52:14  <TrueBrain> better to tell people to fix their issues?
19:52:51  <TrueBrain> well, other-way around: if you have the BOM, it really should be valid utf-8
19:52:54  <TrueBrain> otherwise we run into issues
19:52:58  <TrueBrain> so that is as simple as that
19:53:17  <TrueBrain> the other way around, I am willing to dismiss that as a warning-only
19:53:21  <LordAro> yes, no disagreements there
19:53:56  <TrueBrain> for which I currently have no control-flow, so I hate that suggestion :P
19:55:26  <TrueBrain> the one thing I am on the fence about, this also holds for strings displayed via GS
19:55:33  <TrueBrain> which are user-visible, not only for debugging
19:56:04  <Zuu> Especially if the strings come from eints in a language that the author doesn't read themself.
19:57:05  <TrueBrain> I found a readme with a similar issue :)
19:59:42  <TrueBrain> several readme.txt which are saved in latin-1 .. and OpenTTD loads them as utf-8
19:59:43  <TrueBrain> fun :)
19:59:46  <Zuu> Most helpful for authors would probably be if both OpenTTD and BaNaNaS used the same validation rules so you can detect the problem early. Not sure if a default .editorconfig for AI/GS would help autors from makning misatkes.
20:00:07  <TrueBrain> most helpful, honestly, would be if OpenTTD accepted utf-8 files :P
20:00:20  <TrueBrain> (without BOM)
20:01:04  <Zuu> If this was a game on steam, we'd set that requirement on next release and content authors would have to update :-p
20:01:33  <Zuu> Ie that all content must be in utf-8 (drop latin-1)
20:01:52  <TrueBrain> "CRITICAL Expeced entry 'errors' to be empty, but it is not; found: '['Unique ID should be exactly four character.']'"
20:02:13  <Zuu> But I guess we care about old stale content. :-)
20:02:21  <TrueBrain> Zuu: I guess
20:03:12  <TrueBrain> lol ... I forgot, GS of course has their strings not in Squirrel, but in language files
20:03:17  <TrueBrain> so I guess that is fine-ish
20:03:21  <TrueBrain> also, they don't pass validation :P
20:03:24  <Zuu> Is it possible to go by ie API version. If it is 1.10 or higher, file must be utf-8?
20:03:45  <TrueBrain> LordAro: ^^ sounds like a solid idea? :)
20:04:35  <LordAro> except that you need to read the file to know which API version it is? :p
20:04:50  <Zuu> TrueBrain: Mostly GS uses their external string files but it is still possible to build strings only in GS (just not mix with the external ones) and display to the user if I'm not mistaken.
20:05:00  <TrueBrain> ah
20:05:10  <LordAro> seems a bit backwards to read the file using old OTTD magic, then decide if it got it correct or not
20:05:12  <TrueBrain> lol, all Zuu 's GS fail validation ... GetShortName() fails :P
20:05:23  <TrueBrain> LordAro: it only needs to read info.nut once
20:05:27  <TrueBrain> to know for the whole set
20:06:31  <Samu> my GS had the £ in the info.nut
20:06:47  <Samu> still has
20:07:03  <Zuu> TrueBrain: What have I done?? :-p
20:07:19  <Zuu> NoCarGoal: function GetShortName()		{ return "CAGO"; }
20:07:24  <TrueBrain> no, the other ones
20:07:38  <TrueBrain>         function GetShortName()         { return /*"1234"*/ SELF_SHORTNAME; }
20:07:59  <LordAro> TrueBrain: it doesn't really sounds like you'd be simplifying anything, tbh
20:08:33  <TrueBrain> LordAro: forcing everything to be UTF-8, without BOM etc, does simplify it for users, I think
20:08:43  <TrueBrain> but, it is a suggestion I like, take it for ever you like :)
20:08:43  <Zuu> TrueBrain: which one is that?
20:08:58  <TrueBrain> Zuu: NoCarGoal
20:09:04  <LordAro> TrueBrain: sure, i don't disagree
20:09:04  <TrueBrain> version from 2012 :P
20:09:23  <TrueBrain> hmm .. some people uploaded a readme_settings.txt
20:09:31  <LordAro> but other forms still have to be supported, so there's no particular reason why the "new" UTF-8 should be enforced
20:09:32  <Zuu> Ah.. I guess I was a bit too creative back then.
20:09:36  <TrueBrain> the game only allows readme.txt / readme_nl.txt / readme_nl_NL.txt, as far as I know
20:10:14  <TrueBrain> LordAro: and I guess that is the suggestion: don't support other forms. Only support UTF-8
20:10:18  <TrueBrain> 1 world, simple, clean
20:10:21  <Zuu> Commit message of NoCarGoal version 5: "Version 5: Provide the short name in a way that bananas don't get confused"
20:10:43  <TrueBrain> Zuu: it is no longer confused. It now rejects it :P
20:10:52  <TrueBrain> we talked about writing a Python wrapper around Squirrel
20:10:55  <TrueBrain> so we could execute it
20:10:57  <TrueBrain> but ... effort :P
20:11:04  <LordAro> TrueBrain: but they've still got to be read to determine whether we can support them or not
20:11:09  <TrueBrain> for GameScripts, do languages have to be in the lang/ folder?
20:11:12  <TrueBrain> or can they be where-ever?
20:11:26  <Samu> lang folder
20:11:35  <TrueBrain> as I have one here where they are in the root folder ..
20:11:54  <Samu> strange that
20:12:04  <TrueBrain> ah, one upload out of many
20:12:09  <TrueBrain> so most likely a boo-boo, which BaNaNaS accepted
20:12:13  <TrueBrain> good, it no longer does :)
20:12:21  <Zuu> TrueBrain: What a lovely task you have to wander through all oddities people have succeeded to upload :-D
20:12:22  <LordAro> i'm not seeing any particular advantage to dropping support for other encodings, when for at least some level, other encodings would have to be implemented
20:12:37  <LordAro> s/when for/when at/
20:12:47  <TrueBrain> Zuu: I have to judge for every of them who was in the wrong ... and as you can see about the encoding talk, many opinions too :D
20:13:38  <TrueBrain> like .. I have a readme_de.txt that is saved as latin-1
20:13:41  <TrueBrain> I wonder how the game shows it
20:13:49  <TrueBrain> what does it do when it fails to load a readme as utf-8
20:14:35  <LordAro> displays lots of questionmarks, probably
20:14:54  <Samu> I didn't know you could have multiple readme files for every language
20:15:22  <frosch123> TrueBrain: str_validate(p, this->text + filesize, SVS_REPLACE_WITH_QUESTION_MARK | SVS_ALLOW_NEWLINE);
20:15:29  *** milek7 has left #openttd
20:15:48  <TrueBrain> frosch123: and those flags do what I expect them to do?
20:16:17  <frosch123> whitespace like tabs and formfeed become blanks, other stuff becomes ?
20:16:25  <TrueBrain> thank you good sir
20:16:52  <TrueBrain> I guess here too, the same question: is this a warning, or should we flatout refuse those uploads :)
20:17:00  <frosch123> also, since when does ottd support readme.txt.gz and .xz?
20:17:11  <TrueBrain> I was surprised as much as you are, when I read that blob
20:17:19  <TrueBrain> someone took the effort to implement that
20:17:25  <TrueBrain> because .. they could, I guess?
20:17:34  <frosch123> TrueBrain: non-utf8 users should be auto-banned
20:17:47  <TrueBrain> hahaha, banning them, that is even better :D
20:18:09  <frosch123> it's ridiclous that win10 still defaults to 8bit encodings
20:18:29  <TrueBrain> can't say I disagree ... UTF-8 everything
20:19:05  <TrueBrain> today I found these: 🚢 🚌 ✈
20:19:06  <TrueBrain> :D
20:19:07  *** Zuu has quit IRC
20:19:35  *** Zuu has joined #openttd
20:19:36  <frosch123> i bananas content?
20:19:37  *** Zuu has quit IRC
20:19:39  <frosch123> *in
20:19:51  <TrueBrain> no :) I added them to my regression set
20:19:59  <TrueBrain> so check UTF-8 stuff
20:20:06  *** Zuu has joined #openttd
20:20:08  *** Zuu has quit IRC
20:20:14  <TrueBrain> for some reason, I am still getting used to the fact icons exist inUTF-8
20:20:21  <TrueBrain> on one hand it makes me happy
20:20:26  <TrueBrain> on the other .... not sure what to think
20:20:44  <frosch123> aren't they the majority meanwhile?
20:20:59  <nielsm> https://en.wikipedia.org/wiki/Emoticons_(Unicode_block)
20:21:06  <frosch123> pretty sure the emoticon font was the biggest last time i checked
20:21:16  *** Zuu has joined #openttd
20:21:21  *** Zuu has quit IRC
20:21:23  <TrueBrain> like .. why are there cat-versions in there?
20:21:37  <nielsm> because japan wanted it
20:21:45  <TrueBrain> crazy world
20:21:47  <TrueBrain> seriously
20:21:47  <TrueBrain> crazy
20:22:04  <frosch123> TrueBrain: the fun starts with the prefix-characters
20:22:17  <TrueBrain> prefix-chars?
20:22:33  <frosch123> https://xkcd.com/1813/
20:22:38  <frosch123> modifiers
20:22:47  <LordAro> you didn't know about emoji?
20:22:49  <LordAro> goodness me
20:22:51  <frosch123> for genders, ethnicies, and what more
20:22:59  <TrueBrain> no no nono noooooooo
20:23:09  <TrueBrain> okay, I can see that usecase
20:23:15  <TrueBrain> not the vomit one :P
20:23:27  <LordAro> https://emojipedia.org/unicode-9.0/
20:23:33  <frosch123> ah, and for some reason they are postfix
20:23:51  <LordAro> and 10 and 11 and 12 and ...
20:23:52  <TrueBrain> Unicode has versions? Owh boy ...
20:24:00  <frosch123> TrueBrain: 🏻🏼🏽🏾🏿
20:24:12  <TrueBrain> how do you type this shit  ...
20:24:34  <LordAro> win+,
20:24:48  <TrueBrain> fucking hell .. this is short of insane
20:24:50  <LordAro> otherwise you memorise the codepoints :p
20:24:50  <frosch123> TrueBrain: copy+paste from kcharselect
20:24:59  <LordAro> this is so precious
20:25:02  <TrueBrain> right ... something I could have done without knowing :P
20:25:04  <LordAro> i've never seen someone discover emoji before
20:25:23  <LordAro> here, have a safety vest 🦺
20:25:27  <TrueBrain> I knew emojis were part of the unicode, but I did not know they went THIS FAR with it
20:25:38  <frosch123> TrueBrain: there are new ones every year
20:25:59  <frosch123> and people fight over them because they look different on ios and android
20:26:01  <TrueBrain> in 2020, we are getting one for lungs
20:26:02  <TrueBrain> lol
20:26:19  <frosch123> and since they are used to transport emotions, people are very upset very fast
20:26:33  <frosch123> since minor differennces in the glyphs appear very different in expression
20:26:45  <frosch123> also you missed the gun drama
20:26:47  <TrueBrain> it is a font ......
20:26:48  <TrueBrain> lol
20:26:48  <LordAro> https://blog.emojipedia.org/content/images/2018/04/pistol-emoji-comparison-image-emojipedia-2018.jpg
20:27:18  <LordAro> 2013 Google is my favourite
20:27:19  <TrueBrain> okay, that is just funny
20:27:23  <frosch123> TrueBrain: 🔫 <- that was a big deal some years ago
20:27:33  <TrueBrain> I understand why, tbh
20:27:37  <frosch123> it was a real gun first, then it got replaced by toy guns
20:27:47  <TrueBrain> I seem to get the twitter-variant
20:27:48  <TrueBrain> funny
20:27:54  <frosch123> which causes very different reactions when sender/receiver had different real/toy versions
20:28:10  <nielsm> except microsoft's turned from a scifi zapper into something more real gun-ish
20:28:15  <TrueBrain> wanna go 🔫🔫 with me outside? Yeah, I can understand that :)
20:28:16  <LordAro> https://www.youtube.com/watch?v=3AtBE9BOvvk emoji keyboard
20:28:17  <frosch123> oh, lordaro has a better link :)
20:29:37  <TrueBrain> this is just insane
20:29:41  <TrueBrain> people have too much time
20:30:27  <TrueBrain> and Tom Scott is awesome :)
20:30:49  <TrueBrain> okay, all NewGRFs validate, except for some readme/license/changelogs .. no surprise there
20:30:53  <TrueBrain> as UTF8 IS HARD YO
20:30:53  <frosch123> imagine you are part of unicode, and you have to discuss and approve this shit
20:31:26  <TrueBrain> "dear, what did you do today?" - "well, we talked for 8 hours if the poop emoji should allow the skintone postfix"
20:31:28  <TrueBrain> yeah ... no tnx
20:31:39  *** Zuu has joined #openttd
20:31:57  <LordAro> i have little doubt the unicode consortium hates emoji and just wants to go back to encoding languages that only 3 people have ever heard of
20:32:07  <LordAro> but if they don't, apple will just make stuff up themselves
20:32:08  *** Zuu is now known as Guest20962
20:32:20  <TrueBrain> Zuu, stay or go .. but you making us nervous :)
20:32:21  <nielsm> yes surely they'd rather pick up the han unification matter again
20:32:22  *** Guest20962 is now known as Zuu
20:32:39  <LordAro> aha
20:33:07  <Zuu> My client keept crashing upon join so I've now found a new one.
20:33:28  <nielsm> anyway I'm off to sleep, careful not to get fooled tomorrow
20:33:35  <TrueBrain> you too nielsm  :)
20:33:43  *** Zuu_ has joined #openttd
20:33:51  <TrueBrain> funny, I have a NewGRF that works fine on Windows, and fails on Linux, to show the correct language for its readmes :)
20:33:52  *** Zuu_ has quit IRC
20:33:52  <nielsm> I prepared a small joke for my coworkers tho :D
20:34:01  <LordAro> relatedly, anyone want to approve (& merge?!) #8027 ?
20:34:01  <TrueBrain> (lowercase language-code, instead of uppercase)
20:34:30  <LordAro> TrueBrain: tempted to call that an OTTD issue
20:34:33  <TrueBrain> I can YOLO it if you like?
20:34:46  <TrueBrain> LordAro: filesystem issue, tbh
20:35:11  <Zuu> Any way, what I tried to say when my client crashed was that on my Windows 10, when I open notepad and want to save a new file it now defaults to utf-8 (no BOM).
20:35:19  <LordAro> well yes, but there's no particular reason why OTTD shouldn't accept rEaDmE_nL.TxT
20:35:30  <TrueBrain> on windows, it does :D
20:35:44  <LordAro> *on systems with sane filesystems too
20:35:48  <TrueBrain> BaNaNaS now rightfully refuses uploads with that, btw
20:36:03  <frosch123> LordAro: titlegame?
20:36:19  <LordAro> osht, yeah
20:36:31  <TrueBrain> someone is awake :D
20:36:47  <TrueBrain> clearly me, glx and andythenorth were not :P
20:38:11  <TrueBrain> very tempted to fix all those NewGRFs with wrong encoding ..
20:38:19  <TrueBrain> but I am not going to repack all those entries :P
20:38:35  <LordAro> better make sure it works before pushing...
20:38:41  <LordAro> not the one i voted for
20:41:56  *** nielsm has quit IRC
20:42:05  <DorpsGek_III_> [OpenTTD/OpenTTD] SamuXarick updated pull request #7661: Codechange: Rework 'start_date' parameter for AIs as a game setting https://git.io/fjMsZ
20:42:34  <frosch123> LordAro: were assertions already disabled somewhere/somewhen?
20:42:37  <Zuu> ah.. title game competition. I missed it but looking through them I would have voted for another one than the winning one. Too crowded for my taste.
20:42:47  <LordAro> frosch123: i don't think so..
20:43:08  <LordAro> is that just a hack in he configure script?
20:43:34  <frosch123> https://github.com/OpenTTD/OpenTTD/commit/0b340fd3769fe6623d89a682959d957b5dfa0aef
20:43:47  <frosch123> all project files
20:43:57  <LordAro> :+1:
20:46:15  <LordAro> ah crap, and translations need backporting
20:46:19  <LordAro> blarg
20:46:28  <LordAro> luckily it's only 21:45
20:46:32  <LordAro> feels much later...
20:46:46  <TrueBrain> I have the same issue, indeed
20:46:57  <TrueBrain> (mainly because it is 22:45 here :P)
20:47:07  <LordAro> :p
20:47:09  <TrueBrain> backporting with my python script is easy btw
20:47:19  <TrueBrain> but yeah .. needs doing :)
20:47:37  <frosch123> you can also forget them, and put them into 1.10.1
20:49:41  <frosch123> andythenorth: someone send 9 screenshots to info@, do you want them?
20:49:59  <TrueBrain> hmm, I just realised that my regression tool kind is a musa replacement .. it does nearly the same, except in a YAML format instead of an .ini
20:50:00  <TrueBrain> lol
20:51:26  <DorpsGek_III_> [OpenTTD/OpenTTD] glx22 approved pull request #8027: Prepare for 1.10.0 release https://git.io/Jv59A
20:51:57  <DorpsGek_III_> [OpenTTD/OpenTTD] LordAro dismissed a review for pull request #8027: Prepare for 1.10.0 release https://git.io/Jv59A
20:51:57  <DorpsGek_III_> [OpenTTD/OpenTTD] LordAro updated pull request #8027: Prepare for 1.10.0 release https://git.io/Jvgul
20:52:09  <LordAro> just as well i had some commits ready to dismiss that review :p
20:52:30  <LordAro> frosch123: remind me of your translation backport script?
20:52:38  <LordAro> or TrueBrain
20:52:41  <LordAro> whoever's it is
20:52:44  <TrueBrain> https://devs.openttd.org/~truebrain/backport_languages.py.txt
20:53:08  <TrueBrain> it might kill your puppy; don't hold me responsible plz
20:53:47  <LordAro> i don't see a kill(puppy) in it
20:53:51  <LordAro> so it's probably good
20:53:56  <frosch123> http://devs.openttd.org/~frosch/texts/langbackport.py <- why do we have multiple of those scripts?
20:54:13  <andythenorth> frosch123 are they nice screenshots? :)
20:54:14  <TrueBrain> frosch123: because when I needed it for 1.9, nobody had one that worked with git .. so I wrote my own
20:54:15  <andythenorth> PR?
20:54:35  * andythenorth considers changing website to say 'submit PR for screenies'
20:54:36  <andythenorth> :P
20:55:09  <TrueBrain> frosch123: and it seems mine takes into account changes in english.txt
20:55:23  <TrueBrain> that was one of the issues with 1.9, where master changed english.txt entries, which should NOT be backported ;)
20:55:27  <LordAro> TrueBrain: wow that was simple
20:55:32  <LordAro> and seemed to work first time!
20:55:39  <TrueBrain> \o/
20:55:51  <TrueBrain> happy it was useful :)
20:55:59  <LordAro> why did i end up with a second checkout when i did 1.9?
20:56:46  <TrueBrain> what do you mean?
20:56:49  <DorpsGek_III_> [OpenTTD/OpenTTD] LordAro updated pull request #8027: Prepare for 1.10.0 release https://git.io/Jvgul
20:57:09  <frosch123> TrueBrain: mine does that as well
20:57:14  <LordAro> TrueBrain: dunno, but whichever script i used for 1.9.x required me make another checkout
20:57:17  <LordAro> probably svn-era
20:57:31  <frosch123> when strings change in english, they should not be backported, also not in other languages
20:57:32  <LordAro> right, #8027 is now ready
20:57:33  <LordAro> probably.
20:57:54  <frosch123> yes, my script is svn-era, and needs two checkouts :)
20:58:14  <DorpsGek_III_> [OpenTTD/OpenTTD] LordAro commented on pull request #8027: Prepare for 1.10.0 release https://git.io/Jv5Hv
20:58:22  <frosch123> andythenorth: no idea, they all look same-y, i guess 2 or 3 would have been plenty
20:59:37  <TrueBrain> frosch123: cool; so that means we do have 2 scripts to do the same :P
20:59:51  <frosch123> quite sure rb had a third
21:00:03  <TrueBrain> and dv .. :P
21:00:18  <TrueBrain> anyway, mine uses git and produces a diff btw, as a FYI. I just liked doing that :D
21:00:39  <DorpsGek_III_> [OpenTTD/OpenTTD] arikover opened pull request #8053: Hotkey for Land Info in normal mode https://git.io/Jv5HU
21:00:57  <andythenorth> oof bedtime :)
21:01:02  *** andythenorth has quit IRC
21:01:05  <frosch123> TrueBrain: you generate a diff yourself?
21:01:37  <frosch123> he, i did not edit .diffs since mq days
21:01:39  <TrueBrain> if memory serves me right, it gets the diff, and removes the lines that are changed in english.txt :P
21:02:52  <frosch123> ah,--recount makes it a lot easier
21:03:12  <DorpsGek_III_> [OpenTTD/OpenTTD] glx22 approved pull request #8027: Prepare for 1.10.0 release https://git.io/Jv5Hq
21:05:22  <rotterdxm> \o/
21:05:50  <LordAro> now the question is, when do we tag?
21:06:01  <LordAro> the time i set for the debian changelog was 12:00Z
21:06:41  <TrueBrain> when-ever you feel like releasing, tbh
21:07:18  <LordAro> good thing everything's automated, right?
21:07:26  <LordAro> oh, someone should probably write a news post
21:07:29  <TrueBrain> exactly
21:07:50  <TrueBrain> so you can wait till tomorrow, and have who-ever hit that release button
21:07:54  <TrueBrain> if you like
21:07:57  <TrueBrain> or release it when you merged
21:08:00  <TrueBrain> it really doesn't matter :)
21:09:16  <LordAro> alternatively we find the release-CI has broken somehow in the last 6 months and have to redo the tag :p
21:09:43  <TrueBrain> last release was in feb :P
21:10:00  <LordAro> ...i completely forgot about the RCs
21:10:09  <LordAro> maybe bedtime
21:10:51  <TrueBrain> first hit merge? :D
21:14:50  <LordAro> writing a first draft of the news post
21:14:52  <LordAro> then merge
21:14:54  <LordAro> then bed
21:16:16  <TrueBrain> nice work LordAro  :)
21:17:47  *** frosch123 has quit IRC
21:18:28  *** sla_ro|master has quit IRC
21:24:51  <Samu> 8052 wasn't supposed to be backported?
21:24:59  <Samu> guess it's too late
21:25:00  <TrueBrain> I had a problem .. I used sed ... I now have two problems: sed 's/, '\''/, "/g;s/'\'', /", /g;s/'\'']/"]/;s/\['\''/["/'
21:25:10  <LordAro> :D
21:26:00  <TrueBrain> 50% of the validations errors are UTF-8 related; lol
21:26:08  <TrueBrain> BaNaNaS really did not validate for any of it :)
21:26:53  <DorpsGek_III_> [OpenTTD/website] LordAro opened pull request #155: Add: News post for 1.10.0 https://git.io/Jv5HD
21:27:56  *** Progman has quit IRC
21:28:15  <TrueBrain> I spot a typo .. can I edit this myself ..
21:28:35  <LordAro> by all means
21:28:45  <LordAro> i only used the webinterface anyway
21:29:04  <DorpsGek_III_> [OpenTTD/website] TrueBrain updated pull request #155: Add: News post for 1.10.0 https://git.io/Jv5HD
21:29:09  <TrueBrain> there was a , missing
21:29:11  <TrueBrain> :D
21:29:15  <TrueBrain> I like your text
21:29:46  <LordAro> :)
21:30:22  <DorpsGek_III_> [OpenTTD/website] TrueBrain approved pull request #155: Add: News post for 1.10.0 https://git.io/Jv5HQ
21:30:39  <Samu> LordAro, did you forget #8052, just wondering
21:31:25  <TrueBrain> unpacked, BaNaNaS is 15GB on disk, with 44k files
21:33:05  <LordAro> Samu: ah crap yeah, might as well
21:33:12  <LordAro> thanks for reminder
21:33:22  <DorpsGek_III_> [OpenTTD/OpenTTD] LordAro merged pull request #8052: Fix: [Script] Random deviation upper bound range should be inclusive https://git.io/Jv5gD
21:34:43  <Zuu> "on/offload" => load/unload ?
21:35:02  <Zuu> But maybe that is British to write on/offload?
21:35:12  <LordAro> Zuu: nah, load/unload is probably better
21:35:20  <Zuu> Or ship specific wording that I don't know.
21:36:48  <Zuu> I'm not authorized to github so it is probably easier that you fix it.
21:37:03  <DorpsGek_III_> [OpenTTD/website] TrueBrain dismissed a review for pull request #155: Add: News post for 1.10.0 https://git.io/Jv5HQ
21:37:03  <DorpsGek_III_> [OpenTTD/website] TrueBrain updated pull request #155: Add: News post for 1.10.0 https://git.io/Jv5HD
21:37:17  <DorpsGek_III_> [OpenTTD/website] TrueBrain approved pull request #155: Add: News post for 1.10.0 https://git.io/Jv5H5
21:37:19  <TrueBrain> fixed
21:37:21  *** rotterdxm has quit IRC
21:37:22  <Samu> I gotta go, take care everyone
21:37:24  <Zuu> Thanks
21:37:33  *** Samu has quit IRC
21:37:40  <arikover> website/#155 [l. 19] "imporovements" -> "improvements"
21:38:00  <DorpsGek_III_> [OpenTTD/OpenTTD] LordAro dismissed a review for pull request #8027: Prepare for 1.10.0 release https://git.io/Jv5Hq
21:38:01  <DorpsGek_III_> [OpenTTD/OpenTTD] LordAro updated pull request #8027: Prepare for 1.10.0 release https://git.io/Jvgul
21:38:22  <DorpsGek_III_> [OpenTTD/website] TrueBrain dismissed a review for pull request #155: Add: News post for 1.10.0 https://git.io/Jv5H5
21:38:22  <DorpsGek_III_> [OpenTTD/website] TrueBrain updated pull request #155: Add: News post for 1.10.0 https://git.io/Jv5HD
21:38:23  <TrueBrain> anything else? :D
21:38:27  <TrueBrain> spammy spam spam :)
21:38:45  <DorpsGek_III_> [OpenTTD/website] TrueBrain approved pull request #155: Add: News post for 1.10.0 https://git.io/Jv5Hb
21:39:10  <DorpsGek_III_> [OpenTTD/OpenTTD] TrueBrain approved pull request #8027: Prepare for 1.10.0 release https://git.io/Jv5HN
21:39:11  *** adikt has joined #openttd
21:39:23  <TrueBrain> LordAro: you know that this last-minute-PR-merge-and-backport is going to bite you in the ass, right? :D
21:39:48  <Zuu> similiar  => Similar
21:40:11  <TrueBrain> why would that be a capital?
21:40:16  <TrueBrain> :D
21:40:19  <TrueBrain> but the liar is not needed
21:40:29  <LordAro> TrueBrain: for Bad Reasons, i'm currently logged into work VPN to try to fix something because someone merged some changes that broke the Windows build
21:40:38  <LordAro> so yes, i know that feeling quite well
21:40:43  <TrueBrain> :D
21:41:15  <Zuu> TrueBrain, Sorry. not capital. similiar => similar
21:41:35  <TrueBrain> why does my spellchecker not kick in, I wonder
21:41:35  <TrueBrain> hmm
21:41:45  <DorpsGek_III_> [OpenTTD/website] TrueBrain dismissed a review for pull request #155: Add: News post for 1.10.0 https://git.io/Jv5Hb
21:41:46  <DorpsGek_III_> [OpenTTD/website] TrueBrain updated pull request #155: Add: News post for 1.10.0 https://git.io/Jv5HD
21:41:49  <DorpsGek_III_> [OpenTTD/website] TrueBrain approved pull request #155: Add: News post for 1.10.0 https://git.io/Jv5Qv
21:42:02  <TrueBrain> I like the mispelling of similair
21:42:06  <TrueBrain> I am going to remember that :)
21:45:15  <Zuu> I pasted the text in ms word. One thing it is good at is complaining about spelling. https://pasteboard.co/J1Hh3DC.png The remaining things like "roadtypes" and "titlegame" is more opiniated in my option. :-p
21:45:20  <TrueBrain> "yeah, I am going to run this script before going to bed" - 50 minutes later - ".. I am sure it is ALMOST done, right?"
21:45:58  <TrueBrain> favorite vs favourite .. guess you set it to US? :D
21:46:05  <Zuu> Yep it is set to US.
21:46:23  <TrueBrain> bad Zuu , badd!
21:46:24  <TrueBrain> :D
21:46:30  <TrueBrain> US english is not a language :P
21:46:36  * LordAro has to use US English at work due to Customers
21:46:43  <LordAro> i have no idea how to correctly use "license" anymore
21:46:51  <LordAro> or licence
21:47:40  <TrueBrain> I only recent learnt there is a difference
21:47:48  <TrueBrain> never knew
21:47:53  <TrueBrain> language is funny like that
21:51:19  *** arikover has quit IRC
21:52:47  <TrueBrain> hmm .. for some reason, a few secnarios fail their md5 check
21:53:45  <TrueBrain> and that seems to be caused by my code
21:53:47  <TrueBrain> oh-oh :)
21:54:50  <TrueBrain> "Junk at the end of file."
21:54:51  <TrueBrain> that explains
21:56:04  <TrueBrain> padding zeros
21:56:05  <TrueBrain> yeah
21:56:06  *** milek7 has joined #openttd
21:58:07  *** jinks has joined #openttd
21:59:54  <TrueBrain> 345 validation errors, 39 of them are because of wrongly uploaded files (wrong name, or just shouldnt-have-been-there), 280 bad UTF-8, 17 because people copy/pasted basests too much, 5 because Zuu, leaving 4 with some random odds and ends .. not bad :) I can explain why all fail, so I am happy :)
22:00:41  <Zuu> And you got to blame me :-p
22:00:46  <TrueBrain> :D
22:00:48  <TrueBrain> that made me happy :P
22:00:57  <TrueBrain> sorry :P
22:01:06  <TrueBrain> see it as a welcome back present :)
22:01:12  <Zuu> No problem. I'm sure there are more things for me to blame.
22:01:27  <Zuu> to blam me for*
22:01:34  <Zuu> blame*
22:01:57  <TrueBrain> the good thing is, I managed to load everything in the new API, where I started it once, loaded all the BaNaNaS stuff in there, and it was still running
22:02:02  <TrueBrain> so I guess it is production-ready :P
22:02:37  <Eddi|zuHause> if it compiles, ship it
22:04:05  <Zuu> Also glad to make you happy TrueBrain :-)
22:04:51  <TrueBrain> hmm .. non-zero padding bytes at the end of the savegame
22:04:52  <TrueBrain> that is odd
22:08:56  <DorpsGek_III_> [OpenTTD/OpenTTD] LordAro merged pull request #8027: Prepare for 1.10.0 release https://git.io/Jvgul
22:10:41  *** gelignite has quit IRC
22:11:49  <DorpsGek_III_> [OpenTTD/OpenTTD] msikma commented on issue #7644: Mysteriously poor performance on macOS https://git.io/fjii3
22:12:48  <TrueBrain> okay, there is a bug in the zlib decompressor :)
22:12:52  <TrueBrain> it keeps feeding data infinitely
22:12:56  <TrueBrain> which is a nice feature :)
22:13:42  <LordAro> that's exciting
22:13:51  <TrueBrain> euh, lzma, oops
22:13:56  <TrueBrain> read() keeps returning bytes
22:13:57  <TrueBrain> fantastic
22:23:29  *** Wolf01 has quit IRC
22:23:36  <TrueBrain> okay ... lzma is not in the wrong
22:23:37  <TrueBrain> turns out
22:23:40  <TrueBrain> this is a 300 MiB savegame
22:24:00  <LordAro> lolwat
22:24:05  <TrueBrain> with an endless amount of repeating data
22:24:11  <TrueBrain> I think either compression failed somehow
22:24:18  <TrueBrain> or ... dunno tbh
22:24:30  <TrueBrain> but manually extracting the file results in a 300+MiB file :D
22:26:15  <TrueBrain> if nobody minds, I am going to ignore those files :D
22:26:46  <milek7> zip bomb savegame? :P
22:26:57  <LordAro> are these scenarios on bananas?
22:26:57  <TrueBrain> it is  not a bitflip, I have 3 of those files, all from the same author
22:27:00  <TrueBrain> yes
22:27:07  <LordAro> yeah...
22:27:12  <LordAro> i'd just drop them entirely
22:27:23  <TrueBrain> I will see if there is a modern version that doesn't have this
22:27:26  <TrueBrain> but this is seriously not okay :P
22:27:27  <LordAro> and maybe set a bit of a lower upload limit
22:28:02  <LordAro> add 20% to the biggest 32bpp baseset
22:28:32  <TrueBrain> the compressed file is just 10MiB
22:28:44  <TrueBrain> it is once you start uncompressing, that there is trouble :)
22:33:40  <TrueBrain> and here one with 128k bytes of zeros ... lol
22:34:30  <TrueBrain> very tempted to refuse those; but I have no clue how they are created
22:34:33  <TrueBrain> possibly a bug in OpenTTD?
22:35:39  <glx> do you know the map size ?
22:36:48  <TrueBrain> I have currently no metadata of these games
22:37:08  <TrueBrain> but this is data after the "\x00\x00\x00\x00' chunk in the savegame
22:37:11  <TrueBrain> which indicates: end-of-savegame
22:37:19  <TrueBrain> so the savegame part is valid
22:37:26  <TrueBrain> and I would guess OpenTTD stops reading after that
22:37:40  <TrueBrain> well, not for calculating the md5sum, I could imagine
22:37:53  <glx> could be an almost empty giant map
22:38:01  <TrueBrain> not sure how the md5sum of a scenario is calculated by OpenTTD
22:38:09  <TrueBrain> no; again, this is after the last chunk in the savegame
22:38:13  <TrueBrain> it really is junk from the OpenTTD perspective
22:38:24  <TrueBrain> there is no more data that OpenTTD will process
22:38:53  <TrueBrain> right, I will have to check tomorrow how OpenTTD calculates the md5sum ..
22:39:56  <TrueBrain> for now, I just refuse these .. seems the safer thing to do .. there are only a handful between all the uploads that have this issue
22:39:59  <TrueBrain> so not a real biggy, I guess
22:47:17  <TrueBrain> okay, I guess it is time to get some sleep, as I call a function once, and I see it being executed 3 times .. lol
22:50:59  *** k-man has quit IRC
22:56:13  <TrueBrain> okay .. figured it out :) md5sum is calculated over the compressed file
22:56:19  <TrueBrain> and reading stops after the stop-marker
22:56:25  <TrueBrain> so despite these files being completely weird
22:56:29  <TrueBrain> nothing is noticing it
22:56:33  <TrueBrain> .. still facepalm
22:56:42  <TrueBrain> still going to refuse those files from being uploaded

Powered by YARRSTE version: svn-trunk