Config
Log for #openttd on 8th June 2020:
Times are UTC Toggle Colours
00:38:49  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on pull request #8197: Fix: CPack source package creation https://git.io/JfDJS
02:37:21  *** D-HUND has joined #openttd
02:38:31  *** glx has quit IRC
02:40:40  *** debdog has quit IRC
02:47:26  *** Flygon has joined #openttd
03:27:42  <DorpsGek_III> [OpenTTD/website] James103 commented on pull request #161: Fix: paddings in website footer https://git.io/JfDqS
03:41:38  *** Wormnest has quit IRC
05:30:37  *** Gustavo6046 has quit IRC
05:56:37  *** cHawk- has joined #openttd
06:02:43  *** cHawk has quit IRC
06:08:42  *** nielsm has quit IRC
06:33:42  *** andythenorth has joined #openttd
06:46:22  *** EER has joined #openttd
07:11:45  *** arikover has joined #openttd
07:19:10  <DorpsGek_III> [OpenTTD/OpenTTD] telk5093 updated pull request #8207: Add: 'cheat' console command to open the cheat window https://git.io/JfM57
07:21:01  <DorpsGek_III> [OpenTTD/OpenTTD] telk5093 commented on pull request #8207: Add: 'cheat' console command to open the cheat window https://git.io/JfDZ6
07:24:53  <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz opened pull request #8208: Cleanup: More documentation fixes https://git.io/JfDZF
07:27:00  *** sla_ro|master has joined #openttd
07:30:12  <DorpsGek_III> [OpenTTD/OpenTTD] fsimonis commented on issue #8200: Consider upgrading to C++17 https://git.io/JfMiD
07:32:31  *** Wormnest has joined #openttd
07:34:58  *** gelignite has joined #openttd
08:25:08  *** Wormnest has quit IRC
08:25:25  *** iSoSyS has joined #openttd
08:27:01  *** iSoSyS has quit IRC
08:41:22  <DorpsGek_III> [OpenTTD/OpenTTD] fsimonis commented on issue #8201: Consider upgrading CMake to latest release https://git.io/JfMP8
08:47:40  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on issue #8201: Consider upgrading CMake to latest release https://git.io/JfMP8
08:49:20  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #8203: Fix: Minor changes in bundle generation https://git.io/JfDWx
08:49:30  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro merged pull request #8203: Fix: Minor changes in bundle generation https://git.io/JfMMu
08:49:45  <DorpsGek_III> [OpenTTD/website] auge8472 commented on pull request #161: Fix: paddings in website footer https://git.io/JfDWp
08:56:02  <DorpsGek_III> [OpenTTD/website] LordAro commented on pull request #161: Fix: paddings in website footer https://git.io/JfDln
09:00:58  <andythenorth> LordAro you tagging it? :)
09:01:05  <LordAro> nah.
09:13:16  <DorpsGek_III> [OpenTTD/website] auge8472 commented on pull request #161: Fix: paddings in website footer https://git.io/JfD8J
09:22:10  *** gelignite has quit IRC
09:33:01  *** Smedles has quit IRC
09:34:01  *** Smedles has joined #openttd
09:38:58  *** Smedles has quit IRC
09:40:11  *** Smedles has joined #openttd
09:51:19  *** Samu has joined #openttd
09:52:28  *** Tirili has joined #openttd
10:15:15  *** Tirili has quit IRC
10:29:13  *** Gustavo6046 has joined #openttd
10:38:14  *** WormnestAndroid has quit IRC
10:38:26  *** WormnestAndroid has joined #openttd
10:42:44  <Samu> hi
10:45:48  *** WormnestAndroid has quit IRC
10:46:01  *** WormnestAndroid has joined #openttd
11:04:24  <DorpsGek_III> [OpenTTD/OpenTTD] fsimonis commented on issue #8201: Consider upgrading CMake to latest release https://git.io/JfMP8
11:09:33  <Flygon> MFW - I try to come back to a game, and can't find a vehicle group I need to find because there's no Search function. :D]
11:10:43  <Flygon> Oh, found it.
11:26:10  *** namad7 has joined #openttd
11:27:30  *** namad7 has quit IRC
11:44:16  *** gelignite has joined #openttd
11:55:01  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on issue #8201: Consider upgrading CMake to latest release https://git.io/JfMP8
12:19:20  <supermop_Home_> maybe i should buy a Z scale JR 103
12:19:48  <supermop_Home_> there's also a nice T scale HST out there
12:26:47  *** glx has joined #openttd
12:26:48  *** ChanServ sets mode: +v glx
12:49:52  <andythenorth> hmm
12:50:05  <andythenorth> this would wreck FIRS Better Living Through Chemistry :D https://arstechnica.com/science/2020/06/how-to-make-plastic-bottles-from-sugarcane-and-captured-co%e2%82%82/
13:19:14  <supermop_Home_> just switch away from petrochem in 2030s, have all the oil wells close
13:30:20  *** spnda has joined #openttd
13:32:08  <spnda> How does DoCommandP work? I need to change something about building and placing road stops.
13:33:00  <glx> I think you never need to modify DoCommandP
13:33:18  <spnda> well probably not
13:33:26  <spnda> but what functions does it execute
13:35:25  <spnda> there's a list of Commands and you can pass the commands to DoCommandP, but what handles what command was passed and where is defined what it does afterwards?
13:42:17  <supermop_Home_> andythenorth thoughts on z or T? all my BR stuff is N but its all from like 1997
13:45:33  <_dp_> spnda, you can see what function handles the command in commpand.cpp and then grep for that function
13:46:11  <supermop_Home_> has anyone ever considered a model railroad baseset?
13:46:33  <_dp_> spnda, well, or just go to definition if your editor supports it
13:48:39  <glx> usually I just search for the CMD_XXX
13:49:22  <_dp_> glx, that will only give you the calls, not the handler
13:49:42  <glx> because it's a comment on DEF_CMD lines
13:50:10  <glx> DEF_CMD(CmdBuildRoadStop,            CMD_NO_WATER | CMD_AUTO, CMDT_LANDSCAPE_CONSTRUCTION), // CMD_BUILD_ROAD_STOP
13:50:30  <glx> the easier way to find the mapping
13:50:44  <_dp_> glx, well, that't just the same command.cpp I mentioned
13:51:25  <spnda> Yes I found CmdBuildRoadStop and the DEF_CMD(CmdBuildRoadStop... . What do I do now?
13:51:35  <spnda> I can't find any real definition or function call with it
13:51:56  <glx> you won't find direct call
13:52:02  <glx> it's all indirect
13:52:29  <_dp_> spnda, you either search/grep the whole source base for CmdBuildRoadStop or use goto definition function if your editor has it
13:52:44  <spnda> Tried both, found nothing
13:53:18  <spnda> Well sorry
13:53:19  <_dp_> spnda, then you're doing it wrong, mine jumps to station_cmd.cpp instantly
13:53:25  <spnda> Huh does it
13:54:17  <spnda> Ok I found it manually by searching for RoadStop in station_cmd.cpp. But really, searching for definition or declaration gave me no results
13:54:21  <spnda> But thanks, I got it now.
13:54:44  <andythenorth> supermop_Home_ I only know about OO and HO :)
13:55:20  <glx> spnda: when "go to definition" fails just use global search
13:57:03  <spnda> Well, I've got it but it really didnt find anything: https://imgur.com/a/tAprI88
13:57:04  <glx> oh I see why it fails for CmdBuildRoadStop, there's a TILE_AREA_LOOP() in the function killing intellisense
13:57:26  <supermop_Home_> andythenorth no room for that!
13:57:43  <_dp_> lol, luckily sublime has none of that stupidsense xD
13:57:48  <andythenorth> supermop_Home_ I think I'm building a train set in OpenTTD :P
13:58:07  <andythenorth> the irony is that Iron Horse definitely includes trains I had OO models of
13:58:19  <andythenorth> but now I am buying OO models just because they're in Iron Horse
13:58:32  <supermop_Home_> commission a line of injected molded Iron Horse models
13:58:35  <andythenorth> ha ha
13:58:41  <andythenorth> trains are taking up a lot of space here
13:58:54  <andythenorth> I have got into a buy-look-at-sell-again
13:59:00  <andythenorth> that kind of collecting :P
13:59:08  <andythenorth> buy, sell, lose 60% of value,
13:59:36  <glx> spnda: global search is Ctrl+Shift+F for me
14:00:11  <spnda> oh true
14:00:13  <spnda> lol
14:00:21  <spnda> havent been doin stuff for a while now
14:00:37  <glx> and it was worse with all FOR_ALL_XXX loops used before
14:00:50  <supermop_Home_> do the kids like the trains?
14:00:55  <glx> but there are still some loop macros in place
14:01:55  <andythenorth> supermop_Home_ some days they like the trains yes
14:02:02  <andythenorth> one of them likes them more than the other
14:39:12  *** gelignite has quit IRC
15:15:49  *** keoz has joined #openttd
15:23:17  *** virtualrandomnumber has joined #openttd
15:26:04  *** nielsm has joined #openttd
15:27:48  <supermop_Home_> cute tram fiddle yard: https://earth.google.com/web/@34.65629136,133.94323972,3.21050825a,105.77584197d,60y,0h,0t,0r
15:44:12  *** Wormnest has joined #openttd
15:50:29  <supermop_Home_> andy - make FIRS more dirty looking? https://earth.google.com/web/@34.48578398,133.72287128,4.19259305a,2360.97095428d,60y,0h,0t,0r
15:53:14  <andythenorth> interesting has been adding more grass and stuff to industries
15:53:28  <andythenorth> even really heavy industry tends to have grass areas
15:54:08  <supermop_Home_> combination steel mill / power plant / golf course island as industry?
15:55:18  <supermop_Home_> no grass here: https://earth.google.com/web/@34.46438478,133.43753352,5.89771096a,4822.66508022d,60y,-0h,0t,0r
15:55:49  <supermop_Home_> interesting to see the coal stained vs ore stained areas
15:56:43  <supermop_Home_> i assume they are making very long products in those sheds
15:58:56  <supermop_Home_> few other towns along Seto sea have smaller versions of that
16:00:02  *** virtualrandomnumber has quit IRC
16:23:21  *** frosch123 has joined #openttd
16:29:02  *** Flygon has quit IRC
16:53:43  *** Progman has joined #openttd
16:56:36  *** Wolf01 has joined #openttd
17:05:06  *** gelignite has joined #openttd
17:06:53  *** Wormnest has quit IRC
17:17:18  *** WormnestAndroid has quit IRC
17:17:23  *** WormnestAndroid has joined #openttd
17:19:29  <supermop_Home_> hi Wolf01
17:41:02  *** iSoSyS has joined #openttd
17:46:45  <Wolf01> hi supermop_Home_
18:02:36  <supermop_Home_> how's it over there?
18:06:29  <Wolf01> Me or Italy?
18:08:00  <supermop_Home_> either
18:08:10  <Wolf01> Both shit
18:08:23  <Wolf01> I liked more the lockdown
18:12:37  <supermop_Home_> more stores allowed to re-open today here
18:13:51  *** namad7 has joined #openttd
18:17:05  <Wolf01> https://www.windowscentral.com/hp-reverb-g2-tech-specs hmmm
18:17:18  *** namad7 has quit IRC
18:17:25  <Wolf01> I'm tempted, really
18:18:48  *** WormnestAndroid has quit IRC
18:19:47  *** WormnestAndroid has joined #openttd
18:21:31  *** Yexo has joined #openttd
18:21:32  *** ChanServ sets mode: +o Yexo
18:24:42  <frosch123> Wolf01: can you really play ottd with them?
18:52:51  <DorpsGek_III> [OpenTTD/nml] Yexo approved pull request #78: Add: optimise switches https://git.io/JfDQo
19:02:26  * andythenorth should test that 
19:03:06  <andythenorth> glx can we merge nml 155 and 156 yet?
19:03:20  <andythenorth> doubt anyone else is going to provide test cases until it's released
19:03:48  <andythenorth> :)
19:04:08  <spnda> I'm a bit confused right now. There's a bunch of different Station structs and I can't find the one I need. For a RailStation I saw "BaseStation" and what would be the RoadStop counterpart for that?
19:05:29  <glx> oh I broke nightlies again
19:05:55  <LordAro> eh, no one uses them anyway
19:07:19  <spnda> I see Station has references to bus and truck stops and airports, so I don't think that's what I am looking for
19:07:44  <spnda> I'm trying to get the struct for a RoadStop that I can then give it the RoadStopSpec for that stop
19:09:11  <spnda> oh it seems that this is all only defined for rail stations
19:09:31  <glx> BaseStation is the root of Stations and Waypoints
19:09:37  <spnda> of any stations?
19:09:41  <glx> yes
19:10:03  <glx> and Stations have a "facilities" flag
19:10:21  <glx> to determine what kind are present
19:10:46  <spnda> hmm ok
19:10:58  <spnda> so I guess I should change up the StationSpecList inside BaseStation?
19:11:00  <glx> and there should be a link to the road/bus/truck stop in the station struct
19:12:26  <spnda> so i'm not sure now
19:12:41  <spnda> Should I have a list of specs inside the RoadStop definition or inside the BaseStation definition
19:12:51  <spnda> The rail stations currently use a list of specs in the BaseStation definition
19:13:00  <spnda> so i'd probably need to change that somehow
19:14:24  <glx> https://github.com/OpenTTD/OpenTTD/blob/0b86bd8b03a333b2c0a1900901c3535a188e475d/src/station_base.h#L459-L462
19:15:09  <glx> because there's only rail in station newgrf spec
19:15:52  <glx> and they are shared between stations and waypoints
19:16:46  <glx> I guess if your feature is only for RoadStops it should go in RoadStop
19:17:15  <DorpsGek_III> [OpenTTD/nml] Yexo approved pull request #156: Fix: Procedure calls reference counting https://git.io/JfD7h
19:17:29  <spnda> hmm ok
19:17:37  <glx> like airport grf spec is in Airport
19:17:49  <spnda> oh right ok
19:20:14  <DorpsGek_III> [OpenTTD/OpenTTD] Yexo commented on issue #8001: Ship finds path but reports it is lost https://git.io/JvlVp
19:26:25  <spnda> use of undefined type 'RoadStop'? what?
19:30:26  *** y2kboy23 has quit IRC
19:32:49  <Yexo> spnda: OpenTTD (used to) make heavy use of forward declarations for pointers. If there is a "struct Roadstop;" visible anywhere, you can define a "RoadStop *bus_stops" variable. You can't use member variables that unless you include the right header to get the full definition of the RoadStop struct
19:33:00  <spnda> yeah
19:33:09  <spnda> i didn't include roadstop_base.h
19:33:17  <spnda> only included newgrf_roadstops.h
19:34:19  *** y2kboy23 has joined #openttd
19:48:47  <spnda> Different approach.... How should I add the RoadStopSpec to the RoadStop Station? I don't see a direct reference to it being added anywhere in the Airport build command, I only see the AllocateSpecToStation inside the Rail Station build command.
19:51:54  <glx> Airport store only the type, then Airport::GetSpec() https://github.com/OpenTTD/OpenTTD/blob/0b86bd8b03a333b2c0a1900901c3535a188e475d/src/station_base.h#L320-L324 use the type to get the spec
19:52:25  <glx> usually all this stuff uses indirections
19:54:43  <TrueBrain> in case nobody noticed it, the nightly failed :)
19:54:49  <TrueBrain> not sure who receives those emails ;)
19:55:00  <glx> yeah I know it failed, and I know why
19:55:20  <TrueBrain> cool :)
19:55:26  <glx> but yesterday it built fine, but didn't make its way to the website
19:55:47  <TrueBrain> found out why?
19:55:51  <glx> (and I don't receive emails)
19:57:14  <glx> dunno seems to happen sometimes
19:57:27  <TrueBrain> hasn't before?
19:57:29  <TrueBrain> I will check it out
19:57:30  <spnda> so... hmm, should I just have a RoadStopClassID and then a int to get the spec from that class referenced inside the RoadStop struct?
19:57:34  <TrueBrain> nightly rarely fails :)
19:58:26  <andythenorth> I love this screenshot from website https://www.openttd.org/screenshots/1.0-20090821_luuk_de_vries.png
19:58:31  <andythenorth> worth reading the signs :)
19:59:07  <glx> https://dev.azure.com/openttd/OpenTTD/_build/results?buildId=6026&view=results <-- no errors, but not added to https://cdn.openttd.org/openttd-nightlies/2020/
20:01:15  <EER> Wouldn't the upload be a release pipeline? https://dev.azure.com/openttd/OpenTTD/_releaseProgress?_a=release-environment-logs&releaseId=1278&environmentId=1608
20:04:01  <DorpsGek_III> [OpenTTD/OpenTTD] debdog commented on issue #8001: Ship finds path but reports it is lost https://git.io/JvlVp
20:04:41  *** D-HUND is now known as debdog
20:08:41  *** frosch123 has quit IRC
20:09:21  *** urdh has quit IRC
20:09:55  *** urdh has joined #openttd
20:13:47  <TrueBrain> glx: will check it in a sec :)
20:22:20  *** jottyfan has joined #openttd
20:22:41  <TrueBrain> glx: the release job attached to it failed
20:22:45  <TrueBrain> with a very weird error :) I will check it out
20:23:04  *** jottyfan has quit IRC
20:24:49  <TrueBrain> seems the AWS API made a boo-boo
20:25:55  <EER> TrueBrain: when I use azure devops in my day-job, there's a button to just retry the deployment. Might have just been a fluke with aws :)
20:28:35  <TrueBrain> yeah, I know :) But first I needed to check out why it failed :P
20:28:39  <TrueBrain> but there should be no reason
20:31:05  <TrueBrain> uploading now
20:31:24  <TrueBrain> well, a first time for everything I guess :) First time I have seen it fails because AWS is acting up :)
20:31:31  <TrueBrain> on DO this happened almost every other week
20:31:33  <TrueBrain> so I cannot complain
20:31:35  <TrueBrain> still weird ;)
20:32:14  <EER> very :)
20:32:50  <TrueBrain> I always say: 1 error is no error, so, lets see if it ever happens again :)
20:33:03  <TrueBrain> glx: https://cdn.openttd.org/openttd-nightlies/2020/20200607-master-g90e849198f/
20:33:18  <EER> That's usually my first approach to troubleshooting build failures, try again first, if it fails ... investigate :)
20:34:23  <glx> nice
20:35:12  <TrueBrain> and tnx EER ; was not reading chat tbh, but you were spot on ;)
20:36:40  <EER> np)
20:36:49  <Yexo> While the upload to AWS step is the one that failed, the "Download artifact - bundles - bundles" step apparently took 18h on the failed attempt
20:36:52  <Yexo> That looks fishy
20:38:38  <Yexo> 2020-06-07T18:16:18.4920685Z ##[section]Starting: Upload to AWS
20:38:39  <Yexo> 2020-06-06T23:56:21.9629075Z ##[section]Finishing: Upload to AWS
20:38:48  <Yexo> Time in logs goes backwards
20:39:47  <Yexo> Oh well, not worth spending more time on, still interesting
20:44:43  *** Wormnest has joined #openttd
20:45:48  <DorpsGek_III> [OpenTTD/OpenTTD] MiguelHorta opened pull request #8209: Fix: Display banlist's indexes correctly https://git.io/JfDNJ
20:50:05  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh approved pull request #8209: Fix: Display banlist's indexes correctly https://git.io/JfDN3
20:57:00  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro merged pull request #8209: Fix: Display banlist's indexes correctly https://git.io/JfDNJ
21:08:57  <DorpsGek_III> [OpenTTD/OpenTTD] Yexo commented on pull request #8208: Cleanup: More documentation fixes https://git.io/JfDN5
21:11:23  *** Yexo has quit IRC
21:16:23  *** Wolf01 has quit IRC
21:18:44  *** supermop_Home_ has quit IRC
21:25:49  *** Samu has quit IRC
21:30:22  *** iSoSyS has quit IRC
21:33:28  *** gelignite has quit IRC
21:40:25  *** nielsm has quit IRC
21:47:55  *** y2kboy23 has quit IRC
21:50:13  *** y2kboy23 has joined #openttd
22:01:47  *** jottyfan has joined #openttd
22:03:57  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 opened pull request #8210: Fix: MacOS bundle creation (again) https://git.io/JfDpk
22:06:18  *** jottyfan has quit IRC
22:11:53  *** arikover has quit IRC
22:12:36  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 updated pull request #8210: Fix: MacOS bundle creation (again) https://git.io/JfDpk
22:12:54  *** sla_ro|master has quit IRC
22:13:32  *** Progman has quit IRC
22:16:48  <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz commented on pull request #8208: Cleanup: More documentation fixes https://git.io/JfDpK
22:17:42  *** andythenorth has quit IRC
22:21:18  <DorpsGek_III> [OpenTTD/OpenTTD] techgeeknz updated pull request #8208: Cleanup: More documentation fixes https://git.io/JfDZF
22:26:50  *** keoz has quit IRC
22:32:02  *** y2kboy23 has quit IRC
22:33:41  *** y2kboy23 has joined #openttd
22:44:56  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 updated pull request #8210: Fix: MacOS bundle creation (again) https://git.io/JfDpk
23:03:11  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on issue #8204: cmake: make install DESTDIR="something" ignores GLOBAL_DIR option https://git.io/JfM9j
23:07:02  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 updated pull request #8210: Fix: MacOS bundle creation (again) https://git.io/JfDpk
23:25:37  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 updated pull request #8210: Fix: MacOS bundle creation (again) https://git.io/JfDpk
23:40:13  <DorpsGek_III> [OpenTTD/nml] glx22 commented on pull request #78: Add: optimise switches https://git.io/JfyvT
23:50:17  <spnda> https://imgur.com/a/jGNaUQx
23:50:21  <spnda> NotRoadStops nearly done?
23:56:10  <DorpsGek_III> [OpenTTD/OpenTTD] nikolas opened pull request #8211: Fix #8104: always add WINDOW_RESIZABLE flag to SDL2 https://git.io/Jfyvr

Powered by YARRSTE version: svn-trunk