Config
Log for #openttd on 25th September 2020:
Times are UTC Toggle Colours
00:08:48  *** tokai|noir has joined #openttd
00:08:48  *** ChanServ sets mode: +v tokai|noir
00:15:50  *** tokai has quit IRC
00:17:32  *** tokai has joined #openttd
00:17:32  *** ChanServ sets mode: +v tokai
00:24:18  *** tokai|noir has quit IRC
02:32:52  *** debdog has joined #openttd
02:36:13  *** D-HUND has quit IRC
02:38:04  <azubieta> Hello folks! I took the liberty of including my OpenTTD AppImage on appimagehub.org, I can transfer it to you if you want.
02:38:04  <azubieta> Here is the link https://www.pling.com/p/1425360/
02:40:38  <DorpsGek_III> [OpenTTD/OpenTTD] azubieta commented on issue #8019: AppImage support https://git.io/Jv0hG
02:45:14  *** Flygon has joined #openttd
03:02:56  *** tokai|noir has joined #openttd
03:02:56  *** ChanServ sets mode: +v tokai|noir
03:09:42  *** tokai has quit IRC
03:32:37  *** snail_UES_ has quit IRC
03:37:50  *** snail_UES_ has joined #openttd
03:39:54  <DorpsGek_III> [OpenTTD/OpenTTD] no1wafer opened issue #8316: Sorting of produced cargo for industries with multiple products are inaccurate https://git.io/JUaUm
03:45:58  *** snail_UES_ has quit IRC
05:45:37  *** andythenorth has joined #openttd
05:48:55  *** snail_UES_ has joined #openttd
05:57:58  *** nielsm has joined #openttd
05:59:27  *** andythenorth has quit IRC
06:02:42  *** sla_ro|master has joined #openttd
06:06:27  *** andythenorth has joined #openttd
06:40:47  *** Gustavo6046 has quit IRC
07:05:29  *** WormnestAndroid has quit IRC
07:05:42  *** WormnestAndroid has joined #openttd
07:25:28  *** andythenorth has quit IRC
07:52:50  <DorpsGek_III> [OpenTTD/OpenTTD] Galigator opened pull request #8317: Change: Service at depot resets breakdown chance https://git.io/JUamd
07:53:18  <DorpsGek_III> [OpenTTD/OpenTTD] Galigator commented on pull request #8286: Change: Service depot also reset breakdown chance. https://git.io/JUamF
07:53:19  <DorpsGek_III> [OpenTTD/OpenTTD] Galigator closed pull request #8286: Change: Service depot also reset breakdown chance. https://git.io/JJgj9
08:02:06  *** andythenorth has joined #openttd
08:04:39  *** andythenorth has quit IRC
08:38:54  *** b_jonas has quit IRC
09:23:48  <FLHerne> azubieta: Consider opening a PR adding the appimage build files to the main source tree
09:24:16  <FLHerne> (and maybe even an action to build a nightly appimage on push and do...something with it)
09:24:33  <FLHerne> TrueBrain might have some idea what 'something' should be, I don't :p
09:33:51  <DorpsGek_III> [OpenTTD/OpenTTD] michicc commented on pull request #8286: Change: Service depot also reset breakdown chance. https://git.io/JUaG2
09:39:07  <michi_cc> What's the most-used app package on Linux anyway? Is it AppImage, or Flatpack or Snap or something else? It would definitely be an appropriate replacement for the old universal linux binaries.
09:41:10  <LordAro> i still think actual generic linux binaries would be better
09:41:33  <LordAro> just needs someone to spend time setting up a centos6 image
10:18:28  <FLHerne> michi_cc: AppImage is the only one that works out-of-the-box everywhere
10:19:46  <FLHerne> Snap is pretty much Ubuntu only (it's a NIH version of Flatpak in the same way Mir was of Wayland)
10:22:19  <FLHerne> Flatpak is fairly common, but unlike AppImage the client needs to have the tools/support installed separately
10:22:25  <FLHerne> Which isn't universal yet
10:24:21  <FLHerne> I'm already mucking about with CentOS 6 images having got stuck with making the next KDevelop release, if I learn anything I might look at building OTTD in it
10:30:55  *** Gustavo6046 has joined #openttd
10:58:06  <DorpsGek_III> [OpenTTD/OpenTTD] stormcone commented on issue #8316: Sorting of produced cargo for industries with multiple products are inaccurate https://git.io/JUaUm
11:28:49  *** andythenorth has joined #openttd
11:29:19  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro opened pull request #8318: Fix: Compile warnings when asserts are disabled https://git.io/JUal2
11:30:30  <DorpsGek_III> [OpenTTD/OpenTTD] no1wafer commented on issue #8316: Sorting of produced cargo for industries with multiple products are inaccurate https://git.io/JUaUm
11:41:32  <LordAro> cmake poll: "endif()" or "endif ()" ?
11:52:00  <FLHerne> LordAro: Whatever you use for `if`
11:52:06  <FLHerne> Here it's no space for either
11:52:55  <FLHerne> Which agrees with the CMake docs https://cmake.org/cmake/help/latest/command/if.html
11:52:59  <LordAro> hmm, most of OTTD ifs use `if (foo)`
11:53:32  <LordAro> all the "standard" statements have no spaces, wheras the "control" statements do
11:54:00  <FLHerne> In theory, I think `if()` in CMake is actually a command, it's not syntactically special
11:54:09  <FLHerne> Hence the no-spaces
11:54:30  <FLHerne> But it's a bit weird, which is why I don't think it matters so long as it's consistent
11:54:35  <LordAro> mm
11:57:42  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro opened pull request #8319: Codechange: Make codestyle for CMake files consistent for 'control' statements https://git.io/JUa4Z
11:57:46  <LordAro> go argue there ^ :)
12:02:50  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on pull request #8319: Codechange: Make codestyle for CMake files consistent for 'control' statements https://git.io/JUa4r
12:03:32  <DorpsGek_III> [OpenTTD/OpenTTD] FLHerne commented on pull request #8319: Codechange: Make codestyle for CMake files consistent for 'control' statements https://git.io/JUa41
12:04:39  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on pull request #8315: Codechange: Set CMAKE_BUILD_TYPE to default to debug if not otherwise set https://git.io/JUa4y
12:49:10  *** Feuersalamander has quit IRC
12:49:49  *** grossing has quit IRC
12:57:08  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro updated pull request #8319: Codechange: Make codestyle for CMake files consistent for 'control' statements https://git.io/JUa4Z
12:58:26  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #8317: Change: Service at depot resets breakdown chance https://git.io/JUa0O
12:58:50  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #8319: Codechange: Make codestyle for CMake files consistent for 'control' statements https://git.io/JUa0s
13:10:13  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on pull request #8319: Codechange: Make codestyle for CMake files consistent for 'control' statements https://git.io/JUa0H
13:11:32  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #8319: Codechange: Make codestyle for CMake files consistent for 'control' statements https://git.io/JUaEC
13:21:14  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro updated pull request #8319: Codechange: Make codestyle for CMake files consistent for 'control' statements https://git.io/JUa4Z
13:21:52  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #8319: Codechange: Make codestyle for CMake files consistent for 'control' statements https://git.io/JUauv
13:28:43  *** WormnestAndroid has quit IRC
13:28:50  <DorpsGek_III> [OpenTTD/OpenTTD] stormcone opened pull request #8320: Fix 70f9c3c6: Variable type https://git.io/JUauV
13:28:50  *** WormnestAndroid has joined #openttd
13:32:43  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on pull request #8320: Fix 70f9c3c6: Variable type https://git.io/JUazZ
13:34:16  <DorpsGek_III> [OpenTTD/OpenTTD] FLHerne commented on issue #8310: when I logged in to 1M city mania the error window pops up... https://git.io/JU0EE
13:39:57  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 approved pull request #8319: Codechange: Make codestyle for CMake files consistent for 'control' statements https://git.io/JUazH
13:42:58  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro commented on issue #8310: when I logged in to 1M city mania the error window pops up... https://git.io/JU0EE
13:43:16  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro merged pull request #8319: Codechange: Make codestyle for CMake files consistent for 'control' statements https://git.io/JUa4Z
13:50:54  *** Feuersalamander has joined #openttd
13:51:53  <DorpsGek_III> [OpenTTD/OpenTTD] stormcone updated pull request #8308: Feature: Add cargo filter support to vehicle list. https://git.io/JU4lE
13:56:49  *** grossing has joined #openttd
14:02:24  <andythenorth> well
14:04:41  <andythenorth> I have like 1 hour of freedom, no work, no kids, no chores
14:04:45  <andythenorth> what shall I waste it on?
14:07:02  <LordAro> tanks
14:09:42  <andythenorth> yup
14:09:45  <andythenorth> most likely
14:17:58  <DorpsGek_III> [OpenTTD/OpenTTD] stormcone updated pull request #8320: Fix 70f9c3c6: Variable type https://git.io/JUauV
14:18:58  <DorpsGek_III> [OpenTTD/OpenTTD] stormcone commented on pull request #8320: Fix 70f9c3c6: Variable type https://git.io/JUa2p
14:21:48  *** WormnestAndroid has quit IRC
14:22:31  *** WormnestAndroid has joined #openttd
14:26:33  <DorpsGek_III> [OpenTTD/OpenTTD] stormcone updated pull request #8308: Feature: Add cargo filter support to vehicle list. https://git.io/JU4lE
14:35:22  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro approved pull request #8320: Fix 70f9c3c6: Variable type https://git.io/JUaa6
14:35:51  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro merged pull request #8320: Fix 70f9c3c6: Variable type https://git.io/JUauV
14:47:48  *** Feuersalamander has quit IRC
14:51:57  *** Feuersalamander has joined #openttd
15:09:55  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 approved pull request #8315: Codechange: Set CMAKE_BUILD_TYPE to default to debug if not otherwise set https://git.io/JUawW
15:24:54  *** Progman has joined #openttd
15:26:16  *** matt21347 has joined #openttd
15:57:10  <LordAro> TrueBrain: for some reason i'm looking at converting OTTD to GH actions. Don't really know what i'm doing. Currently it uses an "entrypoint" to execute cmake/make/test, but wouldn't that be better as individual run steps?
15:57:17  <LordAro> s/it/the docker images/
16:09:46  <dwfreed> each RUN statement in a Dockerfile is another layer, and is also cached
16:13:53  *** n00b has joined #openttd
16:14:05  <n00b> i ahve a question about NML
16:14:10  <DorpsGek_III> [OpenTTD/CompileFarm] LordAro commented on issue #14: Commit checker should verify generated files are updated correctly https://git.io/JUaKK
16:14:10  <DorpsGek_III> [OpenTTD/CompileFarm] LordAro closed issue #14: Commit checker should verify generated files are updated correctly https://git.io/JUaKK
16:14:27  <n00b> does NML support 32 bit integer arithmetic ?
16:14:50  <LordAro> dwfreed: yeah, i mean the ENTRYPOINT - it currently runs https://github.com/OpenTTD/CompileFarm/blob/master/ci-linux-amd64-clang-3.9/files/run.sh
16:15:22  <LordAro> whereas i'm suggesting baking that into the GH Action steps where it's more obvious, rather than hidden away in a sh file in another repo
16:19:48  *** snail_UES_ has quit IRC
16:21:22  <FLHerne> n00b: No
16:21:54  <FLHerne> n00b: You can do whatever you want in constant expressions, they're computed by NML before generating the grf
16:22:11  <n00b> i mean expressions in switch statements
16:23:30  <n00b> example: STORE_TEMP(LOAD_TEMP(8) * 100, 9)
16:23:58  *** snail_UES_ has joined #openttd
16:23:59  <FLHerne> Sorry, I think I was misreading the spec
16:24:17  <n00b> if storage 8 has like 1000
16:24:24  <n00b> it should or should not overflow
16:24:55  <n00b> NewGRFs are allowed to operate and store 32bit integers
16:24:56  <FLHerne> I was wrong before, that should be fine
16:25:11  <n00b> ok ok
16:25:17  <n00b> thank you very much
16:25:23  <FLHerne> Er, hang on
16:25:25  <n00b> can you tell me what spec did you read tho
16:25:39  <FLHerne> No, that is fine
16:25:44  <n00b> cuz i was unable to find confirmation on my own
16:25:55  <FLHerne> https://newgrf-specs.tt-wiki.net/wiki/Storages
16:26:19  <n00b> oh you are reading openttd spec, i see
16:26:22  <FLHerne> NML specs kind of suck, but mostly it just maps onto the closest NFO values
16:26:34  <n00b> yep i noticed
16:26:49  <FLHerne> There's some magic in NML, but only for fairly unusual stuff
16:26:52  <n00b> they dont even mention what size integers they operate on
16:26:58  <n00b> ok i see
16:27:03  <n00b> thank you again
16:37:20  <andythenorth> does it matter how many bits in most cases?
16:40:56  <n00b> yep
16:40:59  <FLHerne> Well, if it was 16 bits, 100k would be too big
16:42:01  <n00b> indeed
16:42:10  <n00b> but it seems it has 32bits
16:42:31  <n00b> so should be fine, anyways i will test it now
16:44:10  <LordAro> https://github.com/LordAro/OpenTTD/runs/1166977717?check_suite_focus=true#step:4:105 i'm doing something wrong ... it can't find the checkout's version for some reason... and it can't find opengfx that's definitely been installed in the container
16:44:51  *** frosch123 has joined #openttd
16:49:22  *** Flygon has quit IRC
16:53:55  *** HerzogDeXtEr has joined #openttd
17:00:26  *** Wolf01 has joined #openttd
17:07:02  <andythenorth> hmm, GS editing time :)
17:07:14  * andythenorth has to learn how that works
17:12:25  <andythenorth> hmm, can't figure it out :)
17:12:27  <andythenorth> oh dear
17:21:33  *** Lejving has joined #openttd
17:23:55  *** b_jonas has joined #openttd
17:27:46  *** Progman has quit IRC
17:34:18  *** WormnestAndroid has quit IRC
17:34:46  *** WormnestAndroid has joined #openttd
18:03:13  *** WormnestAndroid has quit IRC
18:04:01  *** WormnestAndroid has joined #openttd
18:05:20  <frosch123> it also didn't find grfcodec
18:27:47  <LordAro> frosch123: that's not unexpected
18:34:17  *** Wormnest has joined #openttd
19:02:03  *** n00b has quit IRC
19:04:58  <andythenorth> this steam engine is not even as tall as a person https://railpictures.net/photo/749057/
19:05:00  <andythenorth> how odd
19:07:11  <frosch123> everyone knows steam engines were invented by dwarfs
19:09:42  <TrueBrain> LordAro: correct, you can use the Docker to execute commands in the workdir on the host, by volume mounting it in the docker, en executing one command at the time
19:09:50  <TrueBrain> means you can remove the entrypoint.sh completely
19:12:44  <LordAro> TrueBrain: and you'd say that's a good thing?
19:12:56  <LordAro> TrueBrain: and any ideas about it not being able to find opengfx?
19:13:11  <TrueBrain> it would mean the containers would only need to contain the compiler, so that would make them easier
19:13:36  <TrueBrain> I am not sure you understood what "container" does in GitHub Actions
19:13:44  <TrueBrain> but I suspect you are compiling OpenTTD on a GitHub runner
19:13:52  <TrueBrain> which .. doesn't have OpenGFX installed :P
19:14:14  <LordAro> there is that possibility
19:14:27  <TrueBrain> I didn't even know you could start containers, I have to say :D
19:14:31  <TrueBrain> let me read up on how they work
19:14:39  <LordAro> but i'm not sure what else that "global" container definition would work...
19:14:49  <LordAro> s/what else/how else/
19:14:53  <TrueBrain> docs say for things like MySQL etc
19:15:01  <TrueBrain> so you can connect to them
19:15:09  <LordAro> hmm
19:15:52  <TrueBrain> no, sorry, I am confusing it with services
19:16:01  <TrueBrain> let me read some more .. docs are a bit unclear :D
19:17:13  <TrueBrain> funny, it starts the container with a "tail -f /dev/null" operation :D
19:17:19  <TrueBrain> (to keep it alive, I guess)
19:17:49  <TrueBrain> the container statement does what you expect
19:17:51  <TrueBrain> which is very cool
19:17:54  <TrueBrain> I did not know that existed
19:18:03  <TrueBrain> the volume mount you have, however, "deinstalls" OpenGFX :)
19:18:11  <TrueBrain> basically, you mount an empty folder from the host to the container
19:18:14  <TrueBrain> making that folder completely empty
19:19:10  <TrueBrain> okay, this is very cool use of GitHub Actions :)
19:19:19  <TrueBrain> it even allows you to skip the CompileFarm containers
19:19:24  <TrueBrain> and just use ubuntu:16.04 for example
19:19:31  <TrueBrain> and do the "apt install" actions
19:19:38  <TrueBrain> which would be even sweeter
19:20:09  <TrueBrain> that it does not detect the version is correct, and it even tells you why :)
19:20:17  <TrueBrain> The repository will be downloaded using the GitHub REST API
19:20:17  <TrueBrain> To create a local Git repository instead, add Git 2.18 or higher to the PATH
19:20:26  <TrueBrain> it downloads an archive, which does not contain a .git folder
19:20:40  <TrueBrain> but seriously, very cool find, I did not know this existed
19:24:29  <TrueBrain> what also might help you greatly, is this: https://github.blog/changelog/2020-08-07-github-actions-composite-run-steps/
19:28:39  <TrueBrain> LordAro: I think you can even use a matrix to run for all the different OSes in a single yml file :)
19:28:41  <TrueBrain> pretty sweet
19:29:08  <LordAro> :)
19:29:12  <LordAro> thanks
19:29:36  <TrueBrain> no clue how you are going to get Git 2.18 on 16.04 ..
19:29:49  <TrueBrain> do the checkout on the host, not on the container, I would guess
19:30:09  <LordAro> not particularly concerned by the OS for standard CI
19:31:03  <LordAro> re: removing compilefarm containers - would make it slower, due to having to redownload the dependencies everytime?
19:31:17  <LordAro> or perhaps not worth worrying about?
19:31:23  <TrueBrain> yes; slower, sure
19:31:25  <TrueBrain> but also always the latest
19:31:28  <TrueBrain> so mostly useful for releases
19:31:34  <LordAro> mm
19:31:36  <TrueBrain> for CI, honestly, it might be best to skip containers
19:31:41  <TrueBrain> and just run it on the runners
19:31:49  <TrueBrain> that is quickest
19:31:54  <LordAro> aye
19:32:17  <TrueBrain> the apt install for our dependencies might take some time
19:32:25  <TrueBrain> but I doubt it is slower than fetching the container
19:32:56  <TrueBrain> https://docs.github.com/en/free-pro-team@latest/actions/reference/specifications-for-github-hosted-runners#supported-software
19:33:03  <TrueBrain> you can pick which Ubuntu version you want even
19:33:24  <TrueBrain> GNU C++ 7, 8 and 9 are installed, and CLang 10, 9 and 8
19:33:34  <TrueBrain> so that gives you a wide variety
19:33:44  <TrueBrain> https://github.com/actions/virtual-environments/blob/main/images/linux/Ubuntu2004-README.md
19:35:15  <LordAro> not exactly "gcc 6 & clang 3.9" :p
19:35:37  <TrueBrain> 2014 called, they want their compilers back
19:35:54  <TrueBrain> it is the CI; you would think newer versions catch more problems :D
19:36:02  <LordAro> but these days, as long as we're actually setting -std=c++11, shouldn't have any compatibility issues
19:36:20  <TrueBrain> otherwise the nightly would catch those, honestly
19:36:39  <TrueBrain> https://github.com/OpenTTD/CompileFarm/blob/master/base-linux/Dockerfile <- so you mainly have just a few of those to instll
19:36:41  <TrueBrain> not even that whole list
19:36:48  <LordAro> yeah
19:36:59  <LordAro> why is git 2.18 necessary?
19:37:08  <TrueBrain> something GitHub says
19:37:14  <TrueBrain> I think it is the first version with v2 protocol support?
19:37:40  <TrueBrain> TLS 1.3
19:37:50  <LordAro> oh, and those are enforced, presumably?
19:37:54  <TrueBrain>  * Transfer protocol v2 learned to support the partial clone.
19:38:00  <TrueBrain> that is what comes to mind
19:38:08  <TrueBrain> I do not know the reason they say this :D
19:38:27  <TrueBrain> https://github.com/actions/checkout/issues/255
19:39:45  <TrueBrain> so not helpful, that issue :P
19:40:35  <LordAro> not particularly :p
19:40:43  <TrueBrain> https://github.com/actions/checkout/issues/170
19:40:46  <TrueBrain> I was right, v2 protocol
19:41:01  <TrueBrain> it makes the checkouts, especially on OpenTTD, so much quicker :)
19:41:26  <TrueBrain> so yeah, do the checkout on the host and volume mount them in the docker if you like :)
19:41:49  <TrueBrain> it still makes me giggle you volume mounted OpenGFX away :P
19:42:01  <TrueBrain> (sorry)
19:43:02  <LordAro> hang on though, i only added that after failing in the same way the first time
19:45:51  <TrueBrain> Now that is more interesting. Add things like 'ls' to give an idea what is really on the file system etc
19:46:03  <LordAro> mm
19:56:35  <TrueBrain> if you have a run without the volume mount, feel free to link it; I can look with you
20:09:23  *** gelignite has joined #openttd
20:19:02  *** frosch123 has quit IRC
20:30:49  <LordAro> TrueBrain: https://github.com/LordAro/OpenTTD/pull/1/checks?check_run_id=1167870237 there y'go
20:31:03  <LordAro> (it'll fail in a sec)
20:32:16  <LordAro> i'd suggest that there's something weird going on with the regression run, but it's basicaly the same as the existing CI
20:32:46  <LordAro> (although the existing CI does install ogfx into /usr/share & and then redownloads it into /usr/local/share
20:32:49  <LordAro> )
20:39:02  <DorpsGek_III> [OpenTTD/OpenTTD] michicc merged pull request #8317: Change: Service at depot resets breakdown chance https://git.io/JUamd
20:50:09  <DorpsGek_III> [OpenTTD/OpenTTD] LordAro merged pull request #8315: Codechange: Set CMAKE_BUILD_TYPE to default to debug if not otherwise set https://git.io/JU2X4
21:07:22  <LordAro> TrueBrain: i think it's actually not looking in /usr/share/games, only /usr/local/share/games
21:07:29  <LordAro> not sure why yet...
21:07:40  <LordAro> not sure where it's getting any of the search paths from yet...
21:09:52  *** andythenorth has quit IRC
21:11:43  <LordAro> aha
21:12:14  <LordAro> GLOBAL_DATA_DIR
21:12:27  <LordAro> can only have one
21:12:50  <LordAro> /usr/local being the default
21:15:03  *** sla_ro|master has quit IRC
21:15:07  *** Progman has joined #openttd
21:28:13  *** Wolf01 has quit IRC
21:40:19  *** gelignite has quit IRC
22:16:23  *** nielsm has quit IRC
22:21:28  *** Gustavo6046 has quit IRC
23:03:18  *** matt21347 has quit IRC
23:09:28  *** Lejving_ has joined #openttd
23:10:36  *** guru3_ has quit IRC
23:11:26  *** Hobbyboy|BNC has quit IRC
23:11:27  *** Hobbyboy has joined #openttd
23:15:10  *** guru3 has joined #openttd
23:16:25  *** Lejving has quit IRC
23:34:55  *** Progman has quit IRC
23:58:22  *** smoke_fumus has joined #openttd

Powered by YARRSTE version: svn-trunk