Times are UTC Toggle Colours
00:47:18 *** Zuu has quit IRC 08:32:03 *** FLHerne has joined #openttd.dev 08:37:39 *** Supercheese has quit IRC 08:48:45 *** FLHerne has quit IRC 14:30:04 <Belugas> hello 14:37:05 *** ntoskrnl has joined #openttd.dev 15:10:09 *** FLHerne has joined #openttd.dev 16:13:30 *** LordAro has joined #openttd.dev 16:13:31 *** ChanServ sets mode: +v LordAro 16:51:38 *** LordAro is now known as Guest1749 16:51:38 *** LordAro has joined #openttd.dev 16:51:38 *** ChanServ sets mode: +v LordAro 16:56:26 *** Guest1749 has quit IRC 18:03:34 *** FLHerne has quit IRC 18:05:46 *** FLHerne has joined #openttd.dev 18:15:12 *** FLHerne has quit IRC 18:16:16 *** FLHerne has joined #openttd.dev 18:24:56 *** FLHerne has quit IRC 18:28:04 *** frosch123 has joined #openttd.dev 18:28:04 *** ChanServ sets mode: +v frosch123 18:45:03 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r24824 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 19:29:01 *** ntoskrnl has quit IRC 19:57:12 *** Alberth has joined #openttd.dev 19:57:12 *** ChanServ sets mode: +v Alberth 20:00:13 *** FLHerne has joined #openttd.dev 20:02:55 *** FLHerne has quit IRC 20:06:03 *** FLHerne has joined #openttd.dev 20:20:37 *** Eagle_Rainbow has joined #openttd.dev 20:20:37 *** ChanServ sets mode: +v Eagle_Rainbow 20:20:45 <Eagle_Rainbow> Good evening 20:21:03 <Eagle_Rainbow> Alberth: Do you still collect typos? 20:21:32 <Alberth> once in a while I do, yes 20:21:55 <Eagle_Rainbow> so, you currently don't? 20:22:36 <Alberth> :) 20:22:37 <Eagle_Rainbow> Well, I went over the source code with a spell checker - and what should I say: it was quite fertile... 20:22:54 <Alberth> I'd expect that :) 20:23:06 <Eagle_Rainbow> should I send you those diffs or should I go via flyspray? 20:23:36 <Alberth> just add it to flyspray, imho 20:23:44 <Eagle_Rainbow> ok 20:24:06 <Alberth> doc fixes doesn't have high priority :p 20:24:50 <Eagle_Rainbow> I also wouldn't assume that; but not fixing them also isn't an option... 20:25:52 <Alberth> I don't actively look for them, that helps too :p 20:26:19 <Alberth> but yeah, once you found them, you might as well record and fix them 20:27:31 <Eagle_Rainbow> that was the idea... and as the spell checker found them easily... ;) 20:27:48 <Eagle_Rainbow> but sometimes it was hard to guess what was meant :p 20:28:35 <Eagle_Rainbow> http://bugs.openttd.org/task/5394 <-- a set of typos 20:28:51 <michi_cc> Eagle_Rainbow: I hope you used british english and not american :p 20:28:53 <Alberth> the spellchecker doesn't understand Openttd-es, so I assume you got a lot of false positives 20:29:21 <Eagle_Rainbow> Michi_cc: no, although I prefer AE, I tried to make it as BE as I could :) 20:29:30 <Eagle_Rainbow> even switched the spell checker to BE - just for you ;) 20:29:57 <Eagle_Rainbow> Alberth: yes, the false-positive rate was very high --- at the beginning... A user-dict helped a lot in the long run 20:30:37 <Eagle_Rainbow> Just one thing which I was a bit cautious on: 20:30:44 <Eagle_Rainbow> I did not change those "initialization"... 20:30:49 <Alberth> can you also add them all together in an archive (tar or zip), that's easier to download 20:31:07 <Eagle_Rainbow> BE would be (AFAIK) Initialisation, whilst AE is initialization 20:31:16 <Eagle_Rainbow> we have that a thousand times... 20:31:28 <Eagle_Rainbow> Alberth: will do, gimme a sec 20:32:35 <Alberth> np, I am not going to check them tonight 20:32:38 <michi_cc> AE is definitely the more common code dialect, and our source code surely contains lots of Americanisms, but we theoretically write BE. 20:32:52 <Eagle_Rainbow> Alberth: done 20:32:56 <Alberth> thanks 20:33:28 * Alberth thought we wrote C++ :p 20:35:06 <michi_cc> Eagle_Rainbow: BE is actually both, see e.g. http://dictionary.cambridge.org/dictionary/business-english/initialize 20:36:23 <Eagle_Rainbow> well, my eclipse-based spell checker was very picky and only wanted to allow initialise... 20:37:38 <michi_cc> I think -ise is the original british spelling, but as all languages it is changing and -ize is now probably just as common. 20:38:04 <Eagle_Rainbow> ok, then it was a good idea anyway to keep it that way 20:38:23 <Eagle_Rainbow> BTW: those patches - in sum - provide changes on 525 lines... 20:38:49 <Eagle_Rainbow> That's why I tried to cut them into smaller chunks - otherwise the commit would become quite large... 20:40:12 <michi_cc> Interesting, apparently -ize is Oxford history while -ise is Cambridge history. Seems they compete in more than just rowing :) 20:41:32 <Eagle_Rainbow> seems so - and we now can argue, if we want to follow O-AE or C-BE :P 20:41:51 <michi_cc> Also, -ise is used in UK mass media while scientific and and technical writing is more -ize. 20:41:52 <Eagle_Rainbow> s/AE/BE/ 20:42:48 <Eagle_Rainbow> Most likely science is affected more by the AE style 20:45:12 <Alberth> size ofa commit is not so relevant, it is the number of conceptual changes that's important (it should be 1). 20:45:58 <Eagle_Rainbow> well, then my patches don't fit to that rule at all - I hope, the count is zero in this case =:) 20:46:23 <Alberth> fix spell-check errors is not a conceptual change? :) 20:46:51 <Eagle_Rainbow> a very "basic" change, though :) 20:47:27 <Alberth> sure, but like Codechange, you do make a change, even if the functionality stays the same :) 20:50:25 <Eagle_Rainbow> well, but -- typically -- a code change provides a change of the program behaviour (functional-wise or usability or quality or ...); I expect that those typo fixes don't change anything that an end user could experience (except: changes on documentation which are made public for 3rd-party dev) 20:51:21 <Eagle_Rainbow> but anyway... 20:51:49 <Eagle_Rainbow> someone will have a look later - and then some time later I hope this will go to trunk... 20:52:49 *** Zuu has joined #openttd.dev 20:52:49 *** ChanServ sets mode: +v Zuu 20:56:26 <Alberth> with "Codechange" I meant a code change that has no functional change, as explained in http://wiki.openttd.org/Commit_style 21:00:27 * Eagle_Rainbow didn't knew this convention 21:00:48 <Eagle_Rainbow> I am no comitter, so I didn't read that wiki page yet ... 21:03:45 <Eagle_Rainbow> What do you use as "commit type" if you cleaned up a file which was there by error ? "Fix,Remove,Cleanup" ;) 21:04:28 <Alberth> not a fix :) 21:05:13 <Alberth> but it never happened to me so far, and maybe never yet; patches get reviewed so often, we catch those errors earlier :) 21:05:14 <frosch123> Revert? 21:07:11 <Alberth> sounds plausible :) 21:07:56 <frosch123> i think we had several -Revert: part of bla 21:10:36 <Alberth> 5, actually :) 21:11:29 <frosch123> :p 21:21:45 *** Belugas has quit IRC 21:40:56 *** Alberth has left #openttd.dev 21:56:51 *** LordAro has quit IRC 21:59:26 <Eagle_Rainbow> @all: n8 21:59:27 *** LordAro has joined #openttd.dev 21:59:28 *** ChanServ sets mode: +v LordAro 21:59:32 *** Eagle_Rainbow has quit IRC 22:36:14 *** frosch123 has quit IRC 23:07:21 *** LordAro has quit IRC 23:22:06 *** FLHerne has quit IRC