Times are UTC Toggle Colours
01:12:18 *** Supercheese has joined #openttd.dev 09:00:50 *** Alberth has joined #openttd.dev 09:00:50 *** ChanServ sets mode: +v Alberth 09:22:49 *** Supercheese has quit IRC 10:55:59 *** frosch123 has joined #openttd.dev 10:55:59 *** ChanServ sets mode: +v frosch123 11:29:52 *** fonsinchen has joined #openttd.dev 11:29:52 *** ChanServ sets mode: +v fonsinchen 12:47:47 *** frosch123 has quit IRC 12:56:12 *** frosch123 has joined #openttd.dev 12:56:12 *** ChanServ sets mode: +v frosch123 13:40:08 *** fonsinchen has quit IRC 13:49:06 *** ntoskrnl has joined #openttd.dev 13:56:26 <frosch123> http://devs.openttd.org/~frosch/diffs/fs3764/ <- likely the gui is not optimal in all scenarios 13:56:32 <frosch123> but it should work find for now 13:57:29 <frosch123> there might be obscure newgrfs out there which use subtypes in a weird way, so i guess this is only for 1.4 13:57:43 <frosch123> so we have one year time to get those weird grfs reported :p 13:59:37 *** LordAro has joined #openttd.dev 13:59:37 *** ChanServ sets mode: +v LordAro 14:04:51 <Alberth> 20, commit message: -Remove: Ordered refit with subtypes, since the cases where it worked were corner cases rather than the main case. (added , moved 'rather') you may want to consider s/main/general/ 14:17:20 <Alberth> 30 inline bool operator != ( <-- s/ (/(/ (ie remove the space in front of the parenthesis ? (also with ==) 14:18:09 <Alberth> I somewhat wonder whether it would be better to express one of them in the negation of the other one 14:21:34 <frosch123> the operator space coding style is quite inconsistent (as expected), but the space on both sides seems to be the majority 14:23:15 <Alberth> k 14:23:30 <Alberth> 40 last + line needed? 14:27:12 <Alberth> 50 change of 'sel' is not really reflected in the doxygen text, eg "\c -1 if nothing is selected" is sufficient? I'd expect an index, or does it hold for each index separately? 14:35:13 <Alberth> 50 some tests do sel[0] < 0 others do sel[0] == -1 14:36:19 <Alberth> looks good, although I don't understand this subtypes stuff :) 15:07:04 <michi_cc> frosch123: Why not MemMoveT in 40 for the smallvec erase (like http://www.icosahedron.de/openttd/git/newmap.git/commitdiff/ed1e430bc7740f52f3d87ab51187472d4f76c71b)? 15:08:48 <frosch123> over-optimisation :) 15:18:18 <michi_cc> Not totally, in fact. There is a difference if the SmallVector stores something with a custom assignment operator that does surprising things, but then std::list/vector would probably be the better choice anyway. 15:20:44 <frosch123> haha, i meant it the other way around :p 15:20:53 <frosch123> afaik memmove always allocated memory 15:21:06 <frosch123> but since i know in which way the memory overlaps, i can avoid that 15:21:09 <frosch123> and move without conflictr 15:23:48 <frosch123> anyway, updated the diffs 15:25:53 <Alberth> memmove does that? pretty stupid then, imho 15:26:04 <michi_cc> Huh, no, memmove doesn't allocate anything. The one and only difference between memcpy and memmove is that memcpy always copies from low address to high while memmove has a simple of to decide up or down. 15:26:16 <michi_cc> s/of/if/ 15:26:37 <Alberth> that's what I'd expect indeed 15:27:16 <michi_cc> AFAIR in newer glibcs memcpy is simply aliased to memmove anyway. 15:27:18 <frosch123> oh, hmm, the documentation only makes the analogy 15:27:30 <frosch123> it behaves as if it was copied 15:27:56 <frosch123> i guess the conjunctive somehow got lost in my memory :p 15:28:11 <Alberth> the interface of memcpy is probably designed so it can take advantage of hardware features if they exist 15:35:44 <michi_cc> If you'd really want to optimize stuff you could replace ErasePreservingOrder by my Extract and http://paste.openttdcoop.org/show/2134/ (it could potentially save a few array lookups, but other than that it is pretty pointless) :) 15:37:01 <frosch123> ah, thanks for pointing out the wrong & coding style :p 15:37:21 *** fonsinchen has joined #openttd.dev 15:37:21 *** ChanServ sets mode: +v fonsinchen 16:38:51 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25040 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 16:40:11 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25041 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 16:40:50 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25042 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 16:41:44 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25043 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 16:42:05 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25044 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 17:15:35 *** ntoskrnl has quit IRC 17:28:38 *** fonsinchen has quit IRC 18:10:09 <frosch123> tamil is quite glitchy :s 18:10:23 <frosch123> the characters are always drawn in slightly different positions 18:10:34 <frosch123> i have no idea why 18:11:00 <frosch123> i would think we always draw complete liens 18:23:21 <michi_cc> Languages with strange characters are always a problem. Try testing Japanese, last time I looked it had a ten mile long string right in the game options window, which means switching back to English is a PITA. 18:23:47 <frosch123> that's not what i mean 18:24:02 <frosch123> when i switch to tamil some characters are not drawn every time 18:24:07 <frosch123> they disappear and appear again 18:43:45 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25045 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 18:55:09 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25046 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:10:57 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25047 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 20:23:30 *** Supercheese has joined #openttd.dev 20:52:19 <frosch123> hmm, there are no ratings for transfer cargos anymore 20:52:28 <frosch123> is that intentional? 20:52:43 <frosch123> i thought they would vanish if the rating is crap just as well 21:39:02 <frosch123> Alberth: true, transfer credits are no longer displayed 21:39:23 <frosch123> just logging all bugs in this channel :p 21:39:50 <Alberth> k, I wondered why you discuss it here :) 21:41:07 <Alberth> wouldn't a 0 leg percentage do that too ? 21:42:30 <frosch123> no idea, but it is set to 75% 22:00:03 *** frosch123 has quit IRC 22:11:42 *** Alberth has left #openttd.dev 22:27:18 *** Webster has joined #openttd.dev 22:27:18 *** ChanServ sets mode: +v Webster 23:06:11 *** LordAro has quit IRC