Times are UTC Toggle Colours
00:36:23 *** FLHerne has quit IRC 03:02:38 *** Supercheese has joined #openttd.dev 05:25:01 *** Supercheese has quit IRC 05:58:56 *** Zuu has joined #openttd.dev 05:58:56 *** ChanServ sets mode: +v Zuu 07:55:57 *** Alberth has joined #openttd.dev 07:55:57 *** ChanServ sets mode: +v Alberth 08:29:24 *** ntoskrnl has joined #openttd.dev 11:18:17 *** FLHerne has joined #openttd.dev 11:25:08 *** FLHerne has quit IRC 11:47:54 *** FLHerne has joined #openttd.dev 12:13:17 *** frosch123 has joined #openttd.dev 12:13:17 *** ChanServ sets mode: +v frosch123 12:15:51 *** FLHerne has quit IRC 12:19:41 <Zuu> Fix: Updates script_window with the new link graph widgets: http://devs.openttd.org/~zuu/goal-gui/16-graph-fix.patch 12:21:07 <planetmaker> oh indeed 12:21:19 <planetmaker> adding widget gets more and more complicated :-) 12:22:29 <planetmaker> Zuu, looks... funny though. At the end of the patch the same enum is defined...? 12:23:42 <Zuu> In the end of the patch the usual enum is defined. The script_window duplicates all enums for some reason. 12:25:25 <planetmaker> uh... against which OpenTTD should that patch apply? 12:25:37 <planetmaker> not against my trunk head 12:25:58 <planetmaker> hm... or I look in the wrong file :D 12:26:07 <Zuu> Hmm, I forgot to actually re-generate the API too. Patch updated. 12:26:48 <Zuu> My local clone is 2-3 weeks old. I should bring it up to date. :-) 12:27:16 <planetmaker> my comment was really based on looking for the last lines in the wrong file, but yeah :-) 12:28:00 <Zuu> It was just 22 revs behind trunk and no conflicts for that particular patch. 12:32:15 <frosch123> [14:28] <planetmaker> uh... against which OpenTTD should that patch apply? <- you could run the scripts yourself :p 12:34:23 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25331 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 12:35:39 <Zuu> That will make sure I don't include the graph window widgets when I run the script to fix my patcehs to include those changes. :-) 12:36:04 *** FLHerne has joined #openttd.dev 12:37:50 <Alberth> :) 12:43:03 <Zuu> Compiler warning related to the link graph: http://paste.openttdcoop.org/show/2309/ 12:43:21 <frosch123> the compile farm burped 12:44:14 <frosch123> looks like you committed too much 12:44:20 <frosch123> there is also GSStoryPage stuff in it 12:44:34 <frosch123> /bamboo/src/game/game_instance.cpp:173: error: 'SQGSStoryPage_Register' was not declared in this scope 12:45:19 <Zuu> hmm, yes that is clearly an error. I wonder why it exist at the bottom of my patch queue 12:51:59 <Zuu> I'll commit a fix soon, I shall just ensure that the fix compiles. 12:52:17 <Zuu> (in a separate OpenTTD clone to be sure) 12:59:15 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25332 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 13:18:51 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25333 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 13:57:08 *** Alberth has quit IRC 13:57:08 *** Zuu has quit IRC 13:57:08 *** Hirundo has quit IRC 13:57:08 *** michi_cc has quit IRC 13:57:08 *** DorpsGek has quit IRC 13:58:12 *** Alberth has joined #openttd.dev 13:58:12 *** Zuu has joined #openttd.dev 13:58:12 *** Hirundo has joined #openttd.dev 13:58:12 *** DorpsGek has joined #openttd.dev 13:58:12 *** charon.oftc.net sets mode: +vvov Alberth Zuu DorpsGek DorpsGek 13:58:12 *** michi_cc has joined #openttd.dev 13:58:12 *** charon.oftc.net sets mode: +v michi_cc 14:02:05 *** michi_cc has quit IRC 14:02:05 *** Alberth has quit IRC 14:02:05 *** Hirundo has quit IRC 14:02:05 *** Zuu has quit IRC 14:02:05 *** DorpsGek has quit IRC 14:03:25 *** Alberth has joined #openttd.dev 14:03:25 *** Zuu has joined #openttd.dev 14:03:25 *** Hirundo has joined #openttd.dev 14:03:25 *** DorpsGek has joined #openttd.dev 14:03:25 *** charon.oftc.net sets mode: +vvov Alberth Zuu DorpsGek DorpsGek 14:03:25 *** michi_cc has joined #openttd.dev 14:03:25 *** charon.oftc.net sets mode: +v michi_cc 14:34:54 *** frosch has joined #openttd.dev 14:37:55 *** frosch123 has quit IRC 14:49:42 *** frosch_ has joined #openttd.dev 14:51:52 *** DorpsGek sets mode: +v frosch_ 14:51:57 <frosch_> http://paste.openttdcoop.org/show/2312/ <- remove the linkgraph from the scenario editor menu, and add the industry list instead 14:52:14 <frosch_> also fix the linkgraph WindowDesc 14:52:30 *** frosch has quit IRC 15:45:30 <Rubidium> frosch_: looks okay to me 15:58:20 <Zuu> Looks good to me too 16:49:19 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25334 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 16:51:05 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25335 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 17:42:37 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25336 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 18:30:10 <Zuu> Regarding the story book patch queue: the feature patches are 30, 40 and 60. The others are preparations. (#65-70 are not finished yet) 18:30:51 <Zuu> I wonder, should I run the vbs to update the visual studio project files and include those changes into the patches which add files? 18:34:44 <frosch_> it's easier if you do the generated files only shortly before commit 18:35:01 <frosch_> though otoh, merging them is only reverting and regen 18:35:19 <Zuu> ok 18:35:59 <frosch_> oh, hm, or are you acutally using vs? 18:36:00 <Zuu> In that case I'll generate those before commit, but perhaps I can keep the generated API/script file changes. 18:36:29 <Zuu> I use VS, but strip those changes away manually when uploading the patches. 18:36:42 <frosch_> well, then just keep them :) 18:39:46 <Zuu> If we want to start somewhere with getting it to trunk, I'd suggest starting with 20 (story data), 25 (count lines helper) and 30 (story gui). Those form more or less one unit after which the story book is functional and can be used. (but the player has to open it manually and find it in the league menu) 18:41:17 <Zuu> 30 is quite long. If it helps, I can create a variant of 30 that excludes the binary blobs with openttdgui.png and openttd.grf. 18:41:35 *** fonsinchen has joined #openttd.dev 18:41:35 *** ChanServ sets mode: +v fonsinchen 18:44:10 *** FLHerne has quit IRC 18:45:43 <frosch_> the docs in 20 do not seem to be correct anymore 18:45:56 <frosch_> "publishing" and stuff 18:46:55 <Zuu> hmm 18:47:30 <Zuu> yes, that is now wrong 18:47:51 <frosch_> there are also some IsPublishedStoryPage preconditions mentioned 18:48:16 *** FLHerne has joined #openttd.dev 18:49:41 <Zuu> I will remove them and look over the API docs. 18:50:35 <Zuu> I've been looking at this code for so many times that I'm getting blind. :-) 18:52:39 <frosch_> "\ No newline at end of file" <- there are some of those in 20 18:53:01 <Zuu> Is those wrong? 18:53:10 <Zuu> Are* 18:53:21 <frosch_> always put nl at end of file, your editor should have an option for that 18:54:09 <Zuu> I specifically looked over my files to remove the new line as Rubidium said something about them being unwanted, but perhaps I didn't understand what he ment. 18:54:27 <Alberth> the last line should also have a \n 18:54:58 <Alberth> depending on the editor, that either means no empty last line, or an empty last line 18:56:02 <Alberth> make a file with a single line containing a single letter 18:56:27 <Alberth> that file should be 2 bytes for unix EOL conventions, and 3 bytes for windows EOL conventions 18:57:00 <Rubidium> Zuu: I meant it shouldn't have that line saying there is no EOL at EOF 19:01:42 <frosch_> this->SetWidgetsDisabledState(Company::GetNumItems() == 0, WID_TN_STATIONS, WID_TN_FINANCES, WID_TN_TRAINS, WID_TN_ROADVEHS, WID_TN_SHIPS, WID_TN_AIRCRAFTS, WIDGET_LIST_END); <- in 60 that line might need extending for goal and storybook 19:02:10 <frosch_> aw, 70 is boring :p 19:03:24 <Zuu> 60 do not cover hiding and/or making the buttons disabled when they are useless. That will later be added either in 60 or a later patch. 19:03:54 <frosch_> yeah, but you need to disable them in multiplayer, if there are no companies 19:03:58 <frosch_> like the other company-dropdowns 19:04:11 <frosch_> not sure what happens when you try to open a dropdown with zero items :) 19:04:20 <frosch_> i would expect a crash :p 19:04:37 <Zuu> yes 60 needs to disable and hiding could go into 61 or so :-) 19:11:37 <Zuu> 20 do no longer refere to the action of publishing pages. It also now have a \n on the last line. 19:14:08 <Zuu> Hmm this looks interesting: 19:14:09 <Zuu> <Zuu> I use VS, but strip those changes away 19:14:17 <Zuu> delete p; 19:14:17 <Zuu> + 19:14:17 <Zuu> + InvalidateWindowData(WC_STORY_BOOK, p->index); 19:25:02 <Rubidium> that looks bad (tm) ;) 19:33:14 <Zuu> Indeed 19:34:27 <Zuu> A point that my test GS should have tested that command too. 19:38:13 <Rubidium> valgrind ;) 19:38:55 <Zuu> It is indeed good, but the code need to get excuted in order to catch the bug. 20:06:24 <Rubidium> Zuu: 20 has misaligned entries in the saveload tables (tabs vs spaces) 20:07:34 <Zuu> Rubidium: Thanks for pointing that out 20:09:37 <Rubidium> Zuu: <> -> != since that's also used for e.g. text != NULL 20:10:29 <Zuu> possible a mismatch between Delphi and C++/Squirrel 20:12:01 <Rubidium> that reminds me of that joke about hide and seek and Newton and Pascal 20:19:57 *** ntoskrnl has quit IRC 20:21:14 <Zuu> Fixed tabs, and <> of 20. Fixed the bug in the DoCommand when deleting pages. However, I found a bug in the page selector code when you have a hole in the page IDs that needs fixing. 20:44:46 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r25337 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 21:13:19 *** fonsinchen has quit IRC 21:15:49 *** frosch_ has quit IRC 21:23:00 *** Alberth has left #openttd.dev 23:26:23 *** Zuu has quit IRC