Times are UTC Toggle Colours
07:48:29 *** LordAro has joined #openttd.dev 07:48:29 *** ChanServ sets mode: +v LordAro 14:21:09 *** Zuu has joined #openttd.dev 14:21:09 *** ChanServ sets mode: +v Zuu 14:27:53 <Zuu> The goal and story book window exist in one instance per company. All other such windows have their window bar show in the company colour. This patch adds this behaviour to the goal/story window: http://devs.openttd.org/~zuu/5-story-gui-owner.patch 14:29:31 <planetmaker> +1 on that Zuu :-) 14:30:08 <Zuu> It may also fix some bug that I don't remeber anymore in case some other general code depend on this->owner being the company that the window relates to. 14:30:28 <Zuu> Possible removing windows related to a bankrupt company. 15:21:42 <Zuu> Adding the feature of hiding the goal and story button when there is no goal/story page has shown to be quite tricky. Especially if you don't want to make a hacky solution. An alternative solution is to just make the buttons disabled when there is no goal/story page: http://devs.openttd.org/~zuu/goal-gui/64.9-disable-buttons.patch 15:22:39 <Zuu> The current behaviour is that the buttons are disabled only when there are zero companies in the game. 15:23:01 <Zuu> With the patch at least one company need to have a goal/story page for the corresponidng button to be enabled. 15:23:14 <planetmaker> that behaviour makes sense 15:26:02 <Zuu> The new behaviour will enable the goal/story button also when there are zero companies and there exist a global goal/story page. 15:26:33 <planetmaker> sounds sensible, too 15:26:51 <Zuu> I need to check if there is a window to show in that case though. 15:27:18 <Zuu> I suspect that it will show an empty menu in that case now with the patch. 16:11:11 *** frosch123 has joined #openttd.dev 16:11:11 *** ChanServ sets mode: +v frosch123 16:29:08 *** ntoskrnl has joined #openttd.dev 18:17:30 <Zuu> I've updated the patch (for disabling story/goal buttons) so that it now display a "{BLACK}Spectator" option in network games. Otherwise an assert is triggered if there are only global goals/story pages and no companies are in the game. http://devs.openttd.org/~zuu/goal-gui/64.9-disable-buttons.patch 18:21:39 <Zuu> An alternative solution is to include a "Global" option shown in both SP and MP games. The story/goal window will show "Global Story Book" etc. already so that would better follow that title. 18:22:34 *** ntoskrnl has quit IRC 18:22:35 <frosch123> i don't think anyone would want to open that 18:22:44 <frosch123> usually you click the icon directly, instead of the menu 18:22:52 <frosch123> so the global thingie is only needed for spectators 18:23:22 <Zuu> futher more, only for spectators joining a server without companies 18:23:53 <Zuu> If there is a company, the spectator could view the window of some company if it wish. 18:24:03 <frosch123> do you need some invalidate / markdirty in the create goal/page commands? 18:24:10 <frosch123> so that the toolbar button are activated 18:24:26 <Zuu> hmm, that may be needed 18:24:56 <frosch123> PopupMainCompanyToolbMenu could profit from some @param 18:25:08 <Zuu> I've only tested MP so far. Not with a GS that sleeps and later add goals/pages 18:25:49 <frosch123> i think silicon valley creates goals only after company creation 18:26:02 <frosch123> so if you join as spectator there should be no goals yet 19:08:41 <Zuu> Added @param:s to PopupMainCompanyTollbMenu and added calls to invalidate the main toolbar when goals/story pages are created/removed by DoCommands as well as when a company is removed. http://devs.openttd.org/~zuu/goal-gui/64.9-disable-buttons.patch 19:20:17 <frosch123> looks fine to me 21:21:23 *** Supercheese has joined #openttd.dev 21:22:40 *** LordAro has quit IRC 21:23:10 *** LordAro has joined #openttd.dev 21:23:10 *** ChanServ sets mode: +v LordAro 22:19:47 *** Supercheese has quit IRC 22:36:39 *** frosch123 has quit IRC 23:08:19 *** Zuu has quit IRC