Log for #openttdcoop.devzone on 30th August 2011:
Times are UTC Toggle Colours
00:33:30  <Brot6> Central European Train Set - Feature #2924: Prussian steam engines - sprites (oberhuemer) @
01:04:52  <Brot6> Central European Train Set - Feature #2924: Prussian steam engines - sprites (oberhuemer) @
06:50:33  <Brot6> DictatorAI - Revision 174:fcf1b42650bb: - Adapt road code to use new cEngine too (krinn) @
07:57:39  *** ODM has joined #openttdcoop.devzone
09:33:15  <Brot6> OpenGFX+ Landscape - Revision 81:931d1607b97d: Doc: Prepare changelog for 0.2.2 (planetmaker) @
09:33:15  <Brot6> OpenGFX+ Landscape - Revision 82:9b454b339b3b: Added tag 0.2.2 for changeset 931d1607b97d (planetmaker) @
09:35:43  <Brot6> ogfx-landscape: update from 0.2.1 to 0.2.2 done (1 warnings) -
09:48:50  *** Lakie has joined #openttdcoop.devzone
09:55:18  *** ODM has quit IRC
10:37:48  <Brot6> Central European Train Set - Feature #2924: Prussian steam engines - sprites (michi_cc) @
11:32:33  *** Hirundo_web has joined #openttdcoop.devzone
11:32:53  <Hirundo_web> moin
11:34:27  <planetmaker> hi Hirundo_web
11:36:19  <Terkhen> hi Hirundo_web
11:37:25  <Ammler> Hirundo, there is also
11:37:34  <Ammler> so you could use your bouncer with webchat
11:38:25  <Hirundo_web> I know, I just need some time to setup everything correctly after an OS reinstall
11:38:41  <Ammler> hmm, you know?
11:38:47  <Ammler> check the url :-)
11:39:48  <Ammler> it's not
11:40:49  <Hirundo_web> knowing != doing :)
11:42:07  <Ammler> I see :-)
11:44:10  * Hirundo_web ponders passwords
11:45:03  <planetmaker> lengthy is better than complicated ;-)
11:45:20  <Ammler> I have one password I can type
11:45:34  <Ammler> the rest is somehow on the filesystem
11:46:09  <Hirundo_web> I seem to have enough variety in my pw choices to make brute-forcing my own pw hard
11:46:32  <planetmaker> :-)
12:14:53  <Hirundo_web> Where was the znc config screen located again?
12:16:02  <^Spike^> https://bnc.....:6697
12:39:58  <Hirundo_web> hmm... would it be possible to do a password reset?
12:47:53  <Ammler> new pw "/msg"d
12:53:40  <Hirundo> fixed again, thanks Ammler
12:54:35  <Ammler> hehe, since yesterday, you are again on the most stable bouncer around :-)
12:55:56  <Hirundo> what's so special about yesterday?
12:56:07  *** Hirundo_web has quit IRC
12:56:10  <Ammler> we fixed our memory issue
12:56:29  <Hirundo> no more OOM?
12:56:32  <Ammler> didn't you notice the almost daily downtime of our server?
12:56:52  <Hirundo> I did
12:57:41  <Ammler> when our kernel reached memory limits, he swapped active memory instead cleaning cache
12:57:54  <Ammler> and so IO got crazy
12:58:16  <Ammler> now I changed swappiness to 0 and it does first remove some cache before swapping
12:59:26  <Ammler> somehow the openvz patch broke the kernel capability to detect active app memory
13:01:07  <Yexo> that rather seems like a workaround than a fix: what is causing the high memory usage in the first place?
13:01:33  <Ammler> Yexo: that is usual linux behavior
13:01:43  <Ammler> kernel uses free memory for cache
13:02:24  <Ammler>
13:03:58  <Yexo> looks like it's still using the swap
13:07:44  <Ammler> yes
13:07:49  <Ammler> I didn't disable swap
13:08:00  <Ammler> I just changed the swappiness :-)
13:08:11  <Ammler> (how kernel should swap)
13:08:34  <Ammler> it does still swap inactive app memory
13:09:47  <Ammler>
13:09:48  <Webster> Title: Linux Howtos: System -> Linux Memory Management (at
13:10:17  <Ammler> and yes, it is a workaround because we use openvz patched kernel
13:10:40  <Ammler> the most stable openvz kernel is .18, we use .32
13:14:09  <^Spike^> still have to see it :)
13:54:50  <Terkhen> why do we need STR_GENERIC_NEWLINE? (FIRS)
13:55:09  <Terkhen> and there is also a STR_GENERIC_D0B2 string
14:04:57  <Terkhen> planetmaker^
14:25:19  <planetmaker> I guess we currently don't really need it / them
14:25:26  <planetmaker> did you check their usage?
14:25:30  <planetmaker> if not used: just remove them
14:25:44  <planetmaker> ^ Terkhen
14:35:34  <Terkhen> STR_GENERIC_NEWLINE is used at text templates, STR_GENERIC_D0B2 is not used at all
14:36:29  <planetmaker> then the newline string is used as place holder for undefined strings. Thus we might want to keep it
14:43:44  <Brot6> Unrealistic Trainset - Feature #3017 (New): Maglev Hopper Wagons (V453000) @
15:13:48  <Brot6> DictatorAI - Revision 175:9f8cbb1f61a9: - Change a bit jobs pricing for trains as we need more ra... (krinn) @
15:37:15  <Brot6> Unable to connect to execution expired
15:38:49  <Brot6> Central European Train Set - Feature #3013: Early steam engines (oberhuemer) @
15:38:49  <Brot6> Central European Train Set - Feature #2924: Prussian steam engines - sprites (oberhuemer) @
15:42:41  <Brot6> Central European Train Set - Feature #3013: Early steam engines (Eddi) @
15:47:29  <Hirundo> planetmaker: You're editing the stringcode page currently?
15:49:00  <planetmaker> yes
15:49:27  <planetmaker> though I'm actually done now
15:49:55  <planetmaker> for the rest I'd have to do some research how it actually works in detail - if you know it, please go ahead
15:52:25  <planetmaker> hm, just added a small note that the cases, genders and number of plural forms should best be looked up in the language files themselves :-)
15:54:04  <Hirundo> Actually I'd like to do a bit of pruning wrt. the available string codes
15:54:25  <planetmaker> please go ahead now
15:55:10  <Hirundo> It needs some discussion first though, not in the least because it might/will break existing grfs
15:55:29  <planetmaker> hm, in what way?
15:55:38  <planetmaker> want to change them?
15:55:49  <planetmaker> they currently should match OpenTTD's ones exactly
15:56:36  <planetmaker> I'd not deviate from that, if not necessary
15:57:07  <Hirundo> They don't match OpenTTD's still in many cases
15:57:24  <planetmaker> hm, not? Then go ahead at adjusting
15:57:25  <Hirundo> for example DWORD_S, WORD_S_TONNES etc is not in OpenTTD
15:57:46  <planetmaker> there's no equivalent then, is there?
15:57:47  <Hirundo> I added a diff at #1848 a week ago
15:57:48  <Brot6> Hirundo: #1848 is "NewGRF Meta Language - Feature Request #1848: string codes - #openttdcoop Development Zone"
15:57:55  <Hirundo> WORD_S_TONNES could just be WEIGHT
15:58:02  <Brot6> Central European Train Set - Feature #2924: Prussian steam engines - sprites (Eddi) @
15:58:25  <Hirundo> and basically I'd like to rip out all the stuff that no-one should be using anyways
16:00:01  <planetmaker> well. Probably the only one you'll break is FIRS. Which I'd not be worried about
16:05:58  *** frosch123 has joined #openttdcoop.devzone
16:07:38  <Hirundo> Yexo: What do you think of renaming string codes like in this diff?
16:09:03  <Hirundo> frosch123: I noticed your comment about railtype default action2 in the backlog. As usual you are right, NML already does the right thing though
16:10:35  <frosch123> great :)
16:11:30  <frosch123> you should never write into some spec, that something is ignored or does not matter. else everyone will do something random with it :p
16:11:44  <planetmaker> :-)
16:12:15  <planetmaker> q.e.d. ;-)
16:13:15  <Hirundo> W.r.t. callback failures (, how does that work for houses/objects etc?
16:14:12  <frosch123> it needs to be a spritelayout
16:14:19  <frosch123> for industries it needs to be a production callback
16:14:27  <Hirundo> Currently NML fails callbacks by referring to a non-existant action2, I'd like a method that works just as well but without all the debug messages
16:15:04  <frosch123> somewhere i reference a page on the wiki which shall explain callback failure, but that page is not written :p
16:15:22  <frosch123> ah, yes, on even that page
16:15:48  <frosch123> anyway, the action2 is sadly feature specific
16:16:13  <planetmaker> maybe nfo8 will change that :-P
16:16:21  <frosch123> unlikely
16:16:23  <frosch123> :p
16:17:11  <Hirundo> So you can fail a callback by returning a 'normal' result, but can you also fail the graphics(/layout, production) callback by returning a CB result?
16:17:22  <frosch123> yes
16:17:47  <Yexo> is there a reason to ever fail the graphics?
16:18:01  <Hirundo> To fall back to default graphics
16:18:24  <frosch123> Yexo: if you want to use industry tile callbacks, but use the default graphics
16:18:44  <Hirundo> IIRC swedishrails uses it for default fences
16:19:06  <frosch123> though i am actually not sure whether that works in all cases
16:19:29  <frosch123> original industry tiles store stuff in other locations in the map array or so
16:20:45  <planetmaker> swedishrails should just not define its own fences when asked to use default
16:21:02  <planetmaker> rails don't yet have callbacks, do they?
16:21:37  <Yexo> Hirundo: your diff is (a little bit) outdated due to planetmakers last commit
16:21:43  <Hirundo> Yexo: I know
16:22:02  <Yexo> looks ok, but will take a better look in like half an hour
16:22:25  <Hirundo> planetmaker: The way you choose to define callbacks (conditional if/else on graphics blocks) is actually not supported
16:22:57  <Hirundo> It works for railtypes because of the particular way railtype action3 works, but not for any other feature
16:30:46  <planetmaker> Hirundo, I can't put graphics blocks into if...then...else constructs?
16:31:03  <Hirundo> no, generally not
16:31:32  <planetmaker> how would I get default fences then?
16:31:40  <Hirundo> CB_FAILED-ing the fence CB
16:31:45  <planetmaker> when not putting the if condition there? hm...
16:31:52  *** FooBar has joined #openttdcoop.devzone
16:31:56  <planetmaker> same for GUI then would also be proper, yes?
16:32:01  <Hirundo> yes
16:33:27  <Yexo> Hirundo: HEX -> perhaps HEX_DWORD ?
16:34:00  <Hirundo> I'd like to do away with all the [|Q|D]WORD stuff
16:34:32  <Yexo> that's hardly possible
16:34:39  <Yexo> the stack space is quite limited
16:34:39  <Hirundo> The argument size only really matters when using the text reference stack, i.e. for a dozen callbacks or so
16:34:46  <Yexo> sometimes to 4 dwords, sometimes to 6
16:35:01  <Yexo> when not using the text reference stack most of these codes are not useable at all
16:35:37  <Hirundo> W/o stack they can be used where openttd expects them, cargo strings for example
16:36:02  <Yexo> hmm, true
16:36:07  <Hirundo> Did you read the comments at #1848 also?
16:36:07  <Brot6> Hirundo: #1848 is "NewGRF Meta Language - Feature Request #1848: string codes - #openttdcoop Development Zone"
16:37:39  <Yexo> "If different translations have differently sized string codes," <- what do you mean with that?
16:37:59  <planetmaker> <-- swedishrails like that, Hirundo ?
16:38:14  <Yexo> one language file using SIGNED_WORD while another uses COMMA ?
16:38:20  <Hirundo> exactly
16:38:35  <Yexo> that should be a downright error with the alternative version not being encoded at all
16:38:46  <Yexo> nml might or might not already check for that, not sure if I ever finished that
16:39:25  <Hirundo> planetmaker: Yes, assuming that you add " fences:          fences_switch;" to the other gfx block
16:39:51  <Hirundo> There might be valid use cases for using different string codes, or using them in a different order
16:40:18  <Yexo> I can't think of a valid use case for using different codes
16:40:31  <Yexo> a different order can be valid, but only when properly done with {ROTATE}
16:40:34  <planetmaker> yes, just noticed that, Hirundo  :-)
16:40:39  <Ammler> noone has pygments patch to update paste with nml highlihtning
16:40:50  <Yexo> welll, code 86
16:41:21  <Hirundo> I think that real parametrized strings are a bridge too far for now (0.2.0)
16:41:41  <Hirundo> We could do the string code renaming though, to minimize breakage later on
16:41:53  <Yexo> agreed
16:42:01  <Yexo> still not sure about COMMA
16:42:17  <Yexo> I know it's in line with the openttd files, but even there it never made sense to me
16:42:56  <Hirundo> We could use NUM there, I don't think anyone will care about the distinction
16:44:03  <Yexo> imo that's more clear
16:44:09  <Hirundo> <bbl, I've got to buy some food before housemates starve..
16:48:40  <Brot6> Swedish Rails - Revision 206:cde41e8ceacf: Codechange: Use CB_FAILED for the cases where default ... (planetmaker) @
16:58:40  *** FooBar has quit IRC
17:06:18  <Brot6> Unrealistic Trainset - Feature #3002: Maglev Strong Series (V453000) @
17:07:24  <Ammler> V453000: you know, "transparent is blue, not white?
17:07:32  <V453000> yes
17:07:48  <V453000> I have it like this just for visibility now
17:08:01  <V453000> not the "real" sprites
17:08:58  *** LordAro has joined #openttdcoop.devzone
17:09:35  <planetmaker> V453000, use layered graphics files. Then you have both concurrently at virtually no extra work
17:10:00  <planetmaker> and re-visiting every gfx file before coding just to add blue is a PITA
17:10:28  <michi_cc> Ammler: Transparent is the first palette entry, even if it is neon green :)
17:11:36  <Ammler> V453000: so you could make your own palette :-P ^
17:11:54  <Ammler> but the white is usually good to find faulty adjusted sprites
17:12:03  <V453000> :d
17:12:07  <Brot6> nml: update from r1639 to r1640 done -
17:12:47  <V453000> planetmaker: layers with indexed colour? Anyway, I just thought that making blue background is just a tiny bit of work in compare with drawing all the sprites
17:13:37  *** LordAro has quit IRC
17:13:59  <V453000> I should probably put the sprites in some unified layout just like the templates have
17:14:43  <planetmaker> yes
17:14:48  <planetmaker> and yes
17:14:56  *** LordAro has joined #openttdcoop.devzone
17:15:13  <planetmaker> using layers is one thing. Using indexed palettes another. Both is a good thing in this context. Completely independently
17:19:08  <Brot6> NewGRF Meta Language - Revision 1641:12e868cbe382: Fix #2932: remove unneeded exec flag on a lot ... (yexo) @
17:19:08  <Brot6> NewGRF Meta Language - Code Review #2932 (Closed): unneded exec (+x) flag set on some files (yexo) @
17:19:40  <Yexo> planetmaker: as asked in that ticket, how hard would it be to setup a commit hook to disallow the -x flag?
17:20:38  <Brot6> firs: update from r2556 to r2557 done -
17:20:57  <planetmaker> I guess not very. But I'm not sure it's generally a good idea, given e.g. scripts for translations or similar
17:21:27  <Yexo> sure, but perhaps just for nml?
17:21:38  <Yexo> oh well, not so important
17:22:17  <planetmaker> hm, yes,... repo-specific. I'd need to look into how that works. I guess possible, too
17:23:32  <Brot6> nml: update from r1640 to r1641 done -
17:23:42  <Yexo> bah, tt-forums / tt-wiki are slow today
17:25:45  <Brot6> ogfx-landscape: update from r80 to r82 done (1 warnings) -
17:26:32  <Brot6> swedishrails: update from r205 to r206 done -
17:27:08  <Brot6> ai-aroai: update from r39 to r49 done -
17:27:31  <Brot6> Following repos didn't need a nightlies update: ogfx-trains (r251), narvs (r52), bros (r52), ogfx-industries (r123), opengfx (r729), ailib-tile (r16), foobarstramtracks (r23), transrapidtrackset (r28), 2cctrainset (r750), cets (r126), ailib-list (r32), opensfx (r97), ttdviewer (r34), worldairlinersset (r672), heqs (r639), openmsx (r97), basecosts (r25), nutracks (r208), water-features (r51), 32bpp-extra (r40), manindu (r7),
17:27:31  <Brot6> newgrf_makefile (r305), ailib-direction (r17), ailib-common (r21), snowlinemod (r49), dutchtramset (r87), ai-admiralai (r75), swisstowns (r22), metrotrackset (r56), dutchroadfurniture (r12), spanishtowns (r10), frenchtowns (r6), grfpack (r279), ogfx-rv (r109), fish (r684), ttrs (r36), ogfx-trees (r51), grfcodec (r833), german-townnames (r34), smts (r19), chips (r143), belarusiantowns (r8), indonesiantowns (r41), ailib-string (r29),
17:27:33  <Brot6> airportsplus (r132), comic-houses (r71)
17:38:34  *** Lord_Aro has joined #openttdcoop.devzone
17:41:11  *** LordAro is now known as Guest7872
17:41:11  *** Lord_Aro is now known as LordAro
17:41:52  <Ammler> ah, this was the ticket I had alberth in mind to ask... (#2932=
17:41:52  <Brot6> Ammler: ah: #2932 is "NewGRF Meta Language - Code Review #2932: unneded exec (+x) flag set on some files - #openttdcoop Development Zone"
17:42:29  *** LordAro has quit IRC
17:44:47  *** Guest7872 has quit IRC
17:45:06  <Brot6> NewGRF Meta Language - Revision 1642:786ac8bbab38: Fix (partly) #2914: define strings before they... (yexo) @
17:46:34  *** LordAro has joined #openttdcoop.devzone
17:52:40  <Brot6> Following repos rebuilds successful without any difference to earlier nightlies builds: ogfx-trains, narvs (11 warnings), ogfx-industries, firs, foobarstramtracks, cets (436 warnings) (Diffsize: 462), manindu (Diffsize: 2), newgrf_makefile, dutchtramset, swisstowns, dutchroadfurniture, spanishtowns (Diffsize: 2), frenchtowns, ogfx-rv, german-townnames (Diffsize: 1), belarusiantowns (Diffsize: 30), indonesiantowns (1 warnings) (Diffsize:
17:52:40  <Brot6> 1), airportsplus (2 warnings)
17:53:10  <Brot6> DictatorAI - Revision 176:18e3b20eb497: - I need to fix terrforming, trying build a station, terr... (krinn) @
18:03:20  *** LordAro has quit IRC
18:03:44  *** LordAro has joined #openttdcoop.devzone
18:05:15  *** LordAro has quit IRC
18:06:09  *** LordAro has joined #openttdcoop.devzone
18:11:14  <Brot6> NewGRF Meta Language - Revision 1643:45bc1732c505: Fix #2914: set the feature byte in action4 cor... (yexo) @
18:11:14  <Brot6> NewGRF Meta Language - Bug #2914 (Closed): Handling of Dxxx strings (yexo) @
18:13:09  *** andythenorth has joined #openttdcoop.devzone
18:14:42  <Brot6> OpenGFX+ Airports - Revision 133:559bbd03822d: Feature: Four rotations for heliport (dnicholls) @
18:15:15  <planetmaker> I should really build a new version of ogfx+airports :-)
18:15:23  <planetmaker> the many commits sound delicious
18:16:25  <Yexo> yes, indeed
18:17:06  <planetmaker> I wished he'd appear on IRC once in a while ;-)
18:17:24  <Yexo> hmm, doesn't build
18:17:33  <Yexo> internal nml error :(
18:19:04  <planetmaker> :-O
18:19:18  <planetmaker> indeed
18:21:00  <Yexo> now it does :)
18:21:26  <Brot6> NewGRF Meta Language - Revision 1644:7ee33637db85: Fix: typo made ogfx+airports unbuildable (yexo) @
18:22:51  <planetmaker> sweet :-)
18:30:07  <planetmaker> looks good. But it's missing the rotation strings on all airports except one
18:30:12  <Ammler> something with rebuild check broken?
18:30:29  <planetmaker> why?
18:30:39  <Ammler> because airport built there
18:43:14  <Yexo> Ammler: I think it was r133 (ie after the rebuild) that triggered a bug in nml (which has been there since r1501)
18:44:46  <Yexo> ^^ after another check I'm sure of that :)
18:45:56  <Ammler> he does huge commits
18:51:05  *** Zuu has joined #openttdcoop.devzone
19:03:24  <Brot6> clientpatches: compile of r22856 still failed (#2964) -
19:08:42  <Brot6> openttd-vehiclevars: update from r22855 to r22856 done -
19:10:27  <Brot6> serverpatches: compile of r22856 still failed (#2966) -
19:12:04  <Brot6> 32bpp-ez-patches: compile of r22856 still failed (#2446) -
19:16:59  <Brot6> NewGRF Meta Language - Bug #2933: Handling of failed callbacks (Hirundo) @
19:17:55  <Yexo> Hirundo: could you commit your string code rename patch?
19:18:23  <Yexo> I wanted to improve the string validation checks a bit, but that'll break your patch if I do it first
19:19:07  <Hirundo> just go ahead, I won't be able to commit right now anyways
19:19:34  <Yexo> was this the last version? then I'll commit it
19:19:57  <Hirundo> I still have to migrate my dev environment, patch queue etc. to the new windows install, which will take some time to setup
19:20:13  <Yexo> ah, ok
19:22:08  <Yexo> should we keep the old names for a while to preserve backwards compatibility?
19:23:30  <Hirundo> That'd be nice
19:32:13  <Yexo> planetmaker: do you have an opinion about "COMMA"?
19:32:30  <Yexo> should nml use "COMMA" to follow the openttd language files or use a more descriptive name like "NUM" instead?
19:33:13  <planetmaker> hm... NUM is the better name. But using the same naming scheme in both would be nice, too
19:34:29  *** ODM has joined #openttdcoop.devzone
19:36:19  <planetmaker> I'm quite undecided on that really :-)
19:36:20  <Yexo> oh, openttd already uses NUM
19:36:37  <planetmaker> comma = 1.234 and NUM = 234.440 ?
19:36:45  <planetmaker> 234,440
19:36:54  <Yexo> I think NUM = 234440
19:36:55  <planetmaker> int vs. float?
19:36:56  <Yexo> but not sure
19:37:02  <Yexo> definitely not float
19:37:12  <planetmaker> where num is int and comma is float? for display?
19:37:22  <Yexo> no, comma is integer too
19:37:26  <planetmaker> hm
19:38:05  <frosch123> num is without thousand separator
19:38:07  <frosch123> comma is with
19:38:31  <frosch123> so it refers to the english thousand separator ","
19:39:33  <Yexo> ok, so let's keep comma to avoid confusion
19:59:15  *** JVassie has joined #openttdcoop.devzone
21:10:13  *** Webster has joined #openttdcoop.devzone
21:10:27  *** Brot6 has joined #openttdcoop.devzone
21:10:54  *** Ammler has joined #openttdcoop.devzone
21:11:04  *** Hirundo has joined #openttdcoop.devzone
21:11:32  *** ^Spike^ has joined #openttdcoop.devzone
21:11:37  *** SmatZ has joined #openttdcoop.devzone
21:12:07  *** planetmaker has joined #openttdcoop.devzone
21:12:37  *** V4530000 has joined #openttdcoop.devzone
21:12:37  *** Terkhen has joined #openttdcoop.devzone
21:12:48  *** XeryusTC has joined #openttdcoop.devzone
21:13:37  *** Yexo has joined #openttdcoop.devzone
21:13:37  *** avdg has joined #openttdcoop.devzone
21:14:07  *** DJNekkid has joined #openttdcoop.devzone
21:14:50  *** pm has quit IRC
21:14:55  *** ^ekipS^ has quit IRC
21:14:57  <Brot6> NewGRF Meta Language - Bug #2933: Handling of failed callbacks (yexo) @
21:15:49  *** jvassie is now known as JVassie
21:16:38  <Brot6> NewGRF Meta Language - Revision 1645:8cabca851ffa: Change #1848: rename some string codes and dup... (yexo) @
21:17:11  <planetmaker> @op
21:17:21  <planetmaker> @whoami
21:17:21  <Webster> planetmaker: planetmaker
21:18:07  <Hirundo> Yexo: I just told pm this afternoon that he should use CB_FAILED in swedishrails to use the default fences
21:18:29  <Yexo> I read that but didn't follow the discussion before
21:19:24  <Hirundo> Before, there were multiple conditional if/else blocks which conditionally included graphics blocks, which works for railtypes but not for other features
21:19:47  <planetmaker> the code this way is also A LOT easier to read
21:20:01  <planetmaker> from how it looks now it was good advice :-)
21:20:22  <Yexo> yes, but for that it doesn't matter if it reads "CB_FAILED;" or "return 0;"
21:20:34  <planetmaker> actually that was what I wanted to write initially - but didn't know or figure how to achieve it
21:20:42  <planetmaker> yes
21:20:55  <planetmaker> new constant RETURN_DEFAULT?
21:21:06  <Yexo> but it's not default
21:21:07  <planetmaker> or USE_DEFAULT
21:21:17  <planetmaker> it is in this case. It'll use the TTD sprites
21:21:19  <Yexo> it's returning a callback result when the game expects a spritegroup
21:21:34  <planetmaker> nah, I mean that's what visually the result is
21:21:36  <Yexo> what happens in that case is highly dependent on the feature
21:21:54  <Yexo> planetmaker: yes, in this case
21:22:16  <Yexo> if a new name, than something like "GRAPHICS_FAILED"
21:22:47  <Yexo> I think I'd prefer a simple "return 0;" with a comment, so the distinction with CB_FAILED is really clear
21:22:53  *** V4530000 is now known as V453000
21:22:53  <planetmaker> well. it's not like it fails. But uses the default fallback
21:23:13  <planetmaker> But using 0 would be fine with me, too
21:23:15  <Yexo> no, the newgrf fails to provide graphics
21:23:23  <planetmaker> yes.
21:23:37  <Yexo> CB_FAILED is alwasy really "failed to return a proper result".
21:23:39  <planetmaker> thus it should use fallback :-)
21:23:57  <Yexo> that openttd has a special meaning for that and it might be intended doesn't matter, for the grf it fails
21:24:04  <Yexo> yes, if possible
21:31:17  <Hirundo> I'm not sure how clear the division graphics/callback is to the user
21:31:39  <Hirundo> Graphics are basically just a callback with a non-numeric result
21:33:23  <Yexo> hmm, true
21:35:29  <Yexo> as for the implementation: unconditionally create @CB_FAILED_<feature_num> switches for all features before loading any of the code, then letting the normal "switch is unused" code filter out the unused ones?
21:35:40  <Yexo> that means we just have to filter out the warnings for them and the rest is already done
21:36:01  <Yexo> it means a very easy rewriting of CB_FAILED to the proper result (just check the feature number of the current block)
21:38:58  <Yexo> we're getting close to getting all 0.2.0 issues done :)
21:41:37  <Hirundo> Indeed :)
21:43:14  <planetmaker> :-)
21:44:04  <Brot6> NewGRF Meta Language - Bug #2933: Handling of failed callbacks (yexo) @
21:44:13  <Yexo> ^^ just added the above bits from irc
22:02:40  *** JVassie has quit IRC
22:04:46  *** Zuu has quit IRC
22:15:44  *** ODM has quit IRC
22:44:53  <Brot6> NewGRF Meta Language - Bug #3018 (New): Handling of unsupported image formats (Hirundo) @
22:50:30  <Brot6> FIRS Industry Replacement Set - Feature Request #3019 (New): Convert all pcx files to png (Hirundo) @
22:55:25  <Hirundo> *someone* beat me to replying in the FIRS topic :)
22:57:12  <Brot6> Central European Train Set - Feature #2924: Prussian steam engines - sprites (oberhuemer) @
22:59:25  <planetmaker> :-)
23:34:27  <planetmaker> good night
23:37:57  <Brot6> Central European Train Set - Feature #2924: Prussian steam engines - sprites (oberhuemer) @

Powered by YARRSTE version: svn-trunk