Times are UTC Toggle Colours
00:56:32 <Brot6> NewGRF Meta Language - Feature #3207 (Closed): support for long date of last servicing (yexo) @ http://dev.openttdcoop.org/issues/3207#change-8774 01:25:01 *** JVassie has quit IRC 01:33:54 *** welshdragon has quit IRC 01:56:59 *** welshdragon has joined #openttdcoop.devzone 03:05:38 *** welshdragon has quit IRC 03:15:55 <Brot6> Central European Train Set - Code Review #3333: palette indices used for cargo recolouring (oberhuemer) @ http://dev.openttdcoop.org/issues/3333#change-8775 04:16:10 <Brot6> Central European Train Set - Revision 373:3d7ceeff3be3: change: add weaker/stronger versions of s... (oberhuemer) @ http://dev.openttdcoop.org/projects/cets/repository/revisions/3d7ceeff3be3 04:16:10 <Brot6> Central European Train Set - Revision 374:cafbaea4283c: add: ET 11 data (can't be used until GRF ... (oberhuemer) @ http://dev.openttdcoop.org/projects/cets/repository/revisions/cafbaea4283c 04:16:44 <Brot6> Central European Train Set - Feature #3013 (Rejected): Early steam engines (oberhuemer) @ http://dev.openttdcoop.org/issues/3013#change-8776 04:18:35 <Brot6> Central European Train Set - Bug #3344 (New): DevZone compile failed (compiler) @ http://dev.openttdcoop.org/issues/3344 04:20:24 <Brot6> Central European Train Set - Revision 375:ddbff6c1ecc4: fix: duplicate ID (oberhuemer) @ http://dev.openttdcoop.org/projects/cets/repository/revisions/ddbff6c1ecc4 04:22:04 *** falconne has joined #openttdcoop.devzone 04:22:55 <Brot6> cets: compile of r375 still failed (#3344) - http://bundles.openttdcoop.org/cets/push/ERROR/r375 04:28:45 *** falconne has quit IRC 08:22:22 *** andythenorth has joined #openttdcoop.devzone 08:34:43 <Brot6> HEQS "Heavy Equipment" Set - Bug #3335 (Closed): Yonkers railmotor refits to PAX (andythenorth) @ http://dev.openttdcoop.org/issues/3335#change-8778 09:06:16 <Brot6> HEQS "Heavy Equipment" Set - Revision 765:99d58467e8ab: Feature: adjust speed of some trams to ... (andythenorth) @ http://dev.openttdcoop.org/projects/heqs/repository/revisions/99d58467e8ab 09:41:11 *** ODM has joined #openttdcoop.devzone 09:46:57 <Brot6> Dutch Trains 2.0 - Feature #3345 (New): Vehicle properties (foobar) @ http://dev.openttdcoop.org/issues/3345 09:48:11 <Brot6> Dutch Trains 2.0 - Bug #3188 (Closed): Class 58 (foobar) @ http://dev.openttdcoop.org/issues/3188#change-8779 09:48:35 *** andythenorth has quit IRC 09:49:16 <Brot6> HEQS "Heavy Equipment" Set - Revision 766:a5e9afc60326: Feature: adjust costs for Afonside tram... (andythenorth) @ http://dev.openttdcoop.org/projects/heqs/repository/revisions/a5e9afc60326 09:49:16 <Brot6> HEQS "Heavy Equipment" Set - Bug #3313 (Closed): steam tram costs incorrect (andythenorth) @ http://dev.openttdcoop.org/issues/3313#change-8780 09:49:49 <Brot6> Dutch Trains 2.0 - Feature #3346 (New): version check (foobar) @ http://dev.openttdcoop.org/issues/3346 09:54:53 <Brot6> Dutch Trains 2.0 - Feature #3347 (New): Apply fire cycle colours to existing wagons (foobar) @ http://dev.openttdcoop.org/issues/3347 10:05:48 *** Zuu has joined #openttdcoop.devzone 10:09:37 <Brot6> Dutch Trains 2.0 - Bug #3201 (Closed): DDM consists (foobar) @ http://dev.openttdcoop.org/issues/3201#change-8781 10:39:35 *** JVassie has joined #openttdcoop.devzone 11:12:02 *** welshdragon has joined #openttdcoop.devzone 11:38:07 *** ODM has quit IRC 11:43:30 <Brot6> Dutch Trains 2.0 - Feature #3346 (Closed): version check (foobar) @ http://dev.openttdcoop.org/issues/3346 11:43:30 <Brot6> Dutch Trains 2.0 - Revision 72:d008ac0d4d2a: Feature close #3346: OpenTTD version check (1.2.0 / ... (foobar) @ http://dev.openttdcoop.org/projects/dutchtrains/repository/revisions/d008ac0d4d2a 11:43:30 <Brot6> Dutch Trains 2.0 - Feature #3346 (Closed): version check (foobar) @ http://dev.openttdcoop.org/issues/3346#change-8782 12:35:34 *** andythenorth has joined #openttdcoop.devzone 12:41:15 *** Zuu_ has joined #openttdcoop.devzone 12:48:25 *** Zuu has quit IRC 12:51:15 *** Zuu_ has quit IRC 12:57:25 <Brot6> HEQS "Heavy Equipment" Set - Revision 767:ddacfc2ce495: Change: increase loading speed of Dynam... (andythenorth) @ http://dev.openttdcoop.org/projects/heqs/repository/revisions/ddacfc2ce495 12:57:25 <Brot6> HEQS "Heavy Equipment" Set - Bug #3325 (Closed): Vehicles may need loading speed prop setting. (andythenorth) @ http://dev.openttdcoop.org/issues/3325#change-8783 13:07:43 <Brot6> HEQS "Heavy Equipment" Set - Revision 768:cd671cd4c914: Fix: Dynamo Tram wagon spritesheet was ... (andythenorth) @ http://dev.openttdcoop.org/projects/heqs/repository/revisions/cd671cd4c914 13:07:43 <Brot6> HEQS "Heavy Equipment" Set - Bug #3339 (Closed): Dynamo tram - invisible wagons (andythenorth) @ http://dev.openttdcoop.org/issues/3339#change-8784 13:08:41 <Brot6> NewGRF Meta Language - Revision 1742:5c06d0ce8bba: Add: support for (optional) url-information in... (yexo) @ http://dev.openttdcoop.org/projects/nml/repository/revisions/5c06d0ce8bba 13:27:44 <Brot6> feed NewGRFs had 11 updates, showing the latest 10 13:27:44 <Brot6> Dutch Trains 2.0 - Revision 75:8d6ee56d1ccb: Feature: NS 1200 basic code (foobar) @ http://dev.openttdcoop.org/projects/dutchtrains/repository/revisions/8d6ee56d1ccb 13:27:45 <Brot6> Dutch Trains 2.0 - Revision 76:e4c304916984: Feature: NS 1300 basic code (foobar) @ http://dev.openttdcoop.org/projects/dutchtrains/repository/revisions/e4c304916984 13:27:45 <Brot6> Dutch Trains 2.0 - Revision 77:fd583edd3a01: Feature: NS 1500 basic code (foobar) @ http://dev.openttdcoop.org/projects/dutchtrains/repository/revisions/fd583edd3a01 13:27:46 <Brot6> Dutch Trains 2.0 - Revision 78:ad35eb7fcb0d: Feature #3282: NS1600 (graphics by Voyager One) (foobar) @ http://dev.openttdcoop.org/projects/dutchtrains/repository/revisions/ad35eb7fcb0d 13:27:50 <Brot6> Dutch Trains 2.0 - Revision 79:b626f5f24be2: Feature: NS1700 (foobar) @ http://dev.openttdcoop.org/projects/dutchtrains/repository/revisions/b626f5f24be2 13:27:53 <Brot6> Dutch Trains 2.0 - Revision 80:e0582ac481f9: Feature: HLE 11 basic code (foobar) @ http://dev.openttdcoop.org/projects/dutchtrains/repository/revisions/e0582ac481f9 13:27:56 <Brot6> Dutch Trains 2.0 - Revision 81:a19f5acd9512: Feature: HLE 25.5 basic code (foobar) @ http://dev.openttdcoop.org/projects/dutchtrains/repository/revisions/a19f5acd9512 13:27:59 <Brot6> Dutch Trains 2.0 - Revision 82:cbc6b141448d: Feature: NS 1600P basic code (foobar) @ http://dev.openttdcoop.org/projects/dutchtrains/repository/revisions/cbc6b141448d 13:28:02 <Brot6> Dutch Trains 2.0 - Revision 83:089c4fe83d35: Feature #3282: TRAXX F140 MS2 (graphics by Voyager One) (foobar) @ http://dev.openttdcoop.org/projects/dutchtrains/repository/revisions/089c4fe83d35 13:28:06 <Brot6> Dutch Trains 2.0 - Revision 84:b3eed11c48d9: Feature #3282: EuroSprinter ES64F4 (graphics by Voya... (foobar) @ http://dev.openttdcoop.org/projects/dutchtrains/repository/revisions/b3eed11c48d9 13:56:02 <Brot6> HEQS "Heavy Equipment" Set - Bug #3312: Model life properties incorrect for mining trucks etc (andythenorth) @ http://dev.openttdcoop.org/issues/3312#change-8785 14:02:48 <Brot6> Central European Train Set - Revision 376:d14a243434c9: don't ever add empty lines to the trackin... (Eddi) @ http://dev.openttdcoop.org/projects/cets/repository/revisions/d14a243434c9 14:10:20 <Brot6> cets: update from r372 to r376 done (220 warnings) - http://bundles.openttdcoop.org/cets/push/r376 14:47:55 *** frosch123 has joined #openttdcoop.devzone 15:05:08 <Brot6> Dutch Trains 2.0 - Revision 85:3d1748ef580f: Feature close #3282: Fyra V250 (graphics by Voyager ... (foobar) @ http://dev.openttdcoop.org/projects/dutchtrains/repository/revisions/3d1748ef580f 15:05:08 <Brot6> Dutch Trains 2.0 - Feature #3282 (Closed): Metros and other stuff (foobar) @ http://dev.openttdcoop.org/issues/3282#change-8786 15:52:15 <Brot6> Dutch Trains 2.0 - Revision 86:706723279cf1: Feature: SLT basic code; known gap between first par... (foobar) @ http://dev.openttdcoop.org/projects/dutchtrains/repository/revisions/706723279cf1 15:59:07 *** andythenorth is now known as Guest20069 15:59:07 *** andythenorth has joined #openttdcoop.devzone 16:01:21 *** andythenorth is now known as Guest20070 16:01:22 *** andythenorth has joined #openttdcoop.devzone 16:09:48 <Yexo> planetmaker: the {{grf|7}} template in the reference http://newgrf-specs.tt-wiki.net/wiki/NML:Base_cost_table doesn't really help 16:09:59 <Yexo> NML authors are not supposed to know anything about the grf version 16:10:51 <frosch123> that template is also troublesome in the nfo specs. sometimes it means >= 7, sometimes == 7, sometimes <= 7 :p 16:11:33 <Brot6> HEQS "Heavy Equipment" Set - Revision 769:1dd400abe830: Fix: disable auto-refit for all trams t... (andythenorth) @ http://dev.openttdcoop.org/projects/heqs/repository/revisions/1dd400abe830 16:16:42 <Brot6> HEQS "Heavy Equipment" Set - Revision 770:26d7d8b5593b: Change: update changelog preparatory to... (andythenorth) @ http://dev.openttdcoop.org/projects/heqs/repository/revisions/26d7d8b5593b 16:17:37 <Brot6> HEQS "Heavy Equipment" Set - Revision 771:695524e53d8c: Added tag 1.5.1 for changeset 26d7d8b5593b (andythenorth) @ http://dev.openttdcoop.org/projects/heqs/repository/revisions/695524e53d8c 16:18:50 <Yexo> any problems with removing all constants for the old style callbacks from nml? 16:19:32 <Yexo> VEH_CB_ARTICULATED_PARTS for examples says "return 0xFF for none" in the documentation, there is no way to automatically detect that and update it for grf v8 16:19:37 <Brot6> heqs: update from 1.5.0 to 1.5.1 done - http://bundles.openttdcoop.org/heqs/releases/1.5.1 16:19:46 <Yexo> although the same holds for the articulated_part callback :( 16:19:54 <Yexo> why didn't we introduce a constant for that 16:22:19 <Brot6> Dutch Trains 2.0 - Feature #3336: Old pax coaches (Voyager1) @ http://dev.openttdcoop.org/issues/3336#change-8788 16:26:06 <planetmaker> you're right, Yexo. Though I inteded it to show the potential difference between 0.2.x and 0.3.x 16:26:23 <Yexo> yes, that should be done, but not via the template 16:26:32 <Yexo> a new template for nml would be better 16:26:40 <planetmaker> yes, probably 16:27:05 <planetmaker> I didn't spend much thought on that text as it was already there 16:27:47 <Yexo> anyway, removal of old-style callbacks is ok? 16:30:20 <planetmaker> Currently I'm inclined to answer 'yes' 16:30:44 *** andythenorth is now known as Guest20078 16:30:44 *** andythenorth has joined #openttdcoop.devzone 16:31:12 <planetmaker> though, Yexo, that's exactly one of the things which might break your promise of "all 0.2.x nml newgrfs will compile fine with 0.3.x" 16:31:24 <Yexo> yes, I shouldn't promise that 16:32:36 <planetmaker> :-) 17:05:18 <andythenorth> too much compatibility is bad 17:11:15 <Brot6> nml: update from r1741 to r1742 done - http://bundles.openttdcoop.org/nml/nightlies/r1742 17:18:03 *** ODM has joined #openttdcoop.devzone 17:25:38 <Brot6> cets: update from r369 to r376 done (220 warnings) - http://bundles.openttdcoop.org/cets/nightlies/r376 17:26:58 <Brot6> heqs: update from r764 to r771 done - http://bundles.openttdcoop.org/heqs/nightlies/r771 17:28:30 <Brot6> dutchtrains: update from r54 to r86 done - http://bundles.openttdcoop.org/dutchtrains/nightlies/r86 17:30:09 <Brot6> chips: update from r149 to r157 done (1 warnings) - http://bundles.openttdcoop.org/chips/nightlies/r157 17:38:28 <Brot6> bandit: compile of r26 still failed (#3303) - http://bundles.openttdcoop.org/bandit/nightlies/ERROR/r26 17:50:05 <Brot6> Dutch Trains 2.0 - Feature #3336: Old pax coaches (Voyager1) @ http://dev.openttdcoop.org/issues/3336#change-8791 17:53:08 * Hirundo agrees with andy 17:56:56 <andythenorth> this is why I have three versions of python installed :P 17:57:07 *** welshdragon has quit IRC 17:58:17 <Brot6> Following repos rebuilds successful without any difference to earlier nightlies builds: ogfx-trains, narvs (11 warnings) (Diffsize: 525), ogfx-industries (1 warnings) (Diffsize: 4406), firs (24 warnings), foobarstramtracks (Diffsize: 37120), manindu (Diffsize: 2), newgrf_makefile, rust (Diffsize: 55), ogfx-biggui, dutchtramset (Diffsize: 26384), swisstowns (Diffsize: 39), dutchroadfurniture (Diffsize: 2045), spanishtowns (Diffsize: 8), 17:58:17 <Brot6> frenchtowns (Diffsize: 21), ogfx-rv (90 warnings) (Diffsize: 364), ogfx-landscape (2 warnings), swedishrails (Diffsize: 719), german-townnames (Diffsize: 39), dach, belarusiantowns (Diffsize: 63), indonesiantowns (1 warnings) (Diffsize: 21), airportsplus 18:01:24 *** andythenorth has quit IRC 18:03:07 *** welshdragon has joined #openttdcoop.devzone 18:36:44 <Yexo> ideas on how to call cb22 for nml 0.3? 18:37:01 <Yexo> it was "availability" with a 0/1 result, now it returns a probability 18:37:31 <Yexo> properties are named "prob_random" and "prob_in_game" 18:41:17 <planetmaker> probability as it applies to ingame and SE, right? 18:41:25 <Yexo> yes 18:41:51 <Yexo> I've been thinking about "construction_prob" with constants CB_RESULT_IND_NO_CONSTRUCTION and CB_RESULT_IND_PROB_FROM_PROPERTY 18:42:30 <planetmaker> rather then prob_construction 18:42:37 <planetmaker> to make it consistent with properties 18:42:44 <Yexo> ok 18:43:00 <planetmaker> or maybe prob_creation 18:43:07 <Yexo> or construction_probability? 18:43:16 <planetmaker> that'd be the speaking name 18:43:21 <planetmaker> I guess that's good, though 18:43:29 <planetmaker> we won't get sore fingers because of it 18:43:45 <Yexo> so also CB_RESULT_IND_PROBABILITY_FROM_PROPERTY 18:45:27 <planetmaker> yes 18:51:58 *** Zuu has joined #openttdcoop.devzone 19:03:23 <Brot6> clientpatches: compile of r23497 still failed (#2964) - http://bundles.openttdcoop.org/clientpatches/testing/ERROR/r23497 19:05:38 <Brot6> serverpatches: compile of r23497 still failed (#2966) - http://bundles.openttdcoop.org/serverpatches/testing/ERROR/r23497 19:07:38 <Brot6> 32bpp-ez-patches: compile of r23497 still failed (#2446) - http://bundles.openttdcoop.org/32bpp-ez-patches/testing/ERROR/r23497 19:18:53 <Brot6> Dutch Trains 2.0 - Feature #3336: Old pax coaches (Voyager1) @ http://dev.openttdcoop.org/issues/3336#change-8792 19:37:36 *** andythenorth has joined #openttdcoop.devzone 19:45:34 <andythenorth> Yexo planetmaker I would like to try solving my FIRS animation challenge. Got time to help? :) 19:45:45 <Yexo> sure 19:45:56 <andythenorth> k 19:46:02 <andythenorth> I'll just check some files 19:49:28 <Brot6> FIRS Industry Replacement Set - Revision 2640:fe66f1c65640: Codechange: add spritesets for animat... (andythenorth) @ http://dev.openttdcoop.org/projects/firs/repository/revisions/fe66f1c65640 19:49:31 <andythenorth> Yexo: it's in iron_works.pnml 19:49:57 <andythenorth> the tile defined by spritelayout_metal_pigs_anim should cycle between spritesets 4-6 19:50:02 <andythenorth> [4,5,6] 19:50:20 <andythenorth> it's a straight swap of the 'building' graphics for 19:51:03 <andythenorth> it probably cycles over 256 frames or so 19:51:18 <andythenorth> and it needs a random offset, so when there are two they are not synchronised 19:51:36 <Yexo> hmm, there is only a single industry tile used for all tiles of that industry currently 19:51:48 <andythenorth> yup 19:51:57 <Yexo> it's easiest to change that 19:51:59 <andythenorth> and that has 47 animation frames, for smoke 19:52:10 <Yexo> so create a new id for the building 19:52:12 <andythenorth> so either I need to use multiple of 47, or split tiles 19:54:51 <Yexo> 4->5->6->4 etc? or 4->5->6->5 ? 19:55:00 <Hirundo> or c) Use animation callbacks (takes CPU power though) 19:55:54 <andythenorth> 4->5->6->4 19:56:16 <Yexo> Hirundo: that's the problem, those are already used 19:56:26 <Yexo> and splitting between the types makes it harder codewise 19:56:52 <Brot6> Dutch Trains 2.0 - Revision 87:c7cebb8c9f98: Feature: ICE 3M basic code (foobar) @ http://dev.openttdcoop.org/projects/dutchtrains/repository/revisions/c7cebb8c9f98 19:56:52 <Brot6> Dutch Trains 2.0 - Revision 88:7eb0eeafd409: Feature: Protos (graphics by Purno) (foobar) @ http://dev.openttdcoop.org/projects/dutchtrains/repository/revisions/7eb0eeafd409 19:57:33 <Brot6> Dutch Trains 2.0 - Bug #3348 (New): r86 "buggies" (Voyager1) @ http://dev.openttdcoop.org/issues/3348 20:00:09 <Yexo> andythenorth: http://devs.openttd.org/~yexo/anim.diff <- completely untested, but I'm thinking something like this 20:01:13 <andythenorth> ok, so in this model we switch layouts 20:01:16 <andythenorth> that's fine by me 20:01:22 <andythenorth> that's old school ;) 20:01:45 <andythenorth> it slightly confuses me that we have industry layout and sprite layout....but meh 20:01:51 * andythenorth tests 20:02:12 <Yexo> a spritelayout is a collection of sprites that will be drawn on a single tile 20:02:19 <andythenorth> I know :) 20:02:21 <Yexo> an industry layout is a collection of tiles that belong to an industry 20:06:47 <andythenorth> Yexo: appears to work :D 20:07:02 <andythenorth> so interesting thing is whether I will be able to extend animation for that tile without affecting smoke 20:07:18 <Yexo> with that code, yes 20:07:19 <andythenorth> and if I can provide a random offset or trigger 20:07:24 <Yexo> I have an alternative patch almost ready 20:07:57 <andythenorth> so that one adds a tile? 20:08:00 <andythenorth> the first one 20:08:03 <Yexo> yes 20:08:05 <andythenorth> hmm 20:08:10 <andythenorth> my test might be invalid then 20:08:22 <andythenorth> I am testing on an existing savegame 20:08:28 <andythenorth> the strange thing is that it appears to work 20:08:32 <andythenorth> that shouldn't be 20:08:38 <Yexo> a bit 20:08:46 <Yexo> the speed will be completely off 20:09:05 <andythenorth> even more interesting 20:09:11 <andythenorth> in a new game that tile is broken :) 20:09:12 <Yexo> it should show spriteset6 way more than the other ones 20:09:23 * andythenorth guesses the issue 20:09:55 <Yexo> hmm, the id 209 is already taken 20:10:00 <Yexo> that shouldn't have compiled at all 20:10:12 <Yexo> guess there is no check for that yet in nml 20:11:45 <Yexo> http://devs.openttd.org/~yexo/anim2.diff This should work too 20:11:54 <Yexo> even better, it disables animation for the tiles that don't use any animation 20:11:58 <Yexo> which speeds up openttd a bit 20:12:20 <Yexo> this one should work on an existing savegame 20:12:54 <Yexo> the chance that the animation starts with spriteset_6 is way bigger than for the other tiles 20:13:00 <andythenorth> can I disable the language check when compiling? 20:13:50 <Yexo> which language check exactly? 20:15:07 <andythenorth> I am assuming that it's the language check that makes compiling so slow 20:15:16 <Yexo> it's not 20:15:23 <andythenorth> false assumption :P 20:15:43 <Yexo> partly it's the makefile framework doing too much to check the dependencies, partly it's because nml seems to be slow 20:15:48 <planetmaker> it's both nml and the makefile 20:16:27 <planetmaker> I've somewhere a nearly working version of the makefile which basically skips most of the double work and dep checks it usually does pointlessly 20:16:33 <andythenorth> \o/ 20:16:37 <planetmaker> but... not working quite correctly yet 20:16:40 <andythenorth> time 20:16:43 <andythenorth> will solve that 20:17:27 <andythenorth> ach, it's only 33s to build FIRS 20:17:56 <andythenorth> and we know FIRS is big 20:18:10 <Yexo> cets takes up to 5 minutes 20:18:12 <andythenorth> it's more noticeable because I've been working on CHIPS and HEQS 20:18:18 <Yexo> and that was without makefile 20:18:19 <andythenorth> CHIPS: 1.15s 20:18:50 <andythenorth> HEQS 2.9s 20:19:20 <andythenorth> anyway, better to write code than moan 20:20:03 <andythenorth> Yexo: animation looks like it will work. Newgame has randomised triggers, savegame doesn't. I assume that's because savegame tiles are already built? 20:20:13 <Yexo> yes 20:20:31 <andythenorth> np 20:20:36 <andythenorth> so I need to add frames 20:20:42 <andythenorth> let me see if I can work that out 20:23:16 <Yexo> anim2 doesn't slow down the animation 20:29:06 <andythenorth> Yexo: ok so I thought I could guess this, but I can't 20:29:31 <Yexo> what exactly do you try to change? 20:29:37 <andythenorth> there are 47 animation frames, but the branch for this tile only seems to see 3 20:29:56 <andythenorth> I tried to change the ranges checked by THIS_ID(tile_anim_building_next_frame) 20:29:58 <Yexo> +switch(FEAT_INDUSTRYTILES, SELF, THIS_ID(tile_anim_building_next_frame), animation_frame) { <- the lines there are doing that 20:31:52 <Yexo> http://devs.openttd.org/~yexo/anim3.diff Adds another 2 frames 20:32:54 * andythenorth tests 20:33:31 <Yexo> I didn't add the extra spritesets, so it won't compile like this 20:35:05 <andythenorth> I just lifted the changed line in the switch 20:35:06 <andythenorth> might work 20:36:13 <andythenorth> works 20:39:38 <andythenorth> can't figure out how to get the result I want yet, but I guess I have to read the docs some more 20:43:11 <andythenorth> Yexo: what does tile_anim_building_next_frame return? 20:43:29 <andythenorth> is it a spriteset, or a skip to frame, or play/stop? 20:43:41 <Yexo> the next frame, but it can also return STOP 20:44:18 <Yexo> however if you return STOP it won't be started again (at least not without further changes) 20:44:53 <Yexo> it's the anim_next_frame callback 20:45:51 <andythenorth> so stop would also stop the smoke? As it's one tile id 20:45:51 <Yexo> which is cb26: http://newgrf-specs.tt-wiki.net/wiki/Callbacks#Next_animation_frame_.281A.2F26.2F141.2F153.2F158.29 20:46:01 <Yexo> no, you can stop each tile individually 20:46:07 <Yexo> each real tile on the map, not each tile id 20:46:23 <Yexo> read the diff from the bottom up 20:46:45 <Yexo> + anim_next_frame: THIS_ID(tile_anim_next_frame); <- for all tiles of this industry, use THIS_ID(tile_anim_next_frame) 20:46:57 <Yexo> +switch(FEAT_INDUSTRYTILES, PARENT, THIS_ID(tile_anim_next_frame), layout_num) { <- pick a layout 20:47:28 <Yexo> +switch(FEAT_INDUSTRYTILES, SELF, THIS_ID(anim_layout_1), relative_pos) { <- pick a tile within layout 1, for tiles 0,2 and 1,2 (the building tiles) go to THIS_ID(tile_anim_building_next_frame) 20:47:46 <Yexo> +switch(FEAT_INDUSTRYTILES, SELF, THIS_ID(tile_anim_building_next_frame), animation_frame) { <- return the animation frame for the animated building tile 20:49:32 <andythenorth> ok 20:50:01 <Yexo> can I commit some cleanup to firs? or do you have changes locally? 20:50:13 <andythenorth> nothing that I need 20:50:36 <andythenorth> so tile_anim_next_frame is equivalent to this? http://paste.openttdcoop.org/show/834/ 20:51:15 <Brot6> FIRS Industry Replacement Set - Revision 2641:5119db476998: Cleanup: don't set callback_flags man... (yexo) @ http://dev.openttdcoop.org/projects/firs/repository/revisions/5119db476998 20:51:39 <Yexo> that's actually tile_anim_control 20:52:07 <Yexo> hmm, no 20:52:32 <Yexo> that paste does: 0-> 0x10, 1-> 0x11, 2-> 0x12 etc. 20:53:35 <andythenorth> yup 20:54:12 <andythenorth> returns a different spritelayout depending on animation frame 20:54:34 <Yexo> oh, right :) 20:54:42 <Yexo> that's what THIS_ID(spritelayout_metal_pigs_anim) does 20:55:37 <andythenorth> ah 20:55:43 <andythenorth> so I'd add ranges there 20:55:51 <Yexo> yes 20:56:16 <Yexo> THIS_ID(tile_anim_building_next_frame) controls the maximum animation frame 20:56:32 <andythenorth> is the second diff still valid after the cleanup? 20:56:44 <Yexo> should be 20:56:52 <Yexo> anim3 might be easier to extend than anim2 20:57:09 <andythenorth> ok 21:00:31 <andythenorth> Yexo: think I've nailed it ;) 21:00:39 <andythenorth> subject to possible misunderstandings :P 21:07:06 <Yexo> maximum_height_level a good name or should it be called maximum_height? 21:07:58 *** andythenorth is now known as Guest20095 21:07:59 *** andythenorth has joined #openttdcoop.devzone 21:08:44 <andythenorth> maximum_height_level 21:08:55 <andythenorth> otherwise could be ambiguous with bounding boxes etc? 21:11:59 <planetmaker> max_height? 21:13:49 <Yexo> hmm, a bit general, don't you think? 21:13:53 <Yexo> max_height_level ? 21:15:48 <frosch123> include the "level". just like ottd source got very strict in "levels" and "pixels" :) 21:16:39 <Brot6> FIRS Industry Replacement Set - Revision 2642:479d4d72b667: Feature: animated molten metal for Ir... (andythenorth) @ http://dev.openttdcoop.org/projects/firs/repository/revisions/479d4d72b667 21:16:53 <andythenorth> we got another FIRS :P 21:17:08 <andythenorth> only another 358 to go :) 21:17:40 <Yexo> andythenorth: it's actually off by one now 21:17:46 <andythenorth> bah 21:17:50 <andythenorth> which way? 21:17:54 <Yexo> 0..180: return animation_frame + 1; <- max frame is 181 21:18:12 <andythenorth> oh how intriguing :P 21:18:30 <Yexo> 0..60 = 61 frames long, 61..120 = 60 frames long, 121..181=61 frames long 21:19:03 <andythenorth> oh that's probably ok 21:19:12 <andythenorth> no-one will notice :) 21:19:33 <andythenorth> I wondered if you meant tile_anim_building_next_frame 21:19:41 <andythenorth> incidentally, why is tile_anim_building_next_frame needed at all? 21:20:13 <andythenorth> afaict, for every frame, it now just advances by one frame... 21:20:28 <Yexo> yes, but the default maximum frame number for the tile is 47 21:20:41 <Yexo> which is necesary for the smoke animation 21:21:01 <andythenorth> I changed that to 180 ;) 21:21:06 <Yexo> and I think that was wrong 21:21:13 <andythenorth> the smoke - by luck - fits perfectly :) 21:21:19 <andythenorth> the smoke runs, then the metal flows 21:21:29 <Yexo> that's no accident 21:21:35 <Yexo> but there is now less smoke than before 21:21:38 <andythenorth> that's ok 21:21:49 <Yexo> previously it was every 47*4 ticks, not every 180*4 ticks 21:22:14 <Yexo> with that changes tile_anim_building_next_frame can be left out completely indeed 21:22:45 <Yexo> I think due to the off-by-one I mentioned earlier it will get very slowly out of sync 21:22:59 <Yexo> if you remove tile_anim_building_next_frame it'll stay in sync 21:23:05 <andythenorth> it does get out of sync 21:23:10 <andythenorth> I just watched :p 21:23:48 <andythenorth> let's see 21:25:10 <Yexo> if you wanted you could basically remove the complete anim_next_frame callback again 21:26:39 *** andythenorth is now known as Guest20096 21:26:39 *** andythenorth has joined #openttdcoop.devzone 21:26:48 <andythenorth> Yexo: fails to randomise if I do that ;) 21:27:17 <andythenorth> wonder why 21:27:26 <Yexo> anim_control should take care of the randomization 21:27:28 <andythenorth> hmm 21:27:40 <andythenorth> perhaps I was just unlucky in my test game 21:27:41 <Yexo> however it randomizes seperately for all tiles 21:28:10 *** andythenorth is now known as Guest20097 21:28:11 *** andythenorth has joined #openttdcoop.devzone 21:33:31 <Brot6> FIRS Industry Replacement Set - Revision 2643:0530a5dc2d4b: Codechange: remove redundant switches... (andythenorth) @ http://dev.openttdcoop.org/projects/firs/repository/revisions/0530a5dc2d4b 21:36:20 <andythenorth> that Iron Works is now much more appealing :) 21:37:24 <Yexo> andythenorth: do you care about openttd 1.1 for firs? 21:38:06 <andythenorth> afaik it doesn't work anyway 21:38:14 <andythenorth> I think we're pretty committed to nightly atm 21:38:15 <Brot6> NewGRF Meta Language - Revision 1743:e03f727a206a: Fix: regression test still used out-dated call... (yexo) @ http://dev.openttdcoop.org/projects/nml/repository/revisions/e03f727a206a 21:38:15 <Brot6> NewGRF Meta Language - Revision 1744:4ad5f26d4655: Change: force constant IDs in item-blocks (yexo) @ http://dev.openttdcoop.org/projects/nml/repository/revisions/4ad5f26d4655 21:38:15 <Brot6> NewGRF Meta Language - Revision 1745:28c88515e5e7: Remove: all traces from old-style callbacks (yexo) @ http://dev.openttdcoop.org/projects/nml/repository/revisions/28c88515e5e7 21:38:17 <Brot6> NewGRF Meta Language - Revision 1746:78f70c2530ba: Change: rename 'availability' callback to 'con... (yexo) @ http://dev.openttdcoop.org/projects/nml/repository/revisions/78f70c2530ba 21:38:19 <planetmaker> Yexo: we use adv. spritelayouts 21:38:21 <Brot6> NewGRF Meta Language - Revision 1747:4aecebfce47f: Change: use cb36 instead of cb11 and cb12 (yexo) @ http://dev.openttdcoop.org/projects/nml/repository/revisions/4aecebfce47f 21:38:24 *** andythenorth has left #openttdcoop.devzone 21:38:25 <Brot6> NewGRF Meta Language - Revision 1748:796b98c63499: Update: values for can_attach_wagon-callback (yexo) @ http://dev.openttdcoop.org/projects/nml/repository/revisions/796b98c63499 21:38:29 <Brot6> NewGRF Meta Language - Revision 1749:121a6bcfac69: Change: don't invert bit 10 anymore for cb157 (yexo) @ http://dev.openttdcoop.org/projects/nml/repository/revisions/121a6bcfac69 21:38:33 <Brot6> NewGRF Meta Language - Revision 1750:8b7a1cce03b5: Change: multiply the 'snowline_height' variabl... (yexo) @ http://dev.openttdcoop.org/projects/nml/repository/revisions/8b7a1cce03b5 21:38:33 <planetmaker> good night now, though 21:38:36 <Yexo> ok. Just updated nml to use grf v8 21:38:37 <Brot6> NewGRF Meta Language - Revision 1751:009996f5c92c: Update: write 8 as grf version (yexo) @ http://dev.openttdcoop.org/projects/nml/repository/revisions/009996f5c92c 21:38:40 <Brot6> NewGRF Meta Language - Revision 1752:bc2d5413b949: Add: max_height_level variable (yexo) @ http://dev.openttdcoop.org/projects/nml/repository/revisions/bc2d5413b949 21:38:42 <planetmaker> great :-) 21:38:46 <Yexo> so no problem if I update firs for that than 21:38:50 <planetmaker> not at all 21:39:18 *** andythenorth has joined #openttdcoop.devzone 21:39:39 <andythenorth> my router is very capable, but is on the other side of a cast iron radiator from me 21:39:47 <andythenorth> seems to be a good faraday cage or such 21:40:27 <Yexo> planetmaker: perhaps you could use the new --quiet flag from nml while generating dependencies? 21:41:41 <planetmaker> I want to skip that step entirely and do that in one wash-up 21:43:25 <andythenorth> FIRS could use more animation 21:44:05 <Brot6> FIRS Industry Replacement Set - Revision 2644:1283f66e88da: Update: for changes in NML r1743..r17... (yexo) @ http://dev.openttdcoop.org/projects/firs/repository/revisions/1283f66e88da 21:44:13 <Yexo> FIRS is probably the first non-test v8 newgrf :) 21:44:36 <frosch123> \o/ 21:44:36 *** andythenorth has quit IRC 21:44:45 *** andythenorth has joined #openttdcoop.devzone 21:44:58 <andythenorth> I want to do HEQS 21:45:30 <andythenorth> I did some refactoring recently to help that along 21:46:14 <Brot6> British Rail OpenTTD Set - Bug #3349 (Assigned): Check Commits (welshdragon) @ http://dev.openttdcoop.org/issues/3349 21:47:10 *** andythenorth is now known as Guest20099 21:47:11 *** andythenorth has joined #openttdcoop.devzone 21:53:04 <Brot6> British Rail OpenTTD Set - Support #3350 (Assigned): Ways to build from external repository? (welshdragon) @ http://dev.openttdcoop.org/issues/3350 21:55:17 <welshdragon> can somebody close the UK Bus Set project please? Thankies 21:55:59 <Yexo> welshdragon: got an url? And why does it need to be closed? 21:56:04 <Yexo> andythenorth: http://devs.openttd.org/~yexo/url.diff 21:56:12 <Yexo> do you want that url or another one? 21:56:52 <welshdragon> Yexo: because it ain't never gonna happen? 21:56:53 <welshdragon> /dev.openttdcoop.org/projects/ukbusset/i 21:57:20 <andythenorth> Yexo: that url is fine 21:57:57 <Brot6> FIRS Industry Replacement Set - Revision 2645:46210a60df85: Add: url to grf-block (yexo) @ http://dev.openttdcoop.org/projects/firs/repository/revisions/46210a60df85 21:57:57 <Yexo> another first for firs :p 22:00:54 <Yexo> welshdragon: done 22:02:48 *** welshdragon has quit IRC 22:05:06 <andythenorth> Yexo: \o/ 22:05:11 <andythenorth> also...good night :) 22:05:15 <Yexo> gn 22:05:44 *** frosch123 has quit IRC 22:06:57 *** andythenorth has quit IRC 22:07:45 *** welshdragon has joined #openttdcoop.devzone 22:07:54 <welshdragon> Yexo: you may be able to answer //dev.openttdcoop.org/projects/ukbusset/i 22:08:01 <welshdragon> erm no 22:08:13 <welshdragon> http://dev.openttdcoop.org/issues/3350 22:08:54 <Yexo> why does WWW use another repo and no the one belonging to the project? 22:09:11 <Yexo> isn't spread of work exactly the reason why there still is no release? 22:09:20 <welshdragon> yeah, I know 22:09:28 <welshdragon> he prefers his method, I think 22:10:11 <Yexo> if he really prefers git I think the best way is to ask Ammler if git can be supported for BROS (maybe it already is) and still push to openttdcoop 22:10:45 <welshdragon> ok 22:22:37 <Brot6> FIRS Industry Replacement Set - Feature #2936: Review substitute type in order to help AIs (yexo) @ http://dev.openttdcoop.org/issues/2936#change-8793 22:23:21 <Brot6> FIRS Industry Replacement Set - Revision 2646:e4f099d384d3: Fix (r2645): compile before commit (yexo) @ http://dev.openttdcoop.org/projects/firs/repository/revisions/e4f099d384d3 22:23:21 <Brot6> FIRS Industry Replacement Set - Revision 2647:af29367f3c34: Fix #3026: remove STR_GENERIC_D0B2 (yexo) @ http://dev.openttdcoop.org/projects/firs/repository/revisions/af29367f3c34 22:23:21 <Brot6> FIRS Industry Replacement Set - Revision 2648:5240a5b6d8b5: Fix: convert lang/hungarian.lng to utf-8 (yexo) @ http://dev.openttdcoop.org/projects/firs/repository/revisions/5240a5b6d8b5 22:23:23 <Brot6> FIRS Industry Replacement Set - Bug #3026 (Closed): Orphan string (yexo) @ http://dev.openttdcoop.org/issues/3026#change-8794 22:49:51 *** ODM has quit IRC 23:20:14 *** JVassie has quit IRC 23:23:35 *** welshdragon has quit IRC 23:25:27 *** welshdragon has joined #openttdcoop.devzone 23:37:38 *** Zuu has quit IRC