Config
Log for #openttdcoop.devzone on 19th March 2013:
Times are UTC Toggle Colours
00:30:40  *** Supercheese has joined #openttdcoop.devzone
03:21:16  *** George has quit IRC
03:28:00  *** George has joined #openttdcoop.devzone
06:23:43  *** Supercheese has quit IRC
06:24:17  *** Supercheese has joined #openttdcoop.devzone
07:18:03  *** Supercheese has quit IRC
08:11:22  *** Zuu has joined #openttdcoop.devzone
08:39:07  *** Zuu has quit IRC
10:17:00  *** George|2 has joined #openttdcoop.devzone
10:18:54  *** George has quit IRC
17:19:40  <Brot6> opengfx: compile of r1007 failed - http://bundles.openttdcoop.org/opengfx/nightlies/ERROR/r1007
17:42:51  *** Alberth has joined #openttdcoop.devzone
17:54:04  *** ODM has joined #openttdcoop.devzone
18:19:01  *** frosch123 has joined #openttdcoop.devzone
18:22:52  *** Zuu has joined #openttdcoop.devzone
18:34:36  <Brot6> Webtranslator - Feature Request #5318: Allow to verify / review updates via file upload before comit... XAlberthX @ http://dev.openttdcoop.org/issues/5318#change-13850
18:40:08  <planetmaker> hi Alberth :-)
18:40:18  <Alberth> hi :)
18:40:28  <Alberth> I found your reports :)
18:40:29  <planetmaker> I spammed your issue tracker yesterday a bit
18:40:42  <Alberth> it liked it :)
18:40:48  <planetmaker> I didn't look whether anything existed already, so close, if there are now duplicates
18:40:49  <frosch123> spammed? with patches? :p
18:41:01  <planetmaker> sadly no patches. Just moooaar wishes ;-)
18:41:12  <frosch123> ah, so a whole year of employment :)
18:41:24  <Alberth> huh, since when do you use a tracker for patches? :)
18:41:31  <planetmaker> :-P
18:41:53  <frosch123> whenever i want someone else to finish it
18:42:10  <Alberth> is it working?
18:42:16  <frosch123> sometimes :)
18:42:34  <frosch123> iirc i contributes a documentation patch to nml
18:42:37  <frosch123> via tracker
18:42:51  <frosch123> and iirc it was even you who finished it :p
18:43:22  <Alberth> sunds likely :)
18:43:26  <Alberth> *sounds
18:46:41  <Alberth> hmm, no andy person here atm
18:48:21  <Brot6> Webtranslator - Feature Request #5297: Allow creation of new translation XAlberthX @ http://dev.openttdcoop.org/issues/5297#change-13853
18:50:19  <Brot6> Webtranslator - Code Review #5303 (Closed): "Send all strings" vs "Commit change(s)" XAlberthX @ http://dev.openttdcoop.org/issues/5303#change-13859
18:54:34  <Brot6> Webtranslator - Feature Request #5315: "Upload language file" XAlberthX @ http://dev.openttdcoop.org/issues/5315#change-13862
18:57:36  <Brot6> Webtranslator - Bug #5321: "just now ago" XAlberthX @ http://dev.openttdcoop.org/issues/5321#change-13865
19:01:46  <Brot6> Webtranslator - Feature Request #5297: Allow creation of new translation XAlberthX @ http://dev.openttdcoop.org/issues/5297#change-13853
19:02:34  <planetmaker> I think he agreed ;-)
19:02:52  <planetmaker> He told me how to get the admin account I needed to test...
19:03:02  <planetmaker> He experienced the spam life ;-)
19:03:22  <Brot6> Webtranslator - Code Review #5300: Compress view for language overview XAlberthX @ http://dev.openttdcoop.org/issues/5300#change-13868
19:04:45  <Alberth> didn't I write how to make an account in a document?
19:06:00  <Alberth> 5297 does seem like a good suggestion to me, even though it won't get used much :)
19:21:25  <planetmaker> I missed the hint that I need to call the script with the account name
19:25:31  <Alberth> it needs an example or so?
19:26:58  <Alberth> hmm, not good.   I was starting to make a new page, and realized I don't know how to code that :p
19:27:34  <Alberth> while the last time I coded that was just a few weeks ago :p
19:27:54  <planetmaker> :-)
19:28:12  <planetmaker> an example would probably have made me try a parameter, yes
19:28:35  <planetmaker> or it could simply spam usage when called without parameter
19:49:00  <Alberth> added :)
19:49:09  <Brot6> Webtranslator - Revision 177:89579336d652: Doc: Add table of contents, improve description of the 's... XAlberthX @ http://dev.openttdcoop.org/projects/eints/repository/revisions/89579336d652
19:49:09  <Brot6> Webtranslator - Revision 178:8ebb689fdab7: Fix: Report an error when 'editsilly' does not get any us... XAlberthX @ http://dev.openttdcoop.org/projects/eints/repository/revisions/8ebb689fdab7
19:54:19  *** andythenorth has joined #openttdcoop.devzone
19:55:21  <planetmaker> :-)
19:57:23  <Alberth> hi andy
19:59:01  <andythenorth> lo
20:01:01  <Brot6> DACH Trains - Feature #5231: NG sprites XVoyager1X @ http://dev.openttdcoop.org/issues/5231#change-13871
20:01:24  <andythenorth> Alberth: our tester had lots of feedback ;)
20:01:43  <Alberth> yep, thanks planetmaker :)
20:06:24  <planetmaker> oh, my pleasure. And my gain actually ;-)
20:06:38  * planetmaker was selfish ;-)
20:10:08  <Alberth> andythenorth: what do you think of #5297 (Allow creation of new translation) ?
20:10:46  <Alberth> he, no brot spam? :)
20:10:56  <andythenorth> Alberth: no strong opinion (sorry)
20:11:44  <Alberth> k, I like it, although it's not very important
20:14:26  <planetmaker> of course not very important :-) But... another piece which lowers the entry barrier in providing a translation
20:20:32  <Alberth> lol, browsing the string_edit file...     @route("/fix/....)    weird url, did I write that????   oh I did :)
20:22:27  <andythenorth> hmm
20:22:30  <andythenorth> I found a bug btw
20:22:52  <andythenorth> I didn't raise an issue, I cba to figure out the steps to reproduce :)
20:23:08  <andythenorth> use 'FIRS' as the project name
20:23:22  <andythenorth> then restart the app, and try and browse to FIRS project
20:23:24  <andythenorth> should 404
20:23:32  <andythenorth> it's a case issue
20:23:35  <andythenorth> Alberth: ^
20:23:56  <andythenorth> or use of name instead of identifier, or such
20:24:01  <andythenorth> I didn't really look into it :)
20:24:04  <andythenorth> sick kids and so forth
20:24:53  <Alberth> don't get sick as well
20:25:03  <andythenorth> ho ho :)
20:25:23  <Alberth> I wonder whether URLs are case-sensitive
20:25:42  <andythenorth> they are in my browser
20:25:45  <andythenorth> :P
20:25:50  <Alberth> or URIs, actually
20:28:32  <Alberth> can I report an error in a message?
20:28:53  <andythenorth> yup
20:30:12  <Alberth> ...
20:30:31  <Alberth> abort(404, "Language \"{}\" already exists".format(lang.name))    will work too :p
20:30:51  <andythenorth> built in error class?
20:30:53  <andythenorth> useful
20:32:07  <Alberth> bottle function ?
20:32:16  <Alberth> s/?//
20:36:23  <andythenorth> hmm
20:36:31  <andythenorth> where do I find the list of attrs for project class?
20:37:30  <frosch123> looks like my browser forces urls to be lower case up to the /
20:38:00  <frosch123> the rest seems to be case senstive at least on openttd.org
20:38:15  <frosch123> but i do not know anyone who might host using windows :p
20:38:33  <andythenorth> Alberth: do projects have both an identifier (lower case) and a name (mixed case)?
20:38:44  <Alberth> yes
20:38:45  <andythenorth> it looks like they do, but I can't find the definition for the class
20:40:17  <andythenorth> config.py looks promising
20:40:17  <Alberth> webtranslate.data.Project, around line417 is the name, the identifier is  name.lower()
20:42:06  <Alberth> config.ProjectMetaData  seems to have both names :)
20:42:44  <Alberth> the latter is always in memory, Project objects may get dropped when not needed
20:42:55  <andythenorth> I am assuming that templated urls should be using the identifier, not the name
20:43:16  <Alberth> that's a correct assumption
20:43:27  <andythenorth> or I could just call .lower() on all templated urls, but that smells
20:44:11  <Alberth> indeed, I pass proj_name to the templates to prevent that
20:44:16  <andythenorth> yes
20:44:30  <andythenorth> I can't figure out how to replicate that for projects.tpl
20:44:52  <andythenorth> hmm
20:45:18  <andythenorth> I only find 5 uses of .lower() in the project: 3 in bottle, and 2 in newproject.py
20:45:22  <Alberth> pretty sort python file :)
20:45:23  <andythenorth> do I miss some files?
20:45:55  <andythenorth>     redirect("/project/" + name.lower() + '?message=' + message) is why the 404 doesn't show up at project creation time
20:46:56  <Alberth> config.py line 110  for name in os.listdir(self.project_root):    I pull identifiers from the disk filenames
20:47:15  <andythenorth> k
20:47:41  <Alberth> which will break horribly at some systems :p
20:49:57  <Alberth> but you want the config.ProjectCache.projects  variable probably    accessible through  config.cache.projects
20:52:25  <andythenorth> hmm
20:52:34  <andythenorth> ok, 10% confused
20:52:43  <andythenorth> 90% understanding :P
20:52:53  <andythenorth> the 10% is stopping me fixing the bug though :)
20:53:45  *** ODM has quit IRC
20:55:10  <andythenorth> so in scope for projects.tpl I have webtranslate.config.ProjectMetaData objects
20:55:18  <andythenorth> which have name and proj_name properties (seemingly same)
20:55:29  <andythenorth> but I can't spot a declaration for any kind of identifier
20:55:31  <Alberth> config.cache.projects.keys()  should iterate over the identifiers of the projects
20:55:56  <andythenorth> ah
20:56:07  <andythenorth> so I need to change l12 in projects.py?
20:56:31  <Alberth> which should be the same as [pmd.name for pmd in config.cache.projects.values()]
20:57:40  <andythenorth> ok, so I think l12 in projects.py is effectively doing that, only with sorted, with a lamda
20:57:44  <andythenorth> lambda :P
20:57:53  <Alberth> what are you fixing?
20:58:29  <andythenorth> 404
20:58:34  <andythenorth> ah
20:58:49  <andythenorth> config.py l237 is..interesting :)
20:58:49  <andythenorth>         self.proj_name = name # Temporary
20:59:06  <Alberth> you seem to be getting the  PMD list, so you can print the identifier (pmd.name) and the name as we know it (pmd.proj_name)
20:59:17  <andythenorth> name and proj_name are identical :)
20:59:21  <andythenorth> and I just found why ;)
20:59:43  <Alberth> very interesting indeed :)
20:59:44  <andythenorth> self.proj_name = name.lower() ?
21:00:09  <Alberth> the other way around
21:00:20  <Alberth>   @ivar proj_name: Project name for humans.
21:00:31  <andythenorth> ah
21:01:14  <andythenorth> and the 'name' parameter passed is the pretty name passed in from the form?
21:01:22  <andythenorth> self.name = name.lower() ?
21:02:17  * andythenorth wonders why are other cases working correctly
21:02:19  <andythenorth> let's look
21:02:33  <Alberth> line 145 suggests that way
21:03:19  <Alberth> most URIs are build from the name of the project from other URIs
21:04:19  <andythenorth> ah
21:04:30  <andythenorth> not by look up from the object
21:05:12  <andythenorth> should you fix?  or should I?
21:05:17  <andythenorth> I'm not sure what else might break
21:05:20  <Alberth> please go ahead
21:05:41  <andythenorth> so self.name = name.lower() ?
21:05:47  <Alberth> +1
21:06:15  <andythenorth> and remove the 'Temporary' comment on l237?
21:06:27  <andythenorth> works so far :P
21:07:01  <planetmaker> Alberth, however, I'm very much impressed by what I saw yesterday :-) Looks nice and works well from what I saw and tested
21:07:17  <Alberth> andythenorth: yes, remove the comment please
21:07:39  <Alberth> planetmaker: andy did all the looks, my forms looked horrible :p
21:07:58  <planetmaker> form and function go hand in hand there really
21:08:07  <Alberth> but yeah, it's coming along nicely
21:08:10  <planetmaker> both of you did great work there :-)
21:08:29  <andythenorth> I want to make newgrf documentation this way too, but that's another story
21:08:34  <andythenorth> auto-generated :P
21:08:36  <Brot6> Webtranslator - Revision 179:7aaf4cfaf386: Fix: project 'name' attr needed .lower() - fixes a 404 on... XandythenorthX @ http://dev.openttdcoop.org/projects/eints/repository/revisions/7aaf4cfaf386
21:08:58  <planetmaker> andythenorth, the one you highlighted ammler and me some days earlier? I have no issue with that
21:09:17  <andythenorth> Alberth: can we have a proper pretty project name, with spaces, i.e "Squid Ate FISH" and such
21:09:26  <andythenorth> either _ the spaces, or just strip all whitespace
21:09:38  <andythenorth> also a project description was suggested by planetmaker
21:09:51  <Alberth> didn't our tester suggest some more text? :)
21:10:13  <Alberth> extend the form somewhat
21:10:34  <Alberth> hmm, and then it should be added into the project data too of course :p
21:10:36  <andythenorth> I'll do that, it's ok to add attrs?
21:10:48  <andythenorth> I just store it in project metadata?
21:11:01  <Alberth> no, in the data.Project
21:11:09  <Alberth> as that is stored on the disk
21:11:38  <andythenorth> oh :(
21:11:42  <Alberth> there is a save_xml and load_xml function for a project nearby there
21:12:04  <andythenorth> ah
21:12:17  * andythenorth looks for a reliable whitespace strip in python :(
21:12:18  <Alberth> but I can do that, just add the info to the ticket, and I'll have a look in the weekend probably
21:12:31  <Alberth> str.replace
21:12:57  <Alberth> why not add a new field 'name'?
21:13:54  <andythenorth> asking users to create their own identifier is a headache
21:14:03  <andythenorth> we'll have to check for bad chars and such anyway
21:14:09  <andythenorth> we might as well automagic it ?
21:14:53  <Alberth> k
21:15:02  <andythenorth> assumes I can figure out how :P
21:19:35  <andythenorth> maybe I figured out how :)
21:27:14  <andythenorth> ugh
21:27:38  <andythenorth> Alberth: I have something that works, but for reasons that bother me
21:27:45  <Alberth> :)
21:27:49  <andythenorth> mind if I commit it, and you can tell me how stupid it is :P
21:28:46  <Alberth> be my guest :)
21:29:25  <andythenorth> pushed
21:29:29  <andythenorth> l238 in config.py
21:29:48  <Brot6> Webtranslator - Revision 180:e68f2a38ce16: Feature: allow better spaces in the pretty name for a pro... XandythenorthX @ http://dev.openttdcoop.org/projects/eints/repository/revisions/e68f2a38ce16
21:29:55  <andythenorth> so ProjectMetaData objects are created when adding a new project
21:30:00  <andythenorth> and again when reloading from disk
21:30:32  <andythenorth> when adding, the pretty name (proj_name) is available in scope, and also disk_name
21:30:39  <andythenorth> when reloading, only disk_name is in scope
21:30:49  <Alberth> ProjectMetaData are always in memory, and are the record of what projects exist
21:30:55  <andythenorth> yet the templates can all find the proj_name further up the chain
21:31:21  <Alberth> the 'real' project data is in Project, and gets loaded from disk when needed
21:31:36  <andythenorth> makes sense
21:31:48  <andythenorth> I had to do a horrible conditional hack to make it work though :(
21:32:16  <andythenorth> l115 (inside ProjectCache) doesn't have proj_name in scope
21:32:41  <Alberth> I'll have a look in a few days
21:33:03  <andythenorth> it all seems to work
21:33:11  <andythenorth> it's just maybe uglier than you'd like
21:33:22  <andythenorth> I'll raise a ticket
21:33:52  <Alberth> I'll reshuffle stuff :)
21:34:46  <andythenorth> thanks
21:35:17  <andythenorth> is a project description actually useful?
21:35:17  <Alberth> ugh, I forgot to import my new page in main :)
21:35:24  <Brot6> Webtranslator - Code Review #5327 (New): Support for spaces in project names XandythenorthX @ http://dev.openttdcoop.org/issues/5327
21:35:26  <andythenorth> I wonder if a url is more useful
21:35:38  <Alberth> it looks pretty
21:35:43  <andythenorth> we have project descriptions in readme.txt, on devzone, in forums, on grfcrawler, on simuscape....
21:35:46  <Alberth> url can also be useful
21:35:55  <andythenorth> project descriptions age
21:36:08  <Alberth> only url is fine too :)
21:36:15  <andythenorth> I think utl
21:36:17  <andythenorth> url*
21:36:31  <andythenorth> I'll try and make it work
21:36:56  <Alberth> seems useful enough, you're not going to browse the translation service for finding a project :)
21:38:18  <andythenorth> url goes in pdata?
21:38:43  <Alberth> if you want to save it for the next time, yes :)
21:40:33  <Alberth> pushed a new page
21:40:44  <Brot6> Webtranslator - Revision 181:491ca39cb146: Add: Page to add a new translation. XAlberthX @ http://dev.openttdcoop.org/projects/eints/repository/revisions/491ca39cb146
21:41:04  <Alberth> hmm, maybe I should have tested it first :p
21:51:25  *** Supercheese has joined #openttdcoop.devzone
21:58:15  <andythenorth> hm
21:58:21  <andythenorth> so I need to save url into the xml
21:59:35  <andythenorth> that was easy :P
22:01:13  <Alberth> just store it literally, xml does nice encoding for us free of charge :)
22:02:51  <andythenorth> I think I've figured it
22:03:04  <Alberth> k
22:03:36  <Alberth> if you have some time, the new page could use some love from you
22:04:27  <Brot6> Webtranslator - Feature Request #5297: Allow creation of new translation XAlberthX @ http://dev.openttdcoop.org/issues/5297#change-13874
22:05:01  <Alberth> good night andythenorth
22:05:18  <andythenorth> I'll look at the new page
22:05:20  <andythenorth> bye
22:05:21  <Brot6> Webtranslator - Revision 182:2c4de57b7e96: Feature: projects can have a url to their homepage (somew... XandythenorthX @ http://dev.openttdcoop.org/projects/eints/repository/revisions/2c4de57b7e96
22:05:39  *** Alberth has left #openttdcoop.devzone
22:08:25  <Brot6> Webtranslator - Revision 183:a17404e78abd: Change: project homepage link should only be shown if a u... XandythenorthX @ http://dev.openttdcoop.org/projects/eints/repository/revisions/a17404e78abd
22:21:30  *** frosch123 has quit IRC
22:22:02  <Brot6> Webtranslator - Revision 184:62849663e51c: Change: refer to 'website' not 'homepage' for project ext... XandythenorthX @ http://dev.openttdcoop.org/projects/eints/repository/revisions/62849663e51c
22:31:04  *** andythenorth has quit IRC
23:37:27  *** Zuu has quit IRC

Powered by YARRSTE version: svn-trunk