Config
Log for #openttdcoop.devzone on 30th October 2013:
Times are UTC Toggle Colours
00:16:37  *** thiagoxxxx has quit IRC
09:01:50  *** frosch123 has joined #openttdcoop.devzone
12:32:27  *** Supercheese has quit IRC
12:33:00  *** Supercheese has joined #openttdcoop.devzone
13:25:32  *** oskari89 has joined #openttdcoop.devzone
15:53:40  *** oskari89 has quit IRC
16:50:11  <DevZone> Project xussrset - Trains from Russia build #74-push: SUCCESS in 2 min 49 sec: https://jenkins.openttdcoop.org/job/xussrset/74/
16:51:31  <DevZone> Project OpenGFX+ Industries build #58-push: STILL FAILING in 1 min 19 sec: https://jenkins.openttdcoop.org/job/ogfx-industries/58/
16:57:57  <DevZone> Project OpenGFX build #87-push: SUCCESS in 6 min 26 sec: https://jenkins.openttdcoop.org/job/opengfx/87/
16:58:21  <DevZone> Project ISR Industrial Station Renewal build #51-push: SUCCESS in 23 sec: https://jenkins.openttdcoop.org/job/isr/51/
17:00:20  <DevZone> Project OpenSFX build #11-push: SUCCESS in 1 min 59 sec: https://jenkins.openttdcoop.org/job/opensfx/11/
17:02:21  <DevZone> Yippee, build fixed!
17:02:21  <DevZone> Project OpenGFX+ Industries build #59-push: FIXED in 2 min 0 sec: https://jenkins.openttdcoop.org/job/ogfx-industries/59/
17:13:17  <DevZone> Project OpenGFX+ Landscape build #32-push: SUCCESS in 26 min: https://jenkins.openttdcoop.org/job/ogfx-landscape/32/
17:20:56  <DevZone> Project NML - NewGRF Meta Language build #111-nightlies: FAILURE in 2 min 19 sec: https://jenkins.openttdcoop.org/job/nml/111/
17:28:17  <DevZone> Project NML - NewGRF Meta Language build #112-nightlies: STILL FAILING in 1 min 17 sec: https://jenkins.openttdcoop.org/job/nml/112/
17:37:51  <DevZone> Project NML - NewGRF Meta Language build #113-nightlies: STILL FAILING in 3 min 26 sec: https://jenkins.openttdcoop.org/job/nml/113/
17:44:38  <DevZone> Yippee, build fixed!
17:44:39  <DevZone> Project NML - NewGRF Meta Language build #114-nightlies: FIXED in 2 min 34 sec: https://jenkins.openttdcoop.org/job/nml/114/
17:47:12  <DevZone> Project NML - NewGRF Meta Language build #115-nightlies: SUCCESS in 1 min 25 sec: https://jenkins.openttdcoop.org/job/nml/115/
17:47:33  <DevZone> Project ISR Industrial Station Renewal build #52-push: SUCCESS in 19 sec: https://jenkins.openttdcoop.org/job/isr/52/
17:54:14  <DevZone> Project grfcodec build #9-nightlies: SUCCESS in 2 min 58 sec: https://jenkins.openttdcoop.org/job/grfcodec/9/
18:04:52  <DevZone> Project ISR Industrial Station Renewal build #53-nightlies: SUCCESS in 22 sec: https://jenkins.openttdcoop.org/job/isr/53/
18:05:00  <DevZone> Project FIRS Industry Replacement Set build #40-push: FAILURE in 5 min 4 sec: https://jenkins.openttdcoop.org/job/firs/40/
18:07:27  <DevZone> Project finnishtrams build #10-nightlies: SUCCESS in 50 sec: https://jenkins.openttdcoop.org/job/finnishtrams/10/
18:12:29  *** ODM has joined #openttdcoop.devzone
18:13:19  <DevZone> Project FIRS Industry Replacement Set build #41-push: STILL FAILING in 5 min 47 sec: https://jenkins.openttdcoop.org/job/firs/41/
18:22:15  <DevZone> Project FIRS Industry Replacement Set build #42-push: STILL FAILING in 5 min 1 sec: https://jenkins.openttdcoop.org/job/firs/42/
18:27:08  <DevZone> Project Finnish Rail Infrastructure - Rails build #129-nightlies: FAILURE in 31 sec: https://jenkins.openttdcoop.org/job/frissrails/129/
18:31:06  <DevZone> Project Nutracks build #56-nightlies: FAILURE in 30 sec: https://jenkins.openttdcoop.org/job/nutracks/56/
18:32:58  <DevZone> Project FIRS Industry Replacement Set build #43-push: STILL FAILING in 5 min 17 sec: https://jenkins.openttdcoop.org/job/firs/43/
18:40:22  <DevZone> Project FIRS Industry Replacement Set build #44-push: STILL FAILING in 4 min 37 sec: https://jenkins.openttdcoop.org/job/firs/44/
18:42:02  <DevZone> Project OpenGFX+ Industries build #60-nightlies: FAILURE in 25 sec: https://jenkins.openttdcoop.org/job/ogfx-industries/60/
18:43:49  <DevZone> Project Nutracks build #57-nightlies: STILL FAILING in 20 sec: https://jenkins.openttdcoop.org/job/nutracks/57/
18:43:57  <DevZone> Project Finnish Rail Infrastructure - Rails build #130-nightlies: STILL FAILING in 40 sec: https://jenkins.openttdcoop.org/job/frissrails/130/
18:44:45  <DevZone> Project OpenGFX+ Industries build #61-nightlies: STILL FAILING in 55 sec: https://jenkins.openttdcoop.org/job/ogfx-industries/61/
18:46:35  <DevZone> Yippee, build fixed!
18:46:35  <DevZone> Project Nutracks build #58-nightlies: FIXED in 21 sec: https://jenkins.openttdcoop.org/job/nutracks/58/
18:46:57  <DevZone> Yippee, build fixed!
18:46:58  <DevZone> Project Finnish Rail Infrastructure - Rails build #131-nightlies: FIXED in 1 min 14 sec: https://jenkins.openttdcoop.org/job/frissrails/131/
18:47:48  <DevZone> Yippee, build fixed!
18:47:49  <DevZone> Project OpenGFX+ Industries build #62-nightlies: FIXED in 52 sec: https://jenkins.openttdcoop.org/job/ogfx-industries/62/
18:48:59  <DevZone> Project Iron Horse build #353-nightlies: SUCCESS in 1 min 11 sec: https://jenkins.openttdcoop.org/job/iron-horse/353/
18:49:31  <planetmaker> sorry for all the spam :D
18:53:23  <DevZone> Yippee, build fixed!
18:53:23  <DevZone> Project FIRS Industry Replacement Set build #45-push: FIXED in 5 min 54 sec: https://jenkins.openttdcoop.org/job/firs/45/
19:00:38  <Rubidium> fixed the anim house callback thing already?
19:04:55  <DevZone> Project OpenGFX build #88-nightlies: SUCCESS in 6 min 18 sec: https://jenkins.openttdcoop.org/job/opengfx/88/
19:07:52  *** oskari89 has joined #openttdcoop.devzone
19:43:31  <Rubidium> is the house callback being needed a bug of nml, or rather a bug in openttd?
19:43:49  <Rubidium> why would the animation callback be needed at all?
19:47:25  <Rubidium> or is it the fact that nvar = 0 is a special case?
19:56:18  <Rubidium> it seems to be just that
20:24:59  *** gelignite has joined #openttdcoop.devzone
20:26:30  <planetmaker> Rubidium, no, that thing is not yet fixed
20:26:56  <planetmaker> I believe it's a bug in NML, as I can create houses without that (see comic-houses)
20:28:02  <planetmaker> http://bundles.openttdcoop.org/comic-houses/nightlies/LATEST/log/comichouses.nfo
20:29:11  <planetmaker> best seen at the very end of that file
20:33:19  *** ODM has quit IRC
20:38:26  <Rubidium> planetmaker: the bug report says what's effectively the issue
20:39:51  <V453000> certainly not beer
20:44:19  *** gelignite_ has joined #openttdcoop.devzone
20:50:35  *** gelignite has quit IRC
20:52:26  <planetmaker> Rubidium, but why don't we have this issue with other features?
21:03:43  <Rubidium> because for some reason they have some data in there by default?
21:04:14  <Rubidium> it's probably not even happening for houses if you got construction stages
21:05:12  <planetmaker> well. It works, on the cost of a bit bloat nfo :D
21:05:56  <Rubidium> I wonder why the current action 2 is needed if there's nothing there
21:07:47  <planetmaker> sequence always is 3->2->1
21:08:20  <Rubidium> but it's 3->2->2->2
21:08:41  <Rubidium> where the first 2 in this chain (or the last one in nfo) is the troublesome
21:08:48  <frosch123> do you have the nfo output of the forum example as a paste somewhere?
21:10:10  <Rubidium> roughly http://paste.openttdcoop.org/show/2757/
21:10:33  <Rubidium> line 48/49 are, what I perceive as, the troublesome lines
21:10:53  <planetmaker> yes
21:11:03  <planetmaker> it works if you add an empty choice
21:11:29  <planetmaker> and that's what effectively changes with an empty callback added
21:11:55  <Rubidium> as I said before, the 0 in 48 means that the calculated value is returned instead of the value in line 49
21:12:15  <Rubidium> so somehow nml constructs this badly/incorrectly or whatever
21:12:22  <frosch123> does nml always add the callback check in the first action2 ?
21:13:23  <planetmaker> I believe so
21:14:14  <planetmaker> though... regression example 006 (vehicle) seems to contradict
21:14:27  <planetmaker> that is plain 3->2->1
21:14:57  <planetmaker> (and regression tests are still passed)
21:16:04  <planetmaker> also 015 (basic object).
21:17:05  <planetmaker> But iff there is callbacks, then yes
21:22:00  <frosch123> action3.py:379
21:23:30  <frosch123> the create_cb_choice there needs a len(mapping) as in other places
21:26:26  <frosch123> ah, lin 368 is why that issue only accours for houses
21:27:19  <planetmaker> so... amending between 392 and 393 something like if len(mapping) == 0: continue?
21:27:43  <frosch123> it somehow needs to insert the 379 stuff into the a123 chain
21:34:48  <frosch123> paste.openttdcoop.org/show/2758/ <- hmm
21:36:27  <frosch123> hmm, do you already have a testcase prepared?
21:36:51  <frosch123> oh, wait, there are some files on the tracker
21:37:08  <planetmaker> they are quite to the point, yes
21:37:24  <planetmaker> it's actually an example of how I like bug reports :-)
21:38:31  <Rubidium> that seems to do the trick
21:40:15  <Rubidium> night
21:40:31  *** gelignite_ has quit IRC
21:40:37  <frosch123> the output does not look like what i wanted
21:40:40  <planetmaker> g'night Rubidium
21:41:59  *** oskari89 has quit IRC
21:44:13  <frosch123> oh, i have to read the testcase!
21:45:15  <frosch123> yay
21:45:24  <planetmaker> hm?
21:45:42  <frosch123> i only ran wget without looking at the file :p
21:45:49  <frosch123> i had to comment out a line :p
21:46:07  <planetmaker> :-)
21:46:15  <frosch123> but yeah, it seems to work, and does not break the regression
21:46:26  <frosch123> no idea, whether there is a more clever way to solve it though
21:46:49  <planetmaker> wanna give yourself the honour? :-)
21:47:04  <frosch123> which? :p
21:47:09  <planetmaker> to fix that issue :-)
21:47:14  <frosch123> make myself dev, or commit without being dev? :p
21:47:55  <planetmaker> :-P
21:47:59  <planetmaker> no need ;-)
21:48:27  <frosch123> yeah, you know how to acquire employees
21:48:34  <planetmaker> lalalalala :-)
21:48:45  <planetmaker> wasn't that in my job description?
21:49:09  <frosch123> no idea, i was busy chewing cake
21:49:25  <planetmaker> haha :)
21:57:19  <DevZone> Project NML - NewGRF Meta Language build #116-push: SUCCESS in 3 min 34 sec: https://jenkins.openttdcoop.org/job/nml/116/
22:05:58  <planetmaker> \o/
22:13:11  <planetmaker> added now also regression test for that :-)
22:16:33  <DevZone> Project NML - NewGRF Meta Language build #117-push: FAILURE in 28 sec: https://jenkins.openttdcoop.org/job/nml/117/
22:20:31  <frosch123> more tests :)
22:25:32  <planetmaker> oh. missing hg add :-)
22:41:33  <DevZone> Yippee, build fixed!
22:41:33  <DevZone> Project NML - NewGRF Meta Language build #118-push: FIXED in 4 min 20 sec: https://jenkins.openttdcoop.org/job/nml/118/
23:51:24  <DevZone> Project NML - NewGRF Meta Language build #119-push: SUCCESS in 2 min 29 sec: https://jenkins.openttdcoop.org/job/nml/119/
23:54:50  *** frosch123 has quit IRC

Powered by YARRSTE version: svn-trunk