Config
Log for #openttdcoop.devzone on 22nd December 2015:
Times are UTC Toggle Colours
00:10:19  *** skyem123 has quit IRC
01:12:28  *** Supercheese has quit IRC
01:13:01  *** Supercheese has joined #openttdcoop.devzone
03:06:28  *** gelignite_ has joined #openttdcoop.devzone
03:13:51  *** gelignite has quit IRC
04:43:15  *** gelignite_ has quit IRC
08:24:22  <DevZone> Project Finnish Trainset build #251-push: SUCCESS in 7 min 3 sec: https://jenkins.openttdcoop.org/job/finnishtrainset/251/
08:28:11  <juzza1> everything is fine with speeds until line 504 at http://dev.openttdcoop.org/projects/nml/repository/entry/nml/actions/action0.py where they adjusted using ottd_display_speed at line 257 @ http://dev.openttdcoop.org/projects/nml/repository/entry/nml/actions/action0properties.py . It returns weird values, like 9 when input is 10, which leads to all the "rounding" problems we have with speeds. Can anyone remember what this function is suppo
08:28:55  <juzza1> for example, input value of 10 is adjuste to 11, which is then writen to 11 in grf and nfo, but if i change the value back to 10 in nfo and compile with grfcodec, it shows 10 ingame just fine
08:29:44  <juzza1> sorry, meant to say "11 when input is 10"
08:35:43  *** Supercheese has quit IRC
09:13:38  <planetmaker> juzza1, did you test that with newest NML? If you can fix it, please be my guest. The problem is correctly reversing openttd's display speed function and putting it in NML :)
09:13:55  *** skyem123 has joined #openttdcoop.devzone
09:16:51  <DevZone> Project FIRS Industry Replacement Set build #950-push: SUCCESS in 3 min 57 sec: https://jenkins.openttdcoop.org/job/firs/950/
09:26:47  <juzza1> this https://paste.openttdcoop.org/pvwkotkc8 _seems_ to fix it, but I don't know if that's correct or if it will break something else. In any case, a lot of precision is lost when doing "value * 10 // 16" which will lead to the errors
09:29:43  <Rubidium> I think that method is used to determine how the speed will be shown in openttd, so changing the rounding will break that functionality
09:30:27  <Rubidium> having said that, I don't know whether it functions correctly right now; maybe some sort of unit test needs to be made for that to be tested
09:34:45  <juzza1> It's meant to do the same as ToDisplay (http://git.openttd.org/?p=trunk.git;a=blob;f=src/strings.cpp;h=d2ce762b70cf5a4d47967baaace620ee066a2f1c;hb=HEAD line 647)?
09:35:07  <juzza1> the input is in "openttd internal unit" there
09:37:55  <planetmaker> it definitely should get probably more test(s) when it is changed (again) :)
09:38:11  <Rubidium> juzza1: speed displaying calls that with rouding = false
09:38:47  <Rubidium> cargo amounts, heights, power and such are rounded
09:39:04  <Rubidium> so probably NML needs to account for that to in different cases
09:39:52  <Rubidium> anyhow, openttd's internal unit is generally km-ish/hour (where aircraft are actually 8 km-ish/h and ships/RVs 0.5 km-ish/h)
09:40:05  <Rubidium> km-ish/h = mph / 1.6
09:41:01  <Rubidium> but it's a bit of a mess in any case
09:41:52  <Rubidium> if it weren't for NewGRFs using/connecting to OpenTTD at such a low level, we might've been able to unify stuff more and make things simpler
10:06:59  <DevZone> Project xussrset - Trains from Russia build #1249-push: SUCCESS in 6 min 40 sec: https://jenkins.openttdcoop.org/job/xussrset/1249/
12:10:19  *** frosch123 has joined #openttdcoop.devzone
13:25:50  *** skyem1234 has joined #openttdcoop.devzone
13:31:30  <DevZone> Project xussrset - Trains from Russia build #1250-push: SUCCESS in 6 min 51 sec: https://jenkins.openttdcoop.org/job/xussrset/1250/
13:32:26  *** skyem123 has quit IRC
13:48:02  *** yorick has quit IRC
13:55:38  <DevZone> Project World Airliner Set build #1547-push: SUCCESS in 5 min 51 sec: https://jenkins.openttdcoop.org/job/worldairlinersset/1547/
14:14:55  <DevZone> Project xussrset - Trains from Russia build #1251-push: SUCCESS in 7 min 3 sec: https://jenkins.openttdcoop.org/job/xussrset/1251/
14:18:46  *** gelignite has joined #openttdcoop.devzone
16:38:20  *** gelignite has quit IRC
16:59:10  <DevZone> Project xussrset - Trains from Russia build #1252-push: SUCCESS in 11 min: https://jenkins.openttdcoop.org/job/xussrset/1252/
17:04:34  <DevZone> Project Finnish Trainset build #252-push: SUCCESS in 17 min: https://jenkins.openttdcoop.org/job/finnishtrainset/252/
17:07:13  <DevZone> Project FIRS Industry Replacement Set build #951-push: SUCCESS in 8 min 1 sec: https://jenkins.openttdcoop.org/job/firs/951/
17:09:54  <DevZone> Project Dutch Road Furniture build #101-push: SUCCESS in 2 min 41 sec: https://jenkins.openttdcoop.org/job/dutchroadfurniture/101/
17:14:00  <DevZone> Project World Airliner Set build #1548-push: SUCCESS in 9 min 26 sec: https://jenkins.openttdcoop.org/job/worldairlinersset/1548/
17:23:19  <juzza1> strings.cpp line 748 begins the conversion from kmhish->display, it then calls the ToDisplay (line 647) of the unit, with the input value multiplied by 10, and only after the ToDisplay function is done, is the value divided by 16. In nmlc, the value is divided right after multiplication by 10. Am I reading this right? So ottd_display_speed in nmlc should be changed to divide by 16 after other calculations
17:23:28  <juzza1> I am referring to this strings.cpp http://git.openttd.org/?p=trunk.git;a=blob;f=src/strings.cpp;h=d2ce762b70cf5a4d47967baaace620ee066a2f1c;hb=HEAD
17:23:49  <juzza1> ottd_display_speed is at line 257 in http://git.openttd.org/?p=trunk.git;a=blob;f=src/strings.cpp;h=d2ce762b70cf5a4d47967baaace620ee066a2f1c;hb=HEAD
17:24:04  <juzza1> If I do that fix, the values seem right in the output nfo
17:24:52  <juzza1> whoops, ottd_display_speed here http://dev.openttdcoop.org/projects/nml/repository/entry/nml/actions/action0properties.py
17:47:53  <Rubidium> then the implementation in NML might be "wrong"
17:48:01  <juzza1> "svn diff -r 23944:23945 src/strings.cpp" at the ottd source shows the change, before that the division was done earlier (as is in nmlc currently)
17:48:24  <Rubidium> does "(int(value.value / divisor) * 10 * unit.ottd_mul >> unit.ottd_shift) // 16" work?
17:49:08  <juzza1> yes
18:15:41  <DevZone> Project Building sprite test project build #81-nightlies: SUCCESS in 38 sec: https://jenkins.openttdcoop.org/job/sprite-tests/81/
18:17:56  <DevZone> Project xussrset - Trains from Russia build #1253-push: SUCCESS in 6 min 48 sec: https://jenkins.openttdcoop.org/job/xussrset/1253/
19:43:56  *** Supercheese has joined #openttdcoop.devzone
19:54:16  *** Zuu has joined #openttdcoop.devzone
19:58:32  *** oskari89 has joined #openttdcoop.devzone
20:02:59  <DevZone> Project xussrset - Trains from Russia build #1254-push: SUCCESS in 6 min 38 sec: https://jenkins.openttdcoop.org/job/xussrset/1254/
20:44:00  *** gelignite has joined #openttdcoop.devzone
20:59:22  <DevZone> Project xussrset - Trains from Russia build #1255-push: SUCCESS in 6 min 49 sec: https://jenkins.openttdcoop.org/job/xussrset/1255/
22:22:44  <DevZone> Project Finnish Trainset build #253-push: SUCCESS in 8 min 6 sec: https://jenkins.openttdcoop.org/job/finnishtrainset/253/
23:06:07  <DevZone> Project Finnish Trainset build #254-push: SUCCESS in 7 min 16 sec: https://jenkins.openttdcoop.org/job/finnishtrainset/254/
23:14:21  *** skyem1234 has quit IRC
23:24:30  <DevZone> Project xussrset - Trains from Russia build #1256-push: SUCCESS in 6 min 38 sec: https://jenkins.openttdcoop.org/job/xussrset/1256/
23:44:18  *** frosch123 has quit IRC
23:47:15  *** oskari89 has quit IRC

Powered by YARRSTE version: svn-trunk