Times are UTC Toggle Colours
00:08:38 *** FLHerne has quit IRC 01:06:54 <arahael> LordAro: That's 10.13.4, I think. :) 01:18:47 *** Flygon has joined #openttd 01:22:48 *** glx has quit IRC 01:40:07 *** Darkvater has quit IRC 01:40:38 *** Darkvater has joined #openttd 01:40:38 *** ChanServ sets mode: +o Darkvater 03:03:38 *** muffindrake4 has joined #openttd 03:05:30 *** muffindrake3 has quit IRC 03:47:47 *** Pikka has joined #openttd 04:12:53 *** Pikka has quit IRC 04:39:11 *** Wacko1976 has joined #openttd 04:50:21 *** Cubey has quit IRC 04:51:33 *** ToffeeYogurtPots has joined #openttd 05:28:06 *** Wacko1976 has quit IRC 05:39:17 *** Smedles has quit IRC 05:41:57 *** snail_UES_ has quit IRC 05:55:29 *** Arveen2 has joined #openttd 05:59:14 *** Arveen has quit IRC 06:09:50 *** andythenorth has joined #openttd 06:30:02 *** Pikka has joined #openttd 06:31:44 <Pikka> o/ 06:35:17 *** Wacko1976 has joined #openttd 06:35:20 <andythenorth> lo bird 06:37:25 <peter1138> Have you heard the word, about the bird? 06:37:36 <peter1138> The word is 'nrt'. 06:39:03 *** Thedarkb1-X40 has joined #openttd 06:39:47 *** Thedarkb-X40 has quit IRC 06:40:25 <Pikka> that's a funny word 06:40:48 <peter1138> Nrt! Nrt! Larks1 06:40:54 <peter1138> -1+! 06:44:44 *** sim-al2 has quit IRC 06:45:32 *** Smedles has joined #openttd 06:45:47 <andythenorth> Pikka: I fixed up pax and mail a bit http://dev.openttdcoop.org/attachments/download/8964/horse_moo.png 06:45:55 <andythenorth> now we just need a better livery GUI 06:45:59 <andythenorth> even RGB 06:46:20 <Pikka> mmm rgb 06:47:22 <Pikka> bright top pixel on -> yellow end? 06:47:51 <andythenorth> shall fix 06:48:18 <andythenorth> dunno about the steam coaches 06:48:23 <andythenorth> windows are tall 06:49:21 <Pikka> not bad... taller/narrower looks older 06:51:32 <andythenorth> also should Scooby Doo be solid CC? 06:52:31 <Pikka> dunno... I've been keeping the stripe so it all still matches with standard passenger and mail cars. 06:53:40 <peter1138> Better livery GUI? What did you envision? 06:54:05 <andythenorth> (1) usability stuff, get rid of the daft tickbox thing 06:54:24 <andythenorth> (2) 5 types of pax coach, but only 1 freight? 06:54:31 <andythenorth> and pax colour is also mail? 06:54:55 <andythenorth> I don't have a proposed solution, I following truebrain's rule, complain about problem :P 06:55:09 <andythenorth> I wondered about applying livery to groups 06:55:19 <andythenorth> and it's either simple: engine livery, wagon livery 06:55:40 <andythenorth> or it's full wtf: engine livery by type (visual effect), and wagon livery by cargo refit 06:55:41 <peter1138> Wait, you can't? 06:55:52 <peter1138> Was that another thing I had a patch for? :S 06:55:53 <andythenorth> to groups? 06:55:57 <andythenorth> groups don't do anything :) 06:55:59 <andythenorth> no livery 06:56:05 <andythenorth> no management of orders 06:56:12 <andythenorth> no making groups from 'vehicles using this station' 06:56:29 <andythenorth> groups are waste of space, but "hey, they're hierarchical now" 06:57:15 <andythenorth> liveries need a bit of fun applying imho 06:57:30 <andythenorth> it's not a place where 100% logic is required 06:57:31 <peter1138> They're not a waste of space, they just don't do everything you want them to do. 06:58:26 <andythenorth> how do we improve anything without dramatic unreasonable statements though? :P 07:01:09 <peter1138> Hmm, why do I have these old patches? 07:03:17 <peter1138> --- station_cmd.c (revision 2979) 07:03:18 <peter1138> Yeah. 07:04:35 <peter1138> CMD 07:04:38 <peter1138> CMD_SET_GROUP_LIVERY 07:04:42 <peter1138> Yeah, I have a patch for group liveries. 07:04:46 <peter1138> r14316 o_O 07:06:05 <peter1138> Maybe I should rebase it :p 07:06:19 <peter1138> It's 10 years old. 07:08:15 <andythenorth> ha :) 07:23:28 *** andythenorth has quit IRC 07:36:06 <_dp_> peter1138, when your patch is older than some players 07:54:57 <V453000> :D 08:10:49 *** andythenorth has joined #openttd 08:28:45 <andythenorth> Pikka: such coach http://dev.openttdcoop.org/attachments/download/8965/horse_moo_2.png 08:28:53 <andythenorth> dunno about the buffet 08:30:17 <Pikka> first window full size? 08:30:47 <andythenorth> red stripe? :P 08:32:04 <andythenorth> might need to be symmetrical 08:33:19 <andythenorth> yair 08:33:25 <andythenorth> doesn't have to be a buffet, might be something else 08:33:27 <andythenorth> who knows 08:35:31 <Pikka> it's just a different-looking coach in the middle for visual interest 08:35:36 <Pikka> doesn't need to be prototypical ;) 08:35:51 <andythenorth> http://dev.openttdcoop.org/attachments/download/8966/hoose_moo_3.png 08:35:58 <andythenorth> better 08:36:06 <andythenorth> I have to repeat this for 5 other generations, so keep it simple eh 08:36:13 <Pikka> all narrow windows? hmmm 08:36:21 <andythenorth> yair 08:36:34 <andythenorth> I went on a french train with a playground coach in it once 08:36:38 <andythenorth> had a climbing frame 08:37:05 <Pikka> fancy 08:38:37 <Pikka> https://i.imgur.com/JofXoC6.png just need to fill in the gaps :P 08:38:50 <andythenorth> ha 08:39:04 <andythenorth> who will finish first? :P 08:40:03 <Pikka> are your coaches all symmetrical? I'm wondering if early coaches having different corridor sides will confuse people 08:41:41 <andythenorth> they're not all symmetrical no 08:41:56 <andythenorth> but generally I'm finding symmetry looks better, and is faster to work with 08:47:54 <V453000> andythenorth and Pikka drawing trains? Did I just wake up 10 years ago? :D Sounds great! 08:49:59 <andythenorth> and OpenTTD is dying again V453000 ! 08:50:04 <andythenorth> new github and everything 08:50:17 *** ToffeeYogurtPots has quit IRC 08:50:19 <V453000> holy shit :) 08:51:15 <V453000> I will just fix PURR tonight and lets see if I can proceed with some work on some trains too :) 08:54:27 <andythenorth> I rearranged all my spritesheets 08:54:45 <andythenorth> so that the columns and rows match photoshop 'press cursor' distance 08:55:37 <V453000> press cursor? 08:55:45 <andythenorth> shift-cursor key 08:55:49 <andythenorth> when using marquee or move tool 08:55:54 <V453000> oh :D 08:55:57 <V453000> "ok" :D 08:56:03 <andythenorth> they used to be off by 1 or 2 08:56:05 <andythenorth> drove me nuts 08:56:11 <V453000> nuts eh 08:56:11 <andythenorth> I wrote a PIL script to move everything 08:56:27 <V453000> not too surprised byu that :?D 08:56:34 <V453000> can't imagine moving everything by hand 08:56:40 <V453000> don't even want to guess how many sprites do you have 08:59:30 <andythenorth> done the short coaches too http://dev.openttdcoop.org/attachments/download/8967/horse_moo_4.png 08:59:45 <andythenorth> V453000: only about 10 or 20 thousand 09:00:09 <V453000> could be worse but it's still a lot :) 09:00:26 <V453000> very nice wagons, I love the variety 09:00:40 <andythenorth> someone said horse is too flat 09:00:42 <andythenorth> and needs noise 09:00:44 <andythenorth> but eh 09:00:51 <andythenorth> I am -1 to random noise crap 09:01:08 <andythenorth> Pikka planning to add random noise? o_O 09:01:23 <V453000> I think it's in a good spot 09:01:31 <andythenorth> noise just damages the shape 09:01:32 <V453000> judging from these pictures here atm 09:01:39 <andythenorth> it's for people who can't actually draw shapes 09:01:48 <andythenorth> "wtf this is getting hard, I splatter some pixels" 09:02:04 <V453000> yar 09:02:20 <V453000> it's not like it's completely flat, you have a bunch of "random" pixels there, and the window variety does a lot 09:02:42 <V453000> I think iz nice 09:02:49 <Pikka> I've a little bit of noise on, eg, coach roofs. but not too much. 09:03:40 <Pikka> there's enough variety in the shading that nothing looks "flat" anyway 09:03:50 <V453000> Pikka: do you 3D? :) 09:04:32 <Pikka> not for UKRS3, or anything else I'm working on at the moment 09:04:48 <V453000> so classic pixel pushing? :) 09:05:14 <Pikka> and some procedural generation with Processing 09:05:15 <V453000> so, working on UKRS3? What are the ideas for it if I may ask? 09:05:23 <peter1138> HELLO 09:05:25 <V453000> :0 procedural generation? :0 09:05:28 <V453000> HI 09:06:00 <peter1138> andythenorth, new carriages. 09:06:04 <peter1138> er... 09:06:07 <peter1138> andythenorth, nice carriages. 09:06:11 <andythenorth> fanks :) 09:06:18 <andythenorth> can mess up the consist quite a bit http://dev.openttdcoop.org/attachments/download/8968/horse_moo_5.png 09:06:23 <peter1138> Now do some dirty variations ;p 09:06:35 <Pikka> oh dear 09:06:36 <andythenorth> well I could 09:06:41 <andythenorth> but no eh 09:06:45 <Pikka> openttd needs more weathering or something 09:06:45 <peter1138> :-) 09:06:49 <andythenorth> layers 09:07:07 <andythenorth> weathering script in PIL 09:07:13 <andythenorth> would totally work 09:07:26 <V453000> darken all pixels by 1 index 09:07:28 <V453000> G_G 09:07:28 <andythenorth> apply 7 random pixels of dirt to each sprite 09:07:53 <andythenorth> V453000 that won't work because Livery Aging isn't allowed because 32 day callback is all wrong 09:07:55 <andythenorth> or something 09:08:06 <andythenorth> someone closed that issue anyway :) 09:08:06 <Pikka> V: http://pikkarail.com/announcements/hello-again-world/ - more pixels, more colours, slightly fewer - or at least different - BAD FEATURES 09:08:23 * andythenorth must to BBL 09:08:24 *** andythenorth has quit IRC 09:08:52 <V453000> Pikka: omg nice, will read, thanks :) 09:09:06 <peter1138> Patreon! 09:09:29 <Pikka> yep! 09:10:57 <V453000> so drawing 32bpp x2 eh :) very nice 09:11:37 <V453000> I'll probably keep trying to smash my head against 3D for my next trains 09:11:44 <Pikka> it seems to be the sweet spot... big enough for more detail, small enough that the pixel-drawing style still works 09:12:44 <peter1138> I regret making 4x ;( 09:12:58 <V453000> very nice, yeah x4 is crazy much 09:12:58 <Pikka> :O 09:12:59 <peter1138> It only started out as a zoom level originally. 09:13:27 <V453000> how well do the graphics work in x1? 09:13:32 <V453000> I guess very well :) 09:14:07 <Pikka> x1 is dots moving around a screen at modern resolutions anyway :P but yes, not bad. 09:14:35 <V453000> :D 09:14:38 <V453000> right 09:14:58 <V453000> yeah I changed my screen as well and everything is a bit smaller ._. 09:15:32 <peter1138> I might find myself a high resolution monitor. 09:19:37 <V453000> I feel like no matter what I do with 3D rendered stuff, it won't look better than your 32bpp x2 hand drawn stuff ... might be influenced by the fact that your stuff is simply awesome art :D 09:21:10 *** WWacko1976-work has joined #openttd 09:22:52 <peter1138> Hmm, 31" 8K monitor... 09:23:11 <V453000> x16 coming? 09:23:59 <peter1138> :D 09:24:13 <peter1138> I may need to upgrade my RAM again. 09:24:58 <Pikka> :) well it's all different, V... hand-drawn vs rendered, "realistic" vs fantastical... 09:27:02 <V453000> yeah my things might not even look like trains almost at all 09:27:32 <V453000> regardless I think I need so many different sprites that hand drawing is simply not viable for me atm 09:30:33 *** Stimrol has joined #openttd 10:20:29 <Eddi|zuHause> i have two 2GB DDR2-1000something RAMs lying around here that my friend gave me from his computer that died 10:20:59 <Eddi|zuHause> no idea what i would use those for 10:46:06 <LordAro> paint scrapers 10:59:29 *** Pikka has quit IRC 11:06:58 *** FLHerne has joined #openttd 11:12:25 *** TheMask96 has quit IRC 11:13:32 *** TheMask96 has joined #openttd 11:13:55 <peter1138> I was using that sort myself up until a couple of months ago. 11:22:25 <Eddi|zuHause> i think it's slightly too low for putting into my current computer 12:05:38 <peter1138> So when I was upgrading my PC I decided to put off getting a new GPU until a month later. 12:05:44 <peter1138> Then the prices went up :( 12:21:57 <Eddi|zuHause> i was considering getting a new PC for the past year, but never got around to doing it 12:22:13 <Eddi|zuHause> i could use a laptop 12:38:17 *** snail_UES_ has joined #openttd 12:41:04 *** andythenorth has joined #openttd 12:44:23 <Sacro> Eddi|zuHause: then you could leave the hause 12:44:39 <Eddi|zuHause> scary thought 12:44:49 <Sacro> Yeah 12:45:04 <Eddi|zuHause> i'd have to think of a new nick 12:45:19 <Sacro> Eddi|zuKirche 12:45:29 <Sacro> I can't think of many german places to go 12:50:49 *** snail_UES_ has quit IRC 12:52:20 *** tokai has joined #openttd 12:52:20 *** ChanServ sets mode: +v tokai 12:53:58 *** sim-al2 has joined #openttd 12:54:08 <Eddi|zuHause> it's more complicated than that, you also have to change the preposition 12:54:21 <Sacro> Eddi|zumKirche 12:54:23 <Sacro> I think 12:54:31 <Sacro> or would it be aus? 12:54:36 <Eddi|zuHause> bei/auf/über/... 12:54:51 <Eddi|zuHause> possibilities are endless 12:56:15 <Eddi|zuHause> "zu" only works for going to a place, not staying at a place. except for home 12:56:42 <Eddi|zuHause> (and a few special cases, too) 12:57:48 <Eddi|zuHause> ("zu Tisch" comes to mind, although that is a rather old fashioned phrase) 12:59:09 <Eddi|zuHause> (although that rather describes the process of eating rather than staying at a table) 12:59:20 *** tokai|noir has quit IRC 13:47:27 *** sla_ro|master has joined #openttd 14:04:10 *** Alberth has joined #openttd 14:04:10 *** ChanServ sets mode: +o Alberth 14:04:21 <Alberth> o/ 14:08:15 <andythenorth> lo Alberth 14:08:28 <Alberth> hi hi andy 14:19:32 <V453000> yoyoyo 14:23:29 <Alberth> he, a V, hi hi 14:23:36 <LordAro> o/ 14:23:54 *** andythenorth has quit IRC 14:50:26 *** andythenorth has joined #openttd 15:01:07 *** synchris has joined #openttd 15:11:59 <andythenorth> well 15:14:28 <Alberth> isn't it? 15:17:13 <andythenorth> I think so 15:18:39 <andythenorth> diesel engines are going to get a 2nd livery, which shows when the engine is flipped 15:18:44 <andythenorth> I was trying to avoid this :P 15:18:48 <andythenorth> but eh 15:18:56 <Alberth> upside down engine 15:27:34 *** Wormnest has joined #openttd 15:34:07 <peter1138> Just spent an hour diagnosing code that failed to work. 15:34:10 <peter1138> Then it started working. 15:34:16 <peter1138> I... dunno. 15:38:46 <andythenorth> usually when I do that, I'm in the wrong repo :P 15:38:47 <Alberth> git status ? 15:38:58 <andythenorth> remarkably often when I have multiple checkouts 15:39:06 *** Cubey has joined #openttd 15:47:15 *** TheMask96 has quit IRC 15:49:30 *** TheMask96 has joined #openttd 15:49:37 <andythenorth> I guess we wouldn't allow 4 flipped states? o_O 15:49:55 <andythenorth> NewLiveryHacks 15:51:36 <Alberth> I can't quite imagine what 4 flipped states would mean 15:52:04 <andythenorth> it's just a counter on how many times user has flipped the vehic;e 15:52:08 <andythenorth> vehicle * 15:52:49 <andythenorth> it's another silly idea for arbitrary, user-editbale storage per vehicle 15:52:59 <andythenorth> similar to cargo subtypes, and just as bad 15:53:43 *** Gja has joined #openttd 16:03:58 <Eddi|zuHause> if that's not a BAD FEATURE waiting to happen, then i don't know 16:04:53 <Eddi|zuHause> on a related note: is the flipped state kept through autoreplace? 16:06:12 <andythenorth> dunno 16:06:14 <andythenorth> let's see 16:06:23 <andythenorth> I doubt it somehow 16:07:45 <andythenorth> oh seems to be 16:07:54 <andythenorth> colour me surprised :P 16:08:18 <Eddi|zuHause> now try autoreplacing with engines that cannot be flipped :p 16:09:28 <andythenorth> that's why I'm surprised it works at all 16:09:35 <andythenorth> I guess something just copies as many props as possible 16:15:35 <andythenorth> peter1138: how about default company colour settings per vehicle in buy menu? o_O 16:15:37 <andythenorth> too much? o_O 16:18:51 *** Progman has joined #openttd 16:20:09 <Alberth> multi-company buy menu or so? 16:21:41 *** frosch123 has joined #openttd 16:21:50 <andythenorth> 'buy this vehicle in red' 16:21:56 <andythenorth> 'buy this vehicle in pink' 16:22:02 <andythenorth> I know the train fans want the real liveries 16:22:03 <andythenorth> but eh 16:22:17 <andythenorth> CC is more fun, by miles 16:23:19 <andythenorth> nns 16:23:21 <andythenorth> bbs even 16:23:22 *** andythenorth has quit IRC 16:32:18 <peter1138> Per vehicle. No. 16:33:12 <TrueBrain> frosch123: #6730, assuming he is asking because he wants to implement it, is tha tsomething we accept PRs for? 16:33:54 <frosch123> that guy has forked cppcheck, i guess they check every project on github :) 16:34:43 *** andythenorth has joined #openttd 16:34:54 <TrueBrain> but does he make any chance if he would make those PRs? :) 16:35:04 <andythenorth> @seen supermop 16:35:04 <DorpsGek> andythenorth: supermop was last seen in #openttd 6 days, 2 hours, 23 minutes, and 26 seconds ago: <supermop> should look good out of the box 16:35:30 <frosch123> TrueBrain: for "strdup" certainly not :) 16:35:58 <frosch123> i would rather use std::string everywhere, than checking success of memory allocation 16:36:01 *** Flygon has quit IRC 16:36:45 <frosch123> i wouldn't even know what ottd should do if strdup fails 16:36:56 <TrueBrain> exit :P 16:37:28 <LordAro> TrueBrain: i get that warning with gcc7.3 16:37:47 <TrueBrain> LordAro: I just dislike issues with too little information 16:38:00 <TrueBrain> learning peopl ehow ot write proper bug reports is also a goal in life :) 16:38:21 <LordAro> discussed it with frosch123 before, it's probably spurious 16:38:33 <LordAro> there's several lines in that file that are very similar, but only that one triggers it 16:38:39 <frosch123> yes, i also though thar lordaro came with that before :) 16:39:17 <LordAro> https://github.com/LordAro/OpenTTD/commit/7ba154ad4e353eb7bf8d89819115f4ec8707c748 indeed so 16:39:25 <frosch123> TrueBrain: actualy, rb already removed all usages of strdup, it only exists in depend.cpp 16:40:09 <TrueBrain> frosch123: wrote a nice reply (I tihnk) :) 16:40:23 <TrueBrain> in general I am tempted to close all these kind of tickets like that; let me know ifyou agree with the content or not :) 16:41:19 <frosch123> you should have written lordaro instead of frosch :) 16:41:36 <TrueBrain> sure, next time :) 16:42:06 <TrueBrain> I just hope the content of tickets improves .. so far I only have seen ambigous reports :( 16:43:36 <TrueBrain> really considering an issue template, if this continues :) 16:43:38 <LordAro> needs a CONTRIBUTING.md 16:43:40 <LordAro> :p 16:43:41 <TrueBrain> that too 16:43:44 <TrueBrain> hurry up LordAro 16:43:48 <TrueBrain> get that in there! 16:44:00 <andythenorth> which? http://dev.openttdcoop.org/attachments/download/8970/horse_tee_pee_o.png 16:44:09 <andythenorth> RL is http://www.rmweb.co.uk/community/uploads/monthly_10_2012/post-9992-0-11240700-1351002235.jpg 16:44:18 <andythenorth> but I want the one that looks best, not most realism 16:44:35 <frosch123> bottom 16:45:04 <andythenorth> I am glad you said that 16:45:16 <andythenorth> reinforces my prejudice :) 16:45:42 <LordAro> TrueBrain: find the hackmd.io link from yesterday! 16:46:03 <TrueBrain> LordAro: I think I wrote enough bla for one week :P Now it is up to you and andythenorth :) 16:46:20 <andythenorth> I will write some in a bit, once chores are done 16:46:31 <TrueBrain> :) 16:46:38 <andythenorth> if I get stuck on some sections I'll leave them out and ship a v1 16:46:44 <andythenorth> something is better than nothing here 16:48:14 <LordAro> aye 16:48:53 *** Thedarkb has joined #openttd 16:56:29 *** agentw4b has joined #openttd 16:59:30 *** glx has joined #openttd 16:59:30 *** ChanServ sets mode: +v glx 16:59:46 *** Wolf01 has joined #openttd 16:59:47 <TrueBrain> the GitHub went from 50 unique visitors to 300 after the forum post :) seems people read forums :) 17:00:05 <TrueBrain> owh, no, not forums 17:00:07 <TrueBrain> was via the website 17:00:15 <Wolf01> o/ 17:00:17 <TrueBrain> so people read news posts :) 17:01:50 <TrueBrain> frosch123: coding style bla, what is your opinion on #6726 ? :) 17:03:15 <TrueBrain> LordAro: my ICC license is in btw 17:03:21 <LordAro> as is mine :) 17:07:54 <Wolf01> peter1138: I read the comments about the TODOs, I think some of them aren't really TODOs, or they were just put there for later refactoring, I would focus on the ones with the subtypes and the SE one (if really needed to check roadtype availability) 17:11:23 <andythenorth> lo Wolf01 17:12:24 <peter1138> I just went through and posted where there are TODOs. 17:12:53 <TrueBrain> lol, 50 euro per month to rent a virtual mac :D 17:12:58 <TrueBrain> pretty smart .. 17:13:11 <TrueBrain> or 1 dollar per hour 17:13:17 <andythenorth> there are / hour versions 17:13:20 <andythenorth> oh you found it :P 17:13:22 <TrueBrain> :D 17:13:30 <TrueBrain> that is smart 17:13:31 <andythenorth> how many hours / month we need? 17:13:48 <TrueBrain> 2 hours per release or so 17:13:55 <andythenorth> I could just hang an old mac off my network, but eugh 17:14:00 <andythenorth> then I am responsible 17:14:09 <TrueBrain> which is the biggest issue :) 17:14:15 <andythenorth> I can donate / month for mac host easy 17:14:18 <peter1138> Still having issues cross-compiling it? :( 17:14:27 <TrueBrain> that is not an issue that will be solved 17:14:47 <TrueBrain> as fundamentally, having a 3rd party implement fixes, never results in good results :) 17:14:55 <frosch123> TrueBrain: what is the question about 6726? the one you already answered? 17:15:12 <TrueBrain> I was just wondering if there is a bigger line in OpenTTD source there 17:15:24 <TrueBrain> I know we used to do it like that; but that was 10 years ago :D 17:15:40 <frosch123> we have LAST for the last valid item, and END for the first invalid item 17:15:53 <frosch123> as long as those are not mixed, i am fine 17:16:00 <TrueBrain> cool; tnx :) 17:16:11 <TrueBrain> peter1138: can we introduce unit tests? :D 17:16:49 *** muffindrake has joined #openttd 17:16:49 <peter1138> Haha 17:17:11 <peter1138> I just wanted some way to see it working without me having to think about it :p 17:17:37 <TrueBrain> screenshot? 17:17:51 <TrueBrain> or what were you tihnking about? 17:18:05 *** agentw4b has quit IRC 17:18:39 *** agentw4b has joined #openttd 17:18:41 *** muffindrake4 has quit IRC 17:20:17 <Wolf01> frosch123: do you remember what you intended to do in those TODOs? https://github.com/andythenorth/NotRoadTypes/issues/22 the "Road is always available" ones 17:20:47 <andythenorth> nope 17:20:50 <andythenorth> much time ago :| 17:21:12 *** FLHerne has quit IRC 17:22:03 <Wolf01> I would really like unit tests 17:22:48 <Wolf01> At least to be sure the 43563467476 cases of a simple function which checks if something is allowed to do in a tile work as intended 17:23:00 *** Gja has joined #openttd 17:23:43 <Wolf01> And I don't speak for the functions with 1e238 cases, there would be really helpful 17:25:19 <peter1138> TrueBrain, something that uses the new string codes, I guess. 17:25:34 <frosch123> Wolf01: that is all around "town always build road" 17:25:48 <peter1138> I can see the code probably works, but I've not tried it. 17:25:52 <frosch123> there must be some road available so town can grow 17:26:19 <frosch123> when i was working on that branch towns always built ROAD, so ROAD was always required 17:26:20 <Wolf01> Ok, then I could have handled the cases on the branch 17:26:51 <Wolf01> Still missing a lot of things, but the core part for towns is there 17:28:36 <frosch123> everytime i see a wot ad, i think of andy 17:28:40 *** agentw4b has quit IRC 17:29:56 <andythenorth> it was the ads that got me playing 17:30:02 <andythenorth> but now I've stopped 17:30:17 <andythenorth> I only have limited tolerance for being sent abusive DMs 17:36:04 *** cHawk has quit IRC 17:55:57 *** cHawk has joined #openttd 17:58:25 *** FLHerne has joined #openttd 18:06:14 *** HerzogDeXtEr has joined #openttd 18:14:45 <andythenorth> http://dev.openttdcoop.org/attachments/download/8971/horse_tee_pee_o_2.png 18:15:08 <andythenorth> occasionally it shows a this sort of thing https://hattonsimages.blob.core.windows.net/products/39-435_32967_Qty1_1.jpg 18:22:47 *** FLHerne has quit IRC 18:23:05 *** FLHerne has joined #openttd 18:24:08 <Thedarkb> Did you sort out the library issue on the Debian/Ubuntu build machines? 18:35:18 *** cHawk has joined #openttd 18:47:45 *** sim-al2 is now known as Guest128 18:47:46 *** sim-al2 has joined #openttd 18:49:58 <andythenorth> so many open tabs 18:50:11 <andythenorth> one of them has lordaro's CONTRIBUTING paste in it 18:50:15 <andythenorth> :P 18:50:31 <andythenorth> https://hackmd.io/IwUvFkoFTR6kuxZAdlLr-w?edit 18:51:59 *** Guest128 has quit IRC 18:58:19 <TrueBrain> smee I finally found a good wy to make an SDK :) 18:58:56 <TrueBrain> but extracting XCode TAKES FOR EVER :) 18:59:31 *** iSoSyS has joined #openttd 19:00:14 <peter1138> TrueBrain, how do i pull a PR locally? 19:00:38 <TrueBrain> peter1138: google.com :) Something with refs/pull/<number>/head .. never sure about syntax 19:00:45 <TrueBrain> git fetch upstrean refs/pull/1111/head ? 19:03:16 <peter1138> Ah, git fetch upstream refs/pull/6726/head:6726 < makes a local branch called 6726. 19:03:28 <peter1138> Thanks for the hint :p 19:03:55 <TrueBrain> FETCH_HEAD .. local branch .. tomato tomat :) 19:05:00 *** synchris has quit IRC 19:09:41 <peter1138> Hmm, what's the optimal -j for parallel compiling these days? 19:09:53 <peter1138> cores, cores * 2, cores + 1, ... 19:09:57 <LordAro> cores 19:10:12 <debdog> -j$(nproc) 19:10:38 <peter1138> what about hyperthreading? 19:10:42 <TrueBrain> if your system has HT, cores is sufficient. If it doesnt have HT, add a few more 19:10:55 <TrueBrain> HT on its own will keep your CPU busy enough 19:11:05 <debdog> (except one has many cores but little ammount of RAM) 19:11:25 <TrueBrain> little ram? *looks at his machine, looks at debdog, looks back at his machine* NAH! :D 19:11:58 <TrueBrain> that would mean compiling a single file takes more than 1GB :P 19:12:00 <TrueBrain> doubt it :) 19:12:04 <debdog> so, you prolly not one of these exceptions 19:14:07 <TrueBrain> finding out which Xcode dropped 10.12 SDK feels like downloading every version :( 19:15:02 <TrueBrain> owh well, 10.13 should work .... :D 19:20:46 *** sim-al2 has quit IRC 19:22:15 <TrueBrain> andythenorth: which clang version does your OSX have? 19:22:54 <andythenorth> Apple LLVM version 9.0.0 (clang-900.0.39.2) 19:23:01 <andythenorth> Target: x86_64-apple-darwin16.7.0 19:24:05 <TrueBrain> ty :) 19:24:16 <LordAro> now try to work out what actual LLVM version number that corresponds to 19:26:30 <TrueBrain> 16.7 is weird .. 10.11 was darwin15 .. so 12 and 13 are 16? OSX is funny 19:36:18 <andythenorth> we got any other licenses besides GPL v2? 19:36:29 <TrueBrain> 3rd party stuff? 19:36:49 <TrueBrain> hmm .. andythenorth, which OSX version are you running? 19:36:58 <TrueBrain> I assumed 10.13, but new information suggestions different :D 19:36:58 <andythenorth> 10.12.6 19:37:01 <TrueBrain> ah :D 19:37:02 <TrueBrain> my bad :)_ 19:37:04 <andythenorth> 10.13 is well dodgy 19:37:04 <TrueBrain> should have asked :P 19:37:12 <andythenorth> Apple clown shoes 19:37:33 <andythenorth> I might have to rewrite CONTRIBUTING.md from scratch 19:37:37 <andythenorth> it's MIT / CC 19:37:39 <andythenorth> not GPL 19:37:59 <TrueBrain> the file is licensed? 19:38:07 <andythenorth> of course 19:38:17 <andythenorth> everything is licensed everywhere, etc 19:38:18 <TrueBrain> GitHub too has suggestions btw 19:39:46 <andythenorth> I'm starting to go off GPL 19:39:55 <andythenorth> I was a big fan, but it's problematic 19:40:03 <TrueBrain> it always has been 19:40:09 <TrueBrain> MIT is a bit nicer license 19:40:14 <TrueBrain> or CC- variants, if you want to be more picky 19:40:18 <TrueBrain> but GPL .. is always .. icky 19:40:48 <andythenorth> I discovered my newgrfs were violating it 19:40:56 <andythenorth> so I've had to armchair lawyer some stuff 19:41:17 <TrueBrain> if you touch anything GPL .. CONCRATZ! YOU ARE NOW GPL TOO :P 19:44:30 <andythenorth> yeah, so what am I going to do? 19:44:38 <andythenorth> not use fonts in my project because WOO FONTS 19:44:48 <andythenorth> not provide html documentation because WOO BOOTSTRAP IS MIT :) 19:44:49 *** sla_ro|master has quit IRC 19:44:49 <andythenorth> nah 19:46:26 <TrueBrain> :D 19:47:48 *** gelignite has joined #openttd 19:51:39 <LordAro> i thought i recognised the name from somewhere - elfring also hit freerct with a load of useless issue reports 19:52:15 <peter1138> :/ 19:52:31 <TrueBrain> and he seems unable to read a response I guess *shrug* 19:52:54 <TrueBrain> it almost feels like a bot tbh :) 19:52:56 *** elfring has joined #openttd 19:53:04 <TrueBrain> talking of which :) 19:53:18 <TrueBrain> LordAro: frosch123 told me to point him to you :) 19:53:50 <andythenorth> what's the deal with 80 char formatting in CONTRIBUTING.md? 19:53:55 <peter1138> Yeah, that comment is... not relevant to what you wrote. 19:53:59 <andythenorth> currently it's mixed, and looks daft 19:54:02 <TrueBrain> andythenorth: ditch it; new rule: newline at the dot 19:54:07 <andythenorth> https://hackmd.io/IwUvFkoFTR6kuxZAdlLr-w?view 19:54:07 <TrueBrain> that makes reviewing SO MUCH EAISER 19:54:25 <elfring> How do you think about to improve error detetection and corresponding exception handling for this software? https://github.com/OpenTTD/OpenTTD/issues/6730 19:54:35 <peter1138> There we go. 19:54:45 <andythenorth> TrueBrain: "at the dot"? o_O 19:55:10 <TrueBrain> elfring: we welcome any PR within sanity :) Talk to LordAro if you want to see if your PR has merrit before creating it :) Saves a lot of time for both you and us :) 19:55:21 <TrueBrain> andythenorth: yes :) So 1 sentence per line 19:55:24 <andythenorth> ok 19:55:26 <TrueBrain> means a diff means something 19:55:26 <andythenorth> wfm 19:55:32 <andythenorth> 80 chars is so old 19:55:33 <TrueBrain> not saying we should :) Just saying it really helped me :) 19:55:44 <TrueBrain> well, the issue is if you change 1 word, you have to change the whole block :D 19:55:52 <andythenorth> we had a thing at work about 80 chars for a while so someone could read it in their phone or something 19:56:06 <andythenorth> or because they had 25 bash windows open inside emacs 19:56:10 <andythenorth> anyway we sacked that 19:56:14 <andythenorth> makes for bad python code 19:56:19 <TrueBrain> I have an ongoing discussion .. tempted to buy better screens for those people :P 19:56:25 <elfring> Which contributors will care for more complete exception handling? 19:56:33 <TrueBrain> for Python I do 120 .. to keep people a bit in line :) 19:56:42 <TrueBrain> elfring: same question, same answer 19:57:09 <peter1138> I was wondering about getting a 4K monitor... 19:57:11 *** cHawk has quit IRC 19:57:18 <peter1138> Then I realised I'd probably want three. 19:57:25 <TrueBrain> I want a 27" 2k .. but it is so hard to find a good one :( 19:57:27 <peter1138> And *then* I saw that an 8K monitor exists... 19:58:39 <andythenorth> TrueBrain: those people don't work with me anymore ;) 19:58:56 <andythenorth> ok this is nearly ready for v1 I think https://hackmd.io/IwUvFkoFTR6kuxZAdlLr-w?view 19:58:57 <TrueBrain> you didnt like the pun? 120 chars? In line? :) 19:59:13 <andythenorth> I did but eh 19:59:18 <andythenorth> CONTRIBUTING.md !!!! 19:59:21 <elfring> LordAro: Would you like to clarify exception handling any more? 19:59:31 <andythenorth> I'm sure some links are broken 20:00:25 <TrueBrain> elfring: no, Open Source works differently; what error flow do you intend to correct? 20:02:06 <elfring> TrueBrain, LordAro: Static source code analysis can point some open issues out in this case. 20:03:18 <TrueBrain> elfring: I am not looking for reports of what is wrong; I am looking for people to fix those issues via Pull Requests :) 20:03:46 <TrueBrain> we run Coverity over our code; we do static analysis :) 20:04:07 <TrueBrain> just not every warning is worth the time of fixing :) 20:04:28 <TrueBrain> LordAro: indeed, GCC 7.2 is throwing that error; guess I should add it to the CI soon :P 20:05:21 <andythenorth> ok this is near done https://github.com/andythenorth/OpenTTD/blob/CONTRIBUTING.md/CONTRIBUTING.md 20:05:23 <elfring> TrueBrain, LordAro: There are a few design approaches available to improve the affected software situation. 20:05:30 <andythenorth> just needs "WRITE ABOUT CI HERE" removed or written 20:05:38 <andythenorth> $someone ^ 20:05:48 <TrueBrain> *looks around* nope andythenorth :) 20:05:48 <andythenorth> then I PR it as a single commit 20:05:51 <TrueBrain> maybe tomorrow :) 20:06:10 <andythenorth> does it really need details today? 20:06:15 <TrueBrain> elfring: are you planning on writing code to apply those approaches? :) 20:08:35 <elfring> TrueBrain, LordAro: Which warnings did you get by the tools Coverity and GCC for the mentioned issue? 20:09:02 <TrueBrain> elfring: how is that relevant? 20:10:03 <elfring> TrueBrain: I am looking for acceptance possibilities for affected software design aspects. 20:10:22 <TrueBrain> elfring: do you plan on implementing those possibilities in code? 20:10:29 <andythenorth> TrueBrain: [distracting you here] "Continuous integration (CI) tools monitor pull requests, and help us identify build and code quality issues. The results of CI tests may show on the pull request." 20:10:35 <andythenorth> can I ship that? 20:11:01 <andythenorth> better than "WRITE ABOUT CI HERE" 20:11:11 <TrueBrain> The results of the CI tests will show on your pull request. By clicking on Details you can further soom in; in case of a failure it will show you why it failed. In case of success how awesome you were. 20:11:23 <TrueBrain> soom? SOOM! 20:11:24 <andythenorth> ok 20:11:25 <TrueBrain> zoom :) 20:11:32 <TrueBrain> possibly rephrase a bit 20:11:34 <TrueBrain> but you get the jizz :) 20:11:43 <TrueBrain> it is not MAY show .. it WILL show :) 20:11:49 <elfring> TrueBrain: Higher level development tools can help more to improve also this software, can't they? 20:11:55 <TrueBrain> (without a success,i you cannot accept pull requests andythenorth :)) 20:12:13 <TrueBrain> elfring: not the question; I ask if YOU are willing to contribute with code? 20:12:29 <TrueBrain> elfring: as we all know things to improve; so only telling us it should etc, does not really help 20:12:46 <andythenorth> someone going to teach me interactive rebase for this .md file? 20:12:52 <andythenorth> or I just do one big diff against trunk? :P 20:12:59 <TrueBrain> 1 commit :) 20:14:21 *** Gja has quit IRC 20:14:40 <elfring> TrueBrain: It depends. - I hope that advanced tools can be used so that some work can eventually be reduced. 20:15:30 <TrueBrain> elfring: you talk in riddles and in circles, sorry :( 20:15:40 <TrueBrain> elfring: it almost feels you are trying to sell something .. :( 20:15:47 <__ln__> Oh, elfring is here and I'm out of popcorn. 20:16:10 <TrueBrain> __ln__: be nice; wait, that is not in your dictionary. be not-your-usual-self! 20:17:06 <elfring> TrueBrain: You might notice that I am trying to improve several software components in a similar way for a while. 20:17:34 <TrueBrain> elfring: tools are a means to an end. Without people to be willing to dedicate their time to follow up on it, tools are just that: tools 20:17:50 <TrueBrain> elfring: a shovel in my garden can do wonders. But without me operation, it isjust a piece of wood with a piece of iron attached 20:18:15 <TrueBrain> elfring: we need people who not only tells us: you should deal with a result value of strdup (better yet: dont use strdup), but who make a Pull Request to do something with it 20:18:54 <TrueBrain> elfring: are you that person for us? 20:18:54 <elfring> TrueBrain: But you can also let a machine perform the digging for you, can't you? 20:19:11 <TrueBrain> elfring: a machine can tell me all the errors in the world; with no human to correct them, they mean nothing to me 20:19:54 <TrueBrain> (and a machine that digs my garden on its own, with no humans, does not exist as of yet ... maybe in a few years :D) 20:20:09 <TrueBrain> scary .. I come home one day: A SWIMMING POOL! 20:20:34 <Wolf01> Automate! 20:20:35 *** Alberth has left #openttd 20:20:38 <andythenorth> are these our guidelines? Or is this Bootstrap cargo cult? https://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html 20:20:44 <andythenorth> it's linked from CONTRIBUTING 20:20:57 <elfring> Can better exception handling help you more automatically? 20:21:09 <TrueBrain> andythenorth: no, that is git; at least, a quick glance gives me that impression 20:21:15 <TrueBrain> andythenorth: just everyone mostly ignores it :D 20:21:28 <frosch123> andythenorth: https://wiki.openttd.org/Commit_style#Commit_message 20:21:38 <TrueBrain> elfring: and we are back in a circle :) Not sure if it is the language, or that you are reading off a script :( 20:21:39 <andythenorth> thx 20:23:18 <andythenorth> we gonna have LICENSE.md? 20:23:23 <andythenorth> github likes it if we do 20:23:29 <TrueBrain> rename our COPYING, you say? 20:23:48 <elfring> Would you dare to apply aspect-oriented software development? https://en.wikipedia.org/wiki/Aspect_%28computer_programming%29 20:23:59 <andythenorth> TrueBrain: I'll link COPYING 20:24:03 <TrueBrain> I think this conversation has come to an end elfring; sorry. 20:24:04 <andythenorth> ta 20:24:14 <andythenorth> uh oh 20:24:20 <andythenorth> there's a paradigm to debate 20:24:25 <andythenorth> shucks 20:24:42 <andythenorth> my experience of paradigm-driven developers is universally negative so far :| 20:24:55 <TrueBrain> the moment you start a build, and after 10 files cmake still says: 0% done .. oh-oh 20:25:24 <andythenorth> :P 20:27:19 <TrueBrain> this really is going to take a long time to build :D But at least it is building what I expect him to build .. which is nice .. 20:28:42 <andythenorth> PR 20:28:46 <andythenorth> let's see if I did it right :P 20:28:52 <andythenorth> I am bad at bureaucracy 20:29:11 <andythenorth> yeah broken ignore 20:29:32 <andythenorth> I clicked a magic git button, but it was the wrong magic 20:31:01 <andythenorth> better https://github.com/OpenTTD/OpenTTD/pull/6732 20:32:20 <TrueBrain> please rebase :D (most likely one of the last time that you are obligated to do that, but .. you use a too old master that doesnt fix that yet :D) 20:33:14 <glx> anyway it's always nice to create a PR from an up-to-date clone 20:33:21 <elfring> How do you think about to encapsulate error detection and corresponding exception handling as a reusable aspect in your software? 20:34:13 <andythenorth> ok so I have to learn rebase now 20:34:43 <andythenorth> let's see 20:34:55 <TrueBrain> git rebase upstream/master 20:34:57 <TrueBrain> git push -f 20:35:00 <TrueBrain> :P 20:35:21 <andythenorth> I was close by guessing :P 20:35:26 <andythenorth> not close enough 20:35:51 <andythenorth> ugh git push -f is going to get me killed at work 20:35:56 <TrueBrain> it should 20:35:58 <TrueBrain> :D 20:36:00 <andythenorth> one day I'll forget and do it by accident 20:36:06 <TrueBrain> it also means they have a bad pre-commit filter :D 20:36:18 <TrueBrain> so you can always just say it was their fault :P 20:36:26 <andythenorth> well it's my company 20:36:31 <andythenorth> so it's always my fault, ultimately 20:37:07 <TrueBrain> I wonder if we should make the GPL stuff more verbose, like many other projects 20:37:09 <TrueBrain> ugh 20:37:11 <TrueBrain> so much administration 20:37:25 <andythenorth> so much 20:37:33 <andythenorth> we need planetmaker or someone 20:37:44 <TrueBrain> there are bots that do that work :) 20:38:00 <TrueBrain> very nice work on the CONTRIBUTION.md 20:38:00 <__ln__> elfring: Please make concrete suggestions about improvements in the form of pull requests. 20:38:02 <TrueBrain> I really like it :) 20:38:14 <andythenorth> TrueBrain: team game eh 20:39:17 <TrueBrain> also nicely done with credits where credits are due :) 20:39:27 <TrueBrain> and your first successful rebase \o/ :D 20:40:04 <TrueBrain> did frosch123 also already read it? :) 20:40:22 <TrueBrain> before I go: merge, andhe goes: WHAT THE FUCK :D 20:40:31 <TrueBrain> (he never does that; but I like to think I would :P) 20:41:05 <elfring> __ln__: How are the chances for pull requests around better exception handling? 20:41:35 <andythenorth> frosch gave comments 20:41:56 * frosch123 reads 20:42:42 <TrueBrain> LordAro: does the fix you showed also work for this GCC 7 bug? Or are those 2 different things? 20:43:12 <LordAro> TrueBrain: it does, but frosch123 didn't think it was the Right Thing(tm) to do 20:43:23 <LordAro> (the other commit is the clang bug) 20:43:51 <TrueBrain> fair 20:43:54 <TrueBrain> such a weird error 20:46:54 <TrueBrain> ah, so yeah, the values makes sense 20:47:03 <TrueBrain> 256 bytes between the two values :) 20:49:20 <TrueBrain> it seems GCC is blind for the if statement just before 20:51:46 <TrueBrain> well, if frosch123 is commenting, I also have one more andythenorth :D 20:52:04 <andythenorth> well 20:52:09 <andythenorth> now I now how to push -f :P 20:52:13 <andythenorth> know * 20:52:23 <TrueBrain> and git commit --amend? :D 20:52:50 <andythenorth> yup 20:53:02 <andythenorth> how does that work in the PR though? 20:53:12 <andythenorth> i.e. what happens to your comments? 20:53:14 <andythenorth> new PR? 20:53:23 <TrueBrain> no 20:53:27 <TrueBrain> commit with amend 20:53:30 <TrueBrain> force push 20:53:41 <TrueBrain> and you can still see our comments, jus tnot in that commit anymore 20:53:43 <TrueBrain> will be fine :) 20:53:46 <andythenorth> ok 20:53:48 <andythenorth> trusting 20:53:49 <TrueBrain> well 20:53:51 <TrueBrain> normally 20:53:54 <TrueBrain> you make a new commit 20:53:59 <TrueBrain> so you can see the diff there 20:54:02 <TrueBrain> honestly, works as well 20:54:07 <TrueBrain> just who accepts your PR needs to squash 20:54:09 <TrueBrain> instead of rebase 20:54:15 <TrueBrain> but .. back to the squash vs rebase dialog :D 20:56:12 <TrueBrain> @base 20 10 20:56:12 <DorpsGek> TrueBrain: 20 20:56:15 <TrueBrain> @base 10 20 20:56:15 <DorpsGek> TrueBrain: 20 20:56:19 <TrueBrain> fail 20:57:31 <TrueBrain> @base 16 10 2a 20:57:31 <DorpsGek> TrueBrain: 42 20:57:32 <TrueBrain> better 20:57:44 <TrueBrain> @base 10 16 18446744073709551361 20:57:44 <DorpsGek> TrueBrain: FFFFFFFFFFFFFF01 20:57:48 <TrueBrain> @base 10 16 18446744073709551615 20:57:48 <DorpsGek> TrueBrain: FFFFFFFFFFFFFFFF 20:59:16 <andythenorth> done 20:59:22 <andythenorth> do I need to comment on PR at all? 20:59:51 <TrueBrain> emails go out, and if you say: frosch123, I am sure you just did :P 21:00:57 <TrueBrain> so GCC think the range is between -1 and -254? 21:01:03 <TrueBrain> so length is always 0? 21:01:42 <frosch123> TrueBrain: no Werror then :) 21:02:08 <TrueBrain> I wonder how it makes that conclusion 21:02:40 *** Progman has quit IRC 21:02:43 <TrueBrain> as two if statements clearly show it is not possible for length to be 0 21:05:19 <TrueBrain> guess optimizations play a part there 21:06:20 <TrueBrain> I would need to install GCC 7 to debug that further .. just weird :P 21:07:06 <TrueBrain> possibly the warning is just out of context 21:07:12 <TrueBrain> because if you have 2 bytes A and B 21:07:26 <TrueBrain> than A - B can range from 255 to -254 21:07:33 <TrueBrain> and maybe it only reports on the -1 .. -254 21:08:15 <TrueBrain> given length - statspec->lengths is used twice 21:08:25 <TrueBrain> putting it in a variable both solves the issue as makes the code prettier 21:08:29 <TrueBrain> sadly, LordAro went for the cheap solution :D 21:09:16 <TrueBrain> would also explain the memset a bit lower; as multiplying it with a few puts the number back into what "is allowed" 21:09:21 <TrueBrain> by what-ever stupid definition 21:09:24 <TrueBrain> it is just a bogus warning 21:13:18 <LordAro> i'll see about fixing it more properly 21:13:24 <TrueBrain> too late :P 21:14:12 <LordAro> hmm? 21:14:25 <TrueBrain> do you have GCC 7 LordAro? 21:14:30 <LordAro> aye 21:14:35 *** Wacko1976 has quit IRC 21:14:38 <TrueBrain> can you check if 6733 still warns? :) 21:17:17 *** sim-al2 has joined #openttd 21:17:26 *** elfring has quit IRC 21:18:01 <TrueBrain> I did something that broke compiling locally :D 21:19:11 <TrueBrain> ah, something added a wrong include .. 21:19:25 <TrueBrain> tnx LordAro; now I just hope frosch123 does like my solution :D 21:20:14 <TrueBrain> THERE! A CONTRIBUTING.md :D 21:20:18 <TrueBrain> tnx again all :D 21:23:36 <frosch123> did you force push to fake the pr number into the message? or did you anticipate the next number? 21:23:44 <TrueBrain> I squashed 21:23:58 <frosch123> i mean 6729 21:24:22 <TrueBrain> hm? 6729 is the bug report, not? 21:24:27 <TrueBrain> 6733 is the fix? What am I missing? 21:24:36 <frosch123> oh, right 21:26:31 <TrueBrain> okay .. going to try eints ... 21:26:45 <TrueBrain> rejected :D 21:27:01 <frosch123> from gh? 21:27:18 <TrueBrain> yes 21:27:25 <TrueBrain> it wants validation of Jenkins :D 21:27:37 <TrueBrain> I once wrote a bot which made the PR 21:27:40 <TrueBrain> waited for approval 21:27:44 <TrueBrain> (from CI) 21:27:46 <TrueBrain> approved it 21:27:47 <TrueBrain> and merged 21:27:50 <TrueBrain> but ... that is a lot of shit :P 21:28:48 <TrueBrain> ha, worked 21:29:11 <TrueBrain> now just administrators can ignore all requirements .. so behave frosch123 :P 21:29:23 <frosch123> he, just wanted to suggest unchecking that :p 21:29:37 <TrueBrain> just a bit unclear who 'administrators' are 21:30:04 <peter1138> Owner? 21:30:11 <TrueBrain> it is called owner in most places 21:30:15 <TrueBrain> I ASSUME they mean the same 21:30:20 <TrueBrain> but ...... why call it differently? 21:30:22 <frosch123> i did as well :p 21:30:57 <TrueBrain> okay, nightly commit is active again 21:31:28 <peter1138> That reminds me... I had to make my jenkin user a gitea admin before the API would work correctly. I'm sure that's not right :S 21:31:36 <LordAro> TrueBrain: worth pointing out that GH doesn't see "Codechange #nnnn" as a close marker 21:31:48 <andythenorth> such CONTRIBUTIONS expected now 21:31:57 <TrueBrain> LordAro: yup, I noticed :) 21:33:20 <TrueBrain> almost hit Squash, till I noticed LordAro approved; seems that is now enough for GH as Owner :D 21:33:40 <frosch123> it's red 21:33:43 <frosch123> and it asks twice 21:33:51 <TrueBrain> hmm .. its green here :) 21:34:01 <TrueBrain> dunno .. weird .. 21:34:23 <frosch123> well, now it is 21:34:43 <TrueBrain> hmm .. that flag has nothing to do with it 21:34:52 <TrueBrain> seems Gardeners can also review :D 21:34:53 <frosch123> but when you try to confirm without approval or ci check, you have to confirm to abuse owner powers 21:34:58 *** iSoSyS has quit IRC 21:35:01 <TrueBrain> good! 21:35:14 <TrueBrain> owh, LordAro is now a Code Owner of course, because he made a contribution :) 21:35:28 <andythenorth> I can't merge PRs 21:35:33 <TrueBrain> not merge, no :) 21:35:34 <andythenorth> "You're not authorized to merge this pull request." 21:35:44 <TrueBrain> merge is restricted via another toggle 21:35:50 <andythenorth> I can comment and/or close 21:35:50 <TrueBrain> GitHub works in mysterious ways :) 21:36:36 <TrueBrain> lol 21:36:41 <TrueBrain> I can dismiss reviews 21:36:44 <TrueBrain> but you need to tell WHY 21:36:45 <TrueBrain> :D 21:37:38 <TrueBrain> happy eints 'just worked', really tnx frosch123 :) 21:37:47 <frosch123> \o/ 21:38:02 *** gelignite has quit IRC 21:38:03 <LordAro> :o 21:38:28 *** gelignite has joined #openttd 21:41:09 <TrueBrain> anyway, frosch123, is #6733 acceptable, or do you want me to dig deeper why GCC does this wrong? 21:41:34 <frosch123> gcc will fix it somewhen 21:41:52 <frosch123> i think we always had weird warnings with some compilers 21:42:03 <frosch123> some got fixes with later compilers, some we disabled 21:42:09 <TrueBrain> yeah; that is why I tried to find something that both benefits the code, and solves the issue :) 21:42:35 <TrueBrain> but compilers indeed will be compilers .. so looking deeper is not really useful indeed 21:42:49 <TrueBrain> I remember the fixes during GCC4 we had to do :D 21:42:51 <TrueBrain> that was fun :P 21:44:33 <TrueBrain> lot of cool new warnings in GCC 7 .. like showing which part of a printf is wrong :D 21:47:58 <frosch123> don't dismiss again :p 21:48:01 *** gelignite has quit IRC 21:48:09 <TrueBrain> haha :D 21:48:10 <TrueBrain> tnx 21:48:45 <frosch123> also: earlier on the contributing pr 21:48:55 <LordAro> i added -Weffc++ to see what happened 21:48:58 <frosch123> you had requested changes and i had approved, but merge was still blocked 21:49:01 <LordAro> so many warnings 21:49:10 <TrueBrain> frosch123: that is at least sane 21:49:12 <frosch123> so, request changes overrules approval :) 21:50:37 <TrueBrain> poor CI, has been busy for over an hour now :P 21:50:41 <TrueBrain> I really need to fix ccache 21:51:01 <TrueBrain> or leave a partial compiled or so 21:51:36 <TrueBrain> or AWS needs to reply with a nice offer :D 21:51:50 <TrueBrain> ugh, the OSX build is only at 55% ... this is taking a REALLY long time 21:51:51 <peter1138> I need to move mine, it's running on a Celeron at the moment. 21:52:09 <peter1138> What's it doing, bootstrapping a compiler? 21:52:23 <TrueBrain> no, that he already did 21:52:28 <TrueBrain> now he is compiling the compiler or something 21:52:43 <TrueBrain> wow ... flush is taking 300% CPU 21:52:47 <LordAro> TrueBrain: partial compiling is risky 21:53:36 <TrueBrain> why is it doing so much I/O for this .. holy crap .. 21:53:39 <TrueBrain> did not expect that ... 21:54:22 <TrueBrain> LordAro: our dependency is pretty good 21:54:24 <Wolf01> About partial compiling, with the new version of the tool I use to develop at work, they allow partial compiling of classes to solve the problem of circular dependencies -.- 21:54:36 <TrueBrain> only issue might be mtime 21:54:48 <TrueBrain> Wolf01: sounds scary :D 21:55:00 <LordAro> TrueBrain: true 21:55:07 <Wolf01> Sounds insane, not scary 21:55:35 <LordAro> maybe make || (make mrproper && make) could work? 21:55:46 <Wolf01> Also, 'night 21:55:50 <TrueBrain> night Wolf01 21:55:52 *** Wolf01 has quit IRC 21:56:04 <LordAro> ^ ./configure && 21:56:05 <TrueBrain> LordAro: that is the case in our current build system 21:56:15 <frosch123> btw, did someone from simutrans already complain? 21:56:16 <TrueBrain> but no need to test that every commit 21:56:20 <TrueBrain> frosch123: nah 21:56:29 <TrueBrain> and I kinda forgot about them 21:56:38 <LordAro> why would simutrans complain? 21:56:45 <TrueBrain> will write a message tomorrow telling them what was going on 21:56:45 <LordAro> oh, build system? 21:57:09 <TrueBrain> hmm ... I closed my docker build, and flush is still at 300% 21:57:11 <TrueBrain> oh-oh :D 21:57:50 <peter1138> Last Simutrans build is 27th Feb, so... 21:57:57 <TrueBrain> when was their last commit? 21:57:59 <peter1138> I guess they don't change very much. 21:58:12 <LordAro> that's not *that* long ago... 21:58:54 *** cHawk has joined #openttd 21:59:09 <peter1138> Hm, according to the git mirror, yesterday. 21:59:22 <TrueBrain> so we are not compiling that version :D 22:04:22 <TrueBrain> right, message sent 22:04:42 <TrueBrain> and this kernel is still at 300% CPU for flush 22:04:45 <TrueBrain> what have I done .... 22:04:54 <peter1138> o_O 22:05:42 <TrueBrain> yet barely any disk IO 22:07:36 <TrueBrain> so writing disks costs more CPU than IO .......... 22:08:24 <TrueBrain> funny, Simutrans also uses Squirrel :) 22:08:31 <peter1138> Yeah, I saw that. 22:08:46 <peter1138> Hmm, I should update this patch. r14316. 22:09:36 <LordAro> i'm sure it's fine 22:09:57 <peter1138> Yeah, well it's not pre-c++ at least. 22:10:31 <TrueBrain> seems the flush is holding back 2GB of RAM 22:10:38 <TrueBrain> guess I just reboot .. that always fixes everything, not? 22:12:25 <peter1138> Heh, still has the saveload stuff in the _cmd files though. 22:14:43 <TrueBrain> owh, this flush is running for over a week now 22:14:44 <TrueBrain> oops 22:15:18 <LordAro> lol. 22:15:41 <TrueBrain> yeah ... that seems to be not my only problem ....... 22:15:51 <TrueBrain> I do not think it really is flush 22:16:01 *** Thedarkb has quit IRC 22:16:07 <TrueBrain> I have an open connection to an IP I dont know about, and a process hiding as 'sysinfo' 22:16:11 <TrueBrain> I think it is just a miner :P 22:16:21 <TrueBrain> question now is .. how did it get on the box .. 22:16:37 <andythenorth> :| 22:17:44 <TrueBrain> its on a docker slave of mine, which does nothing else but handle shit docker commands :P 22:18:17 <peter1138> o_O 22:18:20 <LordAro> that's... 22:18:34 <peter1138> Someone made a dodgy PR? :p 22:18:44 <TrueBrain> no, not on OpenTTD infrastructure 22:21:14 <TrueBrain> indeed a miner 22:21:16 <TrueBrain> moneypunct 22:21:30 <LordAro> that seems concerning 22:22:22 <TrueBrain> honestly, that happens 22:22:28 *** HerzogDeXtEr has quit IRC 22:23:52 <TrueBrain> ah .. I did not firewall my Docker API properly 22:24:03 <TrueBrain> volume mount on host system 22:24:04 <TrueBrain> owned 22:24:06 <TrueBrain> yeah 22:24:07 <TrueBrain> makes sense 22:24:13 <TrueBrain> that was not so smart 22:24:29 *** frosch123 has quit IRC 22:24:38 <TrueBrain> they even left a nice crontab running to wake up the machine every N time :D 22:25:04 <TrueBrain> I blocked port 2376, but Docker runs on 2375 these days :) 22:26:26 <TrueBrain> @calc 60 * 24 * 10 22:26:26 <DorpsGek> TrueBrain: 14400 22:27:30 <TrueBrain> right, that should learn me to be more careful with throw-away machines :) 22:27:38 <TrueBrain> it only containsed the OpenTTD CF stuff on it :P 22:27:45 <TrueBrain> (as in, the GitHub sources) 22:28:07 <peter1138> We had one that was hiding as a WordPress plugin... 22:28:51 <peter1138> Oh, I found the missing bit of this patch: there's no UI. 22:30:48 <peter1138> Heh, still refers to _current_player instead of _current_company. 22:35:27 <TrueBrain> okay, so Docker changed from port between version 22:35:30 <TrueBrain> I did not pick that up 22:35:38 <peter1138> Default deny... 22:35:50 <TrueBrain> yeah, for reasons this box wasnt 22:36:00 <TrueBrain> but okay .. single-purpose box, so meh 22:36:47 <TrueBrain> no private keys on the box, no passwords 22:40:21 *** sim-al2 has quit IRC 22:43:06 <andythenorth> bed 22:43:06 *** andythenorth has left #openttd 22:44:25 <TrueBrain> okay ... so all they got is the OpenTTD source (lol) 22:44:30 <TrueBrain> the OpenTTD-CF source (again, lol) 22:44:49 <TrueBrain> and some tests of mine .. okay, could have been worse 22:46:23 *** Wormnest has quit IRC 22:47:18 <TrueBrain> owh well, shutdown -h now, trash the VM, lets boot a new one :) 22:47:20 <TrueBrain> for now, good night! 23:11:55 *** iSoSyS has joined #openttd 23:14:39 *** iSoSyS has quit IRC 23:57:55 *** sim-al2 has joined #openttd