Times are UTC Toggle Colours
00:00:37 *** D-HUND has joined #openttd 00:01:19 *** debdog has quit IRC 00:35:16 *** D-HUND is now known as debdog 00:38:17 *** Sacro has quit IRC 01:04:03 *** D-HUND has joined #openttd 01:04:29 *** debdog has quit IRC 01:06:29 *** KouDy has quit IRC 01:12:59 *** D-HUND has quit IRC 01:27:12 *** Progman has quit IRC 01:30:18 *** glx has quit IRC 02:08:06 *** Samu has quit IRC 03:00:46 *** KouDy has joined #openttd 03:24:28 *** haudrauf has quit IRC 03:26:18 *** haudrauf has joined #openttd 03:41:17 *** snail_UES_ has quit IRC 03:42:46 *** Supercheese has joined #openttd 04:27:03 *** SpComb^ has joined #openttd 04:27:58 *** SpComb has quit IRC 04:41:21 *** Wacko1976 has joined #openttd 04:53:29 *** Wacko1976 has quit IRC 05:28:59 *** ToBeFree has joined #openttd 05:49:59 *** OsteHovel has joined #openttd 06:21:37 *** Gustavo6046 has quit IRC 06:25:03 *** snail_UES_ has joined #openttd 06:45:10 *** Gustavo6046 has joined #openttd 07:01:16 *** tokai|noir has joined #openttd 07:01:16 *** ChanServ sets mode: +v tokai|noir 07:08:15 *** tokai has quit IRC 07:27:04 *** Supercheese has quit IRC 07:27:27 *** Supercheese has joined #openttd 07:32:54 <planetmaker> moin 07:55:32 *** gelignite has joined #openttd 08:38:49 *** snail_UES_ has quit IRC 09:13:56 *** Arveen has quit IRC 09:26:36 *** Supercheese has quit IRC 09:32:20 *** Progman has joined #openttd 09:54:34 <alluke> how many years will it take to get ratt into trunk? 09:54:47 <alluke> 1.9.0 too soon i suppose? 10:02:59 <LordAro> which one is ratt? 10:22:25 *** Sacro has joined #openttd 10:56:03 *** Samu has joined #openttd 11:03:39 <DorpsGek_II> [OpenTTD/OpenTTD] MosheL commented on issue #6427: [Windows] RTL bug OpenTTD 1.6.0-RC1 https://github.com/OpenTTD/OpenTTD/issues/6427#issuecomment-420969044 11:16:15 <LordAro> interesting 11:16:26 <LordAro> fixed by uniscribe, do we think? 11:21:26 <Eddi|zuHause> worth asking to retest with trunk 11:21:44 <Eddi|zuHause> would be helpful if we had nightlies? 11:22:40 <Eddi|zuHause> i'm looking for an old laptop and i can't figure out where i put it 11:28:35 *** gelignite has quit IRC 11:42:13 <LordAro> Eddi|zuHause: nightlies would be helpful, yes :p 11:54:29 <Samu> is it possible to know to whom a road tile belongs? 11:54:35 <Samu> namely, which town 11:54:41 <Samu> not a company 11:55:11 <Samu> maybe it is, let me think this through 12:01:49 *** Arveen has joined #openttd 12:31:26 *** snail_UES_ has joined #openttd 12:37:32 *** sla_ro|master has joined #openttd 13:00:15 *** sla_ro|master has quit IRC 13:44:34 *** KouDy has quit IRC 13:49:19 *** sim-al2 has quit IRC 14:04:33 *** nielsm has joined #openttd 14:10:31 *** Progman has quit IRC 14:15:49 *** haudrauf has quit IRC 14:19:35 *** haudrauf has joined #openttd 14:20:37 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #6427: [Windows] RTL bug OpenTTD 1.6.0-RC1 https://github.com/OpenTTD/OpenTTD/issues/6427#issuecomment-421024524 14:22:11 *** KouDy has joined #openttd 14:30:21 *** Flygon has quit IRC 14:40:33 <Samu> local arrayMiddleTile = roadArray[roadArray.len() / 2].m_tile; 14:40:45 <Samu> is this gonna get me the the middle tile 14:40:53 <Samu> i hope so lol 14:49:49 *** snail_UES_ has quit IRC 15:01:21 *** sla_ro|master has joined #openttd 15:21:18 *** Gja has joined #openttd 15:44:16 *** wodencafe has joined #openttd 15:46:49 *** Gja has quit IRC 15:47:53 *** FLHerne has quit IRC 15:48:29 *** FLHerne has joined #openttd 15:52:10 *** Samu has quit IRC 16:03:34 *** Samu has joined #openttd 16:19:53 <Samu> local adjacentTiles = (roadTiles = Utils.getAdjacentTiles(tile)); 16:19:59 <Samu> will this work in squirrel code? 16:31:48 *** HerzogDeXtEr has joined #openttd 16:33:38 *** Samu has quit IRC 16:44:07 <LordAro> probably not 16:49:45 *** Wacko1976 has joined #openttd 17:07:55 *** KouDy has quit IRC 17:25:48 *** Wormnest has joined #openttd 17:26:16 *** KouDy has joined #openttd 17:53:15 *** Samu has joined #openttd 18:02:09 *** Smedles has quit IRC 18:02:09 *** APTX has quit IRC 18:02:25 *** Smedles has joined #openttd 18:02:25 *** APTX has joined #openttd 18:04:15 *** Wolf01 has joined #openttd 18:04:24 <Wolf01> o/ 18:16:20 *** andythenorth has joined #openttd 18:16:24 <andythenorth> oof 18:16:29 <andythenorth> can I just hire TrueBrain? :| 18:19:36 *** Gja has joined #openttd 18:19:58 *** KouDy has quit IRC 18:22:18 *** frosch123 has joined #openttd 18:22:54 <TrueBrain> what do you want me to destroy andythenorth? 18:23:02 <andythenorth> I am still looking for an SRE :P 18:23:09 <andythenorth> I am reduced to wading through linkedin 18:23:13 <andythenorth> spamming devops engineers 18:23:17 <andythenorth> it's like the worst thing ever 18:23:27 <andythenorth> but it has worked a couple of times before :| 18:23:27 <TrueBrain> yes; that is :P 18:23:34 <andythenorth> my eyes bleed 18:23:37 <andythenorth> everyone will hate me 18:23:40 <TrueBrain> reason I deleted my LinkedIn tbh 18:23:44 <andythenorth> and linkedin only ever gets worse 18:24:07 <Samu> damn it, for building a road depot i have to write a bajillion of lines in code 18:24:32 <Samu> https://paste.openttdcoop.org/pjjkhttos 161 lines :8 18:26:53 <Samu> i dont need to build signs anymore, removing 18:27:17 <Samu> 160 lines 18:27:29 <andythenorth> so can we rek any PRs? :) https://github.com/OpenTTD/OpenTTD/pulls 18:27:56 <TrueBrain> we should add a "rotting" process .. where PRs without attention automatically get pinged, and in the end closed 18:28:03 <TrueBrain> I really like that in my other github projects :) 18:28:14 <Samu> andythenorth added the waiting-on-author label 3 days ago, but I already answered :( 18:28:14 <TrueBrain> my = many 18:28:17 <TrueBrain> typing is hard 18:30:03 <andythenorth> I think NRT is rotted nearly through 18:30:17 <andythenorth> and that one by peter1138 https://github.com/OpenTTD/OpenTTD/pull/6784 18:30:53 <andythenorth> new label: "didn't happen" 18:31:23 <andythenorth> Samu: your PR is 'waiting-on-author' because it fails to meet checks 18:31:33 <andythenorth> so not much incentive for anyone to look at it :) 18:31:40 *** Stimrol_ has quit IRC 18:34:52 <Samu> I was hoping someone would do that part for me :( 18:37:02 <Samu> we're talking about the commit message, right? 18:40:33 *** Stimrol has joined #openttd 18:40:48 *** GroovyNoodle has joined #openttd 18:49:58 <Samu> ah, the codestyle issue 18:51:13 <Samu> return (Money)(int)GetMaintenanceCostFactor(type) * _price[PR_INFRASTRUCTURE_AIRPORT] >> 3; 18:51:16 <Samu> something like this? 18:51:31 <Samu> gonna test 18:51:45 <planetmaker> Money and int are both types. a double cast is not needed. 18:51:51 <planetmaker> Just cast to Money 18:52:31 <planetmaker> looking at the line you quoted I actually wonder whether any cast is needed at all 18:53:18 <Samu> GetMaintenanceCostFactor(type) is a uint16 and can't multiply with _price[PR... 18:53:28 <Samu> unless ... it can now, brb 18:54:09 *** KouDy has joined #openttd 18:57:16 <Samu> Error (active) more than one operator "" matches these operands: 18:57:17 <Samu> blabla 18:57:32 <Samu> operand types are: Money * Money 18:58:05 <Samu> return (int)GetMaintenanceCostFactor(type) * _price[PR_INFRASTRUCTURE_AIRPORT] >> 3; 18:58:07 <Samu> this works 18:58:17 <Samu> but is it returning Money? 18:58:31 <Samu> /* static */ Money ScriptAirport::GetMonthlyMaintenanceCost(AirportType type) 18:58:46 *** sim-al2 has joined #openttd 19:05:05 <planetmaker> well, you will want to return a Money. So can't you cast the price to Money instead? 19:06:25 *** sim-al2 is now known as Guest422 19:06:25 *** sim-al2 has joined #openttd 19:06:54 *** Guest422 has quit IRC 19:09:04 <Samu> price is Money 19:09:20 <Samu> maintenancecost factor is uint16 19:09:40 <Samu> and Money ScriptAirport::GetMonthlyMaintenanceCost is supposed to return Money 19:10:34 <Samu> https://imgur.com/UopH5bX 19:10:35 <Samu> it works 19:10:42 <Samu> return (int)GetMaintenanceCostFactor(type) * _price[PR_INFRASTRUCTURE_AIRPORT] >> 3; 19:10:44 <Samu> this 19:11:54 <Samu> lol montly 19:11:58 <Samu> monthly :o 19:14:26 <planetmaker> casting to uint16 might work mostly. But fail for higher prices. Money is the far bigger type 19:14:55 <planetmaker> return GetMaintenanceCostFactor(type) * (Money) (_price[PR_INFRASTRUCTURE_AIRPORT] >> 3); 19:14:59 <planetmaker> ^^ wouldn't that work? 19:15:16 <Samu> gonna try 19:15:58 <Samu> nop 19:16:07 <Samu> it still complains about uint16 one 19:17:30 <Samu> https://paste.openttdcoop.org/pzkccdaam 19:17:32 <Samu> the error 19:19:00 <Samu> i suppose I have 4 choices 19:19:13 <Samu> int64, int, uint, byte 19:19:22 <Samu> i went with int, but maybe some other is more fitting 19:24:05 *** Thedarkb-T60 has joined #openttd 19:24:22 *** Gja has quit IRC 19:46:34 <planetmaker> money basically is an overflow-safe uint64 iirc 19:50:27 *** sim-al2 has quit IRC 19:54:00 <Samu> OverflowSafeInt 20:00:03 <Samu> return (uint)GetMaintenanceCostFactor(type) * _price[PR_INFRASTRUCTURE_AIRPORT] >> 3; 20:00:12 <Samu> return (int)GetMaintenanceCostFactor(type) * _price[PR_INFRASTRUCTURE_AIRPORT] >> 3; 20:00:22 <Samu> return (int64)GetMaintenanceCostFactor(type) * _price[PR_INFRASTRUCTURE_AIRPORT] >> 3; 20:00:34 <Samu> return (byte)GetMaintenanceCostFactor(type) * _price[PR_INFRASTRUCTURE_AIRPORT] >> 3; 20:00:40 <Samu> which one planetmaker ? 20:01:17 <planetmaker> 3 20:01:26 <Samu> oki 20:01:48 <Samu> thx 20:10:03 *** sla_ro|master has quit IRC 20:13:29 *** GroovyNoodle has quit IRC 20:16:06 <peter1138> Is that counting from 0 or 1? :D 20:16:38 <planetmaker> :) 20:24:17 <Samu> could someone explain me the right steps to create a pull request? 20:24:22 <Samu> i first clicked fork 20:25:21 <Samu> SamuXarick/OpenTTD forked from OpenTTD/ 20:26:00 <Samu> This branch is even with OpenTTD:master. 20:26:13 <Samu> do i create a branch for every pull request? 20:26:22 <Samu> how do i create a branch :( 20:27:09 <Samu> maybe it's not what I want 20:27:51 <Samu> let's say, i have this patch ready 20:28:31 <Samu> how do i create a pull request just for this patch only 20:28:49 <Samu> imagine i have other patches for other stuff not related to the first patch 20:29:19 <Samu> i wanted to revert back to the original state, but without affecting the pull requests 20:29:24 <Samu> what do I need? 20:30:26 <Samu> patch 1: airportmaintenance for scripts, patch 2: config_random bug 20:31:30 <andythenorth> oof 20:31:35 <andythenorth> I wrote 4 hours of code yesterday 20:31:48 <andythenorth> for something my framework already does 20:31:58 <andythenorth> but I assumed it wouldn't be able to do 20:32:03 <planetmaker> he 20:32:22 <planetmaker> call that lerning curve ;) 20:32:38 <LordAro> Samu: switch back to master, make a new branch from there 20:32:58 <andythenorth> planetmaker: I wouldn't mind, but I wrote the framework :P 20:33:34 <planetmaker> :D :D 20:33:59 <planetmaker> if it is any consolance: I know that feeling first-hand 20:34:01 <Samu> a new branch 20:39:04 <Samu> uh, i dunno how to create a new branch 20:41:25 <Samu> Your branches You haven’t pushed any branches to this repository. 20:47:59 *** andythenorth is now known as Guest435 20:48:07 *** andythenorth has joined #openttd 20:48:14 <andythenorth> bye 20:48:15 *** andythenorth has quit IRC 20:52:42 *** Guest435 has quit IRC 21:00:05 <Samu> Create a new branch for this commit and start a pull request. Learn more about pull requests. 21:00:07 <Samu> aha!! 21:00:19 <Samu> found the holy grail 21:12:52 *** frosch123 has quit IRC 21:17:53 <Samu> where do I see the list of categories? 21:18:19 <Samu> for the docker commit log dude? 21:19:14 <Samu> commit-checker 21:19:50 <Samu> the ([<section]) 21:19:54 <Samu> part 21:20:18 <Samu> *** First line of message must match: '<keyword>( #<issue>| <commit>(, (<keyword> #<issue>|<commit>))*)?: ([<section])? <Details>' 21:20:55 <Samu> where's the list of section 21:28:22 *** nielsm has quit IRC 21:43:22 *** glx has joined #openttd 21:43:22 *** ChanServ sets mode: +v glx 21:43:59 <Samu> https://github.com/OpenTTD/OpenTTD/issues/6892 21:44:05 <Samu> did it work? 21:44:20 <Samu> what am i supposed to do now? 21:45:26 <Samu> I see a SamuXarick added a commit to SamuXarick/OpenTTD that referenced this issue 6 minutes ago 21:46:00 <Samu> too much bureoucracy 21:46:13 <Samu> someone explain what to do now 21:51:35 *** Progman has joined #openttd 21:53:30 <LordAro> Samu: you've made a pull request against your fork, rather than the origin 21:53:54 <LordAro> Samu: if you go here, it'll probably tell you you've recently pushed to a branch https://github.com/OpenTTD/OpenTTD 21:55:58 <LordAro> however, there is also https://github.com/SamuXarick/OpenTTD/pull/new/ 21:56:22 <LordAro> (github itself gives you a link when you push a new branch to a fork) 21:57:23 *** Wormnest has quit IRC 21:59:04 <Eddi|zuHause> "python removes references to 'master'/'slave'"... that is surely not going to backfire on the twitterverse 21:59:19 <Samu> https://github.com/OpenTTD/OpenTTD/compare/master...SamuXarick:CONFIG_RANDOM-fix 21:59:53 <Samu> Create Pull Request? 22:00:48 <Samu> so it's not gonna work, I assume 22:00:52 <Samu> the docker dude 22:00:57 <Samu> commit-checker 22:02:42 <LordAro> dunno, but you've got to actually create it first to find out :p 22:02:57 <LordAro> Eddi|zuHause: you're about a day late 22:03:38 <Eddi|zuHause> i live in a remote corner of the internet 22:11:55 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick opened pull request #6902: Fix #6892: [Script] CONFIG_RANDOM range limit https://github.com/OpenTTD/OpenTTD/pull/6902 22:12:47 *** HerzogDeXtEr has quit IRC 22:15:06 *** Wolf01 has quit IRC 22:15:16 <LordAro> Samu: seems to be happy with the commit :) 22:16:31 <Samu> it's still doing something, isn't it? 22:16:51 <LordAro> yeah, but it's actually testing the compilation now 22:16:58 <LordAro> which i can't imagine it'll have issue with 22:17:05 <LordAro> given it's literally +1 :p 22:19:14 <DorpsGek_II> [OpenTTD/OpenTTD] MosheL commented on issue #6427: [Windows] RTL bug OpenTTD 1.6.0-RC1 https://github.com/OpenTTD/OpenTTD/issues/6427#issuecomment-421171009 22:19:58 <Samu> oh, nice :) 22:25:07 *** Wacko1976_ has joined #openttd 22:28:34 *** Wacko1976 has quit IRC 22:38:59 <DorpsGek_II> [OpenTTD/OpenTTD] spiderbit opened issue #6903: selected rail type should be included in game saves https://github.com/OpenTTD/OpenTTD/issues/6903 22:50:47 <Samu> https://imgur.com/OFOginu there's something wrong with that road piece 22:54:45 <Samu> I think a road depot was removed, and left roadbits behind 22:56:07 <Samu> the only time the AI demolishes roads is when it wants to build a tunnel or bridge 22:56:50 <Samu> invisible roadbits 23:02:26 <Samu> i can't think why would the town build a road piece there, separated from the rest of the road 23:02:34 <Samu> have to investigate 23:22:18 <Samu> maybe it's nothing, just my imagination 23:49:47 *** Thedarkb-T60 has quit IRC