Times are UTC Toggle Colours
00:00:18 <Samu> my ai has a very very long loop 00:00:34 <Samu> especially with the increased number of routes, vehicles, etc 00:00:49 <Zuu> You can always toss in calls for scp.Check() a few places in your loop if it is very very long. 00:00:49 <Samu> i get some loops lasting 5 years :( 00:01:09 <Samu> I see 00:01:17 <Zuu> But if it lasts 5 years, then yes that is very very long. 00:01:49 <Samu> it's the road vehicle management, i can't make it faster :( 00:01:58 <Samu> the aircraft management is adequate 00:02:43 <Samu> until it starts searching for a spot for intercontinentals... 00:03:28 <Zuu> If it cannot be faster, can you run it less often on each route and only do a few routes each main loop cycle? Or monitor a few key stats for all and using that select which ones to target with the slower management? 00:05:05 <Samu> i tried something that let it perform road management up to 2220 ticks 00:05:11 <Zuu> And look for marker signs that are cheap to check that could indicate a broken route that requires runnig the path finder etc. So you don't run it blindly on all routes to check that they aren't borken. 00:05:56 <Zuu> Compare profit over time for example. 00:06:28 <Samu> oh, i dont run the pathfinder while inside the road route management 00:07:01 <Zuu> CluelessPlus sometimes does run it in repair mode. 00:08:20 <Zuu> If not else, run it when you receive vehicle crashed event 00:08:48 <Samu> hmm, let me get my main cycle out there 00:08:55 <Zuu> Chances are that someone ran a track through your road and started to crash your vehicles. :-) 00:08:56 *** Wormnest_ has joined #openttd 00:09:32 <Zuu> And then you better see if path finder can swap that out for a bridge. 00:09:35 <Samu> my loop starts with Utils.RepayLoan(); 00:09:41 <Samu> should be almost instant 00:10:10 <Samu> then it starts the scp check loop, which is supposedly fast enough 00:10:20 <Zuu> I use timers in CluelessPlus source that will register time spent on different parts and log that to console. 00:10:58 <Samu> RemoveLeftovers() is next, which is pretty much just checking if there's something that was left behind that needs to be cleared, so it's also instant 00:11:17 <Samu> dead routes, stations pretty much 00:11:31 *** cboyd_ has joined #openttd 00:11:48 <Samu> updateVehicles(); this is the road management, the more routes, the slower it gets :( 00:12:00 <Zuu> CluelessPlus main loop is unfortunately not very short either codewise. https://dev.openttdcoop.org/projects/ai-cluelessplus/repository/entry/main.nut#L604 00:12:23 *** Wacko1976 has quit IRC 00:12:49 <Samu> BuildRoadRoute(cityFrom, buildManager.hasUnfinishedRoute() ? true : false); comes next, which runs the pathfinder, split into several attempts, each attempt is about 500-700 ticks 00:13:07 <Samu> wrightAI.ManageAirRoutes(); 00:13:37 <Samu> is selling, adding, removing airports, all at once, it's almost always fast enough, unless it's dealing with too many vehicles in depots 00:14:01 <Samu> PerformTownActions(); FoundTown(); BuildHQ(); should all be very fast 00:14:07 *** Wormnest has quit IRC 00:14:07 *** wodencafe has quit IRC 00:14:07 *** rocky1138 has quit IRC 00:14:07 <Samu> and that's the end of the loop 00:14:13 *** rocky1138 has joined #openttd 00:14:23 <Samu> oh, wait, there's the build air route after the manage air route, my bad 00:14:38 <Samu> usually fast, unless dealing with intercontinentals 00:14:53 <Samu> let me look at clueless 00:15:24 *** gelignite has quit IRC 00:16:00 <Zuu> It is long, but the thing I wanted to point out is TimerStart("name"); .... TimerStop("name"); 00:16:39 <Zuu> And every 5 year it prints out the timer counts at the end. 00:17:04 <Zuu> This way I get to know which parts of my main loop to focus on to speed up. 00:19:20 <Samu> this.CheckDepotsForStopedVehicles() 00:19:27 <Samu> i really should prioritize depots indeed 00:19:44 <Samu> having buses waiting 5 years in a depot to be renewed is bad 00:20:09 <Zuu> On line 724, it even runs that check in the middle of managing individual connections. 00:21:07 <Zuu> Oh, and a CluelessPlus special is that it stores vehicle and connection states in vehicle names. :-D 00:21:43 <Zuu> So I can click on vehicles in the depot and see if they are waiting to be sold or to be replaced. :-) 00:23:13 <Samu> my ai, up to about 1500-2000 road vehicles, it's fast enough 00:23:26 <Samu> after that, it becomes a crawl 00:23:42 <Zuu> Not bad. 00:23:50 <Samu> seems to become exponentially slower the more it gets 00:24:02 <Samu> could never reach 5k vehicles :( 00:24:42 <Samu> it tops at about 3500, and that's already 5 years per loop :( 00:24:52 <Samu> oh well 00:25:41 <Samu> prioritizing depots is now on my to-do 00:25:48 *** Progman has quit IRC 00:27:45 <Samu> the dynamically adjustment of the number of vehicles, a feature i recently added, is a slow feature in the long run :| 00:28:33 <Samu> adds, then removes, then adds, then removes, depending on the vehicles moving at 0 km/h 00:28:52 <Samu> nice idea in theory, though 00:32:32 <Samu> timing my stuff is a good idea 00:32:58 <Samu> i should do something better about the way i'm timing stuff on the ai 00:33:24 <Samu> what I have was an afterthought, implemented in a rush 00:39:53 *** Thedarkb-T60 has joined #openttd 00:45:08 <Samu> https://paste.openttdcoop.org/pozutqws7 00:45:23 <Samu> gonna see how long this takes in my 3.5k vehicles game 00:47:14 <Zuu> My timing stuff was added quite late too. It doesn't excuse making it nice though. :-) 00:51:38 <Samu> oh gosh, it's so slow i'm already bored lol 00:51:44 <Zuu> :-D 00:52:09 <Zuu> But in overall large programs get out of shape.. CluelessPlus is large and have many quirks. :-) 00:53:04 <Zuu> Backwards compability is one thing that will make it hard to recover from mistakes or bad design in the past. 00:53:27 <Samu> this is weird 00:53:33 <Samu> managed 154 routes in 0 ticks? 00:55:28 <Samu> oh no, i wasn't saving the lists of stuff in depots 00:55:31 <Samu> :( 00:57:56 <Samu> saveload wasn't ready for this, omg i'm so stupid 00:58:56 <Samu> it works on the aircraft side apparently, it wasn't forgotten there 00:59:08 <Samu> i blame the original LuDi 00:59:45 <Samu> or just myself 01:00:15 <Samu> he's storing these vehicles in AILists, but saving lists is slow 01:00:27 <Samu> saving arrays should be faster, right? 01:01:46 <Zuu> I think you can only store squirrel data types so no AILists only arrays, dicts, and simple data types. But maybe OpenTTD have special code for AIList, you have to look up the docs on that. 01:02:02 <Zuu> CluelessPlus just return {} in Save() 01:02:34 <Zuu> And upon a loaded game in Start() it will read the connections from the map. 01:02:59 <Zuu> By parsing order lists, station names and vehicle names. 01:03:24 <Zuu> Using this it rebuilds the connection data to continue manage the connections. 01:05:54 <Samu> hmm, i don't think i can do that here 01:07:02 <Samu> well, it checks for vehicles that are old on the 2nd loop, not all is lost 01:07:44 <Samu> perhaps i dont need to save this data afterall 01:07:52 <Samu> LuDi was smart, not me 01:08:31 <Samu> gonna wait for the 2nd loop, zzz 01:08:34 <Samu> see what happens 01:09:49 <Zuu> Mind that you have limited time in Save() and Load(). If you spend too much time there, your AI will get killed. 01:10:23 <Samu> my load is smart-mode 01:10:44 <Zuu> So any data that is slow to determine for saving has to be pre-cached already before Save() is called. Load is easier, just save the data to this._save and handle it in Start() and you are good. 01:16:46 *** Zuu has quit IRC 01:18:26 *** cboyd_ has quit IRC 01:18:43 *** wodencafe has joined #openttd 01:20:00 *** wodencafe has quit IRC 01:21:19 *** wodencafe has joined #openttd 01:35:28 <Samu> managed the selling/renewing part of 90 routes out of 154 in 4440 ticks 01:35:58 <Samu> @calc 154*4440 / 90 01:35:59 <DorpsGek> Samu: 7597.33333333 01:36:11 <Samu> @calc 7600/74 01:36:12 <DorpsGek> Samu: 102.702702703 01:36:40 <Samu> 103 days just for this :( 01:37:09 <Samu> then there's also the add vehicle to route part, oh crap, this is seriously too slow 01:46:23 *** HerzogDeXtEr has quit IRC 01:59:54 *** lugo has joined #openttd 02:13:13 <Samu> addremoveVehicleToRoute is slow 02:13:27 <Samu> expandStations is slow 02:13:35 <Samu> these are the biggest offenders 02:14:31 <Samu> gonna wait for the selling/renewing again 02:24:54 *** Wormnest_ has quit IRC 02:29:24 *** Thedarkb-T60 has quit IRC 02:33:05 <Samu> okay, i see where part of the slowdown is coming from 02:33:44 <Samu> creating a list of vehicles of type air or road so that I could count them 02:34:45 <Samu> apparently, i got about a total of 8000 vehicles total 02:34:53 <Samu> road and air included 02:35:14 <Samu> if i only want to count road, or air, it takes about 100 ticks 02:35:32 <Samu> a bit less perhaps 02:35:55 <Samu> but inside loops this adds up to become a slowball 02:36:25 <Samu> what can I do to count? 02:37:38 <Samu> dead chat t.t 02:37:54 <Samu> cyas goodnight 02:38:02 *** Samu has quit IRC 03:10:25 *** wodencafe has quit IRC 03:22:59 <DorpsGek_II> [OpenTTD/OpenTTD] lanurmi commented on pull request #6992: small German translation patch https://git.io/fhThx 03:36:02 *** llugo has joined #openttd 03:39:50 *** glx has quit IRC 03:42:02 *** lugo has quit IRC 04:12:04 *** llugo has quit IRC 05:51:04 <DorpsGek_II> [OpenTTD/OpenTTD] telk5093 commented on pull request #6992: small German translation patch https://git.io/fhkv6 07:24:44 <Eddi|zuHause> @calc 22*8 07:24:44 <DorpsGek> Eddi|zuHause: 176 07:24:48 <Eddi|zuHause> @calc 17*12 07:24:48 <DorpsGek> Eddi|zuHause: 204 07:25:38 *** andythenorth has joined #openttd 07:25:44 <andythenorth> moin 07:30:08 *** sla_ro|master has joined #openttd 07:38:31 <Eddi|zuHause> every time i think a bottleneck is solved, a new one pops up 07:38:36 <Eddi|zuHause> and ships are hopeless :/ 07:44:25 <andythenorth> oof 07:44:34 <andythenorth> sounds like they managed to recreate TTD pretty well 07:44:40 <andythenorth> Eddi|zuHause: make a ship mod :P 07:49:48 * andythenorth wonders if TF vehicles make integer tile lengths :P 07:53:52 <Eddi|zuHause> uhm... no.. definitely not 07:54:42 <Eddi|zuHause> andythenorth: platforms have lengths of 80/160/240/...m, but trains have things like 232m 07:55:10 <Eddi|zuHause> wagons of the same generation don't have the same length, engine lengths are all different 07:55:56 <Eddi|zuHause> and trains of length 240m don't quite fit into 240m terminus platforms 07:57:09 <Eddi|zuHause> and i somehow lost my buffer stops... 08:07:55 *** tokai|noir has joined #openttd 08:07:55 *** ChanServ sets mode: +v tokai|noir 08:10:27 <andythenorth> I don't think I could play that game :P 08:10:38 <andythenorth> some part of my brain spent too much time in grids 08:10:59 <andythenorth> tile grids, lego grids, design grids 08:14:09 *** Wacko1976 has joined #openttd 08:14:59 *** tokai has quit IRC 08:18:52 <Eddi|zuHause> that might get tricky in a gridless game 08:20:05 <andythenorth> free-form curves bother me :P 08:26:16 <Eddi|zuHause> so i replaced half my trains with modded trains, and now i'm out of money :/ 08:50:04 <Eddi|zuHause> <andythenorth> sounds like they managed to recreate TTD pretty well <-- it's actually very different from OpenTTD wrt ships, because in OpenTTD ships have endless capacity (you can just add more) whereas in TF they block each other at docks, and the entry/exit time is so large 08:52:28 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh approved pull request #6985: Fix (#6974): Add filter widget to api (and a double dot from somewhere) https://git.io/fhkIq 08:53:58 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh merged pull request #6985: Fix #6974: Add filter widget to api (and a double dot from somewhere) https://git.io/fpoNj 08:57:35 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh approved pull request #6987: Fix: [Win32] WIN32 may not be defined, always prefer the compiler pre… https://git.io/fhkIl 09:12:30 <andythenorth> oof 09:12:34 <andythenorth> blocking ships :P 09:12:38 <andythenorth> such terrible idea 09:52:52 *** lugo has joined #openttd 10:00:50 *** andythenorth has quit IRC 10:04:06 *** Progman has joined #openttd 10:25:58 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #6917: Fix iconv and clang version detection on OSX https://git.io/fhkmU 10:33:09 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #6992: small German translation patch https://git.io/fhkmW 10:33:10 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain closed pull request #6992: small German translation patch https://git.io/fhTKB 10:33:21 <TrueBrain> as it appears nobody wants to close PRs ...... 11:03:01 <TrueBrain> still a downside of our regression, if no gfx can be found, it 'hangs' 11:11:06 *** Thedarkb-T60 has joined #openttd 11:14:09 <TrueBrain> awh, regression fails on Windows .. no clue why .. total disaster :D 11:37:20 <Eddi|zuHause> sounds like you're having a great day. 11:40:52 *** debdog has joined #openttd 11:49:27 * peter1138 fires up VS 2017. 11:51:08 <peter1138> create mode 100644 docs/Readme_Windows_MSVC.md 11:51:08 <peter1138> delete mode 100644 docs/Readme_Windows_MSVC.txt 11:51:15 <peter1138> What do I use to read a .md file? 12:00:01 <debdog> texteditor 12:02:46 *** sla_ro|master has quit IRC 12:08:14 <Eddi|zuHause> .md is effectively wiki-formatting? 12:10:58 *** HerzogDeXtEr has joined #openttd 12:22:44 *** Thedarkb-T60 has quit IRC 12:22:57 <TrueBrain> so for some reason OpenTTD doesn't want to run the regression, but it is not telling me why it doesn't want to :D 12:22:59 <TrueBrain> useful! 12:27:55 *** Thedarkb-T60 has joined #openttd 12:27:59 *** sla_ro|master has joined #openttd 12:28:01 <LordAro> peter1138: Eddi|zuHause: markdown, specifically 12:31:07 *** wodencafe has joined #openttd 12:37:26 *** TrueBrain is now known as TrueBrain_ii 12:37:32 *** Thedarkb-T60 has quit IRC 12:38:18 *** TrueBrain has joined #openttd 12:47:38 *** Wacko1976 has quit IRC 12:49:54 *** Wacko1976 has joined #openttd 13:01:30 *** wodencafe has quit IRC 13:01:47 *** wodencafe has joined #openttd 13:05:27 *** wodencafe has joined #openttd 13:21:39 <TrueBrain> meh; so running regression via MSVC doesn't work currently. Seems it used to work in 2011, but we used the mingw build to do that for the last 10 years. Guess .. we won't run regression on the Windows builds :P 13:26:02 *** lugo has quit IRC 13:30:39 <Eddi|zuHause> regression is overrated 13:30:57 *** Wacko1976 has quit IRC 13:36:28 <FLHerne> Eddi|zuHause: It's sort of halfway between formalised internet-speak formatting and wiki markup 13:36:35 *** lugo has joined #openttd 13:51:11 *** Progman has quit IRC 13:51:27 *** andythenorth has joined #openttd 13:53:23 <andythenorth> well 14:07:35 *** gelignite has joined #openttd 14:33:35 *** andythenorth has quit IRC 14:47:56 *** Flygon has quit IRC 15:07:17 *** andythenorth has joined #openttd 15:09:39 *** Wacko1976 has joined #openttd 15:43:46 *** Wacko1976 has quit IRC 16:44:20 *** debdog has quit IRC 16:45:13 *** glx has joined #openttd 16:45:13 *** ChanServ sets mode: +v glx 17:00:02 *** Borg has joined #openttd 17:00:09 *** gelignite has quit IRC 17:09:20 <DorpsGek_II> [OpenTTD/OpenTTD] glx22 merged pull request #6987: Fix: [Win32] WIN32 may not be defined, always prefer the compiler pre… https://git.io/fp9vd 17:09:54 *** debdog has joined #openttd 17:33:21 *** synchris has joined #openttd 17:46:26 *** gelignite has joined #openttd 17:53:03 *** Thedarkb-T60 has joined #openttd 17:53:13 *** glx has quit IRC 17:56:22 *** Wolf01 has joined #openttd 17:56:42 *** Thedarkb-T60 has quit IRC 17:57:03 *** Thedarkb-T60 has joined #openttd 17:57:18 <Wolf01> o/ 18:28:36 <andythenorth> hi 19:01:16 *** nielsm has joined #openttd 19:04:39 <nielsm> TrueBrain, maybe add a cmdline flag to redirect/tee debug output to a file 19:04:55 <nielsm> or whatever output the regression tests make 19:08:04 <TrueBrain> that is also a possibility 19:08:16 <TrueBrain> but yeah, as it is now, it is not going to work :D 19:08:25 <TrueBrain> well, guess running the Windows build is better than not running it :) 19:16:32 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain opened pull request #6994: Change: use Azure Pipelines instead of self-hosted Jenkins for CI https://git.io/fhka6 19:17:18 <nielsm> :party: 19:17:33 <andythenorth> o_O 19:17:34 <Eddi|zuHause> how is that part of the main repo? 19:18:53 <nielsm> the same way the makefiles and VS projects are 19:18:57 <nielsm> it's build instructions 19:19:55 <andythenorth> I need a train nerd 19:20:00 * andythenorth wonders who will step up 19:22:49 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #6994: Change: use Azure Pipelines instead of self-hosted Jenkins for CI https://git.io/fhka6 19:24:27 <TrueBrain> finding bugs :D 19:25:21 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #6994: Change: use Azure Pipelines instead of self-hosted Jenkins for CI https://git.io/fhka6 19:26:01 <nielsm> ooh, it's checking itself 19:26:27 <Eddi|zuHause> andythenorth: one who tells you how your sprites have the wrong number of rivets? 19:26:29 <TrueBrain> Eddi|zuHause: guess you haven;t looked in the main repo for a very long time :) Or any other "modern" project :D 19:26:48 <Eddi|zuHause> TrueBrain: not really 19:27:09 <TrueBrain> IaC - Infrastructure as Code 19:27:18 <TrueBrain> any decent project these days defines itself how the CI / CD works 19:27:26 <TrueBrain> high locality 19:27:28 <TrueBrain> easier to maintain 19:27:35 <TrueBrain> (and ... tracked in a VCS!) 19:28:09 <Eddi|zuHause> well, my intuition would have been that CI config would be a separate repo 19:28:21 <Eddi|zuHause> like you have separate repos for all the bots 19:29:59 <andythenorth> Eddi|zuHause: one who tells me which european electric loco can be squashed for UK loading gauge :P 19:30:09 <andythenorth> I need a fake freight engine for 2020 or so 19:30:14 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #6994: Change: use Azure Pipelines instead of self-hosted Jenkins for CI https://git.io/fhka6 19:31:17 <TrueBrain> Eddi|zuHause: you won't see many repositories doing that; and for good reason. How the CI runs, is part of a repository. If you put it somewhere else, locality increases, and that makes it harder to maintain 19:31:27 <TrueBrain> its pretty nifty, how "the world" solved this 19:31:28 <nielsm> andythenorth, with hitachi being in the european market (and england) now maybe a japanese one could work too? remember they largely run on narrow gauge 19:32:40 <TrueBrain> come to think of it .. 'tox' already did it too .. which is older than cloud 19:33:34 <andythenorth> nielsm: seems Hitachi have a UK factory :P 19:33:34 <Eddi|zuHause> andythenorth: doesn't siemens build UK versions? 19:33:59 <TrueBrain> Eddi|zuHause: btw, the bots are in a different repository, but the configuration is per repo too 19:34:43 <TrueBrain> okay, job seems to run now :D 19:38:51 <TrueBrain> https://dev.azure.com/openttd/OpenTTD/_build/results?buildId=28&view=logs <- 8 minutes :D 19:39:15 <nielsm> it's certainly better than 20 minutes :) 19:39:26 *** Wormnest has joined #openttd 19:42:17 <TrueBrain> now the question .. shall we just switch or not? 19:43:03 <nielsm> it's probably no worse than the current jenkins 19:43:16 <TrueBrain> good point 19:43:39 <TrueBrain> guess I wait for the review, and then switch Jenkins to Azure .. and we will see how much it burns :D 19:44:17 <andythenorth> it's obvs. nearly time to switch :D 19:44:23 <andythenorth> what could go wrong :P 19:47:15 <TrueBrain> not much honestly :) 19:48:22 <nielsm> i'd say it's pretty well tested already 19:49:12 <TrueBrain> and it ONLY runs on CI currently :) 19:56:50 <nielsm> but the PR is not being run on jenkins so it's blocking the regular merge 19:57:00 <TrueBrain> but I have powers! 19:57:06 <TrueBrain> just not going to change that till it is approved :D 19:57:21 <TrueBrain> and lucky enough .. approval has nothing to do with what CIs think :) 20:00:09 *** Thedarkb-T60 has quit IRC 20:07:20 *** Thedarkb-T60 has joined #openttd 20:08:50 <Heiki> andythenorth: https://en.wikipedia.org/wiki/British_Rail_Class_93_(Stadler) https://railcolornews.com/2018/12/19/uk-class-93-rail-operations-orders-ten-tri-mode-uk-light-locomotives-from-stadler/ coming in 2020 20:09:08 <andythenorth> yeah I just found that 20:09:21 <andythenorth> life imitates art again :) 20:09:28 <Heiki> haha 20:11:37 <andythenorth> thanks 20:12:18 <andythenorth> any visuals yet? o_O 20:13:59 <Heiki> I haven’t found any, but probably quite similar to Class 88 20:17:28 <TrueBrain> nielsm: I didnt say it with that many words, but I was kinda hoping you would approve my PR :D 20:19:05 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh approved pull request #6994: Change: use Azure Pipelines instead of self-hosted Jenkins for CI https://git.io/fhkrz 20:19:28 <nielsm> sry :] 20:19:32 *** glx has joined #openttd 20:19:32 *** ChanServ sets mode: +v glx 20:19:54 <TrueBrain> :D 20:19:55 <TrueBrain> tnx! 20:21:24 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #6994: Change: use Azure Pipelines instead of self-hosted Jenkins for CI https://git.io/fhkrr 20:21:31 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain merged pull request #6994: Change: use Azure Pipelines instead of self-hosted Jenkins for CI https://git.io/fhka6 20:24:00 *** synchris has quit IRC 20:24:44 <TrueBrain> lol; I now blocked all existing PRs :D 20:24:46 <TrueBrain> oops :) 20:25:04 <TrueBrain> if any need merging without them getting an update, let me know 20:25:07 <TrueBrain> but I doubt any will 20:28:57 <glx> always fun to break everything ;) 20:29:03 <TrueBrain> hell yeah! 20:29:25 <TrueBrain> I am so happy we now run native MacOS and Win32/Win64 is back in the CI again :D 20:29:49 <TrueBrain> hopefully this weekend I can get DigitalOcean setup decently enough to start with some IaC hosting :) 20:29:50 <glx> I remember the C to CPP switch breaking all patches 20:30:11 <Borg> does anyone build OpenTTD w/ Mingw here? 20:30:28 <glx> it's half broken Borg 20:30:42 <glx> disable freetype and it should work 20:30:42 <nielsm> before any nightlies can be published the revision detection needs to be fixed I think 20:30:51 <TrueBrain> its broken? Bah .. and yes, indeed 20:31:14 <glx> was broken before your work TrueBrain ;) 20:31:14 <nielsm> due to the azure pipeline doing a detached HEAD checkout 20:31:46 * glx talks about mingw 20:31:53 <TrueBrain> nielsm: that is easily fixable :) 20:32:43 <glx> Borg: hmm mingw32 or mingw64 BTW ? 20:32:49 <Borg> mingw32... 20:33:01 <Borg> im still on best windows ever made.. 20:33:02 <Borg> ;) 20:33:43 <glx> ah it may build then, for mingw64 it definitively fails with freetype (because harfbuzz) 20:33:56 <Borg> oh.. good 20:36:36 <TrueBrain> nielsm: I guess the main issue with a detached head is that branch detection fails? 20:36:51 <TrueBrain> what we normally do for nightlies, is force the version anyway 20:37:06 <TrueBrain> as we .. had a lot of issues with detection over the years :) 20:38:37 <nielsm> nightlies are just master anyway yes 20:38:59 <nielsm> PRs might be annoying 20:39:15 <TrueBrain> yeah; I think we just need a new way of doing this 20:39:33 <TrueBrain> openttd-openttd-pr6698 20:39:35 <TrueBrain> or something 20:39:45 <TrueBrain> so you can also get: truebrain-openttd-master 20:39:46 <TrueBrain> or something 20:39:47 <nielsm> probably better yes 20:39:57 <TrueBrain> but something for another day :) 20:40:01 <nielsm> rather than depending on whatever bad branch name the PR submitter chose 20:42:24 <glx> I think with github desktop I get pr/XXXX as branch name 20:43:04 * glx likes github desktop for things like that 20:43:23 <glx> not for the silly merges I need to fix with rebase -i ;) 20:43:25 <nielsm> https://www.youtube.com/watch?v=b5jIgDAd89E when did we add those features? 20:43:27 <nielsm> ;) 20:47:55 <glx> note for later: don't switch branch in github desktop while compiling 21:15:49 <glx> ok mingw32 still builds and run 21:17:01 <andythenorth> all modern locomotives look like cheese :P 21:17:20 <andythenorth> harder to draw, and kind of boring 21:27:17 <Borg> glx: cool :) 21:27:50 <Borg> haha.. I just upgraded so old Network safe.. w/ new GRF.. 21:28:12 <Borg> now some power stations are overcharging.... 141% capacity output :D 21:36:43 <DorpsGek_II> [OpenTTD/OpenTTD] glx22 opened pull request #6995: Fix 59e42ea17, 1f083c3ac: make clean was not fully cleaning https://git.io/fhk6u 21:38:00 <glx> let's try the new CI ;) 21:38:09 <LordAro> :o 21:38:32 <Eddi|zuHause> 141% is sqrt(2), so i would expect that to be a reasonable output of a power station :) 21:38:59 <Borg> Eddi|zuHause: haha ;) 21:40:27 <Eddi|zuHause> (given that for AC, this is the factor between average and max) 21:40:38 <Borg> yeah... 21:40:44 <Borg> luicky coincidence :) 21:41:01 <glx> TrueBrain: did the PR trigger the CI ? 21:41:14 <Borg> the true reason is. that I added support for power station layouts.. so smaller produce less power (need less coal too) 21:41:29 <TrueBrain> glx: good point, I forgot to switch something on 21:41:30 <TrueBrain> one sec 21:41:35 <Eddi|zuHause> so many revolutions today, what's next, actual nightly builds? :p 21:42:02 <LordAro> woah now, let's not get ahead of ourselves 21:42:28 <TrueBrain> glx: you need to allow forks to run .. and you cannot do that in the YAML .. I keep forgetting that :D 21:43:07 <TrueBrain> glx: can you push again? (rebase, commit-message change, anything?) 21:43:13 <Eddi|zuHause> so much for locality? 21:43:26 <TrueBrain> glx: suggestion: 'make clean' between quotes :P 21:43:34 <TrueBrain> Eddi|zuHause: glass half-empty kinda guy, I see 21:44:08 <Eddi|zuHause> hey, i was just praising all the progress 21:44:41 <DorpsGek_II> [OpenTTD/OpenTTD] glx22 updated pull request #6995: Fix 59e42ea17, 1f083c3ac: make clean was not fully cleaning https://git.io/fhk6u 21:45:06 <TrueBrain> glx: there we go :) 21:45:25 <Eddi|zuHause> (on an unrelated note, sudden switching between high and low could be a sign of depression) 21:46:01 <TrueBrain> luckily, that is very treatable these days :) 21:46:25 <TrueBrain> glx: hmm ... let me investigate what is going wrong here :) 21:46:50 <glx> it's "in progress" 21:47:10 <TrueBrain> "Latest build not found" .. wuth? 21:49:12 <glx> at least linux and macOS work 21:50:31 *** Wacko1976 has joined #openttd 21:50:31 <andythenorth> yay 21:50:34 <TrueBrain> how weird .. it cannot find the dependencies in the artifact .. 21:50:38 <andythenorth> 'work' 21:51:56 <glx> but I like how the checks are detailled in github 21:52:28 <peter1138> I set up my own Jenkins just so I could copy what we'd done here, and now I have no clue ;p 21:55:14 <LordAro> haha 21:55:27 *** Borg has quit IRC 21:57:18 <TrueBrain> a bit of trial and error .. lets see if I can find the issue 21:57:35 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain opened pull request #6996: Fix: [AzurePipelines] download the correct Windows Dependency artifact https://git.io/fhkis 21:58:06 <TrueBrain> no clue if it uses my new yml now, or the one in master :D 21:59:41 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #6996: Fix: [AzurePipelines] download the correct Windows Dependency artifact https://git.io/fhkis 22:00:09 <glx> good question 22:01:06 <TrueBrain> from my branch :P 22:01:12 <TrueBrain> not what I would like, but fair enough 22:01:20 <TrueBrain> hmm 22:01:21 <TrueBrain> this is weird 22:01:30 <glx> same error 22:04:55 <TrueBrain> okay, this worked a moment ago .. lolz .. :D 22:05:04 <TrueBrain> weird 22:05:58 <TrueBrain> their editor also lost track of the artifact ... which really is there :D 22:06:37 <nielsm> anyone more awake than me, who can check this for me? https://0x0.st/snTm.txt -- the "do not write multiple blank lines in a row" part does not work, it does produce multiple blank lines around a skipped block 22:06:46 <nielsm> (the actual block detection and skipping works) 22:07:29 <nielsm> full script: https://0x0.st/snTa.txt 22:13:57 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #6996: Fix: [AzurePipelines] download the correct Windows Dependency artifact https://git.io/fhkis 22:14:43 <TrueBrain> hmm .. if this fixes the issue, I have another problem, but at least I know where that problem is :D 22:15:28 <glx> it doesn't :( 22:15:42 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #6996: Fix: [AzurePipelines] download the correct Windows Dependency artifact https://git.io/fhkis 22:15:52 <TrueBrain> ugh, sorry for the spam .. not really another way to test this :( 22:17:13 <andythenorth> GL :) 22:17:14 <andythenorth> bye 22:17:16 *** andythenorth has left #openttd 22:17:37 <TrueBrain> this worked moments ago ... lolz 22:18:29 <nielsm> ah figured out my problem 22:20:30 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #6996: Fix: [AzurePipelines] download the correct Windows Dependency artifact https://git.io/fhkis 22:23:28 <TrueBrain> okay, it works if I run it manually 22:23:31 <TrueBrain> it fails when it comes from a PR 22:23:32 <TrueBrain> interesting 22:24:02 <glx> depends on the username ? 22:24:19 <glx> or the account 22:25:10 <nielsm> hm did we use "remove:" or "update:" for removing unused strings from language files? 22:25:29 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #6996: Fix: [AzurePipelines] download the correct Windows Dependency artifact https://git.io/fhkis 22:25:37 <glx> we used to use "cleanup:" 22:25:53 <TrueBrain> nielsm: the fact you ask, means we made it too complicated :D 22:26:21 <TrueBrain> fix/change/update is already confusing for me :D 22:26:35 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #6990: Fix: Correct display of industry requires/produces in Build Industry window https://git.io/fhTef 22:29:24 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #4410: Trains: var4A in purchase list (current railtype) https://git.io/fhkPy 22:29:39 <TrueBrain> I am very tempted to store the artifact somewhere else, so I can just download it :P 22:29:58 <glx> yup looking at the logs I see many Cleanup for removing strings 22:31:09 <glx> TrueBrain: the other option being to rebuild the deps each time I guess 22:31:29 <TrueBrain> glx: yeah .. adds 10 more minutes to the CI :( 22:34:19 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #6996: Fix: [AzurePipelines] download the correct Windows Dependency artifact https://git.io/fhkis 22:35:16 <TrueBrain> now I come to think of it, it might be good to publish it on github as 'release' :P 22:35:18 <TrueBrain> but that is for another day 22:35:36 <TrueBrain> (possibly others find it useful to have the dependencies pre-compiled too) 22:38:12 <TrueBrain> I think it has to do with authentication of some sorts 22:39:11 <glx> that's what I think too 22:39:43 <glx> because when you start it with your truebrain account it works 22:40:03 <glx> *manually 22:41:54 <TrueBrain> of all the issues, I did not expect this to be one :) 22:47:51 <glx> https://docs.microsoft.com/en-us/azure/devops/pipelines/_img/choose-authorize-with-oauth.png?view=vsts from https://docs.microsoft.com/en-us/azure/devops/pipelines/get-started/pipelines-sign-up?toc=/azure/devops/pipelines/toc.json&bc=/azure/devops/boards/pipelines/breadcrumb/toc.json&view=vsts suggest installing the github app to the github organisation 22:48:02 <glx> dunno if you did it 22:48:39 <TrueBrain> yeah; the issue seems to be in permissions inside Azure Pipelines 22:48:53 <TrueBrain> a build triggered from a PR has less rights 22:48:57 <TrueBrain> which seems to give issues here 22:50:16 *** sla_ro|master2 has joined #openttd 22:52:02 <glx> oh nice I have access to the configuration ;) 22:52:11 <glx> (don't worry I won't touch) 22:52:48 <TrueBrain> how do you have access? 22:52:51 <TrueBrain> (that is interesting :D) 22:53:19 <glx> only the basic settings, like repos selection 22:53:42 <TrueBrain> you can save it too? 22:53:57 *** sla_ro|master has quit IRC 22:54:06 <glx> and uninstall 22:54:15 <TrueBrain> in GitHub? 22:54:18 <TrueBrain> yeah, ofc, you are owner there 22:54:24 <glx> yes in github :) 22:54:43 <TrueBrain> but yeah, the issue is not with github 22:54:47 <TrueBrain> it is in azure pipelines 22:55:03 <TrueBrain> (the artifact is in azure pipelines, and it tries to download it (and fails)) 22:55:49 <glx> hmm I could force merge my PR 22:55:56 <glx> to trigger a master build 22:56:04 <TrueBrain> master build? 22:56:09 <TrueBrain> there is no master build 22:56:15 <TrueBrain> which is a good point, there is no master build :P 22:56:34 <glx> of course because there's no nightly yet 22:56:49 <TrueBrain> yeah, but we can also validate master after commit 22:56:54 <TrueBrain> but not important atm :) 22:57:44 <TrueBrain> when I manually query the API, I get results .. hmm 22:58:04 *** nielsm has quit IRC 22:58:05 <TrueBrain> so .... I need more debugging info 22:59:15 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #6996: Fix: [AzurePipelines] download the correct Windows Dependency artifact https://git.io/fhkis 23:02:54 *** Thedarkb-T60 has quit IRC 23:03:07 <glx> hmm it should be possible to add a regression project in the solution 23:03:11 <TrueBrain> meh; more debugging is difficult 23:03:21 <TrueBrain> glx: please do :) 23:05:15 *** Thedarkb-T60 has joined #openttd 23:05:53 <TrueBrain> I see the line of code that fails in the source code, but not really a way to debug it :D 23:09:23 <Wolf01> 'night 23:09:28 *** Wolf01 has quit IRC 23:14:16 <TrueBrain> okay .... guess the only solution is to make our own task, which is a copy of theirs, and add debugging :P 23:20:55 <TrueBrain> funny ... depending on the API version I use, I can access the API or not 23:37:45 *** Samu has joined #openttd 23:38:03 <Samu> hi 23:40:49 *** gelignite has quit IRC 23:52:21 *** sla_ro|master2 has quit IRC 23:56:59 *** Wacko1976 has quit IRC 23:57:41 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #6996: Fix: [AzurePipelines] download the correct Windows Dependency artifact https://git.io/fhkis