Times are UTC Toggle Colours
00:07:06 <DorpsGek_II> [OpenTTD/OpenTTD] ale84s commented on issue #7087: Presignal doesn't work on long distance https://git.io/fhwvx 00:14:56 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro requested changes for pull request #7085: Fix: Remove duplicate French and Slovak town names https://git.io/fhwfW 00:28:00 *** supermop_work_ has quit IRC 00:29:56 <DorpsGek_II> [OpenTTD/OpenTTD] nikolas updated pull request #7085: Fix: Remove duplicate French and Slovak town names https://git.io/fh2Af 00:30:24 <DorpsGek_II> [OpenTTD/OpenTTD] nikolas commented on pull request #7085: Fix: Remove duplicate French and Slovak town names https://git.io/fhwJ8 00:31:50 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on pull request #7080: Change: Cache stations and links for whole map for linkgraph GUI to eliminate delay when scrolling or zooming https://git.io/fhwJ0 00:37:24 <Samu> still testing windows closures 00:41:07 <m1cr0man> What happens when the passenger distribution is set to manual? 01:12:09 *** Thedarkb-T60 has quit IRC 01:19:04 *** Wormnest has joined #openttd 01:29:56 <Samu> makes them unload at the next station that accepts passengers, instead of the station they want to go 01:34:06 *** Wormnest has quit IRC 01:57:25 <m1cr0man> right cool. I just found the big wiki page on cargodist too that cleared it all up 01:58:18 <m1cr0man> I was running asymmetric distribution for my last game and it got..weird (5000 people to a city with 100 people), so I'm going to do 75% symmetric for the next run 02:37:39 <Samu> aha, 1024 is the correct size 02:39:19 *** Thedarkb-X40 has quit IRC 02:40:49 <DorpsGek_II> [OpenTTD/OpenTTD] glx22 commented on issue #7007: Joining server via shortcut causes freeze https://git.io/fhwtG 02:51:38 *** Pikka has joined #openttd 03:27:31 <Samu> i'm getting a crash only in debug mode 03:28:28 <Samu> in release it doesn't crash. Regardless, it's a bug, a difficult one to reproduce 03:45:10 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick opened issue #7090: Query box sets value to hidden parameters https://git.io/fhwmV 03:51:32 *** D-HUND has joined #openttd 03:54:52 *** debdog has quit IRC 03:55:00 *** Samu has quit IRC 04:04:57 *** snail_UES_ has joined #openttd 04:17:04 *** glx has quit IRC 04:27:45 *** Gustavo6046 has quit IRC 05:03:29 *** snail_UES_ has quit IRC 05:03:36 *** HeyCitizen has quit IRC 05:03:41 *** HeyCitizen has joined #openttd 06:12:30 *** HerzogDeXtEr has joined #openttd 06:19:47 <DorpsGek_II> [OpenTTD/OpenTTD] btzy updated pull request #7080: Change: Cache stations and links for whole map for linkgraph GUI to eliminate delay when scrolling or zooming https://git.io/fh2LL 06:25:15 <DorpsGek_II> [OpenTTD/OpenTTD] btzy updated pull request #7080: Change: Cache stations and links for whole map for linkgraph GUI to eliminate delay when scrolling or zooming https://git.io/fh2LL 06:26:41 <DorpsGek_II> [OpenTTD/OpenTTD] btzy commented on pull request #7080: Change: Cache stations and links for whole map for linkgraph GUI to eliminate delay when scrolling or zooming https://git.io/fhwGy 07:01:07 *** Pikka has quit IRC 07:09:11 *** andythenorth has joined #openttd 07:13:01 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7082: Blitter line drawing improvements https://git.io/fhwnl 07:17:46 *** sla_ro|master has joined #openttd 07:17:47 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7082: Blitter line drawing improvements https://git.io/fhwnr 07:19:37 *** HerzogDeXtEr has quit IRC 07:29:02 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7083: Codechange: [Linkgraph GUI] Replace line visibility detection algorithm https://git.io/fhwcv 07:43:16 <andythenorth> probably 07:43:20 <andythenorth> acceleration 07:43:23 <andythenorth> is silly 07:43:27 <andythenorth> :D 08:16:32 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7084: Change: AI/GS Config GUI overhaul https://git.io/fhwWn 08:26:54 *** HeyCitizen_ has joined #openttd 08:28:14 *** andythenorth has quit IRC 08:32:00 *** HeyCitizen has quit IRC 08:52:00 *** Pikka has joined #openttd 08:58:42 *** andythenorth has joined #openttd 09:06:18 <peter1138> Raaar 09:15:05 <Pikka> ee 09:16:52 *** Smedles_ has quit IRC 09:28:26 *** tokai has joined #openttd 09:28:26 *** ChanServ sets mode: +v tokai 09:30:37 *** andythenorth has quit IRC 09:35:24 *** tokai|noir has quit IRC 09:37:58 <planetmaker> moin 09:43:30 *** Smedles has joined #openttd 09:43:41 <Pikka> isn't it 10:01:01 <DorpsGek_II> [OpenTTD/OpenTTD] JGRennison commented on pull request #7082: Blitter line drawing improvements https://git.io/fhwEl 10:02:34 *** andythenorth has joined #openttd 10:07:21 *** Smedles has quit IRC 10:11:25 <andythenorth> orly? 10:13:18 *** Smedles has joined #openttd 10:13:21 <DorpsGek_II> [OpenTTD/OpenTTD] JGRennison updated pull request #7082: Blitter line drawing improvements https://git.io/fh2Ds 10:36:41 <Pikka> probably, andythenorth 10:53:06 <andythenorth> yeah, I'm inclined to agree 11:06:30 *** Borg has joined #openttd 11:06:34 <Borg> hi.. 11:06:55 <Borg> is Company Statue is not counted for Oil Rigs? 11:07:05 <Borg> hmm right! it should NOT 11:07:10 <Borg> because Oil Rig is neutral 11:07:13 <Borg> mystery solved 11:08:48 <peter1138> Nice. 11:09:28 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7082: Blitter line drawing improvements https://git.io/fhwai 11:11:17 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN approved pull request #7082: Blitter line drawing improvements https://git.io/fhwaF 11:12:09 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN merged pull request #7082: Blitter line drawing improvements https://git.io/fh2Ds 11:17:54 <andythenorth> can't believe it's lunchtime already :o 11:18:11 <peter1138> It's not quite :p 11:21:11 <peter1138> Might be cuppa time, though. 11:24:57 <andythenorth> mac + cheese 11:25:11 <peter1138> A cup of macaroni cheese, eh? 11:25:45 <andythenorth> if a cup is also a bowl, yes 11:27:18 <peter1138> Can be! 11:27:27 <peter1138> It's good enough for a cup-a-soup... 11:27:35 *** Gabda has joined #openttd 11:27:39 <Gabda> hi 11:29:24 <Gabda> is there a code editor that shows the documentation texts of the functions, when as mouseover text when I select a use of that function somewhere in the code? 11:32:56 <Gabda> there are format strings in the documentatios, so I assume something display those texts 11:35:22 <Eddi|zuHause> most IDEs nowaday should be able to do that 11:39:13 <peter1138> Not sure what IDEs people use for OpenTTD. 11:39:19 <peter1138> I'm still using vim. 11:40:19 <andythenorth> "what's an IDE" :P 11:40:38 <andythenorth> text ed 11:40:41 <Borg> guys.. help. GRF.. arytmetic... its normal standard x86 one? right? 11:40:42 <andythenorth> shell 11:40:44 <andythenorth> done 11:40:58 <Borg> for callback results.. I see info that sign is bit14.. but its just informative? 11:40:59 <peter1138> Borg, er, what's the actual question? 11:41:17 *** WWacko1976-work has quit IRC 11:41:17 *** Mazur has quit IRC 11:41:27 <Borg> still -1 ix 0xFFFF (16bit) and not 0x4001 ? 11:42:20 <peter1138> You can't return 0xffff. 11:42:26 <Borg> I know 11:42:36 <Borg> callbacks results are limited to 14 bits 11:42:50 <Borg> 15 bit.. is reserved for.. callback result or jump 11:43:04 <Borg> but now.. I want to return negative values 11:43:25 <Borg> and I see note in callback results.. that sign is 14 bit... 11:43:33 <Borg> I know architectures.. where there is ACTUAL sign bit 11:43:36 <Borg> x86 doesnt have one 11:43:47 <Borg> too hard question and I should go RTFS? 11:44:01 <peter1138> bit 15 (counting from 0) leaves you with 15 bits for the result, not 14. 11:44:08 <Borg> right 11:44:13 <Borg> 0-14 11:44:13 <peter1138> (Caveat that grfv7 has some reserved values) 11:44:37 <Borg> I want to use nvar=0 actually 11:44:39 <peter1138> In a 15 bit value, 7fff would be -1 11:44:49 <Borg> okey 11:44:50 <peter1138> Why would you think it's 4001? 11:44:53 <Borg> so its normal x86 11:45:05 <Borg> because if you have sign bit.. its completly different 11:45:10 <peter1138> normal two's complement 11:45:23 <peter1138> the sign bit is in the value 11:45:32 <peter1138> if it's set, it's negative. 11:45:41 <Borg> there is no sign bit in x86 :) 11:46:24 <Borg> okey. anyway. problem solved. thx 11:46:26 <peter1138> i think you are wrong there 11:46:32 <Borg> elaborate 11:47:13 <peter1138> https://pdos.csail.mit.edu/6.828/2012/readings/i386.pdf < page 34 11:47:36 <peter1138> but that's not really relevant 11:49:13 <Borg> ih.. its ages when I done x86 assembly 11:49:21 <Borg> but.. its not that.. 11:49:29 <Borg> I think.. 11:49:38 <Borg> x86 values does not have sign 11:49:47 <peter1138> That's literally the sign flag, set in the CPU's status register depending on the last op. 11:50:06 <peter1138> Sure they do. It's bit 15 in a 16 bit value, for example. 11:50:11 <Borg> but.. its completly optional 11:50:16 <peter1138> It always is. 11:50:23 <Borg> the beauty of x86 is that is irravelant 11:50:27 <Borg> for basic add/sub 11:50:35 <peter1138> If bit 15 is set, then the sign flag will be set. 11:50:38 <Borg> thays why 0x80 can be 128 or -128 11:50:59 <peter1138> That depends if you are treating your value as signed or unsigned. 11:51:03 <Borg> exacly! 11:51:09 <peter1138> Maybe you are not using the right terminology. 11:51:10 <Borg> thats why x86 doesnt have sign.. 11:51:15 <peter1138> It does have sign. 11:51:22 <Borg> some architectures actually can reserve bit for sign :) 11:51:32 <peter1138> Whether it is signed or not depends how your code uses it, not on the CPU. 11:51:49 <peter1138> That must be pretty rare and obsolete. 11:51:54 <Borg> yep.. its rare 11:52:07 <Borg> but ok.. I probably went too far away w/ it.. 11:52:11 <peter1138> Two's complement has been the standard since... forever. 11:52:13 <Borg> TTD was developed in DOS for x86 11:52:23 <Borg> and I should use it as reference 11:52:35 <peter1138> No, you should use the specs as your reference. 11:52:43 <peter1138> x86 is irrelevant. 11:53:19 <Borg> hmm 11:53:27 <Eddi|zuHause> two's complement has been the standard for so long, they considered putting it in the C standard instead of leaving it undefined 11:53:36 <Borg> thats why wording in newgrf worring me 11:53:48 <Eddi|zuHause> i've never ever seen an architecture not using two's complement 11:54:30 <peter1138> In a 16 bit signed value, bit 15 is the sign bit. 11:54:39 <peter1138> I don't understand what's confusing :p 11:55:21 <Borg> https://en.wikipedia.org/wiki/Signed_number_representations 11:55:23 <peter1138> "x86 doesn't have a sign bit" ... it's that register at that moment that has the sign bit. 11:55:29 <Borg> read Signed Magnitude representation 11:55:48 <Borg> thats what I was talking about 11:55:58 <peter1138> We're not using calculator's visual output, here... 11:56:40 <peter1138> I guess two's complement is so standard, nobody ever considered documenting in the specs that it is still two's complement :p 11:57:11 <peter1138> We don't use binary coded decimal either. 11:57:41 <Borg> so.. as I said.. doing x86 as reference is good enough 11:57:52 <Borg> anyway.. back to grf coding.. 11:58:02 <peter1138> (Except that, conveniently, 0x50 = 80km/h = 50mph) 11:58:08 <Eddi|zuHause> no, but we use "4-byte strings as uint" 11:59:54 <Gabda> is there a reason that in sortlist_type the sortable list (GUIList) has GUI in it? 12:00:28 <peter1138> It was written for GUI code originally, I suppose. 12:00:48 <Gabda> can it be used for other pusposes than displaying a sorted list on the screen? 12:01:44 *** andythenorth has left #openttd 12:01:44 <peter1138> Maybe. It was written with GUI in mind such that the list be cached when possible. 12:01:52 <Gabda> or there is a hidden restriction? 12:03:00 <Gabda> ok, if there is no obvious restriction, I will try to use it 12:05:09 *** WWacko1976-work has joined #openttd 12:05:26 *** WWacko1976-work has quit IRC 12:05:53 <peter1138> Yeah, probably better to use the existing function (even if it's misnamed?) than inventing more code. 12:06:57 <Gabda> abd the sorter behind it seems nice 12:07:03 <Gabda> *and 12:30:00 <Borg> arghh! 12:30:01 <Borg> ! *00 0B 01 0B 00 01 02 03 04 05 06 07 08 09 0A 1A 02 12:30:05 <Borg> guys.... 12:30:20 <Borg> num-info.. 12:30:35 <Borg> if I specify more that 1 ? how that should to work.. this one doesnt work 12:30:58 <Borg> I want to change 1 property of 11 cargos 12:31:11 <Borg> 1A 02 is custom rating calc CB 12:32:01 <peter1138> Id "The Vehicle ID of the first vehicle or station to change. If num-info is greater than one, this vehicle/station and the following vehicles/stations will be changed. " 12:32:38 <Borg> yeah.. 12:32:59 <Borg> but what about props? I should do num-id * num-props? 12:33:48 <peter1138> "Each property byte is followed by <num-info> new-info sections" 12:34:18 <Eddi|zuHause> num-info > 1 goes through each consecutive ID 12:34:33 <Borg> aahh 12:34:53 <Borg> so its easier to actually split it 12:34:59 <Eddi|zuHause> for (i=id; i<id+num_info; i++) 12:35:23 <peter1138> It's easier to use nml ;) 12:35:25 <Borg> because I still dont get it.. why this one does not work 12:35:42 <Eddi|zuHause> i wasn't going to open that can of worms :p 12:35:44 <Borg> peter1138: haha ;) nah.. im fine w/ my own NFO system.. works pretty well 12:36:04 <peter1138> I don't know what "! *" means in your input. 12:36:18 <Borg> I have ruby script that does sprite number and size calculations 12:36:21 <peter1138> Ok 12:36:49 <Borg> also.. rewriting it to NML would be nightmare.. 12:36:59 <Borg> I already rewritten it to support opcode mnemonics 12:37:00 <Eddi|zuHause> you know there's nforenum? 12:37:22 <Borg> oh.. nope..but IRC is better imo? :) 12:37:27 <Borg> is there nfo channel? ;) 12:37:27 <peter1138> So you wrote: action 00, feature 0B, num-props 01, num-info 0B, Starting at ID 00, changing property 01, value for first ID 02, value for second ID 03 ... etc, etc... 12:37:55 <Borg> peter1138: yeah... 12:38:11 <Borg> at least its how I understood newgrf specs.. 12:38:25 <Borg> u specifify n IDs.. and then props they will be changed for.. 12:38:26 <peter1138> 12:31 < Borg> 1A 02 is custom rating calc CB 12:38:41 <Borg> property 1A.. bit2 set 12:38:43 <peter1138> Borg, that's not what I wrote. 12:38:57 <peter1138> You only specify 1 ID. 12:39:04 <peter1138> You specify the value multiple times. 12:39:49 <peter1138> Ah, sorry assumed the value was a byte, if it's two bytes, then you've not got enough values, and the first value would be 0x0302 12:39:58 <Borg> value of what? 12:40:14 <Borg> its the only thing I dont get in NFO :D 12:40:26 <Borg> I never managed to set properties for multiple objects.. it never worked 12:40:38 <peter1138> value. the value of the property you want to set 12:40:53 <Borg> okey.. but lets read it again 12:41:00 <Borg> Id: The Vehicle ID of the first vehicle or station to change. If num-info is greater than one, this vehicle/station and the following vehicles/stations will be changed. 12:41:07 <Borg> its all right.. when num-info is 1 12:41:32 <Borg> to my understanding.. if you have num-info > 1 u have to specify multiple IDs.. like list.. 12:41:37 <Borg> right? 12:41:45 <peter1138> No, you always specify one ID, the rest are sequential from there. 12:41:47 <peter1138> 12:37 <@peter1138> So you wrote: action 00, feature 0B, num-props 01, num-info 0B, Starting at ID 00, changing property 01, value for first ID 02, value for second ID 03 ... etc, etc... 12:41:53 <peter1138> As I wrote but you didn't seem to understand either. 12:42:46 <peter1138> Feature 0B (cargo) property 0B is "TextID for 1 unit of cargo"... so where are you getting custom rating calc CB? 12:42:48 <Borg> so what it means if num-info > 1 following stations/vehicles will be changed? 12:43:16 <peter1138> If you specify ID 00, and num-info is 3, then you will be setting the value for IDs 00, 01, and 02. 12:43:21 <Borg> where that folling IDs are specifed.. or they are calculated on fly? 12:43:28 <peter1138> They are SEQUENTIAL. 12:43:33 <Borg> ahhhhh 12:43:46 <peter1138> The IDs following the first ID. 12:43:47 <Borg> someone need add comment there.. that its calculated on fly! 12:43:55 <Borg> now is all clear :) lets try 12:44:25 <peter1138> It's specified that you provide the first ID only. 12:44:43 <Borg> yeah.. but adding (calculated on fly). would be good too :D 12:45:08 <Borg> no is all clear 12:45:10 <peter1138> Oh yes, ignore my text thing, I was misinterpreting too :p 12:46:04 <Borg> yep! it doesnt work either :( 12:46:09 <peter1138> You need something like 00 0B 01 0B 00 1A 02 02 02 02 02 02 02 02 02 02 02 12:46:30 <peter1138> And you also need nforenum. 12:46:41 <Borg> what is 02 02 02 at the end? 12:46:46 <peter1138> That's the value you are setting. 12:46:49 <Borg> ahhhh 12:46:57 <Borg> dammit.. its more complicated that I tought 12:47:13 <peter1138> "Each property byte is followed by <num-info> new-info sections. " 12:47:19 <Pikka> reconsider changing to nml? :P 12:47:26 <Borg> Pikka: howdy!!! :) 12:47:42 <Borg> Pikka: no need to :) really.. this is last thing to be sorted out in NFO.. 12:47:46 <Borg> everything works good 12:47:54 <Borg> as I said.. I can always do copy pasta 12:48:03 <Borg> and I will do it! since this thing is completly illogical to me 12:48:35 <Borg> Pikka: part of NFO code for rating calc: 12:48:38 <peter1138> There's a reason nml was developed. 12:48:38 <Borg> ! *02 0B 01 gw pcl B0 avs FF 00 add pcl B1 avs FF 00 add 12:48:38 <Borg> FF FF 12:48:45 <Eddi|zuHause> that's why people don't code in NFO anymore 12:48:48 <Borg> fuuckl :( 12:48:54 <peter1138> NFO is very low level, based on TTDPatch internals. 12:48:55 <Borg> lets use pastebin 12:49:03 <Pikka> who doesn't code in nfo any more, Eddi|zuHause? 12:49:12 <peter1138> Anyway, thanks for that diversion, my lunch is now at a more reasonable time ;) 12:49:20 <Eddi|zuHause> you know, people 12:49:34 <Eddi|zuHause> no sane people code in nfo 12:49:35 <Borg> peter1138: https://paste.openttdcoop.org/p8pepteoy 12:49:49 <Borg> s/peter1138/Pikka/ 12:49:55 <peter1138> Looks like giberish to me :-) 12:50:02 <Pikka> that explains a lot, eddi 12:50:14 <Eddi|zuHause> well, it is gibberish, that's why it doesn't work :p 12:50:19 <Borg> it works :D 12:50:27 <Borg> and mnemonics are easy to remember 12:50:31 <Borg> pcl is procedure call. 12:50:42 <Borg> gw -is generic word access type 12:50:48 <Borg> avs is advanced variable shift :) 12:50:50 <Borg> etc etc 12:51:21 <Eddi|zuHause> for now there is only one single person in the world for whom it is "easy" 12:51:27 <Borg> ;) 12:52:33 <peter1138> I'd go with NML, yes. 12:53:44 <Borg> okey.. I did copy&paste.. GRF loads 12:53:46 <Borg> lets test! 12:54:04 <Borg> and it workz!!! :D 12:56:00 <Borg> Pikka: so? you switched to NML too? 12:56:27 <Pikka> no, I'm insane 12:57:27 <Borg> ;D 12:57:45 <Borg> Pikka: so you might be interested in my grfix.rb ;) 12:58:16 <Eddi|zuHause> very unlikely 12:58:27 <Eddi|zuHause> because he knows about nforenum 12:58:42 <Borg> sure.. if Pikka remember all hex opcodes :) then no problem 12:59:04 <Eddi|zuHause> there's escape sequences, you know? 12:59:20 <Borg> Eddi|zuHause: yeah.. and except \d \w they are ugly as fuck :D 12:59:38 <peter1138> NFO is ugly as fuck. 13:00:01 <Borg> well.. its not pretties too.. but aint that bad 13:02:19 <planetmaker> it reads to me like we have s/o here who re-invents nforenum ;) 13:02:21 <Borg> Eddi|zuHause: also.. escape sequences doesnt cover everything 13:03:04 <Borg> I added few extras 13:04:51 <Borg> https://paste.openttdcoop.org/pgbluvfmu <- all stuff currently supported 13:05:03 <Borg> it also does minimal sanity checks for act2 13:07:30 *** WWacko1976-work has joined #openttd 13:41:04 *** Mazur has joined #openttd 13:48:16 *** snail_UES_ has joined #openttd 13:51:55 *** Samu has joined #openttd 13:53:49 <Samu> hi 13:56:13 <Borg> hmmm 13:56:19 <Borg> my rating calculations does NOT work 13:56:24 <Borg> I always get good rating.. 13:56:29 <Borg> I did RTFS.. and found this 13:56:31 <Borg> if (HasBit(callback, 14)) rating -= 0x4000; 13:56:40 <Borg> rating is int 13:56:46 <Borg> and so.. 32bit value 13:59:35 <Borg> lets do some calc 14:00:49 <milek7> looks like fancy way to clear 14 bit 14:01:43 <Borg> % ruby -e 'puts "%08X" % (-1&0x7FFF-0x4000)' 14:01:45 <Borg> 00003FFF 14:01:50 <Borg> looks kinda.. wrong? 14:03:25 <Borg> in CB 154 I am supposed to return negative value.. 14:03:25 *** WWacko1976-work has quit IRC 14:04:36 *** WWacko1976-work has joined #openttd 14:05:29 *** snail_UES_ has quit IRC 14:06:21 <Borg> it looks like that HasBit check should NOT happen at all 14:06:31 <peter1138> I guess it is 0x3fff 14:06:42 <Borg> thats why I argued peter1138 about sign 14:06:53 <peter1138> no 14:06:58 <Borg> 3fff is maximal signed value for 15 bits 14:07:05 <peter1138> It's still two's complement. 14:07:27 <Samu> WC_AI_SETTINGS, WC_GAME_OPTIONS, WC_AI_DEBUG, WC_AI_LIST, WC_QUERY_STRING, WC_TEXTFILE 14:07:33 <peter1138> I didn't read the spec :p 14:07:49 <Samu> dropdown lists aren't a window? 14:07:51 <Borg> peter1138: specs say: s long as you stay in the range -16384..16383). 14:08:07 <Borg> % printf "%d\n" 0x3FFF 14:08:07 <Borg> 16383 14:08:10 <peter1138> Hmm. 14:08:11 <Borg> looks about wrong 14:08:28 <peter1138> So it is a 15 bit value or a 14 bit value... 14:08:39 <Borg> 0x8000 means callback have result 14:09:06 <Borg> so.. .. its like result&0x7FFF|0x8000) 14:09:20 <Borg> and u are supposed to get 15 bits from result 14:09:42 <Borg> but.. my calc is wrong 14:09:57 <peter1138> 154 are you sure? 14:10:01 <Borg> FUUUUCK. 14:10:05 <Samu> :) 14:10:08 <Borg> sometimes I hate irssi 14:10:30 <Borg> rating = GB(callback, 0, 14); 14:11:00 <Samu> 7F = 0111 1111 14:11:01 <peter1138> Ah, you mean CB 145 14:11:04 <peter1138> Not 154. 14:11:08 <Borg> yeah.. sorry 14:11:12 <Borg> % ruby -e 'puts "%08X" % (-1&0x3FFF-0x4000)' 14:11:12 <Borg> FFFFFFFF 14:11:15 <Borg> okey. now is -1 14:11:18 <Borg> so its all right 14:11:33 <Samu> 80 = 1000 0000 14:11:58 <Samu> 7F + 80 = FF 14:12:02 <Eddi|zuHause> Borg: internally everything is treated as unsigned, so you need to sign-extend it, if you want to store it in a 16bit or 32bit int 14:12:13 <Borg> or.. I am wrong again 14:12:20 <Borg> lets see GB macro 14:13:21 <Samu> peter1138 help me fix this 14:13:28 <Eddi|zuHause> sign-extend means: if (highest original bit set) {set all higher bits} else {unset all higher bits} 14:13:48 <Samu> i want to close WC_QUERY_STRING on ai parameters that just became invisible 14:14:03 <Borg> GB(shift,num) 14:14:30 <Samu> to fix https://github.com/OpenTTD/OpenTTD/issues/7090 14:15:10 <Borg> okey.. so calc looks about right... 14:15:26 <peter1138> I mean, it's possible it's been wrong since forever, but... 14:16:10 <Borg> return (x >> s) & (((T)1U << n) - 1); 14:16:15 <Eddi|zuHause> i think the specs were never really meant to work for signed 14:16:20 <Borg> I wonder if -1 is right here 14:16:26 <Borg> its wrong again then 14:16:46 <Borg> ahh its ok 14:16:47 <Eddi|zuHause> Borg: test again for positive numbers 14:16:49 <Borg> im tired already 14:17:01 <Borg> Eddi|zuHause: ok.. I will return 0 14:17:07 <peter1138> Eddi|zuHause, this is existing code, so it should work. 14:17:09 <Borg> instead of negative in my CB 14:17:18 <peter1138> Not something Borg is adding. 14:17:27 <Borg> yeah.. im coding GRF.. CB 145 14:17:50 <peter1138> However 14:17:56 <peter1138> CB 145 doesn't take a signed value? 14:18:11 <peter1138> Or I haven't read it enough. 14:18:14 <peter1138> It's quite verbose. 14:18:18 <Borg> CB 145 takes 2 params... 18 in form ssaaaatt 14:18:22 <peter1138> The callback allows you to replace the first three components (days since last pickup, amount waiting and max. speed of last vehicle) in the calculation above. If your callback succeeds, the first three components are skipped and the returned value is used instead their results. Bit 14 is considered the sign bit, so you can return negative numbers (and need not to worry about calculated callback 14:18:28 <peter1138> results yielding a negative result, as long as you stay in the range -16384..16383). During the callback, variable 18 has the value ssaaaatt, where 14:18:33 <Borg> yep 14:18:39 <Borg> so its straign forward 14:18:40 <peter1138> So yeah, it's meant to be a signed value. 14:18:47 <peter1138> 14:16 < Eddi|zuHause> i think the specs were never really meant to work for signed 14:18:50 <Borg> I wonder why my rating are so damn high then 14:18:52 <peter1138> Is clearly wrong :D 14:20:33 <Borg> okey, lets add shortcut.. 14:20:38 <Borg> to see if bug is in my calc 14:21:42 <Samu> aha, i knew there was another window 14:21:43 <Samu> WC_DROPDOWN_MENU 14:22:09 <Borg> hmm.. now rating drops 14:22:14 <Borg> but behavior is weird.. 14:22:38 <Eddi|zuHause> /* Simulate a 15 bit signed value */ 14:22:39 <Eddi|zuHause> if (HasBit(callback, 14)) rating -= 0x4000; 14:23:16 <Eddi|zuHause> so what is the problem again? 14:23:42 <Borg> Eddi|zuHause: no problem.. all works as it should 14:23:44 <Borg> I got confused 14:23:51 <Borg> too much binary operations 14:23:52 <Borg> :) 14:24:19 <Borg> % ruby -e 'puts "%08X" % (-50&0x3FFF-0x4000)' 14:24:20 <Borg> FFFFFFCE 14:26:08 <Eddi|zuHause> "Bit 14 is considered the sign bit" is a bit ambiguous 14:26:27 <Eddi|zuHause> it should mention 2-complement there 14:26:27 <Borg> hmm I just also realised that there will be problem w/ -1 value 14:26:35 <Eddi|zuHause> why? 14:27:22 <Borg> static const uint CALLBACK_FAILED = 0xFFFF; 14:27:31 <Borg> so return -1 as signed value.. means.. callback failed? 14:27:35 <Eddi|zuHause> no 14:27:40 <Eddi|zuHause> because -1 is 0x3FFF 14:27:56 <Eddi|zuHause> 0x3FFF != 0xFFFF 14:28:02 <Borg> wait.. how come? 14:28:07 <peter1138> Callback failed is checked at a different stage. 14:28:10 <Eddi|zuHause> that's why callbacks are only 15 bits, the 16th bit means "callback failed" 14:28:28 <Eddi|zuHause> there's a separate "if (callback != CALLBACK_FAILED) {" 14:28:33 <Borg> yes 14:28:48 <Borg> okey 14:29:03 <Borg> so there is somewhere result &= ~0x8000 in code? 14:29:11 <Eddi|zuHause> no 14:29:25 <Eddi|zuHause> the values between 0x3FFF and 0xFFFF can never be returned 14:29:57 <Borg> Eddi|zuHause: noo?!! stop bullshitng me :D 14:29:59 <Borg> this->result &= ~0x8000; 14:30:16 <Borg> src/newgrf_spritegroup.h: this->result &= ~0x8000; 14:30:53 <planetmaker> @base 16 10 3fff 14:30:53 <DorpsGek> planetmaker: 16383 14:31:25 <planetmaker> @base 16 10 7000 14:31:25 <DorpsGek> planetmaker: 28672 14:31:29 <Borg> yeah.. so return -1 is no problem 14:32:12 <Borg> okey.. back to my GRF.. all seems good in OpenTTD code.. there must be a bug in my GRF then 14:32:18 <planetmaker> @base 2 16 010000000000000 14:32:18 <DorpsGek> planetmaker: 2000 14:32:27 <Eddi|zuHause> Borg: i don't think that code is relevant to your problem 14:32:34 <planetmaker> @base 2 16 0100000000000000 14:32:35 <DorpsGek> planetmaker: 4000 14:32:39 <Borg> Eddi|zuHause: thats.. completly different story :) 14:33:26 <Borg> okey 14:33:27 *** supermop_work has joined #openttd 14:33:31 <Borg> now I AM puzzled!!! 14:33:33 <Eddi|zuHause> Borg: dumb question: did you set the callback flag so the callback is called at all? 14:33:43 <Borg> I returned 80 FF in callback.. and now my rating is stuck at 60% 14:33:53 <Borg> yes it is.. because station rating is manipulated 14:34:00 <Borg> for now.. its too high 14:34:19 <Samu> ... that face when i can crash openttd in debug mode but not in release mode... 14:34:20 <planetmaker> 80FF > 3FFF, thus undefined or failed? 14:34:24 <Samu> :| 14:34:48 <Borg> planetmaker: it should not matter.. there should be no cmp in callbacks!! only bit operations 14:34:51 <Borg> like & 0x8000 14:34:59 <planetmaker> yeah. so fail 14:35:19 <Borg> okey.. lets turn 0... 0x8000 14:35:33 <planetmaker> @calc 0x80ff & 0x8000 14:35:34 <DorpsGek> planetmaker: Error: Something in there wasn't a valid number. 14:35:36 <planetmaker> hm 14:35:50 *** supermop_work_ has joined #openttd 14:35:55 <peter1138> Did I hear that someone was going to get OpenTTD on Steam? 14:36:17 <Eddi|zuHause> orudge or it didn't happen. 14:36:30 <Borg> ok.. confirmed.. something is broken in OpenTTD CB result handling 14:36:37 <Borg> hope its only for CB 145 14:36:48 <Borg> when I return 0 (0x8000) 14:36:55 <Borg> station rating drops flat... 14:37:20 <supermop_work_> yo 14:37:23 <Borg> when I return -128 (0x8080) 14:37:29 <Borg> station rating stuck at 60% 14:37:33 <Borg> lets rerun to confirm 14:37:41 <planetmaker> I guess you might have heard that 14:38:27 <Borg> confirmed 14:38:38 <Borg> now.. lets do RTFS again.. why this might happen 14:38:50 <Borg> let me paste GRF code as well 14:38:52 <Borg> what I aim doing 14:39:06 <Samu> chat is busy :| 14:39:43 <Eddi|zuHause> i don't think anyone gets what you're doing 14:39:56 <Eddi|zuHause> that includes yourself, most likely 14:40:04 <Borg> https://paste.openttdcoop.org/pf3npdlww 14:40:05 <planetmaker> Borg, -128 must be 0x4080, IIRC 14:40:18 <planetmaker> the first bit is the CB_FAILED flag 14:40:37 <planetmaker> (and that's why 0x3FFF is max 14:40:48 <planetmaker> ) 14:40:49 <Borg> planetmaker: how did you came w/ 0x4080 ? 14:41:11 <planetmaker> 15 bit... 15th is sign. Not 16th 14:41:30 *** supermop_work has quit IRC 14:41:34 <Borg> planetmaker: no.. u are wrong 14:41:40 <Borg> first... bits are from 0.. ok? 14:41:52 <planetmaker> then decrement my statement by one 14:41:54 <Borg> so.. 16bit value we have 0 15. but 15 bit.. means result (not jump to another VA2) 14:42:13 <Borg> so.. to return negative values... I need to use bits 0 14.. + 15bit set as result 14:42:20 <planetmaker> nope 14:42:26 <Borg> ok.. 14:42:31 *** nielsm has joined #openttd 14:42:31 <Borg> now please elaborate.. why not 14:43:04 <planetmaker> you have 15bit signed value. You do not touch the 16th bit (or 15 if you start counting with 0) 14:43:20 <planetmaker> and 0x8... touches the highest bit 14:43:24 <planetmaker> you must not do that 14:43:27 <Borg> but I need to set it!!!! 14:43:38 <Borg> to return CB result... 14:43:51 <Borg> not to do another chained VarAct2 14:43:52 <Borg> right? 14:44:04 <Eddi|zuHause> Borg: really, nobody should code in NFO 14:44:50 <Borg> Eddi|zuHause: first.. if NFO spec is fucked up how u can be sure that NML compiler actually works? 14:45:01 <Borg> 99% time in OpenTTD we operate on unsigned values 14:45:15 <Borg> this is first time in my GRF I need signed values 14:45:25 <Borg> and boom! got slapped by them 14:45:27 <Samu> https://paste.openttdcoop.org/po02ffkpg 14:45:38 <Borg> I use PCLs... CB results.. chaining a lot.. 14:45:53 <Borg> I always do result|0x8000 14:45:58 <Borg> to return any value 14:46:01 <Borg> it works like a charm 14:46:15 <Eddi|zuHause> so? 14:46:28 <Borg> so.. now I try to use signed stuff.. and it does not work 14:46:35 <Borg> either I do it wrong.. or there is a bug 14:46:38 <Eddi|zuHause> but you said "80 FF" earlier, which is... which value? 14:46:42 <Borg> hence../ we have discussion 14:46:47 <Borg> -128 14:46:51 <Samu> @calc 0x80ff 14:46:51 <DorpsGek> Samu: 33023 14:46:51 <Borg> in 15bit 14:47:02 <Borg> signed 14:47:13 <planetmaker> 0x8080 is not -128. It is 128. -128 is 0x4080 in 15 bit 14:47:27 <Borg> planetmaker: lets see 14:47:37 <Eddi|zuHause> it's 0xFF80 because of little endian 14:47:51 <Samu> 127 + 1 = -128 14:47:54 <planetmaker> oh, and that mess, yes 14:48:02 <Eddi|zuHause> highest bit is discarded because of callback result 14:48:19 <Eddi|zuHause> and then extended back, because of hacky sign treatment 14:48:40 <Samu> @calc 0x80 14:48:41 <DorpsGek> Samu: 128 14:48:57 <Samu> @calc 0x40 14:48:57 <DorpsGek> Samu: 64 14:49:18 <Borg> yes.. OpenTTD is little endian 14:49:38 <Borg> damn... damn damn 14:49:39 <Eddi|zuHause> Borg: so, have you tried printf to see what "rating" is immediately after the callback handling? 14:49:56 <Borg> Eddi|zuHause: if callback results is 00 80 14:50:00 <Borg> rating goes to 0 14:50:02 <Borg> expected 14:50:10 <Borg> because rating is clampled 0,255 14:50:17 <Borg> but if result is 80 FF 14:50:24 <Borg> rating is stuck at 60% 14:50:45 <Borg> w/ is wrong.. but I understand why 14:50:54 <Eddi|zuHause> in station_cmd.cpp:3326, add a printf? 14:50:55 <Borg> 80 is excaly 50% rating.. in 0,255 14:50:58 <Borg> sign got lost 14:51:06 <Borg> Eddi|zuHause: I cant compile OpenTTD myself :/ 14:51:38 <Eddi|zuHause> Borg: have test grf? 14:51:43 <Borg> im trying to do planetmaker calc to prove or not prove that -128 in 15% is 0x4080 14:52:07 <Borg> Eddi|zuHause: sure I can give you one 14:52:13 <Borg> hold on... 14:53:16 <Borg> Eddi|zuHause: ftp://ds-1.ovh.uu3.net/home/borg/tmp/X2025.grf 14:53:20 <planetmaker> Borg, for what it's worth: the station rating callback seems to work with nml for FIRS ;) 14:53:31 <Borg> I return 80 FF right now 14:53:34 <Borg> for all cargos 14:53:54 <Borg> planetmaker: really? ;) 14:54:06 <Borg> well.. I can have work around.. like clamp myself o 0 255 before returning 14:54:07 <planetmaker> at least it presumably does what andy wants it to do 14:54:46 <Eddi|zuHause> man, i haven't started openttd in so long, "b[pgup]" doesn't result in "bin/openttd &" anymore 14:56:00 <Samu> how do i explain in a bug report that a crash only happens in debug mode? 14:56:13 <peter1138> "this crash only happens in debug mode" 14:56:22 <planetmaker> ^^ 14:56:30 *** Flygon has quit IRC 14:56:31 <Borg> LOOOOL 14:56:32 <Samu> and that in release mode there's no crash 14:56:35 <Borg> Eddi|zuHause: dont bother.. problem solved!!!! 14:56:44 <planetmaker> "it doesn't happen in release mode" ;) 14:56:45 <Samu> but it still sets the value 14:56:50 <Borg> RTFS!! ftw! 14:57:14 <Borg> * Old style callback results (only valid for version < 8) have the highest byte 0xFF so signify it is a callback result. 14:57:17 <Borg> * New style ones only have the highest bit set (allows 15-bit results, instead of just 8) 14:57:20 <Borg> and I use old style GRF 14:57:27 <Borg> so I am limited to 8bit only! 14:57:34 <Borg> daaaaaaamn :D 14:57:38 <planetmaker> hahaha 14:57:40 *** supermop_work_ has quit IRC 14:57:46 <Samu> ok, gonna try fill in a report 14:57:53 <Samu> it's gonna be a weird one 14:57:55 <Eddi|zuHause> uhm, how old do you think old-style is? 14:57:56 <Borg> this one was hard to nail :D 14:58:27 <Borg> Eddi|zuHause: I use grf version 6 14:58:29 <planetmaker> we kinda should... hide the old style stuff 14:58:35 <Eddi|zuHause> why?!? 14:58:37 <planetmaker> !!! 6?!!! are you nuts? 14:58:44 <planetmaker> use 32 14:58:52 <Borg> dunno.. I found it esier 14:58:56 <Borg> no cargo translation tables. 14:58:58 <planetmaker> well... grf v8 and nfo v32 14:59:00 <Eddi|zuHause> nobody should ever need to use grf version 6 14:59:07 <planetmaker> omg 14:59:09 <Borg> and some other things were easier.. 14:59:24 <peter1138> easier ... less features ... less compatibility ... 14:59:24 <planetmaker> no support for anything <7. 14:59:57 <Eddi|zuHause> does grfv6 then even have callbacks >100? 15:00:08 <Borg> they work 15:00:09 <planetmaker> we should really start deprecating grf versions 15:00:09 <Borg> :) 15:00:30 <planetmaker> so we can get rid of old cruft. And make maintenance and extensions easier 15:00:30 <Borg> I use quite a lot >FF CBs here and there 15:00:36 <Eddi|zuHause> planetmaker: but... DBSet... (non-XL)... 15:00:45 <planetmaker> you know my stance 15:01:02 <planetmaker> old grf, old openttd ;) 15:01:12 <planetmaker> or better ... ttd 15:01:35 <Eddi|zuHause> also https://xkcd.com/1782/ 15:01:42 <Borg> planetmaker: btw.. newest GRF version is 8 15:01:55 <Borg> so 6 is not that old to me :D 15:02:14 <planetmaker> it is ... one to two *decades* old 15:02:19 <Eddi|zuHause> Borg: grfv6 was already old when i started, about 12 years ago 15:02:21 <planetmaker> more two than one 15:02:34 <Borg> damn... time fly fast.. ;) 15:02:36 <Borg> anyway. thx for help guys 15:02:44 <Borg> myster solved! I will clamp values myself 15:02:57 <peter1138> o_O 15:03:02 <planetmaker> Eddi|zuHause, exactly that xkcd :) 15:03:35 <Borg> haha I love that xkcd :D 15:04:03 <Eddi|zuHause> google doesn't have any results for "grfv6", except one that mentions "OpenTTD 0.3.3 Problem" 15:04:06 <planetmaker> indeed I've never had to use grf v6 and I'm in grf business for more than a decade... 15:04:49 <Eddi|zuHause> and that is from 2004? 15:05:43 <peter1138> I recommend not using grfv6, Borg. 15:06:01 <peter1138> You don't, for instance, HAVE to use cargo translation tables, just because they are there... 15:06:02 <planetmaker> git log | grep 'v7' 15:06:02 <planetmaker> (svn r13855) -Fix [FS#2157]: Cargo type lookup was incorrect for GRFv7 files without a translation table. 15:06:28 <planetmaker> @r13855 15:06:34 <planetmaker> @revision 13855 15:06:35 <Borg> planetmaker: hmmm 15:06:53 <Eddi|zuHause> @openttd log 13855 15:06:57 <Eddi|zuHause> does that even still work? 15:07:03 <Eddi|zuHause> i guess it's trying to access the old svn 15:07:13 <Eddi|zuHause> which isn't where it expects it to be 15:08:06 <planetmaker> Date: Mon Jul 28 06:16:34 2008 +0000 15:08:16 <Borg> peter1138: well, for now I will stick w GRFv6.. I bet many things will break when I will switch to GRFv8 15:08:24 <planetmaker> by a certain peter...n 15:08:48 <Eddi|zuHause> planetmaker: tried "grep -C3"? 15:08:55 <Borg> I see a lot of GRFv7 comments in newgrf specs 15:09:00 <planetmaker> tried git log --grep 15:09:11 <peter1138> Must be old if it was still me doing NewGRF development... 15:09:18 <planetmaker> a decade ;) 15:11:17 <Eddi|zuHause> these decades might start to get annoying 15:11:52 <planetmaker> how do you mean? 15:12:27 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick opened issue #7091: Dropdown menu can set value to a parameter of a different AI https://git.io/fhwhr 15:13:01 <Eddi|zuHause> Borg: anyway, negative values with 8bit callback results will never work, as the code that tries to sign-extend cannot know whether the result was 8 or 15 bits, and the place that would know, doesn't know it should be treated as signed 15:14:25 <Borg> Eddi|zuHause: yep I know :) I clamp stuff in GRF directly now 15:14:41 <Borg> pcl B2 avs FF 00 max aim \w0 min im \w255 00 15:14:42 <Borg> will do 15:14:57 <Eddi|zuHause> Borg: thus for 8-bit results, the range is 0..255, not -16k..16k 15:15:10 <Eddi|zuHause> and also not -128..127 15:15:19 <Borg> yeah.. now when mistery is solved.. its all easy again :D 15:15:52 <peter1138> You can't have a negative result, right? 15:16:08 <Borg> peter1138: yeah.. thats why I used signed min and max 15:16:10 <peter1138> So you can't use grfv6 to do what you want. 15:16:13 <Borg> will clamp it to 0..255 15:16:16 <Samu> Expression: can't dereference out of range vector iterator 15:16:20 <Samu> english plz 15:16:26 <Eddi|zuHause> "80 FF" is +128 if treated as 8bit 15:16:40 <Eddi|zuHause> and -128 if treated as 15bit 15:16:55 <Borg> Eddi|zuHause: exacly! thats why I had station rating stuck at 60% :) 50% rating + 10% from statue 15:17:17 <peter1138> I don't understand why you wouldn't just use the current version :/ 15:17:25 <Borg> peter1138: I can.. CB 145 can accept negative values betwen -16384 and 16383.. but it will clamp it 0..255 15:17:27 <peter1138> Are you using Windows 95 by any chance? 15:17:35 <Borg> if I provide clamped result.. its all right 15:17:40 <Borg> peter1138: close :) im on Win2003, why? 15:17:47 <peter1138> Oh for fuck sake. 15:18:03 <nielsm> NOT SUPPORTED 15:18:03 <Eddi|zuHause> i knew i shouldn't have unignored people 15:18:04 <peter1138> OpenTTD 0.6 I suppose. 15:18:08 <Borg> peter1138: because I will have to rewrite my GRF again.. I might do this.. but NOT today 15:18:16 <Borg> peter1138: no.. im using 1,8.0 15:18:30 <Borg> peter1138: okey.. I see you have grudge to me.. so lets clarify :) 15:18:49 <Borg> I am not enemy of progress :) but progress must bring me benefits.. not only costs of upgrade and relearning 15:18:51 <peter1138> CB 145 does not clamp from 0..255. 15:18:52 <nielsm> nobody wants to support 16 year old operating systems 15:19:04 <Borg> peter1138: really? let me RTFS again 15:19:15 <Eddi|zuHause> i'm pretty sure OpenTTD 1.9.0 will not run on win2k3 15:19:34 <peter1138> To be clear, it clamps *after* it has calculated the result. 15:19:53 <peter1138> Negative values in the callback reduce the rating. 15:20:02 <Eddi|zuHause> "clamping" is the wrong word 15:20:16 *** supermop_work has joined #openttd 15:20:16 <Borg> peter1138: yes.. its score 15:20:18 <peter1138> Eddi|zuHause, the function name is literally Clamp() 15:20:31 <Borg> valid range is 0..255 to feed station rating 15:20:35 <Eddi|zuHause> peter1138: yeah, but it doesn't even arrive at that point 15:20:46 <peter1138> No, valid range is -16384 ... 16383 15:21:07 <peter1138> (-16384 does not make much sense though) 15:21:38 <Borg> peter1138: okey, lets start from the begining 15:21:49 <Borg> uint16 callback = GetCargoCallback(CBID_CARGO_STATION_RATING_CALC, var10, var18, cs); 15:21:57 <Eddi|zuHause> peter1138: because he is using stupid version, valid range is 0..255 but the values are not CLAMPED, but masked to 8 bit 15:22:05 <Borg> if callback is not failed.. we get result 15:22:09 <Borg> skip is true 15:22:21 <Borg> so calculation is skiped.. we then reach next blok 15:22:27 <Eddi|zuHause> Borg: that's aleady not "the beginning" 15:22:29 <peter1138> Eddi|zuHause, i'm talking about grfv7 case. 15:22:32 <Borg> Company statue... 15:22:40 <Eddi|zuHause> peter1138: yeah, but... stupid 15:22:48 <peter1138> The callback expects -16384..16383. 15:22:58 <Borg> peter1138: yes 15:23:03 <Borg> but I can provide 0..255 15:23:11 <Borg> and it will work too.. not fully tho 15:23:23 <Eddi|zuHause> ah fuck it, nothing good can ever come out of this discussion... back to /ignore 15:23:29 <Borg> ;) 15:23:40 <Borg> yeah.. calm down guys.. I know whats going on now 15:23:46 <Borg> and I know limitations 15:24:04 <Borg> I wonder why I missed info that CB results are only 8 bit in GRFv6 15:24:24 <peter1138> You can't provide a negative value, which is what you had originally intended. 15:24:31 <milek7> win2k3 doesn't run any modern browser build, right? 15:24:32 <Borg> lets read newgrf specs.. if migrating to GRFv8 will not be hard 15:24:50 <peter1138> That was my point. 15:24:57 <Borg> milek7: yep.. im stuck w/ last FF ESR 15:25:11 <Borg> milek7: basicaly.. its ending.. true.. 15:25:23 <Borg> but I cant find anything good enough that can replace it 15:26:30 <Eddi|zuHause> if i had op rights, i would permaban for "don't waste our time" 15:27:15 <Borg> thats rude dude 15:27:23 <Borg> busy? dont get into conversation 15:27:31 <Borg> use /ignore.. thatever.. 15:27:35 <Borg> dont decide for everyone 15:33:03 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on issue #7090: Query box sets value to hidden parameters https://git.io/fhrvB 15:35:00 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on issue #7091: Dropdown menu can set value to a parameter of a different AI https://git.io/fhrvw 15:35:46 <Samu> peter1138, fix my bugs. hehehe 15:35:50 <Samu> j/k 15:36:20 *** Thedarkb-T60 has joined #openttd 15:36:26 <Samu> I have an idea how to fix them, but it's a lazy approach 15:36:31 <Samu> "just close them" 15:39:56 <Samu> close oth WC_QUERY_STRING and WC_DROPDOWN_MENU 15:40:06 <Samu> both* 15:41:14 <Samu> problem is, i don't know how to properly detect whether I'm closing the right WC_QUERY_STRING / WC_DROPDOWN_MENU 15:42:17 <Samu> have to know if they're opened via WC_AI_SETTINGS, and not from some other window 15:42:33 <Samu> WC_AI_SETTINGS is the parent window 15:43:11 *** Wormnest has joined #openttd 15:44:21 <Borg> peter1138: hmm I changed my grf from v6 to v8 15:44:26 <Borg> and it didnt exploded ;) interesting 15:46:09 *** supermop_work_ has joined #openttd 15:52:15 *** supermop_work has quit IRC 15:59:27 <Pikka> boom 15:59:33 <Samu> HideDropDownMenu(WC_AI_SETTINGS) 15:59:41 <Samu> wow, don't tell me this was it 15:59:47 <Samu> sounds too easy to be true 16:01:02 <Samu> nop 16:01:04 <Samu> HideDropDownMenu(this); 16:02:20 <Samu> yesh! this was it! 16:02:36 <Samu> literally the 'this' 16:05:11 <Samu> what about WC_QUERY_STRING 16:05:28 <Samu> how do i close this one? 16:08:27 *** synchris has joined #openttd 16:09:50 <Samu> gonna try DeleteChildWindows(WC_QUERY_STRING); 16:11:17 <Samu> yeah, that was it 16:11:18 *** WWacko1976-work has quit IRC 16:15:01 *** WWacko1976-work has joined #openttd 16:22:19 *** supermop_work has joined #openttd 16:22:25 *** supermop_work_ has quit IRC 16:23:39 *** supermop_work_ has joined #openttd 16:30:20 *** supermop_work has quit IRC 16:30:58 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on issue #7042: Use intrinsics for bit twiddling? https://git.io/fhrIe 16:32:19 *** Gabda has quit IRC 16:33:52 *** Gja has joined #openttd 16:41:49 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick opened pull request #7092: Fix #7091: Close dropdown menu windows after rebuilding AI/GS settings https://git.io/fhrIN 16:46:26 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick opened pull request #7093: Fix #7090: Close Query String window after rebuilding AI/GS settings https://git.io/fhrLG 16:56:03 *** Laedek_ has quit IRC 16:57:20 *** Laedek has joined #openttd 17:01:11 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick opened pull request #7094: Fix #7088: Retrieve an appropriate name for a non-existant AI/GS when… https://git.io/fhrqY 17:21:50 *** HerzogDeXtEr has joined #openttd 17:25:13 <DorpsGek_II> [OpenTTD/OpenTTD] glx22 commented on issue #7007: Joining server via shortcut causes freeze https://git.io/fhrYd 17:25:33 *** glx has joined #openttd 17:25:33 *** ChanServ sets mode: +v glx 17:31:30 <DorpsGek_II> [OpenTTD/OpenTTD] planetmaker approved pull request #7085: Fix: Remove duplicate French and Slovak town names https://git.io/fhrO8 17:33:42 <DorpsGek_II> [OpenTTD/OpenTTD] nikolas commented on pull request #7085: Fix: Remove duplicate French and Slovak town names https://git.io/fhrOd 17:36:16 *** andythenorth has joined #openttd 17:36:18 <DorpsGek_II> [OpenTTD/OpenTTD] nikolas updated pull request #7086: Change #6173: Update SDL driver to use SDL 2.0 https://git.io/fhamZ 17:38:29 <andythenorth> well 17:38:54 <DorpsGek_II> [OpenTTD/OpenTTD] JGRennison updated pull request #7083: Codechange: [Linkgraph GUI] Replace line visibility detection algorithm https://git.io/fh2PV 17:42:39 *** Progman has joined #openttd 17:42:45 *** Gustavo6046 has joined #openttd 17:45:13 <Samu> ShowAIDebugWindowIfAIError hmm this function is being misused 17:46:01 <Samu> when an AI dies, it doesn't call this function 17:46:17 <Samu> it calls ShowAIDebugWindow directly 17:48:05 <DorpsGek_II> [OpenTTD/OpenTTD] PikkaBird opened issue #7095: NoAI - add function to set company colour https://git.io/fhrsm 17:49:12 <Pikka> oops 17:56:24 *** Pikka has quit IRC 18:04:07 <supermop_work_> i want an AI that rage-quits if it can't get it's desired color 18:05:43 <LordAro> :D 18:06:30 <Samu> is it intended that the debug window can be spawned in main menu? 18:06:37 <acklen> I wrote an AI which would create mocking signs around my son's headquarters 18:06:46 <acklen> it quickly went haywire 18:07:37 <Samu> there is some weird saveload stuff happening during openttd launch 18:07:41 *** smoke_fumus has joined #openttd 18:07:51 <Samu> and it can call the AI Debug window if there's a crashed AI 18:08:12 <Samu> do you really want the ai debug there? 18:10:30 <glx> it's just loading the intro game 18:12:22 <Samu> the intro game doesn't have AIs, usually 18:12:47 <Samu> but if it does, it's current behaviour would be to display the ai debug window if it crashed 18:13:24 <glx> it should not have, same for newgrf 18:14:30 <Samu> void ShowAIDebugWindowIfAIError(CompanyID show_company) 18:14:30 <Samu> { 18:14:30 <Samu> if (_game_mode != GM_NORMAL) return; 18:15:08 <Samu> will solve 18:17:27 <m1cr0man> anyone got a rec for a road vehicle pack that works with FIRS 3 to complement a grf set including av8 + dutch trains? I'm just looking for a few real vehicle based variations. I've found the german vehicles set but it seems hella old 18:18:21 <nielsm> trying out using intrinsics for FindFirstBit and FindLastBit, without: https://0x0.st/sCcT.jpg with: https://0x0.st/sCcP.jpg 18:18:50 <nielsm> I'd say not worth the effort 18:19:11 *** smoke_fumus has quit IRC 18:19:56 <glx> indeed almost no gain 18:20:12 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on issue #7042: Use intrinsics for bit twiddling? https://git.io/fhrn5 18:22:44 *** Wolf01 has joined #openttd 18:22:52 <Wolf01> o/ 18:23:42 *** andythenorth has quit IRC 18:28:50 *** Gja has quit IRC 18:29:34 <Borg> peeeeeeeeeeerfect!!! ;D 18:29:37 <Borg> took a while 18:29:37 <Borg> ;) 18:37:15 *** frosch123 has joined #openttd 18:47:41 <Samu> hmm, the reload ai button should be disabled inside scenario editor 18:47:46 <Samu> time to fix 18:48:48 <Samu> or maybe... maybe i could do something else 18:53:48 <Samu> yeah, reload button still enabled inside scenario editor 18:54:02 <Samu> making the start stop button also enabled 18:54:14 <Samu> for consistency 18:55:35 <Samu> i have doubts about starting AIs in the scenario editor 18:55:45 <Samu> it doesn't quite make sense 18:55:51 <Samu> but it's possible 18:56:33 <Samu> it's not consistent with the console 18:56:45 <Samu> startai command doesn't work there 18:56:49 <Samu> but the reload button does 18:57:39 <Samu> guess i better be consistent 18:57:48 <Samu> gonna disable reload ai button 19:01:57 *** andythenorth has joined #openttd 19:03:44 <andythenorth> m1cr0man: Hog 19:03:50 * andythenorth declares authorship 19:04:14 <andythenorth> http://bundles.openttdcoop.org/road-hog/releases/LATEST/docs/html/get_started.html 19:04:48 <nielsm> close that bit twiddling issue, or let someone else make some tests too? 19:08:16 *** Gja has joined #openttd 19:08:56 <m1cr0man> andythenorth, This looks amazing :D thanks man! Is this listed on the newgrf wiki page? Because if so I overlooked it. That was my primary source before I came here. 19:12:01 <andythenorth> seems it's not here https://wiki.openttd.org/NewGRF_List 19:12:23 <andythenorth> feel free to add :D 19:12:38 <andythenorth> @seen TrueBrain 19:12:38 <DorpsGek> andythenorth: TrueBrain was last seen in #openttd 22 hours, 11 minutes, and 38 seconds ago: <TrueBrain> tomorrow it will be available around 20:15 CE(S)T :D 19:13:33 <milek7> summer time? 19:14:28 <andythenorth> oof 96 issues 19:14:34 <andythenorth> that's a regression 19:14:40 <andythenorth> and 38 PRs also a regression :( 19:15:29 <andythenorth> @13/38 19:15:34 <andythenorth> @calc 13 / 38 19:15:34 <DorpsGek> andythenorth: 0.342105263158 19:17:10 <andythenorth> Samu: I'm kind of unclear about this https://github.com/OpenTTD/OpenTTD/pull/6926 19:17:24 <andythenorth> on the one hand, you have PRs about trying to stop docks blocking ships 19:17:37 <andythenorth> and on the other you have a PR that increases the chances of dock construction blocking ships 19:17:51 <andythenorth> there doesn't seem to be a guiding concept here :) 19:18:12 <andythenorth> I don't want to be discouraging, you do a lot of work 19:18:15 <TrueBrain> @seen andythenorth 19:18:15 <DorpsGek> TrueBrain: andythenorth was last seen in #openttd 2 seconds ago: <andythenorth> I don't want to be discouraging, you do a lot of work 19:18:23 <andythenorth> that was me TB :P 19:18:25 <andythenorth> thanks 19:18:40 <TrueBrain> yw! 19:18:43 <TrueBrain> (what are we talking about?) 19:18:52 <andythenorth> I am talking about samu has 34% of open PRs 19:18:59 <andythenorth> but isn't it also binary o'clock? 19:19:15 <TrueBrain> nearly done! 19:19:23 <andythenorth> beer for me then 19:19:30 <TrueBrain> 12 minutes to build it 19:19:41 <TrueBrain> 4 minutes to rebuild the website 19:19:51 <andythenorth> I really think it's bad for the project to have a lot of open PRs going nowhere 19:19:53 <TrueBrain> and a lot more minutes waiting for resources 19:20:00 *** supermop_work_ has quit IRC 19:20:02 <andythenorth> it discourages drive-by contributors 19:20:08 <TrueBrain> in general things that are not going anywhere are not useful :D 19:20:17 *** Borg has quit IRC 19:20:32 <andythenorth> https://github.com/OpenTTD/OpenTTD/pulls/samuxarick 19:20:34 <TrueBrain> owh bah, someone queued other things .. 19:20:40 *** smoke_fumus has joined #openttd 19:20:40 <TrueBrain> that explains why it is taking so darn long :P 19:21:21 *** supermop_work has joined #openttd 19:22:37 *** supermop_work_ has joined #openttd 19:25:35 <supermop_work_> HI 19:26:58 <andythenorth> supermop_work: have you figured out industrial trains for Horse yet? o_O 19:27:24 <TrueBrain> finally the website is being published .. damn .. took a while 19:27:28 <supermop_work_> DO THEY SHUNT? 19:27:59 <andythenorth> supermop_work: do you even lift? 19:28:14 <andythenorth> wait, wat, there's a new website? :o 19:28:26 <andythenorth> who did that? 19:29:26 *** supermop_work has quit IRC 19:29:42 <TrueBrain> andythenorth: its done: https://www.staging.openttd.org/ 19:29:50 <TrueBrain> so within 30 minutes, good enough 19:30:06 <andythenorth> :) 19:30:15 <andythenorth> look how many contributors recently :D \o/ https://github.com/OpenTTD/OpenTTD/graphs/contributors?from=2018-02-04&to=2019-01-24&type=c 19:30:57 <andythenorth> compared to https://github.com/OpenTTD/OpenTTD/graphs/contributors?from=2017-02-12&to=2018-01-19&type=c 19:31:14 <andythenorth> 160 forks 19:32:07 <andythenorth> OpenTTD is dying 19:32:58 <nielsm> killed by fork-wielding gits 19:33:34 <andythenorth> :P 19:35:00 <andythenorth> nielsm: how you feeling about this one now? o_O https://github.com/OpenTTD/OpenTTD/issues/6857 19:35:05 * andythenorth wants to kill issues 19:35:51 <supermop_work_> WHOA THERE IS A NEW SCREENSHOT 19:36:12 <andythenorth> this was waiting on author, but author replied :) https://github.com/OpenTTD/OpenTTD/issues/6842 19:37:10 <andythenorth> supermop_work_: is it of steel mill trains? 19:37:17 * andythenorth needs to teddybear set design :P 19:38:50 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5451: Do not overlap vehicle view window with child windows (orders, timetable, details) https://git.io/fhrR7 19:38:51 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #5451: Do not overlap vehicle view window with child windows (orders, timetable, details) https://git.io/fhrRd 19:39:14 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5679: Allow characters as hotkey instead of assuming everyone uses a Latin keyboard https://git.io/fhrRN 19:39:15 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #5679: Allow characters as hotkey instead of assuming everyone uses a Latin keyboard https://git.io/fhrRA 19:40:56 *** Gja has quit IRC 19:41:08 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6413: Signals: PBS Signal vs 'Skip Signal' Train on Platform https://git.io/fhr0k 19:41:09 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6413: Signals: PBS Signal vs 'Skip Signal' Train on Platform https://git.io/fhr0I 19:42:02 <andythenorth> keeps it fresh eh? 19:42:07 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on issue #6857: Linux SDL video driver runs slightly too fast https://git.io/fhr0q 19:42:20 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6398: Path remains reserved when extending train station https://git.io/fhr0Y 19:42:21 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6398: Path remains reserved when extending train station https://git.io/fhr0O 19:43:05 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6418: bitmask_vehicle_info is not specified for all the engines https://git.io/fhr0c 19:43:06 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6418: bitmask_vehicle_info is not specified for all the engines https://git.io/fhr0C 19:46:45 <LordAro> nielsm: i tried the sdl thing yesterday, it seemed to be running pretty consistently at just over 34ms 19:51:01 <nielsm> 34 fps? 19:52:46 <TrueBrain> https://hub.docker.com/r/openttd/website/tags <- how many tags can I rack up before they start to complain, you think? 19:52:48 <nielsm> and win32 is consistently stuck just below 33 fps for me 19:54:22 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #7084: Change: AI/GS Config GUI overhaul https://git.io/fh2dV 19:55:22 <andythenorth> TrueBrain: at least 99 I reckon 19:56:02 <andythenorth> how many issues can I close before we start to complain? 19:56:19 <LordAro> nielsm: er, yes, fps 19:56:43 <LordAro> though i should point out this is sdl on windows/mingw 19:57:13 <LordAro> windows itself seems to spend most of its time at 32.9xfps, with occasional spikes to 33.0x 19:57:52 <andythenorth> does the mac port use SDL? 19:57:58 <nielsm> maybe the framerate algorithm should be unified between video drivers 19:58:10 <nielsm> no it uses an apple api 19:58:10 <LordAro> andythenorth: if only there was a nightly someone could download to check 19:58:30 <andythenorth> mac version is hovering just above 34 fps 19:58:42 <andythenorth> occasionally drops to 33.x 19:58:49 <nielsm> similar to sdl then 19:59:31 <andythenorth> if I turn on full animation, and do nothing in game, it drops to around 32.x 20:01:14 <andythenorth> moving the cursor around slams it down further 20:01:37 <nielsm> ouch 20:02:09 <LordAro> interesting, it's presumably not on the limit of being able to keep up? 20:03:51 <TrueBrain> andythenorth: stalebot didn't find anything to close in PullRequests :P 20:04:20 <TrueBrain> and only 15 issues 20:04:24 <andythenorth> make it more aggressive :P 20:04:29 *** Vasatko has joined #openttd 20:04:39 <andythenorth> LordAro: dunno, the mac performance is pretty dire 20:04:50 <andythenorth> this is with a new map, no vehicles etc 20:05:00 <TrueBrain> andythenorth: yeah ... 2 days for PRs? :P 20:05:07 <andythenorth> every time I upgrade my mac, graphics performance gets worse 20:06:00 <LordAro> :( 20:06:27 <andythenorth> I suspect the recent FFWD improvements remove the worst symptoms though 20:06:44 <andythenorth> it's usually only noticeably slow during FFWD 20:06:55 <andythenorth> or in cases like having a few vehicle windows 20:07:08 <andythenorth> or a lot of the cost / income animations on screen 20:08:13 *** Gja has joined #openttd 20:08:39 <andythenorth> how many reviews can a PR have before it becomes 'no hope'? 20:09:08 <LordAro> depends on what the review is :p 20:10:58 <TrueBrain> the 26 "stale" issues, can be automatically closed if they expire? 20:10:59 *** CZTR has quit IRC 20:11:06 <TrueBrain> (roughly 30 days left) 20:12:14 <andythenorth> some really look legit 20:12:17 <andythenorth> but still 20:12:34 <andythenorth> nobody is doing anything about them, and empiricism suggests they won't :P 20:12:42 <andythenorth> so let them go free :D 20:12:55 <andythenorth> https://github.com/OpenTTD/OpenTTD/issues?q=is%3Aopen+is%3Aissue+label%3Astale 20:13:31 <andythenorth> TB this one still bothers me :) https://github.com/OpenTTD/OpenTTD/issues/6193 20:15:22 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6583: Scrolling down/right out of map on a 255 high flat map bounces viewport back to edge of map https://git.io/fhrzq 20:15:36 <andythenorth> eh this is approved https://github.com/OpenTTD/OpenTTD/pull/7061 20:15:41 <andythenorth> and will close 6583 20:15:45 <andythenorth> can someone merge? 20:17:20 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh merged pull request #7061: Fix #6583: Rework Tileheight handling (patch by adf88) https://git.io/fhnDK 20:17:31 <LordAro> yay 20:17:38 <nielsm> hope it breaks nothing :D 20:17:45 <TrueBrain> andythenorth: fixed 20:17:58 <TrueBrain> (6193) 20:18:06 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh closed issue #6583: Scrolling down/right out of map on a 255 high flat map bounces viewport back to edge of map https://git.io/fhrzi 20:18:06 <LordAro> irritatingly, "Fix #nnnn" in the PR title doesn't close issues 20:18:12 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain opened pull request #7096: Add: [GitHub] enable probot/stale, to flush out stale issues/pull req… https://git.io/fhrzX 20:18:17 <andythenorth> this is just ICU again? https://github.com/OpenTTD/OpenTTD/issues/6573 20:18:38 <TrueBrain> please check my PR request on both if you agree with the time, text, and if I wrote correct english :D 20:18:50 <TrueBrain> well, I just opened 20 stale.yml, and cherry-picked what I liked 20:19:14 <nielsm> andythenorth, no, it uses sprite fonts 20:19:39 <glx> but it's an old RC version 20:19:41 <andythenorth> there's limited value to preserving these crashes 20:19:50 <andythenorth> OpenTTD must crash hundreds of times a day 20:19:53 <andythenorth> in the player base 20:20:18 <andythenorth> this is like trying to suck the ocean up through a straw 20:20:56 <glx> there are more important issues, like the actual deadlock with "-n something" 20:21:24 <glx> and I don't see how to prevent it 20:21:37 <andythenorth> this one particularly strikes me as 'shit happens' https://github.com/OpenTTD/OpenTTD/issues/6572 20:22:52 <andythenorth> TrueBrain: my wording too cheese? 20:22:53 <andythenorth> "Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. I'm closing it as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun. Feel free to discuss in irc or request re-opening if you disagree. Thanks for contributing!" 20:23:02 <glx> hmm segfault, ukrainian, let's blame ICU ;) 20:23:11 <glx> without proofs of course 20:23:29 <TrueBrain> andythenorth: like I said, I picked what other projects used :) They all use the same first and last two lines 20:23:44 <TrueBrain> I liked the second line from a few other projects 20:23:51 <TrueBrain> thought it might be good to have it more like other projects 20:23:57 <TrueBrain> but I am up for changing it completely 20:24:16 <glx> and useless stack trace, andythenorth just close 6572, nothing usable there 20:24:30 <TrueBrain> glx: you close it :P 20:24:49 <LordAro> TrueBrain: what's "closeComment: false" mean? 20:25:00 <TrueBrain> LordAro: that on close, it doesn't show any comments 20:25:12 <TrueBrain> you can also make it give a comment when it closes it after 7 days 20:25:16 <TrueBrain> just more fuzz, basically 20:25:23 <LordAro> ah right 20:25:39 <TrueBrain> as the stale bot was the last in the thread anyway, why say something again, most projects seems to say :) 20:26:25 <TrueBrain> as you can see, "security", "good first issue" and "regression" are never closed. They should always be fixed :P 20:26:35 <TrueBrain> well, the second because we need some tickets that are easy to get into OpenTTD with :) 20:26:38 <TrueBrain> no matter how old they are 20:27:13 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on issue #6573: Crash: Fatal Application Failure https://git.io/fhrgK 20:28:48 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6573: Crash: Fatal Application Failure https://git.io/fhrgb 20:28:49 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6573: Crash: Fatal Application Failure https://git.io/fhrgN 20:29:37 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6572: Crash: Fatal Application Failure https://git.io/fhr2k 20:29:38 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6572: Crash: Fatal Application Failure https://git.io/fhr2L 20:30:08 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6621: Saving game then loading one of the same name via console, all in the same directory, fails. https://git.io/fhr2Y 20:30:09 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6621: Saving game then loading one of the same name via console, all in the same directory, fails. https://git.io/fhr2O 20:32:04 <TrueBrain> hmm, when I merge my PR, it will close all current 'stale' marked tickets, it seems :) 20:32:28 <TrueBrain> all but 2 :) 20:33:00 <LordAro> TrueBrain: perhaps exemptMilestones/exemptAssignees might be worthwhile? 20:33:11 <TrueBrain> LordAro: I considered it. But no other project uses it 20:33:24 <TrueBrain> so I was unsure about that 20:34:20 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on issue #6916: Re-implement building binaries via compile farm https://git.io/fhr26 20:34:54 <andythenorth> TrueBrain: I can take 'stale' off some issues 20:35:11 <andythenorth> I think some are legit, but I added stale to indicate they're just rotting 20:35:22 <LordAro> i'm still concerned that any sort of stalebot is just going to end up closing issues before anyone can get to them 20:35:23 <TrueBrain> andythenorth: possibly we should remove them from all 20:35:28 <TrueBrain> and let the normal stale do its thing 20:35:39 <LordAro> then it's just going to keep bouncing between getting reopened (if it gets noticed) and closed by the bot 20:35:42 <TrueBrain> LordAro: 60 days to get to them .. and 1 comment to keep it another 60 :) 20:35:54 <TrueBrain> but ... in 120 days we can look back on that, see if you are right :) 20:35:56 <andythenorth> tree, falling, forest 20:36:01 <TrueBrain> we should not be afraid to try things out 20:36:07 <LordAro> that's fair 20:36:08 <andythenorth> if nobody cares about the issue, does it matter if it was closed? o_O 20:36:09 <TrueBrain> just because we might have an unpleasent outcome :) 20:36:35 <TrueBrain> https://trello.com/b/6j90aRB1/openttd <- I could close a lot of things :D 20:36:52 <andythenorth> also we seem to have an inexhaustible supply of PRs from just one contributor 20:36:53 <LordAro> i'd probably be happy with exemptMilestone & exemptAssignee, if only because i'm the only one that uses them :p 20:36:59 <frosch123> what about the "pinned" label? 20:36:59 <andythenorth> so we won't be short of admin work to do :P 20:37:04 <frosch123> does it also exist for pr? 20:37:15 <TrueBrain> LordAro: all the current ones will be exempt anyway :) 20:37:19 <TrueBrain> frosch123: yes 20:37:27 <TrueBrain> frosch123: labels are over issues and pull requests :) 20:37:53 <frosch123> stale.yml does not list exceptions for prs though 20:38:04 <andythenorth> ok I knock a bunch of labels off 20:38:16 <TrueBrain> frosch123: good point! 20:38:47 <andythenorth> really? o_O https://github.com/OpenTTD/OpenTTD/issues/6222 20:39:03 <andythenorth> peter1138 should fix map gen :P https://github.com/OpenTTD/OpenTTD/issues/6337 20:39:12 * andythenorth removing stale 20:39:13 <TrueBrain> frosch123: only 'pinned' enough you think? 20:39:27 <TrueBrain> (for PRs) 20:39:34 <frosch123> you can always set "pinned" 20:39:48 <TrueBrain> good first issue makes no sense 20:39:49 <frosch123> so, technically a single label is enough 20:39:54 <TrueBrain> security/regression PRs are unlikely 20:40:00 <TrueBrain> true :) 20:40:25 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7096: Add: [GitHub] enable probot/stale, to flush out stale issues/pull requests https://git.io/fhrzX 20:40:27 <TrueBrain> there we go, should fix both the issue for frosch123 and LordAro 20:40:40 <andythenorth> oof these issues are dull :) 20:40:42 <andythenorth> nvm 20:42:30 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6592: Missing symbols while linking with MinGW and LTO https://git.io/fhraW 20:42:31 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6592: Missing symbols while linking with MinGW and LTO https://git.io/fhral 20:44:10 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #6337: Mapgen: no tropical trees and no snow with default world generation settings https://git.io/fhraV 20:44:17 *** Gja has quit IRC 20:44:28 <andythenorth> ok removed all stale 20:45:19 <LordAro> dang it, i meant to comment on 6592 20:45:27 <LordAro> this is what i'm worried about :p 20:45:49 <TrueBrain> LordAro: that you are getting old, or what? 20:45:56 <LordAro> yes. 20:46:06 <andythenorth> just comment and reopen, no kittens died, and now you got a prompt :) 20:46:12 <andythenorth> Eddi|zuHause: feel like updating? o_O https://github.com/OpenTTD/OpenTTD/pull/7049 20:47:02 <andythenorth> oof approved, not merged :P https://github.com/OpenTTD/OpenTTD/pull/7065 20:47:14 <andythenorth> merge bot? o_O 20:47:26 <TrueBrain> LordAro: we no longer support MingW, do we? 20:47:52 <LordAro> TrueBrain: me & michi have put effort into making it work :p 20:47:53 <frosch123> isn't glx using mingw64 all the time? 20:47:59 <LordAro> or maybe glx 20:48:04 *** HerzogDeXtEr has quit IRC 20:48:08 <TrueBrain> didn't you say it doesn't support x11? 20:48:11 <LordAro> but, MSYS is probably worth deprecating, MSYS2 works fine 20:48:23 <glx> msy2/mingw64 is fixed 20:48:30 <TrueBrain> ah; so we should add that to the CF too 20:48:32 <frosch123> TrueBrain: we do not support mingw32, and thus do not support win9x 20:48:33 <TrueBrain> as CI 20:48:42 <glx> we dropped MSYS/mingw 20:48:54 <TrueBrain> is mingw64 installed on the Windows Agents .. 20:49:16 <glx> it is if the github wiki is right 20:49:21 <TrueBrain> https://github.com/Microsoft/azure-pipelines-image-generation/blob/master/images/win/scripts/Installers/Install-MinGW.ps1 20:49:22 <TrueBrain> mingw32 20:49:53 <orudge> Hmm, is there a reason the OS X build now seems to require 10.12? I've only got 10.11 (max my hardware can run), and the underlying openttd binary seems to run fine, but the package is marked as 10.12+ only 20:50:14 <glx> ha no it's the outdated one indeed 20:50:18 <TrueBrain> orudge: we said a while back that we are only "supporting" N-2 20:50:27 <TrueBrain> possibly it runs on older ones 20:50:32 <TrueBrain> but we are not building for it, etc 20:50:35 <andythenorth> matches Apple support policy afaict 20:50:40 <TrueBrain> (we only "support" what Apple does) 20:50:46 <orudge> Ah 20:50:52 <TrueBrain> but yeah, it might even run on 10.8 :P 20:50:59 <orudge> Anyone want to donate a new Mac then? :D 20:50:59 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #6592: Missing symbols while linking with MinGW and LTO https://git.io/fhrVL 20:51:00 <TrueBrain> we just know it runs on 10.12 :D 20:51:00 <planetmaker> hihi 20:51:02 <glx> anyway as I said if someone really wants win9x, a PR will work :) 20:51:15 <TrueBrain> glx: go for it :) 20:51:16 <planetmaker> where do I find the new nightlies / builds anyway? 20:51:23 * LordAro wonders when the last time someone tried compiling with --enable-lto on Linux 20:51:24 <TrueBrain> don't you read?! :'( :P 20:51:28 <TrueBrain> https://www.staging.openttd.org 20:51:32 <glx> not from me, from the someone :) 20:51:45 <TrueBrain> LordAro: I would like to have a azure-pipelines.yml which tests all possible combinations 20:51:58 <TrueBrain> glx: fair :P 20:52:12 <andythenorth> orudge: I considered it briefly :P 20:52:13 <TrueBrain> but I would like a mingw64 in CompileFarm on the CI so we can validate we don't break mingw64 :) 20:52:35 <TrueBrain> LordAro: we can run that pipeline every week or so :P 20:52:47 <TrueBrain> anyway .. stalebot PR .. anyone dares to approve? 20:53:51 <andythenorth> you know I will if nobody else does :P 20:54:00 <andythenorth> but I'd have to actually read the rules properly 20:54:04 <LordAro> TrueBrain: remember to turn off github notifications before you set it to work :p 20:54:13 <planetmaker> ty. And no, I didn't read back hours of chatty IRC. 20:54:17 <LordAro> or it'll be a bit noisy in here 20:54:33 <TrueBrain> LordAro: andythenorth makes more noise :P 20:54:34 <andythenorth> I've removed the stale label from all open issues 20:54:40 <glx> TrueBrain: vcpkg uses msys2/mingw64 20:54:42 <planetmaker> hm. Why turning off github notifications? 20:55:10 <TrueBrain> glx: hmm .. can we also use it? 20:55:21 <TrueBrain> as that might be a quicker way to add it to azure-pipelines 20:55:28 *** gelignite has joined #openttd 20:55:42 <glx> but I don't know if it provides pacman 20:55:46 <planetmaker> no nightly linux builds yet? 20:55:50 <glx> or pacboy 20:56:01 <TrueBrain> planetmaker: 'yet', as in: till someone finds a way to build those 20:56:30 <planetmaker> he 20:56:32 <TrueBrain> planetmaker: releases will have debian and ubuntu deb-files, but we have no 'generic' linux 20:56:40 <TrueBrain> someone has to invent them :D 20:56:47 <DorpsGek_II> [OpenTTD/OpenTTD] frosch123 approved pull request #7096: Add: [GitHub] enable probot/stale, to flush out stale issues/pull requests https://git.io/fhrVF 20:57:09 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain merged pull request #7096: Add: [GitHub] enable probot/stale, to flush out stale issues/pull requests https://git.io/fhrzX 20:57:10 <TrueBrain> tnx bossman 20:57:22 <peter1138> Evening. 20:57:40 <TrueBrain> planetmaker: the version I had was a bit too modern for most systems, so that was useless :P 20:57:48 <TrueBrain> someone keeps telling me you have to keep the libc in mind or something like that 20:57:57 <TrueBrain> and than there were issues with what is compiled static 20:57:59 <TrueBrain> and ICU was being stupid 20:58:05 <TrueBrain> and more of that shit 20:58:17 <TrueBrain> someone who understands what they are doing should make a Docker that produces a generic linux binary :) 20:58:24 <planetmaker> meh. sounds nasty. But it used to work... 20:58:30 <TrueBrain> but .. honestly .. the amount of downloads we had on it, were .. low :) 20:58:40 <TrueBrain> "used to work" was more: nobody ever used them, so nobody noticed :P 20:59:13 <LordAro> linux users can use git & make :p 20:59:27 <TrueBrain> let me check the stats on it ... 20:59:43 <glx> hmm or it's just git shell 20:59:51 <TrueBrain> win32: 3268067 20:59:52 <TrueBrain> win64: 3094301 20:59:59 <TrueBrain> macos: 438740 21:00:06 <planetmaker> 15% 21:00:06 <TrueBrain> source: 292469 21:00:12 <planetmaker> hm 21:00:13 <TrueBrain> linux-generic-amd64: 101510 21:00:19 <peter1138> Hrmm, my watch says it's time to sleep :/ 21:00:22 <planetmaker> 3% 21:00:22 <peter1138> I've not eaten yet. 21:00:28 <TrueBrain> @calc 101510 / (3268067 + 3094301 + 438740) 21:00:29 <DorpsGek> TrueBrain: 0.0149255091964 21:00:32 <TrueBrain> @calc 101510 / (3268067 + 3094301 + 438740) * 100 21:00:32 <DorpsGek> TrueBrain: 1.49255091964 21:00:37 <TrueBrain> 1.5% :P 21:00:48 <TrueBrain> more people download the source, than the generic linux :D 21:00:51 <frosch123> TrueBrain: at some point some docker also built ai/gs docs. are they not built, or does the website not know them? 21:00:52 <TrueBrain> like ..... 3 times more people :P 21:01:01 <peter1138> People do want Linux builds. 21:01:02 <TrueBrain> frosch123: 'docs' should be there 21:01:04 <peter1138> Just not many. 21:01:14 <TrueBrain> lol: win9x: 90867 21:01:17 <peter1138> Would be nice to build them, even if they are "too new" 21:01:19 <TrueBrain> as many people that want win9x :D 21:01:25 <planetmaker> TrueBrain, ŵhat time period? 21:01:31 <LordAro> @calc 101510 / (3268067 + 3094301 + 438740 + 101510 + 90867) 21:01:31 <DorpsGek> LordAro: 0.0145149378314 21:01:36 <planetmaker> I agree with peter 21:01:37 <glx> people usually prefer to get them via their distrib 21:01:39 <TrueBrain> peter1138: any contribution to https://github.com/OpenTTD/CompileFarm to make that happen, would be appreciated 21:01:55 <TrueBrain> planetmaker: the exact numbers hav elittle meaning 21:02:03 <peter1138> What happens to the Linux builds the CI makes? 21:02:06 <peter1138> Are they not runnable on anything? 21:02:10 <TrueBrain> and just to be clear: we talk about NIGHTLIES. not releases. 21:02:21 <LordAro> TrueBrain: if the numbers are post-april 2018, they're a little less useful 21:02:22 <frosch123> the farm hast changed so often, i do not recognise anything :p 21:02:25 <TrueBrain> peter1138: not really. They are not static, and depend on very specific installed versions 21:03:01 <planetmaker> can't one just build a static on the debian or ubuntu one and that's it? 21:03:14 <TrueBrain> frosch123: https://www.staging.openttd.org/downloads/openttd-nightlies/latest.html <- 'docs', contains the AI/GS, I think 21:03:17 <LordAro> old style linux generic is probably runnable on ubuntu versions (12.04+?), assuming they have the right dependencies 21:03:18 <TrueBrain> at least, I did the same as we used to do :) 21:03:35 <TrueBrain> planetmaker: I have not found a way to do that; after spending 10+ hours on it, I was like: fuck this, not worth it 21:03:37 <glx> linux generic were static 21:03:45 <TrueBrain> but I would really appreciate it if anyone did find a good way to make it work :) 21:03:52 <glx> so theorically no depenencies 21:03:52 <peter1138> I heard something about Steam the other day. 21:04:14 <peter1138> Can we target just whatever Steam on Linux targets? 21:04:19 <TrueBrain> all the code is available, and all the repositories welcome any PR :) 21:04:46 <planetmaker> that probably is a good idea with "steam's target" 21:04:56 <TrueBrain> make it happen :D 21:04:59 <frosch123> TrueBrain: https://github.com/OpenTTD/CompileFarm/commit/7c0d24db052df87906615e743eff0c6cbb8fc65a#diff-0925013e17fd6908cd3214d19b78915eR41 21:05:13 <planetmaker> glx, yet it still depends on a certain glib version 21:05:17 <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on issue #6922: Replace ICU ParagraphLayout with something else? https://git.io/fhrwX 21:05:19 <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on issue #6907: Cargo capacity should be recalculated on TRIGGER_VEHICLE_NEW_LOAD https://git.io/fhrw1 21:05:20 <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on issue #6219: Commuter - Helicopter is in flight bug https://git.io/fhrwM 21:05:23 <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on issue #6322: AI can allocate more memory than the system has, crashing the game https://git.io/fhrwD 21:05:25 <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on issue #6884: Installer reports success even if not all files were copied https://git.io/fhrwy 21:05:29 <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on issue #6682: menu bars disappear if enable windows screen scaling on high dpi monitors https://git.io/fhrwS 21:05:29 <TrueBrain> SPAM! :P 21:05:31 <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on issue #6797: Interface: Fractional Scale https://git.io/fhrw9 21:05:35 <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on issue #6800: [OSX] NSScrollWheel event handling for 2D scrolling should use scrollingDeltaX/Y https://git.io/fhrwH 21:05:37 <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on issue #6712: Startup ticks don't allow multiple DoCommands https://git.io/fhrwQ 21:05:38 <andythenorth> easier than me doing it 21:05:40 <glx> hey stupid bot 21:05:41 <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on issue #6493: Helicopters do not autorenew/autoreplace while in routes consisting of heliports https://git.io/fhrw7 21:05:41 <planetmaker> :) 21:05:43 <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on issue #6233: Lock price for when built on sloped river and bare land tiles https://git.io/fhrw5 21:05:47 <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on issue #6574: Heliport "hangar" can cause stuck helicopters if it replaced a helidepot/helistation. https://git.io/fhrwF 21:05:49 <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on issue #6603: Insert XDG_DATA_DIRS into data loading path https://git.io/fhrwb 21:05:53 <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on issue #5713: Boats sent to unreachable depots https://git.io/fhrwA 21:06:00 <andythenorth> you have automated my game :( 21:06:13 * andythenorth has to play 2048 instead now :P 21:06:20 <TrueBrain> frosch123: https://github.com/OpenTTD/CompileFarm/blob/master/release-docs/files/run.sh 21:06:24 <TrueBrain> guess that is no longer the same :D 21:06:54 <frosch123> http://noai.openttd.org/api/ <- it's that thing, which is different from the docs 21:07:09 <frosch123> forgotten, or not wanted? 21:07:13 <TrueBrain> ah! More hidden subdomains :D 21:07:16 <TrueBrain> forgotten for sure 21:07:19 <TrueBrain> but one does not exclude the other :) 21:07:33 <TrueBrain> I believe those were only updated on release 21:07:33 <frosch123> http://nogo.openttd.org/api/ <- another one :p 21:07:44 <glx> ha yes the doxygen stuff 21:08:00 <LordAro> it's occasionally useful 21:08:06 <TrueBrain> I guess we should extend the 'release-docs' to also do the noai and nogs 21:08:15 <TrueBrain> I will make an issue out of it; hopefully someone wants to help out and fix it :) 21:08:45 <glx> and intellisense still don't like doxygen comments 21:08:52 <glx> stupid intellisense 21:08:57 <TrueBrain> https://github.com/OpenTTD/CompileFarm/issues/20 21:09:17 <TrueBrain> ah, now I see. We didn't publish NoAI/NoGS for nightlies at all 21:09:33 <glx> no for stable only, and that makes sense :) 21:10:03 <frosch123> i consider script docs more useful then source docs 21:10:15 <TrueBrain> yeah; lets just publish them too with nightlies 21:12:58 <andythenorth> urgh why did I play 2048? :( 21:13:04 <TrueBrain> because it is fun :D 21:13:07 <andythenorth> nope 21:14:05 <TrueBrain> hmm, guess the NoAI / NoGS docs should be a Docker to run on the k8s too 21:14:14 <TrueBrain> that should be easy .. if I have the content :D 21:15:01 <TrueBrain> hmm .. seems even for releases there are no NoAI / NoGS tarballs 21:15:03 <TrueBrain> interesting 21:16:55 <LordAro> i don't see a particular need to provide that as a separate download 21:17:22 <TrueBrain> it makes it difficult to create a Docker containing the correct APIs :P 21:17:34 <TrueBrain> it is now uploaded to a storage, and that is it :D 21:18:08 <TrueBrain> I guess I could put it on the CDN .. hmm 21:18:27 <TrueBrain> that reminds me, I should make sure the CDN has a backup :P 21:19:05 <TrueBrain> LordAro: do you see any particular reason to have docs as a download in general? :D 21:19:21 <LordAro> not really, tbh 21:19:27 <LordAro> if they're online somewhere 21:19:31 <TrueBrain> we publish NoAI and NoGS, but not generic docs, I think .. 21:19:40 <TrueBrain> http://docs.openttd.org/ 21:19:42 <TrueBrain> guess I was wrong 21:19:45 <LordAro> lol 21:20:05 <TrueBrain> holy crap, that is terrible 21:20:26 <LordAro> yeah, no one ever bothered making a doxygen title page 21:20:42 <TrueBrain> welll ..... when was this last generated .... 21:21:07 <TrueBrain> 2018-04-06, so it is updated 21:21:24 <TrueBrain> http://docs.openttd.org/modules.html 21:21:26 <TrueBrain> it is just horrible 21:21:32 <LordAro> it's not great 21:21:37 <TrueBrain> it is useless :P 21:21:42 <LordAro> the other tabs are a bit more useful 21:22:00 <TrueBrain> so okay ... I guess we should either publish all 3 docs as a binary to download 21:22:01 <TrueBrain> or none 21:22:05 <TrueBrain> but 1 of the 3 is silly :D 21:22:54 <TrueBrain> okay, putting it on the CDN is easy and possibly the best pick here 21:23:01 <TrueBrain> meaning we can have the nightly overwrite every night 21:23:05 <TrueBrain> and have a "most recent" version 21:23:10 <TrueBrain> together with all the stables 21:23:16 <TrueBrain> that should be doable 21:23:25 <LordAro> :) 21:24:13 <planetmaker> most important for the docs is that they are online readable. Download... is a nice bonus 21:24:57 <LordAro> hmm, do i milestone #6922 for 1.9? 21:26:15 <frosch123> i definitely linked people to the script apis, when they were asking for some specific function 21:26:29 <DorpsGek_II> [OpenTTD/CompileFarm] TrueBrain opened issue #22: Linux Generic binaries https://git.io/fhrKB 21:26:33 <andythenorth> NoGo docs are pretty essential :) 21:26:33 <frosch123> can't remember doing the same for the source docs :p 21:26:34 <TrueBrain> there, a ticket for someone to pick up 21:27:19 <peter1138> My issue with submitting to the compilefarm... I have no idea how to test stuff, if that's even possible. 21:27:47 <TrueBrain> peter1138: did you even try to read the README? Or did you just assume things here? 21:28:03 <peter1138> Of course not, if I did I would know. 21:28:43 <frosch123> hmm, tb's forum signature... 21:29:11 <frosch123> no, darkvater's 21:29:20 *** synchris has quit IRC 21:29:23 <TrueBrain> link? :) 21:29:33 <frosch123> https://www.tt-forums.net/memberlist.php?mode=viewprofile&u=949 21:29:34 <TrueBrain> I think I had the one about good men do nothing, right? 21:29:51 <TrueBrain> frosch123: yeah, some things haven't changed, sadly 21:30:45 <peter1138> Ok 21:30:56 <TrueBrain> okay ... seems we are pretty close to be able to release a beta :D 21:31:18 <andythenorth> :D 21:31:34 <peter1138> Thanks for just saying "please read the readme" rather than being condescending. 21:32:10 <TrueBrain> tnx for taking an effort, instead of seeing only issues :) 21:33:30 <andythenorth> tpyos in commits? https://github.com/OpenTTD/OpenTTD/pull/7094 21:33:41 <andythenorth> should I comment, or wait for review :P 21:34:09 <LordAro> i think that can be fixed with a squash :p 21:34:25 <LordAro> i don't like that solution though, it's too brittle 21:34:37 <TrueBrain> its a bit weird :D 21:34:50 <andythenorth> I tried to read what it does 21:35:07 <andythenorth> there seem to be a lot of crashes due to changes with certain windows open 21:35:18 <andythenorth> can't we just enforce window modality? :P 21:35:36 <andythenorth> trying to maintain window state when underlying state changes.... 21:35:39 <andythenorth> is a fool's errand 21:35:49 <peter1138> It's not the right way to do what he's trying to do. 21:35:53 <LordAro> andythenorth: exactly 21:35:59 <LordAro> i'll review as such 21:38:31 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro requested changes for pull request #7094: Fix #7088: Retrieve an appropriate name for a non-existant AI/GS when… https://git.io/fhr6S 21:38:42 *** gelignite has quit IRC 21:39:24 <LordAro> TrueBrain: thought: is there an option to prevent an issue from being made stale/closed if it's referred to in a(n open) PR? 21:39:36 <LordAro> e.g. #6574 21:39:39 <TrueBrain> good question 21:39:47 <TrueBrain> probot/stale might have an answer? Dunno 21:40:05 <TrueBrain> I think it only scans for 'updated' 21:40:12 <TrueBrain> but a PR might update that counter 21:42:56 <TrueBrain> LordAro: https://github.com/probot/stale/issues/154 21:43:04 <LordAro> doesn't seem like it, given #6574 was "updated" 12 days ago 21:44:43 <TrueBrain> so indeed, not supported, they accept PRs :D 21:44:59 <LordAro> "Javascript 100.0%" eh. 21:46:13 <peter1138> LordAro, #7085, your changes request is blocking it being merged. 21:46:53 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro dismissed a review for pull request #7085: Fix: Remove duplicate French and Slovak town names https://git.io/fhwfW 21:47:15 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro merged pull request #7085: Fix: Remove duplicate French and Slovak town names https://git.io/fh2Af 21:48:38 <peter1138> :) 21:50:54 <supermop_work_> i like the smart town name request someone wrote 21:51:35 <supermop_work_> would be nice not to get those x-on-sea town in the middle of a prairie 21:51:50 <glx> but it will it work with newgrf townnames ? 21:51:59 <andythenorth> it could be made too 21:52:03 <andythenorth> with a spec extension 21:52:09 <supermop_work_> presumably it would only work with newgrf names 21:52:16 <andythenorth> also some towns should favour forests planting around them 21:52:19 <supermop_work_> and only those that made use of the feature 21:52:22 <andythenorth> oh did I just derail the conversation :P 21:52:24 *** sla_ro|master has quit IRC 21:52:38 <TrueBrain> andythenorth: we are used to you doing that :P 21:52:45 <andythenorth> anyone want to close this as stale? 21:52:52 <andythenorth> https://github.com/OpenTTD/OpenTTD/pull/6811 21:52:57 <peter1138> It bases its decision on the string content of the name. 21:53:06 <supermop_work_> andythenorth: my brother and i build the chez albert restaurant this christmas 21:53:11 <peter1138> Which is fine but feels a bit hardcoded. 21:53:43 <TrueBrain> LordAro: do you know if Squirrel is still a maintained language? (looking at the stale you removed) 21:53:45 <peter1138> Also a mix of return types. 21:53:51 <glx> yeah for newgrf it could pass the flags and let the newgrf do its work 21:54:10 <peter1138> That would need ... infrastructure. 21:54:28 <LordAro> TrueBrain: iirc, it depends what you mean by "maintained" :p OTTD uses Squirrel2, whereas Squirrel3 is a thing these days 21:54:41 <TrueBrain> are the languages compatible? 21:54:42 <LordAro> but our copy of Squirrel is fairly significantly modified anyway 21:54:45 <LordAro> not a clue 21:55:00 <supermop_work_> put nrt in 1.9 so i will feel compelled to work on grfs again 21:55:01 <nielsm> upgrading squirrel in ottd is probably not realistic 21:55:10 <nielsm> may as well switch to a wholly different language then 21:55:10 <peter1138> supermop_work_ :D 21:55:19 <LordAro> nielsm: OTTD 2.0 ^^ 21:55:21 <peter1138> ini files! 21:55:22 <TrueBrain> nielsm: that requires AIs/GSs to change too :P 21:55:36 <TrueBrain> if the language it compatible, upgrading the engine is "just work" 21:55:54 <nielsm> at least if it follows my experience with lua 5.0 to 5.1 which are not compatible :) 21:55:56 <TrueBrain> or, we could write a conversion script! :P 21:56:12 <TrueBrain> does lua support any decent form of OO by now? 21:56:23 <TrueBrain> or is it still this annoying to do any sane complex thing in? 21:56:30 <glx> how silly to break compatibility with a minor release 21:56:38 <nielsm> haven't followed it for many years 21:56:41 <TrueBrain> (btw, the most prominent reason Squirrel is in OpenTTD, and not lua. OO :P) 21:56:45 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on pull request #6925: Fix #6574 #6636 #5405 #6493: Aircraft hangar issues https://git.io/fhrPg 21:56:46 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed pull request #6925: Fix #6574 #6636 #5405 #6493: Aircraft hangar issues https://git.io/fpJfr 21:56:52 <frosch123> TrueBrain: lua is still terrible with custom types 21:57:23 <frosch123> and with security 21:57:37 <TrueBrain> security? really? 21:57:45 <TrueBrain> I would expect them to have that in order by now 21:57:50 <TrueBrain> given ... many games use it :P 21:57:52 <frosch123> like the standard library putting essential dict/array functions into the same library as "load shared library from search path" 21:58:15 <glx> hmm right squirrel vm has no direct access to OTTD code 21:58:19 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on pull request #6926: Change: Allow dock to be constructed in more locations https://git.io/fhrPy 21:58:20 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed pull request #6926: Change: Allow dock to be constructed in more locations https://git.io/fhnCx 21:58:26 <TrueBrain> hmm .. I should have finished NAILs after all .. the BOLTS language was similar to Squirrel, but a bit less weird :P 21:58:36 <frosch123> at work i decided to disable the entire standard library, and reimplement the 3 useful methods 21:58:42 <TrueBrain> the good old days, where writing your own language was an option :D 21:59:18 <glx> hey just retry gpmi ;) 21:59:30 <nielsm> use javascript (and get a barrage of "javascript is a terrible language"), or use something else (and get a barrage of "you should use de-facto standard javascript instead") 21:59:30 <TrueBrain> omg, GPMI .. that is old :P 21:59:40 <TrueBrain> that was the moment I realised that most script languages suck balls 21:59:52 <TrueBrain> nielsm: add NodeJS support? :D 22:00:00 <milek7> webassembly ;) 22:00:01 <frosch123> nielsm: i read left-padding in js is nice 22:00:30 <orudge> VBScript is the way forward 22:00:32 <orudge> :D 22:00:35 <frosch123> https://www.theregister.co.uk/2016/03/23/npm_left_pad_chaos/ 22:00:54 <glx> at least vbs is nice with case 22:00:54 <nielsm> just use c#, import mono and be over with it 22:01:05 <nielsm> or .net core even 22:01:11 <peter1138> :/ 22:01:36 <TrueBrain> honestly, if we add NodeJS support, we might get more AIs :P 22:01:41 <TrueBrain> they will all suck more than the next, but .... 22:01:51 <andythenorth> can we import all the node vulns too? 22:01:56 <andythenorth> then we can lose all our bitcoin 22:02:18 <nielsm> make an ai that builds a bitcoin miner with logic trains 22:03:15 <frosch123> can we agree to reject prs that want to add digital currencies? 22:03:19 <andythenorth> LordAro nielsm I made a decision about some PRs you've been reviewing 22:03:21 <glx> https://github.com/OpenTTD/OpenTTD/issues/7007 <-- this one won't be easy 22:03:26 <TrueBrain> frosch123: no, lets argue about that first 22:03:50 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on issue #6896: game crashes on first autosave if compiled without lzo but with lzma https://git.io/fhrXB 22:05:26 <nielsm> add TycoonCoin as currency option in game, if you use it you will be forced to play with inflation on, and running costs increase at the square of inflation 22:05:54 <TrueBrain> no no; first, you make it worth your while 22:06:04 <TrueBrain> for 1 year or something, everything is incredible cheap 22:06:09 <TrueBrain> you can build the biggest infrastructures 22:06:20 <TrueBrain> after that ..... CRASH :P 22:06:48 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on pull request #6927: Change: Forbid dock placement on docking area https://git.io/fhrXD 22:06:49 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed pull request #6927: Change: Forbid dock placement on docking area https://git.io/fhnCh 22:06:50 <TrueBrain> what ever happened with the game rebalancing ideas .... 22:06:56 <frosch123> how about: the game is slowed the more money you stockpile 22:07:10 <frosch123> so you have to spend it to have stuff moving 22:07:17 <andythenorth> well the coin miner will use more CPU 22:07:21 <andythenorth> so that will slow the game down 22:07:29 <andythenorth> we get 50% of the mined coins, right? 22:07:35 <andythenorth> to pay for servers :P 22:07:42 <TrueBrain> anyway .. 2 more days before we bring the new website online in production .. please let me know if you find any additional issues: https://www.staging.openttd.org/ (only known issue currently is that there are no 'noai/nogs' docs) 22:07:58 <andythenorth> TrueBrain: have you tested the coin miner in it is working? o_O 22:08:16 <nielsm> TrueBrain: should I resurrect my cargo-tiles patch? that rates vehicles by cargo over distance delivered rather than by profit 22:08:35 <andythenorth> nielsm: sounds...interesting :) 22:09:03 <andythenorth> for 2.0 in 2020, can we delete the stupid original high score goals? 22:09:06 <frosch123> are the translations real? or are they fake? 22:09:08 *** Simons_Mith has joined #openttd 22:09:12 <frosch123> *statistics 22:09:22 <andythenorth> child #1 drove me crazy trying to get 100% of the bars complete 22:09:23 <nielsm> and replaces the "min yearly profit" element of the score goals with one based on that instead 22:09:28 <TrueBrain> frosch123: damn, I forgot about those 22:09:30 <TrueBrain> they are fake 22:09:30 <andythenorth> especially the min. vehicle profit 22:09:33 <nielsm> frosch123: it actually measures distance traveled 22:09:41 <TrueBrain> andythenorth: what did we say about the translation stats? 22:09:45 <andythenorth> urgh 22:09:47 <frosch123> TrueBrain: well, now that the screenshot is different, they can remain the same? 22:09:49 <andythenorth> we said bin them 22:09:52 <andythenorth> and rely on eints 22:09:56 <TrueBrain> frosch123: lol :) 22:10:07 <TrueBrain> I kinda agree, lets remove it. Not sure it ever helped finding people tbh 22:10:08 <andythenorth> we were going to replace that block, or remove it 22:10:12 <nielsm> so a curvy route counts as longer distance traveled, but the vehicle is rated on the manhattan distance the cargo was delivered 22:10:33 <nielsm> so vehicles traveling less direct routes are rated worse 22:10:58 <TrueBrain> andythenorth: why did it pick a screenshot from 0.4.7? Didnt we tell it to pick the latest screenshot? 22:11:06 <andythenorth> did we fail? 22:11:33 * andythenorth looks 22:11:37 <nielsm> why aren't there any screenshots from recent versions even? 22:11:54 <DorpsGek_II> [OpenTTD/website] TrueBrain opened issue #35: "Support us by translating" is fake https://git.io/fhr1c 22:12:09 <TrueBrain> nielsm: because it was not easy to upload new screenshots 22:12:12 <TrueBrain> so people stopped doing it 22:12:44 <TrueBrain> andythenorth: {% assign latest_screenshot = site.screenshots | first %} 22:12:44 <TrueBrain> :D 22:12:51 <TrueBrain> we never sorted it 22:12:53 <andythenorth> now it's a PR to add screenshots, right? 22:13:16 <TrueBrain> "site.screenshots | group_by_exp: "screenshot", "screenshot.path" 22:13:21 <TrueBrain> andythenorth: yes! 22:13:41 <andythenorth> "The story goes that one programmer, who had to write the code to calculate the height of a line of text, simply wrote “return 12;” and waited for the bug report to come in about how his function is not always correct. " 22:13:46 <andythenorth> https://www.joelonsoftware.com/2000/08/09/the-joel-test-12-steps-to-better-code/ 22:14:12 <andythenorth> TrueBrain: are you fixing, or am I? Or issue for later? 22:14:26 <TrueBrain> I am about to go to bed; I was creating an issue 22:14:30 <TrueBrain> how do I get inline code snippets 22:14:47 <andythenorth> issue works, I am bed also 22:15:15 <DorpsGek_II> [OpenTTD/website] TrueBrain opened issue #36: Screenshot on frontpage is not latest https://git.io/fhr1M 22:15:23 <nielsm> andythenorth: https://www.tt-forums.net/viewtopic.php?f=33&t=82642 22:15:50 <andythenorth> there's some kind of utilisation feature added to vehicle groups recently 22:15:53 <andythenorth> dunno what it is 22:15:55 <TrueBrain> frosch123: keep the bugs coming :) 22:16:19 <nielsm> andythenorth yeah, it measures current average load percentage 22:16:20 <nielsm> afaik 22:16:23 <TrueBrain> good night all 22:16:55 <andythenorth> bye 22:17:18 <Samu> hi 22:17:39 * LordAro currently looking at the diff between a clean squirrel 2.2.5 and the modified version in ottd 22:17:45 <LordAro> the changes are quite extensive 22:17:45 <andythenorth> nielsm: I could try your patch another day :) 22:17:48 <andythenorth> it's in your fork? 22:17:59 <nielsm> yeah, but haven't updated it lately 22:18:06 <nielsm> probably won't rebase to master 22:18:39 <Samu> how to save the config constructor yada what he said 22:18:51 <frosch123> LordAro: mostly about suspending scripts? 22:18:53 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhrML 22:18:54 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhZzm 22:19:06 <Samu> oh andythenorth :( 22:19:10 <LordAro> frosch123: as far as the actual changes go, yes 22:19:51 <LordAro> there's a lot of mechanical changes, things like removing a define that adds extern to a load of functions, and makes all error strings wchars 22:19:58 <LordAro> Samu: you could ask me :p 22:20:25 <andythenorth> frosch123: is this a comment on the code, or the proposed design? https://github.com/OpenTTD/OpenTTD/pull/6933#issuecomment-427671566 22:20:35 <andythenorth> I am about to close the PR, just want to be accurate 22:20:59 <Samu> :| 22:21:11 <Samu> watching my stuff get closed is depressive 22:21:40 <frosch123> both 22:21:48 <LordAro> Samu: it's nothing personal, they're just changes that don't fit into OTTD into one way or another 22:22:03 <andythenorth> Samu: if it helps, I have deleted entire companies 22:22:15 <frosch123> it changes too much in one thing, and i did not agree with the individual thigns split apart 22:22:16 <andythenorth> 3 of them 22:22:28 <LordAro> luckily, there's plenty of other issues you can work on :) 22:22:29 <andythenorth> deleting one company involved about 10 people losing their jobs 22:22:34 <LordAro> andythenorth: oof 22:22:38 <andythenorth> but otherwise I would have gone bankrupt 22:22:41 <andythenorth> so eh 22:22:51 <andythenorth> all code dies, just some PRs die early 22:23:06 <Samu> ahm that PR was about the bug report 22:23:22 <TrueBrain> DELETE FROM companies LIMIT 0,1 22:23:35 <Samu> found some inconsistencies, then came up with making it more consistent 22:23:44 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on pull request #6933: Fix #6233: Improve lock pricing and infrastructure counting, to achieve better consistency https://git.io/fhrM6 22:23:45 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed pull request #6933: Fix #6233: Improve lock pricing and infrastructure counting, to achieve better consistency https://git.io/fhnWe 22:23:56 <Samu> rip 22:24:11 <andythenorth> I agree that locks and canals cost too much to build 22:24:15 <andythenorth> but I fixed it in newgrf 22:24:29 <andythenorth> it's in the game goals, everything that can be fixed with content, should be fixed with content 22:24:31 <Samu> but the bug... goes unfixed 22:24:48 <LordAro> andythenorth: base game should still be sane though 22:24:55 <nielsm> I don't think you've yet convinced anyone else there is a bug at all? 22:25:27 <andythenorth> I am convinced that some costs for building on water make no sense 22:25:32 <Samu> i tried explaining, requires using base costs, to exploit a flaw 22:25:39 <andythenorth> but I am also convinced it doesn't really matter 22:25:56 <nielsm> but eh, bed time 22:25:57 <TrueBrain> try convincing that yourself 22:27:13 <andythenorth> Samu: if you can get this one through a review, it would be worth focussing on https://github.com/OpenTTD/OpenTTD/pull/6931 22:27:23 <andythenorth> but it's very hard to test reliably 22:27:41 <andythenorth> it is silly when town expansion breaks a ship route 22:28:25 <Samu> 6931 is waiting review atm 22:28:33 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #6712: Startup ticks don't allow multiple DoCommands https://git.io/fhrDn 22:29:51 <Samu> for my part, there's nothing to do 22:30:33 <TrueBrain> Nice catch LordAro 22:30:46 <LordAro> https://github.com/OpenTTD/OpenTTD/issues/6682 anyone with a high dpi monitor to test this on? 22:31:07 <milek7> what's high dpi? 22:31:22 <andythenorth> isn't that same as retina etc? 22:31:23 <LordAro> pretty sure there's been some work in the high dpi area since these issues were raised 22:31:25 <andythenorth> 4x pixels 22:31:28 <LordAro> yeah, think so 22:31:34 <peter1138> ^ andy does 22:31:38 <peter1138> but not windows 22:31:41 <LordAro> https://docs.microsoft.com/en-gb/windows/desktop/hidpi/high-dpi-desktop-application-development-on-windows is linked from one of the duplicates 22:31:45 <andythenorth> I could install windows 7? 22:31:47 <andythenorth> :P 22:32:13 <LordAro> not new enough :p 22:32:15 <LordAro> i suspect 22:32:23 <andythenorth> see also https://github.com/OpenTTD/OpenTTD/issues/6567 22:32:32 *** Simons_Mith has quit IRC 22:32:37 <peter1138> Hmm, my simulated high-res modes have disappeared. 22:32:58 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #6682: menu bars disappear if enable windows screen scaling on high dpi monitors https://git.io/fhrDH 22:33:38 <andythenorth> can't decide on this one https://github.com/OpenTTD/OpenTTD/pull/7078 22:33:45 <andythenorth> rail / road bridges don't raise a corner 22:33:50 <andythenorth> they have foundations 22:34:01 *** nielsm has quit IRC 22:34:20 <andythenorth> I see no rationale for having different behaviour for aqueducts 22:34:23 <LordAro> maybe the issue is that aqueducts don't have foundations :p 22:34:37 <andythenorth> there's no reason to stop canals having foundations 22:34:46 <andythenorth> unless it's an implementation issue 22:35:15 <peter1138> Ok, I set up 4x DSR... 22:35:48 <LordAro> andythenorth: your turn to comment as such :) 22:36:11 <peter1138> Nothing disappears, but I'm using Windows 10. 22:36:34 <LordAro> try checking out some old version? 22:36:47 <peter1138> CBA 22:36:55 <peter1138> Too much hassle with VS2017 22:37:02 <LordAro> just downloading 1.8 would do :p 22:37:11 <glx> I think high dpi is ok in master (not testable for me) 22:37:27 <peter1138> No need, already installed... 22:37:30 <peter1138> Works fine for me. 22:37:39 <peter1138> Simulated high DPI though. 22:37:46 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on pull request #7078: Feature: Raise a corner of land automatically when building aqueducts https://git.io/fhryg 22:37:53 <glx> I mean something was added in the manifest for that 22:38:09 <LordAro> that's what i was thinking of 22:38:26 <LordAro> presumably only makes a difference for MSVC-compiled versions, rather than MSYS 22:38:28 <LordAro> but eh 22:38:42 <glx> https://github.com/OpenTTD/OpenTTD/blob/master/projects/dpi_aware.manifest 22:39:13 <glx> hmm MSYS can embed the manifest too I think 22:40:12 <orudge> The manifest ultimately is just an entry in the resource file 22:40:20 <orudge> It may just require adding to the .rc 22:40:32 <frosch123> andythenorth: you can't build canals on foundations 22:40:34 <milek7> maybe system dpi settings could modify openttd interface size setting? 22:40:52 <frosch123> so, to some extent all water construction requires landscaping 22:40:55 <glx> yes system zooming have an effect 22:41:09 <andythenorth> frosch123: for implementation reasons, or realism reasons? 22:41:19 <glx> or scaling whatever it's called 22:42:03 <frosch123> andythenorth: the former may be the case historically, but would be fixable if it applies. so, mostly the latter? 22:42:34 <andythenorth> you should see the canals in wales :P 22:43:02 <andythenorth> I have been along one that is halfway up a hillside, with foundations :P 22:43:33 <frosch123> hmm, actually.. i guess all vehicle types fall of the cliff if the track continues on the lower side 22:43:44 <frosch123> we also forbid placing roads like that 22:43:49 <glx> hmm seems the dpi_aware.manifest is no longer in use btw as it was for vs100 22:44:10 <frosch123> so, maybe it would not be that easy to allow ships on foundations 22:44:47 <frosch123> no other track type can bridge canyons via foundations 22:44:59 <andythenorth> no 22:45:13 <andythenorth> was my comment clear? :) 22:45:18 <LordAro> glx: PR! 22:45:23 <andythenorth> I wasn't proposing embankment over canyon :) 22:46:13 <frosch123> comment is good :) 22:46:54 *** Wolf01 has quit IRC 22:48:00 <andythenorth> sometimes canals on foundations have...issues https://www.waterwayschaplaincy.org.uk/wp-content/uploads/2018/03/Middlewich-breach-aerial-e1522238121792.png 22:48:46 <Samu> erm, aqueducts have no foundations 22:49:04 <Samu> they build much like a tunnel in reverse 22:49:28 <Samu> tunnels lower a corner of land, aqueducts raise a corner of land 22:50:17 <andythenorth> and rail bridges? o_O 22:50:27 <Samu> those have foundations 22:50:35 <Samu> needs drag & drop to build 22:50:43 <Samu> i didn't break that 22:50:53 <frosch123> looks like the a20 22:51:40 <andythenorth> ok I see the point about tunnels 22:51:59 <frosch123> i always wanted to add tunnel foundations 22:51:59 <andythenorth> aqueducts are weird :P 22:52:10 <frosch123> and tunnels with slopes at the end 22:52:15 <andythenorth> :D 22:53:44 <frosch123> at some point you always run into visibility problems on north-facing slopes 22:55:24 <andythenorth> one of my kids built this :P https://dev.openttdcoop.org/attachments/download/9203/Sarfingfield%20Transport,%204th%20Mar%202183.png 22:56:23 <frosch123> are sure? it looks like kid 1 built the road, and kid 2 wanted their boat to pass 22:56:34 <andythenorth> no, it's all one :P 22:56:54 <andythenorth> MP would be too much trouble :P 22:57:32 <andythenorth> at the top right, the road seems to be in a town zone? 22:57:33 <frosch123> make a PR for the website? 22:57:43 <andythenorth> note the pavements :P 22:57:46 <frosch123> someone wanted more screenshots 22:57:55 <frosch123> yeah, pavements are weird 22:58:01 <Samu> https://github.com/OpenTTD/OpenTTD/pull/7094#pullrequestreview-196262122 22:58:15 <andythenorth> town zone for water tiles :P 22:58:18 <frosch123> also the road is a dead end in the south 22:58:19 <Samu> plz english 22:58:29 <andythenorth> canal cheat is the best thing ever 22:58:49 <andythenorth> is it even a cheat? 22:58:50 <frosch123> i think it was voted "not a cheat" 22:59:02 <Samu> save script object in constructor 22:59:02 <andythenorth> "unintended outcome" 22:59:05 <frosch123> i think there was a fix, and it was rejected 22:59:15 <andythenorth> good 22:59:28 <andythenorth> I encourage anything that adds to free-form construction :P 22:59:42 <andythenorth> there is nothing gained by limiting what can be built where 22:59:59 <Samu> what is LordAro trying to tell 23:01:41 <Samu> TextFileWindow is also used by NewGrf 23:01:50 <Samu> not specific to AI only 23:02:22 <milek7> what's unclear? 23:02:39 <LordAro> Samu: specifically, ScriptTextfileWindow stores a "CompanyID slot". Instead, it should store a specific ScriptConfig (i.e. the return value of GetConfig(slot)) 23:03:38 *** Progman has quit IRC 23:04:10 *** frosch123 has quit IRC 23:04:17 *** andythenorth has left #openttd 23:07:29 <Samu> ok, gonna try pass GetConfig(slot) from wherever it's called 23:08:32 <LordAro> Samu: i don't think that's specifically necessary, just do it in the constructor of the ScriptTextfileWindow 23:08:42 <LordAro> it might be better your way though, i'm not sure 23:10:22 <Samu> the idea I had for an alternative solution was "just close it" 23:10:37 <LordAro> not very productive :p 23:11:16 <Samu> what should it do 23:11:28 <Samu> if not closing 23:11:40 <Samu> refresh its contents? 23:11:43 <LordAro> looks like you'll need at least a bool as well as the ScriptConfig, to determine whether it's a GS or AI 23:11:51 <LordAro> Samu: sure, force push 23:11:58 <LordAro> as per usual 23:13:12 <Samu> i mean, what should the window display? 23:14:27 <LordAro> ooh, i thought you were talking about the PR :p 23:14:33 <LordAro> (the PR itself) 23:14:48 <LordAro> just closing it is also a perfectly good option 23:14:51 <LordAro> (possibly both) 23:15:47 <Samu> there is essentially nothing to display 23:16:14 <Samu> just a large purple square 23:16:19 <LordAro> when the window refers to a "slot", yes 23:16:33 <LordAro> but if the window is referring to a particular AI instead, it makes more sense to keep it open 23:37:22 <Samu> looks like it needs OnInvalidateWindowData, it does not have it 23:37:59 <Samu> OnInvalidateData* 23:41:34 <Samu> virtual void OnInvalidateData? I wonder ... how is it called 23:42:18 *** smoke_fumus has quit IRC 23:44:44 <LordAro> i suspect you're going in the wrong direction, but look at other windows to see what they do, there are plenty of examples