Times are UTC Toggle Colours
00:00:24 <drac_boy> sorry was a little busy .. but hmm .. I guess that makes sense but I still don't see why he shouldn't just use the letter N instead .. oh well its his own grf so meh :) 00:14:31 <drac_boy> anyway night here 00:14:34 *** drac_boy has left #openttd 00:19:15 *** Flygon has joined #openttd 00:29:44 *** tokai|noir has joined #openttd 00:29:44 *** ChanServ sets mode: +v tokai|noir 00:36:27 *** tokai has quit IRC 00:38:47 *** Smedles has quit IRC 00:40:13 *** Smedles has joined #openttd 00:41:04 *** Wormnest has joined #openttd 00:41:37 <Samu> who would have though 00:42:01 <Samu> ScriptTile::GetCargoProduction is the slowest function of all that valuator 00:42:09 <Samu> the most important one, the one that actually matters 00:42:15 <Samu> pff :( 00:44:04 <Samu> Orthogonal tile area intersects... 00:49:06 *** Smedles has quit IRC 00:49:22 *** Smedles has joined #openttd 01:06:50 *** Supercheese has quit IRC 01:07:21 *** HerzogDeXtEr has quit IRC 01:08:07 <utack> does anyone know if there are grf's with animals? all i could find was the opengrf farm https://i.imgur.com/gTSqdW4.png 01:08:57 <Eddi|zuHause> there defintely were animals, in FIRS, maybe also ECS 01:09:22 <Eddi|zuHause> also, ISR stations 01:09:37 <Samu> OthogonalTileArea::Intersects is slow, plz buff 01:09:45 <Samu> :p 01:11:00 <utack> found something here too http://george.zernebok.net/newgrf/downloads.html#decs 01:11:05 <utack> thank you Eddi|zuHause i will see! 01:12:07 *** Thedarkb-X40 has joined #openttd 01:13:15 <Samu> maybe I shouldn't use intercontinental airports :| 01:14:26 <utack> Eddi|zuHause you were right, there is a duck and a chicken at least :) 01:16:17 <utack> and cows 01:23:35 <Samu> this area intersection is ... intersecting with industries tile area 01:23:38 <Samu> for all industries... omg 01:23:45 <Samu> no wonder it's slow 01:24:02 <Samu> and I'm making airports in towns, even 01:24:17 <Samu> but it has to loop over all industries, for some reason 01:25:06 <Samu> line 529 station_cmd.cpp 01:26:46 <Samu> so, if I create a map with no industries, I am expecting this to be faster, let me try 01:36:57 <Samu> tested 01:37:11 <Samu> went from 66% to 2% 01:37:14 <Samu> lol 01:37:33 <Samu> GetNearestTown is now the new 66% 01:44:02 <Samu> wasn't kdtree implemented? 01:45:22 *** Wormnest has quit IRC 01:55:34 <Samu> who was the kdtree implementer? 02:02:47 *** Thedarkb-X40 has quit IRC 02:13:31 *** Supercheese has joined #openttd 03:17:39 *** Supercheese has quit IRC 03:18:00 *** Supercheese has joined #openttd 04:00:34 *** D-HUND has joined #openttd 04:03:57 *** debdog has quit IRC 04:38:36 <DorpsGek_II> [OpenTTD/OpenTTD] glx22 opened pull request #7423: Fix: MSVC warnings https://git.io/fjU12 04:40:53 *** Saqeram[m] has joined #openttd 04:55:16 *** Maarten has quit IRC 04:55:20 *** Maarten has joined #openttd 05:01:43 *** glx has quit IRC 05:06:33 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick opened pull request #7424: Add: Kdtree for AirportGetNearestTown https://git.io/fjU1d 05:09:18 <cHawk> longtime lurker, early player of Transport Tycoon for dos. OpenTTD has done an amazing job. I love you guys! 05:10:39 <Samu> Im off to bed, good night 05:10:45 *** Samu has quit IRC 05:57:35 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN approved pull request #7422: Fix #7421: Don't (directly) dereference std::vector::end() in SmallMap https://git.io/fjUMz 06:03:42 <peter1138> Hmm 06:04:02 <peter1138> Queued. I'm sure it's not. 06:10:43 <peter1138> 01:25 < Samu> line 529 station_cmd.cpp 06:11:35 <peter1138> hmmmmm 06:18:10 <peter1138> Hmm, do we have non-square airports? 06:19:18 <peter1138> I guess so. 06:31:52 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN merged pull request #7422: Fix #7421: Don't (directly) dereference std::vector::end() in SmallMap https://git.io/fjUin 06:31:58 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN closed issue #7421: Can't dereference value-initialized vector iterator https://git.io/fjUKS 06:58:29 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN approved pull request #7417: Group hierarchy improvements (by 3298) https://git.io/fjUDv 06:58:51 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN closed issue #6189: Vehicle Groups: parent group should count total number of vehicles in subgroups https://git.io/fjUDJ 06:58:52 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN closed issue #5977: Vehicle Groups: improve error message when group hierarchy fails https://git.io/fjUDU 06:58:54 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN merged pull request #7417: Group hierarchy improvements (by 3298) https://git.io/fjU3n 06:58:56 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN closed issue #6053: Vehicle Groups: packing and unpacking subgroups https://git.io/fjUDT 06:59:53 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7424: Add: Kdtree for AirportGetNearestTown https://git.io/fjUDk 07:26:08 *** Supercheese has quit IRC 07:26:37 <DorpsGek_II> [OpenTTD/OpenTTD] planetmaker opened issue #7425: Crash report https://git.io/fjUDO 07:33:59 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on issue #7425: Crash report https://git.io/fjUDs 07:41:00 *** kiwitree has joined #openttd 07:50:26 *** andythenorth has joined #openttd 07:53:22 <peter1138> Hi 07:53:28 <planetmaker> moin 07:54:37 <andythenorth> yo 07:55:01 <andythenorth> is it lunch time? 07:57:04 <planetmaker> drive time or trip time... see ya Friday :) 07:58:21 <peter1138> Noooo 07:58:44 <andythenorth> coffee time 08:01:11 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN requested changes for pull request #7424: Add: Kdtree for AirportGetNearestTown https://git.io/fjUDz 08:04:16 *** HerzogDeXtEr has joined #openttd 08:09:01 <LordAro> mrng 08:12:07 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #7425: Crash report https://git.io/fjUDy 08:12:08 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro closed issue #7425: Crash report https://git.io/fjUDO 08:19:55 *** HerzogDeXtEr has quit IRC 08:35:47 <DorpsGek_II> [OpenTTD/OpenTTD] JGRennison commented on issue #6618: Incorrect size bounds checks in vehicle viewport hash scan in ViewportAddVehicles https://git.io/fjUyI 08:53:39 <DorpsGek_II> [OpenTTD/OpenTTD] JGRennison commented on pull request #7366: Add: List recently executed commands in crashlog output. https://git.io/fjUy2 10:07:44 *** andythenorth has quit IRC 10:32:30 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN approved pull request #7409: Some Industry vars missing from #6867 https://git.io/fjU9S 10:44:25 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN merged pull request #7409: Some Industry vars missing from #6867 https://git.io/fjJSs 11:00:57 *** kiwitree has quit IRC 11:10:08 *** gelignite has joined #openttd 11:48:37 *** Laedek has quit IRC 12:07:12 *** sla_ro|master has joined #openttd 12:30:40 *** Samu has joined #openttd 12:30:44 <Samu> hi 12:31:45 <Samu> peter1138, you awake? 12:33:45 <Samu> I found the big reason why my AI was stutterfesting 12:34:00 <Samu> it's on line 529 station_cmd.cpp 12:34:20 <Samu> FOR_ALL_INDUSTRIES 12:34:21 <Samu> :( 12:35:24 <Samu> the 2nd big reason was getting Airport Noise 12:35:39 <Samu> and I created a PR for that, the kdtree thing 12:36:16 <peter1138> Yes, I responded to that. 12:36:44 <Samu> can you take a look on cargo production around industries for me? :p 12:36:52 <peter1138> Not right now, no. 12:36:57 <Samu> :) 12:40:03 *** gelignite has quit IRC 12:52:32 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #7424: Add: Kdtree for AirportGetNearestTown https://git.io/fjU7y 12:53:29 <Samu> maybe I should assert 12:53:44 <Samu> assert(t == NULL); ? 12:53:47 <Samu> oops 12:53:51 <Samu> assert(t != NULL); 12:54:40 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7424: Add: Kdtree for AirportGetNearestTown https://git.io/fjU7H 12:55:28 <Samu> uhm, okay, I failed at explaining 12:59:57 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #7424: Add: Kdtree for AirportGetNearestTown https://git.io/fjU5L 13:06:37 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7424: Add: Kdtree for AirportGetNearestTown https://git.io/fjU5R 13:07:07 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7424: Add: Kdtree for AirportGetNearestTown https://git.io/fjU5E 13:17:32 <Samu> how do I make heliports so noisy so noisy that I can't place them in the smallest town ever? 13:17:39 <Samu> for testing 13:20:04 <Samu> i meant the biggest town ever 13:21:27 <Samu> ugh, looks like I can't assert, grr 13:23:05 <Samu> let's test mindist + 1 13:27:37 <Samu> assert(AirportGetNearestTownForAllTowns(as, it) == AirportGetNearestTownKdTree(as, it)); 13:30:27 <Samu> 65535 ought to be enough noise 13:33:18 <Samu> too much noise 13:34:27 <Samu> damn towns always have a min noise of 3 13:34:42 <Samu> heliports always getting away with i 13:34:43 <Samu> t 13:36:06 <Samu> peter1138, I'm testing this atm https://paste.openttdcoop.org/pmxvuic0n 13:36:32 <Samu> for some reason, I can't assert(t != NULL); 13:36:57 <Samu> so i made it into a continue 13:41:42 <Samu> I notice const AirportSpec *as isn't used anymore 13:59:05 <peter1138> I... hadn't noticed that either :p 14:00:34 <Samu> well, it didn't assert anymore, so... 14:00:37 <Samu> gonna post 14:03:36 <Samu> oh, as to why it prefers town with lowest index 14:03:51 <Samu> it's so that it could match assert(AirportGetNearestTownForAllTowns(as, it) == AirportGetNearestTownKdTree(as, it)); 14:04:00 <Samu> but that's a bad comment 14:04:05 <Samu> what would I say? 14:04:15 <peter1138> I know why it prefers lowest index. 14:04:33 <peter1138> Do you know why it prefers lowest index? 14:05:49 <Samu> because the old method also preferred it 14:05:52 <Samu> lol i dunno 14:06:00 <peter1138> Why did the old method prefer it? 14:07:07 <Samu> because it was iterating from the lowest index to highest index? 14:11:08 <peter1138> Right. 14:11:53 <peter1138> So focus your behaviour comment on that, not some meaningless "assert foo == bar" 14:18:36 *** Pikka has joined #openttd 14:19:23 <Pikka> aww, simyoulater didn't appreciate my "iron vole" title 14:21:06 <peter1138> Hmm? 14:21:49 *** Flygon has quit IRC 14:24:02 <peter1138> Oh the split-topic thing. 14:25:14 *** andythenorth has joined #openttd 14:25:17 <Pikka> yes 14:25:35 <peter1138> andy is north 14:25:50 <Pikka> and an ironmonger 14:28:46 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7380: Feature: Multi-tile docks. https://git.io/fjUFy 14:33:17 *** andythenorth has quit IRC 14:33:48 <Samu> i dont know how to comment this 14:34:42 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #7424: Add: Kdtree for AirportGetNearestTown https://git.io/fjU1d 14:35:00 <peter1138> Let's see what monstrosity you came up with. 14:35:34 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #7424: Add: Kdtree for AirportGetNearestTown https://git.io/fjUFp 14:37:34 *** Wormnest has joined #openttd 14:43:55 <peter1138> Oh. You know what... 14:43:59 <peter1138> Noise level isn't saved anyway. 14:44:09 <peter1138> So you really don't need to replicate that behaviour. 14:45:27 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7424: Add: Kdtree for AirportGetNearestTown https://git.io/fjUbs 14:47:18 <Samu> im trying to figure out why t can be NULL at times 14:57:00 <Samu> ah, i understand 14:57:05 <Samu> lol i'm stupid 14:59:04 <Samu> that threshold 15:01:37 <Samu> does the iterator really need to be copied? 15:04:57 <Eddi|zuHause> if i want to introduce the dreaded R-word to the discussion: sometimes a big city's demands for airports should allow to override the noise level requirement for a small nearby town 15:05:43 <peter1138> Samu, currently yes, because it's used again. 15:05:59 <Samu> ok 15:07:03 <peter1138> Eddi|zuHause, sure, but this change is meant to be just an optimization, not a feature change. 15:07:22 <Eddi|zuHause> when did that ever stop me? :p 15:08:15 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #7424: Add: Kdtree for AirportGetNearestTown https://git.io/fjU1d 15:08:43 <Samu> the function changed 15:08:58 <Samu> it was already described after all that it would prefer the lowest index 15:09:02 <Samu> now it doesn't 15:09:17 <peter1138> Hmm, I didn't notice that comment :p 15:09:23 <peter1138> Well, maybe you should keep the behaviour. 15:09:32 <Samu> oh ... :) 15:09:39 <peter1138> Just drop that last commit. 15:09:54 <Samu> still need to remove the @param as 15:09:59 <peter1138> And yeah, if it already says "town with lower index is returned" then don't worry about the comment. 15:10:02 <peter1138> Yeah. 15:10:26 <peter1138> What's the performance benefit you saw? 15:10:34 <peter1138> (Hard figures, not relative, please) 15:12:22 <Samu> with industries and valuators.... about 15 ms avg 15:12:36 <Samu> with industries... about 8 ms 15:12:55 <Samu> without industries... 2 ms 15:13:24 <Samu> without industries and that fix in the code... 1 ms 15:13:30 <Samu> sometimes less 15:14:44 <Samu> FOR_ALL_INDUSTRIES is my next target 15:16:07 <peter1138> Uh, what? 15:16:24 <peter1138> I mean the performance benefit of that chance. 15:16:26 <Samu> I tested using my own AI 15:16:39 <peter1138> *change 15:16:54 <Samu> went from 2 ms to 1ms 15:16:56 <Samu> a bit less 15:16:59 <Samu> than 1 15:17:16 <Samu> no hard figure i guess 15:17:24 <Samu> will try with TIC TOC thing, maybe? 15:18:03 <peter1138> With 12000 towns or so? 15:18:14 <Samu> yes 15:18:17 <Samu> 4096x4096 map 15:18:23 <Samu> and 20480 industries 15:18:36 <peter1138> Industries don't affect AirportGetNearestTown 15:19:01 <Samu> oh, right 15:19:08 <Samu> forgot you don't care about that 15:19:34 <LordAro> there's no way measurements of <5ms are stable enough to draw any conclusions from 15:19:40 <Samu> Get Cargo Production around tiles iterates over all industries, the main stutter cause 15:19:47 <LordAro> unless you're measuring them hundreds (or better, thousands) of times 15:20:39 <peter1138> LordAro, indeed. 15:20:50 <peter1138> Samu, I can improve that easily, if you want to wait. 15:21:09 <Samu> I wait 15:21:13 <_dp_> is there a way to make mouse feel the same in fullscreen as in windowed with sdl driver? 15:21:28 <_dp_> I used SDL_MOUSE_RELATIVE=0 but it seems broken now :( 15:21:51 <peter1138> Does it not? 15:22:31 <peter1138> Samu, update that existing PR and I've got another (minor) improvement to PR. 15:22:55 <Samu> speaking of mouse, yesterday I had a weird mass popups about an assert related to mouse cursor 15:23:31 <Samu> it felt like I was visiting a broken site 15:23:32 <peter1138> I never bothered optimising GetProductionAroundTiles because it was a GUI-only thing, but I guess as the AI uses it as well, that matters. 15:23:46 <Samu> couldn't reproduce it 15:24:10 <Samu> always poping up error windows 15:24:30 <Samu> had to kill visual studio in the task manager 15:28:19 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #7424: Add: Kdtree for AirportGetNearestTown https://git.io/fjU1d 15:31:10 <Samu> now, measuring 15:31:13 <Samu> hmm 15:31:21 <Samu> TIC TOC, lets see 15:46:06 <Samu> i fail at using tic toc 15:56:38 <peter1138> Yeah? Don't bother :p 16:00:20 <Samu> hah, it's actually slower on smaller maps 16:00:27 <Samu> oh gosh :( 16:03:13 *** crem1 has joined #openttd 16:04:23 <Samu> https://imgur.com/XxHWxXC 16:04:32 <Samu> ok here's a good "test" 16:04:43 <Samu> 4096x4096, about 12k towns, no industries 16:04:53 <Samu> and no valuators on thos 16:04:57 *** crem has quit IRC 16:04:59 <Samu> those* 16:05:10 <Samu> 250000 ops 16:07:26 <peter1138> Slower on smaller maps often means "unnoticable is still unnoticable" 16:14:11 <Samu> voronoi would be faster, right? 16:16:10 <peter1138> Well, how much slower are you talking? 16:24:00 *** synchris has joined #openttd 16:25:41 *** Progman has joined #openttd 16:29:25 *** nielsm has joined #openttd 16:32:48 <Samu> brb, let me put a small map 16:32:59 <Samu> 64 x 64 or so? 16:33:03 <Samu> 128 x 128? 16:37:17 <Samu> gonna try the average 256 x 256 or 256 x 512 16:38:59 <Samu> yep... it's slower :( 16:39:55 <Samu> https://imgur.com/DHb0RNI 16:40:14 <Samu> rip kdtree 16:42:01 <peter1138> Yeah but doing what? 16:42:32 <Samu> 256 x 256 16:43:43 <Samu> https://imgur.com/uVbxC9o 512x512 16:43:45 <Samu> also slower 16:44:40 <nielsm> slower doing what? 16:45:05 <Samu> iterating over ... uhm,, wait, i better upload v10 16:46:22 <peter1138> Yes. That's just a map size. What are you actually DOING. 16:46:44 <Samu> sec 16:47:03 <_dp_> communicating with Samu is slower than ever for sure xD 16:47:18 <peter1138> It's bizarre isn't it? 16:50:03 <Samu> https://github.com/SamuXarick/LuDiAI-AfterFix/blob/master/WrightAI.nut#L880 16:50:13 <Samu> from line 880 to 1008 16:50:48 <Samu> line 912 is the slowest 16:50:54 <Samu> if there are industries 16:52:18 <Samu> then line 955 or line 956, it's one of them, is the 2nd lowest, the case we're testing here 16:52:27 <Samu> 2nd slowest* 16:53:00 <Samu> there are no industries on these tests, i'm testing on maps without them 16:55:27 <Samu> owell 16:56:06 <Samu> up to below 2048x2048 the kdtree is slower, past 2048x2048, it is faster 16:56:10 <Samu> t.t 16:56:13 <Samu> rip PR 16:56:17 <Eddi|zuHause> <_dp_> is there a way to make mouse feel the same in fullscreen as in windowed with sdl driver? <-- what do you mean? 16:56:19 <peter1138> That doesn't make sense. 16:56:42 <peter1138> Map size is not particularly relevant, but number of towns is. 16:56:46 *** Supercheese has joined #openttd 16:56:52 <Samu> ah, you want the number 16:57:01 <Samu> @calc 12k / 4 16:57:01 <DorpsGek> Samu: Error: invalid syntax (<string>, line 1) 16:57:04 <Samu> @calc 12 / 4 16:57:05 <DorpsGek> Samu: 3 16:57:08 <Samu> 3k towns 16:57:46 <_dp_> Eddi|zuHause, when I switch to fullscreen mouse gets much slower, feels very awkward :( 16:58:07 <Eddi|zuHause> slower as in acceleration? 16:58:16 <Eddi|zuHause> or drawing of the pointer is choppy? 16:58:18 <Eddi|zuHause> or what? 16:58:30 <_dp_> Eddi|zuHause, moves slower 16:58:48 <Samu> https://imgur.com/ArJdueq 2048x2048 16:58:54 <Samu> so much PR for nothing 16:59:23 <Eddi|zuHause> _dp_: what OS? 16:59:28 <_dp_> Eddi|zuHause, linux 17:00:02 <_dp_> Eddi|zuHause, SDL_MOUSE_RELATIVE=0 helps but it seems to interfere with gnome somehow 17:00:06 <Samu> and then the glorious 4096x4096 result with the most relevant gains 17:00:09 <Eddi|zuHause> resolution change? 17:00:36 <Samu> https://imgur.com/XxHWxXC 17:03:05 <Samu> i really should stop testing stuff in 4k maps first 17:03:15 <Samu> it was the first thing I did 17:03:49 <_dp_> Eddi|zuHause, same on any resolution 17:03:57 <_dp_> Eddi|zuHause, it's a gnome issue I guess 17:04:19 <Eddi|zuHause> yeah, i'd look in gnome settings 17:04:20 <_dp_> Eddi|zuHause, seems to intercept mouse events as if there is top panel and dock 17:04:50 <Eddi|zuHause> i don't use gnome, so i can't help you there 17:06:40 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #7424: Add: Kdtree for AirportGetNearestTown https://git.io/fjUhE 17:07:49 *** HerzogDeXtEr has joined #openttd 17:08:11 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7424: Add: Kdtree for AirportGetNearestTown https://git.io/fjUhz 17:15:22 <Samu> you mean the borders nielsm ? 17:16:35 <nielsm> I mean instead of calculating nearest town to 100 tiles and taking the lowest distance, just calculate nearest town the the one single tile in the center of the airport area 17:16:42 <nielsm> it's 100 times less work 17:16:58 <nielsm> (assuming a 10x10 tile airport size) 17:18:14 <Samu> i was thinking about something similar, but for the perimeter tiles 17:18:15 <Eddi|zuHause> that would allow large airports in a lot more places, i think 17:18:19 <Samu> not the centre 17:18:27 <_dp_> ok, installing nvidia drivers fixed the mouse issue 17:18:34 <_dp_> I forgot it's using nouveau by default 17:18:49 <nielsm> yeah searching just the corner tiles of the tile area bounding box could be another option perhaps? 17:19:04 <Samu> no, corners nop 17:19:27 <Eddi|zuHause> non-rectangular areas might not have a "corner"? 17:19:35 <nielsm> but at least the interior tile should not be relevant, unless you're demolishing an entire town centre and replacing the entire town with airport 17:19:56 <nielsm> Eddi|zuHause: hence why I said tile area _bounding box_ 17:20:38 <Eddi|zuHause> that sounds like a step backwards 17:20:41 <_dp_> or it didn't... weird, seemed fine at first :p 17:20:44 <_dp_> :( 17:22:03 <Eddi|zuHause> _dp_: just a random thing: does enabling/disabling "full animation" change anything? 17:22:42 <nielsm> unless there's really weirdly shaped airports like this anywhere? https://0x0.st/zKI9.png 17:22:58 <_dp_> Eddi|zuHause, no 17:23:56 <Eddi|zuHause> nielsm: if we ever get around to adding state machines, i would expact such things to appear 17:25:36 <Eddi|zuHause> nielsm: but i'd be primarily worried about things like diagonal airports, where the "bounding box corners" are really far away from the actual airport 17:27:23 <Eddi|zuHause> nielsm: i know we joked a lot about "vision" lately, but that's exactly the point where you need a vision to not introduce these arbitrary limitations 17:30:29 <nielsm> otherwise, keep the original algorithm, but limit the number of towns considered to those inside a bounding box of candidates 17:30:54 <nielsm> isn't there a strict limit to the distance to town sign where airport noise is considered? 17:31:19 <Eddi|zuHause> not that i know of 17:31:39 <_dp_> Eddi|zuHause, weird stuff, sometimes it's broken sometimes it's fine, and sometimes it switches to wrong resolution %) 17:34:42 <peter1138> Samu, so, are you using a debug build by any chance? 17:35:08 <Samu> no, those tests were on release x64 17:39:09 <Samu> there is a DiagonalTileIterator in the code 17:41:58 <peter1138> Urgh, regression fail :/ 17:42:16 *** glx has joined #openttd 17:42:16 *** ChanServ sets mode: +v glx 17:42:16 <peter1138> Now, is that because my test it wrong now, or wrong before? 17:42:30 <_dp_> btw, getting closest town for each tile in area can be done significantly faster than just querying k-d tree for each tile independently 17:44:37 *** supermop_work has joined #openttd 17:49:39 <Eddi|zuHause> yeah, i imagine if you know the bucket for one tile, you can quickly check if the neighbouring tile is in the same bucket 17:50:00 <peter1138> Ok, regression fails because it was wrong before :p 17:50:45 <Eddi|zuHause> "just because you've done something for years, doesn't mean you've been doing it correctly" 17:51:26 <peter1138> That means this codechange: becomes a fix: 17:56:12 *** andythenorth has joined #openttd 18:05:04 <Eddi|zuHause> nielsm: btw, can you have a look at https://github.com/OpenTTD/OpenTTD/pull/7051 how to incorporate the last commit into the signs kdtree? 18:05:18 *** supermop_work_ has joined #openttd 18:06:34 <nielsm> Eddi|zuHause: basically the same pattern as the other four types of viewport signs 18:08:08 <Eddi|zuHause> nielsm: since it's not actually my patch, i was a bit lost on trying to decipher that stuff 18:10:44 <Samu> im experimenting the perimeter stuff 18:10:46 <Samu> if (IsInsideMM(TileX(cur_tile), TileX(it), TileX(it + delta_x) + 1) || IsInsideMM(TileY(cur_tile), TileY(it), TileY(it + delta_y) + 1)) { 18:10:57 <Samu> don't know if this is the correct checking 18:11:11 *** supermop_work__ has joined #openttd 18:12:17 *** supermop_work has quit IRC 18:12:43 *** supermop_work has joined #openttd 18:14:00 <Samu> how do i get the max X and max Y allowed? 18:14:09 <Samu> must not go over it 18:18:12 *** supermop_work_ has quit IRC 18:18:43 <Samu> TileX(min(it + delta_x, MapMaxX())) + 1) 18:18:49 <Samu> great :) 18:20:12 *** supermop_work__ has quit IRC 18:21:07 <peter1138> I have a Samu problem. 18:21:14 <Samu> hum? :( 18:21:16 <peter1138> I can't come up with a nice concise commit message. 18:21:30 <LordAro> Fix: The things 18:21:45 <Samu> oh you're asking to a terrible person for that 18:22:39 *** supermop_work_ has joined #openttd 18:23:07 *** Pikka has quit IRC 18:25:16 <peter1138> Funny though. 18:25:25 <peter1138> This is a fix from your comment last night. 18:25:51 <peter1138> 01:25 < Samu> line 529 station_cmd.cpp 18:26:08 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN opened pull request #7426: Fix: Incorrect display of industry production around tiles. https://git.io/fjUj9 18:26:40 *** supermop_work__ has joined #openttd 18:27:51 *** supermop_work has quit IRC 18:29:37 *** supermop_work has joined #openttd 18:31:30 <peter1138> Samu, so that might be quicker. 18:32:08 <DorpsGek_II> [OpenTTD/OpenTTD] stale[bot] commented on issue #7042: Use intrinsics for bit twiddling? https://git.io/fjUjx 18:33:12 *** supermop_work_ has quit IRC 18:33:46 <peter1138> But it should also be correct now. 18:33:52 <peter1138> Hence the regression change. 18:34:12 <Samu> im terrible math 18:34:58 *** andythenorth has quit IRC 18:35:44 *** frosch123 has joined #openttd 18:36:56 *** supermop_work__ has quit IRC 18:37:11 <Samu> IsInsideMM(TileY(cur_tile), TileY(it), min(TileY(it) + delta_y, MapMaxY()) + 1) 18:38:41 *** supermop_work has quit IRC 18:38:47 <Samu> TileY(it) + delta_y VERSUS MapMaxY() 18:38:54 <Samu> it gets the minimum of both 18:39:20 <Samu> then adds +1 because IsInsideMM is [ , ) 18:39:25 *** supermop_work has joined #openttd 18:45:59 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN opened pull request #7427: Codechange: Distance between town and airport has already just been found, so use it. https://git.io/fjTeL 18:46:03 <peter1138> ^^ PR no. 2 18:46:13 <peter1138> Er, well, No 7427, I guess. 18:46:25 <peter1138> 18:46, I ought to get ready for trail biking. 18:46:53 <peter1138> Samu, please test #7426 and #7427 (preferably together...) 18:47:46 <Samu> ok 18:49:06 <nielsm> btw my tip for testing multiple patches together: make a new branch from master, then merge (don't bother with rebase) both to-test branches into that branch 18:49:17 <nielsm> makes for the easiest cleanup afterwards 18:50:07 <Samu> my IsInsideMM test is not working damn it :p 18:50:08 <glx> cherry-pick works too if there's one commit per PR :) 18:50:24 <peter1138> *nod* 18:50:31 <Samu> i'm so terribad, and all I want is the perimeter tiles 18:50:37 <peter1138> Also, maybe other people here can test and review those two PRs? :-) 18:50:59 <Samu> apparently, I'm getting all tiles 18:51:11 <Samu> the test is useless like that lol 18:52:09 <peter1138> You need the dimensions of the tilearea. 18:52:41 <Samu> AirportSpec is back in action 18:53:54 *** supermop_work_ has joined #openttd 18:53:57 <peter1138> You need the start tile, and the x & y, and then add 1 to TileX(tile) and subtract... 2 (probably) from x. 18:54:00 <peter1138> Same for Y. 18:54:29 <peter1138> AirportPerimeterTileIterator? :p 18:54:37 <Samu> yes, I want that 18:55:35 <Samu> the start tile is it 18:55:52 <peter1138> You can get that from the iterator (before you use it) 18:55:54 <Samu> or at least I assume all airport tables start tile is 0, 0 18:55:57 *** gelignite has joined #openttd 18:56:12 <peter1138> But you should be predetermining these before the loop. 18:56:27 <peter1138> I don't see why layouts would not start at 0, 0 18:56:52 <glx> would be highly unlogical to not start at 0,0 18:57:17 <peter1138> Hmm, well, I guess I better go. 18:57:35 <peter1138> I gave Samu 10 minutes to quickly test my two PRs for performance but he didn't bother cos he's stuck. I love it. 18:57:45 <Eddi|zuHause> can layouts have negative coordinates? 18:58:02 <Eddi|zuHause> because 0,0 might not be part of the layout for diagonal stuff 18:58:16 <Samu> i will test later, visual studio doesn't let me change branch atm, and yeah I'm stuck 18:58:41 <Eddi|zuHause> (i think we had that discussion a few weeks ago with industries) 18:58:52 <Samu> yes 18:59:01 <Samu> oil rigs 18:59:04 <Samu> for example 18:59:42 <peter1138> Eddi|zuHause, andy complained it was not centered, so I made it centered, then he said it wasn't actually any better. 19:00:06 <glx> in the spec "Offsets counted from the northernmost tile of the airport, specifying the position of the current tile. Both are taken as signed integers, but cannot go negative except the special case mentioned below." 19:00:16 <glx> and negative is only for clearance checks 19:00:52 *** supermop_work has quit IRC 19:01:09 *** supermop_work has joined #openttd 19:02:21 <Eddi|zuHause> the problem with diagonal airports will be that the (0,0) origin point will be quite far from the actually built airport 19:02:45 <Eddi|zuHause> (and i'm assuming that also will be a problem with the station sign) 19:03:30 <Eddi|zuHause> so i think it would be beneficial to allow moving the origin point away from (0,0) 19:04:20 <Eddi|zuHause> industries have the additional problem that you don't see the layout size 19:05:43 <peter1138> Well, it's possibly to offset the origin but at the point where Samu is, it would already have been applied. 19:05:58 <Eddi|zuHause> also, andy's industry problem might have been overlapping with the water class issue 19:06:03 *** supermop_work_ has quit IRC 19:14:41 *** supermop_work_ has joined #openttd 19:15:36 *** Laedek has joined #openttd 19:17:07 *** supermop_work__ has joined #openttd 19:17:44 <Samu> https://paste.openttdcoop.org/pwumtlbr3 testing if this works 19:18:26 <Samu> i hope that is the perimeter 19:22:06 *** supermop_work has quit IRC 19:23:23 <Samu> wow, it's faster indeed 19:23:30 <Samu> now I hope it's also correct 19:24:37 *** supermop_work_ has quit IRC 19:25:13 *** m3henry has joined #openttd 19:25:32 <m3henry> ls 19:27:31 <Samu> grr, i'm forced to commit damn it 19:32:44 <Samu> assert(kdtree == forall); 19:32:46 <Samu> testing 19:40:21 <Samu> no asserts so far, so im gonna assume it's "working" 19:40:44 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #7424: Add: Kdtree for AirportGetNearestTown https://git.io/fjU1d 19:42:13 *** supermop_work has joined #openttd 19:47:34 *** supermop_work_ has joined #openttd 19:49:48 *** supermop_work__ has quit IRC 19:55:18 *** supermop_work has quit IRC 20:02:51 *** rocky11384497 has quit IRC 20:03:15 *** andythenorth has joined #openttd 20:03:41 <Samu> about 7426, I thought that was a feature 20:05:51 <Samu> a change like that will surely affect competitive servers 20:05:54 <Samu> but ok 20:06:44 *** andythenorth has quit IRC 20:10:03 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #7424: Add: Kdtree for AirportGetNearestTown https://git.io/fjTvy 20:10:26 <Samu> there was a gain 20:12:15 *** andythenorth has joined #openttd 20:13:46 <andythenorth> yo 20:14:08 *** andythenorth has quit IRC 20:14:16 *** supermop_work has joined #openttd 20:14:57 <Samu> hi 20:21:17 *** supermop_work_ has quit IRC 20:37:22 *** supermop_work_ has joined #openttd 20:44:21 *** supermop_work has quit IRC 20:54:32 *** synchris has quit IRC 21:01:11 *** rocky11384497 has joined #openttd 21:14:21 *** gelignite has quit IRC 21:20:44 <Samu> #7246 results in about 1/4 of the time 21:21:04 <Samu> was averaging 800 ms, now it's about 220 21:28:38 *** supermop_work has joined #openttd 21:30:21 *** stormcone has joined #openttd 21:30:47 *** supermop_work has quit IRC 21:30:50 <stormcone> hi 21:30:53 <Samu> hi 21:31:27 <Samu> #7247 results aren't noticeable... seems to be equal to master 21:32:18 <Samu> 230 ms vs 230 ms 21:32:30 <Samu> let me recheck what my AI do 21:32:51 <stormcone> I am trying to update my personal openttd "patch pack" after the SmallVector replacement, but i have some problem with the SmallMap's Erase function 21:35:11 <stormcone> I am that familiar with C++, but now I am at the point where I would like to know whether is the function working as it is intended? 21:35:46 <Eddi|zuHause> can you be more specific? 21:36:06 *** supermop_work_ has quit IRC 21:37:47 <stormcone> I have a SmallMap, from I trying to delete an element like: map.Erase(key); 21:37:53 <frosch123> there are two methods. one which takes a "Pair*"-iterator, one which takes a key value 21:38:19 <stormcone> but I get a quite long compiling error 21:38:40 <LordAro> can't help you without a) the code b) the error 21:38:47 <frosch123> hmm, oh, i agree, that ERase is weird 21:38:57 <frosch123> it says it takes a key, but acutally it uses a value-pair 21:39:33 <LordAro> Eddi|zuHause: i've activated the centre node :> 21:39:39 <stormcone> i think the main problem from the error log is: error: no match for ‘operator==’ 21:39:50 <stormcone> (operand types are ‘SmallPair<Vehicle*, bool>’ and ‘Vehicle* const’) 21:39:51 <Eddi|zuHause> LordAro: i haven't tried yet since last time... 21:40:00 <stormcone> { return *__it == _M_value; } 21:40:15 <LordAro> Eddi|zuHause: i tried after managing to create a portable oxygenator 21:40:21 <Eddi|zuHause> LordAro: i was testing a theory involving the glowing orbs you find around, but wasn't getting anywhere with it 21:40:32 <LordAro> and finding that they're completely useless as they drain *all* the power 21:40:38 <frosch123> Erase(const T &key) must be unused in ottd code. it does something different than before, and it kind of makes no sense :p 21:40:42 *** andythenorth has joined #openttd 21:41:01 <stormcone> so I rewrite it for myself, but I wanted to be sure, whether that the code in the repo is correct or not 21:41:14 <LordAro> stormcone: if it's a map of your own creation, i'd recommend just switching to use std::map instead :) 21:41:16 <Samu> peter1138, I think you made a mistake here: mindist = UINT_MAX - add; // prevent overflow 21:41:34 <Eddi|zuHause> LordAro: i wasn't at that point yet. it was either looking around on the planet for another piece of processed scrap, or flying to another planet to get iron 21:41:53 <Samu> you want to reuse mindist, but you start all over instead 21:41:54 <stormcone> no, it's not mine 21:42:15 <LordAro> stormcone: maybe you should try converting it anyway :p 21:42:29 <LordAro> unless m3henry gets there first 21:42:46 <frosch123> so, delete Erase? 21:43:04 <frosch123> it compares a pair with a key, which never compiles, so the function must be unused 21:43:54 <LordAro> Eddi|zuHause: mm, i think i'm a bit ahead of you then :) 21:43:55 <Eddi|zuHause> "delete erase" is a strange phrase... it might be one of those recursions that destroy the universe :p 21:44:19 <Eddi|zuHause> LordAro: it's not like i'm progressing fast at 6fps anyway 21:44:24 <LordAro> Eddi|zuHause: ono 21:44:32 <stormcone> i modified it, so now uses it's own find() to find a pair, and then using the erase(pair) function to actually delete the item 21:44:33 <Samu> or i dunno what i'm looking at t.t 21:45:13 <frosch123> that also works :) 21:46:18 <stormcone> okay, so should i make a pr about it? or what are you planning to do with that function? :) 21:46:31 <LordAro> frosch123: confirmed, no compile issues if i remove the function 21:47:10 <LordAro> stormcone: PR fixing it would be lovely. long term SmallMap will be removed in favour of std::{unordered_,}map, but not sure how long that will be 21:47:44 <stormcone> ok, i will do it 21:48:05 <frosch123> LordAro: "long term" would mean "flat_map" :p 21:49:35 <LordAro> frosch123: you're thinking longer term than me :p 21:50:08 <LordAro> depends what sort of performance is required for the particular usages, i imagine :p 21:51:05 <Samu> about my perimeter check, what happens if the town is inside the perimeter 21:51:52 <Samu> and another town is just next door to one of the sides 21:52:07 <Samu> it would get the wrong town, right? 21:54:31 <Eddi|zuHause> Make The Map Round Again 21:55:11 <DorpsGek_II> [OpenTTD/OpenTTD] stormcone opened pull request #7428: Fix #7165: SmallMap::Erase(key) does not work correctly https://git.io/fjTUY 21:56:24 *** sla_ro|master has quit IRC 21:56:29 <stormcone> btw thank you for the help :) 22:04:10 *** andythenorth has quit IRC 22:05:39 <Eddi|zuHause> i'm not sure i understood the difference between the old and the new code 22:07:05 <Samu> TownID ScriptAirport::GetNearestTown 22:07:45 <Samu> AIs could be dumb enough to call this in a place where a town is inside the box 22:07:56 <Samu> openttd code doesn't seem to do this though 22:08:01 <Samu> but AIs... could 22:09:25 *** frosch123 has quit IRC 22:09:34 <Samu> RIP perimeter check 22:12:07 *** nielsm has quit IRC 22:19:17 <peter1138> Hi 22:20:56 <Samu> i thought kdtree was fast 22:21:00 <Samu> :( 22:21:05 <Samu> bring back voronoi 22:24:15 <Samu> https://paste.openttdcoop.org/piojqoyk3 so my main.nut now does this only 22:28:00 <peter1138> Sounds useful 22:28:44 <Samu> AIAirport.GetNearestTown(AIBase.RandRange(alltiles), AIAirport.AT_INTERCON); 22:28:49 <Samu> less bias 22:31:43 <peter1138> Ah yes, 7427 is barely noticable, but does eliminate a pointless loop. 22:31:47 <Samu> wow microsoft edge doing popups about microsoft services... :( 22:31:55 <peter1138> Just not as expensive as I was thinking. 22:32:11 <peter1138> 7426... 1/4 the time? Interesting. 22:33:09 <peter1138> 20:05 < Samu> a change like that will surely affect competitive servers 22:33:36 <Samu> yeah, those that run against the clock 22:33:40 <peter1138> Which bit did you think was a feature? 22:34:07 <peter1138> It was wrong since the new station catchment rules. 22:34:10 <Samu> 1 tile difference is all that matters for a station getting 1 or 2 coal mines 22:34:13 <_dp_> wait a sec, what change? :) 22:34:24 <Samu> faster start vs slower start 22:34:35 <_dp_> start of what? 22:34:43 <Samu> start of your company 22:35:10 <Samu> getting rich faster 22:35:12 <Samu> lel 22:35:41 <_dp_> as long as it doesn't lag who cares 22:35:57 <peter1138> Samu, the change was already made 22:36:07 <Samu> oh no :( 22:36:24 <peter1138> this bit of code is only used for displaying in the ui (and by AIs to find produced cargo) 22:36:57 <Samu> is this in 1.9? 22:37:01 <peter1138> So this function would have said a station at a tile could receive cargo from an industry, but actually it won't 22:37:04 <peter1138> no 22:37:38 <peter1138> But I think you misunderstand it :-) 22:40:39 <_dp_> is this all about non-rect catchment? 22:40:44 <peter1138> Yup 22:40:59 <_dp_> %) 22:41:06 <_dp_> how is it even relevant to company start 22:42:12 <peter1138> I don't know what Samu is talking about :-) 22:42:16 <_dp_> well, I guess if you start with pax and your rv station extensions now get sligtly less area for your train station... 22:42:26 <_dp_> but I'm switching all to 4 tile catchment anyway 22:43:08 <peter1138> http://fuzzle.org/~petern/ottd/catchment5.png < master 22:43:18 <peter1138> http://fuzzle.org/~petern/ottd/catchment6.png < #7426 22:43:23 <Samu> https://imgur.com/QoLDjd6 <-> https://paste.openttdcoop.org/pizf1oyp4 22:43:37 <peter1138> _dp_, modified catchment off? nice. 22:44:22 <_dp_> peter1138, yeah, realistic catchment or whatever is it called 22:44:37 <m3henry> I think I give up on Nuking SimpleTinyEnum, too many use cases need the loose typing 22:44:43 <_dp_> having them different was kinda silly anyway on competitive servers 22:45:09 <peter1138> non-rect catchment makes it less "useful" anyway 22:45:58 <_dp_> peter1138, you mean need more extending stations now? 22:46:16 <_dp_> peter1138, for 7 tile stations doesn't matter :p 22:47:20 <Samu> now i need to assert stuff 22:47:21 <Samu> brb 22:48:09 *** rocky11384497 has quit IRC 22:48:32 *** rocky11384497 has joined #openttd 22:53:57 <Samu> waiting for an assert, afk 22:54:42 <Samu> perhaps i should test more than just Intercontinental 22:54:51 <Samu> nevermind, it just asserted 22:54:53 <Samu> :( 22:55:04 <Samu> --------------------------- 22:55:04 <Samu> Error! 22:55:04 <Samu> --------------------------- 22:55:04 <Samu> Assertion failed at line 2257 of d:\openttd\openttd github\openttd\src\station_cmd.cpp: forall == kdtree 22:55:04 <Samu> --------------------------- 22:55:06 <Samu> OK 22:55:07 <Samu> --------------------------- 22:55:09 <Samu> ouch 22:55:35 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7426: Fix: Incorrect display of industry production around tiles. https://git.io/fjTkL 22:56:48 <m3henry> Of course, I cant use std::unique_ptr, as `#include <memory>` gets lost, probably due to some macro clash 22:56:56 <m3henry> woop woop 22:57:20 <Samu> i wasn't meant to copy paste this much 22:58:09 <LordAro> m3henry: ...well you should probably resolve that... 22:59:26 <Samu> testing without perimeter now, brb 23:00:03 <Samu> wow also asserts 23:00:06 <Samu> this makes me sad 23:00:32 <LordAro> Samu: maybe you should try to understand the code, rather than just adding asserts wherever you feel like 23:02:05 <_dp_> LordAro, well, adding asserts is part of understanding code sometimes :p 23:02:26 <_dp_> probably shouldn't spam about it though 23:03:40 *** Progman has quit IRC 23:04:17 <DorpsGek_II> [OpenTTD/OpenTTD] michicc approved pull request #7423: Fix: MSVC warnings https://git.io/fjTkl 23:05:04 <DorpsGek_II> [OpenTTD/OpenTTD] michicc approved pull request #7426: Fix: Incorrect display of industry production around tiles. https://git.io/fjTk8 23:09:15 <Samu> i have no idea how kdtree works, I just trusted it 23:09:35 <DorpsGek_II> [OpenTTD/OpenTTD] glx22 merged pull request #7423: Fix: MSVC warnings https://git.io/fjU12 23:09:46 <m3henry> LordAro: Easier said than done :v 23:10:04 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN merged pull request #7426: Fix: Incorrect display of industry production around tiles. https://git.io/fjUj9 23:10:15 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on pull request #7423: Fix: MSVC warnings https://git.io/fjTku 23:10:22 <LordAro> gah, 30s too late 23:10:33 <LordAro> and it's wrong anyway 23:10:37 <peter1138> :-) 23:12:11 <glx> hehe IIRC x - base converts to signed 23:13:02 <LordAro> glx: i was reading the type signatures of base & size, not x 23:14:20 <Samu> @calc 43 + 2 23:14:20 <DorpsGek> Samu: 45 23:14:25 <Samu> @calc 40 + 11 23:14:25 <DorpsGek> Samu: 51 23:14:50 <LordAro> Samu: i rather hope you didn't need a calculator for those 23:15:10 <ST2> he was only making sure :D 23:15:17 <peter1138> assert(40 + 11 == 51) 23:15:53 <DorpsGek_II> [OpenTTD/OpenTTD] michicc updated pull request #7428: Fix #7165: SmallMap::Erase(key) does not work correctly https://git.io/fjTUY 23:16:54 <michi_cc> stormcone: Have a look at my update for #7428? 23:18:41 <Samu> interesting find 23:19:01 <Samu> ForAll is giving the wrong town 23:19:09 <Samu> Kdtree is correct 23:22:21 <Samu> i really need to make sure 23:23:30 <Samu> question, is tile 958 on a 64x64 map inside or outside the map? 23:23:52 <Samu> when i zoom to it, it seems to be one in the border, but could be wrong 23:23:58 <Samu> scrollto* 23:24:02 <glx> @calc 958/64 23:24:03 <DorpsGek> glx: 14.96875 23:24:36 <glx> @calc 14*64 23:24:36 <DorpsGek> glx: 896 23:24:38 <stormcone> michi_cc: i had look at it, but as i said earlier i am not that familiar with c++, so if you say that is better in that way, i probably will agree with you :) 23:24:49 <glx> @calc 958-896 23:24:49 <DorpsGek> glx: 62 23:25:26 <Samu> x = 62, y = 13? 23:25:28 <michi_cc> stormcone: I just noticed that Contains() const was wrong and I couldn't be bothered to create another PR. 23:25:34 <Samu> erm y = 14 23:26:25 <glx> yes not counting the void tiles 23:27:44 <glx> but if you want to be sure I think you can draw tilehighlight on the tile 23:28:31 <Samu> it's inside 23:28:43 <Samu> just scrolled to 957 and 959 23:28:48 <Samu> heh 23:29:10 <stormcone> michi_cc: i don't mind it, should i modify something in the PR's title? 23:29:20 <glx> oh and there's landscape info tool 23:29:40 <glx> should show coords of the clicked tile 23:30:18 <michi_cc> No need, but maybe somebody like m3henry can take a quick look. 23:30:32 <michi_cc> glx: Seen https://www.tt-forums.net/viewtopic.php?f=33&t=85021 ? 23:30:39 <Samu> town 1: x = 19, y = 12 23:31:00 <Samu> town 2: x = 22, y = 35 23:31:16 <Samu> it: x = 62, y = 14 23:31:29 <glx> oh old mingw doesn't work 23:31:59 <Samu> the Y lenght of the airport is intercontinental, 11 tiles 23:32:31 <Samu> 14 + 11 - 1 = 24 23:33:16 <Samu> @calc 62-19 + 14-2 23:33:16 <DorpsGek> Samu: 55 23:34:09 <Samu> oops 23:34:12 <Samu> @calc 62-19 + 14-12 23:34:12 <DorpsGek> Samu: 45 23:34:44 <Samu> @calc 62-22 + 35-14 23:34:44 <DorpsGek> Samu: 61 23:35:09 <Samu> @calc 62-22 + 35-24 23:35:09 <DorpsGek> Samu: 51 23:35:25 <Samu> @calc 62-19 + 24-12 23:35:26 <DorpsGek> Samu: 55 23:35:38 <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry commented on pull request #7428: Fix #7165: SmallMap::Erase(key) does not work correctly https://git.io/fjTIl 23:35:57 <Samu> town 1 is the closest 23:36:28 *** m3henry has quit IRC 23:37:13 <Samu> yep 23:37:22 <Samu> forall is giving the wrong town 23:37:25 <Samu> kdtree is correct 23:37:36 <Samu> who would have thought 23:38:55 <Samu> what to do now? 23:39:04 <glx> michi_cc: I redirected him to MSYS2, which works fine, MSYS is outdated and doesn't feel maintained 23:39:33 <LordAro> oh hey, it's that wiki page that i wrote 23:39:56 <glx> the MSYS2 page ? 23:40:05 <LordAro> yeah 23:40:19 <LordAro> ooh, that still lists --without-freetype 23:40:22 <Samu> how do I report a bug like this? 23:40:30 *** HerzogDeXtEr has quit IRC 23:40:40 <glx> I followed it when I installed MSYS2 :) 23:41:31 <glx> yeah wiki pages tends to be created, but not updated later ;) 23:42:29 <LordAro> :) 23:45:21 <DorpsGek_II> [OpenTTD/OpenTTD] michicc commented on pull request #7428: Fix #7165: SmallMap::Erase(key) does not work correctly https://git.io/fjTI1 23:47:58 <michi_cc> LordAro: Review/approve #7428? I should as I have a commit in it (even if GH lets me as it is not my PR). 23:57:19 <LordAro> michi_cc: not sure i understand why your commit is necessary 23:58:12 <michi_cc> The const overload of Find returns a std::vector<Pair>::const_iterator, the const overload of End does not. 23:58:41 <michi_cc> end (small e) OTOH does. 23:59:26 <Samu> this is really funny... they're both wrong!