Config
Log for #openttd on 29th December 2019:
Times are UTC Toggle Colours
00:00:47  <LordAro> oh i see - ua-parser.js is being blocked by ublock on chromium, that's why it's a bullet list rather than a OS dropdown
00:01:15  <glx> yeah we found the same for firefox
00:02:51  <LordAro> oh so you did
00:04:17  <glx> it's a silly block
00:09:27  <LordAro> https://github.com/easylist/easylist/pull/4493 found it
00:10:48  <glx> oh nice :)
00:11:10  <glx> but that's silly to block that for privacy, it's a local thing
00:12:19  <LordAro> yeah, trying to work out if i can dispute it
00:12:44  <LordAro> https://github.com/faisalman/ua-parser-js/issues/356 it's happened in the past too
00:41:33  <DorpsGek_III> [OpenTTD/website] LordAro opened pull request #128: Fix bullet styles and text over multiple lines https://git.io/JeNwQ
00:55:49  *** sla_ro|master has quit IRC
00:58:35  *** Wolf01 has quit IRC
01:07:27  *** tokai has joined #openttd
01:07:27  *** ChanServ sets mode: +v tokai
01:14:18  <glx> oh I should try using -c option of nmlc
01:14:20  *** tokai|noir has quit IRC
01:21:53  *** Pikka has joined #openttd
01:26:36  *** Andrew350 has quit IRC
01:35:03  *** Progman has quit IRC
02:01:35  *** snail_UES_ has quit IRC
03:07:33  *** D-HUND has joined #openttd
03:11:02  *** debdog has quit IRC
03:44:05  *** Laedek has quit IRC
04:03:11  *** glx has quit IRC
05:16:45  *** Wormnest_ has quit IRC
07:28:24  *** andythenorth has joined #openttd
07:33:21  <andythenorth> o/
07:35:44  <andythenorth> such nice trains pikka
07:43:35  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth commented on pull request #7852: Feature: Show the name of the NewGRF in the build vehicle window. https://git.io/JeNXJ
07:45:51  <DorpsGek_III> [OpenTTD/OpenTTD] andythenorth commented on pull request #7550: Add: Screenshot window (& simplify the about/help DropDown) https://git.io/JeNXk
07:50:28  <DorpsGek_III> [OpenTTD/nml] andythenorth commented on pull request #66: Add: allow use of switches and random switches as procedures https://git.io/JeNXq
08:10:11  *** Smedles has quit IRC
08:10:30  *** Smedles has joined #openttd
08:23:02  *** tokai|noir has joined #openttd
08:23:02  *** ChanServ sets mode: +v tokai|noir
08:29:55  *** tokai has quit IRC
08:35:34  <Pikka> thanks andythenorth :) o/
08:38:23  * andythenorth ruins Horse balance
08:38:35  <andythenorth> "need daylength" :D
08:39:11  <Eddi|zuHause> balance cannot possibly depend on daylength
08:40:10  <andythenorth> eh what?
08:40:14  <andythenorth> number of generations
08:40:21  <andythenorth> progression
08:40:28  <andythenorth> 'need to include my favourite trains'
08:41:49  <andythenorth> also hi Eddi|zuHause :)
08:49:37  *** nielsm has joined #openttd
08:57:42  <andythenorth> Pikka: early diesels is a right pain in the arse :)
08:57:49  <andythenorth> for pseudo-realism purposes
08:57:52  <andythenorth> so many of them :P
08:58:09  <Pikka> yes
08:58:42  <andythenorth> I think I just destroyed the 'one obvious choice' rule :P
09:07:39  <Pikka> the correct choice is always a Class 37
09:07:42  *** sla_ro|master has joined #openttd
09:07:43  <Pikka> I should draw one for UKRS3
09:09:04  <andythenorth> you should
09:09:12  <andythenorth> I have designed a set with no 47
09:09:17  <andythenorth> and now I am trying to jam one in :P
09:10:36  <andythenorth> without a deltic there's no room :D
09:22:53  <DorpsGek_III> [OpenTTD/nml] LordAro merged pull request #66: Add: allow use of switches and random switches as procedures https://git.io/JePq0
09:30:38  <andythenorth> thanks
09:48:56  *** Wolf01 has joined #openttd
09:56:29  <DorpsGek_III> [OpenTTD/website] TrueBrain approved pull request #128: Fix bullet styles and text over multiple lines https://git.io/JeN1o
09:56:35  <DorpsGek_III> [OpenTTD/website] TrueBrain merged pull request #128: Fix bullet styles and text over multiple lines https://git.io/JeNwQ
10:18:14  *** HerzogDeXtEr has quit IRC
10:33:53  *** Samu has joined #openttd
10:50:39  *** snail_UES_ has joined #openttd
10:51:33  <Samu> hi
11:00:19  *** Progman has joined #openttd
11:17:40  <andythenorth> Pikka: 2400hp freight engine 1988 (never built class 38).  Looks like a class 58, or a class 60? :)
11:17:55  <andythenorth> someone did this https://www.flickriver.com/photos/northernblue109/5768081105/
11:18:18  <andythenorth> but could have been different https://class37basher.blogspot.com/2011/03/british-rail-class-38that-never-was.html?m=1
11:18:52  <Pikka> well
11:19:04  <Pikka> I'm not much of a fan of the 58 :)
11:19:18  <Pikka> but I guess at least it's distinctive
11:20:53  <andythenorth> https://dev.openttdcoop.org/attachments/download/9566/bone_bone.png
11:20:57  <andythenorth> I don't much like the bone
11:21:21  <andythenorth> I could repurpose Flanders Storm
11:22:12  <Pikka> 60/92 style?
11:22:18  <andythenorth> I'll try
11:22:24  <andythenorth> anybody fancy adding a 'more info' window to vehicles, with a button from buy menu?
11:22:31  * andythenorth wants to add detailed historical notes :P
11:22:38  <andythenorth> we could also put the 'which newgrf' there :P
11:25:52  <Samu> openttd.exe!TileMatrix<unsigned __int64,4>::AllocateStorage(unsigned int)
11:26:00  <Samu> says I don't have the source of this
11:26:08  <Samu> source not available
11:35:13  <Samu> [External Code]
11:35:22  <Samu> why? i thought openttd was open
11:37:16  <nielsm> I've hit on some apparently bug with visual studio recently where it claims it doesn't have code/debug sylbols for things obviously part of the project
11:37:22  <nielsm> workaround was to do a full rebuild of everything
11:38:00  <Samu> https://imgur.com/LX7osvu
11:38:04  <Samu> ok, will try
11:47:39  <nielsm> great, now I'm down in decoding ECS GRFs with grfcodec because I can't figure out where the source is (if anywhere) and someone posts about this https://www.tt-forums.net/viewtopic.php?p=1228007#p1228007
11:48:48  <nielsm> but they've been kind enough to fill the GRF file with action 0C comments
11:51:41  <LordAro> pretty sure ECS isn't open source
11:52:21  <nielsm> yeah... creative commons Attribution-NonCommercial-NoDerivs 3.0 Unported
11:54:48  *** snail_UES_ has quit IRC
11:56:43  <nielsm> yep this matches what I suspected: https://0x0.st/zDF-.txt
11:57:03  <nielsm> defines first entry in cargo translation table as '0000' but does not define a cargo with that label
11:57:22  <nielsm> and then something returns that invalid cargo from a callback
11:58:56  <nielsm> so a bug in ECS, which may have been hidden by OTTD's industry code before the 16 in/out changes
11:59:00  <nielsm> so what
11:59:07  <nielsm> so what's the right thing to do...
12:00:17  <LordAro> ideally, nothing
12:06:24  *** snail_UES_ has joined #openttd
12:12:48  <Samu> woah, GetSnowLine() is called by a bunch of everything
12:15:18  *** snail_UES_ has quit IRC
12:16:02  <FLHerne> nielsm: Ask mb about it, surely?
12:17:05  <andythenorth> george
12:20:55  <Samu> how confusing is this
12:20:57  <Samu> 			_snow_line->highest_value = max(min((byte)MAX_SNOWLINE_HEIGHT, _snow_line->highest_value), table[i][j]);
12:20:57  <Samu> 			_snow_line->lowest_value = min(max((byte)MIN_SNOWLINE_HEIGHT, _snow_line->lowest_value), table[i][j]);
12:21:24  <LordAro> it's a clamp
12:22:28  <Samu> it's on GetSnowLine()
12:22:41  <Samu> yes, i need to clamp
12:23:19  <Samu> erm no, SetSnowLine(), my bad
12:32:24  <nielsm> hmm... the spec isn't entirely clear actuallt
12:32:35  <nielsm> https://newgrf-specs.tt-wiki.net/wiki/Callbacks#Decide_input_and_output_cargo_types_.2814B.2C14C.29
12:32:49  <nielsm> "return FFh as the last element to terminate the lists"
12:33:29  <nielsm> does that mean the literal return value before cargo table mapping (if applicable) should be FFh and only then does it terminate?
12:33:44  <nielsm> because I think possibly ECS thinks it can get away with returning any invalid cargo number
12:47:22  *** andythenorth has quit IRC
12:57:18  <michi_cc> nielsm: TTDpatch terminates on failed sprite lookup (not totally sure which cases that encompasses), getting a literal 0xFF or just reaching 2/3 values.
12:57:22  <michi_cc> nielsm: I.e. see https://github.com/ttdpatch/ttdpatch/blob/master/patches/newindu.asm#L4522
12:59:56  <nielsm> nah that seems to accept cargo numbers that resolve to cargolabels, for which there is no cargo definition
13:00:45  <nielsm> if the callback returns a cargo number, and that index in the cargo translation table is an invalid cargo, it just stuffs CT_INVALID into that position in the industry accepts table and continues
13:01:42  <michi_cc> Yeah, it will use whatever lookuptranslatedcargo returns, no questions asked.
13:02:13  <nielsm> and the issue here is that 16 in/out patch adds a check that the callback doesn't return duplicate CargoIDs
13:02:27  <nielsm> so if it returns CT_INVALID multiple times, then it becomes an error now
13:06:03  <michi_cc> I might be off the mark, but I think return CT_INVALID is necessary sometimes.
13:06:29  <michi_cc> If I understand TTDP right, the prop is always but into the data structure first, and according to the CB wiki page, bad things happen if your callback tries to add a cargo that is not in the prop.
13:07:05  <nielsm> the cargoes returned need to be in the accepts list for the industry type definition
13:07:23  <michi_cc> Which means in order to cancel out values from the prop, you must return invalid values, because nothing else writes to the industry struct.
13:07:30  <nielsm> what ECS does, as far as I can tell, is "blank out" cargoes in the accepts list it does not want
13:07:35  <nielsm> instead of shortening the list
13:07:39  <nielsm> probably simpler to code
13:08:38  <nielsm> so it makes an accepts list that goes FF 08 FF, instead of 08 FF FF
13:08:55  *** frosch123 has joined #openttd
13:09:01  <michi_cc> The callback does not allow shortening, the TTDPatch code simply exits when encountering 0xFF and will not clear our any remaing entries in e.g. industry.accepts.
13:09:02  <nielsm> by returning 00 08 00, instead of 08 FF
13:09:14  <nielsm> oh
13:09:46  <michi_cc> Check lines 4526/4527 to see what I mean.
13:11:25  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh opened pull request #7882: Fix: Workaround for NewGRFs returning invalid cargo indexes in CB https://git.io/JeNyT
13:12:00  <frosch123> the old industry code relies heavily on what is 1st, 2nd or 3rd cargo. so blanking out cargos is very different to reordering cargos into a shorter list
13:12:17  <nielsm> right, that too
13:15:28  <michi_cc> nielsm: Your PR will skip changeing i->produced_cargo[j]/i->accepts_cargo[j] now, won't it?
13:15:48  <frosch123> maybe put that into the comment? imo it's more helpful to state "we allow blanking cargos for old newgrf" instead of  "some weird newgrf does it, so ignore it"
13:16:41  <nielsm> michi_cc: the array is pre-filled with CT_INVALID before the callback
13:17:12  <michi_cc> Ah, yeah, that would do it :)
13:17:47  <michi_cc> Is this old code BTW, because technically it does not match TTDPatch then.
13:18:57  <frosch123> it's hard to guess what ecs stuff was developed against ttdp or ottd
13:19:04  <nielsm> https://github.com/OpenTTD/OpenTTD/blob/release/1.8/src/industry_cmd.cpp#L1729-L1753
13:19:21  <michi_cc> If you make CB 14B return <Cargo> 0xFF, TTDPatch will only overwrite i->accepts_cargo[0] and leave 1/2 alone.
13:20:31  <michi_cc> Ah, sorry, I take that back and claim the opposite :p
13:20:35  <frosch123> michi_cc: https://github.com/ttdpatch/ttdpatch/blob/master/patches/newindu.asm#L4514
13:20:44  <frosch123> yes, ttdp also blanks it
13:20:47  <michi_cc> I missed https://github.com/ttdpatch/ttdpatch/blob/master/patches/newindu.asm#L4514
13:20:51  <frosch123> :)
13:21:45  <michi_cc> Bloody indirect asm coding :p Why OR and not just a MOV as well?
13:22:37  <frosch123> clearly it does both :)
13:22:53  <frosch123> "or" for the first two, "mov" for the third
13:25:15  <michi_cc> Ah, somebody wanted to save a whole byte by using the "r/m16 OR imm8 (sign-extended)" form instead of the imm16 move encoding :p
13:25:25  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh updated pull request #7882: Fix: Workaround for NewGRFs returning invalid cargo indexes in CB https://git.io/JeNyT
13:25:37  <nielsm> better comments :)
13:26:36  <DorpsGek_III> [OpenTTD/OpenTTD] michicc approved pull request #7882: Fix: Workaround for NewGRFs returning invalid cargo indexes in CB https://git.io/JeNy3
13:26:45  <frosch123> really, there is a sign-extending or? but is it shorter than the sign-extending movsb?
13:27:45  <frosch123> hmm, it's not movsb... my assembly is too rusty
13:28:24  <michi_cc> Its movsx, but which according to https://www.felixcloutier.com/x86/movsx:movsxd has no immediate form.
13:28:40  <frosch123> ah :)
13:28:59  <frosch123> at least i got 4 out of 5 letters correct
13:30:36  <michi_cc> movsb is string move, especially if coupled with a rep
13:31:35  <frosch123> yes, my memory first arrived at "movsx" but then i thought i had to replace "x" with the size of the operation b/w/d
13:32:30  <frosch123> but the "x" meant "extend", not "wildcard"
13:36:47  <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 merged pull request #7882: Fix: Workaround for NewGRFs returning invalid cargo indexes in CB https://git.io/JeNyT
13:47:02  <frosch123> hmm, all console commands use some CC_xxx alias for coloring
13:47:18  <frosch123> yet i have difficulties mapping the profiler usage to the existing CC_xx
13:57:29  <DorpsGek_III> [OpenTTD/OpenTTD] frosch123 commented on pull request #7868: Feature: NewGRF callback profiling https://git.io/JeNyz
13:58:27  <frosch123> sun is out, bbl
14:13:11  *** Flygon has quit IRC
14:41:28  <DorpsGek_III> [OpenTTD/website] TrueBrain commented on pull request #127: Change: Do not limit section header to 500px https://git.io/JeNST
14:41:53  <TrueBrain> bad review LordAro :P :D
14:43:05  <Samu> i just discovered flat worlds also need to determine snow line height
14:43:12  <Samu> due to freeform edges being off
14:52:19  *** andythenorth has joined #openttd
14:52:25  <andythenorth> yo
14:58:02  <Pikka> YOYO
15:04:03  <LordAro> TrueBrain: ohno
15:04:32  <Pikka> andythenorth, Deltic is out. Class 66 is out. Gresley Pacifics are out, they've been done.
15:05:23  <andythenorth> class 50 with deltic engine
15:05:37  <Pikka> definitely out
15:05:44  <andythenorth> nah, I'm adding one
15:05:49  <andythenorth> my mail trains are too slow
15:06:07  <andythenorth> oof something about airports
15:06:18  <Pikka> flying deltics?
15:06:22  <andythenorth> maybe
15:06:30  <andythenorth> I don't understand the airports controversy
15:06:40  <andythenorth> are we supposed to be reverting it for 1.10 Beta 3?
15:07:18  <andythenorth> Pikka: deltic zellepin!
15:07:26  <andythenorth> that might even be a thing
15:10:04  <andythenorth> I searched deltic zeppelin and got this https://www.hemmings.com/blog/article/the-ultimate-weapon/
15:12:09  <Pikka> near enough!
15:19:50  <Pikka> bbbl
15:19:52  *** Pikka has quit IRC
15:24:47  <Samu> why do I have to make such gymnastics with values...
15:24:49  <Samu> https://pastebin.com/Kq7GbDvx
15:25:23  <Samu> flat_world_height can be 0
15:25:36  <Samu> 0 - 2 = -2, so it goes into (int) territory
15:27:11  <Samu> can I make less gymnastics with this code?
15:29:17  <frosch123> do people remember the old subsidiaries patch?
15:31:39  * andythenorth doesn't
15:31:43  <andythenorth> is it a good story? :)
15:32:34  <frosch123> there was drama about it never getting included. now reddit has reinvented it using hierarchical groups and group liveries
15:33:13  <frosch123> https://www.tt-forums.net/viewtopic.php?p=541578#p541578 <- i like that policy
15:34:20  <andythenorth> :D https://www.tt-forums.net/viewtopic.php?p=541952#p541952
15:34:31  <andythenorth> as examples of OpenTTD innovation
15:34:42  <andythenorth> all innovations are future regrets :D
15:35:03  <frosch123> nice finding :)
15:36:01  <andythenorth> right below yours :)
15:40:05  *** Progman has quit IRC
15:40:38  <Samu> who can review these comments
15:40:39  <Samu> https://pastebin.com/uLGGFvCu
15:40:45  <Samu> need help with commenting
15:43:03  <DorpsGek_III> [OpenTTD/OpenTTD] stormcone dismissed a review for pull request #7852: Feature: Show the name of the NewGRF in the build vehicle window. https://git.io/JeNLJ
15:43:03  <DorpsGek_III> [OpenTTD/OpenTTD] stormcone updated pull request #7852: Feature: Show the name of the NewGRF in the build vehicle window. https://git.io/JeMKL
15:45:13  <DorpsGek_III> [OpenTTD/OpenTTD] stormcone commented on pull request #7852: Feature: Show the name of the NewGRF in the build vehicle window. https://git.io/JeNSA
15:51:23  <andythenorth> :P https://dev.openttdcoop.org/attachments/download/9568/thunderbird-hst.png
15:53:53  <frosch123> does not look like horse. is that pikka?
15:56:18  <andythenorth> is moi
15:56:34  <andythenorth> very horse
15:58:17  <frosch123> ok, am i hard wired to "no tank car -> can't be horse"?
15:58:47  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh updated pull request #7868: Feature: NewGRF callback profiling https://git.io/JedSy
15:59:55  <Samu> or if you want to see it here: https://github.com/OpenTTD/OpenTTD/compare/master...SamuXarick:auto-determine-snow-line-height
16:00:10  <andythenorth> moar tank cars
16:00:22  <andythenorth> this fast compile is good eh?
16:00:31  <andythenorth> I can add trains so much faster :P
16:06:59  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on pull request #7868: Feature: NewGRF callback profiling https://git.io/JeN9k
16:08:17  *** snail_UES_ has joined #openttd
16:12:21  <Samu> https://github.com/OpenTTD/OpenTTD/pull/7877 this is haunting me :(
16:16:06  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh commented on pull request #7852: Feature: Show the name of the NewGRF in the build vehicle window. https://git.io/JeN9Y
16:18:53  <nielsm> (never stop bikeshedding)
16:19:24  <andythenorth> I have drawn a spectacularly ugly train
16:19:52  <andythenorth> due to trying to include this https://www.hornby.com/media/catalog/product/cache/1/image/550x/040ec09b1e35df139433887a97daa66f/r/3/r3659-colas-class-67.jpg
16:19:56  <andythenorth> which is unappealing
16:25:12  *** D-HUND is now known as debdog
16:27:06  *** Wormnest_ has joined #openttd
16:33:45  *** glx has joined #openttd
16:33:45  *** ChanServ sets mode: +v glx
16:34:47  <Samu> I have a serious haunting dilema, related to #7877. It's very rare that farms are generated at snowline=3, especially at small maps. Better chances are at snowline=4, but at this height it would make Very Flat more like Flat. But if I were to raise snowline to 4, that PR starts to make sense, it would never be able to generate at snowline=3, simplifying my code
16:34:54  *** debdog has quit IRC
16:35:56  <andythenorth> newgrf
16:35:57  <Samu> what I have now is farms that can have a ~1% chance to spawn on 64x64 maps
16:36:08  <andythenorth> just write a newgrf?
16:36:12  <andythenorth> then problem is solved?
16:36:24  <Samu> it's world gen related
16:36:31  *** debdog has joined #openttd
16:36:51  <Samu> with snowline=3
16:37:04  <nielsm> the solution is to not make bad maps
16:37:11  <nielsm> or tell the player they made a bad map
16:37:52  <andythenorth> just use the reddit solution
16:37:55  <andythenorth> load FIRS + ECS
16:38:00  <andythenorth> together
16:38:06  <nielsm> lol
16:38:08  <LordAro> heh
16:38:21  <Samu> on 128x128 maps, it fails too often than I'd like, especially considering I'm making a patch where it's supposed to be smart about it
16:38:39  <Samu> snowline=4 solves many headaches
16:39:17  <Samu> screw the PR
16:39:20  <Samu> make it 4
16:39:22  *** debdog has quit IRC
16:39:26  <Samu> even though it's possible at 3
16:41:59  <DorpsGek_III> [OpenTTD/OpenTTD] stormcone updated pull request #7852: Feature: Show the name of the NewGRF in the build vehicle window. https://git.io/JeMKL
16:43:44  <DorpsGek_III> [OpenTTD/OpenTTD] stormcone commented on pull request #7852: Feature: Show the name of the NewGRF in the build vehicle window. https://git.io/JeN90
16:44:57  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh approved pull request #7852: Feature: Show the name of the NewGRF in the build vehicle window. https://git.io/JeN9E
16:44:58  *** debdog has joined #openttd
16:51:11  *** Progman has joined #openttd
17:07:03  <Samu> now im getting the problem at the other side of the spectrum t.t
17:07:04  <Samu> forests
17:07:16  <Samu> 64x64 just too difficult
17:08:57  <nielsm> the default industry set was designed with the default map generator and 256x256 maps in mind, nothing else
17:09:13  <nielsm> when you change the rules you can't expect it to give good results
17:09:30  <Samu> I need to compromise to make this work well
17:11:15  <Samu> farms closer to snowline
17:12:07  <Samu> that would bring back snowline down to 3, meaning less height required, which is a good thing for such a small map
17:12:23  <Samu> more chances for forests to spawn
17:12:30  <nielsm> you're trying to drive a full size bus around a kids' traffic training playground
17:13:13  <Samu> hehe
17:13:15  <nielsm> either you'll hit something with the front end or you'll hit something with the back end, there just isn't enough space to maneuver
17:16:35  <Samu> LordAro also complained about 6 being too high for very flat
17:16:46  <Samu> i keep it at 6
17:16:53  <Samu> snowline kept at 3
17:17:06  <Samu> everybody is happy, except frosch
17:21:38  <Samu> arf, forests still fail most of the time with original generator, maybe with my other patch about water margins
17:24:30  *** spnda has joined #openttd
17:26:53  *** Progman has quit IRC
17:36:33  *** debdog has quit IRC
17:37:55  <DorpsGek_III> [OpenTTD/OpenTTD] spnda commented on pull request #7550: Add: Screenshot window (& simplify the about/help DropDown) https://git.io/JeNHw
17:43:39  *** debdog has joined #openttd
18:20:02  <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick opened pull request #7883: Fix: Ensure a minimum gap of water upon generating terrain with original generator https://git.io/JeNQn
18:29:48  *** Progman has joined #openttd
18:34:32  <Samu> automatically determined or determined automatically? what's better english
18:34:54  <Samu> Move the snow line height one down If set above maximum, the line is determined automatically
18:36:26  <Samu> determined or determinated :o
18:42:21  * andythenorth wonders
18:42:33  <andythenorth> could we squeeze hp/ton into the train info window? :P
18:42:55  <andythenorth> it's considerably more relevant than TE
18:44:16  <frosch123> we need an excel patch that allows you add custom columns to lists
18:48:14  <Samu> I'm scared to PR this... https://github.com/SamuXarick/OpenTTD/commit/24e9a4ca22b0834c27e3cb66244f417f3e3730d8
18:48:22  <Samu> won't touch it anymore
18:48:44  *** WormnestAndroid has quit IRC
18:48:58  *** WormnestAndroid has joined #openttd
18:57:12  *** supermop_Home has joined #openttd
19:27:43  <andythenorth> it's christmas!
19:27:56  * andythenorth writes back stories for all Iron Horse engines
19:30:03  <andythenorth> like Pikka http://pikka.users.tt-forums.net/wiki/index.php?title=Stanier_Jubilee
19:30:38  <andythenorth> hmm can I docstring methods? o_O
19:39:34  <Samu> oh no, some of my other PRs have conflicts because there was a savegame bump
19:42:29  <peter1138> OH NO!
19:42:44  <peter1138> At least they're easy to fix these days :p
19:43:06  <DorpsGek_III> [OpenTTD/website] auge8472 commented on pull request #113: Change: semantic HTML-elements for the pages main sections https://git.io/JeN5e
19:47:10  *** tokai has joined #openttd
19:47:10  *** ChanServ sets mode: +v tokai
19:52:27  <DorpsGek_III> [OpenTTD/website] auge8472 commented on pull request #122: Fix overflowing nav https://git.io/JeN5k
19:54:00  *** tokai|noir has quit IRC
19:56:47  <DorpsGek_III> [OpenTTD/OpenTTD] nielsmh approved pull request #7550: Add: Screenshot window (& simplify the about/help DropDown) https://git.io/JeN5C
19:59:02  <DorpsGek_III> [OpenTTD/website] LordAro commented on pull request #113: Change: semantic HTML-elements for the pages main sections https://git.io/JeN58
20:08:32  <DorpsGek_III> [OpenTTD/website] auge8472 commented on pull request #127: Change: Do not limit section header to 500px https://git.io/JeN56
20:10:39  <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick updated pull request #7661: Codechange: Rework 'start_date' parameter for AIs as a game setting https://git.io/fjMsZ
20:13:41  <Samu> only 1 conflict
20:16:26  <DorpsGek_III> [OpenTTD/website] auge8472 commented on pull request #113: Change: semantic HTML-elements for the pages main sections https://git.io/JeN57
20:18:32  <andythenorth> my plane crashed :(
20:18:35  <andythenorth> on a small airport
20:19:36  <andythenorth> I bought a new one :P
20:23:28  <DorpsGek_III> [OpenTTD/website] auge8472 commented on issue #117: There's a couple of layouting/responsiveness issues in the OpenTTD website. https://git.io/Jed55
20:30:03  *** tokai|noir has joined #openttd
20:30:03  *** ChanServ sets mode: +v tokai|noir
20:36:55  *** tokai has quit IRC
20:37:04  <Samu> what are these for https://nogo.openttd.org/api/1.9.0/classGSWindow.html
20:37:25  <glx> tutorial usually
20:37:43  *** HerzogDeXtEr has joined #openttd
20:38:49  <Samu> some of the listed widgets don't have links
20:39:37  <glx> all the content of this page comes from the comments in the source code
20:40:07  *** nielsm has quit IRC
20:51:04  <Samu> how are them generated? I mean this file https://github.com/OpenTTD/OpenTTD/blob/master/src/script/api/game/game_window.hpp.sq
20:51:32  <Samu> seems like I've been doing this all wrong :(
20:52:15  <Samu> i've been manually editing
20:56:09  <glx> they are generated with doxygen
20:56:37  <glx> oh the .sq are generated with scripts
20:56:39  <Samu> if I create a widget, how to make it into game_window.hpp.sq
20:57:12  <glx> generate_widgets then squirrel_export
20:57:15  <glx> let me check
20:58:34  <glx> yup generate_widget in src/scripts/api
20:58:56  <Samu> gonna experiment
20:59:24  <glx> better run it using cscript than wscript
21:08:27  * andythenorth oof
21:09:39  <Samu> I have created 3 widgets here https://github.com/OpenTTD/OpenTTD/pull/7661/files#diff-45a3c0af8a09ff4dd96e954c744c5692
21:09:57  <Samu> now I run generate_widgets.vbs with cscript
21:10:07  <Samu> but they didn't appear :(
21:10:56  <glx> appear where ?
21:11:50  <Samu> at the https://github.com/OpenTTD/OpenTTD/blob/master/src/script/api/game/game_window.hpp.sq file
21:12:09  <glx> I see them in your link
21:12:24  <Samu> those were manually entered
21:13:12  <glx> you just run "cscript generate_widget.vbs" from src/scripts/api
21:13:59  <glx> it's a command line script
21:15:36  <Samu> https://pastebin.com/yYQmyAPh
21:15:37  <glx> oh generate_widget modifies game_window.hpp
21:16:04  <glx> for the .sq you need to run squirrel_export after generate_widget
21:16:28  <Samu> ah
21:16:44  <Samu> ok let's try that
21:17:08  <glx> and you don't need to modify game_window.hpp manually ;)
21:18:11  <Samu> aha, github desktop detected the change!
21:18:19  <Samu> it's there now :) thanks this was it
21:22:47  <DorpsGek_III> [OpenTTD/OpenTTD] glx22 requested changes for pull request #7550: Add: Screenshot window (& simplify the about/help DropDown) https://git.io/JeNFo
21:23:32  <glx> thanks you remind me to check it for this PR :)
21:23:49  *** frosch123 has quit IRC
21:26:33  <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick updated pull request #7661: Codechange: Rework 'start_date' parameter for AIs as a game setting https://git.io/fjMsZ
21:34:10  <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick updated pull request #7503: Feature: Add aircraft type dropdown in Autoreplace window https://git.io/fjqQz
21:35:04  <DorpsGek_III> [OpenTTD/website] auge8472 opened pull request #129: Fix: remove fixed width of element #section-full https://git.io/JeNFF
21:39:42  *** debdog has quit IRC
21:42:54  *** debdog has joined #openttd
21:48:29  <DorpsGek_III> [OpenTTD/website] LordAro approved pull request #129: Fix: remove fixed width of element #section-full https://git.io/JeNbn
21:49:39  <DorpsGek_III> [OpenTTD/website] LordAro merged pull request #129: Fix: remove fixed width of element #section-full https://git.io/JeNFF
21:52:26  *** Wormnest has joined #openttd
21:57:25  *** WormnestAndroid has quit IRC
21:57:37  *** WormnestAndroid has joined #openttd
21:58:15  *** Wormnest_ has quit IRC
21:59:02  *** WormnestAndroid has quit IRC
21:59:29  *** WormnestAndroid has joined #openttd
22:44:08  <DorpsGek_III> [OpenTTD/website] auge8472 opened pull request #130: Fix: correct the width of main and footer https://git.io/JeNNS
22:46:35  *** Pikka has joined #openttd
22:51:39  <andythenorth> bob
22:52:21  <Pikka> lo
22:53:20  <andythenorth> is it? https://dev.openttdcoop.org/attachments/download/9568/thunderbird-hst.png
22:53:37  <andythenorth> https://www.flickr.com/photos/25459770@N03/26775309677/in/album-72157640213950564/
22:54:13  <FLHerne> andythenorth: Why?
22:54:40  <Pikka> don't see why not
22:54:45  <andythenorth> probably not
22:54:49  <FLHerne> I guess so
22:54:51  <andythenorth> doesn't look good enough :)
22:55:17  <andythenorth> problem is that all realistic UK diesels from 1970 are boxes
22:55:28  <andythenorth> until they are all cheeses
22:55:32  <andythenorth> cheeses, boxes
22:55:34  <andythenorth> boxes, cheeses
22:56:56  <andythenorth> when is 3 company colours? :)
23:01:26  <andythenorth> all my 2030 engines are euro-cheeses :P
23:04:42  <andythenorth> cheese! http://www.vladanfoto.cz/files/class_88/class-88.001-16-04-29-velim-5384z.jpg
23:08:41  *** supermop_Home has quit IRC
23:08:59  <Pikka> eek
23:09:31  <Pikka> I stop at 1993, as Chris Sawyer intended ;)
23:14:02  *** sla_ro|master has quit IRC
23:14:10  <andythenorth> I should have done that :)
23:14:18  <andythenorth> 'mistakes were made'
23:15:00  <Eddi|zuHause> i made a mistake
23:15:05  <Eddi|zuHause> i think i caught a cold
23:15:47  <andythenorth> oof
23:16:41  <Pikka> oof
23:17:06  <Samu> damn civilai picking dark blue just to annoy me
23:17:49  <Pikka> :D
23:18:06  <andythenorth> content authors are the worst :(
23:18:26  <Pikka> do I newgrf or AI today?
23:20:02  <andythenorth> redraw my class 60
23:20:06  <andythenorth> except it's a class 38
23:20:21  <Pikka> just changing the greebles?
23:20:23  <andythenorth> god it's a boring shape though :P
23:20:34  <andythenorth> maybe I can jazz it up
23:20:56  <Eddi|zuHause> industrially efficient stuff must be "boring"
23:21:13  <Eddi|zuHause> every bit of "unboring" will reduce efficiency
23:22:01  <Samu> testing the new version of civilai
23:22:05  <andythenorth> alternative unbuilt version of class 60 https://glostransporthistory.visit-gloucestershire.co.uk/images/A%206%20000%20bhp%20Co-Co.jpg
23:22:07  <Samu> it likes tall long bridges
23:22:20  <andythenorth> chosen design https://glostransporthistory.visit-gloucestershire.co.uk/images/60%20008%20Moel%20Fammau.jpg
23:22:46  <Eddi|zuHause> i don't know anything about this engine
23:22:58  <Eddi|zuHause> but "the people" will demand the version that was actually built
23:23:00  <andythenorth> it's a UK brick
23:23:15  <andythenorth> those people have alternative grfs available :P
23:23:22  <andythenorth> ever heard of BR Trains? :D
23:23:22  <Eddi|zuHause> there's always some utopian tech artist's vision that was overlooked
23:23:34  *** tokai has joined #openttd
23:23:34  *** ChanServ sets mode: +v tokai
23:27:11  *** Wolf01 has quit IRC
23:30:25  *** tokai|noir has quit IRC
23:37:21  *** tokai|noir has joined #openttd
23:37:21  *** ChanServ sets mode: +v tokai|noir
23:38:17  <Samu> how do i unpause the game paused by a gs?
23:39:40  <Samu> spectators can't get access to GS question window :(
23:44:25  *** tokai has quit IRC
23:44:49  *** Samu has quit IRC

Powered by YARRSTE version: svn-trunk