Times are UTC Toggle Colours
00:06:26 *** nielsm has quit IRC 00:28:59 *** Progman has quit IRC 00:41:35 *** tokai|noir has joined #openttd 00:41:35 *** ChanServ sets mode: +v tokai|noir 00:48:20 *** tokai has quit IRC 00:50:00 *** spnda has quit IRC 01:09:12 *** skrzyp has quit IRC 01:09:46 *** skrzyp has joined #openttd 01:16:09 *** gelignite has quit IRC 02:15:50 *** glx has quit IRC 03:41:16 *** debdog has quit IRC 03:59:33 *** mindlesstux has quit IRC 04:05:46 *** mindlesstux has joined #openttd 04:25:53 *** Wormnest__ has quit IRC 05:21:55 *** WormnestAndroid has quit IRC 05:22:12 *** WormnestAndroid has joined #openttd 06:10:55 *** HerzogDeXtEr has joined #openttd 06:24:49 *** Taede_ has quit IRC 06:24:53 *** Taede has joined #openttd 06:25:44 *** Hobbyboy has quit IRC 06:25:44 *** Hobbyboy has joined #openttd 06:40:10 *** Westie has quit IRC 06:41:12 *** Westie has joined #openttd 07:26:59 *** Progman has joined #openttd 07:59:52 *** andythenorth has joined #openttd 08:04:27 <andythenorth> yo 08:21:27 *** Wolf01 has joined #openttd 08:53:16 *** gelignite has joined #openttd 08:57:27 *** Samu has joined #openttd 08:57:32 <Samu> hi 09:01:12 *** nielsm has joined #openttd 09:16:02 *** LordAro has quit IRC 09:16:03 *** LordAro has joined #openttd 09:30:55 *** Artea has quit IRC 09:31:02 *** Artea has joined #openttd 09:32:52 *** Progman has quit IRC 09:39:10 *** moll has quit IRC 09:39:10 *** moll has joined #openttd 09:56:25 *** adikt- has joined #openttd 10:00:48 *** adikt has quit IRC 10:02:23 *** debdog has joined #openttd 10:06:10 *** michi_cc has quit IRC 10:06:14 *** michi_cc has joined #openttd 10:06:14 *** ChanServ sets mode: +v michi_cc 10:10:54 *** andythenorth has quit IRC 10:33:54 *** TheMask96 has quit IRC 10:33:56 *** TheMask96 has joined #openttd 10:45:51 <TrueBrain> milek7: you suggested tus, right? Have you ever worked with it? As their 'tusd' is .. not the best of quality :( Guess I could try the vimeo tus-node-server ... see if that is any better :P 10:45:58 <TrueBrain> (but ... nodejs .. ) 10:48:41 <milek7> yes, I use it 10:48:46 <milek7> seems to be working fine 10:48:50 <TrueBrain> also tusd? 10:48:56 <milek7> yes 10:49:13 <TrueBrain> mostly their "hook" system is a bit foobar .. you use that? 10:49:50 <TrueBrain> for example, post-receive reads: "It will be emitted whenever the server has received more data from the client but at most every second" 10:49:57 <TrueBrain> this is a non-true statement, as it turns out 10:50:08 <TrueBrain> also "fun": post-finish is received before the last post-receive 10:50:20 <milek7> I use only post-finish and pre-create 10:50:33 <TrueBrain> also "fun": in the ".info" file is no indication what so ever if the file really completed uploading 10:50:49 <TrueBrain> I have a hard time figuring out how I can know stuff for sure :( 10:51:04 <milek7> i assume it did on post-finish call 10:51:20 <TrueBrain> I don't get why the .info is not updated to state: finished 10:51:25 <TrueBrain> seems such a logic thing to do 10:52:34 <milek7> I have some ugly PHP scripts for post-finish and pre-create, and cron job just deleting unfinished older than 24h 10:53:05 <TrueBrain> I guess if you don't use post-receive, it is fine .. I am a bit annoyed that it doesn't do what the documentation says it does 10:57:03 <TrueBrain> so you have the choice, either let your internal http server be hammered with events, or don't listen to post-receive .. bit silly :P 10:57:09 <TrueBrain> it would be nice to show progress of big uploads 10:58:54 <milek7> why you need progress on server backend side? 10:59:47 <TrueBrain> I was considering igoring the progress-bar of the tus-client, as we have post-processing jobs to do, and replacing it with a total progress-bar of the whole 10:59:57 <TrueBrain> and in documentation, that is possible 11:00:07 <TrueBrain> in reality .. turns out documentation says things that are nowhere to be found in the code 11:01:11 <TrueBrain> For each open PATCH request, every second a HookEvent instance will be send over this channel 11:01:16 *** Samu has quit IRC 11:01:17 <TrueBrain> even the code comment reads it should work 11:02:18 <TrueBrain> owh, lol, it is per PATCH 11:02:20 <TrueBrain> so if you use chunks 11:02:23 <TrueBrain> that doesn't work 11:02:25 <TrueBrain> facepalm 11:02:33 *** guru3 has quit IRC 11:02:37 *** guru3 has joined #openttd 11:02:41 <TrueBrain> holy crap ... tusd is really implemented for a few usecases, and that is it :P 11:02:48 <TrueBrain> (the issues made that clear to me already btw) 11:05:53 <TrueBrain> bit my issue with tusd .. you can't really configure it 11:05:58 <TrueBrain> so someone can start an upload with chunk-size of 1 11:10:17 <TrueBrain> lol, verbose is on by default .. how the fuck do you disable that .. --verbose false doesn't work .. 11:11:16 <TrueBrain> who does this .... 11:11:17 <TrueBrain> -verbose 11:11:17 <TrueBrain> Enable verbose logging output (default true) 11:13:23 <milek7> yeah, it might not be suitable to do something fancy with it 11:13:45 <TrueBrain> well, disabling the spam of stdout might be something I wouldn't consider "fancy" :D 11:14:00 <milek7> I just needed a replacement for some "uber uploader php" intermingled with SMF forum code :P 11:14:20 <TrueBrain> I am just a bit shocked that big names use tus, and it is in this state :) 11:14:25 <TrueBrain> it feels very rough and unfinished 11:14:30 <TrueBrain> but it has been around for years now 11:15:40 <TrueBrain> I mean, even uppy wraps tus :) 11:17:08 <TrueBrain> okay, "verbose" only toggles 2 log statements .. k k 11:19:35 <TrueBrain> wish I knew "go" a bit :) 11:31:35 *** Progman has joined #openttd 11:37:09 *** Samu has joined #openttd 12:11:49 *** Alkel_U3 has quit IRC 12:12:02 *** Alkel_U3 has joined #openttd 12:16:13 *** _dp_ has quit IRC 12:29:52 *** dP has joined #openttd 12:29:54 *** dP is now known as _dp_ 13:21:24 <TrueBrain> docs_regexp = re.compile("(readme|changelog)(_[a-z]{2}(_[A-Z]{2})?)?\.txt$") 13:21:32 <TrueBrain> so ... readmeabAB.txt is allowed? 13:24:21 <TrueBrain> ah, changelog_ru.txt, etc 13:24:22 <TrueBrain> okayyy 13:24:25 <TrueBrain> did not expect that 13:26:19 *** arikover has joined #openttd 13:30:45 <Samu> there pt-PT and pt-BR 13:30:58 <TrueBrain> lets see if I can summon frosch ... 13:31:18 <Samu> uint result = 4 * minu(dx, dy) / 3 + abs(dx - dy); 13:31:18 <Samu> uint result2 = (dx > dy ? 2 * dx + dy : 2 * dy + dx) / 2; 13:31:27 <Samu> which of these is more accurate? 13:34:01 <Samu> i expected the results to match, but it doesn't always match, sometimes it's off by 1 13:39:24 <Samu> @calc 4 * 29 / 3 + (29 - 3) 13:39:24 <DorpsGek> Samu: 64.6666666667 13:39:46 <Samu> oops 13:40:15 <Samu> @calc 4 * 3 / 3 + (29 - 3) 13:40:15 <DorpsGek> Samu: 30 13:40:47 <Samu> hmm 13:42:00 <Samu> @calc (2 * 29 + 3) / 2 13:42:00 <DorpsGek> Samu: 30.5 13:43:52 <TrueBrain> Samu: please PM DorpsGek for these kinds of things .. nobody here cares about your math-sprees :) 13:45:51 <Samu> nice, it responds to pms 13:49:06 *** ericnoan has quit IRC 13:51:11 *** ericnoan has joined #openttd 13:56:04 *** Eddi|zuHause2 has joined #openttd 14:00:46 *** Eddi|zuHause has quit IRC 14:08:31 *** lastmikoi has quit IRC 14:11:46 *** lastmikoi has joined #openttd 14:14:54 <TrueBrain> "STR_GRF_DESCRIPTION :License: {SILVER}GPL v2{}{BLACK}" <- silly description andy has :P 14:17:54 *** SpComb has quit IRC 14:17:58 *** SpComb has joined #openttd 14:19:32 *** glx has joined #openttd 14:19:32 *** ChanServ sets mode: +v glx 14:31:37 *** spnda has joined #openttd 14:44:07 *** Flygon has quit IRC 14:45:38 *** luaduck has quit IRC 14:45:41 *** luaduck has joined #openttd 15:26:43 *** arikover has quit IRC 15:51:43 *** KenjiE20 has quit IRC 15:52:16 *** KenjiE20 has joined #openttd 16:03:31 *** welterde has quit IRC 16:03:52 *** Wormnest__ has joined #openttd 16:04:07 *** welterde has joined #openttd 16:08:35 *** tyteen4a03 has quit IRC 16:08:38 *** tyteen4a03 has joined #openttd 16:08:50 *** tycoondemon2 has quit IRC 16:09:07 *** tycoondemon has joined #openttd 16:22:58 *** andythenorth has joined #openttd 16:28:22 *** grossing has quit IRC 16:28:25 *** grossing has joined #openttd 16:43:08 <andythenorth> this is notably dramatic https://www.reddit.com/r/openttd/comments/fb5ykb/gadg8eers_newgrfs/ 16:43:31 <andythenorth> I'm glad I was never an emo, it looks like hard work 16:43:55 <andythenorth> also my laptop is burning hot, feels like 70 degrees 16:44:21 <TrueBrain> what did BaNaNaS do to him :( 16:45:05 <andythenorth> I'd file it all under 'there will always be an outlier' 16:45:12 <LordAro> mm 16:45:17 <andythenorth> can please some of the people some of the time 16:45:19 <LordAro> i asked anyway :p 16:45:39 <TrueBrain> I guess tt-forums and BaNaNaS are the same? :s 16:47:11 <andythenorth> am I supposed to be doing something for 1.10? 16:47:18 <andythenorth> I have an odd sense of guilt here 16:47:35 <andythenorth> maybe it's because I shipped Horse after 2 years of constant work :P 16:48:05 <LordAro> make a new title game 16:49:01 <andythenorth> should it feature multiple docks and NRT? :P 16:49:17 <LordAro> multiple docks, sure 16:49:19 <LordAro> NRT, less so 16:49:51 <andythenorth> are there rules for running the competition? 16:49:54 * andythenorth looks 16:50:54 <andythenorth> oh kamnet https://www.tt-forums.net/viewtopic.php?p=1218409#p1218409 16:50:58 <andythenorth> I could ask him to run it? 16:51:05 <TrueBrain> a new BaNaNaS uploader is difficult .. turns out there are many moving parts .. 16:51:06 <LordAro> could do 16:51:57 <TrueBrain> musa made a tarball on the client-side, to transmit that .. but that is not going to fly via a webpage 16:52:10 <TrueBrain> so ... multiple files need to be uploaded, and recombined to a single tarball ... :D 16:52:23 <TrueBrain> also turns out existing packages have hilarious issues 16:52:28 <TrueBrain> like ... DS_store folders 16:52:31 <TrueBrain> and more of that nonsense 16:52:40 <LordAro> ha 16:52:45 <andythenorth> I dm-ed kamnet 16:54:53 <TrueBrain> hmm, tarballs on BaNaNaS without license file .. that should never happen .. 16:55:06 <TrueBrain> all the same GRFID 16:55:45 <TrueBrain> ah, no, lol, I made a change in my Python script which got picked up too earl 16:55:46 <TrueBrain> y 16:55:48 <TrueBrain> LALALAAAA 17:03:14 *** OsteHovel has quit IRC 17:03:25 *** OsteHovel has joined #openttd 17:06:27 <TrueBrain> andythenorth: quick, URL of the container 1 GRF specs? :D 17:07:33 <glx> TrueBrain: https://dev.openttdcoop.org/projects/grfcodec/repository/entry/docs/grf.txt 17:08:17 <TrueBrain> ty :) 17:08:20 <TrueBrain> couldn't find it myself :P 17:08:32 <glx> I followed links :) 17:08:53 <TrueBrain> "The algorithm to calculate it is unknown, but it is never processed by the game anyway." 17:08:54 <TrueBrain> lol 17:09:13 <glx> smart :) 17:09:29 <TrueBrain> some GRFs are a few bytes shorter than frosch his reader expects 17:11:43 *** frosch123 has joined #openttd 17:11:52 <TrueBrain> this time the summoning did work :o 17:11:54 <TrueBrain> hi frosch123 :) 17:11:57 *** Eddi|zuHause2 is now known as Eddi|zuHause 17:12:55 <frosch123> hoi 17:13:59 <frosch123> https://github.com/OpenTTD/OpenGFX/commit/ec48589a02ec7d12c505e8e4f7b5cb09f0610551 <- if i want dorpsgek to talk about eints, is that all that is needed? 17:14:04 <frosch123> one file? 17:14:10 <TrueBrain> frosch123: you copyrighted every file of BaNaNaS2 to you personally. I wanted to use the files in my rewrite, but that would mean I need to add your copyright in every file I copy .. and modifications become a bit fuzzy now .. was this delibrate? (honest question). Or would you mind changing the copyright owner to "OpenTTD Team", or what do we use for OpenTTD? 17:14:11 <frosch123> or are the more settings? 17:14:26 <TrueBrain> besides that commit, all I need to do is to whitelist the project 17:14:52 <frosch123> TrueBrain: i just followed what gpl told me :) "OpenTTD team" is fine for me 17:15:15 <TrueBrain> yeah, you have to put a copyright, GPL says :P Just personal names are always a bit .. annoying to deal with :D Great, tnx :) 17:15:34 <TrueBrain> so far I found 2 bugs in your NewGRF reader .. fixed 1, the other .. I have to look deeper into it :P 17:15:41 <TrueBrain> good thing about having a HUGE collection of GRFs :D 17:15:59 <TrueBrain> and none (!) on BaNaNaS has a min-compatible-version set ... 17:16:17 <TrueBrain> implementation bug, or just unused? 17:24:23 <frosch123> https://github.com/OpenTTD/eints/pull/3 17:24:56 <frosch123> oh wait, i also want the commit hooks 17:24:56 <TrueBrain> merge, and it should work :) 17:24:59 <frosch123> where are they? 17:25:06 <TrueBrain> "they"? 17:25:13 <TrueBrain> owh, commit hooks 17:25:13 <TrueBrain> lol 17:25:40 <DorpsGek_III> [OpenTTD/eints] frosch123 merged pull request #3: Add: [DorpsGek] announce issues, pull-requests, and tags to IRC. https://git.io/Jv2Th 17:25:46 <TrueBrain> there you go 17:26:23 <DorpsGek_III> [OpenTTD/eints] frosch123 approved pull request #2: typo fix in readme https://git.io/Jv2kt 17:26:26 <TrueBrain> owh, right, food time 17:26:53 <DorpsGek_III> [OpenTTD/eints] frosch123 merged pull request #2: typo fix in readme https://git.io/Jv2km 17:33:34 <DorpsGek_III> [OpenTTD/eints] frosch123 opened pull request #4: Add: [Actions] validate commit messages comply with the OpenTTD stand… https://git.io/Jv2kB 17:35:31 <DorpsGek_III> [OpenTTD/eints] TrueBrain approved pull request #4: Add: [Actions] validate commit messages comply with the OpenTTD stand… https://git.io/Jv2kz 17:35:54 <DorpsGek_III> [OpenTTD/eints] frosch123 merged pull request #4: Add: [Actions] validate commit messages comply with the OpenTTD stand… https://git.io/Jv2kB 17:36:02 <TrueBrain> You got to love cherry picking :p 17:37:59 <frosch123> hmm, settings do not know them 17:38:02 <frosch123> what is missing? 17:38:46 <TrueBrain> Needs to run first once 17:38:52 <TrueBrain> So on next PR 17:40:57 <DorpsGek_III> [OpenTTD/eints] frosch123 opened pull request #5: Add github-based authentication and authorization https://git.io/Jv2k1 17:41:10 <frosch123> inded 17:43:26 <frosch123> i probably should look into flake8 17:43:28 <frosch123> never used it 17:44:31 *** syr has quit IRC 17:44:59 *** syr has joined #openttd 17:51:19 <TrueBrain> And black 17:51:28 <TrueBrain> Black is nice :) 17:58:53 <frosch123> oh, i left my debug code in the commit 18:01:58 <DorpsGek_III> [OpenTTD/eints] frosch123 updated pull request #5: Add github-based authentication and authorization https://git.io/Jv2k1 18:05:10 <DorpsGek_III> [OpenTTD/DorpsGek] pyup-bot opened pull request #21: Scheduled monthly dependency update for March https://git.io/Jv2Iw 18:07:08 <andythenorth> so... 18:07:14 <andythenorth> February dev blog post? o_O 18:14:25 *** milek7 has quit IRC 18:14:25 *** milek7 has joined #openttd 18:26:47 <frosch123> write about open positions: dev blog author, titlegame competition organizer, twitter author, ogfx maintainer, ... :) 18:45:42 <andythenorth> blog article reviewer 18:45:48 <andythenorth> blog article approver 18:45:50 <andythenorth> :P 19:31:34 <frosch123> TrueBrain: do you think we can talk or*dge into hosting wiki.openttd.org, he already has at least 2 wikis, and it seems to be the only thing that we still need a db for 19:38:40 *** sla_ro|master has joined #openttd 19:47:00 <michi_cc> Github Wiki, or is that considered BAD? 19:47:28 <LordAro> i wouldn't want to use it for the amount of content there is 19:53:48 <frosch123> i would claim that repos and containers can be moved to gitlab or other cloud providers in short or medium time 19:54:10 <frosch123> otoh, i would consider a wiki a lot of work to migrate to yet another markup 20:03:11 <Samu> I am inventing a new distance :p 20:07:59 <Samu> name is too long, but then again, i'm always bad with names 20:08:33 <Samu> GetDistanceTransportedGoodsIncomeToTile 20:22:52 *** spnda has quit IRC 20:32:40 <DorpsGek_III> [OpenTTD/nml] frosch123 approved pull request #92: Fix 62cab41: Random switch support for NRT https://git.io/Jv2mn 20:38:03 *** sla_ro|master has quit IRC 20:38:15 <DorpsGek_III> [OpenTTD/nml] frosch123 approved pull request #91: Fix #90, e9429c89: Generated procedure calls where not properly marked https://git.io/Jv2m0 20:52:34 <TrueBrain> frosch123: I have 2 sets of errors with your NewGRF reading code I don't really understand. I am not sure if the GRFs aren't just corrupted, or that something else is going on. One is when the checksum is read in container v1, there aren't 4 bytes left anymore 20:52:53 <TrueBrain> the other is in read_pseudo, the num_sets which hits EOF 20:53:38 <TrueBrain> so num_sets is 0 after uint8() read, but there aren't two uint_ext() after that 20:55:38 <TrueBrain> Main HQ is one of those GRFs where it hits EOF in the checksum read .. if you have any time or when you are bored, mind giving that a look? 20:55:50 <frosch123> hmm, i remember the second issue. i think ottd has a work around for that 20:56:05 <TrueBrain> and this is why I mention these things :D 20:56:42 <frosch123> if (num_sets == 0 && buf->HasData(3)) { <- yep, ottd works around those broken sets 20:57:02 <TrueBrain> what does HasData() do? 20:57:02 <frosch123> ok, i can fix that 20:57:23 <TrueBrain> I have some other fixes, but more on the coding style of things. But I can merge your fix over that I am sure :) 20:57:38 <frosch123> somethnig like len(pseudo) minus already consumed data 20:58:15 <Samu> Help me with a shorter name for this function, it escalated quickly when adding to squirrel https://github.com/OpenTTD/OpenTTD/compare/master...SamuXarick:DistanceTransportedGoodsIncome?expand=1 20:58:21 <TrueBrain> still no clue what HasData() does :D Check if there are exactly that many bytes left in the buffer? Or at least? It is such a strange name for a function :D 20:58:41 <frosch123> "at least" 20:58:49 <TrueBrain> k, that is easy to fix in that case :) 21:01:16 <Samu> here is a quick scrollto to their names: https://github.com/OpenTTD/OpenTTD/compare/master...SamuXarick:DistanceTransportedGoodsIncome?expand=1#diff-39cae6f59941cc3dd0d0dfc9da4bd6bf 21:03:11 <TrueBrain> frosch123: okay, that fixes some of them. But I got a new one in return, on action 0xA :) 21:03:20 <TrueBrain> if num_sets == 0 and len(pseudo) - 3 >= 3: 21:03:22 <TrueBrain> is my fix 21:04:34 <TrueBrain> the 0xA action seems related 21:04:45 <TrueBrain> as the first read can also be zero, it seems 21:05:00 <TrueBrain> yeah, it is 21:06:09 <frosch123> haha, no, that is just copy and paste 21:06:20 <frosch123> there is never a second byte 21:06:25 <frosch123> return reader.uint8() 21:06:32 <frosch123> ^^ it should be just that 21:06:33 <TrueBrain> num_sets = reader.uint8() 21:06:33 <TrueBrain> return sum([reader.uint8() for _ in range(num_sets)]) 21:06:35 <TrueBrain> not that? 21:06:43 <TrueBrain> https://github.com/OpenTTD/OpenTTD/blob/master/src/newgrf.cpp#L6801 21:07:00 <frosch123> oh, right, even more wrong 21:07:00 <TrueBrain> no, also wrong .. hmm 21:07:25 <TrueBrain> spammy: 21:07:25 * TrueBrain sent a long message: < http://tasks.synapse:8008/_matrix/media/r0/download/matrix.home.truebrain.nl/vgMzztvvaMEiLvXfnVpKrpWD > 21:07:42 <TrueBrain> LOL! 21:07:43 <TrueBrain> stupid client 21:07:52 <LordAro> "http://tasks.synapse:8008" 21:07:53 <TrueBrain> that URL won't work for you :P 21:08:06 <TrueBrain> so that is what Matrix does with 4+ lines :) 21:08:13 <LordAro> yup 21:08:26 <TrueBrain> https://gist.github.com/TrueBrain/7b1438f7dc945219b90ddf8bebee5589 21:09:00 <TrueBrain> otherwise Matrix is pretty nice btw 21:09:15 <TrueBrain> well, if you don't use the default IRC bridge, as ugh .. that stupid [m] 21:09:30 <frosch123> TrueBrain: looks good 21:09:39 <TrueBrain> cool 21:09:53 <TrueBrain> doing a new scan to see if any GRFs are broken :) 21:10:04 <TrueBrain> I like being able to scan hunderds of GRFs :D 21:11:51 *** tokai has joined #openttd 21:11:51 *** ChanServ sets mode: +v tokai 21:12:47 <TrueBrain> frosch123: any idea if it is expected that no GRF as of yet defined a minimum version? 21:13:12 <Samu> visual studio changed a "No newline at end of file" into a newline. I tried to delete the new line but when I save it re-adds it. 21:13:27 <TrueBrain> Samu: and it is right to do so 21:13:29 <TrueBrain> stop trying to remove it 21:13:31 <Samu> https://github.com/OpenTTD/OpenTTD/compare/master...SamuXarick:DistanceTransportedGoodsIncome?expand=1#diff-3ecb33040c2e915e9c7dd136896cd2beL73 21:13:33 <frosch123> i would expect that at least ogfx cared about setting minimum of ottd 1.2 at some point 21:13:35 <Samu> look at that diff 21:14:20 <frosch123> oh dear, i forgot that grfcodec was written by an assembler guy 21:15:08 <Samu> well in that case, src/script/api/script_cargo.cpp has a "no newline at end of file" 21:16:12 <TrueBrain> lol .. on WSL, tailing of a file that is written by pipes doesn't work for some reason .. lol 21:16:56 *** gelignite has quit IRC 21:18:53 *** tokai|noir has quit IRC 21:19:53 <Samu> once 1.10 goes live, I am gonna work on my AI, to use those nice new functions :p 21:20:03 <TrueBrain> why wait? 21:20:21 <Samu> because it doesn't work for 1.9 21:20:31 <TrueBrain> use RC1! 21:20:49 <Samu> i would break my AI for many openttd's 21:21:00 <TrueBrain> frosch123: okay, 6 GRFs that fail on your reader now; that is a lot better :) (down from 20-ish). All container v1, all on reading the last few bytes. Hmmm 21:21:10 <TrueBrain> Samu: you don't have to publish it yet! 21:21:13 <frosch123> are they all from ttdur? 21:21:34 <frosch123> because those are ancient 21:22:15 <TrueBrain> frosch123: yes, they are :) 21:22:25 <TrueBrain> well, uploaded in 2014 :P 21:22:30 <frosch123> so, they used a broken encoder 21:22:40 <TrueBrain> but OpenTTD does read them? Cool :D 21:22:49 <frosch123> probably an old grfcodec bug, or they used some custom-made encoder 21:23:30 <TrueBrain> there are 2 bytes, instead of 4 21:24:24 <frosch123> hmm, that sounds again like i heard it before, but don't know where :) 21:24:38 <TrueBrain> OpenTTD doesn't even read those bytes, lol 21:24:46 <frosch123> anyway, i guess ignore if there are less than 4 bytes? 21:24:52 <frosch123> reject if there are more than 4 bytes left 21:25:06 <frosch123> just so that people do not append random junk at the end 21:25:31 <TrueBrain> or we just append 2 bytes to these GRFs and repack them 21:25:47 <frosch123> that changes md5sum, 21:26:06 <TrueBrain> hmm 21:26:07 <TrueBrain> fair point 21:26:07 <frosch123> it's container 1, so the whole file matters 21:27:19 <TrueBrain> you don't check there is no junk btw; I think that is a nice check to add :D 21:28:12 <frosch123> while you are at it, also extend the Feature enum with "ROADTYPES = 0x12, TRAMTYPES = 0x13," :) 21:28:30 <TrueBrain> done 21:28:47 <TrueBrain> any extra code requires, or is this done via action 0/3/4 ? 21:28:56 <frosch123> nothing more required 21:29:04 <TrueBrain> btw, language.csv seems missing in your repo :) But I found the wikipage :) 21:29:21 <frosch123> there is code to fetch it 21:29:41 <frosch123> http://translator.openttd.org/language-list <- that's it 21:29:47 <TrueBrain> hmm .. did not find it, but that might be me not looking good enough :) 21:29:55 <TrueBrain> cheers 21:29:58 <frosch123> maybe i only planed it :) 21:31:47 <TrueBrain> okay, lets scan all the GRFs again :) 21:32:04 <TrueBrain> please never ask me to add test-cases for all these quirks :P 21:32:08 <frosch123> TrueBrain: oh, when you mentioned the minum-version earlier, you meant the stuff from the newgrf class, not from the yaml? 21:32:17 <TrueBrain> yes 21:32:22 <TrueBrain> from your NewGRF reader 21:32:29 <frosch123> ok, i totally got that wrong :) 21:32:31 <TrueBrain> INFOMINV 21:33:18 <frosch123> there are plenty of grf setting that 21:33:35 <frosch123> when i grep in the nml sources i have 21:33:47 <frosch123> so either nml silently drops it, or newgrf.py is wrong :) 21:34:12 <TrueBrain> k, will add some debugging :) 21:34:20 <TrueBrain> well, first scanning to see if any GRF is now broken :) 21:35:10 <TrueBrain> version is None too, so I guess there is a relation :) 21:35:15 <frosch123> TrueBrain: replace "> 4" with ">= 4" :) 21:35:34 <TrueBrain> there we go :) 21:36:19 <TrueBrain> min-version: 5597 21:36:23 <TrueBrain> hmm .. that is a low number 21:36:29 <TrueBrain> @base 10 16 5597 21:36:29 <DorpsGek> TrueBrain: 15DD 21:36:32 <frosch123> days since 2000-01-01 21:36:37 <TrueBrain> ah, tnx 21:36:50 <TrueBrain> min-version: 166 21:36:58 <frosch123> authors can version them as they like, but coop went for the date 21:37:11 <TrueBrain> owh, so it has nothing to do with OpenTTD version? 21:37:28 <frosch123> no, it's about upgrading grfs in savegames 21:37:38 <TrueBrain> k k 21:37:45 <frosch123> whether ottd considers them compaitble or incompatible 21:37:47 <TrueBrain> does it need validating when uploading, that the number is higher, or? 21:38:25 <frosch123> i guess that would make sense 21:38:31 <frosch123> version should be ascending 21:38:44 <frosch123> ottd gui will only show the highest version by default 21:38:52 <frosch123> so if you donwload an older, ottd will hide it from you :p 21:38:56 <TrueBrain> lol 21:38:58 <TrueBrain> how nice :) 21:39:37 <TrueBrain> okay, so I have a basic setup to validate NewGRFs on upload .. 21:39:40 <TrueBrain> now the other types :P 21:39:59 <frosch123> ai/gs are the hardest 21:40:14 <TrueBrain> really? I was thinking that would be easy :D 21:40:23 <TrueBrain> the hardest for me is going to be the Base* :P 21:41:40 <TrueBrain> but where I will allow NewGRFs, scenarios, Base* etc to be uploaded file by file 21:41:50 <TrueBrain> AI/GS (Library) will need to be uploaded in a zip/tar 21:41:50 <frosch123> it's hard to find the uniqueid from ai/gs 21:41:59 <TrueBrain> owh, musa has code for that, so copy/paste :) 21:42:02 <frosch123> esp in zuu's scripts 21:43:11 <frosch123> anyway, bananas2 also has loaders for heightmap and scenarios 21:43:23 <frosch123> so you can debug those if you like :) 21:43:52 <TrueBrain> I saw them yes; looking forward to it :) 21:47:13 <andythenorth> could we build non-track station tiles on corner slopes? o_O 21:47:15 * andythenorth wonders 21:47:40 <TrueBrain> frosch123: I cant tell you how happy I am you wrote those functions; I never would have :D 21:48:12 <frosch123> andythenorth: no, but you could replace all non-track stations with objects 21:48:40 <frosch123> TrueBrain: since i wrote them first, i apparently liked writing them :p 21:49:18 <andythenorth> I do use objects in current gameplay for the corner slopes, it is a valid solution 21:49:26 <andythenorth> just lacks catchment :P 21:50:33 <andythenorth> looks nice though 21:52:21 <andythenorth> https://dev.openttdcoop.org/attachments/download/9633/corner_slope_objects.png 21:53:50 *** Wolf01 has quit IRC 21:56:50 <TrueBrain> bah, frosch123 , now I want to know if your scenario loader works :P 21:57:02 <TrueBrain> I wanted to play a game for the rest of the evening :@ 21:57:16 <TrueBrain> newgrfpresets is something new to add to BaNaNaS btw? 21:57:30 <frosch123> yes, it's not supported by ottd :) 21:57:57 <TrueBrain> not YET, you say? :D 21:58:00 <frosch123> so,do not spend time now 21:58:17 <TrueBrain> you disabled lzo2 btw; never got it to work, o? 21:58:19 <frosch123> i probably only wrote it, to figure out what the format should be 21:58:30 <frosch123> i did not find a python lzo2 21:58:35 <TrueBrain> ah 21:59:21 <frosch123> btw. note that savegame.py will report all uniqueids of used ais and gs as None 21:59:31 <frosch123> that's because ottd does not store them, while it really should :p 21:59:46 <TrueBrain> fix before 1.10? 22:00:03 <LordAro> TrueBrain: "Nothing. I just don't want to use it anymore." - in response to "what did BaNaNaS do to you?" 22:00:09 <LordAro> so as andythenorth said 22:00:30 <TrueBrain> okay .... well ... he can have his opinion I guess 22:00:42 <frosch123> TrueBrain: lordaro rejected a pr that would bump savegame, but maybe that was just an easy excuse 22:00:57 <TrueBrain> tickly him some more 22:00:59 <TrueBrain> it should be fine :P 22:01:10 <LordAro> :o 22:01:41 <frosch123> hmm, maybe it was nielsm, not lordaro :) 22:01:47 <LordAro> if you think it's ok to bump the savegame version after freeze... 22:02:05 <TrueBrain> strongly depends on the case, ofc :) 22:02:12 <frosch123> LordAro: technially it works unless master bumped first 22:02:20 <TrueBrain> but another year of not storing AI data ... :P 22:02:41 *** tokai|noir has joined #openttd 22:02:41 *** ChanServ sets mode: +v tokai|noir 22:03:33 <nielsm> frosch123, I did say that a PR that bumps savegame (especially for a feature) can't be candidate for backport to release branch 22:03:56 <TrueBrain> and you are not wrong :) 22:03:57 <nielsm> since that's cans of various worms 22:03:58 <frosch123> nielsm: i would generalize that to "features are never backport candidates" :) 22:04:02 <TrueBrain> but ... but ... :P 22:04:13 <frosch123> 1.9.3 is broken because of a feature 22:04:27 <nielsm> yeah and it's my fault 22:04:34 <TrueBrain> which feature? 22:04:58 <frosch123> some gui qol thing with assigning orders to oilrigs 22:05:05 <nielsm> yeah 22:05:27 <frosch123> break assigning orders to any station if the tile under the station sign does not belong to the station 22:05:48 <TrueBrain> that is a regression, funny enough :) 22:07:34 <frosch123> once i made a nightly, where trains ignored all signals :) 22:07:45 <TrueBrain> sounds like fun :D 22:08:06 <TrueBrain> before PRs, we broke nightlies a lot 22:08:07 <TrueBrain> and often 22:08:14 <TrueBrain> so I am sure we have more gems like that :P 22:08:36 <frosch123> i mostly broke stuff in svn age, when splitting patches 22:09:17 <TrueBrain> https://cdn.openttd.org/openttd-releases/0.4.0.1/changelog.txt 22:09:22 <TrueBrain> there are a few gems in there as "fix" 22:09:29 <TrueBrain> the most idiotic release we ever did .. 0.4.0.1 :D 22:09:33 *** tokai has quit IRC 22:10:17 <frosch123> LordAro: btw. there was a savegame bump between 1.2.0-rc1 and 1.2.0 22:10:38 <frosch123> it was needed to fix some bug, and we were lucky that trunk had not yet advanced 22:11:46 <LordAro> well that's still the case here 22:12:01 <frosch123> oh, and then there was 1.6.1. there was no savegame bump between 1.5 and 1.6 at all, so people ran into trouble loading 1.6 savegames with 1.5, so we inserted an arbitrary bump in 1.6.1 22:12:23 *** tokai has joined #openttd 22:12:23 *** ChanServ sets mode: +v tokai 22:12:28 <frosch123> just to make 1.5. not load 1.6.1 games :) 22:13:48 <TrueBrain> haha, lol :) 22:13:56 <TrueBrain> and yet we never wrote down that is kinda important to do :P 22:14:03 <TrueBrain> okay, I see what you mean frosch123 , by not storing the uniqueid 22:14:06 <TrueBrain> that is just silly/stupid 22:14:14 <TrueBrain> how does it know which AI to load in that case? 22:14:27 <frosch123> ottd looks up ais by name 22:14:41 <TrueBrain> let me guess .. my handy-work? 22:14:46 <frosch123> probably :p 22:14:55 <TrueBrain> it became such a mess, the loading system :P 22:14:58 <frosch123> though i can't prove that it wasn't yexo 22:15:23 <TrueBrain> we can, but it is not worth the effort :D 22:18:59 <TrueBrain> frosch123: we don't know the uniqueid nor the md5 ... okay, that is a bit silly :D 22:19:13 *** tokai|noir has quit IRC 22:19:53 * andythenorth reads https://wiki.openttd.org/Frosch/NewGRF_Configuration_in_Utopia 22:19:59 <frosch123> yes, ottd can't download missing ai/gs for savegames 22:20:14 <frosch123> andythenorth: it's not about newgrf this time :p 22:20:20 <andythenorth> I know 22:20:26 <TrueBrain> also means I can't help the user when uploading to pick the right dependencies for that .. 22:20:37 <andythenorth> just wondering about having something analyse grfs as a web service, based on bananas data :P 22:20:46 <andythenorth> idle thoughts 22:20:57 <TrueBrain> why ever did I make it lookup by name .. as I am pretty sure I did that bullshit .. I knew I spend hours and hours on getting it to load the AIs correctly from savegames 22:21:02 <TrueBrain> it was really difficult :P 22:21:09 <TrueBrain> so many odd cases 22:21:42 <TrueBrain> well, I guess we can also do a lookup by name ... 22:22:38 <TrueBrain> frosch123: if/when you add support for AI uniqueids .. please also add the md5sum while at it 22:22:47 <TrueBrain> if that is possible :P 22:23:50 <frosch123> i think it's not 22:24:05 <frosch123> ais/gs are not single files 22:24:19 <TrueBrain> the client CAN do it, I am pretty sure about that 22:24:24 <TrueBrain> not 100% 22:24:25 <TrueBrain> just pretty 22:27:11 <frosch123> ah, it XORs the md5sums of all files 22:27:25 <TrueBrain> https://github.com/OpenTTD/OpenTTD/blob/master/src/script/script_scanner.cpp#L248 22:27:26 <TrueBrain> :D 22:27:28 <TrueBrain> yeah .. 22:27:31 <frosch123> i wonderer how it orders the files, but XOR does not need that 22:27:42 <frosch123> so, someone was clever, probably rb 22:27:49 <TrueBrain> :( 22:27:52 <frosch123> :p 22:27:54 <TrueBrain> I am not even considered! :P 22:27:56 <TrueBrain> but you are right :) 22:28:30 <TrueBrain> so the MD5 should already been known for the AIs somewhere 22:28:45 <TrueBrain> okay, all scenarios on file load just fine 22:28:55 <TrueBrain> meaning no lzo2 :) 22:29:53 <frosch123> looks like the md5sum is not stored, but all scripts are rescanned/recomputed for every content item 22:30:00 <frosch123> so, that may also explain performance :) 22:30:19 <frosch123> O(n^2) for number of versions of same item or so 22:30:31 <TrueBrain> so another quick-win :) 22:30:52 <frosch123> hmm, i guess it only checks the latest, so it does not call it for every version 22:32:11 <frosch123> anyway, night :) 22:32:17 <TrueBrain> night frosch123 22:32:18 *** frosch123 has quit IRC 22:34:26 <TrueBrain> and heightmaps load too .. so only AI/GS and Base* left :) Something for another day 22:43:12 *** Progman has quit IRC 22:45:31 *** cHawk- has joined #openttd 22:47:31 <DorpsGek_III> [OpenTTD/OpenTTD] ya-isakov opened issue #8029: Black screen on SDL2-enabled OpenTTD, Sway and SDL_VIDEODRIVER=wayland https://git.io/Jv23P 22:51:36 *** cHawk_ has quit IRC 23:15:41 *** nielsm has quit IRC 23:17:57 *** andythenorth has quit IRC 23:35:01 *** Samu has quit IRC