Times are UTC Toggle Colours
01:00:45 *** gelignite has quit IRC 01:07:12 *** nielsm has quit IRC 01:15:02 *** matt21347 has quit IRC 01:58:44 *** Progman has quit IRC 02:05:29 *** Flygon has joined #openttd 03:46:19 *** D-HUND has joined #openttd 03:47:32 *** Wormnest has quit IRC 03:49:39 *** debdog has quit IRC 03:54:06 *** glx has quit IRC 06:19:10 *** sla_ro|master has joined #openttd 07:27:19 *** andythenorth has joined #openttd 07:31:23 *** nielsm has joined #openttd 07:44:19 *** jottyfan has joined #openttd 08:00:17 *** andythenorth has quit IRC 08:07:25 *** andythenorth has joined #openttd 08:38:36 *** reldred has quit IRC 08:39:16 *** colde has quit IRC 08:39:41 *** dvim has quit IRC 08:40:06 *** innocenat_ has quit IRC 08:40:17 *** mindlesstux has quit IRC 08:44:46 *** andythenorth has quit IRC 08:45:12 *** andythenorth has joined #openttd 08:52:18 *** andythenorth_ has joined #openttd 08:52:34 *** innocenat_ has joined #openttd 08:54:16 *** dvim has joined #openttd 08:55:46 *** colde has joined #openttd 08:59:19 *** andythenorth has quit IRC 08:59:38 *** mindlesstux has joined #openttd 09:00:28 *** reldred has joined #openttd 09:09:14 <andythenorth_> yo 09:09:23 <TrueBrain> hello 09:18:22 <TrueBrain> glad we had this conversation :D 09:18:54 <andythenorth_> wfm 09:19:08 * andythenorth_ making ships 09:19:34 *** frosch123 has joined #openttd 09:20:25 <TrueBrain> lol ... I found a nice bug in TrueWiki ... \r\n -> \n is missing :D 09:20:51 <TrueBrain> frosch123: request for migration: add a newline at end of file for all files :D 09:20:56 <TrueBrain> (and morning :) ) 09:21:16 <frosch123> what does \r break? 09:21:25 <TrueBrain> diffs :) 09:21:26 <frosch123> or just uglyness? 09:21:36 <frosch123> ah, diffs 09:21:45 <TrueBrain> the only reason I found out, honestly :P 09:21:55 <frosch123> to templates change when they gain a \n at the end? 09:22:00 <frosch123> *do 09:22:21 <TrueBrain> newlines are pretty much ignored, but there can be some odd cases .. 09:22:26 <TrueBrain> all templates should be in <includeonly> blocks 09:22:31 <TrueBrain> but fair point, nevermind my request 09:22:43 <frosch123> i can do it for non-templates :) 09:22:52 <TrueBrain> nah; either for all or for none, honestly 09:23:05 <frosch123> ok, so just remove \r 09:23:19 <TrueBrain> replace("\r\n", "\n").replace("\r", "\n") 09:23:23 <TrueBrain> is what I now do on editing 09:23:36 <TrueBrain> \r\n is Windows, only \r is old Mac 09:23:43 <TrueBrain> I think 09:23:52 <TrueBrain> well, removing \r is better 09:23:53 <TrueBrain> lets do that 09:24:02 <TrueBrain> content.replace("\r", "") 09:24:04 <TrueBrain> there :P 09:24:11 <TrueBrain> now I don't have a diff anymore if I hit "save" :D 09:25:35 <TrueBrain> git-operations are not quick :D Saving takes a bit more time now :P 09:26:13 <frosch123> yep, when i migrate the whole history, it fill take hours :) 09:26:26 <Eddi|zuHause> content.replace("\r", "") <-- can't git do this for you with eol-style? 09:26:49 <TrueBrain> sure; but git-backend is optional 09:28:47 <TrueBrain> hmm .. how do I see the commiter of a git commit .. 09:29:30 <TrueBrain> None <None> 09:29:31 <TrueBrain> lol 09:33:22 <TrueBrain> Request-for-feedback: https://gist.github.com/TrueBrain/ace3e01a52338d2ad792a743a39e7362 09:33:30 <TrueBrain> how/where can I improve on commit messages? 09:33:39 <TrueBrain> (the logged in user was "test") 09:39:08 *** WormnestAndroid has quit IRC 09:39:21 *** WormnestAndroid has joined #openttd 09:45:14 *** iSoSyS has joined #openttd 09:47:39 *** HerzogDeXtEr has joined #openttd 09:55:10 *** gelignite has joined #openttd 10:00:07 *** mindlesstux has quit IRC 10:00:28 *** mindlesstux has joined #openttd 10:01:00 <TrueBrain> I don't like spaces in page names, it makes commit messages look weird :P 10:01:10 <TrueBrain> but quoting them is even weirderderder 10:01:42 *** Progman has joined #openttd 10:02:18 <TrueBrain> meh; hopefully frosch123 has more inspiration than I have :P But "git commit" part is done .. now the "git push" part :D 10:14:17 <andythenorth_> %20 :P 10:14:26 <TrueBrain> no 10:15:00 <andythenorth_> I would have quoted them, but eh, YMMV 10:15:15 * andythenorth_ learning about boats 10:35:25 *** Progman has quit IRC 10:36:06 *** Progman has joined #openttd 10:36:44 <frosch123> TrueBrain: https://dpaste.org/n8g9 <- do it like git status? 10:37:21 <andythenorth_> ships are inconvenient 10:37:26 <andythenorth_> IRL is not arranged how I think it should be 10:37:40 <TrueBrain> frosch123: I was talking about the commit message itself 10:37:44 <TrueBrain> that is a single line 10:37:48 <TrueBrain> or .. hmm, no, that works 10:37:50 <TrueBrain> sure 10:37:58 <TrueBrain> not sure what the "git show" is showing? 10:38:10 <frosch123> yeah, ignore that, it's weird 10:38:45 <frosch123> i guess git status is mostly the same as what you already have 10:38:58 <TrueBrain> yup, but a bit better, I would say 10:39:02 <TrueBrain> we just cannot use our normal Add: etc 10:39:03 <frosch123> just "->" instead of "to" 10:39:48 <TrueBrain> a change is just "modified", right? 10:40:11 <frosch123> yes :) 10:40:26 <TrueBrain> I only made it "new page", instead of "new file" :P 10:42:18 <TrueBrain> okay .. so that leaves 1 item on my TODO for v1 :) 10:46:11 <frosch123> hmm, there are no \r in my conversion 10:47:58 <frosch123> yeah, i have to reject your request as "not reproducible" :) 10:49:57 <TrueBrain> I did not request you to remove \r, for the careful reader ;) 10:50:21 <TrueBrain> My request was about end of file newline :p 10:50:36 <TrueBrain> My code on the other hand did need a \r fix :D 10:51:51 <TrueBrain> It is however good to know mediawiki does something right :D 10:53:48 <frosch123> ok, "User:Pystro/Template:Link Translation" is way too complicated to migrate, but luckily there are only 13 usages :) 10:54:11 <TrueBrain> :D 10:54:23 <TrueBrain> hmm .. I think it is easiest if I disallow ":" in page names btw 10:54:32 <TrueBrain> I can add support for it, but it makes the code complex .. 10:55:36 <frosch123> forbidden: ":|", non-printables, leading ".", leading/trailing ws ? 10:55:53 <TrueBrain> and ".." 10:56:05 <frosch123> that's leading . 10:56:11 <TrueBrain> no 10:56:14 <TrueBrain> just anywhere 10:56:32 <TrueBrain> aa..bb is also not allowed 10:56:33 <frosch123> ok, for parts separated by / 10:56:42 <TrueBrain> it doesn't split the / 10:56:47 <TrueBrain> it just scans the whole path 10:57:05 <frosch123> but "/" should also not allow neighbouring whitespace 10:57:39 <TrueBrain> I guess ... 10:57:42 <TrueBrain> so many exceptions! :P 11:00:57 <TrueBrain> okay, so the current rules: 11:01:11 <TrueBrain> in FULLPAGENAME, no "..", "|", or ":" 11:01:25 <TrueBrain> in every part of the FULLPAGENAME (so between the /), no starting or ending with " " or "." 11:01:31 <TrueBrain> FULLPAGENAME cannot end with / 11:01:35 <TrueBrain> and no CCs 11:01:46 <TrueBrain> pretty sure people will find other annoying things to put in names :P 11:02:52 <frosch123> there is probably some js injection for ie6 11:03:13 <TrueBrain> https://www.mediawiki.org/wiki/Manual:Page_title 11:03:16 <TrueBrain> many more I can blacklist, it seems :P 11:03:48 <TrueBrain> # < > [ ] | { } _ will be blacklisted too :) 11:05:13 <frosch123> allow "_", we have a proper " " 11:06:11 <TrueBrain> but what use-case would _ be a valid use? 11:06:21 <TrueBrain> sounds that the user meant " " :P 11:06:37 <frosch123> ok :) 11:06:57 <Eddi|zuHause> a page about an identifier? 11:07:07 <frosch123> also, textareas are really broken in my ff version 11:07:34 *** Wolf01 has joined #openttd 11:08:02 <TrueBrain> define "broken" 11:08:15 <TrueBrain> hmm ... a title with the name "&" is .. not doing what I expect it to do :D 11:08:46 <TrueBrain> I think I am missing some url escaping .. 11:08:51 <TrueBrain> and/or html escaping 11:08:53 <TrueBrain> that will be fun :D 11:09:31 <TrueBrain> same with %20 in names, also fun :D 11:09:38 <frosch123> i disabled spell checking now, it blocked the gui thread and disrupted editing 11:09:41 <TrueBrain> I would like to ban & and %, but there are legit uses for it ... 11:09:51 <TrueBrain> frosch123: ... lol :D 11:10:33 <Eddi|zuHause> for example, if someone was writing a wiki page about the setting "newgrf_developer", why would you assume the page title should be "newgrf developer"? 11:12:20 <Eddi|zuHause> on the other hand, if you allow "_", then you get ambiguity in the lookup 11:12:40 <TrueBrain> "A title can normally contain the character %. However it cannot contain % followed by two hexadecimal digits (which would cause it to be converted to a single character, by percent-encoding)." <- this .... wuth? 11:13:10 <TrueBrain> Eddi|zuHause: I am only willing to allow "_", if we refuse a page named "A_B" and "A B" to both exist 11:13:19 <TrueBrain> but it is just easier to ban "_", honestly 11:13:51 <frosch123> TrueBrain: only because mediawiki authors did not know how to escape, you do not need to copy that 11:14:02 <TrueBrain> frosch123: I fully agree :) 11:14:15 <TrueBrain> well, I don't know how to escape either, clearly, but that is something I can hopefully fix :D 11:14:38 <TrueBrain> are there any characters not allowed by git? 11:15:17 <TrueBrain> * and " are not allowed on NTFS 11:15:20 <frosch123> depends whether you want to allow checkout on windows 11:15:31 <frosch123> backslash is difficult on windows 11:15:46 <TrueBrain> should we just ban those 3 chars? 11:15:49 <frosch123> LPT and CON are difficult 11:15:59 <Eddi|zuHause> i think windows bans a few more characters 11:16:19 <Eddi|zuHause> but i don't remember which ones 11:16:36 <frosch123> TrueBrain: \ did not work on mediawiki either. some user actually created a page containing \, but when trying to view it something converts it to /, and then reports 404 11:16:40 <TrueBrain> that is why I looked it up and came with those missing 3 Eddi|zuHause .. 11:16:57 <TrueBrain> okay, so I banned \, * and " too 11:17:10 <frosch123> ? is allowed? 11:17:18 <Eddi|zuHause> i'm pretty sure ":" was also banned last time i tried 11:17:35 <TrueBrain> Eddi|zuHause: yes ........ which we talked about 5 minutes earlier to already ban 11:17:57 <TrueBrain> frosch123: hmm ... both NTFS and mediawiki doesn't mention it 11:18:19 <TrueBrain> it does need url-escaping, ofc 11:19:07 <TrueBrain> FAT32 does ban ?, it seems 11:19:53 <Eddi|zuHause> i think FAT32 used ? to denote deleted files 11:20:16 <Eddi|zuHause> i could misremember that, though 11:20:30 <TrueBrain> ah, no, it is also reserved on NTFS 11:21:01 <TrueBrain> frosch123: I think I will escape ?, honestly 11:21:08 <TrueBrain> hmm .. buthow .. 11:21:09 <TrueBrain> hmmm 11:21:12 <TrueBrain> no, banning it is 11:21:34 <michi_cc> I think NTFS itself allows more characters than what userspace windows API will let through. 11:23:12 <TrueBrain> frosch123: https://gist.github.com/TrueBrain/f24c3426bb5b2db7039e1c23d25b1bcd 11:24:15 <frosch123> <> without & is weird, but okay 11:24:39 <TrueBrain> we can also just escape < > honestly 11:24:58 <TrueBrain> ah, no, <> is not allowed by NTFS 11:25:01 <TrueBrain> I just change the comment :D 11:25:04 <frosch123> i still don't get why you put such a focus on "..", when the problem applies to "." after "/" 11:25:32 <TrueBrain> frosch123: because any URL you try to access with ".." anywhere, will give you a 404 11:25:35 <frosch123> do you want to allow hidden pages? :) 11:25:58 <TrueBrain> and again, there is ALSO a filter on starting/ending with " " and "." per split on / 11:26:11 <TrueBrain> so a page cannot be named ".bla" 11:26:52 <Eddi|zuHause> so no wiki page on "~/.openttd" :p 11:28:01 <TrueBrain> for the "..", code just becomes a lot easier if you ban access to any URL containing ".." 11:28:20 <TrueBrain> https://github.com/TrueBrain/TrueWiki/blob/master/truewiki/web_routes.py#L72 11:29:41 <TrueBrain> frosch123: maybe eaasier: https://github.com/TrueBrain/TrueWiki/pull/38 11:29:42 *** Flygon has quit IRC 11:29:43 <TrueBrain> the full patch :) 11:30:32 <TrueBrain> let me know if I missed something or if you know a cleaner way to write that function :D 11:33:59 <frosch123> i think there were cases with a trailing "." 11:34:03 <frosch123> let's check 11:34:23 <TrueBrain> T.I.M. 11:34:24 <frosch123> ah, yes, the "T.I.M." engine 11:34:24 <TrueBrain> lol 11:34:37 <TrueBrain> the others are typos, I guess 11:34:47 <TrueBrain> The parameters of the xUSSR set. 11:34:54 <TrueBrain> that makes little sense to have a dot there in the title :) 11:35:05 <frosch123> yes, they are just translations of whole sentences :) 11:35:14 <frosch123> but "CS-Inc." is the same as "T.I.M." 11:35:17 <TrueBrain> but okay, only lstrip on dot it is :) 11:35:44 <frosch123> again, same evolution in the conversion scripts :p 11:37:42 <TrueBrain> :D 11:37:43 <TrueBrain> updated the PR 11:38:09 <frosch123> TrueBrain: i think leading / and // are also invalid, so the split loop could check for part.strip() == "" 11:40:24 <TrueBrain> good point 11:40:30 <TrueBrain> now I really need to rewrite this function, but okay 11:40:33 <TrueBrain> pushed a new version for now 11:41:02 <TrueBrain> I split off the "ending with /" and "starting with /", as that requires a different message to make clear to the user what is going on 11:44:00 <frosch123> such magic :) 11:44:20 <TrueBrain> and now it is a lot more readable :P 11:44:25 <TrueBrain> applied some DRY 11:45:24 <TrueBrain> right, now lunch, after lunch ... htmlencode and urlescape ... that will be FUN! 11:45:26 <TrueBrain> (NOT) 11:46:55 <frosch123> (" ",) <- what emoticon is that? :) 11:47:06 <TrueBrain> :D 11:47:10 <TrueBrain> ghehe :D 11:47:47 <TrueBrain> why doesn't GitHub cancel actions of an earlier PR, I wonder .. 11:47:53 <TrueBrain> or why is that not configurable 11:48:04 <TrueBrain> it is now running 10+ CodeQL checks on outdated commits 11:49:28 <frosch123> maybe they think they charge for each one 11:57:47 *** Progman has quit IRC 11:58:21 <andythenorth_> oof 11:58:23 <andythenorth_> is it lunch? 11:58:30 *** Progman has joined #openttd 12:06:00 <frosch123> breakfast? 12:08:04 <andythenorth_> achieved that already 12:08:08 <andythenorth_> badge unlocked 12:10:00 * andythenorth_ deletes and adds ships 12:10:04 <frosch123> some daily quets are pretty grindy 12:10:08 <andythenorth_> yeah 12:10:25 <andythenorth_> I have some annoying reminders about missions 12:10:36 <andythenorth_> and at the end there's no level up, it's just a silly badge 12:10:42 <andythenorth_> then do it all again tomorrow 12:21:04 <TrueBrain> bah, it is difficult to detect if the user made no change, yet hit the "save page" button :P 12:39:50 <DorpsGek_III> [OpenTTD/OpenTTD] smierlo opened issue #8338: Errornous subsidy for valuables https://git.io/Jkf3t 12:40:27 <TrueBrain> oef, supporting % in page names is a lot more tricky than it sounds ... 12:40:34 <TrueBrain> I get why mediawiki just bans %20 etc 12:40:50 <TrueBrain> it depends on where a pagename is used what you have to do with it 12:41:02 <TrueBrain> as in a href, you have to do different things,than anywhere else 13:00:13 <frosch123> is it not putting all hrefs through urlencode? 13:01:31 <TrueBrain> but finding all the places to do so, that is the issue :D 13:03:54 <frosch123> 7 in wikitexthtml, 7 in truewiki. what am i missing? 13:05:00 <frosch123> i guess img src :) 13:05:28 <TrueBrain> check templates/ in truewiki :) 13:06:01 <frosch123> is there a urlencode parser function? 13:06:36 <TrueBrain> urllib.parse.quote 13:07:13 <frosch123> i mean for wikitext. {{urlencode|/edit/{{FULLPAGENAME}}}} 13:07:29 <frosch123> something to use in templates/ 13:08:38 <TrueBrain> so you now understand why I say it is tricky :) 13:08:56 <TrueBrain> you have to deal with HTML escaping and URL quoting 13:08:59 <TrueBrain> and .. ugh .. 13:09:07 <TrueBrain> but I am slowly working my way through it, don't worry 13:09:11 <TrueBrain> I just get why mediawiki bans it 13:09:26 <frosch123> ok, may python be with you :) 13:15:22 *** sla_ro|master has quit IRC 13:17:40 <TrueBrain> a page named "test&%20test and & this % with" seem to be the best test case out there :P 13:24:05 <frosch123> add " and ', unless you banned both 13:29:43 <TrueBrain> only " 13:29:45 <TrueBrain> ' is allowed 13:29:47 <TrueBrain> and good point 13:35:09 <TrueBrain> hmm .. "used on page" only detects templates 13:35:13 <TrueBrain> not pages linking to you 13:35:19 <TrueBrain> so you can rename a page, even so other pages link to you 13:35:46 <TrueBrain> not even indexed, which pages link to you 13:35:47 <TrueBrain> well, for 1.1 13:36:00 <frosch123> mediawiki add a "(linked)" or "(transcluded)" after every what-links-here item 13:36:32 <TrueBrain> so you can now rename pages that we most likely don't want to have renamable :) 13:37:12 <frosch123> adding redirects is easier, but messier :) 13:37:49 <TrueBrain> messier, yes :) 13:38:02 <TrueBrain> I would prefer if we can avoid any redirect system, honestly 13:39:01 <TrueBrain> new page: en/test&%20test and & this % with ' and the end 13:39:02 <TrueBrain> haha 13:39:53 <TrueBrain> okay, now to test images .. 13:55:37 <TrueBrain> right ... longest I took to fix any bug in TrueWiki so far :P 14:03:31 <TrueBrain> https://github.com/TrueBrain/TrueWiki/pull/39/commits/6162521634766b82647100edb06ff2a6b1ea8198 14:03:33 <TrueBrain> PFFFFFTTTTTT 14:03:34 <TrueBrain> but it works 14:03:45 <TrueBrain> pretty sure I forgot some src/href somewhere :) 14:04:06 <TrueBrain> but even the GitHub history URLs should work :) 14:06:56 <frosch123> haha, let's hope there is no githubencode :) 14:07:00 <FLHerne> Thoughts on a "Tooling: " or so commit prefix? 14:07:19 <FLHerne> For changes to actions, flake8 rules, blah 14:07:58 <FLHerne> It seems a bit odd to be writing Add/Fix/Codechange etc. for things that aren't actually part of the deployed codebase 14:08:06 <TrueBrain> what we do in other repos, is still tell if it is an Add or Fix or what-ever, and add a [Actions] after the : 14:08:22 <TrueBrain> because you are fixing the Actions, for example 14:08:28 <FLHerne> NML is the same, I was just wondering if we should keep doing that :p 14:08:40 <TrueBrain> well, in your reasoning, the commits should not show up, basically :) 14:08:54 <TrueBrain> but git log has little to do with the deployed codebase tbh 14:09:27 <TrueBrain> but adapting a more modern commit messages would also solve it .. but we had that debate a few months ago :P 14:09:31 <TrueBrain> were a lot of NAYs :) 14:09:48 <TrueBrain> as I would call it a chore() commit :P 14:10:28 <FLHerne> "more modern"? 14:11:09 <TrueBrain> lot of projects switched to a commit message format which allows tooling to create changelogs etc 14:11:35 <TrueBrain> they use the "type(scope): subject" format 14:11:58 <TrueBrain> one of the types is "build", or "ci", or "docs" 14:12:17 <TrueBrain> it allows you to make commits as feat(), meaning they should be highlighted in the changelog 14:12:31 <TrueBrain> https://nitayneeman.com/posts/understanding-semantic-commit-messages-using-git-and-angular/ is a pretty decent write-up about that 14:13:25 <TrueBrain> basically, the type splits the commits in "development" and "production" changes 14:13:43 <TrueBrain> what you referred to as "deployed codebase", I guess 14:14:17 <FLHerne> Nope, I don't like that format :p 14:14:27 <TrueBrain> I am in no way surprised ;) 14:14:37 <TrueBrain> but this is what many many projects are currently using :) 14:15:28 <TrueBrain> getting to change #openttd in any of this is like trying to move a building ....... :P 14:16:21 <TrueBrain> frosch123: https://wiki.staging.openttd.org/File/en/Community/NewGRF/AT&SF%205000.png <- w00p, & didn't break anything :D 14:17:50 <TrueBrain> https://wiki.staging.openttd.org/en/test%20&%20and%20%2520%20and%20' 14:18:34 <FLHerne> TrueBrain: What you need is a set of those modular transporter thingies with hundreds of little wheels, then 14:18:45 <FLHerne> Perhaps andy can draw some for you 14:18:50 <TrueBrain> FLHerne: :D 14:20:17 <frosch123> what that filesize thingie always there? 14:22:20 <TrueBrain> well, "always" is such a weird word to use :P 14:22:27 <TrueBrain> but I added it when I created the File pages 14:22:57 <TrueBrain> you don't like it, or? :) 14:22:58 <frosch123> didn't notice yet :) 14:23:39 <TrueBrain> mediawiki had it, and I liked it enough to add it 14:24:03 <TrueBrain> although I am using the correct SI units 14:24:09 <TrueBrain> mediawiki has a weird opinion about those :P 14:24:45 <TrueBrain> although ... hmm, no, I pretty sure I divided by 1024 ... still wrong :P 14:24:56 <frosch123> kiB :) 14:24:59 <TrueBrain> well, mediawiki is more wrong :P 14:25:05 <TrueBrain> (they use KB) 14:25:08 <TrueBrain> no clue what KB is .. 14:25:11 <TrueBrain> it is not SI at least :) 14:25:26 <TrueBrain> isn't it KiB btw? Let me check 14:25:38 <TrueBrain> it is 14:25:52 <frosch123> that's weird 14:26:07 <frosch123> so it's not just "insert 'i' where it looks funny" 14:26:38 <frosch123> TrueBrain: mediawiki uses JEDEC obviously :p 14:27:10 <TrueBrain> hahaha, yeah .. right :P 14:27:22 <TrueBrain> owh,it is not even SI, it is IEC 14:27:23 <TrueBrain> fine 14:28:40 <TrueBrain> right, fix is being deployed :) 14:28:43 <TrueBrain> that is how we roll :) 14:29:05 <TrueBrain> ignoring the "git push", I think this is ready to be tested 14:29:10 <TrueBrain> see if people can break it :P 14:47:34 *** glx has joined #openttd 14:47:34 *** ChanServ sets mode: +v glx 14:57:12 *** longtomjr has joined #openttd 15:13:23 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on issue #8338: Errornous subsidy for valuables https://git.io/Jkf3t 15:13:23 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 closed issue #8338: Errornous subsidy for valuables https://git.io/Jkf3t 15:20:53 <frosch123> editing templates without proper preview is so frustrating on mediawiki... i have such high hopes for truewiki :) 15:38:42 <Eddi|zuHause> wait... it's not called "nowiki"? :p 15:44:50 <FLHerne> yawiki? 15:45:49 <FLHerne> WIKI Interactive Knowledge Interface? 15:48:57 <FLHerne> OpenMW? (wait, that's taken) 16:04:12 <andythenorth_> FLHerne can you find any dedicated ships for carrying plastic pellets, grain, etc? :P 16:04:30 <andythenorth_> I can only find pneumatic-discharge cement carriers 16:06:15 <longtomjr> andythenorth_, https://www.youtube.com/watch?v=bZ28MKp-3M4 16:07:03 <longtomjr> https://en.wikipedia.org/wiki/Algoma_Equinox 16:07:07 <andythenorth_> is that a regular bulker? 16:07:21 <longtomjr> dunno, reading the wikipedia page now 16:07:43 <longtomjr> Owned by the Canadian ~Weed~ Wheat board 16:08:12 <andythenorth_> there are a few on the Snake River in Idaho https://www.sciencephoto.com/media/154682/view/grain-barges 16:09:24 <longtomjr> I find plastic pellets linked to container ships 16:10:43 <longtomjr> andythenorth_, some reading required, but they go into what is required for bulk grain ships https://www.handybulk.com/grain-shipping 16:12:38 <longtomjr> This process may be carried far enough to cause the growth of moulds and bacteria and, in the case of grain, to cause sprouting. Ship malted wiskey 16:12:53 <longtomjr> (that sentance were meant to be in quotes) 16:13:19 <andythenorth_> I can't find any ship equivalent of https://en.wikipedia.org/wiki/Covered_hopper 16:13:27 <longtomjr> andythenorth_, here is a infographic that you can use to see a 3d model of the Equinox class 16:13:28 <longtomjr> https://web.archive.org/web/20140106222034/http://www.algonet.com/Business-Units/Domestic-Shipping/Fleet-Renewal/Equinox-Class/Tour-the-Equinox-Class/ 16:13:38 <longtomjr> it will take some time to load since webarchive 16:14:23 <longtomjr> Looks like the Equinox is used for Grain and Iron Ore from some articles 16:16:01 <longtomjr> Seems like it does grain one way, and the ore on the return 16:16:54 <longtomjr> Is this helping? 16:17:09 *** Speeder_ has quit IRC 16:18:19 <Eddi|zuHause> longtomjr: sounds like a regular bulker, then 16:18:29 <longtomjr> with covers 16:19:53 <longtomjr> Hmm, seems like big bulk ships does have hatchcovers pretty commonly 16:20:35 <andythenorth_> mini-bulkers sometimes don't 16:20:39 <longtomjr> it might just be the barges that does not. 16:20:40 <andythenorth_> if used on rivers and lakes 16:21:51 <longtomjr> Are you looking to split up bulk carriers between cargo lines? 16:22:12 <andythenorth_> maybe 16:22:17 <andythenorth_> it's 50:50 16:22:43 <andythenorth_> might do covered bulker for sheltered cargos 16:23:29 <longtomjr> Maybe do a set of small bulkers, where there are covered and uncovered veriaties, and then have the big ones all be the same? 16:25:37 <longtomjr> Then you have a split on the lower end of the capacities, but a merged line for the big ones? 16:25:42 <longtomjr> Or is that too confusing? 16:27:05 <longtomjr> this is nice: https://www.dreamstime.com/royalty-free-stock-photography-tug-boat-grain-barge-image25320377 16:27:22 <longtomjr> https://kids.britannica.com/students/assembly/view/118331 16:29:43 <longtomjr> http://www.feedandgrain.com/images/uploads/_framed/barge-uAIltCv2-650-433.jpg 16:44:22 *** Wormnest has joined #openttd 16:45:08 <andythenorth_> very definitely covered 16:49:22 <frosch123> what... 556, did not expect that 16:50:08 <frosch123> changing 2 templates halfed the number of errors :p 16:51:58 <TrueBrain> Almost there :D 16:53:33 <frosch123> it's so random. sometimes i change something and think "this will reduce a lot", and then it's like -50 errors. and then you change something because it annoys you, and it changes a lot 17:04:27 <TrueBrain> The shitshow we call wikitext :p 17:10:35 *** glx is now known as Guest5307 17:10:35 *** glx_ has joined #openttd 17:10:35 *** glx_ is now known as glx 17:10:35 *** ChanServ sets mode: +v glx 17:17:34 *** Guest5307 has quit IRC 17:31:45 *** arikover has joined #openttd 17:51:39 <DorpsGek_III> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/Jkf9C 17:51:39 <DorpsGek_III> - Update: Translations from eints (by translators) 18:09:00 *** andythenorth_ has quit IRC 18:30:07 *** andythenorth has joined #openttd 18:43:49 <DorpsGek_III> [OpenTTD/master-server-web] TrueBrain opened pull request #16: Fix: make sorting of servers a bit more robust https://git.io/JkfQ7 18:44:20 <TrueBrain> to proof people don't notify us when things break, turns out there were over 150 error events triggered by a server of which we failed to parse the version correctly .... and sentry didn't have alerts setup on that project, for what-ever reason :P 18:44:25 <TrueBrain> but okay, this should fix that :D 18:45:26 <TrueBrain> all other repos do have alerts setup 18:45:32 <TrueBrain> Sentry can be a bit annoying in configuring projects :D 18:48:09 *** glx_ has joined #openttd 18:48:10 *** glx is now known as Guest5316 18:48:10 *** glx_ is now known as glx 18:52:52 <frosch123> TrueBrain: there are some File: pages that link to LICENSE 18:52:56 <frosch123> what to do with that? 18:53:07 <frosch123> is there a url that works? or should i move the license? 18:54:39 <TrueBrain> well, we should have a license in the root for GitHub. But that should be in Markdown, as that means GitHub can render it 18:54:44 *** Guest5316 has quit IRC 18:54:56 <TrueBrain> and either we make an exception for License to be on /License, or we move it into Page/en/ 18:55:01 <TrueBrain> but I am afraid people will try to translate it 18:55:52 <frosch123> https://github.com/frosch123/gollum-test-data/blob/master/LICENSE.mediawiki <- markdown is not needed 18:56:09 <frosch123> (i got there via githubs "license" link) 18:56:27 <TrueBrain> wuth, GitHub can render wikitext? 18:56:28 <TrueBrain> lol 18:56:42 <frosch123> same as github wiki 18:56:48 <frosch123> but it's the same broken wikicloth 18:56:51 <TrueBrain> ah 18:56:53 <TrueBrain> okay 18:56:57 <TrueBrain> so I can make this a special URL, sure 18:57:45 <TrueBrain> at /License good ? 18:57:53 <frosch123> yep 18:59:10 *** lastmikoi has quit IRC 19:01:41 *** lastmikoi has joined #openttd 19:04:02 *** iSoSyS has quit IRC 19:05:10 <frosch123> 347 :) 19:05:18 <frosch123> i like this andy game 19:06:19 <DorpsGek_III> [OpenTTD/nml] FLHerne updated pull request #168: WIP: Various CodeQL fixes https://git.io/JTbA9 19:07:01 <andythenorth> it's a good game 19:08:30 <TrueBrain> frosch123: want to do something else for a bit? https://github.com/OpenTTD/master-server-web/pull/16 could use a review :P 19:09:08 <andythenorth> I don't think we've played 'newgrf spec' enough recently :P 19:09:10 <andythenorth> oof 19:09:38 <TrueBrain> and https://github.com/TrueBrain/TrueWiki/pull/41 is in the process of being merged / going to staging, that should resolve the license issue :) 19:10:02 <TrueBrain> hmm .. you can now only not link to it with [[License]] or something 19:10:57 <TrueBrain> well, you somewhat can, but it is not seen as a valid page, I guess .. I can fix that 19:11:43 <DorpsGek_III> [OpenTTD/nml] FLHerne updated pull request #168: CodeQL fixes and other misc. cleanups https://git.io/JTbA9 19:13:14 *** rptr_ has joined #openttd 19:13:20 <TrueBrain> okay, frosch123 , I assumed it would be [[License]] . If so, that will work :) 19:13:36 <frosch123> yes, i already pushed that 19:14:02 <frosch123> TrueBrain: isnumeric() looks really wrong, but isdigit() is not much better 19:14:12 <frosch123> possibly isdigit() && isascii() may work 19:14:52 <TrueBrain> it is a shitshow left or right 19:14:55 <TrueBrain> does it matter, I wondered 19:15:21 <TrueBrain> isdecimal() might be better, but .. meh 19:17:16 <DorpsGek_III> [OpenTTD/master-server-web] TrueBrain updated pull request #16: Fix: make sorting of servers a bit more robust https://git.io/JkfQ7 19:17:59 <TrueBrain> isdecimal() works fine for this usecase :) 19:18:27 <frosch123> i think the last return is missing an item 19:18:29 <TrueBrain> (as int() on that works :P) 19:18:36 <frosch123> it return 6 items now, right? 19:18:45 <frosch123> *should 19:18:50 <andythenorth> https://packaging.pypa.io/en/latest/version/ probably doesn't solve those cases 19:18:58 <TrueBrain> frosch123: you are correct! 19:18:59 <DorpsGek_III> [OpenTTD/master-server-web] TrueBrain updated pull request #16: Fix: make sorting of servers a bit more robust https://git.io/JkfQ7 19:19:31 <TrueBrain> int("０") works :) 19:19:32 <TrueBrain> that is not a 0 19:19:37 <TrueBrain> funny 19:20:00 <TrueBrain> int("༠༡") 19:20:02 <TrueBrain> works too :D 19:20:22 <frosch123> be careful, you may be identified as spambot 19:20:28 <TrueBrain> good point :) 19:20:34 <TrueBrain> frosch123: pushed /License to TrueWiki 19:20:53 <TrueBrain> should solve a few more on your list :D 19:22:00 <DorpsGek_III> [OpenTTD/master-server-web] frosch123 approved pull request #16: Fix: make sorting of servers a bit more robust https://git.io/Jkfdc 19:22:15 <TrueBrain> cheers frosch123 19:23:19 *** argoneus has quit IRC 19:23:32 *** argoneus has joined #openttd 19:24:09 <DorpsGek_III> [OpenTTD/nml] FLHerne updated pull request #168: CodeQL fixes and other misc. cleanups https://git.io/JTbA9 19:30:04 <DorpsGek_III> [OpenTTD/master-server-web] TrueBrain merged pull request #16: Fix: make sorting of servers a bit more robust https://git.io/JkfQ7 19:30:19 <DorpsGek_III> [OpenTTD/master-server-web] TrueBrain created new tag: 1.0.6 https://git.io/Jkfd7 19:34:33 <TrueBrain> right, that should prevent the server list from crashing :D 19:37:15 *** jottyfan has quit IRC 19:48:15 *** DasPoseidon has joined #openttd 19:48:34 *** longtomjr has quit IRC 19:51:18 <DorpsGek_III> [OpenTTD/nml] FLHerne commented on pull request #168: CodeQL fixes and other misc. cleanups https://git.io/Jkfbe 19:52:46 <FLHerne> (should be 'done' for review now) 20:01:54 <DorpsGek_III> [OpenTTD/nml] LordAro approved pull request #168: CodeQL fixes and other misc. cleanups https://git.io/Jkfb6 20:02:31 <DorpsGek_III> [OpenTTD/nml] FLHerne merged pull request #168: CodeQL fixes and other misc. cleanups https://git.io/JTbA9 20:02:39 <FLHerne> LordAro: thanks 20:04:53 <LordAro> have to do actual changes now :p 20:06:04 <FLHerne> Yeah, but now I can do that without fear of rebase hell :F 20:06:17 <LordAro> ^^ 20:06:38 *** sla_ro|master has joined #openttd 20:07:40 <FLHerne> Oh, the one more mega-change I wanted was to use f-strings 20:08:15 <frosch123> f-strings are such a mis-feature :/ 20:09:22 <FLHerne> They're amazing 20:09:23 <frosch123> but tb also uses them, so i have to wait for the next cycle of "mixing code and formatting is bad" 20:10:44 <frosch123> old-print, c-printf, c++-iostream, python-print, python-f-strings, what's next? 20:11:45 <Xaroth> fstrings improves readability a lot 20:12:01 *** HerzogDeXtEr has quit IRC 20:12:58 <LordAro> indeed 20:13:37 <LordAro> though i will occasionally use format strings for the more complicated ones 20:13:45 *** jottyfan has joined #openttd 20:13:49 <LordAro> traditional format strings, that is 20:13:51 <frosch123> i am just amazed that c++20 finally gained a pythonic print method. and now python goes to make the same mistakes as c++iostreams did before :) 20:14:31 <frosch123> they switched places :p 20:17:22 <LordAro> i'm not sure they're really equivalent 20:18:07 *** tokai|noir has joined #openttd 20:18:07 *** ChanServ sets mode: +v tokai|noir 20:21:17 <frosch123> it's more obvious when you do not take raw strings, but something like sqalchemy, where you need to preprocess/escape parameters 20:21:59 <frosch123> c++ and java are full of sql injections, because they just do "WHERE a='" + b + "'..." 20:22:14 <frosch123> sqalchemy is amazing by providing print-like methods to compose them 20:22:33 <LordAro> i'm not sure .format() vs fstring changes that much 20:22:33 <frosch123> f-strings are the opposite. i expect more code-injection issues with them 20:24:57 *** tokai has quit IRC 20:29:11 <dwfreed> You should be using any kind of formatting with SQL 20:29:59 <dwfreed> but f-strings are so much nicer to work with when composing strings that don't go to SQL 20:36:46 *** WormnestAndroid has quit IRC 20:37:00 *** WormnestAndroid has joined #openttd 21:04:14 *** rptr_ has quit IRC 21:13:39 *** WormnestAndroid has quit IRC 21:13:48 *** WormnestAndroid has joined #openttd 21:16:14 *** jottyfan has quit IRC 21:19:09 *** jottyfan has joined #openttd 21:50:59 <TrueBrain> SQL is the problem, not however you replace strings tbfh 21:51:40 <TrueBrain> SQL language is by concept an insecure language.. lucky enough, more and more alternatives are in the make :) 21:54:35 <andythenorth> silly SQL designers 21:54:50 <andythenorth> they should have put 'unsecured user input from the global population' into the spec 21:55:15 <andythenorth> clearly incompetent 21:55:16 <TrueBrain> Happens with old languages :) 21:55:31 <andythenorth> it's only 46 years old 21:55:40 <andythenorth> they should have done more scoping and requirements 21:55:40 <TrueBrain> Alternatives are only a bit slow getting there .... 21:55:50 <andythenorth> oh wait 21:55:55 * andythenorth back to ebay 21:58:17 <frosch123> 192 21:59:39 <frosch123> next round is editing the wiki again :/ 21:59:55 <TrueBrain> Good luck 22:00:16 <frosch123> sounds like a thing for tomorrow 22:02:10 <TrueBrain> Sleep well 22:03:30 *** DasPoseidon has quit IRC 22:03:47 *** glx_ has joined #openttd 22:03:47 *** glx is now known as Guest5323 22:03:48 *** glx_ is now known as glx 22:08:09 *** TinoDidriksen has quit IRC 22:09:00 *** debdog has joined #openttd 22:09:39 *** frosch123 has quit IRC 22:09:39 *** gretel[m] has quit IRC 22:09:44 *** robert[m] has quit IRC 22:09:44 *** cyberjunkie[m] has quit IRC 22:09:45 *** grossing has quit IRC 22:09:49 *** cawal[m] has quit IRC 22:10:14 *** patricia[m] has quit IRC 22:10:19 *** D-HUND has quit IRC 22:10:20 *** TinoDidriksen has joined #openttd 22:10:24 *** Guest5323 has quit IRC 22:10:51 *** TinoDidriksen is now known as Guest5335 22:15:30 *** gelignite has quit IRC 22:16:07 *** robert[m] has joined #openttd 22:21:19 *** Wolf01 has quit IRC 22:27:45 *** Guest5335 is now known as TinoDidriksen 22:34:17 *** Progman has quit IRC 22:36:19 *** grossing has joined #openttd 22:45:27 <andythenorth> 'pseudo-realistic' :P 22:45:29 * andythenorth planning 22:45:42 *** m1cr0man has quit IRC 22:51:29 *** cyberjunkie[m] has joined #openttd 22:52:43 *** m1cr0man has joined #openttd 22:53:29 *** andythenorth has quit IRC 23:07:50 <DorpsGek_III> [OpenTTD/OpenTTD] TinCanTech reopened issue #8336: [Game play] Vehicle disasters should always be banner headlines. https://git.io/JTjuk 23:08:55 <DorpsGek_III> [OpenTTD/OpenTTD] TinCanTech commented on issue #8336: [Game play] Vehicle disasters should always be banner headlines. https://git.io/JTjuk 23:12:12 *** patricia[m] has joined #openttd 23:22:31 *** arikover has quit IRC 23:23:40 *** gretel[m] has joined #openttd 23:24:18 *** cawal[m] has joined #openttd 23:40:17 *** nielsm has quit IRC 23:55:01 *** tokai|noir has quit IRC