Times are UTC Toggle Colours
00:00:36 <TrueBrain> you also seen " Warning: ..\src\autoreplace_gui.cpp(420): warning C4267: 'initializing': conversion from 'size_t' to 'EngineID', possible loss of data" ? Not sure it is your PR 00:00:52 <glx> yeah I was thinking about that 00:01:49 <TrueBrain> right, I should be in bed; night :) 00:01:58 <DorpsGek> [OpenTTD/OpenTTD] LordAro dismissed a review for pull request #8502: Codechange: Remove min/max functions in favour of STL variants https://git.io/JLxyr 00:02:01 <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #8502: Codechange: Remove min/max functions in favour of STL variants https://git.io/JLNcq 00:02:07 <LordAro> i'll take a look 00:03:41 <glx> maybe it is, as the warning is not in master 00:04:00 <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #8502: Codechange: Remove min/max functions in favour of STL variants https://git.io/JLNcq 00:04:00 <LordAro> yeah, it's a std::min line 00:04:12 <LordAro> add casts until the warnings go away 00:11:57 <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #8502: Codechange: Remove min/max functions in favour of STL variants https://git.io/JLNcq 00:12:55 <TrueBrain> Now it is glx' turn to approve :p 00:13:54 <glx> I'll wait for CI first :) 00:14:32 <TrueBrain> Noooo, that is against the flow!! :p 00:17:36 <glx> more warnings, and still fails :) (town_cmd.cpp) 00:19:04 <LordAro> D: 00:19:43 <LordAro> the differing behaviour is really quite interesting 00:19:57 <glx> maybe I can just try to fix them locally 00:22:02 <LordAro> heh, probably 00:22:09 <LordAro> let me suffer a bit more first 00:22:35 <LordAro> for one, the line number for town_cmd.cpp doesn't match 00:22:48 <LordAro> error is 3332, std::min is 3335 00:22:59 <LordAro> and both arguments are the same type 00:24:47 <DorpsGek> [OpenTTD/OpenTTD] LordAro updated pull request #8502: Codechange: Remove min/max functions in favour of STL variants https://git.io/JLNcq 00:30:03 <LordAro> glx: ok, i give in 00:30:05 <LordAro> can you take a look? 00:32:30 <DorpsGek> [OpenTTD/OpenTTD] Milek7 opened pull request #8522: Codechange: Use access __attribute__ to silence warnings in GCC https://git.io/JLx9Q 00:33:46 <glx> yeah I don't see where 3332 comes, it's 3306 00:34:34 <glx> may explain why you can't fix it ;) 00:35:06 <LordAro> doesn't help 00:36:21 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #8522: Codechange: Use access __attribute__ to silence warnings in GCC https://git.io/JLxHe 00:36:58 <DorpsGek> [OpenTTD/OpenTTD] Milek7 commented on pull request #8522: Codechange: Use access __attribute__ to silence warnings in GCC https://git.io/JLxHf 00:37:36 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #8522: Codechange: Use access __attribute__ to silence warnings in GCC https://git.io/JLxHI 00:39:03 *** DasPoseidon has quit IRC 00:40:39 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8522: Codechange: Use access __attribute__ to silence warnings in GCC https://git.io/JLxHl 00:40:49 <DorpsGek> [OpenTTD/OpenTTD] LordAro merged pull request #8522: Codechange: Use access __attribute__ to silence warnings in GCC https://git.io/JLx9Q 00:51:26 <milek7> urgh 00:51:37 <milek7> now I created more warnings "unknown attribute 'access' ignored" 00:51:38 <milek7> :( 00:51:48 <milek7> (in older compilers) 00:53:15 <LordAro> ah crap 00:53:46 <LordAro> take GCC version into account in the macro pls 01:00:52 <glx> ok with a simple change it compiles 01:01:17 <glx> now the 224 warnings (many are just langfiles) 01:01:23 <Eddi|zuHause> all changes are simple. just a bunch of letters :p 01:04:54 <DorpsGek> [OpenTTD/OpenTTD] Milek7 opened pull request #8523: Codechange: Check if access __attribute__ is supported before trying to use it. https://git.io/JLxHj 01:07:59 *** Flygon has joined #openttd 01:42:14 <DorpsGek> [OpenTTD/OpenTTD] Milek7 updated pull request #8391: RFC: Feature: Public key company authorization https://git.io/JLnig 01:47:09 *** jottyfan has quit IRC 01:50:47 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #8502: Codechange: Remove min/max functions in favour of STL variants https://git.io/JLNcq 01:52:34 *** roadt__ has quit IRC 01:54:29 *** roadt__ has joined #openttd 02:11:22 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #8502: Codechange: Remove min/max functions in favour of STL variants https://git.io/JLx5S 03:13:13 *** Wormnest has quit IRC 03:15:35 *** D-HUND has joined #openttd 03:18:58 *** debdog has quit IRC 03:55:22 *** glx has quit IRC 04:22:18 *** tejanos has joined #openttd 06:20:14 *** FLHerne has quit IRC 06:20:58 *** FLHerne has joined #openttd 06:55:22 *** tejanos has quit IRC 07:21:06 *** sla_ro|master has joined #openttd 07:42:04 *** snail_UES_ has quit IRC 08:29:10 *** DasPoseidon has joined #openttd 08:32:49 *** Smedles has quit IRC 08:33:45 *** Smedles has joined #openttd 08:53:41 *** andythenorth has joined #openttd 09:12:28 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8523: Codechange: Check if access __attribute__ is supported before trying to use it. https://git.io/JLpJi 09:12:38 <TrueBrain> LordAro: coding style seems off? 09:12:41 <DorpsGek> [OpenTTD/OpenTTD] LordAro merged pull request #8523: Codechange: Check if access __attribute__ is supported before trying to use it. https://git.io/JLxHj 09:12:43 <TrueBrain> (I was about to comment on that :P) 09:12:58 <TrueBrain> gave me no time at all :'( 09:13:00 <DorpsGek> [OpenTTD/OpenTTD] orudge updated pull request #8340: Draft: Feature: Create Universal (x86_64 + Apple Silicon) build on macOS https://git.io/JkqLt 09:13:03 <LordAro> oh no 09:13:32 <TrueBrain> it is what it is :D 09:14:55 <TrueBrain> static_cast<uint>(std::min<size_t>( <- wow, that is a lot of casting 09:15:40 <andythenorth> le oof 09:15:45 * andythenorth woke up 09:15:50 <TrueBrain> LordAro: shall I rebase your std::min/max for you? 09:16:01 <TrueBrain> (to merge glx' work so it passes CI) 09:16:39 <LordAro> sure 09:16:45 <LordAro> or do it better :p 09:17:21 <TrueBrain> I wouldn't know how :) 09:17:37 <andythenorth> oof triggered https://www.tt-forums.net/viewtopic.php?p=1240214#p1240214 09:17:41 <andythenorth> can someone reply to that 09:17:59 * andythenorth has just deleted the "I have no idea what this complete crap you've posted is" 09:18:06 <andythenorth> doesn't help 09:18:45 <andythenorth> I hate these whiney twats who turn up out of context and complain that "popular people get special treatment" 09:20:12 <LordAro> "can you please clarify ..." 09:20:31 <TrueBrain> tl;dr: he had a meltdown, because he felt there was injustice. He burned bridges to get to his "right", and it was all caused because he was being an ass to the author, and the author did not really understand what was going on (the author clearly doesn't speak English as a native language) 09:21:26 <TrueBrain> if you want to have a good read, open DIscord, #development, last night 09:22:20 <andythenorth> I haven't had had coffee yet 09:23:24 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #8502: Codechange: Remove min/max functions in favour of STL variants https://git.io/JLNcq 09:24:32 <TrueBrain> the irony is, that he himself posted work that clearly violated licenses weeks before; but that was okay, as someone else was also not following licensing. I think that sums up the story nicely 09:25:27 <andythenorth> I wrote 'please explain' 09:25:35 <andythenorth> coffee time! 09:25:39 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #8502: Codechange: Remove min/max functions in favour of STL variants https://git.io/JLpUt 09:30:01 <TrueBrain> let's see if I can fix that annoying Windows warning ... if we can get ride of all the warnings, we can make warnings fail CI .. that would be swell :D 09:30:19 <TrueBrain> now too easy overlooked :D 09:32:04 <LordAro> aye 09:32:15 <LordAro> feasible to do that now 09:33:40 <TrueBrain> well, there are 2 things we can do: -Werror on all targets, but I was also thinking: enable a post github workflow check, that tells when there was any warning in any job 09:34:01 <TrueBrain> not sure about the first 09:34:06 <TrueBrain> the last has this annoying 'tar' issue :P 09:45:06 <TrueBrain> bah; GNU tar is not compatible with "save-cache" 09:45:14 <TrueBrain> tar: c:\vcpkg: Cannot stat: No such file or directory 09:45:23 <TrueBrain> no clue where that extra \ is coming from :D 09:49:08 <TrueBrain> andythenorth: if you think your commit messages are so-so, check this: https://github.com/lukka/run-vcpkg/commit/a1b6a0046a28c09f4bcc8caa9eecec9a8e512152 :D 09:49:40 <andythenorth> ooh that's a nice one 09:49:57 <andythenorth> being strict, have they just squashed a load of things there? 09:51:51 <TrueBrain> yeah 09:52:08 <TrueBrain> https://github.com/lukka/run-vcpkg/pull/65 was the source 09:52:14 <TrueBrain> squash vs rebase vs merge :) 09:58:15 <TrueBrain> attrib -r "c:/vcpkg" /s 09:58:15 <TrueBrain> Parameter format not correct - 09:58:21 <TrueBrain> tnx ....... windows .... this is very clear now to me 10:09:48 <TrueBrain> LordAro: https://github.com/OpenTTD/OpenTTD/pull/8502 <- CI says yes .. merge? :D 10:09:59 <LordAro> could do! 10:11:53 <TrueBrain> \o/ 10:16:22 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8502: Codechange: Remove min/max functions in favour of STL variants https://git.io/JLNcq 10:16:28 <TrueBrain> this version so needs a beta now :P 10:17:01 <LordAro> my changelog is out of date now! 10:17:13 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed issue #8050: Scoring year is -1 when loading old savegame https://git.io/Jv7Ei 10:17:16 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8512: Several mistakes with ending-year and extreme values https://git.io/JLANI 10:18:54 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #8513: Fix: for arctic and tropic, make sure we have at least a few hills https://git.io/JLxrv 10:18:57 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #8513: Fix: for arctic and tropic, make sure we have at least a few hills https://git.io/JLxTc 10:20:12 <TrueBrain> haha, and is that a bad thing? :D 10:20:51 *** Compu has joined #openttd 10:20:52 <TrueBrain> bah, 2 PRs need rebasing, that already had approvals :P 10:21:00 *** Compu has quit IRC 10:21:44 <TrueBrain> he came, he saw, and he got the hell out of here 10:21:51 <TrueBrain> would it been personal you think? 10:24:11 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #8508: Fix #7656: destroying a tunnel/bridge now first removes the tracks for cost calculation https://git.io/JLxoE 10:24:14 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #8508: Fix #7656: destroying a tunnel/bridge now first removes the tracks for cost calculation https://git.io/JLARD 10:24:52 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #8516: Fix #7972: show invalid orders to stations that don't accept your vehicle https://git.io/JLxcf 10:25:06 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLx6I 10:25:41 <andythenorth> TrueBrain he saw your message and ran away 10:25:50 <TrueBrain> can't blame him 10:28:36 <TrueBrain> hmm ... run-vcpkg now doesn't want to cache for me .. that is annoying, how can I test if this works if it doesn't want to cache?! :P 10:31:55 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #8524: Fix: [Actions] remove read-only flag from c:\vcpkg https://git.io/JLpIE 10:32:02 <TrueBrain> so lets just try it in our own repo 10:37:31 <TrueBrain> seems to work :D 10:37:41 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #8524: Fix: [Actions] circumvent Windows tar warning about read-only files https://git.io/JLpIE 10:37:41 <TrueBrain> now to fix the silly commit message .. 10:38:32 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #8524: Fix: [Actions] circumvent Windows tar warning about read-only files https://git.io/JLpIy 10:39:11 <TrueBrain> did you seriously just not read the comments LordAro ? :D 10:39:33 <TrueBrain> I only did not want to link our issue to his, as .. GitHub 10:40:00 <TrueBrain> (lot of comments in workflow) 10:40:01 <TrueBrain> # In other words: this is a hack! 10:40:01 <TrueBrain> # See: https://github.com/lukka/run-vcpkg/issues/61 10:40:02 <TrueBrain> :) 10:43:07 <LordAro> i think you're being too averse to GH links :p 10:43:44 <LordAro> also, no, i just looked at the PR text :p 10:43:47 <TrueBrain> :D 10:44:01 <TrueBrain> I really really hate that GitHub makes all these cross-links without you asking it to 10:44:11 <TrueBrain> but I am happy I am not alone in this, as frosch also clearly dislikes that :) 10:44:35 <TrueBrain> just because I reference another ticket, doesn't mean it is interesting to the other ticket to know about that 10:45:08 <LordAro> eh, lets them know it's important to other people 10:46:52 <TrueBrain> if they would make it less annoying in the interface, I guess 10:46:59 <TrueBrain> but it is now just way too much in-your-face :) 10:47:40 <TrueBrain> anyway, more importantly: NO WARNINGS! 10:49:17 <LordAro> \o/ 10:52:31 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8524: Fix: [Actions] circumvent Windows tar warning about read-only files https://git.io/JLpLl 10:53:11 <TrueBrain> so, what is left for 1.11 .. 10:53:47 <TrueBrain> only 3 bugs I have on the list, of which I suspect we won't solve 2 for 1.11 10:55:13 <TrueBrain> that leaves https://github.com/OpenTTD/OpenTTD/pull/7286, which basically needs to be redone, https://github.com/OpenTTD/OpenTTD/pull/8169, which I have to read up about, and https://github.com/OpenTTD/OpenTTD/issues/7869, which seems like an easy fix 10:55:31 <TrueBrain> lets start with the second :) 10:56:09 <andythenorth> 8169 I understand the underlying issue, if that helps 10:56:13 <DorpsGek> [OpenTTD/OpenTTD] J0anJosep updated pull request #8480: Multitile depots https://git.io/JL5Hh 10:57:10 <LordAro> did anyone test the OSXI release build yet? 10:57:21 <LordAro> yes, i'm calling it OSXI to be annoying 10:57:54 <TrueBrain> LordAro: what do you mean? 10:58:18 <TrueBrain> if people tried the nightly MacOS build? 10:58:18 <LordAro> the build produced by the CI for the Apple Sillion 10:58:30 <LordAro> Sillion. yes. 10:58:38 <TrueBrain> the PR is still in Draft :) 10:58:43 <TrueBrain> the author is still working on that :) 10:58:50 <andythenorth> hmm, 8169 that attached save doesn't demonstrate the problem 10:58:50 <LordAro> no it isn't? 10:59:06 <TrueBrain> did he sneaky finish it without telling us? 10:59:17 <TrueBrain> pfft 10:59:26 <TrueBrain> owh, you removed Draft 10:59:39 <TrueBrain> that doesn't mean it is less of a draft :) 10:59:40 <LordAro> from the title, because it wasn't a Draft PR any longer 10:59:47 <LordAro> unless i've become confused 10:59:50 <TrueBrain> was it ever? :D 10:59:57 <LordAro> pretty sure it was... 11:00:14 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8508: Fix #7656: destroying a tunnel/bridge now first removes the tracks for cost calculation https://git.io/JLpLQ 11:00:26 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8513: Fix: for arctic and tropic, make sure we have at least a few hills https://git.io/JLpL7 11:00:30 <TrueBrain> I think he never hit the "this is a draft" button, honestly :) Anyway, last I heard, he was working on it :) 11:00:55 <TrueBrain> https://github.com/orudge/OpenTTD/actions <- like 11 minutes ago :) 11:01:00 <LordAro> consider it readded :) 11:01:04 <andythenorth> did we always have a depot refit order? 11:01:12 * andythenorth finds new bits of OpenTTD UI 11:01:36 <TrueBrain> but the new OSX targets are really annoying, as they don't have enough of them 11:01:41 <TrueBrain> so they stall a lot and often 11:01:46 <TrueBrain> makes testing SSLLOOWWWW as fuck 11:02:04 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #8519: [OSX] Render screen in full native resolution on HiDPI displays. https://git.io/JLpLj 11:02:10 <TrueBrain> andythenorth: if you have a savegame for me, that would be lovely 11:02:13 <andythenorth> 8169 the save is correct 11:02:17 <andythenorth> on the ticket 11:02:30 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed issue #7656: Bridge/tunnel remove cost does not take into account road/tram/rail remove cost. https://git.io/fj1vu 11:02:31 <andythenorth> it does work, the issue shown is a different one to my expectation 11:02:34 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8508: Fix #7656: destroying a tunnel/bridge now first removes the tracks for cost calculation https://git.io/JLARD 11:02:43 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed issue #6337: Mapgen: no tropical trees and no snow with default world generation settings https://git.io/JLpte 11:02:46 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8513: Fix: for arctic and tropic, make sure we have at least a few hills https://git.io/JLxTc 11:02:52 <TrueBrain> rgr 11:03:05 <TrueBrain> the one thing I do not like about that PR, that it is not throwing an error, but a news message 11:03:20 <TrueBrain> owh, auto-renew 11:03:21 <TrueBrain> fine 11:06:25 <TrueBrain> wow, that news pops up every time it tries autorenew? 11:06:30 <TrueBrain> damn, that is annoying 11:06:35 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #8518: [OSX] Replace FreeType by native glyph rasterization https://git.io/JLptn 11:07:50 <andythenorth> we never found a better way 11:08:16 <andythenorth> autorenew or autoreplace? 11:08:19 <TrueBrain> a new GUI! :) 11:08:29 <TrueBrain> auto-replace, sorry 11:08:31 <LordAro> autochange 11:08:47 <orudge> TrueBrain: sorry, trying to get it to actually build is proving fun, clearly a severe lack of agents... 11:08:48 <andythenorth> template replacement :P 11:08:52 <andythenorth> shadow off-screen vehicles 11:08:56 <TrueBrain> orudge: no need to be sorry :) 11:09:04 <TrueBrain> orudge: have you tried the older version, if that can produce binaries? 11:09:19 <orudge> Not yet, let me check the installed software list 11:11:01 *** tokai has joined #openttd 11:11:01 *** ChanServ sets mode: +v tokai 11:11:08 <TrueBrain> besides some coding-style thingies, I am fine with 8169. I just don't know enough about auto-replace to know if his function is correct 11:12:23 <DorpsGek> [OpenTTD/OpenTTD] orudge updated pull request #8340: Draft: Feature: Create Universal (x86_64 + Apple Silicon) build on macOS https://git.io/JkqLt 11:12:43 <orudge> OK, it seems that the 10.15 VMs do have the newer xcode and SDK on, and enabled by default 11:13:16 <orudge> so let's see how well that works 11:15:07 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #8169: Fix #8153: Report autoreplace failure when new vehicle cannot carry the cargo https://git.io/JfVAv 11:15:22 <TrueBrain> LordAro: if you can spare some cycles, would you mind looking at ^^ ? I can't tell if the code is doing what it should :) 11:15:36 <TrueBrain> andythenorth: you agree that this functionality is wanted? 11:15:44 <DorpsGek> [OpenTTD/OpenTTD] orudge updated pull request #8340: Draft: Feature: Create Universal (x86_64 + Apple Silicon) build on macOS https://git.io/JkqLt 11:16:11 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #8169: Fix #8153: Report autoreplace failure when new vehicle cannot carry the cargo https://git.io/JfVAv 11:17:09 <andythenorth> TrueBrain it addresses the reported issue in https://github.com/OpenTTD/OpenTTD/issues/8153 11:17:20 <andythenorth> I don't have much more opinion than that sorry 11:17:29 <andythenorth> I never encounter the issue, I don't play the game that way 11:17:33 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8169: Fix #8153: Report autoreplace failure when new vehicle cannot carry the cargo https://git.io/JLptN 11:17:55 <TrueBrain> I like explicit failures over silence 11:18:01 <TrueBrain> other autoreplace failures use news too 11:18:04 <andythenorth> yes 11:18:04 *** tokai|noir has quit IRC 11:18:07 <TrueBrain> text looks okay-ish 11:18:11 <andythenorth> I don't see anything controversial 11:18:12 <TrueBrain> so I am fine with the functionality myself 11:18:17 <andythenorth> if this is a mistake, we'll get told? 11:18:44 <TrueBrain> I am not scared of that :) I am just evaluating :) 11:20:16 <TrueBrain> owh, right, that heightmap PR did 10 things, I forgot 11:21:17 <TrueBrain> and I don't agree with 1/3rd of the PR, so that was the issue :D 11:21:48 <DorpsGek> [OpenTTD/OpenTTD] orudge updated pull request #8340: Draft: Feature: Create Universal (x86_64 + Apple Silicon) build on macOS https://git.io/JkqLt 11:21:52 <Heiki> /usr/local/src/openttd/src/strgen/../stdafx.h:142:62: error: attribute ‘access’ invalid mode ‘none’; expected one of ‘read_only’, ‘read_write’, or ‘write_only’ 11:22:18 <TrueBrain> cc --version Heiki ? :) 11:22:26 <Heiki> gcc version 10.2.1 20201224 (Debian 10.2.1-3) 11:22:31 <orudge> Apologies for the spam, I should probably push this to a non-PRed branch until it's working :D 11:22:51 <TrueBrain> orudge: who am I to tell you anything about spamming this channel with DorpsGek text :D 11:23:05 <TrueBrain> so "none" is GCC 11 only, I am guessing 11:23:22 <TrueBrain> things that sound like an easy change ... can easily lead to fix after fix after fix :D 11:23:28 <Heiki> haha 11:24:23 <TrueBrain> I can look into this after lunch; no clue what "access" does, so would need to read up on that first :) 11:28:42 <LordAro> linked in the original PR 11:31:04 *** WormnestAndroid has quit IRC 11:31:06 *** DasPoseidon has quit IRC 11:31:17 *** WormnestAndroid has joined #openttd 11:36:42 *** J0anJosep has joined #openttd 11:39:27 <orudge> Hurrah, a build at last 11:49:05 * Timberwolf stares into the abyss of road types drama. 11:50:07 <Timberwolf> I don't understand why that one small corner of newgrf development is such an ongoing tyre fire. 11:50:07 *** WormnestAndroid has quit IRC 11:50:21 *** WormnestAndroid has joined #openttd 11:52:13 <andythenorth> Timberwolf I could try and explain 11:54:24 * andythenorth remains baffled that JGR is somehow expected to support savegames from other patchpacks :P 11:54:31 <andythenorth> including ones featuring broken patches 11:54:38 <andythenorth> people! 11:54:40 <andythenorth> are amazing! 11:57:09 *** J0anJosep has quit IRC 11:57:19 <Timberwolf> Heh, yes. JGR has a lot of patience :) 11:57:24 <orudge> So, now we hit the next snag. I had read some articles about this, but it appears that Apple Silicon apps do indeed need to be signed to run. The previous workaround of right-clicking and holding down a key while opening doesn't work for Silicon. 11:57:31 <orudge> There is a workaround where you can de-quarantine an app and then it runs 11:57:48 *** J0anJosep has joined #openttd 11:57:58 <orudge> But for a reasonable user experience, we might need to get that "licensing" company set up and get an Apple Developer ID 11:58:18 <orudge> (I'm willing to do that as indicated previously) 12:03:59 * andythenorth procrastinating 12:06:07 <TrueBrain> orudge: I suspect we hit the same issue again for Windows too 12:06:43 <TrueBrain> regarding setting up what-ever company, we never figured out if we wanted short-term or long-term for that 12:07:47 <orudge> Well, I can register a UK company very cheaply and easily, and the admin is quite minimal. I am happy, at least in the short term, to do that. The plan would be for a simple company to handle our store licensing but nothing else (it wouldn't take donations for instance). 12:07:58 <orudge> Should we transition to something more appropriate in the medium or long term, then this can simply be wound up. 12:08:49 <andythenorth> we can always sell the company to a charity P 12:08:55 <orudge> For Apple, I think there's a €99/year fee, which isn't ideal, but we aren't exactly short on money. (Could stick a PayPal link into the Mac build :P) 12:09:46 <andythenorth> €99 is less than I currently donate to openttdcoop :P 12:10:00 <andythenorth> hmm coop is maybe dead though, I should look into that 12:10:05 <orudge> I'll get my Apple Silicon PR ready (it does work, if you put the workaround in place), but won't make it universal at this time 12:10:44 <TrueBrain> orudge: as I said: for a company we stalled on: do we want a Stichting, which would also allow donations, or do we want an LLC, which doesn't allow donations 12:10:45 <orudge> I don't know who exactly needs to "approve" my plan, but unless anybody is unhappy, I can go and register a company and get an Apple Developer account, and put in a new PR to sign the Mac builds. 12:10:49 <TrueBrain> it felt silent after that 12:11:07 <TrueBrain> doing the work is never the issue here, of course; it is just that nobody seems to care enough to voice an opinion on the matter :) 12:11:24 <orudge> TrueBrain: mm. From my point of view at least, the latter is simple, as it effectively has no more work for me other than filling out a form or two once a year. 12:11:34 <TrueBrain> both are equally simple 12:11:36 <TrueBrain> there is no difference 12:11:39 <TrueBrain> just you have experience with one 12:11:40 <TrueBrain> :) 12:11:43 <orudge> well, quite 12:11:55 <TrueBrain> but it is as simple to setup a Stichting vs an LLC UK 12:12:11 <TrueBrain> the main difference will be, that the first has more members and a policy how to deal with everything 12:12:14 <TrueBrain> the latter is a YOLO 12:12:22 <orudge> Yeah 12:12:36 <andythenorth> we only need YOLO 12:12:36 <TrueBrain> so again, short-term vs long-term :) 12:12:45 <TrueBrain> there is a risk involved with YOLOing stuff 12:12:45 <Eddi|zuHause> YOLO sounds like a tight bus factor 12:12:53 <TrueBrain> for one, and don't take this the wrong way, what if something happens to orudge 12:13:08 <orudge> There can be other company directors, and they don't need to be UK resident, in terms of the Ltd 12:13:11 <TrueBrain> but, on the other hand: we have been operating like that for 15 years, so yeah .. 12:13:24 <orudge> Of course, if I do get hit by a bus, you might need to change the registered office from my home address :P 12:13:29 <LordAro> nothing's happened to him yet! 12:13:54 <TrueBrain> so to be clear, and I appreciate you pushing for your solution orudge , it is not about doing the work 12:14:00 <TrueBrain> it is more about, how professional do we want to become 12:14:04 <TrueBrain> or do we just want to get it over with 12:14:09 <TrueBrain> (with all the risks attached to that) 12:14:20 <andythenorth> have we had lunch? 12:14:28 <andythenorth> this sounds like thinking 12:14:30 <andythenorth> thinking needs food 12:14:39 <TrueBrain> and to be clear, I rather have we do what orudge says, as that means I don't have to do anything; I am lazy where I can :) 12:14:46 <orudge> Heh 12:14:48 <TrueBrain> it is just about accepting the risks involved, doing something delibrately 12:14:50 <TrueBrain> instead of by accident 12:15:22 <orudge> Plus, in terms of Apple, we aren't going to be uploading to the Mac App Store (I don't think we can, because GPL), this is just effectively for a code signing certificate 12:15:26 <andythenorth> we could make a table of risks 12:15:28 <andythenorth> and risk score them 12:15:29 <TrueBrain> so, to voice my opinion: I am fully okay with putting the full load on orudge , IF he is willing to accept that 12:15:30 <orudge> So if anything does happen to me, you've not really lost anything. 12:15:41 <orudge> You just set up a new developer identity and sign with that 12:15:49 <orudge> If we move onto Steam, etc, then that might be something else to consider 12:15:50 <TrueBrain> orudge: something something funds :P 12:15:50 <andythenorth> and we can devise mitigations to prevent risks, and remedies if they manifest 12:15:56 <andythenorth> or we can yolo :P 12:16:06 <orudge> TrueBrain: ah, yes, that's a separate matter really :) 12:16:10 <TrueBrain> no, it is not :) 12:16:17 <TrueBrain> if we go your route, we will never do a Stichting or what-ever 12:16:25 <TrueBrain> as we are inherit lazy 12:16:32 <TrueBrain> and again, I am totally fine with it 12:16:41 <TrueBrain> just ... deliberate action vs accidental :) 12:17:10 <andythenorth> TL;DR current 'authority' is based on who has possession of certain keys and passwords? So it's property based? 12:17:21 <TrueBrain> so basically, we have 2 choices: either we solve OpenTTD LLC clean and correctly, or we continue to use orudge as our broker for the next 15 years :P 12:17:41 <TrueBrain> I vote for the latter, simply because it is so much easier 12:17:51 <orudge> I wouldn't say never, but from my point of view, it's probably not something I have time for just now (if you need me to do anything, of course; I suspect there would be some work necessary). And at some point, yes, I would be happy to take that responsibility/liability off my shoulders. :) 12:18:19 <TrueBrain> I can promise you, how OpenTTD operates .. once there is no more issue, nobody will put any effort in "doing it more correct" :) 12:18:24 <TrueBrain> might sound harsh, but it is true :P 12:18:25 <andythenorth> this way we sidestep having an OpenTTD legal entity 12:18:26 <orudge> I am happy to vote for the latter, with the intention that maybe in the next year or so we try to do something. There may be other options too, Software Freedom Conservancy, etc, that could be looked into. 12:18:51 <TrueBrain> again, all nice ideas, but it really is not going to happen, unless you start to explicit lobby you no longer want to do it :P 12:18:52 <andythenorth> I would rather we have a disorganised coop with no legal structure, and a broker providing some services 12:19:03 <andythenorth> for now 12:19:17 <TrueBrain> nobody really cares about where donations go, and how we pay AWS, basically :) 12:19:33 <orudge> TrueBrain: well, I need to move house first, that is likely to take up most of my time over the next 6 months or so. After that, perhaps I can lobby. Given I have all the funds, there would probably be some interest in that being sorted :D 12:19:39 <andythenorth> if we make a legal entity, with a board, and some kind of process for getting on / off the board 12:19:42 <andythenorth> we create politics 12:19:50 <orudge> True 12:19:51 <TrueBrain> and to be clear orudge , I mostly do this for you; as you have to understand that it would mean you are stuck with us for another 10 years :D 12:19:58 <andythenorth> and we create a thing for that one person who does care about donations etc 12:19:59 <orudge> Well 12:20:16 <orudge> I'm happy to keep doing what I'm doing 12:20:26 <orudge> but eventually we should probably do something more formal with the funds, or alternatively, spend them all :P 12:20:30 <orudge> Let's see how AWS does 12:20:31 <TrueBrain> :D 12:20:34 <andythenorth> defer the problem 12:20:58 <TrueBrain> just so there is no illusion that if you start an UK company, that next year anyone would be interesting in doing it differently :) 12:21:05 <TrueBrain> there will be even more crickets :P 12:21:09 <orudge> Well quite 12:21:28 <orudge> It sounds like nobody is particularly objecting to, whether in the short or long term, having an OpenTTD Distribution Ltd, which would help us at least solve our Mac (and/or Windows) problems. 12:21:34 <orudge> So I may well proceed with that. 12:21:39 <TrueBrain> that said, I am very happy that you did this for the last 15 years, and I am pretty sure you do the Ltd well and correctly, so, yeah, I am all in for that :) 12:21:57 <andythenorth> shall we vote? 12:21:57 <TrueBrain> just as long as you understand the risks, I am all fine :) 12:22:01 * andythenorth votes +1 12:22:05 <orudge> Once it's set up, perhaps I can persuade some of you to stick your name down as a company director if you so wish ;) 12:22:25 <TrueBrain> +/- 0 on that .. if you like to, sure, if I don't have to, it is fine too :) 12:22:33 <orudge> but anyway 12:22:34 <orudge> lunch 12:22:38 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #8517: Codechange: Make void tiles flood edge tiles, instead of edge tiles flooding themselves https://git.io/JLxCt 12:23:04 <TrueBrain> so yeah, please do make an Ltd, create an Apple account, and .. let's pick one to sign Windows with too :) 12:23:09 <TrueBrain> while at it, make a Steam account based on that Ltd 12:23:22 <TrueBrain> please do this before you move :P (you move a lot, don't you?) 12:24:33 *** Samu has joined #openttd 12:24:33 *** ekangmonyet_ has joined #openttd 12:25:07 *** ekangmonyet has quit IRC 12:28:16 <TrueBrain> owh, yeah, the other issue was OV or EV 12:28:22 <andythenorth> thanks orudge also! 12:28:46 <TrueBrain> I do not think we can automate EVs, as they mostly require hardware tokens 12:29:06 *** Samu has quit IRC 12:29:17 <orudge> TrueBrain: no, been here 9 years! 12:29:29 <orudge> and yes 12:29:46 <orudge> Can look into that separately 12:30:02 <TrueBrain> 9 years? Sorry, I lost context :) 12:30:08 <TrueBrain> owh ,house 12:30:10 <TrueBrain> haha :) 12:30:15 <TrueBrain> sorry, slow :P 12:30:56 <TrueBrain> anyway, so that means we can finally publish on Steam? That will be interesting :D 12:31:09 <FLHerne> What we really need is build-on-slopes for airports https://cimg7.ibsrv.net/gimg/pprune.org-vbulletin/265x190/a_af467faf56b2590151045e0679df98fa5e78583e.jpg 12:33:43 <TrueBrain> seems https://www.ksoftware.net/code-signing-certificates/ offers the cheapest OVs still 12:38:01 <TrueBrain> insane how expensive it still is :P 12:38:40 <TrueBrain> Comodo site itself is like ~150 dollar a year, but via a reseller it is 62 dollar a year 12:38:41 <TrueBrain> like wtf? 12:40:17 <Eddi|zuHause> is "cheapest" really the metric to go for with code signing? 12:40:43 <TrueBrain> given they are otherwise identical, it is a metric for sure 12:40:59 <TrueBrain> but the difference is ~70 dollar and ~350 dollar 12:41:13 <TrueBrain> (Between suppliers and resellers) 12:42:44 <Eddi|zuHause> well, maybe i'm being naive here, but i imagine "code signing" would involve someone actually checking what they're signing 12:42:50 <twpol> In my experience the only difference of any consequence is how painful their validation process is, and that's pretty hard to judge before going through it :( 12:43:31 <TrueBrain> Eddi|zuHause: you would be surprised :) 12:43:45 <Eddi|zuHause> i'd rather not :p 12:43:45 <TrueBrain> hmm, with the Apple Developers program, you get a code signing certificate 12:43:52 <TrueBrain> I wonder if that also works on Windows binaries :D 12:43:59 <twpol> For typical code signing, once they've validated your existence, and they hand over a certificate, they're no longer involved (except for a timestamping service) 12:44:11 <twpol> No idea how it differs for Apple-specific stuff 12:44:26 <TrueBrain> the thing I do not know, how easy it is to automate signing :D 12:44:48 <Eddi|zuHause> TrueBrain: the other alternative is that "code signing" is effectively a money printing machine with no consequence on whatever 12:44:51 <orudge> For Apple we can store the certificate data in GitHub Secrets 12:45:01 <twpol> Windows with an OV is trivial, `signtool` from the MS dev tools 12:45:07 <TrueBrain> Eddi|zuHause: welcome to certificates! :) 12:45:24 <TrueBrain> orudge: yeah, and GitHub does a very good job in keeping secrets a secret 12:45:35 <Eddi|zuHause> TrueBrain: which in consequence creates a false sense of security 12:45:42 <orudge> Anyway, I will register the company this afternoon, will need to get a bank account set u 12:45:49 <TrueBrain> Eddi|zuHause: have you read up on any CA lately? :P 12:45:55 <TrueBrain> orudge: <3 12:45:57 <Eddi|zuHause> ... which makes everything worse for everyone 12:46:15 <Eddi|zuHause> "i'd rather not :p" 12:46:17 <TrueBrain> lets say I am happy we have Letsencrypt and ACM for https :) 12:47:49 <milek7> I think officially you need to store cert on hardware smartcard 12:48:41 <milek7> at least that was what certum wanted 12:49:09 <milek7> (of course they cannot check where really you stored it) 12:49:36 <TrueBrain> https://github.com/simonw/datasette/issues/1171 <- useful for MacOS signing 12:53:04 <TrueBrain> milek7: EVs should be on hardware, OVs do not; this is why OVs are easier, but also less trust-worthy 12:55:52 <milek7> hmm, curious why certum wanted smartcard 12:56:09 <TrueBrain> EV is advised to use with Windows, but I have no clue how we would go about that 12:59:06 *** Samu has joined #openttd 13:04:06 <LordAro> TrueBrain: manual step in release process! 13:04:17 <TrueBrain> yeah ......... can I opt out? :D 13:04:46 <Samu> hi 13:06:20 <TrueBrain> hmm, gcc hasn't published a version 11 docker (yet) 13:07:39 <orudge> TrueBrain: yes, I found something similar, which I think uses the same library 13:07:47 <milek7> sorry for the access __attribute__ saga 13:07:57 <TrueBrain> milek7: isn't it just a GCC 11 bug, you ran into? 13:08:31 <milek7> it's feature, look at first PR 13:08:55 <TrueBrain> I am not talking about the noaccess macro, I mean the warning you get 13:09:17 <TrueBrain> as the warning seems incorrect to me 13:09:42 <milek7> well, it is passing uninitialized const pointer, so warning seems reasonable 13:10:07 <TrueBrain> either my definition of uninitialized is wrong, or I don't understand the code :P 13:10:56 <LordAro> seems reasonable to me 13:11:12 <LordAro> the pointer could be explicitly initialised to null first i suppose, but it's not necessary 13:11:34 <milek7> https://github.com/gcc-mirror/gcc/commit/b825a2289074 13:11:39 <milek7> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=10138 13:12:24 <TrueBrain> I guess the first question is: what pointer are we talking about :D 13:12:48 <TrueBrain> I hate that I cannot run gcc11 easily myself :P 13:12:58 <Heiki> GCC 11 doesn’t even have a release day yet 13:13:54 <milek7> maybe we should revert it, and add it back when gcc11 is released with proper version check macro 13:14:22 <TrueBrain> I am first trying to understand what the warning is trying to tell me :) 13:14:35 <TrueBrain> as "last" is pretty much initialized 13:14:42 <TrueBrain> does it mean that "url" is not? 13:15:47 *** Gustavo6046_ has joined #openttd 13:15:49 <DorpsGek> [OpenTTD/OpenTTD] iTKerry opened issue #8525: Server on MacOS is not sending ADMIN_PACKET_SERVER_WELCOME packet https://git.io/JLpsj 13:17:12 <milek7> last is pointer to uninitialized url 13:17:19 <orudge> Company registration submitted 13:17:27 <milek7> "A pointer to const parameter is almost always an input parameter to a function, so -Wuninitialized could warn if it has not been initialized. 13:17:34 <TrueBrain> orudge: nice 13:17:41 <andythenorth> @orudge do you still have to pay in £1? 13:17:44 <andythenorth> for the share? 13:17:45 <TrueBrain> milek7: so the issue is not last, but url 13:17:57 <TrueBrain> ? 13:18:05 <milek7> no 13:18:23 <milek7> compiler assumes that const pointer is input, and function will be reading from it, therefore warning 13:18:31 <milek7> but in fact pointer is never dereferenced, so it doesn't matter 13:18:40 <milek7> attribute none tells compiler about it 13:19:28 <TrueBrain> pretty sure that is not what I meant .. I am not debating whether it is used or not in the function, I am trying to make sense of the warning itself :) 13:19:50 <orudge> andythenorth: I will, yes, once there's a bank account 13:19:52 <TrueBrain> to me, and that might be fully me, but ELI5, last is perfectly valid 13:19:54 *** Gustavo6046 has quit IRC 13:19:54 *** Gustavo6046_ is now known as Gustavo6046 13:20:06 <TrueBrain> I for example wonder, and we shouldn't do this, if "char url[1024] = {};" solves the issue? 13:20:09 <andythenorth> @orudge I think I have a debt to my company somewhere of £1 for share cap :P 13:20:12 <TrueBrain> just trying to understand what the compiler is seeing 13:21:16 <TrueBrain> and that is the issue with not being able to try yourself, hard to understand what things are doing :) 13:22:06 <milek7> all the code is perfectly valid, this is just to silence slightly overzealous warning 13:22:27 <TrueBrain> I understand that, but it is not what I am asking about :) 13:22:46 <andythenorth> sometimes a twitch stream would answer a lot :P 13:23:17 <milek7> warning is just about that: "A pointer to const parameter is almost always an input parameter to a function, so -Wuninitialized could warn if it has not been initialized." 13:23:28 <TrueBrain> you have said that 3 times now already 13:23:34 <TrueBrain> I am not sure what you think helps by repeating the same thing :) 13:23:56 <TrueBrain> clearly, I am not understanding something; so just repeating the same thing over and over, doesn't help 13:24:21 <TrueBrain> I am simply asking: why does it think "last" is not initialized? 13:24:43 <milek7> because.. it is not? I give up ;P 13:25:19 *** glx has joined #openttd 13:25:19 *** ChanServ sets mode: +v glx 13:27:46 <milek7> https://godbolt.org/z/Txohv8 13:28:22 <TrueBrain> so, what I have been asking in different forms now: the problem is that "url" is not initialized? 13:28:55 <milek7> I wouldn't call that a problem 13:29:14 <TrueBrain> .... 13:29:22 <TrueBrain> the compiler warns because url is not initialized 13:29:24 <TrueBrain> that better? 13:30:12 <milek7> no, because it skips fact that it warns about 'last', which don't have to be initialized :P 13:30:36 <milek7> but sure, you can also fix it that way 13:31:10 <TrueBrain> this seems really difficult for you, but in general people like to understand a problem before they can think about a fix .. so I am just trying to understand WHY the compiler warns, this allows me to think what we can do to fix this .. 13:31:35 <TrueBrain> so, all I was asking, do I get this right that the problem is that last points into url, which is not initialized 13:31:39 <TrueBrain> the answer appears to be: yes 13:33:25 <milek7> or, the problem is that compiler wrongly assumes 'that' last is dereferenced 13:33:29 <milek7> sorry, I'm stubborn :P 13:33:41 <TrueBrain> and you are really not helping at all 13:33:47 <TrueBrain> like, I am trying to show I don't know much about this stuff 13:33:52 <TrueBrain> and all you do is bash me back over and over 13:34:02 <TrueBrain> not sure what you think that does make me feel .. but it is not helping 13:34:26 <milek7> that wasn't intended 13:34:49 <TrueBrain> in that case I forgive you, but you frustrated the hell out of me :P 13:35:05 <TrueBrain> GCC warnings are annoying as fuck, most of the time :) 13:39:07 *** DasPoseidon has joined #openttd 13:42:25 <andythenorth> hmm vehicle variants demanded 13:42:28 * andythenorth drawing trains 13:42:49 *** jottyfan has joined #openttd 13:47:28 <andythenorth> discord is much more supportive about my train adventures TBH :P 13:48:02 <Samu> :P 13:48:52 <TrueBrain> you want to say something with that andythenorth ? 13:49:06 <andythenorth> I said it 13:49:09 <Samu> i read irc log 13:49:19 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #8525: Server on MacOS is not sending ADMIN_PACKET_SERVER_WELCOME packet https://git.io/JLpsj 13:50:00 <andythenorth> anyway vehicle variants or go home 13:54:00 *** rptr_ has joined #openttd 13:55:06 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #8526: Fix 639cfa43: access_mode "none" is only available on GCC 11 and later https://git.io/JLpnT 13:55:07 <TrueBrain> milek7: mind testing ^^ 13:57:04 *** DasPoseidon has quit IRC 13:57:18 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #8517: Codechange: Make void tiles flood edge tiles, instead of edge tiles flooding themselves https://git.io/JLpns 13:57:45 <supermop_Home> good morning 13:58:10 <andythenorth> yo 13:58:46 *** DasPoseidon has joined #openttd 13:59:25 *** DasPoseidon has quit IRC 13:59:41 *** DasPoseidon has joined #openttd 14:00:24 <milek7> TrueBrain: it works for me, but TBH I would revert NOACCESS and place it back when gcc11 is released and gate it with __GNUC__ >= 11 __GNUC_MINOR__ >= 1 14:00:36 *** jottyfan has quit IRC 14:00:44 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8526: Fix 639cfa43: access_mode "none" is only available on GCC 11 and later https://git.io/JLpnl 14:01:46 <TrueBrain> milek7: why? (honest question) 14:02:01 <milek7> gcc11 was branched in april, but none attribute is present since june, so it will fail on compiler builds between those dates 14:03:17 <FLHerne> milek7: But who uses outdated unreleased compiler versions? 14:03:37 *** DasPoseidon has quit IRC 14:03:54 <FLHerne> Surely people are either using a release or a fairly recent dev build 14:04:59 *** nielsm has joined #openttd 14:05:16 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #8517: Codechange: Make void tiles flood edge tiles, instead of edge tiles flooding themselves https://git.io/JLpni 14:05:59 *** DasPoseidon has joined #openttd 14:06:32 <andythenorth> so can we have filter modes for OpenTTD? 14:06:38 <andythenorth> e.g. sepia 14:06:44 <andythenorth> for all sprites except UI 14:06:48 <glx> oh indeed, just check with mingw (gcc10) and it errors 14:08:46 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #8526: Fix 639cfa43: access_mode "none" is only available on GCC 11 and later https://git.io/JLpnF 14:09:38 <TrueBrain> milek7: good point; minor 1 or 2? 14:09:53 <TrueBrain> I see godbolt is already on 2 :P 14:10:13 <TrueBrain> so "#if __GNUC__ >= 11 && __GNUC_MINOR__ >= 1" would work too, not? 14:10:14 <milek7> huh 14:10:23 <TrueBrain> owh, nevermind 14:10:25 <TrueBrain> I am an idiot 14:10:27 <TrueBrain> haha 14:10:30 <TrueBrain> righttt, revert it is 14:10:31 <milek7> mine is __GNUC_MINOR__ 0 14:10:55 <milek7> and minor 1 would be first tagged release 14:11:05 <TrueBrain> feels a bit sad, but okay 14:12:32 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #8526: Fix 639cfa43: access_mode "none" is only available on GCC 11 and later https://git.io/JLpnF 14:12:35 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #8526: Fix 639cfa43: access_mode "none" is only available on GCC 11 and later https://git.io/JLpnl 14:12:38 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #8526: Fix 639cfa43: access_mode "none" is only available on GCC 11 and later https://git.io/JLpnT 14:13:18 <TrueBrain> commit checker .. grr :P 14:13:20 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #8526: Revert: access_mode "none" is only available on GCC 11.1 and later https://git.io/JLpnT 14:13:27 <milek7> btw. the whole reason I have gcc11 installed because gcc10.2 miscompiles something in mesa with lto 14:13:42 <TrueBrain> owh, too fed chars ... 14:14:05 <LordAro> TrueBrain: how did you manage to dismiss that review twice? :p 14:14:18 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #8526: Revert: access_mode "none" is only available on GCC 11.1 and later https://git.io/JLpnT 14:14:19 <TrueBrain> LordAro: because 2 people approved it 14:14:34 <LordAro> lol 14:16:14 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #8525: Server on MacOS is not sending ADMIN_PACKET_SERVER_WELCOME packet https://git.io/JLpsj 14:16:21 <TrueBrain> okay, writing that psuedo-code was a lot harder than I remembered 14:16:31 <TrueBrain> reading TCP is annoying :P 14:19:50 <milek7> https://gist.github.com/Milek7/3dd1f0d2bd6fd8422579055d7dbbd62f 14:20:08 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8524: Fix: [Actions] circumvent Windows tar warning about read-only files https://git.io/JLpcB 14:20:16 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8526: Revert: access_mode "none" is only available on GCC 11.1 and later https://git.io/JLpc0 14:20:31 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8524: Fix: [Actions] circumvent Windows tar warning about read-only files https://git.io/JLpIE 14:20:32 * LordAro not merging anything 14:20:39 <LordAro> have broken enough things today :p 14:20:47 <TrueBrain> we all break shit constantly 14:20:49 <TrueBrain> that is our job, not? 14:20:49 <milek7> sorry :P 14:20:52 *** rptr_ has quit IRC 14:22:56 <orudge> OPENTTD DISTRIBUTION LTD 14:22:56 <orudge> Company number SC685432 14:22:57 <orudge> Hurrah 14:23:02 <TrueBrain> \o/ 14:23:06 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #8517: Codechange: Make void tiles flood edge tiles, instead of edge tiles flooding themselves https://git.io/JLpcK 14:23:16 <TrueBrain> that is rather quick ... UK has some nice IT 14:23:22 <TrueBrain> that doesn't belong in the EU 14:24:06 <TrueBrain> https://partner.steamgames.com/ <- just leaving that URL here ....... :D 14:24:25 <milek7> yeah.. opening limited company there requires sending papers to court and waiting weeks 14:25:48 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8526: Revert: access_mode "none" is only available on GCC 11.1 and later https://git.io/JLpnT 14:25:58 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8526: Revert: access_mode "none" is only available on GCC 11.1 and later https://git.io/JLpc9 14:26:44 <Samu> honestly that last check 14:26:58 <Samu> would go undetected 14:27:06 *** snail_UES_ has joined #openttd 14:30:07 *** ekangmonyet_ has quit IRC 14:30:14 *** ekangmonyet has joined #openttd 14:30:23 <Samu> it would require someone fiddling with the RunTileLoop, to expose it visually 14:30:33 <Samu> pause it 14:31:38 <Samu> don't run RunTileLoop to expose something nobody in a real game would ever notice 14:34:08 <Samu> im just trying to be consistent 14:35:37 <TrueBrain> ugh ... while trying to work on an open PR, I found an old PR, that is just a combination of wtf and huh and oef, this and that is forgotten ... down the rabbit hole we go!!! 14:37:49 <Xaroth> bring a ladder, or a rope. 14:37:52 <Xaroth> ... or both. 14:39:30 <Eddi|zuHause> a ladder on a rope? 14:39:37 <Eddi|zuHause> or a rope-ladder? 14:45:06 <Samu> funny! I just exposed an inconsisency in ConvertGroundTilesIntoWaterTiles() 14:45:36 <Samu> but it requires to have RunTileLoop not to run to actually visualize it 14:46:36 <Samu> or someone with a very big screen resolution and a very slow system at the same time 14:46:51 <Samu> to see it happen before RunTileLoop takes action 14:49:37 *** frosch123 has joined #openttd 14:49:48 <Samu> This is what ConvertGroundTilesIntoWaterTiles do if RunTileLoop never happens: https://i.imgur.com/hcuvhBH.png 14:50:09 <Samu> it already makes shores of those tiles adjacent to void tiles 14:50:20 <Samu> and this is in master! 14:50:25 <Samu> not related to my PR 14:53:03 <orudge> [14:23:54] <TrueBrain> https://partner.steamgames.com/ <- just leaving that URL here ....... :D <-- have applied for a bank account, so once that's in place... 14:53:09 <orudge> Also started the Apple application process 14:53:25 <Samu> openttd is going to steam? 14:53:30 <orudge> Potentially 14:53:35 <orudge> If they'll have us :P 14:53:41 <TrueBrain> orudge: guess we should see if the Apple cert works for Windows first, and otherwise pick an OV :D 14:53:44 <Samu> that's gonna be mayhem 14:53:52 <orudge> TrueBrain: I don't think it will 14:53:57 <orudge> I think we'll need to do it separately 14:54:08 <orudge> Will wait and see 14:54:17 <orudge> but pretty sure it works differently :) 14:54:31 <TrueBrain> it should be a real certificate etc 14:54:35 <TrueBrain> you can do it the other way around 14:54:48 <TrueBrain> use a third-party code signing certificate, manual says 14:54:51 <TrueBrain> not sure for what 14:54:51 <orudge> Ah 14:54:53 <TrueBrain> as that is .. unclear 14:54:56 <orudge> well, will see what happens! 14:54:59 <TrueBrain> if that is for developers build only 14:55:05 <TrueBrain> but indeed ... one step at the time :) 14:58:28 <TrueBrain> so ... I load a game, I go to console, I type: newgame, I open console, I type: restart 14:58:32 <TrueBrain> what do you expect that happens? 14:58:33 <TrueBrain> :D 15:01:05 <DorpsGek> [OpenTTD/OpenTTD] hpiirai commented on pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLpWw 15:02:09 *** _2TallTyler has joined #openttd 15:03:35 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLpWX 15:03:53 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8516: Fix #7972: show invalid orders to stations that don't accept your vehicle https://git.io/JLpWM 15:04:31 <TrueBrain> "assuming no issues with PUSH/POP_COLOUR with eints/whatever" <- good question, we just blame frosch123 if there are :P 15:04:48 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed issue #7972: Impossible/invalid orders aren't marked as such in the order list https://git.io/JvGub 15:04:51 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8516: Fix #7972: show invalid orders to stations that don't accept your vehicle https://git.io/JLxcf 15:05:34 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8169: Fix #8153: Report autoreplace failure when new vehicle cannot carry the cargo https://git.io/JLpWQ 15:05:53 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed issue #8153: Autoreplace does not report failures due to refittability https://git.io/Jf0oB 15:05:56 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8169: Fix #8153: Report autoreplace failure when new vehicle cannot carry the cargo https://git.io/JfVAv 15:06:44 <TrueBrain> LordAro: tnx for the reviews, much appreciated :) 15:08:53 *** tokai|noir has joined #openttd 15:08:53 *** ChanServ sets mode: +v tokai|noir 15:11:07 <TrueBrain> okay, the "restart" command is rather broken :) Time to fix it :P 15:11:08 <DorpsGek> [OpenTTD/OpenTTD] hpiirai commented on pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLplv 15:11:54 <TrueBrain> I honestly can live without people being able to abuse the game in that way for these edge-cases; but that is just me :) 15:15:51 *** tokai has quit IRC 15:16:04 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #8473: Add: Towns can build tunnels https://git.io/JLpl3 15:18:08 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLplC 15:18:54 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #8473: Add: Towns can build tunnels https://git.io/JLpl8 15:19:07 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLpl4 15:19:10 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLplB 15:23:09 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLplr 15:24:52 <TrueBrain> frosch123: it seems my copy/paste really is terrible .. aggghh :P 15:25:20 <frosch123> copy/paste is always terrible, not just yours 15:25:33 <TrueBrain> happy you are as sharp as you are in this review :) 15:25:44 <frosch123> i deny your patent request on terrible copy&paste 15:26:02 <TrueBrain> haha :D 15:26:37 <TrueBrain> I can also just set the tooltip, and stay away from the widget_data 15:26:46 <TrueBrain> I was using the wrapper functions, but SetupRoadToolbar is neither 15:27:00 <frosch123> add another wrapper function? 15:27:11 <frosch123> no idea 15:27:24 <TrueBrain> sounds good to me 15:27:24 <frosch123> but not reassigning the sprite when it does not change anyway, sounds smart :) 15:30:09 <frosch123> did someone figure out that bananas complaint? 15:30:31 <TrueBrain> owh, someone finally emailed? 15:30:39 <TrueBrain> I already was told it should come :P 15:30:51 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLx6I 15:30:56 <frosch123> yes, but i don't want to read up the drama, in case someone else already did :) 15:31:16 <TrueBrain> yeah .. I know what is going on ... not sure yet what we should do .. it is all .. childish, at best 15:32:07 <TrueBrain> basically, someone took GPLv2 and CC-BY graphics, repacked it, and published it on BaNaNaS 15:32:13 <TrueBrain> under a single license 15:32:23 <TrueBrain> so we can take this down, but he is just going to upload it as 2 packages 15:32:32 <TrueBrain> not sure what we can really do about that, honestly .. 15:32:52 <TrueBrain> I will make a short write-up soon, as I guess this is not just going away 15:33:33 *** rptr_ has joined #openttd 15:34:29 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLp8f 15:35:43 *** iSoSyS has joined #openttd 15:36:28 *** rptr_ has quit IRC 15:41:15 <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLp82 15:43:42 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #8527: Fix a bug in "restart" and introduce "reload" console command https://git.io/JLp8M 15:43:44 *** jottyfan has joined #openttd 15:43:56 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed issue #8055: Road Construction UI unavailable https://git.io/Jvbvc 15:43:59 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLx6I 15:44:02 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed pull request #8063: Fix #8055: Always allow building any available roadtypes, even if there are no road vehicles available https://git.io/JvNRF 15:44:28 <TrueBrain> down to 11 open things in the milestone :D 15:44:46 <Eddi|zuHause> that might be my fault 15:45:26 <TrueBrain> I might have been a bit rant-ish in #8527, but boyyyy ... 15:45:53 <TrueBrain> the argumentation in #7328 was just flawed 15:46:45 <TrueBrain> Eddi|zuHause: what did you do? :) 15:46:55 <Eddi|zuHause> i didn't finish #7000 :) 15:47:15 <frosch123> i'll do that 15:47:22 <frosch123> it's less work to do it myself 15:47:45 <Eddi|zuHause> you sound mad when you say that 15:48:00 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on pull request #8521: Change: always allow to click on the toolbar icons for road/rail/dock/airport https://git.io/JLp8h 15:48:15 <frosch123> no, it's a dilbert reaction in this case, not an alice one 15:48:36 <Eddi|zuHause> i'm not that familiar with those characters 15:50:09 <andythenorth> dogbert ftw! 15:50:11 * andythenorth coffee 15:53:35 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #8473: Add: Towns can build tunnels https://git.io/JL7cV 15:54:13 <andythenorth> JGR should get an award for patience 15:54:16 <andythenorth> in our annual awards 15:54:20 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #8473: Add: Towns can build tunnels https://git.io/JL7cV 15:54:30 <andythenorth> also potentially JGR should be a sub-forum, not just a thread 15:55:47 <_2TallTyler> Agreed, but JGR might want to make that decision as it could add more threads to monitor and reply to 15:57:37 <orudge> If he wants one, he can have one; I suspect it would be busy enough 15:58:07 <TrueBrain> JGR: do you want one? 15:58:43 <TrueBrain> (bah, the summoning powers are low today :P) 15:58:56 <DorpsGek> [OpenTTD/OpenTTD] orudge updated pull request #8340: Draft: Feature: Create Universal (x86_64 + Apple Silicon) build on macOS https://git.io/JkqLt 16:01:08 *** Progman has joined #openttd 16:07:43 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #8517: Codechange: Make void tiles flood edge tiles, instead of edge tiles flooding themselves https://git.io/JLp4F 16:09:11 <Samu> i think i'm overexplaining 16:09:28 <Samu> i derail my own PR's 16:10:11 <orudge> TrueBrain: btw, reading some of the documentation on Steam, I think publishing OpenTTD on Steam itself ought to be fine, but integrating it with SteamWorks (for things like friends lists, achievements, etc) might be more problematic with regards to the GPL. I suspect initially at least we wouldn't be wanting to do any of that anyway. 16:10:35 <orudge> We'd probably have to create some kind of dynamic interface on the OpenTTD side to load the Steam DLLs without directly linking to them, not quite sure. 16:11:18 <TrueBrain> I did not plan on integrating with SteamWorks, personally :) 16:11:23 <_2TallTyler> Steam achievements would be so fun to brainstorm though :P 16:11:26 <TrueBrain> but the publishing was what I was hoping for :) 16:12:31 <TrueBrain> from what I understand, we can even publish it via "OpenTTD", as long as there is a company behind it that is registered somewhere in the world 16:12:42 <TrueBrain> and from what I understand, it is completely free to do so if your game is free too 16:12:44 <orudge> Yes 16:13:08 <orudge> The next fun thing (though I don't fancy it myself at this time) would be to trademark OpenTTD and get the imposter removed/renamed on the MS Store... 16:13:09 <glx> Samu: but RunTileLoop() should always run 16:13:11 <orudge> Could prove expensive though 16:13:23 <TrueBrain> yeah ... 16:13:27 <glx> you're finding non issues I think Samu 16:13:40 <TrueBrain> anyway, integrating with Steam is a different subject and problem, indeed :) 16:13:51 <TrueBrain> but mostly, I am not sure that is a direction we want to go to, integrate with platforms 16:14:00 <TrueBrain> sounds annoying to maintain :P 16:14:07 <TrueBrain> (ignoring possible license issues) 16:15:14 <glx> Samu: but you may have found the real location for a fix :) 16:18:48 *** _dp_ has quit IRC 16:18:58 <Samu> maybe it's nothing, but it could affect town placement logic or industry placement logic, not really sure if it matters that much 16:19:10 *** Flygon has quit IRC 16:19:32 <Samu> which happen still before the run tile loop 16:19:37 <milek7> huh, steam publishing is free? 16:19:45 <milek7> last time they charged 100$ 16:20:47 <orudge> Yes, there's a 0 charge to sign up it seems 16:21:26 <milek7> and you have to fill US tax forms even if you game is free 16:21:29 <milek7> this is silly.. 16:21:36 <orudge> Need to wait for the bank account to be set up anyway 16:23:43 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #8473: Add: Towns can build tunnels https://git.io/JLpB6 16:23:57 <glx> Samu: I think you just confirmed the issue is in TileLoop_Clear() ;) 16:25:16 <DorpsGek> [OpenTTD/OpenTTD] orudge commented on pull request #8340: Feature: Add support for Apple Silicon (ARM64) build on macOS https://git.io/JLpBy 16:27:23 <DorpsGek> [OpenTTD/OpenTTD] orudge updated pull request #8340: Feature: Add support for Apple Silicon (ARM64) build on macOS https://git.io/JkqLt 16:33:53 *** Tirili has joined #openttd 16:34:13 <frosch123> TrueBrain: surprise. today content download fails for me 16:34:45 <TrueBrain> hmm 16:35:02 <LordAro> working here 16:35:09 <LordAro> but you probably knew that 16:35:33 <frosch123> -d net=7 says, it tries via ipv6 16:35:49 <frosch123> dbg: [net] Connecting to [content.openttd.org]:3978 (IPv6) 16:35:50 <frosch123> dbg: [net] [tcp] could not connect IPv6 socket: Connection timed out 16:36:28 <TrueBrain> works over IPv6 for me 16:36:37 <TrueBrain> dbg: [net] Connecting to [content.openttd.org]:3978 (IPv6) 16:36:37 <TrueBrain> dbg: [net] [tcp] connected to [2a05:d014:870:d200:f298:e9f2:759:5cd4]:3978 (IPv6) 16:36:45 <glx> I can try here too 16:36:51 <milek7> works for me too 16:37:02 <TrueBrain> but .. IPv6 is still IPv6 :P 16:37:58 <glx> some days my ipv6 can't route outside ISP, but today should be good 16:38:18 <frosch123> interesting. it tried ipv6 twice, both failed. then it tried ipv4. connection succeeded but it does not show a list either 16:39:26 <TrueBrain> does https://content.openttd.org/ work? 16:39:46 <TrueBrain> does it work from https://preview.openttd.org/pr8386/ ? 16:40:08 <glx> first link shows empty page 16:40:13 <TrueBrain> yup 16:40:51 *** DasPoseidon has quit IRC 16:41:32 <frosch123> curl -4 gives 200, curl -6 times out 16:41:55 <frosch123> so, i think the main bug is that ottd's fallback to ipv4 works only partially 16:42:22 <TrueBrain> and your IPv6 to AWS is acting up, which is also not good 16:42:28 <TrueBrain> can you reach https://www.openttd.org ? 16:42:41 <TrueBrain> (hosted on a different segment within AWS) 16:42:50 <TrueBrain> over IPv6, ofc 16:43:05 <frosch123> yeah, also fails over ipv6, so my ipv6 is just broken :) 16:43:13 <TrueBrain> k :) 16:43:18 <TrueBrain> so a bug for OpenTTD client! 16:43:20 <frosch123> and ottd's fallback 16:43:54 *** Tirili has quit IRC 16:45:14 <TrueBrain> hmm .. can you on the forum see what someone edited in his post? 16:47:55 <andythenorth> let's have a digressions into fun :) https://en.wikipedia.org/wiki/Tech_Model_Railroad_Club 16:48:02 <orudge> I don't think so, TrueBrain 16:48:12 <TrueBrain> owh, I just dno't have powers in this subforum 16:49:46 <TrueBrain> even with powers, I cannot find that :P 16:49:47 <andythenorth> http://henryjenkins.org/blog/2007/10/spacewars_and_beyond_how_the_t.html 16:49:51 <TrueBrain> I want to know if someone ninja-edited something :) 16:50:17 <frosch123> usually it says "edited last" 16:50:25 <frosch123> so you have at least a date 16:53:01 <orudge> Right, hopefully the bank account will get set up on or by Monday, and Apple will have verified that the company exists, then we can look at moving forward 16:53:05 <orudge> Have a good weekend all :) 16:53:33 <TrueBrain> you too! 16:54:12 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #8340: Feature: Add support for Apple Silicon (ARM64) build on macOS https://git.io/JLp0I 16:54:59 <_2TallTyler> TrueBrain: I found a bug in the code I added in #8401 related to checking the direction of drive-through road stations. Would you prefer I fix it in #8473 or open a new PR? 16:55:21 <LordAro> _2TallTyler: new PR please 16:58:18 <DorpsGek> [OpenTTD/OpenTTD] orudge merged pull request #8340: Feature: Add support for Apple Silicon (ARM64) build on macOS https://git.io/JkqLt 16:58:40 <LordAro> \o/ 16:59:40 <_2TallTyler> OK, in that case #8473 is ready for review again. 17:01:37 *** Gustavo6046 has quit IRC 17:09:14 <TrueBrain> cool; will give it a looksie soon :) Tnx! 17:09:34 <TrueBrain> orudge: owh, we shouldn't forget "website" PR :P 17:10:10 <TrueBrain> well, you said already bye, guess I can do that real quick :) 17:11:45 <Samu> road tunnels 17:11:53 <Samu> town road tunnels 17:12:06 *** Gustavo6046 has joined #openttd 17:13:27 <Samu> so max and min have changed? 17:13:31 <Samu> interesting 17:13:47 <DorpsGek> [OpenTTD/website] TrueBrain opened pull request #180: Add: description for MacOS arm64 binaries https://git.io/JLpEC 17:13:47 <glx> not a real change 17:13:57 *** Progman has quit IRC 17:14:03 <TrueBrain> if anyone has a better way of describing intel vs silicon, I am all ears :) 17:14:12 <DorpsGek> [OpenTTD/website] LordAro approved pull request #180: Add: description for MacOS arm64 binaries https://git.io/JLpE4 17:14:18 <LordAro> seems good to me 17:14:27 <TrueBrain> that was .. scary quick 17:14:41 <LordAro> a whole 25s 17:17:34 <TrueBrain> well, 1 drama dealt with .. hopefully 17:17:42 <TrueBrain> we do need to setup a licensing-course or something :D 17:17:46 <TrueBrain> we are the first students :P 17:18:35 <DorpsGek> [OpenTTD/website] TrueBrain merged pull request #180: Add: description for MacOS arm64 binaries https://git.io/JLpEC 17:18:52 <DorpsGek> [OpenTTD/website] TrueBrain created new tag: 1.4.9 https://git.io/JLpED 17:20:07 <andythenorth> "please complete this 10 credit video learning course to get a bananas upload account" :P 17:20:08 <andythenorth> oof 17:20:50 <LordAro> :D 17:21:00 <_2TallTyler> Need some Git help: my fix to #8401 is based on my new tunnel commits, since I renamed several things within the function. Should I rebase off master somehow? How does that work when two PRs rename the same thing? https://github.com/2TallTyler/OpenTTD/tree/road_station_direction_fix 17:21:20 <andythenorth> anyway, shall we reply on behalf of JGR? :P https://www.tt-forums.net/viewtopic.php?p=1240265#p1240265 17:21:29 <TrueBrain> _2TallTyler: I would just wait a few minutes if I were you :) 17:21:59 <_2TallTyler> I think some basic education about licenses is a perfectly fair prerequisite to using Bananas 17:25:36 <TrueBrain> like we really know what we are doing when it comes to licenses :P 17:25:53 <frosch123> got content download to work 17:26:01 <frosch123> it's a really stupid bug :p 17:26:09 <andythenorth> hmm are we upstream or downstream of JGR now? 17:26:15 * andythenorth is moderately confused :P 17:27:17 <frosch123> ottd tries all ip-connection candidates sequentially, so if there are 3 and only the last one works, it takes 2 timeouts until the 3rd one is tried 17:27:31 <TrueBrain> lol 17:27:42 <frosch123> on successful connection ottd calls ClientNetworkContentSocketHandler::SendReceive() to actually send the packets 17:28:00 <frosch123> however, the first thing it does, it checks for some inactivity timeout, and closes the connection 17:28:09 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #8473: Add: Towns can build tunnels https://git.io/JLpuO 17:28:13 <TrueBrain> serious nice work _2TallTyler 17:28:23 <LordAro> ^ 17:28:24 <TrueBrain> also with the feedback; thank you 17:28:29 <frosch123> so, if resolving the addresses takes longer than a minute, it never sends stuff 17:28:46 <orudge> TrueBrain: not at my PC now to submit a PR, but the macOS builds are for 10.9+. For arm64 it's 11+ though because that's the only macOS version available obviously on that platform. 17:29:04 <TrueBrain> so I just added a lie :'( 17:29:21 <_2TallTyler> Thank you! :) 17:29:27 <TrueBrain> is it 11.0 orudge ? Or just 11? 17:29:55 <orudge> Just 11, I think next year's macOS will be 12 17:30:07 <Samu> im looking at #7822, and... indeed it can get quite confusing what I'm talking about, coming from nowhere. Now that a year has passed, I can see where the confusion comes from 17:30:09 <TrueBrain> description: MacOS 11+ (Apple Silicon, arm64) 17:30:13 <TrueBrain> description: MacOS 10.9+ (Intel, x86_64) 17:30:17 <orudge> 10.9 for x86_64 though 17:30:18 <LordAro> OSXI 17:30:22 <orudge> Yep 17:30:35 <Samu> i edited a bit to point to things 17:30:40 <orudge> Thanks 17:32:12 <DorpsGek> [OpenTTD/website] TrueBrain opened pull request #181: Fix: update the MacOS binary descriptions to reflect reality https://git.io/JLpul 17:32:22 <TrueBrain> lets see how many seconds LordAro needs this time 17:32:40 <DorpsGek> [OpenTTD/website] LordAro approved pull request #181: Fix: update the MacOS binary descriptions to reflect reality https://git.io/JLpuR 17:32:42 <LordAro> i wasn't ready! 17:32:49 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8473: Add: Towns can build tunnels https://git.io/JL7cV 17:33:44 <LordAro> my fault for approving the first one, really 17:33:47 <Samu> wow towns can build tunnels, which means... I need to update terraforming again 17:33:58 <LordAro> i know that arm64 is MacOS 11 only :p 17:34:10 <Samu> because tunnels terraform 17:34:15 <TrueBrain> I know that too ... yet ... I wrote the nonsense :D 17:34:54 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #7822: Fix #7670: Cache the origin tile to prevent recurring calls to the road pathfinder when a vehicle is blocked by another https://git.io/JegbJ 17:35:17 <TrueBrain> LordAro: so now your scroll-PR needs some fixing :P 17:35:25 <LordAro> yup 17:35:33 <LordAro> half of the casts can be removed, for instance :p 17:35:38 <TrueBrain> \o/ 17:35:45 <TrueBrain> I am really curious about that one statement 17:35:50 <TrueBrain> took me a good 30 minutes to work out what the old code did 17:35:52 <TrueBrain> what the new one did 17:35:58 <TrueBrain> and why I think it is wrong :P 17:36:02 <LordAro> (half of the trouble was GetPosition() returning an int, but it being compared against a size_type 17:36:04 <TrueBrain> damn, that was difficult :D 17:36:08 <LordAro> ) 17:36:09 <LordAro> hehe 17:36:34 <DorpsGek> [OpenTTD/website] TrueBrain merged pull request #181: Fix: update the MacOS binary descriptions to reflect reality https://git.io/JLpul 17:36:49 <DorpsGek> [OpenTTD/website] TrueBrain created new tag: 1.4.10 https://git.io/JLpuH 17:40:05 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened pull request #8528: Fix #8401: Drive-thru road stations can be connected at either end https://git.io/JLpze 17:40:16 *** Wormnest has joined #openttd 17:40:48 <frosch123> ottd needs asyncio :/ 17:40:49 <TrueBrain> _2TallTyler: are you now subtle pointing out we failed in reviewing your work? :P :P 17:40:51 <TrueBrain> frosch123: yes 17:40:57 <TrueBrain> does that exist for C++? 17:41:09 <frosch123> it's in boost, and it's on the roadmap for c++23 17:41:19 <TrueBrain> ugh, I cannot wait that long 17:41:20 <frosch123> but it was already on the roadmap for c++20, so who knows 17:41:24 <_2TallTyler> Maybe, but also that my test savegame should have checked all four orientations of road stations 17:41:44 <frosch123> TrueBrain: if you are fine with boost. i have used that stuff before :) 17:42:22 <LordAro> nooo 17:42:23 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #8528: Fix #8401: Drive-thru road stations can be connected at either end https://git.io/JLpzG 17:42:38 <TrueBrain> well, I just know network code looks a lot better when using asyncio 17:42:47 <TrueBrain> as in, you can almost make it somewhat readable with it 17:42:50 <frosch123> downloading 5 things from bananas, waiting 5 times for a >1 minute timeout :p 17:43:54 <frosch123> but at least it succeeds now 17:44:14 <Samu> _2TallTyler, CommandFlagsToDCFlags(GetCommandFlags(CMD_BUILD_TUNNEL)) doesn't used DC_NO_WATER, let's see what could go wrong, brb 17:44:20 <Samu> doesn't useP 17:44:22 <Samu> use* 17:45:11 *** rptr_ has joined #openttd 17:45:27 <milek7> TrueBrain: I hope you aren't talking about asio? 17:45:35 <milek7> that stuff is not readable at all imo :P 17:45:58 <TrueBrain> _2TallTyler: just wait till he finds out neither do bridges :D :D 17:46:21 <_2TallTyler> Samu: It's currently possible to build tunnels which end on a coast slope. This is a legitimate bug but it's possible for players to do, so it's out of scope of my PR 17:47:26 <_2TallTyler> https://snipboard.io/5l4zwg.jpg 17:47:57 <Samu> exactly that 17:48:43 <_2TallTyler> I'll let you fix that :) 17:48:48 <Samu> also if the thing needs to terraform 17:49:01 <Samu> yes, i am working on it 17:49:12 <Samu> but i can't make new PR's so, whatever 17:49:43 *** rptr_ has quit IRC 17:49:56 <TrueBrain> boy, this PR couldn't possibly have worked as intended ... hmmmmm 17:50:29 <TrueBrain> another one for the list: revamp console 17:50:44 <frosch123> TrueBrain: what is the proper term for the addresses that resolve returns, and which you then try to connect to? connect-candidates? 17:51:14 <TrueBrain> addresses :P 17:51:35 <frosch123> meh 17:51:41 <TrueBrain> isn't an address always a candidate, you can wonder :) 17:52:16 <TrueBrain> possible-addresses and worked-last-time-addresses ? :) 17:52:40 *** jottyfan has quit IRC 17:52:42 <TrueBrain> well, I guess you can call them "resolved addresses" 17:52:47 <TrueBrain> as not every address can resolve 17:52:54 <TrueBrain> and not every resolve address you can connect to 17:55:34 <Samu> i got a crash, clicked build road in scenario editor 17:55:40 <Samu> latest master 17:56:40 <TrueBrain> _2TallTyler: one minor thing in your PR: we don't fix PRs, we fix commits. So I just changed your commit message ever so slightly :) 17:56:43 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8528: Fix #8401: Drive-thru road stations can be connected at either end https://git.io/JLpze 17:56:56 <Samu> TrueBrain, 17:57:08 <TrueBrain> Samu 17:57:54 <_2TallTyler> Aha, thank you 17:58:11 <TrueBrain> no, thank you! 17:58:16 <glx> oh scenario editor, always forgotten when touching build toolbars 17:58:25 <TrueBrain> nah, I tested it, so now I am annoyed :P 17:59:12 <TrueBrain> ugh, always that last minute addition 17:59:23 <glx> the not tested one ;) 17:59:32 <_2TallTyler> Now to try my hand at fixing #8506... 18:01:09 <TrueBrain> just a weird reuse of code, basically :) 18:02:19 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #8529: Fix af22a4f2: scenario editor doesn't have build station/depot/etc https://git.io/JLpg6 18:03:31 <Samu> you work fast 18:04:29 <glx> knowing the cause it's easy to fix :) 18:04:40 <TrueBrain> most time I spend on starting gdb 18:04:46 <TrueBrain> it takes for ever to load symbols 18:05:21 <glx> oh same for water 18:05:28 <glx> (just tested) 18:05:39 <TrueBrain> there is a reason that part is also in the PR, yes :) 18:06:02 <TrueBrain> doubting my fixing skills, pfft :P 18:06:22 <TrueBrain> glx: if you can add a comment explaining how slow-forward and fast-forward behaves in the hunderthtick PR, we can merge that too :D 18:06:52 <glx> where ? in OnHundredthTick() main comment ? 18:06:59 <TrueBrain> dunno, find a nice place for it :) 18:07:12 <TrueBrain> I agree with frosch123 's remark the other day that documenting what we expect it to do helps future-us :) 18:07:20 <TrueBrain> otherwise in 2 years someone changes it back to a GUITimer again 18:07:22 <TrueBrain> :D 18:07:25 <TrueBrain> ping pong :P 18:08:10 <TrueBrain> maybe even in the doxygen part of the callback 18:08:30 <glx> yeah that's where I was about to add it 18:08:35 <TrueBrain> sounds good to me :) 18:10:32 <DorpsGek> [OpenTTD/OpenTTD] frosch123 opened pull request #8530: Fix: The time-out for connecting to the content-server was shorter th… https://git.io/JLpgA 18:10:46 <frosch123> i hope someone squashes that, and enters a better commit message 18:10:48 <TrueBrain> E_COMMIT_MESSAGE_TOO_LONG :P 18:10:51 <TrueBrain> :D 18:11:00 <frosch123> it's longer than the diff :) 18:12:05 <LordAro> just split it into 2 lines and remove the "So " 18:13:06 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #8530: Fix: The time-out for connecting to the content-server was shorter th… https://git.io/JLpgA 18:13:27 <TrueBrain> that comment confused me enough that I had to look in the code :D 18:14:03 <TrueBrain> it has nothing to do with sending :P 18:14:26 <frosch123> yeah, you would think so :p but it does 18:14:28 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8530: Fix: The time-out for connecting to the content-server was shorter th… https://git.io/JLp2k 18:14:41 <TrueBrain> well, if I understand the code: lastActivity keeps track when we last saw the other end doing anything 18:15:00 <TrueBrain> and it closes the socket if that reaches a timeout 18:15:08 <TrueBrain> so it is not only sending, also receiving :P 18:15:28 <frosch123> the client has to send first 18:15:51 <TrueBrain> the "now" was mostly what confused me btw :) 18:15:56 <TrueBrain> like: is it otherwise going to wait? 18:16:08 <TrueBrain> but it closes the connection :P 18:16:20 <_2TallTyler> Question: Can a tile have more than one NRT roadtype? Or is the maximum one roadtype and one tramtype? 18:16:38 <Samu> _2TallTyler, [img]https://i.imgur.com/IRef6j0.png[/img] 18:16:42 <frosch123> the latter 18:16:53 <Samu> tunnel issued a terraform command 18:18:52 <Samu> let me test with DC_NO_WATER 18:18:56 <_2TallTyler> Thanks frosch123 18:20:38 <Samu> it was smarter! https://i.imgur.com/Q2ywb2Z.png 18:21:21 <TrueBrain> frosch123: that lastActivity is a bit weird n general .. if I read this right, if you take more than 60 seconds to pick a download, it also resets the connection .. despite the connection still being valid and active 18:23:08 <TrueBrain> anyway, I guess you can remove the assignment of lastActivity in Connect() with your patch, not? 18:23:38 <TrueBrain> ugh, I should write in PRs 18:23:56 <TrueBrain> how the hell do you add a comment in a line that is not changed ... 18:24:25 <TrueBrain> you can't?! Lol 18:25:46 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8530: Fix: The time-out for connecting to the content-server was shorter th… https://git.io/JLpaT 18:26:58 <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/JLpaI 18:26:59 <DorpsGek> - Update: Translations from eints (by translators) 18:27:23 <TrueBrain> this time of the schedule ... unbelievable :P It is getting worse and worse 18:30:12 <frosch123> it's super weird. Connect() resets the timeout, even if it still connecting 18:30:20 <frosch123> so by closing the gui at the right time 18:30:27 <frosch123> you can elongate it indefinitely 18:32:41 <frosch123> but yes, if i remove it from connect(), i am more confident in not adding a comment in OnConnect 18:32:49 <frosch123> it looks more natural now 18:32:53 <glx> and git decided to do housekeeping while I was rebasing 18:33:21 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #8032: Fix #7904: Don't use a timer for hundredth tick determination https://git.io/JvruE 18:33:28 <glx> I hope it's clear enough 18:35:01 <milek7> I asked around on gcc irc 18:35:09 <milek7> there is vague possibility that they will define __has_attribute(access) to 2 to indicate extra features 18:35:20 <TrueBrain> frosch123: yeah, it seems the idea was to do it "on connected" not "on connect" :D 18:38:55 *** Wolf01 has joined #openttd 18:40:43 *** DasPoseidon has joined #openttd 18:44:01 <DorpsGek> [OpenTTD/OpenTTD] frosch123 updated pull request #8530: Fix: The time-out for connecting to the content-server was shorter th… https://git.io/JLpgA 18:47:49 <TrueBrain> https://github.com/OpenTTD/OpenTTD/pull/8529 <- can someone review this before 2000 pretty please? :D 18:48:22 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #8530: Fix: The time-out for connecting to the content-server was shorter th… https://git.io/JLpVr 18:48:33 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #8529: Fix af22a4f2: scenario editor doesn't have build station/depot/etc https://git.io/JLpVo 18:48:43 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8529: Fix af22a4f2: scenario editor doesn't have build station/depot/etc https://git.io/JLpg6 18:48:44 <TrueBrain> tnx! 18:50:45 <glx> and now I reread previous commits and may have found an issue, need to check 18:51:15 <TrueBrain> oh-oh :P 18:52:14 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8032: Fix #7904: Don't use a timer for hundredth tick determination https://git.io/JLpV7 18:53:20 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #8032: Fix #7904: Don't use a timer for hundredth tick determination https://git.io/JLpVA 18:53:55 <glx> dinner time 18:54:16 <TrueBrain> enjoy! 18:54:44 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #8032: Fix #7904: Don't use a timer for hundredth tick determination https://git.io/JLpwJ 18:55:57 <Samu> dinner, afk 18:57:12 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #8032: Fix #7904: Don't use a timer for hundredth tick determination https://git.io/JLpwt 18:57:58 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #8032: Fix #7904: Don't use a timer for hundredth tick determination https://git.io/JLpwJ 18:58:06 <TrueBrain> damn, you are sharp today frosch123 :) 18:58:30 <frosch123> i stopped working early, it was too boring 18:59:04 <TrueBrain> so you come to OpenTTD! :D 18:59:35 <TrueBrain> sorry glx, it sounded like a good idea to move the code; I was wrong :) 19:02:30 <frosch123> you can probably move the scheduledinvalidation stuff up 19:02:57 <frosch123> it should be one of the first things to call. it's weird there is so much stuff in front of it 19:06:18 <TrueBrain> hmm .. I can make functions 'static' 19:06:19 <TrueBrain> I like doing that 19:08:58 <milek7> so, did we discuss admin port? 19:09:08 <milek7> whether it should be also migrated to pubkey auth? 19:09:26 <TrueBrain> I believe we left it that you were going to see if we could find a library that also could be used by 3rd party? 19:10:24 <milek7> hmm, yes 19:10:39 <milek7> I'll check then 19:10:46 <TrueBrain> if you wouldn't mind, that would be lovely :) 19:18:05 *** iSoSyS has quit IRC 19:18:34 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7286: Add #2155: newheightmapgame command https://git.io/JLprm 19:18:37 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed pull request #7286: Add #2155: newheightmapgame command https://git.io/fhNZl 19:18:54 <TrueBrain> that took a long time to establish ... but okay, 2 years after creating the PR, at least I have an opinion :D 19:20:36 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #8519: [OSX] Render screen in full native resolution on HiDPI displays. https://git.io/JLprn 19:20:58 <DorpsGek> [OpenTTD/OpenTTD] frosch123 merged pull request #8530: Fix: The time-out for connecting to the content-server was shorter th… https://git.io/JLpgA 19:23:40 <TrueBrain> yeah, tl;dr, console needs love :) 19:27:51 <Heiki> “uudelleensovittaa” is the shortest Finnish translation of “refit” I can come up with for STR_ERROR_AUTOREPLACE_INCOMPATIBLE_REFIT, sometimes I wonder why this language can’t express some things more concisely 19:28:02 <Heiki> real-life example, German vs. Finnish: http://vaunut.org/kuva/144773 19:28:49 <TrueBrain> we used refit many more times; all instances are that long? :D 19:29:19 <Heiki> no, in some context “sovittaa” is enough 19:29:24 <Heiki> +s 19:29:50 <TrueBrain> well, sucks to speak Finnish, I guess :P 19:29:50 <TrueBrain> :D 19:30:13 <Heiki> haha 19:30:23 <TrueBrain> omg, someone uploaded a savegame in lzo format 19:30:29 <TrueBrain> ..... what in the world 19:30:45 <milek7> where? 19:31:10 <TrueBrain> more importantly, how am I going to compile support for that :D 19:31:23 <Xaroth> Finnish has some fun words though 19:31:25 <Xaroth> like Tietokone 19:32:02 <TrueBrain> only funny to Dutch people, I guess? :P 19:32:15 <Xaroth> well yes 19:32:24 <TrueBrain> you are such a child :P 19:32:37 <Xaroth> :D 19:34:54 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #7619: Game crash from out-of-bounds helicopter, infinite circling with superfast aircraft https://git.io/fjz3Z 19:36:24 <TrueBrain> okay, I cannot explain enough how cool that bug is 19:36:33 <TrueBrain> I am not sure I can capture this on video even 19:38:20 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #8492: Fix: Don't allow towns to terraform certain floodable tiles https://git.io/JLdA0 19:38:37 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #7619: Game crash from out-of-bounds helicopter, infinite circling with superfast aircraft https://git.io/fjz3Z 19:42:45 *** gelignite has joined #openttd 19:45:26 <TrueBrain> so planes can go at such a fast speed, they miss their patterns or something ... 19:46:13 <frosch123> don't they slow down in holding patterns? 19:46:29 <TrueBrain> I think that movie gave you the answer :) 19:47:18 <frosch123> SPEED_LIMIT_HOLD 19:47:43 <frosch123> so either there is no holding position for that airport, or the speed limit does not work 19:47:53 <TrueBrain> lets find out! :) 19:49:43 <TrueBrain> no hold state reached 19:50:47 <TrueBrain> seems the airport has no holding pattern 19:51:10 <TrueBrain> now the question: should we still apply a speed limit when it goes in these circles? 19:51:40 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on issue #7619: Game crash from out-of-bounds helicopter, infinite circling with superfast aircraft https://git.io/fjz3Z 19:52:43 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #7619: Game crash from out-of-bounds helicopter, infinite circling with superfast aircraft https://git.io/fjz3Z 19:52:52 <frosch123> only the original large airport has a holding pattern 19:53:19 <frosch123> that's kind of funny 19:54:01 <TrueBrain> lol, it was the one I tested to make sure my debugging was valid 19:54:14 <TrueBrain> so what causes it to go in circles .. hmm 19:55:31 <supermop_Home> really any aircraft going that fas should be recolored to the fire cycle colors 19:55:49 <andythenorth> I love UIs designed by power users https://www.tt-forums.net/viewtopic.php?f=32&t=88329 19:56:23 <frosch123> wow 19:56:42 <TrueBrain> so when is that patch done? :D 19:57:09 <TrueBrain> that content downloading window is 10 times better, but that isn't saying a lot :P 19:57:09 <andythenorth> the ideas aren't awful 19:57:15 <andythenorth> and the thought gone into it is high 19:57:28 <andythenorth> it's not how I'd make a a simple interface 19:57:32 <TrueBrain> damn, that Rich NewGRF window 19:58:01 <TrueBrain> well, if he makes a design, I am pretty sure we can implement it, so .. there is that 19:58:20 <andythenorth> pff, that's what we said last time :) 19:58:34 <TrueBrain> we did? Hmm 19:59:06 <andythenorth> nah I'm just moaning I drew multiple newgrf and game start windows 19:59:16 <andythenorth> it was a long time ago 19:59:48 <andythenorth> anyway, it's nice to have pictures instead of words 19:59:56 <andythenorth> same for this also https://www.tt-forums.net/viewtopic.php?f=32&t=88255 20:00:23 <TrueBrain> did he implement it already?! 20:00:30 <TrueBrain> I assumed it was just art 20:00:35 <TrueBrain> but that gif suggests it is ingame :P 20:00:55 <andythenorth> it is extensive art 20:01:29 <andythenorth> really detailed mockups 20:02:04 * andythenorth still doesn't understand why authors don't just an extra vehicle ID for every variant 20:02:05 <TrueBrain> it is amazing 20:03:24 *** J0anJosep has quit IRC 20:04:46 <michi_cc> TrueBrain: Laggin quite a bit in catching-up, but you know if we go back to Azure, we can get a cloud HSM: https://docs.microsoft.com/en-us/azure/key-vault/managed-hsm/overview 20:04:57 <michi_cc> Might not be free, tough :p 20:05:00 <TrueBrain> michi_cc: I so read today yes :) 20:05:05 <TrueBrain> it is pretty nice 20:05:14 <TrueBrain> I even googled if GitHub has an interface with it 20:05:17 <TrueBrain> couldn't find it :( 20:06:13 <michi_cc> TrueBrain: https://docs.microsoft.com/th-th/azure/key-vault/secrets/quick-create-github-secret 20:06:20 <michi_cc> Doesn't mention HSM though. 20:07:19 <TrueBrain> owh, the other way around, did not check that :D 20:07:28 <TrueBrain> well, over time, maybe worth a further look 20:07:38 <TrueBrain> using HSM is .. better/easier? :D 20:11:58 <TrueBrain> okay, the airplanes in the bug moves fast enough that it overshoots the point it changes in the state machine 20:12:05 <TrueBrain> and that check is outside of the loop that moves the plane 20:12:06 <TrueBrain> ghehe 20:13:31 <frosch123> delete statemachines! 20:14:16 <TrueBrain> the simple solution is a really expansive calculation ... :P 20:14:19 <andythenorth> wat how does a state machine get out of state? :P 20:15:06 <TrueBrain> at its peek, it does 72 moves 20:15:11 <TrueBrain> how many pixels is a tile? 20:15:22 <frosch123> 16 world coordinates 20:15:30 <TrueBrain> so it can move .. 20:15:33 <TrueBrain> @calc 72 / 16 20:15:33 <DorpsGek> TrueBrain: 4.5 20:15:41 <andythenorth> hmm can we just detect the condition, then increase the player's high score? 20:15:44 <TrueBrain> tiles in 1 instant 20:15:46 <andythenorth> like...this is rare no? 20:15:53 <TrueBrain> happens with fast planes 20:16:38 <TrueBrain> and if the distance is < 4, it is ... nudges, towards the airport, it seems 20:18:25 <TrueBrain> so it depends on where the airport is located etc, how "unlucky" you get 20:18:56 <TrueBrain> guess we need an universal speed cap :P 20:19:03 <frosch123> if (!(amd.flag & AMED_EXACTPOS) && dist <= (amd.flag & AMED_SLOWTURN ? 8U : 4U)) return true; <- it can only warp so far 20:19:34 <TrueBrain> that check is outside the while in that function 20:19:45 <TrueBrain> that while does the real moving of the plane, and is called 70+ times 20:19:48 <TrueBrain> instead of the normal 1 to 2 :P 20:20:01 <frosch123> hmm, EXACTPOS is weird 20:20:19 <frosch123> it is set for the airport entry 20:20:27 <TrueBrain> there are already several safeguards to, in the end, make the plane go to the airport 20:20:31 <TrueBrain> but .. it is not enough :D 20:22:08 <TrueBrain> ah, and it circles as it tries to get to the entry point, overshoots, makes a turn, tries again 20:24:45 <TrueBrain> I think I can force it into a holding state if it overshoot once 20:25:55 <frosch123> can you do it by distance? 20:26:03 <TrueBrain> normal planes, as in, not absurd planes done in NewGRF, never go fast enough for count > 1 :) 20:26:27 <frosch123> slow down aircraft when near destination 20:27:02 <TrueBrain> I see no reason why not 20:28:12 <andythenorth> nerf newgrf 20:28:18 <TrueBrain> well, I say that .. it does mean I overrule the airport layout 20:28:23 <TrueBrain> as I force a holding pattern, basically 20:28:35 <frosch123> none of them define one, except one 20:28:41 <TrueBrain> okay 20:29:00 <frosch123> and in utopia someone implemented modular airports, so no stupid statemachines 20:29:58 <TrueBrain> so 6 tiles before an airport I make it slow to holding speed 20:30:50 <frosch123> can it turn within 6 tiles? would be silly if it got further away again because it has to turn by 270° or so 20:31:34 <TrueBrain> what do you mean, sorry? 20:31:59 <TrueBrain> lol, 6 tiles isn't enough for this plane, omg .. eeuuhhhhhh 20:32:10 <milek7> https://github.com/Xaroth/libottdadmin2/blob/master/libottdadmin2/packets/base.py#L220 20:32:39 <milek7> wtf it does? 20:33:14 <frosch123> TrueBrain: train approaches airport, gets within 6 tiles, slows down, state machine requiests to go in different direction, aircraft turns slowly, but while flying the arc it gets further away than 6 tiles again 20:33:30 <TrueBrain> haha, yeah, that is possible 20:33:35 <TrueBrain> I can set HOLD state on it 20:33:38 <TrueBrain> that would prevent that 20:33:56 <TrueBrain> but that means we are really overruling NewGRFs :) 20:34:01 <Xaroth> milek7: it combines all data to be sent into one output buffer 20:34:16 <frosch123> TrueBrain: those statemachines are not in newgrf 20:34:22 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #8404: Feature: Snow line height can be autodetermined upon world generation https://git.io/JLa2N 20:34:31 <TrueBrain> frosch123: NewGRFs cannot define holding patterns? 20:34:54 <Xaroth> milek7: constantly constructing/packing/unpacking structs can get slow, so we build one big struct, construct it once, then pack/unpack with the current data that needs packing/unpacking. 20:34:57 <frosch123> newgrf can define look&feel of airports. but there are only the fixed state machines from airport_movement.h 20:35:04 <TrueBrain> ah .. did not know 20:35:12 <TrueBrain> explains why someone was talking about NewGRF airports :P 20:35:17 <TrueBrain> euh, yes, that changes things a bit 20:35:21 <frosch123> newgrf airports were not finished. and then people noticed that they were the wrong idea anyway 20:36:37 <frosch123> playing with airports is boring, because you can only choose from a fixed set. newgrf airports add a game "design an airport". which is fun, but it is added for newgrf authors, nor for players :p 20:36:50 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #7619: Game crash from out-of-bounds helicopter, infinite circling with superfast aircraft https://git.io/fjz3Z 20:37:22 <TrueBrain> design your own airport as player .. now that is an idea :P 20:37:36 <michi_cc> NewGRF statemachine airports don't really add that much. IMHO modular airports are the way to go (no, I'm not volunteering). 20:37:39 <frosch123> there are like 3 partial implementations of that 20:38:01 <TrueBrain> would be really fun, if you put down your own runways etc 20:38:06 <TrueBrain> means I can make Schiphol :D 20:38:09 <TrueBrain> (it has an insane layout) 20:38:26 <frosch123> funnily modular airports also fix the broken airport catchment area and noise mechanics 20:38:40 <frosch123> only terminals would have catchment, and only runways would have noise 20:38:59 <TrueBrain> so, another thing that needs revamping 20:39:01 <TrueBrain> my list is getting big :P 20:39:02 <andythenorth> airport taxiways over bridges or go home 20:39:06 <michi_cc> But if I would do that, I think I would try mapping aircraft movement like trains, i.e. airport tiles have trackbits, "signals", and movement is PBS based. 20:39:06 <frosch123> so, if your planes "drive" far enough ... you can use them as bus shuttle service 20:39:12 <Xaroth> airport taxiways over roads or go home 20:39:18 <Xaroth> otherwise TrueBrain can't make his Schiphol recreation. 20:39:21 <andythenorth> same thing :P Xaroth 20:39:32 <andythenorth> I was thinking of one of the Paris ones 20:39:38 <andythenorth> Orly or CDG, can't remember 20:39:48 <milek7> Xaroth: if "combines all data to be sent into one output" I would expect to be called at the end 20:39:49 <TrueBrain> another type of "road" .. taxiways 20:39:55 <milek7> but it's called in write_str 20:39:55 <andythenorth> I flew London -> Paris once, more time taxiing in Paris than flying 20:40:14 <frosch123> michi_cc: TrueBrain: https://www.tt-forums.net/viewtopic.php?t=38709 <- someone tested that aircraft pbs thingie by writing a prototype minigame in java 20:40:15 <andythenorth> TrueBrain it's simple really, planes just reimplement as hovercraft 20:40:22 <frosch123> can't remember how good it was 20:40:27 <andythenorth> hovercraft need altitude 20:40:35 <TrueBrain> it is a really fun idea, modular airports (for players) 20:40:47 <Xaroth> milek7: write_str forces the data before the string to be packed, then appends the string 20:41:00 <Xaroth> because python structs don't do strings the way ottd likes to receive it 20:41:23 <Xaroth> so at that point the data before write_str becomes a struct/pack and the data after another one. 20:41:50 <TrueBrain> okay, and planes are never in a holding state .. the state machine target can have that flag .. hmmm 20:42:29 <milek7> Xaroth: so _write_process should be called before every _buffer modification? 20:43:12 <Xaroth> pretty much, yes 20:43:17 <Xaroth> it's a noop if nothing needs to be done 20:43:39 <milek7> ok, thanks 20:43:50 <Xaroth> What are you trying to do? 20:44:32 <milek7> sending raw bytes 20:44:35 *** jottyfan has joined #openttd 20:44:37 <milek7> containing pubkey and signature 20:44:39 *** jottyfan has quit IRC 20:44:54 <Xaroth> fun 20:45:04 <Xaroth> let me know what you've made of it :) 20:45:37 <frosch123> aw, it does not work. so much for java 20:46:38 <milek7> oh 20:46:58 <milek7> does write_byte can already accept many bytes? 20:47:28 <Xaroth> yes, but it's not made for a gazillion bytes 20:47:39 <Xaroth> https://docs.python.org/3/library/struct.html < that's what it uses internally 20:48:22 <Xaroth> write_byte uses B 20:48:35 <Xaroth> so you might want to add something that uses 's' 20:49:39 <milek7> I guess appending bytearray to _buffer and increasing _index would work too? 20:50:08 <Xaroth> if you preface\ it with _write_process, yes 20:50:14 <TrueBrain> meh; making the plane slow down is easy .. to keep it slowed down till it landed, hard .. 20:53:32 <TrueBrain> owh, I was thinking dist was in tiles, but it is in subtiles, or what-ever we call them 20:53:46 <Samu> may I suggest a min snowline height of 3? 20:53:59 <Samu> change MIN_SNOWLINE_HEIGHT to 3 20:54:09 <Samu> then my PR can go to dust 20:55:05 <Samu> but farms fail to generate at that height 20:55:18 <Samu> fail at height 2 20:56:08 <Samu> your PR handles forests 20:56:15 <Samu> kinda 20:56:42 <Samu> unless i'm stupid and set a snowline height higher than the max height 20:57:23 <TrueBrain> https://www.youtube.com/watch?v=zpMZcQ1lGWU 20:57:37 <TrueBrain> Replace Dancing with Talking, and that is what is my head atm 20:58:15 <Samu> your commit, since now it's on master 20:59:15 <Samu> https://github.com/OpenTTD/OpenTTD/commit/7463c46a54bed2d21ee8e8e2e8cfe9d67f5f45dc 21:00:09 *** ekangmonyet has quit IRC 21:00:41 <Samu> nevermind, I fail at explaining 21:00:50 *** ekangmonyet has joined #openttd 21:00:51 <frosch123> that's why we have no voice chat 21:01:26 <TrueBrain> wait, you were explaining something? Sorry, I thought you were mumbling in yourself :) That we were just a rubber ducky 21:01:32 <TrueBrain> it is how andythenorth and I get through the day 21:01:35 <TrueBrain> pretty normal for this channel :) 21:01:53 <andythenorth> sometimes people even reply 21:02:47 <Samu> I think I rather close my PR. Doesn't seem useful anymore 21:06:12 <TrueBrain> must .. not .. touch .. other .. parts of this code 21:06:14 <TrueBrain> "speed" is signed 21:06:23 <TrueBrain> like ... can a plane go backwards?! (it cannot) 21:06:42 <_2TallTyler> That would be a problem, I think 21:06:50 <andythenorth> wait wat? 21:06:59 <andythenorth> helicopter backwards is needed 21:07:04 * andythenorth cancels plane grf idea :( 21:12:40 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #8032: Fix #7904: Don't use a timer for hundredth tick determination https://git.io/JvruE 21:14:20 *** rptr_ has joined #openttd 21:16:14 <glx> andythenorth: CDG goes over the highway 21:17:04 <andythenorth> airway bridges then 21:17:09 <andythenorth> but only on French maps 21:21:07 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #8531: Fix #7619: nudge fast planes sooner towards their target https://git.io/JLp1e 21:21:09 <TrueBrain> I think this is a clean solution :) 21:23:18 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #8532: Fix 85a49a0d: invalidate airport toolbar when new planes become available https://git.io/JLp1k 21:24:13 <TrueBrain> https://github.com/OpenTTD/OpenTTD/issues/8121 <- tempted to close with: not-a-bug. Did I miss anything? :) 21:27:58 <glx> hmm yeah weird behaviour but intended 21:28:14 <TrueBrain> the 3rd tile of a dock is just a really odd requirement .. 21:28:52 <frosch123> yay, tb is removing c89 stuff 21:28:56 <glx> it's to make sure a boat can dock I think, but now we have more docking tiles 21:29:03 <TrueBrain> frosch123: I knew that would make you happy :D 21:29:31 <TrueBrain> I also made it into an unsigned int, but that was a world of hurt .. lot of that code is still signed, for no reason what-so-ever besides being signed 21:29:40 <TrueBrain> +almost 21:30:05 <TrueBrain> shit like: uint bla = <table value>; int other_bla = bla >> 8 21:30:10 <TrueBrain> makes me nervous :P 21:30:24 <TrueBrain> (well, uint8 vs int32, but okay) 21:30:35 <TrueBrain> euh, uint16 21:30:36 <TrueBrain> lol 21:30:41 <TrueBrain> it is late okay, shut up :P 21:30:55 <glx> yeah uint8 >> 8 is 0 ;) 21:31:43 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #8121: Cannot rebuild just buildozed dock https://git.io/JfnIF 21:31:46 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed issue #8121: Cannot rebuild just buildozed dock https://git.io/JfnIF 21:31:52 <TrueBrain> doing psuedo-code is hard :P 21:32:44 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #8532: Fix 85a49a0d: invalidate airport toolbar when new planes become available https://git.io/JLp1P 21:32:47 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #8404: Feature: Snow line height can be autodetermined upon world generation https://git.io/JLp11 21:32:49 <_2TallTyler> Re: #8506, I think this is a legitimate thing to fix. If a town can't build a road type, it shouldn't be able to build junctions on that road. 21:33:32 <TrueBrain> _2TallTyler: currently, towns are not really NewGRF aware :P But I like the way you think .. I wonder if that is easy to add 21:34:05 <glx> towns parly understand NRT 21:34:26 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8532: Fix 85a49a0d: invalidate airport toolbar when new planes become available https://git.io/JLp1k 21:34:31 <TrueBrain> sorry, town-roads :P 21:34:43 <_2TallTyler> I've been working on it for several hours. Still trying to figure out where to put the check. 21:35:17 <_2TallTyler> There's a lot of duplication in town_cmd, partly due to the multiple road layouts 21:35:32 <TrueBrain> yupppppp 21:35:39 <glx> there's at least a check for the flags, but it's not enough it seems 21:36:13 <glx> I think road type flag is checked only for empty tiles 21:36:16 <_2TallTyler> There's a check for whether houses can grow along the road, but not whether the town can build it 21:37:44 <_2TallTyler> I actually have it working, but I need to figure out how to let the growth algorithm continue along the road 21:38:42 <_2TallTyler> I think we can ignore the flag about whether houses can grow. If a town can't build a road type, that should mean no junctions on said road either 21:41:37 <glx> GetTownRoadType() checks the can build road type flag, but it's the only place checking it I think 21:49:20 *** tokai has joined #openttd 21:49:20 *** ChanServ sets mode: +v tokai 21:50:49 <glx> _2TallTyler: I think the main issue is to find where it's built and go back from there 21:51:39 <_2TallTyler> I'm currently working inside GrowTownInTile() 21:52:00 <glx> but yeah the code is hard to read and follow 21:52:45 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #8533: Fix: don't allow free-wagon-chains to exceed max-train-length https://git.io/JLpMo 21:52:52 <TrueBrain> looking for opinions ^^ 21:52:56 <TrueBrain> looking at you LordAro :D 21:53:25 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #8404: Feature: Snow line height can be autodetermined upon world generation https://git.io/JLa2N 21:54:42 *** Samu has quit IRC 21:55:03 <_2TallTyler> Does an excess-length train give an error as when dragging trains into one consist, or overflow into a new line as when you're buying trains? 21:55:23 <TrueBrain> latter when buying 21:55:25 <TrueBrain> first when dragging 21:55:48 *** Samu has joined #openttd 21:55:56 <glx> so multi free-wagon chains ? 21:55:59 <TrueBrain> yes 21:56:07 <TrueBrain> which was already the case for incompatible wagons 21:56:11 <_2TallTyler> Makes sense to me 21:56:14 *** tokai|noir has quit IRC 21:56:23 <glx> I think AI can already lose track of free wagons 21:56:45 <TrueBrain> yeah .. Human vs AI :) 21:57:04 <Samu> dear TrueBrain, you might want to add this to your arctic section https://github.com/OpenTTD/OpenTTD/pull/8404/files#diff-8463692a54e306b04c06accf493308970b084cc1a2d09c9d93160ba0dc283924 21:57:19 <Samu> and now i gotta run 21:57:21 <Samu> good night 21:57:26 *** Samu has quit IRC 21:57:31 <TrueBrain> I ... don't even know ... wuth? 21:58:05 <DorpsGek> [OpenTTD/OpenTTD] J0anJosep commented on pull request #8533: Fix: don't allow free-wagon-chains to exceed max-train-length https://git.io/JLpM5 21:59:12 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #8533: Fix: don't allow free-wagon-chains to exceed max-train-length https://git.io/JLpMo 21:59:27 <TrueBrain> I have, once again, no clue what Samu was on about 21:59:54 <TrueBrain> I have no open PRs about that stuff ... shrug 22:00:00 <TrueBrain> spends time on things he does understand instead 22:00:36 <frosch123> diff is out-dated, can't comment :/ 22:00:55 <glx> oh TrueBrain, try pressing a shortcut key, like A for autorail, during the newgrf scan 22:01:04 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #8533: Fix: don't allow free-wagon-chains to exceed max-train-length https://git.io/JLpDJ 22:01:15 <TrueBrain> glx: my NewGRF scans don't take that long 22:01:21 <TrueBrain> what am I to see or not to see? 22:01:29 <glx> a crash 22:02:16 <TrueBrain> and why are you telling me? :) 22:02:32 <glx> it's related to toolbars 22:02:44 <TrueBrain> so I now became the drain for all issues related to toolbars? :( 22:02:44 <TrueBrain> :P 22:03:10 <TrueBrain> but I don't believe I touched code related to that, did I? 22:04:26 <frosch123> i think that modal thingie broke somewhen 22:04:53 <frosch123> i don't think it should handle any hotkeys during modal state 22:05:05 <glx> it's not only the grf scan, it's the main menu 22:05:20 <glx> https://github.com/OpenTTD/OpenTTD/commit/85a49a0d3#diff-c3bd27ff69cf1279f08dce978b9675810679458efabacf2cefab2e9f81a218d0L784 <-- removed some checks 22:05:27 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #8533: Fix: don't allow free-wagon-chains to exceed max-train-length https://git.io/JLpMo 22:05:52 <TrueBrain> glx: LOL .. stupid reviewers :P 22:06:10 <TrueBrain> I have no idea why I brainfarted on that 22:06:15 <glx> I'll fix it, I know what to look 22:06:25 <TrueBrain> I want to fix it to, no problem? 22:06:43 <glx> it's your code, so feel free 22:07:11 <TrueBrain> it is all our code :) 22:07:20 <glx> well your change ;) 22:07:41 <glx> but it was easy to overlook 22:08:20 <glx> so many special handlings everywhere 22:09:44 *** frosch123 has quit IRC 22:09:45 <TrueBrain> yeah, but I cannot believe I threw out that whole line 22:10:36 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #8534: Fix 85a49a0d3: hotkeys were enabled outside of GM_NORMAL https://git.io/JLpD2 22:11:32 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8533: Fix: don't allow free-wagon-chains to exceed max-train-length https://git.io/JLpDV 22:13:46 <TrueBrain> ugh, forgot how incredible difficult the "next" chain was in OpenTTD for trains 22:13:54 <TrueBrain> sounds like it is very overcomplicated 22:15:30 <TrueBrain> _2TallTyler: did you find where OpenTTD grows roads? (that was what you were after, right?) 22:16:04 <_2TallTyler> Yes, I've mostly got it working 22:16:09 <TrueBrain> good 22:16:17 <TrueBrain> the code is very odd where it decides what to do next 22:16:20 <TrueBrain> partially checking for road-growth 22:16:24 <TrueBrain> partially for house-growth 22:16:33 <TrueBrain> and on top of that 2 completely different layouts 22:16:35 <TrueBrain> it is .. lovely code :D 22:16:37 *** sla_ro|master has quit IRC 22:17:08 <andythenorth> goes it throw out? 22:17:17 <_2TallTyler> I'm hoping I can work towards understanding it, then clean it up 22:17:34 <glx> I like your spirit :) 22:17:57 <TrueBrain> I wouldn't bother too much _2TallTyler 22:18:02 <andythenorth> we haven't had this for a while https://www.tt-forums.net/viewtopic.php?p=192300#p192300 22:18:13 <TrueBrain> we plan to work towards making GS do town growth 22:18:21 <TrueBrain> if that happens, this code would be mostly voided anyway 22:18:28 <TrueBrain> so don't spend too much time on cleaning it up 22:18:33 <_2TallTyler> GS or NewGRF? 22:18:44 <TrueBrain> shrug 22:18:47 <TrueBrain> GS most likely 22:18:55 <_2TallTyler> Or does that go in parallel with allowing multiple GS if they don't conflict? 22:19:48 <TrueBrain> one doesn't work without the other, so properly 22:19:54 <TrueBrain> but it is early days 22:20:02 <TrueBrain> anyway, cleaning up your own work == good 22:20:40 <TrueBrain> cleaning up the town growth mess .... I am sure I can find something better for you to do :P 22:20:53 <glx> hmm there's a non working hotkey in road toolbar, but probably not related 22:21:10 <_2TallTyler> I have some ideas but they're a bit beyond my abilities right now 22:21:37 <TrueBrain> glx: which? 22:21:59 <glx> autoroad, default key is 3 22:22:24 <TrueBrain> works for me 22:22:35 <TrueBrain> both ingame as in SE 22:22:38 <TrueBrain> did you remap any keys? :P 22:22:41 <glx> hmm unless I'm reading the wrong hotkey file 22:23:40 <glx> was reading the wrong file, I indeed remap 22:24:24 <TrueBrain> pfew :) 22:24:29 <TrueBrain> that would have been so selective :P 22:24:54 <TrueBrain> https://github.com/OpenTTD/OpenTTD/issues/7869 <- seems that is the only thing I have left over for 1.11 .. well, besides the other PRs people are working on, ofc :) 22:25:17 <andythenorth> woo 22:25:21 <TrueBrain> and the issue-count is also slowly decreasing .. that aint bad 22:26:48 <andythenorth> < 100 TBH is pretty healthy 22:26:55 <glx> indeed using the correct keys work, I forgot I changed them 22:26:59 <andythenorth> I know it's just numbers, but eh 22:27:58 <andythenorth> maybe we have a clean up after 1.11 22:28:01 * andythenorth wants to close https://github.com/OpenTTD/OpenTTD/pull/8461 22:28:04 <TrueBrain> I doubt any number is healthy .. the amount of closed vs opened says a bit more :D 22:28:20 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #8534: Fix 85a49a0d3: hotkeys were enabled outside of GM_NORMAL https://git.io/JLpyv 22:28:27 <TrueBrain> there was no consensus on #8461 yet 22:28:35 <TrueBrain> closing for the fact of closing is also not a good idea :) 22:28:50 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8534: Fix 85a49a0d3: hotkeys were enabled outside of GM_NORMAL https://git.io/JLpD2 22:28:54 <TrueBrain> glx: I checked the other toolbars in the code too :D 22:29:00 <TrueBrain> just to be sure :P 22:30:56 <glx> hehe 22:31:02 <andythenorth> closing non-destroyable rivers I'd do because I think it's a bad idea in concept, but eh, just my view 22:31:30 <andythenorth> hmm PR count has gone down, can't keep up :P 22:31:43 <TrueBrain> andythenorth: so typie typie that, or give my comment a +1 via emoticon :) 22:31:55 <TrueBrain> PR count is up :P I made too many PRs :D 22:32:01 <TrueBrain> we keep bouncing around 50 :P 22:32:03 <andythenorth> "how many is too many" 22:32:21 <TrueBrain> well, if I drain the resources of other devs, it is too many 22:32:24 <andythenorth> 'bouncing around 50' is steady state if they move? 22:32:28 <TrueBrain> but I am almost done, so just a little bit longer :D 22:32:41 <TrueBrain> https://github.com/OpenTTD/OpenTTD/pulse :P 22:32:50 <TrueBrain> merged 48 PRs in 1 week 22:33:12 <andythenorth> pretty rad 22:34:12 <_2TallTyler> I've got some more PRs on the way to keep the count up :P 22:35:40 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #8471: Fix #8462: Don't check whether to grow a town road on water https://git.io/JLpyW 22:37:50 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #8419: Trains stuck at path through implicit destinations after fixing route towards real destination https://git.io/JLPDF 22:39:31 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened pull request #8535: Fix #8506: Towns don't add junctions to NewGRF roads they cannot build https://git.io/JLpyz 22:39:54 <glx> already ? 22:40:34 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #8405: Trains not unloading load at station to later go to the depot for maintenance https://git.io/JLVPs 22:40:37 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed issue #8405: Trains not unloading load at station to later go to the depot for maintenance https://git.io/JLVPs 22:40:46 <_2TallTyler> Think I figured it out, but I'd like help testing edge cases. Hoping James103 sees it. :P 22:40:56 <glx> huhu 22:41:23 <TrueBrain> "As a quick-fix, you can set the order of a train to go to a depot after a station; it will not do automatic service at that point, and go when it is done with the station." <- this is true, right? 22:41:54 <TrueBrain> lol @ commit message _2TallTyler .. so you fix that they don't add junctions? Or you fix that they do? :P 22:42:08 <glx> yes if there's a depot in the orders, it won't never decide to go to depot by itself 22:42:24 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #7901: Train prefers service in depot over station https://git.io/Jeh7q 22:42:50 <_2TallTyler> Uh, let me fix that 22:44:24 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #8535: Fix #8506: Towns don't add junctions to NewGRF roads they cannot build https://git.io/JLpyz 22:45:42 <_2TallTyler> Dinnertime; be back later 22:45:48 <TrueBrain> enjoy 22:45:52 <andythenorth> hmm is it bedtime? 22:46:01 * andythenorth needs magic 8 ball 22:46:18 <andythenorth> nope, it's tidy the kitchen time 22:46:25 <TrueBrain> highway is always build by the player in this case, right? 22:46:37 <TrueBrain> there is 1 other place that can build roads in town growth 22:46:43 <TrueBrain> but, only if it can clear the tile 22:46:47 <TrueBrain> so that shouldn't be the case 22:47:39 <TrueBrain> PR looks good to me; but I am scared shitless to approve it :P 22:49:21 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed issue #8290: Game Crashed while attempting to clone a train in one depot while train is in another depot https://git.io/JJMmI 22:49:33 <glx> yeah it seems correct to me, but maybe ask the #8506 author to test 22:49:46 <TrueBrain> glx: merge and ask after? :P 22:49:57 <glx> preview and ask ? 22:50:04 <TrueBrain> I was about to say: owh, we have previews! 22:50:09 <TrueBrain> so yeah, add that preview label glx :D 22:50:19 <TrueBrain> I am also still getting used to us having that :P 22:51:43 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed issue #8275: NRT uses "backwards" roadtype intercompatibility, at least in NML https://git.io/JJZ3X 22:52:55 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #8272: Stopped vehicule destination should be red when mouse over https://git.io/JJ35w 22:53:49 * andythenorth tinkers with an idea 22:54:05 <TrueBrain> be careful with that 22:54:08 *** gelignite has quit IRC 22:54:25 <andythenorth> yeah, also it's an implementation idea not a use case, and it's half-assed 22:54:39 <andythenorth> probably explodes in my face 22:54:43 <andythenorth> much regret 22:55:17 <DorpsGek> [OpenTTD/OpenTTD] Milek7 updated pull request #8391: RFC: Feature: Public key company authorization https://git.io/JLnig 22:56:16 <andythenorth> @Timberwolf would you have a use for extensible arbitrary vehicle properties (defined per grf)? E.g. livery, gear ratio, all that crap? 22:56:28 <andythenorth> oops no @, not discord :P 22:59:38 <TrueBrain> https://github.com/OpenTTD/OpenTTD/issues/8034 <- it is not wrong .. it is of course meant as a fun remark, but in this day and age, it is not okay anymore .. 23:00:43 <andythenorth> I used to write silly things like that 23:00:46 <andythenorth> now I don't so much 23:00:50 <milek7> Xaroth: https://github.com/Milek7/libottdadmin2/commit/4590a8901a17d20ef93cc61d9047b1b64e142af3 23:01:45 <TrueBrain> funny, I never read the text .. lolz 23:02:08 <andythenorth> Whenever I read it now the words 'fuck you' silently play in my head 23:02:11 <andythenorth> such a rebel 23:02:13 <TrueBrain> OMG! I NOW HAVE milek7 's SECRET KEYS! 23:02:39 <milek7> ugh, no :P 23:02:42 <andythenorth> I mean, for newgrf testing I have to use cheat constantly 23:02:50 <andythenorth> so maybe I see it more than most 23:02:51 <milek7> password in cmdline argument is still used 23:03:03 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #8506: Town builds unnecessary junctions on highway https://git.io/JLN40 23:04:50 <Xaroth> milek7: https://github.com/Milek7/libottdadmin2/blob/4590a8901a17d20ef93cc61d9047b1b64e142af3/libottdadmin2/client/common.py#L54-L58 might as well move that to on_server_need_keyauth (basically what the lines below do) 23:05:18 <Xaroth> that's what the callbacks are for, and allows people to override the functionality (if ever needed) 23:05:38 <milek7> this isn't meant to be overriden 23:05:46 <milek7> I need access to self._keypair there 23:05:51 *** Progman has joined #openttd 23:06:33 <Xaroth> all the on_* functions have access to self, and with that, self._keypair 23:06:45 <milek7> ah 23:07:03 <Xaroth> much like on_server_shutdown 23:07:15 <DorpsGek> [OpenTTD/OpenTTD] michicc opened pull request #8536: Feature: Choose a sensible window size on a fresh OTTD config file. https://git.io/JLpSy 23:07:19 <DorpsGek> [OpenTTD/OpenTTD] michicc opened pull request #8537: Feature: Automatic UI and font zoom levels. https://git.io/JLpSS 23:07:41 <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #8519: [OSX] Render screen in full native resolution on HiDPI displays. https://git.io/JLxK4 23:08:02 <milek7> it's only quick demo anyway, I didn't even bother with proper typing 23:08:02 <Xaroth> technically this means you can create two classes, one that does password auth, and one that does keypair auth, without them interfering 23:08:07 <Xaroth> fair enough 23:08:26 <michi_cc> andythenorth: #8537 makes a lot of sense together with #8519 (should apply/merge cleanly on top, too). 23:09:36 <andythenorth> +1 23:09:41 <andythenorth> I'll test tomorrow probs :) 23:10:12 <andythenorth> I'm not sure 8519 is viable on most contemporary macs though for performance reasons 23:10:39 <andythenorth> mine is a relatively high end 2020 i9 and performance was low so far 23:10:40 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #8538: Remove: warning in cheat window https://git.io/JLpSx 23:10:43 <TrueBrain> let's see how many people I can tick off with 1 PR :) 23:11:05 <andythenorth> maybe I should put xcode on my kids' m1 23:11:55 <andythenorth> mac games tend to not run in HDPI for performance reasons, and generally macs have very poor UI and screen drawing performance these days 23:12:31 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8536: Feature: Choose a sensible window size on a fresh OTTD config file. https://git.io/JLp9f 23:13:44 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on pull request #8538: Remove: warning in cheat window https://git.io/JLp9T 23:15:08 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8538: Remove: warning in cheat window https://git.io/JLp9t 23:16:03 <Timberwolf> Aw :( 23:16:07 <Timberwolf> GS joke injection API! 23:18:11 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #8536: Feature: Choose a sensible window size on a fresh OTTD config file. https://git.io/JLp9Z 23:19:14 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #8536: Feature: Choose a sensible window size on a fresh OTTD config file. https://git.io/JLp9l 23:19:52 <TrueBrain> michi_cc: good enough reason for me. Maybe we should write it in a comment or what-ever .. *shrug* 23:20:58 <TrueBrain> Timberwolf: haha :) 23:22:30 <TrueBrain> can't find other open bugs that I consider worth fixing for 1.11 .. few triages that might be worth doing 23:23:03 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #8518: [OSX] Replace FreeType by native glyph rasterization https://git.io/JLp9r 23:24:12 *** Wolf01 has quit IRC 23:25:56 <TrueBrain> glx: I added the direct link to the preview for his comfort; not sure yet everyone know where to find the deployment button :) 23:26:06 *** roadt__ has quit IRC 23:26:08 <TrueBrain> still not sure about that part .. 23:26:19 *** roadt__ has joined #openttd 23:35:39 <michi_cc> Emscripten could use an implentation of #8537. No idea at all though how (and if at all) you can get DPI on Emscripten. 23:36:28 <TrueBrain> hopefully someone walk by that want to do that :D Would be nice :) 23:36:46 <TrueBrain> I have been considering putting somewhere things in all kind of domains of the game people could help out with 23:36:53 <TrueBrain> we now have a few "good first" issues 23:36:56 <TrueBrain> but it is hard to find and read 23:37:09 <TrueBrain> maybe a project to bind them together 23:37:52 <TrueBrain> anyway, it might look we can do a 1.11 beta somewhere at the beginning of next week .. 23:38:57 <TrueBrain> at least, if I have anything to say in it :P 23:39:03 <TrueBrain> we might want to figure out signing first, I guess 23:39:28 <TrueBrain> if there are open issues / PRs you consider should be in 1.11, please add them to the milestone (goes for everyone) 23:42:13 <supermop_Home> andythenorth its past your bedtime 23:42:19 <andythenorth> so is 23:42:28 <TrueBrain> :D You guys are cute 23:42:43 <supermop_Home> here it is beertime 23:46:53 <supermop_Home> not sure what openttd thing i should be doing next 23:49:39 <DorpsGek> [OpenTTD/OpenTTD] LC-Zorg opened issue #8539: Graph Window - Colors of the mauve, dark green and purple companies are barely visible https://git.io/JLpHF 23:53:43 <TrueBrain> Oeh, he found GitHub. Lovely ticket, clear and suggestions how to solve it :D 23:56:02 <andythenorth> right, bedtime 23:56:11 <andythenorth> I turn into a goblin if I stay up past midnight 23:56:13 <andythenorth> or get wet 23:56:22 *** andythenorth has quit IRC