Times are UTC Toggle Colours
00:03:46 *** HerzogDeXtEr has quit IRC 00:08:35 *** moll has quit IRC 00:12:40 *** Wolf01 has quit IRC 00:27:05 *** Westie has quit IRC 00:32:06 *** moll has joined #openttd 00:55:08 *** glx has quit IRC 01:02:30 *** Westie has joined #openttd 01:09:48 *** Flygon has joined #openttd 01:48:31 *** Wormnest has quit IRC 01:48:55 *** Wormnest has joined #openttd 03:11:03 *** Wormnest has quit IRC 03:36:40 *** debdog has joined #openttd 03:40:00 *** D-HUND has quit IRC 03:57:20 <Wuzzy2> reminder that https://github.com/OpenTTD/OpenSFX/pull/14 is ready for review 03:57:23 <Wuzzy2> bye 03:57:26 *** Wuzzy2 has quit IRC 07:00:48 *** andythenorth has joined #openttd 07:08:57 *** sla_ro|master has joined #openttd 07:42:38 *** andythenorth has quit IRC 07:49:38 *** andythenorth has joined #openttd 08:00:33 *** supermop_Home has quit IRC 08:01:41 *** Wolf01 has joined #openttd 08:06:07 *** HerzogDeXtEr has joined #openttd 08:36:07 <andythenorth> yo 08:51:16 *** Gustavo6046 has quit IRC 08:54:39 *** jgx__ has joined #openttd 09:00:51 *** jgx_ has quit IRC 09:27:39 *** roadt_ has joined #openttd 09:34:16 *** roadt__ has quit IRC 10:21:35 <TrueBrain> https://github.com/OpenTTD/OpenTTD/blob/master/src/video/sdl2_v.cpp#L356 <- sometimes a comment is not helping anything 10:21:48 <TrueBrain> I understand what it does, but WHY it is doing that .... absolutely no clue 10:22:54 *** HerzogDeXtEr has quit IRC 10:23:24 *** HerzogDeXtEr has joined #openttd 10:23:38 <TrueBrain> https://github.com/OpenTTD/OpenTTD/commit/f4f4044859b9ae89f70dcffc459b81d769c0a93f <- this massive commit-message commit introduced it, it seems 10:24:18 <TrueBrain> still no clue as to why :) 10:28:31 <LordAro> maybe you need to track down that paper :) 10:28:56 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #8664: Fix potential bug in SDL2 driver introduced in last cleanup, and cleanup some more https://git.io/JtK3K 10:29:55 <TrueBrain> I now just removed that line, as with OpenGL it was a bit troublesome 10:30:11 <LordAro> i presume you checked that it made no difference to performance? 10:30:12 <TrueBrain> it might have been an SDL1 only thing :P 10:30:27 <TrueBrain> I did; and that line is ONLY called on first tick 10:30:46 <LordAro> maybe you should test it with SDL1 as well :p 10:31:14 <TrueBrain> you make it sound I care enough :) 10:31:58 <TrueBrain> hmm, looking at the code some more .. _num_dirty_rects is initialized 0 anyway 10:32:20 <LordAro> it does seem unlikely to be doing anything 10:35:12 <TrueBrain> I found many minor issues with SDL driver, but none are influence by that variable being set to 0 :) 10:35:38 <TrueBrain> for example, increasing the window size can create random artifacts in the new (what-should-be-black) part of the screen 10:35:42 <TrueBrain> depending on when you resize 10:35:44 <TrueBrain> which is fun :P 10:35:51 <TrueBrain> but .... not worth fixing :) 10:43:55 <TrueBrain> okay, the OpenGL patch became really small for SDL2, which is nice :D 10:44:03 <LordAro> \o/ 10:44:21 <LordAro> are you intending to get this in 1.11 ? 10:44:57 <TrueBrain> personally, I would like that, yes 10:45:12 <TrueBrain> but it is not really my project :) 10:45:29 <TrueBrain> I guess it would be better if we can also add it for OSX 10:46:23 <TrueBrain> hmm, does my Ubuntu VM have OpenGL support, lets find out 10:47:02 <LordAro> might be nice to get it in as a non-default 10:47:25 <TrueBrain> not sure if non-default is needed even .. we might want to do RC1 with it being default 10:47:30 <TrueBrain> and if too many reports come in, make it non-default 10:47:51 <LordAro> maybe 10:48:02 <LordAro> but it's going to have to be done pretty soon if it wants to make RC1 :p 10:48:16 <TrueBrain> SDL and Win32 honestly are really done 10:48:36 <TrueBrain> sure, it needs a review, but I am also pretty sure it will be a review based on coding style 10:48:46 <LordAro> hehe, likely 10:48:49 *** andythenorth has quit IRC 10:48:56 <TrueBrain> I read the Win32 driver a few times now, as I made SDL similar 10:48:57 <TrueBrain> that part looks good 10:49:01 <TrueBrain> the OpenGL backend code itself 10:49:03 <TrueBrain> eeuuuhhhhh 10:49:04 <TrueBrain> "sure" 10:49:44 <TrueBrain> unless we magically find someone with OpenGL knowledge that can talk in a constructive matter, I think we should YOLO that part :) 10:49:45 <LordAro> my brief experiments with OpenGL have taught me that it's all magic and voodoo anyway 10:50:30 <TrueBrain> honestly, it is amasing he got this far with OpenGL 10:50:35 <TrueBrain> of the many attempts we had over a decade 10:50:41 <TrueBrain> this is by far the most mature and functional one 10:50:58 <TrueBrain> I am sure many things can be done better, but .. the increase in performance cannot be ignored here :) 10:58:27 *** arikover has joined #openttd 11:03:25 <TrueBrain> okay, on Linux it is also ~10 times as fast 11:06:33 <TrueBrain> even works on Wayland 11:11:10 <TrueBrain> michi_cc: https://github.com/michicc/OpenTTD/compare/opengl...TrueBrain:opengl-sdl-take-two?expand=1 <- took a bit of time, but here you go, a newly rebased version of OpenGL for SDL :) 11:11:18 <TrueBrain> the first 4 commits are in a PR to master 11:11:30 <TrueBrain> the next 2 you might or might not want to merge with your code; just two more things I found 11:11:34 <LordAro> an order of magnitude is ridiculous 11:11:44 <TrueBrain> LordAro: it really really is 11:11:55 <TrueBrain> just as a reminder, that doesn't make OpenTTD 10 times as fast :P 11:12:46 <TrueBrain> michi_cc: I think I have done everything correct for the SDL port, so I think you can consume it in your branch :) 11:13:11 <TrueBrain> if you can rebase your branch after that, we can build binaries for Windows and Linux, and ask some more stats from people, possibly :) 11:14:07 <TrueBrain> if there is anything else I can help with bringing OpenGL into master, let me know! No clue where you are with the OSX stuff, and if any of these need reviews etc .. just let me know :) 11:15:57 <TrueBrain> https://steamcommunity.com/app/1536610/discussions/0/3113646281426437689/ <- second post about similar topic :) 11:15:59 <TrueBrain> how nice :) 11:18:09 <LordAro> what a curious profile picture 11:18:11 <LordAro> but yes, nice 11:23:15 *** Samu has joined #openttd 11:32:31 <Eddi|zuHause> that username rings a bell 12:02:09 *** HerzogDeXtEr1 has joined #openttd 12:08:10 *** HerzogDeXtEr has quit IRC 12:24:19 <Samu> hi 12:34:46 *** sla_ro|master has quit IRC 13:15:15 *** roadt__ has joined #openttd 13:18:54 *** supermop_Home__ has joined #openttd 13:22:31 *** roadt_ has quit IRC 14:24:11 *** GNU_Pepe has joined #openttd 14:57:16 *** nielsm has joined #openttd 15:11:39 *** Gustavo6046 has joined #openttd 15:28:45 *** roadt__ has quit IRC 15:35:23 *** roadt__ has joined #openttd 15:45:09 *** nielsm has quit IRC 15:45:24 *** nielsm has joined #openttd 15:45:43 *** Flygon has quit IRC 15:53:33 *** arikover has quit IRC 16:25:23 *** Progman has joined #openttd 16:30:33 *** Wormnest has joined #openttd 16:51:01 *** Gustavo6046 has quit IRC 16:59:14 *** Gustavo6046 has joined #openttd 17:00:09 *** glx has joined #openttd 17:00:09 *** ChanServ sets mode: +v glx 17:22:16 *** sla_ro|master has joined #openttd 17:43:45 *** frosch123 has joined #openttd 17:59:15 *** iSoSyS has joined #openttd 18:21:55 *** jottyfan has joined #openttd 18:22:21 *** iSoSyS has quit IRC 18:47:29 *** andythenorth has joined #openttd 18:49:09 <andythenorth> haz? 18:54:25 <supermop_Home__> github? no 19:00:02 <supermop_Home__> I did make some generative whisky bottles in grasshopper to fill out the back bar for a rendering im working on 19:01:18 <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/JtKXQ 19:01:19 <DorpsGek> - Update: Translations from eints (by translators) 19:01:22 <supermop_Home__> although ideally a real back bar would be much more boring and less noisey, as one wouldn't stock a 1/3 full bottle of gin behind a full bottle of scotch 19:03:58 *** jottyfan has quit IRC 19:05:01 *** gelignite has joined #openttd 19:15:30 <michi_cc> TrueBrain: Will look at your SDL stuff for the next round, but I have something else to push first :) 19:15:37 <TrueBrain> pam pam pammmmmm 19:15:43 <TrueBrain> and no rush/hurry what so ever :) 19:16:11 * andythenorth can test mac stuff more at the weekend or next week 19:16:28 <andythenorth> probably other mac users would be more useful though :) 19:16:32 <andythenorth> more systems 19:16:47 <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #7744: Draft Feature: OpenGL video driver https://git.io/JeO8B 19:16:57 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #7744: Draft Feature: OpenGL video driver https://git.io/JtK1N 19:17:17 <michi_cc> andythenorth, orudge: You may test (or incinerate your computer, who knows :P) 19:17:44 <TrueBrain> nice michi_cc :D 19:18:01 * andythenorth is curious about an M1 build 19:18:03 <TrueBrain> well, if you merge my branch in it, we can send it to the farm to produce binaries for all supported OSes :D 19:18:11 <andythenorth> \o/ 19:19:15 <michi_cc> OSX works for me on 10.14 with the Apple software driver. Before handing it out, somebody should at check if it survives contact with a real GPU :) 19:19:38 <TrueBrain> fair point :D 19:21:33 <michi_cc> And at least with that setup, the OpenGL variant is a lot slower than the current (and updated variant from #8652) driver. 19:23:14 <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #8664: Fix potential bug in SDL2 driver introduced in last cleanup, and cleanup some more https://git.io/JtKMm 19:23:57 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #8664: Fix potential bug in SDL2 driver introduced in last cleanup, and cleanup some more https://git.io/JtK3K 19:30:58 <TrueBrain> michi_cc: why all of a sudden call the file cocoa_ogl, and not like the rest cocoa_opengl? :D 19:31:06 <TrueBrain> (this is the quality review you can expect, honestly :P) 19:31:34 <michi_cc> It looks too long :P 19:31:50 <TrueBrain> win32_opengl is identical in length :P 19:31:52 <TrueBrain> you are weird :D 19:33:19 <michi_cc> It needs a cleanup anyway later. Right now there are two alternative methods implemented (with a driver param to switch), because both peg the CPU at 100%, so I can't decide which one is better. The end should absolutely only have one variant. There's a bit more to clean as well. 19:34:08 <TrueBrain> makes sense :) 19:34:39 <TrueBrain> for SDL, performance is both on Windows and Linux a magnitude better for video output time 19:34:41 <TrueBrain> so that is good :) 19:34:46 <michi_cc> But just like with SDL, if you've done all the preparation work beforehand, the actual driver file and commit are deceptively small :) 19:34:58 <TrueBrain> yuppppp 19:35:16 <TrueBrain> which is a good thing, as that means your OpenGL backend is abstracted at just the right level :) 19:36:58 <michi_cc> Hmm, I push OSX support, and the OSX CI runner gets stuck :) 19:37:06 <TrueBrain> oh-oh :P 19:37:19 <michi_cc> Stuck at starting, not at building. 19:37:30 <TrueBrain> it felt what you were doing 19:37:31 <TrueBrain> and said: NO 19:44:48 *** WormnestAndroid has quit IRC 19:45:01 *** WormnestAndroid has joined #openttd 19:53:11 *** WormnestAndroid has quit IRC 19:53:24 *** WormnestAndroid has joined #openttd 19:54:06 <michi_cc> Let's see if we can get it unstuck... 19:54:19 <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #7744: Draft Feature: OpenGL video driver https://git.io/JeO8B 19:54:22 <michi_cc> Now with more SDL 19:54:36 <TrueBrain> \o/ 19:55:17 <TrueBrain> oops, now spot that 1 commit message is wrong .. reads [SDL] , not [SDL2] 19:55:59 <michi_cc> I'm sure there are more bug to be found :) 19:56:34 <TrueBrain> pfft, commit message checker is being evil 19:56:40 <TrueBrain> seems I failed at tabs etc .. sorry :( 19:56:41 <michi_cc> Hmm, "src/video/sdl2_opengl_v.hpp:25: Invalid tab usage:" :P 19:56:56 <TrueBrain> vscode really does not understand our coding style 19:56:59 <TrueBrain> I cannot really blame it :P 19:57:06 <TrueBrain> normally it is either tabs or spaces 19:57:09 <TrueBrain> but we have a mix :) 19:57:23 <michi_cc> You could review and approve #8652 as a penance :P 19:57:40 <TrueBrain> is already reviewed for you 19:57:47 <TrueBrain> you just need to process the results :) 19:58:41 <TrueBrain> someone skipped lunch over that review, I have been told :P 20:03:07 <Wolf01> https://img-9gag-fun.9cache.com/photo/aK63Lo3_460swp.webp 20:03:11 <Wolf01> Lol 20:04:13 <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #7744: Draft Feature: OpenGL video driver https://git.io/JeO8B 20:04:17 <michi_cc> Take that, commit checker! 20:04:24 <TrueBrain> <3 20:05:11 <_dp_> Wolf01, but my new gaming pc compiles openttd 10 times faster! :p 20:05:34 <michi_cc> Well, still "Queued — Waiting to run this check..." 20:06:19 <TrueBrain> guess the runners broke 20:06:21 <TrueBrain> that happens sometimes 20:22:44 <frosch123> Wolf01: which is the original? 9gag or reddit? 20:28:35 <Wolf01> Reddit for sure, 9gag is original only for stuff which talks about 9gag... and I'm not 100% sure about it too 20:40:12 <michi_cc> TrueBrain: You broke Emscripten :) 20:40:45 <TrueBrain> lolz ... every time I was: I should test Emscripten after this .. after "this".. what was it I had to do? *shrug*, continues with the next 20:40:51 <TrueBrain> so sorry .. will check in a bit :) 20:41:23 <michi_cc> I think it's just some missing CMake condition. I tries to link to OpenGL and is of course failing. 20:41:42 <TrueBrain> how did it detect OpenGL ? :P 20:45:16 <michi_cc> I'll take care of the few warnings in the CI log. 20:45:21 <TrueBrain> <3 20:45:31 <TrueBrain> I will make sure to test Emscripten tomorrow 20:45:33 <TrueBrain> ensuring it really works 20:45:50 <TrueBrain> and I believe you can also use an OpenGL backend with WASM .. something to look at :P 20:48:58 <glx> doesn't seem to find opengl (at least cmake log says nothing about opengl for emscripten) 20:49:51 *** Wormnest has quit IRC 20:51:36 <michi_cc> Something's still trying to link to OpenGLBackend. 20:52:45 <glx> haha I like how detailled is macos failure 20:53:17 <michi_cc> Runner broke somewhere. 20:53:32 <michi_cc> L 20:53:35 <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #7744: Draft Feature: OpenGL video driver https://git.io/JeO8B 20:53:39 <michi_cc> et's retrigger :) 20:54:16 *** WormnestAndroid has quit IRC 20:55:26 *** WormnestAndroid has joined #openttd 21:00:26 <michi_cc> TrueBrain: WASM will be OpenGL ES, which is very similar to normal OpenGL, except when it's not :( 21:02:21 <TrueBrain> ah, I see where I went wrong .. I assumed LockVideoBuffer() was a local function 21:02:24 <TrueBrain> I even made a commit for it in Win32 21:02:32 <TrueBrain> but that is wrong .. it is defined already in video_driver.hpp 21:02:43 <TrueBrain> I hate how unclear this is in both Visual Studio Code, and in C++ in general 21:02:56 <TrueBrain> so sorry michi_cc , that just needs a ton of "virtual" and "override" again :P 21:03:33 <michi_cc> Already done 21:03:38 <TrueBrain> I wonder why the other compilers didn't complain 21:03:39 <TrueBrain> silly 21:04:36 <TrueBrain> ah, and indeed, OpenGL is detected on emscripten 21:04:37 <TrueBrain> that makes sense 21:05:33 <TrueBrain> import object field '_ZN13OpenGLBackend7DestroyEv' is not a Function 21:05:35 <TrueBrain> boooeeeeee 21:05:53 <TrueBrain> why is that not a function .. eeeuuuhhhhhh 21:09:49 <TrueBrain> because the files are protected with WITH_OPENGL 21:10:33 <TrueBrain> michi_cc: isn't it enough to CMake condition with OPENGL_FOUND? 21:12:06 *** nielsm has quit IRC 21:12:22 <michi_cc> Probably. I think my opengl repo was created a few months before CMake :) 21:12:28 <TrueBrain> :D 21:12:35 <TrueBrain> error: undefined symbol: glTexImage1D (referenced by top-level compiled C/C++ code) 21:12:45 <michi_cc> It looked very differently back then, but still. 21:14:33 <TrueBrain> let's see if the 1D functions are the only ones that don't work .. 21:15:21 <michi_cc> OpenGL ES has some subtly but annoying differences. 21:16:02 *** jottyfan has joined #openttd 21:16:33 <milek7> extension loading code will be probably all wrong on GLES 21:16:33 <TrueBrain> only the two 1D functions prevent linking 21:16:57 <milek7> shaders will need tweaking 21:17:24 <milek7> and I guess some subtle breakage of doing something that is not allowed in GLES ;p 21:18:09 <TrueBrain> michi_cc: hihi, it doesn't pass the >= 1.3 OpenGL version detection :D 21:18:19 <TrueBrain> [driver] OpenGL driver: Mozilla - Mozilla (OpenGL ES 2.0 (WebGL 1.0)) 21:18:31 <TrueBrain> The error was: OpenGL version >= 1.3 require 21:20:13 *** Wormnest has joined #openttd 21:25:07 <TrueBrain> michi_cc: https://gist.github.com/TrueBrain/41ca7ec0326cd7c68d05ce2b6f1a54cc <- one blob to fix Emscripten, the others because I was hoping it would fix it :P 21:26:21 *** Wuzzy has joined #openttd 21:27:44 <Wuzzy> I request to review <https://github.com/OpenTTD/OpenSFX/pull/14> ← This PR will rid OpenSFX of the non-free CC Sampling Plus license 21:28:19 <orudge> Hmm, trying to play OpenTTD on my iPhone via Steam Remote Link does technically work, but is... tricky 21:28:29 <TrueBrain> orudge: in what sense? 21:29:08 <orudge> TrueBrain: everything is too small :) Even with quad scaling it's fiddly for me at least 21:29:33 <TrueBrain> well, not having a mouse/keyboard is an issue too, I am sure : 21:29:33 <TrueBrain> p 21:29:45 <orudge> Plus lack of mouse, things like scrolling are tricky 21:29:51 <orudge> Quite 21:30:07 <orudge> You can set up mappings for gestures etc in Steam I think 21:30:14 <orudge> but it does work 21:43:52 <LordAro> needs the android ui :p 21:45:18 <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #7744: Draft Feature: OpenGL video driver https://git.io/JeO8B 21:45:19 <michi_cc> TrueBrain: Applied 21:45:55 <TrueBrain> pam pam pammmmm 21:54:13 <TrueBrain> michi_cc: w00p, CI passes on emscripten :P 21:54:19 <TrueBrain> macOS ..... 21:54:23 <TrueBrain> has ..... other issues :P 21:55:20 <michi_cc> But it's almost done... 21:55:23 *** Samu has quit IRC 21:55:38 <michi_cc> Ha: "8 successful checks 21:55:38 <michi_cc> " 21:55:41 <TrueBrain> IT FINISHED! 21:55:41 <TrueBrain> \o/ 21:55:42 <TrueBrain> party 21:55:55 <TrueBrain> YOLO approve now, right? :D 21:56:06 <michi_cc> Merge and release 1.11 :P 21:56:12 <TrueBrain> exactly :D 21:56:23 <TrueBrain> ideally, I would love to see this in 1.11 .. I wonder how Steam reacts if we delay the release :P 21:57:00 <TrueBrain> I also once again realised how backwards our video drivers really are :) 21:57:01 <michi_cc> If we can get people to actually test this, aiming for 1.11 is totally okay. 21:57:15 <TrueBrain> but that is something for 1.12 to address :P 21:57:39 <TrueBrain> michi_cc: yeah, if one or two people tried macOS, we can create binaries with a small guide what and how to test 21:57:43 <TrueBrain> and we can send it around a bit 21:57:52 <TrueBrain> we have Discord :) 21:58:37 <_dp_> there can always be 1.11.1 :p 21:59:08 <TrueBrain> exactly 21:59:11 <TrueBrain> what is the worst that can happen 21:59:16 <TrueBrain> me looks at Steam release 21:59:17 <TrueBrain> NOTHING 21:59:18 <TrueBrain> :D 21:59:25 <TrueBrain> well, off to bed for me, night all 22:00:47 <andythenorth> bye TB 22:12:46 *** Wormnest has quit IRC 22:16:41 <DorpsGek> [OpenTTD/OpenTTD] embeddedt commented on issue #8661: Orders not showing correctly in the UI https://git.io/JtrgT 22:34:38 *** Progman has quit IRC 22:35:35 <supermop_Home__> yay github unflagged me 22:36:31 <michi_cc> You've grown a tail in here instead :D 22:37:23 <supermop_Home__> oh nooo 22:37:35 <andythenorth> \o/ 22:37:51 *** gelignite has quit IRC 22:41:46 *** WormnestAndroid has quit IRC 22:42:10 *** WormnestAndroid has joined #openttd 22:44:10 *** Wormnest has joined #openttd 22:47:54 *** jottyfan has quit IRC 22:50:29 *** frosch123 has quit IRC 22:57:08 *** GNU_Pepe has quit IRC 23:06:15 *** Wolf01 has quit IRC 23:08:11 *** andythenorth has quit IRC 23:09:39 *** HerzogDeXtEr1 has quit IRC 23:12:59 *** sla_ro|master has quit IRC 23:13:46 <Eddi|zuHause> TrueBrain: i thought there should be a way to push "secret" beta binaries to steam, that you hide behind a beta code 23:14:07 <Eddi|zuHause> (not sure that is worth the effort) 23:21:14 <LordAro> supermop_Home__: yay! 23:27:02 *** jottyfan has joined #openttd 23:33:20 *** jottyfan has quit IRC