Times are UTC Toggle Colours
02:31:57 *** glx has quit IRC 02:41:48 *** Wormnest has quit IRC 05:19:14 *** snail_UES_ has quit IRC 05:35:58 *** Flygon has joined #openttd 06:15:01 *** HerzogDeXtEr has joined #openttd 06:30:37 *** sla_ro|master has joined #openttd 07:10:49 *** gelignite has joined #openttd 07:32:09 *** namad7 has quit IRC 07:32:35 *** namad7 has joined #openttd 07:33:18 *** Eddi|zuHause has joined #openttd 07:38:06 *** Eddi|zuHause2 has quit IRC 08:09:07 *** Progman has joined #openttd 08:21:35 *** Beer has joined #openttd 08:24:29 *** sla_ro|master has quit IRC 08:44:03 *** andythenorth has joined #openttd 08:58:31 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #9330: Fix #9329: [CMake] FindVersion.cmake relied on internal cmake variable https://git.io/JGrnN 09:14:50 *** WormnestAndroid has quit IRC 09:15:03 *** WormnestAndroid has joined #openttd 09:28:20 *** Smedles_ has quit IRC 09:30:56 *** Smedles has joined #openttd 09:48:02 *** Samu has joined #openttd 09:57:00 *** tneo has quit IRC 09:57:31 *** tneo has joined #openttd 09:58:15 *** ericnoan has quit IRC 09:59:48 *** ericnoan has joined #openttd 10:12:06 *** frosch123 has joined #openttd 10:16:32 *** Xaroth2 has joined #openttd 10:21:42 *** Xaroth has quit IRC 11:03:55 <DorpsGek> [OpenTTD/OpenTTD] extrazi commented on discussion #9250: [Suggestion] Make console commands and outputs translatable strings https://git.io/JsUuI 11:04:40 *** iSoSyS has joined #openttd 11:15:30 *** WormnestAndroid has quit IRC 11:15:36 *** snail_UES_ has joined #openttd 11:18:38 *** WormnestAndroid has joined #openttd 11:18:49 *** iSoSyS has quit IRC 11:19:49 *** andythenorth_ has joined #openttd 11:26:16 *** andythenorth has quit IRC 11:26:31 *** Xaroth2 is now known as Xaroth 11:53:04 *** WormnestAndroid has quit IRC 11:53:18 *** WormnestAndroid has joined #openttd 12:11:44 *** k32n13 has joined #openttd 12:13:12 *** k32n13 has left #openttd 12:24:40 *** geli has joined #openttd 12:24:40 *** gelignite has quit IRC 12:25:20 <TrueBrain> so the delete savegame button doesn't ask for: are you sure? 12:25:20 <TrueBrain> nice 12:28:19 *** jellyknight has joined #openttd 12:34:41 *** geli has quit IRC 12:38:13 <peter1138> Yeah 12:38:39 *** jellyknight has quit IRC 12:39:56 <andythenorth_> 'type the name of this savegame to confirum' 12:40:01 <andythenorth_> or confirm 12:40:07 <TrueBrain> at least something would help 12:40:13 <TrueBrain> Save and Delete buttons are next to each other 12:41:56 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9322: Add: store settings as key->value pair https://git.io/JGlmd 12:42:02 <TrueBrain> okay, finally found a clean way to add headers to other chunks too 12:42:22 <TrueBrain> haven't done them all, as we have 79 things to convert, and they are a lot of manual work each :P 12:42:40 <TrueBrain> guess I could make it into another PR, but what-ever 12:49:03 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGrpy 12:49:05 <TrueBrain> ping frosch123 ^^ :) 12:51:13 *** gelignite has joined #openttd 13:03:29 *** andythenorth_ has quit IRC 13:11:48 <frosch123> separate chunk types is a good idea. that way external tools can detect whether there is a schema 13:13:59 <TrueBrain> Wait, why are you already here? :p 13:14:05 <TrueBrain> Unexpected :D 13:14:43 <frosch123> another lazy-cathlic-day 13:14:57 <TrueBrain> Nice :D 13:15:20 <TrueBrain> But yeah, my biggest worry is those chunks that are really not a table 13:15:34 <TrueBrain> Bit tempted to make those into a RIFF instead 13:15:35 <frosch123> also, both savegame parsers that i wrote over the years, kind of survive the new chunk types 13:15:56 <frosch123> (bananas_api scenario parser, and some desync decoder) 13:16:53 *** sla_ro|master has joined #openttd 13:18:31 <frosch123> meh, i still don't like that the variable names are used as keys in the savegame 13:18:53 <frosch123> "_game_saveload_name" should really just be "name" in the savegame 13:18:58 <frosch123> the rest is a weird implementation detail 13:20:08 <TrueBrain> Yeah, that is easily fixed my changing that code 13:20:18 <TrueBrain> It is very weird saveload code 13:20:36 <TrueBrain> So that is mostly the exception .. a few more spots this happens in 13:21:25 *** Progman has quit IRC 13:21:53 <TrueBrain> But otherwise we have to duplicate 90% of the keys for the 10% .. doesn't sound like a good idea either .. not sure if there is anything in between :) 13:24:03 <TrueBrain> Why do we store translations of the GS in the save game btw? 13:24:22 <frosch123> so that the clients get them 13:24:30 <frosch123> clients do not have the gs 13:24:35 <frosch123> but they need to show the strings 13:25:00 <frosch123> i think only multiplayer store them 13:25:10 <frosch123> isn't it skipped in singleplayer? 13:25:34 <TrueBrain> Haven't seen code for it but also haven't been looking for it 13:25:38 <TrueBrain> And that makes sense 13:25:59 <TrueBrain> I will see if I cant rework that chunk 13:26:08 <TrueBrain> So it is a proper table 13:27:01 <TrueBrain> Owh, and I have an idea how to solve the global name issue 13:28:05 *** Progman has joined #openttd 13:38:15 <frosch123> oh, this also bakes the historic settings structures into the savegame :p lol, didn't notice this before 13:38:31 <TrueBrain> what do you mean, sorry? 13:39:05 <frosch123> "difficulty.terrain_type" that was a difficulty setting in ttd. but has been a mapgen setting in ottd for years 13:39:34 <frosch123> also, various things moved between client settings, game settings and company settings over the years, it's just a mess :p 13:39:41 <TrueBrain> yup 13:39:47 <TrueBrain> and hopefully with this, we can clean that up a bit :) 13:41:24 <frosch123> also, wtf is with "gui.autosave"? "from = SLV_23" and "flags = SLF_NOT_IN_SAVE | SLF_NO_NETWORK_SYNC" 13:41:29 <frosch123> is it in the savegame, or is it not? 13:42:19 <TrueBrain> those 2 flags mostly come hand in hand 13:42:48 <TrueBrain> read: all SLF_NOT_IN_SAVE also have SLF_NO_NETWORK_SYNC :) 13:43:00 <TrueBrain> "SLF_NOT_IN_SAVE | SLF_NOT_IN_CONFIG | SLF_NO_NETWORK_SYNC" <- we have that too 13:43:03 <frosch123> i mean the "it's in the savegame starting with savegame version 23" and "it's not in the savegame" 13:43:14 <TrueBrain> ah, like that, yes 13:43:16 <TrueBrain> many odd things :) 13:43:19 <frosch123> also, why would the autosave interval be in the savegame? 13:43:31 <TrueBrain> because people wanted it to be stored per game 13:43:39 <TrueBrain> in the old days, we made some weird choices 13:51:18 <TrueBrain> (and with "we" in this case I guess CS or ludde :P) 13:52:21 <TrueBrain> so tempted to remove the macros for saveload stuff 13:52:25 <TrueBrain> it makes things more complex than needed 13:56:34 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9322: Add: store settings as key->value pair https://git.io/JGlmd 13:56:41 <TrueBrain> frosch123: how about that? :) 13:57:26 <TrueBrain> basically, I forced global variables to name the field :P 13:58:05 <frosch123> off, does this now invalidate all my comments :p 13:58:25 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGomk 13:58:29 <TrueBrain> only if they were all about the name :P 13:58:39 <frosch123> let's see what survived 13:59:40 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGoml 13:59:52 <frosch123> i am mostly confused about whether the schema contains SLF_NOT_IN_SAVE things, and wtf that autosave setting is doing 14:00:00 <TrueBrain> euh, no, my comment is wrong .. 14:00:46 <TrueBrain> I need to investigate autosave .. I think it doesn't do what it appears to do :P 14:00:55 <frosch123> exactly my problem :p 14:01:31 <peter1138> Bootstrap is like "Hey you know the semantic part of HTML, and the cascasing part of CSS? LOL!" 14:02:18 <frosch123> TrueBrain: btw. i love the first commit. it makes the code actually easier 14:02:34 <TrueBrain> yeah ... took me a long time to figure out what it was doing ... 14:03:15 <peter1138> mpdrandom decided to play the album "Unknown" 14:03:30 <peter1138> I have 76 random tracks with "Unknown" as the album :/ 14:03:53 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGoYI 14:04:15 <TrueBrain> wait, [[maybe_unused]] exists? Lol .. well, I guess I can fix some other places in that case too :D 14:04:28 <frosch123> https://en.cppreference.com/w/cpp/language/attributes/maybe_unused 14:04:37 <frosch123> i checked first, whether it's also c++20 :p 14:04:42 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGoYZ 14:06:01 <peter1138> Time to redesign the page :/ 14:07:57 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGoYN 14:08:09 <TrueBrain> storing the type first is a good idea frosch123 14:08:12 <TrueBrain> makes a lot more sense 14:08:39 *** nielsm has joined #openttd 14:10:52 <TrueBrain> okay, the autosave indeed can be removed safely 14:10:59 <TrueBrain> the field before that does 0 .. 22 14:12:18 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9322: Add: store settings as key->value pair https://git.io/JGlmd 14:12:33 <TrueBrain> anyway, you think it is good to finish this PR this way frosch123 ? I wouldn't be able to do all chunks, but .. at least a good portion 14:14:06 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9180: Codechange: Remove FOR_ALL_CHUNK_HANDLERS https://git.io/JGoOA 14:14:31 <TrueBrain> it will just take me a few .. days to finish it :P 14:15:41 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGo3O 14:16:48 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGo30 14:18:00 <TrueBrain> okay, so we have NDEBUG, WITH_ASSERT and OTTD_ASSERT 14:18:02 <TrueBrain> and we use them all! 14:18:41 <TrueBrain> am I really surprised? Guess not 14:18:46 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGosv 14:24:04 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGosx 14:25:42 <TrueBrain> good question; possibly the header is waaayyyy too long 14:25:50 <TrueBrain> will work itself out while loading just fine, so you won't notice that 14:26:00 <TrueBrain> clearly, I need to write some Python to look into savegames with this new header 14:26:09 <TrueBrain> so we can validate it is doing what we expect :D 14:26:17 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #9322: Add: store settings as key->value pair https://git.io/JGoGG 14:27:21 <TrueBrain> I love how you complained like 5 times about that newline :P 14:27:28 <TrueBrain> your OCD is consistent :D 14:27:29 <TrueBrain> so is mine :P 14:28:27 <frosch123> in chat? or did github duplicate my comment? 14:28:32 <TrueBrain> frosch123: can I assume that with [[maybe_unused]], the compiler will optimize out the variable completely? So also if it is assigned something (not a function etc) 14:28:35 <TrueBrain> frosch123: in chat :) 14:28:42 <TrueBrain> you mentioned it a few times earlier when looking at it :P 14:29:52 <TrueBrain> I could also just godbolt it, instead of asking you .. 14:29:58 <TrueBrain> even functions are optimized out if possible 14:29:59 <TrueBrain> nice 14:30:04 <frosch123> do you want to short or the long answer? :p 14:30:22 <TrueBrain> in general, I care about how it works, not if :P 14:30:36 <frosch123> the optimiser removes unused storage and conditions (sometimes security relevant conditions) 14:30:44 <frosch123> but in this case the storage is in the stackframe anyway 14:30:56 <frosch123> or in a register 14:31:09 <frosch123> bool result is in rax 14:31:10 <TrueBrain> there are many more places :P 14:32:01 <frosch123> so well, if the compiler inlines the function, it will remove the storage. if it calls the function, the function will store the result anywhere 14:32:02 <TrueBrain> for ([[maybe_unused]] const Industry *i : Industry::Iterate()) assert(i->town != this); 14:32:07 <TrueBrain> is that going to work as I expect, I wonder .. 14:32:31 <frosch123> that looks dangerous in other ways... 14:32:38 <TrueBrain> do tell? 14:32:47 <frosch123> sometimes "assert" is a macro, so would it apply the for to the next insutrction? 14:32:54 <frosch123> i would add { } to be safe :p 14:32:55 <TrueBrain> we use cassert :) 14:33:11 <TrueBrain> and it an existing line of code ;) 14:33:25 <TrueBrain> but sure, I will add {} :) 14:33:35 <TrueBrain> fun fact: some asserts() didn't work on RC-builds 14:33:45 <TrueBrain> and some ONLY worked on RC-builds :P 14:34:26 <frosch123> TrueBrain: if you want to do it the c89 way, you can use the variable and cast it to void :p "(void)i;" will also remove the "unused" warning, without adding real code 14:34:38 <TrueBrain> that is what other places do, yes 14:35:55 <frosch123> so, anyway, i like this PR. but all the historic settings names are annoying 14:36:06 <TrueBrain> yeah .. I have some more plans to clean up that stuff 14:36:06 <frosch123> it's the same mess as in openttd.cfg :) 14:36:09 <TrueBrain> mostly: splitting up 14:36:19 <TrueBrain> and for that I need a way to rename settings anyway 14:36:21 <TrueBrain> so .. yeah .. 14:36:24 <TrueBrain> lets fix this mess :D 14:36:37 <V453000> HellO! I've been told air_drag_coefficient should be set to 1 if I want it to have no effect. NUTS has always had 0 though, that's correct, isn't it? I think it doesn't have any effect with 0 14:39:28 <frosch123> zero is a special value 14:39:42 <V453000> what does it mean? 14:39:54 <frosch123> all the default vehicles have air_drag zero, and it sets a max-speed dependent air-drag value 14:40:24 <frosch123> https://github.com/OpenTTD/OpenTTD/blob/master/src/ground_vehicle.cpp#L47 <- see there 14:41:11 <frosch123> oh, and if you look 7 lines downwards, also "1" is a special value for "no airdrag" :p 14:41:45 <TrueBrain> so 0 and 1 are special, and anything else isn't? 14:41:47 <frosch123> typical ttdpatch assembler stuff :) 14:41:55 <TrueBrain> "nobody wants an airdrag of 1, don't be silly" 14:42:44 <V453000> interesting, I had a logic engine built with max speed 40 000, and with 1 it looks like it goes about 1900kmh at most, with 0 it seems to go 16 000 ... though when I added more engines it was getting faster with 0. Didn't try with 1 14:44:22 <V453000> So what exactly is the air drag? It just means that if trains don't have enough power, they won't be able to go above some speed? is it the thing that also makes them slow down in tunnel entrances? 14:45:42 <frosch123> V453000: see line 144 in that file 14:46:47 <V453000> so fast trains with low power have a harder time reaching top speed? 14:46:56 <frosch123> "area" is different in tunnels and outside 14:47:44 <frosch123> but only for trains, not for rv 14:47:59 <V453000> with 1 trains do seem to slow down in tunnels 14:48:23 <frosch123> they shouldn't 14:48:35 <frosch123> "1" would result in "tunnel_effect * 0" 14:48:57 <frosch123> so, anyway, drag is a speed-dependant uphill-slope. it's doubled in tunnels 14:49:53 <TrueBrain> maglev seriously have no friction? Haha, didn't expect things to go in that much detail :D 14:50:26 <frosch123> hmm, the slope comparision is meh, ignore that :) 14:51:09 <TrueBrain> damn, the game plays so much faster on release build 14:51:10 <TrueBrain> lol 14:51:11 <frosch123> but yes, it reduces power at higher speeds 14:51:26 <frosch123> TrueBrain: newgrf scan is so much faster on release build 14:51:45 <TrueBrain> mapgen too 14:52:06 <TrueBrain> after weeks of testing newgame, that is noticeable :P 14:58:20 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #9331: Codechange: use "[[maybe_unused]]" instead of a wide variety of other ways we had https://git.io/JGo8f 14:58:36 <TrueBrain> enjoy the variety of different ways developer can fix the same problem :D 14:58:48 <frosch123> TrueBrain: https://dpaste.org/qVaD <- i was pondering about a syntax to define string-values for enum settings in the .ini files 14:59:04 <frosch123> allowing to set multiple aliases for old configs and savegames 14:59:43 <TrueBrain> sorry, I do not follow that paste at all :P 14:59:48 *** Wormnest has joined #openttd 15:00:34 <frosch123> terrain_type is currently stored as integer 0..3 in savegames, in openttd.cfg and in console's get/set setting 15:00:46 <frosch123> i would like to use "temperate", "arctic", ... instead 15:01:22 <TrueBrain> and you don't like the current solution for that? :D 15:01:26 <frosch123> but i also want to support renaming those values in the future, so for each enum value there is a "primary string" that is used when saving, and multiple aliases which map the same when loading 15:01:43 <frosch123> TrueBrain: no, the current solution defines the stuff in a different place 15:01:57 <frosch123> and it does not support aliases 15:02:02 <TrueBrain> it is funny how bad the current form is 15:02:08 <TrueBrain> made sense when it was only used for gameopts 15:02:12 <TrueBrain> but it got a bit out of hand :P 15:02:27 <TrueBrain> "The rest is here for consistency." part made me giggle 15:02:30 <TrueBrain> (comment in gameopts.ini) 15:02:36 <frosch123> TrueBrain: btw. i do not regret telling you about maybe_unused :) 15:02:41 <TrueBrain> :P 15:02:59 <TrueBrain> frosch123: I can understand if we would do full.0 = .. 15:03:00 <TrueBrain> full.1 = .. 15:03:12 <TrueBrain> but with an enum there .. not sure how we would implement that 15:03:35 <frosch123> i intended the stuff after the "." to be copied into the generated code by settingsgen 15:03:39 <TrueBrain> and for example you now don't define all values .. how to deal with that? 15:04:14 <TrueBrain> frosch123: settingsgen is really primitive .. so it doesn't know the value of those things .. it does need to generate a "std::string []" list from it 15:05:00 <TrueBrain> well, std::map in your case, as aliases :P 15:05:19 <TrueBrain> I just don't see how we could do that efficient 15:05:25 <TrueBrain> but that is an implementation problem :) 15:05:26 <frosch123> it does not have to. it would generate std::map<int, std::vector<std::string>> = {LT_TEMPERATE, {"temperate", "0"}} or so 15:05:41 <frosch123> the compiler has to understand LT_TEMPERATE, settingsgen just copies it 15:06:04 <TrueBrain> but that the min=0, max=5, and you define 4 values, does worry me .. as I wonder what other 2 terrain types we have :D 15:06:14 <frosch123> maybe with some special magic for converting old integer values, like the "0" here 15:06:35 <TrueBrain> I have been wondering several times now if we shouldn't switch to YAML for settings.ini 15:06:44 <TrueBrain> as that allows easier syntax for many of these things 15:06:53 <frosch123> oh lol... i copied the wrong setting 15:06:55 <TrueBrain> (having dict and list support is kinda useful :P) 15:07:14 <frosch123> i started with "terrain_type" and then added the strings for "landscape" 15:07:17 <TrueBrain> owh, this is flat, very flat, etc 15:07:22 <TrueBrain> gotcha 15:07:25 <TrueBrain> that makes more sense :) 15:07:36 <TrueBrain> anyway, we should at least validate that all full. entries are defined too 15:07:46 <TrueBrain> but, to put it in Dutch, "ik zie beren op de weg", which is not what your snippet is about 15:07:52 <TrueBrain> so yeah, I think that is good 15:08:02 <TrueBrain> also means we can do stuff for zoom like "auto, 1x, 2x, 4x" 15:08:05 <TrueBrain> instead of the current 0, 1, 2, 3 15:08:08 <TrueBrain> which .. yeah, no :P 15:10:16 <LordAro> "an internal compiler error has occurred" 15:10:19 <LordAro> well done TrueBrain :) 15:10:32 <TrueBrain> sweet! 15:11:45 <TrueBrain> https://gist.github.com/TrueBrain/294690fa8c08f105bff6f74a318dbd2c <- just imagine 15:12:35 <frosch123> isn't NDEBUG some msvc magic? 15:13:48 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9331: Codechange: use "[[maybe_unused]]" instead of a wide variety of other ways we had https://git.io/JGo8f 15:14:03 <TrueBrain> NDEBUG is set by CMake 15:14:09 <TrueBrain> and cassert is the one doing something with it 15:14:17 <TrueBrain> but I think this problem is with the weird line I pasted earlier 15:14:34 <TrueBrain> MSVC2016 has a lexer error :D 15:20:55 <frosch123> i can't trigger it on godbolt with easier code 15:20:59 <TrueBrain> see, now it is happy :) 15:25:59 <frosch123> hmm, WITH_ASSERT is probably better there. not sure whether it would figure out it can skip the Iterate() :) 15:26:34 <V453000> somehow 15:26:44 <V453000> 0.004 is the value with which it doesn't slow down in tunnels 15:26:51 <V453000> it looks like it does with both 0 and 1 15:27:01 <TrueBrain> frosch123: yeah, I wasn't either .. so yeah 15:27:47 <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #9331: Codechange: use "[[maybe_unused]]" instead of a wide variety of other ways we had https://git.io/JGoue 15:28:37 <frosch123> V453000: ah, sorry, yes, nml does unit coversion, so 1 is not 1 :) 15:28:54 <V453000> XD 15:29:04 <V453000> alright, so I'll just keep 0.004 15:29:12 <V453000> the interesting part is the NUTS 0.8.4 was compiled with 0 and worked fine 15:29:15 <frosch123> there probably should be NO_DRAG and DEFAULT_DRAG constants 15:29:30 <V453000> would make sense 15:29:40 <V453000> I guess updated NML converted the units? 15:29:54 <frosch123> nope, no changes there 15:30:04 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #9331: Codechange: use "[[maybe_unused]]" instead of a wide variety of other ways we had https://git.io/JGo8f 15:30:28 <TrueBrain> can I make OpenTTD CMake depend on Python? :P 15:30:36 <TrueBrain> (I AM KIDDING) 15:30:49 <TrueBrain> right, lets get out of this rabbit hole .. frosch123 : yes, I think your idea is a nice idea, now go make it :D 15:32:36 *** glx has joined #openttd 15:32:36 *** ChanServ sets mode: +v glx 15:32:40 <DorpsGek> [OpenTTD/nml] frosch123 opened issue #219: Add DEFAULT_DRAG and NO_DRAG constants https://git.io/JGozA 15:33:21 <frosch123> TrueBrain: i won't do yaml :) 15:33:49 <TrueBrain> that's fine 15:33:56 <TrueBrain> we can do that after :P 15:34:16 <TrueBrain> personally, I would like if we don't have to do min/max if we have an enum, as that feels really useless 15:34:24 <TrueBrain> (that is mainly what I removed in my YAML snippet :P) 15:34:27 *** tokai|noir has joined #openttd 15:34:27 *** ChanServ sets mode: +v tokai|noir 15:34:58 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #9330: Fix #9329: [CMake] FindVersion.cmake relied on internal cmake variable https://git.io/JGog2 15:35:02 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9322: Add: store settings as key->value pair https://git.io/JGlmd 15:35:10 <frosch123> hmm, there are some settings where only "0" has a string 15:35:14 <frosch123> at least in the gui 15:35:30 <TrueBrain> the 0ISDISABLED (but not really disabled) 15:35:32 <TrueBrain> right? :P 15:35:54 <frosch123> yep :) 15:36:06 <TrueBrain> many of the flags should be renamed 15:36:15 <glx> 0ISSTRING 15:36:32 <TrueBrain> but in general, why do I need to tell that 0 is special, if I have to define the string to start with? 15:36:38 <TrueBrain> why can't it add the flag for me if I define one of those "str" 15:36:42 <TrueBrain> lets call it str_if_zero: 15:36:44 <TrueBrain> and .. magic! 15:36:59 <frosch123> for newgrf setting we did: min/max defines the allowed integers. strings for specific values are added on top 15:37:10 <TrueBrain> (now it does that sneaky thing of doing strval + 1 to find it) 15:37:16 <frosch123> so you can have min=3, max=5, and still 0="magic" 15:37:42 <TrueBrain> well, in your idea, "full." indicates sufficiently what the valid values are 15:37:45 <TrueBrain> so min/max have no meaning 15:37:49 <frosch123> to get "magic", 3, 4, 5 as options 15:37:55 <TrueBrain> same as "interval=1" EVERYWHERE .. like .. wuth? 15:38:32 <frosch123> "interval = 0" <- in [defaults] :p 15:38:35 <TrueBrain> but from my understanding of settingsgen, it is really "dumb" 15:38:42 <TrueBrain> it just combines information, and doesn't reason over it 15:38:42 <frosch123> probably some magic meaning as well :) 15:38:58 <TrueBrain> which I fully understand btw 15:39:04 <TrueBrain> but .. it makes us do so much more work 15:39:21 <glx> was worse before it IIRC 15:39:27 <TrueBrain> sure 15:39:32 <TrueBrain> but this isn't "nice" either :) 15:40:01 <glx> yeah it's the same, but in a centralised location :) 15:40:53 <TrueBrain> but yeah .. on my agenda, after this saveload stuff, is to split up settings.ini over multiple files 15:41:07 <TrueBrain> as that is driving me nuts 15:41:21 *** tokai has quit IRC 15:41:22 <TrueBrain> and after that, store it in more than one openttd.cfg, namely: "secrets.cfg" and "private.cfg" 15:41:23 <TrueBrain> that is my goal :D 15:41:46 <DorpsGek> [OpenTTD/nml] FLHerne commented on issue #219: Add DEFAULT_DRAG and NO_DRAG constants https://git.io/JGozA 15:45:32 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #9180: Codechange: Remove FOR_ALL_CHUNK_HANDLERS https://git.io/JGoa2 15:55:11 <V453000> BTW how could I change the railtype "icons" ? 15:55:18 <V453000> are they just the 2nd piece of the gui? 15:55:25 <V453000> (the icons in the dropdown when choosing which railtype to build) 16:05:55 <peter1138> Probably yes. 16:08:19 <V453000> can I somehow set the default monorail and maglev GUIs? 16:08:32 <V453000> ideally I should just create new ones but ugh 16:09:51 <frosch123> yes, you can set the gui icons only 16:10:49 <frosch123> though no idea why you would want to make the rails look different in the gui than on the map 16:13:06 <V453000> but I can't just access default monorail icons, right? 16:13:13 <V453000> like with stations for example 16:13:19 <V453000> a railtype can have monorail stations/depots 16:13:26 <V453000> can a railtype have monorail gui? 16:14:00 <peter1138> There's one set that includes the menu background colour in the icons. Except it's not exactly the right shade. 16:15:02 <V453000> but that probably just copy pastes the images to define new gui sprites, right? 16:15:15 <V453000> I'm just asking if there's a way to do it just via properties or flags 16:15:32 <V453000> so in the code i could just set "this gui looks like base set monorail" 16:17:06 <frosch123> no, you cannot access baseset monorail sprites 16:17:27 <frosch123> it will fall-back to default normalrail sprites, if you set no gui sprites, but you cannot pick other baseset sprites 16:17:55 <V453000> alright, that's what I needed, thank you :) yeah, it's been using rail for years 16:19:36 <V453000> hm, I've got a parameter which has a value of 65535, I put it into logic engine's max speed, and the engine in game has 38170 max. speed 16:19:39 <V453000> what did I fuck up? 16:19:41 <V453000> units? 16:19:48 <V453000> speed: param_logic_maglev_speed; 16:19:53 <V453000> in properties, not callback 16:24:36 <V453000> oh super wtf, with value 2222 in parameter, it goes 7999km/h 16:24:38 <V453000> :d 16:24:57 <V453000> ah 16:25:02 <V453000> meters/second 16:28:04 <V453000> this feels incredibly filthy to write speed: param_logic_maglev_speed km/h; 16:28:27 <peter1138> Already custom CSS-grid instead of bootstrap bullshit. Much nicer. 16:30:06 *** nielsm has quit IRC 16:51:25 *** k32n13 has joined #openttd 16:57:41 *** k32n13 has quit IRC 16:58:55 *** k3 has joined #openttd 16:59:20 *** k3 has left #openttd 17:21:04 *** Flygon has quit IRC 17:21:49 <TrueBrain> frosch123: I think SLF_NOT_IN_SAVE is weird, now I take a second look at it .. it should be a settings flag, not a saveload flag :P 17:22:28 <TrueBrain> same as SLF_NOT_IN_CONFIG 17:25:00 <frosch123> nice, SLF_HEX appears to be unused :p 17:26:18 <frosch123> what? that thing is from february 2020 17:26:23 <frosch123> some eddi PR 17:26:23 <TrueBrain> lol 17:26:32 <TrueBrain> okay, that is it, I am going to do a mess rename of SLF_ flags 17:26:36 <TrueBrain> SGF_ 17:26:38 <TrueBrain> sorry 17:26:40 <TrueBrain> done with them .. 17:27:36 <frosch123> https://github.com/OpenTTD/OpenTTD/pull/7396 <- i suggest to just trash it 17:28:00 <LordAro> it was supposed to be used... 17:28:51 <TrueBrain> the typical: I add a PR and I will use it later? 17:31:09 <frosch123> so yeah, i was wondering whether SLF_HEX would be a setting or a saveload flag, in case we wanted to store vehiclesflags in hex in out new json save format. but well, if it is unused anyway :p 17:34:59 <TrueBrain> burn it with fire! 17:43:32 *** tokai has joined #openttd 17:43:32 *** ChanServ sets mode: +v tokai 17:44:33 <TrueBrain> https://www.youtube.com/watch?v=5lXmQE4xUjU <- #100th episode ..he has been busy :) 17:49:57 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGoA9 17:50:02 <TrueBrain> I like to dedicated this PR to Rubidium :) 17:50:13 *** andythenorth has joined #openttd 17:50:20 *** tokai|noir has quit IRC 17:50:25 <TrueBrain> mostly seds, no worries :) 17:56:14 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGopm 17:56:15 <peter1138> When one of your routers doesn't have enough flash to store the latest firmware image... :/ 17:57:00 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGopl 17:57:54 <TrueBrain> should I add an extra space for every row in #9332? 17:58:33 <LordAro> it is a bit awkward :p 17:58:51 <LordAro> just call it savflags 17:59:27 <TrueBrain> I rather add the spaces :) 17:59:44 <TrueBrain> any patch fails to apply anyway already 18:05:29 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGoA9 18:05:31 <TrueBrain> let me know if you disagree on the last commit :) 18:10:47 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGKeC 18:12:06 <Rubidium> is it me, or is a period after a question mark weird? 18:12:42 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #9333: Codechange: move SLF_NOT_IN_SAVE and SLF_NOT_IN_CONFIG to SettingFlag https://git.io/JGKeH 18:12:46 <TrueBrain> Rubidium: that is not you 18:13:18 <andythenorth> yo 18:13:20 <TrueBrain> the question only is: where and what line? :D 18:13:52 <TrueBrain> okay, I screwed myself over big-time with 9332 .. making changes to that is a pita :P Lol 18:13:56 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGKvf 18:14:08 <Rubidium> 75 of settings_internal.h 18:14:31 <TrueBrain> frosch123: very solid point there, so indeed, we shouldn't .. but what do you mean with "sf"? 18:15:10 <frosch123> the "settingsflags" enum uses "sf_" prefix, so the ini should also use "settingsflags" or "sf" 18:15:20 <frosch123> name the ini key the same as the enum or the enum items :) 18:15:27 <frosch123> possibly the same for the saveflags 18:15:30 <TrueBrain> saveload is called slf 18:15:38 <TrueBrain> so that would make "slf=" and "sf=" 18:15:48 <frosch123> yeah, no, meh :p 18:15:56 <TrueBrain> my issue exactly :) 18:15:59 <frosch123> is "saveload" and "settings" available? 18:15:59 <TrueBrain> I was thinking not calling it SF_ 18:16:02 <TrueBrain> but ran out of ideas :P 18:16:17 <TrueBrain> both words are not used, if that is what you are asking 18:16:44 <TrueBrain> noting that it is a flag is pretty nice honestly 18:16:47 <Rubidium> maybe guiflags -> setflags? 18:16:56 <TrueBrain> setflags and savflags? :D 18:17:22 <frosch123> taking more letters for "flags" than for "set" and "sav" :p 18:17:33 <TrueBrain> this happens when you do aligning 18:17:35 <TrueBrain> it sucks balls 18:17:49 <TrueBrain> flags:\n settings: ..\n saveload: .. :) 18:17:59 <frosch123> haha :p 18:18:37 <frosch123> i vote for "saveload" and "setting" 18:18:44 <TrueBrain> after my other patch, the only "saveload" is SLF_NO_NETWORK_SYNC 18:18:54 <TrueBrain> what if we make that ALSO a settingflag 18:19:01 <TrueBrain> and just remove the saveloadflag 18:19:33 <TrueBrain> makes the world simpler, I guess 18:19:50 <frosch123> ah, just one flags, yeah, that's good :) 18:19:54 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGKfu 18:20:16 <TrueBrain> Rubidium: check the other PR! I happened to have fixed it there :D 18:21:08 *** Wormnest has quit IRC 18:21:46 *** OsteHovel_ has joined #openttd 18:22:38 *** WormnestAndroid has quit IRC 18:22:57 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGKJm 18:24:09 <TrueBrain> okay, lets not do everything at once in 1 PR .. lets first rename the settings only :D 18:24:56 *** WormnestAndroid has joined #openttd 18:26:10 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #9333: Codechange: move SLF_NOT_IN_SAVE and SLF_NOT_IN_CONFIG to SettingFlag https://git.io/JGKJh 18:27:30 <frosch123> https://www.ruxan-muenchen-onlineshop.de/images/product_images/original_images/postkarte_0011_436x640.jpg <- our new PR template 18:28:08 <TrueBrain> :D 18:28:31 *** OsteHovel has quit IRC 18:30:44 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGoA9 18:36:06 <frosch123> good thing you want to merge the flags :) just noticed "SF_PER_COMPANY" is rather a saveload flag :p 18:36:56 <TrueBrain> atm, it is fully a settings-only flag 18:37:22 <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGKI0 18:37:39 <TrueBrain> decides in what thing to store the settings .. _settings_company or _settings_client/_settings_game 18:41:24 *** nielsm has joined #openttd 18:45:17 <TrueBrain> guiflags = SLF_NOT_IN_SAVE | SLF_NOT_IN_CONFIG | SLF_NO_NETWORK_SYNC | SF_NETWORK_ONLY 18:45:18 <TrueBrain> ll 18:45:25 <TrueBrain> lol even 18:45:36 <TrueBrain> when is this used?! :P 18:48:03 <TrueBrain> (hint: it is server-only :P) 18:50:23 <TrueBrain> that moment you start the game and it is a blue ocean 18:50:26 <TrueBrain> I broke something :D 18:53:28 <frosch123> funny that those settings are NOT_IN_SAVE :) just to avoid that people mess with them 18:57:51 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGKI0 18:57:54 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGoA9 18:58:03 <TrueBrain> I made a change, I stashed it, pushed the branch 18:58:07 <TrueBrain> something went wrong there :D 18:58:36 *** Wormnest has joined #openttd 19:02:57 *** Gustavo6046 has joined #openttd 19:06:18 <TrueBrain> btw, I love that SLF_HEX was sold as a feature :) 19:07:03 *** WormnestAndroid has quit IRC 19:07:56 *** WormnestAndroid has joined #openttd 19:08:59 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9333: Codechange: merge guiflags and flags for settings https://git.io/JGKeH 19:10:33 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9333: Codechange: merge guiflags and flags for settings https://git.io/JGKeH 19:10:47 <TrueBrain> right ... that is a lot cleaner now :) 19:11:32 <frosch123> i assume nothing breaks when LoadSettings validates ranges of all int settings, also those which were not loaded :p 19:12:06 <TrueBrain> honestly, I do not know 19:12:11 <TrueBrain> I limited it to the ones in the savegame now 19:12:21 <TrueBrain> but I am a bit annoyed version-check is not done 19:12:23 <TrueBrain> might as well add that 19:13:00 <TrueBrain> owh, yes, it used to do that 19:13:03 <TrueBrain> so that is a bug in my PR :D 19:14:01 <TrueBrain> hmm .. that is unexpected more difficult :D 19:14:53 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #9333: Codechange: merge guiflags and flags for settings https://git.io/JGKOU 19:15:13 <TrueBrain> owh, SLF_NO_NETWORK_SYNC is also only used for settings 19:15:33 <TrueBrain> I expected others parts to also use it 19:15:43 <TrueBrain> frosch123: regarding your comment, yes, yes there are. One proxies it into the other 19:16:09 <TrueBrain> but I assumed it would be used by others to. It is not, so I can remove it from SaveLoad 19:16:41 <TrueBrain> only this was is annoyingly hooked into the saveload system 19:16:52 <frosch123> ah, i did not see the proxy thing, i just assumed you forgot to delete it :) 19:17:30 <TrueBrain> meh; I need to look at that when the temperature in my room isn't above "able to think" temperature :) 19:17:40 <TrueBrain> if you wouldn't mind reapproving #9332, I can at least merge that :D 19:18:01 <DorpsGek> [OpenTTD/OpenTTD] frosch123 approved pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGKOR 19:18:33 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #9332: Codechange: rename SettingGuiFlag to SettingFlag https://git.io/JGoA9 19:18:54 <frosch123> good thing that eints is still two hours away :p 19:20:20 <frosch123> TrueBrain: just so i get this right: the numberic values of SLE_FILE_ values will matter in the future, when #9322 starts storing them in the schema? 19:20:57 <frosch123> while all other SLE_ do not matter 19:21:15 <TrueBrain> yes 19:21:37 <TrueBrain> unintentional , but yes. 19:21:55 <TrueBrain> ideally, we first split up that variable 19:22:02 <TrueBrain> as it is so annoying that 1 variable contains 2 meanings 19:24:17 <frosch123> maybe we can use template magic to remove some of the SLE_VAR 19:24:32 <frosch123> but SLF_ALLOW_CONTROL, ... will remain 19:25:11 <TrueBrain> okay, SF_NO_NETWORK_SYNC doesn't prevent the setting from being saved 19:25:15 <TrueBrain> but only from being loaded 19:25:43 <frosch123> oh, lol, SLF_ALLOW_NEWLINE is also unused :p 19:25:48 <TrueBrain> ..... 19:30:12 <frosch123> looks like it was added together with ALLOW_CONTROL. just to pass all StringValidationSettings through 19:30:41 <frosch123> https://github.com/OpenTTD/OpenTTD/commit/5cda1d7c90f7ac2a1d8a851edbe426f07a032946 <- oh, look, who added it :p 19:30:55 <frosch123> so, gs stuff 19:30:59 <TrueBrain> LIES 19:31:10 <TrueBrain> I am happy there is another name in those () 19:31:11 <TrueBrain> :D 19:31:21 <TrueBrain> shifting blame :D 19:32:42 <frosch123> hmm, is SLE_STRINGQUOTE also a settings thing? 19:33:19 <TrueBrain> seems so 19:33:31 <TrueBrain> bit of a weird type 19:33:37 <TrueBrain> no clue why a normal string isn't enough 19:33:40 <frosch123> but where is it used? 19:33:53 <TrueBrain> grep SLE_STRQ 19:34:20 <frosch123> StringSettingDesc::FormatValue 19:34:33 <TrueBrain> owh, that side of "used", sorry :) 19:34:40 <TrueBrain> it adds "" around a string .. it is really odd :P 19:36:04 <frosch123> so, it's only about openttd.cfg, not about console, right? 19:36:15 <TrueBrain> I do not know 19:36:23 <TrueBrain> I looked at it, was like: wtf? and moved on 19:36:24 <TrueBrain> :D 19:37:28 <frosch123> well, rb was working on removing all STRB 19:37:43 <frosch123> so if STRQ could make it into the settingsflags :p 19:38:21 <frosch123> otoh, maybe the config file should just quote all string settings 19:38:47 <TrueBrain> or no settings 19:38:57 <TrueBrain> I mean ... when it quoting useful? 19:38:58 <Rubidium> STRQ is basically "this string can start or end with a space, so it needs to be quoted otherwise it gets lost in the configuration" 19:39:14 <TrueBrain> uuuggggghhhh .. 19:39:18 <TrueBrain> can't we just use YAML? :P 19:39:21 <TrueBrain> and leave that to the libyaml? :D 19:39:39 <frosch123> oh, i assumed it applied to all strings with spaces, but small_font and friends disprove that :p 19:40:25 <Rubidium> practically it could probably even be removed and the code just checks for it starting/ending with a space, and if so add the quotes 19:40:30 <frosch123> but yes, i agree. the iniwriter should figure out itself, whether quotes are needed 19:40:40 <frosch123> add quotes when starting/ending with space or quotes 19:41:44 <TrueBrain> the only "trick" in that case is to quote strings with quotes :) 19:41:51 <TrueBrain> but yes, indeed 19:42:58 <glx> don't quote and encode spaces with %20 ? 19:43:13 <TrueBrain> and escape % with .. :D 19:43:18 <TrueBrain> before you know it we have urllib :P 19:43:49 <TrueBrain> ==19244==ERROR: AddressSanitizer: alloc-dealloc-mismatch (operator new vs free) on 0x6070002a4fc0 19:43:56 <TrueBrain> in code I think I did not touch .. 19:43:57 <frosch123> aw... we still store some strings as StringID in the saves. i thought that was all old stuff 19:44:11 <TrueBrain> new vs free 19:45:20 <TrueBrain> I am happy those traces show both ends (both the line of the "new" and the line of the "free") 19:46:23 <frosch123> Rubidium: https://github.com/OpenTTD/OpenTTD/blob/master/src/script/script_instance.cpp#L385 <- do you already have that on your std::string agenda? :) 19:47:30 <frosch123> (it's the only usage of SLE_CHAR) 19:47:31 *** iSoSyS has joined #openttd 19:48:05 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #9334: Fix: server was trying to free() a packet created with "new CommandPacket()" https://git.io/JGKnt 19:50:22 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9333: Codechange: merge guiflags and flags for settings https://git.io/JGKeH 19:51:48 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #9334: Fix: server was trying to free() a packet created with "new CommandPacket()" https://git.io/JGKnP 19:53:05 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9334: Fix: server was trying to free() a packet created with "new CommandPacket()" https://git.io/JGKnt 19:53:08 <DorpsGek> [OpenTTD/OpenTTD] frosch123 commented on pull request #9334: Fix ef991b17: server was trying to free() a packet created with "new CommandPacket()" https://git.io/JGKnA 19:54:10 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9334: Fix ef991b17: server was trying to free() a packet created with "new CommandPacket()" https://git.io/JGKnt 19:54:12 <TrueBrain> funny, I did search for "free(" :D But yes 19:54:22 <TrueBrain> owh, other file 19:54:23 <TrueBrain> nice 19:54:46 <glx> and in #ifdef code 19:54:51 <frosch123> luckily there are not many free anymore 19:55:32 <glx> I searched for free(cp); (assuming variable names will be stable) 19:55:38 <glx> found only 2 19:55:58 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9333: Codechange: merge guiflags and flags for settings https://git.io/JGKeH 19:56:00 <frosch123> there are only 14 "free(" in src/network/... 19:56:07 <TrueBrain> we are getting there :) 19:56:18 <TrueBrain> okay, #9333 should be done now too .. not the easiest to review 19:56:25 <TrueBrain> I could split it up in several commits, if that is liked 19:58:20 <TrueBrain> not super happy I had to make SlCalcConvMemLen visible .. 19:58:41 <frosch123> haha, i bet you raged a bit when you noticed to had to reasslign the SF_ comments again :p 19:58:57 <frosch123> *reallign 19:59:06 <frosch123> *realign ? 20:00:29 <frosch123> huh, what happened to the GetSettingsDesc? 20:00:31 <TrueBrain> I fucking hate that we want things to be aligned :P 20:00:34 <TrueBrain> I removed it .. it was buggy 20:00:42 <TrueBrain> the temperature needs to drop before I can revisit that :) 20:03:47 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #9334: Fix ef991b17: server was trying to free() a packet created with "new CommandPacket()" https://git.io/JGKCW 20:06:04 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9333: Codechange: merge guiflags and flags for settings https://git.io/JGKeH 20:06:07 <TrueBrain> right, a bit less ugly SF_NO_NETWORK_SYNC 20:06:10 <TrueBrain> but still not what I want it to be 20:06:14 <frosch123> i see, the entry to the rabbit hole collaped :p 20:06:25 <frosch123> wasn't GetSettingsDesc the intial reason to start this? :p 20:06:51 <TrueBrain> I cannot even remember why I was doing this :P 20:07:27 <Rubidium> because you wanted validation of the server name in your new network UI 20:07:40 <TrueBrain> no, that is your rabbit hole :P 20:07:48 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #9334: Fix ef991b17: server was trying to free() a packet created with "new CommandPacket()" https://git.io/JGKnt 20:08:03 <TrueBrain> I really cannot remember why I ended up doing this stuff :D Funny 20:08:09 <Rubidium> if I hadn't gone into that hole, you might not have done much of this 20:08:41 <TrueBrain> no, my rabbit hole is having secrets in secrets.cfg :P 20:08:44 <Rubidium> frosch123: no, it's not on a list. Just occasionally I look for places with C-strings and change them 20:11:05 <TrueBrain> funny, I really cannot remember what triggered me down this rabbit hole .. so, yes, it collapsed frosch123 :D 20:11:12 <glx> and with bad luck a simple C-string replacement ends up in a massive patch :) 20:13:51 *** nielsm has quit IRC 20:17:21 *** WormnestAndroid has quit IRC 20:17:35 *** WormnestAndroid has joined #openttd 20:18:11 *** glx_ has joined #openttd 20:18:11 *** glx is now known as Guest769 20:18:11 *** glx_ is now known as glx 20:20:08 <TrueBrain> hmm .. not sure if my lovely GetSettingsDesc can work .. 20:20:16 <TrueBrain> skipping the NO_NETWORK_SYNC entries is difficult 20:22:58 <frosch123> andythenorth: you seem to know about newgrf drama. why are there 4 egrvts on bananas now? 20:23:05 <andythenorth> there are? 20:23:08 <andythenorth> I don't know 20:23:18 <andythenorth> I don't read forums 20:23:20 <TrueBrain> unacceptable :P 20:23:31 <frosch123> egrvts, egrvts2, rgrvts2 nrt, rgrvts 2.1 20:24:20 <frosch123> i mean, i get firs 1,2,3,4 using different grfids. but egrvts 2 and 2.1 :p 20:24:26 <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/JGKlH 20:24:27 <DorpsGek> - Update: Translations from eints (by translators) 20:24:37 *** Guest769 has quit IRC 20:24:38 <TrueBrain> poor GitHub schedule 20:24:40 <TrueBrain> totally confused 20:25:03 <michi_cc> They moved the runners to Mars? 20:25:36 <michi_cc> Or hired somebody that spent years of running the rovers for NASA... 20:31:43 <TrueBrain> it is just weird 20:34:27 <TrueBrain> "Note: Due to load, the `schedule` event may be delayed" 20:34:29 <TrueBrain> yeah, no shit 20:34:53 <glx> luckily we only run it once a day 20:36:15 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #9335: Codechange: make [Save|Load]Settings() behave more like other Save/Load code https://git.io/JGKBm 20:36:20 <TrueBrain> frosch123: okay, I managed to make it work .. I think :P 20:37:06 *** iSoSyS has quit IRC 20:38:32 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9333: Codechange: merge guiflags and flags for settings https://git.io/JGKB4 20:38:53 <TrueBrain> what an utter mess this saveload / settings integration has become, damn 20:43:29 <TrueBrain> and I found back why I was doing this .. because I was done being confused by the flags being in saveload :P 20:43:36 <TrueBrain> had nothing to do with any of the other work :P 20:43:48 *** tokai|noir has joined #openttd 20:43:48 *** ChanServ sets mode: +v tokai|noir 20:50:50 *** tokai has quit IRC 20:54:04 *** gelignite has quit IRC 20:55:15 *** Samu has quit IRC 21:09:11 <peter1138> maybe someone wanted to use all versions of *grvts* together 21:09:43 *** sla_ro|master has quit IRC 21:14:52 *** k32n13 has joined #openttd 21:16:09 *** k32n13 has left #openttd 21:16:18 *** k32n13 has joined #openttd 21:16:22 *** Beer has quit IRC 21:16:40 *** k32n13 has left #openttd 21:22:05 <Timberwolf> A grf I persist in calling "eggverts" despite that not even being the correct order of 'r' and 'v' 21:24:54 <FLHerne> Well, the actual order is unpronounceable 21:26:29 <andythenorth> pronounce it like PNG 21:27:32 <peter1138> Allegedly "ping" but nobody does that. Right? 21:28:14 *** frosch123 has quit IRC 21:28:38 <andythenorth> exactly 21:41:32 <dwfreed> pee enn gee 21:46:28 *** andythenorth has quit IRC 21:46:55 <Timberwolf> Pernug. 21:51:30 *** andythenorth has joined #openttd 22:26:45 *** crem has quit IRC 22:30:04 *** tokai has joined #openttd 22:30:04 *** ChanServ sets mode: +v tokai 22:31:52 *** crem has joined #openttd 22:32:11 *** andythenorth has quit IRC 22:37:00 *** tokai|noir has quit IRC 22:37:36 *** Strom has quit IRC 22:38:17 *** Beer has joined #openttd 22:39:20 *** Strom has joined #openttd 22:58:24 *** Gustavo6046 has quit IRC 22:58:28 *** Gustavo6046 has joined #openttd 23:00:46 *** Progman has quit IRC 23:22:12 *** HerzogDeXtEr has quit IRC 23:37:32 *** Gustavo6046 has quit IRC 23:37:42 *** Gustavo6046 has joined #openttd 23:51:43 *** Gustavo6046 has quit IRC 23:52:15 *** Gustavo6046 has joined #openttd