Times are UTC Toggle Colours
00:38:26 *** Progman has quit IRC 01:25:09 *** snail_UES_ has joined #openttd 01:31:01 *** Gustavo6046 has quit IRC 01:32:03 *** Gustavo6046 has joined #openttd 01:57:24 *** tokai|noir has joined #openttd 01:57:24 *** ChanServ sets mode: +v tokai|noir 02:04:20 *** tokai has quit IRC 02:37:01 *** Wormnest has quit IRC 02:40:45 *** debdog has joined #openttd 02:44:05 *** D-HUND has quit IRC 02:59:34 *** Wuzzy has quit IRC 03:16:44 *** yeoldetoast has joined #openttd 03:29:35 *** glx has quit IRC 03:43:40 *** kgarza has joined #openttd 03:49:47 *** kgarza__ has quit IRC 04:27:18 *** kgarza has quit IRC 04:27:35 *** kgarza has joined #openttd 04:40:33 *** snail_UES_ has quit IRC 05:24:26 *** nielsm has joined #openttd 05:29:41 *** Flygon has joined #openttd 07:00:20 *** andythenorth has joined #openttd 07:16:23 *** andythenorth has quit IRC 07:21:50 *** andythenorth has joined #openttd 07:22:30 <andythenorth> yo 07:26:30 <DorpsGek> [OpenTTD/nml] andythenorth commented on pull request #220: Fix #209: Cargo 'profit' callback applied a unit conversion, when there was no unit. https://git.io/JcApp 07:26:39 <DorpsGek> [OpenTTD/nml] andythenorth commented on pull request #212: Fix #209: Sign-extend value before cargo_profit callback result calculation https://git.io/JcAhe 07:26:54 <DorpsGek> [OpenTTD/nml] andythenorth commented on pull request #193: Update: changelog for 0.6.0 https://git.io/JcAhU 07:30:51 <LordAro> yo 07:33:57 <TrueBrain> time to test if my redis backend works :D How to test it properly .. eeeeeuuuuuhhhhh 07:34:00 <TrueBrain> deploy it? :P 07:34:18 <andythenorth> yolo 07:34:33 <andythenorth> how to test any prod. infra ever? 07:40:02 <Rubidium> write a post on slashdot that you have something new and amazing ;) 07:40:43 <andythenorth> ok so it seems I don't need to fork 07:41:11 <andythenorth> desert or > snowline towns don't set a growth requirement if no cargos have TOWN_EFFECT defined 07:41:26 <andythenorth> wish I'd known that years ago :D 07:42:17 <andythenorth> that's how I read this anyway :) https://github.com/OpenTTD/OpenTTD/blob/master/src/town_cmd.cpp#L1829 07:42:29 <andythenorth> and a quick FIRS test _appears_ to confirm 07:47:11 <DorpsGek> [OpenTTD/master-server] TrueBrain updated pull request #35: Feature: redis support as database backend https://git.io/Jc7rO 07:55:29 * peter1138 ponders doing unmentionable things to the road bike. 07:55:46 <peter1138> Needs a new derailleur :/ 07:56:54 <TrueBrain> DO ITTTTT 07:57:19 <peter1138> Needs new cables too, they are all gummed up, and because they're internally routed that's a pain in the arse. 07:57:53 <peter1138> So I might strip it down, clean everything up, then take it to the local bike shop to sort out. 07:57:56 <DorpsGek> [OpenTTD/master-server] TrueBrain updated pull request #35: Feature: redis support as database backend https://git.io/Jc7rO 07:58:39 <peter1138> Bike shop owners are patronizing cunts, 07:58:44 <peter1138> In my experience :( 07:59:04 <TrueBrain> okay .. I am going to break the master-server JSON API .. no clue if other people use it .. guess their tool will break, and they will complain? Dunno :) 07:59:19 <peter1138> You haven't stripped down and immediately cleaned everything after your last ride?! What are you even doing having a bikr!? 07:59:20 <TrueBrain> I think we never published the API endpoint, so meh? :) 07:59:35 <TrueBrain> peter1138: haha :D 07:59:43 <TrueBrain> you aren't that obsessed with your bike? Tssk 07:59:54 <peter1138> Yeah, fuck off, I needed that bike to get me to and from work every day, I couldn't risk taking it to bits... 07:59:59 <andythenorth> peter1138 I have found at least one that isn't 08:00:03 <andythenorth> in my life 08:00:15 <peter1138> We had a nice one, it was even in this town. But then he closed up. 08:00:43 <andythenorth> go in and ask for an inner tube, then when they ask which valve type, say 'normal' 08:00:50 <peter1138> Now the two nearest are a car journey away, and condescending as fuck. 08:01:19 <andythenorth> if a bike needs servicing, time for a new bike? 08:01:39 * andythenorth has friends with bike collecting issues 08:01:39 <peter1138> Ride a bike in winter, chain is immediately black. 08:01:57 <DorpsGek> [OpenTTD/master-server-web] TrueBrain opened pull request #29: Fix: adjust to new field-names in API and optimize server detail ordering https://git.io/JcxTs 08:02:01 <peter1138> Bike shop: posts photos of immaculate looking bike out on the trails with a brand-new looking chain. 08:02:12 <peter1138> "You just need to clean it" 08:02:23 <peter1138> Yea... I clean it and it's black again the moment it gets out. 08:02:52 <peter1138> (Not actually black, but not shiny silver) 08:05:33 <andythenorth> another day, another Covid test 08:05:35 <andythenorth> hurrah 08:06:42 <andythenorth> ok credit:debit calculation time 08:06:55 <andythenorth> debit: child covid test required 08:07:12 <andythenorth> credit: no need to fork OpenTTD to disable TOWN_EFFECT goals from grf 08:08:11 <TrueBrain> okay, from what I can tell, the new MS should work fine .. just deploying might interrupt the server-list for a bit of time .. so I guess we just going to do it :D 08:13:04 <peter1138> Or I could just go out for a ride on the touring bike (which is what I have been doing all year anyway) 08:13:15 <peter1138> Heavy bike though. 08:19:45 *** andythenorth has quit IRC 08:19:51 <DorpsGek> [OpenTTD/master-server] TrueBrain opened pull request #36: Change: rename fields in the API to more match what it does https://git.io/JcxLG 08:21:57 <DorpsGek> [OpenTTD/master-server] TrueBrain merged pull request #36: Change: rename fields in the API to more match what it does https://git.io/JcxLG 08:22:12 <DorpsGek> [OpenTTD/master-server] TrueBrain updated pull request #35: Feature: redis support as database backend https://git.io/Jc7rO 08:22:43 <DorpsGek> [OpenTTD/master-server-web] TrueBrain merged pull request #29: Fix: adjust to new field-names in API and optimize server detail ordering https://git.io/JcxTs 08:23:23 <DorpsGek> [OpenTTD/master-server] TrueBrain merged pull request #35: Feature: redis support as database backend https://git.io/Jc7rO 08:23:24 <TrueBrain> time to test on staging :) 08:27:41 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #9423: Fix 11ab3c4: [NewGRF] Overflow when determining cargo mask for string code 9A 1E https://git.io/Jcxtx 08:30:32 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #9423: Fix 11ab3c4: [NewGRF] Overflow when determining cargo mask for string code 9A 1E https://git.io/Jcxqg 08:30:46 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #9423: Fix 11ab3c4: [NewGRF] Overflow when determining cargo mask for string code 9A 1E https://git.io/JcxqV 08:31:03 <LordAro> :D 08:31:36 <TrueBrain> The approve reason is the best :D 08:34:18 <Rubidium> nice! Approving untested code ;) 08:34:54 *** HerzogDeXtEr has joined #openttd 08:37:17 <peter1138> I had some code that had been tested and merged and turned into a release. 08:37:48 <peter1138> Then I happened to read one line of code and realised it had a bug... so I made a new release without ever using the other release... 08:38:06 <peter1138> (That was yesterday) 08:40:18 <TrueBrain> Rubidium: what is the worst that can happen 08:40:55 <Rubidium> compiler complaining about unsigned <-> signed issues I guess 08:50:27 *** Wolf01 has joined #openttd 08:50:46 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #9424: Remove some logically dead code https://git.io/Jcx3n 08:51:03 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #9423: Fix 11ab3c4: [NewGRF] Overflow when determining cargo mask for string code 9A 1E https://git.io/Jcxtx 08:53:14 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #9424: Remove some logically dead code https://git.io/Jcx31 09:02:54 <peter1138> Sometimes I feel logically dead. 09:02:58 <TrueBrain> meh, testing on staging for the master-server is always annoying, as it uses another port (instead of another IP) ... 09:04:02 <TrueBrain> okay, it seems master is acting differently from 1.11, even on production .. so unrelated to my change :P 09:04:37 <TrueBrain> owh, yes, ofc, I removed a pointless debug statement, and I am now annoyed I do not see that debug line in master 09:04:38 <TrueBrain> lalalalaaaaa 09:04:57 <peter1138> I have my test instances running on the same server as my production instances, which feels a little awkward, but means that I know when it works on test it will work on prod. 09:05:10 <DorpsGek> [OpenTTD/OpenTTD] MrSmoke commented on issue #8095: Feature suggestion: option to automatically space out vehicles in a shared order https://git.io/JfIUi 09:05:23 <TrueBrain> I like that for http etc you can do that easily .. just for TCP that is rather annoying :P 09:05:35 <peter1138> Yea 09:05:56 <TrueBrain> hmm ... I do not have a place anymore to host a custom compiled OpenTTD server to test .. that is annoying :D 09:06:05 <TrueBrain> stupid port forwarding .. 09:06:13 <peter1138> Ideally I would use modern devops practises to run everything but that's a whole load of learning which I don't have time for. 09:06:53 <TrueBrain> but it seems everything is "just working" .. so I guess YOLO? I can always roll back the deployment, I guess :) 09:07:06 *** andythenorth has joined #openttd 09:07:31 <peter1138> Want an account on my server? :p 09:07:55 <TrueBrain> I want a server to announce itself on 4978, that is what I want :P 09:08:48 <TrueBrain> but I tested everything locally, and staging accepted the new deployment without issue .. so I think I am good :) 09:09:04 <peter1138> static const uint16 NETWORK_MASTER_SERVER_PORT = 4978; ///< The default port of the master server (UDP) 09:09:08 <andythenorth> hmm all this FIRS breaking 09:09:09 <peter1138> Is that the only way to change it? 09:09:10 <andythenorth> goes it a branch? 09:09:11 <TrueBrain> peter1138: yup 09:09:13 <andythenorth> hmm 09:09:27 <TrueBrain> one of the reasons that testing is rather annoying : 09:09:50 <peter1138> Would be sensible to add a (hidden) cmdline parameter for it? 09:09:55 <TrueBrain> I have been wondering if we should add a "--staging" flag, also for content services .. but .. yeah .. effort 09:10:10 <TrueBrain> or an ENV variable, might be better I guess 09:10:49 <TrueBrain> might make a PR for that later today, as for the game-coordinator, this will also be a bit of an issue :P 09:10:49 <peter1138> env might be a pain on windows 09:11:02 <peter1138> dunno if it is though 09:11:29 <peter1138> Had a takeaway curry last night. There is no a yellow stain on my kitchen work top as one of the containers was on it for 5 seconds. 09:11:32 <TrueBrain> hmm ... I might also make the change that we don't have the hostname and port in 2 variables .. 09:11:52 <peter1138> master.openttd.org:4978 09:12:17 <TrueBrain> that means testing with other DNS etc is also a lot easier 09:12:21 <TrueBrain> as now I keep changing my /etc/hosts :P 09:12:26 <andythenorth> peter1138 same :P 09:12:34 <andythenorth> saffron and turmeric 09:12:50 <andythenorth> ok, so do I need to set TOWNGROWTH_PASSENGERS on passengers cargo? 09:12:56 <andythenorth> what even do does it? 09:13:01 <peter1138> Why did my compiler start taking ages to compile OpenTTD? :( 09:13:22 <peter1138> Pretty sure it is not compiling con 09:13:30 <peter1138> -currently. 09:13:43 <TrueBrain> and worst part, changing config.h recompiles 60% of the files :P 09:13:49 <TrueBrain> for some reason, EVERYTHING is including it 09:14:21 <peter1138> When I originally set this up my CPU fans would ramp up and it would use all cores and then some more. 09:14:35 <peter1138> Now it does it file by file and nothing else is affected. 09:14:43 <TrueBrain> make -j9 ? :) 09:14:45 <peter1138> But I didn't change any cmake settings. 09:15:01 <TrueBrain> concurrency value is not part of CMake, sadly enough :( 09:15:14 <peter1138> Okay, 4978 09:15:45 <peter1138> Advertising to the master server is failing. Hmm. 09:15:57 <TrueBrain> UDP portforwarding working? 09:16:01 <peter1138> Oh right, THIS IP is on NAT :( 09:16:08 <TrueBrain> :( 09:16:27 <TrueBrain> I have the same issue .. and a double-NAT at that .. and forwarding UDP is a bit iffy for one of the two :P 09:16:29 <TrueBrain> so annoying :D 09:17:45 <TrueBrain> (well, via WSL I even have 3 NATs, and for one I cannot even enable forwarding :P) 09:17:49 <andythenorth> also TOWNGROWTH_MAIL needs to be set? 09:18:01 <andythenorth> something about subsidies or something 09:18:05 * andythenorth doesn't know 09:18:27 <peter1138> Take 2 09:18:43 <peter1138> 3 packets forwarded. 09:18:55 <peter1138> Hmm, still says it failed. :/ 09:19:01 <peter1138> Ugh, Windows firewall maybe/. 09:19:50 *** Progman has joined #openttd 09:20:40 <peter1138> Okay, what's the apt command to install build dependencies? Heh 09:20:49 <TrueBrain> apt install build-essentials :) 09:20:52 <peter1138> E: You must put some 'source' URIs in your sources.list 09:20:52 <TrueBrain> might be singular 09:20:54 <peter1138> fuuuuu 09:20:55 <TrueBrain> can never remember :P 09:21:15 <TrueBrain> but it is okay peter1138 , I am just going to wing it ;) 09:21:18 <peter1138> build-dep wants source :( 09:21:37 <DorpsGek> [OpenTTD/master-server] TrueBrain created new tag: 1.1.0 https://git.io/JcxCV 09:21:40 <DorpsGek> [OpenTTD/master-server-web] TrueBrain created new tag: 1.1.0 https://git.io/JcxCw 09:22:06 <peter1138> Yeah, autoconf, automake, fuck off, no. 09:22:22 <TrueBrain> but I do appreciate you trying to help out here :D 09:22:38 <TrueBrain> I have also considered to make something simple to spin up an EC2 instance to test OpenTTD servers on 09:22:41 <TrueBrain> but .. ugh .. effort :P 09:23:10 <peter1138> I think adding ENV to allow changing these would be best. 09:23:17 <peter1138> No need to custom compile then. 09:23:34 <TrueBrain> yeah, especially if they are "master.openttd.org:3978" :) 09:23:55 <peter1138> Yeah, single string. 09:27:00 <TrueBrain> okay, in-game serverlisting works fine 09:27:09 <TrueBrain> website will be shit for the next 15 minutes :P 09:27:13 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #9424: Remove some logically dead code https://git.io/Jcx3n 09:28:48 <TrueBrain> funny that for months now a few servers try to register which .. do not behave according to the protocol 09:28:52 <TrueBrain> I think they are custom servers 09:29:01 <TrueBrain> either way, they keep trying to announce themselves, every 15 minutes 09:29:04 <TrueBrain> for MONTHS now :P 09:29:07 *** felix has quit IRC 09:29:17 <andythenorth> errr 09:29:32 <TrueBrain> (they are not being listed because they make a protocol error) 09:29:35 <andythenorth> does this mean that towns don't grow unless more pax were transported this month than last? https://github.com/OpenTTD/OpenTTD/blob/master/src/town_cmd.cpp#L3514 09:30:58 * andythenorth assumes that can't be the case 09:32:23 * andythenorth doesn't want to put lies into the newgrf wiki 09:32:55 *** WormnestAndroid has quit IRC 09:33:08 *** WormnestAndroid has joined #openttd 09:33:33 <TrueBrain> 50% of the servers are already updated ... waiting on the other 50% :D 09:40:33 *** felix has joined #openttd 09:42:47 <TrueBrain> 21 servers left ... 09:46:04 <TrueBrain> 1 .... 09:46:20 <andythenorth> \o/ 09:47:17 <TrueBrain> and the weblisting is back :D 09:48:18 <TrueBrain> next step, switching to redis .. that will wipe the serverlist for ~15 minutes, as they all reannounce themselves :) 09:48:28 <andythenorth> stupid HTML 09:48:33 <andythenorth> can't close an <li> with </p> 09:48:35 <andythenorth> who knew? 09:48:41 <andythenorth> TrueBrain GG WP :) 09:49:21 <andythenorth> does this read ok for a note in FIRS docs? 09:49:23 <andythenorth> "FIRS adjusts default town behaviour: towns above snowline do not require food to grow, and towns in desert do not require food and water to grow." 09:49:55 <TrueBrain> sure 09:50:15 <andythenorth> tx 09:51:35 <TrueBrain> right, lets see if redis works on staging first ... pam pam pammmmm 09:53:20 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #5: Add: small tweaks so the Game Coordinator understands Master Server data https://git.io/Jc7rW 10:02:40 *** Samu has joined #openttd 10:06:15 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain opened pull request #6: Fix: report back to servers that cannot accept remote connections https://git.io/Jcxuo 10:06:40 <Samu> hi 10:07:15 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #6: Fix: report back to servers that cannot accept remote connections https://git.io/Jcxuo 10:15:05 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain created new tag: 0.1.1 https://git.io/JcxgL 10:15:18 <TrueBrain> I think switching to redis is going to work .. just no real way of knowing if it can handle the load honestly :) 10:16:59 <Rubidium> oh joy... want to verify an uninitialized memory issue, so compiling with memorysanitizer... and that fails building due to using uninitialized memory in one of the helpers... grr 10:24:30 <TrueBrain> meh ... I forgot the website wants a key to identify servers ... 10:34:30 <andythenorth> how many days is 'every 3 months' in OpenTTD? 10:34:40 <andythenorth> or alternatively, how many 256-tick industry production cycles? 10:36:19 <andythenorth> are the lengths of months known? 10:38:42 <Rubidium> ~365.25 / 4 days ;) 10:39:43 <Rubidium> about ~26.4 256 tick cycles per 3 months 10:40:42 <andythenorth> but calendar months vary length.... 10:41:17 <andythenorth> although nobody has ever actually reported the bug in FIRS 10:41:27 <andythenorth> which is surprising given the weird detailed analysis some players do 10:41:52 <Rubidium> though 3 months is ofcourse a quite fluid concept 10:42:09 <andythenorth> it is 10:42:29 <andythenorth> if an industry needs supplies 'every 3 months' to boost production 10:42:34 <andythenorth> when does the boost end? 10:42:43 <Rubidium> as anything between 2.5 and 3.|9| months can be classified as 3 months 10:42:59 <andythenorth> if I deliver on Jan 16th, does the boost end on April 16th? 10:43:01 <andythenorth> or last day of April? 10:43:04 <andythenorth> or 90 days? 10:43:12 <andythenorth> or 26.4 production cycles? 10:43:49 <andythenorth> and if it's April 16th, do I have to calculate exact proportion of cargo if next prod cycle is actually April 20th 10:43:58 * andythenorth thinks this is all a bit silly 10:44:32 <andythenorth> maybe just 27 production cycles :P 10:44:38 <Rubidium> I'd say 27 cycles; mostly so if you schedule it to be delivered ever 91 days. And if the next cycle starts in a few days... well... that's very agile... it's when the new sprint starts ;) 10:51:42 <peter1138> Okay my chain is clean but the sprockets are not really there yet. 10:52:49 <andythenorth> 27 cycles for the win 10:55:24 <Samu> success https://i.imgur.com/DJQoeY6.png 10:58:12 <Samu> 48402 ops used for saving 11:01:53 <peter1138> 27 bicycles is the right amount. 11:01:57 <peter1138> I need a bigger shed. 11:02:27 <Samu> 2973 stations, 3161 buoys 11:02:49 <Samu> @calc (2973 + 3161) * 15 11:02:49 <DorpsGek> Samu: 92010 11:02:56 <Samu> that's over 64000 11:03:10 <Samu> not enough station ids with 15 companies 11:05:34 <Samu> local table = {234, false, {567, 890}}; why is this not compiling? 11:05:43 <Samu> looks like I don't know what a table is 11:08:03 <Samu> well, if that doesn't work with table, maybe it will work with array, let's redo this 11:12:45 <andythenorth> peter1138 I didn't convince you to e-bike yet? :P 11:13:35 <peter1138> I've got legs 11:22:02 <peter1138> I should get a belt-drive bike. 11:22:08 <peter1138> No need to worry about a dirty chain then. 11:24:35 <peter1138> Fuck sake 11:24:45 <peter1138> Tern HSD S+ 2021, electric folding bike. £5,400 11:24:46 <peter1138> Haha 11:25:16 <peter1138> Only the handlebar folds lol 11:25:28 <peter1138> Still, it's got belt drive. And a motor. 11:28:03 <peter1138> Frame – Ash wood frame with walnut centre stripe 11:28:03 <peter1138> wutt 11:29:20 <peter1138> https://connorcycles.files.wordpress.com/2016/03/square_mountain.jpg 11:29:30 <peter1138> I dunno... I think a wooden mountain bike is a strange idea. 11:33:43 <LordAro> mm, splinters 11:43:23 <andythenorth> I have a weird enclosed chain thing 11:43:47 <andythenorth> because hub gears 11:49:47 <andythenorth> hmm I am going to get obiwans counting 27 production cycles :P 11:49:53 <andythenorth> with registers starting at 0 11:49:57 * andythenorth needs a pencil 11:58:35 *** glx has joined #openttd 11:58:35 *** ChanServ sets mode: +v glx 12:10:29 <andythenorth> if I start with storage_0 and run up to storage_26, that gives 27 I reckon 12:10:33 * andythenorth basic programming problems 12:15:44 <DorpsGek> [OpenTTD/master-server] TrueBrain opened pull request #37: Fix: server-list was filled with coroutines instead of server info https://git.io/JcxQ6 12:15:47 <DorpsGek> [OpenTTD/master-server] TrueBrain opened pull request #38: Fix: don't error out when a server doesn't exist https://git.io/JcxQi 12:18:42 <DorpsGek> [OpenTTD/master-server] TrueBrain opened pull request #39: Fix: use the redis-key as server-id for the redis backend https://git.io/Jcx7I 12:18:48 <DorpsGek> [OpenTTD/master-server] TrueBrain merged pull request #37: Fix: server-list was filled with coroutines instead of server info https://git.io/JcxQ6 12:18:58 <DorpsGek> [OpenTTD/master-server] TrueBrain merged pull request #38: Fix: don't error out when a server doesn't exist https://git.io/JcxQi 12:19:39 <DorpsGek> [OpenTTD/master-server-web] TrueBrain opened pull request #30: Fix: time_[first|last]_seen are no longer used nor available https://git.io/Jcx7G 12:21:34 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain opened pull request #7: Fix: expiring servers because of TTL caused an instance crash https://git.io/Jcx76 12:21:43 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain opened pull request #8: Fix: redis-keys should contain a server-id as expected by the web API https://git.io/Jcx7P 12:21:57 <DorpsGek> [OpenTTD/master-server-web] TrueBrain merged pull request #30: Fix: time_[first|last]_seen are no longer used nor available https://git.io/Jcx7G 12:22:04 <DorpsGek> [OpenTTD/master-server] TrueBrain merged pull request #39: Fix: use the redis-key as server-id for the redis backend https://git.io/Jcx7I 12:23:40 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #7: Fix: expiring servers because of TTL caused an instance crash https://git.io/Jcx76 12:23:57 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain updated pull request #8: Fix: redis-keys should contain a server-id as expected by the web API https://git.io/Jcx7P 12:23:59 <TrueBrain> ugh, rebase needed ... that is unexpected 12:24:31 <peter1138> Oops, I broke my run of forming proper coherent sentences. Back to normal! 12:24:36 <glx> https://github.com/OpenTTD/OpenTTD/compare/master...glx22:script_list_save <-- it was a fun exercise, so I did the loading too 12:24:49 <TrueBrain> poor peter1138 :P 12:25:34 <TrueBrain> glx: I think the original reason not to allow storing complex objects, as that it is more and more likely people add crap into them :P 12:26:13 <glx> yeah, but same goes with arrays and tables :) 12:26:14 <TrueBrain> because really hard to debug at a certain point 12:26:42 <TrueBrain> code-wise, they can be proof-read a lot more easy :P 12:26:49 *** HerzogDeXtEr has quit IRC 12:27:11 <glx> at leasts list should contain only integers 12:27:42 <TrueBrain> but in general I think script save/load missed their mark 12:27:46 <TrueBrain> like ... by a long shot :P 12:28:08 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #8: Fix: redis-keys should contain a server-id as expected by the web API https://git.io/Jcx7P 12:30:11 <TrueBrain> I have been wondering if we can do the script save/load in a header-way like the rest of the savegames 12:30:31 <TrueBrain> I think it is possible, but .. not sure it is worth it :D 12:30:45 <glx> the header is integrated in the saved data 12:31:00 <glx> with all the markers 12:31:27 <TrueBrain> no clue if we talk about the same thing .. but the AI and GS chunk atm have a "blob" at the end of each row 12:31:36 <TrueBrain> which doesn't have a header in the saveload header 12:31:40 <glx> table string key type value string key type value ... tableend 12:31:41 <TrueBrain> header = field 12:32:29 <glx> yeah I know, header is hard to do 12:33:47 <TrueBrain> as converting the presented data from script to a SaveLoad structure, would clean up that code a lot :P 12:36:00 <glx> at least now I understand the blob structure :) 12:37:14 <TrueBrain> document it! :P 12:37:57 <TrueBrain> oof, found another bug in game-coordinator and master-server playing nice .. why is the real world different from my local :P :P 12:41:00 <glx> in theory it should be possible to generate a dynamic SaveLoad table 12:48:03 <DorpsGek> [OpenTTD/team] JustImagine436 opened issue #233: [cs_CZ] Translator access request https://git.io/Jcxb2 12:48:57 * andythenorth watching industry debug window for storages 12:49:07 <andythenorth> every 256 ticks I shift the contents of 27 registers 1 left 12:49:12 <andythenorth> it's a bit like space invaders 12:49:21 <andythenorth> or duck hunt 12:50:16 <andythenorth> it's funny that I didn't know I could return the value from procedures 12:50:23 <andythenorth> I have been doing huge look up tables 12:50:27 <andythenorth> 1: return 1; 12:50:27 <andythenorth> etc 12:53:45 <DorpsGek> [OpenTTD/master-server] TrueBrain opened pull request #40: Fix: do not list non-public servers or servers that cannot be reached https://git.io/JcxNN 12:53:55 <DorpsGek> [OpenTTD/master-server] TrueBrain opened pull request #41: Fix: move "server_id" key in API to server-level https://git.io/JcxNh 12:55:05 <Samu> hey glx, i'd like to try your script list save load, but i dont know how to access your branch 12:56:00 <DorpsGek> [OpenTTD/master-server] TrueBrain updated pull request #41: Fix: move "server_id" key in API to server-level https://git.io/JcxNh 12:56:13 <DorpsGek> [OpenTTD/master-server] TrueBrain updated pull request #40: Fix: do not list non-public servers or servers that cannot be reached https://git.io/JcxNN 12:58:41 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain opened pull request #9: Add: also indicate what connection-type a server has https://git.io/JcxAj 12:58:44 <DorpsGek> [OpenTTD/master-server-web] TrueBrain opened pull request #31: Fix: "server_id" is now at server-level (instead of ip-level) https://git.io/Jcxxe 12:58:49 <TrueBrain> you got to love having to work in 3 repos .. 12:59:08 <andythenorth> oof 12:59:11 <DorpsGek> [OpenTTD/master-server] TrueBrain merged pull request #40: Fix: do not list non-public servers or servers that cannot be reached https://git.io/JcxNN 12:59:21 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #9418: Codechange: Don't explicitly unset _generating_world outside of genworld.cpp https://git.io/Jc96s 12:59:54 <DorpsGek> [OpenTTD/master-server] TrueBrain updated pull request #41: Fix: move "server_id" key in API to server-level https://git.io/JcxNh 13:00:21 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #9: Add: also indicate what connection-type a server has https://git.io/JcxAj 13:00:42 <Samu> github-desktop added some remotes 13:00:51 <Samu> i dont know how to do that again 13:00:57 <glx> "git fetch https://github.com/glx22/openttd.git script_list_save:<the_name_you_want_locally>" then "git checkout the_name_you_want_locally" 13:01:14 <glx> no need to add remotes :) 13:05:09 <Samu> that's not with github desktop, but k, let me try 13:05:59 <glx> github desktop gets better, but it still miss the non typical git usage ;) 13:06:29 <glx> and probably won't never handle it, because it's not useful for most 13:07:33 <andythenorth> 256 ticks is how many game days? :) 13:08:02 <LordAro> @calc 256/74 13:08:02 <DorpsGek> LordAro: 3.4594594594594597 13:08:28 <andythenorth> 256 / 74 gives me what I need thanks :) 13:08:38 <andythenorth> @calc 27 * (256/74) 13:08:38 <DorpsGek> andythenorth: 93.40540540540542 13:08:42 <DorpsGek> [OpenTTD/master-server] TrueBrain merged pull request #41: Fix: move "server_id" key in API to server-level https://git.io/JcxNh 13:08:43 <Samu> didn't work 13:08:45 <DorpsGek> [OpenTTD/master-server-web] TrueBrain merged pull request #31: Fix: "server_id" is now at server-level (instead of ip-level) https://git.io/Jcxxe 13:08:52 <Samu> bash: syntax error near unexpected token `newline' 13:09:15 <Samu> git fetch https//github.com/glx22/openttd.git script_list_save:<saveloadscriptlist> 13:09:22 <LordAro> Samu: you're not supposed to put the <> 13:09:31 <Samu> oh, my bad then 13:09:46 <peter1138> Heh 13:10:17 <Samu> fatal: 'https//github.com/glx22/openttd.git' does not appear to be a git repository 13:11:19 <glx> missing : 13:11:30 <glx> it's https:// 13:11:39 <Samu> oh, damn im bad 13:13:00 <Samu> awesome, thx, im in 13:14:02 <LordAro> i'd suggest that you should actually work out how to use github desktop, but honestly you're no worse than half of my colleagues 13:18:01 <Samu> it's saving a string with name GSList, but it's an AI 13:29:29 <Samu> failed to load 13:29:55 <Samu> loaded a string named GSList 13:30:03 <Samu> and failed somehwere in the vm 13:30:19 <Samu> hard to follow the squirrel code 13:31:10 <Samu> it should have saved "AIList", but ended up saving "GSList" 13:34:29 <andythenorth> more industry storage anyone? 13:34:35 <andythenorth> @calc 27 * 8 13:34:35 <DorpsGek> andythenorth: 216 13:34:38 <andythenorth> hmm 13:34:45 <andythenorth> I won't be tracking delivery for 8 different cargos then :P 13:34:52 <andythenorth> only 256 registers, and I want some spare 13:34:54 <glx> TrueBrain: https://gist.github.com/glx22/d919fd83acea80a63624ad2e17fc9ca3 13:36:59 <glx> Samu: weird, it should detect the right type when saving (but I only tested with GS) 13:39:30 <Samu> SQ_OK is 0 13:39:43 <Samu> SQ_TRUE is 1 13:39:53 <Samu> SQTrue 13:39:55 <Samu> 0 != 1 13:43:37 <glx> try if (SQ_FAILED(sq_get(vm, -2))) { 13:46:19 <Samu> nice, it saved as AIList 13:46:58 <Samu> i wonder if this would also work with AITileList too 13:47:32 <glx> every list is a subclass of AIList, so yes :) 13:47:43 <glx> my test was using a GSTownList 13:56:41 <Samu> very cool 14:07:32 <Samu> what an awesome job glx, PR it :p 14:17:06 <Samu> i wonder how many ops will this take in actual saving 14:31:20 <Samu> will i be able to, for example used tile_list.AddRectangle(top, bot) after loading a list that was an AITileList? 14:31:25 <Samu> use* 14:31:26 <TrueBrain> glx: there is SLE_STR and SLE_SSTR for strings 14:31:58 <TrueBrain> so annoying that it stores the length as a SLE_UINT8 14:32:00 <TrueBrain> as that uses a gamma :P 14:32:22 <glx> main issue is array, can contain any type 14:32:33 <TrueBrain> meh 14:32:49 <glx> table is just a list of key and value (of any type of course) 14:33:28 <TrueBrain> guess a way out could be to store a list as a table 14:33:31 <TrueBrain> with the key as index 14:33:43 <TrueBrain> but it is a bit of a hack ;) 14:33:58 <TrueBrain> probable not worth the effort at all 14:34:33 <glx> I counl just add my gist to savegame_format.md :) 14:34:55 <glx> for future reference 14:35:13 <DorpsGek> [OpenTTD/master-server] TrueBrain created new tag: 1.2.0 https://git.io/JcpOA 14:35:32 <DorpsGek> [OpenTTD/master-server-web] TrueBrain created new tag: 1.1.1 https://git.io/Jcp3J 14:35:38 <TrueBrain> glx: sounds like a plan ;) 14:36:07 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain created new tag: 0.1.2 https://git.io/Jcp3s 14:36:16 <TrueBrain> right .. I think I am ready to flip the switch now 14:40:52 <Eddi|zuHause> you always find the error right after flipping the switch :p 14:43:15 <Rubidium> the script saving would probably require a recursive type declaration with optional stuff like vehicles to get to the different sub types, so it might be easier to convert to json or so and save that as string 14:47:07 <TrueBrain> here goes nothing! 14:47:08 <Rubidium> TrueBrain: I fear I'm not of much use for that decision ;( I have no clue of redis or most of the libraries used by the master server 14:47:29 <TrueBrain> it is just Python! 14:50:34 <Samu> i just added 4096x4096 tiles to an AITileList and saved 14:50:39 <Samu> took long 14:50:53 <Samu> prone to abuses 14:50:55 <Samu> t.t 14:51:18 <glx> yeah so it's wise to not allow saving ScriptList 14:51:34 <Samu> :( 14:52:15 <andythenorth> lol 14:52:29 * andythenorth spent 20 minutes wondering why cargo was disappearing when delivered 14:52:37 <andythenorth> but vehicles delivering didn't have full load order :P 14:52:38 <andythenorth> ha ha 14:52:44 <glx> can you tell the savegame size Samu ? 14:53:28 <TrueBrain> lol, and indeed, the master-server is crashing ... ofc one thing that I did not test :D 14:53:29 <TrueBrain> lol 14:54:29 <Samu> 135 MB, but im using lzo 14:55:16 <glx> not too bad 14:55:23 <glx> could be worse 14:55:28 <Samu> seems a lot 14:57:27 <Samu> also found a bug 14:57:59 <Samu> https://i.imgur.com/u3gAsqU.png 14:58:12 <Samu> it doesn't recognize it as an AITileList 14:58:31 <glx> 16M TileIndex * 5 (type + uint64) + 16M values * 5 (type + uint64) + extra stuff 14:58:45 <glx> yes on load it creates an AIList 14:59:44 <Samu> damn :( 15:01:25 <DorpsGek> [OpenTTD/master-server] TrueBrain opened pull request #42: Fix: NewGRF md5sum could not be converted to JSON, crashing the insta… https://git.io/Jcpnw 15:03:15 <DorpsGek> [OpenTTD/master-server] TrueBrain merged pull request #42: Fix: NewGRF md5sum could not be converted to JSON, crashing the instances https://git.io/Jcpnw 15:03:54 <DorpsGek> [OpenTTD/master-server] TrueBrain created new tag: 1.2.1 https://git.io/Jcpck 15:04:05 <DorpsGek> [OpenTTD/py-protocol] TrueBrain opened pull request #2: Fix: store NewGRF md5sum as hex-strings instead of bytes-string https://git.io/JcpcI 15:04:26 <Samu> using default savegame format 15:04:56 <Samu> i get 22,905 KB with no AI running 15:04:57 <DorpsGek> [OpenTTD/py-protocol] TrueBrain merged pull request #2: Fix: store NewGRF md5sum as hex-strings instead of bytes-string https://git.io/JcpcI 15:05:17 <DorpsGek> [OpenTTD/py-protocol] TrueBrain created new tag: 0.1.2 https://git.io/Jcpcc 15:05:18 <Samu> and 27,269 KB with AI running and saving whole map tiles 15:05:25 <Samu> as a list 15:06:18 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain opened pull request #10: Fix: bump openttd-protocol to fix a crash when a server has NewGRFs https://git.io/Jcpc2 15:08:59 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #10: Fix: bump openttd-protocol to fix a crash when a server has NewGRFs https://git.io/Jcpc2 15:09:19 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain created new tag: 0.1.3 https://git.io/JcpCJ 15:15:46 <DorpsGek> [OpenTTD/py-protocol] TrueBrain opened pull request #3: Fix: use the same naming for the NewGRF-list as master-server https://git.io/JcpCj 15:15:55 <TrueBrain> MOAR BUGS! :D 15:17:57 <DorpsGek> [OpenTTD/py-protocol] TrueBrain merged pull request #3: Fix: use the same naming for the NewGRF-list as master-server https://git.io/JcpCj 15:18:16 <DorpsGek> [OpenTTD/py-protocol] TrueBrain created new tag: 0.1.3 https://git.io/JcpWz 15:19:35 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain opened pull request #11: Fix: bump openttd-protocol to fix an incompatibility with the master-server JSON data https://git.io/JcpWX 15:20:41 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #11: Fix: bump openttd-protocol to fix an incompatibility with the master-server JSON data https://git.io/JcpWX 15:21:04 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain created new tag: 0.1.4 https://git.io/Jcplf 15:21:09 <TrueBrain> right, that should be it for now 15:21:23 <LordAro> "should" 15:21:29 <peter1138> Best way to find bugs... make it live. 15:21:33 <TrueBrain> I cannot look in the future, no :P 15:21:44 <TrueBrain> peter1138: hehe, yup! We have many servers that do odd things :) 15:21:52 <TrueBrain> all within specs .. just .. impossible to find those during testing :D 15:22:20 <TrueBrain> I really need to find a way that after a GameCoordinator disconnect, a server doesn't immediately reconnect .. 15:22:34 <TrueBrain> it should slowly backoff in case of disconnects .. till it is stable again for a while 15:22:46 <TrueBrain> guess I should not reset backoff to 1, but divide it by 2 till it reaches 1 again or something 15:23:37 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #9425: Doc: explain the binary structure of scripts custom data https://git.io/Jcpl4 15:28:10 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #9425: Doc: explain the binary structure of scripts custom data https://git.io/Jcpl4 15:31:41 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9425: Doc: explain the binary structure of scripts custom data https://git.io/Jcp8D 15:31:45 <TrueBrain> sorry, but you triggered my OCD a lot :P 15:33:45 <andythenorth> I bet there's an OBIWAN in my new FIRS code 15:34:48 <andythenorth> it's adorable that the industry debug window doesn't update very reliably 15:34:56 <andythenorth> I guess there are good reasons :) 15:39:10 *** jottyfan has joined #openttd 15:39:28 <andythenorth> kind of OBIWAN that probably doesn't matter 15:46:20 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #9425: Doc: explain the binary structure of scripts custom data https://git.io/Jcpl4 15:47:11 <glx> oups I missed an occurence 15:47:44 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #9425: Doc: explain the binary structure of scripts custom data https://git.io/Jcpl4 15:48:13 <TrueBrain> and a comment :P 15:48:36 <TrueBrain> and SQSL_TABLE at the last line btw :D 15:49:19 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9425: Doc: explain the binary structure of scripts custom data https://git.io/Jcp0r 15:49:22 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #9425: Doc: explain the binary structure of scripts custom data https://git.io/Jcpl4 15:50:53 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #9425: Doc: explain the binary structure of scripts custom data https://git.io/Jcpl4 15:52:20 <glx> cancelled useless ci runs 15:52:27 <TrueBrain> :) 15:52:37 <TrueBrain> and I think you missed my last comment from the last review I did? 15:52:54 <TrueBrain> everywhere in this document it says "0 - <name>" and you picked "<name> (0)" :D 15:53:31 <glx> oh right 15:55:24 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #9425: Doc: explain the binary structure of scripts custom data https://git.io/Jcpl4 15:56:04 <TrueBrain> can I nitpick that the others do `0` ? I am fine with how it is, it is really nitpicking :) 15:56:40 <glx> let's do like others then :) 15:56:44 <TrueBrain> <3 15:57:37 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened pull request #9426: Doc: Add appstore links to README https://git.io/JcpuK 15:57:45 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #9425: Doc: explain the binary structure of scripts custom data https://git.io/Jcpl4 15:58:04 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #9425: Doc: explain the binary structure of scripts custom data https://git.io/JcpuD 15:58:26 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #9426: Doc: Add appstore links to README https://git.io/JcpuN 15:59:35 <glx> and microsof store ? 15:59:41 <TrueBrain> owh, I forgot about that 15:59:43 <TrueBrain> good point 16:00:04 <TrueBrain> do you tell 2TallTyler about it? 16:00:39 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9411: Replace master-server (UDP-based) with Game Coordinator (TCP-based) https://git.io/JcgaE 16:02:04 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #9411: Replace master-server (UDP-based) with Game Coordinator (TCP-based) https://git.io/Jcpz4 16:03:55 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #9426: Doc: Add appstore links to README https://git.io/Jcpzy 16:06:33 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler dismissed a review for pull request #9426: Doc: Add appstore links to README https://git.io/JcpuN 16:06:36 <glx> oh noticed typos in my doc 16:06:37 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #9426: Doc: Add appstore links to README https://git.io/JcpuK 16:06:57 *** Gustavo6046 has quit IRC 16:07:47 *** snail_UES_ has joined #openttd 16:07:48 <DorpsGek> [OpenTTD/OpenTTD] glx22 dismissed a review for pull request #9425: Doc: explain the binary structure of scripts custom data https://git.io/JcpuD 16:07:51 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #9425: Doc: explain the binary structure of scripts custom data https://git.io/Jcpl4 16:08:02 <glx> I really hate doing docs 16:09:26 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #9425: Doc: explain the binary structure of scripts custom data https://git.io/Jcpgw 16:09:54 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #9426: Doc: Add appstore links to README https://git.io/Jcpg1 16:09:57 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #9426: Doc: Add appstore links to README https://git.io/JcpgM 16:10:11 *** Gustavo6046 has joined #openttd 16:13:07 <glx> TrueBrain: you won't believe it, found 2 more typos SQLS_ARRAY_TABLE_END when it should be SQSL_ARRAY_TABLE_END 16:15:01 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler dismissed a review for pull request #9426: Doc: Add appstore links to README https://git.io/JcpgM 16:15:04 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #9426: Doc: Add appstore links to README https://git.io/JcpuK 16:15:26 *** Gustavo6046_ has joined #openttd 16:16:31 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #9426: Doc: Add appstore links to README https://git.io/Jcp2F 16:18:17 *** Gustavo6046 has quit IRC 16:18:17 *** Gustavo6046_ is now known as Gustavo6046 16:18:27 <DorpsGek> [OpenTTD/OpenTTD] glx22 dismissed a review for pull request #9425: Doc: explain the binary structure of scripts custom data https://git.io/Jcpgw 16:18:28 *** Wormnest has joined #openttd 16:18:30 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #9425: Doc: explain the binary structure of scripts custom data https://git.io/Jcpl4 16:20:24 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #9425: Doc: explain the binary structure of scripts custom data https://git.io/JcpaD 16:20:48 <TrueBrain> No worries I just keep pressing approve ;) 16:22:38 <Samu> do you guys want a 5000 road vehicles, 5000 ships, 5000 aircraft.sav? 16:22:49 <Samu> ai doesn't make trains 16:23:17 <glx> could be fun to parse for headers :) 16:24:04 <glx> but probably not needed 16:24:33 <Samu> one day, I will try trains 16:25:22 <Samu> and once I do, i will run 15 AIs, hoping that all get 5000 all vehicle types 16:25:27 <Samu> muahahaha 16:26:52 <glx> https://github.com/OpenTTD/OpenTTD/actions/runs/1018280095 <-- looks like cancel runs are not fully cancelled ;) 16:28:01 <glx> ah finally found a runner 16:34:42 <DorpsGek> [OpenTTD/OpenTTD] J0anJosep updated pull request #8480: Feature: Extended depots https://git.io/JL5Hh 16:37:49 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #9426: Doc: Add appstore links to README https://git.io/JcpuK 16:38:31 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #9425: Doc: explain the binary structure of scripts custom data https://git.io/Jcpl4 16:44:00 * andythenorth fell asleep 16:44:03 * andythenorth woke up 16:45:06 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #9411: Replace master-server (UDP-based) with Game Coordinator (TCP-based) https://git.io/Jcp6T 16:52:05 <DorpsGek> [OpenTTD/team] glx22 commented on issue #233: [cs_CZ] Translator access request https://git.io/Jcxb2 16:59:01 <glx> TrueBrain: just reading through all the merged ms/gc PR, I see many magic numbers ;) 16:59:55 <TrueBrain> glx: there should only be 2, with comments 17:00:03 <TrueBrain> but feel free to comment in any PR, I will pick them up 17:00:50 <TrueBrain> I am not pushing through the PRs to bypass reviews .. but rather to keep some fun on my side doing this stuff ;) 17:02:27 <DorpsGek> [OpenTTD/master-server] glx22 commented on pull request #40: Fix: do not list non-public servers or servers that cannot be reached https://git.io/JcpPQ 17:05:57 <TrueBrain> your and mine definition of "magic number" is pretty different glx :P In all these cases there is a clear comment next to it stating what the value is 17:06:31 <glx> yes there's a comment but with an explicit name you don't have to comment on every usage 17:06:31 <TrueBrain> sure, I can make a variable doing the same, but that is a bit bikeshedding at that point :P In reality master-server should be ported to use py-protocol .. but .. master-server is going to die off slowly anyway, so I didn't want to spend time on that yet :D 17:06:44 <TrueBrain> there is a balance here in effort vs reward ;) 17:08:04 <TrueBrain> but, if anyone feels up for porting master-server to py-protocol, I am not stopping you :D :D :D 17:13:43 <TrueBrain> (and to be clear, otherwise I will get to it some day, but first I am going to focus on STUN stuff :P ) 17:17:50 *** jottyfan has quit IRC 17:29:19 <DorpsGek> [OpenTTD/master-server] TrueBrain opened issue #43: Switch to openttd-protocol https://git.io/JcpDF 17:29:24 <DorpsGek> [OpenTTD/nml] andythenorth commented on issue #221: Support industry cargo subtype display without waiting amount https://git.io/JZ38r 17:30:08 <DorpsGek> [OpenTTD/master-server] TrueBrain commented on pull request #40: Fix: do not list non-public servers or servers that cannot be reached https://git.io/Jcpyk 17:32:03 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9411: Replace master-server (UDP-based) with Game Coordinator (TCP-based) https://git.io/JcgaE 17:33:07 <TrueBrain> @calc 300000 / 5 / 60 17:33:07 <DorpsGek> TrueBrain: 1000 17:33:21 <TrueBrain> 1 KB/s communication with redis .. that is not bad 17:33:25 *** snail_UES_ has quit IRC 17:33:27 <TrueBrain> owh, sorry, I should have looked into my DHCP settings 17:33:34 *** yeoldetoast has quit IRC 17:33:37 <TrueBrain> I miss frosch .. what have we done with him? :) 17:35:19 <andythenorth> newgrf feature requests probably :( 17:37:19 <TrueBrain> @calc 3600 * 24 * 30 17:37:19 <DorpsGek> TrueBrain: 2592000 17:37:44 <TrueBrain> 3GB of traffic to redis per month .. we can handle that bill :P 17:40:34 <Samu> man, the vehicle being named after the group name, is bad 17:40:59 <Samu> don't even know now if it's a ship or road vehicle 17:41:07 <Samu> when it shows up in the log 17:41:34 <glx> it's a setting I think 17:42:01 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #9411: Replace master-server (UDP-based) with Game Coordinator (TCP-based) https://git.io/Jcp9k 17:42:27 <TrueBrain> :o 17:45:37 <Samu> nah, it's not 17:45:51 <TrueBrain> glx: would you be able to test #9411 with IPv6 and port forwarding by any chance? 17:46:16 <TrueBrain> I think it doesn't work, but I am not sure ... 17:46:31 <glx> I can try 17:46:40 <TrueBrain> if you wouldn't mind, that would be appreciated :) 17:50:41 <glx> seems a changed file caused a lot of recompile :) 17:50:53 <TrueBrain> yeah..... 17:52:19 <glx> dinner time, will try after 17:52:47 <TrueBrain> k, enjoy! 17:57:19 *** snail_UES_ has joined #openttd 18:01:48 *** tokai has joined #openttd 18:01:48 *** ChanServ sets mode: +v tokai 18:05:46 <TrueBrain> okay .. finally figured out why I couldn't upgrade the Network Load Balancers on AWS .. 18:05:52 <TrueBrain> we were running nginx 1.16 18:05:55 <TrueBrain> it wants to upgrade to 1.20 18:06:03 <TrueBrain> but it doesn't accept my config 18:08:40 *** tokai|noir has quit IRC 18:16:56 <TrueBrain> right, lets merge this PR .. I can fix the infra after .. it is a nightly after all :) 18:17:11 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain merged pull request #9411: Replace master-server (UDP-based) with Game Coordinator (TCP-based) https://git.io/JcgaE 18:17:21 <TrueBrain> tnx a lot Rubidium , much appreciated this review :) Now up to the smaller stuff to add to this :) 18:18:16 *** jottyfan has joined #openttd 18:28:52 *** Flygon has quit IRC 18:50:05 <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://git.io/JcpNQ 18:50:06 <DorpsGek> - Update: Translations from eints (by translators) 18:50:17 <peter1138> TrueBrain, but all the third party tooling that need to be rewritten! 18:50:28 <TrueBrain> yup 18:50:41 <TrueBrain> :D 18:57:39 *** supermop_Home has joined #openttd 18:58:30 <supermop_Home> helllo 19:07:01 <glx> and now I just remember I don't have port forwarding on IPv6, it's just open/closed direct access 19:21:46 <glx> TrueBrain: closed or open ipv6, same result "Remote players can't connect", and I'm listening on IPv4 too (port forwarded) 19:21:58 <TrueBrain> IPv4 does work? 19:22:14 <TrueBrain> you can force IPv4 only by setting server-bind-addresses 19:22:15 <glx> no, but maybe I should check windows firewall :) 19:22:28 <TrueBrain> IPv4 should really work, I think .. I do expect IPv6 to fail 19:25:46 <andythenorth> ooops 19:25:47 <andythenorth> "Error: (IndexError) "pop from empty list"." 19:26:21 <glx> hmm nml bug, it should give a sensible message 19:26:31 <glx> open a report :) 19:26:39 <andythenorth> I've found the cause 19:26:53 <andythenorth> [foo1, foo2, foo3,] 19:27:00 <andythenorth> switch expression 19:27:22 <andythenorth> extra comma due to templating loop not catching it 19:27:30 <glx> ah parsing should fail in this case, it's still a compiler bug 19:28:36 <glx> TrueBrain: ok forced IPv4, not joinable (but I still have to check windows firewall) 19:28:38 <andythenorth> hmm I might be wrong 19:28:50 <andythenorth> I've fixed the templating to drop the last comma 19:28:56 <andythenorth> error persists 19:29:42 <glx> report, with the trace, or steps to reproduce :) 19:30:14 <andythenorth> doing a gist 19:32:39 *** HerzogDeXtEr has joined #openttd 19:32:40 <andythenorth> fails https://gist.github.com/andythenorth/29ff267d5ed9b4532e6f4a4155adbc1a#file-gistfile1-txt-L7163 19:32:44 <andythenorth> doesn't fail 19:32:45 <andythenorth> https://gist.github.com/andythenorth/be4263d1bd6dafb6c4551b44fcdb0949 19:33:04 <andythenorth> only difference is a trailing "," or ",0" in the end of the expression 19:33:35 <glx> windows firewall fully open for openttd, same result 19:33:36 <andythenorth> https://gist.github.com/andythenorth/be4263d1bd6dafb6c4551b44fcdb0949#file-gistfile1-txt-L7163 better link for second example 19:33:56 <andythenorth> around L7201 shows the difference 19:34:53 <TrueBrain> glx: can you try 1.11.2, see if that works? 19:35:03 <TrueBrain> just to rule out local error? 19:39:26 <glx> 1.11.2 is ok on both IPv4 and IPv6 19:40:52 <DorpsGek> [OpenTTD/py-protocol] TrueBrain opened pull request #4: Fix: rename packets based on latest naming schema https://git.io/Jchvw 19:40:56 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain opened pull request #12: Fix: rename packets based on latest naming schema https://git.io/Jchvr 19:41:05 <TrueBrain> glx: k, tnx .. I have some incoming code that might help 19:41:39 <DorpsGek> [OpenTTD/py-protocol] TrueBrain merged pull request #4: Fix: rename packets based on latest naming schema https://git.io/Jchvw 19:41:59 <DorpsGek> [OpenTTD/py-protocol] TrueBrain opened pull request #5: Add: extra hook to call when connection is created https://git.io/JchvX 19:43:04 <DorpsGek> [OpenTTD/py-protocol] TrueBrain merged pull request #5: Add: extra hook to call when connection is created https://git.io/JchvX 19:43:30 <DorpsGek> [OpenTTD/py-protocol] TrueBrain opened pull request #6: Feature: a beginning for support of the game-protocol https://git.io/Jchvj 19:43:32 <TrueBrain> spam spam spam spam spammmmm 19:44:20 <DorpsGek> [OpenTTD/py-protocol] TrueBrain merged pull request #6: Feature: a beginning for support of the game-protocol https://git.io/Jchvj 19:44:41 <DorpsGek> [OpenTTD/py-protocol] TrueBrain created new tag: 0.2.0 https://git.io/Jchfc 19:45:28 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain updated pull request #12: Fix: rename packets based on latest naming schema https://git.io/Jchvr 19:46:19 <Samu> windows firewall is very picky 19:46:52 <glx> no windows firwall is not the issue here :) 19:47:15 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #12: Fix: rename packets based on latest naming schema https://git.io/Jchvr 19:48:14 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain opened pull request #13: Add: check if a server-port actually is an OpenTTD server https://git.io/JchfX 19:48:38 <glx> andythenorth: if I correctly compare, the difference is one is only doing a succesion of STORE_PERM(), and the other does a final 0 after the STORE_PERM() 19:48:47 <andythenorth> yes 19:49:01 <andythenorth> simply removing the trailing comma doesn't fix the parse error 19:49:37 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #13: Add: check if a server-port actually is an OpenTTD server https://git.io/JchfX 19:49:46 *** outtatime has quit IRC 19:50:02 *** outtatime has joined #openttd 19:54:18 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain opened pull request #14: Feature: SOCKS proxy support for new connections https://git.io/JchJV 19:54:29 <TrueBrain> okay ... that PR should fix it ... locally it works :P 19:55:18 <glx> ah yes that indeed could explain the issue 19:55:23 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain updated pull request #14: Feature: SOCKS proxy support for new connections https://git.io/JchJV 19:55:39 <TrueBrain> well, outgoing connections via IPv4 shouldn't be an issue 19:56:18 <TrueBrain> so I am not completely sure why that doesn't work from AWS 19:56:24 <TrueBrain> it does work locally ofc, so something is in the way 19:56:28 <TrueBrain> but lets first see what the pproxy does :P 19:56:45 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain merged pull request #14: Feature: SOCKS proxy support for new connections https://git.io/JchJV 19:57:06 <DorpsGek> [OpenTTD/game-coordinator] TrueBrain created new tag: 0.1.5 https://git.io/JchJp 19:58:19 <TrueBrain> so many moving parts .. it now first deploys with SOCKS proxy disabled .. 19:58:27 <TrueBrain> when it is done, I have to send new configuration to AWS 19:58:30 <TrueBrain> so it deploys with SOCKS :P 19:59:18 <glx> just tell me when it's testable :) 20:01:30 <glx> andythenorth: ideally, if you can provide some really small examples to reproduce it will be simpler to debug :) 20:01:56 <andythenorth> maybe we should write an nml test case :P 20:02:11 <DorpsGek> [OpenTTD/aws-infra] TrueBrain pushed 5 commits to main https://git.io/JchUX 20:02:12 <DorpsGek> - Fix: forgot to add the import line in last commit (by TrueBrain) 20:02:13 <DorpsGek> - Add: switch master-server to redis backend (by TrueBrain) 20:02:14 <DorpsGek> - Add: enabled TCP SOCKS proxy on the NLB, next to the UDP SOCKS proxy (by TrueBrain) 20:02:17 <DorpsGek> - Fix: allow rebuilding the NLB EC2 instances (by TrueBrain) 20:02:17 <DorpsGek> - Add: enabled SOCKS proxy for Game Coordinator (by TrueBrain) 20:07:26 *** jottyfan has quit IRC 20:09:32 <TrueBrain> glx: when 20:09:34 <TrueBrain> :P 20:09:40 <TrueBrain> deployment is done, "should work now" :) 20:09:54 <TrueBrain> it might crash and burn ofc 20:10:24 <TrueBrain> its nice with the nightly how fast server-list loads 20:10:31 <TrueBrain> I could make it even faster, but that would stall the UI too 20:13:57 *** sla_ro|master has joined #openttd 20:14:42 <andythenorth> oof stripping FIRS down to 'minimal example' is hard 20:15:12 <andythenorth> maybe nml example industry can be extended 20:18:46 <glx> I see no changes TrueBrain :( 20:19:40 <TrueBrain> hmm 20:19:46 <TrueBrain> just to check, you do forward TCP? 20:20:15 <TrueBrain> (that is the main difference with 1.11, that was UDP-based, if you could advertise or not .. now it is TCP-based) 20:20:16 <glx> tcp and udp 20:20:48 <glx> range 3979-3980 20:22:56 <glx> even with my internal ip in dmz no change 20:23:51 <andythenorth> oh nml tests require black? 20:23:53 <andythenorth> lol 20:24:07 <glx> from root dir yes 20:24:18 <glx> but just run make from regression dir :) 20:30:23 <TrueBrain> glx: found 1 issue in the infra, deploying a fix now .. 20:32:23 <glx> funny, on forced IPv4 I can see openttd listening on IPv4, but it connected to gc via IPv6 :) 20:32:44 <TrueBrain> yeah, I just realised you cannot force the gc connection to be IPv4 20:32:48 <TrueBrain> it just picks what-ever connects fastest 20:32:52 <TrueBrain> okay, IPv4 works now at least 20:32:57 <TrueBrain> I would guess IPv6 too? 20:34:34 <glx> no change for forced IPv4 it seems, let's retry with both 20:34:47 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #9427: Codechange: use the C++ std::getenv over the POSIX/C getenv https://git.io/Jcht6 20:34:52 <TrueBrain> yeah, I realise now that it is a bit odd situation atm 20:35:00 <TrueBrain> if you have dual-stack, hosting on IPv4 doesn't mean it will find IPv4 20:35:08 <TrueBrain> as if you connect to GC on IPv6, it will only try that 20:35:17 <TrueBrain> it is a bit evil .. but that will be fixed soon (tm) 20:35:28 <TrueBrain> there are no nightly servers anyway :P 20:35:39 <glx> issue is the dns resolving ;) 20:35:56 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #9427: Codechange: use the C++ std::getenv over the POSIX/C getenv https://git.io/JchtQ 20:36:07 <TrueBrain> so you can manipulate your hosts file to get either IPv4 or IPv6 20:36:29 <TrueBrain> but if you start with both IPv4 and IPv6 enabled, it is likely IPv6 will be picked 20:36:37 <TrueBrain> so testing that would already help me a lot :) 20:36:38 <glx> ipv6: connection type public 20:36:46 <TrueBrain> sweet 20:36:49 <TrueBrain> okay, so SOCKS works :) 20:37:22 <DorpsGek> [OpenTTD/aws-infra] TrueBrain pushed 1 commits to main https://git.io/Jchqk 20:37:23 <DorpsGek> - Fix: allow TCP SOCKS traffic into the NLB from ECS (by TrueBrain) 20:37:56 <glx> and connection to gc doesn't close 20:38:06 <andythenorth> glx (no rush I can see you're busy) I started adding an example for list of STORE_PERM, but I broke the tests with this https://github.com/andythenorth/nml/commit/02588eb711b030f35da9029c337268985b27714a 20:38:51 <andythenorth> nmlc 0.5.3.post20210701+g840613e.m 20:38:55 <TrueBrain> glx: it stays open for the length you run a server, yes 20:39:07 <TrueBrain> not sure you expected it to close or it was just an observation, but that is expected behaviour :) 20:39:20 <glx> was my guess :) 20:39:24 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain opened pull request #9428: Feature: raise the maximum NewGRF limit to 255 https://git.io/Jchq0 20:39:37 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #9429: Feature: allow setting (game) coordinator and content server connection strings using environment variables https://git.io/Jchqz 20:41:04 <TrueBrain> <3 Rubidium 20:41:05 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #9429: Feature: allow setting (game) coordinator and content server connection strings using environment variables https://git.io/JchqX 20:42:11 <TrueBrain> now to find a way to test #9428 ... eeeuuuhhhh 20:42:14 <TrueBrain> lot of clicking? 20:43:19 <glx> modifying hosts on windows is a pain, it's well hidden 20:43:26 <glx> (I know where it is) 20:43:38 <TrueBrain> I have it as favorite :P 20:44:38 <andythenorth> ha I misunderstood the nml tests 20:44:57 <glx> I hate you windows, I forgot to open it as admin 20:45:59 <TrueBrain> "is not loaded as the maximum number of file slots has been reached" 20:46:04 <TrueBrain> WHAT IS THIS!? 20:46:30 <andythenorth> so I have to write nfo for the test? oof 20:46:57 *** sla_ro|master has quit IRC 20:47:16 <glx> ok IPv4 "forced" in host, still public 20:47:57 <glx> so it works but not on both at the same time 20:48:25 <TrueBrain> glx: that I told you already, yes :) 20:48:31 <TrueBrain> tnx, good to know IPv6 works .. that I cannot test easily :P 20:48:52 <glx> and if I remove in hosts and reenable IPv6 firewall, I should be doomed 20:52:21 <Rubidium> TrueBrain: how many were loaded at that time? 255 maybe? 20:52:28 <TrueBrain> I really do not know 20:52:33 <TrueBrain> I just added every GRF I had 20:52:41 <TrueBrain> but some I couldn't add because of duplicated IDs 20:53:25 <TrueBrain> 209 20:53:29 <TrueBrain> is the answer 20:53:37 <TrueBrain> so the file-limit is reached before the NewGRF limit now 20:53:39 <TrueBrain> interesting :D 20:54:02 <glx> 255 is more than enough :) 20:54:25 <glx> already too many trains in the YETI test game 20:54:46 <Rubidium> there is a MAX_GRF_COUNT which limits it to 128 20:55:27 <TrueBrain> lol 20:55:31 <TrueBrain> is it safe to increase that number? 20:55:49 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #9427: Codechange: use the C++ std::getenv over the POSIX/C getenv https://git.io/Jcht6 20:57:27 <Rubidium> TrueBrain: it should be, at least to 255 20:57:46 *** Samu has quit IRC 20:58:27 <Rubidium> there used to be these Fio slots which limited it, but that's gone now so it's more or less an artificial limit now 20:58:50 <TrueBrain> cool 20:59:06 <glx> andythenorth: nml tests are "compile to nfo, nml and grf", "check nfo and grf output", "compile nml output to nfo and grf", "check nfo and grf output" 20:59:07 <andythenorth> glx the nmlc parse error is just a simple empty expression 20:59:18 <andythenorth> it's not a very helpful error, but eh 20:59:52 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain updated pull request #9428: Feature: raise the maximum NewGRF limit to 255 https://git.io/Jchq0 21:00:08 <glx> so failing compilation doesn't fit in the test setup 21:00:26 <TrueBrain> Rubidium: that works :) 21:01:17 * Rubidium hoped to see the server in the server list on the website 21:01:27 <TrueBrain> I am trying, but .. forwarding ... 21:04:06 <supermop_Home> what are you guys working on? 21:04:49 <TrueBrain> waiting till a cache expires atm 21:04:51 <TrueBrain> it is rather boring 21:04:52 <glx> andythenorth: it compiles fine for me 21:05:29 <TrueBrain> Rubidium: https://cdn.discordapp.com/attachments/337701432230805505/863526328069783562/unknown.png :) 21:05:31 <TrueBrain> BAM 21:05:36 <TrueBrain> it actually works :) 21:05:51 <glx> andythenorth: using nml master 21:06:27 <andythenorth> glx https://github.com/andythenorth/nml/commit/896830267349692cf0c6efc2ff58ee6dfdb6c83d 21:06:41 <andythenorth> parse error for me 21:06:58 <Rubidium> I don't see it in OpenTTD though 21:07:14 <glx> I was testing with https://github.com/andythenorth/nml/commit/02588eb711b030f35da9029c337268985b27714a (doesn't fail) 21:07:18 <TrueBrain> closed the server already, sorry Rubidium :) 21:07:36 <TrueBrain> keeping a port-forward open isn't easy .. but let me try ngrok 21:07:47 <andythenorth> glx yeah that other commit was because I misunderstood tests 21:07:50 <andythenorth> ignore it 21:08:03 <andythenorth> branch parse_error_empty_expression is more useful 21:08:39 <TrueBrain> hmm, no, ngrok is not going to work ofc 21:08:40 <TrueBrain> meh 21:08:57 <TrueBrain> sorry Rubidium , can't really show you :) I had to poke so many holes to get it working ... (read: disable firewalls :P) 21:09:01 <TrueBrain> wasn't planning doing that again :D 21:09:05 <glx> confirmed "pop from empty list" 21:09:21 <glx> but it should be a compile error :) 21:09:38 <andythenorth> +1 21:09:48 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #9429: Feature: allow setting (game) coordinator and content server connection strings using environment variables https://git.io/Jchqz 21:09:53 <andythenorth> I know where the problem is in my templating now 21:09:59 <andythenorth> but it was not easy to see :) 21:10:15 <glx> let's check the parser (I hate reading that part of the code) 21:17:12 *** snail_UES_ has quit IRC 21:17:23 <glx> I suspect something is wrong in https://github.com/OpenTTD/nml/blob/840613eb393eface5026dd15e491051176f6dc3c/nml/parser.py#L337-L341 21:17:39 <glx> returning an empty array feels wrong 21:19:46 <glx> or a missing check in expression.Array() https://github.com/OpenTTD/nml/blob/840613eb393eface5026dd15e491051176f6dc3c/nml/parser.py#L256-L258 21:22:58 * andythenorth always breaking things :) 21:28:15 <glx> ahah I see how it fails, there's a loop to build expr r expr r ... and after the loop the extra r is removed, of course fails on an empty list 21:28:35 <glx> anyway that's the consequence, not the cause 21:28:49 <andythenorth> :) 21:35:59 <glx> nmlc ERROR: ".\example_industry.nml", line 68: Switch-block last parameter 'expression' cannot be an empty array. 21:36:02 <glx> seems better 21:36:26 <andythenorth> :) 21:47:33 <glx> and I running regression test on wsl (just because I can "pip install -e ." from the windows filesystem in wsl) 21:48:09 <glx> simpler than starting mingw 21:52:09 <glx> so nice to be able to run make in the same terminal window as powershell 21:58:35 <DorpsGek> [OpenTTD/nml] glx22 opened pull request #224: Fix: Reject empty arrays as switch expressions https://git.io/JchcC 21:59:50 * andythenorth tests 22:02:41 <DorpsGek> [OpenTTD/nml] andythenorth commented on pull request #224: Fix: Reject empty arrays as switch expressions https://git.io/JchcF 22:03:35 <DorpsGek> [OpenTTD/nml] andythenorth approved pull request #224: Fix: Reject empty arrays as switch expressions https://git.io/Jchcb 22:04:17 <glx> I think I should make parse_expr failsafe too 22:16:04 <DorpsGek> [OpenTTD/nml] glx22 dismissed a review for pull request #224: Fix: Reject empty arrays as switch expressions https://git.io/Jchcb 22:16:07 <DorpsGek> [OpenTTD/nml] glx22 updated pull request #224: Fix: Reject empty arrays as switch expressions https://git.io/JchcC 22:16:42 <glx> this will catch all possible empty arrays (I commented out the switch specific check) 22:16:54 <glx> I think it's a better option 22:18:04 <andythenorth> I should ap/me tests 22:18:37 <glx> of course code is not mergeable as-is 22:20:18 <andythenorth> what was my last line :P 22:20:27 <andythenorth> such nonsense 22:20:29 * andythenorth should sleep 22:20:52 <andythenorth> glx updated PR works as expected 22:20:55 * andythenorth bed :) 22:20:58 *** andythenorth has quit IRC 22:26:25 <DorpsGek> [OpenTTD/nml] glx22 updated pull request #224: Fix: Reject empty arrays as switch expressions https://git.io/JchcC 22:27:27 <DorpsGek> [OpenTTD/nml] glx22 updated pull request #224: Fix: Reject empty arrays as switch expressions https://git.io/JchcC 22:30:09 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on pull request #9428: Feature: raise the maximum NewGRF limit to 255 https://git.io/JchW7 22:31:34 *** Wolf01 has quit IRC 22:33:00 *** nielsm has quit IRC 22:39:13 <TrueBrain> Lol 22:39:34 <glx> had the same reaction, but in emoji 22:41:19 <peter1138> Hmm, shrinking disks in VMware ESXI looks like a pain. 22:42:10 <Eddi|zuHause> raise newgrf limit? what's next? bigger maps? more vehicles? :p 22:42:41 <peter1138> Someone set up a server with 720GB thick provisioned, and it's using about 50GB of it. 22:42:53 <peter1138> Eddi|zuHause, smaller maps. 22:43:13 <Eddi|zuHause> great idea 22:43:28 <Eddi|zuHause> 1x1 maps with no buildable tiles :p 22:43:44 <peter1138> It'll be one giant statement on a single tile. 22:43:47 <peter1138> ... 22:43:54 <peter1138> ... state machine ... 22:44:04 <Eddi|zuHause> it has to be a VOID tile 23:00:03 *** HerzogDeXtEr has quit IRC 23:18:41 *** Progman has quit IRC