Times are UTC Toggle Colours
10:27:08 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #9926: Fix #9925: Industry tile layout validation for layouts of only one tile https://github.com/OpenTTD/OpenTTD/pull/9926#pullrequestreview-1011407006 10:37:24 *** D-HUND is now known as debdog 10:46:23 *** Samu has joined #openttd 10:49:36 *** andythenorth has joined #openttd 10:52:56 *** Etua has joined #openttd 10:56:03 *** Etua has quit IRC 11:01:32 *** andythenorth has quit IRC 11:41:45 *** wallabra has quit IRC 11:44:36 *** andythenorth has joined #openttd 12:03:05 *** Etua has joined #openttd 12:06:13 *** glx has joined #openttd 12:06:13 *** ChanServ sets mode: +v glx 12:08:56 *** andythenorth has quit IRC 12:10:19 <Samu> hi 12:13:31 *** Etua has quit IRC 12:18:16 *** Etua has joined #openttd 12:20:22 *** Etua has quit IRC 12:26:13 <Samu> i found something strange 12:26:31 <Samu> GetQuarterlyExpenses returns negative values, is that intended? 12:27:12 <Samu> -1 is also returned when prerequesites aren't met 12:27:27 <glx> probably (when you sell stuff it's a negative expense) 12:28:21 <Samu> https://docs.openttd.org/gs-api/classGSCompany.html#a604dc4a562685e1dabd9e036e33d85ce 12:31:05 <Samu> -1 can be valid and invalid, isn't that troublesome? 12:31:58 <glx> based on the description it seems it's never negative 12:32:22 <glx> unless some weird stuff happens in the economy 12:34:54 <Samu> the values are stored as negative 12:35:03 <Samu> or 0 12:52:21 <Samu> now I wonder, can expenses ever be positive, that is, > 0 ? 12:52:49 <Samu> how am I fixing this without breaking AIs 12:53:04 <Samu> or GS'es in this case 12:54:43 <glx> operating graph uses the same data, so maybe GetQuarterlyExpenses() miss a '-' 12:56:26 <glx> *operation profit graph 13:03:17 <glx> and for graph it's use as "return c->old_economy[j].income + c->old_economy[j].expenses;" 13:03:28 <glx> so it's supposed to be negative 13:03:59 <peter1138> That was wet. 13:05:22 <glx> anyway script API doesn't say anything about the signedness of the returned value 13:06:44 <glx> and a total of expenses being exactly -1 is probably very improbable 13:09:50 <Samu> it happens, road vehicles with low running costs -1 is common 13:10:58 <glx> but a total of -1 for 3 months ? 13:11:40 <Samu> no, unless you stop the vehicle :p 13:12:34 <glx> and you still have property and loan expenses 13:13:01 <Samu> maybe fix the opposite way 13:13:07 <Samu> make the invalid value = 1 13:14:36 <glx> returning -2 or 0 for the rare expenses == -1 case would be safer 13:17:23 <glx> btw if you know you are following the precondition, then -1 is perfectly valid 13:18:58 <glx> API is fine for me 13:20:38 <glx> and -1 is not an error value, it's a default result 13:22:58 *** felix has joined #openttd 13:27:27 *** andythenorth has joined #openttd 13:35:28 *** andythenorth has quit IRC 13:52:23 *** Tirili has quit IRC 13:54:07 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #9927: Change: GetQuarterlyExpenses now returns the additive inverse of the value https://github.com/OpenTTD/OpenTTD/pull/9927 13:54:34 <Samu> just in case 13:55:54 <Samu> wow commit checker got something 13:57:07 <glx> I still think current code is not an issue 13:59:12 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #9927: Change: GetQuarterlyExpenses now returns the additive inverse of the value https://github.com/OpenTTD/OpenTTD/pull/9927 14:02:12 <glx> oh with https://www.tt-forums.net/viewtopic.php?t=89117 I think it might be possible for GetQuarterlyIncome() to return -1 as valid ;) 14:04:09 <Samu> :( 14:04:20 <Samu> not sure what that is 14:05:00 <Samu> ah, i have to pay for imported cargos? let me test 14:06:08 <glx> some cargoes in IOTC have a negative cargo payment rates, so it's possible revenue total to be exactly -1 14:06:57 <glx> anyway as I said -1 is a valid value if you are sure your arguments when calling the functions meet the conditions 14:13:11 <Samu> wow, that is seriously weird https://i.imgur.com/hcSgsck.png 14:14:36 <Samu> wow, I don't even know what to say... why is it allowed 14:15:15 <Samu> Revenue -£1,420 that's so weird 14:15:31 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on pull request #9927: Change: GetQuarterlyExpenses now returns the additive inverse of the value https://github.com/OpenTTD/OpenTTD/pull/9927#pullrequestreview-1011423211 14:16:14 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #9927: Change: GetQuarterlyExpenses now returns the additive inverse of the value https://github.com/OpenTTD/OpenTTD/pull/9927#pullrequestreview-1011423317 14:18:41 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #9927: Change: GetQuarterlyExpenses now returns the additive inverse of the value https://github.com/OpenTTD/OpenTTD/pull/9927 14:23:54 <Samu> in that case, there needs to be an INVALID_MONEY constant? 14:24:13 <Samu> how would that even work 14:24:43 <glx> not really, if the script ensure it will call with valid parameters it can assume -1 is valid 14:25:00 <Samu> i see 14:28:15 <Samu> im surprised some ais manage that well 14:28:24 <Samu> everybody's transporting mail! 14:28:34 <Samu> no one doing passengers (workers) 14:46:17 <Samu> heh my ai isn't immune to the problem 14:46:36 <Samu> i never expected negative incomes 15:14:41 *** Wormnest has joined #openttd 15:21:54 *** andythenorth has joined #openttd 15:29:56 *** andythenorth has quit IRC 15:47:05 *** andythenorth has joined #openttd 15:55:08 *** andythenorth has quit IRC 16:10:13 *** andythenorth has joined #openttd 16:15:12 <Samu> (quarterly_income + quarterly_expenses) / quarterly_delivered 16:15:20 <Samu> profit per unit delivered? 16:15:31 <FLHerne> TrueBrain: fwiw, ISR does have all the individual tiles in various categories if you don't want to use the magic NxM stations? 16:16:27 <Samu> im trying to come up with more ways to rank companies in a leaderboard 16:18:26 <Samu> NoNoCAB seems to excel at this metric 16:31:13 *** Smedles has quit IRC 16:31:45 *** Smedles has joined #openttd 16:47:51 <andythenorth> grfids for Iron Moose and Iron Ibex? 16:48:27 *** virtualrandomnumber has joined #openttd 16:48:32 <andythenorth> Iron Horse seems to be "CAF" https://github.com/andythenorth/iron-horse/blob/master/src/global_constants.py#L113 16:49:00 *** virtualrandomnumber has quit IRC 16:51:01 <andythenorth> hard to explain how little grfids interest me :P 17:14:21 <andythenorth> Train Whack: The High Score https://media.discordapp.net/attachments/477434889508093952/987767178788999229/unknown.png?width=1660&height=1268 17:38:37 <andythenorth> no grfid suggestions? :P 17:38:53 <andythenorth> ok I just bump them up one from Horse 18:10:59 *** andythenorth has quit IRC 18:22:40 *** Flygon has quit IRC 18:40:36 *** nielsm has joined #openttd 19:13:52 *** felix has quit IRC 19:30:40 *** tokai|noir has joined #openttd 19:30:41 *** ChanServ sets mode: +v tokai|noir 19:37:33 *** tokai has quit IRC 20:02:12 <DorpsGek> [OpenTTD/OpenTTD] nielsmh closed issue #9925: [Bug]: PR #9902 considers all industry tile layouts of only one tile to be invalid https://github.com/OpenTTD/OpenTTD/issues/9925 20:02:15 <DorpsGek> [OpenTTD/OpenTTD] nielsmh merged pull request #9926: Fix #9925: Industry tile layout validation for layouts of only one tile https://github.com/OpenTTD/OpenTTD/pull/9926 20:10:56 *** wallabra has joined #openttd 20:44:58 *** nielsm has quit IRC 21:01:23 <Samu> found a little bug 21:02:47 <Samu> 9th Mau 2004 https://i.imgur.com/UazniCj.png 21:04:40 <Samu> ah, it's May, but the y leg is cut off 21:04:42 <glx> not a bug, font may lie 21:05:41 <glx> R, V, C and o also look weird 21:05:59 <dwfreed> >640x480 21:06:07 <dwfreed> what is this, a picture for ants 21:23:45 *** Smedles has quit IRC 21:23:53 *** Smedles has joined #openttd 22:07:41 *** Samu has quit IRC 22:14:25 *** Joel has joined #openttd 22:22:14 *** sla_ro|master has quit IRC 23:46:52 *** HerzogDeXtEr has quit IRC 23:48:05 *** Joel has quit IRC 23:54:27 *** Joel has joined #openttd 2022-06-19T15:38:2