Times are UTC Toggle Colours
10:32:19 *** birdjj has joined #openttd 10:39:17 <nielsm> make a benchmark! generate a game with a huge number of vehicles and run it for 10 seconds, test both options 10:41:56 <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #9959: Feature: Constantly update destination of 'any depot' orders https://github.com/OpenTTD/OpenTTD/pull/9959#pullrequestreview-1151923677 10:45:46 <Bouke> nielsm: Is this already available somewhere, like hidden command line arguments? If not, we could create such and run it on CI to see perf impact of PRs. 10:46:10 <nielsm> not really no 10:49:36 <nielsm> there is the null renderer which can runs the game for a number of ticks, but it doesn't do any graphics at all, not even composition or requesting sprites (as far as I know) 10:50:49 <TrueBrain> michi_cc[d]: do remember that one of the reason to disable it by default, is that MacOS deprecated OpenGL. They froze the implementation, and is stated to not receive any further updates. I remember that being one of the deciders 🙂 10:53:04 <michi_cc[d]> Yes, but even if the OpenGL lib is not changed anymore, the underlying graphics driver will still get updates, so if everything points to it being a good idea now, I'm not against changing it. 10:53:31 <TrueBrain> Yeah, as said, one of the deciders. I also remember different people reporting vastly different results on MacOS 😄 10:53:37 <TrueBrain> but we lack MacOS users to give that a true value, ofc 10:54:27 <TrueBrain> MacOS was one of those platforms that always used 32bpp anyway, not? 10:58:27 <michi_cc[d]> Yeah, native 8bpp graphic modes aren't supported on the more modern Quartz (they were on the old QuickDraw stuff, but that died with move away from PPC). 10:58:44 <TrueBrain> yeah, okay, so the difference (compared to other platforms) was smaller anyway 10:59:12 <TrueBrain> I am slightly annoyed we didn't write any of this down in the PRs we made 😄 As I know it took a lot of time/effort back then to figure out 🙂 11:07:27 <andythenorth> we have logs... 11:07:41 <TrueBrain> just if only everyone was consistent with MacOS / OSX / Mac OS .. 😛 11:08:04 <andythenorth> stuff and thigns 11:08:06 <TrueBrain> `21:49:52 <andythenorth> we might want to advise mac laptop owners not to turn on hardware acceleration maybe ` 11:08:14 <TrueBrain> there was something with laptops and the GPU and getting REALLY hot 😛 11:08:31 <andythenorth> yes, then it throttles, so perf. dives 11:08:40 <andythenorth> required running it for more than about 2 mins 11:08:54 <TrueBrain> owh, that was a story too not? That your performance was widely different depending how long you were gaming? 🙂 11:09:32 <andythenorth> on specific intel macbooks yes 11:09:51 <TrueBrain> it is funny how I just remember: it was a shitshow 😛 But yeah .. lack of writing down sucks 😄 11:09:53 <andythenorth> showing my privilege here, but can't mac users just get an M1? 😛 11:10:15 *** WormnestAndroid has joined #openttd 11:10:55 <Bouke> Yeah just share your credit card here and we’ll happily oblige! 11:11:16 <andythenorth> ooof 11:12:42 <Bouke> Interestingly enabling HW didn’t trigger my MBP to switch to discrete gfx, it continues to use integrated gfx. 11:13:19 <andythenorth> are you on battery or mains power? 11:14:08 <TrueBrain> `12:30:23 <o*** (avoid HL)> Yes, in a more substantial game, I'm getting 60-70fps ish with OpenGL on Mac, but 70-90fps with Cocoa ` 11:14:12 <Bouke> Tried both. Also fiddled with Energy settings. 11:14:16 <TrueBrain> (sorry, just digging through the logs to avoid regressions :D) 11:15:47 <Bouke> https://cdn.discordapp.com/attachments/1008473233844097104/1033337870817181726/image0.jpg 11:23:38 <TrueBrain> yeah, those are the cases I can find easily in the logs for MacOS: 11:23:39 <TrueBrain> - Runs of more than 2 minutes get a performance hit due to throttling (seems Intel only issue) 11:23:39 <TrueBrain> - More than other OSes, depending on savegame, performance widely differ 11:23:39 <TrueBrain> - Deprecation warning from Apple 11:23:39 <TrueBrain> - Performance gain, compared to other OSes, is lower 11:23:40 <TrueBrain> Hopefully that helps when debating enabling/disabling, to avoid repeating past mistakes 🙂 11:25:30 <andythenorth> https://en.wikipedia.org/wiki/Wikipedia:Chesterton%27s_fence 11:28:06 <TrueBrain> andythenorth: lol; and yeah, now we know (again), we can validate if those points still hold 🙂 11:28:10 <michi_cc[d]> Bouke: We explicitly tell OSX to manage the GPU for us as the default behaviour otherwise would be to just use the discrete GPU for any OpenGL app. For the few OGL stuff OTTD actually does, the integrated GPU is probably a lot more effective regarding power/heating. 11:29:32 <TrueBrain> https://weblogs.openttd.org/openttd/2021/03/09.html#215013-1021 11:29:32 <TrueBrain> `21:50:13 <andythenorth> or we could trick the mac into using the discrete GPU ` 11:29:35 <TrueBrain> 😄 11:30:20 <michi_cc[d]> There should be an OSX app option to use the discrete GPU (at least that is what google suggests). 11:30:25 <andythenorth> nice trip into last year 11:30:30 <TrueBrain> hihi 🙂 11:33:40 <michi_cc[d]> As this discussion only pertains new players anyway, the current state of the world is the most relevant. As soon as you already have a config file, changing our defaults won't matter. And I would definitely not approve of force-changing the setting. 11:34:29 <TrueBrain> hmm, not disagreeing with that stance. I kinda like it even. But how do we figure out what new players use, I wonder? 11:35:06 <TrueBrain> N-2 approach? 😄 11:36:57 *** WormnestAndroid has quit IRC 11:37:03 *** WormnestAndroid has joined #openttd 11:37:05 <michi_cc[d]> If it seems that right now that HW acceleration has better results in contrast to earlier in time, this has to be due to some kind of change on Apples sides as we didn't do any. And I'm assuming most users keep somewhat up on OS updates. 11:37:24 <TrueBrain> so N-2 approach, that seems fair 🙂 11:37:33 <TrueBrain> I suggest we check the boxes of the above points I gave, ignoring the 3rd 11:38:01 <TrueBrain> the logs suggest that the integrated GPU didn't actually give any performance boost; so if that has changed, that would be nice ofc 11:38:06 <petern> Afternoon. Should I buy a Mac to test with? 11:38:19 <TrueBrain> but it might be good to validate if intel laptops don't do weird shit 😄 11:38:40 <Bouke> Bouke: This iMac is running Catalina (10.15.7), originally released in late 2019. It's the last major version available for this machine. 11:39:15 <michi_cc[d]> Deprecation is irrelevant unless Apple actively sabotages it. Either it keeps working or if Apple decides to remove it sometime in the future and does not sabotage it, the video driver will just not load and fall back to the non-accelerated anyway. 11:39:31 <TrueBrain> michi_cc[d]: that is why I suggest to ignore the 3rd point 🙂 11:39:51 <michi_cc[d]> That's why reading is hard 🙂 11:40:06 <andythenorth> just going to leave here also....the "tests" are barely science 😛 11:40:17 <TrueBrain> so we check on Intel laptops if the problem still exists that andy describes. And we check several savegames to see if they increase performance, over several different Macs 11:40:59 <TrueBrain> make a nice GitHub Discussion out of it 11:41:07 <TrueBrain> and we can refer to it in the future, in case things change (again) 11:41:31 <michi_cc[d]> Some of the data points came from orudge, but I think he switched over to the M1 andy camp, too. 11:41:50 <TrueBrain> yeah, but I am sure our community can gather enough datapoints to get a feel for the landscape 11:42:03 <TrueBrain> it doesn't have to be 100ths of datapoints, ofc 🙂 11:42:16 <TrueBrain> just a bit more than "but it improves stuff on my machine" would be nice 🙂 11:42:20 <andythenorth> I have 3 different intel macs and 3 different m1 macs I could test on right now 😛 11:42:34 <andythenorth> but I am not sure that is what I want to spend my day on 😛 11:42:52 <andythenorth> can't we rent a cloud mac and run some logged tests, and be done with it? 😛 11:42:56 <TrueBrain> so my suggestion: pick a few savegames, an empty one, a busy one, a NewGRF one, I dunno 11:43:04 <TrueBrain> put them in a Discussion, write some lines in how to measure performance 11:43:17 <andythenorth> one of my 'todo' jobs: sell some old intel macs 11:43:38 <TrueBrain> create a nice table of what Mac it is, what OS it is running, and how it did with HW on and off 11:44:21 <TrueBrain> and yes, we should have done that already a few times over, not only for Mac 😛 11:44:37 <andythenorth> we have benchmarked CI tests at work 11:44:45 <andythenorth> they're not perfect, but they are repeatable and baselined 11:44:50 <andythenorth> which wins out over perfection 11:45:01 <TrueBrain> graphical testing over CI too? 11:45:08 <andythenorth> visual diff 11:45:11 <andythenorth> incredibly useful 11:45:15 <TrueBrain> yeah, but not performance? 11:45:27 <TrueBrain> most CIs I know, don't have GPUs available 😦 11:45:34 <andythenorth> yeah this is a web app 11:45:46 <TrueBrain> yeah, so different metrics 😄 11:45:48 <andythenorth> the tests will be varied, but things like jmeter, and selenium run times 11:46:02 <andythenorth> did we ever script our UI? 😛 11:46:29 <TrueBrain> more than once we started an attempt to do performance metrics over a lot of savegames 11:46:32 <andythenorth> we can load and run a savegame over server admin port? 11:46:38 <TrueBrain> I even have a full collection of savegames to do that on 11:46:49 <TrueBrain> but those are all "how fast does the game run" savegames 11:46:52 <TrueBrain> not "how fast does it render" 😄 11:47:31 <TrueBrain> andythenorth: if you want to do performance metrics of: how long does it take to run 10 gamedays with `-vull`, we have complete scripts for that 11:48:09 <TrueBrain> `time ./openttd -snull -mnull -vnull:ticks=1000 -g<savegame> -x -c empty/empty.cfg` would do 11:48:34 <TrueBrain> but yeah, that only works on a the null driver 11:49:03 <TrueBrain> https://github.com/TrueBrain/OpenTTD-savegames 11:49:03 <TrueBrain> As an example 11:49:33 <TrueBrain> (of a collection) 11:50:15 <TrueBrain> but okay, now the subject changed from GPU benchmarking to game benchmarking 😄 11:55:11 <DorpsGek> [OpenTTD/OpenTTD] J0anJosep updated pull request #8480: Feature: Extended depots https://github.com/OpenTTD/OpenTTD/pull/8480 11:55:16 <DorpsGek> [OpenTTD/OpenTTD] J0anJosep updated pull request #9577: Feature: Multi-tile depots https://github.com/OpenTTD/OpenTTD/pull/9577 11:57:07 <TrueBrain> https://github.com/OpenTTD/OpenTTD/pull/7895 is related to that conversation btw 🙂 12:06:21 <DorpsGek> [OpenTTD/OpenTTD] J0anJosep updated pull request #8480: Feature: Extended depots https://github.com/OpenTTD/OpenTTD/pull/8480 12:06:24 <DorpsGek> [OpenTTD/OpenTTD] J0anJosep updated pull request #9577: Feature: Multi-tile depots https://github.com/OpenTTD/OpenTTD/pull/9577 12:09:11 <Bouke> TrueBrain: This looks nice! What’s needed to use that approach for actual GPU testing? 12:11:10 <petern> Will someone go food shopping for me? 12:12:25 <andythenorth> and me also 12:13:26 <reldred> Who do I have to bribe to get multi tile depots merged? 😎 12:13:41 <petern> You can bribe me with food shopping 😄 12:14:09 <reldred> 🤔 12:14:40 <petern> Although I'm sure TB is removing all my rights right now 12:16:01 <reldred> Sounds like I need to bribe TB then 12:16:50 <TrueBrain> petern: no, that deal is fair 🙂 12:17:22 <TrueBrain> Bouke: Access to actual GPUs, for starters 12:17:49 <michi_cc[d]> petern: Isn't that called online delivery? 12:19:11 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #9959: Feature: Constantly update destination of 'any depot' orders https://github.com/OpenTTD/OpenTTD/pull/9959 12:19:49 <TrueBrain> michi_cc[d]: sadly they don't deliver here the same day 😦 12:20:59 <reldred> Same here, Uber eats does limited same day grocery delivery 12:21:04 <DorpsGek> [OpenTTD/OpenTTD] michicc dismissed a review for pull request #10065: Fix #8252: Remove duplicate functionality in `screenshot.cpp` https://github.com/OpenTTD/OpenTTD/pull/10065#pullrequestreview-1143293191 12:21:44 <DorpsGek> [OpenTTD/OpenTTD] michicc commented on pull request #10065: Fix #8252: Remove duplicate functionality in `screenshot.cpp` https://github.com/OpenTTD/OpenTTD/pull/10065#issuecomment-1287776163 12:28:13 <andythenorth> deliveroo will do coop, waitrose etc 12:28:17 <andythenorth> petern: no roo? 😛 12:28:50 <petern> https://cdn.discordapp.com/attachments/1008473233844097104/1033356255529537587/unknown.png 12:28:50 <petern> Damn that pixel... 12:29:11 <andythenorth> ha ha the apostrophe strikes again 12:30:04 <petern> Smart quotes didn't exist in 1995... 12:31:54 <andythenorth> ' 12:31:57 <andythenorth> would have done 12:32:01 <andythenorth> 😛 12:32:41 <petern> https://cdn.discordapp.com/attachments/1008473233844097104/1033357226515103764/unknown.png 12:32:41 <petern> That's the symbol on the BBC Micro... 12:33:39 <petern> (Although it's vertical in MODE 7) 12:39:37 <Bouke> TrueBrain: So each video driver would require such a `:ticks` argument, and we'd `time` the runtime duration? But that only gives the time required to run that amount of ticks (so game speed, right?), how to measure gfx performance? 12:45:17 <Eddi|zuHause> ich finde das ist einer der größten schwachpunkte von ronny, er versteht den sinn von befehlsketten nicht 12:45:22 <Eddi|zuHause> bäh 12:45:25 <Eddi|zuHause> wrong chat 12:57:08 <TrueBrain> Bouke: as there are many factors involved in what influences drawing speed, I do not think it can be done in a similar way. Where we can make game-performance very measurable, as it is fully deterministic, drawing-performance is not. So it stays very subjective, I think 12:57:34 <TrueBrain> having Discord open or not could already have an impact on drawing-performance, for example 12:59:02 <Bouke> So there's no point in doing this, as the results will not be usable? 12:59:28 <JGR> At some point you will need to make a subjective judgement call 12:59:55 <TrueBrain> exactly; it will not be scientific, but it will be sufficient 13:00:28 <TrueBrain> so what people have been doing, eyeballing the FPS window, is, I think, more than sufficient 13:05:23 <TrueBrain> that is why I suggest to just make written instructions, and a few savegames that widely differ 13:06:26 <TrueBrain> but, that is just me. Others might have other ideas here 13:16:18 <andythenorth> it's trying to find pathological cases no, rather than prove x > y? 13:16:26 * andythenorth wavey hands 13:17:17 <andythenorth> our work performance benchmarking is about verifying that we roughly understand the system, or finding things that are "wtf?" 13:18:05 <andythenorth> the actual IRL workloads are extremely variable, so we don't assume that benchmark results correspond to IRL perf 13:20:03 <petern> Wibble 13:21:38 <andythenorth> froth 13:29:20 *** tokai|noir has joined #openttd 13:29:20 *** ChanServ sets mode: +v tokai|noir 13:35:48 <TrueBrain> andythenorth: If only CIs had GPUs 😄 well, there are setups that have that ofc 🙂 but not our CIs 🙂 13:36:19 *** tokai has quit IRC 13:36:24 <TrueBrain> I assume you mostly use it to find regressions? 13:36:50 <andythenorth> we use it to find regressions 13:37:06 <andythenorth> and from time-to-time we compare empirical performance in the live fleet against the benchmarks 13:37:29 <andythenorth> and if we do performance work, it's a verification that making A faster doesn't have side-effect at B 13:37:36 <andythenorth> or at least we know if it does and trade 13:37:57 <TrueBrain> Smart 13:38:20 <andythenorth> these are complex systems, a long way from e.g. me trying to make nml compiles faster 🙂 13:38:40 <andythenorth> so e.g. increasing cache in one layer improves some workloads, but hurts others due to cold-cache 13:38:46 <andythenorth> etc etc 13:38:50 <petern> multithreaded terrain generation? 13:39:09 <TrueBrain> When? 13:39:15 <andythenorth> petern: use voxels 13:39:56 <JGR> Terrain generation is already very fast 13:40:11 <JGR> It's putting stuff on the terrain afterwards which can take a while 13:40:11 <TrueBrain> Never fast enough 😄 13:40:26 <andythenorth> petern: run 4 different terrains, then have a random battle for each tile to see who wins 13:40:44 <andythenorth> competitive terrain gen 13:41:03 <TrueBrain> Hmm .. Still want to make sharding support in OpenTTD, so you can have truly massive maps 😄 13:41:03 <petern> andythenorth: I know that's a stupid suggestion, but it might be an interesting way to get variety 😉 13:41:18 <andythenorth> I know 🙂 13:41:27 <andythenorth> regional terrain 13:41:37 <andythenorth> then just substitute segments 13:41:44 <andythenorth> with some kind of edge blending 13:42:33 <andythenorth> ok, lunch: marmite on toast, cheese on toast, or marmite on cheese on toast 13:42:35 <andythenorth> ? 13:42:51 <TrueBrain> All? 13:42:56 <petern> Map sharding suggests you might need town and industry sharding. And maybe vehicle sharding. 13:43:12 <andythenorth> did I ever mention newgrf sharding? 13:43:13 <petern> 4kx4k is not big enough though I guess. 13:43:13 <TrueBrain> petern: If you truly want to scale, yes 13:43:24 <andythenorth> map regions 13:43:30 <TrueBrain> I wss thinking of an MMO server 13:43:38 <andythenorth> ok marmite then 13:43:40 <andythenorth> no cheese 13:43:42 <TrueBrain> Like 100kx100k 13:43:49 <TrueBrain> Multiple servers 13:44:05 <TrueBrain> But you need to hand over vehicles and viewports somehow 13:44:29 <andythenorth> but all at 256x256 😛 13:44:32 <andythenorth> the correct size 13:44:48 <andythenorth> single player bigger maps are sharded 😛 13:44:50 <petern> Hmm, I wonder, does this -1 mean to 'fix' an off-by-one, or does it mean to move up by 1 pixel... 13:44:57 <andythenorth> can we go shard-per-core? 13:45:50 <petern> How long does it take for one griefer to destroy a 100kx100k map? 13:45:56 <TrueBrain> Haha 13:47:02 <petern> Basically, basing your offsets off step_size, but your starting y position is already +1 scaled pixel, so step_size should be at least -1 scaled pixel. Hmm. 13:47:28 <TrueBrain> Say what now? :p 13:48:41 <petern> I'm being picky & perfectionist 😉 13:49:04 <petern> The -1 comment and the step_size thing are related 13:54:26 <Bouke> Can I pass in-game console commands from say a bash script? Use-case: extract “fps” output using a script. 13:54:47 <TrueBrain> Admin port? 13:55:22 <TrueBrain> There is also console scripting, but it is .. Well, it is. And that is it 😄 13:55:27 <TrueBrain> See script folder 13:56:45 <Bouke> Thanks, will look into that! 13:59:47 <TrueBrain> You can also execute scripts from console 14:00:32 <TrueBrain> What might work is that you preprogramm some scrollto and run fps between them to get a runtime idea of what the fps is of a savegame 14:03:03 <Bouke> So my overall idea here is that I have a bash script that’ll launch ottd with some savegames and predefined config and run the fps command at an interval and aggregate/avg those values. 14:04:12 <nielsm> <TrueBrain> Admin port? <-- admin port only works against a multiplayer server 14:04:23 <TrueBrain> nielsm: Awh 😦 14:04:47 <nielsm> which is why there are many things it's specifically not a solution to 14:04:48 <TrueBrain> Still want to remove the difference between SP and MP .. wish I had more time as resource 😄 14:06:26 <TrueBrain> Bouke: Keep in mind by default the refresh rate is capped, and you cannot enable FWD by scripts 14:06:52 <TrueBrain> The cap can however be disable (or made very large) by config 14:10:59 <andythenorth> full-time OpenTTD when? 😛 14:11:13 <andythenorth> we should have included that coin-miner, then we could rent player CPU time to third parties 14:11:23 *** m3henry has joined #openttd 14:11:44 <andythenorth> how about we do a startup so we can sell it and retire to do OpenTTD? 14:12:07 <petern> OpenTTD-Discord bridge when? 14:12:17 <m3henry> IRC logs fix when? 14:13:13 <petern> https://cdn.discordapp.com/attachments/1008473233844097104/1033382523482423406/unknown.png 14:13:13 <petern> Do I need to scale the "checker" pixels? Hmm 14:17:06 <TrueBrain> andythenorth: Suggestions? 14:17:23 <TrueBrain> m3henry: Don't fix what isn't broken! 14:17:48 <andythenorth> TrueBrain: how about a game about trains? 14:18:09 <TrueBrain> Meh, so 1994 14:18:28 <andythenorth> but on the blockchain 14:18:30 <andythenorth> blocktrain 14:18:35 <TrueBrain> Now we are talking! 14:19:20 <petern> Non Fungible Trains? 14:19:25 <TrueBrain> Haha 14:19:56 *** m3henry_ has joined #openttd 14:20:26 <m3henry_> But it always shows empty 14:20:31 <m3henry_> Seems pretty broken to me 14:21:54 <TrueBrain> m3henry_: Well, we cannot fix things we don't own / host; but what we do works fine, so *shrug* 🙂 14:22:06 <Bouke> TrueBrain: So can I trigger console scripts externally? Or do I have to put a script named “autoexec.scr” in the user’s OTTD folder? 14:22:27 <TrueBrain> (In other words, use weblogs.openttd.org/openttd/ and stop using 3rd party logs :p) 14:23:12 <TrueBrain> Bouke: There are no external triggers as far as I know in SP 14:25:13 *** m3henry has quit IRC 14:26:36 <DorpsGek> [OpenTTD/OpenTTD] krysclarke started discussion #10096: Updating OpenTTD to use liballegro5 https://github.com/OpenTTD/OpenTTD/discussions/10096 14:26:54 *** m3henry_ has quit IRC 14:28:41 *** m3henry has joined #openttd 14:33:23 <TrueBrain> Hmm .. blogs 😄 14:36:54 <petern> Is Allegro used by anyoine? 14:37:47 <m3henry> TrueBrain: Looks like the link on the wiki needs updating to point at that then 14:38:36 <TrueBrain> m3henry: Go for it! 14:42:24 <m3henry> Done, didn't relaise the wiki was open for all to edit 14:44:40 <TrueBrain> What else are wikis good for 😄 cheers! 15:14:22 *** virtualrandomnumber has joined #openttd 15:14:37 *** virtualrandomnumber has quit IRC 16:04:06 <petern> Heh, nobody spoke here while I went shopping 16:05:54 <petern> https://pbs.twimg.com/media/Exa7FWUWQAcsAwJ?format=png&name=large 8-bit graphics are the best 😄 16:06:24 <andythenorth> that is the best 16:06:26 <andythenorth> font also 16:06:36 <andythenorth> container shipping game? 16:07:04 <JustANortherner> Where is the bridge tho? 16:31:44 <petern> Hmm, what happened to the NewGRF y-position thing... 16:32:54 <DorpsGek> [OpenTTD/OpenTTD] Arastais updated pull request #10065: Fix #8252: Remove duplicate functionality in `screenshot.cpp` https://github.com/OpenTTD/OpenTTD/pull/10065 16:33:41 <ag> petern: Very funny 16:42:19 <Bouke> TrueBrain: Alright, I've created draft instructions to kick this off. I invite you all to provide some feedback on this draft before I post the discussion on GitHub. The goal of this discussion would be to make an informed decision on whether to enable hardware acceleration by default. https://gist.github.com/Bouke/482c4f33898cc1dbc198bdbdb5eb6bce 16:58:06 <Bouke> Bouke: I’ll add running latest nightly to the instructions as there’s a crash with 32bpp in 12.2. Also: people should report their gfx base set. 17:07:03 *** Wormnest has joined #openttd 17:09:30 *** esselfe has quit IRC 17:21:49 *** esselfe has joined #openttd 17:34:05 *** gelignite has joined #openttd 17:51:06 <DorpsGek> [OpenTTD/OpenTTD] michicc approved pull request #10065: Fix #8252: Remove duplicate functionality in `screenshot.cpp` https://github.com/OpenTTD/OpenTTD/pull/10065#pullrequestreview-1152087875 18:07:36 *** bryjen has joined #openttd 18:20:08 *** esselfe has quit IRC 18:30:22 <TallTyler> What are everybody’s thoughts on 10058? That’s been talked about for a while but somebody finally did it. 18:33:53 *** esselfe has joined #openttd 18:48:22 <DorpsGek> [OpenTTD/OpenTTD] JGRennison commented on pull request #9959: Feature: Constantly update destination of 'any depot' orders https://github.com/OpenTTD/OpenTTD/pull/9959#pullrequestreview-1152104926 18:51:07 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #10065: Fix #8252: Remove duplicate functionality in `screenshot.cpp` https://github.com/OpenTTD/OpenTTD/pull/10065 18:51:10 <DorpsGek> [OpenTTD/OpenTTD] michicc closed issue #8252: Possible duplication of functionality in `screenshot.cpp` https://github.com/OpenTTD/OpenTTD/issues/8252 18:58:17 <DorpsGek> [OpenTTD/OpenTTD] DorpsGek pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/e7a16f4514275f0feb42d40cc32390882455e7ad 18:58:18 <DorpsGek> - Update: Translations from eints (by translators) 19:26:11 <petern> Fix my code, or watch Lego YouTube? 19:26:26 <andythenorth> yes 19:26:28 <andythenorth> two screens 19:41:24 *** wallabra has joined #openttd 19:42:11 <TrueBrain> TallTyler: My only comments is that I don't like the custom height of the buttons 😄 I don't see why they can't just be normal height .. they look weird now :p 19:44:39 <petern> Oh... agred 19:45:15 <TrueBrain> Bouke: Nice! Much more scientific then I would have done it, so I can only applaud that 😄 tip: make the title read MacOS first, as people will otherwise not read it and you get all kind of OS