Times are UTC Toggle Colours
02:07:17 *** Wormnest has quit IRC 03:00:54 *** D-HUND has joined #openttd 03:04:29 *** D-HUND is now known as debdog 03:13:33 *** Kitrana1 has joined #openttd 03:31:55 *** keikoz has joined #openttd 04:19:17 *** tokai has joined #openttd 04:19:18 *** ChanServ sets mode: +v tokai 04:22:46 *** keikoz has quit IRC 04:34:46 *** keikoz has joined #openttd 05:09:39 *** HerzogDeXtEr has joined #openttd 07:20:54 *** Flygon has joined #openttd 08:55:04 <andythenorth> hmm 08:55:20 <andythenorth> if I track town deliveries per-company (currently it's tracked for all companies) 08:55:38 <andythenorth> the GS could automatically build company statues in happy towns 08:55:45 <andythenorth> shave that yak 08:55:46 *** ufo-piloot_ has joined #openttd 09:00:21 *** ufo-piloot has quit IRC 09:00:21 *** ufo-piloot_ is now known as ufo-piloot 09:17:40 <andythenorth> hmm maybe the industry window should report if the town has a statue for your company 09:24:16 *** gelignite has joined #openttd 09:24:30 <andythenorth> is there a grf var for it? 09:26:32 *** talltyler has joined #openttd 09:26:32 <talltyler> No, but it could be added. There are vars for stadiums and churches 09:27:43 <andythenorth> would need company context 09:29:07 *** Wolf01 has joined #openttd 09:32:10 *** HerzogDeXtEr has quit IRC 09:33:11 *** HerzogDeXtEr has joined #openttd 09:41:38 <talltyler> Ah, that could be a problem. Industry windows don’t have company context. 09:42:19 <talltyler> The town bar could be a bitmask of companies with statutes, but I don’t know what good that would do 🤷 09:45:51 <andythenorth> back to GS then 😛 10:00:57 *** _zephyris has joined #openttd 10:00:57 <_zephyris> Add it to the list... https://github.com/OpenTTD/OpenTTD/discussions/8635 10:08:57 <DorpsGek> [OpenTTD/team] xboxc opened issue #446: [pl_PL] Translator access request https://github.com/OpenTTD/team/issues/446 10:12:59 <DorpsGek> [OpenTTD/OpenTTD] andythenorth commented on discussion #8635: NewGRF Town Spec ideas https://github.com/OpenTTD/OpenTTD/discussions/8635 10:15:33 <DorpsGek> [OpenTTD/team] glx22 commented on issue #446: [pl_PL] Translator access request https://github.com/OpenTTD/team/issues/446 10:32:55 <DorpsGek> [OpenTTD/OpenTTD] michicc updated pull request #11141: Add: [Script] Game script control of industry production level. https://github.com/OpenTTD/OpenTTD/pull/11141 10:41:40 <andythenorth> merge it before it needs rebased again 😛 10:42:47 *** michi_cc[d] has joined #openttd 10:42:47 <michi_cc[d]> Get someone to approve 🙂 10:43:51 <michi_cc[d]> Peter: 1139 You had some reservations on #11186, but I don't see any in-progress PR for CI checks, so I'm tending to merge it to fix the current actual problem. 10:44:26 <michi_cc[d]> Okay, no @ apparently, peter1139 ^^ 10:45:22 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #11231: Fix #11230: Group list widget layout failed, if dropdown widgets were higher than the font height. https://github.com/OpenTTD/OpenTTD/pull/11231 10:45:25 <DorpsGek> [OpenTTD/OpenTTD] michicc closed issue #11230: [Bug]: Sort by button is misaligned with OpenGFX2. https://github.com/OpenTTD/OpenTTD/issues/11230 10:46:28 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #10755: Feature: Setting to disallow level crossings with competitors https://github.com/OpenTTD/OpenTTD/pull/10755 10:46:32 <DorpsGek> [OpenTTD/OpenTTD] michicc closed issue #10311: [Feature request]: Add a setting to prevent crossing tracks with other players roads https://github.com/OpenTTD/OpenTTD/issues/10311 10:46:50 <andythenorth> can someone approve 11141, please thanks 🙂 11:00:00 <Wolf01> I approve 👍 12:12:28 <DorpsGek> [OpenTTD/OpenTTD] Pubiwhy opened issue #11254: [Bug]: Train does not pick up any passengers or mails https://github.com/OpenTTD/OpenTTD/issues/11254 12:17:21 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #11254: [Bug]: Train does not pick up any passengers or mails https://github.com/OpenTTD/OpenTTD/issues/11254 12:30:22 *** gelignite has quit IRC 13:32:59 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler approved pull request #11141: Add: [Script] Game script control of industry production level. https://github.com/OpenTTD/OpenTTD/pull/11141#pullrequestreview-1608268368 14:21:03 <DorpsGek> [OpenTTD/OpenTTD] michicc merged pull request #11141: Add: [Script] Game script control of industry production level. https://github.com/OpenTTD/OpenTTD/pull/11141 14:39:21 *** gelignite has joined #openttd 15:37:35 <andythenorth> \o/ 15:46:56 <truebrain> michi_cc[d]: #11198 does that. Directly above in the PR list. But _glx_ kinda needs to decide if he wants to go the cmake route or the CI route 🙂 15:50:29 *** _glx_ has joined #openttd 15:50:29 <_glx_> doing it in cmake makes more sense, as it's visible immediately without opening a PR 15:50:52 <truebrain> You happen to have time to finish your work and PR it? 15:53:33 <_glx_> I think I just need to ignore headers and change the level of message 15:55:18 <truebrain> Ignore headers? What do you mean? 15:57:06 <_glx_> we have 2 core.h in 3rdparty and network 15:57:29 <_glx_> but they are not an issue compared to duplicate .cpp 15:57:44 <truebrain> We can just rename the network one 15:57:56 <truebrain> Might make it easier to keep duplicates away 15:58:13 <truebrain> But yeah, I agree, less important 15:58:51 <truebrain> If you can make that happen, would be nice, means we can unblock XCode users 15:59:21 <_glx_> ```1> [CMake] openttd_lib: D:/developpement/GitHub/glx22/OpenTTD/src/network/core/core.h filename is a duplicate of D:/developpement/GitHub/glx22/OpenTTD/src/3rdparty/fmt/core.h 15:59:21 <_glx_> 1> [CMake] openttd_lib: D:/developpement/GitHub/glx22/OpenTTD/src/network/core/game_info.cpp filename is a duplicate of D:/developpement/GitHub/glx22/OpenTTD/src/game/game_info.cpp 16:00:02 <_glx_> that's what I have for now (it's just a `message`, but it's easy to make it an error) 16:00:38 <truebrain> Fatal that shit 16:00:40 <truebrain> :d 16:02:38 <peter1139> Hmm, silly UK drivers still aren't aware of Highway Code changes introduced 19 months ago... 16:07:18 <DorpsGek> [OpenTTD/OpenTTD] glx22 opened pull request #11255: Codechange: [CMake] detect source files with duplicate names https://github.com/OpenTTD/OpenTTD/pull/11255 16:07:27 <_glx_> CI will fail 😉 16:10:45 <truebrain> You wanted to add ignoring headers? 16:13:35 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #11255: Codechange: [CMake] detect source files with duplicate names https://github.com/OpenTTD/OpenTTD/pull/11255 16:14:00 <_glx_> will still fail 😉 (but headers are ignored) 16:15:05 <truebrain> .h and .hpp? 16:15:35 <_glx_> `\.h` should match both 16:15:43 <truebrain> Ah, like that 16:16:13 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #11255: Codechange: [CMake] detect source files with duplicate names https://github.com/OpenTTD/OpenTTD/pull/11255#pullrequestreview-1608339030 16:16:28 <truebrain> Looks good, let's gooooo 16:19:18 <_glx_> `# Check ${FILE} is not already added, but ignore header files` ? 16:24:22 <truebrain> Sounds good to me! 16:26:09 <michi_cc[d]> So should I merge #11186 in preparation? 16:29:05 <_glx_> oh I can even make it report header duplicates without stopping 16:32:10 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #11255: Codechange: [CMake] detect source files with duplicate names https://github.com/OpenTTD/OpenTTD/pull/11255 16:32:19 <truebrain> _glx_: That would be annoying as we expect that? 16:32:34 <truebrain> michi_cc[d]: If you wait a few more, we can see what glx did 🙂 16:32:37 <_glx_> it's just a line in the log 16:32:47 <truebrain> Yeah, but it will trigger people 16:32:52 <truebrain> And they want to fix it 😛 16:33:27 <truebrain> People work like that .. they want to act on messages 😄 16:33:39 <truebrain> So I wouldn't print it at all if not action is expected, honestly 16:33:52 <_glx_> that's how I detected the duplicate strgen.h 16:34:22 <michi_cc[d]> Filter for 3rdparty? 16:34:58 <_glx_> oh good idea, that's what #11198 do 16:36:32 <_glx_> (I think, I'm not the best with `find` arguments) 16:55:29 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #11255: Codechange: [CMake] detect source files with duplicate names https://github.com/OpenTTD/OpenTTD/pull/11255 16:56:00 <_glx_> now it doesn't report core.h, but can detect the duplicate strgen.h we used to have 16:56:45 <truebrain> I would say make all others fatal 16:56:53 <truebrain> warnings on which we don't take action are just weird, honestly 16:56:58 <Timberwolf> I shouldn't be allowed access to NML. http://timberwolf.woaf.net/things/openttd/horses_lol2.gif 17:00:07 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #11255: Codechange: [CMake] detect source files with duplicate names https://github.com/OpenTTD/OpenTTD/pull/11255#pullrequestreview-1608345888 17:19:40 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #11255: Codechange: [CMake] detect source files with duplicate names https://github.com/OpenTTD/OpenTTD/pull/11255 17:20:23 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #11255: Codechange: [CMake] detect source files with duplicate names https://github.com/OpenTTD/OpenTTD/pull/11255#pullrequestreview-1608349015 17:20:25 <truebrain> enough bikeshedding 😄 17:21:47 <truebrain> tnx _glx_ 🙂 17:24:33 <_glx_> hmm something doesn't work in the last version, it reports core.h but not game_info.hpp 17:25:03 <truebrain> FATAL_ERROR stops after the first hit 17:25:08 <truebrain> so I expect only to see one 17:25:17 <truebrain> but not `core.h` 😄 17:25:36 <_glx_> I moved too much 17:25:36 <truebrain> owh, you made it so both header files need to be in 3rdparty 17:25:38 <truebrain> that is not needed 🙂 17:30:34 <_glx_> hmm even if I don't ignore anything the .hpp duplicate is not detected, something broken in a regex 17:31:51 <truebrain> just be careful that with FATAL you only see the first hit 🙂 17:32:28 <_glx_> I removed the FATAL for my testing 17:32:55 <truebrain> what is `${RES}` btw? As in, where does it come from? The regex? 17:33:32 <_glx_> pff it's game_info.hpp and game_info.h, of course it's not detected 17:34:09 <truebrain> oof ... that is still bad, but yeah, explains 😄 17:34:42 <truebrain> 11186 also fixes that, so that is good 🙂 17:35:31 <_glx_> yeah I expected it because #11186 🙂 17:38:05 <_glx_> `${RES}` is the result of the regex yes, and in current PR the regex is not at the right place 17:38:45 <_glx_> but I'll have to rebase after #11186 merge anyway 17:39:45 <_glx_> it's fixed locally 17:40:33 <truebrain> so just push it 🙂 Then we can all appreciate your work 😄 17:40:37 <truebrain> it fails quickly enough anyway 17:41:39 <DorpsGek> [OpenTTD/OpenTTD] glx22 dismissed a review for pull request #11255: Codechange: [CMake] detect source files with duplicate names https://github.com/OpenTTD/OpenTTD/pull/11255#pullrequestreview-1608349015 17:41:42 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #11255: Codechange: [CMake] detect source files with duplicate names https://github.com/OpenTTD/OpenTTD/pull/11255 17:42:21 <truebrain> that regex 17:42:22 <truebrain> lol 17:42:27 <truebrain> what-ever 😛 "its fine" 😄 17:42:37 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #11255: Codechange: [CMake] detect source files with duplicate names https://github.com/OpenTTD/OpenTTD/pull/11255#pullrequestreview-1608352692 17:43:44 <_glx_> yeah the regex extract the already added filename from a ;-separated list 17:45:05 <truebrain> so merge away! 😄 17:45:56 <_glx_> 11186 should go first 17:46:01 <truebrain> so merge it! 🙂 17:46:56 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #11186: Workaround CMake/Xcode duplicate file name issue https://github.com/OpenTTD/OpenTTD/pull/11186 17:47:30 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #11255: Codechange: [CMake] detect source files with duplicate names https://github.com/OpenTTD/OpenTTD/pull/11255 17:49:45 <_glx_> and auto merge enabled 17:49:50 <truebrain> \o/ 17:51:15 <_glx_> locally it works 17:51:52 <_glx_> in the PR it seems fine too 17:53:16 *** Wormnest has joined #openttd 17:59:47 <andythenorth> working docks peter1139? https://www.youtube.com/watch?v=xZWTvxzlExA 18:12:38 <truebrain> _glx_: you also close that other PR btw? 18:12:59 <DorpsGek> [OpenTTD/OpenTTD] ketsuban opened issue #11256: [Bug?]: Pristine company with no assets and no cash on hand still has expenses https://github.com/OpenTTD/OpenTTD/issues/11256 18:18:04 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on issue #11256: [Bug?]: Pristine company with no assets and no cash on hand still has expenses https://github.com/OpenTTD/OpenTTD/issues/11256 18:23:20 <peter1139> https://media.infosec.exchange/infosecmediaeu/media_attachments/files/110/996/871/755/461/846/original/06c8ebaed4b73f1b.png 18:25:16 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #11256: [Bug?]: Pristine company with no assets and no cash on hand still has expenses https://github.com/OpenTTD/OpenTTD/issues/11256 18:25:19 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain closed issue #11256: [Bug?]: Pristine company with no assets and no cash on hand still has expenses https://github.com/OpenTTD/OpenTTD/issues/11256 18:25:24 <truebrain> peter1139: hahaha 😄 18:26:23 <Rubidium> well... I'd say call the first number of the question. If they don't know, call the other one :D 18:27:31 <truebrain> micro-explaining how payments work in OpenTTD 😄 I like it! 18:32:48 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #11255: Codechange: [CMake] detect source files with duplicate names https://github.com/OpenTTD/OpenTTD/pull/11255 18:35:02 <peter1139> Hmm, breakpad fails to compile. Yay. 18:35:47 <peter1139> Perhaps I should use the v2023.01.27 tag. 18:38:20 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/5c2e4ee6feb9d50628dde439fe76d23559fd210a 18:38:21 <DorpsGek> - Update: Translations from eints (by translators) 18:38:57 <peter1139> Doesn't help. third_party/lss is missing. Hmm. 18:39:31 <peter1139> Oh right, there's "depot_tools" 18:40:25 <peter1139> So just pulling from git doesn't work. Dumb. 19:10:41 <truebrain> Google software is the worst to compile yourself 19:10:46 <truebrain> An absolute nightmare 19:11:01 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #11201: Codechange: Reorder some high-use structs to reduce their size. https://github.com/OpenTTD/OpenTTD/pull/11201 19:13:29 <peter1139> I 'unno 19:14:38 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #11198: Add: ensure no duplicate filenames https://github.com/OpenTTD/OpenTTD/pull/11198#issuecomment-1703916213 19:14:41 <DorpsGek> [OpenTTD/OpenTTD] glx22 closed pull request #11198: Add: ensure no duplicate filenames https://github.com/OpenTTD/OpenTTD/pull/11198 19:15:26 <_glx_> haha so much spam in github notifications 19:34:20 <truebrain> peter1139: lol, I recently committed some code that went with `a{0}`, as that was what you had 😄 Lol 🙂 19:34:33 <truebrain> I was being a good boy 😛 19:43:56 <peter1139> Oh ffs. 19:44:23 <peter1139> Oh well, I still have the original. 19:44:31 <truebrain> we really have to write this down 😄 19:54:06 <peter1139> You've done it now ;) 19:54:10 <truebrain> btw, if it wasn't a draft, I would have approved it by now 😛 19:54:17 <peter1139> I was away :D 19:54:30 <truebrain> pfffffff 19:54:31 <truebrain> 😄 19:59:42 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #11201: Codechange: Reorder some high-use structs to reduce their size. https://github.com/OpenTTD/OpenTTD/pull/11201 19:59:49 <peter1139> Back to how it was. 19:59:58 <truebrain> \o/ 20:00:22 <peter1139> It probably needed the rebase anyway. 20:00:23 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain approved pull request #11201: Codechange: Reorder some high-use structs to reduce their size. https://github.com/OpenTTD/OpenTTD/pull/11201#pullrequestreview-1608372309 20:01:38 <peter1139> Hmm, the other thing I was looking at was the pathfinder cache for ships/roadvehicles. 20:08:49 <_jgr_> I had a go at those recently, <https://github.com/JGRennison/OpenTTD-patches/commit/2ae4e5bdc1856c0cc1a6e9cd3362ea4a1c1b6697> <https://github.com/JGRennison/OpenTTD-patches/commit/92e632454e836877a9816b348b760cb12aa7d302> 20:10:06 <_jgr_> std::deque is not really a light-weight container 20:10:30 <truebrain> yeah, didnt we talk about that recently .. especially the double deque was silly 😄 20:10:55 <truebrain> (silly large, that is) 20:12:07 <truebrain> `SLEG_CONDVECTOR("path.td", _path_td, SLE_UINT8, SLV_SHIP_PATH_CACHE, SL_MAX_VERSION),` <- SHIP? That feels a bit odd 20:12:12 <truebrain> (in the RV commit) 20:13:15 <_jgr_> Hmm, looks a like a copy-paste error 20:14:16 <truebrain> helping making JGRPP better, one "review" at the time! 😄 20:18:56 <_jgr_> Thanks, that's fixed now. One of the downsides of doing my own thing is that things slip through more easily 20:19:07 <truebrain> yeah, I can fully understand that 20:19:16 <truebrain> it helps you have a vocal userbase, so bugs boil up quick 🙂 20:27:05 <peter1139> Yeah, I was going to use a fixed buffer, which JGR has done, so... 20:27:51 <peter1139> Although probably in a more generic way. 20:28:03 <truebrain> You or him? 😄 20:29:03 <_jgr_> I thought about unifying them, but they're just different enough that it's not worth the bother 20:37:21 <truebrain> having a generic ringbuffer is also useful for other places 20:37:29 <truebrain> I think 20:37:30 <truebrain> 😄 20:38:02 <_jgr_> <https://github.com/JGRennison/OpenTTD-patches/blob/jgrpp/src/core/ring_buffer.hpp> 20:38:20 <_jgr_> Though this is a variable size one 20:38:33 <truebrain> dunno, for me a ringbuffer is always fixed size 20:38:39 <truebrain> so I was reading it like: huh? 😄 20:38:45 <truebrain> but that might just be my world I live in, honestly 20:38:55 <peter1139> That's kind of the point of a ringbuffer, yes. 20:40:09 <peter1139> Come on CodeQL :D 20:43:13 <_jgr_> The above is mainly intended as a drop-in for deque/queue, so when full it allocates a bigger ring 20:45:05 <andythenorth> I mean yes...https://www.reddit.com/r/openttd/comments/1681loy/this_game_seriusly_lacks_good_worldgen/ 20:45:11 <andythenorth> but those things are so unsolvable 20:45:52 <truebrain> and some have nothing to do with worldgen 😛 20:45:54 <truebrain> reddit 😄 20:47:55 <peter1139> I have a standalone height map generator somewhere. 20:48:03 <peter1139> One of the heightmaps is on Bananas for some reason. 20:48:40 <truebrain> it still won't have water on higher levels 😛 20:48:51 <truebrain> well, sea 20:48:55 <truebrain> it might have rivers, ofc 😛 20:49:49 <peter1139> Hmm, £50 for a game is still a lot of money :o 20:56:40 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #11201: Codechange: Reorder some high-use structs to reduce their size. https://github.com/OpenTTD/OpenTTD/pull/11201 21:59:24 *** ahyangyi has joined #openttd 21:59:24 <ahyangyi> andythenorth: Ah, I should upload those 16384x16384 heightmaps for real 21:59:51 *** keikoz has quit IRC 22:02:16 <peter1139> 256 pixels per tile, nice. 22:32:56 *** HerzogDeXtEr has quit IRC 22:36:39 *** Wolf01 has quit IRC 22:58:47 *** gelignite has quit IRC