Times are UTC Toggle Colours
00:04:13 <_glx_> yeah nightly failed again 00:04:24 <_glx_> so steam still has the broken version 00:04:40 <_glx_> "/Users/runner/work/OpenTTD/OpenTTD/build-x64/_CPack_Packages/x86_64/Bundle/openttd-20231211-master-g0a8bcdd344-macos-universal/OpenTTD.app: timestamps differ by 242 seconds - check your system clock" 00:04:44 <_glx_> that's annoying 00:06:40 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on issue #11577: [Bug]: Ctrl + left click Centre view on ship depot opens a viewport centered on a power station https://github.com/OpenTTD/OpenTTD/issues/11577 00:26:05 <_glx_> at least I can use git bisect 🙂 00:36:24 <_glx_> git bisect says https://github.com/OpenTTD/OpenTTD/pull/11191 00:49:11 <_glx_> ok I understand what happens 00:52:34 <peter1138> ExtraViewportWindow passing 0, which used to be interpreted as a tile, but now is a... vehicleid? 00:52:55 <peter1138> But then... a power plant isn't a vehicle 00:52:56 <peter1138> *shrug* 00:53:42 <peter1138> But also it's windows only, so. 00:53:50 <peter1138> Or maybe it's some combination of settings. 00:56:26 <_glx_> most likely UB 00:56:35 <_glx_> but yeah it's the 0 00:57:16 *** bryjen has quit IRC 01:02:43 <_glx_> hmm need to check if I didn't break anything 01:03:00 <peter1138> Hmm, I'd say pass tile to InitializeViewport, and make it handle INVALID_TILE, and then drop lines 63-78 of ExtraViewportWindow. 01:05:04 <peter1138> I can make a PR for that. 01:06:15 <_zephyris> Hmm 01:06:18 <_zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1184300229877575782/image.png?ex=658b788a&is=6579038a&hm=5b9d08d73f7d15acb527cd7c18a5c305b2b5e28eecd160a1dc08a04f5425fb48& 01:07:01 <_zephyris> peter1138[d]: What OS are you running? And was it Liberation Sans that overflowed nicely? 01:07:09 <peter1138> FreeSans 01:07:22 <peter1138> On Linux, so FreeType 01:12:15 <_zephyris> peter1138[d]: Free Sans Bold size 10? 01:12:53 <peter1138> Yes 01:12:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #11578: Fix #11577: Extra viewport opened in wrong location. https://github.com/OpenTTD/OpenTTD/pull/11578 01:13:55 <_glx_> I was going to TileIndex(0) 01:14:07 <_zephyris> https://cdn.discordapp.com/attachments/1008473233844097104/1184302196863553556/image.png?ex=658b7a5f&is=6579055f&hm=913004ae32917fd810f67c5c93199d8f4aa66f5f8c528f944f204c08cc2f7d4d& 01:14:07 <_zephyris> No overflow... Windows 10 01:15:09 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1184302459422769172/image.png?ex=658b7a9d&is=6579059d&hm=4cda9668d734965eaaec8996ef6208d70021c47373c51392ab6d5904673eda78& 01:15:31 <peter1138[d]> Not really overflowing here either. Hmm. 01:16:12 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1184302721839407195/image.png?ex=658b7adc&is=657905dc&hm=436817b60efb661449eac71d8674c4e58dd39aa518cea38be69eb9b0cafe55f5& 01:16:39 <peter1138[d]> It's subtle. But yes, Windows and FreeType rendering can be different. 01:17:12 <peter1138> I have a patch for Windows that uses different geometry, let's see where that went. 01:18:16 <peter1138> https://github.com/OpenTTD/OpenTTD/pull/10273 01:19:55 <peter1138> LOL just noticed that truebrain AI'd that one. 01:21:37 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #10273: Fix #10151: Use otmAscent instead of otmTextMetrics.tmAscent [Windows] https://github.com/OpenTTD/OpenTTD/pull/10273 01:21:49 <peter1138> No longer a year out of date :D 01:24:34 <_zephyris> Thanks, I'll have a poke 01:24:43 <_zephyris> Now sleep 🙂 01:37:21 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #11578: Fix #11577: Extra viewport opened in wrong location. https://github.com/OpenTTD/OpenTTD/pull/11578#pullrequestreview-1778697684 01:41:21 <DorpsGek> [OpenTTD/OpenTTD] github-advanced-security[bot] commented on pull request #11578: Fix #11577: Extra viewport opened in wrong location. https://github.com/OpenTTD/OpenTTD/pull/11578#pullrequestreview-1778704941 01:41:31 <peter1138> :o 01:41:45 <peter1138> Ah, oops :) 01:42:20 <peter1138> VehicleID 0 doesn't explain why it goes to an industry, except perhaps is vehicle id 0 doesn't exist. 01:43:39 <_glx_> when testing I had no vehicles 01:43:47 <_glx_> I can test with one 01:43:58 <peter1138> It's fine, it's clearly wrong anyway :) 01:48:31 <_glx_> oh vehicle 0 is an effect 01:48:37 <peter1138> Oh! 01:50:23 <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #11578: Fix #11577: Extra viewport opened in wrong location. https://github.com/OpenTTD/OpenTTD/pull/11578#pullrequestreview-1778697684 01:50:26 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #11578: Fix #11577: Extra viewport opened in wrong location. https://github.com/OpenTTD/OpenTTD/pull/11578 01:50:31 <_glx_> the vehicle I built is at index 1 01:50:53 <peter1138> And vehicle it's a VehicleID, follow_vehicle is set, so the location override is moot. 01:50:58 <peter1138> ... 01:51:00 <peter1138> And because 01:51:34 <peter1138> This is where implicit conversions are bad. 01:51:48 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #11578: Fix #11577: Extra viewport opened in wrong location. https://github.com/OpenTTD/OpenTTD/pull/11578#pullrequestreview-1778714434 01:52:12 <peter1138> It's not exactly undefined behaviour, it's 0 is implicitly converted to VehicleID on Windows, and implicitly converted to TileIndex on others. 01:52:37 <peter1138> I suppose this the definition of UB :) 01:55:58 <_glx_> spec is not clear on this point 01:57:18 <_glx_> I think it's (4) in <https://en.cppreference.com/w/cpp/utility/variant/variant>, but it doesn't really tell what type should be selected 02:04:26 *** herms has quit IRC 02:05:45 *** herms has joined #openttd 02:13:16 <_glx_> oh of course vehicle 0 is the chimney smoke 02:13:48 <peter1138> Yup 02:14:54 <_glx_> that explains everything 🙂 02:16:35 <DorpsGek> [OpenTTD/grfcodec] glx22 merged pull request #28: Add: Install, Pack (windows) and Release workflow https://github.com/OpenTTD/grfcodec/pull/28 02:19:20 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #11578: Fix #11577: Extra viewport opened in wrong location. https://github.com/OpenTTD/OpenTTD/pull/11578 02:19:23 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #11577: [Bug]: Ctrl + left click Centre view on ship depot opens a viewport centered on a power station https://github.com/OpenTTD/OpenTTD/issues/11577 03:03:38 *** Flygon has quit IRC 03:29:39 *** Gadg8eer[m] has quit IRC 03:35:45 *** Wormnest has quit IRC 03:39:22 *** bryjen has joined #openttd 03:55:29 *** debdog has joined #openttd 03:58:51 *** D-HUND has quit IRC 04:30:49 *** keikoz has joined #openttd 04:35:04 <locosage> peter1138[d]: you can check how cmclient does 32bpp to 8 04:35:15 <locosage> it's somewhat similar to rgba-eater minus all the options 04:41:59 <locosage> <https://github.com/citymania-org/cmclient/blob/master/src/blitter/32bpp_base.hpp#L182> 04:42:41 <locosage> not the best solution but for 8bpp blitter fallback should be enough 04:43:26 <locosage> lol, wtf, it is using wrong color distance... 04:44:08 <locosage> should be smth like this <https://github.com/citymania-org/grf-py/blob/main/grf/sprites.py#L13> 04:44:44 <locosage> as rgb space isn't linear 04:57:15 <pandonaut> truebrain: :Sadgers: 05:47:37 *** bryjen has quit IRC 08:47:49 *** Deep3D has joined #openttd 09:10:51 <peter1138> Why do you convert from RGB to M for 32bpp blitters instead of 8bpp blitters? 09:17:45 <locosage> for 32bpp recolors 09:28:42 <locosage> https://cdn.discordapp.com/attachments/1008473233844097104/1184426664613134356/Screenshot_from_2023-12-13_14-58-33.png?ex=658bee4a&is=6579794a&hm=a79a9e37f9d215bed85ffe89bdcfa51a690cad723c026335c68879501692211f& 09:39:47 <xarick> hmm OpenTTD doesn't handle Hibernate option that well 09:40:13 <xarick> when system awakes from hibernate, there's a change that something goes wrong 09:40:16 <peter1138> OpenTTD doesn't need to handle Hibernate. 09:40:24 <xarick> it either gets stuck 09:40:33 <xarick> or crashes 09:40:34 <peter1138> That's your system not hibernating properly. 09:40:35 <xarick> or poofs 09:40:52 <LordAro> you know where crash reports are supposed to go 09:41:49 <xarick> well, yes, but this time it is stuck... 09:42:03 <xarick> unresponsive 09:42:40 <xarick> funny thing, it's using 33% of cpu 09:42:46 <peter1138> It's generally graphics card drivers not restoring state. 09:42:48 <xarick> on a 8 core 09:42:59 <LordAro> i believe you know how to attach to a process with visual studio? 09:44:27 <xarick> this is the official 13.4 OpenTTD 09:44:32 <xarick> how would I do that? 09:44:55 <LordAro> hmm, trickier indeed 09:45:15 <LordAro> https://www.openttd.org/downloads/openttd-releases/latest but debug symbols are available 09:50:21 *** Deep3D has left #openttd 09:50:49 <xarick> oh snap, Github Desktop latest update changes the way branches are listed 09:50:57 <xarick> I can't switch to 13.4 anymore 09:53:45 <xarick> nevermind, I can on visual studio 10:00:44 <xarick> apparently i dont know how to attach debug symbols 10:01:14 *** ufo-piloot_ has joined #openttd 10:03:28 <peter1138> lol, 16MB array for palette lookups right? 10:03:45 *** ufo-piloot has quit IRC 10:03:50 <peter1138> One way to make emscriptem fail again :D 10:05:46 <locosage> mine is 262k 10:06:20 <peter1138> I know. 10:07:44 <peter1138> I tried 2 bits for fun. It's actually completely usable. The 32bpp houses GRF I tested is not bad, but zBase suffers. 10:08:37 <peter1138> 256KiB is probably reasonable. 10:09:43 <locosage> what color distance are you using? 10:09:48 <peter1138> sRGB 10:10:02 <peter1138> I was already using the same as in your python. 10:10:02 <locosage> that's space not distance 10:10:07 <peter1138> Oh, sorry. 10:10:09 <peter1138> Er... 10:10:09 <locosage> r*r+g*g+b*b 10:10:16 <locosage> ? 10:10:39 <peter1138> 2/4/3 or 3/4/2 10:10:41 <peter1138> Yeah 10:11:27 <merni> locosage: discord thought * was for italic markup :p 10:11:44 <merni> oops replied to wrong post 10:12:04 <locosage> yeah, I also accidentally pressed enter too soon xD 10:13:26 <peter1138> https://en.wikipedia.org/wiki/Color_difference < this page refers to it as sRGB distance. 10:21:51 <locosage> where? that page is a bit of a mess but it seems to be listing euclidean and other distances for srgb space 10:21:57 <locosage> one python uses is apparently "redmean" 10:22:45 <locosage> though I'm trying redmean in cmclient and it doesn't look that great, but maybe I'm doing smth wrong 10:25:25 <peter1138[d]> https://cdn.discordapp.com/attachments/1008473233844097104/1184440937066287122023-12-13T22:46:47 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened pull request #11581: Add: Improve World Generation GUI tooltips https://github.com/OpenTTD/OpenTTD/pull/11581 22:54:01 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #10606: Feature: Setting to scale cargo production of towns and industries https://github.com/OpenTTD/OpenTTD/pull/10606#issuecomment-1854821844 22:54:39 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #10606: Feature: Setting to scale cargo production of towns and industries https://github.com/OpenTTD/OpenTTD/pull/10606 22:56:10 *** Wormnest has joined #openttd 22:59:46 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #11581: Add: Improve World Generation GUI tooltips https://github.com/OpenTTD/OpenTTD/pull/11581#pullrequestreview-1780627141 23:04:40 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #11580: Codechange: Replace pointer to Sprite array with reference to SpriteCollection. https://github.com/OpenTTD/OpenTTD/pull/11580#pullrequestreview-1780631446 23:06:06 <talltyler> 4 annotations found on #11428, but I sure can’t see them in the code view (and none of the build actions are complaining about them) 23:18:51 *** keikoz has quit IRC 23:20:37 <xarick> `AirportGetNearestTown(as, tile, it, dist);` 23:20:37 <xarick> found another bug here 23:21:32 <xarick> if the town tile is inside the airport, the distance reported is not 0 23:24:23 <xarick> if the airport is super gigantic big, the perimeter of the airport might be closest to a town outside the perimeter than the one inside 23:25:07 *** Eddi|zuHause2 is now known as Eddi|zuHause 23:25:15 <Eddi|zuHause> there probably is a maximum size 23:26:07 <truebrain> Finding hypothetical bugs ... also a way to spend your day 😛 23:27:12 <Eddi|zuHause> we can probably conjure up more pathological cases if we consider non-rectangular airports 23:27:42 <truebrain> A 4096x4096 airport when? 23:27:56 <Eddi|zuHause> right after state machines *cough* :p 23:28:37 <xarick> what is the minimum distance between towns? 23:28:42 <truebrain> Ah, the fictive state machines for airports! 23:29:12 <xarick> gonna try to reproduce this 23:33:10 <xarick> it's 20 tiles 23:33:19 <xarick> so it's safe 23:33:28 <xarick> biggest airport right now is 9x11 23:35:32 <_glx_> talltyler: 5 actually 23:36:02 <_glx_> in a generated file 23:36:02 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #11580: Codechange: Replace pointer to Sprite array with reference to SpriteCollection. https://github.com/OpenTTD/OpenTTD/pull/11580 23:36:36 <_glx_> so somewhere in a .ini 23:37:57 <peter1138> Airports have state machines :D 23:38:13 <xarick> there may be something else that could end up bugged -> the noise level reported might be different, must test 23:38:16 <peter1138> The layout is a bit... meh though. 23:39:25 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #11428: Feature: Setting to control calendar progress speed https://github.com/OpenTTD/OpenTTD/pull/11428#pullrequestreview-1780661432 23:41:50 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #11428: Feature: Setting to control calendar progress speed https://github.com/OpenTTD/OpenTTD/pull/11428#pullrequestreview-1780663322 23:42:46 <Eddi|zuHause> xarick: there's not really much of the problem if the distance is "wrong", it just needs to be the same on construction and destruction. 23:47:28 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1184642777783472208/image.png?ex=658cb78f&is=657a428f&hm=f716b3f8aebe888a78735efe186689f5543aa3769180a8bd59eecee0dfafacce& 23:47:28 <xarick> okay, it's fine too. that inner area without signs report a noise increase in town of 25, and signs report 24. There is no 24 being reported when the town is inside the airport 23:47:41 *** goddess_ishtar has joined #openttd 23:47:41 <goddess_ishtar> are "BAD FEATURES" actually, yknow, *bad* (and thus should be avoided) or just divisive? 23:48:52 <peter1138> xarick, remind me how you place an airport on top of a town. 23:49:09 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler updated pull request #11428: Feature: Setting to control calendar progress speed https://github.com/OpenTTD/OpenTTD/pull/11428 23:50:07 <talltyler> Now they all have the same `new_value` parameter, hopefully that fixes it 23:50:27 <_glx_> do you really need it in both files ? 23:51:10 <xarick> the signs are placed for the northest tile of the airport only 23:53:07 <_glx_> talltyler: it doesn't <https://gist.github.com/glx22/67399a6a91f4f59057e3adce37ace879> 23:58:13 <xarick> xarick: this table tells me I should be worried 23:59:40 <xarick> that noise 25: (7) (11) (15) (19), i still fail to decipher it