Times are UTC Toggle Colours
01:19:54 <wensimehrp> andythenorth: what's `st`? Status? 01:19:54 <wensimehrp> ❯ git st 01:19:54 <wensimehrp> git: 'st' is not a git command. See 'git --help'. 01:19:54 <wensimehrp> The most similar commands are 01:19:54 <wensimehrp> status 01:19:55 <wensimehrp> reset 01:19:55 <wensimehrp> stage 01:19:57 <wensimehrp> stash 01:37:17 <mnhebi> peter1138: damn dude, have some mercy. 😅 01:37:33 <mnhebi> Junior devs gotta start somewhere :D 02:03:10 *** herms61 has joined #openttd 02:10:14 *** gnu_jj has joined #openttd 02:13:44 *** gnu_jj_ has quit IRC 02:21:20 *** debdog has joined #openttd 02:24:44 *** D-HUND has quit IRC 04:05:35 *** keikoz has joined #openttd 04:41:34 *** blathijs has quit IRC 04:45:40 *** blathijs has joined #openttd 04:45:40 *** ChanServ sets mode: +o blathijs 05:25:38 *** keikoz has quit IRC 06:04:51 *** nielsm has joined #openttd 06:33:31 <andythenorth> hmm, this repo that had 250k redundant PNGs in it....should I prune my repo history? 07:11:53 <wensimehrp> git pull --depth 1 07:19:05 <johnfranklin> ++++++++++[>+++++++++++>++++++++++>++++++<<<-]>--.+++++++++.-------.>-.+++++.>+++ 07:19:57 <johnfranklin> or, lunch? 07:51:11 *** nielsm has quit IRC 08:10:42 *** nielsm has joined #openttd 08:16:42 *** mindlesstux has joined #openttd 08:36:23 <xarick> hi 08:36:30 <xarick> bad news... I got an assert 08:38:30 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1290956061896998942/image.png?ex=66fe5805&is=66fd0685&hm=2220cc13ab73dff2cd759281b3a317495b150d0102fe5fbf30dd9132f6c09587& 08:41:16 <xarick> aha @glx, got the crash 08:41:22 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1290956783203909683/image.png?ex=66fe58b1&is=66fd0731&hm=159b67cfa7945987ae12e81f1cb6d9a2419ff01a81160fe3bf371fd53ef9264b& 08:42:54 <xarick> right after I clicked OK of the previous Error window 08:44:34 <DorpsGek> [OpenTTD/OpenTTD] flix1 commented on discussion #12970: New inflation settings https://github.com/OpenTTD/OpenTTD/discussions/12970 08:47:33 <johnfranklin> https://cdn.discordapp.com/attachments/1008473233844097104/1290958341748817961/IMG_0140.png?ex=66fe5a25&is=66fd08a5&hm=b0c7941cac218903f7c8b69b5c0293a5d5a6840dc98a52f73ca2490876821031& 08:47:33 <johnfranklin> WTF, goodnotes thought the “coslogx” function diagram as an instruction to erase the x axis 08:48:02 <johnfranklin> After screenshot, the diagram would be gone along with the x axis 08:51:39 *** nielsm has quit IRC 08:55:25 <DorpsGek> [OpenTTD/OpenTTD] flix1 commented on discussion #12970: New inflation settings https://github.com/OpenTTD/OpenTTD/discussions/12970 08:59:49 <DorpsGek> [OpenTTD/OpenTTD] yeah-its-gloria commented on issue #12971: [Bug]: Mac Cursor is not moving https://github.com/OpenTTD/OpenTTD/issues/12971 09:00:05 <LordAro> johnfranklin: ahaha 09:24:23 <DorpsGek> [OpenTTD/OpenTTD] flix1 commented on discussion #12970: New inflation settings https://github.com/OpenTTD/OpenTTD/discussions/12970 09:26:47 <truebrain> Wauw, #12973 contains a lot of totally irrelevant noise 09:26:55 *** nielsm has joined #openttd 09:27:01 <truebrain> The bug itself is pretty trivial; the ticket is not 😛 09:28:48 <xarick> what does the game do when 1 minute between autosaves is insufficient? 09:29:02 <xarick> imagine saving takes 1 minute and half 09:29:15 <LordAro> truebrain: title is taken directly from that forum thread that peter linked yesterday 09:29:46 <truebrain> Yeah, it makes a simple ticket a lot more difficult 09:30:12 <truebrain> Either way, a simple oversight on our part, not removing the scoreboard exception thingy 09:31:43 <LordAro> i thought it was intentional 09:31:57 <LordAro> in so much as the highscore table is completely meaningless anyway 09:32:24 <LordAro> but using sandbox options meaning that you don't appear on the highscore table is perfectly reasonable to me 09:46:50 <peter1138> Was more going to be done with the sandbox changes? 09:47:54 <peter1138> I got the impression that it was all going to be merged into settings at some point, which is why we added new sandboxy type stuff (infinite money) as settings instead. 09:49:10 <DorpsGek> [OpenTTD/OpenTTD] rendomnet closed issue #12971: [Bug]: Mac Cursor is not moving https://github.com/OpenTTD/OpenTTD/issues/12971 09:49:13 <DorpsGek> [OpenTTD/OpenTTD] rendomnet commented on issue #12971: [Bug]: Mac Cursor is not moving https://github.com/OpenTTD/OpenTTD/issues/12971 09:52:10 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on issue #12973: [Bug]: Score excluded from highscore when using sandbox https://github.com/OpenTTD/OpenTTD/issues/12973 09:52:45 <truebrain> Someone had a plan with it. But it seems it stranded after the initial bump 🙂 09:53:02 <truebrain> Either way, used some editorial powers to make the bug report more readable 😉 09:54:13 <truebrain> Now we can discuss whether it is wanted behaviour in the ticket 😄 😛 09:54:18 <LordAro> nice 10:00:06 <xarick> hmm... 10:10:23 <peter1138> Is that Someone™? 😄 10:13:26 <peter1138> Also the distinction between GM_NORMAL and GM_EDITOR gets a bit blurred. 10:42:48 <xarick> 70000 ships autoservice -> no issues found, there are some false positives though, with some ships never servicing 10:43:46 <xarick> but that's due to their current path choice not having a depot within the max_penalty 10:43:52 <xarick> i verified 10:44:39 <xarick> 70000 service at nearest depot order -> we have an assert 😦 10:45:33 <xarick> how am I going to debug this... it only happens after 1 year game time 10:46:00 <xarick> waiting 1 year with a debug build is gonna take forever! 10:48:58 <peter1138> Use a smaller savegame. 10:56:38 <xarick> i have an idea that might work, savegame 1 day before it happens 10:56:40 *** HerzogDeXtEr has joined #openttd 10:56:51 <xarick> on a non debug build 11:18:31 *** Flygon has joined #openttd 11:36:00 <xarick> okay, another case of hlpf vs llpf disagreeing 11:36:07 <xarick> pff these are so difficult to solve 11:37:04 *** keikoz has joined #openttd 11:44:17 *** aviationgamerx has joined #openttd 11:44:17 <aviationgamerx> https://cdn.discordapp.com/attachments/1008473233844097104/1291002810124468255/image.png?ex=66fe838f&is=66fd320f&hm=f7d009792e440b75db285be4e1d9478efbe54a720ecdab93faaf1667805dce05& 11:44:17 <aviationgamerx> https://cdn.discordapp.com/attachments/1008473233844097104/1291002810669731870/image.png?ex=66fe838f&is=66fd320f&hm=625bdb1d3277fb8fe2378b8a8381e8e5f9783e2d5539ff721dde4901a1d2d525& 11:44:17 <aviationgamerx> Alright, I did some stuff, max loan setting change, I changed code in different places but it seems this is the only place that is getting messed up in the difficulty_settings.ini file 11:44:17 <aviationgamerx> What does it mean `difficulity` undefined? how do I make it reccognize the `difficulty` as it did in `var = difficulty.max_loan_percentage`? 11:44:17 <aviationgamerx> And what about the other errors, I don't quite understand them? 11:44:19 <aviationgamerx> If there is a place I should be posting questions like these instead of here in like a forum or something tell me where, otherwise I guess this is the only place, thanks in advance 11:46:14 <LordAro> the full variable is _settings_game.difficulty 11:46:20 <LordAro> i imagine the ini is prepending that 11:46:27 <LordAro> for var* 11:47:03 <LordAro> the other errors probably follow from the first 11:47:16 <LordAro> in C/C++ you should always fix the first error before worrying about the others 11:48:26 <_glx_> Like a missing `;` could cause a huge amount of errors after it 🙂 11:53:37 <kuhnovic> A missing const is also a good way to get lots of fun errors, especially when templates are involved 11:53:44 <kuhnovic> C++, so much fun 12:09:53 <aviationgamerx> LordAro: I automatically did that lol, I didn't even bother trying to understand them 12:10:06 <aviationgamerx> _glx_: or writing difficulity instead of difficulty 12:11:08 <aviationgamerx> LordAro: alr thanks will try it 12:25:22 *** akimoto has joined #openttd 12:26:15 <aviationgamerx> https://cdn.discordapp.com/attachments/1008473233844097104/1291013378432569435/image.png?ex=66fe8d67&is=66fd3be7&hm=93b10f1e06a826a7568f5724fc1ef6211970ba583a13086f91f2ede021ca64a5& 12:26:15 <aviationgamerx> LordAro: welp they weren't related to the same error 12:26:28 <aviationgamerx> does it have to do with the flags 12:32:59 <LordAro> probably. 12:34:04 <LordAro> hmm, no, probably not flags 12:37:01 <aviationgamerx> seems like not 12:40:29 <LordAro> you might be able to work something out from looking at the generated code, but i'm not sure looking at those errors 12:40:40 <LordAro> i don't get VS errors 13:31:57 <aviationgamerx> https://cdn.discordapp.com/attachments/1008473233844097104/1291029913561989243/image.png?ex=66fe9ccd&is=66fd4b4d&hm=660ed943758f6fd18008780e2a8a2de5c883bb461fd7e77c149ac603ce5a4e3b& 13:31:57 <aviationgamerx> the generated code shows the problem is with this line 13:37:51 <LordAro> are those callback functions supposed to return boolean? 13:38:21 <aviationgamerx> not sure 13:38:23 <LordAro> it looks like it's supposed to be a IntSettingDesc, does that match the constructor? 13:39:46 <aviationgamerx> I am not sure what it means, I don't see any constructors 13:41:26 <aviationgamerx> is there supposed to be a constructor with the same parameters somewhere that is missing? 13:41:40 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1291032356484026471/Captura_de_ecra_2024-10-02_142254.png?ex=66fe9f14&is=66fd4d94&hm=b62903b1f699838c17871599f69fc1481d33734f6dc0208c3198852cfb36a028& 13:41:40 <xarick> My investigative work... 13:42:25 <xarick> the problem is llpf to intermediate_destination 😦 13:42:33 <xarick> at the 2nd call 13:43:43 <_glx_> it's expected to get 2 different depot for hlpf only and llpf only 13:44:23 <LordAro> aviationgamerx: settings_internal.h:173 13:44:54 <LordAro> critically, the PostChangeCallback is a void function 13:45:17 *** akimoto has quit IRC 13:46:21 <_glx_> https://cdn.discordapp.com/attachments/1008473233844097104/1291033536891064342/296482771-a81b2602-193a-4f0e-95a2-b545c1c58a9d.png?ex=66fea02d&is=66fd4ead&hm=024e10ec54c6fc7c915eda9930886861ab362b1cf97588f9c376ba9723a537b1& 13:46:21 <_glx_> like 13:46:53 <_glx_> hlpf will return the one in yellow circle, while llpf will return the other one 13:48:08 <xarick> intermediate_destination should be false, as the 5th region is the destination 13:48:38 <xarick> let's see if I can solve this without breaking it 13:49:24 <xarick> i think i can't without changing something fundamental 13:54:02 <xarick> maybe I don't need to do anything at all... 13:54:14 <aviationgamerx> LordAro: oh so I don't need to return anything 13:54:42 <xarick> this call is from the order, so there's no limit to the cost of the path 13:55:36 <xarick> it would be nice if the path results matched, but in this case... it doesn't matter 13:55:47 <xarick> I'm being too assertive for no reason 13:57:17 <xarick> ship will still end up going to the depot I specified 14:10:59 <aviationgamerx> LordAro: but even without the return it doesn't seem to fix it 14:13:31 <xarick> I can try and do something about it... instead of getting only the first 5 regions, the first 6. If there are 5 or more regions in the path, also check if it is the last and set intermediate_destination if it isn't. 14:14:03 <xarick> terrible englsih typos 14:15:11 <xarick> i might end up in a cat and mouse cycle though 14:19:06 <xarick> what if the llpf finds a depot in a place where it results in 6 regions... 14:19:19 <xarick> hmm :p 14:19:23 <xarick> unsolveable problem 14:25:29 <_glx_> in the screenshot ship and circled depot are in the same region, but there's not path inside the region 14:29:56 <peter1138> Where does the water region patch fit in there? 14:30:03 <talltyler> Why are you doing the conversion of the old setting value in the setting callback? 14:31:40 <aviationgamerx> talltyler: well I tried switching it to a percentage, but make it still change the value after changing the percentage 14:35:10 <xarick> I wish there was a delete all groups button 14:35:24 <xarick> need to stop all ships, but one 14:37:08 <aviationgamerx> since the setting changes the value directly, making it into percentage meant making a new variable that carries the percentage, at least that was one way to do it 14:37:08 <aviationgamerx> and the main max_loan variable has to change as well, so I made it change after the percentage changes 14:39:00 <aviationgamerx> talltyler: unless you mean the currency conversion 14:40:18 <aviationgamerx> I think I put it because the currency automatically converted with the currency flag 14:40:37 <aviationgamerx> which I removed since it's working with percentage 14:40:48 <aviationgamerx> so I had to make it converted in here 14:41:56 <aviationgamerx> problem is now is the intializer list thing, I am struggling to understand it 14:42:48 <johnfranklin> These days I haven’t seen andriydohniak 14:52:40 <xarick> wish i could make the debugger draw the two paths... 14:58:10 <xarick> ok, i can 🙂 15:03:25 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1291052930761490573/image.png?ex=66feb23d&is=66fd60bd&hm=921fb11fc32cb315adcdc48e18048d93e40e3abe6de8047e153f0625c36775ff& 15:03:25 <xarick> there it is 15:04:14 <xarick> first call hlpf wanted the depot pointed by the red arrow, llpf decided the depot pointed by green arrow 15:04:43 <xarick> second call hlpf pointed to green arrow, llpf however picked the intermediate path 15:04:56 <xarick> with is the path on the right, leading to nowhere 15:05:41 <xarick> oh, forgot to circle depot in green 15:06:17 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1291053653741801624/image.png?ex=66feb2e9&is=66fd6169&hm=f4df137683004417d77893fec88c6ac06d2d953d1b6340cc24eabd62185f4096& 15:06:24 <xarick> better image 15:07:18 <kuhnovic> And that's why a depot should be chosen _and the ship should stick to it_ 15:07:35 <xarick> in this case, it's fine 15:07:52 <xarick> it's a order from the order list 15:08:00 <peter1138> Deal with that outside the pathfinder. 15:08:15 <kuhnovic> I can explain it all one more time, but I'm not going to, because you're going to implement something random anyway that has nothing to do with it 15:08:27 <xarick> ^_^ 15:30:18 <xarick> // DEBUG_clearDrawInstructions(); 15:30:21 <xarick> interesting 15:32:12 <xarick> ```assert(track == track2 || 15:32:12 <xarick> (track == INVALID_TRACKDIR && best_origin_dir == reverse_dir) || 15:32:12 <xarick> (forward_dirs == forward_dirs2 && max_penalty == 0));``` 15:32:30 <xarick> new testings 15:37:10 <xarick> not sure this is correct, must think 15:49:14 <aviationgamerx> LordAro: ohhhhhhhhhhhh 15:49:15 <aviationgamerx> I got it 15:49:38 <aviationgamerx> post_cb is not supposed to take `[](auto &new_value)` 15:49:51 <aviationgamerx> it only allows `[](auto)` 15:49:59 <aviationgamerx> it actually ran 15:50:27 <aviationgamerx> that was the paramater causing the error all along 15:50:49 <aviationgamerx> thanks a lot 15:53:12 <aviationgamerx> https://cdn.discordapp.com/attachments/1008473233844097104/1291065459969622037/image.png?ex=66febde8&is=66fd6c68&hm=9439fbc0217e37505c84919ab7ed10373f6475ef0a79acf6e9b65b76a0095958& 15:53:12 <aviationgamerx> alr first succeful run, check 15:53:12 <aviationgamerx> first "that's not supposed to happen", check 16:36:34 <DorpsGek> [OpenTTD/OpenTTD] WenSimEHRP commented on discussion #12970: New inflation settings https://github.com/OpenTTD/OpenTTD/discussions/12970 16:57:56 <xarick> running new set of tests 16:57:59 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1291081761329119232/image.png?ex=66fecd17&is=66fd7b97&hm=55c41da1d10c6333a7cc2ce5111d9f3e416c9b1784e00a1a3ffde10d67dcc2d5& 17:02:42 *** HerzogDeXtEr has quit IRC 17:03:43 *** HerzogDeXtEr has joined #openttd 17:07:06 <xarick> I'm finally dealing with the track that comes after checkshipreverse 17:07:27 <xarick> a 3 step verification 17:10:14 <xarick> <https://gist.github.com/SamuXarick/076d15b11633fcbccb80c2e9bca3a9a8> 17:15:24 <aviationgamerx> https://cdn.discordapp.com/attachments/1008473233844097104/1291086141738713159/image.png?ex=66fed12b&is=66fd7fab&hm=23e1626117cd9f5b58577706c4d5f134bb65a35a57badf4f0db9f582b1f92908& 17:15:24 <aviationgamerx> is there a way to make this line run while the game is opening 17:15:49 <LordAro> probably not 17:16:10 <aviationgamerx> or run right after the main setting is loaded 17:17:01 <aviationgamerx> it seems to stay 0 at intilization and even when changing the main setting 17:17:38 <LordAro> there is the concept of "ini file version", i think you probably need something in there 17:18:10 <LordAro> see IFV_AUTOSAVE_RENAME for something similar 17:26:15 <talltyler> I have not looked at the code, but keeping the old setting, adding a new one, and tying the two together seems to be the wrong way to go 17:27:50 <talltyler> In my mind, you need one setting that holds the percent, and then a helper function that calculates the actual money equivalent to be used everywhere that needs said money equivalent. 17:29:03 <_glx_> yeah allowing to set both percent and value is asking for trouble 17:29:37 <aviationgamerx> LordAro: I am not sure how that works or ties with the problem 17:29:37 <talltyler> This involves some saveload conversion to get the old outdated setting and calculate the new setting value, but I’m pretty sure I did it wrong with service intervals so don’t look at me for help with that 😛 17:30:36 <_glx_> service interval is not the best example as it was holding 2 types of values before you added another one 17:32:49 <aviationgamerx> talltyler: I removed the option of value, the variable is still there, but you can only change the percentage, the post_cb part is what was supposed to take the value and convert it, and I didn't want to mess with whatever calculations happen in the whole code using difficulty.max_loan 17:33:27 <aviationgamerx> https://cdn.discordapp.com/attachments/1008473233844097104/1291090688523505675/image.png?ex=66fed567&is=66fd83e7&hm=e94e63144e7d0a3185230ead81488d010583ca6a77f2a60edb4f0fd9fe42e958& 17:33:27 <aviationgamerx> it looks like how I want it to look but it doesn't seem to be changing anything with diffculty.max_loan 17:35:59 <talltyler> I would replace `difficulty.max_loan` with a `GetMaxLoan()` helper function that does the math 17:37:08 <aviationgamerx> talltyler: that's actually a good idea, never thought of it 17:37:38 <aviationgamerx> hope it does work tho 17:37:49 <talltyler> Oh, it already exists, because dP recently added company-specific max loans that can be controlled by GS… 17:38:14 <aviationgamerx> then GetMaxLoanFromPercentage()? 17:38:40 <talltyler> But that uses `company->max_loan`, so yeah, you shouldn’t have to worry about it 17:38:48 <talltyler> As long as your function names don’t conflict 17:38:59 <aviationgamerx> alr thanks 17:40:38 <xarick> I got an email from github... <https://github.com/SamuXarick/OpenTTD/actions/runs/11148611470/job/30985593022> 17:56:30 <xarick> Linux (Clang) / CI 17:56:30 <xarick> failed 18:07:48 <aviationgamerx> https://cdn.discordapp.com/attachments/1008473233844097104/1291099330534445056/image.png?ex=66fedd73&is=66fd8bf3&hm=ace55a4f731fe86feb4b68e754c8fc1671a1a2b0d7d0a5004989aee9f06579fd& 18:07:48 <aviationgamerx> is there a problem if I add the function here? or is there supposed to be a place for functions like these 18:19:36 *** Wolf01 has joined #openttd 18:30:42 <xarick> ///< are disaligned 18:31:27 <talltyler> Inside the structure would be a weird place 😉 18:34:06 <aviationgamerx> xarick: will worry about that later lol 18:34:46 <talltyler> Comments are misaligned now, don’t worry about it 🙂 18:34:59 <aviationgamerx> talltyler: weird or illegal? It does seem like the best place for it 18:35:29 <talltyler> We stopped caring about alignment because it was making diffs huge, and then did some batch renaming that misaligned things all over the codebase 18:35:52 <talltyler> Definitely don’t put it in the struct 18:37:11 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1291106726254350409/image.png?ex=66fee457&is=66fd92d7&hm=34a5f8de421b6caca6d703e1efb2d3378810cec7c7490559440b8ac792a5cb3a& 18:37:11 <xarick> what do I want to test now? 18:37:49 <aviationgamerx> talltyler: alr 18:37:56 <talltyler> `company_base.h` seems like a suitable place to me, for now anyway. You can always move it later 🙂 18:46:52 <aviationgamerx> talltyler: wherever I put I am gonna have to include currency.h 18:48:49 <aviationgamerx> not sure why I would place it in here specifically but I will go with it 18:53:09 <aviationgamerx> https://cdn.discordapp.com/attachments/1008473233844097104/1291110745861259376/image.png?ex=66fee815&is=66fd9695&hm=9c72b9edad59769a107dd66e484963474d546324e6c1e83ddf17d77daa3b319d& 18:53:10 <aviationgamerx> https://cdn.discordapp.com/attachments/1008473233844097104/1291110746192744519/image.png?ex=66fee815&is=66fd9695&hm=f2c82468a2810bed85ba275502ef3fe36858ed7db7985a70301fec69c1583703& 18:53:10 <aviationgamerx> what is up with all the 1000 here? 18:53:37 <aviationgamerx> something about a new game saving mechanic, not sure what it means 18:54:28 <aviationgamerx> it multiplies what exactly with a 1000? and why 19:01:18 <_glx_> Old setting used to omit final 000 19:01:46 <_glx_> But it's very old 19:19:00 <aviationgamerx> https://cdn.discordapp.com/attachments/1008473233844097104/1291117250992148563/image.png?ex=66feee24&is=66fd9ca4&hm=0939e8ff5598e2d466a9fcceecaf4c0e5391fc5c882358a9c9849b8625df68f9& 19:19:00 <aviationgamerx> ok wth 19:21:42 <aviationgamerx> 240 errors all in different .obj files 19:26:44 <aviationgamerx> https://cdn.discordapp.com/attachments/1008473233844097104/1291119197174239253/image.png?ex=66feeff4&is=66fd9e74&hm=324fa134dddc67609c336aa7cdf6e3a3dd62151579c436a098f5d311c1b6e671& 19:32:19 <aviationgamerx> what does this mean 19:32:59 <aviationgamerx> what have I done to make it all blow up like that 19:33:12 <xarick> making a wild guess: missing include somewhere 19:33:16 <xarick> probably wrong 19:33:44 *** nielsm has quit IRC 19:35:32 <xarick> or static vs inline or whatever 19:35:56 <bigyihsuan> aviationgamerx: only ever `#include` header files `.h`, if you include `.cpp` files it gives you those errors 19:37:30 <xarick> I have 2 issues yet... 19:38:14 <xarick> a nearest depot order after a buoy order is issuing a forward and backward search 19:38:28 <xarick> should only issue a forward search 19:39:14 <aviationgamerx> bigyihsuan: does the same rule apply if I implement a function in a .h file? 19:39:18 <bigyihsuan> no 19:39:29 <aviationgamerx> because there is no .cpp includes 19:41:45 <xarick> manually sending ship to depot is also issuing a forward and backward search. Either only issue forward search, or issue both ways but add a big cost for the reverse path 19:43:04 *** tokai has joined #openttd 19:43:04 *** ChanServ sets mode: +v tokai 19:47:35 <xarick> i prefer the 2nd option 19:49:53 *** tokai|noir has quit IRC 19:57:44 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1291126995459117168/image.png?ex=66fef737&is=66fda5b7&hm=0d12ffceac8a5ae3d3149344eb8c1868cd5373acb20571970430cfa2a07ed086& 19:57:44 <xarick> there is a depot behind the ship, but when the search is forward looking only, it returns no depot 😐 20:00:25 <aviationgamerx> https://cdn.discordapp.com/attachments/1008473233844097104/1291127673388535841/image.png?ex=66fef7d9&is=66fda659&hm=02796f7dd2ad14dae6a80f9e61d9eb9d7725fd1e4b585183024d3e00e4049499& 20:00:25 <aviationgamerx> bigyihsuan: thankfully all I had to do was make the function inline 20:04:11 <aviationgamerx> ok need confirmation on this 20:05:24 <aviationgamerx> do I make the percentage interval in 10%, 50% or 100%? 20:05:24 <aviationgamerx> 100 -> 110 -> 120 -> 130 20:05:24 <aviationgamerx> 100 -> 150 -> 200 -> 250 20:05:24 <aviationgamerx> 100 -> 200 -> 300 -> 400 20:13:46 <aviationgamerx> as of right now it seems to be always rounding down to the last 100% 20:15:11 <aviationgamerx> it is currently working well that way 20:15:22 <aviationgamerx> but it means less customization 20:15:43 <aviationgamerx> I will wait for you guys to reply and finally finish this thing 20:26:48 <talltyler> Interval is just what the buttons do, you can always click the value to enter a custom value 20:29:32 <aviationgamerx> talltyler: oh, but the code sitll automatically rounds to the last 100% anyway 20:29:56 <aviationgamerx> if you enter any value between 100 and 200 it will still be 100 20:32:06 <aviationgamerx> should I make it that it accepts any whole percentage? 20:32:56 <aviationgamerx> 112% would 336000 normally, as right now it goes down to 300000 anyway 20:43:57 <aviationgamerx> although I am unsure what is making it always round to these values 20:44:12 *** D-HUND has joined #openttd 21:01:11 <aviationgamerx> alr I will treat it as 100% 21:01:59 <aviationgamerx> if anyone liked to change it in the future, they can make a whole other story for it 21:02:06 <aviationgamerx> thanks for the help everyone 21:02:24 <aviationgamerx> I shall finalize this thing 21:06:10 <soylent_cow[m]> this is probably a stupid question, sorry, but when i query service intervals with setting, they appear completely unrelated to what's in config, and yet the config values seem to work just fine. 21:06:37 <soylent_cow[m]> and the question is, am i missing something? 21:13:20 *** Wormnest has joined #openttd 21:32:31 <xarick> guys! 21:32:41 <xarick> I think I'm done 21:33:24 <xarick> https://github.com/OpenTTD/OpenTTD/compare/master...SamuXarick:find-nearest-depot-with-multiple-destinations?expand=1 21:34:11 <xarick> the code is that, i still didn't document the stuff, I'm bad at that 21:34:28 <xarick> but it's functional, I'd like kuhnovic to take a look 21:34:41 <xarick> I will document tomorrow 21:50:08 *** keikoz has quit IRC 22:02:14 *** Wolf01 has quit IRC 22:14:51 <DorpsGek> [OpenTTD/OpenTTD] AviationGamerX opened pull request #12974: Fix #8932: Changed Max Loan in Settings From Currency Value to Percentage https://github.com/OpenTTD/OpenTTD/pull/12974 22:15:29 <aviationgamerx> it has been done 22:31:09 <talltyler> 🎉 22:32:41 <talltyler> Congratulations! Now comes the hard part, where we help you make it work with loading old savegames and meet code standards. I’ll be honest, you’ve got some work ahead of you. 😉 22:32:58 <talltyler> But we will guide you through it. 🙂 22:36:19 <aviationgamerx> talltyler: alright, I am with you guys till it's fully done