Times are UTC Toggle Colours
00:00:37 <_glx_> aggreed, looks better 01:24:04 *** Wormnest has quit IRC 01:57:22 *** Wormnest has joined #openttd 02:10:35 <DorpsGek> [OpenTTD/wiki-data] TrueBrain approved pull request #41: Remove: Page/en/Development/NewGRF/Specification Status directory https://github.com/OpenTTD/wiki-data/pull/41#pullrequestreview-2471295221 02:32:55 *** tokai has joined #openttd 02:32:55 *** ChanServ sets mode: +v tokai 02:39:49 *** tokai|noir has quit IRC 02:48:09 *** Tirili has joined #openttd 03:11:52 *** gnu_jj has joined #openttd 03:14:09 *** Tirili has quit IRC 03:14:49 *** gnu_jj_ has quit IRC 03:26:56 *** Wormnest has quit IRC 03:58:01 *** D-HUND has joined #openttd 04:01:24 *** debdog has quit IRC 04:04:37 *** D-HUND is now known as debdog 04:35:06 *** speeder has quit IRC 04:47:52 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/1885bd7166329587f002f468ff9285a1482b641d 04:47:53 <DorpsGek> - Update: Translations from eints (by translators) 05:09:34 *** keikoz has joined #openttd 05:13:16 <wensimehrp> https://cdn.discordapp.com/attachments/1008473233844097104/1312647685513416714/image.png?ex=674d41ec&is=674bf06c&hm=f6385ee7dc09d871d70fc82e02b6f1196c38448759e4c0aed37f9757b3b9c2a2& 05:13:16 <wensimehrp> hmm 05:14:30 <wensimehrp> https://cdn.discordapp.com/attachments/1008473233844097104/1312647995996635146/image.png?ex=674d4236&is=674bf0b6&hm=2f7405b6ff38195426ac8fd58693fadd2ea9f2ab8bf1c085cd6a38934e23b7e4& 05:15:33 <wensimehrp> https://www.w3.org/TR/clreq/#punctuation_width_adjustment 05:15:45 <wensimehrp> ๐ minor problem though 05:18:14 <wensimehrp> https://www.w3.org/TR/jlreq/#necessity_for_line_adjustment 06:04:28 *** XYZ has joined #openttd 06:08:34 *** XYZ_ has quit IRC 07:40:37 *** Wolf01 has joined #openttd 07:44:36 *** bohaska has joined #openttd 07:44:38 <bohaska> wensimehrp: don't the Chinese-style brackets naturally have space at their ends? like they look like this 07:44:38 <bohaska> ๏ผ๏ผ๏ผ๏ผ 07:44:38 <bohaska> even without any additional space 07:45:03 <wensimehrp> yeah but when you have multiple punctuations the spaces should merge 07:45:21 <wensimehrp> say ๏ผ๏ผ combo 07:45:28 <bohaska> How do they implement that in existing systems? 07:45:39 <bohaska> Replace it with normal ()() brackets? 07:45:47 <wensimehrp> bohaska: that would be terrible then 07:46:23 <wensimehrp> I spent ages replacing half-width punctuation with proper full-width punctuation โน๏ธ 07:46:44 <bohaska> That seems like a giant pain to do... 07:48:24 <bohaska> wensimehrp: how would you combine two brackets together? like, what characters would you use? can you send a discord message that merges these brackets correctly? 07:49:25 <wensimehrp> ๆต่ฏๆต่ฏๆต่ฏ๏ผ่ฟไนๆฏๆต่ฏ๏ผ๏ผ่ฟ่ฟๆฏๆต่ฏ๏ผ 07:49:25 <wensimehrp> ๆต่ฏๅ ซๅๅ่ทฏ๏ผโไฝ ็ๅคงๅคงๅฐๅฅฝ๏ผโๅ ซๅๅ ซๅ 07:49:57 <wensimehrp> bohaska: there aren't any special characters connecting the punctuation 07:50:08 <wensimehrp> it mostly depends on the font and the formatting engine 07:50:21 <wensimehrp> most modern web browsers have well support for that 07:51:44 <bohaska> good luck 07:56:05 <wensimehrp> https://cdn.discordapp.com/attachments/1008473233844097104/1312688659341901887/image.png?ex=674d6814&is=674c1694&hm=69995314d20dace1fe5cf9c09b27fe27a3a72aa98e15f249b98e61865bdc279b& 07:56:05 <wensimehrp> strange... 07:56:25 <wensimehrp> the quotation mark and the comma didn't merge 08:04:07 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13136: Change: [UI] Tweak news window layouts. https://github.com/OpenTTD/OpenTTD/pull/13136#pullrequestreview-2471332394 08:30:24 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1312697294650605618/image.png?ex=674d701f&is=674c1e9f&hm=66a2f5a199949ce4a7d16f08cd02d3eff6764d7cf6f1cde24dfb796384d6e1c6& 08:30:24 <peter1138> Yeah 08:31:52 <peter1138> wensimehrp: `STR_INDUSTRY_DIRECTORY_ITEM_INFO :{BLACK}{CARGO_LONG}{STRING}{YELLOW}๏ผ{COMMA}% ๅทฒ่ฟ่พ๏ผ{BLACK}` 08:33:14 <peter1138> So is it ") (" or ")(" ? 08:35:13 <peter1138> Oh directory, so not that string at all. Idiot. 08:39:27 <peter1138> https://cdn.discordapp.com/attachments/1008473233844097104/1312699573252391023/image.png?ex=674d723f&is=674c20bf&hm=9ea37cace054e9b8449be035d5154af5e1a1023b76c6c80556701f9f5d4844f0& 08:39:27 <peter1138> Well, can't see when there's no suffix. 08:48:21 <wensimehrp> I'm using jgrpp 08:48:47 <peter1138> Condolences. 08:49:05 <wensimehrp> ๐จ 08:49:25 <peter1138> Cargo suffix text is a vanilla feature, but not used by my version of FIRS here. 08:49:38 <peter1138> Of course you might not even be using FIRS. 08:49:44 <wensimehrp> I am 08:49:58 <wensimehrp> FIRS git version 08:50:03 <peter1138> Or it might depend on the state of the game. 08:53:40 <wensimehrp> https://cdn.discordapp.com/attachments/1008473233844097104/1312703148237783080/image.png?ex=674d7593&is=674c2413&hm=df25ae17b5bbfa3e244ec3f78e6ba5bc3502ab51a38c8f64bffa7bd1cb9367e4& 08:53:40 <wensimehrp> https://cdn.discordapp.com/attachments/1008473233844097104/1312703148586041384/image.png?ex=674d7593&is=674c2413&hm=8445c3b8abd10c5cb6f5dbce54e902c62c2981a4e37c06420374cf2c9f583d2f& 08:53:40 <wensimehrp> There's another place where the punctuation is displayed incorrectly, and it may be trickier 08:55:38 <peter1138> /* Add a comma if this is not the first item */ 08:55:38 <peter1138> builder += ", "; 08:55:44 <peter1138> Is that this one? 08:55:50 <wensimehrp> 3980:STR_INDUSTRY_DIRECTORY_ITEM_PROD2 :{ORANGE}{INDUSTRY} {STRING}ใ{STRING} 08:55:50 <wensimehrp> 3981:STR_INDUSTRY_DIRECTORY_ITEM_PROD3 :{ORANGE}{INDUSTRY} {STRING}ใ{STRING}ใ{STRING} 08:55:50 <wensimehrp> 3982:STR_INDUSTRY_DIRECTORY_ITEM_PRODMORE :{ORANGE}{INDUSTRY} {STRING}ใ{STRING}ใ{STRING}โฆโฆ๏ผๅฐๆ {NUM} ไธชๆชๆพ็คบ๏ผ 08:55:50 <peter1138> Not sure. 08:56:07 <wensimehrp> These ones I think 08:57:52 <wensimehrp> peter1138: This does not apply to Chinese though. Chinese uses `ใ` as the separator (the comma is `,`) 08:58:05 <peter1138> Sure. 08:58:10 <peter1138> But this isn't that anyway. 08:58:15 <wensimehrp> yeah 08:58:46 <peter1138> Last time someone attempted to make things different based on localisation settings it all got out of hand with "this doesn't work now" that it all got reverted. 08:58:57 <wensimehrp> โน๏ธ 08:59:19 *** XYZ has quit IRC 09:00:27 <wensimehrp> https://cdn.discordapp.com/attachments/1008473233844097104/1312704854770192455/image.png?ex=674d772a&is=674c25aa&hm=f0c630c396310e0c88ca994d4efbfb7a317fc0ee73a167da3f112f8aa61a91ce& 09:00:27 <wensimehrp> Least for this case, the `{STRING}` holding the cargo name and transport status contains colour codes. The last piece of punctuation is a closing parenthesis, and it should merge with the separator following 09:00:28 *** XYZ has joined #openttd 09:00:47 <peter1138> So in the string that is "๏ผใ" 09:00:54 <wensimehrp> yes 09:01:08 <peter1138> The space is because it's full-width characters. 09:01:19 <wensimehrp> I think OpenTTD supports ligatures already? 09:01:45 <peter1138> Ligatures are a font-specific feature. 09:02:36 <peter1138> Fonts can, e.g. combine "ff" to "๏ฌ", if they want to. 09:03:10 <peter1138> So the font you use could combine "๏ผใ" if it wanted to. 09:08:07 <wensimehrp> https://cdn.discordapp.com/attachments/1008473233844097104/1312706784842092564/image.png?ex=674d78f6&is=674c2776&hm=10550b7870a657496b8ae8b39e493869fb0cbb3a8291efabf46989bf4082c10c& 09:08:07 <wensimehrp> It doesn't want to merge anything 09:08:40 <wensimehrp> https://cdn.discordapp.com/attachments/1008473233844097104/1312706923572756500/image.png?ex=674d7917&is=674c2797&hm=e6b6d839bec451078988be427616a527f7d66bb2d2d3cc1f637c21239f05c5d5& 09:08:40 <wensimehrp> Noto Sans CJK 09:09:28 <wensimehrp> https://cdn.discordapp.com/attachments/1008473233844097104/1312707128338677820/image.png?ex=674d7948&is=674c27c8&hm=52b72640ee9cc2c153f272885703c5c8f8a1e4d6b78f3d94f252e66fe4a56a13& 09:09:28 <wensimehrp> Source Han Sans CN 09:11:50 *** Flygon has quit IRC 09:18:23 *** asasnat has quit IRC 09:18:23 *** digitalsoma has quit IRC 09:18:23 *** locosage has quit IRC 09:18:24 *** belajalilija has quit IRC 09:18:24 *** _jgr_ has quit IRC 09:18:24 *** audigex has quit IRC 09:18:24 *** brickblock19280 has quit IRC 09:18:26 *** masterhellish has quit IRC 09:18:26 *** mnhebi has quit IRC 09:18:26 *** xarick has quit IRC 09:18:28 *** sam_chug has quit IRC 09:18:28 *** yiffgirl has quit IRC 09:18:28 *** talltyler has quit IRC 09:18:28 *** ellwill has quit IRC 09:18:28 *** johnfranklin has quit IRC 09:18:29 *** emperorjake has quit IRC 09:18:29 *** jfinance has quit IRC 09:18:29 *** kuhnovic has quit IRC 09:18:29 *** _glx_ has quit IRC 09:18:29 *** DorpsGek_vi has quit IRC 09:18:29 *** wensimehrp has quit IRC 09:18:29 *** exceptik has quit IRC 09:18:29 *** peter1138 has quit IRC 09:18:31 *** squirejames has quit IRC 09:18:33 *** herringland has quit IRC 09:18:51 *** bohaska has quit IRC 09:18:51 *** merni has quit IRC 09:18:53 *** gwyd4016 has quit IRC 09:18:54 *** reldred has quit IRC 09:18:56 *** xarothbrook has quit IRC 09:18:58 *** gadg8eer has quit IRC 09:19:15 *** de_schmitt has quit IRC 09:19:15 *** michi_cc[d] has quit IRC 09:19:15 *** bigyihsuan has quit IRC 09:19:15 *** truebrain has quit IRC 09:19:36 *** DorpsGek_vi has joined #openttd 09:21:32 *** johnfranklin has joined #openttd 09:21:32 <johnfranklin> Yesterday I consumed too little coffee and slept for 15 hours 09:32:40 *** kuka_lie has joined #openttd 09:39:26 *** kuka_lie has quit IRC 09:39:49 *** kuka_lie has joined #openttd 09:40:46 *** bohaska has joined #openttd 09:40:46 <bohaska> peter1138: I don't think it's usually done that way because it's inefficient to make a ligature for every single copy of a right space and a left space character together, and it seems to be implemented in text rendering most of the tme 09:41:42 *** andythenorth has joined #openttd 09:41:42 <andythenorth> right what was I doing? 09:41:46 <andythenorth> I've lost all context ๐ 09:41:50 <LordAro> he's back! 09:41:56 <LordAro> as far as i'm concerned 09:41:58 *** peter1138 has joined #openttd 09:41:58 <peter1138> Sure. What I meant was that ligatures are already supported, so it is, indeed, NOT a font ligature in this case. 09:42:07 <andythenorth> so I can't use unicode fractions in this channel? 09:42:51 <LordAro> apparently not 09:42:53 <LordAro> someone should fix that 09:43:48 <johnfranklin> ๏ผน๏ผฏ๏ผตใ๏ผฃ๏ผก๏ผฎ 09:44:15 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13136: Change: [UI] Tweak news window layouts. https://github.com/OpenTTD/OpenTTD/pull/13136 09:44:55 <andythenorth> how will I make my 15KV 16.7Hz AC railtype? ๐ 09:45:09 <andythenorth> 16 2/3 09:45:28 <peter1138> 16.666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666666 Hz 09:45:57 <andythenorth> if only there was a mathematical convention for recurring 09:46:57 <andythenorth> wait 09:47:01 <andythenorth> did I hallucinate this? 09:47:04 <johnfranklin> 50/3 09:47:22 <andythenorth> I did A-level and degree level engineering maths (wasn't very good but eh) 09:47:34 <andythenorth> we were taught a convention call 'dot' for recurring decimals 09:47:38 <andythenorth> google cannot find it 09:48:29 <andythenorth> maybe I imagined that, or the narrative timelines have been adjusted 09:48:52 <peter1138> <https://en.wikipedia.org/wiki/Repeating_decimal> 09:49:52 <Heiki> 16.6ฬ 09:50:47 <johnfranklin> Fuck, the train is cancelled. 09:51:50 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1312717788279869501/F4D5EC2F-FA5A-444C-B225-7D412E2B9F95_1_102_a.jpeg?ex=674d8335&is=674c31b5&hm=87373f1eff58698dc9ebfca70c5f8b48eff0efaa6c2365a1c08cb5d02640e2b2& 09:51:50 <andythenorth> Yeah looks it was 'dots' above. I remember it like this though 09:52:05 <andythenorth> to avoid conflating with 'degree' 09:52:09 <peter1138> 16.6โข 09:52:26 <andythenorth> that ๐ 09:52:32 <andythenorth> seems to be hallucination 09:54:08 <johnfranklin> No? It should be the dot on top, or there are different notations 09:54:34 <johnfranklin> And I heard the UK tradition is the decimal point is in the middle 09:54:50 <andythenorth> mine was just hallucinated, nobody does what I've drawn 09:55:01 <johnfranklin> 16โข6 09:55:07 <andythenorth> nobody does that either ๐ 09:55:22 <LordAro> 16๐6 09:56:03 <johnfranklin> That book was written in 1997, maybe things are different now 10:06:43 <DorpsGek> [OpenTTD/dibridge] LordAro opened pull request #252: Update dependencies https://github.com/OpenTTD/dibridge/pull/252 10:07:52 <LordAro> typing-extensions! 10:08:29 <DorpsGek> [OpenTTD/dibridge] LordAro updated pull request #252: Update dependencies https://github.com/OpenTTD/dibridge/pull/252 10:17:07 <DorpsGek> [OpenTTD/dibridge] LordAro updated pull request #252: Update dependencies https://github.com/OpenTTD/dibridge/pull/252 10:41:19 *** michi_cc[d] has joined #openttd 10:41:19 <michi_cc[d]> andythenorth: By literally writing 16.7 Hz. Exact 16 2/3 Hz isn't actually used anymore because of harmonic interference. So it really is 16.7 nowadays. 10:43:47 <andythenorth> ha ๐ 10:45:11 <peter1138> Someone will then need to make another 10 railtypes to differentiate between 16.6ยท and 16.7... 10:45:19 <andythenorth> won't be me ๐ 10:46:54 <andythenorth> can anyone remember current state of grf strings (and what nml is doing with them)? 10:47:14 <andythenorth> I thought Horse had used them all, but seems not 10:47:15 <andythenorth> ` nmlc info: D0xx strings: 50/1024 10:47:15 <andythenorth> nmlc info: DCxx strings: 501/10240` 10:49:17 <andythenorth> hmm the 110132 STORE_TEMP ops to the text stack might be why I didn't run out of string IDs ๐ 10:49:25 <andythenorth> "probably fine" 10:49:43 *** xarick has joined #openttd 10:49:43 <xarick> woah 126 messages since yesterday 10:54:13 *** _glx_ has joined #openttd 10:54:13 <_glx_> andythenorth: Nml tries to use DCxx when possible 10:56:34 <_glx_> Since <https://github.com/OpenTTD/nml/pull/326> 10:57:48 <andythenorth> I see ๐ 10:58:04 <andythenorth> wonder if I can reduce my 110132 text stack ops ๐ 10:58:35 <andythenorth> they are all in the `name` callback ๐ 10:59:36 <_glx_> Numbers seems to imply a lot of duplicated names, so only 501 DCxx 11:00:34 <andythenorth> it's all related to handling different variant levels 11:00:51 <andythenorth> any variant can become the parent in the tree 11:01:03 <andythenorth> which needs different strings 11:01:06 <andythenorth> and there's autoreplace as well 11:01:51 <andythenorth> 'badges' maybe? 11:02:06 <peter1138> IMHO the name callback is silly, engines shouldn't be able to rename themselves. But it is there. 11:02:31 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1312735579603210360/image.png?ex=674d93c7&is=674c4247&hm=5492afb4ef4a8fc2b9fd81dd66887c65838803e2f7889c21eb8cf6cb77b230e9& 11:03:07 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1312735726479343626/image.png?ex=674d93ea&is=674c426a&hm=a7cf5b6fc6ddc0cfd7e5130adc5f58d427d38abfce3b22aff31f58f4e7d1f632& 11:03:07 <andythenorth> maybe this would be fine also 11:04:07 <andythenorth> 'probably fine', but the callback handling for the suffix is templated in anyway, so I dropped it 11:04:30 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1312736077924274246/image.png?ex=674d943e&is=674c42be&hm=6f83f7f568f755cd438e35b1881c2d32ba7ea9b5ba6b3b7612308257e5616546& 11:04:30 <andythenorth> name callback means I can do this ๐ 11:05:07 <peter1138> Hmm, should that be a badge feature? 11:05:11 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1312736250536656936/image.png?ex=674d9467&is=674c42e7&hm=374a7aef78e9a1d8cf5a83edc8d6eb401d277412db3c807324afd40d44805a93& 11:05:11 <andythenorth> oof I've missed a case though ๐ 11:05:20 <andythenorth> more callback handling needed ๐ 11:05:26 <peter1138> Currently you get "Power: Diesel" in the additional text. 11:06:05 <andythenorth> variants as folders was never really expected ๐ 11:06:38 <peter1138> Power units should be in a separate hierarchy to coaches. 11:06:51 <andythenorth> then they're really hard to find ๐ 11:07:19 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1312736787583598592/image.png?ex=674d94e7&is=674c4367&hm=0fa0bbea8aa35b1de09b8d34fd82702018332208374a9abf754e7d2dc11af714& 11:07:19 <andythenorth> this is convenient ๐ 11:07:41 <andythenorth> maybe we should have arbitrary default buy menu order? ๐ 11:07:46 <andythenorth> or 'tags' 11:07:52 <andythenorth> or 'group buy menu by badge' 11:09:11 <peter1138> Nested 11:10:28 <andythenorth> nested badgers 11:10:36 <andythenorth> do badgers have nests? 11:11:05 <andythenorth> oof seems *every* variant does 11 STORE_TEMP ops for name cb 11:11:16 <andythenorth> even though in most cases, all children are same handling as parent 11:11:43 <andythenorth> I think it's done this way because I ran out of concurrent varact2 IDs, but I might have fixed that in the meantime 11:11:54 <andythenorth> the nfo bloat from this is horrible 11:14:23 <andythenorth> 82 MB nfo with the text stack handling, 72 MB without 11:15:07 <andythenorth> grf is only 2 MB smaller, but eh 11:15:30 <andythenorth> https://cdn.discordapp.com/attachments/1008473233844097104/1312738845778907166/image.png?ex=674d96d2&is=674c4552&hm=f42acb84b424d8e34b4bbc80d9f0f41ac583bae080256a24c157828ebdae9d65& 11:15:30 <andythenorth> do we need engine names at all? ๐ 12:08:28 <peter1138> How many GRF files do people have lying around in their newgrf / content_download directories? 12:09:07 <peter1138> 10s, 100s, or 1000s? 12:12:15 *** merni has joined #openttd 12:12:15 <merni> 521 12:12:20 <xarick> let me check 12:12:26 <merni> 100s is probably common and 1000s probably not rare if you include old versions. 12:13:02 <xarick> 88 12:14:49 <xarick> I'm dealing with a strange assert ๐ฆ 12:17:30 <xarick> TestRiverConnection doesn't find a path but when i go look at it, the river is connected 12:18:33 *** truebrain has joined #openttd 12:18:33 <truebrain> peter1138: Something to add to the survey? 12:24:20 <peter1138> Nah, it's not important. 12:24:38 <peter1138> I suspect I have more than most given I test a few things here and there. 12:24:58 <peter1138> But then again, I've never added enough NewGRFs to think a limit needs to be increased. 12:25:16 <truebrain> It is a curious number to have, tbh.. we always talk about caching the scan, but how many people benefit? ๐ 12:25:49 <peter1138> I have around 1000, but the scan does not take very long, so...? 12:26:34 <peter1138> It's noticeable on debug, but otherwise is just a second. 12:26:48 <peter1138> Probably SSDs helped? 12:28:04 <andythenorth> I have ~400 12:28:16 <andythenorth> mostly I don't use them 12:28:29 <xarick> oh, I got a max_search_nodes limit reached on TestRiverConnection ๐ฆ 12:34:57 *** mnhebi has joined #openttd 12:34:57 <mnhebi> 654 grfs 12:35:42 <mnhebi> quite a few of those are just version upgrades tho 12:36:14 <peter1138> I just like to download lots of them so I can complain about them ๐ 12:36:16 <mnhebi> like 60 versions of Tot's cargo distance mod lol 12:37:28 <peter1138> At least the scrollbar slider is usable now. 12:40:16 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13137: Codechange: Store GRFConfig parameters in a vector. https://github.com/OpenTTD/OpenTTD/pull/13137 12:43:10 <johnfranklin> https://cdn.discordapp.com/attachments/1008473233844097104/1312760908296097844/IMG_6036.jpg?ex=674dab5e&is=674c59de&hm=f0b878f61a56fe6149c65416eec337303e26e5ae7c1c95f06d3a9c62ac7f07cc& 12:43:10 <johnfranklin> typical British train services 12:43:30 <peter1138> I think you're getting a bus today. 12:47:00 <johnfranklin> I think I can apply for refunds for very much delayed trains? 12:47:51 <johnfranklin> Now Exp 1304โฆ 12:49:10 *** exceptik has joined #openttd 12:49:10 <exceptik> DB reached britain 12:52:44 <peter1138> Well, DB sold Arriva apaprently, so... 12:54:58 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13137: Codechange: Store GRFConfig parameters in a vector. https://github.com/OpenTTD/OpenTTD/pull/13137 13:08:15 <andythenorth> ๐ https://github.com/OpenTTD/nml/pull/344 and https://github.com/OpenTTD/nml/pull/343 ? 13:41:30 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13138: Codefix: Avoiding passing new raw pointer into a smart pointer. https://github.com/OpenTTD/OpenTTD/pull/13138 13:45:20 *** speeder has joined #openttd 13:48:22 <DorpsGek> [OpenTTD/OpenTTD] LordAro merged pull request #12979: Add #12975: Cargo class bits 13 and 14 now define potable and non-potable. https://github.com/OpenTTD/OpenTTD/pull/12979 13:48:29 <DorpsGek> [OpenTTD/nml] LordAro approved pull request #343: Change: cargo class bits 13 and 14 now define potable and non-potableโฆ https://github.com/OpenTTD/nml/pull/343#pullrequestreview-2471428558 13:48:59 <DorpsGek> [OpenTTD/nml] LordAro approved pull request #344: Change: add vehicle 'refit' callback (cb 0x163) and cargo class filter prop (0x28 for trains etc) https://github.com/OpenTTD/nml/pull/344#pullrequestreview-2471428653 13:52:45 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13137: Codechange: Store GRFConfig parameters in a vector. https://github.com/OpenTTD/OpenTTD/pull/13137#pullrequestreview-2471429075 13:56:45 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13138: Codefix: Avoiding passing new raw pointer into a smart pointer. https://github.com/OpenTTD/OpenTTD/pull/13138#issuecomment-2509781093 13:57:17 <andythenorth> \o/ 14:01:52 <andythenorth> I gave up merge rights on nml ๐ 14:02:00 <andythenorth> fell out with myself ๐ 14:04:29 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13138: Codefix: Avoiding passing new raw pointer into a smart pointer. https://github.com/OpenTTD/OpenTTD/pull/13138#issuecomment-2509784132 14:06:44 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13138: Codefix: Avoiding passing new raw pointer into a smart pointer. https://github.com/OpenTTD/OpenTTD/pull/13138#issuecomment-2509785075 14:13:45 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13137: Codechange: Store GRFConfig parameters in a vector. https://github.com/OpenTTD/OpenTTD/pull/13137#pullrequestreview-2471433705 14:13:58 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13137: Codechange: Store GRFConfig parameters in a vector. https://github.com/OpenTTD/OpenTTD/pull/13137#pullrequestreview-2471433749 14:14:03 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13137: Codechange: Store GRFConfig parameters in a vector. https://github.com/OpenTTD/OpenTTD/pull/13137#pullrequestreview-2471433768 14:14:19 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13137: Codechange: Store GRFConfig parameters in a vector. https://github.com/OpenTTD/OpenTTD/pull/13137 14:14:34 <peter1138> Blahdyblah 14:16:44 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13138: Codefix: Avoiding passing new raw pointer into a smart pointer. https://github.com/OpenTTD/OpenTTD/pull/13138#issuecomment-2509788900 14:17:19 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13137: Codechange: Store GRFConfig parameters in a vector. https://github.com/OpenTTD/OpenTTD/pull/13137#pullrequestreview-2471434443 14:17:38 <DorpsGek> [OpenTTD/OpenTTD] LordAro approved pull request #13138: Codefix: Avoiding passing new raw pointer into a smart pointer. https://github.com/OpenTTD/OpenTTD/pull/13138#pullrequestreview-2471434508 14:22:45 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13138: Codefix: Avoiding passing new raw pointer into a smart pointer. https://github.com/OpenTTD/OpenTTD/pull/13138 14:41:08 *** kuhnovic has joined #openttd 14:41:08 <kuhnovic> xarick: I've decided to clean up my YAPF ship debug drawing and put it in a branch. It's an improved version of the patch you've used in the past. I will try to keep it up to date with master every now and then. https://github.com/Kuhnovic/OpenTTD/tree/YAPF_DEBUG_DRAWING 14:41:33 <xarick> oh, nice ๐ 14:42:06 <LordAro> kuhnovic: worth trying to get it into master behind a key combo perhaps? 14:42:14 <kuhnovic> The drawing functionality might be useful for your river shenanigans as well 14:42:17 <LordAro> ctrl+b etc 14:42:29 <kuhnovic> I'll put it behind Alt-F4 14:42:34 <LordAro> lol 14:43:05 <peter1138> Silly me adding debug features in live code ;p 14:43:33 <kuhnovic> The implementation is quite hacky, I'm messing with the viewport drawing. I don't really feel comfortable putting it in master as it is today. 15:10:44 <xarick> I'm at the last part of my river memes 15:10:54 <xarick> dealing with "partially built rivers" 15:12:35 <xarick> rivers that built up to a point, but then failed to continue because pathfinder reached search node limit 15:13:46 <xarick> in these cases, I am relocating the spring to the last built position 15:14:19 <xarick> and still check if the partially built river is connected 15:15:07 <xarick> and convert canals from the upper parts that failed into clear land 15:15:11 <xarick> my hacky canals 15:15:25 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13137: Codechange: Store GRFConfig parameters in a vector. https://github.com/OpenTTD/OpenTTD/pull/13137 15:16:32 <xarick> but for some reason now I'm not getting the pathfinder to fail in a specific way ๐ฆ 15:18:17 <xarick> it seems to run out of nodes only on the last part that flows down into ocean, and not a level before ๐ฆ 15:27:41 *** speeder has quit IRC 15:36:07 *** speeder has joined #openttd 15:43:41 <xarick> generating trees on arctic is ugly slow 15:43:54 <xarick> it's on my next to do 15:44:08 <xarick> faster trees 16:00:00 *** D-HUND has joined #openttd 16:16:58 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1312814709744992356/image.png?ex=674ddd79&is=674c8bf9&hm=3cc719072bf6388e58b61ecfdec5abba24392f9c7cd24cd211de33c9dcb7d94e& 16:16:58 <xarick> wow... it's actually disconnected 16:17:10 <xarick> not a false positive 16:21:32 <xarick> 5 cases, and they're all positive 16:21:49 <xarick> rivers are hard! 16:26:24 <xarick> and here I was thinking I was about to wrap 16:32:04 <andythenorth> kuhnovic: alias it to `newgame` also ๐ 16:44:59 *** gelignite has joined #openttd 17:11:58 <xarick> how am I solving this situation... 17:12:06 <xarick> more canals? 17:13:41 <xarick> canalise the entire skeleton river? 17:15:27 <xarick> once entire river is build and widened from spring to end, convert canals to rivers 17:15:35 <xarick> very hacky! 18:11:50 *** Flygon has joined #openttd 18:29:12 <xarick> The circular tile search used for widening is a little bit... bad 18:29:21 <xarick> how do I explain 18:31:10 <xarick> maybe it's fine after all, but the way it jumps from a tile to the other 18:32:40 <xarick> for radius 2 is fine, but for radius 3... it jumps from the center to the tile in DIR_W direction, which is not directly adjacent 18:40:01 <peter1138> The function literally explains why. 18:54:18 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13139: Codechange: Pass span of strings to drivers instead of StringList. https://github.com/OpenTTD/OpenTTD/pull/13139 18:56:27 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13139: Codechange: Pass span of strings to drivers instead of StringList. https://github.com/OpenTTD/OpenTTD/pull/13139#issuecomment-2510207595 19:13:13 *** virtualrandomnumber has joined #openttd 19:19:25 *** virtualrandomnumber has quit IRC 19:46:55 *** kuka_lie has quit IRC 20:27:19 <johnfranklin> https://cdn.discordapp.com/attachments/1008473233844097104/1312877713241018389/IMG_6042.jpg?ex=674e1826&is=674cc6a6&hm=2767eceabf136060f676811a3b6a5341cbc6d1a2ab4eeafd81fc64ca66194c71& 20:27:19 <johnfranklin> I give up 20:28:45 <johnfranklin> It is impossible to make it clearer without using other colours ๐ฆ 20:32:11 <andythenorth> seems pretty accurate ๐ 20:43:23 <exceptik> xarick: That repeating pattern doesn't look right ๐ค 20:57:37 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler opened issue #13140: [Bug]: "Production last month" stats at game start not scaled by cargo scale settings https://github.com/OpenTTD/OpenTTD/issues/13140 21:01:45 *** gelignite has quit IRC 21:01:48 <xarick> it's perlin noise something 21:06:56 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1312887685421072506/image.png?ex=674e2170&is=674ccff0&hm=3d247741a54aa5e6997a55e92fe477fde63a70dce6f04e471608c0896028862f& 21:06:56 <xarick> wow this is the worst I've seen 21:11:04 <xarick> ```/* We manually set the Directions to widen the river in adjacent basis manner. */ 21:11:04 <xarick> std::vector<Direction> directions; 21:11:04 <xarick> if (radius >= 2) directions.insert(directions.end(), { DIR_SE, DIR_S, DIR_SW }); 21:11:04 <xarick> if (radius == 3) directions.insert(directions.end(), { DIR_W, DIR_NW, DIR_N, DIR_NE, DIR_E }); 21:11:04 <xarick> for (Direction d : directions) { 21:11:05 <xarick> TileIndex t = AddTileIndexDiffCWrap(tile, TileIndexDiffCByDir(d)); 21:11:05 <xarick> RiverMakeWider(t, reinterpret_cast<void *>(&tile)); 21:11:07 <xarick> }``` 21:11:58 <xarick> didn't help ๐ฆ 21:18:19 <xarick> do i really need to do skeletton river approach? 21:18:44 <xarick> build canals instead of rivers 21:18:53 <xarick> widen up with rivers 21:19:09 <xarick> convert canals to rivers once river is completelly built 21:19:22 <xarick> canals can't be terraformed 21:19:32 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13082: Codechange: Store animated tile state in map to improve performance. https://github.com/OpenTTD/OpenTTD/pull/13082 21:20:25 <xarick> more performant debug mode? 21:20:29 <xarick> let's do it 21:21:40 *** Markk_ has joined #openttd 21:23:48 <DorpsGek> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #12288: Change: Increase house type limit to 4096. https://github.com/OpenTTD/OpenTTD/pull/12288#pullrequestreview-2004211974 21:23:51 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #12288: Change: Increase house type limit to 4096. https://github.com/OpenTTD/OpenTTD/pull/12288 21:32:25 *** Markk_ has quit IRC 21:33:22 *** Markk_ has joined #openttd 21:33:27 <xarick> oh well, let's do skeleton rivers ๐ฆ 21:51:03 *** Wormnest has joined #openttd 21:51:53 <xarick> it worked! 21:51:59 <xarick> but it's so bad 21:52:21 <xarick> makes me sad 21:53:04 *** Markk_ has quit IRC 21:53:28 *** Markk_ has joined #openttd 21:59:34 <andythenorth> so what was I doing? 21:59:43 <andythenorth> removing FIRS animated tiles? 21:59:52 <andythenorth> napping? 22:02:10 *** Markk_ is now known as MarkZwei 22:03:02 *** MarkZwei has joined #openttd 22:04:59 <kuhnovic> Flat docks? 22:06:07 <xarick> dear someone 22:06:16 <xarick> can we have unterraformable rivers? 22:06:34 <xarick> a property 22:06:49 <xarick> some rivers have this temporary property, the others don't 22:07:43 <xarick> so that I can stop using canals for preventing terraform, these rivers would still look like rivers 22:08:04 <andythenorth> unterraformable rivers would be annoying ๐ 22:10:22 <xarick> this property would only be in effect during world gen 22:10:52 <kuhnovic> I actually think it could be a fun challenge. You can't alter any of the rivers / sea, so build bridges instead. 22:11:25 <kuhnovic> But that would be for different reasons than what Xarick wants 22:14:24 <peter1138> River destruction by magic bulldozer 22:15:02 <peter1138> Terraforming is too easy and cheap. 22:17:44 <xarick> is it worth wasting 1 bit in the map array for this abuse? 22:18:24 <peter1138> Just disable it completely first 22:18:24 <kuhnovic> Why would you need a bit per tile? 22:18:37 <peter1138> ^^ 22:19:11 <xarick> it still is an abuse, and hackish 22:19:46 <xarick> unless someone who understands puzzles, and slopes and heights 22:20:04 <xarick> can design a better river gen algorithm 22:24:25 <peter1138> Flow & erosion, sure. 22:27:07 <xarick> wtf, landscape grid is still not fixed 22:27:14 <xarick> :/ 22:37:10 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13056: Doc: landscape_grid.html formatting https://github.com/OpenTTD/OpenTTD/pull/13056 22:40:48 <peter1138> IMHO bits are either free or not. 22:41:00 <peter1138> Not "could be free if the code was changed" 22:42:39 *** keikoz has quit IRC 22:48:30 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #12741: Add: Show house information in House Selection window. https://github.com/OpenTTD/OpenTTD/pull/12741 22:54:51 *** k-man has quit IRC 22:56:14 *** k-man has joined #openttd 23:08:02 <xarick> `if (_generating_world && IsRiver(tile) && IsUnterraformableRiver(tile)) return CMD_ERROR;` 23:12:45 <peter1138> `chmod +r-w #openttd-development` 23:24:34 *** Wolf01 has quit IRC 23:29:51 *** wensimehrp has joined #openttd 23:29:51 <wensimehrp> rm -rf Discord channel #openttd-development 23:36:33 <xarick> what? 23:36:42 <xarick> something happened? 23:40:19 <_glx_> just disable river terraforming in mapgen 23:40:50 <xarick> that's an all or nothing approach 23:41:18 <xarick> I still want some of the rivers to be maleable, but not the "bone structure" 23:41:39 <_glx_> with a marker for the current step if you want fine tuning 2024-12-02T162024-12-02T22:43:46 <peter1138> Yeah, everything is failing with check annotations. Hmm.