Times are UTC Toggle Colours
01:29:06 <DorpsGek> [OpenTTD/OpenTTD] JGRennison opened pull request #13451: Codefix: Town index used in CMD_BUILD_ROAD test call in IsRoadAllowedHere https://github.com/OpenTTD/OpenTTD/pull/13451 03:05:10 *** Wormnest has quit IRC 04:00:08 *** D-HUND has joined #openttd 04:03:40 *** debdog has quit IRC 04:33:47 *** D-HUND is now known as debdog 04:44:13 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/8962ea8bcc06822f4b8aaf0fd81cf366ecb3cddd 04:44:14 <DorpsGek> - Update: Translations from eints (by translators) 05:09:30 *** keikoz has joined #openttd 05:40:20 *** felix_ has joined #openttd 05:42:56 *** felix has quit IRC 06:13:33 *** keikoz has quit IRC 06:28:13 *** peter1138 has quit IRC 07:05:40 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13451: Codefix: Town index used in CMD_BUILD_ROAD test call in IsRoadAllowedHere https://github.com/OpenTTD/OpenTTD/pull/13451#pullrequestreview-2589068147 07:09:50 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13448: Fix #12912: CompanyProperties::inaugurated_year_calendar not saved https://github.com/OpenTTD/OpenTTD/pull/13448 07:09:53 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 closed issue #12912: [Bug]: CompanyProperties::inaugurated_year_calendar is not saved https://github.com/OpenTTD/OpenTTD/issues/12912 07:14:17 *** urdh has joined #openttd 07:15:37 <DorpsGek> [OpenTTD/survey-web] survey-summary[bot] pushed 1 commits to main https://github.com/OpenTTD/survey-web/commit/21e62a9255acf3e5b9fdb9f1e5fb119eebc1ab82 07:15:38 <DorpsGek> - Add: summary for week 05 of 2025 (by OpenTTD Survey) 07:16:17 *** Smedles has quit IRC 07:17:35 *** Smedles has joined #openttd 07:22:06 *** Speedy` has quit IRC 07:23:39 *** Speedy` has joined #openttd 07:42:03 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13407: Change: [Script] GetWaypointID to return the StationID of any waypoint https://github.com/OpenTTD/OpenTTD/pull/13407 07:49:04 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13408: Add: [Script] GetBaseStationID https://github.com/OpenTTD/OpenTTD/pull/13408#issuecomment-2630199348 07:56:49 <truebrain> Rubidium: for your info, I just checked, more than one AI already uses IsValidBaseStation 🙂 So removing is no longer an option 😦 Fixing documentation to tell people not to use it, ofc, is always a good idea 😄 07:58:11 <LordAro> compatibility layer is always an option 07:58:34 <truebrain> Even that layer needs a public function to call to 😛 07:58:54 <truebrain> I am not sure we have anything in place that only allows a function to exist for certain compatibility layers only 08:00:13 <truebrain> owh, no, you are right. We can litteraly implement that function in Squirrel script 08:00:19 <truebrain> it is that simple code-wise 08:00:24 <truebrain> okay, I take back my comment 😛 08:00:51 <truebrain> I expected that function to do something internal; but it calls two other functions that are public too 08:00:56 <truebrain> so that could just go into the compat script 08:00:59 <truebrain> okay: lalalala, I said nothing 08:01:14 <truebrain> pretty sure #13408 won't go this way, but what Rb says sounds like an excellent idea 🙂 08:02:06 <LordAro> truebrain: without having looked at anything, i was imagining implementing as isvalidststion || isvalidwaypoint 08:04:12 <truebrain> I just said that! 08:04:20 <truebrain> Too slow .. too slow ..... 08:04:41 <LordAro> :c 08:08:28 *** HerzogDeXtEr has joined #openttd 08:30:46 *** benjaminv has joined #openttd 08:48:59 *** peter1138 has joined #openttd 08:48:59 *** ChanServ sets mode: +o peter1138 09:04:41 <peter1138> Right. Some reason my pi blew up in a way that disconnected things :S 09:04:53 <peter1138> irssi had a broken pipe ¦ 10:03:52 <LordAro> peter1138: https://www.100climbs.co.uk/events closer to you than me this time 10:05:51 <peter1138> Yeah, my fitness isn't up for any of that. 10:06:08 <LordAro> nonsense 10:09:14 <LordAro> i may have used my TSP setup to create a route for it regardless 10:09:29 <LordAro> only 166km! 10:09:41 <LordAro> (not that you have to do them all) 10:50:58 <xarick> hmm okay let's see if I understood what must be done about IsValidBaseStation 10:56:45 <xarick> <https://github.com/OpenTTD/OpenTTD/blob/master/src/script/api/script_station.cpp#L22-L27> 10:56:45 <xarick> <https://github.com/OpenTTD/OpenTTD/blob/master/src/script/api/script_waypoint.cpp#L18-L23> 10:56:45 <xarick> <https://github.com/OpenTTD/OpenTTD/blob/master/src/script/api/script_basestation.cpp#L23-L28> 11:02:15 *** Flygon has quit IRC 11:02:17 <xarick> if I understood... GetBaseStationID is not implemented, and on top of that, remove IsValidBaseStation from being accessible to the API? but still keep it, to be used internally as a helper function? 11:13:29 <LordAro> correct 11:13:39 <LordAro> (except it should be kept for compatibility) 11:21:35 <xarick> ScriptVehicleList_Station::ScriptVehicleList_Station(StationID station_id) hmm 11:21:49 <xarick> should have been ScriptVehicleList_BaseStation 11:29:45 <_glx_> No, because you really want stations only and no waypoints 11:30:51 <_glx_> Well it could internally use a Base Station version providing the correct filter 11:33:22 <xarick> I am just inventing ScriptVehicleList_Waypoint::ScriptVehicleList_Waypoint(StationID waypoint_id) 11:37:03 <xarick> > 69/70 Test #69: regression_regression ........................................................................................................... Passed 11.85 sec 11:37:04 <xarick> Hmm, I expected it to fail, I made IsValidBaseStation innaccessible 11:37:22 <xarick> guess I failed 11:42:04 <xarick> is this an inheritance issue or ... 11:42:09 <xarick> I dont understand 11:44:51 <xarick> oh... there is no IsValidBaseStation in regression 11:44:55 <xarick> ^-^ 11:49:36 <DorpsGek> [OpenTTD/OpenTTD] AldiAgung opened issue #13452: [Bug]: Trains sometimes didnt want to use the rail https://github.com/OpenTTD/OpenTTD/issues/13452 11:50:28 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1335940468483035136/image.png?ex=67a1ff04&is=67a0ad84&hm=611afd3681f55e58cb75fb6182338366c8878839064f6ebca7dc34f94cdd08d3& 11:51:16 *** keikoz has joined #openttd 11:52:27 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on issue #13452: [Bug]: Trains sometimes didnt want to use the rail https://github.com/OpenTTD/OpenTTD/issues/13452 11:57:35 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13408: Add: [Script] GetBaseStationID https://github.com/OpenTTD/OpenTTD/pull/13408#issuecomment-2630742431 12:00:26 <xarick> glx22viaGitHub: I don't agree 12:01:17 <peter1138> Comment on the PR. 12:01:26 <_glx_> The 3 functions have exact same code 12:01:44 <xarick> seemingly similar, but not quite 12:05:18 <xarick> oh, also there was also the proposal for fixing GetStationID with 13409 12:05:41 <xarick> to not work on waypoints. I was coming from this angle 12:08:04 <_glx_> Call base, then validate returned ID 12:24:46 <xarick> where are the regression tests being written to? 12:30:25 <xarick> CTest runs the test, but doesn't write to a file anymore... 12:30:34 <xarick> what happened, it was working fine 2 days ago 12:33:05 <xarick> ah, it works suddenly 12:34:19 <xarick> here's what I'm doing:<https://github.com/OpenTTD/OpenTTD/compare/master...SamuXarick:OpenTTD:remove-IsValidBaseStation> 12:39:28 <_glx_> No need to make it private, just hide it in API 12:51:10 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #13451: Codefix: Town index used in CMD_BUILD_ROAD test call in IsRoadAllowedHere https://github.com/OpenTTD/OpenTTD/pull/13451 12:53:49 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13449: Codechange: Make OverflowSafeInt ConvertibleThroughBase. https://github.com/OpenTTD/OpenTTD/pull/13449 12:56:04 <DorpsGek> [OpenTTD/OpenTTD] AldiAgung commented on issue #13452: [Bug]: Trains sometimes didnt want to use the rail https://github.com/OpenTTD/OpenTTD/issues/13452 12:56:52 <LordAro> excellent. 13:04:07 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13453: Codechange: Make Squirrel handle ConvertibleThroughBase. https://github.com/OpenTTD/OpenTTD/pull/13453 13:13:08 <_glx_> Ah signed/unsigned return mismatch 13:14:32 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13453: Codechange: Make Squirrel handle ConvertibleThroughBase. https://github.com/OpenTTD/OpenTTD/pull/13453#pullrequestreview-2589877043 13:14:40 <peter1138> Oh right, it compiles but doesn't actually work. Sigh. 13:14:46 <peter1138> Forgot to check regression test. 13:15:08 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13453: Codechange: Make Squirrel handle ConvertibleThroughBase. https://github.com/OpenTTD/OpenTTD/pull/13453#pullrequestreview-2589878405 13:15:58 <peter1138> Saved by it I guess. 13:16:39 <LordAro> peter1138: impossible. 13:18:45 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13453: Codechange: Make Squirrel handle ConvertibleThroughBase. https://github.com/OpenTTD/OpenTTD/pull/13453#pullrequestreview-2589888109 13:23:23 <peter1138> std::make_signed hopefully. 13:25:08 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13453: Codechange: Make Squirrel handle ConvertibleThroughBase. https://github.com/OpenTTD/OpenTTD/pull/13453 13:25:27 <peter1138> This passes regression for me, but I'm not sure if it's correct. 13:26:18 <DorpsGek> [OpenTTD/OpenTTD] AldiAgung commented on issue #13452: [Bug]: Trains sometimes didnt want to use the rail https://github.com/OpenTTD/OpenTTD/issues/13452 13:29:17 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #13452: [Bug]: Trains sometimes didnt want to use the rail https://github.com/OpenTTD/OpenTTD/issues/13452 13:29:40 <xarick> technically... 13:30:01 <xarick> TileIndex sometimes behaves as TileIndexDiff for AI/GS 13:34:58 <DorpsGek> [OpenTTD/OpenTTD] AldiAgung commented on issue #13452: [Bug]: Trains sometimes didnt want to use the rail https://github.com/OpenTTD/OpenTTD/issues/13452 13:36:07 <_glx_> hmm I wonder if regression test did something to check `return TileIndex((uint32_t)(int32_t)tmp)` (old `Param<TileIndex>`) 13:37:52 <_glx_> IIRC the int32_t cast was needed to first narrow SQInteger from 64 to 32 bits 13:41:33 <peter1138> Dunno, https://www.godbolt.org/z/1n61W7ssT 13:42:39 <peter1138> Oh, lack of optimisations. 13:43:03 <peter1138> https://www.godbolt.org/z/6zbazsdWG 13:44:57 <peter1138> Heh, the ARM v8 code is just "ret"? o_O 13:46:23 *** merni has quit IRC 13:49:50 <DorpsGek> [OpenTTD/OpenTTD] AldiAgung closed issue #13452: [Bug]: Trains sometimes didnt want to use the rail https://github.com/OpenTTD/OpenTTD/issues/13452 13:50:09 <_glx_> but #9725 doesn't mention anything about the double cast 13:54:50 *** benjaminv has quit IRC 14:03:06 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13453: Codechange: Make Squirrel handle ConvertibleThroughBase. https://github.com/OpenTTD/OpenTTD/pull/13453#pullrequestreview-2589997057 14:03:45 <_glx_> and yes we do strange stuff when talking to squirrel 14:05:59 <LordAro> _glx_: i'd say those casts are just to appease the compiler 14:06:22 <LordAro> i can't see there any functional change from them 14:06:41 <LordAro> (i.e. they could just be std::make_signed as well) 14:07:22 <_glx_> but uint8_t to int8_t will "change" the value in squirrel side, 128 becomes -1 14:07:47 <LordAro> oh yeah 14:07:57 <LordAro> hmm. 14:08:01 <_glx_> while when we do uint8_t to int32_t it stays 128 14:09:23 <xarick> compatibility scripts... 14:09:44 <_glx_> technically I think the int32_t stuff comes from the fact initially we had SQInteger being 32 ot 64 bits depending to platform 14:10:55 <xarick> when was IsValidBaseStation introduced 14:11:15 *** kuka_lie has joined #openttd 14:11:27 <peter1138> SQInteger has been 64 bit since (at least) we vendored it. 14:12:00 <peter1138> Well, `__int64`, whatever that was. 14:13:18 <peter1138> So std::make_signed is not the same behaviour for uint8_t and uint16_t types, but on the other hand there are no existing ConvertibleThroughBase types of those sizes. 14:13:29 <peter1138> Money is already signed, so make_signed does nothing. 14:13:41 <peter1138> Leaving TileIndex the only one. 14:15:44 <xarick> Interesting, in 2009 there was a WaypointID <https://github.com/OpenTTD/OpenTTD/commit/8c05194c0241d88226ba6c727a0c45b00d8495ed#diff-5643940d0c5e0db7bea58fe67702a9c74074e95c41d454969a6ed2c5b0fd794dL15-R15> 14:15:50 *** benjaminv has joined #openttd 14:17:21 <peter1138> https://mastodon.social/@nixCraft/110038398299092780 14:17:46 <peter1138> (old) 14:17:54 <_glx_> makes sense 14:18:15 <_glx_> a 5 years old child would do the same 14:28:26 <_glx_> we vendor squirrel since r15578, but we force 64bit SQInteger since r26584 14:29:27 <_glx_> 2009 and 2014 (and fixed the save handling in 2021) 14:35:25 <xarick> oh the glory days <https://github.com/OpenTTD/OpenTTD/commit/a3dd7506d377b1434f913bd65c019eed52b64b6e> 14:35:46 <xarick> I wasn't here at the time 14:36:32 <xarick> so basestation didn't exist from the start 14:36:33 * LordAro neither 14:36:46 <xarick> it was initially station 14:37:04 <xarick> then yexo created a basestation and moved some stuff around 14:39:47 <DorpsGek> [OpenTTD/OpenTTD] zephyris opened issue #13454: [Bug]: Inconsistencies with rocks in combination with variable snowlines https://github.com/OpenTTD/OpenTTD/issues/13454 14:40:05 <xarick> waypoints didn't exist either 14:41:00 <xarick> before the inauguration and yexo's basestation, waypoints were created... must find when 14:43:53 <DorpsGek> [OpenTTD/OpenTTD] zephyris commented on issue #13454: [Bug]: Inconsistencies with rocks in combination with variable snowlines https://github.com/OpenTTD/OpenTTD/issues/13454 14:44:37 <peter1138> Weird. r15578 has `typedef __int64 SQInteger;` 14:45:19 <peter1138> So __int64 didn't mean a 64 bit integer or something. 14:46:46 <_glx_> enclosed in #ifdef _SQ64 14:46:59 <_glx_> else it was typedef int SQInteger 14:47:43 <peter1138> Oh derp, the __int64 is just the only line that wasn't removed. 14:58:17 <peter1138[d]> Or... do heightmaps contain rivers? 14:58:27 <peter1138[d]> Oh wrong channel 14:59:27 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on issue #13454: [Bug]: Inconsistencies with rocks in combination with variable snowlines https://github.com/OpenTTD/OpenTTD/issues/13454 15:08:19 <xarick> well, AIBaseStation was introduced in 1.0.0, confirmed 15:11:05 <xarick> should I add a compatibility function for 0.7? 15:11:14 <xarick> that is the question 15:12:19 *** test242352 has joined #openttd 15:13:12 <_glx_> if it didn't exist in 0.7 no need to add compat layer 15:13:35 *** test242352 has quit IRC 15:13:36 <xarick> thx 15:16:14 <ahyangyi> ahyangyi: peter1138[d] I was (and still am) interested in heightmaps with rivers, though there were some discussions about the potential difficulties. 15:17:29 <ahyangyi> At that time I looked at the source code of the existing river generation algorithm and also wondered if I could just force the rivers to happen in a similar way we currently force slopes on heightmaps. 15:17:29 <ahyangyi> But river slopes are much more restricted than regular slopes, and there were cases I was not happy about. 15:21:21 <ahyangyi> ( I didn't put time into a branch because I decided to work on the heightmaps first, which turned out to be another time sink ) 15:24:59 *** nielsm has joined #openttd 15:47:51 <andythenorth> teaching GPT to do this refactor was....a thing 😐 https://github.com/andythenorth/iron-horse/commit/c2719c3655b61e1461c17efea0875b6600cb0178 15:48:12 <andythenorth> me and my robot had adventures with python AST, and # comments 16:01:20 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #13455: Change: [Script] ScriptVehicleList_Station no longer works for waypoints https://github.com/OpenTTD/OpenTTD/pull/13455 16:01:23 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #13456: Add: [Script] ScriptVehicleList_Waypoint https://github.com/OpenTTD/OpenTTD/pull/13456 16:05:33 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick opened pull request #13457: Change: [Script] Remove IsValidBaseStation https://github.com/OpenTTD/OpenTTD/pull/13457 16:05:57 <xarick> okay I'm done 16:07:09 <xarick> i think 13408 can be closed now 16:07:31 <xarick> but that goes against @glx suggestion 16:10:03 <xarick> oh, can't compile due to.... dependencies 16:11:22 <xarick> yeah, it requires the others 2 to merge 16:11:27 <xarick> then it will compile 16:15:15 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick commented on pull request #13457: Change: [Script] Remove IsValidBaseStation https://github.com/OpenTTD/OpenTTD/pull/13457#issuecomment-2631453281 16:15:18 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13458: Codechange: [Script] Merge compat scripts to reduce duplicating compat code https://github.com/OpenTTD/OpenTTD/pull/13458 16:24:37 <xarick> how many AIs am i gonna break now? 16:25:50 <xarick> ScriptVehicleList_Station 16:26:06 <xarick> and buoys 16:30:18 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #13458: Codechange: [Script] Merge compat scripts to reduce duplicating compat code https://github.com/OpenTTD/OpenTTD/pull/13458#issuecomment-2631490952 16:37:01 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13458: Codechange: [Script] Merge compat scripts to reduce duplicating compat code https://github.com/OpenTTD/OpenTTD/pull/13458#issuecomment-2631507778 16:38:57 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13453: Codechange: Make Squirrel handle ConvertibleThroughBase. https://github.com/OpenTTD/OpenTTD/pull/13453#pullrequestreview-2590455790 16:40:06 *** urdh_ has joined #openttd 16:40:40 <DorpsGek> [OpenTTD/OpenTTD] glx22 commented on pull request #13457: Change: [Script] Remove IsValidBaseStation https://github.com/OpenTTD/OpenTTD/pull/13457#pullrequestreview-2590470596 16:41:45 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13458: Codechange: [Script] Merge compat scripts to reduce duplicating compat code https://github.com/OpenTTD/OpenTTD/pull/13458#issuecomment-2631519470 16:42:26 *** urdh has quit IRC 16:43:12 <DorpsGek> [OpenTTD/OpenTTD] patric-stout-ccpgames commented on pull request #13458: Codechange: [Script] Merge compat scripts to reduce duplicating compat code https://github.com/OpenTTD/OpenTTD/pull/13458#issuecomment-2631523038 16:43:24 <truebrain> that did not happen 😛 16:43:45 <_glx_> lol 16:43:48 <LordAro> 👀 16:44:15 <truebrain> being ratted out by a freaking bot; can you imagine 😛 16:44:38 <LordAro> get ganked 16:44:51 <LordAro> or some other terminology along those lines 16:44:58 <LordAro> it's been many years... 16:45:41 <xarothbrook> Lol 16:45:42 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #13458: Codechange: [Script] Merge compat scripts to reduce duplicating compat code https://github.com/OpenTTD/OpenTTD/pull/13458#issuecomment-2631529337 16:45:59 <xarothbrook> truebrain: skill issue 16:46:03 <truebrain> Yup 16:47:03 <peter1138> That's a lot of PRs, making up for some being closed :p 16:48:02 <truebrain> _glx_: I don't understand your comment. The `compat.nut` script in that PR doesn't do any of that either? 16:48:51 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13458: Codechange: [Script] Merge compat scripts to reduce duplicating compat code https://github.com/OpenTTD/OpenTTD/pull/13458#issuecomment-2631536939 16:49:49 <_glx_> there's #13457 as an example, it removes `AIBaseStation.IsValidBaseStation` which was only present since 1.0, so 0.7 compat doesn't need to know about it 16:50:37 <peter1138> Remember it's for making old scripts compatible with the current API. 16:50:39 <truebrain> peter1138: I meant the other way around ofc 😛 1.13 should load 1.14, and 1.14 should load 1.15 🙂 It is still a chain, isn't it? 16:51:00 <peter1138> Well, that's a big difference. 16:51:10 <peter1138> I guess I read it wrong. 16:51:18 <truebrain> or I wrote it wrong 16:51:26 <truebrain> but there should be a direction it chains 😛 16:51:54 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13446: Change: [MacOS] Put the icon in a rounded rectangle https://github.com/OpenTTD/OpenTTD/pull/13446#issuecomment-2631544003 16:51:56 <truebrain> anyway, was just a random thought, to avoid having a single file with all those checks 16:52:18 <truebrain> I kinda liked having the version that introduced a change in a single place; makes it less errorprune, for my idea 16:52:21 <truebrain> no clue if that is true 😄 16:53:32 <truebrain> _glx_: In the current structure, that would still not be solved one way or the other? I mean, 0.7 would just get an `AIBaseStation.IsValidBaseStation`, but as no AI ever could have been used it, it doesn't matter? 16:55:16 <_glx_> it matters when the replacement function (even if never used) calls stuff not existing at that time 16:55:39 <peter1138> How can it? 16:56:12 <xarick> found a typo: waypint 16:56:24 <peter1138> Good idea. Let's go to the pub. 16:56:40 <truebrain> Doesn't it already happen, as in, we patch in functions already that didn't exist in older versions 16:56:43 <_glx_> though in IsValidBaseStation it's probably fine 16:56:46 <truebrain> but it just makes writing compat functions easier 16:58:27 <truebrain> _glx_: so let's take an example. I have a script that uses compat version 0.7. That causes, because of the chain of events, that this `IsValidBaseStation` is patched with a version that is more correct. That function will be completely valid, as it is 15 that is executing it. And as no 0.7 can ever be calling the function, it also doesn't matter. 16:58:31 <peter1138> If the function isn't called because it didn't exist in that earlier version, then I don't see the harm. 16:58:52 <_glx_> it's still compiled 16:58:59 <truebrain> and it would compile fine 16:59:05 <truebrain> I mean, it is 15 code that is being compiled? 17:00:01 <truebrain> (btw, it is not actually compiled is it? It just executed what is under the cursor .. as the code is never executed, it can contain total garbage; as long as it is synthetical correct, not?) 17:00:18 <truebrain> been too long, so these are honest questions; I can't really remember whether what I ask is true or not 😄 17:03:07 <_glx_> oh right I forgot the compat script is loaded by current openttd 17:03:27 <truebrain> Yeah, that makes things easier here 😉 17:03:44 <peter1138> I was wondering :) 17:04:26 <DorpsGek> [OpenTTD/OpenTTD] porisamaani2 opened issue #13459: [Bug]: scenario editor possible crash/glitch https://github.com/OpenTTD/OpenTTD/issues/13459 17:04:31 <truebrain> so okay, we are all thinking the wrong way around, it is not just me 😛 17:04:35 <truebrain> I should fix my comments to make sense 😄 17:04:37 <peter1138> Not everyone. 17:04:48 <truebrain> Sorry, you are right; you didn't 😛 17:05:07 <peter1138> Chaining from old to new sounds fine, if we don't care about implementing things that didn't exist in older version.s 17:05:16 <peter1138> And perhaps the compatibility message. 17:06:04 <truebrain> Either way, I like this `require()` stuff 🙂 17:06:06 <peter1138> It's like the big red message saying not to modify NewGRFs doesn't exist. 17:06:15 <truebrain> is that new, or did I just not know about it? 17:06:32 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13457: Change: [Script] Remove IsValidBaseStation https://github.com/OpenTTD/OpenTTD/pull/13457 17:07:23 <_glx_> truebrain: I think you added `require` 17:07:23 <peter1138> You probably clicked ok and didn't read it... nobody else does ;) 17:07:37 <peter1138> Oh you mean require, heh. 17:08:58 <DorpsGek> [OpenTTD/OpenTTD] maksalees commented on pull request #13446: Change: [MacOS] Put the icon in a rounded rectangle https://github.com/OpenTTD/OpenTTD/pull/13446#issuecomment-2631585495 17:10:08 <truebrain> _glx_: funny; I am getting old, clearly 😄 17:10:27 <_glx_> and it was present since NoAI introduction 17:10:48 <truebrain> I thought we had `import` and it had to be the first statement 17:10:57 <truebrain> so yeah ... I haven't touched Squirrel in a long time 😄 17:11:05 <truebrain> I will shut up now, I am only embarrising myself more 😛 17:12:06 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on pull request #13446: Change: [MacOS] Put the icon in a rounded rectangle https://github.com/OpenTTD/OpenTTD/pull/13446#issuecomment-2631592946 17:13:34 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13446: Change: [MacOS] Put the icon in a rounded rectangle https://github.com/OpenTTD/OpenTTD/pull/13446#issuecomment-2631596217 17:14:37 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on issue #13459: [Bug]: Assertion after removing NewGRF with items saved in picker https://github.com/OpenTTD/OpenTTD/issues/13459 17:15:18 <Rubidium> oh... I see a way to do the daisy chaining with exactly one log message, but it requires doubling the number of .nut files. That doesn't really feel like it's going to make things better 17:16:07 <truebrain> no, that would not 😛 17:16:14 <truebrain> The log-message can be done programmatically 17:16:41 <truebrain> it was mostly in that file, if I remember correctly, to make debugging a bit easier to see if the compat script was actually loaded 17:16:46 <truebrain> but .. I think we can trust the system by now? 😄 17:16:56 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13460: Fix: Too many trees when generating trees at same height. https://github.com/OpenTTD/OpenTTD/pull/13460 17:17:48 <peter1138> ^ One way to increase tree generation speed. Fix it from producing too many trees... 17:18:34 <peter1138> Crap, those screenshots were meant to be at the same location :S 17:19:49 <peter1138> Okay, now they are. 17:21:32 <LordAro> peter1138: i think the map looked better in the before :p 17:22:02 <LordAro> bet it speeds up worldgen though ;) 17:24:37 <peter1138> I've added a max-height 15 screenshot as well. 17:25:06 <peter1138> (Funnily enough it's the same seed, but map gen height apparently doesn't just scale...) 17:25:19 <DorpsGek> [OpenTTD/OpenTTD] maksalees commented on pull request #13446: Change: [MacOS] Put the icon in a rounded rectangle https://github.com/OpenTTD/OpenTTD/pull/13446#issuecomment-2631621965 17:27:45 <peter1138> I wonder how clamping instead of scaling looks. 17:27:55 <peter1138> Probably still too many trees. 17:30:19 <DorpsGek> [OpenTTD/OpenTTD] maksalees updated pull request #13446: Change: [MacOS] Put the icon in a rounded rectangle https://github.com/OpenTTD/OpenTTD/pull/13446 17:30:33 <peter1138> Correct, because it's always producing the maximum number of extra trees for each clump > 15. 17:34:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13460: Fix: Too many trees when generating trees at same height. https://github.com/OpenTTD/OpenTTD/pull/13460#issuecomment-2631641469 17:35:05 <DorpsGek> [OpenTTD/OpenTTD] LordAro commented on pull request #13446: Change: [MacOS] Put the icon in a rounded rectangle https://github.com/OpenTTD/OpenTTD/pull/13446#issuecomment-2631643264 17:35:59 <peter1138> Homogenous icons :( 17:40:11 <andythenorth> hmm train.py is 10k LOC 17:40:20 <andythenorth> maybe it should be consist.py and unit.py 17:41:06 *** kuka_lie has quit IRC 17:43:23 <truebrain> or should it? 17:48:10 <andythenorth> I asked the robot 17:48:16 <andythenorth> it made a lot of answers 17:48:21 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13461: Codechange: [Script] Daisy chain compat scripts to reduce duplication https://github.com/OpenTTD/OpenTTD/pull/13461 17:48:45 <andythenorth> I should tune my GPT prompt so that if the answer is "it depends" it uses those 2 words, not 900 17:49:17 <peter1138> Did you... just make a PR of something that doesn't work? 17:49:23 <peter1138> (I mean, I do that a lot.) 17:49:35 <ahyangyi> andythenorth: Just ask GPT to summarize what GPT says 17:49:40 <andythenorth> oo 17:49:42 <andythenorth> power move 17:50:52 <peter1138> Okay, I guess I just don't understand the error message part. 17:51:31 <DorpsGek> [OpenTTD/OpenTTD] TrueBrain commented on pull request #13461: Codechange: [Script] Daisy chain compat scripts to reduce duplication https://github.com/OpenTTD/OpenTTD/pull/13461#issuecomment-2631678200 17:52:46 <andythenorth> hmm ok, so now I'm refactoring the core Horse module 17:52:53 <andythenorth> so I can do variants better 17:53:01 <andythenorth> so I can do badges for more things 17:53:06 <andythenorth> so I can reduce name callback use 17:53:08 <peter1138> :badger: 17:53:10 <andythenorth> so I get a faster compile 17:53:25 <andythenorth> spell S I D E Q U E S T? 17:53:48 <andythenorth> or is this actually how a Quest works? 17:54:09 <andythenorth> I guess 'go to the shops, buy cake, go home' isn't much of a quest 17:54:45 <peter1138> Simi