Times are UTC Toggle Colours
00:07:20 *** HerzogDeXtEr has quit IRC 00:10:07 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #13695: Codechange: Use parameterised GetString() for settings window. https://github.com/OpenTTD/OpenTTD/pull/13695#pullrequestreview-2652601901 00:18:10 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #13694: Codechange: Use parameterised GetString() for remaining windows. https://github.com/OpenTTD/OpenTTD/pull/13694#pullrequestreview-2652602683 03:21:31 *** D-HUND has joined #openttd 03:22:42 *** Wormnest has quit IRC 03:24:49 *** debdog has quit IRC 03:39:15 *** D-HUND is now known as debdog 04:15:00 *** Flygon has joined #openttd 04:43:27 <DorpsGek> [OpenTTD/OpenTTD] eints-sync[bot] pushed 1 commits to master https://github.com/OpenTTD/OpenTTD/commit/f360913ebf30152206965d026c3a377309766185 04:43:28 <DorpsGek> - Update: Translations from eints (by translators) 05:12:03 *** keikoz has joined #openttd 05:46:18 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13556: Add: [Script] Framework for loading/saving selected ScriptObject https://github.com/OpenTTD/OpenTTD/pull/13556#pullrequestreview-2652635977 07:28:57 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on pull request #13695: Codechange: Use parameterised GetString() for settings window. https://github.com/OpenTTD/OpenTTD/pull/13695#issuecomment-2692600547 07:29:03 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13695: Codechange: Use parameterised GetString() for settings window. https://github.com/OpenTTD/OpenTTD/pull/13695 07:29:28 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13694: Codechange: Use parameterised GetString() for remaining windows. https://github.com/OpenTTD/OpenTTD/pull/13694 07:33:18 <andythenorth> was it coffee? 07:34:14 <peter1138> I've just made one, so it is. 07:34:29 <peter1138> "Made" 07:42:19 *** nielsm has joined #openttd 07:42:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13285: Codechange: Remove global string parameters. https://github.com/OpenTTD/OpenTTD/pull/13285 08:09:39 <peter1138[d]> Hmm. 08:11:38 <andythenorth> I have made coffee 08:23:38 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13696: Fix 4389321623: Invalid string parameters in cheat window. https://github.com/OpenTTD/OpenTTD/pull/13696 08:23:48 <peter1138> Whoopsie. 08:24:12 <peter1138> The original patch set had a patch that allowed unconsumed parameters to be missing. 08:25:21 *** jfs has joined #openttd 08:25:21 <jfs> oh I just realized that some of the explanations here haven't been updated for the last several versions: <https://github.com/OpenTTD/OpenTTD/blob/master/docs/logging_and_performance_metrics.md#20-frame-rate-and-performance-metrics> 08:27:06 *** Wolf01 has joined #openttd 08:28:56 <peter1138> Should be fine, nobody reads is anyway. 08:29:23 <peter1138> Would've been noticed if we had :p 08:29:57 <jfs> if I remember it, I may try to amend it tonight 08:31:36 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13696: Fix 4389321623: Invalid string parameters in cheat window. https://github.com/OpenTTD/OpenTTD/pull/13696#pullrequestreview-2652659366 08:38:40 *** nielsm has quit IRC 09:00:45 <peter1138> "Maybe I should go out today" opens door "Too damn cold" 09:00:52 <andythenorth> yair 09:01:04 <andythenorth> I am at my mums, looking at sunlit frosty garden 09:01:12 <andythenorth> no inclination to open the door 09:01:19 <andythenorth> enjoy the view 09:02:18 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13696: Fix 4389321623: Invalid string parameters in cheat window. https://github.com/OpenTTD/OpenTTD/pull/13696 09:02:23 <reldred> its warm here, I had to turn the aircon on 09:42:15 <peter1138> Well, I was going to do the next commit as one but I guess I can't now. 09:42:51 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13687: Codechange: prepare replacing SetStringParameters with GetWidgetString https://github.com/OpenTTD/OpenTTD/pull/13687#pullrequestreview-2652675755 09:58:18 *** kuka_lie has joined #openttd 10:03:01 <kuhnovic> Moar coffee 10:04:19 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13687: Codechange: prepare replacing SetStringParameters with GetWidgetString https://github.com/OpenTTD/OpenTTD/pull/13687 10:18:33 <xarick> i drank tea 10:39:42 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13697: Codechange: Use GetWidgetString for NewGRF debug window. https://github.com/OpenTTD/OpenTTD/pull/13697 10:46:12 <xarick> ```bool human = false; 10:46:12 <xarick> for (Company *c : Company::Iterate()) { 10:46:12 <xarick> if (!c->is_ai) { 10:46:12 <xarick> human = true; 10:46:12 <xarick> break; 10:46:14 <xarick> } 10:46:14 <xarick> }``` 10:46:16 <xarick> How do I use std::any_of here? 10:53:27 <peter1138> Maybe `std::ranges::any_of(Company::Iterate(), [](const Company *c) { return !c->is_ai; });` but I'm not sure. 10:56:05 <xarick> ranges didn't work 😦 10:56:21 <xarick> `bool human = std::any_of(Company::Iterate().begin(), Company::Iterate().end(), [](const Company *c) { return !c->is_ai; });` 10:56:22 <xarick> but this did, I think 10:56:25 <xarick> gonna test 11:04:24 <xarick> it works 11:04:43 <xarick> why doesn't it like std::ranges::any_of 😦 11:11:08 *** HerzogDeXtEr has joined #openttd 12:08:53 <DorpsGek> [OpenTTD/OpenTTD] glx22 approved pull request #13697: Codechange: Use GetWidgetString for NewGRF debug window. https://github.com/OpenTTD/OpenTTD/pull/13697#pullrequestreview-2652706256 12:13:17 <xarick> what lang ?//suche die gr��te Stadt 12:13:30 <xarick> //sortiere alle st�dte nach der entfernung zur gesuchteen stadt und finde die n�chstgelegene 12:13:58 <_glx_> German of course 12:14:34 <xarick> ah, so this AI is german 12:35:30 *** benjaminv has quit IRC 12:41:16 <DorpsGek> [OpenTTD/OpenTTD] glx22 merged pull request #13556: Add: [Script] Framework for loading/saving selected ScriptObject https://github.com/OpenTTD/OpenTTD/pull/13556 12:46:05 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13697: Codechange: Use GetWidgetString for NewGRF debug window. https://github.com/OpenTTD/OpenTTD/pull/13697 13:14:05 <peter1138> Hmm, can a pinky kill all cyber? 13:15:16 <peter1138> -all+a 13:44:29 *** akimoto has joined #openttd 13:54:26 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13285: Codechange: Remove global string parameters. https://github.com/OpenTTD/OpenTTD/pull/13285 14:38:50 <xarick> yay, saving Lists! 14:38:58 <xarick> amazing job _glx_ 15:25:02 <DorpsGek> [OpenTTD/OpenTTD] Sonnengruesser opened issue #13698: [Bug]: Ship reports loss despite being set to "transfer" https://github.com/OpenTTD/OpenTTD/issues/13698 15:27:03 *** Wormnest has joined #openttd 16:10:56 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1345790489793789952/message.txt?ex=67c5d490&is=67c48310&hm=c0b2ee6393d609931952f17e9d4c116e6c52de4f8e57f4b0c73929f70fe0c318& 16:10:56 <xarick> How do I avoid code repetition here 16:11:06 <xarick> oops 16:29:57 <xarick> ok simplified a bit 16:30:19 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1345795364883791974/image.png?ex=67c5d91a&is=67c4879a&hm=e41d2f490ba9444553679c4865e057db8a302dcd6bb8f7ee07297ceeaf0c3875& 16:54:40 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13565: Add #13519, e4c511d: [Script] Saveload and config file support for handpicked configs https://github.com/OpenTTD/OpenTTD/pull/13565 17:07:07 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13285: Codechange: Remove global string parameters. https://github.com/OpenTTD/OpenTTD/pull/13285 17:24:01 *** tokai has joined #openttd 17:24:01 *** ChanServ sets mode: +v tokai 17:24:22 *** gelignite has joined #openttd 17:31:01 *** tokai|noir has quit IRC 17:53:06 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13699: Codechange: Use GetWidgetString for network windows. https://github.com/OpenTTD/OpenTTD/pull/13699 17:54:08 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13700: Codechange: Use GetWidgetString for goal, league and story windows. https://github.com/OpenTTD/OpenTTD/pull/13700 17:58:35 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 commented on pull request #13699: Codechange: Use GetWidgetString for network windows. https://github.com/OpenTTD/OpenTTD/pull/13699#pullrequestreview-2652782691 18:00:05 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13700: Codechange: Use GetWidgetString for goal, league and story windows. https://github.com/OpenTTD/OpenTTD/pull/13700#pullrequestreview-2652782977 18:00:10 *** nielsm has joined #openttd 18:03:29 *** Wormnest has quit IRC 18:05:07 <xarick> "don't use std::move on constant variables" 18:05:33 <xarick> says intellisense on release build but not on debug build 18:06:18 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1345819521532952730/image.png?ex=67c5ef9a&is=67c49e1a&hm=e4ef87066b2c38b490f6164e6ce313c8f3613ce27b3c22996361c9388346b5d2& 18:08:55 <xarick> is it right? 18:09:36 <LordAro> are you questioning the compiler? 18:09:47 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13455: Change: [Script] ScriptVehicleList_Station no longer works for waypoints https://github.com/OpenTTD/OpenTTD/pull/13455 18:10:16 <xarick> yes 18:10:38 <LordAro> you need to have a very good reason to question the compiler 18:11:51 <xarick> it's original code <https://github.com/OpenTTD/OpenTTD/blob/master/src/script/script_config.cpp#L24> 18:12:58 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13699: Codechange: Use GetWidgetString for network windows. https://github.com/OpenTTD/OpenTTD/pull/13699 18:15:22 <peter1138> Yeah, std::move probably shouldn't be used here. 18:18:02 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #13409: Change: [Script] GetStationID can no longer return the StationID of waypoints https://github.com/OpenTTD/OpenTTD/pull/13409 18:21:49 <Rubidium_> though std::optional<const ...something...> is kinda weird 18:22:21 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13699: Codechange: Use GetWidgetString for network windows. https://github.com/OpenTTD/OpenTTD/pull/13699#pullrequestreview-2652786942 18:24:31 <DorpsGek> [OpenTTD/OpenTTD] SamuXarick updated pull request #12083: Add: [Script] Hangar index parameter to ScriptAirport::GetHangarOfAirport https://github.com/OpenTTD/OpenTTD/pull/12083 18:26:20 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 opened pull request #13701: Codefix: std::optional<const std::string> is weird https://github.com/OpenTTD/OpenTTD/pull/13701 18:31:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN approved pull request #13701: Codefix: std::optional<const std::string> is weird https://github.com/OpenTTD/OpenTTD/pull/13701#pullrequestreview-2652788509 18:33:15 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13700: Codechange: Use GetWidgetString for goal, league and story windows. https://github.com/OpenTTD/OpenTTD/pull/13700 18:39:33 <peter1138> I thought about doing the windows beginning with B, but there's a lot of Build...Window... 18:43:22 <dwfreed> tackle them by the second word letter? 18:44:06 <Rubidium_> peter1138: just do files starting with some letter. Much easier :D 18:49:44 <andythenorth> hmm can I be arsed to refactor `consist` to `model_variant` 18:49:49 <andythenorth> consist is shorter to type 😛 18:50:50 <peter1138> Why does it matter? 18:50:58 <peter1138> (tl;dr, It doesn't) 18:51:58 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13699: Codechange: Use GetWidgetString for network windows. https://github.com/OpenTTD/OpenTTD/pull/13699 18:52:52 <andythenorth> I could just call them all `brian` 19:13:10 *** akimoto has quit IRC 19:16:28 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 merged pull request #13701: Codefix: std::optional<const std::string> is weird https://github.com/OpenTTD/OpenTTD/pull/13701 19:58:57 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1345847871701782620/image.png?ex=67c60a01&is=67c4b881&hm=221e05048f953fe92d21e288b6cc453e2b65f333eb921125dfd2d774a1cdc078& 19:58:57 <xarick> why is this train saying 19:59:04 <xarick> the entire journey 20:15:58 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13670: Fix: More AI than max_no_competitors could start with competitors_interval=0 https://github.com/OpenTTD/OpenTTD/pull/13670#pullrequestreview-2652807280 20:48:19 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13702: Codechange: Move to GetWidgetString for build vehicle window. https://github.com/OpenTTD/OpenTTD/pull/13702 20:52:27 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13702: Codechange: Move to GetWidgetString for build vehicle window. https://github.com/OpenTTD/OpenTTD/pull/13702#pullrequestreview-2652814112 21:01:46 <DorpsGek> [OpenTTD/OpenTTD] Ufiby opened issue #13703: [Crash]: The game crashes when the road is converted. https://github.com/OpenTTD/OpenTTD/issues/13703 21:05:28 <DorpsGek> [OpenTTD/OpenTTD] James103 commented on issue #13703: [Crash]: The game crashes when the road is converted. https://github.com/OpenTTD/OpenTTD/issues/13703 21:07:13 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13704: Codechange: Move to GetWidgetString for company windows. https://github.com/OpenTTD/OpenTTD/pull/13704 21:08:18 <peter1138> Pool type, hmm. 21:09:28 <peter1138> Error message changes likely. 21:09:54 <peter1138> Trying to draw a company face for an error from a town. Oops. 21:17:46 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13704: Codechange: Move to GetWidgetString for company windows. https://github.com/OpenTTD/OpenTTD/pull/13704#pullrequestreview-2652821559 21:19:56 *** nielsm has quit IRC 21:20:51 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13705: Fix #13703: Don't set error owner for town-originated errors. https://github.com/OpenTTD/OpenTTD/pull/13705 21:22:41 *** Wormnest has joined #openttd 21:26:49 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13702: Codechange: Move to GetWidgetString for build vehicle window. https://github.com/OpenTTD/OpenTTD/pull/13702 21:27:08 <DorpsGek> [OpenTTD/OpenTTD] rubidium42 approved pull request #13705: Fix #13703: Don't set error owner for town-originated errors. https://github.com/OpenTTD/OpenTTD/pull/13705#pullrequestreview-2652823377 21:28:26 <peter1138> When the fix is to just remove lines... 21:30:46 <Rubidium_> less is more, right? 21:34:01 <xarick> I have 3 versions of CoronaAI 21:34:05 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1345871810843115581/image.png?ex=67c6204c&is=67c4cecc&hm=ae546a201dc38d0486b6b1ecbeeaee58a6fcb743724da8322e7aa91d08ad39f1& 21:34:32 <LordAro> 3 variants, if you will 21:34:42 <xarick> ~yes, that 21:34:54 <xarick> original CoronaAI on the left 21:35:12 <xarick> my version in the middle, and the CoronaAI Fix on the right 21:35:24 <xarick> 3 authors 21:36:12 <xarick> AIVehicleList() eats performance 21:36:37 <xarick> so I devised a different method to get the list of vehicles 21:36:58 <xarick> it fast forwarded faster than original 21:37:25 <DorpsGek> [OpenTTD/OpenTTD] James103 opened issue #13706: [Bug]: Map generation failure message is shorter than other two-line messages https://github.com/OpenTTD/OpenTTD/issues/13706 21:37:44 <xarick> the CoronaAI Fix though... has added some waiting time between starting new routes 21:38:03 <xarick> but also many other improvements 21:38:38 <xarick> in the end, I suspect the 3rd iteration to come stronger in profits than the 2 others 21:38:45 <xarick> but let's see 21:41:15 <peter1138> Hmm, that error message just one string... odd :) 21:42:09 <DorpsGek> [OpenTTD/OpenTTD] 2TallTyler commented on issue #13706: [Bug]: Map generation failure message is shorter than other two-line messages https://github.com/OpenTTD/OpenTTD/issues/13706 21:45:21 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13704: Codechange: Move to GetWidgetString for company windows. https://github.com/OpenTTD/OpenTTD/pull/13704 21:48:01 *** kuka_lie has quit IRC 21:49:05 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13473: Change: [Script] Replace ScriptDate with ScriptEconomyDate and ScriptCalendarDate https://github.com/OpenTTD/OpenTTD/pull/13473 21:58:42 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1345878005708226621/image.png?ex=67c62611&is=67c4d491&hm=1e49e7c43c4e704b9ecf326be7bc0f4d43591efe02c5d71f3ce14e41f9792590& 21:58:42 <xarick> hmmm the league table having so much unused space... feels wrong 21:59:59 <DorpsGek> [OpenTTD/OpenTTD] PeterN merged pull request #13705: Fix #13703: Don't set error owner for town-originated errors. https://github.com/OpenTTD/OpenTTD/pull/13705 22:00:02 <DorpsGek> [OpenTTD/OpenTTD] PeterN closed issue #13703: [Crash]: The game crashes when the road is converted. https://github.com/OpenTTD/OpenTTD/issues/13703 22:03:30 <DorpsGek> [OpenTTD/OpenTTD] glx22 updated pull request #13473: Change: [Script] Replace ScriptDate with ScriptEconomyDate and ScriptCalendarDate https://github.com/OpenTTD/OpenTTD/pull/13473 22:08:57 *** Wolf01 has quit IRC 22:21:04 *** Flygon has quit IRC 22:24:40 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13707: Codechange: Move to GetWidgetString for files starting d-e-f https://github.com/OpenTTD/OpenTTD/pull/13707 22:26:19 *** keikoz has quit IRC 22:27:54 <DorpsGek> [OpenTTD/OpenTTD] PeterN commented on issue #13706: [Bug]: Map generation failure message is shorter than other two-line messages https://github.com/OpenTTD/OpenTTD/issues/13706 22:57:46 <xarick> in squirrel vm i'm trying to figure out how _can_suspend works 22:58:25 <_glx_> don't 🙂 23:01:33 <DorpsGek> [OpenTTD/OpenTTD] PeterN updated pull request #13707: Codechange: Move to GetWidgetString for files starting d-e-f https://github.com/OpenTTD/OpenTTD/pull/13707 23:06:28 <xarick> hehe, i see 23:07:35 <xarick> https://cdn.discordapp.com/attachments/1008473233844097104/1345895343916580965/image.png?ex=67c63637&is=67c4e4b7&hm=5f124af3f901c23ce014ba4e5a31ad6e54c4cea504690f320b1ae02fbb7c4781& 23:07:36 <xarick> middle corona was better after 10 years 23:09:22 <xarick> uhmm yeah can't suspend in the middle of Valuate 23:09:29 <xarick> t.t 23:10:29 <xarick> unfortunate 23:12:09 <_glx_> yes you can't suspend inside a c++ function 23:12:36 <peter1138> In theory we could redesign it, but so far... 23:14:26 <peter1138> Rewrite Valuate as a squirrel function, perhaps. 23:37:37 <DorpsGek> [OpenTTD/OpenTTD] PeterN opened pull request #13708: Codechange: Drop SetToolTip for window caption. https://github.com/OpenTTD/OpenTTD/pull/13708