Times are UTC Toggle Colours
00:05:56 <DorpsGek_III> [OpenTTD/OpenTTD] ya-isakov commented on issue #8029: Black screen on SDL2-enabled OpenTTD, Sway and SDL_VIDEODRIVER=wayland https://git.io/Jv23P 00:23:19 *** adikt has joined #openttd 00:29:08 *** adikt- has quit IRC 00:39:23 *** Flygon has joined #openttd 01:02:48 *** Wormnest__ has quit IRC 01:06:44 *** adikt- has joined #openttd 01:12:04 *** adikt has quit IRC 01:34:28 *** Flygon_ has joined #openttd 01:40:03 *** Flygon has quit IRC 02:16:22 *** Wormnest__ has joined #openttd 02:59:29 *** Wormnest__ has quit IRC 03:08:57 *** Flygon has joined #openttd 03:08:57 *** Flygon_ has quit IRC 03:35:43 *** debdog has joined #openttd 03:38:47 *** glx has quit IRC 03:39:09 *** D-HUND has quit IRC 04:47:58 *** WormnestAndroid has joined #openttd 06:33:52 *** adikt has joined #openttd 06:40:28 *** adikt- has quit IRC 07:38:53 *** mindlesstux has quit IRC 07:52:33 *** gelignite has joined #openttd 08:14:03 *** tokai has joined #openttd 08:14:03 *** ChanServ sets mode: +v tokai 08:20:54 *** tokai|noir has quit IRC 10:12:01 *** Smedles has quit IRC 10:13:53 *** Smedles has joined #openttd 11:10:50 *** Samu has joined #openttd 11:14:50 *** gelignite has quit IRC 11:34:24 <Samu> hi 12:20:33 *** Smedles has quit IRC 12:22:31 *** Laedek_ has joined #openttd 12:24:42 *** Smedles has joined #openttd 12:29:49 *** Laedek has quit IRC 12:30:17 *** Flygon_ has joined #openttd 12:37:33 *** Flygon has quit IRC 12:39:01 *** Flygon_ has quit IRC 12:47:19 *** gelignite has joined #openttd 13:31:57 *** spnda has joined #openttd 14:45:33 <DorpsGek_III> [OpenTTD/OpenTTD] glx22 commented on issue #8029: Black screen on SDL2-enabled OpenTTD, Sway and SDL_VIDEODRIVER=wayland https://git.io/Jv23P 15:16:26 *** nielsm has joined #openttd 15:44:40 *** sla_ro|master has joined #openttd 16:15:09 *** Wormnest__ has joined #openttd 17:18:13 <Samu> hmm dredging site near a coast, and an AI trying to load sand via trains 17:18:45 <Samu> it's not working, no sand goes to the station 17:19:07 <Samu> serve_neutral_industries setting 17:19:27 <Samu> working as intended, but breaking ais 17:25:38 *** Smedles has quit IRC 17:25:56 *** Smedles has joined #openttd 17:29:47 *** Progman has joined #openttd 17:30:36 *** glx has joined #openttd 17:30:37 *** ChanServ sets mode: +v glx 17:48:02 <Samu> KrakenAI, AIAI, NoCAB are failing 17:52:08 <Samu> i wonder now why are thei failing :p 17:56:17 *** tokai|noir has joined #openttd 17:56:17 *** ChanServ sets mode: +v tokai|noir 18:03:19 *** tokai has quit IRC 18:07:28 *** Progman has quit IRC 18:17:24 *** andythenorth has joined #openttd 18:19:22 <Samu> EA is spamming me with emails 18:19:33 <Samu> Answers HQ 18:19:37 <Samu> wtf is that 18:20:35 <Samu> Sixth Anniversary 18:20:35 <Samu> You've been a member of Answers HQ for six years! 18:20:46 <Samu> really? i don't even know wtf this is 18:27:29 <andythenorth> YO 18:27:33 <andythenorth> I AM HERE 18:43:44 *** frosch123 has joined #openttd 18:44:20 <andythenorth> cat is here! 18:44:24 <andythenorth> quak says cat 18:45:05 <frosch123> hoi cat 18:45:26 <frosch123> where is alf? 18:46:03 <debdog> on a date with Ronda 18:46:05 <Eddi|zuHause> taxis seem like the worst mode of transport in C:S 18:46:32 *** Wolf01 has joined #openttd 18:47:20 <andythenorth> I has new idea 18:47:22 <andythenorth> Iron Horses 18:47:28 <andythenorth> web based train newgrf maker 18:47:36 <Wolf01> Yes 18:47:43 <andythenorth> step 1: teach openttd to compile grf from remote GH repo 18:47:50 <Eddi|zuHause> i'm fairly sure you had this idea before 18:47:59 <andythenorth> it was a TERRIBLE idea last time 18:48:02 <andythenorth> this time it is good 18:48:21 <Wolf01> Port the compiler to javascript 18:49:08 <Eddi|zuHause> i've got this offer to become a PHP developer for a bank... let's say i'm... hesistant 18:49:49 <andythenorth> so many reasons to question that 18:50:17 <andythenorth> Wolf01: wasm compiler 18:50:21 <andythenorth> wasm openttd in browser 18:50:36 <andythenorth> two tabs, one edits train value, other reloads it in openttd live 18:51:02 <andythenorth> we could put the editor directly into openttd, but I think that would be a TERRIBLE IDEA 18:51:16 <Wolf01> Web based OTTD is real 18:52:10 <andythenorth> I know 18:52:14 <andythenorth> wasm is real 18:52:19 <andythenorth> against all probability 18:52:22 <andythenorth> ooh 18:52:30 <andythenorth> we could put a GitHub client into OpenTTD 18:52:35 <andythenorth> then edit vehicles in place 18:52:37 <andythenorth> then commit back 18:52:52 <Wolf01> THAT is a terrible idea 18:53:02 <andythenorth> we could put a GH client cross-compiled into WASM into a browser in OpenTTD in WASM 18:55:17 <FLHerne> andythenorth: Your ideas are steadily getting worse 18:56:47 <frosch123> he watched the METAL video too often 19:12:40 <LordAro> it's the sort of bad idea where you just laugh at it, rather than try to explain why it's so bad 19:14:44 <TrueBrain> But with enough bad ideas, there is a single brilliant one :) 19:14:48 <TrueBrain> Just keep it up! 19:15:53 <andythenorth> the WASM future will happen 19:16:07 <andythenorth> one day, we'll even run JS on servers :P 19:16:21 <Wolf01> We already do it 19:16:26 <andythenorth> omfg 19:16:31 <TrueBrain> still dreading the day we have an OS running in a browser 19:16:34 <Wolf01> Node based apps 19:16:36 <TrueBrain> wait .. that already happened 10 years ago 19:17:05 <andythenorth> when I learnt Macromedia Director, the first thing I thought was 'can I make the GUI part of the OS?' 19:17:25 <andythenorth> then I made a slideshow instead :P 19:17:26 <andythenorth> much easier 19:17:40 <Wolf01> Of an OS? 19:17:56 <andythenorth> of 5 photos 19:18:17 <andythenorth> making all the window / file manager part of an OS would be at least twice as much work 19:18:31 <TrueBrain> at least, that is correct 19:20:16 <andythenorth> I miss cross-platform fully graphical runtimes :( 19:20:23 <TrueBrain> you miss browsers? 19:20:23 <andythenorth> director, flash 19:20:45 <andythenorth> I was going to learn Unity, but then it turned out to be broken 19:21:00 <andythenorth> oh there was also Silverlight 19:21:02 <andythenorth> 'lol' 19:21:38 <andythenorth> eh wat, Unity still exists? 19:21:45 <andythenorth> I thought it died under crippling CVEs 19:21:48 <TrueBrain> duh 19:21:51 <TrueBrain> and it is kicking ass 19:22:58 <andythenorth> oh it was the browser plugin that got banned 19:23:38 <andythenorth> hmm 19:25:31 <TrueBrain> right, time to write parsers for the Base* types 19:30:32 <andythenorth> hmm 19:30:37 <andythenorth> extra train info for Horse? 19:30:41 <andythenorth> or tanks :P 19:31:34 <TrueBrain> what-ever you feel like ;) 19:35:02 <frosch123> maybe buy more flour, sugar and rice? 19:47:31 <Eddi|zuHause> have you been to a supermarket lately? :p 19:48:44 *** Eddi|zuHause is now known as Eddi|zuHause2 19:48:47 *** Eddi|zuHause2 is now known as Eddi|zuHause3 19:48:47 <frosch123> shopping is entertaining, whenever there is an empty shelf, you check what is sold there normally, and then wonder who tf would stockpile that 19:51:11 <TrueBrain> "Exception: option metadata:blitter is missing" <- hmmmmm 19:51:21 <TrueBrain> seems not all base graphics have that entry :D 19:52:01 <frosch123> i wonder whether it is even used :p 19:52:03 <TrueBrain> musa made it mandatory :) 19:52:14 <frosch123> i thought that kind of stuff is auto-detected 19:52:38 <TrueBrain> I dunno .. just reading implementations :) 19:52:53 <TrueBrain> "Exception: option origin:default is missing" <- seems that is optional too 19:52:55 <frosch123> hmm, ah, there was some logic depending on "some sprites are 32bpp" vs "most sprites are 32bpp" 19:53:37 <TrueBrain> seems md5 of base graphics does not depend on content of .obg file 19:53:45 <TrueBrain> so possibly this is worth cleaning 19:54:38 <TrueBrain> I don't get what [origin] does tbh :P 19:54:54 <frosch123> it is displayed when the md5sums are incorrect 19:55:03 <TrueBrain> ah .. okay, that makes sense 19:55:11 <TrueBrain> and I guess it used to be that you had to tell that per file 19:55:15 <TrueBrain> and now you can also set a "default" 19:55:37 <frosch123> ottd loads the baseset with most files present, and dispalys a message when one file is missing or broken 19:56:03 <TrueBrain> so musa is a lot more strict 19:56:06 <TrueBrain> I guess that is not a bad thing 19:56:22 <frosch123> TrueBrain: the "per file" is for original graphics, "openttd.grf" is "redownload ottd", rest is "get all files from your ttd cd" 19:56:52 <TrueBrain> yeah .. but 2 base graphics we have on file doesn't define a "default", but do for each file it contains 19:56:52 <frosch123> so, probably not used by any bananas set :) 19:57:11 <TrueBrain> but those are older non-active ones 19:57:16 <TrueBrain> so I guess it is fine to just leave them or what-ever 19:58:17 <frosch123> it's probably hard to trigger those messages, users would have to modify the tars they download 19:58:30 <TrueBrain> yeah 20:00:39 <TrueBrain> when will OpenGFX and co be bumped to 1.0? 20:00:43 <TrueBrain> as I guess they are done? 20:01:36 <Samu> I found a bug with AITileList_IndustryProducing 20:01:50 <frosch123> when people were working on it, it was not considered done 20:02:22 <Samu> if serve_neutral_industries is disabled, this still returns tiles 20:02:31 <Samu> it should return no tile 20:02:41 <frosch123> just noone is interested in finishing the remaining draft sprites 20:02:52 <TrueBrain> frosch123: ah .. 20:02:54 <TrueBrain> and OpenSFX? 20:03:33 <frosch123> no idea, i think rb was the only contributor 20:03:47 <TrueBrain> I think this is a nielsm to wrap up to 1.0 if possible :) 20:03:58 <frosch123> maybe he hoped someone would do a real soundset somewhen :) 20:05:00 <frosch123> last year there was some dude on the forums mailing original authors of opensfx, and asking them for a more free license 20:05:43 <frosch123> they got some responses, but it's still not debian core 20:06:13 <frosch123> anyway, why do you care about version numbers? 20:06:28 <TrueBrain> was just annoying me, to see < 1.0, for something that is not moving :) 20:06:57 <Samu> GetStationCoverageRadius should be deprecated 20:07:04 <frosch123> i guess you can name nml 1.0 when you implement stations :p 20:07:11 <Samu> but that would break many AIs that use it 20:07:13 <frosch123> but the rest has no real agenda 20:07:35 <TrueBrain> fair enough :) 20:08:14 <frosch123> i still don't get why people invest so much time into music sets 20:08:35 <TrueBrain> people just fancy it, I guss 20:08:52 <frosch123> unless a game can play context-specific music matching the game state, external players are always superior 20:09:22 <TrueBrain> Exception: the short name is not 4 long 20:09:23 <TrueBrain> oh-oh ... 20:09:31 <frosch123> lol 20:09:36 <frosch123> what did old bananas do? 20:09:41 <TrueBrain> "name = Holiday Island" 20:09:46 <TrueBrain> how is this parsed in OpenTTD ... 20:10:05 <TrueBrain> all Base Music sets have ".mid", but 1 has ".gm" 20:10:08 <TrueBrain> both are fine? 20:10:30 <frosch123> nielsm may know 20:10:39 <TrueBrain> 4 base music sets have wrong "shortnames" 20:10:51 <TrueBrain> owh, wrong paste: 20:10:51 <TrueBrain> shortname = Holiday 20:11:19 <TrueBrain> and yes, we have shortname and ShortName and short_name 20:11:20 <TrueBrain> :D 20:11:32 <frosch123> i can select those sets in-game 20:11:45 <TrueBrain> only first 4 chars are used 20:11:51 <TrueBrain> so the error is correct :) But it is harmless 20:12:52 <frosch123> "default = Holiday" 20:13:06 <frosch123> someone entered "holiday" into every field they did not understand :) 20:16:18 <TrueBrain> Exception: option metadata:description.da_da set but not expected 20:16:22 <TrueBrain> ah, you can also translate those 20:16:26 <TrueBrain> good to know :D 20:17:11 <frosch123> da_da ? 20:17:18 <frosch123> da_DK ? 20:17:28 <TrueBrain> dunno .. random entry 20:17:52 <TrueBrain> could also validate language-tags, I guess 20:19:52 <TrueBrain> "Exception: option metadata:palette set but not expected" <- in a Base Sounds set :D 20:19:53 <TrueBrain> lol 20:22:29 <nielsm> frosch123: the windows version of TTD had the music files named as .gm and .awe and .fm (iirc) but they were just standard midi files 20:22:51 <frosch123> sound palettes are an early version of sound fonts? 20:22:54 <TrueBrain> so I can rename .gm to .mid, and it would still work fine? 20:23:02 <TrueBrain> frosch123: pretty sure someone copy/pasted too much :P 20:23:25 <nielsm> well the original_win music set expects the files named as .gm 20:23:35 <nielsm> just make sure the .obm file refers to the right file names :) 20:23:50 <TrueBrain> yeah, but I am creating the validation for them :) 20:24:35 <nielsm> I'd say rather check that the files have a standard midi file header, than validate file extension 20:25:21 <TrueBrain> first is a good idea, sure 20:25:35 <TrueBrain> but all but 1 have the .mid extension .. 20:25:53 <TrueBrain> basically, I have to use the extension to know what type it is, after which I validate it really is that type :P 20:26:02 <TrueBrain> (so .grf means NewGRF, and after that it is checked it really is a NewGRF) 20:26:30 <nielsm> yeah just assume .mid or .gm are midi files 20:26:55 <TrueBrain> k, tnx 20:27:07 <nielsm> really, all music sets should just use .mid and nothing else, using .gm for a non-ttd music set is misunderstood 20:27:24 <TrueBrain> print(set(keys_in_section) - set(keys)) 20:27:24 <TrueBrain> TypeError: 'type' object is not iterable 20:27:28 <TrueBrain> okay .. that error is new to me ... 20:27:47 *** tokai has joined #openttd 20:27:47 *** ChanServ sets mode: +v tokai 20:29:01 <TrueBrain> okay, I need to fix up some Base Sets in order to import them, but it is all very minor 20:29:03 <TrueBrain> and should not impact md5 20:29:19 <TrueBrain> what is the default for blitter .. hmm 20:29:52 <nielsm> 32bpp-anim afaik 20:30:10 <TrueBrain> in the base-graphics section 20:30:33 <glx> base graphics are 8bpp usually 20:31:03 *** Wolf01 has quit IRC 20:31:16 <TrueBrain> "usually" is not the answer I am looking for :D 20:31:21 <TrueBrain> can't find where this blitter entry is read .. 20:31:30 <frosch123> this->blitter = (item != nullptr && *item->value == '3') ? BLT_32BPP : BLT_8BPP; 20:31:31 <TrueBrain> ah, there it is 20:31:41 <TrueBrain> all entries are read with "fetch_metadata("palette");" 20:31:42 <TrueBrain> except blitter :D 20:31:55 <TrueBrain> so if the first char is "3", it is 32bpp 20:31:56 <TrueBrain> lol 20:31:59 <TrueBrain> now that is lazy coding :D 20:32:01 <TrueBrain> tnx frosch123 :) 20:32:02 <glx> nice validation 20:32:12 <LordAro> aha 20:32:22 *** HerzogDeXtEr has joined #openttd 20:32:30 <frosch123> it will work until ottd 3.0 or something 20:34:03 <TrueBrain> okay, added a shit-ton more validation on base-sets .. found a few boo-boos .. but that concludes validating upload-files for most part, I guess .. 20:34:09 <TrueBrain> owh, right, "mid/gm" and "cat" files 20:34:16 <TrueBrain> after that .. md5sums .. 20:34:38 *** tokai|noir has quit IRC 20:34:55 <glx> haha just got an email from central bank of nigeria on my openttd.org address 20:35:13 <TrueBrain> YOU WON THE LOTTERY! 20:35:16 <frosch123> i think i already deleted that one from info 20:35:16 <TrueBrain> We are so happy for you :) 20:35:47 <frosch123> oh, 20:03 to info, 20:16 to me 20:36:07 <Samu> i received 8 "badges" from EA, their Answers HQ, 1 email per badge 20:36:14 <frosch123> heavy workload :) 20:36:20 <Samu> i dont even use their service 20:36:39 <TrueBrain> "Exception: option names:piano_roll.mid is missing" <- it now even detects issues like this, sweet :) 20:37:18 <TrueBrain> [origin] 20:37:18 <TrueBrain> default = Licensed under a variant of the MIT license; see license.txt for details. Contact the author at furber.k@outlook.com. 20:37:23 <TrueBrain> frosch123: I think nobody understands [origin] 20:37:28 <andythenorth> frosch123: did I miss a memo about stockpiling? o_O 20:37:37 <glx> yesterady it was a products inquiry "The attached file contains two products list so we have combined them with an iso for easier download. Kindly find purchase inquiry as attached to this email then click on the iso file to find inquiry lists. " 20:37:48 <frosch123> TrueBrain: unless ottd requires it, you can just delete it 20:37:55 <frosch123> no sane way to trigger it 20:38:09 <TrueBrain> so why did someone add it, I wonder :D 20:38:13 <nielsm> I think the origin section is only supposed to tell you how to obtain the data files the set requires if you don't have them 20:38:15 <glx> they are inventive these days 20:38:21 <nielsm> i.e. original media to copy the files from 20:38:32 <nielsm> (copyrighted media files that can't be distributed) 20:39:03 <TrueBrain> "DEBUG(grf, 1, "No origin warning message specified for: %s", filename);" 20:39:04 <TrueBrain> if not set 20:39:09 <frosch123> andythenorth: weird people started panicking on saturday, and are now wondering what they shall do with flour, sugar and green kale... and are now looking for info how to cook that 20:39:41 <TrueBrain> well, I just leave it as is .. what-ever :P 20:40:01 <frosch123> TrueBrain: it was useful when people copied original files, it's pointless for bananas downloads 20:40:24 <TrueBrain> but OpenTTD "requires" it, I guess 20:40:37 <glx> frosch123: but flour and sugar can be kept forever, no hurry 20:40:50 <andythenorth> I am not going to panic until deliveroo delivery times go up past 1.5 hours 20:40:57 <frosch123> glx: their children will be happy :) 20:41:11 <TrueBrain> so how to validate mid/gm/cat .. what are their headers .. 20:41:16 <Samu> is this a big message? 20:41:18 <Samu> Fix: AI/GS Creating a list of tiles that will accept or produce cargo for a given industry were not considering whether the industry could only be serviced by its neutral station only 20:41:25 <glx> too long 20:41:28 <frosch123> prefix those questions with "nielsm" :) 20:41:29 <glx> definitely 20:41:29 <Samu> ok, help me reduce 20:41:52 <nielsm> https://github.com/OpenTTD/OpenTTD/blob/master/src/music/midifile.cpp#L432 20:42:12 <TrueBrain> nielsm: k, that is mid/gm? Also cat? 20:42:28 <TrueBrain> no, cat is different .. 20:42:33 <nielsm> nobody should be uploading cat music to bananas 20:42:35 *** tokai|noir has joined #openttd 20:42:35 *** ChanServ sets mode: +v tokai|noir 20:42:41 <nielsm> there aren't any tools to create it afaik 20:42:44 <TrueBrain> nielsm: OpenSFX kinda requires you doing so? :) 20:43:04 <nielsm> ah, well cat files don't have any magic to recognise 20:43:12 <glx> Samu: Fix: [AI/GS] Consider neutral station setting when creating AITile lists 20:43:19 <nielsm> but you can try to parse the directory and see if it makes sense 20:43:24 <Samu> wow, nice 20:43:29 <nielsm> sound effect cat files should always have a fixed amount of entries too 20:43:39 <glx> or tile list, as it's for both 20:43:52 <TrueBrain> nielsm: I have no clue what cat files are :D Happen to know where it is parsed in the code or something to go by? 20:44:08 <glx> weird packing format :) 20:44:32 <frosch123> nielsm: TrueBrain: cat are created with https://github.com/OpenTTD/catcodec: 20:44:52 <glx> cat meaning catalog but many different format in real world IIRC 20:45:22 <Samu> ScriptTileList_IndustryAccepting and ScriptTileList_IndustryProducing, they already have long names 20:45:48 <glx> it's ok for function names 20:45:57 <Samu> https://docs.openttd.org/ai-api/classAITileList__IndustryAccepting.html 20:46:00 <glx> will be hard to shorten the names 20:47:44 <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick opened pull request #8030: Fix: [AI/GS] Consider neutral station setting when creating tile lists https://git.io/Jva4v 20:48:02 <TrueBrain> surprisingly, all midi files are valid midi files :P 20:48:19 <frosch123> TrueBrain: looks like cat has no real header, it's just binary data 20:48:34 <TrueBrain> so nothing to do any validation on? 20:48:35 <frosch123> https://github.com/OpenTTD/catcodec/blob/master/src/catcodec.cpp#L46 <- you could replicate that, but probably tmwftlb 20:48:38 <TrueBrain> size-bytes or anything? 20:48:46 <nielsm> yeah cat files start with an index of pointers into the file 20:49:15 <nielsm> first 32 bits (little endian) is a pointer to the data of the first data contained 20:49:29 *** tokai has quit IRC 20:49:30 <nielsm> everything before that should be the index 20:49:59 <nielsm> so just read the first dword and divide by 4 to get number of entries 20:50:21 <TrueBrain> code appears to be a tiny bit more complex nielsm 20:50:31 <TrueBrain> but frosch123 's link works, I guess 20:50:36 <frosch123> is the number of sounds fixed? 20:50:42 <nielsm> I think it is yes 20:50:53 <frosch123> then the first 4 bytes only have two valid values 20:50:53 <nielsm> sound effects cat files should always have the same number of entries 20:51:32 <TrueBrain> https://github.com/OpenTTD/catcodec/blob/7bded96d11c52a15a140c3a504fd0cb73e8b1e14/src/sample.cpp#L104 20:51:34 <TrueBrain> holy crap 20:51:41 <TrueBrain> okay, nevermind, I just process these "raw" :P 20:51:57 <nielsm> I don't think you need to validate the contained sound data 20:52:01 <nielsm> just that the header makes sense :) 20:52:04 <frosch123> TrueBrain: first dword must be 73 or 73+0x80000000 20:52:21 <nielsm> yeah 20:52:23 <nielsm> that 20:52:37 <TrueBrain> @base 10 16 73 20:52:37 <DorpsGek> TrueBrain: 49 20:52:42 <frosch123> nah, there is another factor 8 20:52:43 <Samu> the "Accepting" list actually didn't really need a fix, as GetAcceptanceAroundTiles already does the check, but it would be executing needless code https://github.com/OpenTTD/OpenTTD/blob/541c1905eeb4bb2a24e7d5874632be558dbf0415/src/script/api/script_tilelist.cpp#L103 20:52:52 <frosch123> 73*8 or 73*8+0x80000000 20:52:57 <nielsm> you can also verify that all entries in the file index are valid pointers into the file 20:52:59 <Samu> i made it return earlier 20:53:54 <Samu> i'll post in the PR 20:54:15 <TrueBrain> @calc 73*8 20:54:15 <DorpsGek> TrueBrain: 584 20:54:18 <TrueBrain> @base 10 16 584 20:54:18 <DorpsGek> TrueBrain: 248 20:54:27 <DorpsGek_III> [OpenTTD/OpenTTD] SamuXarick commented on pull request #8030: Fix: [AI/GS] Consider neutral station setting when creating tile lists https://git.io/Jva4O 20:55:45 <TrueBrain> frosch123: works, cheers :) 21:03:15 <TrueBrain> okay ... md5 of all single objects ... except for heightmaps .. (I am trying to avoid a fp.seek .. tricky for heightmaps :D) 21:03:43 <Samu> that fix, fixes AIAI 21:03:46 <Samu> :) 21:06:19 <Samu> also fixes KrakenAI 21:06:53 <TrueBrain> there is the checksum, w00p 21:07:57 <TrueBrain> someone uploaded an AI Library as AI :) 21:08:01 <TrueBrain> well, that is never going to work :P 21:08:32 <TrueBrain> so many mistakes that BaNaNaS made :P 21:08:40 <TrueBrain> who wrote that validation?! 21:08:44 <Samu> also fixes NoCAB 21:09:19 <Samu> last one that was failing is OtviAI, let's check 21:10:04 *** spnda has quit IRC 21:14:53 <Samu> also fixes OtviAI 21:14:55 <Samu> barelly 21:15:17 <Samu> it doesn't start building, but still have it in its plans 21:15:25 <Samu> so it's all good 21:15:29 <DorpsGek_III> [OpenTTD/eints] frosch123 opened pull request #6: Fix validation of {G ...} https://git.io/Jva4Q 21:16:20 <frosch123> i love it when you debug for an hour, and then only need to add two short lines 21:18:00 <Samu> oh, WormAI was also affected, it's also fixed 21:22:48 <TrueBrain> hmm .. I wonder if common users know how to create a ob[gms] file, with the md5sums in there :P 21:23:16 <TrueBrain> but okay .. I think the validation code is ready now .. which is a lot quicker than I expected :) 21:23:29 <frosch123> the music set authors were rather common people 21:24:22 <TrueBrain> now validating every BaNaNaS upload .. to see if I did my work correctly :P 21:25:31 <frosch123> andythenorth: why does eints request that newgrf translators use the same amount of colour coded in translations, while it does not require that for gs and ottd? 21:25:35 <DorpsGek_III> [OpenTTD/eints] glx22 approved pull request #6: Fix validation of {G ...} https://git.io/JvaBq 21:25:59 <TrueBrain> I think the flow will be something like this: upload a grf, it looks up if this is a new version of an existing, or a new entry. It asks you to validate the finding. It asks you to fill in the blanks, like: upload readme.txt, upload license.txt, etc. If that is all done, you can hit publish 21:26:06 <TrueBrain> this works for newgrf, scenarios and heightmaps 21:26:17 <TrueBrain> for AI/GS (library), you can either upload your nut-files 21:26:21 <TrueBrain> or a zip with them in there 21:26:26 <TrueBrain> and the flow goes from there 21:26:39 <TrueBrain> for Base Sets, you can start with uploading a ob[gms], and the grfs after 21:26:41 <TrueBrain> or as a zip too 21:26:57 <TrueBrain> so basically: upload all the files, you get asked some questions to make sure we understood your request 21:27:03 <TrueBrain> should be easy enough 21:27:22 <frosch123> glx: on the "commits" tab you can see the diff per commit 21:28:29 <DorpsGek_III> [OpenTTD/eints] frosch123 merged pull request #6: Fix validation of {G ...} https://git.io/Jva4Q 21:28:47 <glx> yeah didn't notice there were 2 commits ;) 21:28:59 <TrueBrain> even then you needed the "hide whitespace" :P 21:29:03 <frosch123> hmm, gh's split-view diff is substandard 21:29:25 <frosch123> other tools highlight diffs based on characters in that case 21:29:41 <TrueBrain> it does at the bottom 21:29:48 <TrueBrain> but for some reason it detected a remove too :P 21:31:17 <frosch123> https://github.com/OpenTTD/OpenTTD/pull/7564/files <- hey, exactly 10 months :) 21:31:37 <Samu> how do i request a backport requested? 21:32:00 <Samu> it's a serve_neutral_industries fix which is a new feature for 1.10 21:32:13 <nielsm> ask someone to add the tag 21:32:19 <Samu> nielsm, add the tag 21:32:20 <Samu> :p 21:32:39 <glx> done 21:33:05 <Samu> well in that case, 8020 also needs it 21:33:12 <TrueBrain> well done frosch123 :) 21:33:28 <andythenorth> frosch123: eints, don't know :) 21:33:33 <TrueBrain> Samu: how was that asking?! :o 21:33:37 <Samu> oops 8021 21:34:17 <Samu> it went well 21:34:54 <Samu> i dont think 8009 is yet ready for the bakcport requested tag 21:35:10 <Samu> but 8021 is 21:36:34 <Samu> cool, thx, wondering if there's still time those will get into 1.10 21:38:18 <Samu> 8001/8009 is difficult to solve 21:39:00 <Samu> better not rush it into 1.10 21:39:15 *** andythenorth has quit IRC 21:39:32 *** sla_ro|master has quit IRC 21:42:40 <TrueBrain> 1200 lines of code to validate BaNaNaS uploads .. lol 21:42:46 <TrueBrain> and it aint done yet :P 21:47:41 <Eddi|zuHause3> if you write more than 100 lines in a day, you're probably doing it wrong 21:48:19 <DorpsGek_III> [OpenTTD/eints] frosch123 opened pull request #7: Add new string codes from OpenTTD 1.9 and 1.10 https://git.io/JvaBM 21:48:45 <frosch123> gh still sorts commits by author date, instead of by commit date 21:48:52 <TrueBrain> yup :( 21:54:34 <TrueBrain> only 25 uploads did not validate; 80% of that is OpenGFX, and 100% are Base Sets :D 21:54:35 <TrueBrain> how nice :D 21:56:02 <Eddi|zuHause3> nobody needs those... ship it :p 21:57:41 <TrueBrain> awh, AI/GS detection is broken :P 22:03:20 *** Progman has joined #openttd 22:06:20 <DorpsGek_III> [OpenTTD/eints] glx22 approved pull request #7: Add new string codes from OpenTTD 1.9 and 1.10 https://git.io/JvaRc 22:06:29 *** gnu_jj_ has quit IRC 22:15:00 *** Samu has quit IRC 22:20:36 <DorpsGek_III> [OpenTTD/eints] frosch123 merged pull request #7: Add new string codes from OpenTTD 1.9 and 1.10 https://git.io/JvaBM 22:22:09 *** frosch123 has quit IRC 22:33:15 *** gnu_jj has joined #openttd 22:38:15 *** Progman has quit IRC 22:50:16 *** nielsm has quit IRC 23:08:56 *** Lejving has quit IRC 23:16:31 *** Lejving has joined #openttd 23:20:50 *** nielsm has joined #openttd 23:38:36 *** HerzogDeXtEr has quit IRC 23:39:33 *** mindlesstux has joined #openttd