Times are UTC Toggle Colours
02:23:40 *** Klanticus has joined #openttd.dev 02:26:50 *** Klanticus_ has quit IRC 09:31:22 *** JacobD88 has joined #openttd.dev 12:31:07 *** JacobD88 has quit IRC 12:53:59 *** JacobD88 has joined #openttd.dev 13:27:13 *** JacobD88 has quit IRC 14:22:51 *** Klanticus_ has joined #openttd.dev 14:26:03 *** Klanticus has quit IRC 14:45:02 *** Klanticus has joined #openttd.dev 14:48:14 *** Klanticus_ has quit IRC 17:39:28 *** adf88 has joined #openttd.dev 17:39:28 *** ChanServ sets mode: +v adf88 18:31:52 <adf88> Some time ago we talked with Alberth about an issue with industries on the smallmap. 18:31:52 <adf88> The problem occurs when industries overlap each other. 18:31:52 <adf88> When you hide some industries, other industries "beneath" them won't show up, the spot will just become "clear". 18:31:53 <adf88> Zooming out, many industries, small industries, all these factors make things worse. 18:31:53 <adf88> It can be a real pain when using FIRS. 18:31:53 <adf88> It also makes sense to give highest priority to industries while in smallmap "Industries" view. 18:31:53 <adf88> Roads, railroads and stations may overlap them and this is undesirable, I think. 18:31:55 <adf88> Recently I wrote a patch for the two above, they nicely combine into something simpler so I decided to make one, common patch. 18:31:55 <adf88> Take a look: 18:31:57 <adf88> http://pastebin.com/BEkrPGRe 18:35:17 <adf88> oil rigs are also a good exaple 18:35:34 *** frosch123 has joined #openttd.dev 18:35:34 *** ChanServ sets mode: +v frosch123 18:36:02 <adf88> should the station hide the industry when zoomed out? 18:36:07 <adf88> rather not 18:40:27 <adf88> small industries inside towns like banks "disappear" too when zooming out 18:41:23 <frosch123> isn't that what _tiletype_importance is about? 18:43:03 <frosch123> hmm, so road is more important than industries currently :p 18:43:18 <frosch123> i guess that is fine for player-owned road, but meh for town-owned roads 18:45:48 <adf88> yes, it's _tiletype_importance responsible currently 18:45:57 <adf88> and it's insufficient 18:46:24 <frosch123> i always use the industry map view, never any of the other ones 18:46:40 <frosch123> so, i kind of have no idea whether it needs different priorities for different map types 18:47:19 <frosch123> but yes, industries seem to be the most important 18:47:46 <frosch123> since single tiles matter, while they do not really for other types 18:48:03 <adf88> found the talk with Alberth: http://webster.openttdcoop.org/?channel=openttd.dev&date=1435449600 18:48:16 *** Milek7 has left #openttd.dev 18:48:23 *** milek7 has joined #openttd.dev 18:48:31 <adf88> AFAIR he said that 18:48:44 <adf88> industries should not become globally most important 18:50:00 <adf88> that makes sens 18:50:26 <adf88> when you are in "routes" view, you want to see routes right? :) 18:52:38 <frosch123> yes, but routes are generally small and next to each other, so they hide each other 18:52:56 <adf88> routes was just an example 18:53:02 <adf88> anyway, giving highest priority doesn't solve the first problem 18:53:13 <frosch123> ultimately the ownership view will always fail when zoomed out :) 18:53:14 <adf88> one industries hiding other 18:53:43 <frosch123> i think there is no point in changing the other map modes, or at least i wouldn't know what to change 18:53:48 <frosch123> so, just changing industry view is fine 18:54:23 *** Klanticus_ has joined #openttd.dev 18:57:21 <frosch123> i wonder whether to remove GetEffectiveTileType and inline it 18:57:27 <frosch123> it is only called once 18:57:39 <frosch123> and what it does is not much different to the new stuff you added 18:57:44 *** Klanticus has quit IRC 18:58:06 <frosch123> (and it does not make sense to add the new stuff to GetEffectiveTileType) 19:00:58 <adf88> hmmm 19:01:02 <adf88> yea 19:03:47 <adf88> frosch123: before, I tried to put everything into GetEffectiveTileType 19:04:05 <adf88> but it wasn't nice 19:04:16 <adf88> perhaps doing the opposite is the way to go 19:25:19 <adf88> seems all ok 19:25:21 <adf88> http://pastebin.com/KdGRScbb 19:26:01 <adf88> (apply on top) 19:35:45 <frosch123> looks fine to me 19:35:48 <frosch123> will commit later :) 19:50:33 *** sgtbigman has joined #openttd.dev 20:49:41 *** sgtbigman has quit IRC 21:32:25 <frosch123> @services op 21:32:25 *** ChanServ sets mode: +o DorpsGek 21:38:50 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r27621 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 21:44:54 *** DorpsGek changes topic to "OpenTTD Dev Channel || Latest SVN: r27622 || Logs: http://webster.openttdcoop.org/?channel=openttd.dev || Voice (talk-right) upon request via #openttd; make sure you are registered to NickServ before asking" 21:51:11 *** sgtbigman has joined #openttd.dev 22:13:33 *** frosch123 has quit IRC 22:19:16 *** sgtbigman has quit IRC 22:30:27 *** JacobD88 has joined #openttd.dev 22:35:43 *** JacobD88 has quit IRC 23:34:33 *** _dp_ has quit IRC