Log for #openttd on 9th October 2016:
Times are UTC Toggle Colours
00:06:26  <Samu> question, is there a way to recompress a .sav file without loading and saving it again?
00:06:47  <Samu> erm, let me rephrase
00:07:43  <Samu> i saved using zlib:1, but want to convert to using lzma:9 without loading/saving because it would break some AIs
00:09:31  <Samu> wanted to upload smaller files to the forum
00:36:44  *** Samu has quit IRC
00:40:01  *** Flygon has joined #openttd
00:45:13  *** tokai|noir has joined #openttd
00:45:13  *** ChanServ sets mode: +v tokai|noir
00:49:24  *** Myhorta has quit IRC
00:52:04  *** tokai has quit IRC
00:53:13  *** Progman has quit IRC
01:26:04  *** tokai has joined #openttd
01:26:04  *** ChanServ sets mode: +v tokai
01:33:04  *** tokai|noir has quit IRC
01:58:27  *** gelignite_ has joined #openttd
02:05:46  *** gelignite has quit IRC
03:06:57  *** Lejving is now known as BIG_Lejving
03:08:22  *** BIG_Lejving is now known as Lejving
03:37:55  *** gelignite_ has quit IRC
03:48:30  *** glx has quit IRC
04:29:35  *** Snail has quit IRC
04:32:19  *** Snail has joined #openttd
05:11:29  *** Snail has quit IRC
06:15:48  *** sla_ro|master has joined #openttd
06:18:11  *** Flygon_ has joined #openttd
06:24:58  *** Flygon has quit IRC
06:27:27  *** Flygon_ has quit IRC
06:29:54  *** HerzogDeXtEr1 has quit IRC
06:40:37  *** Alberth has joined #openttd
06:40:37  *** ChanServ sets mode: +o Alberth
06:46:57  *** Supercheese has quit IRC
07:07:59  *** andythenorth has joined #openttd
07:08:05  <Alberth> yo, andy
07:17:12  *** Flygon has joined #openttd
07:20:10  *** Lejving has quit IRC
07:20:11  <andythenorth> Sunday cat
07:20:53  *** Lejving has joined #openttd
07:22:20  *** Flygon has quit IRC
07:24:15  *** andythenorth has quit IRC
07:25:03  *** keoz has joined #openttd
07:26:51  *** andythenorth has joined #openttd
07:30:16  *** Flygon has joined #openttd
07:39:47  *** Flygon has quit IRC
07:41:16  <Alberth> 1000 buildings project has major clashes in building style :)
07:41:52  * andythenorth looks
07:47:01  *** Flygon has joined #openttd
07:52:13  <andythenorth> is it Hog day?
07:55:21  <Alberth> could be renamed
07:55:33  <Alberth> s/Sun/Hog/
07:55:35  <Alberth> done
07:56:15  <Alberth> more tramz?
07:57:23  *** Flygon_ has joined #openttd
08:02:20  *** Flygon has quit IRC
08:08:02  <andythenorth> need to paint some unpainted angles
08:09:04  <Alberth> ah, I advise red or bright yellow for those angles, as they can be very sharp
08:09:35  *** Flygon__ has joined #openttd
08:11:12  <andythenorth> probably$prodImageMedium$
08:16:27  *** Flygon_ has quit IRC
08:20:42  <Alberth> If you have run out of red paint, black would work too :)
08:23:03  *** Wolf01 has joined #openttd
08:24:09  <Alberth> moin W
08:26:04  <Wolf01> o/
08:27:05  <andythenorth> lo Wolf01 :)
08:32:16  <Wolf01> Slow server is slow
08:32:48  <andythenorth> so what’s current blocker on NRT? o_O
08:32:54  <Wolf01> Me
08:33:04  * andythenorth is hoping $someone will get interested and help :)
08:33:15  <andythenorth> the patch you posted, I am out of my depth
08:33:29  <Wolf01> It seem I don't have enough knowledge to fix it
08:35:35  <andythenorth> what does it do / not do? o_O
08:36:15  <Wolf01> I think I'm stuck on the pack/upack of roadtypes
08:36:21  <Wolf01> *unpack
08:37:06  *** frosch123 has joined #openttd
08:37:24  <Wolf01> Quak
08:40:47  <frosch123> moi
08:43:17  <andythenorth> Wolf01: where’s the patch?
08:43:28  <Wolf01> My 1drive
08:44:42  <Wolf01>!AgUFeOGLNNfVhdJb5qXQXZwkjHmBgA
08:50:06  *** sla_ro|master has quit IRC
08:50:08  *** Flygon_ has joined #openttd
08:53:00  *** Snail has joined #openttd
08:56:57  *** Flygon__ has quit IRC
08:59:36  *** Snail has quit IRC
09:06:13  <Wolf01> andythenorth, I have a question, why do you/supermop/whoever put 1 train station non track tile connected to every truck station in
09:06:31  <andythenorth> displays waiting cargo
09:06:38  <andythenorth> so can see if station is under-served
09:07:12  <Wolf01> Oh, you mean visually intead of clicking the station
09:07:18  <andythenorth> yes
09:07:42  <andythenorth> it’s much less useful if more than one cargo is collected though
09:07:55  <andythenorth> because station display of multiple cargos is crap
09:10:25  <andythenorth> Wolf01: which branch should I compile this against?
09:10:29  <Wolf01> dev
09:10:36  <andythenorth> or just put it in the repo, broken? o_O
09:10:59  <andythenorth> usually I hate that, but it’s a dev branch, in a fork of a fork :P
09:11:12  <andythenorth> no kittens will die
09:11:17  <Wolf01> I would like to have something working, it compiles and run, but asserts almost immediately
09:12:13  <Wolf01> It retrieves "roadtype = 2" which is ROADTYPE_END
09:14:02  * andythenorth trying to apply the patch
09:14:07  <andythenorth> it assumes svn file structure? o_O
09:14:13  <andythenorth> looks svn-ish :P
09:15:02  <Wolf01> Yes, it breaks if I do it as git because I usually try to apply the same patch to different working copies
09:15:19  <Wolf01> Or even branches, or trunk
09:27:30  *** Webster has joined #openttd
09:28:20  <andythenorth> not sure how to resolve a failed patch
09:28:31  * andythenorth goes by line number
09:29:00  <andythenorth> dunno if it’s the line numbers in the patch, or the .rej file
09:29:17  <Wolf01> Usually I try to resolve by applying each chunk with the helper, but some times I do it manually
09:32:03  *** Progman has joined #openttd
09:33:09  <andythenorth> ach
09:33:18  * andythenorth can’t see why that wouldn’t patch
09:34:08  <Wolf01> Line endings maybe
09:38:47  <andythenorth> it fixed line endings in other files :|
09:39:20  <andythenorth> Wolf01: push it in dev-unpack branch? o_O
09:39:47  <Wolf01> Or directly in dev, as you said, it's a clone of a branch
09:41:16  <andythenorth> if we can get the unpack working, I think the rest is just work and yak-shaving
09:41:23  *** Wormnest has joined #openttd
09:42:06  <Wolf01> Committing
09:42:47  <Wolf01> It's 3-patches-in-one because it's too wide spread to get all divided
09:43:33  <Wolf01> Done
09:43:48  <andythenorth> got it
09:45:57  <andythenorth> yeah asserts for me
09:46:12  <andythenorth> got a compile warning about “CompareRoadTypes” being unused also, probably not relevant?
09:46:15  <Wolf01> Yes, it asserts, with no doubt :P
09:46:54  <Wolf01> Not relevant, I disabled sorting
09:47:14  <Wolf01> I'll re-enable it when I'll get it working
09:47:33  <Wolf01> GetRoadTypeInfo() is the problem
09:48:06  <andythenorth> not Unpack() ?
09:49:01  <Wolf01> It's the entire RoadTypeIdentifier if we want to be precise
09:49:07  <andythenorth> ok it doesn’t assert with no grf
09:49:12  * andythenorth working through things
09:49:19  <andythenorth> we’re sure it’s not the grf is broken?
09:49:29  <Wolf01> Could be
09:49:31  <andythenorth> but then if it was, the behaviour should be better handled than assert
09:49:37  <andythenorth> "should"
10:04:05  *** Defaultti has quit IRC
10:07:14  *** Defaultti has joined #openttd
10:17:32  *** Myhorta has joined #openttd
10:18:56  <andythenorth> Wolf01: I’ve made a grf that has “ROAD” as label rather than “WOLF"
10:19:13  <andythenorth> appears not to assert, _if_ I’ve done it right :P
10:19:46  <Wolf01> It should appear in the road types dropdown if I made it right
10:21:16  <andythenorth> I just get one type, normal road
10:21:21  <andythenorth> that’s expected?
10:21:45  <Wolf01> No
10:22:00  <andythenorth> can I get it to print the label in shell?
10:22:07  <andythenorth> it’s printing the roadtype props
10:22:29  <Wolf01> It only prints the uint32, I don't know how to print the string
10:24:56  <andythenorth> hmm
10:25:14  <andythenorth> this is painful eh? :D
10:27:28  <Wolf01> It's depressing, not painful
10:28:46  <andythenorth> ok so changing the label from “ROAD” definitely triggers the assert
10:29:05  <andythenorth> so why doesn’t that assert when label is “ROAD”…? o_O
10:29:21  <Wolf01> Because it asserts when adding a roadtype
10:29:34  <Wolf01> Not when changing an existing one
10:29:39  <andythenorth> ok
10:29:52  <andythenorth> are the ranges for GB correct?
10:30:01  <Wolf01> I don't think so
10:30:15  <Wolf01> Maybe thy are off by 1
10:30:46  <andythenorth> “C++ for dummies”: why is ret a bool?
10:31:00  <andythenorth> the return value from Unpack() is a bool?
10:31:14  <Wolf01> Yes, it returns if unpacked succesfully
10:32:36  <andythenorth> ok
10:35:06  * andythenorth needs a pencil and paper to draw bits :( :P
10:36:45  <argoneus> good morning train friends
10:38:35  <Wolf01> o/
10:41:29  <andythenorth> Wolf01: I can stop the assert on L207 of road.cpp :(  (by commenting it out)
10:41:41  <andythenorth> that gets me more asserts in road.h
10:41:54  <Wolf01> Heh... that's because it's returning the wrong type
10:42:14  <Wolf01> There's an assert there for a reason :P
10:42:43  *** Arveen has joined #openttd
10:48:02  <Eddi|zuHause> andythenorth: if the grf is faulty, it should error out much earlier
10:48:34  <Wolf01> Yes
10:49:32  <Wolf01> But I think it is already on the reservation for the newgrf which calls GetRailTypeInfo() to check if there's already a label
10:51:12  <andythenorth> ha ha
10:51:36  <andythenorth> I forced this->subtype = (RoadType)1;
10:51:43  <andythenorth> and now I am building tram instead of road :P
10:51:55  <andythenorth> (RoadType) is a cast?
10:52:00  <Eddi|zuHause> yes
10:52:01  <Wolf01> Yes
10:52:29  <Eddi|zuHause> not to confuse with RoadType(1), which would be a constructor
10:56:17  <andythenorth> ach can’t just printf the result of GB
10:56:21  <andythenorth> have to format it
10:59:06  <andythenorth> Wolf01: if basetype is 0 and subtype is 1, what should the result be? o_O
10:59:10  <andythenorth> I get tram track and trams :P
11:00:03  <Wolf01> Basetype 0 is road, and subtype 1 should be a new roadtype
11:00:19  <andythenorth> yeah...
11:00:33  * andythenorth is prone to hard-coding things to test, rather than debugging ‘properly'
11:01:39  <Wolf01> I have a bigger problem now: need to transport gasoline, I only have fuel cargo O_o
11:04:09  <Wolf01> Oh, it works
11:08:23  <andythenorth> ? o_O
11:08:34  *** Arveen2 has joined #openttd
11:08:34  *** Arveen is now known as Guest1575
11:08:34  *** Arveen2 is now known as Arveen
11:08:35  <Wolf01> Mix of different grfs
11:08:43  <Wolf01> UKRS, FIRS...
11:08:52  <andythenorth> sounds like something is changing cargo name?
11:09:43  <Wolf01> Italian translation is different, in english is correct
11:10:40  <Wolf01> UKRS "petrol" translate to "carburante (fuel)" while FIRS "petrol" translates to "benzina (gasoline)"
11:10:43  <andythenorth> ah ok
11:10:50  * andythenorth staring at RoadType() :P
11:11:02  *** Guest1575 has quit IRC
11:25:31  *** Alberth has left #openttd
11:29:05  *** gelignite has joined #openttd
11:32:31  <andythenorth> Wolf01: I got nothing :(
11:32:36  <Wolf01> :/
11:32:41  <andythenorth> needs code review from someone who isn’t andythenorth :(
11:32:44  <Wolf01> I'll give it a look too
11:33:03  *** Samu has joined #openttd
11:33:40  <Samu> @logs
11:33:40  <DorpsGek> Samu:
11:34:04  <Wolf01> Samu, give it a look you too
11:35:05  <andythenorth> see if you can get Eddi|zuHause interested
11:35:24  <Samu> what am i looking at?
11:35:25  <Eddi|zuHause> that'll be hard
11:35:26  <Wolf01> Oh, he is interested
11:35:38  <Wolf01> He just don't want us to know
11:35:40  <andythenorth> it’s an obiwan somewhere, € on it
11:35:41  <Wolf01> ;)
11:35:42  <Eddi|zuHause> well, interested, just not motivated
11:36:06  <andythenorth> or subtype and basetype are transposed somewhere :P
11:36:23  <Wolf01> Samu, Roadtypes, but it asserts because I don't know how to do it right in the RoadTypeIdentifier
11:36:44  * andythenorth suspects subtype and basetype transposition in a way that doesn’t show up when both are 0
11:37:06  <andythenorth> Samu: you have to have a test grf also
11:38:27  <andythenorth> this one
11:38:45  <Samu> hmm, not really sure if i follow
11:39:06  <Samu> - i downloaded this
11:40:05  <Samu> gonna try loading project in visual studio
11:40:50  <andythenorth> it’s a git repo forked from main openttd repo
11:40:53  <andythenorth> should be fine
11:43:56  <Samu> Visual studio does not like it "Security Warning for openttd_vs140: The project file openttd_vs140 may have come from a location that is not fully trusted.
11:44:17  <Samu> Would you like to open this project?
11:45:59  <Samu> is this project gonna do a format c: or something :o
11:46:41  <Wolf01> We are working on roadtypes and we don't know how to fix a thing, we just need more point ov views
11:51:29  <andythenorth> Samu: could just clone it with git? o_O
11:54:21  <Samu> ok, back, gonna try building it
11:55:26  <Samu> crap, needs those essentials stuff, brb
11:57:31  <Wolf01> Why don't you prepare an openttd_vs140.vcxproj.user file?
11:58:06  <Wolf01> I just copy that on every working copy and ba-dum! Useful included automagically
11:58:26  <Wolf01> *Essentials
12:01:52  <Samu> tortoise scv checkout doesn't work
12:02:00  <Samu> or it's slow
12:02:23  <Samu> ah, it just started
12:02:34  <Wolf01> Git server is slow
12:02:43  <Wolf01> *Github
12:04:17  <Wolf01> Also I found why I missed key strokes, I connected again keyboard and mouse in the same usb hub...
12:04:36  <Samu> there's branches, and there's trunk, which one is it?
12:04:46  <Wolf01> dev
12:05:03  <Wolf01> I don't know why, but if I do that they miss key strokes or even mouse clicks
12:05:04  <Samu> branches/dev ?
12:05:07  <Wolf01> Yes
12:06:07  * andythenorth bbl
12:06:08  <Samu> whatt's the vcxproj.user file?
12:06:09  *** andythenorth has quit IRC
12:06:46  <Samu> how do i prepare that
12:07:03  <Wolf01> A user file to store user-dependant project properties instead of modifying the distributed project file
12:08:13  <Wolf01> I did this
12:08:56  <Wolf01> Where OTTD_IncludePath and OTTD_LibraryPath are environment variables, you can put the exact path if you want
12:16:28  <Samu> sorry for noob question, is that the conents of a 'openttd_vs140.vcxproj.user' file?
12:16:41  <Samu> i've never done it before
12:16:51  <Samu> contents*
12:16:59  <Wolf01> Yes
12:17:51  <Samu> well anyway, i just done it by editing the vcxproj, maybe next time
12:17:56  <Samu> it built!
12:18:06  <Samu> how am i triggering the crash now?
12:18:45  <Wolf01> Loading the provided grf
12:19:03  <Samu> oh right
12:21:40  <Samu> ah, crashed when starting a new game
12:36:05  *** Wormnest has quit IRC
12:36:32  <Samu> return (0< 16) && (2 < 2);
12:36:40  <Samu> true && false
12:36:53  <Samu> i don't really know what these values mean
12:36:59  <Samu> false is 0?
12:38:28  *** Gja has joined #openttd
12:38:40  <Samu> where is this data = 2 coming from t.t o
12:39:27  <Wolf01> From Unpack(), and that, or pack, is wrong
12:42:14  <Samu> hmm i see there's 2 RoadTypes and 16 RoadSubTypes ...
12:42:24  <Samu> i'd need to learn how is this all organized
12:44:37  <Wolf01> RoadTypeIdentifier should be a tool to provide an unique number based on base type + sub type, for example "Road + paved road 120kmh" or "Tram + rack and pinion rail"
12:45:14  <Wolf01> And with that number you can know if it's road or tram
12:45:25  <Wolf01> And which one if road or tram
12:46:05  <Wolf01> It's needed in cases where you can't pass more parameters (sort functions)
12:46:32  <Wolf01> But also to keep the code clean instead of passing 2 parameters everywhere
12:46:59  <Samu> basetype can't be 2, i see that throughout the code
12:47:19  <Wolf01> Indeed, that's wrong, it can only be 0 and 1
12:48:00  <Samu> this->basetype = (RoadType)GB(2, 0, 2);
12:48:07  <Samu> = 2
12:51:01  <Samu> return (this->basetype << ROADSUBTYPE_END) | this->subtype; trying to decipher this
12:51:17  <Samu> when it was packed it was 1, right?
12:51:21  <Samu> or either 0 or 1
12:51:29  <Samu> would it pack 2?
12:51:37  <Samu> assert is there, so i suppose not
12:51:57  <Wolf01> It should be GB(2, 0, 1)
12:52:54  <Wolf01> And the following line GB(2, 2, 4)
12:53:48  <Wolf01> Need to store length in bits in the enum
13:00:46  *** aard has joined #openttd
13:08:09  <Wolf01> Ok, now it seem that there's a problem with the FOR_ALL_SORTED_ROADTYPES, I can't find other road types even if there are
13:08:24  <Samu> return (2 << 16) | 0 - who's a math expert
13:10:01  <Samu> or right, 2 is not possible
13:10:06  <Samu> return (1 << 16) | 0 - who's a math expert
13:11:24  <Samu> I'm getting 65.536 - is that what should be stored? I'm a bit confused now
13:11:53  <Samu> erm, packed
13:12:17  <Wolf01> No, it should pack 4
13:12:43  <Wolf01> Pack() is wrong too
13:13:20  <Wolf01> I mixed lengths with max values
13:13:58  <Samu> is pack and unpack related?
13:14:07  <Samu> how does it go from 65536 to 2
13:14:07  <Wolf01> Yes, they are
13:14:57  <Wolf01> Pack 0 and 0 -> *number* -> unpack -> 0 and 0
13:15:49  <Samu> pack returns 65536, then somehow it becomes 2 when it unpacks
13:16:44  <Wolf01> Unpack should do:
13:16:45  <Wolf01> 	this->basetype = (RoadType)GB(data, 0, 1);
13:16:45  <Wolf01> 	this->subtype = (RoadType)GB(data, 2, 4);
13:17:04  <Wolf01> I must go now, bbl
13:24:44  <Samu> this->basetype = (RoadType)GB(data, 0, ROADTYPE_END -1);
13:24:47  *** Gja has quit IRC
13:25:43  <Samu> this->subtype = (RoadType)GB(data, ROADTYPE_END, calculate_4_somwhoe);
13:25:55  <Samu> this->subtype = (RoadType)GB(data, ROADTYPE_END, calculate_4_somehow);
13:27:08  <Samu> basetype is stored in 1 bit, right?
13:27:30  <Samu> the other is in 4 bits
13:28:03  <Samu> I think you want this->subtype = (RoadType)GB(data, 1, 4);
13:28:09  <Samu> not 2,4
13:30:11  *** HerzogDeXtEr has joined #openttd
13:30:57  <Samu> 7654 3210
13:31:06  <Samu> 0000 000x - RoadType
13:31:20  <Samu> 000x xxx0 - RoadSubType
13:31:45  <Samu> 000 x xxxx - RoadType + RoadSubType
13:31:51  <Samu> 000x xxxx - RoadType + RoadSubType
13:31:54  <Samu> :o
13:32:37  <Samu> but packing needs fixing
13:32:39  <Samu> grrr
13:34:54  <Samu> return this->basetype | (this->subtype << 1); maybe this?
13:36:37  *** sim-al2 has quit IRC
13:37:33  <Samu> trying the test grf
13:37:34  <Samu> brb
13:38:26  <Samu> it's generating world :)
13:39:09  *** HerzogDeXtEr1 has joined #openttd
13:40:11  <Samu> world generated but there's another assert when i get to road construction
13:40:14  <Samu> meh :(
13:43:12  <Samu> 		assert(list->Length() > 0);
13:43:20  <Samu> dropdown window error
13:43:51  <Samu> there are 0 items in the dropdown list
13:45:44  *** HerzogDeXtEr has quit IRC
13:59:23  *** Arveen has quit IRC
14:38:17  *** Alberth has joined #openttd
14:38:17  *** ChanServ sets mode: +o Alberth
14:53:14  <Samu> just started testing RoadRunner v10
14:53:29  <Alberth> meep meep!
15:27:21  *** andythenorth has joined #openttd
15:30:34  <Samu> andythenorth: hi
15:30:46  <andythenorth> lo
15:31:08  <Samu> how many road types are in your test grf
15:31:38  <Samu> I presume 1, but not sure
15:32:05  <Alberth> o/
15:32:49  <Samu> i also tested the generic tram set
15:32:54  <Samu> and i could only build roads
15:33:16  <Samu> seems like 2 is 1, and 1 is 0
15:34:32  <andythenorth> Samu: just 1 in the grf I linked iirc
15:36:37  <Samu> seems to be it, when i access the road construction dropdown it crashes because there are 0 items to display
15:36:58  <Samu> but didn't crash with generic tram set
15:37:16  <Samu> Wolf01: wake up
15:41:39  * andythenorth should probably delete this post
15:41:50  <andythenorth> nothing good will come of it
15:45:17  <Samu> i didn't read the whole topic, but it's about licenses?
15:45:39  <Samu> i hate licenses
15:45:41  <andythenorth> it’s about misunderstandings
15:46:01  <Samu> if i post something on the internet, it's not mine anymore
15:46:12  <Alberth> false
15:46:28  <Alberth> the law says it's still yours
15:46:34  <andythenorth> Samu: (1) you need the wtfpl :) (2) nah
15:46:37  <Samu> anymore can do whatever they want with it :o
15:46:46  <andythenorth> only if you license it for that
15:46:49  <andythenorth> ;)
15:46:50  <Alberth> you have to explicitly say you give it away
15:47:05  <Samu> it's the internet, once there, always there
15:47:44  <andythenorth> nah :)
15:47:46  <andythenorth> not
15:48:11  <Alberth> being around is not the same as being allowed to use
15:48:31  <Alberth> andy: indeed, post won't do much good
15:48:49  * andythenorth deletes
15:48:58  <Samu> not like i have any say on what the others do with it
15:49:13  <Alberth> Samu: but it's easily solved, just say with every post  that the content has a the WTPL  license
15:50:18  <Samu> i don't get why do I need a license of stuff I post
15:51:14  <andythenorth> you don’t need to
15:51:27  <Alberth> you don't, but then everything you post is still yours, others may not use it as they see fit
15:51:34  <Alberth> ^ Samu
15:51:59  <Alberth> just ass it to your signature :)
15:52:01  <Alberth> *add
15:52:53  * andythenorth removed the post
15:53:02  <andythenorth> spending Sunday arguing on the internet might have been fun
15:53:08  <andythenorth> but Monday is a work day :P
15:57:45  <Alberth> :)
15:58:03  <Samu> screw that wtf license
15:58:05  <andythenorth> he must be about 15?
15:58:07  <Alberth> stuff seems mostly settled
16:00:39  <Samu> - the seriousness of this site...
16:02:23  <andythenorth> pretty serious business
16:08:30  <Alberth> WTPL is an official open source license. It even has a real use, some countries do not recognize public domain, That license is equivalent to it, but it does get recognized as being legal in those countries
16:10:48  <Wolf01> Back
16:11:01  <Wolf01> andythenorth, I think I fixed one of the asserts
16:11:45  <Wolf01> I need to understand the Pack() stuff now
16:16:19  <andythenorth> great :)
16:17:29  *** Snail has joined #openttd
16:19:07  <Samu> hey Wolf01 andythenorth
16:19:33  <Samu> did you read logs? i typed stuff when you were gone
16:20:04  <Wolf01> Samu, did you read that I fixed it way before you wrote that?
16:20:19  <Samu> yes
16:20:23  <Wolf01> Then?
16:20:32  <Samu> pack was fixed
16:20:35  <Samu> or not?
16:21:10  <Samu> sec, i copy paste
16:22:16  <Samu> for unpack i did this this->basetype = (RoadType)GB(data, 0, 1);
16:22:27  <Samu> this->subtype = (RoadType)GB(data, 1, 4);
16:23:08  <Samu> for pack i did this return this->basetype | (this->subtype << 1);
16:24:29  <Samu> it worked, but there's more crashes
16:24:33  <Wolf01> Ok
16:25:41  <Samu> there's 2 is 1 and 1 is 0 issues somewhere when constructing a list of items for the road dropdown menu
16:26:49  <Wolf01> That's because I hardcoded the showinf of tram
16:26:54  <Wolf01> *showing
16:27:03  *** tokai has quit IRC
16:27:18  <Wolf01> I need to change the macro FOR_ALL_SORTED_ROADTYPES
16:31:01  <Samu> you have said you did: this->subtype = (RoadType)GB(data, 2, 4);
16:31:20  <Samu> i suppose it should be: this->subtype = (RoadType)GB(data, 1, 4);
16:32:02  *** tokai has joined #openttd
16:32:02  *** ChanServ sets mode: +v tokai
16:32:24  <Wolf01> Yes it should be 1, 4
16:34:26  <Wolf01> andythenorth, could you provide a roadtype with a different menu text? Dropdowns don't seem to work really well with same text
16:35:44  <Samu> i used generic tram set
16:36:17  *** frosch123 has quit IRC
16:37:13  <Wolf01> It's not related to a tram set
16:38:48  <Wolf01> Committed some fixes
16:46:05  <Samu> let me see what happens when i use it
16:47:33  <Samu> yay nice job, i can build trams and roads now
16:48:52  <Wolf01> Nice error I'm getting now "96,030 bags of sweet"
16:50:08  <Alberth> enough to fill a house :)
16:50:56  <Samu> I'm getting: Road Construction, Road Construction, Tramway Construction
16:51:18  <Wolf01> Yes, the second road should be the new one
16:51:21  <Samu> the two Road Constructions are pegged into each other, not separate
16:56:26  <Samu> a quick fast forward test shows RoadRunner v10 doing much much better than v9
17:02:53  *** sla_ro|master has joined #openttd
17:02:58  <Samu> and not cheating
17:03:15  <Samu> hehe, RoadRunner was the cheating AI with 80 year preview vehicles :)
17:03:32  <Samu> but that was fixed in 1.6.1
17:03:54  <Samu> would have to test in 1.5.0 or something to see if it really was fixed, i'm not in the mood for it
17:05:48  <Wolf01> Mmmh, I need to get rid of all those RoadTypeToRoadTypes()
17:06:27  <Wolf01> Also I fixed even that double selected dropdown item
17:06:42  <Wolf01> Too bad the second roadtype is unbuildable right now
17:12:52  <Samu> this is too much information to post in the forum
17:13:03  <Samu> horizontal scrolling will be needed
17:13:16  <Samu> not sure if i post these results like that
17:25:55  <andythenorth> Wolf01: I’ll make a new grf shortly
17:26:15  <Samu> i'm not sure how terron managed a 101% with ships
17:26:25  <Samu> i think he uses transfer orders
17:26:51  <Samu> buses transfer passangers to ships
17:27:51  <Samu> not sure about the whole math involved in transfers, but... ship profit averaged higher than the best last year ship profit
17:28:32  <Samu> in better english: the average is higher than the best
17:34:51  <Samu> or he sold quite some many ships right before entering 2051
17:35:02  <Samu> and that would inflate the average
17:35:09  *** Myhorta has quit IRC
17:35:19  <Samu> terron likes to renew vehicles for no reason
17:35:31  <Samu> way before their max age
17:39:33  <Samu> maybe he cheats like rondje
17:39:36  <Samu> i dunno
17:42:29  <Samu> @calc (((1131295-273205)/10)/85249)*100
17:42:29  <DorpsGek> Samu: 100.656899201
17:42:35  <Samu> it's over 100
17:42:38  <Samu> :(
17:42:42  <Samu> i rounded up to 101
17:45:48  <DorpsGek> Commit by translators :: r27659 trunk/src/lang/portuguese.txt (2016-10-09 19:45:39 +0200 )
17:45:49  <DorpsGek> -Update from Eints:
17:45:50  <DorpsGek> portuguese: 25 changes by Samu
17:45:57  <Samu> oh, ty
17:46:19  <Samu> is that my name there? it should be Xarick
17:46:24  <Samu> whatever, doesn't matter
17:56:21  <andythenorth> Wolf01: is the menu fetching the correct strings? o_O
17:57:08  <Samu> andythenorth: your grf crashes on original 1.6.1
17:57:08  <Wolf01> Seems not
17:57:17  <Samu> it's not supposed to use it, right?
17:57:31  <andythenorth> Samu: no support for roadtype ;)
17:57:37  <andythenorth> crashing is ‘correct’
17:58:00  <andythenorth> Wolf01: this one has two types
17:58:14  <andythenorth> ‘default’ ROAD, and WOLF road
17:58:30  <andythenorth> the strings don’t work for me though
17:59:16  <Wolf01> The second type has something different
17:59:24  <Wolf01> But still not using the right strings
18:00:37  <andythenorth> it misses one way roads, I noticed
18:00:50  <Wolf01> Yup
18:01:15  <Wolf01> But I think it's because some hardcoded check on roadtype "1"
18:01:44  <Wolf01> Since it should be using road subtype 1 now it might be that...
18:02:53  <Wolf01> There are many things to change
18:03:11  <Wolf01> It's checked everywhere that the roadtype must be road or tram
18:03:47  <andythenorth> yes
18:03:58  <andythenorth> but we now have it not crashing
18:04:01  <andythenorth> which is a big deal )
18:04:02  <andythenorth> :)
18:04:14  <Wolf01> And it's even loading another dropdown item!
18:05:44  <andythenorth> construction menu thinks it’s a tramway :)
18:06:13  <Wolf01> I can't decide if RoadTypeInfo is wrong
18:06:28  <andythenorth> also nothing builds on the new type :D
18:06:49  <Wolf01> No, that's because the hardcoded checks in tram and road
18:06:54  <andythenorth> yair
18:07:07  * andythenorth has seen those checks before and changed them in an old patch ;)
18:07:13  <Wolf01> If you build a roadstop it even asserts
18:07:27  <andythenorth> on a string eh?
18:07:29  <andythenorth> interesting
18:10:01  <Samu> pt_PT and pt_BR are copied over each other? or are they just suggestions?
18:10:18  <Samu> the translation website is smart!
18:20:53  <Samu> the portuguese translators have a tough town versus city issue
18:21:09  <Samu> i guess we initially translated town to city
18:21:28  <Samu> then city became part of openttd
18:21:45  <Samu> and we still kept translating city to city
18:21:54  <Samu> bah :(
18:24:45  <Samu> is there a way to send notes to other portuguese translators? or put notes about certain words?
18:25:20  <Samu> we're not in agreement about this town vs city issue
18:26:34  <Samu> i'd like a note saying: DO NOT TRANSLATE CITY TO CITY, BUT TO METRÓPOLE
18:30:14  <Samu> the root of the problem was at the beginning, whoever was at it, translated town to city, instead of village
18:38:17  *** Snail has quit IRC
18:44:18  <Samu> town to city is also correct, but not when openttd also has city
18:49:03  *** Gja has joined #openttd
18:50:34  *** Myhorta has joined #openttd
19:03:35  <Wolf01> Samu, feel free to change all town occurrencies
19:14:54  *** Supercheese has joined #openttd
19:18:34  *** Wormnest has joined #openttd
19:22:33  *** glx has joined #openttd
19:22:33  *** ChanServ sets mode: +v glx
19:29:52  *** Alberth has left #openttd
19:32:52  <Wolf01> andythenorth, I found why there were no strings in the errors of the second roadtype
19:33:20  <Wolf01> Also why is the item title "road" and toolbar title "tramway"
19:34:17  <Wolf01> The funny thing is that now you can build both roads
19:36:46  <Wolf01> The last one is because I'm stupid
19:40:43  <Wolf01> Uhm, it seem to work anyway
19:42:49  <Wolf01> I want to try a thing
19:43:36  <Wolf01> Ok, it seem I can add an arbitrary number of roadtypes and tramtypes now
19:43:57  <andythenorth> Wolf01: let me know if there’s something to pull :)
19:44:02  <andythenorth> if / when
19:44:13  <Wolf01> I committed some fixes and changes
19:45:44  *** Supercheese has quit IRC
19:48:03  <andythenorth> Wolf01: nicely played
19:48:13  <andythenorth> both types now show
19:48:24  <Samu> Wolf01: well i could do that, but then the next translator would find town and translate it to city, it's natural translation, and then another one finds city and then translates to city :(
19:48:35  <andythenorth> hoo
19:48:42  *** aard has quit IRC
19:48:47  <andythenorth> be useful if the land inspector gained the newgrf debug tools for NRT
19:49:09  <andythenorth> maybe Samu would do that? o_O
19:49:10  <Wolf01> Yup, we will do that
19:49:31  <Samu> ? i was answering to Wolf01 [20:03] <Wolf01> Samu, feel free to change all town occurrencies
19:49:42  <Wolf01> I added a second tramtype with label "etrm" and menu string from elrail and it works
19:50:03  <andythenorth> in newgrf, or hard-coded? o_O
19:50:08  <Wolf01> Hard coded
19:50:24  <andythenorth> hard-coded ftw when it’s a complex patch
19:50:46  *** Supercheese has joined #openttd
19:50:49  <Wolf01> You could do that by copying the tram definition in roadtypes.h
19:50:53  <Samu> it's natural for us to translate town to city
19:51:18  <Wolf01> I just added another "original roadtype"
19:51:33  <Samu> bah whatever, doesn't matter
19:51:38  <Wolf01> It's like it's done by a newgrf but it's hardcoded instead
19:52:03  <Samu> town = cidade
19:52:10  <Samu> city = cidade
19:52:24  <Samu> everything is a cidade.... and it can't be
19:52:25  *** sim-al2 has joined #openttd
19:52:48  <Samu> i think im going crazy
19:53:57  <Wolf01> So you in portuguese call a town city?
19:54:10  <Samu> it's usually that
19:54:16  <Samu> but it could also be village
19:54:21  <Wolf01> And also a city city?
19:54:28  <Samu> yes
19:54:31  *** HerzogDeXtEr1 has quit IRC
19:54:39  <andythenorth> USA often does same
19:54:53  <andythenorth> ‘city’ is a legal incorporation, but might be 500 people
19:57:33  *** sla_ro|master has quit IRC
19:58:48  <Wolf01> It would be cool if while I'm doing the gui part somebody tries to fix the grf loading part... if that need a fix
19:59:26  <Wolf01> I can't understand why it doesn't load a different string for the dropdown
19:59:47  <Wolf01> Maybe because it isn't handled?
20:00:55  <Samu>
20:01:07  <Samu> A vila is a town in Portugal.
20:01:12  <Samu> that settles it
20:02:00  <Samu> i blame the first ever translator that made town to cidade
20:02:04  <Wolf01> Then change it, cidade for town is wrong
20:02:22  <Samu> there's towns all over it, gah... :(
20:02:30  <Samu> not in the mood for it now :(
20:02:55  <andythenorth> Wolf01: the strings are at least in the encoded grf, I have confirmed that much
20:05:43  <Wolf01> Oooooooh, I found how to pass the correct roadtype
20:06:19  <Wolf01> I just need some help with flags
20:07:27  <Wolf01> DoCommandP(start_tile, end_tile, _place_road_flag | (_cur_roadtype << 3) | (_one_way_button_clicked << 5), .....
20:07:44  <Wolf01> I need to pass the _cur_roadtype_id there
20:08:04  <Samu> it's 1 bit?
20:08:09  <Wolf01> No
20:08:27  <Samu> _cur_road_type is 1+4 bits?
20:08:29  <Wolf01> I used uint32 because I didn't know the exact length
20:08:44  <Wolf01> But I think I could reduce to uint8
20:09:02  <Wolf01> Yes Samu, it's that
20:09:44  <Samu> 7654 3210
20:10:00  <Samu> 000x xxxx - _cur_road_type
20:10:59  <Samu> _cur_roadtype << 3 means ....
20:11:14  <Samu> xxxx x000
20:13:34  <Wolf01> So the _one_way_button_clicked must be moved by 8 instead of 5?
20:14:35  <Wolf01> I really have problems to follow bit shifting
20:15:15  <Samu> me too, kinda, i used the windows calculator for that
20:15:36  <Samu> change calculator mode to programmer
20:15:51  <Samu> then it has all the nice bit math stuff
20:16:06  <Wolf01> Yes I know
20:16:08  <Samu> left shift right shihft, word, dwords etc... crap like that
20:17:43  <Samu> _one_way_button_clicked is this 1 bit too?
20:17:47  <Eddi|zuHause> <Wolf01> DoCommandP(start_tile, end_tile, _place_road_flag | (_cur_roadtype << 3) | (_one_way_button_clicked << 5), ..... <-- that sounds like a place where you should use pack/unpack
20:17:48  <Wolf01> Yes
20:18:28  <Wolf01> Yes Eddi, I'm trying to put there the packed identifier to unpack on the other side
20:18:37  <Samu> in calculator i did 1 Lsh 8 = 256 in decimal
20:18:52  <Samu> in bin it's 1 0000 0000
20:19:09  <Samu> 8 7654 3210
20:19:21  <Samu> so ya, i thnk that's where u want it
20:19:55  <Samu> but a byte is only 8 bits
20:20:00  <Samu> u got 9 bits already
20:20:31  <Wolf01> The param is uint32, so I don't think it's a problem
20:21:25  <Wolf01> The problem is: id is uint8 but only 5 bits are used, what kind of errors will this bring in future?
20:23:29  <Samu> you only want to read those 5 bits
20:24:02  <Samu> I don't really know, honestly
20:24:33  <Samu> as long as you only use 5 bits and read only those 5 bits, there is no problem, but i'm not an expert
20:24:55  <Wolf01> <- I mean this
20:26:12  <Wolf01> Maybe it's not even a problem
20:26:35  <Samu> you have asserts all over the place for that part you showed me
20:26:49  <Samu> only 5 bits
20:26:53  <Samu> 4+1
20:26:57  <Eddi|zuHause> it's not a problem, just you need to document the limitation so someone who extends it stumbles over it
20:27:37  <Samu> you limited it already to 5 bits
20:28:02  <Wolf01> Asserts can be changed
20:28:31  <Wolf01> I'll do as Eddi suggested, a comment in the right place could only be a good thing
20:28:39  *** aard has joined #openttd
20:28:59  *** Snail has joined #openttd
20:45:53  * andythenorth -> bed
20:46:00  <andythenorth> Wolf01: progress is good :) \o/
20:46:07  <Wolf01> Yup
20:46:14  <Wolf01> But far from working
20:46:29  <Wolf01> Also needs a lot of cleanup
20:46:51  <Wolf01> nn
20:48:26  *** Supercheese has quit IRC
20:51:47  <Wolf01> Samu, is there a window which shows all the set breakpoints?
20:58:07  <Samu> Debug > Windows > Breakpoints
20:58:33  <Wolf01> Bah.. to many places for "windows"
20:58:35  *** Ethereal_Whisper has joined #openttd
20:58:41  <Wolf01> I didn't even notice that
20:59:00  <Wolf01> Thank you anyway
21:00:46  *** Supercheese has joined #openttd
21:06:36  *** andythenorth has left #openttd
21:28:55  *** sim-al2 has quit IRC
21:36:11  *** sim-al2 has joined #openttd
21:40:58  *** gelignite has quit IRC
21:52:17  *** Progman has quit IRC
21:57:04  *** keoz has quit IRC
21:58:05  *** aard has quit IRC
22:23:31  *** Gja has quit IRC
22:40:54  *** Wormnest has quit IRC
22:42:46  *** Biolunar has joined #openttd
22:47:44  *** NGC3982 has quit IRC
22:47:57  *** NGC3982 has joined #openttd
22:57:11  *** Lejving_ has joined #openttd
22:57:59  *** Supercheese has quit IRC
23:01:01  *** Lejving has quit IRC
23:24:44  <Wolf01> 'night
23:24:48  *** Wolf01 has quit IRC
23:31:44  *** Biolunar has quit IRC
23:44:53  *** Lejving_ is now known as Lejving

Powered by YARRSTE version: svn-trunk