Log for #openttd on 2nd October 2018:
Times are UTC Toggle Colours
00:04:27  *** HerzogDeXtEr has quit IRC
00:09:11  <Samu> died?
00:09:15  <Samu> nvm it's back
00:33:49  *** rocky11384497 has quit IRC
00:50:52  *** Samu has quit IRC
01:01:23  *** snail_UES_ has joined #openttd
01:14:59  *** Flygon has joined #openttd
01:21:16  *** WWacko1976-work has joined #openttd
01:59:32  *** whtemple1959 has joined #openttd
02:02:26  <whtemple1959> hello room, I have an oil refinery butted but to a rail staion with a trian refitted to carry refined products. I hve trucks delivering crudde oil from the oil fields. there is 85,000 gallons of oil siting in the truck stops. could some one explain why the refinery is not conveting the oild?
02:06:01  *** Extrems has quit IRC
02:08:56  *** Extrems has joined #openttd
02:56:48  *** Supercheese has joined #openttd
03:03:08  *** whtemple1959 has left #openttd
03:14:13  *** haudrauf has quit IRC
03:15:11  *** haudrauf has joined #openttd
03:36:06  *** rocky11384497 has joined #openttd
04:14:31  *** glx has quit IRC
04:17:52  *** OtakuSenpai has joined #openttd
04:24:42  *** Supercheese has quit IRC
04:25:04  *** Supercheese has joined #openttd
04:44:46  *** snail_UES_ has quit IRC
05:04:59  *** Wacko1976 has quit IRC
05:18:01  *** rocky11384497 has quit IRC
05:25:59  *** Yotson_ has joined #openttd
05:28:25  *** Yotson has quit IRC
05:56:14  *** Wacko1976 has joined #openttd
06:18:49  *** Yotson_ is now known as Yotson
06:20:38  *** Wacko1976 has quit IRC
06:57:00  *** andythenorth has joined #openttd
07:05:44  *** andythenorth has quit IRC
07:39:27  *** Supercheese has quit IRC
07:45:29  *** andythenorth has joined #openttd
08:07:48  *** Wacko1976 has joined #openttd
08:18:12  *** OtakuSenpai has quit IRC
08:19:11  *** andythenorth has quit IRC
08:26:14  *** andythenorth has joined #openttd
08:35:31  *** andythenorth has left #openttd
10:06:58  <Eddi|zuHause> damn irc noobs, can't even wait 6 hours for a reply! :p
10:09:41  <peter1138> :D
10:10:26  <muetD> ^^
10:43:31  *** muetD has quit IRC
11:41:36  *** Samu has joined #openttd
11:45:38  <Samu> i think the limit is 64k towns
11:46:05  <Samu> because of uint16 or something like that
11:46:36  <Samu> he wants 80k towns
11:55:29  <Samu>
11:57:02  *** snail_UES_ has joined #openttd
11:58:01  <Samu> uint16 custom_town_number; yep
12:01:52  <Samu> typedef Pool<Town, TownID, 64, 64000> TownPool; extern TownPool _town_pool;
12:01:56  <Samu> 64000
12:03:38  <peter1138> Increase the number of towns 10 fold and then wonder why OpenTTD is so slow for such an old game...
12:04:16  <Samu> hey, i suggested 20000, he wants 80000
12:04:45  <Samu> pool limits to 64000, i believe
12:09:53  *** snail_UES_ has quit IRC
12:26:01  *** Sacro has quit IRC
12:34:34  *** Sacro has joined #openttd
12:44:16  <Eddi|zuHause> the bio-computerscientists always mocked the (regular) computerscientists by saying stuff like "i don't know why computer scientists are so happy about exponential computer power growth... we just simulate one atom more, and it brings it back to its knees"
12:59:24  *** Compu has joined #openttd
13:08:10  *** tokai|noir has joined #openttd
13:08:10  *** ChanServ sets mode: +v tokai|noir
13:15:10  *** tokai has quit IRC
13:16:43  *** quiznilo has left #openttd
13:37:00  <Samu> i'm a bit lost about this, what exactly was fixed?
13:37:52  <Samu> in r27586. Thanks for the patch! where do I ... check r27586 nowadays?
13:44:10  <Samu> ah, found it
13:44:25  <Samu> sucks to navigate backwards :( there should be a search here
13:47:25  <Samu> 6410
13:48:25  <Samu> dang, how do I edit title name?
13:48:38  <Samu> Add: [YAPF] Use a max penalty for finding the nearest road vehicle depot
13:48:49  <Samu> someone put a #6410 here plz
13:52:56  <LordAro> in the PR title, there's an edit button the right
13:53:01  <LordAro> in the commit, that's up to you
13:53:28  <Samu> oh, oh omg i totally missed it :p
13:55:01  <Samu> thx
14:04:43  *** sla_ro|master has joined #openttd
14:06:57  *** Alberth has joined #openttd
14:06:57  *** ChanServ sets mode: +o Alberth
14:07:06  <Alberth> moin
14:15:03  *** KouDy has quit IRC
14:15:39  <Samu> hi
14:20:57  <Samu> peter1138:  copy the SetMaxCost() strategy    	 *       applied in YAPF for rail. I did that
14:21:23  <Samu> copied the strategy used by rails
14:21:38  <Samu> also because I did it for ships
14:21:50  <Samu> road vehicles were going to be the only one without it
14:23:16  <Samu> i can't remember exactly, but I think the automatic servicing applies this max_penatly
14:23:24  <Samu> max_penalty
14:23:26  <peter1138> ?
14:24:19  <Alberth> doesn't look like a question to me :)
14:24:20  <peter1138> Don't write random gibberish here, put it in the PR.
14:33:17  *** KouDy has joined #openttd
14:35:36  *** Wacko1976 has quit IRC
14:44:06  <Samu> don't remember what changes exactly. I think it could prevent road vehicles going back and forth when needing to service at the nearest road depot and getting out of range
14:44:24  <Samu> at least it solved this problem for ship depots, i would assume the same would happen for road depots
14:44:49  <Samu> would have to recheck
14:48:58  <LordAro> Samu: put it in the pr
14:49:04  <LordAro> things here will be forgotten
14:49:07  <LordAro> or ignored
14:52:21  *** nielsm has joined #openttd
14:57:29  <Samu> hold on a sec, i'm rechecking, will reply there with more certainty
15:01:06  <LordAro> gj
15:13:38  <Samu> oh, apparently it changes nothing, but makes the pathfinder quit earlier
15:13:44  <Samu> if it goes past the max_penalty
15:13:52  <Samu> gonna post
15:20:46  *** ToBeFree has joined #openttd
15:22:21  *** WWacko1976-work has quit IRC
15:33:38  *** Wacko1976 has joined #openttd
15:42:56  *** Alberth has left #openttd
15:48:31  <Samu> damn inconsistencies
15:48:34  <Samu>
15:49:29  *** rocky11384497 has joined #openttd
15:52:46  *** acklen has joined #openttd
16:00:01  <Samu> if someone has done before what I did, why wasn't it implemented?
16:00:49  <Samu> josep guy has done it
16:01:24  <LordAro> because he's not a dev
16:01:29  <LordAro> and it's not been PR'd
16:01:37  <LordAro> why do you think?
16:02:13  <Samu> oh :(
16:03:51  <Samu> who's dev then?
16:03:59  <Samu> i thought you were
16:09:55  <Samu> I have more aircraft hangar issues patches here, but have to be extra careful now
16:10:46  <Samu> they are part of a feature suggestion, and were implemented with that in mind :(
16:11:01  <LordAro> i can review stuff, but i can't commit/merge anything
16:11:16  <Samu> have to dissect my own code :|
16:13:41  <nielsm> never write the most clever code you can come up with, because you won't be able to understand it yourself when returning to it later!
16:16:07  <Samu> as an extra problem, i already have the feature split into smaller patches, but they're hg
16:16:42  <Samu> have to convert from hg to svn, to apply patch, then move it into github
16:17:13  <nielsm> or you could just skip the svn step
16:17:24  <Samu> i dont have a git patcher
16:18:09  <LordAro> it's a common format
16:18:29  <LordAro> there's nothing (very) different about svn/hg/patches
16:19:00  <nielsm> the patch format is called "unified diff" and has been standard for 20+ years
16:19:17  <nielsm> used everywhere in software development
16:20:24  <LordAro> there's the -p0/-p1 difference, but that's easily worked around
16:23:12  <Samu> regular expression should help
16:23:26  <LordAro> does that follow from anything?
16:23:38  <Samu> replace a\ and b\ with nothing
16:23:50  <LordAro> i guess that's one solution
16:23:52  <nielsm> that's what the -p1 option does that LordAro just mentioned
16:23:54  <LordAro> not a good solution
16:23:56  <LordAro> but a solution
16:24:43  <Samu> i dont have command line solutions :|
16:24:51  <LordAro> besides, you want to eliminate the svn step, not ensure it
16:24:58  <Samu> except git bash and git cmd
16:25:08  <LordAro> that is all you need
16:25:11  *** Flygon has quit IRC
16:25:33  <Samu> I was forced to having it because of commit messages :|
16:25:42  *** frosch123 has joined #openttd
16:25:48  <Samu> but it helps, I admit
16:25:49  <LordAro> but any patching gui worth their salt will have equivalent options for pnum
16:25:58  <LordAro> ...because of commit messages?
16:26:32  <Samu> I mean failled commit messages
16:27:20  <LordAro> still not understanding you
16:27:33  <LordAro> oh, you mean "forced into having git bash"
16:28:06  <LordAro> (incidentally, it looks like sublime merge can do rebasing/amending quite nicely)
16:30:35  <Samu> sublime merge
16:30:41  <Samu> will take a look at it later
16:31:11  *** glx has joined #openttd
16:31:11  *** ChanServ sets mode: +v glx
16:34:17  <Samu> Evaluate for free – no account, tracking, or time limits.
16:34:27  <Samu> hmm i have a feeling this sublime merge is a trial
16:35:26  <Samu> Sublime Merge may be downloaded and evaluated for free, however a license must be purchased for continued use. There is currently no enforced time limit for the evaluation.
16:35:31  <Samu> no thx
16:41:49  <LordAro> Samu: "no enforced time limit"
16:41:50  <LordAro> it's fine
16:42:02  <LordAro> it's basically like winrar
16:42:09  <LordAro> it complains at you, but it doesn't actually care
16:42:31  <LordAro> alternatively, actually try it
16:42:35  <LordAro> you might like it enough to buy it anyway ;)
16:43:55  *** Gja has joined #openttd
16:44:43  *** HerzogDeXtEr has joined #openttd
16:49:43  <LordAro> regardless, don't complain about the bad tooling when you refuse to use the good tooling
16:50:34  <nielsm> agree. becoming effective at any task requires investing time into learning the tools properly
16:59:03  *** andythenorth has joined #openttd
16:59:06  <andythenorth> yo
16:59:15  <nielsm> oy
17:06:32  <Samu> is there a search here? I wanna navigate to r24855
17:07:11  <Samu> don't want to click Older Older Older till i reach it
17:07:25  *** Wacko1976 has quit IRC
17:08:24  <SpComb>
17:08:58  <Samu> thx
17:09:00  <SpComb> it's pretty well hidden in the top nav bar
17:09:02  *** Wacko1976 has joined #openttd
17:16:55  <Samu> my mind isn't as it used to be :(
17:17:21  <Samu> I made this fix for a reason, but can't remember what it was for :(
17:23:43  <Samu> 08_FindNearestHangar__try_to_determine_the_correct_last_and_next_destinations_and_then_ensure_these_are_within_range
17:24:11  <LordAro> something to do with aircraft ranges, i presume
17:24:19  <Samu> i made this to replace that code here
17:25:00  <Samu> something to do with it not getting the correct last and next destinations somehow?
17:26:51  <Samu> brb checking my temp savegames, I know I have something that is supposed to expose this issue
17:32:44  *** Wolf01 has joined #openttd
17:32:51  <Wolf01> o/
17:42:03  <andythenorth> lo Wolf01
17:56:06  *** rocky11384497 has quit IRC
17:59:01  <Samu> aha, I remember
17:59:36  <Samu> it's about the order of type v->current_order.IsType(OT_GOTO_DEPOT) && v->current_order.GetDepotActionType() != ODATFB_NEAREST_DEPOT
18:00:34  <Samu> pikka savegame is ideal to expose it too
18:01:00  <Samu> 1 go to A
18:01:06  <Samu> 2 service at nearest hangar
18:01:08  <Samu> 3 go to b
18:01:12  <Samu> 4 service at nearest hangar
18:01:34  <Samu> the issue happens when executing order 4
18:02:03  <Samu> it goes to a hangar that would cause the distance to A to become out of range
18:05:54  <Samu> yeah, my fix makes the "service at nearest hangar" not do exactly as it says
18:06:26  <Samu> it will "service at the nearest hangar that is still within range of the next destination"
18:06:56  <Samu> to avoid the "out of range"
18:07:39  <Samu> ok, gonna submit
18:19:08  <Samu>
18:20:19  <andythenorth> has anyone coded pantographs yet?
18:20:22  <andythenorth> for horse?
18:20:29  <andythenorth> or will I have to do it? :P
18:21:12  <SpComb> electric horses?
18:25:42  *** Progman has joined #openttd
18:28:47  <andythenorth> such
18:28:50  <andythenorth> graphics generation
18:28:59  <andythenorth> draw 1 pantograph, not 10
18:47:48  *** Wormnest has joined #openttd
18:47:55  *** Supercheese has joined #openttd
18:48:16  *** Gja has quit IRC
18:49:02  *** gelignite has joined #openttd
18:50:33  *** NGC3982 has joined #openttd
18:50:38  <NGC3982> oh my!
18:50:41  *** NGC3982 is now known as ngc3982
18:58:33  <LordAro> osht
19:03:35  *** Gja has joined #openttd
19:05:23  <andythenorth> ohmy
19:10:08  *** Gja has quit IRC
19:25:30  *** sla_ro|master has quit IRC
19:54:31  <Samu> i have a solution for this but it envolves a bit of rules changing
19:56:34  <Samu> implies a different aircraft handling behaviour
19:58:17  <Samu> uhm, so how do I explain this
19:59:31  <Samu> well, nvm I'll post it the best manner I can
20:13:17  *** andythenorth has quit IRC
20:17:41  *** andythenorth has joined #openttd
20:37:48  <Samu> bah failed hunk
20:48:09  <Samu> is CodeChange a thing?
20:48:47  <Samu> whe do you use CodeChange?
20:49:36  <Samu> oh, Codechange
20:52:25  <andythenorth> when it changes code
20:54:33  <Samu> i'm splitting a function in 2
20:54:42  <Samu> what is the techincal term for this?
20:54:57  <LordAro> sounds like a codechange
20:54:57  <Wolf01> Refactoring
20:55:00  <Samu> refactor
20:55:02  <Samu> ok, ty
20:55:42  <andythenorth> such bed
20:55:43  *** andythenorth has left #openttd
20:55:53  *** nielsm has quit IRC
20:55:59  <Wolf01> /me too
20:56:05  <Samu> Codechange #6493: Refactoring NeedsServicing into NeedsServicing + HasPendingReplace
20:56:07  <Samu> good name?
20:56:15  <Wolf01> 'night
20:56:18  *** Wolf01 has quit IRC
20:57:02  <LordAro> Samu: codechange doesn't often have an issue in it
20:57:11  <LordAro> because codechanges don't fix issues
20:57:46  <Samu> i see, but ultimately it will be used to fix a problem
20:58:03  <Samu> I want to call HasPendingReplace directly, and skip the first half of NeedsServicing
20:58:03  <LordAro> will be, sure, but is not the actual fix
20:58:54  <Samu> so, it's a fix?
20:59:33  <Samu> oh, it's a codechange without referring which issue it will be used for?
21:00:48  <Samu> i'm unsure how to do this, any tips?
21:01:41  <Samu> sec, let me link
21:02:44  <Samu> this function here
21:04:03  <Samu> the lines from 206 to 245 are moved into HasPendingReplace
21:04:41  <Samu> NeedsServicing will be calling HasPendingReplace afterwards, it won't change its functionality
21:05:07  <Samu> but I am going to call HasPendingReplace directly, skipping the first half of NeedsServicing from within aircraft_cmd.cpp file
21:05:40  <Samu> because I need to do that for helicopters that service at helipads
21:06:41  <LordAro> codechange without referring what issue it's for
21:07:23  <LordAro> "refactoring" as a single commit is fine, as long as it's followed up with a reason for the refactoring
21:12:33  <Samu> commit message: In order to verify if a helicopter with service at helipad has a pending replace, I need to create a HasPendingReplace function that can be called from some aircraft_cmd.cpp functions
21:13:22  <Samu> commit title: Codechange: Refactoring NeedsServicing into NeedsServicing + HasPendingReplace
21:13:31  <Samu> good?
21:15:58  <Samu> my english
21:20:57  <Samu> In order to verify if a helicopter with service at helipad has a pending replace, I need to call HasPendingReplace directly, as a seperate function that can be used by some aircraft_cmd.cpp functions
21:22:04  <Samu> , it's needed to call
21:22:20  <Samu> In order to verify if a helicopter with service at helipad has a pending replace, it's needed to call HasPendingReplace directly, as a seperate function that can be used by some aircraft_cmd.cpp functions
21:22:56  *** ericnoan has joined #openttd
21:25:22  <Samu> whatever, pushed
21:29:58  *** gelignite has quit IRC
21:50:32  <Samu> The supplied credentials are invalid to login
21:50:35  <Samu> what is this?
21:51:26  <Samu> Jenkins failed in OS / osx-10.9
21:51:32  <Samu> was it my fault?
21:51:56  <Samu>
21:51:59  <Samu> ahalp
21:56:46  <LordAro> doesn't look like anything you did
21:58:06  <Samu> eww
21:58:23  <Samu> visual studio doesn't complain
21:58:35  <Samu> how could I guess
22:02:01  *** frosch123 has quit IRC
22:03:07  <Samu> anyway, the good news, I don't have anything else to commit here
22:03:20  <Samu> ready for review
22:47:49  *** Progman has quit IRC
22:58:25  *** tokai has joined #openttd
22:58:25  *** ChanServ sets mode: +v tokai
23:05:09  *** tokai|noir has quit IRC
23:26:57  *** Thedarkb-T60 has joined #openttd
23:32:16  *** Wormnest has quit IRC
23:42:01  *** Samu has quit IRC

Powered by YARRSTE version: svn-trunk