Times are UTC Toggle Colours
00:03:08 *** hph^ has joined #openttd 00:17:43 *** Compu has joined #openttd 00:32:43 *** guru3 has joined #openttd 00:35:31 *** guru3_ has quit IRC 00:36:16 *** urdh_ has joined #openttd 00:36:21 *** urdh has quit IRC 00:36:21 *** urdh_ is now known as urdh 00:39:14 *** chomwitt has quit IRC 00:47:58 *** Flygon has joined #openttd 00:52:24 *** HerzogDeXtEr1 has quit IRC 00:54:38 <Samu> The nightly database backup is currently running, and the site is unavailable as a result. 00:54:41 <Samu> bah terrible timing 01:09:37 *** hph^ has quit IRC 01:26:35 *** hph^ has joined #openttd 02:20:26 <Samu> what the heck is this regression thing? 02:32:32 *** hph^ has quit IRC 02:43:58 *** Samu has quit IRC 02:54:26 *** Mazur has quit IRC 03:03:03 *** Mazur has joined #openttd 03:10:27 *** haudrauf has quit IRC 03:12:07 *** haudrauf has joined #openttd 03:12:47 *** glx has quit IRC 05:15:00 *** sla_ro|master has joined #openttd 05:21:01 *** yellyFish has quit IRC 07:08:14 *** Mahjong has quit IRC 07:10:17 *** Mahjong has joined #openttd 07:15:34 *** andythenorth has joined #openttd 07:23:48 <andythenorth> o/ 07:48:00 *** Progman has joined #openttd 07:54:42 *** sla_ro|master has quit IRC 08:22:10 *** nielsm has joined #openttd 08:58:43 *** Progman has quit IRC 08:58:50 *** Arveen has joined #openttd 09:03:01 *** Arveen2 has quit IRC 09:28:02 *** Arveen has quit IRC 09:31:11 *** Samu has joined #openttd 09:51:50 <Samu> hi 09:51:58 <LordAro> o/ 09:52:28 <LordAro> Samu: are you still wondering what the regression tests are? 09:53:17 <Samu> yes, a bit 09:53:34 <Samu> i can't visualize it :( 09:53:41 <Samu> can only suspect what it does 09:53:55 <LordAro> essentially it's an AI that runs a load of stuff to check that the game is performing as expected 09:54:11 <LordAro> things like construction & associated costs 09:54:13 <Samu> I suspected it built a lock 09:55:04 <LordAro> the AI (and reference files) are in bin/ai/regression 09:55:27 *** sla_ro|master has joined #openttd 09:56:57 <Samu> @calc 465070 - 461320 09:56:57 <DorpsGek> Samu: 3750 10:00:33 <Samu> https://github.com/OpenTTD/OpenTTD/blob/master/bin/ai/regression/tst_regression/main.nut#L879 10:00:42 <Samu> yeah, it built a lock 10:01:01 <Samu> in some unknown map, dont even know 10:01:19 <LordAro> i imagine you can just load the save up 10:01:30 <LordAro> it'll be in that folder somewhere 10:02:14 <Samu> empty.sav? 10:02:23 <LordAro> maybe 10:03:37 <Samu> it's empty! :p 10:04:13 <LordAro> well, the AI hasn't run on it :p 10:04:27 <LordAro> i imagine it doesn't save the game when it runs 10:05:10 <Samu> ah, i can scroll to the tile in question 10:06:01 <Samu> https://imgur.com/XJKi2Uo 10:06:25 <Samu> so that's the cost of clearing land + simulated cost of building canal 10:06:42 <Samu> which is 3750? was expecting 5000 10:06:50 <Samu> unless easy costs 10:07:30 <Samu> Construction costs: Low 10:07:31 <Samu> ok 10:07:31 <andythenorth> peter1138: should I go try this? o_O https://www.youtube.com/watch?v=c7a8XjeDRGg 10:08:19 <Samu> 3750, confirmed 10:08:24 <Samu> so it's fine 10:08:29 <Samu> working as I intended 10:09:41 <Samu> https://imgur.com/o5DIpjH 10:10:07 <Samu> then it removes lock 10:10:49 <Samu> simulates cost of removing canal 10:10:55 <Samu> which is also 3750 10:11:40 <Samu> @calc 459675 - 452175 10:11:40 <DorpsGek> Samu: 7500 10:11:54 <Samu> @calc 3750 + 3750 10:11:54 <DorpsGek> Samu: 7500 10:11:57 <Samu> correct 10:12:20 <Samu> my edits to results are fine then 10:15:56 *** frosch123 has joined #openttd 10:21:52 <TrueBrain> awh, DorpsGek still doesn't rejoin channels? BOOOO 10:22:06 <andythenorth> yo TrueBrain 10:22:45 <LordAro> an TrueBrain 10:22:53 <LordAro> it got netsplitted, i think 10:23:01 <LordAro> probably thinks it's still connected 10:23:04 <TrueBrain> yup 10:25:21 <TrueBrain> meh, why does PyUp make N commits, instead of just one .. this looks silly 10:25:44 <LordAro> multiple PRs too, if the old one is still there 10:25:58 <TrueBrain> yeah ... which is a: IF YOU WERE TOO LAZY TO ACCEPT ME, I WILL DO THIS AGAIN OKAY 10:26:03 <TrueBrain> I think it is a good nutch to say: YOU FAILED 10:26:16 <LordAro> yup 10:27:54 <TrueBrain> meh, enough changes that I cannot simply accept the PR .. bah, I need more free time :( 10:28:09 <LordAro> :( 10:29:24 <TrueBrain> wow, indeed, the per commit stuff is very .. euh .. verbose 10:31:15 <TrueBrain> ah, because he does it one by one to a branch in the repository 10:31:19 <TrueBrain> yeah .. that is annoying as ... 10:34:53 *** DorpsGek_II has joined #openttd 10:34:53 <DorpsGek_II> [OpenTTD/DorpsGek-irc] pyup-bot merged pull request #9: Initial Update https://github.com/OpenTTD/DorpsGek-irc/pull/9 10:34:56 <DorpsGek_II> [OpenTTD/DorpsGek-irc] TrueBrain pushed 1 commits to master: 10:34:57 <DorpsGek_II> - Initial Update (#9) Update: version update of all dependencies * Update aiohttp from 3.3.2 to 3.4.4 * Update attrs from 18.1.0 to 18.2.0 * Update irc3 from 1.1.0 to 1.1.1 * Update multidict from 4.3.1 to 4.4.2 (by pyup-bot) 10:34:58 <DorpsGek_II> https://github.com/OpenTTD/DorpsGek-irc/commit/c7f2ab30793a 10:35:25 <TrueBrain> oops .. that commit message was not what I wanted it to be :D 10:35:54 *** DorpsGek_II has quit IRC 10:36:11 <LordAro> the author, or something else? there's an issue for the former :) 10:36:36 <TrueBrain> no, I forgot how GitHub worked, so now the commit message itself is just weird ... and not by specs :D 10:36:49 <LordAro> hehe 10:53:03 *** DorpsGek_II has joined #openttd 10:53:03 <DorpsGek_II> [OpenTTD/DorpsGek-irc] TrueBrain pushed 2 commits to master: 10:53:03 <DorpsGek_II> - Add: create pyup.io config file (#8) (by pyup-bot) 10:53:03 <DorpsGek_II> - Update: version update of all dependencies (#9) * Update aiohttp from 3.3.2 to 3.4.4 * Update attrs from 18.1.0 to 18.2.0 * Update irc3 from 1.1.0 to 1.1.1 * Update multidict from 4.3.1 to 4.4.2 (by pyup-bot) 10:53:04 <DorpsGek_II> https://github.com/OpenTTD/DorpsGek-irc/compare/c7f2ab30793a...4a9660406ceb 10:53:40 *** DorpsGek_II has quit IRC 10:53:56 <TrueBrain> I might have forced-pushed some things :D 10:54:10 <LordAro> haha 10:58:16 <TrueBrain> right, lets see about the bugs you lovely guys created for me :) 10:59:07 *** DorpsGek_II_ has joined #openttd 10:59:07 <DorpsGek_II_> [TrueBrain/Testing] TrueBrain opened pull request #2: Testing https://github.com/TrueBrain/Testing/pull/2 10:59:16 <TrueBrain> oops, that should not go to this channel 10:59:18 <TrueBrain> sorry 11:04:13 *** DorpsGek_II_ has quit IRC 11:07:21 *** DorpsGek_II has joined #openttd 11:07:21 <DorpsGek_II> [OpenTTD/DorpsGek-irc] LordAro commented on issue #7: PRQ merge messages are duplicated https://github.com/OpenTTD/DorpsGek-irc/issues/7#issuecomment-427565365 11:07:51 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain pushed 2 commits to pyup-scheduled-update-2018-10-01: 11:07:51 <DorpsGek_II> - Update: version update of all dependencies (#8) * Update aiohttp from 3.3.2 to 3.4.4 * Update attrs from 18.1.0 to 18.2.0 * Update cryptography from 2.3 to 2.3.1 * Update gidgethub from 2.5.0.post1 to 3.0.0 * Update multidict from 4.3.1 to 4.4.2 * Update pycparser from 2.18 to 2.19 (by pyup-bot) 11:07:51 <DorpsGek_II> - Remove: now unneeded hacks for gidgethub With version 3.0.0 of gidgethub, those hacks are now upstream. (by TrueBrain) 11:07:51 <DorpsGek_II> https://github.com/OpenTTD/DorpsGek-github/compare/5e277fa55e8b...32ebe6b7da15 11:08:00 <DorpsGek_II> [OpenTTD/DorpsGek-github] pyup-bot updated pull request #8: Scheduled monthly dependency update for October https://github.com/OpenTTD/DorpsGek-github/pull/8 11:08:18 <TrueBrain> this is so unreadable :D 11:08:42 <LordAro> i already mentioned the url shortener :p 11:08:48 <TrueBrain> guess all non-master stuff should not be notified 11:08:55 <LordAro> but most of that is the commit message 11:09:01 <TrueBrain> feel free to implement the URL shortener :D 11:11:22 <DorpsGek_II> [OpenTTD/DorpsGek-github] pyup-bot merged pull request #8: Scheduled monthly dependency update for October https://github.com/OpenTTD/DorpsGek-github/pull/8 11:11:22 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain pushed 2 commits to master: 11:11:22 <DorpsGek_II> - Update: version update of all dependencies (#8) * Update aiohttp from 3.3.2 to 3.4.4 * Update attrs from 18.1.0 to 18.2.0 * Update cryptography from 2.3 to 2.3.1 * Update gidgethub from 2.5.0.post1 to 3.0.0 * Update multidict from 4.3.1 to 4.4.2 * Update pycparser from 2.18 to 2.19 (by pyup-bot) 11:11:24 <DorpsGek_II> - Remove: now unneeded hacks for gidgethub With version 3.0.0 of gidgethub, those hacks are now upstream. (by TrueBrain) 11:11:24 <DorpsGek_II> https://github.com/OpenTTD/DorpsGek-github/compare/718fab3cafda...757a6c32c739 11:11:37 <TrueBrain> the wrong user is funny :) 11:12:18 <TrueBrain> okay, so the commit message should change to only the first line 11:12:20 <TrueBrain> not anything after that 11:12:51 <TrueBrain> how does that work out for the translation commits 11:13:13 <LordAro> some would argue better than it previously did :p 11:14:11 <DorpsGek_II> [OpenTTD/DorpsGek-runner] pyup-bot merged pull request #7: Scheduled monthly dependency update for October https://github.com/OpenTTD/DorpsGek-runner/pull/7 11:14:12 <DorpsGek_II> [OpenTTD/DorpsGek-runner] TrueBrain pushed 1 commits to master: 11:14:12 <DorpsGek_II> - Update: version update of all dependencies (#7) * Update aiohttp from 3.3.2 to 3.4.4 * Update attrs from 18.1.0 to 18.2.0 * Update multidict from 4.3.1 to 4.4.2 (by pyup-bot) 11:14:12 <DorpsGek_II> https://github.com/OpenTTD/DorpsGek-runner/commit/11aedf3c8206 11:14:53 <TrueBrain> as they are not announced? :P 11:16:06 <TrueBrain> why are they not .. .hmmmm 11:18:36 <TrueBrain> I really do not know why they are not announced .. 11:20:51 <andythenorth> oof 11:22:35 * andythenorth brain ache from sprite generation 11:29:03 *** HerzogDeXtEr has joined #openttd 11:31:18 <LordAro> TrueBrain: i'm actually putting together a url shortener thing 11:31:25 <LordAro> it's not actually too difficult 11:31:37 <LordAro> aiohttp's documentation is reasonably nice 11:32:16 <TrueBrain> \o/ 11:32:36 <TrueBrain> and I believe the github url shortner was also pretty nice 11:37:30 *** Wolf01 has joined #openttd 11:37:35 <Wolf01> o/ 11:37:53 <Wolf01> I forgot to run mirc :P 11:39:04 <Wolf01> andythenorth: you asked what didn't work with rebase, I don't know, I'm just not used to it and with merge I feel I can do things better 11:40:07 <DorpsGek_II> [OpenTTD/DorpsGek-irc] LordAro opened pull request #10: Add: Shortened GitHub urls https://github.com/OpenTTD/DorpsGek-irc/pull/10 11:40:35 <LordAro> completely untested, of course 11:40:40 <LordAro> but that's what the CI is for! 11:42:38 <Wolf01> https://www.youtube.com/watch?v=ZWQ0591PAxM mmmmh sprite composition, 50MB grf to 20KB! Fuck the 16GB of ram (+3GB video ones) 640KB are enough for everyone 11:43:28 <TrueBrain> LordAro: I love how easy coroutines make adding this stuff in :) 11:44:22 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain opened pull request #9: Add: allow filtering for which branch push notifications work https://github.com/OpenTTD/DorpsGek-github/pull/9 11:44:31 <TrueBrain> right, that commit should reduce the pyup spam 11:46:55 <DorpsGek_II> [OpenTTD/DorpsGek-irc] LordAro updated pull request #10: Add: Shortened GitHub urls https://github.com/OpenTTD/DorpsGek-irc/pull/10 11:48:35 <TrueBrain> guess I should test it first :) 11:48:41 <LordAro> probably 11:50:04 <TrueBrain> doesnt 11:50:05 <TrueBrain> even 11:50:07 <TrueBrain> run 11:50:32 <Wolf01> :D 11:50:34 <LordAro> :D 11:50:46 <LordAro> but it passed CI! 11:51:01 <TrueBrain> yeah .. guess CI doesnt run the code :P 11:51:08 <TrueBrain> (I think it only builds the docker and runs flake tbh) 11:51:34 <LordAro> did i make too many assumptions about what a ws is? 11:51:53 <TrueBrain> no, it is a syntax error :) 11:51:57 <TrueBrain> "async with" is not valid Python :) 11:51:58 <LordAro> nice. 11:52:14 <TrueBrain> you didnt make the function a coroutine :) 11:52:14 <LordAro> wait, what 11:52:17 <LordAro> oh 11:52:32 <LordAro> tbf, this is the first time i've ever tried to use python coroutines :p 11:52:37 <LordAro> s/use/write my own/ 11:52:58 <TrueBrain> async in front of the function 11:53:01 <TrueBrain> await all usages 11:53:06 <TrueBrain> the last return in your function can be removed 11:53:11 <TrueBrain> (as it will never be executed) 11:53:34 <LordAro> so when you say how easy coroutines make this stuff... :p 11:53:50 <TrueBrain> I mean you at least have to read the "n00b guide to coroutines" :P 11:54:40 <DorpsGek_II> [OpenTTD/DorpsGek-irc] LordAro updated pull request #10: Add: Shortened GitHub urls https://github.com/OpenTTD/DorpsGek-irc/pull/10 11:54:55 <TrueBrain> ws.get doesn't exist either 11:55:00 <TrueBrain> ws is the websocket 11:55:08 <TrueBrain> so yeah, you cannot make another call with that 11:55:18 <LordAro> damn 11:55:29 <TrueBrain> you can however just use aiohttp to make a new one 11:55:29 <LordAro> ok, i retract my previous comments about aiohttp's documentation :p 11:55:59 <TrueBrain> well, this is not really aiohttp to blame .. 'ws' is just the WebSocket object 11:56:10 <TrueBrain> I don't pass the session object along 11:57:06 <LordAro> i did wonder whether i was following the code correctly 11:57:07 <LordAro> ah well 11:57:20 <TrueBrain> ws .. websocket .. guess it somewhat makes sense :D 11:59:08 <DorpsGek_II> [OpenTTD/DorpsGek-irc] LordAro updated pull request #10: Add: Shortened GitHub urls https://github.com/OpenTTD/DorpsGek-irc/pull/10 11:59:11 <LordAro> take 4... 12:00:20 <TrueBrain> no clue how smart aiohttp is with session recycling .. I hope sufficient :D 12:00:55 <LordAro> i can't imagine it's expensive 12:02:13 <TrueBrain> response code is 200 it seems? 12:02:31 <TrueBrain> did you test the function at least? 12:02:51 <TrueBrain> its returning 200 12:02:57 <LordAro> curl returns a 201... 12:03:05 <TrueBrain> (python3; import url; await shorten(...) 12:03:46 <TrueBrain> Sorry yo, that's an invalid URL 12:03:55 <TrueBrain> is what it is yelling 12:04:47 <TrueBrain> the CI is failing ... it shouldnt pass this :D 12:05:16 <TrueBrain> it continues if flake8 fails :D 12:05:17 <TrueBrain> hahaha 12:05:20 <TrueBrain> oops :D 12:08:05 <DorpsGek_II> [OpenTTD/DorpsGek-irc] TrueBrain opened pull request #11: Fix: fail the CI if flake8 fails https://github.com/OpenTTD/DorpsGek-irc/pull/11 12:09:38 <DorpsGek_II> [OpenTTD/DorpsGek-irc] TrueBrain updated pull request #11: Fix: fail the CI if flake8 fails https://github.com/OpenTTD/DorpsGek-irc/pull/11 12:09:39 <TrueBrain> good, that works now :) 12:09:55 <LordAro> :) 12:11:00 <Eddi|zuHause> what's better than "the CI apparently doesn't run the code"? "the CI runs the code, but ignores the result" :p 12:11:04 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain opened pull request #10: Fix: fail the CI if flake8 fails https://github.com/OpenTTD/DorpsGek-github/pull/10 12:12:22 <DorpsGek_II> [OpenTTD/DorpsGek-runner] TrueBrain opened pull request #8: Fix: fail the CI if flake8 fails https://github.com/OpenTTD/DorpsGek-runner/pull/8 12:12:35 <TrueBrain> think of it this way: at least it was consistent 12:13:08 <DorpsGek_II> [OpenTTD/DorpsGek-irc] TrueBrain merged pull request #11: Fix: fail the CI if flake8 fails https://github.com/OpenTTD/DorpsGek-irc/pull/11 12:13:09 <DorpsGek_II> [OpenTTD/DorpsGek-irc] TrueBrain pushed 1 commits to master: 12:13:09 <DorpsGek_II> - Fix: fail the CI if flake8 fails (#11) Without 'set -e', an non-zero exit code from flake8 is simply ignored and test.sh continues. With 'set -e' it abort on the first non-zero exit code. (by TrueBrain) 12:13:10 <DorpsGek_II> https://github.com/OpenTTD/DorpsGek-irc/commit/95048f7a2680 12:13:41 <TrueBrain> yeah, I think we just have to mute the 'push' if there was a 'pr merge' of the same 12:13:46 <TrueBrain> it doesnt add any value 12:14:06 *** DorpsGek_II has quit IRC 12:14:14 <Eddi|zuHause> can there be pushes without a PR? 12:14:18 <TrueBrain> yes 12:14:21 <TrueBrain> translator for example 12:15:46 *** DorpsGek_II_ has joined #openttd 12:15:46 <DorpsGek_II_> [OpenTTD/DorpsGek-github] TrueBrain updated pull request #10: Fix: fail the CI if flake8 fails https://github.com/OpenTTD/DorpsGek-github/pull/10 12:16:54 *** DorpsGek_II_ is now known as DorpsGek_II 12:19:27 <TrueBrain> can any of you make a pull request for https://github.com/TrueBrain/Testing ? 12:19:34 <TrueBrain> I need another username to test this username bug :D 12:20:00 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain merged pull request #10: Fix: fail the CI if flake8 fails https://github.com/OpenTTD/DorpsGek-github/pull/10 12:20:00 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain pushed 1 commits to master: 12:20:00 <DorpsGek_II> - Fix: fail the CI if flake8 fails (#10) Without 'set -e', an non-zero exit code from flake8 is simply ignored and test.sh continues. With 'set -e' it abort on the first non-zero exit code. (by TrueBrain) 12:20:02 <DorpsGek_II> https://github.com/OpenTTD/DorpsGek-github/commit/029ca44d5048 12:20:47 <nielsm> made one 12:21:15 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain updated pull request #9: Add: allow filtering for which branch push notifications work https://github.com/OpenTTD/DorpsGek-github/pull/9 12:21:22 <DorpsGek_II> [OpenTTD/DorpsGek-irc] LordAro updated pull request #10: Add: Shortened GitHub urls https://github.com/OpenTTD/DorpsGek-irc/pull/10 12:21:28 <LordAro> LOUD NOISES 12:22:00 <TrueBrain> tnx nielsm :) 12:24:00 <TrueBrain> LordAro: that PR still doesnt work btw 12:24:49 <DorpsGek_II> [OpenTTD/DorpsGek-runner] TrueBrain merged pull request #8: Fix: fail the CI if flake8 fails https://github.com/OpenTTD/DorpsGek-runner/pull/8 12:24:49 <DorpsGek_II> [OpenTTD/DorpsGek-runner] TrueBrain pushed 1 commits to master: 12:24:50 <DorpsGek_II> - Fix: fail the CI if flake8 fails (#8) Without 'set -e', an non-zero exit code from flake8 is simply ignored and test.sh continues. With 'set -e' it abort on the first non-zero exit code. (by TrueBrain) 12:24:50 <DorpsGek_II> https://github.com/OpenTTD/DorpsGek-runner/commit/fd0f5c49a5d0 12:25:04 <TrueBrain> and tnx for the reviews :) 12:27:13 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain opened issue #11: Wrong user in most actions https://github.com/OpenTTD/DorpsGek-github/issues/11 12:27:46 <LordAro> TrueBrain: fine i'll actually install aiohttp locally 12:27:59 <DorpsGek_II> [OpenTTD/DorpsGek-irc] TrueBrain commented on issue #5: Wrong data used for merge and close notifications https://github.com/OpenTTD/DorpsGek-irc/issues/5#issuecomment-427569865 12:27:59 <DorpsGek_II> [OpenTTD/DorpsGek-irc] glx22 closed issue #5: Wrong data used for merge and close notifications https://github.com/OpenTTD/DorpsGek-irc/issues/5 12:28:19 <LordAro> ^ nicely demonstrating the error :p 12:29:19 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain opened pull request #12: Fix #11: always use the 'sender' to notify who made the change https://github.com/OpenTTD/DorpsGek-github/pull/12 12:30:43 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain merged pull request #9: Add: allow filtering for which branch push notifications work https://github.com/OpenTTD/DorpsGek-github/pull/9 12:30:43 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain pushed 1 commits to master: 12:30:43 <DorpsGek_II> - Add: allow filtering for which branch push notifications work (#9) Pyup for example creates a branch in the repository. Pushes to these branches don't have to be announced. (by TrueBrain) 12:30:44 <DorpsGek_II> https://github.com/OpenTTD/DorpsGek-github/commit/7d589bdb6da5 12:31:21 <LordAro> TrueBrain: incidentally, "SyntaxError: 'await' outside function" 12:31:44 <TrueBrain> sorry? 12:32:00 <TrueBrain> so okay, 'sender' seems to be mostly the correct one, unless an App or something triggered the event 12:32:08 <TrueBrain> so we will have to experiment with it a bit, see how we like it 12:33:41 <LordAro> TrueBrain: i can't run "await url.shorten(foobar)", results in that error 12:33:53 <LordAro> and google is being unhelpful in finding a way around it 12:34:18 <TrueBrain> owh, shit, ofc :( 12:34:24 <TrueBrain> you need an asyncio context 12:34:26 <TrueBrain> euuhhh 12:34:42 <TrueBrain> this is a tiny bit more difficult 12:35:15 <TrueBrain> I believe: asyncio.run(func()) 12:35:37 <LordAro> that's it, thanks 12:35:40 <TrueBrain> \o/ 12:36:05 <TrueBrain> meh, the push payload doesn't indicate if it was triggered by a PR merge 12:37:40 <LordAro> mm, i didn't think so 12:38:04 <TrueBrain> in all my tests, the push always came after the PR 12:38:11 <TrueBrain> but not sure if that is a guarantee or something 12:41:22 <DorpsGek_II> [OpenTTD/DorpsGek-irc] LordAro updated pull request #10: Add: Shortened GitHub urls https://github.com/OpenTTD/DorpsGek-irc/pull/10 12:41:23 <LordAro> ok, it actually works now 12:41:25 <LordAro> promise 12:41:56 <TrueBrain> :D 12:42:39 <TrueBrain> and so it does :P 12:43:19 <LordAro> bad quotes? where did those come from? 12:43:52 <DorpsGek_II> [OpenTTD/DorpsGek-irc] LordAro updated pull request #10: Add: Shortened GitHub urls https://github.com/OpenTTD/DorpsGek-irc/pull/10 12:43:52 <TrueBrain> post vs get, lol 12:43:56 <LordAro> shhhh 12:44:10 <TrueBrain> you moved a ' out of a ", so yeah :) 12:44:11 <LordAro> i did not read curl's documentation closely enough 12:45:25 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain opened issue #13: Pull Request merge and push give duplicated information https://github.com/OpenTTD/DorpsGek-github/issues/13 12:45:38 <DorpsGek_II> [OpenTTD/DorpsGek-irc] TrueBrain commented on issue #7: PRQ merge messages are duplicated https://github.com/OpenTTD/DorpsGek-irc/issues/7#issuecomment-427570868 12:45:38 <DorpsGek_II> [OpenTTD/DorpsGek-irc] LordAro closed issue #7: PRQ merge messages are duplicated https://github.com/OpenTTD/DorpsGek-irc/issues/7 12:46:35 <LordAro> i wonder if it might be easier to solve from the irc side 12:46:53 <LordAro> given that can cache messages (assuming push comes after merge) 12:47:11 <Eddi|zuHause> user on "ticket closed" message still wrong 12:47:18 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain opened pull request #14: Fix #13: deduplicate pull request merge and push information https://github.com/OpenTTD/DorpsGek-github/pull/14 12:47:27 <TrueBrain> Eddi|zuHause: yes, it requires a review ;) 12:47:46 <TrueBrain> LordAro: the line between IRC and Github is a bit thin :) But I try to have most of the logic in Github for now 12:48:08 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain merged pull request #12: Fix #11: always use the 'sender' to notify who made the change https://github.com/OpenTTD/DorpsGek-github/pull/12 12:48:09 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain closed issue #11: Wrong user in most actions https://github.com/OpenTTD/DorpsGek-github/issues/11 12:49:37 <DorpsGek_II> [OpenTTD/DorpsGek-irc] TrueBrain merged pull request #10: Add: Shortened GitHub urls https://github.com/OpenTTD/DorpsGek-irc/pull/10 12:50:13 <Eddi|zuHause> i believe glx once made a ticket about the wrong user thing, but i don't know which repo he made the ticket against 12:50:27 <LordAro> Eddi|zuHause: scroll further up 12:50:35 *** andythenorth has quit IRC 12:50:38 *** DorpsGek_II has quit IRC 12:50:39 <LordAro> 13:27 12:50:44 <LordAro> though it is a little tricky to see 12:50:52 <TrueBrain> so much spam! :P 12:50:57 *** KouDy has quit IRC 12:52:38 <Eddi|zuHause> to be frank, it's a little intransparent which repo actually does what 12:52:54 *** KouDy has joined #openttd 12:53:28 <TrueBrain> the IRC repo only puts the notification on IRC 12:53:35 <TrueBrain> it can easily be replaced with Slack, Discord, etc 12:53:41 <TrueBrain> so there is no logic in there, just a gateway 12:54:06 <LordAro> i do wonder if it would be better just to merge the repos 12:54:10 <TrueBrain> the bugs like: wrong sender, etc, would be true for any of them 12:54:25 <TrueBrain> if there would be a Slack or Discord version, it would make a lot more sense :) 12:54:58 <TrueBrain> (and I still hope some day OpenTTD moves away from IRC :P) 12:55:09 <LordAro> heathen 12:55:16 <TrueBrain> LordAro: I cannot find documentation what merge_commit_sha is/does 12:55:22 <TrueBrain> I was hoping it would be what I thought it was 12:55:33 <Eddi|zuHause> i'm going to postulate that IRC will outlive those two things :p 12:55:57 <LordAro> TrueBrain: sounds like Truebrain/Testing needs some use :p 12:56:12 <TrueBrain> LordAro: fair point 12:56:17 *** DorpsGek_II has joined #openttd 12:56:19 <DorpsGek_II> [OpenTTD/DorpsGek-github] LordAro commented on pull request #14: Fix #13: deduplicate pull request merge and push information https://git.io/fx39J 12:56:23 <DorpsGek_II> [OpenTTD/DorpsGek-irc] TrueBrain commented on issue #7: PRQ merge messages are duplicated https://git.io/fx39U 12:56:24 *** iSoSyS has joined #openttd 12:56:27 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain commented on pull request #14: Fix #13: deduplicate pull request merge and push information https://git.io/fx39c 12:56:34 <TrueBrain> something got stuck in a queue :D 12:56:49 <LordAro> dem short urls 12:58:06 <Eddi|zuHause> "Banksy painting spontaneously self-destructs after auction"... from "the outside" that sounds incredibly funny :p 12:58:52 <TrueBrain> LordAro: tested both squash and rebase; does what I expect it to do :) 12:59:12 <LordAro> nice. 12:59:29 <LordAro> let's give it a go then 12:59:37 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain commented on pull request #14: Fix #13: deduplicate pull request merge and push information https://git.io/fx39z 12:59:45 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain merged pull request #14: Fix #13: deduplicate pull request merge and push information https://git.io/fx39g 12:59:46 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain closed issue #13: Pull Request merge and push give duplicated information https://git.io/fx392 12:59:57 <TrueBrain> it is a lot better tbfh :P 13:00:50 <LordAro> wait, why has it stopped reporting pushes on the DorpsGek-* repos? 13:00:57 <LordAro> before you merged that 13:00:59 <TrueBrain> because it was being deployed :) 13:01:14 <TrueBrain> so after the pull request, it started to deploy, and the push even is never received :P 13:01:17 <TrueBrain> ITS CHEATING :D 13:01:38 <LordAro> and it does that silently, because it's not the irc component that was restarted 13:01:42 <LordAro> nice 13:01:43 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain commented on issue #15: No message for reviews https://git.io/fx39w 13:01:56 <TrueBrain> yup 13:02:16 <TrueBrain> and because it is rare enough, I did not write code to capture the events and play them whenthe bot comes back online 13:02:19 <TrueBrain> read: I was too lazy 13:02:27 <LordAro> :) 13:07:42 <TrueBrain> sorry for the spam nielsm :) But it is appreciated :D 13:14:31 <LordAro> at what point do we start looking at OTTD again? :p 13:15:45 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain opened pull request #16: Add #15: support notifications about pull-request-review https://git.io/fx3HU 13:15:46 <DorpsGek_II> [OpenTTD/DorpsGek-irc] TrueBrain opened pull request #12: Add: handle the new pull_request_review actions https://git.io/fx3HT 13:17:28 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain opened pull request #17: Fix: don't shorten 'push' URLs https://git.io/fx3Hq 13:20:05 <DorpsGek_II> [OpenTTD/DorpsGek-irc] TrueBrain opened pull request #13: Fix: ignore activity on pyup- branches https://git.io/fx3Hn 13:20:10 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain opened pull request #18: Fix: ignore activity on pyup- branches https://git.io/fx3HC 13:20:58 <DorpsGek_II> [OpenTTD/DorpsGek-runner] TrueBrain opened pull request #9: Dorpsgek pyup https://git.io/fx3H4 13:21:13 <DorpsGek_II> [OpenTTD/DorpsGek-runner] TrueBrain updated pull request #9: Dorpsgek pyup https://git.io/fx3H4 13:21:55 <TrueBrain> LordAro: it is a regex, yes; that is why it is a *? 13:22:12 <LordAro> but that just matches any number of - 13:22:49 <DorpsGek_II> [OpenTTD/DorpsGek-irc] TrueBrain updated pull request #12: Add: handle the new pull_request_review actions https://git.io/fx3HT 13:22:55 <LordAro> should be .* 13:22:58 <TrueBrain> hmm 13:23:00 <TrueBrain> good point :D 13:23:20 <DorpsGek_II> [OpenTTD/DorpsGek-runner] TrueBrain updated pull request #9: Fix: ignore activity on pyup- branches https://git.io/fx3H4 13:23:21 <LordAro> i imagine it wouldn't make a difference in practice, it's not matching the whole line, but... 13:23:31 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain updated pull request #18: Fix: ignore activity on pyup- branches https://git.io/fx3HC 13:23:47 <DorpsGek_II> [OpenTTD/DorpsGek-irc] TrueBrain updated pull request #13: Fix: ignore activity on pyup- branches https://git.io/fx3Hn 13:25:04 <DorpsGek_II> [OpenTTD/DorpsGek-irc] TrueBrain opened issue #14: After net-split, the bot doesn't rejoin channels https://git.io/fx3Ho 13:28:04 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain closed issue #6913: Request: support Discord's Rich Presence API https://git.io/fx3Hy 13:28:05 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on issue #6913: Request: support Discord's Rich Presence API https://git.io/fx3HS 13:28:18 <TrueBrain> closed + commented have similar issues I see :) 13:28:50 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on issue #6916: Re-implement building binaries via compile farm https://git.io/fx3H9 13:29:05 *** gelignite has joined #openttd 13:29:40 <TrueBrain> that Discord issue :) Hihi 13:30:35 <DorpsGek_II> [OpenTTD/DorpsGek-irc] TrueBrain merged pull request #12: Add: handle the new pull_request_review actions https://git.io/fx3HT 13:31:14 *** sim-al2 has quit IRC 13:31:30 *** DorpsGek_II has quit IRC 13:32:52 *** DorpsGek_II has joined #openttd 13:32:53 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain merged pull request #16: Add #15: support notifications about pull-request-review https://git.io/fx3HU 13:33:00 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain closed issue #15: No message for reviews https://git.io/fx3Qe 13:35:20 <DorpsGek_II> [OpenTTD/DorpsGek-runner] TrueBrain merged pull request #9: Fix: ignore activity on pyup- branches https://git.io/fx3H4 13:35:26 <TrueBrain> HA! No more push spam :) 13:35:47 <DorpsGek_II> [OpenTTD/DorpsGek-irc] TrueBrain merged pull request #13: Fix: ignore activity on pyup- branches https://git.io/fx3Hn 13:36:00 <TrueBrain> tnx for all the reviews LordAro :) 13:36:23 *** DorpsGek_II has quit IRC 13:36:53 *** DorpsGek_II has joined #openttd 13:36:54 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain merged pull request #18: Fix: ignore activity on pyup- branches https://git.io/fx3HC 13:37:50 <TrueBrain> owh, one more left to review :P 13:37:57 <TrueBrain> means we can see if that also works now :D 13:58:02 <DorpsGek_II> [OpenTTD/DorpsGek-github] LordAro approved pull request #17: Fix: don't shorten 'push' URLs https://git.io/fx3Qh 13:58:07 <TrueBrain> \o/ 13:58:13 <LordAro> \o/ 13:58:19 <DorpsGek_II> [OpenTTD/DorpsGek-github] TrueBrain merged pull request #17: Fix: don't shorten 'push' URLs https://git.io/fx3Hq 13:59:50 <TrueBrain> and look, even the names are correct :D 14:00:19 <LordAro> well, the PR was also yours 14:00:28 <LordAro> haven't fully checked that yet ;) 14:00:30 <TrueBrain> I meant the approval :) 14:00:40 <LordAro> yeah, that works 14:00:52 <LordAro> don't know about the merge messages though :p 14:01:12 <TrueBrain> time will tell :D 14:07:38 *** Progman has joined #openttd 14:30:49 *** Wormnest has joined #openttd 14:33:37 <Eddi|zuHause> about the discord thing, i think the counter-suggestion was to try that via an admin port library 14:34:20 <TrueBrain> go for it! :) 14:34:22 <TrueBrain> :D 14:34:47 <Eddi|zuHause> i don't think so :p 14:35:26 <TrueBrain> exactly ;) 14:36:55 *** Gja has joined #openttd 14:38:21 *** haudrauf has quit IRC 14:39:19 *** haudrauf has joined #openttd 14:44:35 <Samu> a patch for helping AI's https://www.tt-forums.net/viewtopic.php?f=33&t=75216&hilit=patch 14:44:39 <Samu> i'm undecided 14:44:54 <Samu> juanjo approach or my approach? 14:45:30 <Eddi|zuHause> so, what's actually the holdup with nightly builds? 14:46:07 <Samu> my approach feels incomplete in regards to industry tiles on water 14:46:12 <Samu> it isn't done 14:46:30 <LordAro> Eddi|zuHause: windows, i think 14:47:34 <Samu> juanjo approach is kinda... too global, some situations could be excused 14:52:07 <Samu> oh, right, object tiles on water, i haven't done that either 14:55:26 <Samu> removing stuff shouldn't care if a ship is nearby 14:55:56 <Samu> changing rail signals shouldn't care if a ship is nearby 14:56:07 <Samu> hmm, i'm torn apart 14:56:09 <LordAro> you wouldn't have thought so 14:57:01 <Samu> i think that's what juanjo's approach is doing, it's too global 15:15:28 <Samu> juanjo's approach has one advantage, it's much simpler, it's just that it can't be applied inside EnsureNoVehicleOnGround 15:16:17 <Samu> must think 15:17:32 <Samu> calls all ships and see if they're coming into "collision" route towards the tile we're working on 15:18:25 <Samu> my approach is too manual, case by case 15:19:17 <Samu> doesn't call all ships, it only checks for ships on the nearby tiles 15:20:14 <Samu> what's supposedly faster? 15:20:34 <peter1138> Who even knows what you are doing. 15:21:04 <Samu> check if there's a ship in 4 tiles, or check from all ships if one is coming into collision with the tile we're working on? 15:21:31 *** andythenorth has joined #openttd 15:21:50 <Samu> we're trying to make ships avoid deadlocks 15:23:07 <andythenorth> do ships deadlock often? o_O 15:23:23 <Samu> well, in AI games they do happen quite often 15:24:25 <andythenorth> ok 15:25:23 <Samu> i remember NoCAB, especially, would built docks in such a manner that it could make a ship become trapped between two docks, in a single tile, no means to change its route, it's stuck 15:25:47 <Samu> going forward is dock 1, going backwards, is dock 2, stuck 15:26:16 <Samu> and I think OtviAI was also suffering similarly, with ship depots 15:27:22 <Samu> for human games, this is pratically a non-issue 15:27:55 <Samu> if someone locks a ship, it's like 99% to be on purpose 15:28:03 <andythenorth> are you trying to fix it in AI? 15:28:25 <LordAro> doesn't sound like it 15:28:29 <Samu> no 15:29:05 <andythenorth> oof 15:29:12 <andythenorth> sounds like poor AI design, but I'll leave it 15:29:44 <LordAro> perhaps the solution is to check for adequate space when constructing the dock/depot 15:29:54 <LordAro> doesn't help if you alter the water though 15:31:19 <Samu> i could try make this work exclusively for AI 15:32:11 <Samu> have seen some similar exclusivity work on BuildRoad stuff, could try mimic that 15:33:33 <Samu> there is a 0,0000001% chance of an industry spawning on water to lock a ship 15:33:49 <Samu> i saw some report on flyspray years ago 15:34:05 <Samu> couldn't find it now 15:36:56 *** Flygon has quit IRC 15:38:41 *** iSoSyS has quit IRC 15:40:48 <Samu> are you still planning to remove 90 degrees for ships? 15:42:48 *** andythenorth has quit IRC 15:45:21 *** andythenorth has joined #openttd 15:46:07 <Samu> https://imgur.com/B9GKm0S 15:46:54 <Samu> there must be no ship coming from that direction when the oil rig is placed there 15:47:17 <Samu> all those directions* 15:48:00 <Samu> How am I gonna do this 15:48:12 <Samu> the industry builder places tiles 1 by 1 :( 15:48:33 *** andythenorth has quit IRC 16:12:28 *** Wormnest has quit IRC 16:13:10 *** Gja has quit IRC 16:19:27 *** andythenorth has joined #openttd 16:40:07 <Samu> gonna pick up juanjo's work, and try to make it a bit more specialized 16:49:24 *** gelignite has quit IRC 16:49:48 *** synchris has joined #openttd 17:32:25 *** wodencafe has joined #openttd 17:33:11 <andythenorth> this is nearly a whole day's work :P 17:33:12 <andythenorth> https://dev.openttdcoop.org/attachments/download/9152/roarer_pantographs.png 17:33:14 <andythenorth> I blame Eddi 17:33:18 <andythenorth> but it's nearly done 17:37:20 *** Thedarkb-T60 has joined #openttd 17:41:21 *** snail_UES_ has joined #openttd 17:46:25 <Samu> who's a network expert 17:47:49 <Samu> how would I test for desyncs? 17:53:30 *** yellyFish has joined #openttd 17:54:52 <Samu> hmmm nah... juanjo approach is bad 17:55:02 <Samu> really have to do this case by case... boring 17:58:17 *** Code has joined #openttd 17:58:45 <Code> IDENTIFY 17:58:54 *** Code is now known as Guest725 17:59:00 <Guest725> sad 17:59:19 <Guest725> FUDGE 17:59:24 *** Guest725 has quit IRC 17:59:52 <LordAro> rip 18:00:12 *** yellyFish has quit IRC 18:02:22 *** Thedarkb-T60 has quit IRC 18:04:19 <Eddi|zuHause> andythenorth: except, the pantographs should be mirror images 18:05:16 <andythenorth> yes that will come 18:05:19 *** Thedarkb-T60 has joined #openttd 18:05:56 <andythenorth> that's just needs some indices swapping 18:07:35 *** gelignite has joined #openttd 18:13:13 *** stefino has joined #openttd 18:17:11 <stefino> hello, Is possible to code industry what can be build only manualy? For example hotels. I could build them manualy and they will be not generated automaticly when the map is create. 18:17:38 <Eddi|zuHause> yes 18:17:56 <Eddi|zuHause> the default game has the tropic sawmill that can only be built manually 18:18:33 <Eddi|zuHause> it's also really simple to do, just set the appearance chance to 0 18:19:31 <andythenorth> oof buy menu offsets have to be different for pantographs 18:19:35 <andythenorth> this is getting nuanced 18:20:02 <Eddi|zuHause> just make a separate buy menu sprite without composition 18:20:19 <andythenorth> well 18:20:33 <andythenorth> that kind of defeats the point :P 18:20:52 *** Wacko1976 has joined #openttd 18:20:58 <Eddi|zuHause> why? 18:21:15 <andythenorth> then I have just 2 sets of pantograph sprites, except where I've copied them into every purchase menu sprite 18:21:23 <stefino> ahh, thank s a lot. we have an idea to make some objects to reduce the cash, in case you have a lot of money. So I have idea to code some industry - for example schools, hospitals etc, what will be more expensive (you will reduce cash) and it gives to you some bonus(pass production ets) 18:21:23 <andythenorth> also I don't generally have purchase menu sprites 18:21:35 <andythenorth> I just use sprite 6 or so 18:22:01 <andythenorth> at this point I might as well figure out the maths for 2 more offset adjustments, then it's done 18:22:20 <Eddi|zuHause> andythenorth: them file an issue that you want the offsets to be the same, potentially breaking some existing grfs :p 18:22:50 <andythenorth> do you think we'd accept that PR :) 18:23:04 <Eddi|zuHause> i don't know 18:23:06 <andythenorth> I suspect the problem originates with me, because I center the sprites in purchase menu 18:23:36 <Eddi|zuHause> possibly 18:23:46 <andythenorth> not sure why the yoffs is off by one pixel 18:23:46 <andythenorth> but the xoffs discrepancy is almost certainly my doing 18:24:30 <Eddi|zuHause> the xoffs may be some inherited issue 18:24:53 <Eddi|zuHause> where the bottom part of the sprite gets cut off or something 18:25:04 <andythenorth> -${int(consist.buy_menu_width / 2)} 18:25:12 <andythenorth> suggests the cause of the xoffs 18:25:55 <Eddi|zuHause> andythenorth: i don't know how the compositing works exactly, but ideally you would make that adjustment after the composition 18:26:07 <Eddi|zuHause> so the relative positions of the subsprite stay the same 18:26:35 <andythenorth> each layer resolves to a spriteset 18:26:35 <Eddi|zuHause> or you have to duplicate the calculation everywhere 18:26:49 <andythenorth> I have to duplicate the calculation everywhere 18:27:05 <andythenorth> interestingly, Horse buy menu rows are taller than default base set 18:27:12 <andythenorth> the actual UI row 18:27:38 <Eddi|zuHause> the ui scales to sprite sizes 18:27:41 <andythenorth> 28px vs 34px or so 18:28:00 <andythenorth> so I am pushing sprites down further to compensate 18:28:09 <andythenorth> which explains the yoffs discrepancy I think 18:28:35 <Eddi|zuHause> 28px does not sound like a height 18:28:57 <Eddi|zuHause> (assuming 1x zoom) 18:29:54 <andythenorth> it might be off by a couple, I used a screen ruler 18:30:29 <Eddi|zuHause> but if just one buy menu sprite across all your loaded GRFs is taller than default, it's going to rescale 18:34:26 <stefino> an how many cargo labels can I use in one inustry GRF? 18:34:46 <stefino> my friend said that only 32? 18:43:49 <andythenorth> https://github.com/OpenTTD/OpenTTD/pull/6802 18:44:00 <andythenorth> stefino: ^ 18:44:14 <andythenorth> there is no stable release with that yet 18:44:29 <andythenorth> so it's a design choice whether you use 32 or 64 18:44:42 <andythenorth> and you'll have to compile your own OpenTTD to test the grf 18:45:03 <andythenorth> you should also see https://github.com/OpenTTD/OpenTTD/pull/6867 18:45:08 <andythenorth> which may or may not be approved 18:46:37 <Samu> I have a question, how do i iterate over all ships located on a tile? 18:47:00 <Samu> CommandCost ret = EnsureNoShipOnWater(tile); is insufficient 18:47:34 <Samu> there could be more than 1 ship 18:47:53 <stefino> thanks Andy 18:48:38 <andythenorth> I am working on FIRS v4 with up to 64 cargos, and 16 in / 16 out per industry 18:48:50 <andythenorth> I am hoping the second PR gets approved 18:51:12 <Samu> * When you fail to do this properly you create an almost untraceable DESYNC! 18:51:17 <Samu> I'm scared 18:51:56 <nielsm> andythenorth: nobody has lodged any conceptual complaint over the 16 in/out patches, so them getting in should really just be a matter of code quality 18:53:03 <andythenorth> frosch indicated same :) 18:53:12 <andythenorth> hopefully someone will review it some time :) 18:53:53 * andythenorth back tomorrow 18:53:55 *** andythenorth has quit IRC 18:56:52 <Samu> https://github.com/OpenTTD/OpenTTD/blob/master/src/vehicle.cpp#L400 18:57:10 *** glx has joined #openttd 18:57:10 *** ChanServ sets mode: +v glx 18:57:18 <Samu> so trains are different than ships in that they can't be on top of each other 18:57:35 <Samu> I can't resort to copy paste :( 19:00:27 <Samu> can't do a EnsureNoShipProcZ 19:00:55 <Samu> or the proc must return a list of vehicles on the tile, instead of returning only 1 vehicle 19:01:19 <Samu> how to do this? 19:06:37 *** stefino has quit IRC 19:14:46 <nielsm> what do you need a full list for? 19:15:25 <nielsm> if your goal is to detect whether or not there are any ships on a tile, if you can get just one from a query on the tile you know there are one or more ships there 19:40:25 *** sla_ro|master has quit IRC 19:43:02 *** Thedarkb-T60 has quit IRC 19:50:43 * LordAro compiled OTTD with clang7 19:50:59 <LordAro> only 3 new warnings (all the same thing), irritatingly from squirrel 19:51:21 <LordAro> sqcompiler.cpp:145:10: warning: local variable 'ret' will be copied despite being returned by name 19:56:27 <Samu> i need to check if a ship on a tile is on a specific track bit 19:57:28 <Eddi|zuHause> C++ has "return by name"? 19:57:50 <Samu> I am trying to avoid using FOR_ALL_SHIPS(s) 19:58:43 <Eddi|zuHause> can't even properly imagine what that would do 19:58:57 <Samu> hmm sec 19:59:58 *** HerzogDeXtEr has quit IRC 20:00:01 <Samu> https://paste.openttdcoop.org/pagop3ur5 20:00:58 <Samu> this is what I have right now, but it's not sufficient, because a ship could be on those tiles and yet not coming into collision with the tile 20:01:19 <Samu> i want to check in which tracks the ships are 20:02:18 <Samu> i need to iterate over all the ships on a tile and check each one individually in which track they are 20:02:25 <Samu> heh, repetition 20:03:51 <Samu> if (s->state & DiagdirReachesTracks(DiagdirBetweenTiles(tile, s->tile) 20:04:02 <Samu> s for vehicle of type ship 20:04:53 <LordAro> Eddi|zuHause: i have to admit, i'm not sure 20:05:55 <Samu> instead of CommandCost ret = EnsureNoShipOnWater(tile);, I want to get a list of vehicles on the tile :/ 20:06:04 <Eddi|zuHause> i once learned about languages like algol that "call by name" was meant as something like "everywhere the parameter appears, the expression that is passed is put in, and then evaluated in that context" 20:06:13 *** iSoSyS has joined #openttd 20:06:47 *** frosch123 has quit IRC 20:07:13 <Eddi|zuHause> but that concept always seemed so crazy to me that nobody should ever use it 20:52:04 <nielsm> I think that warning message above might have something to do with return value optimizations, since it talks about "will be copied" 20:53:01 <nielsm> I assume that means the compiler wasn't able to prove the variable can be constructed in the return slot in the calling function's stack, or whatever it might do 20:59:37 *** synchris has quit IRC 21:10:41 *** sim-al2 has joined #openttd 21:14:46 <Samu> what's the difference between DiagDirection and DiagDirectionByte 21:20:42 *** nielsm has quit IRC 21:21:30 *** Wormnest has joined #openttd 21:24:00 *** gelignite has quit IRC 21:30:47 *** iSoSyS has quit IRC 21:34:25 *** snail_UES_ has quit IRC 21:41:48 <Samu> why doesn't this work? DiagDirectionByte diag_dir_byte = axis == AXIS_X ? 1 << DIAGDIR_SE | 1 << DIAGDIR_NW : 1 << DIAGDIR_NE | 1 << DIAGDIR_SW; 21:41:59 <Samu> Severity Code Description Project File Line Suppression State Error C2440 'initializing': cannot convert from 'int' to 'DiagDirectionByte' openttd D:\OpenTTD\OpenTTD GitHub\OpenTTD\src\water_cmd.cpp 138 21:42:33 <Samu> gonna try byte 21:45:30 <Samu> byte diag_dir_byte = axis == AXIS_X ? 1 << DIAGDIR_SE | 1 << DIAGDIR_NW : 1 << DIAGDIR_NE | 1 << DIAGDIR_SW; 21:52:49 *** HerzogDeXtEr has joined #openttd 21:57:01 *** Wolf01 has quit IRC 21:58:59 *** andythenorth has joined #openttd 22:00:36 *** andythenorth has left #openttd 22:33:57 *** Wacko1976 has quit IRC 22:37:13 *** Wormnest has quit IRC 22:42:21 <Eddi|zuHause> i'm not sure if i learned anything about that here... https://github.com/jarro2783/cxxopts/pull/134/commits/dadc911e44c69b1e34926586271e495749a6cfd6 22:44:42 <LordAro> mm, that's a bit different 22:45:27 *** haudrauf has quit IRC 22:46:25 *** haudrauf has joined #openttd 23:08:17 *** Maarten has quit IRC 23:46:08 *** iSoSyS has joined #openttd