Log for #openttd on 15th November 2018:
Times are UTC Toggle Colours
00:53:24  *** Supercheese has quit IRC
00:53:49  *** Progman has quit IRC
02:47:43  *** glx has quit IRC
03:16:17  *** daspork is now known as movingtoznc
03:21:23  *** daspork has joined #openttd
03:46:29  *** movingtoznc has quit IRC
10:08:00  *** Progman has joined #openttd
11:12:20  *** wodencafe has joined #openttd
11:25:46  *** matt21347 has joined #openttd
14:53:42  *** nielsm has joined #openttd
15:41:04  *** Wormnest has joined #openttd
16:08:01  *** chomwitt has joined #openttd
17:02:55  *** andythenorth has joined #openttd
17:22:17  <andythenorth> o/
17:45:43  *** chomwitt has quit IRC
17:48:12  *** andythenorth has quit IRC
17:58:28  *** frosch123 has joined #openttd
17:59:32  <frosch123> @mode -R
17:59:32  *** DorpsGek sets mode: -R 
18:19:08  *** Wormnest has quit IRC
18:25:17  *** Eddi|zuHause has joined #openttd
18:26:24  *** andythenorth has joined #openttd
18:26:38  *** andythenorth has joined #openttd
18:28:33  <frosch123> 26 minutes for eddi
18:29:43  <andythenorth> is cat?
18:40:44  <andythenorth> have we lost eddi forever? o_O
18:43:53  <LordAro> rip eddi
18:47:42  *** Wolf01 has joined #openttd
18:47:46  <Wolf01> o/
18:49:01  <Wolf01> Did something funny happen here while I didn't exist?
18:56:57  <Eddi|zuHause> yeah. rip him
19:01:33  <planetmaker> o/
19:03:05  <SpComb> +R keeps all the spammers away
19:05:01  <Wolf01> Oh, a wild Eddi
19:05:55  *** Gja has joined #openttd
19:09:14  *** sim-al2 has joined #openttd
19:09:31  <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on issue #6967: BaNaNaS: Unhandled exception when uploading new
19:19:17  *** sim-al2 has quit IRC
19:48:57  *** sim-al2 has joined #openttd
19:51:41  <Wolf01> Btw, where have you been these days, Eddi?
19:52:26  <nielsm> caught up in eddy currents, lol
19:52:38  <frosch123> hibernation
19:53:04  <frosch123> Wolf01: that's like asking your cell phone what it did while the battery was low
19:54:47  <Wolf01> Oh, so other people than me disappear from existence when offline?
19:58:21  *** Supercheese has joined #openttd
20:00:09  <Eddi|zuHause> what days` it was october yesterday.
20:01:28  <Eddi|zuHause> also, i was complaining on another channel about how freenode became unusable since the previous spam wave, when this spam wave started
20:01:46  <Eddi|zuHause> because everything went +r
20:01:57  <LordAro> you could register :p
20:02:17  <andythenorth> wait
20:02:25  <andythenorth> there are _other_ channels? :o
20:02:31  <andythenorth> what do they talk about?
20:02:56  <Eddi|zuHause> i tried talking about trains with them, but that went nowhere
20:02:57  <frosch123> you
20:03:58  *** sim-al2 has quit IRC
20:04:10  <LordAro> Eddi|zuHause: you should try #trains :p
20:04:22  <LordAro> or maybe it's ##trains
20:04:26  <LordAro> i don't remember
20:04:40  <andythenorth> there's #andythenorth frosch123 ?
20:04:49  <andythenorth> there is now :P
20:05:08  <frosch123> no, it's #openttdcoop.devzone
20:05:13  <Eddi|zuHause> it's not only a different channel, but also a different network
20:05:21  *** sim-al2 has joined #openttd
20:05:28  <frosch123> some DevZone guy is commenting on every andy push all day
20:05:47  <Eddi|zuHause> also weirdly, i'm currently on 3 channels, but on 4 networks...
20:06:01  <frosch123> there are 4 different network?
20:06:08  <frosch123> or do you mean netsplits?
20:07:22  <Wolf01> I should get rid of my channels
20:07:29  <Wolf01> And keep only this
20:07:38  <Eddi|zuHause> i have 7 networks set up, but i haven't been to those others in ages
20:07:43  <Eddi|zuHause> no idea if they still exist
20:07:50  <Wolf01> So you can move on slack or whatever and I'll get rid of this too
20:08:41  <Wolf01> Meh, I'm still downloading destiny 2
20:08:43  <andythenorth> so where is TrueBrain?
20:09:06  *** rocky11384497 has joined #openttd
20:09:08  <andythenorth> gone to bed probly
20:09:11  <LordAro> tell me where is TrueBrain for i much desire to speak with him
20:09:20  <LordAro> TB is basically Gandalf
20:09:21  <frosch123> Wolf01: create a mattermost docker container, and submit it to tb for deployment on
20:09:38  <Eddi|zuHause> Wolf01: are you in a cycle where they release updates faster than you can download them?
20:10:03  <andythenorth> I am just curious which chatops tool he uses
20:10:07  <Eddi|zuHause> LordAro: a TrueBrain is never late
20:10:09  <andythenorth> such new buzzwords
20:11:10  <Eddi|zuHause> is there a blockchain-based chat yet?
20:11:31  <frosch123> i was wondering whether andy forgot that tb already talked about chat tools  2 weeks ago, but maybe he just assumes that tb moved on to other tools already
20:11:36  <LordAro> you can take my irc client away from my cold dead hands
20:11:46  <Wolf01> <Eddi|zuHause> Wolf01: are you in a cycle where they release updates faster than you can download them? <- still downloading the installation, I hope there isn't a patch after
20:12:16  <Eddi|zuHause> Wolf01: weren't you already doing that when i left "yesterday"?
20:12:38  <Wolf01> Yes, that's why I said "meh"
20:13:30  <Wolf01> The download started on october 2
20:14:17  <Eddi|zuHause> i don't think you're doing this right
20:15:02  <LordAro> oh dear
20:15:29  <andythenorth> frosch123: TB is on slack already
20:15:31  <Wolf01> 80GB... there was one time when I downloaded a 50GB game and I said "I won't do it again"
20:15:50  <andythenorth> chatops is some buzzword for handling incidents via chat
20:16:28  <Eddi|zuHause> i mean, you could have mailed them a stick and it would have arrived back...
20:18:39  <Wolf01> I really thought about it
20:19:11  <Eddi|zuHause> i've had slow internet for over a decade, there definitely had been situations where i drove to a place with decent internet, downloaded something, and came back home.
20:20:27  <Wolf01> They won't allow me from work
20:23:22  <Eddi|zuHause> i had a friend which i visited about once per week, and we swapped DVD+RWs
20:24:38  <Wolf01> I should get more friends... at least close to my location, the nearest one lives at 40km
20:25:23  <Eddi|zuHause> ever since i got good internet i haven't visited him nearly as often anymore
20:36:57  *** Gja has quit IRC
20:38:05  *** matt21347 has quit IRC
20:47:23  *** sim-al2 has quit IRC
20:50:13  *** gelignite has joined #openttd
21:04:04  <DorpsGek_II> [OpenTTD/OpenTTD] RailwAI opened issue #6969: Bug in extracting .tar file
21:05:02  <andythenorth> hmm
21:05:05  <andythenorth> nml needs patched?
21:05:33  <andythenorth> for industry cargos
21:10:58  <planetmaker> what does it need patching there? New cargoes? or 64?
21:11:49  <frosch123> new properties, new documentation
21:13:04  <frosch123>  <- no idea how completed/tested the latter is
21:13:36  <frosch123> also, no idea whether the cargo limit was raised to 64
21:13:40  <frosch123> but that is likely only one constant
21:14:28  <andythenorth> I somewhat tested nielsm's patch
21:14:42  <andythenorth> but some of the props were delayed by design issues / my understanding
21:14:57  <frosch123> hmm, nml seems to have abandoned all commit message style :p
21:27:30  <planetmaker> meh... it shouldn't... but yes, looks like
21:30:12  <nielsm>
21:30:28  <nielsm> can more people test this?
21:34:03  <LordAro> nielsm: anything specific? i'm not spotting anything when just scrolling around the map
21:34:30  <nielsm> it's a bunch of specific cases
21:35:46  *** gelignite has quit IRC
21:36:52  <planetmaker> frosch123, I've difficulty with that when doing it the git style with the pull requests and stuff... no editing it then anymore
21:37:08  <nielsm> e.g. build the medium heliport and have a heli land at it, the pad will paint on top of the heli
21:37:26  <frosch123> planetmaker: when squashing you can edit it
21:37:27  <nielsm> same for the helipads on some of the airports
21:38:24  <LordAro> nielsm: helicopters look fine for me, all zoom levels
21:38:28  <nielsm> hmm
21:38:42  <frosch123> you should share a savegame :)
21:39:08  <frosch123> sprite sorting is not particuary local, objects far away can affect it
21:41:01  <LordAro> wait, i see it with the heliports on the international airport
21:41:06  <nielsm> argh the hell of windows updates
21:41:15  <nielsm> changing all kinds of dll's
21:41:18  <LordAro> city & all heliports are fine though
21:41:20  <nielsm> invalidating my debug symbols cache
21:41:46  <nielsm> and having to wait for it to download new symbol files
21:42:15  <LordAro> similarly for intercontinental
21:42:46  <LordAro> similarly broken*
21:42:50  <nielsm> commuter airport should also do it
21:43:54  <LordAro> yeah, all 3 "new" airports
21:44:01  <LordAro> i still think of them as new, dammit
21:46:11  <LordAro> i can confirm something funky going on with RailwAI as well
21:47:06  <frosch123> the railwai issue is probably some squirrel thingie reading a line until \n and not checking for eof
21:47:22  <nielsm>
21:47:53  <frosch123> nielsm: it's pointless without savegame
21:47:57  <nielsm> this one is a fence flickering over the bridge when it should be below
21:48:04  <nielsm> I just recreated it in a fresh game
21:48:06  <nielsm> trivially
21:48:38  <LordAro> fine for me
21:48:41  <LordAro> both directions
21:49:15  <frosch123> nielsm: even the trees around the tile affect the sorting
21:49:18  <frosch123> it's not trivial
21:49:22  <LordAro> all bridge types
21:49:37  <frosch123> LordAro: maybe you have set trees to intransparent :p
21:49:58  <LordAro> nope :p
21:51:10  <Eddi|zuHause> this stuff is typically due to overlapping bounding boxes
21:51:47  <Eddi|zuHause> which maybe could use a better heuristic
21:52:12  <frosch123> Eddi|zuHause: the bounding boxes were not changed
21:52:17  <frosch123> someone made optimisations to the sorter
21:52:33  <frosch123> which are either wrong, or they are unlucky in undefined cases :p
21:52:48  <LordAro> ¯\_(ツ)_/¯
21:52:49  <frosch123> the "unlucky" may be triggered by the new "presort"
21:52:55  <LordAro> dunno what else i can check
21:53:03  <LordAro> (trees on or off)
21:53:27  <frosch123> LordAro: almost all you examples have X and Y swapped compared to nielsm's case :p
21:53:43  <frosch123> the suspected codechange does magic asymmetrically for X and Y
21:54:08  <Eddi|zuHause> frosch123: yes, but the "undefined" cases are usually wrong bounding boxes (either too big and overlapping, or too small and seemingly unrelated)
21:54:22  <LordAro> frosch123: not all though
21:55:04  <frosch123> Eddi|zuHause: anyway, both nielsm and lordaro have not yet found ctrl+b
21:55:46  <LordAro> :p
21:55:59  <LordAro> helicopter bounding box appears to be leaving a load of artifacts behind
21:56:00  <nielsm> frosch123 I did try it several days ago
21:56:09  <nielsm> and my results were inconclusive
21:56:35  <Eddi|zuHause> LordAro: in nielsm's picture there is also a vehicle on the bridge, which adds another bounding box
21:56:41  <frosch123> LordAro: that's a documented limitation of ctrl+b
21:56:48  <LordAro> fair enough
21:57:13  <nielsm>
21:57:20  <nielsm> zero vehicles here
21:57:40  <nielsm> literally just made a new game, built some rail and a bridge over, in a random position
21:57:48  <nielsm> and reproduced it for 4th or 5th time in a row
21:58:11  <LordAro> sounds like undefined behaviour then, if i can't reproduce it :p
21:58:15  <LordAro> you're on windows, right?
21:58:17  <nielsm> yes
21:58:31  <LordAro> compared to my linux build
21:58:32  <frosch123> nielsm: i think i know what is wrong with the diff
21:58:33  <nielsm> this is a debug build so it may not be using the sse4 code too
21:58:35  <Eddi|zuHause> nielsm: i'm pretty sure that ramp bounding box and the fence bounding box overlap
21:58:59  <frosch123>  /* all following sprites have xmin >= ps2->xmin */ <- this is not true after the first round of sorting
21:59:41  <andythenorth> undefined behaviour sounds like my government and elected representatives today :P
22:00:27  <Eddi|zuHause> with "today" you mean "the past two years"?
22:03:02  <nielsm> okay also getting it in a release build
22:03:17  <nielsm> and with a railroad bridge of a different type doing the crossing
22:04:18  <andythenorth> more specifically today
22:04:24  <Eddi|zuHause> <frosch123>  /* all following sprites have xmin >= ps2->xmin */ <- this is not true after the first round of sorting <-- that sounds like a "burn everything down and start from scratch" kind of error
22:05:09  <frosch123> Eddi|zuHause: sorting by a non-transitive relation is not easy :)
22:05:26  <Eddi|zuHause>
22:07:16  <LordAro> :D
22:08:28  <frosch123> is there some github option to directly create a pr to revert some commit?
22:08:48  <nielsm> I couldn't find it
22:08:53  <andythenorth> you're probably supposed to use a chatbot for it
22:09:00  <andythenorth> or jenkins does it for you
22:09:42  <Eddi|zuHause> i've no clue how github works
22:10:00  <frosch123> apparently i need to fnid the original pr
22:10:11  <frosch123> but it is not linked in the commit message in this case
22:10:14  <LordAro> it's linked with the commit
22:10:17  <LordAro> just below the message
22:10:44  <frosch123> found it, thanks
22:11:06  <frosch123> aww, not automatically revertable
22:11:12  <frosch123> apparently no trivial merge or something
22:11:47  <nielsm> "git revert thehash" worked just fine on commandline
22:12:00  <andythenorth> that usually works fine
22:12:07  <nielsm> maybe github wants to rewind history/reset head
22:12:11  <andythenorth> unless you want to revert the revert :P
22:12:12  <nielsm> for some strange reason
22:13:43  <nielsm> or maybe it wants the original branch to still exist
22:14:20  <nielsm> anyway, work tomorrow so bedtime
22:14:23  <nielsm> gn
22:15:41  *** bluepixel has joined #openttd
22:17:33  <planetmaker> it's not a "I add this in 30 minutes" addition to NML ;)
22:17:55  <DorpsGek_II> [OpenTTD/OpenTTD] frosch123 opened pull request #6970: Revert: Sprite sorting optimisation sorted incorrectly.
22:18:29  <andythenorth> planetmaker: nope :)
22:18:34  <andythenorth> it's more like a weekend
22:18:40  <andythenorth> it needs test cases also
22:18:48  <planetmaker> quite indeed
22:19:03  <andythenorth> I have some crude test cases from a FIRS hack, but not really something I'd commit
22:20:13  <Eddi|zuHause> andythenorth: sounds like a thing for a branch
22:20:22  <planetmaker> hm, maybe
22:20:35  <planetmaker> any syntax suggestions for that, andythenorth ?
22:20:48  <andythenorth> it's definitely a branch
22:21:13  <frosch123> every PR is a branch
22:21:16  <andythenorth> planetmaker: syntax for the branch, or the test cases?
22:21:22  <andythenorth> frosch123: not in FIRS yet :P
22:21:30  <frosch123> oh, i thought NML
22:21:31  <planetmaker> for how nml should handle these new things
22:21:54  <planetmaker> are we talking different things? :D
22:22:02  * andythenorth finds nielsm's patch
22:22:14  <andythenorth>
22:22:28  *** nielsm has quit IRC
22:22:28  <Eddi|zuHause> i was thinking a FIRS branch as test case for the NML update
22:22:49  <andythenorth> iirc most of those patches work, but prop 28 and industry prod. cb is a design bunfight
22:23:13  <andythenorth> Eddi|zuHause: like this? :P
22:23:37  <andythenorth> that's for the 64 cargos limit test, not the 16 cargo industry limit
22:23:48  <andythenorth> but same approach applies
22:27:15  <planetmaker> I would first need probably input on how the syntax for these queries should look like :)
22:27:28  <planetmaker> but even before that... I would need a bed :D
22:30:27  <Eddi|zuHause> beds are overrated
22:31:16  *** mitchellsalad__ has joined #openttd
22:35:09  * andythenorth sleeps on the floor
22:35:10  <andythenorth> not
22:35:13  *** andythenorth has left #openttd
22:36:48  <Wolf01> \o/ destiny 2 downloaded
22:36:57  <Wolf01> Also 'night
22:37:02  *** Wolf01 has quit IRC
22:52:44  <LordAro> interesting
22:53:06  <LordAro> RailwAI is UTF8-BOM formatted
22:54:10  <frosch123> i think there was some special code to skip BOMs
22:54:22  <LordAro> there is...
22:54:24  <frosch123> do you mean the buffer is overrun by the length of the BOM?
22:54:42  <LordAro> 3 characters "Rai"
22:54:45  <LordAro> looks like it might be
22:54:53  <LordAro> file starts 0xefbbbf
22:55:24  <LordAro> but so do all the other files, dunno why it's borking on the shippathfinder.nut in particular
22:56:03  <frosch123> do .tars do some alignment? so stuff is zero-padded to reach a multiple of 8 or something?
22:56:08  <Eddi|zuHause> "buffer overflow by utf8 bom" is another one of these "burn everything down" bugs :p
22:56:59  * LordAro xxd's the tar file
22:58:44  <LordAro> yeah, definitely some sort of alignment
22:59:43  *** Wacko1976 has joined #openttd
23:00:06  <LordAro> with the end of that file
23:00:19  <frosch123> squirrel.cpp:453 looks very much like the BOM is not accounted in "size"
23:00:54  <LordAro> that's what i was thinking
23:01:54  <LordAro> the file is 14848, which is 29*512
23:02:05  <LordAro> hits a lot of the power of 2 boundaries
23:02:20  <LordAro> maybe a file like that has never happened before
23:02:51  <frosch123> BOMs are quite uncommon, aren't they?
23:02:55  <LordAro> reasonably
23:03:01  <LordAro> especially in utf8
23:03:31  <LordAro> i think i can patch this reasonably
23:06:00  <frosch123> c90 code is so ugly
23:06:09  <LordAro> it's not great
23:06:29  <frosch123> also fix the "if (ret != 2) us = 0;" :)
23:06:43  <LordAro> i caught that while putting debugging in :p
23:06:44  <frosch123> it should check "size" instead of just reading 2 bytes
23:09:11  <LordAro> hmm, i don't think this would be able to read a UTF32 file :p
23:10:31  <LordAro> works :)
23:10:34  <frosch123> only oracle and other "enterprises" use utf32
23:11:04  <LordAro> still better than utf16 though
23:11:32  <LordAro> utf16 has the all the disadvantages of byte ordering in utf32, and it's also variable width
23:12:54  <frosch123> utf16 is said to be faster, but i think it is more complicated than utf8, so for me it's a case of optimsation negatively affecting the code
23:13:31  <LordAro> more or less
23:13:41  <LordAro> utf16 is usually only used because the system predates utf32
23:13:48  <LordAro> (windows, java, icu)
23:14:01  *** Wacko1976 has quit IRC
23:14:02  <LordAro> they were expecting fixed width, but then ucs4 happened
23:18:00  <LordAro> "Each file object includes any file data, and is preceded by a 512-byte header record. The file data is written unaltered except that its length is rounded up to a multiple of 512 bytes. The original tar implementation did not care about the contents of the padding bytes, and left the buffer data unaltered, but most modern tar implementations fill the extra space with zeros."
23:18:16  <LordAro> yeah, had to be a multiple of 512 AND with a BOM to cause this
23:18:23  <LordAro> that's pretty edgecasey :p
23:18:27  <frosch123> :)
23:19:54  <DorpsGek_II> [OpenTTD/OpenTTD] LordAro opened pull request #6971: Fix #6969: Account for BOM when reading script files
23:24:24  <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #6969: Bug in extracting .tar file
23:24:39  <DorpsGek_II> [OpenTTD/OpenTTD] frosch123 requested changes for pull request #6971: Fix #6969: Account for BOM when reading script files
23:30:12  <LordAro> frosch123: i'm not sure i quite understand your comment about sizes
23:30:49  <frosch123> the code uses the result of fread (number of bytes read) to check for eof
23:31:00  <frosch123> but that is pointless in tars, you have to check "size"
23:31:37  <frosch123> if you store a file of size "1" in the tar, the "size -= 2" will wrap around to 0xFFFFFFFF :)
23:31:57  <frosch123> the checks before do not catch the size "1" since fread is happy in a tar
23:33:13  <LordAro> right
23:36:18  *** itsallvoodoo has joined #openttd
23:38:30  <DorpsGek_II> [OpenTTD/OpenTTD] LordAro updated pull request #6971: Fix #6969: Account for BOM when reading script files
23:38:44  <LordAro> frosch123: i'm afraid the diff got a bit bigger :> telling gh to hide whitespace should make it easier
23:39:02  <DorpsGek_II> [OpenTTD/OpenTTD] LordAro dismissed a review for pull request #6971: Fix #6969: Account for BOM when reading script files
23:39:14  <frosch123> they added that to the gui
23:39:21  <LordAro> aye
23:39:24  <frosch123> in the past you had to enter a magic url
23:40:13  *** PlanckWalk has joined #openttd
23:40:42  <frosch123> LordAro: now it skips the fread, but still does a seek -2 ?
23:40:50  *** PlanckWalk has quit IRC
23:41:15  <LordAro> gah
23:41:16  <LordAro> :p
23:42:49  *** Flygon has joined #openttd
23:43:28  <frosch123> i don't think there is a valid squirrel file with size < 3
23:43:41  <frosch123> so, maybe just check it first and return invalid file
23:43:50  <LordAro> presumably the empty file is valid?
23:43:56  <LordAro> or a couple of spaces
23:44:08  <LordAro> does nothing, but technically valid
23:44:17  <frosch123> hm :s
23:48:29  <LordAro> it occurs to me that technically speaking the tar file could be lying about the length of file
23:49:02  <LordAro> i'm not sure how the tar parser handles that
23:49:35  <frosch123> if that is not checked earlier, then many things are likely broken :p
23:50:01  <LordAro> ok, i'll assume size will be happy :p
23:50:43  <frosch123> yes, i think if "size" is wrong, that should be handled earlier/elsewhere
23:52:48  <peter1138> < wossat then
23:54:51  <frosch123> shall we mirate from gh to
23:56:23  <DorpsGek_II> [OpenTTD/OpenTTD] LordAro updated pull request #6971: Fix #6969: Account for BOM when reading script files
23:56:27  <frosch123> i wonder what "sr" stands for
23:59:07  <LordAro> peter1138: it's suspiciously every single thing TB wanted
23:59:10  <LordAro> literally

Powered by YARRSTE version: svn-trunk