Log for #openttd on 4th January 2019:
Times are UTC Toggle Colours
00:16:15  <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #7008: The Debian and Ubuntu builds all depend on shockingly out of date libicu and libpng packages.
00:16:16  <DorpsGek_II> [OpenTTD/OpenTTD] LordAro closed issue #7008: The Debian and Ubuntu builds all depend on shockingly out of date libicu and libpng packages.
00:16:20  <LordAro> how's that?
00:23:39  <Samu> it becomes hiden
00:28:18  <Thedarkb-T60> Oh, fair enough
00:28:29  <Thedarkb-T60> I thought neither Libpng nor libicu were a problem
00:28:37  <Thedarkb-T60> I was told a while ago that it was just the age of the build farm.
00:28:49  <Thedarkb-T60> Sorry about that.
00:28:52  <LordAro> it's a bit of both :p
00:29:01  <LordAro> but mostly not, in the case of icu
00:32:30  <Samu> yay, everything works
00:32:31  *** Flygon has joined #openttd
00:32:33  <Samu>
01:14:54  *** lugo has quit IRC
01:34:26  *** Oroburos has joined #openttd
01:40:45  *** Oroburos has quit IRC
01:47:11  <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep opened pull request #7009: Improve pathfinder behaviour for finding road depots (fix #7001; see #6410, #6928, #6929)
02:17:19  *** Thedarkb-T60 has quit IRC
02:22:38  *** smoke_fumus has quit IRC
02:24:47  *** Progman has quit IRC
02:37:20  <Samu>
02:37:43  <Samu> Can you see where I'm going with that?
02:37:53  <Samu> anyone
02:38:25  <Samu> I'm doing this because of autorenew/autoreplace, let's hope it's not for nothing
02:45:05  *** Samu has quit IRC
03:15:28  *** glx has quit IRC
03:40:16  *** Wormnest has joined #openttd
03:42:07  *** Wormnest has quit IRC
03:42:09  *** HerzogDeXtEr has quit IRC
04:51:12  *** Thedarkb-X40 has quit IRC
06:34:39  *** Tshaw has joined #openttd
06:36:37  *** Tshaw has quit IRC
07:25:04  *** andythenorth has joined #openttd
08:02:03  <andythenorth> moin
08:35:18  *** smoke_fumus has joined #openttd
08:56:01  *** Samu has joined #openttd
09:07:42  *** Samu has quit IRC
09:14:28  *** andythenorth is now known as Guest1691
09:14:38  *** andythenorth has joined #openttd
09:25:30  *** Lejving has quit IRC
09:38:57  *** chomwitt has joined #openttd
09:49:03  <crem> When is openttd 2.0.0? :)
09:49:08  <crem> Morgen!
10:07:21  *** Mahjong1 has joined #openttd
10:11:15  *** sla_ro|master has joined #openttd
10:11:39  *** Mahjong has quit IRC
10:18:13  *** Progman has joined #openttd
10:20:46  *** andythenorth has joined #openttd
10:24:36  *** andythenorth has quit IRC
10:25:34  *** andythenorth has joined #openttd
10:27:59  <andythenorth> well
10:32:41  *** andythenorth has quit IRC
10:32:58  *** andythenorth has joined #openttd
10:38:40  <andythenorth> "all my errors"
11:43:48  *** lugo has joined #openttd
11:52:34  <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7009: Improve pathfinder behaviour for finding road depots (fix #7001; see #6410, #6928, #6929)
11:54:50  <LordAro> crem: when it's finished
11:56:31  <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on pull request #7009: Improve pathfinder behaviour for finding road depots (fix #7001; see #6410, #6928, #6929)
11:58:53  *** Samu has joined #openttd
12:03:57  <crem> Hm so 2.0.0 will be the ultimate openttd version when it's finished.. Make it last longer then!
12:07:17  <LordAro> :p
12:07:56  <Samu> hi
12:18:25  <DorpsGek_II> [OpenTTD/website] LordAro requested changes for pull request #7:  Add: downloads pages, and links from header/index to them
12:38:40  <peter1138> LordAro, surely there should be a behaviour change with 7009?
12:39:38  *** Thedarkb-T60 has joined #openttd
12:41:40  <Eddi|zuHause> i think he forgot the word "unexpected"?
12:42:05  <LordAro> er, yes
12:42:31  <LordAro> fixed
12:45:21  <Samu> do wagons have a unitnumber?
12:45:26  <Samu> must check
12:55:13  <peter1138> No they don't.
13:05:47  *** Borg has joined #openttd
13:10:14  *** Flygon has quit IRC
13:22:44  *** Thedarkb-T60 has quit IRC
13:23:20  *** lugo has quit IRC
13:41:30  <Samu> Types of rail known to the game.
13:41:30  <Samu> Enumerator:
13:41:30  <Samu> RAILTYPE_INVALID
13:41:30  <Samu> Invalid RailType.
13:41:36  <Samu> does not compute
13:42:12  <Samu>
13:42:13  <Samu> explain
13:45:04  <andythenorth> it's not valid
13:46:41  <LordAro> Samu: it's similar to the way "null" is used
13:52:35  *** milek7 has joined #openttd
13:55:19  *** Thedarkb-T60 has joined #openttd
13:57:00  *** synchris has joined #openttd
14:07:53  *** Thedarkb-T60 has quit IRC
14:17:06  *** nielsm has joined #openttd
14:19:21  *** Thedarkb-T60 has joined #openttd
14:19:59  <Samu> so there are no rail types at all? can't be
14:20:29  <Samu> there are 4 at least
14:25:16  <Samu> Train 0, lol
14:25:41  <Samu> so, wagons vehicles have names
14:26:43  <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7009: Improve pathfinder behaviour for finding road depots (fix #7001; see #6410, #6928, #6929)
14:26:52  <Samu> unit number of wagons is 0
14:27:02  <Samu> what if i have multiple wagons?
14:44:12  <Samu> still 0
14:45:00  <Samu> so -1 for invalid vehicle, 0 for wagons, 1 to 5000 for real vehicles
14:45:43  <Samu> i mean -1 for invalid unitnumber
14:48:15  <Samu> rail type 0 exists, but has no name, is that intended?
14:49:17  <Samu> the enumerator only got RAILTYPE_INVALID, where are the others
14:57:08  <Samu> I need another type
14:57:20  <Samu> there's VehicleID, can I invent UnitID?
14:57:28  <Samu> well, not invent, i mean reuse
14:57:37  <Samu> erm, dunno how to explain
14:58:32  <Samu> static bool IsValidVehicle_UnitNumber(UnitID vehicle_uid);
14:58:44  <Samu> UnitID vehicle_un?
14:59:11  <Samu> _un ? _uid? what's better?
14:59:37  <nielsm> "uid" is commonly an abbreviation for Unique ID so it might be misunderstood
14:59:53  <Samu> so _un?
15:00:03  <Samu> or maybe better
15:00:06  <Samu> vehicle_num?
15:00:40  <dwfreed> why not vehicle_unitnumber?
15:00:56  <Samu> kinda big name, but meh
15:00:59  <Samu> if that is ok
15:01:06  <andythenorth> bigger the better
15:01:28  * andythenorth looks for some long var names
15:01:29  <dwfreed> descriptive is better than brief
15:02:24  <andythenorth> hmm can't find any really good ones
15:02:32  <Samu> static bool IsValidVehicle_UnitNumber(UnitID vehicle_unitnumber);
15:02:33  <andythenorth> visual_effect_override_by_railtype is kind of ok
15:02:59  <Samu> oh, that's actually incomplete
15:03:03  *** Thedarkb-T60 has quit IRC
15:03:12  <Samu> static bool IsValidVehicle_UnitNumber(UnitID vehicle_unitnumber, ScriptVehicle::VehicleType vehicle_type);
15:03:26  <andythenorth> hehe classname PassengerVeryHighSpeedMiddleEngineConsist()
15:04:21  <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep opened pull request #7010: Defined constants instead of their values
15:09:35  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7010: Defined constants instead of their values
15:16:45  *** HerzogDeXtEr has joined #openttd
15:18:48  <Samu> vehicle_unitnumber <= max<UnitID>
15:18:58  <Samu> how do I extract the maximum value that UnitID can have?
15:19:15  <Samu> all I know is that it's uin16
15:19:18  <Samu> uint16
15:19:40  <Samu> vehicle_unitnumber <= UINT16_MAX
15:19:42  <Samu> looks ugly
15:19:57  <Samu> max<UnitID> doesn't work, im noob
15:21:17  *** GroovyNoodle has joined #openttd
15:21:27  <Samu> and if it's uint16, it can never be -1... uh oh, that is a problem
15:23:45  <Samu> looks like i'm gonna be forced to use int32
15:23:49  <Samu> because of -1
15:24:03  <Samu> rip UnitID
15:24:12  <nielsm> or you could do it like INVALID_CARGO etc. that uses the maximum value as sentinel
15:24:30  <nielsm> CargoID is a byte and the invalid value is 255
15:24:55  <Samu> can i define typedef or so?
15:25:05  <Samu> i saw a list of typedefs somewhere
15:25:41  <Samu> typedef uint32 UnitID;
15:25:52  <Samu> wait, not uint
15:25:53  <Samu> int32
15:26:57  <Samu> ok
15:27:06  <Samu> all the other typedefs are uints
15:27:16  <Samu> i am a bit lost here
15:28:23  <Samu> this is the file
15:28:32  <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on pull request #7010: Defined constants instead of their values
15:29:55  <Samu> where do I see that table?
15:29:59  <Samu> in the comment
15:30:04  <Samu> seems to be a table
15:31:52  <nielsm> good question, it seems that file isn't included in the doxygen runs for some reason
15:37:05  <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #7010: Defined constants instead of their values
15:37:40  *** Wormnest has joined #openttd
15:38:43  <Samu> seems that it was documented the autorenew would screw vehicle ids
15:41:51  *** andythenorth is now known as Guest1710
15:41:52  *** andythenorth has joined #openttd
15:44:02  *** Guest1710 has quit IRC
15:44:27  *** GroovyNoodle has quit IRC
15:47:33  <andythenorth> such draw
15:47:36  <andythenorth> very sprites
15:48:30  <Samu> typedef int32 UnitID;        ///< The unitnumber of a vehicle-type of a company
15:48:34  <Samu> good english? explanation?
15:48:58  <Samu> the unit number of a full consist vehicle of a type of a company?
15:49:07  <Samu> halp!
15:49:41  <Samu> i need to explain that wagons are not considered
15:49:57  <Samu> their ID is always 0, that would make it not unique
15:52:31  <Samu> and the invalid value is -1, if i want to maintain compatibility with the previous apis
15:53:54  <LordAro> Samu: get it working first, worry about wording of comments later
15:55:14  <Samu> ok, guess i need to make it compatible
15:55:27  <Samu> and turn it into uint16
15:56:11  *** frosch123 has joined #openttd
15:57:21  <Samu> current api treats it as a int32 and returns -1 for invalid, how to make it uint16 and return INVALID_UNITNUMBER
15:58:01  <andythenorth> 84% complete
15:58:11  <andythenorth> also quak
16:05:56  <frosch123> hoi
16:18:38  <LordAro> o/
16:19:02  <LordAro> someone should merge some PRs
16:28:29  <andythenorth> that mac os fix :P
16:28:38  <andythenorth> which I have to merge into every PR I test currently
16:29:27  <Samu> 	static const UnitID INVALID_UNITNUMBER = 0xFFFFui16; ///< Invalid UnitID.
16:33:28  <andythenorth> 0xFFFFui16 isn't something I've seen before
16:34:11  <Samu> is it wrong?
16:35:12  <dwfreed> I don't think i16 is a thing
16:35:23  <dwfreed> reading
16:37:45  <Samu> ok then UINT16_MAX
16:37:51  <Samu> or 0xFFFF
16:37:56  <Samu> dont know which one is uglier
16:38:23  <dwfreed> use UINT16_MAX
16:42:47  <Samu> i'm unsure if i need to edit the bin/ai/compat_ files
16:43:31  <nielsm> those are only needed if the API of an old feature has changed
16:43:41  <nielsm> to translate from old calls to new calls
16:44:04  <Samu> i am changing a return value from -1 to UINT16_MAX
16:44:28  <andythenorth> 86%
16:44:32  <andythenorth> I should make a bot
16:44:35  <nielsm> then you'd need to add some compat wrappers
16:45:51  <Samu>
16:46:06  <Samu> changing it sligthly
16:46:46  <Samu> . /* static */ int32 ScriptVehicle::GetUnitNumber(VehicleID vehicle_id)
16:47:01  <Samu> int32 to UnitID which is uint16
16:47:13  <Samu> if (!IsValidVehicle(vehicle_id)) return -1;
16:47:35  <Samu> -1 to UNITNUMBER_INVALID which is UINT16_MAX
16:49:06  <Samu> how to wrap?
16:52:48  <Samu> ah, I think I know what to do
16:56:19  *** Thedarkb-T60 has joined #openttd
16:56:49  *** andythenorth is now known as Guest1713
16:56:49  *** andythenorth has joined #openttd
16:59:16  <Samu> looks wrong
16:59:17  *** Guest1713 has quit IRC
17:00:52  <Samu> i dont know if i want to return -1
17:01:19  <Samu> for the old apis
17:03:19  <Samu> screw it
17:03:26  <Samu> im goin with int32
17:03:37  <Samu> less trouble
17:04:14  <Samu> and -1
17:07:51  <andythenorth> 87%
17:19:37  <Samu>  error C2371: 'UnitID': redefinition; different basic types
17:19:57  <Samu> what if I call it
17:20:00  <Samu> UnitNumber
17:20:08  <Samu> will it shut up?
17:30:21  <Samu> i'm unsure what to do about GS'es
17:30:42  <Samu> it requires them to be in a company to get the correct vehicle
17:33:01  <Samu> there can be up to (15 companies * 4 vehicle types) vehicles with the same UnitNumber
17:33:26  <Samu> vehicle type is enforced as a parameter
17:33:33  <Samu> but company isn't
17:37:16  <Samu> so... there can still be 15 vehicles with the same unitnumber when being OWNER_DEITY? or 0
17:38:32  *** Thedarkb-T60 has quit IRC
17:41:05  <Samu> EnforcePrecondition(false, ScriptObject::GetCompany() != OWNER_DEITY);
17:41:10  <Samu> rip GS'es
17:54:54  *** Wolf01 has joined #openttd
17:55:00  <Wolf01> o/
17:57:17  <andythenorth> lo
18:08:17  <TrueBrain> andythenorth: yup, that python script will fill your _downloads folder for you
18:08:26  <TrueBrain> tnx LordAro, for review
18:09:13  <LordAro> np :)
18:09:48  <TrueBrain> so if you click resolve, it eats your comment
18:09:49  <TrueBrain> that is evil
18:10:06  <LordAro> only hides it
18:10:21  <andythenorth> oof which python version does it need
18:10:22  * andythenorth looks
18:10:41  <LordAro> py3.6
18:10:49  <LordAro> because async stuff
18:10:53  <andythenorth> 5th time lucky
18:11:00  <LordAro> i didn't think to check that :p
18:11:00  <andythenorth> my 3.6 doesn't have aiohttp
18:11:02  <andythenorth> so eh
18:11:08  <andythenorth> I will fix that...another time
18:11:16  <LordAro> well it's an external library, so it won't :p
18:11:18  <andythenorth> I read the html, it basically looks fine
18:11:18  <DorpsGek_II> [OpenTTD/website] TrueBrain commented on pull request #7:  Add: downloads pages, and links from header/index to them
18:11:58  <TrueBrain> cool
18:12:10  <TrueBrain> LordAro: COPY .flake8 .flake8 copies the file .flake8 inside the docker under the same name
18:12:16  <TrueBrain> what did you find weird about the statement?
18:12:20  <TrueBrain> (your comment is a bit vague)
18:13:55  <LordAro> yeah, thought it was something like that
18:14:09  <LordAro> just my lack of knowledge of docker :)
18:14:26  <LordAro> (thought maybe it was doing `cp foo foo`)
18:14:31  <TrueBrain> ah :)
18:14:42  <LordAro> given all the other COPYs have different destinations
18:15:20  <TrueBrain> hmm .. can I use a variable in
18:15:29  <TrueBrain> I can not
18:15:31  <TrueBrain> annoying
18:15:31  <Wolf01> <- I'm really tempted from this shit
18:16:44  *** Gabda has joined #openttd
18:16:53  <LordAro> ew
18:17:39  <LordAro> last commit 5 months ago isn't a great sign
18:20:02  <DorpsGek_II> [OpenTTD/website] TrueBrain commented on pull request #7:  Add: downloads pages, and links from header/index to them
18:20:18  <Borg> guys... will be easy to merge maglev -> monorail?
18:20:21  <Borg> using newgrf?
18:20:45  <DorpsGek_II> [OpenTTD/website] TrueBrain commented on pull request #7:  Add: downloads pages, and links from header/index to them
18:20:53  <TrueBrain> annoying, I cannot bundle my comments :(
18:21:25  <nielsm> Borg that has already been done?
18:21:45  <Borg> nielsm: huh? where?
18:22:10  <Borg> nvm! if its done. great
18:22:13  <DorpsGek_II> [OpenTTD/website] TrueBrain updated pull request #7:  Add: downloads pages, and links from header/index to them
18:22:18  <Borg> I will read how to do it.. and I will do it myself :)
18:23:55  <TrueBrain> andythenorth: btw, I know how I want to solve downloads in the end-state; it won't stay in 'website' (but we just generate index.html files on the CDN which show a similar page). But that is future work :D
18:24:07  <TrueBrain> *focus TrueBrain, FOCUS*
18:24:08  <andythenorth> ok that's cool
18:25:54  <TrueBrain> so, nginx redirects and server-listing left
18:26:02  <TrueBrain> lets see if that can be done in this weekend or something
18:26:48  <TrueBrain> LordAro: bit difficult to see on gtihub, but I tihnk I fixed all the things you mentioned :) Tnx again!
18:26:57  <LordAro> :)
18:28:15  *** Gja has joined #openttd
18:29:00  <nielsm> hmm I swear I've seen a newgrf that just unifies monorail/maglev but maybe I'm confusing it with a ttdpatch option that does this?
18:30:24  <DorpsGek_II> [OpenTTD/website] LordAro approved pull request #7:  Add: downloads pages, and links from header/index to them
18:30:47  <LordAro> nielsm: pretty sure there's a grf that does something like that
18:31:03  <LordAro> i think it just makes the trains compatible with both track types
18:31:21  <nielsm> yes, or moves them to use the other type or somesuch
18:31:24  <LordAro> or, replaces them with trains that are compatible
18:31:29  <Samu> isn't EnforcePreCondition supposed to crash the script? I'm confused
18:32:43  <DorpsGek_II> [OpenTTD/website] TrueBrain merged pull request #7:  Add: downloads pages, and links from header/index to them
18:33:13  <LordAro> nielsm:
18:33:17  <Borg> nielsm: yeah.. I heard that is such newgrf.. cant find it for now
18:33:28  <LordAro> TrueBrain: excite
18:34:02  <nielsm> LordAro that's not quite the same :)
18:34:07  <TrueBrain> andythenorth: we also need a 404 and 500 page I guess; just to be fancy :)
18:34:25  <LordAro> nielsm: pretty sure that's the one i was thinking of, anyway :p
18:35:09  <DorpsGek_II> [OpenTTD/website] TrueBrain opened issue #8: No 404/500 html pages
18:37:00  <DorpsGek_II> [OpenTTD/website] TrueBrain opened issue #9: Redirect old URLs to new URLs
18:37:16  <TrueBrain> <- w00p!
18:37:52  <LordAro> it even downloads stuff!
18:38:20  <andythenorth> TrueBrain: I'll do those in a bit
18:38:31  <DorpsGek_II> [OpenTTD/website] TrueBrain opened issue #10: Auto-detect most likely download
18:38:41  <Borg> nielsm: hmm seems u cannot merge it.. at least I dont think there is easy way to do it
18:38:55  <TrueBrain> andythenorth: no rush; I decided to make bug-tickets for all the missing stuff, so anyone can help (hint hint) :D
18:39:23  <nielsm> Borg no, the approach should be to change the (default) trains so they only run on one of the railtypes
18:41:52  <DorpsGek_II> [OpenTTD/website] TrueBrain opened issue #11: Make the copyright in the bottom automatically bump years
18:43:28  <DorpsGek_II> [OpenTTD/website] LordAro commented on issue #11: Make the copyright in the bottom automatically bump years
18:43:50  <LordAro> #10 seems very doable with some basic JS
18:44:06  * andythenorth likes the idea of more contributors
18:44:07  <andythenorth> maybe someone can kill the remaining 2001-style css :P
18:44:18  <LordAro> :<
18:44:45  <LordAro> i fear i did not have as much time as i was expecting over christmas, so did not have any significant time for ottd :(
18:45:07  <DorpsGek_II> [OpenTTD/website] TrueBrain opened pull request #12: Fix: don't only print DATE after VERSION, but also set the BuildNumber as such
18:45:12  <TrueBrain> nasty bug :D
18:45:14  * LordAro is currently on train heading away from parents
18:45:40  <TrueBrain> LordAro: nobody blames you; we are just a bit disapointed, that is all :P
18:45:43  <TrueBrain> (KIDDING)
18:45:46  <LordAro> TrueBrain: what did that cause?
18:45:49  <LordAro> TrueBrain: :p
18:46:03  <TrueBrain> LordAro: docker image names are wrong
18:46:07  <Gabda> Hi everyone!
18:46:08  <TrueBrain> the tag is only the git-tag
18:46:12  <LordAro> heh
18:46:14  <TrueBrain> and I wanted it postfixed with the date :)
18:46:31  <DorpsGek_II> [OpenTTD/website] TrueBrain commented on issue #11: Make the copyright in the bottom automatically bump years
18:47:02  <TrueBrain> LordAro: #10 is indeed doable, especially as we did it server-side already (and there you have less data)
18:47:08  <TrueBrain> we just have to pick a good javascript library which does this :)
18:47:19  <LordAro> lol
18:47:22  <TrueBrain> (there are awesome small ones that do this for you)
18:47:38  <LordAro> pretty sure no external js is required
18:47:46  <LordAro> just a case of reading the user agent
18:47:49  <andythenorth> just install all of react, grunt, gulp, node
18:47:49  <andythenorth> it'll be fine
18:47:55  <TrueBrain> you want to use an existing library, as you dont want to know what you need to do to get it correct :P
18:47:57  * LordAro twitches
18:48:30  <TrueBrain> (let others do the hard work :P)
18:48:34  <LordAro> easy :p
18:49:11  <TrueBrain>
18:49:46  <TrueBrain> I really would like to avoid writing "our own", where others did already figure it out :P
18:50:16  <TrueBrain> <- I do not want to support shit like this :P
18:50:53  *** gelignite has joined #openttd
18:50:54  <DorpsGek_II> [OpenTTD/website] TrueBrain merged pull request #12: Fix: don't only print DATE after VERSION, but also set the BuildNumber as such
18:51:49  <LordAro> TrueBrain: pretty sure that's just browser detection rather than os detection :p
18:51:52  <LordAro> but sure
18:52:32  <TrueBrain> I know that we use to do the simply checks
18:52:35  <TrueBrain> and that we were often wrong
18:52:40  <TrueBrain> so we used a python lib to do it for us
18:52:43  <TrueBrain> never had an issue since :D
18:52:49  <TrueBrain> that is my only scare here
18:53:02  <LordAro> heh
18:54:07  <TrueBrain> openttd/website:0.0.0-79-g6b6309d-20190104-1851
18:54:12  <TrueBrain> is there a limit on tag-length? :P
18:55:29  <TrueBrain> possibly we need to put that tag in the HTML, so we can see what is served :)
18:55:33  <TrueBrain> expectation vs reality :P
18:56:26  <LordAro> lol
18:56:51  <TrueBrain> <- only 50MiB :D
18:56:52  <TrueBrain> sweet
18:57:18  <TrueBrain> that is a bit weird ... added a shitton of downloads, and it didnt icnrease in size
18:57:28  <TrueBrain> compression much? :P
19:00:07  <Samu> I've been thinking through this and wonder if I need more functions other than what i've done already
19:00:15  <DorpsGek_II> [OpenTTD/OpenTTD] Gabda87 commented on issue #6887: Add layer showing boundaries for local authorities
19:00:55  <Samu> Vehicle lists returning the unitnumber and a function that redirects unitnumber to the current vehicle index
19:00:59  <LordAro> TrueBrain: nice, the same size as an electron app :p
19:01:19  <Samu> i can build my own valuators
19:01:36  <Samu> dont need the api to have them
19:03:03  <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #6887: Add layer showing boundaries for local authorities
19:06:39  <Samu> i'm confused
19:16:35  <andythenorth> TrueBrain: just keep using the python lib, via XHR :P
19:16:36  <Borg> is acceleration model of railtype is actually used?
19:16:41  <andythenorth> 'over-engineered'
19:16:53  <Borg> because engine have traction type..
19:17:13  <andythenorth> borg AIUI it's used
19:17:23  <andythenorth>
19:17:26  <LordAro> TrueBrain: it occurs to me that there's going to have to be a way to update the website every time the downloads list changes, without any actual change to the website content. i assume you've accounted for that?
19:20:09  <Borg> andythenorth: AIUI??
19:20:19  <andythenorth> as I understand it, sorry
19:20:20  <Borg> As I understand It? ;)
19:20:23  <Borg> ok...
19:20:37  <Borg> okey..
19:20:44  <Borg> got an idea how to merge maglev and monorail :)
19:21:44  *** Gabda has quit IRC
19:23:05  <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6887: Add layer showing boundaries for local authorities
19:24:13  <Borg> btw, what ID should I use for railtype ID when Im changing existing one? this is noet clearnly documented
19:25:21  *** Tirili has joined #openttd
19:28:58  <andythenorth> dunno, railtypes are a mystery :)
19:36:16  <Borg> okey, lets use 00 and see what happens
19:36:37  <peter1138> Pretty they are GRF-local only, it's the labels that matter.
19:38:51  <Borg> seems so
19:38:54  <Borg> used 00 and its all right
19:39:02  <Borg> YAY... merging maglev -> monorail was easy
19:39:09  <Borg> redefining 4 trains
19:43:34  <Samu> wow, i've been an idiot all this time
19:44:17  <Samu> the functions I am making for the API could be made on the AI
19:44:42  <Samu> perhaps lists as well
19:45:05  <Samu> it just that it takes tons of turns to do the same job
19:56:49  *** Gja has quit IRC
20:00:37  <peter1138> +sure
20:01:31  *** Gabda has joined #openttd
20:02:32  *** glx has joined #openttd
20:02:32  *** ChanServ sets mode: +v glx
20:08:53  <Gabda> andythenorth: what are function of patch packs here? they are optional to add to their own copy, ot these pathes will be included after a while to the game?
20:09:48  *** Gja has joined #openttd
20:11:35  <andythenorth> Gabda: patch packs are just personal projects by the author
20:11:41  <andythenorth> they have no relation to official release
20:11:45  <andythenorth> but they are encouraged
20:12:45  <nielsm> okay now, why is it not using my graphics...
20:13:53  <Gabda> and what happens when a patch, like the zoning patch you mentioned solves two issues (requests)?
20:13:54  <Borg> nielsm: I made it :D
20:14:29  <andythenorth> nielsm: I'm looking
20:14:32  <Borg> nielsm: not merged technically.. but moved Maglev engines to monorail.. and kept monorail engines too.. now its mixed.. monorail/maglev
20:15:24  <Samu> tragic work just to redirect to the current vehicle_id, it's probably slow
20:15:34  <Samu> but at least I didn't need to change the API
20:17:17  <nielsm> andythenorth: I can confirm my graphics is getting included at least, I can browse to them in the sprite aligner
20:17:17  <andythenorth> oof FIRS code :P
20:17:26  <andythenorth> such baroque
20:18:00  <andythenorth> what's the 'default' prop in 'graphics'?
20:18:02  * andythenorth looks it up
20:18:19  <nielsm> as far as I understand, the actual spriteset to use
20:18:51  <andythenorth> hmm it's some kind of optional nml keyword I think
20:18:55  <andythenorth> FIRS doesn't use it, but docs do
20:19:13  <nielsm> let's try without it
20:19:23  <nielsm> no dif
20:20:25  <andythenorth> hmm
20:20:28  <nielsm> actually, maybe the issue is in the tilelayout
20:21:09  <DorpsGek_II> [OpenTTD/OpenTTD] Gabda87 commented on issue #6887: Add layer showing boundaries for local authorities
20:21:48  <nielsm> because it seems like it might really be using one of the original industrytiles
20:22:21  <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6887: Add layer showing boundaries for local authorities
20:23:24  <andythenorth> can't see anything wrong with your tilelayout
20:24:08  <andythenorth> nielsm: does it show the water even?
20:24:15  <nielsm> no
20:24:27  <andythenorth> can you get the tile IDs out of debug tools?
20:24:29  * andythenorth looks
20:24:42  <nielsm>
20:24:46  <Samu> i see some kind of light at the end of the tunnel for my AI :)
20:25:04  <Samu> candy coal
20:25:31  <andythenorth> nielsm: no debug tools? o_O
20:25:46  <nielsm> running a release build atm because it's faster :)
20:25:50  <andythenorth> ok
20:25:57  *** Gabda has left #openttd
20:26:39  <andythenorth> newgrf dev tools could use some extension :)
20:26:46  <andythenorth> tile ID would be helpful
20:27:11  <andythenorth> hmm maybe var 62 will give it
20:27:38  <andythenorth> yes it does, if given the offset 0000
20:30:06  <nielsm> m5 = 0 for all the tiles, that's the coal mine tile
20:30:11  <nielsm> matching graphics
20:33:10  <nielsm> think this is the nfo generated for it:
20:33:44  <nielsm> 0A \b1 \d68 introduces the tilelayout, which looks correct (the industrytile ids are nonzero)
20:37:18  <andythenorth> it will be something obvious we're overlooking :P
20:38:41  <andythenorth> nielsm: try setting override
20:39:24  <andythenorth> don't think it's relevant but eh
20:41:49  <andythenorth> the docs say don't use override, but FIRS does, dunno why
20:44:17  <andythenorth> nielsm: try moving the tile definition above the layout definition
20:44:36  <andythenorth> I can't remember nfo FIRS, but iirc order of declaration was significant
20:45:07  <andythenorth> not sure how nml handles that  :P
20:45:34  <andythenorth> if this was just a typo, you'd have a syntax errror, right?
20:45:39  <andythenorth> and the correct grf is loaded? o_O
20:53:02  *** Gabda has joined #openttd
20:59:21  <TrueBrain> LordAro: that is why I added the ${DATE}  to the tag, yes :)
20:59:40  <TrueBrain> LordAro: over time, downloads will be removed from website; for  now it needs to be triggered every time a new download is added
20:59:54  <TrueBrain> its a rare event, so we should be fine :)
21:00:02  <LordAro> :)
21:00:03  <nielsm> hmm
21:00:28  <andythenorth> nielsm: you won :P
21:00:38  <andythenorth> x and y switched? o_O
21:01:13  <nielsm> nope, I overrode the oilrig tile ids and used those original ids in the tilelayout instead
21:01:19  <TrueBrain> hmm .. self host Sentry, or use the limited cloud solution .. hmm
21:01:51  <nielsm> but yes I switched x and y in the layout ;)
21:02:03  <nielsm>
21:02:10  <andythenorth> finis
21:02:20  <DorpsGek_II> [OpenTTD/website] glx22 commented on issue #10: Auto-detect most likely download
21:03:04  <DorpsGek_II> [OpenTTD/website] TrueBrain commented on issue #10: Auto-detect most likely download
21:04:18  <TrueBrain> oeh, you can apply for a free Sentry account if you are Open Source .. that might be a good idea
21:04:34  <andythenorth> as long as you don't want too many nodes :P
21:04:44  <andythenorth> oh no I'm thinking of Server Density
21:04:44  <andythenorth> oops
21:04:52  <andythenorth> confused andythenorth
21:05:10  <LordAro> TrueBrain: sentry for error collection?
21:05:29  <TrueBrain> LordAro: yes; mostly for the Python parts
21:05:34  <LordAro> are you expecting lots of errors? :p
21:05:42  <TrueBrain> no; but errors will be invisible now
21:05:49  <TrueBrain> so I want something that creates a ticket for any error that comes by
21:06:09  <LordAro> aye
21:06:17  <TrueBrain> I rather have a ticket about an error, than a user telling me something doesnt work :)
21:06:50  <LordAro> now you can have both!
21:07:08  <andythenorth> oof
21:08:18  * LordAro whispers admin port
21:09:13  <andythenorth> so can haxors own me through openttd?
21:09:30  <LordAro> yes.
21:09:52  <andythenorth> hey, I got one of those 'I have video of you watching adult content, send me btc' emails today
21:09:56  <LordAro> i feel like some sort of fail2ban integrarion shouls be possible...
21:10:03  <andythenorth> never had one before
21:10:03  <LordAro> but as a separate script, ofc
21:10:06  <nielsm> ugh can't override indtile 0x18 to not accept passengers, without losing the magic oilrig station behavior
21:10:17  <andythenorth> 'you will see that I have sent this from your account, proving I have your password'
21:10:23  <LordAro> oilrigs are still very magic
21:10:27  <andythenorth> nielsm: you can't
21:10:33  <andythenorth> there was a simple patch to provide it
21:10:51  <andythenorth> but it fell into the hellchasm called newgrf airports about 8 years ago
21:10:56  <andythenorth> so it died of course
21:11:13  <andythenorth> nothing kills good ideas like newgrf airports :P
21:11:39  <LordAro> heh
21:11:39  <LordAro> i thought that was ntrt?
21:11:47  <LordAro> nrt*
21:11:54  <andythenorth> nah, NRT hasn't blocked other stuff
21:11:56  <andythenorth> 'your anti-virus can't stop me, I have installed this malware via the driver'
21:12:04  <nielsm> should have an indtile special flag for "creates dock" and "creates helipad"
21:12:22  <andythenorth> nielsm: yes, but then THAT PREVENTS NEWGRF AIRPORTS EVER, or something silly :)
21:12:28  <andythenorth> I have a screenshot
21:12:48  <TrueBrain> lol @ tt-forums post andythenorth .. "aware of this problem" .. which problem?
21:12:51  <TrueBrain> what got hacked?
21:13:03  <TrueBrain> so many questions
21:13:05  <TrueBrain> so few answers :P
21:13:05  <andythenorth> so many
21:13:25  <LordAro> someone had their password set to password, probably
21:13:39  <TrueBrain> or did the server got hacked? which runs OpenTTD? :P
21:13:56  <TrueBrain> right, requested access for an Open Source sentry account
21:13:58  <TrueBrain> see what happens
21:14:13  <glx> maybe just company auto clean removed the password
21:14:26  <LordAro> ha
21:14:47  <TrueBrain> the logs allow that option, yes
21:14:55  <TrueBrain> the logs just show someone that connects, and starts to play
21:14:57  <TrueBrain> so .. yeah ..
21:15:08  <TrueBrain> maybe someone should ask nicely what the fuck he is on about :P
21:15:51  <andythenorth> not me now
21:16:06  <andythenorth> I am all out of nice today
21:16:17  <LordAro> TrueBrain: but you're so good at it :p
21:16:59  <TrueBrain> I do the polite shit on GitHub, you can do it on tt-forums, okay? :)
21:17:14  <andythenorth> I did it on Flyspray
21:17:17  <andythenorth> in 500 tickets :P
21:17:24  <andythenorth> my work is done
21:17:25  <TrueBrain> so tag, LordAro is it
21:17:32  <andythenorth> just wait for Eddi|zuHause to do it
21:17:36  <andythenorth> Eddi|zuHause is good at it
21:17:40  <LordAro> /part
21:17:47  <TrueBrain> the same way an axe is good in chopping wood, I assume
21:18:10  <andythenorth> eddi is unfailingly polite, but technically accurae
21:18:13  <andythenorth> accurate *
21:18:52  <TrueBrain> I like how and are nearly identical
21:18:54  <TrueBrain> its sweet :D
21:19:08  <LordAro> as it should be ^^
21:19:19  <andythenorth> there is a screaming difference
21:19:30  <andythenorth> the drop shadow doesn't use as many images
21:19:42  <TrueBrain> the bottom is different too
21:19:45  <andythenorth> yes
21:19:49  <TrueBrain> but .. that is fine
21:19:55  <TrueBrain> LordAro is going to fix it all anyway, he promised
21:19:56  <TrueBrain> :D
21:19:57  <TrueBrain> <3
21:19:58  <andythenorth> I changed it deliberatlely
21:20:11  <TrueBrain> we should cleanup the Developers list soon
21:20:20  <TrueBrain> if no activity for N years, remove from list
21:20:33  <LordAro> unless ludde
21:20:38  <TrueBrain> ludde is not on that list
21:20:45  <TrueBrain> DV isn't even
21:20:57  <LordAro> oh, that developers list
21:21:06  <TrueBrain>
21:21:19  <LordAro> ye
21:21:32  <LordAro> i was thinking of the ingame/readme/wiki developers list
21:21:43  <TrueBrain> ah; yeah, we should just update there who is retired :)
21:21:58  <LordAro> mm
21:22:03  <nielsm> I wrote a reply to that supposed vuln
21:22:18  <LordAro> retired/mia, same diff
21:22:51  <TrueBrain> nielsm: nice :D
21:22:57  <TrueBrain> LordAro: yup .. we have some MIAs ...
21:23:04  <TrueBrain> of some I still wonder what happened :P
21:23:22  <LordAro> Yexo went to google, i think pm said?
21:23:37  <TrueBrain> so people said, yes
21:23:41  <TrueBrain> how about adf88?
21:23:44  <LordAro> adf had some polish weirdness happen
21:24:00  <TrueBrain> Belugas?
21:24:05  <LordAro> that's as detailed as i can get :p
21:24:16  <LordAro> @seen Belugas
21:24:16  <DorpsGek> LordAro: Belugas was last seen in #openttd 1 year, 39 weeks, 6 days, 1 hour, 5 minutes, and 44 seconds ago: <Belugas> yeah, a birthday :)  a good friend of mine!
21:24:23  <TrueBrain> Terkhen is still idling here .. but I guess it is safe to remove him from the list :)
21:24:35  <TrueBrain> @seen Zuu
21:24:35  <DorpsGek> TrueBrain: Zuu was last seen in #openttd 1 week, 1 day, 20 hours, 13 minutes, and 51 seconds ago: <Zuu> So any data that is slow to determine for saving has to be pre-cached already before Save() is called. Load is easier, just save the data to this._save and handle it in Start() and you are good.
21:24:51  <LordAro> zuu's inactive at most
21:25:03  <LordAro> @seen Terkhen
21:25:03  <DorpsGek> LordAro: Terkhen was last seen in #openttd 2 years, 47 weeks, 5 days, 2 hours, 48 minutes, and 7 seconds ago: <Terkhen> Hello
21:25:10  <TrueBrain> Rubidium isnt even on IRC anymore? :o
21:25:20  <LordAro> :o
21:25:22  <LordAro> whelp
21:25:24  <TrueBrain> owh, he is, just not here :P
21:25:27  <TrueBrain> cannot blame him :D
21:25:29  <LordAro> when did that happen?
21:25:48  *** synchris has quit IRC
21:25:54  <LordAro> @seen Rubidium
21:25:54  <DorpsGek> LordAro: Rubidium was last seen in #openttd 22 weeks, 6 days, 12 hours, 22 minutes, and 10 seconds ago: <Rubidium> peter1138: but then the 4-5 day shipping holds, right? Friday, Saturday, Sunday and finally arriving on Monday; I count 4 days of shipping ;)
21:26:10  <LordAro> 6 months ago, fine
21:26:37  <TrueBrain> I think mostly that list should be people who can be contacted
21:26:45  <TrueBrain> I dont care if they have commit-rights etc
21:27:00  <TrueBrain> but at least that list should somewhat give names which you can poke for certain stuff
21:27:07  <andythenorth> yeah yexo is apparently a google SRE in Munich
21:27:50  <andythenorth> time for a clean up then TB
21:28:07  <TrueBrain> yeah .. but first I am going to work towards getting it production-ready :P
21:29:14  <andythenorth> 90% Horse
21:29:18  <andythenorth> that's 'done'?
21:29:34  <LordAro> :o
21:29:57  <andythenorth> probly not then
21:30:00  <andythenorth> alpha 2 maybe :P
21:30:05  *** sla_ro|master has quit IRC
21:30:24  <DorpsGek_II> [OpenTTD/website] TrueBrain opened issue #13: Server-listing cannot be on
21:32:25  *** gelignite has quit IRC
21:32:52  <andythenorth> 92%
21:41:54  *** Tirili has quit IRC
21:44:07  <nielsm> andythenorth: painting or deleting? :)
21:44:17  <andythenorth> both
21:44:33  <andythenorth> urgh, I was about to ship an alpha using a var that doesn't exist
21:44:34  <andythenorth> oops
21:45:31  <TrueBrain> bad andythenorth
21:45:32  <TrueBrain> bad! :P
21:45:53  *** Borg has quit IRC
21:45:55  <andythenorth> kittens would have died
21:47:38  <TrueBrain> guess it is a good thing we only care about frogs
21:47:49  <andythenorth> oh I was better than I thought
21:47:57  <andythenorth> I'd already fixed that :P
21:49:30  <TrueBrain> we always knew you were awesome
21:49:43  <TrueBrain> too bad it took this long to shine; but better late than never!
21:49:45  <TrueBrain> <3 :D
21:50:45  <andythenorth> been hiding my ligth
21:50:47  <andythenorth> for years
21:50:50  <andythenorth> under a bushel
21:51:00  *** Tirili has joined #openttd
21:51:02  * andythenorth tags it
21:54:18  *** Gabda has quit IRC
21:56:04  <LordAro> no going back now
21:57:44  <TrueBrain> WE ARE DOOMED!
21:57:47  <TrueBrain> TO THE SHELTERS
21:57:48  <TrueBrain> :D
21:58:06  <andythenorth> oops, I broke Jenkins
21:58:07  <andythenorth> nvm
21:58:13  <andythenorth> jenkins doesn't have 'time'
22:04:17  <TrueBrain> nobody has time
22:04:20  <TrueBrain> we all have to make due
22:05:00  *** Wacko1976 has joined #openttd
22:08:52  *** Tirili has quit IRC
22:09:09  *** Tirili has joined #openttd
22:12:29  <nielsm> okay I think there is a bug with newgrf handling of industry tiles
22:12:41  <nielsm> that don't have an override property set
22:13:35  *** Tirili has quit IRC
22:14:08  <nielsm> here it's checked whether the tile id is overridden to something else:
22:14:21  <nielsm> INVALID_INDUSTRYTILE is 0x1FF
22:15:35  <nielsm> but the way the IndustryTileOverrideManager is implemented in newgrf_commons.(h|cpp) the override value is a byte, so the default of "not overridden" is not possible
22:15:40  <nielsm> and isn't used either
22:15:59  <andythenorth> plausible
22:16:17  <nielsm> as far as I can tell this means it's impossible to actually define a new and usable industrytile, you have to re-purpose an existing tile
22:17:34  <nielsm> okay the global instance _industile_mngr does get initialized with an invalidID=INVALID_INDUSTRYTILE
22:17:50  <nielsm> but I'm not sure I follow the conditions for the invalidID to actually get used
22:18:02  <andythenorth> all of the FIRS tiles use substitute
22:18:30  <andythenorth> but FIRS industry uses both substitute and over-ride, which I'm not sure why, might just be error
22:18:36  <andythenorth> override /s
22:19:07  <nielsm> hmm FIRS tiles only substitute, never override?
22:24:08  <andythenorth> code says so
22:24:39  <andythenorth> I don't know what nml is doing
22:24:42  * andythenorth looks
22:27:06  <andythenorth> casual check suggests nml is doing prop 0x08 and 0x09 correctly
22:27:20  <nielsm> it is
22:27:28  <nielsm> I've checked the generated NFO and it looks fine
22:32:49  <andythenorth> hmm
22:42:50  <nielsm> well that was a wild chase
22:43:02  <nielsm> when the reason was indeed definition order in nml
22:43:15  <nielsm> the industry defined before the tiles
22:43:35  <nielsm> so when the tilelayout is read from the grf it refers to tiles that don't exist yet
22:43:49  <nielsm> moving the industry def below the tile defs makes it work
22:43:55  <andythenorth> good
22:44:19  <andythenorth> feel like I could have saved you some time there, sorry :P
22:45:59  <nielsm> on the positive side, I learned some more about how grf loading happens :D
22:46:43  <DorpsGek_II> [OpenTTD/OpenTTD] slhurst opened issue #7011: Towns don't grow if first tile of station is outside authority area
22:47:40  <nielsm> and that also got me a bunch more indtiles fixed :)
22:48:12  <andythenorth> \o/
22:48:14  * andythenorth bed
22:48:15  *** andythenorth has left #openttd
22:51:57  *** NoMorePacers_ has joined #openttd
22:53:55  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on issue #7011: Towns don't grow if first tile of station is outside authority area
22:55:10  <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh merged pull request #7010: Defined constants instead of their values
23:10:21  <DorpsGek_II> [OpenTTD/OpenTTD] slhurst commented on issue #7011: Towns don't grow if first tile of station is outside authority area
23:19:07  <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z commented on issue #7011: Towns don't grow if first tile of station is outside authority area
23:37:07  *** nielsm has quit IRC
23:39:26  <Samu> found a bug here
23:39:35  *** NoMorePacers_ has quit IRC
23:39:59  <Samu> it is looking for waypoints, but there is already a way to get waypoints
23:40:37  <Samu>
23:40:38  <Samu> there
23:41:20  <Samu> actually line 36
23:43:18  <Samu> oh no, sorry, not a bug, I'm confused
23:57:06  *** Wacko1976_ has joined #openttd

Powered by YARRSTE version: svn-trunk