Times are UTC Toggle Colours
00:06:21 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhnY4 00:08:50 <Samu> https://en.wikipedia.org/wiki/Function_prototype 00:09:06 <Samu> it's not declared, I'm unsure what he meant 00:09:41 <Samu> opf_ship.h does not have it 00:10:25 *** Wolf01 has quit IRC 00:12:04 *** Eddi|zuHause has quit IRC 00:13:33 *** Eddi|zuHause has joined #openttd 00:14:00 <Eddi|zuHause> weird... 00:14:06 <Eddi|zuHause> it seems to work 00:14:55 <Samu> there is no prototype 00:22:54 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhnYu 00:25:04 *** Thedarkb-T60 has joined #openttd 00:25:33 <DorpsGek_II> [OpenTTD/OpenTTD] nikolas opened pull request #7038: Fix: Remove duplicate town name "Huacho" https://git.io/fhnYg 00:25:47 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhnY2 00:26:23 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhnYV 00:27:19 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhnYw 00:30:58 *** Compu has joined #openttd 00:33:27 *** chomwitt has quit IRC 00:35:44 <Samu> _settings_game.pf.npf.maximum_go_to_depot_penalty 00:36:00 <Samu> they call it penalty 00:37:18 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhnYi 00:37:39 <Samu> I feel bad 00:38:20 <Samu> the nomenclature used by the other pathfinders, and even game settings, call it max_penalty 00:38:41 <Samu> why must opf be different? 00:39:46 <Samu> alright, i'll leave it as max_distance 00:45:30 <Samu> nooo, it makes no sense, it's driving me crazy! :( 01:11:32 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhZzm 01:11:52 <Samu> what the heck is wrong... 01:12:30 <Samu> i fail at rebases 01:13:49 *** Thedarkb-T60 has quit IRC 01:15:02 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhZzm 01:15:23 <Samu> rebases are the most complicated things I've ever had to deal with 01:27:01 *** Thedarkb-T60 has joined #openttd 01:30:49 <nnyby> lol 01:32:35 *** Progman has quit IRC 01:38:02 <nnyby> often when i'm doing a rebase it's simpler to just start with the new master, and re-apply the changes semi-manually 01:55:04 <DorpsGek_II> [OpenTTD/OpenTTD] James103 commented on pull request #7038: Fix: Remove duplicate town name "Huacho" https://git.io/fhnOr 02:00:19 *** Thedarkb-X40 has joined #openttd 02:00:24 <DorpsGek_II> [OpenTTD/OpenTTD] nikolas updated pull request #7038: Fix: Remove duplicate town name "Huacho" https://git.io/fhnYg 02:01:00 <milek7> https://xkcd.com/1597/ 02:01:46 <DorpsGek_II> [OpenTTD/OpenTTD] nikolas commented on pull request #7038: Fix: Remove duplicate town name "Huacho" https://git.io/fhnOo 02:04:47 *** Thedarkb-T60 has quit IRC 02:43:13 <Samu> framerates are not working properly peter1138 02:44:22 <Samu> https://github.com/OpenTTD/OpenTTD/commit/c693463c29f98f763cc4dd6346527262b34ff6ea i think it was this 02:45:26 <Samu> oh actually I don't know, there was a lot of changes in that camp 02:45:36 <Samu> one of them broke framerate window 02:49:55 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhZzm 03:33:24 <Samu> so i just sent 5000 ships to their depots 03:33:38 *** debdog has joined #openttd 03:35:06 <Samu> meh, i dont have a way to test it 03:35:21 <Samu> unreliable means 03:36:59 *** D-HUND has quit IRC 03:40:03 <Samu> @calc 21.234 - 35.812 03:40:04 <DorpsGek> Samu: -14.578 03:40:24 <Samu> OPF: 14,5 seconds hiccup when sending 5000 ships to depots 03:42:18 <Samu> @calc 37.875 - 52.345 03:42:18 <DorpsGek> Samu: -14.47 03:42:41 <Samu> NPF: 14,4 seconds hiccup when sending 5000 ships to depots 03:44:20 <Samu> @calc 10.640 - 13.390 03:44:20 <DorpsGek> Samu: -2.75 03:44:40 <Samu> YAPF: 2.7 seconds hiccup when sending 5000 ships to depots 03:45:20 <Samu> this is with my patch applied, forgot to mention 03:46:04 *** HerzogDeXtEr has joined #openttd 03:46:19 <Samu> honestly, I expected much worse for OPF, I'm kinda surprised, even though 14 seconds stalls are huuge 03:52:06 *** Samu has quit IRC 04:10:41 *** Smedles has quit IRC 04:13:49 *** Smedles has joined #openttd 04:53:39 *** Thedarkb-X40 has quit IRC 05:46:50 *** glx has quit IRC 05:52:14 *** Gja has joined #openttd 05:56:56 *** Gja has quit IRC 07:03:21 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth approved pull request #7038: Fix: Replace duplicate town name "Huacho" https://git.io/fhnsR 07:15:58 <DorpsGek_II> [OpenTTD/OpenTTD] btzy updated pull request #7028: Feature: Option to group vehicle list by shared orders https://git.io/fhGxd 07:16:58 *** andythenorth has joined #openttd 07:31:40 <planetmaker> moin 07:32:33 *** chomwitt has joined #openttd 07:33:16 <DorpsGek_II> [OpenTTD/OpenTTD] planetmaker merged pull request #7038: Fix: Replace duplicate town name "Huacho" https://git.io/fhnYg 07:38:25 *** sla_ro|master has joined #openttd 07:39:34 <andythenorth> moin 07:39:52 <andythenorth> if we keep merging, LordAro won't be able to finish the changelog....ever 07:39:57 <andythenorth> :) 07:41:20 <planetmaker> if *that* is our main concern, then I'm happy to have him shove that problem on the feet :P 07:42:19 <planetmaker> and that sentence no grammar 07:43:23 <planetmaker> also... we have our commit message style so that a script can make the changelog :P 07:44:27 <planetmaker> I rather accidentially setup my git repo such that it pulls the pull requests, too. But I find that surprisingly convenient 07:47:56 <andythenorth> no need to fetch the PR from upstream? 07:48:20 <planetmaker> yep. And I can quickly build them to actually check what it looks or feels like 07:48:54 <planetmaker> it's all just different branches in my OpenTTD.git 07:50:24 <planetmaker> https://paste.openttdcoop.org/px9lcajoc <-- a bit lengthy ... but who cares 07:58:38 <DorpsGek_II> [OpenTTD/OpenTTD] btzy opened issue #7039: In viewport.cpp at function UpdateViewportPosition(Window *w), what is the purpose of bool update_overlay? https://git.io/fhnGv 08:08:16 <DorpsGek_II> [OpenTTD/OpenTTD] btzy closed issue #7039: In viewport.cpp at function UpdateViewportPosition(Window *w), what is the purpose of bool update_overlay? https://git.io/fhnGv 08:23:59 <DorpsGek_II> [OpenTTD/OpenTTD] planetmaker commented on pull request #7003: Feature #6918: Add option to adjust font size separately from GUI size. https://git.io/fhnGk 08:58:09 *** debdog has quit IRC 08:59:10 *** nielsm has joined #openttd 09:10:45 <TrueBrain> and if you don't want to pull everything like planetmaker does, https://help.github.com/articles/checking-out-pull-requests-locally/ is a good way to do that :) 09:12:57 <andythenorth> so 09:13:08 <andythenorth> what visual effect for a zero-emissions hydrogen train? 09:13:10 <andythenorth> o_O 09:15:28 <TrueBrain> dead people where ever it passes through 09:15:50 <TrueBrain> it sends out a vibration that instantly rips open all your organs 09:15:51 <TrueBrain> really horrible 09:15:55 <TrueBrain> but, zero-emissions! 09:16:59 <Heiki> no effect normally, but a massive explosion when it breaks down 09:17:28 <SpComb> morbid 09:17:50 <Heiki> clearing at least 100 tiles around it in every direction 09:17:53 <andythenorth> rainbows? 09:18:11 <TrueBrain> unicorns! 09:18:31 <Heiki> 🌈 🌈 09:18:46 <SpComb> zero-emission unicorns fart rainbows, not unicorns 09:19:15 <TrueBrain> and if zero-emissions rainbows fart unicorns, we have infinite energy! 09:20:03 <andythenorth> assuming you can find the unicorn 09:20:11 <TrueBrain> and the rainbow, ofc 09:20:15 <andythenorth> it will be at the end of the rainbow 09:20:18 <andythenorth> just go there 09:20:23 *** Wolf01 has joined #openttd 09:20:24 <TrueBrain> okay ... so today I have to find back a 'changelog.sh' script that is on some server in some /root folder .. 09:20:27 <Wolf01> Moin 09:20:58 <TrueBrain> but in that script there should be some magic code that makes nice changelogs between nightlies 09:32:56 <TrueBrain> owh, that script mostly only works for subversion 09:32:57 <TrueBrain> DOH 09:33:01 <TrueBrain> owh well, something for later today :) 09:42:35 <LordAro> good moin 09:43:42 <nielsm> andythenorth just poopping out a trail of water as it travels 09:43:50 <andythenorth> bubles 09:43:53 <andythenorth> bubbles * 09:44:00 <andythenorth> there are some in toyland sprites 09:44:16 <nielsm> or really, some thin steam 09:45:06 *** Gabda has joined #openttd 09:45:18 <Gabda> o/ 09:45:31 <DorpsGek_II> [OpenTTD/OpenTTD] Gabda87 commented on pull request #7025: Add #6887: Option to show zone inside local authority boundary of towns https://git.io/fhnG1 09:47:16 <andythenorth> BBL etc 09:47:18 *** andythenorth has quit IRC 09:51:53 <DorpsGek_II> [OpenTTD/OpenTTD] Gabda87 updated pull request #7025: Add #6887: Option to show zone inside local authority boundary of towns https://git.io/fhsu0 10:12:26 <TrueBrain> how do I find which commit was done 7 days before the current HEAD 10:12:28 <TrueBrain> in git 10:14:55 <LordAro> --since 10:15:35 <LordAro> oh hey, it'll even do --since="1 week ago" 10:16:39 <TrueBrain> yes .. but that is from the current date 10:16:42 <TrueBrain> not from the HEAD date 10:16:56 <TrueBrain> and I am not willing to change my clock :D 10:17:01 <LordAro> ah 10:18:20 <LordAro> --since="somedate - 1 week" works as well 10:18:25 <LordAro> so just need to get the date of HEAD 10:19:15 *** debdog has joined #openttd 10:20:11 <TrueBrain> yeah .. 10:20:14 <TrueBrain> so we are going old-style 10:20:19 <TrueBrain> revdate=$(git log -1 --pretty=format:"%ci") 10:20:19 <TrueBrain> last_week=$(date -u -d "$revdate -7days" +"%Y-%m-%d %H:%M") 10:20:23 <TrueBrain> was hoping to avoid that :) 10:20:55 <LordAro> you can avoid most of that 10:20:57 <TrueBrain> hmm .. by default 'git log' shows the author date 10:21:03 <TrueBrain> which is often weird 10:21:07 <TrueBrain> should I just use commit date instead? 10:21:21 <LordAro> probably 10:21:28 <LordAro> given rebase/squash 10:22:00 <TrueBrain> and "most of that" is only the second line :P 10:22:07 <TrueBrain> so that is strictly seen 50% :P 10:22:09 <LordAro> well, yeah :p 10:22:15 <LordAro> it's longer than the first line 10:22:29 <TrueBrain> just less git-depending :) 10:22:33 <TrueBrain> (I copied this from the subversion script) 10:22:48 <TrueBrain> http://ftp.snt.utwente.nl/pub/games/openttd/binaries/nightlies/trunk/r28004/changelog.txt 10:22:51 <TrueBrain> this is what it used to be 10:22:56 <TrueBrain> do I want to match that 10:23:00 <TrueBrain> or just use git log --pretty=fuller 10:28:24 <TrueBrain> I think fuller is more than sufficient 10:30:09 <TrueBrain> LordAro: difference between 'zip' and 'zip -9' is huge 10:30:37 <TrueBrain> and of course it is better to spend some extra CPU cycles getting binaries smaller :) 10:31:38 <TrueBrain> if I remember correctly, it was bytes with the other compressions, but huge chunks with zip :P 10:32:48 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhnZO 10:38:02 *** synchris has joined #openttd 10:41:30 *** Progman has joined #openttd 10:51:34 *** nielsm has quit IRC 10:59:39 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE 10:59:47 <TrueBrain> hmm, that was unneeded 11:09:22 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhnZ6 12:06:29 <TrueBrain> "2019-01-12T12:05:25.6308700Z touch: illegal option -- d" 12:06:33 <TrueBrain> pffft @ Mac OS X! 12:08:27 <LordAro> TrueBrain: why do you want to get a week old commit, anyway? 12:17:32 <DorpsGek_II> [OpenTTD/OpenTTD] btzy opened pull request #7040: Fix: Round up deltas for smooth scrolling, so that target will eventually be reached https://git.io/fhnn8 12:18:33 *** Thedarkb-T60 has joined #openttd 12:27:18 <DorpsGek_II> [OpenTTD/OpenTTD] btzy updated pull request #7040: Fix: Round up deltas for smooth scrolling, so that target will eventually be reached https://git.io/fhnn8 12:45:36 <Eddi|zuHause> so it's illegal in MacOS land to touch d? 13:12:58 *** kgz has quit IRC 13:14:56 *** gelignite has joined #openttd 13:17:18 *** tokai|noir has joined #openttd 13:17:18 *** ChanServ sets mode: +v tokai|noir 13:20:19 *** Thedarkb-T60 has quit IRC 13:24:17 *** tokai has quit IRC 13:26:20 *** gelignite2nd has joined #openttd 13:32:07 *** gelignite has quit IRC 13:32:49 *** chomwitt has quit IRC 13:33:59 <DorpsGek_II> [OpenTTD/OpenTTD] btzy opened issue #7041: Cargo flow legend not fully redrawn when middle of station is moved https://git.io/fhncf 13:45:47 *** chomwitt has joined #openttd 13:51:54 <TrueBrain> LordAro: changelog.txt for nightlies are always the last 7 days 13:51:58 <TrueBrain> just to put something in there :) 13:52:09 <TrueBrain> so I dont want a week old commit, I want the log between them 13:52:22 <TrueBrain> and in git world, getting the commit and the log is the same thing :) 13:52:34 <LordAro> ah yeah 13:56:06 *** Thedarkb-T60 has joined #openttd 13:56:12 <TrueBrain> okay, I now have a released.txt, README.md and changelog.txt .. last one left: manifest.yaml .. which is a post-job 13:57:06 <TrueBrain> Also changed the way I fetch the source .. just once now, make a tarball, give that to all the other jobs 13:57:11 <TrueBrain> so we are sure we are building the same thing :D 13:59:36 *** kragniz has joined #openttd 14:00:29 <TrueBrain> so many Doxygen errors and warnings 14:01:22 <LordAro> pretty much all of them should just be to do with missing docs 14:01:40 <LordAro> at least they were a couple of months ago when i fixed all of them :p 14:02:07 <TrueBrain> no clue; just watched the long list passing by :D 14:06:15 *** glx has joined #openttd 14:06:15 *** ChanServ sets mode: +v glx 14:11:18 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE 14:16:49 *** Flygon has quit IRC 14:18:03 *** WWacko1976-work has joined #openttd 14:44:44 <DorpsGek_II> [OpenTTD/OpenTTD] btzy opened issue #7042: Use intrinsics for bit twiddling? https://git.io/fhnch 14:52:34 *** Samu has joined #openttd 14:56:42 <Gabda> is it normal that a road bridge is owned by 2 towns? 14:57:18 <Samu> really? that happens? 14:57:19 <Eddi|zuHause> owner or local authority? 14:57:24 <Eddi|zuHause> is a different thing 14:58:05 <Gabda> the 2 different ends has different owners and local authority 14:58:47 <TrueBrain> did they both pay for it? :P 14:59:04 <Gabda> i was looking for exotic town placements to understand how the local authority works on roads 14:59:24 <Samu> bt, I found a bug regarding town bridges, during world generation the code deletes towns that are generated with 0 population, but by doing so, nearby bridges are also removed 14:59:27 <Samu> btw* 14:59:43 <Eddi|zuHause> then maybe the code that assigns bridge ownership is wrong? 15:00:01 <Samu> those bridges didn't belong to the town being deleted 15:00:09 <Gabda> it is a world generated bridge 15:00:56 <Samu> it results in disconnected towns 15:01:24 <Samu> posted a few screenshots a few days ago, let me find them 15:03:06 <Samu> ah, here they are 15:03:06 <Samu> https://imgur.com/a/hqCAgsO 15:03:44 <Samu> chronologic order is, image at the top fist, then later on, image at the bottom 15:04:20 <Gabda> I pissed off one of the towns, so I couldn't demolish anything anymore, not even the bridge 15:04:42 <Eddi|zuHause> probably code that has opon founding a town take over ownership of nearby roads 15:04:52 <Eddi|zuHause> modulo grammar 15:04:54 <Gabda> but I could demolish it from the other side of the bridge :D 15:06:02 <Gabda> but the road continuing the bridge belongs to the first city again 15:06:47 <Gabda> like A city, B city, No owner, Road, Bridge 15:07:30 <Eddi|zuHause> other roads built after game start? 15:07:55 <Gabda> R R R R R B B B B B B B B B R R R R R 15:08:01 <Gabda> A A A A A A N N N N N N N B A A A A A 15:08:36 <Gabda> didn't play with the game, so I don't know that one 15:10:38 <Gabda> I think it doesn't have any effect on anything, I just found it funny enough to share :) 15:11:11 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #7042: Use intrinsics for bit twiddling? https://git.io/fhnCC 15:13:28 <peter1138> Morning 15:13:39 <peter1138> #7027 sounds interesting 15:15:08 <Samu> peter1138 hi, you broke framerate window recently, can u fix? was gonna use them to time ship pathfinders 15:15:32 <peter1138> -> report on github or it doesn't exist 15:15:51 <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z commented on issue #7042: Use intrinsics for bit twiddling? https://git.io/fhnC4 15:18:37 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick opened issue #7043: Disconnected towns during world generation https://git.io/fhnCg 15:19:12 <DorpsGek_II> [OpenTTD/OpenTTD] Gabda87 commented on pull request #7025: Add #6887: Option to show zone inside local authority boundary of towns https://git.io/fhnC2 15:21:15 <peter1138> Well there's some other windows I broke :p 15:21:25 <peter1138> Oh well, I'll fix. 15:21:41 <LordAro> are you suggesting that someone didn't review your PR well enough? 15:23:42 <Samu> do I really have to 15:23:45 <Samu> :( 15:24:23 <Gabda> So it is not normal that you have to close and open the framerate window to update the data? 15:24:42 <peter1138> OnTick is no longer called, but a couple of windows still have it :p 15:24:46 <peter1138> That's why it doesn't update. 15:24:54 <Gabda> I used that window for the first time today, and it was a little odd. 15:27:49 <peter1138> Heh 15:31:19 *** Wormnest has joined #openttd 15:34:58 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #6926: Change: Allow dock to be constructed in more locations https://git.io/fhnCx 15:37:39 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick dismissed a review for pull request #6927: Change: Forbid dock placement on docking area https://git.io/fxptD 15:37:40 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #6927: Change: Forbid dock placement on docking area https://git.io/fhnCh 15:39:11 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #6933: Fix #6233: Improve lock pricing and infrastructure counting, to achieve better consistency https://git.io/fhnWe 15:39:49 <Samu> dismissed? 15:39:59 <Samu> i'm only refreshing 15:43:14 *** gelignite2nd has quit IRC 15:43:31 <LordAro> Samu: you could also say it was "invalidated" 15:43:53 <Samu> Falling back to patching base and 3-way merge... 15:43:59 <Samu> i had a weird rebase 15:44:04 <Samu> what does that mean? 15:44:22 *** andythenorth has joined #openttd 15:44:40 <andythenorth> no but seriously 15:44:42 <andythenorth> rainbows 15:44:59 <TrueBrain> welcome back andythenorth 15:45:05 <andythenorth> what changed? 15:45:21 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #6935: Add: EnsureNoShipFromDiagDirs https://git.io/fxno7 15:45:35 <Samu> whatever 15:45:46 <DorpsGek_II> [OpenTTD/OpenTTD] btzy commented on issue #7042: Use intrinsics for bit twiddling? https://git.io/fhnWL 15:45:48 <Samu> if something's wrong, i hope i know it 15:45:58 <Samu> from azure pipeliner dude 15:48:13 <andythenorth> TrueBrain: today is the deadline you set for removing stale issues 15:48:17 <andythenorth> so I will be doing that 15:48:27 <andythenorth> anyone want to save any more FS patches? :) 15:48:32 <TrueBrain> blame me, fine :P 15:49:23 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep opened pull request #7044: Codechange: Define INVALID_TOWN as a TownID. https://git.io/fhnW3 15:49:24 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #6925: Fix #6574 #6636 #5405 #6493: Aircraft hangar issues https://git.io/fpJfr 15:51:05 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #7044: Codechange: Define INVALID_TOWN as a TownID. https://git.io/fhnWc 15:52:57 <LordAro> andythenorth: i've not had chance to look through them yet, gimme a few more hours? 15:52:59 *** Thedarkb-T60 has quit IRC 15:53:12 <andythenorth> sure 15:53:24 <TrueBrain> only approved? Not even merged? 15:53:27 <TrueBrain> :P 15:53:34 <LordAro> CI hadn't finished :p 15:53:37 <TrueBrain> :D 15:53:38 <andythenorth> LordAro: https://github.com/OpenTTD/OpenTTD/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3A%22patch+from+FlySpray%22+label%3A%22stale%22+ 15:53:42 <andythenorth> 35 15:53:45 <TrueBrain> going for quickest PR of th week, I guess 15:54:03 <andythenorth> ^^^ pretty mixed batch 15:54:20 <Samu> how do i quote code on gitgub :( 15:54:21 <andythenorth> I already picked out some where I recognise the author, it's had prior review etc 15:54:31 <andythenorth> also the ones where it's not politics whether it's merged or not 15:55:04 <Samu> andythenorth I wanna reply to you but i fail at quoting code 15:55:13 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6927: Change: Forbid dock placement on docking area https://git.io/fhnW8 15:55:48 <andythenorth> Samu: "yes" / "no" would be enough :) 15:56:13 <Samu> ah, found it 15:56:25 <Samu> https://github.com/OpenTTD/OpenTTD/pull/6927/files#r230102973 15:56:40 <andythenorth> for saving FS patches, the ones that are easy to test are also preferable 15:57:08 <andythenorth> e.g. timetable stuff is a fricking tarpit to test 15:57:20 <Samu> it's hidden 15:57:26 <Samu> it's a resolved converstation thing 15:57:46 <andythenorth> I like this one https://bugs.openttd.org/task/5735/getfile/9334/new-signal-gui.png 15:57:51 <andythenorth> https://github.com/OpenTTD/OpenTTD/issues/5735 15:58:22 <TrueBrain> 15 minutes between attempts for the final pieces of the release pipeline .. this is annoyingly slow :D 15:58:36 <Samu> https://github.com/OpenTTD/OpenTTD/pull/6927/files#r230428556 ... damn it, im not getting the correct link 15:58:41 <andythenorth> very cycle time 15:58:43 <andythenorth> such slow 15:58:45 <andythenorth> much annoy 15:59:39 <Samu> andythenorth you have to click to show "This conversation was marked as resolved by nielsmh 15:59:39 <Samu> Show conversation " 15:59:47 <Samu> I answered there 16:00:11 <DorpsGek_II> [OpenTTD/OpenTTD] Gabda87 commented on pull request #7025: Add #6887: Option to show zone inside local authority boundary of towns https://git.io/fhnWu 16:04:25 <Samu> oh no, build errors 16:05:28 <Samu> somebody ruined my patch 16:05:43 <Samu> whoever made the airport tile check 16:06:51 <Samu> the rebase wasn't clear, it only said something weird about 3-way merge 16:07:09 <Gabda> does the codebase have a function that loops over all the tiles that are within a certain (manhattan) distance from a source tile? 16:07:48 <TrueBrain> plenty of variants :D 16:09:33 <Samu> he renamed tile_cur to tile_iter 16:09:38 <Samu> interesting 16:09:51 <Samu> now I understand the importance of keeping the same variable names 16:11:35 <Gabda> TrueBrain: can you give a hint on the name, of the file they are defined in? 16:11:58 <Samu> https://github.com/OpenTTD/OpenTTD/commit/06cd561cea26c41553b7a6b327a7ac1fbdea23d2 16:12:17 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep opened pull request #7045: Codechange #5859: Simplify CheckTrainStayInDepot(). https://git.io/fhnWi 16:13:51 <TrueBrain> Gabda: I wish I knew :D Havent touched the code in 10+ years :P 16:13:54 <TrueBrain> sorry for not being helpful 16:14:07 <TrueBrain> pretty sure that if you open any _cmd file you will find plenty 16:14:42 <TrueBrain> https://github.com/OpenTTD/OpenTTD/blob/master/src/station_cmd.cpp#L107 16:14:43 <Gabda> I found a search patter for it, I hope "#define FOR_" will help me :) 16:15:14 <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z commented on issue #7042: Use intrinsics for bit twiddling? https://git.io/fhnWP 16:15:51 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on issue #6476: Suggested changes for pathfinding for automatic servicing https://git.io/fhnWX 16:16:14 <Gabda> this AddWrap can be interesting, thanks :) 16:16:34 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6476: Suggested changes for pathfinding for automatic servicing https://git.io/fhnWD 16:16:35 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6476: Suggested changes for pathfinding for automatic servicing https://git.io/fhnWy 16:17:14 *** Mahjong has quit IRC 16:17:37 *** Mahjong has joined #openttd 16:20:03 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep commented on issue #5978: Autoreplace window isn't updated after group hierarchy changes https://git.io/fhnW9 16:20:35 <andythenorth> 'Hydrogen' or 'Fuel Cell' 16:20:42 <andythenorth> Pikka did 'Fuel Cell' in UKRS 16:20:47 <andythenorth> I never used them, dunno why 16:21:06 <TrueBrain> https://www.tt-forums.net/viewtopic.php?f=33&t=84609 <- I changed the topic 16:21:12 <TrueBrain> got annoyed by "security vuln" 16:21:15 <TrueBrain> it is not 16:21:26 <andythenorth> fanks 16:21:29 <andythenorth> triggered me ;P 16:22:00 <TrueBrain> yeah ... me too 16:22:35 <andythenorth> hmm novely train power doesn't really work 16:22:42 <andythenorth> Steam | Diesel | Electric 16:22:48 <andythenorth> stick to the knowns :P 16:23:05 <Samu> EnsureNoShipFromDiagDir, basically makes ship size appears like they're 3 tile-wide 16:23:09 <andythenorth> Fuel Cell, Hydrogen, Electro-diesel, Battery, not so good for ottd 16:23:16 <Eddi|zuHause> fuel cell is just a variation on diesel? 16:23:24 <andythenorth> hydrogen usually 16:23:30 <andythenorth> reverse electrolysis or something 16:23:35 * andythenorth chemically vague ;P 16:23:37 <Eddi|zuHause> i mean in terms of game mechanics 16:23:40 <andythenorth> yes 16:23:43 <andythenorth> it's just words 16:23:49 <andythenorth> and remove the visual effect 16:23:51 <Eddi|zuHause> just make fuel cell the diesel of 2020+ 16:24:01 <andythenorth> the problem is that I like the rolling coal smoke effect :P 16:24:09 <andythenorth> and we don't have rainbows 16:24:21 <Eddi|zuHause> just like the switch from steam to diesel 16:24:28 <Eddi|zuHause> switch from diesel to fuel cell 16:24:31 <Eddi|zuHause> at a certain year 16:24:42 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE 16:24:51 <TrueBrain> now with a Manifest! :D 16:25:54 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhnWp 16:26:21 <TrueBrain> https://dev.azure.com/truebrain/OpenTTD/_build/results?buildId=223 <- who can test the MacOS binaries for me? Specifically, if the version ingame is the same as the name of that build? 16:26:45 * andythenorth whistles innocently 16:26:47 <andythenorth> who indeed? 16:27:04 <andythenorth> you could just highlight me :P 16:27:18 <TrueBrain> you didnt do the last round of testing :) 16:27:28 <TrueBrain> we have more MacOS users these days helping out! 16:27:30 <TrueBrain> YOU ARE NOT SPECIAL 16:27:31 <TrueBrain> :D 16:27:47 <peter1138> Oops, I fell asleep o_O 16:28:09 <Samu> who's a git command line expert? https://paste.openttdcoop.org/prkv7boyh 16:28:11 <andythenorth> of course I'm special 16:28:14 <Samu> what happened there? 16:28:15 <andythenorth> I have a fruit on my computer 16:28:23 <andythenorth> think of how important that makes me 16:28:25 <TrueBrain> hmm ... fruit ... 16:29:15 <andythenorth> version # from azure 20190112-azure_release2-g7ba4856b 16:29:28 <andythenorth> version # in the binary package 20190112-azure_release2-g7ba4856b 16:29:41 <TrueBrain> ingame too? 16:30:15 <andythenorth> version # ingame: 20190112-azure_release2-g7ba4856b 16:30:20 <TrueBrain> sweet 16:30:20 <andythenorth> in all the many places 16:30:23 <TrueBrain> thank you! 16:30:48 <TrueBrain> nearly done :D 16:34:43 <andythenorth> Eddi|zuHause: switching at a certain point was my plan, but it's meaningless in-game, except for the loss of effects :P 16:34:52 <Eddi|zuHause> so? 16:35:00 <Eddi|zuHause> lots of things are meaningless 16:35:15 <andythenorth> so what effect can I abuse? 16:36:05 <andythenorth> there's some white vapour industry smoke 16:37:12 <andythenorth> think it's too big 16:38:44 <Gabda> Samu something happened that shouldn't have? 16:39:40 <Gabda> it seems like there was no merge conflict 16:43:24 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE 16:44:05 <andythenorth> so can we use the topology of the cargo graph as a factor in town pax generation? 16:44:36 <andythenorth> somewhat IRL, number of nodes in the network is a factor in pax numbers 16:44:59 <andythenorth> I think we can re-interpret that to a game world, in a way that is fun 16:45:29 <andythenorth> it doesn't have to be realistic, nor scale perfectly 16:46:30 <Samu> there was no conflict detected, but there was a problem, someone made changes to airport tile iterator and renamed a variable name which made my patch fail to pass the test on azure pipeliner 16:46:47 <Samu> now i wonder if there were more problems 16:48:25 <peter1138> Well, did you not actually compile it yourself? 16:48:30 <Samu> no 16:48:36 <peter1138> That's your first mistake. 16:48:42 <Samu> because rebase 99% never fail 16:48:49 <Samu> but fail 16:49:34 <Xaroth> Isn't the idiom "Compile before comitting/submitting" ? 16:50:03 <andythenorth> 99% of my failures are due to not compiling before commit 16:50:03 <Samu> I didn't make any change 16:50:13 <Xaroth> irrelevant 16:50:17 <Samu> i only put everything up to date 16:50:23 <andythenorth> ^^ that is complete lies, 99% of my failures are due to not using 'hg add' 16:50:43 <Samu> somebody renamed tile_cur to tile_iter 16:50:47 <Samu> that made it fail 16:51:02 <Samu> the rebase didn't mention any conflict 16:51:16 <Xaroth> Rebasing has little to do with checking the validity of your code 16:51:20 <andythenorth> thre is no conflict there 16:51:23 <Xaroth> only that changes can be applied one atop of another. 16:52:11 <Xaroth> If you assume that if a rebase works, that your changes will work as well, you're in for a lot of hurt :P 16:52:13 <TrueBrain> wait, there is no magic rabbit? AWH! 16:52:21 <Samu> t.t 16:52:42 * andythenorth reading ground_vehicle.cmd for acceleration 16:52:46 <Samu> so it's my fault, not the fault of the other guy? 16:52:49 <Xaroth> yes 16:52:53 <andythenorth> I've been testing, would kind of like a gearing concept 16:52:54 <Samu> oki :| 16:52:58 <Xaroth> well, maybe not fault 16:53:01 <Xaroth> but responsibility 16:53:44 <Samu> rebases are too complicated for my underttanding 16:53:48 <Xaroth> this problem isn't intrinsic to git, it's a common workflow in any programming collaboration 16:54:01 <Xaroth> nor is it inherent to rebases only :) 16:54:26 <Xaroth> if you have a patch set (plain old diff patches), and upstream something changes, your patch will fail to run, just like with this 16:55:26 <LordAro> TrueBrain: https://dev.azure.com/openttd/OpenTTD/_build/results?buildId=236 well that's even weirder 16:55:47 <TrueBrain> LordAro: no, that sadly is more common than I would like 16:55:53 <TrueBrain> Docker Hub is really terrible in availability 16:55:57 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #7035: Add: Mexican Peso currency https://git.io/fhnlu 16:55:58 <TrueBrain> I cannot understand that it is .. but it is 16:56:46 <LordAro> remind me, does anyone care either way wrt rebase vs squash? 16:57:07 <TrueBrain> squash is there to make it easier to squash in case someone didnt rebase, but merged/added to his PR 16:57:11 <TrueBrain> which is a fine workflow 16:57:18 <TrueBrain> rebase is the easiest in most cases 16:57:26 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro merged pull request #7035: Add: Mexican Peso currency https://git.io/fhZFR 16:57:29 <LordAro> that's what i thought 16:57:31 <TrueBrain> I squash 1 commit PRs often so the PR number gets added 16:57:46 <TrueBrain> so what-ever .. just don't squash if the individual commits are useful 16:58:46 <LordAro> :+1: 16:58:53 <TrueBrain> ? 16:58:57 <Xaroth> This isn't slack :P 16:59:00 <LordAro> (y) 16:59:06 <TrueBrain> we are moving to slack? 16:59:09 <TrueBrain> cool! :D 16:59:13 <LordAro> dammit 16:59:16 <TrueBrain> retrigged the job LordAro 16:59:25 <TrueBrain> I really want to move away from Docker Hub 16:59:27 <TrueBrain> not sure how yet 16:59:37 <TrueBrain> setting up our own registry, possibly 16:59:45 * andythenorth read how max_te is used 16:59:48 <LordAro> mm, probably 17:00:02 <andythenorth> practically, testing in-game with hills, TE makes piss all difference to trains 17:00:12 <andythenorth> only HP is relevant to acceleration 17:01:41 <andythenorth> fwiw, I'm not looking for realism, I'm looking for performance variation in vehicles :P 17:02:15 *** snail_UES_ has joined #openttd 17:02:18 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro requested changes for pull request #7040: Fix: Round up deltas for smooth scrolling, so that target will eventually be reached https://git.io/fhnl2 17:03:47 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #7045: Codechange #5859: Simplify CheckTrainStayInDepot(). https://git.io/fhnla 17:04:06 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro merged pull request #7045: Codechange #5859: Simplify CheckTrainStayInDepot(). https://git.io/fhnWi 17:04:09 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE 17:04:15 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro closed issue #5859: Calling VehicleEnterDepot for a train frees the reservation of the depot https://git.io/fhnlw 17:07:26 <LordAro> TrueBrain: https://dev.azure.com/truebrain/OpenTTD/_build/results?buildId=223 why is it that linux is "skipped" but none of the others are? something to do with "part of the docker image" ? 17:07:47 <TrueBrain> LordAro: read the pipeline :D 17:07:56 <LordAro> :< 17:07:58 <TrueBrain> # If this is false, not all targets are triggered. For example: 17:07:59 <TrueBrain> # both the NSIS installer for Windows and the creation of debs only work 17:07:59 <TrueBrain> # for releases. Not for any other type of binary. 17:08:12 <TrueBrain> Azure Pipelines doesn't allow giving reasons WHY something is skipped 17:08:37 <LordAro> ah right 17:08:50 <TrueBrain> I wish I could make it more clear, but there isn't really .. 17:08:51 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #6935: Add: EnsureNoShipFromDiagDirs https://git.io/fxno7 17:09:10 <LordAro> and because the linux build does so little as part of the pipeline (as opposed to in the docker image), it means it looks like the whole linux build was skipped? 17:10:51 *** frosch123 has joined #openttd 17:11:10 <LordAro> also 245 build is completely different to 223 anyway :> 17:11:12 <LordAro> quak 17:11:15 <TrueBrain> LordAro: I can make it skip steps, instead of jobs, if that helps 17:11:33 <TrueBrain> there is no build 245 17:11:55 <LordAro> https://dev.azure.com/openttd/OpenTTD/_build/results?buildId=245 beg to differ 17:12:04 <TrueBrain> yes; check the URL :) 17:12:10 <TrueBrain> 2 completely different projects :P 17:12:16 <LordAro> oh, bleh 17:12:23 <TrueBrain> and of course, that 245 is the CI 17:12:26 <TrueBrain> has nothing to do with releases :) 17:12:40 <Gabda> can I have two PR-s with the same commit msg? 17:12:44 <TrueBrain> https://dev.azure.com/truebrain/OpenTTD/_build/results?buildId=226 <- for example a release build 17:13:13 <LordAro> Gabda: no reason why not, but.. why? 17:13:38 <TrueBrain> LordAro: basically, it skips the 'linux', as all those targets will not be able to build a release. I can also skip them after expansion I guess .. but it still is vague 17:13:43 <TrueBrain> I can make two pipelines 17:13:48 <TrueBrain> but that is a lot of duplication 17:14:11 <LordAro> mm 17:14:22 <LordAro> wait, there is no linux build in 223? 17:14:24 <LordAro> i'm confused 17:14:28 <Gabda> I made a fundamentally different approach for a problem, and I want them reviewed separately 17:14:42 <TrueBrain> LordAro: you should be; you were going to make me a linux build that is generic :D 17:14:53 <LordAro> oh right, and you took that out for now? 17:14:59 <TrueBrain> yes; it was broken 17:15:06 <TrueBrain> so no generic linux builds for now :) 17:15:14 <LordAro> shame, but ok 17:15:34 <TrueBrain> I am hoping someone comes up with a good way to make generic linux builds :) 17:15:47 <TrueBrain> can even be a .deb :P 17:15:52 <TrueBrain> but currently debs only really work for releases 17:15:57 <LordAro> Gabda: should probably put something in the PR title to show that its different. commit messages can be the same though 17:16:13 <TrueBrain> over time I hope we get Steam releases too, for nightlies .. but .. lets just do the bare minimum first :) 17:16:30 <TrueBrain> no need to build a complete castle first 17:16:35 <TrueBrain> I am happy with a house :) 17:16:52 <andythenorth> both these trains started at the same time https://dev.openttdcoop.org/attachments/download/9239/TE_vs_HP.png 17:16:59 <andythenorth> pretty similar weight and HP 17:17:02 <Gabda> I thought PR title is the first line of the commit msg. I set it when make a PR, of after that? 17:17:05 <TrueBrain> LordAro: if you click on the Linux (skipped), and than the (!), it shows why it was skipped btw 17:17:11 <Gabda> *Can I set it... 17:17:31 <LordAro> Gabda: both :) 17:17:52 <LordAro> PR title is mostly unconnected with the commit messages 17:17:56 <LordAro> unless the PR gets squashed 17:18:09 <LordAro> but then whoever's squashing can review the message anyway 17:18:37 <Gabda> ok, thanks 17:19:07 <DorpsGek_II> [OpenTTD/OpenTTD] J0anJosep opened pull request #7046: Fix #5978: Update some stats and lists caused by group hierarchy. (3298 and Juanjo) https://git.io/fhnlj 17:20:14 <peter1138> Hmm, I wonder when the OnTick of a dropdown list happens. 17:20:18 <andythenorth> for the first time in years #openttd.dev might be useful :P 17:20:19 <TrueBrain> meh; seems we are not the only one with docker hub issues .. meh 17:20:31 <peter1138> Something to do with scrolling, but it seems to scroll fine without it;. 17:20:45 <peter1138> andythenorth, this is where we dev 17:20:54 <andythenorth> isn't it 17:21:29 <TrueBrain> LordAro: would it help if I call it "Linux (Stable)" .. meaning it would resolve to "Linux (Stable) linux-ubuntu-xenial-i386-gcc" when not skipped 17:22:52 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE 17:23:24 <TrueBrain> "Linux (Stable only)" 17:23:24 <TrueBrain> hmm 17:23:41 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE 17:24:32 <TrueBrain> https://dev.azure.com/truebrain/OpenTTD/_build/results?buildId=228 17:24:35 <TrueBrain> looks better, I guess 17:25:02 <TrueBrain> but two pipelines might be better 17:25:31 <TrueBrain> hmm, yes, that would make other things easier too I guess 17:26:06 <TrueBrain> first, food 17:28:10 <Samu> looks like i have nothing more to refresh 17:31:50 <Samu> yesterday night I sent 5000 ships to depots 17:32:09 <Samu> the yapf result was surprisingly good 17:32:20 <Samu> a stall of 2.7 seconds 17:33:14 <Samu> which makes me wonder if my implementation was actually working 17:33:23 <Samu> better recheck 17:39:47 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhn8h 17:44:04 *** Gja has joined #openttd 17:54:42 <Samu> forbid 90 degs improve pathfinder times 17:55:11 <peter1138> Let options to try. 17:58:51 <Samu> something that juanjo has done was the removal of water tracks if the adjacent tiles were land 17:59:16 <DorpsGek_II> [OpenTTD/OpenTTD] Gabda87 opened pull request #7047: Add #6887: Highlight tiles within local authority of towns https://git.io/fhn44 17:59:17 <Samu> wondering if that could be implemented on the real openttd 18:01:04 <Samu> it would break savegame compatibility 18:01:35 <Samu> so I guess not 18:02:16 *** Thedarkb-T60 has joined #openttd 18:03:22 <Samu> maybe it could be implemented for pathfinders decision logic? 18:03:51 <peter1138> One way to improve ship pathfinding: explicit ship tracks. 18:04:32 <peter1138> Then it would be similar in performance to trains. 18:04:52 <peter1138> I wonder if implicit-semi-explicit could work. 18:08:51 <andythenorth> can we implicitly lay some? 18:08:56 <andythenorth> when orders are created? 18:09:46 <andythenorth> lay track bits in water tiles? 18:09:52 <andythenorth> then pathfinding is 'next tile' 18:10:02 * andythenorth wavey hands 18:14:09 <peter1138> Quite 18:14:54 <andythenorth> 'auto track maker' 18:15:19 *** Thedarkb1-T60 has joined #openttd 18:17:07 <Samu> strange, I have all 5000 ships stopped in depots but the framerate still registers ship tick activity 18:17:58 <peter1138> Could it be that checking 5000 ships to see if they are stopped costs CPU time? 18:18:26 <Samu> averaging 0.55 ms 18:19:32 <Samu> maybe it's doing some other type of checks, not just pathfinder 18:19:45 <Samu> dont know how this was implemented 18:21:52 *** Thedarkb-T60 has quit IRC 18:22:08 <Samu> just started 5000 ships with opf, about 4100 ms spike 18:22:29 <Samu> the number disappears too fast 18:23:05 <Samu> too spiky atm 18:23:37 <peter1138> Hmm, should I double my RAM to 64GB? 18:23:45 <peter1138> And then add a few uint64s to the map array :D 18:24:15 <Samu> https://imgur.com/OzkHlB5 18:25:23 *** Thedarkb1-T60 has quit IRC 18:27:25 <andythenorth> peter1138: free RAM with every OpenTTD download 18:27:31 <andythenorth> send us a coupon, we mail it out 18:27:31 <peter1138> RAM Doubler 18:30:35 <Samu> lets see how many opf ships get lost when sending them to depot 18:34:22 <Samu> going to compare the result with how many opf ships get lost when sending them to depot on 1.8.0 18:35:33 <andythenorth> can I name a train Hermes? 18:35:41 <andythenorth> or does it sound like a courier company? :P 18:41:59 <Samu> 26 ships lost with my implementation 18:42:05 <Samu> out of 5000 18:42:50 <Samu> for opf 18:46:50 <Samu> 52 ships lost for opf in 1.8.0, out of 5000 18:47:12 <Samu> next is npf 18:49:55 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5978: Autoreplace window isn't updated after group hierarchy changes https://git.io/fhnB3 18:54:20 <TrueBrain> "WARNING: Url has SSL/TLS available, switching to HTTPS for download" <- how is that a warning? 18:59:19 <Samu> 4 ships lost for npf in my implementation, out of 5000 18:59:45 <Samu> 7 ships lost for npf in 1.8.0, out of 5000 19:00:04 <Samu> something's wrong, I was expecting 0 19:00:12 <Samu> but ok, will investigate later 19:00:17 <Samu> next is yapf 19:02:53 *** snail_UES_ has quit IRC 19:03:43 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE 19:03:57 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhGSE 19:04:07 <TrueBrain> LordAro: this should fix most of the confusion, I hope :) Lemme know :) 19:04:30 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7027: Add: [AzurePipeline] introducing a release pipeline https://git.io/fhnBg 19:04:59 <Samu> wow, yapf is really good 19:05:12 <Samu> 0 ships lost for yapf in my implementation, out of 5000 19:05:21 <Samu> 0 ships lot for yapf in 1.8.0, out of 5000 19:05:24 <Samu> lost* 19:05:35 <LordAro> we call that "actually works" 19:05:46 <LordAro> TrueBrain: cool, will take a look 19:05:54 <LordAro> but first, some food 19:06:25 <TrueBrain> no rush 19:07:52 <andythenorth> oof, some projects might have quietly deleted the old pathfinders 19:08:01 <andythenorth> mumble mumble savegames 19:08:28 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN opened pull request #7048: Fix #6780: Some windows didn't get updated from OnTick() https://git.io/fhnBV 19:09:01 <TrueBrain> we still have multiple PFs? Silly :D 19:09:13 <andythenorth> you know why :P 19:09:15 <peter1138> TrueBrain, yes :( 19:09:30 <andythenorth> the terrible even might happen 19:09:38 <andythenorth> one person might post something rude in the forums 19:09:44 <andythenorth> event * 19:10:10 <andythenorth> also the only person here who seems to like scorched earth 19:10:11 <andythenorth> is andythenorth 19:10:24 <Samu> must investigate why npf is failing 19:10:34 <peter1138> Delete it. 19:10:38 <TrueBrain> andythenorth: I honestly don't know why it still is in there 19:10:47 <andythenorth> TrueBrain: I posted the reason above 19:10:47 <TrueBrain> I know 10 years ago it was a hot thing to even talk about 19:10:49 <TrueBrain> but ... 10 years :P 19:10:49 <peter1138> I like scorched earth. 19:10:59 <andythenorth> it's the fear that someone has a saved game 19:11:07 <Samu> it's failing even in 1.8.0 19:11:08 <andythenorth> and makes a post questioning the decision 19:11:10 <TrueBrain> so start a deprecation! :P 19:11:16 <andythenorth> remember depot-flip controversy? 19:11:19 <TrueBrain> no 19:11:21 <peter1138> But... I played it about, hmm, 25-30 years ago? 19:11:22 <andythenorth> the only feature that was ever removed 19:11:34 <TrueBrain> you could flip depots? :P 19:11:41 <andythenorth> you could flip trains in depots 19:11:43 <TrueBrain> or was that what that AI did and made massive amounts of money 19:11:44 <TrueBrain> ah :) 19:11:48 <andythenorth> it was / is broken for newgrf vehicles 19:11:52 <andythenorth> so it was removed 19:11:52 <TrueBrain> that clearly was abuse/bug :) 19:11:55 <andythenorth> mega rage quits 19:11:58 <andythenorth> such woe 19:12:28 <TrueBrain> I love that an AI author found out it was better to have trains do one-ways (and sell/buy constantly) 19:12:31 <andythenorth> wait until I delete 'Extreme' in FIRS 4 :P 19:12:38 <andythenorth> then we'll see woe 19:13:09 <TrueBrain> okay, building nightlies seems to be in good order 19:13:17 <TrueBrain> just needs a CDN to publish the binaries on 19:13:27 <andythenorth> they would build faster 19:13:28 <andythenorth> and be smaller 19:13:30 <TrueBrain> and .. then we need to get the new website online :) 19:13:33 <TrueBrain> sadly, 0 contributions :( 19:13:34 <andythenorth> if they had fewer pathfinders 19:14:08 <TrueBrain> https://github.com/OpenTTD/website/issues <- still 3 things we need fixing 19:14:40 <andythenorth> I can do https://github.com/OpenTTD/website/issues/11 if no-one else can be arsed to 19:14:52 <andythenorth> probably can't do this well https://github.com/OpenTTD/website/issues/10 19:15:00 <TrueBrain> I was hoping putting the issues there would attract a few people more helping out :P 19:15:38 *** Gja has quit IRC 19:15:39 <TrueBrain> https://github.com/OpenTTD/website/issues/13 I really need to fix myself I guess :) 19:15:50 <andythenorth> kinda 19:16:02 <andythenorth> LA is also busy reviewing stuff 19:16:10 <TrueBrain> yeah :D 19:16:14 <andythenorth> and making some kind of changelog 19:17:17 <TrueBrain> hmm .. when I move everything to a DO CDN, I increase the montly bill with 30 dollars .. 19:17:27 <TrueBrain> in return I no longer have to maintain this custom mirror stuff :P 19:17:27 <andythenorth> what are our funds? :P 19:17:38 <TrueBrain> I have been told I have nothing to worry about 19:17:49 <andythenorth> I have NFI what the money situation is 19:18:08 <TrueBrain> the one thing we are not really open about; not sure why not 19:18:20 <andythenorth> because people can be weird about money? 19:18:22 <TrueBrain> something down the line to look at, I guess 19:18:36 <TrueBrain> yeah .. especially salaries :D 19:18:53 <TrueBrain> anyway, I believe that if we had no donations, we could still run our infrastructure for several years, or something 19:19:07 <TrueBrain> but people are kind enough to still donate 19:19:16 <Samu> aha, I see what's wrong 19:19:40 <TrueBrain> people are awesome like that 19:20:03 <Samu> it's turning an automatic service order to an unreachable depot into a manual order to stop at the same unreachable depot, instead of computing another 19:20:17 <Samu> searching for another 19:20:45 <Samu> and there really is a depot just 10 tiles away 19:20:49 <Samu> :( 19:20:54 <Samu> reachable 19:21:41 <Samu> where in the code are automatic service orders changed to manual 19:24:20 <peter1138> Hmm 19:24:36 <peter1138> My PR failed CI. Github issue or something I did? 19:25:02 <peter1138> Oh right. Commit message wrong. Hmm. 19:25:20 <peter1138> Haha old style -Fix :p 19:25:39 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7048: Fix #6780: Some windows didn't get updated from OnTick() https://git.io/fhnBV 19:26:06 <peter1138> Unable to find image 'openttd/compile-farm-ci:commit-checker' locally 19:26:12 <peter1138> ^ That kinda confused me :p 19:26:20 <TrueBrain> fix it and make a PR :D 19:26:34 <peter1138> I'm gonna fix dinner firsty. 19:26:37 <peter1138> FIRSTY 19:27:35 <TrueBrain> Docker really is not the best piece of software out there :( 19:27:41 <TrueBrain> the CLI is so freakinglish inconsistent 19:32:04 <andythenorth> secondy 19:32:06 <andythenorth> dinner 19:37:06 <Samu> i found the problem 19:37:07 <Samu> https://github.com/OpenTTD/OpenTTD/blob/master/src/vehicle.cpp#L2299 19:37:21 <Samu> the same depot happens to be unreachable 19:37:27 <Samu> what can I do? 19:37:35 <Samu> it doesn't even check with pathfinder 19:37:39 <Samu> it's skipped 19:40:47 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro requested changes for pull request #7048: Fix #6780: Some windows didn't get updated from OnTick() https://git.io/fhnB7 19:41:10 <Eddi|zuHause> what's wrong with youtube? trying to show me videos such as "why are british trains so bad" and "why is DB so bad"? 19:43:31 <andythenorth> Eddi|zuHause: "why are british trains so bad" is being highly recommended to me also 19:43:33 <andythenorth> are you me? 19:45:57 <Wolf01> Meh, I finished the robotic arm and configured the sbrick profile with the controls (with icons too!) now I have *ache, put any body part in place of * and you'll guess right... 19:46:53 <Wolf01> Youtube for me only suggests lego, spacex, and numberphile 19:55:27 <Eddi|zuHause> i've been subscribed to numberphile for years 20:00:49 <frosch123> do you want links to ruin your suggestions? 20:01:49 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7048: Fix #6780: Some windows didn't get updated from OnTick() https://git.io/fhnBV 20:01:55 *** nielsm has joined #openttd 20:02:16 <peter1138> LordAro, such a noob ;( 20:02:22 <LordAro> :p 20:04:30 <LordAro> peter1138: given you actually know stuff about the map array, do you think you could offer your thoughts on #7047? 20:04:50 *** Thedarkb1-T60 has joined #openttd 20:05:36 *** synchris has quit IRC 20:06:58 <TrueBrain> hmm .. so Sentry manual suggests to commit the sentry_sdk.init URL in your VCS 20:07:05 <TrueBrain> but that means anyone can report issues on that project .. 20:07:11 <TrueBrain> is it me, or does that sound strange 20:09:02 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7047: Add #6887: Highlight tiles within local authority of towns https://git.io/fhnR1 20:10:06 <peter1138> Oh.. 20:11:39 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7047: Add #6887: Highlight tiles within local authority of towns https://git.io/fhnRD 20:12:10 <LordAro> TrueBrain: depends what you want to achieve, i guess. the other project i know uses an environment variable when running. ...but that's because it's a single instance of an irc bot and rather easier to constrain access to it 20:12:46 <TrueBrain> if I want to achieve people being asses and submit all kinds of bugs via the public DSN, I should put it in git yes :P 20:12:49 <andythenorth> usually Sentry would be in a less open source env? 20:13:09 <andythenorth> access control and all that jazz 20:13:15 <TrueBrain> guess that means I have to setup a Secret on production, and put it in there 20:13:32 <TrueBrain> andythenorth: I don't follow, sorry? :( 20:13:54 <andythenorth> usually you'd be putting that URL in a private VCS? 20:13:59 <andythenorth> with only employees having access 20:14:02 <andythenorth> not github 20:14:07 <TrueBrain> or some other method 20:14:14 <TrueBrain> but the getting started kinda suggests to just put it in your code 20:14:16 <TrueBrain> which feels odd :P 20:14:22 <andythenorth> we used Sentry 20:14:25 <andythenorth> it's kinda odd 20:14:25 <TrueBrain> but a search on github gave me a lot of people doing that :D 20:14:28 <andythenorth> we kinda dropped it 20:14:41 <TrueBrain> Sentry is pretty nice for Python and Javascript 20:14:48 <TrueBrain> and free for Open Source, so meh :) 20:14:57 <andythenorth> "the problem was us, not Sentry" 20:14:58 <TrueBrain> any monitoring better than none :D 20:15:00 <andythenorth> probably 20:15:10 <LordAro> andythenorth: less "open source env" and more "open env", i think 20:15:12 <peter1138> Hmm, I think I need a bigger microSD card for my retropie. PSX images are big :p 20:15:22 <LordAro> wonder how other systems do error reporting 20:15:26 <LordAro> there must be something out there 20:15:31 <andythenorth> there are tools 20:15:45 <andythenorth> datadog and stuff 20:15:54 <andythenorth> but Sentry seems to be default last time I checked 20:16:01 <andythenorth> or you can....read the logs :P 20:16:03 <andythenorth> weird idea 20:16:39 * andythenorth looking at flyspray patches 20:17:01 <TrueBrain> if you have any system that digests logs, you are fine :) 20:17:17 <andythenorth> https://github.com/OpenTTD/OpenTTD/issues/6657 <- that's the intended behaviour IMHO, closing that 20:17:20 <TrueBrain> but reading logs yourself is ... very odd andythenorth :P 20:17:27 <TrueBrain> like someone is having a tail open 24/7 :D 20:17:39 <LordAro> yeah, who would do that 20:17:48 <andythenorth> I have to fill in security questionnaires that require it 20:18:02 <andythenorth> as part of bid process 20:18:14 <andythenorth> not even server logs, wifi access logs 20:18:17 <andythenorth> have to be read in detail 20:18:20 <TrueBrain> normally you use SIEMs/SIMs for that :P 20:18:31 <andythenorth> no they require them to be manually audited 20:18:37 <andythenorth> 'best practice' 20:18:49 <andythenorth> because wifi 20:18:56 <LordAro> andythenorth: idk, it's very weird that the oil rig would be "banned" from using its own station 20:19:01 <andythenorth> no 20:19:07 <andythenorth> you bought exclusive transport rights 20:19:09 <andythenorth> the clue is in the name 20:19:12 <andythenorth> :) 20:19:27 <andythenorth> it's correct behavour 20:19:33 <andythenorth> behaviour * 20:19:49 <LordAro> guess it boils down to whether "exclusive transport rights" in a town applies to oil rigs 20:19:56 <andythenorth> it does 20:19:59 <andythenorth> it's exclusive 20:20:10 * andythenorth takes a stance 20:20:19 <andythenorth> or we can roll a die 20:20:22 <andythenorth> flip a coin 20:20:28 * TrueBrain sees andy drawing a line in the sand 20:20:28 <andythenorth> but changing it is...change 20:20:30 <TrueBrain> I DARE YOU :P 20:21:00 <andythenorth> DOUBLE DARE 20:21:38 <andythenorth> this, NFI, sounds like a bug 20:21:39 <andythenorth> https://github.com/OpenTTD/OpenTTD/issues/6636 20:21:50 <andythenorth> diff seems quite clean, but eh, dunno 20:22:58 <LordAro> andythenorth: also already part of a PR 20:23:29 <andythenorth> it is? :o 20:23:42 <andythenorth> I can't see the PR reffed on the ticket, I should get my glasses 20:23:59 <LordAro> yeah, it's only referenced in the last commit, annoyingly 20:24:04 <andythenorth> this sounds nice, but fails to apply https://github.com/OpenTTD/OpenTTD/issues/6635 20:25:11 <LordAro> sounds like it would be confusing 20:25:22 <LordAro> can't imagine it would be difficult to make it apply again though 20:25:25 <nielsm> okay so I could write a decoder for the dos adlib music and import the dosbox adlib emulation to render it... or I could do something actually worthwhile but perhaps less fun 20:25:30 <nielsm> (for certain definitions of fun) 20:25:35 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6636: airplane going for helistation depot https://git.io/fhn0a 20:26:11 <andythenorth> it sounds confusing to have to ctrl-click titlebars 20:26:21 <andythenorth> windows remembering position isn't a bad idea, but meh 20:26:28 <TrueBrain> https://pypi.org/project/PyYAML/#history <- there is a CVE against 3.13 .... so ...... yeah ... 20:26:30 *** Wormnest has quit IRC 20:26:47 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6635: Save default window position https://git.io/fhn0r 20:26:48 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6635: Save default window position https://git.io/fhn0o 20:27:43 <andythenorth> this sounds like a bug patch 20:27:46 <andythenorth> https://github.com/OpenTTD/OpenTTD/issues/6633 20:27:56 <andythenorth> but diff is relatively big for the issue 20:28:51 <andythenorth> has a test sav if anyone wants to try, otherwise closing 20:29:21 <LordAro> nah, leave it 20:29:30 <LordAro> if nothing else it's a bug 20:29:35 <LordAro> even if the patch isn't useful 20:29:58 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on issue #7042: Use intrinsics for bit twiddling? https://git.io/fhn06 20:30:28 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6657: Buying exclusive transport rights prevents oil rigs from using their own dock/helipad https://git.io/fhn0i 20:30:29 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6657: Buying exclusive transport rights prevents oil rigs from using their own dock/helipad https://git.io/fhn0P 20:31:01 <peter1138> Hmm, MacOS Job failed. 20:31:26 <peter1138> "The agent: Hosted Agent lost communication with the server. Verify the machine is running and has a healthy network connection." o_O 20:31:28 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6633: cargomonitor industry delivery https://git.io/fhn01 20:31:37 <andythenorth> bloody macOS 20:31:46 <LordAro> can't blame docker hub for that one 20:31:52 <LordAro> probably 20:32:36 <andythenorth> I confirmed this is a bug in 2017, but does the patch fix it? ;) https://github.com/OpenTTD/OpenTTD/issues/6599 20:32:38 * andythenorth tries 20:33:18 <TrueBrain> funny error .. first time I have seen thatone :D Hopefully also the last .. 20:33:32 <TrueBrain> weird that the rerun button doesnt work 20:33:39 <andythenorth> patch thinks this has already been applied in master :o https://bugs.openttd.org/task/6599/getfile/10802/3-use-gui-sorlists-for-buildvehgui-engines-filtering.diff 20:33:47 * andythenorth is not good enough to know how to resolve that :P 20:33:56 <LordAro> probably by skipping it :p 20:34:11 <LordAro> git blame to work out when it got included, see if anything else got included with it 20:35:07 <LordAro> a glance at build_vehicle_gui.cpp suggests that it has not been applied 20:35:38 <LordAro> also, `git apply` might be more effective 20:35:45 * andythenorth tries stuff 20:35:51 <LordAro> or it might barf at the hg patch, who knows 20:36:22 <andythenorth> meh, I did 'apply anyway' and the compile barfs 20:38:32 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6599: Can still click on buy button in vehicle selection window even if no vehicle is selected https://git.io/fhn0Q 20:38:41 <Eddi|zuHause> i don't think that applies cleanly on anything 20:38:51 <andythenorth> it's a stupid small issue 20:38:59 <andythenorth> it's more than an edge case 20:39:04 <andythenorth> but TMWFTLB? 20:39:08 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7025: Add #6887: Option to show zone inside local authority boundary of towns https://git.io/fhn07 20:39:10 <Eddi|zuHause> you need to apply the patches in order 20:39:35 <andythenorth> oh yes 20:39:38 <andythenorth> meh 20:39:49 <andythenorth> I think that one should be left open TBH 20:40:03 <LordAro> #6599? yeah 20:40:38 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6598: Possible for client to be in a nonexistent company on a server; but then the client crashes. https://git.io/fhn05 20:40:39 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6598: Possible for client to be in a nonexistent company on a server; but then the client crashes. https://git.io/fhn0d 20:41:42 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #6935: Prevent water construction where it could block nearby ships https://git.io/fhn0b 20:43:02 <LordAro> andythenorth: easily reproducible crash/invalid state stuff should be kept open, imo 20:43:32 <andythenorth> this one, if I understand the comments correctly, is all commited apart from patch 5 https://github.com/OpenTTD/OpenTTD/issues/6472 20:43:50 <andythenorth> NFI if it's worth saving or not 20:44:06 <andythenorth> I suspect fonso would have just committed it if was valid 20:44:40 <LordAro> presumably only because of the last comment? 20:44:51 <LordAro> @seen fonsinchen 20:44:51 <DorpsGek> LordAro: fonsinchen was last seen in #openttd 1 year, 44 weeks, 5 days, 3 hours, 38 minutes, and 25 seconds ago: <fonsinchen> There we go. 20:45:34 <LordAro> i'd like to keep it, those performance improvements seem worth it 20:45:51 <LordAro> and JGR's stuff is usually good 20:46:11 <LordAro> feel free to assign me :p 20:46:17 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6472: Cargodist: various link graph performance improvements https://git.io/fhn0x 20:46:18 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6472: Cargodist: various link graph performance improvements https://git.io/fhn0p 20:46:23 <andythenorth> ok I re-open 20:46:30 * andythenorth is behind the times 20:46:33 <LordAro> :> 20:46:46 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6472: Cargodist: various link graph performance improvements https://git.io/fhn0h 20:48:08 <andythenorth> you want this one too LordAro ? https://github.com/OpenTTD/OpenTTD/issues/6470 20:48:27 <Eddi|zuHause> andythenorth: so the 3-patch seems to conflict on a uint32/CargoType rename, and something else that seems to already have happened on a completely unrelated thing. should be trivial to solve 20:49:15 <andythenorth> Eddi|zuHause: for 6599? Would definitely be worth solving 20:49:33 <andythenorth> if I can get a clean PR with no faff, I'll test it happily 20:49:44 <LordAro> oh, i didn't even notice that 4/5 patches had already been applied, but cool 20:50:04 <LordAro> andythenorth: given JGR is actually on github, give them a poke first 20:50:40 <Eddi|zuHause> andythenorth: i need to come up with commit messages before pushing this 20:51:16 <nielsm> yeah if the author of a flyspray-imported ticket has a github account, @-mentioning them when updating that ticket could help get it on track 20:51:53 <Eddi|zuHause> andythenorth: at least seems to compile now 20:52:11 <andythenorth> LordAro: I @ JGR already :) 20:52:19 <Eddi|zuHause> what's the easiest way to batch-edit commit messages? 20:52:20 <andythenorth> if the author is on GH, I do @ them 20:52:27 <LordAro> andythenorth: not on 6470 20:52:28 <andythenorth> Eddi|zuHause: rebase -i ? 20:52:50 <peter1138> Hmm, should I try rebasing my RGB company colours patch? :p 20:53:20 <peter1138> Last commit was in 2013, although it was rebased in May last year. 20:54:03 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6470: Link graph job thread-join schedule changes https://git.io/fhnEq 20:54:08 <andythenorth> peter1138: group liveries :P 20:54:30 <andythenorth> delete the current UI, put a menu on every group, just pick two colours 20:54:37 <andythenorth> make a nice palette colour choose thing 20:54:38 <andythenorth> profit 20:55:35 <andythenorth> this one has a patch, but maybe the bug is the useful part of the ticket? https://github.com/OpenTTD/OpenTTD/issues/6468 20:56:50 <Eddi|zuHause> where's the list of commit message prefixes? 20:57:19 <LordAro> on the wiki :p 20:57:22 <Wolf01> Uh oh, big update for mashinky 20:57:38 <andythenorth> https://wiki.openttd.org/Commit_style#Commit_message 20:57:40 <LordAro> https://github.com/OpenTTD/OpenTTD-git-hooks/blob/master/hooks/check-message.py#L5 20:58:15 <LordAro> andythenorth: definitely bug, patch is... unclear 20:58:23 <andythenorth> yair I'll change the labels 20:58:38 <andythenorth> Eddi|zuHause: mostly for dev stuff I start by looking here https://github.com/OpenTTD/OpenTTD/blob/master/CONTRIBUTING.md 20:59:24 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6468: Loading savegame with AI loaded as specific version of that AI fails to load correct version of AI https://git.io/fhnEn 20:59:51 <Eddi|zuHause> dunno what prefix applies to these... picking "Change" for now 21:00:20 * andythenorth tests https://github.com/OpenTTD/OpenTTD/issues/6453 21:00:36 <andythenorth> anyone want to read this before I spend time testing? https://bugs.openttd.org/task/6453/getfile/10825/fs6453.diff 21:00:41 <andythenorth> looks straightforward 21:01:07 <LordAro> yeah 21:01:15 <nnyby> so when will 1.9.0 be released? :P 21:01:32 <LordAro> probably April 21:01:47 <LordAro> probably betas and release candidates before that 21:01:58 <andythenorth> I can't repro this, https://github.com/OpenTTD/OpenTTD/issues/6453 21:02:00 <andythenorth> closing it 21:02:09 <Eddi|zuHause> andythenorth: rebase -i just complains i have no tracking branch 21:02:18 <andythenorth> HEAD~n 21:02:19 <andythenorth> ? 21:02:29 <andythenorth> rebase -i is remarkably hard to learn 21:02:38 <andythenorth> but not remarkably hard to actually do 21:02:42 <Eddi|zuHause> ok, rebase -i master works 21:03:11 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6453: Crash: scrolling down list of (none) GS parameters https://git.io/fhnEW 21:03:12 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6453: Crash: scrolling down list of (none) GS parameters https://git.io/fhnEl 21:03:25 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhnE8 21:05:35 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6439: Aircraft will not move if company is bought while displaying "too far to next destination" https://git.io/fhnER 21:05:36 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6439: Aircraft will not move if company is bought while displaying "too far to next destination" https://git.io/fhnE0 21:05:55 <peter1138> andythenorth, hmm, the vehicle-type liveries was quite a wanted feature back in the day :/ 21:06:02 <andythenorth> I bet 21:06:32 <andythenorth> I'm not saying it's crap, burn it with fire 21:06:44 <andythenorth> but there's a more interesting way to do it? 21:06:48 <andythenorth> the UI is crap though :D 21:06:54 <peter1138> Well we can do that AND have group colours. 21:07:26 <peter1138> My livery patch removed the checkbox stuff. 21:07:34 <andythenorth> well ship that :D 21:07:37 <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z opened pull request #7049: 6599 https://git.io/fhnEu 21:07:43 <andythenorth> it's just weird, 4 ways to configure pax coach colours 21:07:45 <andythenorth> but not mail 21:07:49 <andythenorth> and freight gets 1 way 21:08:03 <Eddi|zuHause> dunno if any of that is right 21:08:06 <andythenorth> and the whole thing pretends newgrfs don' exist 21:08:11 <andythenorth> don't * 21:08:35 <peter1138> Not really, it works with company-colour newgrfs. 21:09:00 <andythenorth> I mean the steam / diesel / electric split 21:09:08 <peter1138> And the original classes was done because that's how TTDPatch did it! 21:09:10 <andythenorth> although those are the correct categories :P 21:09:17 <andythenorth> I tried Hydrogen today, and it's weird 21:09:21 <peter1138> https://www.tt-wiki.net/wiki/EnhancedGraphicalUserInterface/2.5 21:09:31 <Eddi|zuHause> andythenorth: newgrfs also only know about these three 21:09:35 <andythenorth> mail isn't pax though, I don't think I lose that argument 21:09:50 <andythenorth> Eddi|zuHause: I concede defeat on that point :P 21:09:53 <peter1138> Mail ISN'T passengers, but "pax" covers mail and passengers. 21:10:13 <andythenorth> ha ha the TTDP one is brilliant 21:10:17 <andythenorth> it colours the dropdowns in 21:10:19 <andythenorth> rainbow menus 21:10:29 <peter1138> The argument for mail being included is that passengers/mail often travel together. 21:10:37 <peter1138> Yeah, I didn't bother with that. 21:10:51 <nielsm> https://github.com/OpenTTD/OpenTTD/issues/6470 is definitely in JGR's own builds so it probably is actively being ported up 21:11:05 <andythenorth> the coloured dropdowns are every rule of UI design style broken 21:11:06 <nielsm> and might be possible to pull almost unchanged from his branch 21:11:06 <andythenorth> I love them 21:11:35 <Eddi|zuHause> andythenorth: maybe rules of UI design were different 10 years ago? 21:11:44 <andythenorth> not that many 21:11:48 <andythenorth> bevels vs flat 21:11:51 <andythenorth> not much else 21:12:00 <andythenorth> is it 20 years yet? 21:12:11 <Eddi|zuHause> bevels were more pronounced in original TT 21:12:13 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #2155: Console: heightmaps for dedicated server https://git.io/fhnE2 21:12:18 *** snail_UES_ has joined #openttd 21:12:27 <Eddi|zuHause> so it got flatter between 1994 and 1996 21:13:33 <andythenorth> Eddi|zuHause: so 7049 - the fix is that it selects another vehicle, when hiding one? 21:13:41 <andythenorth> works for me, if that's the intent 21:13:52 <Eddi|zuHause> i have no clue about intent 21:14:28 <Eddi|zuHause> also no clue if my distribution of "Change" and "Codechange" is correct 21:14:47 <andythenorth> I'm assuming it's intended due to title of patch 1 https://bugs.openttd.org/task/6599/getfile/10797/1-select-first-available-rail-engine-to-buy.diff 21:14:53 <andythenorth> anyway it resolves the issue 21:15:41 <andythenorth> also for the "filter cargo 'none'" case 21:15:52 <Eddi|zuHause> only the first commit seems to be related to the original issue, the rest is "bonus" of some sort 21:15:59 <LordAro> i like #4540, and it has a fonsichen and/or 3298 patch, unstaled 21:16:07 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on pull request #7049: Fix #6599: Can still click on buy button in vehicle selection window even if no vehicle is selected https://git.io/fhnEw 21:16:15 <andythenorth> bonus scares me but eh 21:16:50 <andythenorth> LordAro aren't implicit orders solved yet? 21:17:44 <LordAro> i have no idea tbh, never use them :p 21:18:03 <DorpsGek_II> [OpenTTD/OpenTTD] Gabda87 commented on pull request #7047: Add #6887: Highlight tiles within local authority of towns https://git.io/fhnEr 21:18:24 <andythenorth> do the patches apply? 21:19:17 <LordAro> #4684 seems nice, but perhaps confusing? 21:19:26 <andythenorth> https://github.com/OpenTTD/OpenTTD/issues/2155 seems like an obviously missing feature, and I agree to keep....but dead since 2012 :P 21:19:28 <andythenorth> nvm 21:19:47 <andythenorth> 4684 is tarpit politics 21:19:49 <andythenorth> and doesn't win much 21:19:52 <LordAro> mm 21:20:14 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #4684: Use shift to estimate costs only with a certain type of commands https://git.io/fhnEo 21:20:21 <andythenorth> freeing up shift is questionable 21:20:27 <andythenorth> it often won't be free when it's wanted 21:20:29 <andythenorth> so don't bother 21:20:53 <peter1138> Oh, this is a nightmare: "both modified: media/extra_grf/openttdgui.png" 21:20:53 <peter1138> :p 21:21:00 <andythenorth> frigging openttdgui again 21:21:02 <andythenorth> every time 21:21:17 <nielsm> seriously, split it into multiple files 21:21:19 <peter1138> Was it not possible to use separate files? 21:21:20 <peter1138> Heh 21:21:20 <andythenorth> "but one spritesheet is so much more efficient" 21:21:21 <nielsm> possibly even one per sprite 21:21:42 <andythenorth> some retro misunderstood bollocks about minimising http requests probably 21:21:44 <andythenorth> or just inertia 21:21:45 <nielsm> obviously not efficient for the workflow 21:21:58 <andythenorth> optimise for collaborative development 21:22:06 <nielsm> eh perhaps for the artist being able to easier copy-paste pixels bewteen sprites 21:22:16 <peter1138> Ok, when I have a rebase conflict on a binary file, how do I pick which file I want to edit? 21:22:37 <nielsm> (then group a few related sprites into each spritesheet, but still individual files per concern) 21:22:43 <peter1138> --ours --theirs :/ 21:23:05 <andythenorth> peter1138: NFI, does it matter? You have to open both anyway 21:23:26 * andythenorth should merge all these spritesheets, for 'efficiency' 21:23:27 <andythenorth> https://dev.openttdcoop.org/projects/iron-horse/repository/show/src/graphics/pony 21:23:27 <peter1138> Yes, but in the rebased state you only get one. 21:23:40 <peter1138> git checkout --ours was the correct incantation. 21:24:16 <peter1138> Oh, actually no. 21:25:02 <andythenorth> someone file a ticket for me to split it up? 21:25:07 <andythenorth> that's how work gets done right? :P 21:25:19 <peter1138> --ours/--theirs is the wrong way around to what I was expecting. 21:26:06 <Eddi|zuHause> <nielsm> eh perhaps for the artist being able to easier copy-paste pixels bewteen sprites <-- because it is so mind-boggingly difficult to have two images open at the same time? 21:26:08 <andythenorth> wait, this is merged? https://github.com/OpenTTD/OpenTTD/issues/6397 21:26:24 <LordAro> andythenorth: #4540 doesn't apply, but i think it's quite close 21:26:38 <andythenorth> Eddi|zuHause: it probably started small and no-one split it 21:26:46 <andythenorth> the other sprite files are quite split up iirc 21:26:48 <andythenorth> inertia :P 21:27:13 <peter1138> Not one per sprite. 21:27:27 <andythenorth> one per sprite is not useful for, e.g. the canals stuff 21:27:41 <andythenorth> that's split up by concern quite well 21:28:08 <andythenorth> but openttdgui.png is too many concerns in one file 21:28:16 <LordAro> ^ 21:28:21 <andythenorth> toolbar, window buttons etc 21:28:45 <peter1138> Well yeah, one-per-sprite for the GUI file is what I was thinking. 21:28:46 <andythenorth> LordAro: comment on #4540 then? 21:29:03 <andythenorth> I like implicit orders being displayed, but eh, people used to moan a lot about them 21:29:30 <Eddi|zuHause> clearly a toggle between show/hide implicit? 21:29:39 <andythenorth> peter1138: you proposing to do it, or you want to wait until I do? 21:30:09 *** Thedarkb2-T60 has joined #openttd 21:30:20 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #4540: Orders: toggle display of implicit orders https://git.io/fhnEP 21:31:12 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6397: Keep town growth rate in sync with house count https://git.io/fhnEM 21:31:13 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6397: Keep town growth rate in sync with house count https://git.io/fhnED 21:31:59 <andythenorth> eh looks like some or all of this is merged too? https://github.com/OpenTTD/OpenTTD/issues/6378 21:32:49 <LordAro> "some", i think 21:32:52 <LordAro> difficult to tell how much 21:33:02 <andythenorth> Eddi|zuHause: want to try and gravedig this? It's potentially a useful feature https://github.com/OpenTTD/OpenTTD/issues/6328 21:33:35 <andythenorth> I'm closing 6378 and @ dp to tell me if I'm wrong 21:33:35 <Eddi|zuHause> andythenorth: re: #6397: i'm not sure how much of that was actually in the commit. the description is a bit fuzzy 21:33:58 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #5078: NOAI API lack vehicle is old event https://git.io/fhnES 21:34:06 <peter1138> Hmm, how do I force openttd.grf to be rebuilt? o_O 21:34:07 <andythenorth> Eddi|zuHause: you could read the diffs if you could be bothered? :) 21:34:19 <Eddi|zuHause> i don't think i could be bothered :p 21:35:03 <Eddi|zuHause> peter1138: if in doubt, make -B :p 21:35:11 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6378: Erroneous behavior of Get/SetGrowthRate GS methods https://git.io/fhnEH 21:35:12 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6378: Erroneous behavior of Get/SetGrowthRate GS methods https://git.io/fhnEQ 21:35:16 <peter1138> I've never heard of -B 21:35:18 <Eddi|zuHause> there might be a makefile in /media 21:35:31 <Eddi|zuHause> -B ignores timestamps/dependencies 21:35:34 <Eddi|zuHause> and makes everything 21:35:43 <andythenorth> if grfcodec is in the path, and the nfo is changed? 21:35:47 <andythenorth> doesn't it just build? 21:36:04 <Eddi|zuHause> peter1138: only people who fucked up their dependencies usually need -B :p 21:36:09 <peter1138> make -B fails with OpenTTD. 21:36:22 <LordAro> doesn't surprise me 21:36:29 *** Thedarkb1-T60 has quit IRC 21:36:44 <peter1138> andythenorth, hmm, maybe I need to reconfigure 21:36:52 <LordAro> did you configure with --without-grfcodec or similar? 21:36:58 <peter1138> Yeah that'll be it. 21:37:08 <andythenorth> because of those .obs files? 21:37:14 <peter1138> I installed grfcodec just now, after deinstalling it the other day due to those spurious changed files :p 21:37:21 <andythenorth> I have to git reset --hard every frigging time I want to rebase 21:37:32 <andythenorth> it's really low-level hostile :P 21:37:48 <andythenorth> I tried global .gitignore, but didn't do it right 21:38:10 <peter1138> Ah right, I remember now, the group livery stuff relied on resizing a matrix which just doesn't work :p 21:38:40 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5872: No wait cursor while autosaving https://git.io/fhnE5 21:38:41 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #5872: No wait cursor while autosaving https://git.io/fhnEd 21:39:01 <LordAro> andythenorth: hmm, #5377 has a PR #6751... which was closed 21:39:27 <andythenorth> it does? o_O 21:39:50 <Eddi|zuHause> andythenorth: #6328 has a few more conflicts 21:40:02 <LordAro> it was closed unsatisfactorily, imo 21:40:17 *** Thedarkb2-T60 has quit IRC 21:40:27 *** Gabda has quit IRC 21:40:28 <Eddi|zuHause> uhoh, saveload changes :/ 21:40:57 <andythenorth> I would leave 6751 closed, no use case given 21:41:04 <DorpsGek_II> [OpenTTD/OpenTTD] nikolas opened issue #7050: Compiling with --disable-network yields error https://git.io/fhnEF 21:41:15 <andythenorth> maintainers go mad just trying to please people 21:41:29 <andythenorth> APIs *should* be complete in theory 21:41:38 <andythenorth> but let people come with actual problems they can't solve 21:42:22 <Eddi|zuHause> where do i edit my local gitignore? 21:42:58 <LordAro> andythenorth: i think my "GetWaterTile" idea is best :p 21:43:02 <LordAro> Eddi|zuHause: https://help.github.com/articles/ignoring-files/ 21:43:08 <nnyby> Eddi|zuHause: ~/.gitignore 21:43:31 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5377: AIs cannot detect river tiles https://git.io/fhnEN 21:43:32 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #5377: AIs cannot detect river tiles https://git.io/fhnEA 21:43:48 <Eddi|zuHause> there also seems to be .git/info/exclude 21:43:50 <nnyby> well the filename is flexible. it's configured like this: git config --global core.excludesfile ~/.gitignore_global 21:43:52 <Eddi|zuHause> for repo-specific 21:44:00 <nnyby> just read the article LordAro linked to 21:44:22 <nnyby> Eddi|zuHause: for repo-specific it's just the .gitignore file in each directory 21:44:34 <nnyby> i wouldn't mess with what's in .git/, that's internal git stuff 21:44:50 <Eddi|zuHause> nnyby: no, there's a repo-specific-but-local-gitignore 21:44:57 <nnyby> only stuff i alter in there is .git/config, to set up origin to be my repo, vs upstream OpenTTD 21:45:17 <Eddi|zuHause> i.e. "only in this repo, and only on this computer" 21:45:28 <nnyby> ah okay 21:45:36 <nnyby> yeah, i've never needed to use that feature 21:45:43 <Eddi|zuHause> where .gitignore is "only in this repo, but shared between everyone" 21:45:49 <nnyby> right 21:46:19 <Eddi|zuHause> but probably ~/.gitignore would be more appropriate for now 21:46:43 <LordAro> nielsm: care to take up #5735? :p 21:47:13 <andythenorth> only 15 left, some of which we triaged already https://github.com/OpenTTD/OpenTTD/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3A%22patch+from+FlySpray%22+label%3A%22stale%22 21:47:52 <andythenorth> I didn't test 5735 because it's queue faff, but it's a good feature 21:48:00 <andythenorth> *way* too many signals in the UI 21:49:26 <LordAro> #5977 is trivial, and applies 21:49:28 * LordAro takes 21:49:48 <andythenorth> yeah 3298's stuff was pretty good 21:49:52 <andythenorth> I tested quite a bit of it 21:50:13 <LordAro> shame he didn't get on with github 21:50:16 <andythenorth> shame 21:50:27 <andythenorth> there is a forum ticket with a bunch of useful fixes in 21:50:28 <LordAro> i noticed in his forum post that he cited having to pay for private repos as an issue 21:50:41 <LordAro> now that that is no longer the case... 21:50:44 <andythenorth> JJ has been picking some of the fixes out 21:51:05 <Eddi|zuHause> so... gitignore sorted out, distributed stuff between ~/.gitignore and .git/info/exclude appropriately, i think 21:51:07 <andythenorth> 3298's primary problem was being tracked 21:51:11 <andythenorth> but eh distractions 21:51:22 <andythenorth> Eddi|zuHause: can we all have our gitignore fixed? 21:51:26 <andythenorth> I will mail you my computer 21:51:26 <Eddi|zuHause> now back to the actual conflict 21:51:42 <Eddi|zuHause> andythenorth: teamviewer? :) 21:51:45 <andythenorth> :P 21:52:08 <andythenorth> timetable bugs are an absolute tarpit for testing https://github.com/OpenTTD/OpenTTD/issues/2944 21:52:16 <andythenorth> there's no save attached 21:52:42 <andythenorth> it's not from a contributor I recognise 21:52:47 <andythenorth> 2009 :P 21:53:12 <nielsm> LordAro I'd do the signal GUI completely different myself from that patch in 5735 :) 21:53:24 <nielsm> but don't really feel like working on GUI right now 21:53:30 <LordAro> that's fair 21:53:34 <LordAro> andythenorth: kill it ^ 21:53:53 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #2944: Timetable: auto-reset delay counter https://git.io/fhnuJ 21:53:54 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #2944: Timetable: auto-reset delay counter https://git.io/fhnuU 21:54:16 <andythenorth> I don't actually much like the new signal ui in the attached PNG 21:54:19 <andythenorth> it's not....good 21:54:20 <nielsm> right now: https://0x0.st/s7lP.png 21:54:25 <Eddi|zuHause> andythenorth: i'm not sure if i understand #2944, i thought that's how it already behaves? 21:54:38 <andythenorth> Eddi|zuHause: NFI, timetables don't work for me ever :) 21:54:51 <LordAro> nielsm: dare i ask? 21:54:51 <andythenorth> something about having to use full load, or not 21:54:59 <andythenorth> timetables are super confusing and broken 21:55:12 <andythenorth> actually I lie 100% 21:55:22 <nielsm> LordAro, I want to make a decoder for the dos adlib music (ADLIB.CAT) and play it through emulation 21:55:26 <andythenorth> I use 'wait at station for n days' on nearly all pax routes :P 21:55:54 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on issue #6266: UI Zoom: ugly lists in network windows on double/quad interface sizes with custom fonts https://git.io/fhnuI 21:55:57 <Eddi|zuHause> timetables are ok, but miss a lot of advanced features 21:56:19 <Eddi|zuHause> too much micromanagement 21:57:43 <andythenorth> why it's not just a cadence of vehicles I don't know :P 21:57:46 <andythenorth> seems very complex 21:58:00 <andythenorth> it's for modelling real world timetables for train fans, right? 21:58:15 <LordAro> oh 21:58:21 <LordAro> i can't actually compile on mingw 21:58:23 <LordAro> that's unfortunate 22:01:39 *** chomwitt has quit IRC 22:01:56 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5735: Signals: signal window - show one signal variant at a time https://git.io/fhnuq 22:01:57 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #5735: Signals: signal window - show one signal variant at a time https://git.io/fhnum 22:05:05 <andythenorth> oof this one modifies openttdgui.png :( https://github.com/OpenTTD/OpenTTD/issues/5981 22:05:34 <andythenorth> I don't think making 'location' an icon is wise 22:05:55 <Eddi|zuHause> src/depot_base.h:46:13: error: ‘const struct Depot’ has no member named ‘type’ 22:05:56 <Eddi|zuHause> return d->type == this->type; 22:05:59 <Eddi|zuHause> more problems 22:06:04 <andythenorth> Eddi|zuHause: TMWFTLB? 22:06:14 <Eddi|zuHause> not yet 22:06:30 <Eddi|zuHause> but also not trivial, like the other one 22:06:44 <andythenorth> I wonder if it has more work behind it https://github.com/OpenTTD/OpenTTD/issues/6328#issuecomment-379454447 22:06:53 <andythenorth> order handling might need adjusted 22:07:03 *** debdog has quit IRC 22:07:26 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #5981: Unify appearance and position of location buttons (wanted contributions-list) https://git.io/fhnus 22:07:27 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #5981: Unify appearance and position of location buttons (wanted contributions-list) https://git.io/fhnuG 22:08:16 <andythenorth> 101 issues open 22:08:22 <Eddi|zuHause> so what happened to depot types? 22:08:23 <andythenorth> TrueBrain: ready for Probot yet? ^ 22:08:34 <andythenorth> NotDepotTypes Eddi|zuHause ? 22:08:37 <andythenorth> ;) 22:10:24 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6060: Allow drawing dropdown lists with scrollbars above the widgets https://git.io/fhnuC 22:11:02 <Eddi|zuHause> can't i browse through just changes to a specific file on git? 22:11:08 <Eddi|zuHause> i can get the changelog for that file 22:11:18 <Eddi|zuHause> but it'll lead me to complete repo diffs 22:12:19 <andythenorth> is there a blame view 22:12:20 <andythenorth> ? 22:12:22 * andythenorth looking 22:12:37 <andythenorth> Eddi|zuHause: https://help.github.com/articles/tracking-changes-in-a-file/ 22:13:09 <andythenorth> can't figure out how to use it though :P 22:13:52 <andythenorth> oh found it 22:14:03 <andythenorth> Eddi|zuHause: https://help.github.com/articles/tracking-changes-in-a-file/ 22:14:07 <andythenorth> nope wrong paste 22:14:10 <andythenorth> https://github.com/OpenTTD/OpenTTD/blame/master/src/airport.cpp 22:15:20 <Eddi|zuHause> i found a deeply hidden thing in git gui that does what i want 22:15:50 <Eddi|zuHause> but i found no evidence of depot type ever being a thing 22:16:33 <Eddi|zuHause> maybe it's a badly ordered patch queue, i'll ignore it and go ahead 22:17:53 <Eddi|zuHause> if it works after all patches are applied, then maybe consider squashing? 22:20:01 <andythenorth> this one is very interesting https://github.com/OpenTTD/OpenTTD/issues/6060 22:20:09 <andythenorth> the original issue seems to be fixed 22:20:33 <andythenorth> I can crash r27656 by making the window size too small to display a dropdown menu 22:20:39 <andythenorth> which is clown shoes, but seems fixed in 1.8.0 22:20:50 <andythenorth> I don't know what the remaining patches fix 22:25:22 *** Thedarkb2-T60 has joined #openttd 22:25:39 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6583: Scrolling down/right out of map on a 255 high flat map bounces viewport back to edge of map https://git.io/fhnu0 22:26:35 *** Wormnest has joined #openttd 22:26:50 <andythenorth> peter1138: any interest in JFDI-ing this? https://github.com/OpenTTD/OpenTTD/issues/6155. Comment from 23 Mar 2017 smells of 'incoming politics' :P 22:27:00 <Eddi|zuHause> so complete queue compiles 22:27:18 <andythenorth> :) 22:30:55 *** Thedarkb-T60 has joined #openttd 22:31:45 <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z opened pull request #7051: Feature: Moveable depots #6328 https://git.io/fhnug 22:33:08 * andythenorth tests 22:33:41 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6583: Scrolling down/right out of map on a 255 high flat map bounces viewport back to edge of map https://git.io/fhnur 22:34:59 *** Thedarkb2-T60 has quit IRC 22:35:48 <andythenorth> Eddi|zuHause: did you test it? o_O 22:35:59 <Eddi|zuHause> no 22:36:48 <andythenorth> it's pretty neat 22:37:03 <andythenorth> the building / rebuilding is pretty straightforward 22:37:17 <Eddi|zuHause> yeah, i do remember going "why does this not work?" a while ago 22:37:49 <andythenorth> I've got a train stuck though 22:38:02 <andythenorth> I gave it orders to a depot, then deleted the depot 22:38:04 <Eddi|zuHause> but it's not quite merge-ready i think 22:38:21 <andythenorth> actually it's user error I think 22:38:25 <andythenorth> the order has been invalidated 22:38:27 <andythenorth> probs fine 22:38:39 <Eddi|zuHause> i'm assuming it's going to disappear after a month like invalid station? 22:39:02 <andythenorth> yup 22:39:05 <andythenorth> think so 22:39:20 <andythenorth> yeah 22:39:39 <andythenorth> kind of thing that needs a long-run game to test it 22:39:47 <andythenorth> or just putting in a nightly :P 22:40:36 * andythenorth wonders what it does with airport hangars 22:41:00 <andythenorth> seems to work 22:41:27 *** Thedarkb1-T60 has joined #openttd 22:42:15 <andythenorth> distance is 8 tiles Eddi|zuHause ? 22:42:18 <andythenorth> approx? 22:43:22 *** Thedarkb-T60 has quit IRC 22:43:48 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on pull request #7051: Feature: Moveable depots #6328 https://git.io/fhnuM 22:47:15 <andythenorth> just 7 left 22:47:15 <andythenorth> https://github.com/OpenTTD/OpenTTD/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3A%22patch+from+FlySpray%22+label%3A%22stale%22 22:47:23 <andythenorth> I think this is dead? https://github.com/OpenTTD/OpenTTD/issues/6490 22:48:09 <LordAro> maybe 22:48:26 <LordAro> i feel like i saw something about an appdata.xml somewhere else recently anyway 22:48:28 <andythenorth> also the dude was just plain rude 22:48:41 <andythenorth> "Copying it into your repository shouldn't be that much of an effort. If your attitude would be more friendly and your source code repository more accessible, " 22:48:48 <andythenorth> is 50% accurate, at the time :P 22:49:02 <andythenorth> it was FS :P 22:49:30 <andythenorth> closing, there's nothing useful to test there, just another grumpy open source developer 22:49:57 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6490: appdata.xml metadata file for inclusion in Software Center https://git.io/fhnuF 22:49:58 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6490: appdata.xml metadata file for inclusion in Software Center https://git.io/fhnub 22:50:17 <andythenorth> this one needs the 'escalated quickly' gif https://github.com/OpenTTD/OpenTTD/issues/6583 22:50:28 <andythenorth> scroll bug -> refactor tile heights completely :P 22:50:47 <Samu> ok, gonna create an assert 22:51:00 <Samu> for this https://github.com/OpenTTD/OpenTTD/pull/6928#discussion_r247325714 22:52:28 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6505: Allow rail when ships are on lower halftile https://git.io/fhnuN 22:52:29 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #6505: Allow rail when ships are on lower halftile https://git.io/fhnuA 22:53:20 <andythenorth> frosch123: any recollections about https://github.com/OpenTTD/OpenTTD/issues/6060 22:53:21 <Samu> aha, an assert was triggered 22:53:28 <andythenorth> specifically https://github.com/OpenTTD/OpenTTD/issues/6060#issuecomment-453784718 22:57:38 <Samu> nielsm was right, now the ship is told to reverse 22:57:40 <frosch123> andythenorth: you need a dropdown with a lot of entries 22:57:49 <frosch123> possibly translation selection or so 22:57:58 <andythenorth> ok 22:58:03 <frosch123> then make the main window very small in height 22:58:04 <Samu> would not reverse otherwise, but I can't see where the shit is 22:58:09 <Samu> ship* 22:58:10 <andythenorth> I did trigger the previous assert with very small window height 22:58:15 <frosch123> so that the whole selection doe snot fit 22:58:44 <frosch123> then position the combobox in the upper or lower half of the main window 22:58:58 <Eddi|zuHause> andythenorth: seems that regression failed 22:59:03 *** Thedarkb1-T60 has quit IRC 22:59:32 <andythenorth> frosch123: all of that seems to work fine ? 22:59:35 <andythenorth> in master 22:59:35 *** Wormnest has quit IRC 22:59:37 <Eddi|zuHause> and that errors are still useless 23:00:51 <Eddi|zuHause> andythenorth: so that definitely needs more work 23:00:52 <andythenorth> 2019-01-12T22:39:23.2400344Z Running ai/regression/tst_regression... failed! 23:01:15 <Eddi|zuHause> andythenorth: the linux ones contain actual regression output 23:01:24 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on pull request #7051: Feature: Moveable depots #6328 https://git.io/fhnzv 23:01:39 <frosch123> andythenorth: the window still scrolls when holding the button down 23:02:19 <frosch123> i have no idea whether parts of that diff were committed or whether someone else implemented the same 23:02:56 <frosch123> (svn r27820) -Fix: Allow dropdown to be drawn above origin widget even with scrollbar (Juanjo) 23:03:43 <andythenorth> I can't trigger any scroll behaviour that looks weird 23:03:58 <frosch123> ah, that's the reivision that's mentioned in the issue as well 23:04:19 <andythenorth> yes 23:04:36 <frosch123> andythenorth: make the combobox open above the widget with a scrollbar 23:04:49 <Samu> ah i see 23:04:56 <frosch123> open the combobox with keeping the button pressed down, not releasing it 23:04:58 <andythenorth> frosch123: I did 23:05:08 <andythenorth> then I can mousewheel scroll as expected 23:05:21 <Samu> assert((dist <= rev_dist) == (dist2 <= rev_dist2)); 23:05:26 <frosch123> there are two ways to use a combobox: 1 click open + 1 click select, and press to open + release to select 23:05:32 <glx> <Eddi|zuHause> andythenorth: the linux ones contain actual regression output <-- indeed in the windows vbs I just do a <content of file A> = <content of file B> with no diff 23:05:53 <Samu> yeah, this reversal is bad behaviour, well uhm, how am i gonna do this 23:05:55 <frosch123> in the second method the window scrolls with the mouse is above/below the combowindow 23:06:04 <Samu> just spotted the ship 23:06:07 <andythenorth> oof 23:06:07 <glx> that's assuming the sh/awk fails too on other platforms 23:06:11 <andythenorth> I can't repro 23:06:24 <andythenorth> but I have the ottd mac-specific scroll stuff disabled, because it's bollocks 23:06:27 <andythenorth> let me turn on it 23:06:43 <frosch123> well, my repository is in november, no idea whether something changed in past 2 months 23:07:08 <Eddi|zuHause> glx: i can't tell from the regression output what it was trying to do and whether that is a "good" or "bad" change 23:08:56 <Eddi|zuHause> was there ever some followup to https://github.com/OpenTTD/OpenTTD/issues/6862 ? 23:09:08 <glx> it's related to depots ;) 23:09:23 <Eddi|zuHause> glx: yeah, i see that :p 23:09:28 <LordAro> i don't actually know how to get larger interface on the menu screen 23:09:39 <Eddi|zuHause> glx: whic might be somewhat expected since we changed depot code :p 23:09:45 <LordAro> which makes it a bit difficult to test #6212 23:09:52 <glx> and line numbers should match the .nut 23:09:59 <LordAro> #6266* 23:11:22 <glx> ah no it doesn't because iterators 23:11:26 <andythenorth> LordAro: game options? 23:11:36 <LordAro> oh. 23:11:40 <LordAro> how long has that been there> 23:12:01 <Eddi|zuHause> probably years. 23:12:14 <andythenorth> since peter1138 did it :) 23:12:21 <andythenorth> best feature ever, at the time 23:12:43 <Eddi|zuHause> we need 1.5 zoom. or sqrt(2) 23:13:31 <glx> Eddi|zuHause: running regression with -k flag used to keep result.txt, but I think it's overwritten by the second test 23:13:31 <nnyby> C++ is so much harder to use than javascript/python lol 23:14:02 <Eddi|zuHause> glx: not going to look at this today... 23:14:07 <andythenorth> Eddi|zuHause: "add your vote" https://github.com/OpenTTD/OpenTTD/issues/6797 23:14:21 <andythenorth> because votes = patches, right? :P 23:14:37 <frosch123> andythenorth: so, something changed from november to now 23:14:52 <frosch123> someone broke or removed the scrolling 23:15:11 <glx> Eddi|zuHause: I'll look at it and put it in comments 23:17:18 <andythenorth> not getting much here frosch123 https://github.com/OpenTTD/OpenTTD/commits/master/src/widgets/dropdown.cpp 23:17:26 <andythenorth> I'm assuming it's somewhere else :P 23:17:41 <frosch123> i am compiling the revision before the ontick stuff 23:18:05 <andythenorth> k 23:18:57 <LordAro> andythenorth: frosch123: are you missing https://github.com/OpenTTD/OpenTTD/pull/7048 ? 23:19:24 <LordAro> 6266 looks fine though 23:19:31 <LordAro> i'll make that into a PR at some point, probably 23:19:35 * LordAro bedteim 23:19:51 <andythenorth> not bad eh 23:19:57 <andythenorth> cleared out a bunch, saved a few 23:20:12 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro merged pull request #7044: Codechange: Define INVALID_TOWN as a TownID. https://git.io/fhnW3 23:20:14 <frosch123> so, the scrolling still happens before the ontick stuff, and probably again with 7048 23:20:38 <andythenorth> frosch123: shall I update the issue, or you will? 23:21:07 <frosch123> please do 23:21:33 <andythenorth> thanks 23:22:58 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro dismissed a review for pull request #7048: Fix #6780: Some windows didn't get updated from OnTick() https://git.io/fhnB7 23:23:15 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #7048: Fix #6780: Some windows didn't get updated from OnTick() https://git.io/fhnzB 23:23:25 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro merged pull request #7048: Fix #6780: Some windows didn't get updated from OnTick() https://git.io/fhnBV 23:23:35 <LordAro> andythenorth: there you go :p 23:23:38 <andythenorth> ta 23:25:01 * andythenorth compiling 23:26:06 <andythenorth> frosch123: repro-ed 23:26:16 <glx> oh macOS task is the best way to look at regression diff ;) 23:26:33 <glx> in linux tasks it's hidden in the logs 23:27:31 <glx> but still doesn't tell what the regression was testing exactly 23:27:52 <LordAro> https://i.imgur.com/MjgTv6G.png osht 23:27:56 <LordAro> grats andythenorth 23:28:18 <andythenorth> :P 23:28:49 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6060: Allow drawing dropdown lists with scrollbars above the widgets https://git.io/fhnzu 23:29:53 <andythenorth> this is ready for PR afaict https://github.com/OpenTTD/OpenTTD/issues/6060#issuecomment-379453143 23:29:58 <andythenorth> but very bedtime 23:33:17 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #6078: Orders: it does not jump order by remaining lifetime https://git.io/fhnzr 23:34:42 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #5321: AI: allow placing waypoints like human player (next to each, other, covering more than 1 tile etc) https://git.io/fhnz6 23:35:17 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth commented on issue #4754: Scenario Editor: rivers with desert https://git.io/fhnzi 23:35:18 <DorpsGek_II> [OpenTTD/OpenTTD] andythenorth closed issue #4754: Scenario Editor: rivers with desert https://git.io/fhnzP 23:35:38 *** Samu has quit IRC 23:35:47 *** Samu has joined #openttd 23:36:50 *** andythenorth has quit IRC 23:44:19 *** rocky1138 has quit IRC 23:46:55 *** rocky1138 has joined #openttd 23:47:44 *** rocky1138 has quit IRC 23:49:00 *** frosch123 has quit IRC 23:58:59 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #6928: Fix #5713: Use pathfinder to find closest ship depot https://git.io/fhnzj 23:59:02 <glx> ok I have a PR to write to improve regression