Times are UTC Toggle Colours
00:00:08 *** Wolf01 has quit IRC 00:01:17 *** Thedarkb-T60 has quit IRC 00:09:35 <peter1138> Hmm. 00:13:39 *** Thedarkb1-T60 has quit IRC 00:14:09 *** Flygon has joined #openttd 00:19:10 <TrueBrain> Samu: no. and you are again stuck on the problem right in front of you. take a step back and see what the whole statement is doing. as is, it is incredibly hard to understand. I am sure you can make something more readable from it. but don't focus on the do/while on it's own.. think what you want it to do, and do it in the most clean way you can! 00:21:32 <Samu> okay 00:23:43 <peter1138> Hmm, maybe it is cleaner to keep the waterclass-for-tree-tiles change. 00:23:51 <peter1138> Regardless of how illogical it seems :/ 00:42:11 *** Wormnest has joined #openttd 00:42:19 *** Thedarkb-T60 has joined #openttd 00:44:05 <Samu> * @param count Current count of number of AI company indexes that are going to be started. 00:44:05 <Samu> * @see MaybeStartNewCompany 00:46:08 <Samu> terrible terrible english 00:59:39 *** drac_boy has left #openttd 01:04:02 *** Wormnest has quit IRC 01:51:19 *** tokai has joined #openttd 01:51:19 *** ChanServ sets mode: +v tokai 01:59:41 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN opened pull request #7405: Fix #7400: WaterClass for tree tiles was not converted for old saves preventing industry creation. https://git.io/fjJoP 02:05:50 *** Progman has quit IRC 02:06:31 <peter1138> Turns out that doing the savegame conversion and keeping the data duplication is cleaner than reverting and explicitly checking for trees on coasts. 02:06:34 <peter1138> Hmm. 02:14:39 <Samu> why can't I do something that is so simple... 02:23:23 <Eddi|zuHause> or we scrap the pseudo-water-classes and recalculate it for more tiles? 02:23:38 <Eddi|zuHause> like for industries and stuff? 02:24:35 <peter1138> Eddi|zuHause, possible but makes everything more complex. 02:24:44 <Eddi|zuHause> yeah. 02:24:46 <peter1138> For the sake of 3 bits which are already allocate.d 02:24:53 <Eddi|zuHause> exactly 02:25:15 <peter1138> For tree tiles it's very easily calculated, I'm not sure about the others. 02:25:24 <Eddi|zuHause> this is more a "maybe we should have designed it differently in the first place, but for now it works" kind of thing 02:25:32 *** Supercheese has quit IRC 02:25:35 <peter1138> Eddi|zuHause, well, we didn't have a vision. 02:25:53 *** Supercheese has joined #openttd 02:26:36 <peter1138> Eddi|zuHause, it is odd that shore tiles are considered water at all. 02:26:58 <Eddi|zuHause> hysterical raisins 02:27:09 <peter1138> But it is what it is, and NewGRF landscape checks rely on this implementation detail. 02:39:19 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7301: Feature: When filtering purchase list by cargo type, make buy button perform a refit if required. https://git.io/fhAIp 02:39:41 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7301: Feature: When filtering purchase list by cargo type, make buy button perform a refit if required. https://git.io/fjJox 02:40:38 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7301: Feature: When filtering purchase list by cargo type, make buy button perform a refit if required. https://git.io/fjJop 02:46:31 <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z commented on pull request #7405: Fix #7400: WaterClass for tree tiles was not converted for old saves preventing industry creation. https://git.io/fjJoj 02:49:52 <peter1138> Hmm, this may call for... minor version :p 02:50:34 <peter1138> Really it calls for _sl_version <= major, but we don't have that function. 02:53:10 <Eddi|zuHause> iirc there was some trickery done in some minor releases to have savegame conversion stuff without breaking the forward compatibility 02:53:26 <Eddi|zuHause> i have no clue what that was, though 02:54:08 <peter1138> If we check against sub version 1, then it basically becomes a <= test. 02:54:14 <peter1138> But it's not entirely clear :/ 02:55:07 <peter1138> Probably best to add a new function. 02:56:35 <Eddi|zuHause> i don't know why we have a minor version when we're not allowed to use it 02:57:02 <peter1138> It's only there because it's needed for old savegame conversion. 02:58:08 <peter1138> It's read-only, not written to the save. 03:05:40 *** D-HUND has joined #openttd 03:09:02 *** debdog has quit IRC 03:14:44 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #7376: More than max_no_competitors could be created in network games https://git.io/fjvY8 03:14:50 *** Supercheese has quit IRC 03:14:58 <Samu> who wants to read my code 03:15:11 *** Supercheese has joined #openttd 03:15:27 <Samu> if it's still confusing, then... 03:16:07 <Samu> .... I'm stuck 03:36:50 *** Pikka has joined #openttd 03:55:42 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #7376: More than max_no_competitors could be created in network games https://git.io/fjvY8 03:56:01 <Samu> just fixup'ed everything, and changed commit message, nothing else 04:03:20 *** debdog has joined #openttd 04:06:42 *** D-HUND has quit IRC 04:22:15 *** Samu has quit IRC 04:40:58 *** glx has quit IRC 05:31:34 *** tycoondemon has quit IRC 05:35:02 *** tycoondemon has joined #openttd 06:48:51 *** Supercheese has quit IRC 07:00:37 *** Alberth has joined #openttd 07:00:37 *** ChanServ sets mode: +o Alberth 07:00:42 <Alberth> moin 07:28:36 *** nielsm has joined #openttd 07:32:09 *** Progman has joined #openttd 07:33:18 <Pikka> boing 07:36:58 <Alberth> poing 07:37:43 <nielsm> moo 07:38:10 <nielsm> irc logs not working? webster server just does not reply to the request 07:38:32 <nielsm> looks like there might be something in yesterday's log that makes it give up 07:42:22 <planetmaker> o/ 07:42:35 <planetmaker> @logs 07:42:36 <DorpsGek> planetmaker: https://webster.openttdcoop.org/index.php?channel=openttd 07:47:28 <planetmaker> I wonder whether that happens when there's too many chatter 07:54:24 *** Speedy` has quit IRC 08:26:07 *** andythenorth has joined #openttd 08:26:10 <andythenorth> moin 08:27:07 <peter1138> Isn't it 08:28:25 <andythenorth> should I fix FIRS? 08:28:28 <andythenorth> been avoiding it for weeks 08:28:31 <andythenorth> sun is out 08:28:47 <peter1138> What needs fixing? 08:29:15 <andythenorth> 16-cargo stuff 08:29:18 <andythenorth> mostly 08:29:48 <andythenorth> it's not very interesting, just yak-shaving 08:51:47 <peter1138> I need to cycle. I ate waaaaay too many snacks yesterday. 08:52:15 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7301: Feature: When filtering purchase list by cargo type, make buy button perform a refit if required. https://git.io/fhAIp 08:59:41 <andythenorth> BUT DOCKS! 08:59:54 <andythenorth> hmm can DOCKS be bacronymed? o_O 09:00:00 *** synchris has joined #openttd 09:00:01 <andythenorth> can I reserve a grfid for it? 09:00:20 *** cHawk has quit IRC 09:00:25 <andythenorth> Docks on Coasts Keep Shipping 09:00:42 *** gelignite has joined #openttd 09:02:57 <Alberth> sounds like a good grfid 09:03:14 <Alberth> bbl 09:03:16 *** Alberth has left #openttd 09:03:52 <peter1138> Well, I'm stuck on newgrf docks now because build rules and UI-confusion and... general station tiles? 09:04:23 <peter1138> But hey, refit-on-purchase works pretty well now. Probably someone will find a breaking bug the moment it gets merged. 09:04:27 <peter1138> (If it gets merged) 09:05:49 <andythenorth> let docks mature for a while 09:05:54 <andythenorth> is it playable? 09:06:02 <andythenorth> I built it and had a poke 09:06:13 <peter1138> Not really. 09:06:26 <peter1138> There's still the old-style vs new-style rules which mess it up. 09:23:55 <andythenorth> FIRS grinding 09:25:34 <andythenorth> sometimes I find spiders 09:26:04 <andythenorth> https://encrypted-tbn0.gstatic.com/images?q=tbn:ANd9GcQqJNoJtLGUuUUzQWKnvUgGnNffuftPtaDL_j6Z1LIdhvTkON8n 09:26:30 <andythenorth> "the history of FIRS" 09:27:05 <andythenorth> NFO + CPP -> automated conversion to nml -> reinsertion of CPP -> partial replacement of CPP by python -> total conversion to python -> now 09:27:13 <andythenorth> definite spiders 09:32:18 <andythenorth> hmm 09:32:32 <andythenorth> could we update the industry newgrf debug window occasionally? 09:32:48 <andythenorth> currently I have to windowshade it or open / close it to see values change 10:00:52 <andythenorth> hmm are industry vars 0x8E and 0x8F undocumented? 10:00:54 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain requested changes for pull request #7376: More than max_no_competitors could be created in network games https://git.io/fjJi1 10:00:57 <andythenorth> can't find them in newgrf wiki 10:01:04 <andythenorth> nml uses them as production_rate_1 and production_rate_2 10:01:12 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7376: More than max_no_competitors could be created in network games https://git.io/fjJiM 10:01:39 <TrueBrain> this kid .. 10:02:23 <andythenorth> https://github.com/OpenTTD/nml/blob/master/nml/actions/action2var_variables.py#L506 10:03:15 * andythenorth must go and do responsible things 10:03:20 <andythenorth> can we fix nml later? :P 10:03:27 <andythenorth> and maybe artefact publishing? :P 10:08:24 <TrueBrain> hmm .. Backport PR not reviewed yet? Awh .. I thought we wanted to release RC2 this weekend? 10:10:24 *** andythenorth has quit IRC 10:13:20 <Eddi|zuHause> <peter1138> Well, I'm stuck on newgrf docks <-- have you considered "docking tile" to be just a map bit, so it can be inside other objects (depot, lock, ...) and also serve multiple adjacent docks? 10:19:33 <Eddi|zuHause> TrueBrain: we definitely need to fix #7400 before RC 10:20:03 <TrueBrain> before release? :D 10:20:27 <TrueBrain> I mean, having that bug also in RC2 is not the worst; but having it fixed would be nice, ofc 10:22:44 <TrueBrain> do I feel looking into andy's docs stuff today, or do I feel building in Satisfactory ... hmmmmmm 10:22:45 <TrueBrain> choices 10:23:02 <TrueBrain> or do I further look into cmake .. hmm .. 10:35:50 <nielsm> what kind of review would the backport PR take... checking the bugs are in fact still fixed? 10:38:16 <TrueBrain> I think it only needs someone to hit Approve, tbh :) 10:38:58 <TrueBrain> scrolling through the diff and commit list might be useful, just to spot odd things that might have happened 10:39:12 <TrueBrain> but they are all 'cherry-pick', and only one conflict in finnish.txt 10:39:25 <TrueBrain> so yeah .. it is not the usual 'review' if you ask me 10:39:57 <TrueBrain> I think it is a bit above and beyond to validate the bugs are really fixed 10:41:12 *** sla_ro|master has joined #openttd 10:42:29 <TrueBrain> funny .. seems because I used WSL to checkout this git clone, the folder is "case sensitive" .. VS2019 wants to open "cmakelists.txt" .. fails, because it should be "CMakeLists.txt" .. 10:42:30 <TrueBrain> funny 10:43:33 <TrueBrain> and this is the reason things work for glx in VS, and not for me :D 10:57:06 <TrueBrain> so okay, Microsoft added case sensitive file support, which is on by default in WSL ... MSBuild lowercases all paths .. see where this is going wrong? :P 10:57:10 <TrueBrain> you would think they fix these things 10:57:22 <TrueBrain> suggested fix? Disable case sensitive support 10:57:24 <TrueBrain> lol 10:59:14 <TrueBrain> they did fix it in cl.exe, just not in msbuild.exe 10:59:17 <TrueBrain> *facepalm* 11:07:19 *** andythenorth_ has joined #openttd 11:09:02 <andythenorth_> industry var 8E and 8F then? 11:09:24 <andythenorth_> anyone find them in openttd src? I am on my phone :p 11:10:03 <TrueBrain> random out of context questions? :D 11:10:30 <andythenorth_> nielsm ^ did you do 16 cargo support for those? they seem to be undocumented 11:10:41 <TrueBrain> context :D Tnx! :) 11:11:04 <nielsm> uh what do they do? 11:11:32 <andythenorth_> give current prod rate for cargo 1 and 2 afaict 11:11:58 <andythenorth_> nml has var names for them, but nfo docs seem to miss them 11:12:05 <andythenorth_> or I missed them 11:13:07 <andythenorth_> the impedance mismatch in content API is high :p 11:13:15 <andythenorth_> it’s lolz 11:14:30 <TrueBrain> wow, NSIS installer via CMake works very well :o 11:14:32 <TrueBrain> and out-of-the-box 11:14:51 <TrueBrain> just no "download OpenGFX" 11:15:51 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7270: Introduce CMake (and removing all other project-related code) https://git.io/fhbqc 11:17:05 <TrueBrain> mostly what is left is testing OSX bundling now .. which is a whole other game :) 11:18:36 * andythenorth_ whistles innocently 11:21:29 <TrueBrain> yeah, you better hide 11:22:01 *** andythenorth_ has quit IRC 11:22:14 *** Speedy` has joined #openttd 11:23:07 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7270: Introduce CMake (and removing all other project-related code) https://git.io/fhbqc 11:25:44 *** andythenorth_ has joined #openttd 11:26:49 <Eddi|zuHause> <TrueBrain> just no "download OpenGFX" <-- should we revisit "just bundle OpenGFX in the installer"? 11:27:19 <TrueBrain> Eddi|zuHause: I am 11:27:27 <TrueBrain> I think it is not fair that only Windows has this, and only on the installer 11:27:33 <TrueBrain> I think we should work on our bootstrap 11:28:19 <Eddi|zuHause> i think the vast majority of people installing will also download opengfx anyway, so there's no real bandwidth saving 11:29:14 <andythenorth_> maybe we should license original base set 11:29:21 <Eddi|zuHause> maybe skip the bundling in the nightly 11:29:27 * andythenorth_ derails conversation :p 11:29:46 <Eddi|zuHause> andythenorth_: please, go ahead :) 11:30:36 <andythenorth_> someone must hold the rights :p 11:30:57 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7270: Introduce CMake (and removing all other project-related code) https://git.io/fhbqc 11:31:23 <TrueBrain> andythenorth_: we once went down that road; we figured out who and what, but .. that is not really helping :) 11:31:49 <TrueBrain> you really don't want to know how that world works ... distribution rights, publishing rights, licensing ... 11:32:11 <andythenorth_> probably like film 11:32:12 <TrueBrain> Eddi|zuHause: what do you mean, 'bundling in the nightly'? 11:32:15 <Eddi|zuHause> if only we could get a modernized copyright law 11:32:50 <Eddi|zuHause> TrueBrain: for releases, put opengfx in the bundle, for nightly, don't. 11:32:54 <TrueBrain> well, I think it is more, we are like: we need the license to those files. But in reality, we need the distribution rights .. which is a whole different game :P 11:32:56 <andythenorth_> if only I could make friends with CS :p 11:33:06 <TrueBrain> anyway, original base set, OpenGFX .. they both would have the same issue: how to distribute :) 11:33:15 <TrueBrain> andythenorth_: funny enough, that won't help you at all for the gfx :) 11:33:32 <TrueBrain> Eddi|zuHause: or we just make a bootstrap that always allows you to download it? :D 11:33:37 <TrueBrain> on any platform 11:33:58 <TrueBrain> that would require internet access for first boot, but that is all 11:34:26 <andythenorth_> my assumption is they’re lost in an asset register at Atari 11:34:47 <andythenorth_> and won’t be dug out ever 11:34:51 <TrueBrain> Atari has granted distribution rights of the original set to at least one company over the years; so not lost, it seems 11:35:07 <TrueBrain> but okay, there is no benefit for us to go down that road 11:36:15 <Eddi|zuHause> TrueBrain: i think the bootstrap and the bundling are totally orthogonal 11:36:25 <TrueBrain> Eddi|zuHause: but we can do, is to have 2 'installers' .. a thin, and one with everything in it, I guess 11:36:40 <TrueBrain> Eddi|zuHause: yes. My point is exactly this: have the bundling without any OpenGFX 11:36:49 <TrueBrain> and use bootstrap on all platforms to get it 11:36:57 <TrueBrain> we now have a mix of those 11:37:08 <TrueBrain> not all platforms support bootstrap, not all platforms bundle with OpenGFX 11:37:43 <TrueBrain> but we can make 'fat' installers and 'thin' installers 11:37:44 <Eddi|zuHause> and i was saying, have nightlies with the "thin" installer, and releases with the "everything" installer 11:38:01 <TrueBrain> yeah, I don't think we should do it like that 11:38:13 <TrueBrain> I am pretty sure many people have internet access .. so the thin works for them 11:38:16 <TrueBrain> even for releases 11:38:22 <TrueBrain> saves a lot of bandwidth 11:38:25 *** andythenorth_ has quit IRC 11:40:32 <Eddi|zuHause> anyway, we should probably rework the bootstrap, so that openttd comes with a minimal gfx that at least allows startup and access to bananas 11:41:08 <Eddi|zuHause> that would happen before loading the intro game 11:41:30 <Eddi|zuHause> and wouldn't rely on stuff like font loading 11:41:55 <TrueBrain> exactly that 11:42:02 <TrueBrain> an universal one 11:42:34 <TrueBrain> and I think we should always promote to download the thin variant, where the bootstrap takes over 11:42:41 <TrueBrain> as otherwise our bandwidth bill will increase drasticly :D 11:43:35 <Eddi|zuHause> i still think the bandwidth difference would be marginal. but you have more data about that :p 11:43:56 <TrueBrain> you avoid people downloading OpenGFX on upgrade 11:44:00 <TrueBrain> often on upgrade the already have it 11:44:20 <Eddi|zuHause> but, at least with this upgrade, they also need to upgrade opengfx 11:44:27 <TrueBrain> most people already did 11:44:35 <TrueBrain> when a new OpenGFX is released, bandwidth spikes for a bit 11:44:42 <TrueBrain> because people are really about that "update content" button 12:02:55 *** circ-user-3HYVs has quit IRC 12:12:47 *** Thedarkb-T60 has quit IRC 12:14:56 *** Thedarkb-T60 has joined #openttd 12:17:29 <Eddi|zuHause> TrueBrain: we need delta-downloads :p 12:17:42 *** andythenorth has joined #openttd 12:18:18 <andythenorth> many grfs :P 12:18:26 <andythenorth> in a wrapper 12:18:33 <andythenorth> faster compiles too :P 12:19:04 <Eddi|zuHause> andythenorth: sure. write down a list, put "santa" on the envelope. 12:19:35 * andythenorth adds 'delta downloads' to the santa list 12:20:07 <TrueBrain> okay, NSIS installer looks nice now .. except for the details of the executable .. that seems not possible to set .. while NSIS can do it, CMake doesn't .. odd 12:22:30 <andythenorth> oh var 8E and 8F https://github.com/OpenTTD/OpenTTD/blob/master/src/newgrf_industries.cpp#L355 12:22:33 <andythenorth> I don't even.... 12:22:37 <andythenorth> how does that work? :( 12:23:40 <andythenorth> the problem to solve is that FIRS seems to depend on these vars https://github.com/andythenorth/firs/blob/master/src/templates/produce_primary.pynml#L10 12:23:46 <andythenorth> and that needs to not be the case 12:23:52 <Eddi|zuHause> andythenorth: it returns rate[0] or rate[1] 12:24:03 <andythenorth> clever 12:24:05 <Eddi|zuHause> andythenorth: sounds like a case for a 6x var 12:24:36 <nielsm> I think 6x vars for industries are exhausted... 12:24:36 <Eddi|zuHause> return rate[parameter] 12:25:08 <Eddi|zuHause> 6x vars go to 7F 12:25:31 <nielsm> oh, good 12:25:44 * andythenorth tries to work out what determines production_rate 12:28:59 *** m3henry has joined #openttd 12:29:01 <Eddi|zuHause> there seem to be more 8x variables that follow this pattern that need to be replaced? 12:29:42 <Eddi|zuHause> like transported amount 12:32:21 <Eddi|zuHause> "NewGRFs shouldn't be doing pointer magic" haha :) 12:32:44 <andythenorth> how many 8x vars have a 6x equivalent? https://github.com/OpenTTD/OpenTTD/pull/6867 12:36:38 <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry updated pull request #7324: Codechange: [C++11] Use override specifer for overriding member declarations https://git.io/fhxq0 12:37:44 *** synchris has quit IRC 12:41:59 <Eddi|zuHause> first glance: 88/9: xx, 8A/C: 69, 8E/F: xx 90/1/2: xx 94/96: 6A, 98/A: 6B, 9C/D: xx, 9E/A0: 6C, A2/4: 6D 12:42:12 <Eddi|zuHause> dunno where 6E and 6F come from 12:45:47 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7270: Introduce CMake (and removing all other project-related code) https://git.io/fhbqc 12:45:56 <TrueBrain> there, that finishes the NSIS installer :) Looks pretty, as far as I can tell :) 12:46:17 <nielsm> 6E is an extension of B4 12:47:41 <nielsm> 6F is 40/41/42 12:48:18 <nielsm> bbl, going outside for a bit 12:49:27 <andythenorth> TrueBrain: \o/ 12:53:13 <andythenorth> maybe I can move all primary production to the cb 12:53:17 <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z commented on pull request #6867: 16 cargo types in and out for industries https://git.io/fjJXr 12:53:23 <andythenorth> then var 8E / 8F isn't needed 12:55:17 * andythenorth wants to subscribe to planetmaker's newsletter 12:55:28 <andythenorth> industry newgrf spec is :( 12:57:11 <DorpsGek_II> [OpenTTD/OpenTTD] michicc commented on pull request #7324: Codechange: [C++11] Use override specifer for overriding member declarations https://git.io/fjJXi 13:11:42 <andythenorth> so what is production_rate derived from? 13:13:50 <andythenorth> I assume it's prod_level * cargo multipliier 13:14:37 <andythenorth> or I just ignore all this and write my own primary production 13:16:39 *** Flygon has quit IRC 13:28:38 <andythenorth> hmm, I need to know the calculation though 13:36:50 <andythenorth> cargo multiplier * (prod level / 16) ? 13:37:24 *** Thedarkb-T60 has quit IRC 13:44:16 *** Thedarkb-T60 has joined #openttd 13:44:31 <peter1138> Eddi|zuHause, docking tile *is* just a map bit. 13:45:59 *** Thedarkb-T60 has quit IRC 13:47:24 <peter1138> Eddi|zuHause, in fact that change is part of multi-tile docks, which is already PR'd 13:49:25 <Eddi|zuHause> then i don't know what the problem is 13:54:58 *** synchris has joined #openttd 14:07:11 <peter1138> Maybe I should do dock layouts, like industries have. 14:07:19 <peter1138> (And indeed airports) 14:07:29 *** gelignite has quit IRC 14:08:18 <peter1138> TrueBrain, should we add more stuff to the backport PR or add that later? 14:10:29 *** sla_ro|master has quit IRC 14:12:51 <TrueBrain> peter1138: later, I would say 14:12:56 <TrueBrain> we can always open a new one 14:13:52 <TrueBrain> owh, wait, there is one new one .. sure, I can add that 14:14:40 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7397: Backport marked PRs to 1.9 https://git.io/fjJ4C 14:16:06 <nielsm> hmm, if we add extra industry vars for those Eddi|zuHause pointed out are missing, is that in 1.9.0 or 1.9.1, or 1.10? 14:16:22 <peter1138> 1.10 14:16:34 <Eddi|zuHause> it's a bit late for 1.9 14:16:56 <nielsm> the newgrf version _can_ be bumped to have something for authors to test against 14:19:29 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN approved pull request #7397: Backport marked PRs to 1.9 https://git.io/fjJ1M 14:21:42 <peter1138> Damn, LordAro beat me again. 14:23:38 <TrueBrain> to what? 14:24:24 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain merged pull request #7397: Backport marked PRs to 1.9 https://git.io/fjJ4C 14:25:18 <peter1138> Cycling. He did 112.8 km this morning, I only did 109.2 km. 14:26:32 <TrueBrain> :o 14:29:13 <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry updated pull request #7324: Codechange: [C++11] Use override specifer for overriding member declarations https://git.io/fhxq0 14:31:00 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain opened pull request #7406: Update: Changelog for 1.9.0-RC2 and prepare for release https://git.io/fjJ1N 14:31:03 <TrueBrain> please review my changelog ^^ 14:33:03 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7406: Update: Changelog for 1.9.0-RC2 and prepare for release https://git.io/fjJ1N 14:33:37 <andythenorth> do we need new vars for 8E, 8F? 14:33:54 <andythenorth> how about we drop industry action 0 production, and only do it on prod. cb? 14:34:17 <peter1138> Backwards compatibility says no. 14:34:39 <TrueBrain> do we wait for the two remaining 1.9.0 entries before releasing RC2? (https://github.com/OpenTTD/OpenTTD/pull/7405 and https://github.com/OpenTTD/OpenTTD/pull/7376) 14:34:42 <nielsm> 8E and 8F still work, just only for the first two cargos :P 14:34:59 <peter1138> TrueBrain, unless you want to do an RC3, I think so. 14:35:07 <andythenorth> but we have a newgrf spec no? 14:35:13 <andythenorth> so we don't delete the vars 14:35:16 <TrueBrain> peter1138: we don't have to do an RC before release, for some fixes 14:35:25 <andythenorth> we just make grf v9 drop the old production props and vars 14:35:28 <TrueBrain> it is perfectly fine to fix them next week, and just release this weekend, in my opinion 14:35:44 <TrueBrain> mostly, I wonder what the ETA is on one of those two :D 14:37:18 <peter1138> Sometimes you just need to do it yourself :p 14:38:25 <TrueBrain> yeah .... I have been tempted a few times already ... including just reverting the patch and saying: 1.10 a new chance! 14:38:53 <peter1138> That's not a terrible idea. 14:39:51 <planetmaker> going through with 1.9 as a test for a whole release cycle wouldn't be bad. If we feel like... just let's add necessary stuff to 1.9.1. or release 1.10 early 14:40:38 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7405: Fix #7400: WaterClass for tree tiles was not converted for old saves preventing industry creation. https://git.io/fjJoP 14:40:48 <nielsm> but, 1.10 can't be released until year 20110 14:40:56 <planetmaker> that's pretty late 14:41:33 <planetmaker> so... when do we release 1.9.1? :P 14:42:05 <nielsm> may? 14:42:25 <planetmaker> thinking of same time scheme as 1.10 :P 14:42:33 <planetmaker> s/\.//g 14:43:54 <TrueBrain> I hope 1.9.1 will never exist; as I hope we have 1.10 before we want to release 1.9.1 :P 14:45:10 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7405: Fix #7400: WaterClass for tree tiles was not converted for old saves preventing industry creation. https://git.io/fjJMq 14:46:21 <andythenorth> 1.9.1 is the bug fixes tho :P 14:46:30 <peter1138> No. 14:46:40 <peter1138> Defer to 1.10 14:47:06 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7405: Fix #7400: WaterClass for tree tiles was not converted for old saves preventing industry creation. https://git.io/fjJMm 14:48:38 <DorpsGek_II> [OpenTTD/website] TrueBrain updated pull request #65: Add: Monthly Dev Post of April 2019 https://git.io/fhAzy 14:49:24 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7405: Fix #7400: WaterClass for tree tiles was not converted for old saves preventing industry creation. https://git.io/fjJM3 14:49:57 <TrueBrain> peter1138: why not guard with current savegame revision; when ever that is bumped, it is bumped? 14:50:10 *** Alberth has joined #openttd 14:50:10 *** ChanServ sets mode: +o Alberth 14:50:11 <TrueBrain> (hybrid solution, basically) 14:50:15 <Alberth> o/ 14:50:18 <TrueBrain> hi Alberth 14:50:23 <peter1138> TrueBrain, becuase "current savegame version" in 1.9 is different. 14:50:31 <TrueBrain> ah :D Yes :D 14:50:43 <peter1138> in 1.9 it will always test true. 14:51:03 <TrueBrain> yeah; we no longer can fix that :) 14:51:09 <nielsm> always convert in 1.9, bump sl version in master? 14:51:19 <TrueBrain> ^^ :) 14:51:33 <TrueBrain> we just need to keep that in mind with the backport :) 14:51:50 <peter1138> I can split the PR into 2 commits, one for the fix, one for the bump. 14:52:07 <TrueBrain> that would help for sure 14:52:14 <TrueBrain> keeps a clean cherry-pick 14:52:46 <TrueBrain> what if we revert https://github.com/OpenTTD/OpenTTD/commit/011257dc8804175dd7d1e839e97e796c0a88aee6 only in 1.9 branch? 14:52:54 <LordAro> morn 14:52:55 <TrueBrain> means Samu can continue to fix master 14:53:06 <LordAro> peter1138: :D 14:54:23 *** gelignite has joined #openttd 14:54:42 <TrueBrain> that change is not even mentioned in our changelogs, lol 14:55:16 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7405: Fix #7400: WaterClass for tree tiles was not converted for old saves preventing industry creation. https://git.io/fjJoP 14:56:12 <peter1138> ^^ first commit is unconditional, second adds the bump for master. 14:56:25 <TrueBrain> sweet 14:56:30 <peter1138> TrueBrain, i'm not against reverting that change. 14:56:43 <peter1138> I'm pretty sure Samu is the only user of it. 14:57:04 <TrueBrain> can't revert it cleanly, because you made fixes to it :P 14:57:21 <TrueBrain> peter1138: but do we want to revert it in 1.9 only, was more what I was wondering about 14:57:22 <peter1138> Oh :( 14:57:45 <peter1138> I assumed that's what you meant, heh. 14:58:00 <peter1138> What's so hard about the fix? 14:58:10 <peter1138> Is it just Samu struggling with logic? 14:58:29 <TrueBrain> yup 14:58:38 <TrueBrain> we can also just fix the fix, I guess 14:58:41 <TrueBrain> easier tbh :P 14:58:53 <peter1138> Someone review 7405 so TrueBrain can backport it ;) 14:58:58 <TrueBrain> he doesn't understand what is happening; so most of the code is just an estimation of what should be correct 14:59:46 <TrueBrain> (how we call it in the office: stackoverflow kiddies). But he has to learn, so .. making him think about what is going on is worth it, I guess 15:00:41 <peter1138> Yes, it's a little annoying but at least he is making an effort instead of the usual "i can't code because i wasn't born with the knowledge" bullshit. 15:00:47 <andythenorth> and he tests 15:00:57 <andythenorth> right what am I doing with FIRS? 15:01:00 <TrueBrain> it just takes a lot of effort from our side 15:01:09 <andythenorth> fixing it myself, and not waiting for OpenTTD and nml? 15:01:11 <DorpsGek_II> [OpenTTD/OpenTTD] michicc approved pull request #7324: Codechange: [C++11] Use override specifer for overriding member declarations https://git.io/fjJMz 15:01:15 <andythenorth> using the existing spec? 15:01:27 <andythenorth> or wait for an update to the duplicate spec? 15:01:30 <TrueBrain> okay, reverting is non-trivial .. so I guess we just release 1.9 with this bug :P 15:01:44 <peter1138> andythenorth, what are you waiting for in OpenTTD/nml? 15:02:00 <andythenorth> 16-cargo version of vars 8E and 8F 15:02:36 <peter1138> If you're expecting new vars, you need to file something because we're not actively working on it because we're not aware of a problem. 15:02:48 <andythenorth> to rephrase the question, am I JFDI to make FIRS work, which is easy-ish 15:02:58 <andythenorth> or do I put in the work to make sure we keep extending this oversized spec 15:03:22 <DorpsGek_II> [OpenTTD/OpenTTD] michicc approved pull request #7405: Fix #7400: WaterClass for tree tiles was not converted for old saves preventing industry creation. https://git.io/fjJM2 15:03:29 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7405: Fix #7400: WaterClass for tree tiles was not converted for old saves preventing industry creation. https://git.io/fjJMa 15:04:06 <andythenorth> JFDI then 15:04:11 <andythenorth> because it makes FIRS simpler 15:04:42 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh approved pull request #7405: Fix #7400: WaterClass for tree tiles was not converted for old saves preventing industry creation. https://git.io/fjJMr 15:04:52 <andythenorth> what's the algorithm for 256 tick industry production? 15:04:53 <nielsm> very much approval 15:05:01 <TrueBrain> and yet I have a remark :P 15:05:02 <andythenorth> I have looked in src, but I can't make sense of it 15:05:18 <andythenorth> I need to replicate the OpenTTD algorithm in FIRS 15:06:41 <peter1138> Oh. If I fix that then the approvals go :p 15:06:55 <TrueBrain> :D Up to you :P 15:07:27 <peter1138> Might as well, there are eyes around to reapprove it? :) 15:07:37 <TrueBrain> that will be fine :) 15:07:38 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #7405: Fix #7400: WaterClass for tree tiles was not converted for old saves preventing industry creation. https://git.io/fjJMr 15:07:39 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #7405: Fix #7400: WaterClass for tree tiles was not converted for old saves preventing industry creation. https://git.io/fjJM2 15:07:40 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7405: Fix #7400: WaterClass for tree tiles was not converted for old saves preventing industry creation. https://git.io/fjJoP 15:07:45 <peter1138> Ooh spammy 15:08:00 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain approved pull request #7405: Fix #7400: WaterClass for tree tiles was not converted for old saves preventing industry creation. https://git.io/fjJM6 15:08:04 <nielsm> andythenorth: it just adds production_rate for each cargo to the waiting cargo 15:08:08 <DorpsGek_II> [OpenTTD/OpenTTD] michicc approved pull request #7301: Feature: When filtering purchase list by cargo type, make buy button perform a refit if required. https://git.io/fjJMi 15:08:17 <andythenorth> it uses prod_level as well, no? 15:08:26 <peter1138> Gotta wait for CI :D 15:08:29 <andythenorth> production_rate is derived, not constant 15:08:42 <nielsm> andythenorth: indirectly it does, depends on the smooth economy setting 15:08:49 <TrueBrain> tempted to overrule the CI, but .. I will wait .. :P 15:08:49 <andythenorth> and the industry prod level 15:09:12 <andythenorth> I think it's "cargo prod rate * (prod level / 16)" 15:09:16 <andythenorth> but I'm not sure 15:09:23 <peter1138> So I tried the alternative method of not using waterclass for tree tiles at all 15:09:29 <peter1138> It made the code way more ugly :/ 15:09:40 <nielsm> andythenorth: see Industry::RecomputeProductionMultipliers (line 2257) 15:09:51 <nielsm> that's how it calculates production_rate for non-smooth economy 15:09:51 <peter1138> Anyway, I guess we can now have swamps and mangos? :p 15:09:54 <peter1138> err 15:09:58 <peter1138> mangroves? 15:10:03 <TrueBrain> tasty things 15:10:03 <nielsm> for smooth economy, I think production_rate is just incremented/decremented 15:10:07 <DorpsGek_II> [OpenTTD/OpenTTD] michicc merged pull request #7324: Codechange: [C++11] Use override specifer for overriding member declarations https://git.io/fhxq0 15:11:03 <peter1138> heh, now everything conflicts :p 15:11:08 <andythenorth> yeah so what's CeilDiv 15:11:11 * andythenorth looks it up 15:11:14 <peter1138> Ceiling div. 15:11:23 <peter1138> It rounds differently, I think. 15:11:34 <andythenorth> doctor google says it's java :P 15:11:38 <nielsm> yeah, round up instead of down 15:12:08 <nielsm> CeilDiv(101, 100) == 2 15:12:18 <andythenorth> second parameter is the divisor? 15:12:41 <nielsm> yes 15:13:11 <andythenorth> ok so yeah it's "(cargo multiplier * prod level) / 16" 15:13:35 <TrueBrain> how ever often I look at the "Start AIs immediately", I keep having issues with the whole approach 15:13:42 <TrueBrain> it is now just terrible design, tbh 15:14:27 <DorpsGek_II> [OpenTTD/OpenTTD] michicc updated pull request #7379: Codechange: Use C++11 functions for threading https://git.io/fjvlz 15:14:57 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN dismissed a review for pull request #7301: Feature: When filtering purchase list by cargo type, make buy button perform a refit if required. https://git.io/fjJMi 15:14:58 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7301: Feature: When filtering purchase list by cargo type, make buy button perform a refit if required. https://git.io/fhAIp 15:15:21 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7301: Feature: When filtering purchase list by cargo type, make buy button perform a refit if required. https://git.io/fjJMy 15:15:27 <TrueBrain> start_date is the amount of days between AIs .. not the date it will start on 15:15:31 <TrueBrain> terrible naming :) 15:16:45 <DorpsGek_II> [OpenTTD/OpenTTD] michicc approved pull request #7301: Feature: When filtering purchase list by cargo type, make buy button perform a refit if required. https://git.io/fjJMS 15:16:50 <TrueBrain> say I have 2 AIs with start_date = 0, 1 with start_date of 2 years, and 2 more of start_date = 0 15:16:58 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN merged pull request #7405: Fix #7400: WaterClass for tree tiles was not converted for old saves preventing industry creation. https://git.io/fjJoP 15:17:04 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN closed issue #7400: Funding a new primary industry fails on top of trees https://git.io/fjJu2 15:17:09 <TrueBrain> what happens now, with Samu's approach, that 2 start immediately .. nothing for 2 years ... 3 more pop up 15:17:11 <TrueBrain> is that expected? 15:17:19 <nielsm> TrueBrain yes that's correct 15:17:30 <nielsm> the AIs are supposed to start in the order given 15:17:41 <TrueBrain> feels weird, but fair enough :) 15:17:42 <nielsm> with the delay given 15:18:36 <LordAro> TrueBrain: didn't you write it? :p 15:18:59 <TrueBrain> not with '0' 15:19:00 <TrueBrain> no 15:19:10 <TrueBrain> still not sure I like that feature to start with 15:19:20 <TrueBrain> still don't understand why we want it 15:19:29 <michi_cc> #7401 wanted? I would say yes. 15:19:50 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7406: Update: Changelog for 1.9.0-RC2 and prepare for release https://git.io/fjJ1N 15:19:56 <andythenorth> TrueBrain: isn't it wanted because we can? 15:20:03 <nielsm> original game has four "competitor start time" settings: immediate, 3 months after player, 6 months after player, 9 months after player... but I'm not sure if that's 3 months and then everyone starts simultaneously, or 3 months delay between each ai start 15:20:26 <TrueBrain> peter1138: backported :P 15:20:30 <peter1138> michi_cc, I was wondering if there's some occasion where autoreplace could fail and you'd end up with no news, but I guess autoreplace failing would make its own news anyway. 15:20:41 <TrueBrain> nielsm: 3 months between each 15:21:05 <michi_cc> peter1138: The message is already skipped for autorenew, and that could fail as well. 15:21:06 <TrueBrain> peter1138: there was a merge conflict; please check if I resolved it correctly :D 15:21:22 <peter1138> TrueBrain, urgh! 15:22:02 *** Pikka has quit IRC 15:22:11 <peter1138> Yes, looks good. 15:22:16 <TrueBrain> \o/ 15:22:18 <peter1138> Silly us, adding new features ;) 15:22:26 <michi_cc> nielsm: You really want to review #7379, don't you? :p 15:22:44 *** andythenorth has quit IRC 15:24:49 <peter1138> We must have had a lot of CI jobs queued. 15:26:43 <michi_cc> nielsm: #7374 needs a rebase. 15:28:51 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN merged pull request #7301: Feature: When filtering purchase list by cargo type, make buy button perform a refit if required. https://git.io/fhAIp 15:31:40 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7376: More than max_no_competitors could be created in network games https://git.io/fjvY8 15:32:33 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7376: More than max_no_competitors could be created in network games https://git.io/fjvY8 15:32:45 <peter1138> That PR title has a story all by itself. 15:33:06 <peter1138> Samu doesn't get the concept of Why rather than What, I guess. 15:33:40 <TrueBrain> peter1138: would you mind giving it a look, the PR? I think this at least makes it somewhat understandable 15:33:58 <TrueBrain> still not really happy with how the whole start_date has become, but that is not for this PR I guess 15:34:58 <TrueBrain> and still not happy to add this to 1.9 1 week before release .. but that is a different story :) 15:35:01 *** Wormnest has joined #openttd 15:35:10 <TrueBrain> these are the things that can cause a 1.9.1 within a week :P 15:38:05 <LordAro> i think i agree that it should be removed for 1.9 15:38:42 <DorpsGek_II> [OpenTTD/OpenTTD] michicc commented on pull request #7351: Add: Warn players that company passwords are not truly secure https://git.io/fjJDO 15:38:48 <TrueBrain> I rather have we do that .. would you mind giving it a try LordAro? 15:38:58 <TrueBrain> I got a bit stuck because of changes on changes :D 15:39:10 <TrueBrain> (the moments you notice you don't understand the code enough to be useful :D) 15:39:45 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7376: More than max_no_competitors could be created in network games https://git.io/fjJDs 15:39:51 <LordAro> TrueBrain: you think i do? :p 15:40:16 <DorpsGek_II> [OpenTTD/OpenTTD] michicc commented on pull request #7351: Add: Warn players that company passwords are not truly secure https://git.io/fjJDZ 15:40:20 <TrueBrain> meh; was hoping :P 15:41:32 *** supermop_Home_ has joined #openttd 15:41:39 <LordAro> i mean, i can do it anyway :p 15:41:39 <supermop_Home_> yo 15:41:46 <peter1138> supermop_Home_, mornign 15:42:17 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh commented on pull request #7351: Add: Warn players that company passwords are not truly secure https://git.io/fjJDC 15:43:36 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7406: Update: Changelog for 1.9.0-RC2 and prepare for release https://git.io/fjJ1N 15:43:50 <TrueBrain> LordAro: please do; I tried it ^^, but I would like a second opinion if that is correct :) 15:44:08 <nielsm> anyway: yes, also back to 1995 "competitors start: 3 months after player" setting means there is 3 month delay between each AI starts 15:44:48 <TrueBrain> that makes the most sense I guess 15:44:59 <TrueBrain> do I read the code correctly that an AI can now also influence this? 15:45:15 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7351: Add: Warn players that company passwords are not truly secure https://git.io/fjJD8 15:46:16 <LordAro> TrueBrain: https://github.com/OpenTTD/OpenTTD/commit/b1e40b6b569c206d672f677a8e474a73ecf2173b should also be reverted 15:46:35 <TrueBrain> LordAro: does it? I mean .. it doesn't hurt, does it? 15:46:43 <TrueBrain> (and it also fixes CMD_PAUSE) 15:46:47 <LordAro> well, possibly 15:46:55 <LordAro> i only saw that it referenced the original PR 15:46:56 <TrueBrain> owh, no, that was already a special case 15:46:57 <TrueBrain> you are right 15:47:13 <LordAro> by luck :p 15:48:53 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7406: Update: Changelog for 1.9.0-RC2 and prepare for release https://git.io/fjJ1N 15:50:22 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7376: More than max_no_competitors could be created in network games https://git.io/fjJDB 15:50:33 <TrueBrain> that makes the revert a lot cleaner at least :) 15:52:20 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7406: Update: Changelog for 1.9.0-RC2 and prepare for release https://git.io/fjJ1N 15:52:23 <TrueBrain> lets also backport languages .. 15:52:31 <TrueBrain> seems my Python script works well :D 15:55:26 <supermop_Home_> hows it going 15:56:21 <TrueBrain> about 30 kilometers per second 15:56:50 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #7406: Update: Changelog for 1.9.0-RC2 and prepare for release https://git.io/fjJDu 15:57:50 <TrueBrain> tnx LordAro 15:58:46 <TrueBrain> ld: warning: object file (/usr/local/opt/freetype/lib/libfreetype.a(ftlzw.o)) was built for newer OSX version (10.13) than being linked (10.9) 15:58:50 <TrueBrain> guess that should be fixed too 15:59:50 *** Thedarkb-T60 has joined #openttd 16:00:36 <TrueBrain> so RC2 release? 16:00:49 <TrueBrain> LordAro: btw, was the changelog okay like this? (don't really know how you made it before :D) 16:00:59 <TrueBrain> I just did a "git log --oneline", and added PRs where needed 16:01:06 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #7279: Fix #7062: Remove ship max order distance. https://git.io/fjJDg 16:03:45 <DorpsGek_II> [OpenTTD/OpenTTD] michicc commented on pull request #7279: Fix #7062: Remove ship max order distance. https://git.io/fjJD2 16:04:24 <LordAro> TrueBrain: #7384 never appeared in any release, that line can be removed 16:05:33 <LordAro> everything else looks fine, imo 16:05:39 <LordAro> could remove the Change: line altogether 16:05:59 <TrueBrain> done 16:06:02 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain dismissed a review for pull request #7406: Update: Changelog for 1.9.0-RC2 and prepare for release https://git.io/fjJDu 16:06:03 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain updated pull request #7406: Update: Changelog for 1.9.0-RC2 and prepare for release https://git.io/fjJ1N 16:06:05 <TrueBrain> now to wait 10+ more minutes :P 16:06:38 *** Samu has joined #openttd 16:07:10 <TrueBrain> after that I will release RC2 :) I like seeing all the CD parts purring into action :) 16:07:21 <LordAro> :) 16:07:31 <TrueBrain> (owh, and please approve, ofc :P) 16:07:36 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro approved pull request #7406: Update: Changelog for 1.9.0-RC2 and prepare for release https://git.io/fjJDo 16:07:48 <TrueBrain> <3 16:12:25 <TrueBrain> https://www.reddit.com/r/space/comments/b4tsen/an_astronaut_in_microg_without_access_to_handles/ <- for those who need a laugh :) 16:13:04 <Samu> hi 16:13:32 <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry opened pull request #7407: Codechange: Use null pointer literal instead of the NULL macro https://git.io/fjJDX 16:16:01 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7407: Codechange: Use null pointer literal instead of the NULL macro https://git.io/fjJDy 16:16:08 <Eddi|zuHause> moar C++11!!! 16:16:18 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain merged pull request #7406: Update: Changelog for 1.9.0-RC2 and prepare for release https://git.io/fjJ1N 16:17:03 <Eddi|zuHause> compile errors still unreadable 16:17:33 <Eddi|zuHause> "##[error]*** b/src/stdafx.h:180: Preprocessor hash is put into the first column, before the tab indentation: ' #pragma warning(disable: 6011) // code analyzer: Dereferencing nullptr pointer 'pfGetAddrInfo': Lines: 995, 996, 998, 999, 1001'" 16:17:34 <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry commented on pull request #7407: Codechange: Use null pointer literal instead of the NULL macro https://git.io/fjJDQ 16:18:36 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7407: Codechange: Use null pointer literal instead of the NULL macro https://git.io/fjJD7 16:18:40 <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z commented on pull request #7407: Codechange: Use null pointer literal instead of the NULL macro https://git.io/fjJD5 16:19:38 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7407: Codechange: Use null pointer literal instead of the NULL macro https://git.io/fjJDF 16:19:42 <m3henry> Lol? Why would anyone dereference NULL? 16:20:06 <LordAro> maybe just remove that line entirely? 16:20:19 <TrueBrain> I am sure the commit checker will find many more instances where the # is on the wrong place 16:20:24 <TrueBrain> as we used to suck at doing that correctly 16:21:11 <LordAro> especially since pfGetAddrInfo doesn't seem to exist... 16:21:25 <TrueBrain> most likely one of the OSes I threw out :P 16:21:44 <TrueBrain> not even that 16:22:05 <Eddi|zuHause> cleaning that up is probabl out of scope for the PR :p 16:22:59 <Eddi|zuHause> "Process 'msbuild.exe' exited with code '1'." sounds only marginally more helpful than the linux errors :p 16:22:59 <TrueBrain> hmm .. up till 1.2, that function did not exist :P 16:23:22 <Samu> oh, thanks TrueBrain I was definitely stuck with that for loop, I had no idea how to make it work 16:23:27 <TrueBrain> ##[error]src\video\win32_v.cpp(505,0): Error C2446: '!=': no conversion from 'nullptr' to 'HIMC' 16:23:37 <m3henry> what is a HIMC? 16:23:39 *** Megas has joined #openttd 16:23:43 <TrueBrain> *shrug* 16:24:10 <m3henry> ImmAssociateContext 16:24:12 <Eddi|zuHause> H is windows-speak for "handle"? 16:24:16 <m3henry> some windows thing 16:24:34 <m3henry> is not a pointer 16:24:37 <Eddi|zuHause> which is a fancy word for "pointer"/"index"? 16:24:45 <TrueBrain> did you know: if you create a new GitHub project, it allows you to create an Azure Pipelines immediately :) 16:25:03 <m3henry> The documentation says that it should be comapred with NULL 16:25:27 <TrueBrain> guess you found some non-C++11 compatible windows thingy? :D 16:25:45 <m3henry> NULL is always false, so instead just conversion to bool 16:26:04 <m3henry> So I guess I need to replace all comparisons with NULL first 16:26:12 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN opened pull request #7408: More override keyword use https://git.io/fjJye 16:27:56 <m3henry> Or I could just ignore those few instances for now 16:28:19 <m3henry> I think LordAro suggested dropping comparisons with NULL in the vector PR 16:28:21 <peter1138> Hmm, it's pretty cold outside. I can tell because my pantry, and therefore my beer, is pretty cold. 16:28:50 <Eddi|zuHause> "Files changed: 489" ... how far off is that from "all files"? 16:29:03 <m3henry> :D 16:30:02 <Samu> the art of commenting code :| 16:30:05 <peter1138> Is Minecraft 1.14 out yet? 16:30:08 <Samu> i'm really bad at it 16:30:15 <peter1138> We noticed. 16:30:28 <LordAro> m3henry: it depends on the comparison - some are sufficient to be "like bools", others are better explicit 16:30:33 <LordAro> can't script that, i'm afraid :p 16:31:20 <peter1138> Don't we shun pretending any comparison is boolean unless it's actually a bool? 16:31:27 <peter1138> There's a few places where that's missing. 16:31:41 <peter1138> nielsm's midi stuff :p 16:31:48 <LordAro> ¯\_(ツ)_/¯ 16:31:52 <m3henry> I've never come across a case where comparing with NULL was clearer than just implicit cast to bool 16:32:03 <Eddi|zuHause> as for the "prevent future uses", can we put an "#undef NULL" somewhere? i think we did that for some alloc functions and stuff? 16:32:24 <LordAro> safeguards.h ? 16:32:32 <peter1138> That's our codestyle though, m3henry . 16:32:44 <LordAro> NULL isn't *always* a define that can be removed 16:33:11 <m3henry> peter1138: could be changed though 16:33:17 <Eddi|zuHause> LordAro: doesn't need to, the CI only needs to catch it in SOME targets? 16:33:29 <LordAro> true 16:33:39 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #7376: More than max_no_competitors could be created in network games https://git.io/fjJyt 16:35:43 <Eddi|zuHause> so, did i understand this right, that 1.9.0 makes the conversion unconditionally, and master has a saveload bump? 16:35:55 <Eddi|zuHause> the tree-water conversion, i mean 16:36:33 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7279: Fix #7062: Remove ship max order distance. https://git.io/fjJyZ 16:36:40 <peter1138> Eddi|zuHause, correct. 16:38:38 <peter1138> If we had JGR's saveload extensions we could've done it with that, but we done. 16:38:46 <peter1138> Maybe we should incorporate them. 16:40:30 <nielsm> is it feature flags instead of incrementing version number? 16:41:21 <Samu> about the comments in MakeNewGameDone() 16:41:40 <Samu> in a dedicated server, the first AI is company 0 16:41:40 <peter1138> nielsm, something like that. 16:42:10 <Samu> in a normal game, the human company is created first, so the first AI company is 1 16:42:41 <Samu> /* Check if the first AI is set to start immediately */ 16:43:04 <Samu> dont know if the comment is fine 16:43:10 <Samu> saying "first" 16:43:22 <Samu> I guess it is 16:43:58 <Samu> it's not the first in the config .ini but the second 16:44:11 <Samu> openttd.cfg, I mean 16:44:33 *** glx has joined #openttd 16:44:33 *** ChanServ sets mode: +v glx 16:44:35 <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry updated pull request #7407: Codechange: Use null pointer literal instead of the NULL macro https://git.io/fjJDX 16:46:03 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #6811: Feature: Add NotRoadTypes (NRT) https://git.io/vhlfg 16:46:24 <peter1138> Gotta give the CI something to do ;) 16:47:35 <Samu> well I'll comment there, I guess 16:48:39 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #7376: More than max_no_competitors could be created in network games https://git.io/fjJyC 16:49:52 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN updated pull request #7408: More override keyword use https://git.io/fjJye 16:50:01 <Samu> wasn't that a rhetorical question? 16:50:03 <Samu> :| 16:50:19 <Samu> ok i guess not 16:51:43 <peter1138> squirrel exporting is in the cmake branch now, right? 16:52:13 <Eddi|zuHause> well, i guess it's fine. the unconditional conversion will die with 1.9.x, where we know it won't do any harm, and master does it properly 16:52:54 <peter1138> Eddi|zuHause, was there a problem? 16:52:54 <Eddi|zuHause> well, "know" is a hard word here :p 16:53:00 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #7376: More than max_no_competitors could be created in network games https://git.io/fjJyB 16:53:20 <Eddi|zuHause> i know of no problem... 16:53:32 <peter1138> You wrote as if I did something wrong. 16:53:53 <glx> peter1138: not yet 16:54:19 <peter1138> glx, I've done plenty wrong, mostly by not thinking about savegame conversion in the first place. 16:54:52 <Eddi|zuHause> peter1138: i was thinking along the lines of "will this cause issues in the future?" 16:55:01 <glx> was replying about squirrel and cmake ;) 16:55:08 <peter1138> glx, :-) 17:01:24 <glx> if you want to test it's at https://github.com/glx22/OpenTTD/commits/cmake_api 17:01:49 *** andythenorth has joined #openttd 17:03:21 <peter1138> I'm just thinking I might as well remove my branch, that's all :) 17:03:30 <peter1138> I have a lot, heh. 17:03:41 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7376: More than max_no_competitors could be created in network games https://git.io/fjJyw 17:04:30 <TrueBrain> glx: I added NSIS to CMake branch; can you give that a spin and check if it is what you would expect? (you can run 'make package' or via MSVC project run the PACKAGE project, to create it) 17:05:06 <TrueBrain> glx: other fun fact, if you 'git clone' via WSL, the MSVC project will keep rebuilding. WSL creates a case sensitive folder, msbuild makes everything lowercase. w00p \o/ (this is why you didn't have the constant-rebuilding-issue, and I have :P) 17:05:11 <peter1138> Okay, how should station coverage area highlight work? 17:05:20 <peter1138> In regards to showing existing stations. 17:05:25 <glx> wow silly 17:06:23 <TrueBrain> @topic set 1 1.9.0-RC2, 1.8.0 17:06:23 *** DorpsGek changes topic to "1.9.0-RC2, 1.8.0 | Website: *.openttd.org (source: github, translator: translator, server list: servers, wiki: wiki) | Don't ask to ask, just ask | 'Latest' is not a valid version, 'Most recent' neither | English only" 17:06:37 <TrueBrain> someone else can write a news post + forum topic, okay? :D 17:06:47 <TrueBrain> as I backported peter1138's stuff, I think it is peter1138's turn to do so :D 17:07:00 <peter1138> I'm worse at writing stuff than Samu. 17:07:12 <TrueBrain> so ... we just say: LordAro, as a FYI :D 17:08:13 <LordAro> pfft. 17:08:25 *** andythenorth has quit IRC 17:08:32 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #7376: More than max_no_competitors could be created in network games https://git.io/fjJyi 17:08:55 <Samu> 1.9.0-RC2 is out? 17:08:57 <Samu> downloading 17:09:21 <Samu> https://www.openttd.org/ 17:09:26 <Samu> meh, the news are wrong then 17:09:40 <glx> news is not written yet ;) 17:10:09 <Samu> Windows Defender SmartScreen does not like it 17:10:18 <Samu> needs more downloads 17:11:39 <Samu> oh no no more instant start ais 17:11:45 <Samu> i hate that random deviation 17:12:02 <peter1138> Fix it for 1.10. 17:13:10 <glx> removed from 1.9 means more time to fix it for 1.10 17:14:39 <Samu> I set up the AIs, but due to this random deviation crap, it can give enough time for human players to take their positions 17:15:22 <peter1138> Ok. 17:15:43 <LordAro> "oh no" 17:16:35 <Samu> instatnly starting them would mean no one would have time to occupy their slots 17:16:46 <Samu> the correct configs are loaded 17:16:53 <Samu> solves a lot of headache 17:16:55 <Samu> for me 17:16:57 <peter1138> What are you going on about? 17:17:06 <Samu> AIs in multiplayer 17:17:39 <Samu> and the random deviation that exists for start_date 17:18:27 <peter1138> Are you complaining or just randomly wittering? 17:18:32 <Eddi|zuHause> that's why i said they should be separately configurable 17:18:45 <Eddi|zuHause> so you can have N slots for human companies and M for AIs 17:19:45 <Eddi|zuHause> also, you could just run the savegame in single player for a while (on fast forward) until the AIs are in place, then start the server with the savegame 17:21:14 <Eddi|zuHause> or make one of those "on_server_start.scr" scripts, that just runs start_ai command a bunch of times... 17:21:31 <peter1138> Such simple. 17:21:32 <Samu> those are the headaches :( 17:22:06 <peter1138> No, the headache was trying to get you to fix it so that it could stay in 1.9. 17:22:37 <peter1138> p.s. it's still in 1.10, and still needs fixing. 17:22:57 <Samu> there's not much to fix, i guess it's only comments from now on 17:24:09 <peter1138> Get on with it then :p 17:24:37 <Samu> the for loop was the last thing needed changes 17:24:48 <Samu> TrueBrain, did it for me 17:25:03 <Eddi|zuHause> you're gonna have to learn to write lots of comments, until you learn to write self-documenting code :) 17:25:18 <LordAro> Samu: have you actually understood what TrueBrain did for you? 17:25:34 <Samu> the for? 17:25:46 <Samu> I wasn't aware that for (;;) was possible 17:26:04 <peter1138> Apart from the whole "spending lots of time trying to help you out"? 17:26:32 <Samu> yes, I try to understand 17:26:53 <Samu> it's hard to view it from a perpective other than the author 17:27:43 <Samu> I get too stuck in what I did 17:31:11 <DorpsGek_II> [OpenTTD/OpenTTD] michicc approved pull request #7408: More override keyword use https://git.io/fjJyA 17:32:56 <peter1138> scripts/game_start.scr: start_ai * 10 17:33:09 <peter1138> ^^ starts all your AIs on game start. 17:33:57 <peter1138> All on tick 0. 17:34:01 <Samu> ewww, terrible 17:34:08 <Samu> then I have to constantly edit it 17:34:09 <peter1138> Yes, working solution , terrible. 17:34:21 <Samu> for whenever I don't want that to happen 17:34:41 <peter1138> You'd have to edit the ai settings anyway. 17:34:57 <Samu> in gui mode, much easier 17:35:08 <peter1138> Or you can name the script something else, and manually execute it. 17:37:36 <Eddi|zuHause> maybe i should read up on what these industry variables actually do? :p 17:38:00 <LordAro> Samu: for a really niche feature that no one else uses or wants? yeah, you don't get a GUI option for that 17:38:08 <LordAro> OTTD isn't your personal playground 17:38:33 <Eddi|zuHause> "Types of cargo produced" "Types of cargo accepted" maybe we don't really need that? 17:38:38 <Samu> why wouldn't anyone want to ? 17:38:45 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro merged pull request #7408: More override keyword use https://git.io/fjJye 17:39:02 <Samu> yesterday I had ppl playing on my server 17:39:07 <Samu> there was 3 ais 17:39:17 <peter1138> And you can still have that. 17:39:31 <peter1138> Just start_ai thrice. 17:39:32 <Eddi|zuHause> it certainly doesn't make sense with "provide the cargo ID as parameter" 17:39:53 <LordAro> peter1138: the console still works in multiplayer, right? 17:40:16 *** supermop_Home_ has quit IRC 17:40:31 <DorpsGek_II> [OpenTTD/OpenTTD] glx22 commented on pull request #7376: More than max_no_competitors could be created in network games https://git.io/fjJSI 17:40:53 <DorpsGek_II> [OpenTTD/OpenTTD] LordAro commented on pull request #7396: Fix: Saving SDT_INTLIST handle unsigned values properly https://git.io/fjJSt 17:42:10 <peter1138> LordAro, yes. 17:42:18 <peter1138> "rcon start_ai" while paused works. 17:44:11 <peter1138> Hmm, still get double autosave :/ 17:44:29 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick commented on pull request #7376: More than max_no_competitors could be created in network games https://git.io/fjJSO 17:44:50 <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z opened pull request #7409: Industry var https://git.io/fjJSs 17:45:13 <Eddi|zuHause> uhm, name needs some work :p 17:50:05 <Eddi|zuHause> but that should address andy's issue (the only one he ever had and will have, i'm sure) 17:51:17 <Eddi|zuHause> how did i misspell NewGRF? 17:52:16 <Eddi|zuHause> oh, it isn't even % 17:54:29 <Samu> glx, I think the commands are executed in EXEC mode immediately 17:54:35 <Samu> but let me test reload 17:55:05 <Samu> that line only seems to be used by ReloadAI 17:55:26 <glx> reload should work num_to_start is 1 in this case 17:56:13 <glx> what can go wrong is if reload style call is done for more than 1 num_to_start 17:58:02 <Samu> I see 17:58:33 <Samu> but it's 1 17:58:48 <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z commented on pull request #7396: Fix: Saving SDT_INTLIST handle unsigned values properly https://git.io/fjJS4 17:58:53 <Samu> unless someone misuses it in the future 17:59:23 <Samu> gonna try 2, see what happens 18:02:28 <Samu> hmm, DC_NONE 18:02:56 *** Megas has quit IRC 18:03:15 <Samu> ok DC_NONE, then queue 18:03:24 <Samu> i wanna see what happens when executing local queue 18:05:01 <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z updated pull request #7396: Fix: Saving SDT_INTLIST handle unsigned values properly https://git.io/fjfhC 18:05:35 <Samu> DC_NONE and DC_EXEC 18:05:37 <Samu> that's really funny 18:07:09 <Samu> it passes that check, and never returns CMD_ERROR 18:07:30 <Samu> company is created, then hits the break 18:07:46 <Samu> res == res2 still 18:07:46 <glx> the current check is to validate company_id 18:08:08 <Samu> return CommandCost(); 18:08:12 <Samu> ah, line 932 18:08:22 <Samu> ok, so both return CommandCost() after all 18:09:07 <glx> yes commands work, but if you pass a company_id I guess they all start in the same slot 18:09:20 <Samu> what if it actually errored 18:09:27 <Samu> it would assert at res == res2 test 18:09:29 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh updated pull request #7399: Fix #7374: Ensure k-d trees are always updated when station sign moves https://git.io/fjJBj 18:09:48 <glx> true, this checke is not at the right place anyway 18:10:06 *** frosch123 has joined #openttd 18:10:40 <Samu> gonna try reload 2 now 18:10:57 <Samu> on purpose 18:11:00 <Samu> mauahahah 18:14:05 <Samu> if (Company::IsValidID(company)) return NULL; 18:14:16 <Samu> well, nothing bad happens apparently 18:15:02 <Samu> it can even be 15, only 1 is created 18:15:03 <glx> except only one AI is started when you asked for 2 18:15:16 <glx> and for me it should be an error 18:15:56 <Samu> DoStartupNewCompany returns NULL the 2nd time it tries to create the same ID 18:16:16 *** Wormnest has quit IRC 18:16:45 <Samu> then it breaks, then it returns CommandCost(), and res == res2 18:16:50 <Samu> no problem 18:17:44 <glx> no problem, but it's still a caller error and should be catched before even starting companies 18:18:38 <Samu> ok 18:18:46 <Samu> let me edit this part then 18:19:43 <peter1138> Woo, debug build time :D 18:21:36 <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z updated pull request #7396: Fix: Saving SDT_INTLIST handle unsigned values properly https://git.io/fjfhC 18:22:22 <Samu> if (company_id != INVALID_COMPANY && ais_to_start != 1 && (company_id >= MAX_COMPANIES || Company::IsValidID(company_id))) return CMD_ERROR; 18:24:21 <Samu> and i moving it to before if (!(flags & DC_EXEC)) return CommandCost(); 18:24:32 <Samu> ok lets test 18:25:00 <DorpsGek_II> [OpenTTD/OpenTTD] michicc approved pull request #7399: Fix #7374: Ensure k-d trees are always updated when station sign moves https://git.io/fjJSd 18:26:17 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh merged pull request #7399: Fix #7374: Ensure k-d trees are always updated when station sign moves https://git.io/fjJBj 18:26:24 <DorpsGek_II> [OpenTTD/OpenTTD] nielsmh closed issue #7374: Station sign kd-tree is not updated if station XY changes due to acquiring an ownerless/grey station pending deletion https://git.io/fjeGW 18:28:00 <Samu> it failed the test, didn't even queue the command 18:28:05 <Samu> i see 18:28:30 <planetmaker> so... how much do we care whether the new titlegame has modified NewGRFs? I had to remove manual industries from one of the submissions 18:28:48 <Samu> disclassify 18:28:53 <Samu> but that's just me 18:29:50 <peter1138> Titlegame should not have *any* NewGRFs, let alone modified. 18:30:18 <planetmaker> if it weren't manual industries I'd not ask 18:30:28 <peter1138> I don't know what a manual industry is. 18:30:28 <Eddi|zuHause> just remove it 18:30:28 <planetmaker> removing that probably does not break anything. But yeah 18:30:42 <peter1138> If the game has newgrfs, discard it. 18:30:46 <planetmaker> the name is programme... 18:30:47 <peter1138> Maybe let the author know. 18:31:40 <peter1138> Which one is it? 18:32:09 <planetmaker> I will. the first one 18:32:19 <planetmaker> Just creating all screenshots now, then I'll make a posting 18:32:45 <planetmaker> so... I'll be back in 30 minutes... screen flickering till then :P 18:33:15 <peter1138> manindu.grf 18:33:17 <Eddi|zuHause> you can make screenshots from headless? 18:33:19 <peter1138> What a silly. 18:33:31 <peter1138> " Do not use AIs, GameScripts or NewGRFs. These are automatically disabled. " 18:34:06 <Eddi|zuHause> peter1138: that's probably ill-phrased 18:34:43 <planetmaker> well... it could be much worse 18:35:11 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #7376: More than max_no_competitors could be created in network games https://git.io/fjvY8 18:39:49 <Samu> maybe reloading once would be better english 18:40:41 <Samu> seems that OWNER_DEITY can't start AIs 18:40:50 <Samu> game scripts 18:43:39 <Samu> hmm I didn't do exactly as you asked :( 18:43:47 <Samu> i placed the check in last 18:44:27 <Samu> ok let me re-do 18:44:53 <glx> order doesn't really matter for && 18:45:07 <Samu> yeah, but readability stuff 18:45:27 <Samu> would it be better at start I guess 18:46:57 <Eddi|zuHause> you want to check the condition first that fails more often, or is easier to calculate, with && 18:47:47 <glx> or maybe just a if (num_to_start !=1 && company_id != INVALID_COMPANY) return CMD_ERROR; then the old check 18:48:45 <Eddi|zuHause> (but that is probably a microoptimization) 18:51:19 <Samu> hmm 18:51:49 <Samu> it was wrong 18:51:52 <Samu> if (company_id != INVALID_COMPANY && (company_id >= MAX_COMPANIES || Company::IsValidID(company_id)) || ais_to_start != 1) 18:52:07 <Samu> or ais_to_start > 1 18:53:02 <glx> !=1 is ok, we check 0 before 18:53:25 <Samu> what's wrong was the && 18:53:27 <Samu> it's a || 18:53:34 <glx> indeed 18:54:02 <glx> easy to notice when you do i in 2 lines 18:56:20 <glx> and move num_to_start check before IsValidID check, will skip the call if true 18:57:27 <Samu> https://paste.openttdcoop.org/prdve2hgh 18:59:04 <Samu> switch 2 with 3 18:59:33 <Samu> https://paste.openttdcoop.org/pfuhbl0yr 18:59:59 <peter1138> http://fuzzle.org/~petern/ottd/catchment3.png -> http://fuzzle.org/~petern/ottd/catchment4.png 19:00:08 <peter1138> ^ thwarted somewhat by the mouse cursor being invisible :p 19:00:39 <peter1138> So when it joins an existing station, it highlights the catchment for the complete station. 19:01:34 <Samu> https://paste.openttdcoop.org/pqbk9yybt 19:03:43 <Samu> I wonder if IsValidID doesn't already return false for companies over MAX_COMPANIES 19:03:57 <Samu> must test 19:05:24 <DorpsGek_II> [OpenTTD/OpenTTD] stormcone commented on pull request #7270: Introduce CMake (and removing all other project-related code) https://git.io/fjJ9K 19:06:52 <Samu> ok, it returns false, and what I want is it to return true so it can fail 19:06:57 *** nielsm has quit IRC 19:07:53 *** SimYouLater has joined #openttd 19:08:56 <SimYouLater> https://www.tt-forums.net/viewtopic.php?f=26&t=84905&p=1218991#p1218991 19:09:39 <Samu> https://paste.openttdcoop.org/pwdz0xly8 19:10:01 <Samu> good, or I better do it in 1 line? 19:10:10 <SimYouLater> ^ Can someone help me figure out why Recycled Infrastructure Set is not working right? There are no vehicles on the Utility Pole rails or Early Rail replacements. 19:11:51 <Samu> ok 19:11:53 <DorpsGek_II> [OpenTTD/OpenTTD] janisozaur commented on pull request #7270: Introduce CMake (and removing all other project-related code) https://git.io/fjJ9X 19:12:28 <SimYouLater> This is my last resort, so if I can't get help here then I'll probably abandon my OpenTTD projects and quietly leave the community. 19:12:59 <Eddi|zuHause> Cut my life into pices? 19:14:12 <DorpsGek_II> [OpenTTD/OpenTTD] nikolas updated pull request #7086: Change #6173: Update SDL driver to use SDL 2.0 https://git.io/fhamZ 19:14:16 <peter1138> Hi SimYouLater. 19:14:59 <peter1138> SimYouLater, please give us some time to take a look. 19:15:15 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #7376: More than max_no_competitors could be created in network games https://git.io/fjvY8 19:15:38 <Eddi|zuHause> SimYouLater: you could help us by breaking it down for us what you were expecting and what happens? 19:16:33 <Samu> should I change TrueBrain's comment in here? https://github.com/OpenTTD/OpenTTD/pull/7376#issuecomment-475971582 19:16:40 <Samu> feels counter productive 19:17:04 <Samu> I guess I better wait 19:17:46 <Samu> wrong link https://github.com/OpenTTD/OpenTTD/pull/7376#discussion_r268442536 19:18:25 <peter1138> Hmm, wrong path-separator. 19:19:29 <Samu> none = start_date=0 is the first AI 19:19:34 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7270: Introduce CMake (and removing all other project-related code) https://git.io/fjJ9H 19:19:46 <Samu> but this is only valid for dedicated server 19:21:01 <Samu> "LuDiAI AfterFix" = air_support=1 is the first available AI, after the HU company is created 19:21:14 <Samu> the second on that list 19:21:55 <Samu> meh... and to think it's just a damn comment 19:21:59 <Samu> why bother so much 19:23:50 <peter1138> SimYouLater, so with the utility poles, I see 'vehicles' available to purchase. 19:24:11 <peter1138> SimYouLater, and they seem to work. What's the issue with them that you see? 19:26:05 <SimYouLater> Hold on, I'll take a look. 19:26:07 <DorpsGek_II> [OpenTTD/OpenTTD] janisozaur commented on pull request #7270: Introduce CMake (and removing all other project-related code) https://git.io/fjJ9x 19:27:19 <Eddi|zuHause> my sed-fu failing to handle the \ 19:27:43 <Eddi|zuHause> how does this even compile on windows? 19:28:03 <peter1138> %s@\@/@g 19:28:07 <peter1138> (In vim :p) 19:28:20 <DorpsGek_II> [OpenTTD/OpenTTD] TrueBrain commented on pull request #7270: Introduce CMake (and removing all other project-related code) https://git.io/fjJHe 19:28:23 <peter1138> And then revert the /02 back to . 19:28:33 <Eddi|zuHause> that's replacing some valid \ at the end of the line 19:28:47 <peter1138> I only did it for ris.nml 19:29:17 <Eddi|zuHause> oh, after gcc 19:29:17 <peter1138> That seems to be the only one with the problem. 19:29:35 <Eddi|zuHause> well, .nml is a generated file 19:29:42 <peter1138> Oh. 19:30:28 <SimYouLater> Okay, I just checked. The vehicles from WIRES (electricity) that I included in RIS are showing up, but not the vehicles from Wired (telecom). 19:31:00 <peter1138> So vehicles in another newgrf are not working with it? 19:34:07 *** Supercheese has joined #openttd 19:34:48 <SimYouLater> I included the vehicles from WIRES and Wired in the RIS NewGRF (both are GPL v2) to reduce th e number of required NewGRFs. 19:35:08 <peter1138> So not a separate newgrf. 19:35:34 <peter1138> You probably need to explain a LOT more because we don't know anything about what you've been doing. 19:35:41 <peter1138> So please don't assume things. 19:35:57 <SimYouLater> Sorry. 19:36:26 <SimYouLater> Okay, Recycled Infrastructure Set is a track set designed to replace several other GPL v2 NewGRFs. 19:36:34 <TrueBrain> building new binaries for NRT, BECAUSE I CAN. :D 19:36:45 <peter1138> TrueBrain, it would be easier if it was merged... 19:36:48 <Eddi|zuHause> gah... compile failing now because of new produce syntax 19:36:53 <peter1138> Once 1.9 was forked... 19:37:03 <peter1138> Eddi|zuHause :-) 19:37:09 <Eddi|zuHause> WHO WAS THIS IDIOT WHO SAID WE DON'T NEED BACKWARDSCOMPATIBILITY? 19:37:23 <TrueBrain> peter1138: that is not me that is keeping you from merging :) All I can do is help out with the powers I do have :P 19:37:41 * LordAro hides 19:37:57 <peter1138> SimYouLater, you've got one instance in utilitytrains.pnml of "UPOLE" instead of "UPOLES" 19:39:38 <peter1138> SimYouLater, that's not really what I mean by "explain a LOT" 19:40:03 <peter1138> SimYouLater, we have no idea what vehicles are _meant_ to appear. 19:43:08 <SimYouLater> All of the vehicles in RIS are meant to appear. If you want specifics, that would require me to check the other NewGRFs I borrowed code and sprites from. 19:43:39 <DorpsGek_II> [OpenTTD/website] TrueBrain opened pull request #69: Create 2019-03-24-1.9.0-RC2.md https://git.io/fjJHI 19:43:59 <Eddi|zuHause> nmlc warning: "src/earlytype1.pnml", line 139: "gfx/rails/1568_WGWY/lc_right.png" at [x: 100, y: 100]: 2 of 391 pixels (0%) are animated <-- is there a setting/flag "i MEANT this to be animated"? 19:44:05 <TrueBrain> LordAro: okay, I did it for you :P (news post) :D 19:44:13 <peter1138> SimYouLater, yes, we do need specifics. 19:44:17 <planetmaker> Eddi|zuHause, there is exactly one change in the newest NML: that is the production callback. Use the 2nd latest revision 19:44:26 <peter1138> SimYouLater, I'm not interested in other GRFs. 19:44:38 <planetmaker> and yes, we do not need it 19:45:17 <Eddi|zuHause> planetmaker: i'm fine. i can use "../../../../nml-hg/nmlc ris.nml" 19:45:24 <Eddi|zuHause> *headdesk* 19:46:50 <DorpsGek_II> [OpenTTD/website] TrueBrain updated pull request #69: Create 2019-03-24-1.9.0-RC2.md https://git.io/fjJHI 19:47:19 <SimYouLater> I know you're not interested in other NewGRFs! I'm trying to explain that all I did was take the code from existing NewGRFs and modify them to be a single NewGRF, and that if you want a list of vehicles then my only reference is to look at what the GRFs I took code from because I don't have a list or spreadsheet to give you! 19:47:22 <planetmaker> yes, good that you know better 19:47:24 <Eddi|zuHause> very descriptive title. you wanted to out-describe me? :p 19:47:48 <peter1138> SimYouLater, okay. Then do that :-) 19:48:17 <SimYouLater> Thank you. I'll be back in an hour, sorry for yelling. 19:48:43 <planetmaker> TrueBrain, wait with push. titlegame competition 19:49:07 <TrueBrain> planetmaker: feel free to edit the branch; and good idea :) 19:49:19 <TrueBrain> As in, feel free to edit via https://github.com/OpenTTD/website/edit/new-news-post/_posts/2019-03-24-1.9.0-RC2.md?pr=%2FOpenTTD%2Fwebsite%2Fpull%2F69 19:49:44 <Samu> I notice ppl are still afraid of making ships 19:49:49 <Samu> servers 20:01:57 <LordAro> Samu: i imagine it's less "afraid" and more "they're slow and boring" 20:06:00 *** andythenorth has joined #openttd 20:06:19 <TrueBrain> its an andythenorth! 20:07:09 <andythenorth> meh 20:08:04 <andythenorth> I have been to hospital to see if I have a kidney infection (seems not) 20:08:15 <TrueBrain> you sound disapointed? 20:08:17 <andythenorth> now I come home and the water is off, water main outside my house burst 20:08:24 <andythenorth> mega lolz 20:08:25 <Supercheese> Oh no 20:08:27 <TrueBrain> ugh :( 20:08:49 <LordAro> andythenorth: :( 20:08:59 <andythenorth> first world problem tbh 20:08:59 <Eddi|zuHause> so now you have to touch your apocalypse/brexit stockpile of water? 20:09:11 <TrueBrain> well, water is not a first world thingy :D 20:09:17 <andythenorth> Eddi|zuHause: apparently stockpiling is unpatriotic, so I haven't 20:09:18 <TrueBrain> brexit stockpile :D 20:09:32 <andythenorth> you joke 20:09:35 <Supercheese> >stockpiling is unpatriotic 20:09:37 <Supercheese> whaaaat 20:10:04 <andythenorth> don't even 20:10:54 <andythenorth> so does anyone know about newgrf yet? 20:11:04 <TrueBrain> still a back unknown to me :( 20:11:11 <Eddi|zuHause> andythenorth: i made a PR 20:12:14 <andythenorth> you did :) 20:12:24 <andythenorth> so we continue maintaining this spec then 20:12:39 <Eddi|zuHause> we commited it to master, there's no going back. 20:12:54 <TrueBrain> what he is saying: WE ARE DOOMED 20:12:57 <TrueBrain> RUN! TO THE SHELTERS 20:13:01 <TrueBrain> (without your brexit water) 20:14:29 <DorpsGek_II> [OpenTTD/OpenTTD] stormcone commented on pull request #7270: Introduce CMake (and removing all other project-related code) https://git.io/fjJHz 20:18:49 <andythenorth> sometimes I think some vision would be helpful :P 20:18:55 <andythenorth> maybe not realistic 20:18:57 <andythenorth> or wanted 20:18:58 <andythenorth> but helpful 20:19:16 <DorpsGek_II> [OpenTTD/website] planetmaker updated pull request #69: Add: OpenTTD 1.9.0-RC2 news post https://git.io/fjJHI 20:19:42 <TrueBrain> planetmaker: please use newlines after dots when creating markdown files :) 20:19:53 <Eddi|zuHause> i said that last time... 20:19:59 <DorpsGek_II> [OpenTTD/website] TrueBrain updated pull request #69: Add: OpenTTD 1.9.0-RC2 news post https://git.io/fjJHI 20:20:07 <planetmaker> thx 20:20:12 <TrueBrain> I say it many times; it will stick with people sooner or later :D 20:20:29 <planetmaker> ^^ 20:21:31 <andythenorth> it bothers me that we're adding vars so I can do something in FIRS, which is already completely achievable without spec change 20:21:36 <Eddi|zuHause> there's always more people who never heard it... 20:21:37 <andythenorth> otoh, RL is messy 20:21:46 <DorpsGek_II> [OpenTTD/website] TrueBrain updated pull request #69: Add: OpenTTD 1.9.0-RC2 news post https://git.io/fjJHI 20:21:55 <Eddi|zuHause> and other people who never learn it 20:22:01 <Eddi|zuHause> like, making spaces around operators 20:22:15 <Eddi|zuHause> or reformed orthography 20:22:44 <TrueBrain> can anyone approve the website news message? :D 20:24:28 <Eddi|zuHause> not me 20:24:33 <TrueBrain> why not? 20:24:37 <TrueBrain> scared? :P 20:24:40 *** Gumle2 has joined #openttd 20:24:41 <DorpsGek_II> [OpenTTD/website] PeterN approved pull request #69: Add: OpenTTD 1.9.0-RC2 news post https://git.io/fjJHo 20:24:43 <Eddi|zuHause> i don't have approval rights 20:24:46 <TrueBrain> Eddi|zuHause: you should? 20:24:48 <TrueBrain> tnx peter1138 :) 20:24:50 <Eddi|zuHause> well, i didn't last time i tried 20:25:05 <TrueBrain> I gave you edit rights, not? Should also give you approval rights 20:25:14 <Eddi|zuHause> ah yes, i have approve rights, but not merge rights 20:25:15 <Eddi|zuHause> that was it 20:25:25 <TrueBrain> :) 20:25:39 <peter1138> andythenorth, how is it achievable without a spec addition? 20:25:50 <Eddi|zuHause> definitely don't give me those :p 20:25:54 <DorpsGek_II> [OpenTTD/website] TrueBrain merged pull request #69: Add: OpenTTD 1.9.0-RC2 news post https://git.io/fjJHI 20:26:11 <andythenorth> peter1138: just use prod cb 20:26:33 <DorpsGek_II> [OpenTTD/OpenTTD] PeterN commented on pull request #7396: Fix: Saving SDT_INTLIST handle unsigned values properly https://git.io/fjJHK 20:26:50 <peter1138> andythenorth, I'm not familiar enough with it to know what that means. 20:26:53 <andythenorth> if newgrf controls production directly, no need to read openttd internals 20:27:12 <andythenorth> industry spec is a classic of too many ways to do things 20:27:16 <andythenorth> like vehicle refitting 20:27:24 <andythenorth> it's probably all fine 20:27:31 <andythenorth> just a faff to maintain, extend, document 20:28:19 <DorpsGek_II> [OpenTTD/OpenTTD] Eddi-z commented on pull request #7396: Fix: Saving SDT_INTLIST handle unsigned values properly https://git.io/fjJH6 20:31:11 <TrueBrain> planetmaker: you used the wrong URL for the titlegame ... :P 20:31:16 <TrueBrain> you might want to symlink that now :D 20:31:37 <andythenorth> did anyone respond to the nml documentation post? 20:31:39 * andythenorth looks 20:31:48 <andythenorth> nope 20:32:05 <TrueBrain> did I went to the bathroom already? 20:32:06 * TrueBrain checks 20:32:08 <TrueBrain> nope 20:32:15 <andythenorth> are you sure? 20:32:19 <andythenorth> check your trousers 20:32:46 <TrueBrain> planetmaker: always check your links before hitting commit :D (well, and I should have checked before merging, ofc :P) 20:33:17 <planetmaker> damn. I spellt the URL wrongly :P 20:33:25 <planetmaker> I just noticed 20:33:29 <DorpsGek_II> [OpenTTD/website] TrueBrain opened pull request #70: Fix: wrong link in 1.9.0-RC2 news post https://git.io/fjJHX 20:33:44 <TrueBrain> I should have waited for the staging version, before I promoted it to production .. I was lazy :P 20:33:56 <peter1138> Which idiot approved that? 20:34:15 <TrueBrain> the one that quiclly approves the fix? :D 20:34:18 <Eddi|zuHause> only idiots here... 20:34:26 <andythenorth> somone I wouldn't trust to go to the bathroom unsupervised 20:34:27 <Eddi|zuHause> and samu. 20:34:36 <DorpsGek_II> [OpenTTD/website] PeterN approved pull request #70: Fix: wrong link in 1.9.0-RC2 news post https://git.io/fjJH1 20:34:40 <TrueBrain> tnx peter1138 :) 20:34:46 <peter1138> I checked the link ;) 20:35:15 <planetmaker> andythenorth, not sure the nml doc posting is exactly encouraging. But... lack of constructive feedback, so I should not criticise 20:35:55 <peter1138> Saying it's unmaintained, when clearly it is being maintained, is a bit weird. 20:36:19 <planetmaker> I think it's sending some wrong signals in that regards, yes. 20:36:25 <planetmaker> Though it's definitely not well-maintained 20:36:39 <Eddi|zuHause> that's just andy being overly dramatic once again? 20:36:41 <peter1138> Not yet. 20:36:58 <peter1138> But it got moved to github and there's been PRs and merges. 20:37:00 <DorpsGek_II> [OpenTTD/website] TrueBrain merged pull request #70: Fix: wrong link in 1.9.0-RC2 news post https://git.io/fjJHX 20:38:47 <TrueBrain> I believe we published 9 dockers on Docker Hub today for the website :P 20:38:50 <peter1138> Any opinions on the station catchment stuff? 20:38:56 <TrueBrain> LALALALALAAAA .. no retention is their fault, not mine :D 20:39:51 <peter1138> http://fuzzle.org/~petern/ottd/catchment4.png < When placing a station, if it touches an existing station it will highlight the full catchment area. 20:40:13 <TrueBrain> hmm .. tomorrow I am flying to the UK again .. one thing that is always weird: you don't need to show your passport when leaving the UK .. like: WE ARE HAPPY YOU ARE GONE, kind of way .. 20:40:24 <andythenorth> 'unmaintained' was my improvement on 'unsupported' in my original post, I deleted that cos it's clearly daft 20:40:33 <andythenorth> nml is supported, it's just in bad shape 20:40:34 <Eddi|zuHause> peter1138: is that what you intend to happen? 20:40:40 <andythenorth> TrueBrain such UK 20:40:55 <andythenorth> will the prime minister change between you arriving and leaving? o_O 20:41:02 <TrueBrain> possible 20:41:02 <peter1138> Eddi|zuHause, yes. It's not an accident at least :p 20:41:05 <TrueBrain> in fact, likely 20:41:12 <TrueBrain> people called me crazy I was going to the UK this week :D 20:41:16 <Eddi|zuHause> peter1138: i think it's a good idea to highlight the coverage area of the resulting station 20:41:28 <peter1138> Eddi|zuHause, that's... what it does. 20:41:37 <Eddi|zuHause> peter1138: possibly also do something with the "merge to other station" window (ctrl+click) 20:41:49 <peter1138> Eddi|zuHause, it's difficult to see in the screenshot because the cursor is hiddeN :p 20:42:04 <TrueBrain> ticket prices were insane btw .. like .. 30% higher than normal 20:42:09 <peter1138> The cursor is on the white highlighted tile with just grass in it. 20:42:09 <TrueBrain> like everyone wanted to leave the country :D 20:42:26 <Eddi|zuHause> peter1138: that's what i guessed \o/ 20:42:38 <peter1138> Until the cursor is adjacent to a station, it just shows as normal. 20:42:47 <andythenorth> TrueBrain: some Brits are having holidays in Europe before we can't, or something 20:42:56 <Eddi|zuHause> yeah, i'd say that is good behaviour 20:43:06 <TrueBrain> andythenorth: afraid they are not let back in, or something :P 20:43:06 <peter1138> For distant join, i'm thinking of doing the with mouse hovering. 20:43:23 <peter1138> when the cursor hovers over a station in the list, highlight it (and the new tile) 20:43:42 <Eddi|zuHause> that might work 20:44:41 <peter1138> That just leaves the issue of showing catchment when *not* building stations :) 20:45:41 <peter1138> Which is easy for individual stations actually. 20:47:24 <peter1138> I'm rubbish at playing this game. I'm too happy to just watch towns expand, and then it's too late to connect them up :p 20:48:37 <Eddi|zuHause> i'm even worse, the game is paused 95% of the time 20:49:06 <Eddi|zuHause> i have this problem with many games 20:49:32 <Eddi|zuHause> like in EU4 it took me like 8 months to finish a game, where in the meantime 2 expansions came out that made the game incompatible to load 20:49:48 <planetmaker> I build a bit to be out of money-trouble. And then it's just watching things move and change :D 20:50:27 <peter1138> I'm currently playing newgrf-less games too. 20:50:40 <peter1138> So the funky buy & refit I wrote is a bit redundant. 20:50:46 <peter1138> No ships on this map, not enough water. 20:51:36 <andythenorth> shall we allow demolishing town for stations? 20:51:41 <andythenorth> might be worth exploring 20:51:42 <Eddi|zuHause> peter1138: that's the problem when you write features for a target audience of 1 :p 20:51:56 <andythenorth> Eddi|zuHause there's another audience size? :o 20:52:03 <peter1138> Pretty sure the audience for that is much larger. 20:52:10 <peter1138> I know there were existing patches, and JGR has it. 20:52:12 <andythenorth> it's kind of a tedious limitation, the towns 20:52:21 <peter1138> (Just, not my implementation) 20:52:28 <Eddi|zuHause> goes it throw out limitation? 20:52:52 <peter1138> Hmm, oops, accidentally built an airport. 20:53:07 <Eddi|zuHause> non-rotatable one? 20:53:30 <peter1138> I was pressing shift, but apparently that doesn't count when the window didn't have focus initially. 20:53:39 <peter1138> (Maybe because it's in VNC as well. 20:53:40 <peter1138> ) 20:54:12 <Eddi|zuHause> that sounds like a few too many layers for things to go wrong/missing 20:57:01 *** circ-user-3HYVs has joined #openttd 21:02:56 *** Alberth has left #openttd 21:03:57 *** gelignite has quit IRC 21:05:21 <planetmaker> is it sensible to have a patch which allows to choose a different titlegame via cmd line switch? 21:06:32 <TrueBrain> who would be the intended user? 21:06:47 <planetmaker> intended target audience size: ~1 21:06:52 <planetmaker> :P 21:07:06 <TrueBrain> so can that person make a small shell script to exchange title games? 21:07:15 <glx> too bad there's no option to build installer via cmake in VS open folder mode 21:07:30 <glx> I can install but not generate an installer 21:07:32 <TrueBrain> glx: I noticed indeed. Only 'install'. Guess that makes somewhat sense 21:07:41 <TrueBrain> you can via ninja 21:08:01 <glx> and I have to add install* to ignore :) 21:08:33 <TrueBrain> still have to figure out how to do versions for CPack 21:08:38 <planetmaker> TrueBrain, it anyway needs hacks to quickly create the screenshots I posted... cannot be done completely without 21:08:39 <TrueBrain> not completely trivial .. 21:08:56 <TrueBrain> planetmaker: so there you have your answer :D 21:09:05 <planetmaker> so... not exchanging titlegame, but load option. Yet with additional hacks :P 21:09:05 <TrueBrain> the 1.9.0 on the screenshots was kinda a give-away :P 21:09:15 <planetmaker> hehe 21:09:18 *** Wormnest has joined #openttd 21:09:27 <TrueBrain> anyway, off for now; back in a few days :) 21:09:37 <planetmaker> you need means to start and immediately terminate after screenshot 21:09:50 <planetmaker> enjoy and safe travel 21:13:03 *** Gumle2 has quit IRC 21:13:50 *** supermop_Home has joined #openttd 21:15:30 *** Supercheese has quit IRC 21:15:51 *** Supercheese has joined #openttd 21:15:57 *** frosch123 has quit IRC 21:17:21 *** Wormnest has quit IRC 21:26:59 <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry updated pull request #7407: Codechange: Use null pointer literal instead of the NULL macro https://git.io/fjJDX 21:30:14 <DorpsGek_II> [OpenTTD/OpenTTD] M3Henry updated pull request #7165: [core] Implement SmallVector using std::vector https://git.io/fhSz0 21:30:50 <planetmaker> how do I delete a branch from my git repo? 21:31:13 <m3henry> git branch -d <branch> 21:31:46 <m3henry> If deleting the branch would cause commits to be lost, and you are sure you want to do that, use -D 21:32:26 <peter1138> But they're not really lost, unless you gc it. 21:32:32 <m3henry> (they will still be available in the reflog if you do that but don't mean to) 21:33:39 <planetmaker> thanks :) 21:35:12 <m3henry> deleting a remote branch requires `git push <remote_name> --delete <branch_name>` 21:35:29 <m3henry> Woo inconsistent command syntax! 21:35:40 <planetmaker> I'm not surprised by the latter :P 21:36:14 <planetmaker> hence I'm asking... 21:42:12 <LordAro> this is why i just delete via github ui :p 21:42:42 <peter1138> git push <remote> :<branch> 21:44:12 <andythenorth> should we unpin this? https://www.tt-forums.net/viewtopic.php?f=32&t=30877 21:44:13 <andythenorth> :P 21:44:52 <andythenorth> it is at top of Suggestions forum 21:44:55 <andythenorth> and contains only dead links 21:47:25 <SimYouLater> Okay, I'm back. 21:48:43 <SimYouLater> Let's start with something simple. I'm trying to make three decorative tracktypes: DIRT (Wired Planning), TBED (Useless Tracks Trackbed) and PLAN (Useless Tracks Planning) 21:49:04 <SimYouLater> As of this moment, only TBED and PLAN sow up in the list of railtypes 21:50:02 <peter1138> Is this in RIS? 21:50:13 <SimYouLater> Yes. 21:50:51 <peter1138> None of those types appear. 21:50:59 <Eddi|zuHause> there's three things that make a railtype available: 1) a vehicle is available for that railtype, 2) an introduction date was set and passed, or 3) a railtype has set another as "make this available as well" 21:51:54 <peter1138> "Lifted Track Construction", "Track Planning" appear 21:52:55 <peter1138> Hmm, label "DIRT" is "Dirt path" not "Wired Planning" 21:53:10 <peter1138> TBED doesn't appear in RIS at all 21:53:12 <SimYouLater> Try messing with the parameters. In fact, I found out I accidentally had the parameter for DIRT set to off. Whoops! Thanks anyway. 21:55:05 <SimYouLater> Huh. Somehow all the problems are fixed, I must have screwed up trying to test stuff and thought things didn't work when they actually did! 21:55:22 <SimYouLater> Thanks for puting up with me, everyone! 21:55:24 <DorpsGek_II> [OpenTTD/OpenTTD] stormcone opened issue #7410: Signs made by AIs do not show up at the creation time https://git.io/fjJQr 21:56:50 <peter1138> Hmm, when distant-joining a station the highlight for what you're going to build disappears :/ 21:57:04 <peter1138> Well, still follows the mouse, despite being fixed. 21:57:35 <andythenorth> hmm 21:57:38 * andythenorth needs Eddi|zuHause 21:58:31 <Eddi|zuHause> if only there were more of those around 21:58:45 <andythenorth> one is the right amount 21:58:54 <andythenorth> more or less would be unwanted 21:59:12 <Eddi|zuHause> anything in particular? 21:59:23 <andythenorth> I want industries to run a random chance of something once every 12 months 21:59:38 <andythenorth> and I'd like the spread of that to be reasonably distributed across industries and months 21:59:45 <andythenorth> doesn't have to be perfect 22:00:04 *** SimYouLater has quit IRC 22:00:09 <andythenorth> there is the random prod. change cb, but I don't know if it work 22:00:10 <andythenorth> works * 22:00:20 <Eddi|zuHause> so once per tileloop, run a "1 in x" chance where x depends on the number of industries? 22:01:07 <andythenorth> and if random is working as expected, over a large data set that will distribute? 22:01:08 <Eddi|zuHause> is the production change callback run for every industry, or does it randomly pick one? 22:01:15 <andythenorth> code knows 22:01:18 <andythenorth> code is meh 22:01:34 <andythenorth> I believe it depends on economy setting also 22:01:41 <Eddi|zuHause> not quite in the mood for code, with the internet ending next week and stuff 22:02:17 <Eddi|zuHause> while you're off playing with your brexit, other people have real problems 22:02:54 <andythenorth> article 13 or something? 22:03:08 <Eddi|zuHause> yes, that 22:04:17 <andythenorth> the internet is over anyway 22:04:24 <andythenorth> most of it is now more awful than in 2001 22:04:33 <andythenorth> avg screen: 35% cookie warning 22:04:45 <andythenorth> 45% scam ads 22:04:58 <andythenorth> 20% listicle copied from buzzfeed 22:05:04 <Eddi|zuHause> ... i took care of the 45% 22:05:19 <andythenorth> I never did do ad-block 22:05:25 <andythenorth> I somehow think it makes it all even worse 22:05:35 <Eddi|zuHause> i highly recommend it... 22:05:47 <milek7> don't forget about modal GDPR popup 22:06:23 <Eddi|zuHause> i hope they make some browser-wide cookie policy thing at some point 22:06:54 * andythenorth wonders 22:07:09 <andythenorth> is there any reason industry newgrf can't have global off-map storage? 22:07:19 <andythenorth> and a cb on specific events ? 22:07:31 <andythenorth> I know that's supposed to be GS, but let's not pretend that has worked out well 22:07:33 <milek7> Eddi|zuHause: P3P? 22:07:43 <milek7> https://en.wikipedia.org/wiki/P3P 22:08:19 <Eddi|zuHause> there seems to be a conflict to store my refusal to allow cookies, without storing a cookie 22:08:36 <andythenorth> it is challenging yes 22:09:39 <Eddi|zuHause> i spend most of my time in private browsing mode nowadays, which automatically discards cookies when i close the browser 22:10:24 <Eddi|zuHause> there's a usability issue with firefox, that all private browsing windows share one cookie database 22:10:31 <Eddi|zuHause> so you must close all windows for it to reset 22:10:55 <Eddi|zuHause> which conflicts with long-running settings like long videos that i watch on-and-off for days sometimes 22:11:17 <andythenorth> peter1138: some kind of newgrf storage, off-map? 22:11:18 <andythenorth> o_O 22:11:36 *** Progman has quit IRC 22:12:56 <Eddi|zuHause> i thought that exists? 22:18:28 <andythenorth> there was an idea around town storage 22:18:41 <andythenorth> it kind of lapsed, in favour of GS 22:18:41 <Eddi|zuHause> but why would you need storage? 22:18:50 <andythenorth> the only time I've seen pikka rage quite here was over that 22:18:55 <andythenorth> quit * 22:19:37 <peter1138> Who what? 22:20:47 <andythenorth> 'need' is a strong word for anything to do with newgrf 22:21:23 <peter1138> Sometimes you just, er, need... to explain what you want to achieve. 22:21:30 <peter1138> Instead of just asking random things. 22:21:55 <peter1138> And referencing conversations that are long gone which nobody else saw. 22:22:05 <andythenorth> well yes 22:22:06 <andythenorth> quite 22:25:06 <peter1138> Ok, I might ditch my current game for something with NewGRFs. 22:25:09 <peter1138> Maybe dbsetxl :) 22:25:20 <peter1138> 14 years old? 22:26:15 *** synchris has quit IRC 22:35:01 <andythenorth> hmm no 22:35:24 * andythenorth just escalated an idea about newgrf being able to read individual industry instance storages 22:35:35 <andythenorth> or individual instances writing to a global storage 22:35:45 <andythenorth> electricity and all kinds of silly ideas 22:35:46 <andythenorth> nope 22:36:38 <andythenorth> but how should industry closure work? 22:36:42 <Eddi|zuHause> peter1138: i'm still hopeful for 18.18.18 22:36:54 <andythenorth> currently industry closure....sucks 22:37:30 <andythenorth> or should it just be disabled? 22:37:55 <Eddi|zuHause> there should definitely be an option to disable it 22:38:03 <peter1138> What sucks about it? 22:38:10 <Eddi|zuHause> but some people will want it 22:38:17 <Eddi|zuHause> hence option 22:38:22 <andythenorth> what does suck about it? 22:38:29 <andythenorth> I can't remember, I disabled it years ago 22:38:48 <andythenorth> but now the FIRS code that disables is is broken 22:38:56 <andythenorth> should I restore it? 22:39:00 <peter1138> Industries never closing is boring. 22:39:21 <Eddi|zuHause> i always had an issue with how ECS closed industries with the protection period 22:39:21 <andythenorth> maybe I should just delete the FIRS closure code 22:39:36 <m3henry> I find the problem is player feedback 22:39:43 <Eddi|zuHause> because 5 years after game start, every region you expand into is devoid of industries 22:39:47 <andythenorth> what economy setting do people use? 22:40:02 <andythenorth> default, or smooth? 22:40:14 <andythenorth> mine seems to be smooth, not sure why, Frosch told me it's broken 22:40:19 <andythenorth> I should try the other one 22:40:22 <m3henry> On a large map, the volume of industry messages means it's hard to notice when that industry you're connecting to is about to close 22:40:34 <Eddi|zuHause> industries will mostly override smooth economy 22:40:40 <Eddi|zuHause> so you should not see a difference 22:40:57 <andythenorth> does anyone know what it does? 22:41:14 <m3henry> Perhaps industries should have alternate graphics which indicates that the industry is likely to close soon 22:41:29 <Eddi|zuHause> it makes the random production changes be something other than half/double 22:42:01 <Eddi|zuHause> but any industry using production callback will ignore that 22:42:23 <andythenorth> reddit thinks smooth economy is broken https://www.reddit.com/r/openttd/comments/5h691s/smooth_economy_and_industry_issues/dazjlln/ 22:42:26 <andythenorth> https://www.reddit.com/r/openttd/comments/5h691s/smooth_economy_and_industry_issues/ 22:42:42 <andythenorth> did TTD have recessions, or did I imagine that? 22:42:49 <peter1138> Reddit tends to think a lot of wrong things. 22:42:58 <peter1138> Like "path signals are bad" 22:42:59 <Eddi|zuHause> TTD had recessions 22:43:28 <andythenorth> does OpenTTD have recessions? 22:43:42 <andythenorth> that's the kind of thing that global newgrf storage is needed for 22:43:44 <_dp_> yeah, an option to stop industry closure would be nice 22:43:48 <Eddi|zuHause> might depend on settings 22:43:53 <_dp_> otherwise servers just die out after a while 22:43:57 <andythenorth> industry closure should be handled in newgrf 22:44:05 <andythenorth> game changes should be in content 22:44:33 <peter1138> Industry closure should be balanced out by new industries. 22:44:40 <andythenorth> it kind of is 22:44:42 <andythenorth> iirc 22:44:47 <andythenorth> there was an idea that global things should be GS, but eh 22:44:52 <_dp_> it's already handled in newgrfs and I'm already not using it :p 22:44:55 <Eddi|zuHause> there was an economy rewrite a few years ago 22:45:05 <andythenorth> _dp_: I can help you with that then: add newgrfs :P 22:45:06 <_dp_> coz it's stupid to use newgrfs just to stop industries 22:45:08 <Eddi|zuHause> which handles the amount of industries that should be present on the map 22:45:10 <andythenorth> we discussed this before? 22:45:41 <andythenorth> it's stupid to have a policy to modify the game via content, then add more settings :) 22:45:44 <andythenorth> but eh 22:46:45 * andythenorth tries to figure out what recession does in openttd 22:47:05 <andythenorth> seems to stop industries being constructed 22:47:26 <andythenorth> and cut cargo output by 50%? 22:47:50 <andythenorth> sometimes I wonder why I don't know about all these OpenTTD features :P 22:48:27 <Eddi|zuHause> it depended on an original difficulty setting 22:48:55 <Eddi|zuHause> no idea where that went 22:49:31 <andythenorth> might be missing from smooth economy 22:49:38 <andythenorth> and probably not applied to newgrf 22:49:49 <andythenorth> seems to be L528 in industry_cmd.cpp 22:54:23 <peter1138> "Hard to answer that - I suspect that the RNG of OpenTTD is broken." 22:54:30 <peter1138> See how Reddit often wrong? :p 22:54:35 <andythenorth> RNGesus 23:00:57 * andythenorth wondering about some kind of industry 'health' thing 23:01:11 <andythenorth> which would nerf/boost production under certain conditions 23:01:18 <andythenorth> (in newgrf) 23:01:42 <andythenorth> FIRS has various cargo boosts 23:02:13 <andythenorth> this idea is more indirect stuff like 'worker shortage: grow nearby town' 23:02:31 <andythenorth> or 'power shortage: deliver coal to nearby power station' 23:02:57 <andythenorth> I can probably access town popn now 23:04:48 <andythenorth> 25% of industries would just be healthy 23:05:23 <andythenorth> then there would be 3 conditions which would each apply to ~25% of industries 23:05:49 <andythenorth> can I do that in current spec? maybe 23:06:04 <Eddi|zuHause> people are quick to blame things on RNGesus 23:06:46 <andythenorth> it's because of games like Blitz 23:06:50 <andythenorth> where RNG is horrible 23:07:11 *** m3henry has quit IRC 23:07:21 <Eddi|zuHause> RNG is great, if you can control it. that's how casinos earn money 23:07:37 <andythenorth> most Blitz-style games are casinos :P 23:07:40 <andythenorth> why should an industry close? 23:07:50 <andythenorth> bad RNG roll? 23:08:00 <andythenorth> low transported cargo? 23:08:06 <andythenorth> low delivered cargo? 23:08:11 <andythenorth> disaster? 23:08:18 <andythenorth> recession? 23:08:34 <Eddi|zuHause> the main problem with industry closure is player agency. the message comes out of the blue, and then there's nothing the player can do about it 23:08:44 <Eddi|zuHause> and that is not fixable by NewGRF 23:08:49 <andythenorth> they also come in waves after 5 years 23:09:00 <andythenorth> it's pretty hideous 23:09:21 <_dp_> hm, it's supposed to have 4.5% chance for 3-23% but for low production rates it's does much less coz it rounds down to an integer... 23:09:42 <Eddi|zuHause> it should be more like "industry X will close in 1 year, if service is not improved" 23:09:44 * andythenorth wonders if smooth economy loop visits industries too often 23:10:18 <andythenorth> Eddi|zuHause: that part is fixable by newgrf 23:10:18 <Eddi|zuHause> smooth economy should not change the loop 23:10:33 <andythenorth> I haven't read it 23:10:46 <andythenorth> I just know frosch hates it, and thinks it's broken 23:11:25 <andythenorth> anyway, we can mark up industry to close in 12 months 23:11:28 <andythenorth> and show a message 23:11:55 <andythenorth> but there's no way to show 'at risk' or something in industry list 23:12:08 <Eddi|zuHause> there's also ECS which puts ridiculously high ratings as requirements 23:12:15 <supermop_Home> andythenorth no small freight electrics in 90s? 23:12:22 <andythenorth> supermop_Home: shoeboxes 23:12:27 <supermop_Home> too fast 23:12:29 <andythenorth> small as you get 23:12:42 <supermop_Home> I want an electric little bear 23:12:45 <andythenorth> regeraring? o_O 23:12:48 <supermop_Home> not very british I guess 23:13:08 <supermop_Home> but my Martinique map quite hilly 23:13:14 <supermop_Home> need swiss horse 23:13:32 <andythenorth> you need swiss horse 23:13:39 <andythenorth> or just use the fast train 23:13:47 <andythenorth> cost is marginal 23:13:59 *** Wormnest has joined #openttd 23:14:22 <supermop_Home> early days so money tight 23:14:28 <andythenorth> hmm, 2.5x more expensive to buy 23:14:47 <supermop_Home> guess I shouldn't have wired up this little copper line 23:15:01 <andythenorth> use a mail EMU 23:15:17 <andythenorth> https://en.wikipedia.org/wiki/British_Rail_Class_419 23:15:24 <supermop_Home> i am considering it 23:16:29 <supermop_Home> super shoebox is k and 1100 hp ish, Hercules is .5k and 1300 hp 23:16:48 <andythenorth> Eddi|zuHause: so what's a good reason to close industry? Station rating? 23:16:48 <andythenorth> Transported cargo? 23:16:48 <andythenorth> good old hercules 23:17:09 <supermop_Home> copper & steel 23:17:14 <Eddi|zuHause> it might be, but in the ECS implementation it's too strict 23:17:17 <supermop_Home> about 4-6 cars 23:17:30 <Eddi|zuHause> give people options to make it less strict 23:18:15 <andythenorth> should there be a single closure mechanic? 23:18:41 <andythenorth> or does the idea of specific reason per industry instance work? 23:19:35 <Eddi|zuHause> there should probably be a distinction between primary and secondary 23:19:39 * andythenorth wary of complications 23:21:48 <andythenorth> well 23:21:58 <andythenorth> that is something to consider in my sleep :P 23:21:59 *** andythenorth has left #openttd 23:22:14 *** Wormnest_ has joined #openttd 23:25:17 *** Wormnest has quit IRC 23:30:43 <Samu> I got conflicts to solve 23:30:45 <Samu> ok let's solve 23:30:51 <peter1138> I think everyone does. 23:32:03 <peter1138> Oops 23:34:33 <Samu> void SetStringParameters(int widget) const override 23:34:38 <Samu> override? this is new 23:35:08 <peter1138> http://fuzzle.org/~petern/ottd/docks15.png < I thin that lock tile might be wrong... 23:37:07 <peter1138> Red highlight is a docking tile. 23:37:26 <peter1138> On the other hand, I'm minded to not care. 23:40:44 <_dp_> ffs, that reddit post is 2 years old 23:40:59 <_dp_> why did andy even dig up that fossil :/ 23:41:01 <peter1138> :-) 23:41:18 <_dp_> well, now I know much more about industry production than I'd probably even need xD 23:42:08 <_dp_> and, yeah, wiki is kinda wrong :p 23:42:27 <peter1138> Usually. 23:43:00 <peter1138> But should I care about the docking tile at the top of the dock? 23:43:32 <_dp_> industry with 80 unit production only gets 8.5% avg change instead of 13 (3-23) 23:45:19 <Samu> aha, this one was added by me /* virtual */ void OnInvalidateData(int data = 0, bool gui_scope = true) 23:45:25 <_dp_> and after 20 years there is only about 67% chance that it will increase production 23:45:31 <Samu> now its void bla bla override 23:45:50 <_dp_> with average production change of +40% (including decreasing ones) 23:46:54 <_dp_> make 23:47:00 <_dp_> ops, sorry) 23:49:53 <Samu> oh, and the ifdef network stuff is also removed now 23:51:24 <peter1138> That's been removed for a while... 23:54:37 <DorpsGek_II> [OpenTTD/OpenTTD] SamuXarick updated pull request #7084: Change: AI/GS Config GUI overhaul https://git.io/fh2dV 23:55:16 <Samu> only had to change one line 23:55:29 <Samu> the rest was auto-merged or whatever by visual studio 23:55:34 <Samu> autofixed